blob: b60ab953e977762b1066cdc293878ae422a0d56d [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "media/engine/webrtc_video_engine.h"
12
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000013#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080014#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020015#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070016#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000017#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000018
Steve Anton2c9ebef2019-01-28 17:27:58 -080019#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010020#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020021#include "absl/strings/match.h"
Danil Chapovalov83bbe912019-08-07 12:24:53 +020022#include "api/rtc_event_log/rtc_event_log.h"
Steve Anton10542f22019-01-11 09:11:00 -080023#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020024#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070025#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/test/mock_video_bitrate_allocator.h"
27#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070028#include "api/test/mock_video_decoder_factory.h"
29#include "api/test/mock_video_encoder_factory.h"
Niels Möller65f17ca2019-09-12 13:59:36 +020030#include "api/transport/media/media_transport_config.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020031#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080032#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010033#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020034#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020035#include "api/video_codecs/builtin_video_decoder_factory.h"
36#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "api/video_codecs/sdp_video_format.h"
38#include "api/video_codecs/video_decoder_factory.h"
39#include "api/video_codecs/video_encoder.h"
40#include "api/video_codecs/video_encoder_factory.h"
41#include "call/flexfec_receive_stream.h"
42#include "common_video/h264/profile_level_id.h"
Niels Möller805a27e2019-01-21 12:21:27 +010043#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/base/fake_video_renderer.h"
46#include "media/base/media_constants.h"
47#include "media/base/rtp_utils.h"
48#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/fake_webrtc_call.h"
51#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "media/engine/webrtc_voice_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020054#include "rtc_base/arraysize.h"
Elad Alon80f53b72019-10-11 16:19:43 +020055#include "rtc_base/experiments/min_video_bitrate_experiment.h"
Steve Anton10542f22019-01-11 09:11:00 -080056#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020058#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080059#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010061#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020062#include "test/gmock.h"
Tommi25eb47c2019-08-29 16:39:05 +020063#include "test/rtp_header_parser.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000064
philipeld9cc8c02019-09-16 14:53:40 +020065using ::testing::Contains;
66using ::testing::Eq;
Mirko Bonadei6a489f22019-04-09 15:11:12 +020067using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020068using ::testing::IsEmpty;
philipeld9cc8c02019-09-16 14:53:40 +020069using ::testing::Pair;
Chen Xing90f3b892019-06-25 10:16:14 +020070using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010071using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070072using webrtc::RtpExtension;
73
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000074namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000075static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000076
noahricd10a68e2015-07-10 11:27:55 -070077static const uint8_t kRedRtxPayloadType = 125;
78
Niels Möller6557d0c2018-04-11 15:18:34 +020079static const uint32_t kTimeout = 5000U;
80static const uint32_t kDefaultReceiveSsrc = 0;
81static const uint32_t kSsrc = 1234u;
82static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
83static const int kVideoWidth = 640;
84static const int kVideoHeight = 360;
85static const int kFramerate = 30;
86
Peter Boström0c4e06b2015-10-07 12:23:21 +020087static const uint32_t kSsrcs1[] = {1};
88static const uint32_t kSsrcs3[] = {1, 2, 3};
89static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080090static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020091static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080092static const uint32_t kDefaultRecvSsrc = 0;
93
Bjorn A Mellemda4f0932019-07-30 08:34:03 -070094constexpr uint32_t kRtpHeaderSize = 12;
95
pbos@webrtc.org3c107582014-07-20 15:27:35 +000096static const char kUnsupportedExtensionName[] =
97 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000098
magjed509e4fe2016-11-18 01:34:11 -080099cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
100 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +0200101 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -0800102}
103
Elad Alonfadb1812019-05-24 13:40:02 +0200104void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
105 bool lntf_expected) {
106 EXPECT_EQ(lntf_expected,
107 codec.HasFeedbackParam(cricket::FeedbackParam(
108 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
110 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
111 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
112 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
113 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
114 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
115 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800116 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
117 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000118 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
119}
120
magjed725e4842016-11-16 00:48:13 -0800121// Return true if any codec in |codecs| is an RTX codec with associated payload
122// type |payload_type|.
123bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
124 int payload_type) {
125 for (const cricket::VideoCodec& codec : codecs) {
126 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200127 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800128 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
129 &associated_payload_type) &&
130 associated_payload_type == payload_type) {
131 return true;
132 }
133 }
134 return false;
135}
136
nisseca5706d2017-09-11 02:32:16 -0700137// TODO(nisse): Duplicated in call.cc.
138const int* FindKeyByValue(const std::map<int, int>& m, int v) {
139 for (const auto& kv : m) {
140 if (kv.second == v)
141 return &kv.first;
142 }
143 return nullptr;
144}
145
Yves Gerey665174f2018-06-19 15:03:05 +0200146bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
147 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700148 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
149 payload_type) != nullptr;
150}
151
152// Check that there's an Rtx payload type for each decoder.
153bool VerifyRtxReceiveAssociations(
154 const webrtc::VideoReceiveStream::Config& config) {
155 for (const auto& decoder : config.decoders) {
156 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
157 return false;
158 }
159 return true;
160}
161
brandtrffc61182016-11-28 06:02:22 -0800162rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700163 int width,
164 int height) {
165 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
166 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800167 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700168 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000169}
170
Shao Changbine62202f2015-04-21 20:24:50 +0800171void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
172 const std::map<int, int>& rtx_types) {
173 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200174 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800175 EXPECT_TRUE(it != rtx_types.end() &&
176 it->second == config.rtp.rtx.payload_type);
177
brandtrb5f2c3f2016-10-04 23:28:39 -0700178 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
179 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800180 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700181 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800182 }
183}
kthelgason2bc68642017-02-07 07:02:22 -0800184
185cricket::MediaConfig GetMediaConfig() {
186 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100187 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800188 return media_config;
189}
nisse26e3abb2017-08-25 04:44:25 -0700190
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200191// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
192int GetMaxDefaultBitrateBps(size_t width, size_t height) {
193 if (width * height <= 320 * 240) {
194 return 600000;
195 } else if (width * height <= 640 * 480) {
196 return 1700000;
197 } else if (width * height <= 960 * 540) {
198 return 2000000;
199 } else {
200 return 2500000;
201 }
202}
203
Niels Möller731a2c22018-07-30 15:08:07 +0200204class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
205 public:
206 MOCK_METHOD2(AddOrUpdateSink,
207 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
208 const rtc::VideoSinkWants& wants));
209 MOCK_METHOD1(RemoveSink,
210 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
211};
212
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000213} // namespace
214
Yves Gerey665174f2018-06-19 15:03:05 +0200215#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200216 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200217 EXPECT_EQ((w), renderer_.width()); \
218 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200219 EXPECT_EQ(0, renderer_.errors());
220
Yves Gerey665174f2018-06-19 15:03:05 +0200221#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200222 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200223 EXPECT_EQ((w), (r).width()); \
224 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200225 EXPECT_EQ(0, (r).errors());
226
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000227namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700228class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000229 public:
eladalonf1841382017-06-12 01:16:46 -0700230 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200231 explicit WebRtcVideoEngineTest(const std::string& field_trials)
232 : override_field_trials_(
233 field_trials.empty()
234 ? nullptr
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200235 : std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alon040dc432019-05-22 15:40:02 +0200236 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200237 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
238 call_(webrtc::Call::Create([&] {
239 webrtc::Call::Config call_config(&event_log_);
240 call_config.task_queue_factory = task_queue_factory_.get();
241 return call_config;
242 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200243 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
244 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200245 video_bitrate_allocator_factory_(
246 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200247 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200248 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200249 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200250 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200251 // Ensure fake clock doesn't return 0, which will cause some initializations
252 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200253 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200254 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000255
256 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 void AssignDefaultAptRtxTypes();
258 void AssignDefaultCodec();
259
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100260 // Find the index of the codec in the engine with the given name. The codec
261 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100262 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100263
magjed509e4fe2016-11-18 01:34:11 -0800264 // Find the codec in the engine with the given name. The codec must be
265 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100266 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800267
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200268 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000269
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200270 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000271 const std::vector<VideoCodec>& codecs);
272
Elad Alon157540a2019-02-08 23:37:52 +0100273 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100274
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200275 // Has to be the first one, so it is initialized before the call or there is a
276 // race condition in the clock access.
277 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200278 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
Danil Chapovalov83bbe912019-08-07 12:24:53 +0200279 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200280 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700281 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000282 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800283 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200284 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
285 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200286 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
287 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700288 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000289 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800290 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000291};
292
eladalonf1841382017-06-12 01:16:46 -0700293TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200294 encoder_factory_->AddSupportedVideoCodecType("VP8");
295 AssignDefaultCodec();
296
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000297 std::vector<VideoCodec> engine_codecs = engine_.codecs();
298 for (size_t i = 0; i < engine_codecs.size(); ++i) {
299 if (engine_codecs[i].name != kRtxCodecName)
300 continue;
301 int associated_payload_type;
302 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000303 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000304 EXPECT_EQ(default_codec_.id, associated_payload_type);
305 return;
306 }
307 FAIL() << "No RTX codec found among default codecs.";
308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100311 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100315 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000316}
317
eladalonf1841382017-06-12 01:16:46 -0700318TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100319 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700320}
321
eladalonf1841382017-06-12 01:16:46 -0700322TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100323 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
327 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
328}
329
330TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
331 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
332}
333
334TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
335 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
336}
337
338TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
339 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100340}
341
342TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100343 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
344}
345
Elad Alonccb9b752019-02-19 13:01:31 +0100346TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
348}
349
350TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
351 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700352}
353
philipel1e054862018-10-08 16:13:53 +0200354class WebRtcVideoEngineTestWithGenericDescriptor
355 : public WebRtcVideoEngineTest {
356 public:
357 WebRtcVideoEngineTestWithGenericDescriptor()
358 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
359};
360
Elad Alonccb9b752019-02-19 13:01:31 +0100361TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
362 AdvertiseGenericDescriptor00) {
363 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
364}
365
366TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
367 AdvertiseGenericDescriptor01) {
368 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200369}
370
eladalonf1841382017-06-12 01:16:46 -0700371TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200372 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200374 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700375
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200376 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700377
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200378 std::unique_ptr<VideoMediaChannel> channel(
379 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700380 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
381
382 // Add CVO extension.
383 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800384 cricket::VideoSendParameters parameters;
385 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200386 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700387 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200388 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700389
Niels Möller731a2c22018-07-30 15:08:07 +0200390 EXPECT_CALL(
391 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200392 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200393 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700394 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200395 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700396
397 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200398 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700399
400 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200401 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200402 EXPECT_CALL(
403 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200404 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200405 Field(&rtc::VideoSinkWants::rotation_applied, true)));
406
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200407 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700408}
409
eladalonf1841382017-06-12 01:16:46 -0700410TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200411 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800412 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200413 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800414
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200415 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800416
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200417 std::unique_ptr<VideoMediaChannel> channel(
418 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800419 // Add CVO extension.
420 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800421 cricket::VideoSendParameters parameters;
422 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800423 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700424 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800425 EXPECT_TRUE(channel->SetSendParameters(parameters));
426 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
427
Niels Möller731a2c22018-07-30 15:08:07 +0200428 // Set source.
429 EXPECT_CALL(
430 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200431 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200432 Field(&rtc::VideoSinkWants::rotation_applied, false)));
433 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800434}
435
eladalonf1841382017-06-12 01:16:46 -0700436TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200437 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700438
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200439 encoder_factory_->AddSupportedVideoCodecType("VP8");
440 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700441
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200442 std::unique_ptr<VideoMediaChannel> channel(
443 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700444 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
445
446 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200447 EXPECT_CALL(
448 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200449 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200450 Field(&rtc::VideoSinkWants::rotation_applied, true)));
451 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452
perkjcaafdba2016-03-20 07:34:29 -0700453 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200454 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700455
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700456 // Add CVO extension.
457 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800458 cricket::VideoSendParameters parameters;
459 parameters.codecs.push_back(GetEngineCodec("VP8"));
460 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200461 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700462 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700463 // Also remove the first codec to trigger a codec change as well.
464 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200465 EXPECT_CALL(
466 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200467 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200468 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200469 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700470
471 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200472 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700473
474 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200475 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200476 EXPECT_CALL(
477 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200478 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200479 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200480 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700481}
482
eladalonf1841382017-06-12 01:16:46 -0700483TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200484 encoder_factory_->AddSupportedVideoCodecType("VP8");
485
Sebastian Jansson84848f22018-11-16 10:40:36 +0100486 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200487 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
488 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000489
490 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
491
492 EXPECT_FALSE(channel->SetSend(true))
493 << "Channel should not start without codecs.";
494 EXPECT_TRUE(channel->SetSend(false))
495 << "Channel should be stoppable even without set codecs.";
496}
497
eladalonf1841382017-06-12 01:16:46 -0700498TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200499 encoder_factory_->AddSupportedVideoCodecType("VP8");
500
Sebastian Jansson84848f22018-11-16 10:40:36 +0100501 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200502 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
503 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000504 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
505 VideoMediaInfo info;
506 channel->GetStats(&info);
507}
508
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200509TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200512 std::unique_ptr<VideoMediaChannel> channel(
513 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800514 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515
516 EXPECT_TRUE(
517 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200518 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000519 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100520 webrtc::test::FrameForwarder frame_forwarder;
521 cricket::FakeFrameSource frame_source(1280, 720,
522 rtc::kNumMicrosecsPerSec / 30);
523 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
524 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100525 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
527 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000528 kTimeout);
529
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200530 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100531 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000532
533 // Setting codecs of the same type should not reallocate any encoders
534 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800535 cricket::VideoSendParameters parameters;
536 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200537 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200538 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000539
540 // Remove stream previously added to free the external encoder instance.
541 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200542 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000543}
544
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200545// Test that when an encoder factory supports H264, we add an RTX
546// codec for it.
547// TODO(deadbeef): This test should be updated if/when we start
548// adding RTX codecs for unrecognized codec names.
549TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800550 using webrtc::H264::kLevel1;
Jonas Olssona4d87372019-07-05 19:08:33 +0200551 using webrtc::H264::ProfileLevelId;
552 using webrtc::H264::ProfileLevelIdToString;
Anders Carlsson67537952018-05-03 11:28:29 +0200553 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
554 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800555 *ProfileLevelIdToString(
556 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200557 webrtc::SdpVideoFormat h264_constrained_high("H264");
558 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800559 *ProfileLevelIdToString(
560 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200561 webrtc::SdpVideoFormat h264_high("H264");
562 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800563 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
564
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200565 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
566 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
567 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700568
magjed725e4842016-11-16 00:48:13 -0800569 // First figure out what payload types the test codecs got assigned.
570 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800571 // Now search for RTX codecs for them. Expect that they all have associated
572 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800573 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200574 codecs,
575 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
576 ->id));
magjed725e4842016-11-16 00:48:13 -0800577 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200578 codecs,
579 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
580 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800581 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200582 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700583}
584
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100585#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700586TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200587 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100588
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200589 std::unique_ptr<VideoMediaChannel> channel(
590 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100591
592 EXPECT_TRUE(
593 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
594}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100595#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100596
eladalonf1841382017-06-12 01:16:46 -0700597TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200598 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100599 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200600 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200601 std::unique_ptr<VideoMediaChannel> channel(
602 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700603
604 EXPECT_TRUE(
605 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
606
Niels Möllerd0f0f682019-01-14 09:09:53 +0100607 webrtc::test::FrameForwarder frame_forwarder;
608 cricket::FakeFrameSource frame_source(1280, 720,
609 rtc::kNumMicrosecsPerSec / 60);
610 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700611 channel->SetSend(true);
612
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200613 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700614
Niels Möllerd0f0f682019-01-14 09:09:53 +0100615 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700616 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700617 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100618 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700619 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700620 int64_t interval = timestamp - last_timestamp;
621
622 // Precision changes from nanosecond to millisecond.
623 // Allow error to be no more than 1.
624 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
625
626 last_timestamp = timestamp;
627 }
628
Niels Möllerd0f0f682019-01-14 09:09:53 +0100629 frame_forwarder.IncomingCapturedFrame(
630 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
631 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700632 last_timestamp = stream->GetLastTimestamp();
633 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100634 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
635 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
636 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700637 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700638 int64_t interval = timestamp - last_timestamp;
639
640 // Precision changes from nanosecond to millisecond.
641 // Allow error to be no more than 1.
642 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
643
644 last_timestamp = timestamp;
645 }
646
647 // Remove stream previously added to free the external encoder instance.
648 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
649}
650
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200651void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
652 std::vector<VideoCodec> engine_codecs = engine_.codecs();
653 RTC_DCHECK(!engine_codecs.empty());
654 for (const cricket::VideoCodec& codec : engine_codecs) {
655 if (codec.name == "rtx") {
656 int associated_payload_type;
657 if (codec.GetParam(kCodecParamAssociatedPayloadType,
658 &associated_payload_type)) {
659 default_apt_rtx_types_[associated_payload_type] = codec.id;
660 }
661 }
662 }
663}
664
665void WebRtcVideoEngineTest::AssignDefaultCodec() {
666 std::vector<VideoCodec> engine_codecs = engine_.codecs();
667 RTC_DCHECK(!engine_codecs.empty());
668 bool codec_set = false;
669 for (const cricket::VideoCodec& codec : engine_codecs) {
670 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
671 codec.name != "ulpfec") {
672 default_codec_ = codec;
673 codec_set = true;
674 }
675 }
676
677 RTC_DCHECK(codec_set);
678}
679
Oleh Prypina40f8242017-12-21 13:32:23 +0100680size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
681 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100682 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
683 for (size_t i = 0; i < codecs.size(); ++i) {
684 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200685 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200686 continue;
687 // The tests only use H264 Constrained Baseline. Make sure we don't return
688 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200689 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200690 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200691 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
692 if (profile_level_id->profile !=
693 webrtc::H264::kProfileConstrainedBaseline) {
694 continue;
695 }
696 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100697 return i;
magjed509e4fe2016-11-18 01:34:11 -0800698 }
699 // This point should never be reached.
700 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100701 return -1;
702}
703
704cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
705 const std::string& name) const {
706 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800707}
708
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200709VideoMediaChannel*
710WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100711 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200712 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
713 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200714 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800715 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200716 for (const webrtc::SdpVideoFormat& format :
717 encoder_factory_->GetSupportedFormats()) {
718 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800719 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200720 parameters.codecs.push_back(engine_codec);
721 }
722 }
magjed509e4fe2016-11-18 01:34:11 -0800723
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200724 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000725
726 return channel;
727}
728
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200729VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000730 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100731 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200732 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
733 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200734 cricket::VideoRecvParameters parameters;
735 parameters.codecs = codecs;
736 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000737
738 return channel;
739}
740
Elad Alon157540a2019-02-08 23:37:52 +0100741void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
742 bool supported) const {
743 const RtpCapabilities capabilities = engine_.GetCapabilities();
744 if (supported) {
745 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200746 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100747 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200748 EXPECT_THAT(capabilities.header_extensions,
749 ::testing::Each(::testing::Field(&RtpExtension::uri,
750 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100751 }
752}
753
eladalonf1841382017-06-12 01:16:46 -0700754TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200755 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000756
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200757 std::unique_ptr<VideoMediaChannel> channel(
758 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000759
Peter Boström0c4e06b2015-10-07 12:23:21 +0200760 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000761
Yves Gerey665174f2018-06-19 15:03:05 +0200762 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000763 EXPECT_TRUE(channel->SetSend(true));
764
Niels Möller805a27e2019-01-21 12:21:27 +0100765 webrtc::test::FrameForwarder frame_forwarder;
766 cricket::FakeFrameSource frame_source(1280, 720,
767 rtc::kNumMicrosecsPerSec / 60);
768 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
769 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000770
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200771 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000772
773 // Verify that encoders are configured for simulcast through adapter
774 // (increasing resolution and only configured to send one stream each).
775 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200776 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
777 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000778 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200779 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000780 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
781 EXPECT_GT(codec_settings.width, prev_width);
782 prev_width = codec_settings.width;
783 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000784
Niels Möllerff40b142018-04-09 08:49:14 +0200785 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000786
787 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200788 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000789}
790
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200791TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
792 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200793 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000794
Niels Möllerd0f0f682019-01-14 09:09:53 +0100795 // Frame source.
796 webrtc::test::FrameForwarder frame_forwarder;
797 cricket::FakeFrameSource frame_source(1280, 720,
798 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200799
Sebastian Jansson84848f22018-11-16 10:40:36 +0100800 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200801 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
802 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200803 cricket::VideoSendParameters parameters;
804 parameters.codecs.push_back(GetEngineCodec("H264"));
805 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000806
807 EXPECT_TRUE(
808 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100809 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200810 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100811 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200812
813 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000814
Anders Carlsson67537952018-05-03 11:28:29 +0200815 cricket::VideoSendParameters new_parameters;
816 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
817 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200818
819 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100820 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200821
Anders Carlsson8a150d92018-05-14 12:40:04 +0200822 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000823}
824
eladalonf1841382017-06-12 01:16:46 -0700825TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000826 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200827 encoder_factory_->AddSupportedVideoCodecType("VP8");
828 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000829
Sebastian Jansson84848f22018-11-16 10:40:36 +0100830 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200831 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
832 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800833 cricket::VideoSendParameters parameters;
834 parameters.codecs.push_back(GetEngineCodec("VP8"));
835 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
Peter Boström0c4e06b2015-10-07 12:23:21 +0200837 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000838
Yves Gerey665174f2018-06-19 15:03:05 +0200839 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000840 EXPECT_TRUE(channel->SetSend(true));
841
842 // Send a fake frame, or else the media engine will configure the simulcast
843 // encoder adapter at a low-enough size that it'll only create a single
844 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100845 webrtc::test::FrameForwarder frame_forwarder;
846 cricket::FakeFrameSource frame_source(1280, 720,
847 rtc::kNumMicrosecsPerSec / 30);
848 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
849 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000850
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200851 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
852 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000853 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000855
856 channel.reset();
857 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200858 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000859}
860
eladalonf1841382017-06-12 01:16:46 -0700861TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000862 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200863 encoder_factory_->AddSupportedVideoCodecType("VP8");
864 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000865
Sebastian Jansson84848f22018-11-16 10:40:36 +0100866 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200867 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
868 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800869 cricket::VideoSendParameters parameters;
870 parameters.codecs.push_back(GetEngineCodec("H264"));
871 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000872
873 EXPECT_TRUE(
874 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100875
876 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100877 webrtc::test::FrameForwarder frame_forwarder;
878 cricket::FakeFrameSource frame_source(1280, 720,
879 rtc::kNumMicrosecsPerSec / 30);
880 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
881 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200882 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
883 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200884 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000885 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200886 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000887
888 channel.reset();
889 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200890 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000891}
892
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200893TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200894 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200895 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200896 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200897 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700898
Sebastian Jansson84848f22018-11-16 10:40:36 +0100899 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200900 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
901 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200902 cricket::VideoSendParameters parameters;
903 parameters.codecs.push_back(GetEngineCodec("H264"));
904 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700905
Peter Boström0c4e06b2015-10-07 12:23:21 +0200906 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700907 EXPECT_TRUE(
908 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100909
910 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100911 webrtc::test::FrameForwarder frame_forwarder;
912 cricket::FakeFrameSource frame_source(1280, 720,
913 rtc::kNumMicrosecsPerSec / 30);
914 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
915 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100916
Niels Möller4db138e2018-04-19 09:04:13 +0200917 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200918 ASSERT_EQ(1u, encoder_factory_->encoders().size());
919 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
920 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700921 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200922 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200923 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700924}
925
brandtrffc61182016-11-28 06:02:22 -0800926// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700927// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800928//
929// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700930TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800931 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200932 encoder_factory_->AddSupportedVideoCodecType("VP8");
933
Steve Anton2c9ebef2019-01-28 17:27:58 -0800934 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800935
936 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800937 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800938
939 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200940 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200941 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800942 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800943 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800944}
945
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200946// Test that codecs are added in the order they are reported from the factory.
947TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
948 encoder_factory_->AddSupportedVideoCodecType("VP8");
949 const char* kFakeCodecName = "FakeCodec";
950 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000951
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200952 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100953 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200954 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
955 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000956}
957
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200958// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800959// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200960TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100961 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
962 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100963
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100964 // Set up external encoder factory with first codec, and initialize engine.
965 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
966
brandtrffc61182016-11-28 06:02:22 -0800967 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800968
969 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100970 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800971 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200972 // The codec itself and RTX should have been added.
973 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100974
975 // Check that both fake codecs are present and that the second fake codec
976 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100977 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
978 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100979 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800980}
981
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200982TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
983 const char* kFakeCodecName = "FakeCodec";
984 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
985
986 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
987 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
988}
989
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200990TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
991 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200992 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200993 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800994 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000995
kwiberg686a8ef2016-02-26 03:00:35 -0800996 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200997 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998
999 EXPECT_TRUE(
1000 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001001 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001002
1003 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001004 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001005 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006
1007 // Remove stream previously added to free the external decoder instance.
1008 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001009 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010}
1011
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001012// Verifies that we can set up decoders.
1013TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001014 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1015 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1016 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1017 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001018 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001019 webrtc::SdpVideoFormat supported_h264("H264");
1020 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1021 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001022 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001023 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001024
kwiberg686a8ef2016-02-26 03:00:35 -08001025 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001026 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001027
1028 EXPECT_TRUE(
1029 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001030 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001031}
1032
Jonas Oreland49ac5952018-09-26 16:04:32 +02001033// Tests when GetSources is called with non-existing ssrc, it will return an
1034// empty list of RtpSource without crashing.
1035TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1036 // Setup an recv stream with |kSsrc|.
1037 encoder_factory_->AddSupportedVideoCodecType("VP8");
1038 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1039 cricket::VideoRecvParameters parameters;
1040 parameters.codecs.push_back(GetEngineCodec("VP8"));
1041 std::unique_ptr<VideoMediaChannel> channel(
1042 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1043
1044 EXPECT_TRUE(
1045 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1046
1047 // Call GetSources with |kSsrc + 1| which doesn't exist.
1048 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1049 EXPECT_EQ(0u, sources.size());
1050}
1051
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001052TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1053 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1054 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1055 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001056 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 EXPECT_EQ(0u, engine.codecs().size());
1058}
1059
1060TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1061 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001062 webrtc::MockVideoEncoderFactory* encoder_factory =
1063 new webrtc::MockVideoEncoderFactory();
1064 webrtc::MockVideoDecoderFactory* decoder_factory =
1065 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001066 WebRtcVideoEngine engine(
1067 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001068 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001069 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1070 EXPECT_EQ(0u, engine.codecs().size());
1071 EXPECT_CALL(*encoder_factory, Die());
1072 EXPECT_CALL(*decoder_factory, Die());
1073}
1074
1075// Test full behavior in the video engine when video codec factories of the new
1076// type are injected supporting the single codec Vp8. Check the returned codecs
1077// from the engine and that we will create a Vp8 encoder and decoder using the
1078// new factories.
1079TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1080 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001081 webrtc::MockVideoEncoderFactory* encoder_factory =
1082 new webrtc::MockVideoEncoderFactory();
1083 webrtc::MockVideoDecoderFactory* decoder_factory =
1084 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001085 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1086 rate_allocator_factory =
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001087 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001088 EXPECT_CALL(*rate_allocator_factory,
1089 CreateVideoBitrateAllocatorProxy(Field(
1090 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001091 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001092 WebRtcVideoEngine engine(
1093 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001094 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095 const webrtc::SdpVideoFormat vp8_format("VP8");
1096 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1097 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001098 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001099
1100 // Verify the codecs from the engine.
1101 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001102 // Verify default codecs has been added correctly.
1103 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001104 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001105
1106 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001107 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001108 int vp8_associated_payload;
1109 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1110 &vp8_associated_payload));
1111 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1112
1113 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1114
1115 // RTX codec for RED.
1116 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1117 int red_associated_payload;
1118 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1119 &red_associated_payload));
1120 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1121
1122 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1123
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001124 int associated_payload_type;
1125 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1126 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1127 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1128 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001129 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1130 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001131
1132 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001133 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1134 codec_info.is_hardware_accelerated = false;
1135 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001136 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001137 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001138 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001139 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001140 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001141 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001142 .WillOnce(
1143 ::testing::DoAll(::testing::InvokeWithoutArgs(
1144 [&encoder_created]() { encoder_created.Set(); }),
1145 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001146
1147 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001148 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001149 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001150 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001151
1152 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001153 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001154 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1155 webrtc::Call::Config call_config(&event_log);
1156 call_config.task_queue_factory = task_queue_factory.get();
1157 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001158
1159 // Create send channel.
1160 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001161 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001162 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1163 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001164 cricket::VideoSendParameters send_parameters;
1165 send_parameters.codecs.push_back(engine_codecs.at(0));
1166 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1167 send_channel->OnReadyToSend(true);
1168 EXPECT_TRUE(
1169 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1170 EXPECT_TRUE(send_channel->SetSend(true));
1171
Niels Möller4db138e2018-04-19 09:04:13 +02001172 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001173 webrtc::test::FrameForwarder frame_forwarder;
1174 cricket::FakeFrameSource frame_source(1280, 720,
1175 rtc::kNumMicrosecsPerSec / 30);
1176 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001177 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001178 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001179 encoder_created.Wait(kTimeout);
1180
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001181 // Create recv channel.
1182 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001183 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001184 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1185 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001186 cricket::VideoRecvParameters recv_parameters;
1187 recv_parameters.codecs.push_back(engine_codecs.at(0));
1188 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1189 EXPECT_TRUE(recv_channel->AddRecvStream(
1190 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1191
1192 // Remove streams previously added to free the encoder and decoder instance.
1193 EXPECT_CALL(*encoder_factory, Die());
1194 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001195 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001196 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1197 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1198}
1199
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001200// Test behavior when decoder factory fails to create a decoder (returns null).
1201TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1202 // |engine| take ownership of the factories.
1203 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001204 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001205 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001206 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001207 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1208 rate_allocator_factory =
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001209 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001210 WebRtcVideoEngine engine(
1211 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001212 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001213 const webrtc::SdpVideoFormat vp8_format("VP8");
1214 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1215 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001216 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001217
1218 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001219 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1220 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001221
1222 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001223 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001224 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1225 webrtc::Call::Config call_config(&event_log);
1226 call_config.task_queue_factory = task_queue_factory.get();
1227 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001228
1229 // Create recv channel.
1230 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001231 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001232 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1233 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001234 cricket::VideoRecvParameters recv_parameters;
1235 recv_parameters.codecs.push_back(engine.codecs().front());
1236 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1237 EXPECT_TRUE(recv_channel->AddRecvStream(
1238 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1239
1240 // Remove streams previously added to free the encoder and decoder instance.
1241 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1242}
1243
eladalonf1841382017-06-12 01:16:46 -07001244TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001245 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001246 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001247 std::unique_ptr<VideoMediaChannel> channel(
1248 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001249 ASSERT_TRUE(
1250 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1251 cricket::VideoCodec codec = GetEngineCodec("VP8");
1252 cricket::VideoSendParameters parameters;
1253 parameters.codecs.push_back(codec);
1254 channel->OnReadyToSend(true);
1255 channel->SetSend(true);
1256 ASSERT_TRUE(channel->SetSendParameters(parameters));
1257
Niels Möller805a27e2019-01-21 12:21:27 +01001258 webrtc::test::FrameForwarder frame_forwarder;
1259 cricket::FakeFrameSource frame_source(1280, 720,
1260 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001261 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001262 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001263
Niels Möller805a27e2019-01-21 12:21:27 +01001264 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001265 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001266 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001267 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001268
Niels Möller805a27e2019-01-21 12:21:27 +01001269 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1270 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001271 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001272 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001273
1274 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001275 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1276 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001277 // Change to screen content, recreate encoder. For the simulcast encoder
1278 // adapter case, this will result in two calls since InitEncode triggers a
1279 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001280 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001281 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001282 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001283
Niels Möller805a27e2019-01-21 12:21:27 +01001284 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1285 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001286 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001287 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001288
1289 options.is_screencast.emplace(false);
1290 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001291 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001292 // Change back to regular video content, update encoder. Also change
1293 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001294 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001295 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001296 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001297 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001298
1299 // Remove stream previously added to free the external encoder instance.
1300 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001301 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001302}
1303
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001304class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001305 protected:
1306 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001307 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1308 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001309 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1310 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1311 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001312
1313 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001314 // One testcase calls SetUp in a loop, only create call_ once.
1315 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001316 webrtc::Call::Config call_config(&event_log_);
1317 call_config.task_queue_factory = task_queue_factory_.get();
1318 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001319 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001320 cricket::MediaConfig media_config;
1321 // Disabling cpu overuse detection actually disables quality scaling too; it
1322 // implies DegradationPreference kMaintainResolution. Automatic scaling
1323 // needs to be disabled, otherwise, tests which check the size of received
1324 // frames become flaky.
1325 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001326 channel_.reset(
1327 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1328 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001329 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001330 channel_->OnReadyToSend(true);
1331 EXPECT_TRUE(channel_.get() != NULL);
1332 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001333 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001334 cricket::VideoRecvParameters parameters;
1335 parameters.codecs = engine_.codecs();
1336 channel_->SetRecvParameters(parameters);
1337 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001338 frame_forwarder_ = std::make_unique<webrtc::test::FrameForwarder>();
1339 frame_source_ = std::make_unique<cricket::FakeFrameSource>(
Niels Möller805a27e2019-01-21 12:21:27 +01001340 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1341 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 }
1343
1344 // Utility method to setup an additional stream to send and receive video.
1345 // Used to test send and recv between two streams.
1346 void SetUpSecondStream() {
1347 SetUpSecondStreamWithNoRecv();
1348 // Setup recv for second stream.
1349 EXPECT_TRUE(channel_->AddRecvStream(
1350 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1351 // Make the second renderer available for use by a new stream.
1352 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1353 }
1354 // Setup an additional stream just to send video. Defer add recv stream.
1355 // This is required if you want to test unsignalled recv of video rtp packets.
1356 void SetUpSecondStreamWithNoRecv() {
1357 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001358 EXPECT_TRUE(
1359 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001360 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001361 EXPECT_FALSE(
1362 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 EXPECT_TRUE(channel_->AddSendStream(
1364 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1365 // We dont add recv for the second stream.
1366
1367 // Setup the receive and renderer for second stream after send.
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001368 frame_forwarder_2_ = std::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001369 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001370 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001371 }
Yves Gerey665174f2018-06-19 15:03:05 +02001372 virtual void TearDown() { channel_.reset(); }
1373 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001374
1375 bool SetOneCodec(const cricket::VideoCodec& codec) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001376 frame_source_ = std::make_unique<cricket::FakeFrameSource>(
Niels Möller805a27e2019-01-21 12:21:27 +01001377 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001378
1379 bool sending = channel_->sending();
1380 bool success = SetSend(false);
1381 if (success) {
1382 cricket::VideoSendParameters parameters;
1383 parameters.codecs.push_back(codec);
1384 success = channel_->SetSendParameters(parameters);
1385 }
1386 if (success) {
1387 success = SetSend(sending);
1388 }
1389 return success;
1390 }
Yves Gerey665174f2018-06-19 15:03:05 +02001391 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001392 void SendFrame() {
1393 if (frame_forwarder_2_) {
1394 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001395 }
Niels Möller805a27e2019-01-21 12:21:27 +01001396 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 }
1398 bool WaitAndSendFrame(int wait_ms) {
1399 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001400 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001401 return ret;
1402 }
Yves Gerey665174f2018-06-19 15:03:05 +02001403 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001404 int NumRtpBytes(uint32_t ssrc) {
1405 return network_interface_.NumRtpBytes(ssrc);
1406 }
Yves Gerey665174f2018-06-19 15:03:05 +02001407 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 int NumRtpPackets(uint32_t ssrc) {
1409 return network_interface_.NumRtpPackets(ssrc);
1410 }
Yves Gerey665174f2018-06-19 15:03:05 +02001411 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001412 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1413 return network_interface_.GetRtpPacket(index);
1414 }
1415 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001416 webrtc::RTPHeader header;
1417 EXPECT_TRUE(ParseRtpPacket(p, &header));
1418 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001419 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001420
Niels Möller6557d0c2018-04-11 15:18:34 +02001421 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001422 webrtc::RTPHeader* header) {
1423 std::unique_ptr<webrtc::RtpHeaderParser> parser(
Tommi25eb47c2019-08-29 16:39:05 +02001424 webrtc::RtpHeaderParser::CreateForTest());
Åsa Persson23cd45a2018-07-03 10:40:40 +02001425 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001426 }
1427
1428 // Tests that we can send and receive frames.
1429 void SendAndReceive(const cricket::VideoCodec& codec) {
1430 EXPECT_TRUE(SetOneCodec(codec));
1431 EXPECT_TRUE(SetSend(true));
1432 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1433 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001434 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001435 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1436 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1437 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1438 }
1439
1440 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001441 int duration_sec,
1442 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001443 EXPECT_TRUE(SetOneCodec(codec));
1444 EXPECT_TRUE(SetSend(true));
1445 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1446 EXPECT_EQ(0, renderer_.num_rendered_frames());
1447 for (int i = 0; i < duration_sec; ++i) {
1448 for (int frame = 1; frame <= fps; ++frame) {
1449 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1450 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1451 }
1452 }
1453 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1454 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1455 }
1456
Niels Möller6557d0c2018-04-11 15:18:34 +02001457 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1458 cricket::VideoMediaInfo info;
1459 EXPECT_TRUE(channel_->GetStats(&info));
1460 return info.senders[i];
1461 }
1462
1463 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1464 cricket::VideoMediaInfo info;
1465 EXPECT_TRUE(channel_->GetStats(&info));
1466 return info.receivers[i];
1467 }
1468
1469 // Two streams one channel tests.
1470
1471 // Tests that we can send and receive frames.
1472 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1473 SetUpSecondStream();
1474 // Test sending and receiving on first stream.
1475 SendAndReceive(codec);
1476 // Test sending and receiving on second stream.
1477 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1478 EXPECT_GT(NumRtpPackets(), 0);
1479 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1480 }
1481
1482 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1483 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001484 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001485 return engine_codec;
1486 }
1487 // This point should never be reached.
1488 ADD_FAILURE() << "Unrecognized codec name: " << name;
1489 return cricket::VideoCodec();
1490 }
1491
1492 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1493
1494 cricket::StreamParams DefaultSendStreamParams() {
1495 return cricket::StreamParams::CreateLegacy(kSsrc);
1496 }
1497
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001498 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001499 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001500 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001501 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1502 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001503 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001504
1505 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1506 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1507 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1508
Niels Möller6557d0c2018-04-11 15:18:34 +02001509 std::unique_ptr<WebRtcVideoChannel> channel_;
1510 cricket::FakeNetworkInterface network_interface_;
1511 cricket::FakeVideoRenderer renderer_;
1512
1513 // Used by test cases where 2 streams are run on the same channel.
1514 cricket::FakeVideoRenderer renderer2_;
1515};
1516
1517// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001518TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001519 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001520 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001521 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1522 EXPECT_FALSE(channel_->sending());
1523 EXPECT_TRUE(SetSend(true));
1524 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001525 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001526 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1527 EXPECT_TRUE(SetSend(false));
1528 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001529}
Niels Möller6557d0c2018-04-11 15:18:34 +02001530
1531// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001532TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001533 EXPECT_FALSE(channel_->sending());
1534 EXPECT_FALSE(SetSend(true));
1535 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001536}
Niels Möller6557d0c2018-04-11 15:18:34 +02001537
1538// Test that we properly set the send and recv buffer sizes by the time
1539// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001540TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001541 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1542 EXPECT_TRUE(SetSend(true));
1543 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001544 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001545}
1546
Johannes Kron5a0665b2019-04-08 10:35:50 +02001547// Test that we properly set the send and recv buffer sizes when overriding
1548// via field trials.
1549TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1550 // Set field trial to override the default recv buffer size, and then re-run
1551 // setup where the interface is created and configured.
1552 const int kCustomRecvBufferSize = 123456;
1553 webrtc::test::ScopedFieldTrials field_trial(
1554 "WebRTC-IncreasedReceivebuffers/123456/");
1555 SetUp();
1556
1557 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1558 EXPECT_TRUE(SetSend(true));
1559 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1560 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1561}
1562
1563// Test that we properly set the send and recv buffer sizes when overriding
1564// via field trials with suffix.
1565TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1566 // Set field trial to override the default recv buffer size, and then re-run
1567 // setup where the interface is created and configured.
1568 const int kCustomRecvBufferSize = 123456;
1569 webrtc::test::ScopedFieldTrials field_trial(
1570 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1571 SetUp();
1572
1573 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1574 EXPECT_TRUE(SetSend(true));
1575 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1576 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1577}
1578
1579// Test that we properly set the send and recv buffer sizes when overriding
1580// via field trials that don't make any sense.
1581TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1582 // Set bogus field trial values to override the default recv buffer size, and
1583 // then re-run setup where the interface is created and configured. The
1584 // default value should still be used.
1585
1586 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1587 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1588 field_trial_string += group;
1589 field_trial_string += "/";
1590 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1591 SetUp();
1592
1593 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1594 EXPECT_TRUE(SetSend(true));
1595 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1596 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1597 }
1598}
1599
Niels Möller6557d0c2018-04-11 15:18:34 +02001600// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001601TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001602 SetUp();
1603
Niels Möller6557d0c2018-04-11 15:18:34 +02001604 const int kDurationSec = 3;
1605 const int kFps = 10;
1606 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1607
1608 cricket::VideoMediaInfo info;
1609 EXPECT_TRUE(channel_->GetStats(&info));
1610
1611 ASSERT_EQ(1U, info.senders.size());
1612 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1613 // For webrtc, bytes_sent does not include the RTP header length.
Niels Möllerac0a4cb2019-10-09 15:01:33 +02001614 EXPECT_EQ(info.senders[0].payload_bytes_sent,
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001615 NumRtpBytes() - kRtpHeaderSize * NumRtpPackets());
Niels Möller6557d0c2018-04-11 15:18:34 +02001616 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1617 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1618 ASSERT_TRUE(info.senders[0].codec_payload_type);
1619 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1620 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1621 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1622 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1623 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1624 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1625 EXPECT_GT(info.senders[0].framerate_input, 0);
1626 EXPECT_GT(info.senders[0].framerate_sent, 0);
1627
1628 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1629 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1630 info.send_codecs[DefaultCodec().id]);
1631
1632 ASSERT_EQ(1U, info.receivers.size());
1633 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1634 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1635 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1636 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1637 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001638 EXPECT_EQ(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Niels Möllerac0a4cb2019-10-09 15:01:33 +02001639 info.receivers[0].payload_bytes_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001640 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001641 EXPECT_EQ(0, info.receivers[0].packets_lost);
1642 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1643 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1644 EXPECT_EQ(0, info.receivers[0].firs_sent);
1645 EXPECT_EQ(0, info.receivers[0].plis_sent);
1646 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1647 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1648 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1649 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1650 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1651 EXPECT_GT(info.receivers[0].framerate_output, 0);
1652
1653 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1654 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1655 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001656}
Niels Möller6557d0c2018-04-11 15:18:34 +02001657
1658// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001659TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001660 SetUp();
1661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662 cricket::FakeVideoRenderer renderer1, renderer2;
1663 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1664 cricket::VideoSendParameters parameters;
1665 parameters.codecs.push_back(DefaultCodec());
1666 parameters.conference_mode = true;
1667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1668 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001669 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1670 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001671 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1672 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1673 EXPECT_EQ(0, renderer1.num_rendered_frames());
1674 EXPECT_EQ(0, renderer2.num_rendered_frames());
1675 std::vector<uint32_t> ssrcs;
1676 ssrcs.push_back(1);
1677 ssrcs.push_back(2);
1678 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001679 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001680 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1681 kTimeout);
1682 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1683 kTimeout);
1684
1685 EXPECT_TRUE(channel_->SetSend(false));
1686
1687 cricket::VideoMediaInfo info;
1688 EXPECT_TRUE(channel_->GetStats(&info));
1689 ASSERT_EQ(1U, info.senders.size());
1690 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1691 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001692 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Niels Möllerac0a4cb2019-10-09 15:01:33 +02001693 GetSenderStats(0).payload_bytes_sent, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1695 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1696 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1697
1698 ASSERT_EQ(2U, info.receivers.size());
1699 for (size_t i = 0; i < info.receivers.size(); ++i) {
1700 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1701 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001702 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Niels Möllerac0a4cb2019-10-09 15:01:33 +02001703 GetReceiverStats(i).payload_bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1706 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1707 }
srtee0c2eea2017-12-15 17:44:33 +01001708}
Niels Möller6557d0c2018-04-11 15:18:34 +02001709
1710// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001711TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 // Normal setup; note that we set the SSRC explicitly to ensure that
1713 // it will come first in the senders map.
1714 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1715 cricket::VideoSendParameters parameters;
1716 parameters.codecs.push_back(DefaultCodec());
1717 parameters.conference_mode = true;
1718 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001719 EXPECT_TRUE(
1720 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001721 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1722 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001723 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001724 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1725 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1726
1727 // Add an additional capturer, and hook up a renderer to receive it.
1728 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001729 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 const int kTestWidth = 160;
1731 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001732 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1733 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001734 EXPECT_TRUE(
1735 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001736 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001737 EXPECT_TRUE(
1738 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001739 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001740 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001741 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1742 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001743
1744 // Get stats, and make sure they are correct for two senders. We wait until
1745 // the number of expected packets have been sent to avoid races where we
1746 // check stats before it has been updated.
1747 cricket::VideoMediaInfo info;
1748 for (uint32_t i = 0; i < kTimeout; ++i) {
1749 rtc::Thread::Current()->ProcessMessages(1);
1750 EXPECT_TRUE(channel_->GetStats(&info));
1751 ASSERT_EQ(2U, info.senders.size());
1752 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1753 NumRtpPackets()) {
1754 // Stats have been updated for both sent frames, expectations can be
1755 // checked now.
1756 break;
1757 }
1758 }
1759 EXPECT_EQ(NumRtpPackets(),
1760 info.senders[0].packets_sent + info.senders[1].packets_sent)
1761 << "Timed out while waiting for packet counts for all sent packets.";
1762 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1763 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1764 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1765 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1766 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1767 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1768 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1769 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1770 // The capturer must be unregistered here as it runs out of it's scope next.
1771 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001772}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001773
Niels Möller6557d0c2018-04-11 15:18:34 +02001774// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001775TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 cricket::VideoSendParameters parameters;
1777 parameters.codecs.push_back(DefaultCodec());
1778 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1779 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1780 parameters.max_bandwidth_bps = 128 * 1024;
1781 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001782}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001783
Niels Möller6557d0c2018-04-11 15:18:34 +02001784// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001785TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 EXPECT_TRUE(SetDefaultCodec());
1787 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001788 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001790 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001792 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1793 EXPECT_EQ(kSsrc, header.ssrc);
1794
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 // Packets are being paced out, so these can mismatch between the first and
1796 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001797 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1798 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001799 EXPECT_EQ(1, NumSentSsrcs());
1800 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1801 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001802}
Niels Möller6557d0c2018-04-11 15:18:34 +02001803
1804// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001805TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001806 // Remove stream added in Setup.
1807 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1808 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001809 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001810 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001811 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001812 EXPECT_TRUE(SetSend(true));
1813 EXPECT_TRUE(WaitAndSendFrame(0));
1814 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001815 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001816 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001817 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1818 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001819 // Packets are being paced out, so these can mismatch between the first and
1820 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1822 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001823 EXPECT_EQ(1, NumSentSsrcs());
1824 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1825 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001826}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001827
Niels Möller6557d0c2018-04-11 15:18:34 +02001828// Test that we can set the default video renderer before and after
1829// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001830TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001831 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1832 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001833
1834 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1835 rtc::SetBE32(packet1.data() + 8, kSsrc);
1836 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1837 EXPECT_TRUE(SetDefaultCodec());
1838 EXPECT_TRUE(SetSend(true));
1839 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001840 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001841 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001842 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001843 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001844}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001845
Niels Möller6557d0c2018-04-11 15:18:34 +02001846// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001847TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001848 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1849 EXPECT_TRUE(SetSend(true));
1850 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001851 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001852 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1853 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001854 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001855 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001856 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1857 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001858 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1859 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001860
1861 // Remove the send stream that was added during Setup.
1862 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1863 int rtp_packets = NumRtpPackets();
1864
Niels Möller6557d0c2018-04-11 15:18:34 +02001865 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001866 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001867 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001868 EXPECT_EQ(rtp_packets, NumRtpPackets());
1869 // Wait 30ms to guarantee the engine does not drop the frame.
1870 EXPECT_TRUE(WaitAndSendFrame(30));
1871 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1872
1873 last_packet = NumRtpPackets() - 1;
1874 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001875 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1876 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001877}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001878
Niels Möller6557d0c2018-04-11 15:18:34 +02001879// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001880TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001881 cricket::FakeVideoRenderer renderer1, renderer2;
1882 EXPECT_TRUE(SetDefaultCodec());
1883 cricket::VideoSendParameters parameters;
1884 parameters.codecs.push_back(DefaultCodec());
1885 parameters.conference_mode = true;
1886 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1887 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001888 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1889 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001890 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1891 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1892 EXPECT_EQ(0, renderer1.num_rendered_frames());
1893 EXPECT_EQ(0, renderer2.num_rendered_frames());
1894 std::vector<uint32_t> ssrcs;
1895 ssrcs.push_back(1);
1896 ssrcs.push_back(2);
1897 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001898 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001899 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1900 kTimeout);
1901 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1902 kTimeout);
1903
1904 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1905 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1906 EXPECT_EQ(kVideoWidth, renderer1.width());
1907 EXPECT_EQ(kVideoHeight, renderer1.height());
1908 EXPECT_EQ(kVideoWidth, renderer2.width());
1909 EXPECT_EQ(kVideoHeight, renderer2.height());
1910 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1911 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001912}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001913
Niels Möller6557d0c2018-04-11 15:18:34 +02001914// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001915TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 using cricket::FOURCC_I420;
Jonas Olssona4d87372019-07-05 19:08:33 +02001917 using cricket::VideoCodec;
1918 using cricket::VideoFormat;
1919 using cricket::VideoOptions;
Niels Möller6557d0c2018-04-11 15:18:34 +02001920
1921 VideoCodec codec = DefaultCodec();
1922 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1923 EXPECT_TRUE(SetOneCodec(codec));
1924 EXPECT_TRUE(SetSend(true));
1925 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1926 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001927 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001928 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001929
1930 webrtc::test::FrameForwarder frame_forwarder;
1931 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1932 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001933
1934 // TODO(nisse): This testcase fails if we don't configure
1935 // screencast. It's unclear why, I see nothing obvious in this
1936 // test which is related to screencast logic.
1937 VideoOptions video_options;
1938 video_options.is_screencast = true;
1939 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1940
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 int captured_frames = 1;
1942 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001943 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001944 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001945 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1946
Niels Möller6557d0c2018-04-11 15:18:34 +02001947 ++captured_frames;
1948 // Wait until frame of right size is captured.
1949 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001950 480 == renderer_.width() &&
1951 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001952 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001953 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001954 EXPECT_EQ(480, renderer_.width());
1955 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001956 captured_frames = renderer_.num_rendered_frames() + 1;
1957 EXPECT_FALSE(renderer_.black_frame());
1958 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1959 // Make sure a black frame is generated within the specified timeout.
1960 // The black frame should be the resolution of the previous frame to
1961 // prevent expensive encoder reconfigurations.
1962 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001963 480 == renderer_.width() &&
1964 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001965 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001967 EXPECT_EQ(480, renderer_.width());
1968 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001969 EXPECT_TRUE(renderer_.black_frame());
1970
1971 // The black frame has the same timestamp as the next frame since it's
1972 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1973 // not render a frame with the same timestamp so capture another frame
1974 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001975 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001976 }
srtee0c2eea2017-12-15 17:44:33 +01001977}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001978
Niels Möller6557d0c2018-04-11 15:18:34 +02001979// Tests that if SetVideoSend is called with a NULL capturer after the
1980// capturer was already removed, the application doesn't crash (and no black
1981// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001982TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001983 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1984 EXPECT_TRUE(SetSend(true));
1985 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1986 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001987 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1989 // Wait for one frame so they don't get dropped because we send frames too
1990 // tightly.
1991 rtc::Thread::Current()->ProcessMessages(30);
1992 // Remove the capturer.
1993 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1994
1995 // No capturer was added, so this SetVideoSend shouldn't do anything.
1996 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1997 rtc::Thread::Current()->ProcessMessages(300);
1998 // Verify no more frames were sent.
1999 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01002000}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002001
Niels Möller6557d0c2018-04-11 15:18:34 +02002002// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01002003TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2005 // interval time to avoid that.
2006 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2007 // interval time to avoid that.
2008 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02002009 EXPECT_TRUE(
2010 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
2012 cricket::VideoFormat capture_format(
2013 kVideoWidth, kVideoHeight,
2014 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2015 // Set up additional stream 1.
2016 cricket::FakeVideoRenderer renderer1;
2017 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002018 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002020 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002021
2022 webrtc::test::FrameForwarder frame_forwarder1;
2023 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2024 rtc::kNumMicrosecsPerSec / kFramerate);
2025
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 // Set up additional stream 2.
2027 cricket::FakeVideoRenderer renderer2;
2028 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002029 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002030 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002031 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002032 webrtc::test::FrameForwarder frame_forwarder2;
2033
Niels Möller6557d0c2018-04-11 15:18:34 +02002034 // State for all the streams.
2035 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2036 // A limitation in the lmi implementation requires that SetVideoSend() is
2037 // called after SetOneCodec().
2038 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002039 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2040 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002041 EXPECT_TRUE(SetSend(true));
2042 // Test capturer associated with engine.
2043 const int kTestWidth = 160;
2044 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002045 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2046 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2047 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002048 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2049 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002050 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002051 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2052 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2053 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002054 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2055 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002056 // Successfully remove the capturer.
2057 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2058 // The capturers must be unregistered here as it runs out of it's scope
2059 // next.
2060 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2061 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002062}
Niels Möller6557d0c2018-04-11 15:18:34 +02002063
2064// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002065TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002066 // Remove the send stream that was added during Setup.
2067 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2068
2069 cricket::StreamParams empty;
2070 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002071 EXPECT_TRUE(
2072 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002073}
Niels Möller6557d0c2018-04-11 15:18:34 +02002074
2075// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002076TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002077 // Remove stream added in Setup. I.e. remove stream corresponding to default
2078 // channel.
2079 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002080 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002081 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2082 EXPECT_TRUE(channel_->AddSendStream(
2083 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2084 }
2085 // Delete one of the non default channel streams, let the destructor delete
2086 // the remaining ones.
2087 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2088 // Stream should already be deleted.
2089 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002090}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002091
eladalonf1841382017-06-12 01:16:46 -07002092TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002093 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002094}
2095
eladalonf1841382017-06-12 01:16:46 -07002096TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002097 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002098}
2099
eladalonf1841382017-06-12 01:16:46 -07002100TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002101 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002102}
2103
eladalonf1841382017-06-12 01:16:46 -07002104TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002105 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2106 // bitrates. This currently happens at <250k, and two streams sharing 300k
2107 // initially will use QVGA instead of VGA.
2108 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2109 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002110 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002111 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002112 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002113}
2114
philipeld9cc8c02019-09-16 14:53:40 +02002115TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderFallback) {
philipele8ed8302019-07-03 11:53:48 +02002116 cricket::VideoSendParameters parameters;
2117 parameters.codecs.push_back(GetEngineCodec("VP9"));
2118 parameters.codecs.push_back(GetEngineCodec("VP8"));
2119 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2120
2121 VideoCodec codec;
2122 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2123 EXPECT_EQ("VP9", codec.name);
2124
philipeld9cc8c02019-09-16 14:53:40 +02002125 // RequestEncoderFallback will post a task to the worker thread (which is also
philipele8ed8302019-07-03 11:53:48 +02002126 // the current thread), hence the ProcessMessages call.
philipeld9cc8c02019-09-16 14:53:40 +02002127 channel_->RequestEncoderFallback();
philipele8ed8302019-07-03 11:53:48 +02002128 rtc::Thread::Current()->ProcessMessages(30);
2129 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2130 EXPECT_EQ("VP8", codec.name);
2131
2132 // No other codec to fall back to, keep using VP8.
philipeld9cc8c02019-09-16 14:53:40 +02002133 channel_->RequestEncoderFallback();
philipele8ed8302019-07-03 11:53:48 +02002134 rtc::Thread::Current()->ProcessMessages(30);
2135 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2136 EXPECT_EQ("VP8", codec.name);
2137}
2138
philipeld9cc8c02019-09-16 14:53:40 +02002139TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderSwitchWithConfig) {
2140 const std::string kParam = "the-param";
2141 const std::string kPing = "ping";
2142 const std::string kPong = "pong";
2143
2144 cricket::VideoSendParameters parameters;
2145 VideoCodec vp9 = GetEngineCodec("VP9");
2146 vp9.params[kParam] = kPong;
2147 parameters.codecs.push_back(vp9);
2148
2149 VideoCodec vp8 = GetEngineCodec("VP8");
2150 vp8.params[kParam] = kPing;
2151 parameters.codecs.push_back(vp8);
2152
2153 EXPECT_TRUE(channel_->SetSendParameters(parameters));
philipel16cec3b2019-10-25 12:23:02 +02002154 channel_->SetVideoCodecSwitchingEnabled(true);
philipeld9cc8c02019-09-16 14:53:40 +02002155
2156 VideoCodec codec;
2157 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2158 EXPECT_THAT(codec.name, Eq("VP9"));
2159
2160 // RequestEncoderSwitch will post a task to the worker thread (which is also
2161 // the current thread), hence the ProcessMessages call.
2162 webrtc::EncoderSwitchRequestCallback::Config conf1{"VP8", kParam, kPing};
2163 channel_->RequestEncoderSwitch(conf1);
2164 rtc::Thread::Current()->ProcessMessages(30);
2165 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2166 EXPECT_THAT(codec.name, Eq("VP8"));
2167 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2168
2169 webrtc::EncoderSwitchRequestCallback::Config conf2{"VP9", kParam, kPong};
2170 channel_->RequestEncoderSwitch(conf2);
2171 rtc::Thread::Current()->ProcessMessages(30);
2172 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2173 EXPECT_THAT(codec.name, Eq("VP9"));
2174 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPong)));
2175}
2176
2177TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderSwitchIncorrectParam) {
2178 const std::string kParam = "the-param";
2179 const std::string kPing = "ping";
2180 const std::string kPong = "pong";
2181
2182 cricket::VideoSendParameters parameters;
2183 VideoCodec vp9 = GetEngineCodec("VP9");
2184 vp9.params[kParam] = kPong;
2185 parameters.codecs.push_back(vp9);
2186
2187 VideoCodec vp8 = GetEngineCodec("VP8");
2188 vp8.params[kParam] = kPing;
2189 parameters.codecs.push_back(vp8);
2190
2191 EXPECT_TRUE(channel_->SetSendParameters(parameters));
philipel16cec3b2019-10-25 12:23:02 +02002192 channel_->SetVideoCodecSwitchingEnabled(true);
philipeld9cc8c02019-09-16 14:53:40 +02002193
2194 VideoCodec codec;
2195 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2196 EXPECT_THAT(codec.name, Eq("VP9"));
2197
2198 // RequestEncoderSwitch will post a task to the worker thread (which is also
2199 // the current thread), hence the ProcessMessages call.
2200 webrtc::EncoderSwitchRequestCallback::Config conf1{"VP8", kParam, kPing};
2201 channel_->RequestEncoderSwitch(conf1);
2202 rtc::Thread::Current()->ProcessMessages(30);
2203 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2204 EXPECT_THAT(codec.name, Eq("VP8"));
2205 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2206
2207 // Incorrect conf2.value, expect no codec switch.
2208 webrtc::EncoderSwitchRequestCallback::Config conf2{"VP9", kParam, kPing};
2209 channel_->RequestEncoderSwitch(conf2);
2210 rtc::Thread::Current()->ProcessMessages(30);
2211 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2212 EXPECT_THAT(codec.name, Eq("VP8"));
2213 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2214}
2215
eladalonf1841382017-06-12 01:16:46 -07002216class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002217 public:
eladalonf1841382017-06-12 01:16:46 -07002218 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2219 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002220 : WebRtcVideoEngineTest(field_trials),
2221 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2222 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002223 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002224 encoder_factory_->AddSupportedVideoCodecType("VP8");
2225 encoder_factory_->AddSupportedVideoCodecType("VP9");
2226#if defined(WEBRTC_USE_H264)
2227 encoder_factory_->AddSupportedVideoCodecType("H264");
2228#endif
2229
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002230 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002231 channel_.reset(engine_.CreateMediaChannel(
2232 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2233 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002234 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002235 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002236 send_parameters_.codecs = engine_.codecs();
2237 recv_parameters_.codecs = engine_.codecs();
2238 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002239 }
2240
2241 protected:
2242 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002243 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002244 }
2245
2246 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002247 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002248 EXPECT_TRUE(channel_->AddSendStream(sp));
2249 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002250 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002251 EXPECT_EQ(num_streams + 1, streams.size());
2252 return streams[streams.size() - 1];
2253 }
2254
2255 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002256 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002257 }
2258
2259 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002260 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002261 }
2262
2263 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002264 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002265 EXPECT_TRUE(channel_->AddRecvStream(sp));
2266 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002267 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002268 EXPECT_EQ(num_streams + 1, streams.size());
2269 return streams[streams.size() - 1];
2270 }
2271
pbos@webrtc.org00873182014-11-25 14:03:34 +00002272 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2273 int expected_min_bitrate_bps,
2274 const char* start_bitrate_kbps,
2275 int expected_start_bitrate_bps,
2276 const char* max_bitrate_kbps,
2277 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002278 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2279 expected_start_bitrate_bps,
2280 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002281 auto& codecs = send_parameters_.codecs;
2282 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002283 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002284 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2285 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2286 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002287 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002288 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002289
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002290 void ExpectSetBitrateParameters(int min_bitrate_bps,
2291 int start_bitrate_bps,
2292 int max_bitrate_bps) {
2293 EXPECT_CALL(
2294 *fake_call_->GetMockTransportControllerSend(),
2295 SetSdpBitrateParameters(AllOf(
2296 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2297 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2298 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2299 }
2300
2301 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2302 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2303 SetSdpBitrateParameters(Field(
2304 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002305 }
2306
Johannes Kron9190b822018-10-29 11:22:05 +01002307 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2308 // For a caller, the answer will be applied in set remote description
2309 // where SetSendParameters() is called.
2310 EXPECT_TRUE(
2311 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2312 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2313 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2314 const webrtc::VideoSendStream::Config& config =
2315 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2316 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2317 }
2318
2319 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2320 // For a callee, the answer will be applied in set local description
2321 // where SetExtmapAllowMixed() and AddSendStream() are called.
2322 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2323 EXPECT_TRUE(
2324 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2325 const webrtc::VideoSendStream::Config& config =
2326 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2327 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2328 }
2329
isheriff6f8d6862016-05-26 11:24:55 -07002330 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002331 // Enable extension.
2332 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002333 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002334 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002335 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002336 FakeVideoSendStream* send_stream =
2337 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2338
2339 // Verify the send extension id.
2340 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2341 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002342 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002343 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002344 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002345 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2346 // receivers.
2347 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2348 ->GetConfig()
2349 .rtp.extensions.empty());
2350
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002351 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002352 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002353 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2354 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002355 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2356
2357 // Verify that adding receive RTP header extensions adds them for existing
2358 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002359 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002360 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002361 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2362 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002363 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002364 }
2365
isheriff6f8d6862016-05-26 11:24:55 -07002366 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002367 // Enable extension.
2368 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002369 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002370 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002371 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002372
2373 FakeVideoReceiveStream* recv_stream =
2374 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2375
2376 // Verify the recv extension id.
2377 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2378 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002379 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002380 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002381 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002382
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002383 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2384 // senders.
2385 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2386 ->GetConfig()
2387 .rtp.extensions.empty());
2388
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002389 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002390 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002391 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2392 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002393 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2394
2395 // Verify that adding receive RTP header extensions adds them for existing
2396 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002397 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002398 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002399 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2400 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002401 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002402 }
2403
Elad Alonfadb1812019-05-24 13:40:02 +02002404 void TestLossNotificationState(bool expect_lntf_enabled) {
2405 AssignDefaultCodec();
2406 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2407
2408 cricket::VideoSendParameters parameters;
2409 parameters.codecs = engine_.codecs();
2410 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2411 EXPECT_TRUE(channel_->SetSend(true));
2412
2413 // Send side.
2414 FakeVideoSendStream* send_stream =
2415 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2416 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2417
2418 // Receiver side.
2419 FakeVideoReceiveStream* recv_stream =
2420 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2421 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2422 }
2423
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002424 void TestExtensionFilter(const std::vector<std::string>& extensions,
2425 const std::string& expected_extension) {
2426 cricket::VideoSendParameters parameters = send_parameters_;
2427 int expected_id = -1;
2428 int id = 1;
2429 for (const std::string& extension : extensions) {
2430 if (extension == expected_extension)
2431 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002432 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002433 }
2434 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2435 FakeVideoSendStream* send_stream =
2436 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2437
2438 // Verify that only one of them has been set, and that it is the one with
2439 // highest priority (transport sequence number).
2440 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2441 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2442 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002443 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002444 }
2445
asapersson3c81a1a2017-06-14 05:52:21 -07002446 void TestDegradationPreference(bool resolution_scaling_enabled,
2447 bool fps_scaling_enabled);
2448
Erik Språngefbde372015-04-29 16:21:28 +02002449 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002450 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002451 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2452 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002453
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002454 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002455 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002456 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002457 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002458 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002459 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002460 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002461 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002462 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002463
Erik Språng143cec12015-04-28 10:01:41 +02002464 return fake_call_->GetVideoSendStreams().back();
2465 }
2466
Peter Boström2feafdb2015-09-09 14:32:14 +02002467 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2468 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002469 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002470 std::vector<uint32_t> ssrcs;
2471 std::vector<uint32_t> rtx_ssrcs;
2472 uint32_t num_streams = enabled ? 3 : 1;
2473 for (uint32_t i = 0; i < num_streams; ++i) {
2474 uint32_t ssrc = last_ssrc_ + i;
2475 ssrcs.push_back(ssrc);
2476 if (with_rtx) {
2477 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2478 }
Erik Språng143cec12015-04-28 10:01:41 +02002479 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002480 if (with_rtx) {
2481 return AddSendStream(
2482 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2483 }
2484 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002485 }
2486
perkjfa10b552016-10-02 23:45:26 -07002487 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002488 std::vector<FakeVideoSendStream*> streams =
2489 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002490 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002491 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002492 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002493 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002494 }
2495
perkjfa10b552016-10-02 23:45:26 -07002496 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002497 int stream_max,
2498 int expected_encoder_bitrate) {
2499 VideoSendParameters limited_send_params = send_parameters_;
2500 limited_send_params.max_bandwidth_bps = global_max;
2501 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002502 webrtc::RtpParameters parameters =
2503 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002504 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002505 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002506 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002507 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002508 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002509 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002510 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002511 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002512 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002513 }
2514
Åsa Persson55659812018-06-18 17:51:32 +02002515 // Values from kSimulcastConfigs in simulcast.cc.
2516 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2517 std::vector<webrtc::VideoStream> layers(3);
2518 layers[0].min_bitrate_bps = 30000;
2519 layers[0].target_bitrate_bps = 150000;
2520 layers[0].max_bitrate_bps = 200000;
2521 layers[1].min_bitrate_bps = 150000;
2522 layers[1].target_bitrate_bps = 500000;
2523 layers[1].max_bitrate_bps = 700000;
2524 layers[2].min_bitrate_bps = 600000;
2525 layers[2].target_bitrate_bps = 2500000;
2526 layers[2].max_bitrate_bps = 2500000;
2527 return layers;
2528 }
2529
Niels Möller805a27e2019-01-21 12:21:27 +01002530 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002531 std::unique_ptr<FakeCall> fake_call_;
2532 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002533 cricket::VideoSendParameters send_parameters_;
2534 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002535 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002536};
2537
eladalonf1841382017-06-12 01:16:46 -07002538TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002539 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002540 const std::string kSyncLabel = "AvSyncLabel";
2541
2542 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002543 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002544 EXPECT_TRUE(channel_->AddRecvStream(sp));
2545
Mirko Bonadeif859e552018-05-30 15:31:29 +02002546 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002547 EXPECT_EQ(kSyncLabel,
2548 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2549 << "SyncGroup should be set based on sync_label";
2550}
2551
eladalonf1841382017-06-12 01:16:46 -07002552TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002553 cricket::VideoSendParameters parameters;
2554 parameters.codecs = engine_.codecs();
2555 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002556 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002557 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002558 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002559
2560 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002561 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2562 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002563 FakeVideoSendStream* send_stream = AddSendStream(
2564 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2565
2566 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2567 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2568 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2569
2570 // Receiver side.
2571 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2572 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002573 EXPECT_FALSE(
2574 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002575 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002576 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002577 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002578 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002579 << "RTX should be mapped for the RED payload type";
2580
brandtr14742122017-01-27 04:53:07 -08002581 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002582}
2583
eladalonf1841382017-06-12 01:16:46 -07002584TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002585 // Setup one channel with an associated RTX stream.
2586 cricket::StreamParams params =
2587 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2588 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2589 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002590 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002591
2592 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2593 << "RTX should be mapped for all decoders/payload types.";
2594 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002595 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002596 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002597}
2598
eladalonf1841382017-06-12 01:16:46 -07002599TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002600 // Setup one channel without an associated RTX stream.
2601 cricket::StreamParams params =
2602 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2603 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002604 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002605}
2606
Johannes Kron9190b822018-10-29 11:22:05 +01002607// Test propagation of extmap allow mixed setting.
2608TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2609 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2610}
2611TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2612 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2613}
2614TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2615 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2616}
2617TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2618 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2619}
2620
eladalonf1841382017-06-12 01:16:46 -07002621TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002622 FakeVideoSendStream* send_stream =
2623 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2624 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2625
2626 FakeVideoReceiveStream* recv_stream =
2627 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2628 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002629}
2630
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002631// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002632TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002633 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002634}
isheriff6f8d6862016-05-26 11:24:55 -07002635
eladalonf1841382017-06-12 01:16:46 -07002636TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002637 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002638}
2639
2640// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002641TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002642 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002643}
isheriff6f8d6862016-05-26 11:24:55 -07002644
eladalonf1841382017-06-12 01:16:46 -07002645TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002646 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002647}
2648
eladalonf1841382017-06-12 01:16:46 -07002649TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002650 // Enable three redundant extensions.
2651 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002652 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2653 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2654 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2655 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002656}
2657
eladalonf1841382017-06-12 01:16:46 -07002658TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002659 // Enable two redundant extensions.
2660 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002661 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2662 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2663 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002664}
2665
stefanc1aeaf02015-10-15 07:26:07 -07002666// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002667TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002668 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002669}
eladalonf1841382017-06-12 01:16:46 -07002670TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002671 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002672}
2673
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002674// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002675TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002676 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002677}
eladalonf1841382017-06-12 01:16:46 -07002678TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002679 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002680}
2681
eladalonf1841382017-06-12 01:16:46 -07002682TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002683 const int kAbsSendTimeId = 1;
2684 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002685 send_parameters_.extensions.push_back(
2686 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2687 send_parameters_.extensions.push_back(
2688 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002689
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002690 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002691 FakeVideoSendStream* send_stream =
2692 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2693
2694 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002695 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002696
2697 // Setting the same extensions (even if in different order) shouldn't
2698 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002699 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002700 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002701
2702 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2703
2704 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002705 send_parameters_.extensions.resize(1);
2706 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002707
2708 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2709}
2710
eladalonf1841382017-06-12 01:16:46 -07002711TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002712 const int kTOffsetId = 1;
2713 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002714 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002715 recv_parameters_.extensions.push_back(
2716 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2717 recv_parameters_.extensions.push_back(
2718 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2719 recv_parameters_.extensions.push_back(
2720 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002721
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002722 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002723 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002724 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2725
2726 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002727 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002728
2729 // Setting the same extensions (even if in different order) shouldn't
2730 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002731 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002732 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002733
2734 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2735
2736 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002737 recv_parameters_.extensions.resize(1);
2738 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002739
2740 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2741}
2742
eladalonf1841382017-06-12 01:16:46 -07002743TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002744 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002745 const int kUnsupportedId = 1;
2746 const int kTOffsetId = 2;
2747
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002748 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002749 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002750 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002751 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002752 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002753 FakeVideoSendStream* send_stream =
2754 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2755
2756 // Only timestamp offset extension is set to send stream,
2757 // unsupported rtp extension is ignored.
2758 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002759 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2760 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002761}
2762
eladalonf1841382017-06-12 01:16:46 -07002763TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002764 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002765 const int kUnsupportedId = 1;
2766 const int kTOffsetId = 2;
2767
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002768 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002769 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002770 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002771 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002772 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002773 FakeVideoReceiveStream* recv_stream =
2774 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2775
2776 // Only timestamp offset extension is set to receive stream,
2777 // unsupported rtp extension is ignored.
2778 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002779 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2780 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002781}
2782
eladalonf1841382017-06-12 01:16:46 -07002783TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002784 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002785 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002786 send_parameters_.extensions.push_back(
2787 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002788 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002789 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2790 }
2791}
2792
eladalonf1841382017-06-12 01:16:46 -07002793TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002794 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002795 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002796 recv_parameters_.extensions.push_back(
2797 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002798 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002799 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2800 }
2801}
2802
eladalonf1841382017-06-12 01:16:46 -07002803TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002804 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002805 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002806 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002807 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002808 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002809 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002810
2811 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002812 send_parameters_.extensions.clear();
2813 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002814 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002815 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2816 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002817}
2818
eladalonf1841382017-06-12 01:16:46 -07002819TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002820 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002821 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002822 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002823 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002824 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002825 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002826
2827 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002828 recv_parameters_.extensions.clear();
2829 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002830 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002831 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2832 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002833}
2834
eladalonf1841382017-06-12 01:16:46 -07002835TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002836 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002837 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002838}
2839
eladalonf1841382017-06-12 01:16:46 -07002840TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002841 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002842 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002843}
2844
eladalonf1841382017-06-12 01:16:46 -07002845TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002846 FakeVideoReceiveStream* stream = AddRecvStream();
2847 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2848}
2849
eladalonf1841382017-06-12 01:16:46 -07002850TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002851 FakeVideoReceiveStream* stream = AddRecvStream();
2852 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2853
2854 // Verify that transport cc feedback is turned off when send(!) codecs without
2855 // transport cc feedback are set.
2856 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002857 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002858 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2859 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2860 stream = fake_call_->GetVideoReceiveStreams()[0];
2861 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2862
2863 // Verify that transport cc feedback is turned on when setting default codecs
2864 // since the default codecs have transport cc feedback enabled.
2865 parameters.codecs = engine_.codecs();
2866 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2867 stream = fake_call_->GetVideoReceiveStreams()[0];
2868 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2869}
2870
Elad Alonfadb1812019-05-24 13:40:02 +02002871TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2872 TestLossNotificationState(false);
2873}
2874
2875TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2876 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002877 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alonfadb1812019-05-24 13:40:02 +02002878 "WebRTC-RtcpLossNotification/Enabled/");
2879 SetUp();
2880 TestLossNotificationState(true);
2881}
2882
2883TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2884 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002885 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alonfadb1812019-05-24 13:40:02 +02002886 "WebRTC-RtcpLossNotification/Enabled/");
2887 SetUp();
2888
2889 AssignDefaultCodec();
2890 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2891
2892 {
2893 cricket::VideoSendParameters parameters;
2894 parameters.codecs = engine_.codecs();
2895 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2896 EXPECT_TRUE(channel_->SetSend(true));
2897 }
2898
2899 // Start with LNTF enabled.
2900 FakeVideoSendStream* send_stream =
2901 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2902 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2903 FakeVideoReceiveStream* recv_stream =
2904 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2905 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2906
2907 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2908 cricket::VideoSendParameters parameters;
2909 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2910 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2911 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2912 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2913 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2914 send_stream = fake_call_->GetVideoSendStreams()[0];
2915 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2916
2917 // Setting the default codecs again, including VP8, turns LNTF back on.
2918 parameters.codecs = engine_.codecs();
2919 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2920 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2921 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2922 send_stream = fake_call_->GetVideoSendStreams()[0];
2923 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2924}
2925
eladalonf1841382017-06-12 01:16:46 -07002926TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002927 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002928 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002929
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002930 cricket::VideoSendParameters parameters;
2931 parameters.codecs = engine_.codecs();
2932 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002933 EXPECT_TRUE(channel_->SetSend(true));
2934
2935 // Send side.
2936 FakeVideoSendStream* send_stream =
2937 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2938 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2939
2940 // Receiver side.
2941 FakeVideoReceiveStream* recv_stream =
2942 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2943 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2944
2945 // Nack history size should match between sender and receiver.
2946 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2947 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002948}
2949
eladalonf1841382017-06-12 01:16:46 -07002950TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002951 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002952 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002953
2954 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2955 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2956
2957 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002958 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002959 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002960 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2961 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002962 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2963 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2964 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002965 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2966
Peter Boström67c9df72015-05-11 14:34:58 +02002967 // Verify that NACK is turned on when setting default codecs since the
2968 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002969 parameters.codecs = engine_.codecs();
2970 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002971 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2972 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2973 send_stream = fake_call_->GetVideoSendStreams()[0];
2974 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002975}
2976
Peter Boströme7ba0862016-03-12 00:02:28 +01002977// This test verifies that new frame sizes reconfigures encoders even though not
2978// (yet) sending. The purpose of this is to permit encoding as quickly as
2979// possible once we start sending. Likely the frames being input are from the
2980// same source that will be sent later, which just means that we're ready
2981// earlier.
eladalonf1841382017-06-12 01:16:46 -07002982TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002983 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002984 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002985 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2986 channel_->SetSend(false);
2987
2988 FakeVideoSendStream* stream = AddSendStream();
2989
perkjfa10b552016-10-02 23:45:26 -07002990 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002991 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002992 EXPECT_EQ(0u, streams[0].width);
2993 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002994
Niels Möller805a27e2019-01-21 12:21:27 +01002995 webrtc::test::FrameForwarder frame_forwarder;
2996 cricket::FakeFrameSource frame_source(1280, 720,
2997 rtc::kNumMicrosecsPerSec / 30);
2998
2999 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
3000 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01003001
3002 // Frame entered, should be reconfigured to new dimensions.
3003 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003004 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
3005 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01003006
Niels Möllerff40b142018-04-09 08:49:14 +02003007 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01003008}
3009
eladalonf1841382017-06-12 01:16:46 -07003010TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003011 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08003012 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003013 cricket::VideoSendParameters parameters;
3014 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003015 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003016 AddSendStream();
3017
Niels Möller805a27e2019-01-21 12:21:27 +01003018 webrtc::test::FrameForwarder frame_forwarder;
3019 cricket::FakeFrameSource frame_source(1280, 720,
3020 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07003021 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003022 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01003023 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
3024 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003025
3026 EXPECT_TRUE(channel_->SetSend(true));
3027
Niels Möller805a27e2019-01-21 12:21:27 +01003028 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003029 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3030 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3031
3032 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3033
3034 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07003035 webrtc::VideoEncoderConfig encoder_config =
3036 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003037 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003038 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003039 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003040 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3041 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003042 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
3043 << "Non-screenshare shouldn't use min-transmit bitrate.";
3044
Niels Möllerff40b142018-04-09 08:49:14 +02003045 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08003046 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07003047 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003048 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003049 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
3050 &frame_forwarder));
3051 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08003052 // Send stream recreated after option change.
3053 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3054 send_stream = fake_call_->GetVideoSendStreams().front();
3055 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003056
3057 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003058 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003059 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003060 encoder_config.content_type);
3061 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
3062 encoder_config.min_transmit_bitrate_bps);
3063
perkjfa10b552016-10-02 23:45:26 -07003064 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003065 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3066 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01003067 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02003068 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003069}
3070
eladalonf1841382017-06-12 01:16:46 -07003071TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003072 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02003073 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08003074 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003075 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003076
3077 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003078 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003079 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003080 webrtc::test::FrameForwarder frame_forwarder;
3081 cricket::FakeFrameSource frame_source(1280, 720,
3082 rtc::kNumMicrosecsPerSec / 30);
3083 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003084 EXPECT_TRUE(channel_->SetSend(true));
3085
Niels Möller805a27e2019-01-21 12:21:27 +01003086 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003087 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3088 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3089
perkj26091b12016-09-01 01:17:40 -07003090 webrtc::VideoEncoderConfig encoder_config =
3091 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003092
3093 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003094 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003095 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003096 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003097
3098 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3099 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003100 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003101 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003102 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003103
Niels Möllerff40b142018-04-09 08:49:14 +02003104 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003105}
3106
eladalonf1841382017-06-12 01:16:46 -07003107TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003108 FakeVideoSendStream* stream = AddSendStream();
3109 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3110}
3111
eladalonf1841382017-06-12 01:16:46 -07003112TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003113 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003114 media_config.video.suspend_below_min_bitrate = true;
3115
Sebastian Jansson84848f22018-11-16 10:40:36 +01003116 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003117 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3118 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003119 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003120
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003121 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003122
3123 FakeVideoSendStream* stream = AddSendStream();
3124 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3125
nisse0db023a2016-03-01 04:29:59 -08003126 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003127 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003128 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3129 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003130 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003131
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003132 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003133
nisse0db023a2016-03-01 04:29:59 -08003134 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003135 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3136}
3137
eladalonf1841382017-06-12 01:16:46 -07003138TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003139 FakeVideoSendStream* stream = AddSendStream();
3140 webrtc::VideoCodecVP8 vp8_settings;
3141 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3142 EXPECT_TRUE(vp8_settings.denoisingOn);
3143}
3144
eladalonf1841382017-06-12 01:16:46 -07003145TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003146 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003147 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003148 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003149
Peter Boström2feafdb2015-09-09 14:32:14 +02003150 // Single-stream settings should apply with RTX as well (verifies that we
3151 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3152 // both RTX and regular SSRCs).
3153 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003154
Niels Möller805a27e2019-01-21 12:21:27 +01003155 webrtc::test::FrameForwarder frame_forwarder;
3156 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003157 channel_->SetSend(true);
3158
Niels Möller805a27e2019-01-21 12:21:27 +01003159 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003160
pbos4cba4eb2015-10-26 11:18:18 -07003161 webrtc::VideoCodecVP8 vp8_settings;
3162 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3163 EXPECT_TRUE(vp8_settings.denoisingOn)
3164 << "VP8 denoising should be on by default.";
3165
Niels Möller805a27e2019-01-21 12:21:27 +01003166 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003167
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003168 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3169 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003170 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3171 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003172
Niels Möller805a27e2019-01-21 12:21:27 +01003173 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003174
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003175 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3176 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003177 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3178 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3179
Niels Möllerff40b142018-04-09 08:49:14 +02003180 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003181 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003182 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003183 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003184 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003185
Mirko Bonadeif859e552018-05-30 15:31:29 +02003186 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003187 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3188 // Autmatic resize off when using simulcast.
3189 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3190 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3191
Florent Castelli66b38602019-07-10 16:57:57 +02003192 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003193 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003194 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003195 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003196
Niels Möller805a27e2019-01-21 12:21:27 +01003197 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003198
Florent Castelli66b38602019-07-10 16:57:57 +02003199 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003200 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3201 EXPECT_FALSE(vp8_settings.denoisingOn);
3202 // Resizing and frame dropping always off for screen sharing.
3203 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3204 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3205
Niels Möller805a27e2019-01-21 12:21:27 +01003206 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003207
3208 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3209 EXPECT_FALSE(vp8_settings.denoisingOn);
3210 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3211 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3212
Niels Möllerff40b142018-04-09 08:49:14 +02003213 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003214}
3215
deadbeef119760a2016-04-04 11:43:27 -07003216// Test that setting the same options doesn't result in the encoder being
3217// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003218TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003219 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003220 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003221
perkjfa10b552016-10-02 23:45:26 -07003222 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003223 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003224 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003225 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3226 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3227
Niels Möller805a27e2019-01-21 12:21:27 +01003228 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3229 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3230 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003231 // Expect 1 reconfigurations at this point from the initial configuration.
3232 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003233
3234 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003235 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003236 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3237
3238 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003239 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003240 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003241 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3242
Niels Möllerff40b142018-04-09 08:49:14 +02003243 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003244}
3245
eladalonf1841382017-06-12 01:16:46 -07003246class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003247 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003248 Vp9SettingsTest() : Vp9SettingsTest("") {}
3249 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003250 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003251 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003252 }
3253 virtual ~Vp9SettingsTest() {}
3254
3255 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003256 void TearDown() override {
3257 // Remove references to encoder_factory_ since this will be destroyed
3258 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003259 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003260 }
Erik Språng143cec12015-04-28 10:01:41 +02003261};
3262
3263TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003264 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003265 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003266 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003267
Peter Boström2feafdb2015-09-09 14:32:14 +02003268 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003269
Niels Möller805a27e2019-01-21 12:21:27 +01003270 webrtc::test::FrameForwarder frame_forwarder;
3271 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003272 channel_->SetSend(true);
3273
Niels Möller805a27e2019-01-21 12:21:27 +01003274 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003275
pbos4cba4eb2015-10-26 11:18:18 -07003276 webrtc::VideoCodecVP9 vp9_settings;
3277 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003278 EXPECT_TRUE(vp9_settings.denoisingOn)
3279 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003280
Niels Möller805a27e2019-01-21 12:21:27 +01003281 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003282
Erik Språng143cec12015-04-28 10:01:41 +02003283 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3284 EXPECT_FALSE(vp9_settings.denoisingOn);
3285 // Frame dropping always on for real time video.
3286 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3287
Niels Möller805a27e2019-01-21 12:21:27 +01003288 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003289
3290 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3291 EXPECT_TRUE(vp9_settings.denoisingOn);
3292 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3293
3294 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003295 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003296 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003297 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003298
Niels Möller805a27e2019-01-21 12:21:27 +01003299 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003300
3301 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3302 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003303 // Frame dropping always on for screen sharing.
3304 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003305
Niels Möller805a27e2019-01-21 12:21:27 +01003306 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003307
3308 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3309 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003310 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003311
Niels Möllerff40b142018-04-09 08:49:14 +02003312 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003313}
3314
Sergey Silkinf18072e2018-03-14 10:35:35 +01003315TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3316 cricket::VideoSendParameters parameters;
3317 parameters.codecs.push_back(GetEngineCodec("VP9"));
3318 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3319
3320 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3321
3322 FakeVideoSendStream* stream =
3323 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3324
3325 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003326
Niels Möller805a27e2019-01-21 12:21:27 +01003327 webrtc::test::FrameForwarder frame_forwarder;
3328 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003329 channel_->SetSend(true);
3330
Niels Möller805a27e2019-01-21 12:21:27 +01003331 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003332
3333 webrtc::VideoCodecVP9 vp9_settings;
3334 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3335
3336 const size_t kNumSpatialLayers = ssrcs.size();
3337 const size_t kNumTemporalLayers = 3;
3338 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3339 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3340
Niels Möllerff40b142018-04-09 08:49:14 +02003341 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003342}
3343
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003344TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3345 cricket::VideoSendParameters parameters;
3346 parameters.codecs.push_back(GetEngineCodec("VP9"));
3347 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3348
3349 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3350
3351 FakeVideoSendStream* stream =
3352 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3353
3354 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3355
3356 // Despite 3 ssrcs provided, single layer is used.
3357 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3358
3359 webrtc::test::FrameForwarder frame_forwarder;
3360 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3361 channel_->SetSend(true);
3362
3363 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3364
3365 webrtc::VideoCodecVP9 vp9_settings;
3366 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3367
3368 const size_t kNumSpatialLayers = ssrcs.size();
3369 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3370
3371 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3372}
3373
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003374TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3375 cricket::VideoSendParameters send_parameters;
3376 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3377 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3378
3379 const size_t kNumSpatialLayers = 3;
3380 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3381
3382 FakeVideoSendStream* stream =
3383 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3384
3385 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3386 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3387 ASSERT_TRUE(parameters.encodings[0].active);
3388 ASSERT_TRUE(parameters.encodings[1].active);
3389 ASSERT_TRUE(parameters.encodings[2].active);
3390 // Invert value to verify copying.
3391 parameters.encodings[1].active = false;
3392 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3393
3394 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3395
3396 // number_of_streams should be 1 since all spatial layers are sent on the
3397 // same SSRC. But encoding parameters of all layers is supposed to be copied
3398 // and stored in simulcast_layers[].
3399 EXPECT_EQ(1u, encoder_config.number_of_streams);
3400 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3401 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3402 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3403 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3404}
3405
Sergey Silkincf267052019-04-09 11:40:09 +02003406class Vp9SettingsTestWithFieldTrial
3407 : public Vp9SettingsTest,
3408 public ::testing::WithParamInterface<
3409 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003410 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003411 Vp9SettingsTestWithFieldTrial()
3412 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3413 num_spatial_layers_(::testing::get<1>(GetParam())),
3414 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003415 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003416
3417 void VerifySettings(int num_spatial_layers,
3418 int num_temporal_layers,
3419 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003420 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003421 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003422 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3423
3424 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3425
Niels Möller805a27e2019-01-21 12:21:27 +01003426 webrtc::test::FrameForwarder frame_forwarder;
3427 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003428 channel_->SetSend(true);
3429
Niels Möller805a27e2019-01-21 12:21:27 +01003430 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003431
3432 webrtc::VideoCodecVP9 vp9_settings;
3433 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3434 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3435 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003436 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003437
Niels Möllerff40b142018-04-09 08:49:14 +02003438 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003439 }
Sergey Silkincf267052019-04-09 11:40:09 +02003440
3441 const uint8_t num_spatial_layers_;
3442 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003443 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003444};
3445
Sergey Silkincf267052019-04-09 11:40:09 +02003446TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003447 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3448 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003449}
3450
Sergey Silkincf267052019-04-09 11:40:09 +02003451INSTANTIATE_TEST_SUITE_P(
Mirko Bonadei09f11952019-09-29 10:19:42 +02003452 All,
Sergey Silkincf267052019-04-09 11:40:09 +02003453 Vp9SettingsTestWithFieldTrial,
3454 ::testing::Values(
3455 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3456 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3457 1,
3458 1,
3459 webrtc::InterLayerPredMode::kOnKeyPic),
3460 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3461 2,
3462 3,
3463 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003464 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003465 1,
3466 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003467 webrtc::InterLayerPredMode::kOnKeyPic),
3468 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003469 1,
3470 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003471 webrtc::InterLayerPredMode::kOnKeyPic),
3472 std::make_tuple(
3473 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3474 1,
3475 1,
3476 webrtc::InterLayerPredMode::kOff),
3477 std::make_tuple(
3478 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3479 1,
3480 1,
3481 webrtc::InterLayerPredMode::kOn),
3482 std::make_tuple(
3483 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3484 1,
3485 1,
3486 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003487
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003488TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3489 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3490 ASSERT_EQ(1u, streams.size());
Elad Alon80f53b72019-10-11 16:19:43 +02003491 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps, streams[0].min_bitrate_bps);
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003492}
3493
3494TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003495 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003496 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003497 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3498 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3499 ASSERT_EQ(1u, streams.size());
3500 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3501}
3502
asapersson3c81a1a2017-06-14 05:52:21 -07003503TEST_F(WebRtcVideoChannelTest,
3504 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003505 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003506 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003507 "WebRTC-Video-BalancedDegradation/Disabled/");
3508 const bool kResolutionScalingEnabled = true;
3509 const bool kFpsScalingEnabled = false;
3510 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3511}
3512
3513TEST_F(WebRtcVideoChannelTest,
3514 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003515 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003516 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003517 "WebRTC-Video-BalancedDegradation/Enabled/");
3518 const bool kResolutionScalingEnabled = true;
3519 const bool kFpsScalingEnabled = true;
3520 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3521}
3522
eladalonf1841382017-06-12 01:16:46 -07003523TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003524 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003525}
3526
eladalonf1841382017-06-12 01:16:46 -07003527TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003528 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003529}
3530
Niels Möller3de32e62019-01-18 08:42:18 +01003531TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3532 TestCpuAdaptation(false, true);
3533}
3534
eladalonf1841382017-06-12 01:16:46 -07003535TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003536 TestCpuAdaptation(true, true);
3537}
3538
eladalonf1841382017-06-12 01:16:46 -07003539TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003540 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003541 cricket::VideoSendParameters parameters;
3542 parameters.codecs.push_back(codec);
3543
kthelgason2bc68642017-02-07 07:02:22 -08003544 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003545 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003546 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003547 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3548 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003549 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003550 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3551
3552 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003553 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003554
Per766ad3b2016-04-05 15:23:49 +02003555 ASSERT_TRUE(channel_->SetSend(true));
3556 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003557 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003558 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003559
3560 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3561 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003562
Niels Möllerdcc70292019-01-15 16:32:38 +01003563 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3564 // Dont' expect anything on framerate_scaling_enabled, since the default is
3565 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003566
Niels Möllerdcc70292019-01-15 16:32:38 +01003567 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003568 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003569 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003570 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003571 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3572 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003573 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003574
Niels Möllerdcc70292019-01-15 16:32:38 +01003575 // Switch back to the normal capturer. Expect resolution scaling to be
3576 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003577 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3578 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003579 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3580 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003581 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003582
Niels Möllerff40b142018-04-09 08:49:14 +02003583 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003584}
3585
asapersson3c81a1a2017-06-14 05:52:21 -07003586// TODO(asapersson): Remove this test when the balanced field trial is removed.
3587void WebRtcVideoChannelTest::TestDegradationPreference(
3588 bool resolution_scaling_enabled,
3589 bool fps_scaling_enabled) {
3590 cricket::VideoCodec codec = GetEngineCodec("VP8");
3591 cricket::VideoSendParameters parameters;
3592 parameters.codecs.push_back(codec);
3593
3594 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003595 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003596 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003597 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3598 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003599 channel_->OnReadyToSend(true);
3600
3601 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3602
3603 AddSendStream();
3604
Niels Möller805a27e2019-01-21 12:21:27 +01003605 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003606 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003607 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003608
3609 EXPECT_TRUE(channel_->SetSend(true));
3610
3611 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3612 EXPECT_EQ(resolution_scaling_enabled,
3613 send_stream->resolution_scaling_enabled());
3614 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3615
Niels Möllerff40b142018-04-09 08:49:14 +02003616 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003617}
3618
eladalonf1841382017-06-12 01:16:46 -07003619void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3620 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003621 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003622 cricket::VideoSendParameters parameters;
3623 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003624
kthelgason2bc68642017-02-07 07:02:22 -08003625 MediaConfig media_config = GetMediaConfig();
3626 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003627 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003628 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003629 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003630 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3631 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003632 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003633
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003634 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003635
3636 AddSendStream();
3637
Niels Möller805a27e2019-01-21 12:21:27 +01003638 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003639 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003640 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003641 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003642
3643 EXPECT_TRUE(channel_->SetSend(true));
3644
solenberge5269742015-09-08 05:13:22 -07003645 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003646
sprangc5d62e22017-04-02 23:53:04 -07003647 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003648 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003649 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003650 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003651 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3652 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3653 } else {
3654 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3655 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3656 }
Niels Möllerff40b142018-04-09 08:49:14 +02003657 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003658}
3659
eladalonf1841382017-06-12 01:16:46 -07003660TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003661 // Start at last timestamp to verify that wraparounds are estimated correctly.
3662 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3663 static const int64_t kInitialNtpTimeMs = 1247891230;
3664 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003665 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003666
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003667 FakeVideoReceiveStream* stream = AddRecvStream();
3668 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003669 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003670
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003671 webrtc::VideoFrame video_frame =
3672 webrtc::VideoFrame::Builder()
3673 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3674 .set_timestamp_rtp(kInitialTimestamp)
3675 .set_timestamp_us(0)
3676 .set_rotation(webrtc::kVideoRotation_0)
3677 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003678 // Initial NTP time is not available on the first frame, but should still be
3679 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003680 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003681
3682 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003683
3684 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3685 // triggers a constant-overflow warning, hence we're calculating it explicitly
3686 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003687 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003688 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3689 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003690 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003691
3692 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003693
3694 // Verify that NTP time has been correctly deduced.
3695 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003696 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003697 ASSERT_EQ(1u, info.receivers.size());
3698 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003699}
3700
eladalonf1841382017-06-12 01:16:46 -07003701TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003702 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003703 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003704
3705 VideoCodec codec;
3706 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003707 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003708
3709 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003710 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3711 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003712 FakeVideoSendStream* stream = AddSendStream(
3713 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003714 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003715
3716 // Make sure NACK and FEC are enabled on the correct payload types.
3717 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003718 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3719 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003720
3721 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3722 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003723 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003724 // TODO(juberti): Check RTCP, PLI, TMMBR.
3725}
3726
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003727TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3728 cricket::VideoSendParameters parameters;
3729 parameters.codecs.push_back(GetEngineCodec("VP8"));
3730 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3731
3732 FakeVideoSendStream* stream = AddSendStream();
3733 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3734 EXPECT_FALSE(config.rtp.raw_payload);
3735}
3736
3737TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3738 cricket::VideoSendParameters parameters;
3739 parameters.codecs.push_back(GetEngineCodec("VP8"));
3740 parameters.codecs.back().packetization = kPacketizationParamRaw;
3741 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3742
3743 FakeVideoSendStream* stream = AddSendStream();
3744 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3745 EXPECT_TRUE(config.rtp.raw_payload);
3746}
3747
brandtr31bd2242017-05-19 05:47:46 -07003748// The following four tests ensures that FlexFEC is not activated by default
3749// when the field trials are not enabled.
3750// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3751// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003752TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003753 FakeVideoSendStream* stream = AddSendStream();
3754 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3755
brandtr3d200bd2017-01-16 06:59:19 -08003756 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003757 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3758 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003759}
3760
eladalonf1841382017-06-12 01:16:46 -07003761TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003762 FakeVideoSendStream* stream = AddSendStream(
3763 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3764 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3765
brandtr3d200bd2017-01-16 06:59:19 -08003766 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003767 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3768 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3769}
3770
Yves Gerey665174f2018-06-19 15:03:05 +02003771TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003772 AddRecvStream();
3773
3774 const std::vector<FakeFlexfecReceiveStream*>& streams =
3775 fake_call_->GetFlexfecReceiveStreams();
3776 EXPECT_TRUE(streams.empty());
3777}
3778
eladalonf1841382017-06-12 01:16:46 -07003779TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003780 AddRecvStream(
3781 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3782
3783 const std::vector<FakeFlexfecReceiveStream*>& streams =
3784 fake_call_->GetFlexfecReceiveStreams();
3785 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003786}
3787
3788// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3789// tests that use this test fixture into the corresponding "non-field trial"
3790// tests.
eladalonf1841382017-06-12 01:16:46 -07003791class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003792 public:
eladalonf1841382017-06-12 01:16:46 -07003793 WebRtcVideoChannelFlexfecRecvTest()
3794 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003795};
3796
eladalonf1841382017-06-12 01:16:46 -07003797TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003798 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3799 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3800 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3801}
3802
eladalonf1841382017-06-12 01:16:46 -07003803TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003804 AddRecvStream();
3805
3806 const std::vector<FakeFlexfecReceiveStream*>& streams =
3807 fake_call_->GetFlexfecReceiveStreams();
3808 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003809
3810 const std::vector<FakeVideoReceiveStream*>& video_streams =
3811 fake_call_->GetVideoReceiveStreams();
3812 ASSERT_EQ(1U, video_streams.size());
3813 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3814 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3815 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003816}
3817
eladalonf1841382017-06-12 01:16:46 -07003818TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003819 AddRecvStream(
3820 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3821
3822 const std::vector<FakeFlexfecReceiveStream*>& streams =
3823 fake_call_->GetFlexfecReceiveStreams();
3824 ASSERT_EQ(1U, streams.size());
3825 const FakeFlexfecReceiveStream* stream = streams.front();
3826 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3827 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3828 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3829 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3830 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003831
3832 const std::vector<FakeVideoReceiveStream*>& video_streams =
3833 fake_call_->GetVideoReceiveStreams();
3834 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003835 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3836 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003837 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003838 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003839 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003840}
3841
eladalonf1841382017-06-12 01:16:46 -07003842TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003843 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3844 cricket::VideoRecvParameters recv_parameters;
3845 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3846 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3847
3848 AddRecvStream(
3849 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3850 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003851 const std::vector<FakeVideoReceiveStream*>& video_streams =
3852 fake_call_->GetVideoReceiveStreams();
3853 ASSERT_EQ(1U, video_streams.size());
3854 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3855 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3856 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003857
3858 // Enable FlexFEC.
3859 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3860 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3861 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3862 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3863 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3864 << "Enabling FlexFEC should not create VideoReceiveStream.";
3865 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3866 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003867 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3868 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003869}
3870
eladalonf1841382017-06-12 01:16:46 -07003871TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003872 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3873 cricket::VideoRecvParameters recv_parameters;
3874 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3875 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3876 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3877
3878 AddRecvStream(
3879 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3880 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003881 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003882 const std::vector<FakeVideoReceiveStream*>& video_streams =
3883 fake_call_->GetVideoReceiveStreams();
3884 ASSERT_EQ(1U, video_streams.size());
3885 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3886 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3887 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003888
3889 // Disable FlexFEC.
3890 recv_parameters.codecs.clear();
3891 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3892 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3893 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3894 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3895 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3896 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3897 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3898 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003899 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3900 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003901}
3902
Steve Anton2d2bbb12019-08-07 09:57:59 -07003903TEST_F(WebRtcVideoChannelFlexfecRecvTest, DuplicateFlexfecCodecIsDropped) {
3904 constexpr int kUnusedPayloadType1 = 127;
3905
3906 cricket::VideoRecvParameters recv_parameters;
3907 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3908 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3909 cricket::VideoCodec duplicate = GetEngineCodec("flexfec-03");
3910 duplicate.id = kUnusedPayloadType1;
3911 recv_parameters.codecs.push_back(duplicate);
3912 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3913
3914 AddRecvStream(
3915 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3916
3917 const std::vector<FakeFlexfecReceiveStream*>& streams =
3918 fake_call_->GetFlexfecReceiveStreams();
3919 ASSERT_EQ(1U, streams.size());
3920 const FakeFlexfecReceiveStream* stream = streams.front();
3921 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3922 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3923}
3924
brandtr31bd2242017-05-19 05:47:46 -07003925// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3926// tests that use this test fixture into the corresponding "non-field trial"
3927// tests.
eladalonf1841382017-06-12 01:16:46 -07003928class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003929 public:
eladalonf1841382017-06-12 01:16:46 -07003930 WebRtcVideoChannelFlexfecSendRecvTest()
3931 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003932 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3933 }
3934};
3935
Yves Gerey665174f2018-06-19 15:03:05 +02003936TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003937 FakeVideoSendStream* stream = AddSendStream();
3938 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3939
brandtr3d200bd2017-01-16 06:59:19 -08003940 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3941 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3942 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003943}
3944
eladalonf1841382017-06-12 01:16:46 -07003945TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003946 FakeVideoSendStream* stream = AddSendStream(
3947 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3948 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3949
brandtr3d200bd2017-01-16 06:59:19 -08003950 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3951 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3952 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3953 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003954}
3955
eladalonf1841382017-06-12 01:16:46 -07003956TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003957 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003958 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003959 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003960
3961 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003962 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003963
brandtrb5f2c3f2016-10-04 23:28:39 -07003964 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3965 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003966}
3967
eladalonf1841382017-06-12 01:16:46 -07003968TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003969 cricket::VideoSendParameters parameters;
3970 parameters.codecs.push_back(GetEngineCodec("VP8"));
3971 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3972
3973 FakeVideoSendStream* stream = AddSendStream();
3974 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3975
brandtr3d200bd2017-01-16 06:59:19 -08003976 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003977}
3978
eladalonf1841382017-06-12 01:16:46 -07003979TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003980 AddRecvStream(
3981 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003982
3983 cricket::VideoRecvParameters recv_parameters;
3984 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3985 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3986 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003987
3988 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3989 fake_call_->GetFlexfecReceiveStreams();
3990 ASSERT_EQ(1U, flexfec_streams.size());
3991 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3992 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3993 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003994 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003995 flexfec_stream_config.payload_type);
3996 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3997 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3998 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3999 const std::vector<FakeVideoReceiveStream*>& video_streams =
4000 fake_call_->GetVideoReceiveStreams();
4001 const FakeVideoReceiveStream* video_stream = video_streams.front();
4002 const webrtc::VideoReceiveStream::Config& video_stream_config =
4003 video_stream->GetConfig();
4004 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
4005 flexfec_stream_config.local_ssrc);
4006 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
4007 EXPECT_EQ(video_stream_config.rtcp_send_transport,
4008 flexfec_stream_config.rtcp_send_transport);
4009 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
4010 // spec-compliant way.
4011 EXPECT_EQ(video_stream_config.rtp.transport_cc,
4012 flexfec_stream_config.transport_cc);
4013 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
4014 EXPECT_EQ(video_stream_config.rtp.extensions,
4015 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08004016}
4017
brandtr31bd2242017-05-19 05:47:46 -07004018// We should not send FlexFEC, even if we advertise it, unless the right
4019// field trial is set.
4020// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07004021TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004022 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
4023 cricket::VideoSendParameters parameters;
4024 parameters.codecs.push_back(GetEngineCodec("VP8"));
4025 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4026 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4027
4028 FakeVideoSendStream* stream = AddSendStream();
4029 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4030
4031 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004032 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07004033 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
4034}
4035
eladalonf1841382017-06-12 01:16:46 -07004036TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004037 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
4038 cricket::VideoSendParameters parameters;
4039 parameters.codecs.push_back(GetEngineCodec("VP8"));
4040 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4041 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4042
4043 FakeVideoSendStream* stream = AddSendStream(
4044 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4045 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4046
4047 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004048 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07004049 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
4050}
4051
eladalonf1841382017-06-12 01:16:46 -07004052TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004053 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08004054 const int kUnusedPayloadType = 127;
4055 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
4056
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004057 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004058 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004059 parameters.codecs.push_back(rtx_codec);
4060 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004061 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004062}
4063
eladalonf1841382017-06-12 01:16:46 -07004064TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004065 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08004066 const int kUnusedPayloadType1 = 126;
4067 const int kUnusedPayloadType2 = 127;
4068 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4069 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4070 {
4071 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4072 kUnusedPayloadType1, GetEngineCodec("VP8").id);
4073 cricket::VideoSendParameters parameters;
4074 parameters.codecs.push_back(GetEngineCodec("VP8"));
4075 parameters.codecs.push_back(rtx_codec);
4076 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4077 }
4078 {
4079 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4080 kUnusedPayloadType1, kUnusedPayloadType2);
4081 cricket::VideoSendParameters parameters;
4082 parameters.codecs.push_back(GetEngineCodec("VP8"));
4083 parameters.codecs.push_back(rtx_codec);
4084 EXPECT_FALSE(channel_->SetSendParameters(parameters))
4085 << "RTX without matching video codec should be rejected.";
4086 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004087}
4088
eladalonf1841382017-06-12 01:16:46 -07004089TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004090 const int kUnusedPayloadType1 = 126;
4091 const int kUnusedPayloadType2 = 127;
4092 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4093 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4094
4095 // SSRCs for RTX.
4096 cricket::StreamParams params =
4097 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4098 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4099 AddSendStream(params);
4100
4101 // Original payload type for RTX.
4102 cricket::VideoSendParameters parameters;
4103 parameters.codecs.push_back(GetEngineCodec("VP8"));
4104 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4105 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4106 parameters.codecs.push_back(rtx_codec);
4107 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4108 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4109 const webrtc::VideoSendStream::Config& config_before =
4110 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4111 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4112 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4113 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4114
4115 // Change payload type for RTX.
4116 parameters.codecs[1].id = kUnusedPayloadType2;
4117 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4118 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4119 const webrtc::VideoSendStream::Config& config_after =
4120 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4121 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4122 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4123 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4124}
4125
eladalonf1841382017-06-12 01:16:46 -07004126TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004127 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004128 parameters.codecs.push_back(GetEngineCodec("VP8"));
4129 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004130 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004131
4132 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004133 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004134
magjed509e4fe2016-11-18 01:34:11 -08004135 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004136
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004137 parameters.codecs.pop_back();
4138 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004139 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004140 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004141 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004142 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004143 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4144}
4145
eladalonf1841382017-06-12 01:16:46 -07004146TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004147 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004148 cricket::VideoSendParameters parameters;
4149 parameters.codecs.push_back(GetEngineCodec("VP8"));
4150 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4151 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4152
4153 FakeVideoSendStream* stream = AddSendStream(
4154 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4155 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4156
brandtr3d200bd2017-01-16 06:59:19 -08004157 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4158 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004159 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4160 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4161
4162 parameters.codecs.pop_back();
4163 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4164 stream = fake_call_->GetVideoSendStreams()[0];
4165 ASSERT_TRUE(stream != nullptr);
4166 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004167 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004168 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004169}
4170
eladalonf1841382017-06-12 01:16:46 -07004171TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004172 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004173 cricket::VideoCodec codec(100, "VP8");
4174 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4175 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004176
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004177 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004178 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004179
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004180 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004181 webrtc::test::FrameForwarder frame_forwarder;
4182 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004183
4184 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004185 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004186
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004187 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004188 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4189 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004190 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004191 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004192 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004193 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004194}
4195
eladalonf1841382017-06-12 01:16:46 -07004196TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004197 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4198 200000);
4199}
4200
eladalonf1841382017-06-12 01:16:46 -07004201TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004202 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4203 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4204 ASSERT_EQ(1u, streams.size());
4205 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4206}
4207
eladalonf1841382017-06-12 01:16:46 -07004208TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004209 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004210 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004211}
4212
eladalonf1841382017-06-12 01:16:46 -07004213TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004214 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004215}
4216
eladalonf1841382017-06-12 01:16:46 -07004217TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004218 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4219 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4220 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004221}
4222
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004223// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4224// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004225TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004226 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4227 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4228 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4229 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004230 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004231 ExpectSetBitrateParameters(100000, 200000, 400000);
4232 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4233 // Since the codec isn't changing, start_bitrate_bps should be -1.
4234 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004235
4236 // Decrease max_bandwidth_bps.
4237 send_parameters_.max_bandwidth_bps = 350000;
4238 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004239
4240 // Now try again with the values flipped around.
4241 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4242 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004243 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004244 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004245
4246 // If we change the codec max, max_bandwidth_bps should still apply.
4247 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004248 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004249 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004250}
4251
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004252// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4253// are present in the same send parameters, the settings are combined correctly.
4254TEST_F(WebRtcVideoChannelTest,
4255 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4256 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4257 // Transport.
4258 webrtc::MediaTransportSettings settings;
4259 settings.is_caller = true;
4260 webrtc::FakeMediaTransport fake_media_transport(settings);
4261 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4262 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004263 channel_->SetInterface(network_interface.get(),
4264 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004265
4266 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4267 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4268 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4269 send_parameters_.max_bandwidth_bps = 400000;
4270 {
4271 // We expect max_bandwidth_bps to take priority, if set.
4272 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4273 ASSERT_EQ(1u,
4274 fake_media_transport.target_rate_constraints_in_order().size());
4275 const webrtc::MediaTransportTargetRateConstraints& constraint =
4276 fake_media_transport.target_rate_constraints_in_order()[0];
4277 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4278 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4279 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4280 }
4281
4282 {
4283 // Decrease max_bandwidth_bps.
4284 send_parameters_.max_bandwidth_bps = 350000;
4285 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4286 ASSERT_EQ(2u,
4287 fake_media_transport.target_rate_constraints_in_order().size());
4288 const webrtc::MediaTransportTargetRateConstraints& constraint =
4289 fake_media_transport.target_rate_constraints_in_order()[1];
4290
4291 // Since the codec isn't changing, start_bitrate_bps should be 0.
4292 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4293 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4294 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4295 }
4296
4297 {
4298 // Now try again with the values flipped around.
4299 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4300 send_parameters_.max_bandwidth_bps = 300000;
4301 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4302 ASSERT_EQ(3u,
4303 fake_media_transport.target_rate_constraints_in_order().size());
4304 const webrtc::MediaTransportTargetRateConstraints& constraint =
4305 fake_media_transport.target_rate_constraints_in_order()[2];
4306
4307 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4308 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4309 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4310 }
4311
4312 {
4313 // Now try again with the values flipped around.
4314 // If we change the codec max, max_bandwidth_bps should still apply.
4315 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4316 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4317 ASSERT_EQ(4u,
4318 fake_media_transport.target_rate_constraints_in_order().size());
4319 const webrtc::MediaTransportTargetRateConstraints& constraint =
4320 fake_media_transport.target_rate_constraints_in_order()[3];
4321
4322 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4323 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4324 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4325 }
4326}
4327
Yves Gerey665174f2018-06-19 15:03:05 +02004328TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004329 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4330 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004331 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004332 // Setting max bitrate should keep previous min bitrate.
4333 // Setting max bitrate should not reset start bitrate.
4334 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004335 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004336}
4337
eladalonf1841382017-06-12 01:16:46 -07004338TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004339 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004340 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004341 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004342 // -1 means to disable max bitrate (set infinite).
4343 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004344 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004345 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004346}
4347
eladalonf1841382017-06-12 01:16:46 -07004348TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004349 send_parameters_.max_bandwidth_bps = 99999;
4350 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004351 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004352 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004353 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4354 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4355 stream->GetVideoStreams()[0].max_bitrate_bps);
4356
4357 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004358 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004359 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4360 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004361 stream->GetVideoStreams()[0].max_bitrate_bps);
4362}
4363
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004364// Tests that when the codec specific max bitrate and VideoSendParameters
4365// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4366// appropriately.
4367TEST_F(WebRtcVideoChannelTest,
4368 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4369 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4370 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4371 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4372 send_parameters_.max_bandwidth_bps = -1;
4373 AddSendStream();
4374 ExpectSetMaxBitrate(300000);
4375 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4376
4377 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4378 ASSERT_EQ(1u, video_send_streams.size());
4379 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4380 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4381 // First the max bitrate is set based upon the codec param.
4382 EXPECT_EQ(300000,
4383 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4384
4385 // The VideoSendParameters max bitrate overrides the codec's.
4386 send_parameters_.max_bandwidth_bps = 500000;
4387 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4388 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4389 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4390 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4391}
4392
4393// Tests that when the codec specific max bitrate and RtpParameters
4394// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4395// appropriately.
4396TEST_F(WebRtcVideoChannelTest,
4397 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4398 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4399 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4400 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4401 send_parameters_.max_bandwidth_bps = -1;
4402 AddSendStream();
4403 ExpectSetMaxBitrate(300000);
4404 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4405
4406 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4407 ASSERT_EQ(1u, video_send_streams.size());
4408 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4409 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4410 // First the max bitrate is set based upon the codec param.
4411 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4412
4413 // The RtpParameter max bitrate overrides the codec's.
4414 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4415 ASSERT_EQ(1u, parameters.encodings.size());
4416 parameters.encodings[0].max_bitrate_bps = 500000;
4417 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4418 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4419 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4420 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4421}
4422
Åsa Persson55659812018-06-18 17:51:32 +02004423TEST_F(WebRtcVideoChannelTest,
4424 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4425 send_parameters_.max_bandwidth_bps = 99999;
4426 FakeVideoSendStream* stream = AddSendStream();
4427 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4428 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4429 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4430 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4431 stream->GetVideoStreams()[0].max_bitrate_bps);
4432
4433 // Get and set the rtp encoding parameters.
4434 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4435 EXPECT_EQ(1u, parameters.encodings.size());
4436
4437 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4438 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4439 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4440 stream->GetVideoStreams()[0].max_bitrate_bps);
4441
4442 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4443 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4444 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4445 stream->GetVideoStreams()[0].max_bitrate_bps);
4446}
4447
eladalonf1841382017-06-12 01:16:46 -07004448TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004449 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004450 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004451 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004452 channel_->SetSend(true);
4453
4454 FakeVideoSendStream* stream = AddSendStream();
4455
Niels Möller805a27e2019-01-21 12:21:27 +01004456 webrtc::test::FrameForwarder frame_forwarder;
4457 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004458
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004459 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4460 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4461 EXPECT_GT(initial_max_bitrate_bps, 0);
4462
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004463 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4464 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004465 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004466 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004467 streams = stream->GetVideoStreams();
4468 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004469 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004470}
4471
eladalonf1841382017-06-12 01:16:46 -07004472TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004473 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004474 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004475 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004476 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004477 channel_->SetSend(true);
4478
4479 FakeVideoSendStream* stream = AddSendStream(
4480 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4481
4482 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004483 webrtc::test::FrameForwarder frame_forwarder;
4484 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4485 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004486
4487 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4488 ASSERT_GT(streams.size(), 1u)
4489 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004490 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004491 EXPECT_GT(initial_max_bitrate_bps, 0);
4492
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004493 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4494 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004495 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004496 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004497 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004498 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004499 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4500
Niels Möllerff40b142018-04-09 08:49:14 +02004501 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004502}
4503
eladalonf1841382017-06-12 01:16:46 -07004504TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004505 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004506 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004507 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004508 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4509 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004510 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004511 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004512
4513 VideoCodec codec;
4514 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4515 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4516}
4517
eladalonf1841382017-06-12 01:16:46 -07004518TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004519 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004520 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004521 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004522 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004523 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004524 parameters.codecs[0].id = kIncorrectPayloads[i];
4525 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004526 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004527 }
4528}
4529
eladalonf1841382017-06-12 01:16:46 -07004530TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004531 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004532 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004533 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004534 parameters.codecs[0].id = payload_type;
4535 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004536 << "Payload type '" << payload_type << "' rejected.";
4537 }
4538}
4539
deadbeef67cf2c12016-04-13 10:07:16 -07004540// Test that setting the a different set of codecs but with an identical front
4541// codec doesn't result in the stream being recreated.
4542// This may happen when a subsequent negotiation includes fewer codecs, as a
4543// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004544TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004545 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4546 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004547 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4548 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004549 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4550
4551 AddSendStream();
4552 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4553
4554 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004555 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004556 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4557 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4558}
4559
eladalonf1841382017-06-12 01:16:46 -07004560TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004561 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004562 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004563 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004564}
4565
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004566// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004567TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004568 const int kUnusedPayloadType1 = 126;
4569 const int kUnusedPayloadType2 = 127;
4570 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4571 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4572
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004573 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004574 parameters.codecs.push_back(GetEngineCodec("VP8"));
4575 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004576 parameters.codecs.push_back(rtx_codec);
4577 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004578 << "RTX codec without associated payload should be rejected.";
4579
magjed509e4fe2016-11-18 01:34:11 -08004580 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004581 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004582 << "RTX codec with invalid associated payload type should be rejected.";
4583
magjed509e4fe2016-11-18 01:34:11 -08004584 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004585 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004586
magjed509e4fe2016-11-18 01:34:11 -08004587 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004588 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004589 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004590
Yves Gerey665174f2018-06-19 15:03:05 +02004591 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4592 << "RTX codec with another RTX as associated payload type should be "
4593 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004594}
4595
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004596TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4597 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4598 vp8_codec.packetization = kPacketizationParamRaw;
4599
4600 cricket::VideoRecvParameters parameters;
4601 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4602 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4603
4604 const cricket::StreamParams params =
4605 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4606 AddRecvStream(params);
4607 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4608
4609 const webrtc::VideoReceiveStream::Config& config =
4610 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4611 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4612 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4613}
4614
4615TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4616 cricket::VideoRecvParameters parameters;
4617 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4618 parameters.codecs.back().packetization = kPacketizationParamRaw;
4619 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4620
4621 const cricket::StreamParams params =
4622 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4623 AddRecvStream(params);
4624 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4625 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4626
4627 parameters.codecs.back().packetization.reset();
4628 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4629 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4630}
4631
Steve Anton2d2bbb12019-08-07 09:57:59 -07004632TEST_F(WebRtcVideoChannelTest, DuplicateUlpfecCodecIsDropped) {
4633 constexpr int kFirstUlpfecPayloadType = 126;
4634 constexpr int kSecondUlpfecPayloadType = 127;
4635
4636 cricket::VideoRecvParameters parameters;
4637 parameters.codecs.push_back(GetEngineCodec("VP8"));
4638 parameters.codecs.push_back(
4639 cricket::VideoCodec(kFirstUlpfecPayloadType, cricket::kUlpfecCodecName));
4640 parameters.codecs.push_back(
4641 cricket::VideoCodec(kSecondUlpfecPayloadType, cricket::kUlpfecCodecName));
4642 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4643
4644 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4645 EXPECT_EQ(kFirstUlpfecPayloadType,
4646 recv_stream->GetConfig().rtp.ulpfec_payload_type);
4647}
4648
4649TEST_F(WebRtcVideoChannelTest, DuplicateRedCodecIsDropped) {
4650 constexpr int kFirstRedPayloadType = 126;
4651 constexpr int kSecondRedPayloadType = 127;
4652
4653 cricket::VideoRecvParameters parameters;
4654 parameters.codecs.push_back(GetEngineCodec("VP8"));
4655 parameters.codecs.push_back(
4656 cricket::VideoCodec(kFirstRedPayloadType, cricket::kRedCodecName));
4657 parameters.codecs.push_back(
4658 cricket::VideoCodec(kSecondRedPayloadType, cricket::kRedCodecName));
4659 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4660
4661 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4662 EXPECT_EQ(kFirstRedPayloadType,
4663 recv_stream->GetConfig().rtp.red_payload_type);
4664}
4665
eladalonf1841382017-06-12 01:16:46 -07004666TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004667 const int kUnusedPayloadType1 = 126;
4668 const int kUnusedPayloadType2 = 127;
4669 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4670 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4671
4672 // SSRCs for RTX.
4673 cricket::StreamParams params =
4674 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4675 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4676 AddRecvStream(params);
4677
4678 // Original payload type for RTX.
4679 cricket::VideoRecvParameters parameters;
4680 parameters.codecs.push_back(GetEngineCodec("VP8"));
4681 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4682 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4683 parameters.codecs.push_back(rtx_codec);
4684 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4685 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4686 const webrtc::VideoReceiveStream::Config& config_before =
4687 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004688 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4689 const int* payload_type_before = FindKeyByValue(
4690 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4691 ASSERT_NE(payload_type_before, nullptr);
4692 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004693 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4694
4695 // Change payload type for RTX.
4696 parameters.codecs[1].id = kUnusedPayloadType2;
4697 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4698 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4699 const webrtc::VideoReceiveStream::Config& config_after =
4700 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004701 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4702 const int* payload_type_after = FindKeyByValue(
4703 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4704 ASSERT_NE(payload_type_after, nullptr);
4705 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004706 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4707}
4708
eladalonf1841382017-06-12 01:16:46 -07004709TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004710 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004711 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004712 parameters.codecs[0].id = 99;
4713 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004714}
4715
eladalonf1841382017-06-12 01:16:46 -07004716TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004717 cricket::VideoRecvParameters parameters;
4718 parameters.codecs = engine_.codecs();
4719 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004720
4721 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004722 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004723 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004724 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004725}
4726
eladalonf1841382017-06-12 01:16:46 -07004727TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004728 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004729 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004730 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004731 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004732}
4733
eladalonf1841382017-06-12 01:16:46 -07004734TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004735 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004736 parameters.codecs.push_back(GetEngineCodec("VP8"));
4737 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004738 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004739}
4740
eladalonf1841382017-06-12 01:16:46 -07004741TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004742 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004743 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4744 send_parameters.codecs.push_back(GetEngineCodec("red"));
4745 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004746 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004747
4748 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004749
magjed509e4fe2016-11-18 01:34:11 -08004750 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004751 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004752
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004753 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004754 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004755 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004756 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004757 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004758 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004759 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4760}
4761
eladalonf1841382017-06-12 01:16:46 -07004762TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004763 AddRecvStream(
4764 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004765 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004766 fake_call_->GetFlexfecReceiveStreams();
4767
4768 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004769 const FakeFlexfecReceiveStream* stream = streams.front();
4770 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4771 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4772 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4773 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004774
4775 cricket::VideoRecvParameters recv_parameters;
4776 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4777 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4778 EXPECT_TRUE(streams.empty())
4779 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004780}
4781
eladalonf1841382017-06-12 01:16:46 -07004782TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004783 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004784 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004785 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004786
4787 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004788 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4789 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4790 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004791 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4792 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004793 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004794 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004795 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004796 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004797
4798 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004799 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4800 send_parameters.codecs.push_back(GetEngineCodec("red"));
4801 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004802 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4803 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004804 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004805 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004806 << "ULPFEC should be enabled on the receive stream.";
4807}
4808
eladalonf1841382017-06-12 01:16:46 -07004809TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004810 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004811 AddRecvStream(
4812 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004813 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004814 fake_call_->GetFlexfecReceiveStreams();
4815
4816 cricket::VideoRecvParameters recv_parameters;
4817 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4818 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4819 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4820 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004821 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004822 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004823 stream_with_recv_params->GetConfig().payload_type);
4824 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004825 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004826 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004827 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004828 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004829
4830 cricket::VideoSendParameters send_parameters;
4831 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4832 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4833 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4834 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004835 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004836 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004837 stream_with_send_params->GetConfig().payload_type);
4838 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004839 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004840 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004841 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004842 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004843}
4844
eladalonf1841382017-06-12 01:16:46 -07004845TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004846 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004847 parameters.codecs.push_back(GetEngineCodec("VP8"));
4848 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004849 parameters.codecs[1].id = parameters.codecs[0].id;
4850 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004851}
4852
eladalonf1841382017-06-12 01:16:46 -07004853TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004854 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004855 cricket::VideoRecvParameters parameters;
4856 parameters.codecs.push_back(GetEngineCodec("VP8"));
4857 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4858 parameters.codecs[1].id = parameters.codecs[0].id;
4859 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4860}
4861
eladalonf1841382017-06-12 01:16:46 -07004862TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004863 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004864 parameters.codecs.push_back(GetEngineCodec("VP8"));
4865 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004866 parameters.codecs[1].id = parameters.codecs[0].id;
4867 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004868}
4869
eladalonf1841382017-06-12 01:16:46 -07004870TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004871 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004872 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004873 parameters.codecs.push_back(GetEngineCodec("VP8"));
4874 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004875 parameters.codecs[1].id += 1;
4876 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004877}
4878
deadbeef67cf2c12016-04-13 10:07:16 -07004879// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004880// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004881TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004882 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004883 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004884 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4885 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004886 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004887
4888 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4889 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4890
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004891 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004892 parameters2.codecs.push_back(GetEngineCodec("red"));
4893 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004894 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004895 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4896}
4897
eladalonf1841382017-06-12 01:16:46 -07004898TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004899 EXPECT_FALSE(AddSendStream()->IsSending());
4900}
4901
eladalonf1841382017-06-12 01:16:46 -07004902TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004903 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004904}
4905
eladalonf1841382017-06-12 01:16:46 -07004906TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004907 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004908 EXPECT_FALSE(stream->IsSending());
4909
4910 // false->true
4911 EXPECT_TRUE(channel_->SetSend(true));
4912 EXPECT_TRUE(stream->IsSending());
4913 // true->true
4914 EXPECT_TRUE(channel_->SetSend(true));
4915 EXPECT_TRUE(stream->IsSending());
4916 // true->false
4917 EXPECT_TRUE(channel_->SetSend(false));
4918 EXPECT_FALSE(stream->IsSending());
4919 // false->false
4920 EXPECT_TRUE(channel_->SetSend(false));
4921 EXPECT_FALSE(stream->IsSending());
4922
4923 EXPECT_TRUE(channel_->SetSend(true));
4924 FakeVideoSendStream* new_stream = AddSendStream();
4925 EXPECT_TRUE(new_stream->IsSending())
4926 << "Send stream created after SetSend(true) not sending initially.";
4927}
4928
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004929// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004930TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004931 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004932 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004933 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004934 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004935 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004936
Sebastian Jansson84848f22018-11-16 10:40:36 +01004937 channel.reset(
4938 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004939 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4940 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004941 channel->SetInterface(network_interface.get(),
4942 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004943 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004944 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004945
Tim Haloun648d28a2018-10-18 16:52:22 -07004946 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4947 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004948 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004949 channel.reset(
4950 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004951 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4952 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004953 channel->SetInterface(network_interface.get(),
4954 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004955 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4956
4957 // Create a send stream to configure
4958 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4959 parameters = channel->GetRtpSendParameters(kSsrc);
4960 ASSERT_FALSE(parameters.encodings.empty());
4961
4962 // Various priorities map to various dscp values.
4963 parameters.encodings[0].network_priority = 4.0;
4964 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004965 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004966 parameters.encodings[0].network_priority = 0.5;
4967 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4968 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4969
4970 // A bad priority does not change the dscp value.
4971 parameters.encodings[0].network_priority = 0.0;
4972 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4973 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004974
Tim Haloun6ca98362018-09-17 17:06:08 -07004975 // Packets should also self-identify their dscp in PacketOptions.
4976 const uint8_t kData[10] = {0};
4977 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4978 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004979 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004980
nisse51542be2016-02-12 02:27:06 -08004981 // Verify that setting the option to false resets the
4982 // DiffServCodePoint.
4983 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004984 channel.reset(
4985 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004986 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4987 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004988 channel->SetInterface(network_interface.get(),
4989 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004990 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004991}
4992
deadbeef13871492015-12-09 12:37:51 -08004993// This test verifies that the RTCP reduced size mode is properly applied to
4994// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004995TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004996 // Create stream, expecting that default mode is "compound".
4997 FakeVideoSendStream* stream1 = AddSendStream();
4998 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004999 webrtc::RtpParameters rtp_parameters =
5000 channel_->GetRtpSendParameters(last_ssrc_);
5001 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08005002
5003 // Now enable reduced size mode.
5004 send_parameters_.rtcp.reduced_size = true;
5005 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
5006 stream1 = fake_call_->GetVideoSendStreams()[0];
5007 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02005008 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5009 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08005010
5011 // Create a new stream and ensure it picks up the reduced size mode.
5012 FakeVideoSendStream* stream2 = AddSendStream();
5013 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
5014}
5015
5016// This test verifies that the RTCP reduced size mode is properly applied to
5017// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07005018TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08005019 // Create stream, expecting that default mode is "compound".
5020 FakeVideoReceiveStream* stream1 = AddRecvStream();
5021 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
5022
5023 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07005024 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
5025 // the reduced_size flag should come from that.
5026 send_parameters_.rtcp.reduced_size = true;
5027 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08005028 stream1 = fake_call_->GetVideoReceiveStreams()[0];
5029 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
5030
5031 // Create a new stream and ensure it picks up the reduced size mode.
5032 FakeVideoReceiveStream* stream2 = AddRecvStream();
5033 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
5034}
5035
eladalonf1841382017-06-12 01:16:46 -07005036TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07005037 EXPECT_EQ(webrtc::kNetworkUp,
5038 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5039 EXPECT_EQ(webrtc::kNetworkUp,
5040 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00005041
5042 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07005043 EXPECT_EQ(webrtc::kNetworkDown,
5044 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5045 EXPECT_EQ(webrtc::kNetworkUp,
5046 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00005047
5048 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07005049 EXPECT_EQ(webrtc::kNetworkUp,
5050 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5051 EXPECT_EQ(webrtc::kNetworkUp,
5052 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00005053}
5054
eladalonf1841382017-06-12 01:16:46 -07005055TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005056 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005057 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005058 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01005059
5060 AddSendStream();
5061
5062 cricket::VideoMediaInfo info;
5063 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08005064 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01005065}
5066
eladalonf1841382017-06-12 01:16:46 -07005067TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01005068 FakeVideoSendStream* stream = AddSendStream();
5069 webrtc::VideoSendStream::Stats stats;
5070 stats.encoder_implementation_name = "encoder_implementation_name";
5071 stream->SetStats(stats);
5072
5073 cricket::VideoMediaInfo info;
5074 ASSERT_TRUE(channel_->GetStats(&info));
5075 EXPECT_EQ(stats.encoder_implementation_name,
5076 info.senders[0].encoder_implementation_name);
5077}
5078
eladalonf1841382017-06-12 01:16:46 -07005079TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005080 FakeVideoSendStream* stream = AddSendStream();
5081 webrtc::VideoSendStream::Stats stats;
5082 stats.avg_encode_time_ms = 13;
5083 stats.encode_usage_percent = 42;
5084 stream->SetStats(stats);
5085
5086 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005087 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005088 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
5089 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
5090}
5091
eladalonf1841382017-06-12 01:16:46 -07005092TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07005093 FakeVideoSendStream* stream = AddSendStream();
5094 webrtc::VideoSendStream::Stats stats;
5095 stats.frames_encoded = 13;
5096 stream->SetStats(stats);
5097
5098 cricket::VideoMediaInfo info;
5099 ASSERT_TRUE(channel_->GetStats(&info));
5100 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
5101}
5102
Rasmus Brandt2efae772019-06-27 14:29:34 +02005103TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
5104 FakeVideoSendStream* stream = AddSendStream();
5105 webrtc::VideoSendStream::Stats stats;
5106 stats.substreams[123].frame_counts.key_frames = 10;
5107 stats.substreams[456].frame_counts.key_frames = 87;
5108 stream->SetStats(stats);
5109
5110 cricket::VideoMediaInfo info;
5111 ASSERT_TRUE(channel_->GetStats(&info));
5112 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
5113 // for each simulcast stream, instead of accumulating all keyframes encoded
5114 // over all simulcast streams in the same outbound-rtp stats object.
5115 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
5116}
5117
eladalonf1841382017-06-12 01:16:46 -07005118TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07005119 FakeVideoSendStream* stream = AddSendStream();
5120 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01005121 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07005122 stream->SetStats(stats);
5123
5124 cricket::VideoMediaInfo info;
5125 ASSERT_TRUE(channel_->GetStats(&info));
5126 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5127}
5128
eladalonf1841382017-06-12 01:16:46 -07005129TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005130 FakeVideoSendStream* stream = AddSendStream();
5131 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005132 stats.substreams[17].width = 123;
5133 stats.substreams[17].height = 40;
5134 stats.substreams[42].width = 80;
5135 stats.substreams[42].height = 31;
5136 stats.substreams[11].width = 20;
5137 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005138 stream->SetStats(stats);
5139
5140 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005141 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005142 ASSERT_EQ(1u, info.senders.size());
5143 EXPECT_EQ(123, info.senders[0].send_frame_width);
5144 EXPECT_EQ(90, info.senders[0].send_frame_height);
5145}
5146
eladalonf1841382017-06-12 01:16:46 -07005147TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005148 FakeVideoSendStream* stream = AddSendStream();
5149 webrtc::VideoSendStream::Stats stats;
5150 stats.number_of_cpu_adapt_changes = 2;
5151 stats.cpu_limited_resolution = true;
5152 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005153
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005154 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005155 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005156 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005157 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005158 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005159}
5160
eladalonf1841382017-06-12 01:16:46 -07005161TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005162 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005163 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005164 stats.number_of_cpu_adapt_changes = 2;
5165 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005166 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005167 stream->SetStats(stats);
5168
5169 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005170 EXPECT_TRUE(channel_->GetStats(&info));
5171 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005172 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5173 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005174 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005175 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005176}
5177
eladalonf1841382017-06-12 01:16:46 -07005178TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005179 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5180 FakeVideoSendStream* stream = AddSendStream();
5181 webrtc::VideoSendStream::Stats stats;
5182 stats.bw_limited_resolution = true;
5183 stream->SetStats(stats);
5184
5185 cricket::VideoMediaInfo info;
5186 EXPECT_TRUE(channel_->GetStats(&info));
5187 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005188 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005189 info.senders[0].adapt_reason);
5190}
5191
Yves Gerey665174f2018-06-19 15:03:05 +02005192TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005193 FakeVideoSendStream* stream = AddSendStream();
5194 webrtc::VideoSendStream::Stats stats;
5195 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5196 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5197 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5198
5199 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5200 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5201 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5202
5203 stream->SetStats(stats);
5204
5205 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005206 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005207 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5208 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5209 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5210}
5211
eladalonf1841382017-06-12 01:16:46 -07005212TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005213 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5214 FakeVideoReceiveStream* stream = AddRecvStream();
5215 webrtc::VideoReceiveStream::Stats stats;
5216 stats.rtcp_packet_type_counts.fir_packets = 2;
5217 stats.rtcp_packet_type_counts.nack_packets = 3;
5218 stats.rtcp_packet_type_counts.pli_packets = 4;
5219 stream->SetStats(stats);
5220
5221 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005222 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005223 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005224 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005225 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005226 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005227 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005228 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005229}
5230
eladalonf1841382017-06-12 01:16:46 -07005231TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005232 FakeVideoReceiveStream* stream = AddRecvStream();
5233 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005234 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005235 stats.decode_ms = 2;
5236 stats.max_decode_ms = 3;
5237 stats.current_delay_ms = 4;
5238 stats.target_delay_ms = 5;
5239 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005240 stats.jitter_buffer_delay_seconds = 60;
5241 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005242 stats.min_playout_delay_ms = 7;
5243 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005244 stats.width = 9;
5245 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005246 stats.frame_counts.key_frames = 11;
5247 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005248 stats.frames_rendered = 13;
5249 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005250 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005251 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005252 stream->SetStats(stats);
5253
5254 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005255 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005256 EXPECT_EQ(stats.decoder_implementation_name,
5257 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005258 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5259 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5260 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5261 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5262 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005263 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5264 info.receivers[0].jitter_buffer_delay_seconds);
5265 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5266 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005267 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5268 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005269 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5270 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005271 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5272 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005273 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005274 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005275 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005276 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5277 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005278 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005279 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005280}
5281
eladalonf1841382017-06-12 01:16:46 -07005282TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005283 FakeVideoReceiveStream* stream = AddRecvStream();
5284 webrtc::VideoReceiveStream::Stats stats;
Niels Möllerd77cc242019-08-22 09:40:25 +02005285 stats.rtp_stats.packet_counter.payload_bytes = 2;
5286 stats.rtp_stats.packet_counter.header_bytes = 3;
5287 stats.rtp_stats.packet_counter.padding_bytes = 4;
5288 stats.rtp_stats.packet_counter.packets = 5;
5289 stats.rtp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005290 stream->SetStats(stats);
5291
5292 cricket::VideoMediaInfo info;
5293 ASSERT_TRUE(channel_->GetStats(&info));
Niels Möllerd77cc242019-08-22 09:40:25 +02005294 EXPECT_EQ(stats.rtp_stats.packet_counter.payload_bytes,
Niels Möllerac0a4cb2019-10-09 15:01:33 +02005295 rtc::checked_cast<size_t>(info.receivers[0].payload_bytes_rcvd));
Niels Möllerd77cc242019-08-22 09:40:25 +02005296 EXPECT_EQ(stats.rtp_stats.packet_counter.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005297 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
Niels Möllerd77cc242019-08-22 09:40:25 +02005298 EXPECT_EQ(stats.rtp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005299}
5300
eladalonf1841382017-06-12 01:16:46 -07005301TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005302 AddSendStream();
5303 AddSendStream();
5304 webrtc::Call::Stats stats;
5305 stats.rtt_ms = 123;
5306 fake_call_->SetStats(stats);
5307
5308 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005309 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005310 ASSERT_EQ(2u, info.senders.size());
5311 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5312 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5313}
5314
eladalonf1841382017-06-12 01:16:46 -07005315TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005316 FakeVideoSendStream* stream = AddSendStream();
5317 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005318 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005319 stats.media_bitrate_bps = 123;
5320 stats.substreams[17].total_bitrate_bps = 1;
5321 stats.substreams[17].retransmit_bitrate_bps = 2;
5322 stats.substreams[42].total_bitrate_bps = 3;
5323 stats.substreams[42].retransmit_bitrate_bps = 4;
5324 stream->SetStats(stats);
5325
5326 FakeVideoSendStream* stream2 = AddSendStream();
5327 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005328 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005329 stats2.media_bitrate_bps = 321;
5330 stats2.substreams[13].total_bitrate_bps = 5;
5331 stats2.substreams[13].retransmit_bitrate_bps = 6;
5332 stats2.substreams[21].total_bitrate_bps = 7;
5333 stats2.substreams[21].retransmit_bitrate_bps = 8;
5334 stream2->SetStats(stats2);
5335
5336 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005337 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005338 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005339 BandwidthEstimationInfo bwe_info;
5340 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005341 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5342 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5343 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5344 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005345 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005346 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005347 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005348 bwe_info.actual_enc_bitrate);
5349 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005350 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005351 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005352 << "Bandwidth stats should take all streams into account.";
5353}
5354
eladalonf1841382017-06-12 01:16:46 -07005355TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005356 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005357
Peter Boström0c4e06b2015-10-07 12:23:21 +02005358 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5359 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005360
5361 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5362 const size_t kDataLength = 12;
5363 uint8_t data[kDataLength];
5364 memset(data, 0, sizeof(data));
5365 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005366 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005367 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005368
5369 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5370 << "No default receive stream created.";
5371 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005372 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005373 << "Default receive stream should not have configured RTX";
5374
5375 EXPECT_TRUE(channel_->AddRecvStream(
5376 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5377 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005378 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005379 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005380 EXPECT_FALSE(
5381 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005382 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005383 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005384 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005385 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005386 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005387 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005388}
5389
eladalonf1841382017-06-12 01:16:46 -07005390TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005391 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005392
Peter Boström0c4e06b2015-10-07 12:23:21 +02005393 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5394 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005395
5396 StreamParams sp =
5397 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5398 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5399
5400 EXPECT_FALSE(channel_->AddSendStream(sp));
5401 EXPECT_FALSE(channel_->AddRecvStream(sp));
5402}
5403
eladalonf1841382017-06-12 01:16:46 -07005404TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005405 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005406
Peter Boström0c4e06b2015-10-07 12:23:21 +02005407 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5408 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005409
5410 StreamParams sp =
5411 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5412
5413 EXPECT_TRUE(channel_->AddSendStream(sp));
5414 EXPECT_TRUE(channel_->AddRecvStream(sp));
5415
5416 // The RTX SSRC is already used in previous streams, using it should fail.
5417 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5418 EXPECT_FALSE(channel_->AddSendStream(sp));
5419 EXPECT_FALSE(channel_->AddRecvStream(sp));
5420
5421 // After removing the original stream this should be fine to add (makes sure
5422 // that RTX ssrcs are not forever taken).
5423 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5424 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5425 EXPECT_TRUE(channel_->AddSendStream(sp));
5426 EXPECT_TRUE(channel_->AddRecvStream(sp));
5427}
5428
eladalonf1841382017-06-12 01:16:46 -07005429TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005430 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005431 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5432 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005433 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005434
Peter Boströmd6f4c252015-03-26 16:23:04 +01005435 StreamParams sp =
5436 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5437
5438 EXPECT_TRUE(channel_->AddSendStream(sp));
5439 EXPECT_TRUE(channel_->AddRecvStream(sp));
5440
5441 // One of the SSRCs is already used in previous streams, using it should fail.
5442 sp = cricket::CreateSimStreamParams("cname",
5443 MAKE_VECTOR(kOverlappingStreamSsrcs));
5444 EXPECT_FALSE(channel_->AddSendStream(sp));
5445 EXPECT_FALSE(channel_->AddRecvStream(sp));
5446
5447 // After removing the original stream this should be fine to add (makes sure
5448 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005449 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5450 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005451 EXPECT_TRUE(channel_->AddSendStream(sp));
5452 EXPECT_TRUE(channel_->AddRecvStream(sp));
5453}
5454
eladalonf1841382017-06-12 01:16:46 -07005455TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005456 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005457
5458 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5459 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5460
5461 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5462 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5463
5464 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5465
5466 static const uint32_t kReceiverSsrcs[] = {3};
5467 static const uint32_t kReceiverRtxSsrcs[] = {2};
5468
5469 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5470 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5471 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5472
5473 cricket::VideoMediaInfo info;
5474 ASSERT_TRUE(channel_->GetStats(&info));
5475
5476 ASSERT_EQ(1u, info.senders.size());
5477 ASSERT_EQ(1u, info.receivers.size());
5478
5479 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5480 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5481 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5482}
5483
eladalonf1841382017-06-12 01:16:46 -07005484TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005485 FakeVideoReceiveStream* stream = AddRecvStream();
5486 webrtc::VideoReceiveStream::Stats stats;
5487 cricket::VideoMediaInfo info;
5488
5489 // Report no codec name before receiving.
5490 stream->SetStats(stats);
5491 ASSERT_TRUE(channel_->GetStats(&info));
5492 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5493
5494 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005495 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005496 stream->SetStats(stats);
5497 ASSERT_TRUE(channel_->GetStats(&info));
5498 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5499
5500 // Report no codec name for unknown playload types.
5501 stats.current_payload_type = 3;
5502 stream->SetStats(stats);
5503 ASSERT_TRUE(channel_->GetStats(&info));
5504 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5505}
5506
Seth Hampson5897a6e2018-04-03 11:16:33 -07005507// Tests that when we add a stream without SSRCs, but contains a stream_id
5508// that it is stored and its stream id is later used when the first packet
5509// arrives to properly create a receive stream with a sync label.
5510TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5511 const char kSyncLabel[] = "sync_label";
5512 cricket::StreamParams unsignaled_stream;
5513 unsignaled_stream.set_stream_ids({kSyncLabel});
5514 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5515 // The stream shouldn't have been created at this point because it doesn't
5516 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005517 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005518
5519 // Create and deliver packet.
5520 const size_t kDataLength = 12;
5521 uint8_t data[kDataLength];
5522 memset(data, 0, sizeof(data));
5523 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5524 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005525 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005526
5527 // The stream should now be created with the appropriate sync label.
5528 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5529 EXPECT_EQ(kSyncLabel,
5530 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5531
Saurav Dasff27da52019-09-20 11:05:30 -07005532 // Reset the unsignaled stream to clear the cache. This time when
Seth Hampson5897a6e2018-04-03 11:16:33 -07005533 // a default video receive stream is created it won't have a sync_group.
Saurav Dasff27da52019-09-20 11:05:30 -07005534 channel_->ResetUnsignaledRecvStream();
Seth Hampson5897a6e2018-04-03 11:16:33 -07005535 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5536 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5537
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005538 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005539 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5540 EXPECT_TRUE(
5541 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5542}
5543
Ruslan Burakov493a6502019-02-27 15:32:48 +01005544// Test BaseMinimumPlayoutDelayMs on receive streams.
5545TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5546 // Test that set won't work for non-existing receive streams.
5547 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5548 // Test that get won't work for non-existing receive streams.
5549 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5550
5551 EXPECT_TRUE(AddRecvStream());
5552 // Test that set works for the existing receive stream.
5553 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5554 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5555 EXPECT_TRUE(recv_stream);
5556 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5557 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5558 200);
5559}
5560
5561// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5562TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5563 absl::optional<int> delay_ms;
5564 const FakeVideoReceiveStream* recv_stream;
5565
5566 // Set default stream with SSRC 0
5567 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5568 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5569
5570 // Spawn an unsignaled stream by sending a packet, it should inherit
5571 // default delay 200.
5572 const size_t kDataLength = 12;
5573 uint8_t data[kDataLength];
5574 memset(data, 0, sizeof(data));
5575 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5576 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005577 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005578
5579 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5580 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5581 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5582 EXPECT_EQ(200, delay_ms.value_or(0));
5583
5584 // Check that now if we change delay for SSRC 0 it will change delay for the
5585 // default receiving stream as well.
5586 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5587 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5588 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5589 EXPECT_EQ(300, delay_ms.value_or(0));
5590 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5591 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5592}
5593
eladalonf1841382017-06-12 01:16:46 -07005594void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005595 uint8_t payload_type,
5596 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005597 // kRedRtxPayloadType must currently be unused.
5598 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5599
noahricd10a68e2015-07-10 11:27:55 -07005600 // Add a RED RTX codec.
5601 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005602 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005603 recv_parameters_.codecs.push_back(red_rtx_codec);
5604 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005605
5606 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5607 const size_t kDataLength = 12;
5608 uint8_t data[kDataLength];
5609 memset(data, 0, sizeof(data));
5610
5611 rtc::Set8(data, 1, payload_type);
5612 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005613 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005614 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005615
5616 if (expect_created_receive_stream) {
5617 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5618 << "Should have created a receive stream for payload type: "
5619 << payload_type;
5620 } else {
5621 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5622 << "Shouldn't have created a receive stream for payload type: "
5623 << payload_type;
5624 }
5625}
5626
Åsa Persson2c7149b2018-10-15 09:36:10 +02005627class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5628 public:
5629 WebRtcVideoChannelDiscardUnknownSsrcTest()
5630 : WebRtcVideoChannelTest(
5631 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5632};
5633
5634TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5635 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5636 false /* expect_created_receive_stream */);
5637}
5638
eladalonf1841382017-06-12 01:16:46 -07005639TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005640 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5641 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005642}
5643
eladalonf1841382017-06-12 01:16:46 -07005644TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005645 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5646 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005647}
5648
eladalonf1841382017-06-12 01:16:46 -07005649TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005650 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005651 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5652 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5653 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5654 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005655}
5656
eladalonf1841382017-06-12 01:16:46 -07005657TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005658 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5659 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005660}
5661
eladalonf1841382017-06-12 01:16:46 -07005662TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005663 FlexfecPacketDoesntCreateUnsignalledStream) {
5664 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5665 false /* expect_created_receive_stream */);
5666}
5667
eladalonf1841382017-06-12 01:16:46 -07005668TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005669 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5670 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005671}
5672
mzanaty8a855d62017-02-17 15:46:43 -08005673// Test that receiving any unsignalled SSRC works even if it changes.
5674// The first unsignalled SSRC received will create a default receive stream.
5675// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005676TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005677 // Allow receiving VP8, VP9, H264 (if enabled).
5678 cricket::VideoRecvParameters parameters;
5679 parameters.codecs.push_back(GetEngineCodec("VP8"));
5680 parameters.codecs.push_back(GetEngineCodec("VP9"));
5681
5682#if defined(WEBRTC_USE_H264)
5683 cricket::VideoCodec H264codec(126, "H264");
5684 parameters.codecs.push_back(H264codec);
5685#endif
5686
5687 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5688 // No receive streams yet.
5689 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5690 cricket::FakeVideoRenderer renderer;
5691 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5692
5693 // Receive VP8 packet on first SSRC.
5694 uint8_t data[kMinRtpPacketLen];
5695 cricket::RtpHeader rtpHeader;
5696 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5697 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005698 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005699 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5700 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005701 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005702 // VP8 packet should create default receive stream.
5703 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005704 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005705 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5706 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005707 webrtc::VideoFrame video_frame =
5708 webrtc::VideoFrame::Builder()
5709 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5710 .set_timestamp_rtp(100)
5711 .set_timestamp_us(0)
5712 .set_rotation(webrtc::kVideoRotation_0)
5713 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005714 recv_stream->InjectFrame(video_frame);
5715 EXPECT_EQ(1, renderer.num_rendered_frames());
5716
5717 // Receive VP9 packet on second SSRC.
5718 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005719 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005720 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5721 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005722 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005723 // VP9 packet should replace the default receive SSRC.
5724 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5725 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5726 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5727 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005728 webrtc::VideoFrame video_frame2 =
5729 webrtc::VideoFrame::Builder()
5730 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5731 .set_timestamp_rtp(200)
5732 .set_timestamp_us(0)
5733 .set_rotation(webrtc::kVideoRotation_0)
5734 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005735 recv_stream->InjectFrame(video_frame2);
5736 EXPECT_EQ(2, renderer.num_rendered_frames());
5737
5738#if defined(WEBRTC_USE_H264)
5739 // Receive H264 packet on third SSRC.
5740 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005741 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005742 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5743 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005744 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005745 // H264 packet should replace the default receive SSRC.
5746 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5747 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5748 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5749 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005750 webrtc::VideoFrame video_frame3 =
5751 webrtc::VideoFrame::Builder()
5752 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5753 .set_timestamp_rtp(300)
5754 .set_timestamp_us(0)
5755 .set_rotation(webrtc::kVideoRotation_0)
5756 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005757 recv_stream->InjectFrame(video_frame3);
5758 EXPECT_EQ(3, renderer.num_rendered_frames());
5759#endif
5760}
5761
brandtr0dc57ea2017-05-29 23:33:31 -07005762// This test verifies that when a new default stream is created for a new
5763// unsignaled SSRC, the new stream does not overwrite any old stream that had
5764// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005765TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005766 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5767 cricket::VideoRecvParameters parameters;
5768 parameters.codecs.push_back(GetEngineCodec("VP8"));
5769 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5770
5771 // No streams signaled and no packets received, so we should not have any
5772 // stream objects created yet.
5773 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5774
5775 // Receive packet on an unsignaled SSRC.
5776 uint8_t data[kMinRtpPacketLen];
5777 cricket::RtpHeader rtp_header;
5778 rtp_header.payload_type = GetEngineCodec("VP8").id;
5779 rtp_header.seq_num = rtp_header.timestamp = 0;
5780 rtp_header.ssrc = kSsrcs3[0];
5781 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5782 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005783 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005784 // Default receive stream should be created.
5785 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5786 FakeVideoReceiveStream* recv_stream0 =
5787 fake_call_->GetVideoReceiveStreams()[0];
5788 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5789
5790 // Signal the SSRC.
5791 EXPECT_TRUE(
5792 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5793 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5794 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5795 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5796
5797 // Receive packet on a different unsignaled SSRC.
5798 rtp_header.ssrc = kSsrcs3[1];
5799 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5800 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005801 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005802 // New default receive stream should be created, but old stream should remain.
5803 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5804 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5805 FakeVideoReceiveStream* recv_stream1 =
5806 fake_call_->GetVideoReceiveStreams()[1];
5807 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5808}
5809
Seth Hampson7c682e02018-05-04 16:28:15 -07005810TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005811 AddSendStream();
5812
Niels Möller805a27e2019-01-21 12:21:27 +01005813 webrtc::test::FrameForwarder frame_forwarder;
5814 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005815 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005816 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005817
perkjfa10b552016-10-02 23:45:26 -07005818 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005819 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005820
5821 // TODO(skvlad): Resolve the inconsistency between the interpretation
5822 // of the global bitrate limit for audio and video:
5823 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5824 // max_bandwidth_bps = -1 - remove the bandwidth limit
5825 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005826 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005827
perkjfa10b552016-10-02 23:45:26 -07005828 SetAndExpectMaxBitrate(1000, 0, 1000);
5829 SetAndExpectMaxBitrate(1000, 800, 800);
5830 SetAndExpectMaxBitrate(600, 800, 600);
5831 SetAndExpectMaxBitrate(0, 800, 800);
5832 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005833
Niels Möllerff40b142018-04-09 08:49:14 +02005834 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005835}
5836
eladalonf1841382017-06-12 01:16:46 -07005837TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005838 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005839 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005840 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005841
5842 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005843 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005844 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005845}
5846
eladalonf1841382017-06-12 01:16:46 -07005847TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005848 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005849 FakeVideoSendStream* stream = AddSendStream();
5850
Seth Hampson7c682e02018-05-04 16:28:15 -07005851 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5852 EXPECT_EQ(1UL, parameters.encodings.size());
5853 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5854 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5855
5856 // Note that this is testing the behavior of the FakeVideoSendStream, which
5857 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5858 // we are just testing the behavior of
5859 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005860 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02005861 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
5862 stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005863
5864 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5865 // by this amount.
5866 parameters = channel_->GetRtpSendParameters(last_ssrc_);
Elad Alon80f53b72019-10-11 16:19:43 +02005867 int low_max_bitrate_bps = webrtc::kDefaultMinVideoBitrateBps - 1000;
Seth Hampson7c682e02018-05-04 16:28:15 -07005868 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5869 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5870
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005871 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5872 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5873 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5874}
5875
5876TEST_F(WebRtcVideoChannelTest,
5877 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5878 FakeVideoSendStream* stream = AddSendStream();
5879
5880 // Note that this is testing the behavior of the FakeVideoSendStream, which
5881 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5882 // we are just testing the behavior of
5883 // EncoderStreamFactory::CreateEncoderStreams.
5884 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5885 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5886
5887 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5888 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5889 EXPECT_EQ(1UL, parameters.encodings.size());
5890 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5891 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5892
5893 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5894 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5895 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5896}
5897
5898TEST_F(WebRtcVideoChannelTest,
5899 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5900 send_parameters_.max_bandwidth_bps = 99999;
5901 FakeVideoSendStream* stream = AddSendStream();
5902 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5903 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5904 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02005905 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
5906 stream->GetVideoStreams()[0].min_bitrate_bps);
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005907 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5908 stream->GetVideoStreams()[0].max_bitrate_bps);
5909
5910 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5911 // adjusted down.
5912 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5913 EXPECT_EQ(1UL, parameters.encodings.size());
5914 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5915 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5916 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5917 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5918 stream->GetVideoStreams()[0].min_bitrate_bps);
5919 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5920 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005921}
5922
Åsa Persson8c1bf952018-09-13 10:42:19 +02005923TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5924 FakeVideoSendStream* stream = AddSendStream();
5925
5926 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5927 EXPECT_EQ(1UL, parameters.encodings.size());
5928 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5929 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5930
5931 // Note that this is testing the behavior of the FakeVideoSendStream, which
5932 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5933 // we are just testing the behavior of
5934 // EncoderStreamFactory::CreateEncoderStreams.
5935 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5936 EXPECT_EQ(kDefaultVideoMaxFramerate,
5937 stream->GetVideoStreams()[0].max_framerate);
5938
5939 // Set max framerate and check that VideoStream.max_framerate is set.
5940 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5941 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5942 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5943 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5944
5945 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5946 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5947}
5948
Åsa Persson23eba222018-10-02 14:47:06 +02005949TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5950 FakeVideoSendStream* stream = AddSendStream();
5951
5952 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5953 EXPECT_EQ(1UL, parameters.encodings.size());
5954 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5955 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5956
5957 // Note that this is testing the behavior of the FakeVideoSendStream, which
5958 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5959 // we are just testing the behavior of
5960 // EncoderStreamFactory::CreateEncoderStreams.
5961 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5962 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5963
5964 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5965 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5966 parameters.encodings[0].num_temporal_layers = 2;
5967 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5968
5969 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5970 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5971}
5972
Seth Hampson7c682e02018-05-04 16:28:15 -07005973TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005974 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005975 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005976 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005977 // Two or more encodings should result in failure.
5978 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005979 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005980 // Zero encodings should also fail.
5981 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005982 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005983}
5984
Zach Stein3ca452b2018-01-18 10:01:24 -08005985TEST_F(WebRtcVideoChannelTest,
5986 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5987 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5988 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5989 AddSendStream(sp);
5990
5991 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5992
5993 // Additional encodings should result in failure.
5994 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005995 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005996 // Zero encodings should also fail.
5997 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005998 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005999}
6000
deadbeeffb2aced2017-01-06 23:05:37 -08006001// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07006002TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08006003 AddSendStream();
6004 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01006005 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08006006 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07006007}
6008
Seth Hampson24722b32017-12-22 09:36:42 -08006009// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
6010// a value <= 0, setting the parameters returns false.
6011TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
6012 AddSendStream();
6013 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6014 EXPECT_EQ(1UL, parameters.encodings.size());
6015 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6016 parameters.encodings[0].bitrate_priority);
6017
6018 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08006019 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006020 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08006021 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006022}
6023
6024// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
6025// properly on the VideoChannel and propogates down to the video encoder.
6026TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
6027 AddSendStream();
6028 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6029 EXPECT_EQ(1UL, parameters.encodings.size());
6030 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6031 parameters.encodings[0].bitrate_priority);
6032
6033 // Change the value and set it on the VideoChannel.
6034 double new_bitrate_priority = 2.0;
6035 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08006036 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006037
6038 // Verify that the encoding parameters bitrate_priority is set for the
6039 // VideoChannel.
6040 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6041 EXPECT_EQ(1UL, parameters.encodings.size());
6042 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
6043
6044 // Verify that the new value propagated down to the encoder.
6045 std::vector<FakeVideoSendStream*> video_send_streams =
6046 fake_call_->GetVideoSendStreams();
6047 EXPECT_EQ(1UL, video_send_streams.size());
6048 FakeVideoSendStream* video_send_stream = video_send_streams.front();
6049 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6050 // appropriately.
6051 EXPECT_EQ(new_bitrate_priority,
6052 video_send_stream->GetEncoderConfig().bitrate_priority);
6053 // Check that the vector of VideoStreams also was propagated correctly. Note
6054 // that this is testing the behavior of the FakeVideoSendStream, which mimics
6055 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006056 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006057 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6058}
6059
6060// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
6061// VideoChannel and the value propogates to the video encoder with all simulcast
6062// streams.
6063TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
6064 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006065 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08006066 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6067 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6068 AddSendStream(stream_params);
6069 uint32_t primary_ssrc = stream_params.first_ssrc();
6070
Niels Möller805a27e2019-01-21 12:21:27 +01006071 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006072 // frame. This creates multiple VideoStreams for all simulcast layers when
6073 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01006074 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08006075 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006076 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08006077 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006078 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6079 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6080 rtc::kNumMicrosecsPerSec / 30));
6081
Seth Hampson24722b32017-12-22 09:36:42 -08006082 // Get and set the rtp encoding parameters.
6083 webrtc::RtpParameters parameters =
6084 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006085 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006086 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6087 parameters.encodings[0].bitrate_priority);
6088 // Change the value and set it on the VideoChannel.
6089 double new_bitrate_priority = 2.0;
6090 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08006091 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006092
6093 // Verify that the encoding parameters priority is set on the VideoChannel.
6094 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006095 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006096 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
6097
6098 // Verify that the new value propagated down to the encoder.
6099 std::vector<FakeVideoSendStream*> video_send_streams =
6100 fake_call_->GetVideoSendStreams();
6101 EXPECT_EQ(1UL, video_send_streams.size());
6102 FakeVideoSendStream* video_send_stream = video_send_streams.front();
6103 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6104 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006105 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08006106 video_send_stream->GetEncoderConfig().number_of_streams);
6107 EXPECT_EQ(new_bitrate_priority,
6108 video_send_stream->GetEncoderConfig().bitrate_priority);
6109 // Check that the vector of VideoStreams also propagated correctly. The
6110 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
6111 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006112 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02006113 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006114 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6115 // Since we are only setting bitrate priority per-sender, the other
6116 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006117 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006118 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02006119 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006120 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02006121 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006122}
6123
Tim Haloun648d28a2018-10-18 16:52:22 -07006124// RTCRtpEncodingParameters.network_priority must be one of a few values
6125// derived from the default priority, corresponding to very-low, low, medium,
6126// or high.
6127TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6128 AddSendStream();
6129 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6130 EXPECT_EQ(1UL, parameters.encodings.size());
6131 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6132 parameters.encodings[0].network_priority);
6133
6134 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6135 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6136 for (auto it : good_values) {
6137 parameters.encodings[0].network_priority = it;
6138 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6139 }
6140 for (auto it : bad_values) {
6141 parameters.encodings[0].network_priority = it;
6142 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6143 }
6144}
6145
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006146TEST_F(WebRtcVideoChannelTest,
6147 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006148 VideoSendParameters parameters;
6149 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006150 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6151 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6152
6153 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006154 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006155
6156 VideoOptions options;
6157 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6158 channel_->SetSend(true);
6159
6160 // Try layers in natural order (smallest to largest).
6161 {
6162 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6163 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6164 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6165 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6166 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6167 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6168 ASSERT_TRUE(result.ok());
6169
6170 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6171
6172 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6173 ASSERT_EQ(3u, video_streams.size());
6174 EXPECT_EQ(320u, video_streams[0].width);
6175 EXPECT_EQ(180u, video_streams[0].height);
6176 EXPECT_EQ(640u, video_streams[1].width);
6177 EXPECT_EQ(360u, video_streams[1].height);
6178 EXPECT_EQ(1280u, video_streams[2].width);
6179 EXPECT_EQ(720u, video_streams[2].height);
6180 }
6181
6182 // Try layers in reverse natural order (largest to smallest).
6183 {
6184 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6185 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6186 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6187 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6188 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6189 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6190 ASSERT_TRUE(result.ok());
6191
6192 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6193
6194 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6195 ASSERT_EQ(3u, video_streams.size());
6196 EXPECT_EQ(1280u, video_streams[0].width);
6197 EXPECT_EQ(720u, video_streams[0].height);
6198 EXPECT_EQ(640u, video_streams[1].width);
6199 EXPECT_EQ(360u, video_streams[1].height);
6200 EXPECT_EQ(320u, video_streams[2].width);
6201 EXPECT_EQ(180u, video_streams[2].height);
6202 }
6203
6204 // Try layers in mixed order.
6205 {
6206 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6207 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6208 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6209 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6210 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6211 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6212 ASSERT_TRUE(result.ok());
6213
6214 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6215
6216 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6217 ASSERT_EQ(3u, video_streams.size());
6218 EXPECT_EQ(128u, video_streams[0].width);
6219 EXPECT_EQ(72u, video_streams[0].height);
6220 EXPECT_EQ(640u, video_streams[1].width);
6221 EXPECT_EQ(360u, video_streams[1].height);
6222 EXPECT_EQ(320u, video_streams[2].width);
6223 EXPECT_EQ(180u, video_streams[2].height);
6224 }
6225
6226 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6227 {
6228 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6229 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6230 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6231 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6232 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6233 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6234 ASSERT_TRUE(result.ok());
6235
6236 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6237
6238 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6239 ASSERT_EQ(3u, video_streams.size());
6240 EXPECT_EQ(1280u, video_streams[0].width);
6241 EXPECT_EQ(720u, video_streams[0].height);
6242 EXPECT_EQ(1280u, video_streams[1].width);
6243 EXPECT_EQ(720u, video_streams[1].height);
6244 EXPECT_EQ(320u, video_streams[2].width);
6245 EXPECT_EQ(180u, video_streams[2].height);
6246 }
6247
6248 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6249}
6250
6251TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006252 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6253 // Ensure that the top layer has width and height divisible by 2^3,
6254 // so that the bottom layer has width and height divisible by 2.
6255 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6256 // the number of simulcast layers set by the app.
6257 webrtc::test::ScopedFieldTrials field_trial(
6258 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6259
6260 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6261 VideoSendParameters parameters;
6262 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6263 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6264 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6265 webrtc::test::FrameForwarder frame_forwarder;
6266 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6267 &frame_forwarder));
6268 channel_->SetSend(true);
6269
6270 // Set |scale_resolution_down_by|'s.
6271 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6272 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6273 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6274 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6275 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6276 const auto result =
6277 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6278 ASSERT_TRUE(result.ok());
6279
6280 // Use a capture resolution whose width and height are not divisible by 2^3.
6281 // (See field trial set at the top of the test.)
6282 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6283 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6284
6285 // Ensure the scaling is correct.
6286 const auto video_streams = stream->GetVideoStreams();
6287 ASSERT_EQ(video_streams.size(), 3u);
6288 // Ensure that we round the capture resolution down for the top layer...
6289 EXPECT_EQ(video_streams[0].width, 2000u);
6290 EXPECT_EQ(video_streams[0].height, 1200u);
6291 EXPECT_EQ(video_streams[1].width, 1000u);
6292 EXPECT_EQ(video_streams[1].height, 600u);
6293 // ...and that the bottom layer has a width/height divisible by 2.
6294 EXPECT_EQ(video_streams[2].width, 500u);
6295 EXPECT_EQ(video_streams[2].height, 300u);
6296
6297 // Tear down.
6298 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6299}
6300
6301TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006302 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006303 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6304 VideoSendParameters parameters;
6305 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006306 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6307 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6308
6309 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006310 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006311
6312 VideoOptions options;
6313 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6314 channel_->SetSend(true);
6315
6316 // Try layers in natural order (smallest to largest).
6317 {
6318 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6319 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6320 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6321 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6322 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6323 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6324 ASSERT_TRUE(result.ok());
6325
6326 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6327
6328 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6329 ASSERT_EQ(3u, video_streams.size());
6330 EXPECT_EQ(320u, video_streams[0].width);
6331 EXPECT_EQ(180u, video_streams[0].height);
6332 EXPECT_EQ(640u, video_streams[1].width);
6333 EXPECT_EQ(360u, video_streams[1].height);
6334 EXPECT_EQ(1280u, video_streams[2].width);
6335 EXPECT_EQ(720u, video_streams[2].height);
6336 }
6337
6338 // Try layers in reverse natural order (largest to smallest).
6339 {
6340 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6341 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6342 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6343 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6344 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6345 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6346 ASSERT_TRUE(result.ok());
6347
6348 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6349
6350 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6351 ASSERT_EQ(3u, video_streams.size());
6352 EXPECT_EQ(1280u, video_streams[0].width);
6353 EXPECT_EQ(720u, video_streams[0].height);
6354 EXPECT_EQ(640u, video_streams[1].width);
6355 EXPECT_EQ(360u, video_streams[1].height);
6356 EXPECT_EQ(320u, video_streams[2].width);
6357 EXPECT_EQ(180u, video_streams[2].height);
6358 }
6359
6360 // Try layers in mixed order.
6361 {
6362 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6363 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6364 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6365 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6366 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6367 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6368 ASSERT_TRUE(result.ok());
6369
6370 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6371
6372 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6373 ASSERT_EQ(3u, video_streams.size());
6374 EXPECT_EQ(128u, video_streams[0].width);
6375 EXPECT_EQ(72u, video_streams[0].height);
6376 EXPECT_EQ(640u, video_streams[1].width);
6377 EXPECT_EQ(360u, video_streams[1].height);
6378 EXPECT_EQ(320u, video_streams[2].width);
6379 EXPECT_EQ(180u, video_streams[2].height);
6380 }
6381
6382 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6383 {
6384 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6385 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6386 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6387 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6388 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6389 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6390 ASSERT_TRUE(result.ok());
6391
6392 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6393
6394 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6395 ASSERT_EQ(3u, video_streams.size());
6396 EXPECT_EQ(1280u, video_streams[0].width);
6397 EXPECT_EQ(720u, video_streams[0].height);
6398 EXPECT_EQ(1280u, video_streams[1].width);
6399 EXPECT_EQ(720u, video_streams[1].height);
6400 EXPECT_EQ(320u, video_streams[2].width);
6401 EXPECT_EQ(180u, video_streams[2].height);
6402 }
6403 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6404}
6405
Rasmus Brandt9387b522019-02-05 14:23:26 +01006406TEST_F(WebRtcVideoChannelTest,
6407 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6408 // Ensure that the top layer has width and height divisible by 2^3,
6409 // so that the bottom layer has width and height divisible by 2.
6410 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6411 // the number of simulcast layers set by the app.
6412 webrtc::test::ScopedFieldTrials field_trial(
6413 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6414
6415 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6416 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6417 VideoSendParameters parameters;
6418 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6419 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6420 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6421 webrtc::test::FrameForwarder frame_forwarder;
6422 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6423 &frame_forwarder));
6424 channel_->SetSend(true);
6425
6426 // Set |scale_resolution_down_by|'s.
6427 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6428 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6429 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6430 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6431 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6432 const auto result =
6433 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6434 ASSERT_TRUE(result.ok());
6435
6436 // Use a capture resolution whose width and height are not divisible by 2^3.
6437 // (See field trial set at the top of the test.)
6438 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6439 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6440
6441 // Ensure the scaling is correct.
6442 const auto video_streams = stream->GetVideoStreams();
6443 ASSERT_EQ(video_streams.size(), 3u);
6444 // Ensure that we round the capture resolution down for the top layer...
6445 EXPECT_EQ(video_streams[0].width, 2000u);
6446 EXPECT_EQ(video_streams[0].height, 1200u);
6447 EXPECT_EQ(video_streams[1].width, 1000u);
6448 EXPECT_EQ(video_streams[1].height, 600u);
6449 // ...and that the bottom layer has a width/height divisible by 2.
6450 EXPECT_EQ(video_streams[2].width, 500u);
6451 EXPECT_EQ(video_streams[2].height, 300u);
6452
6453 // Tear down.
6454 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6455}
6456
Åsa Persson8c1bf952018-09-13 10:42:19 +02006457TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6458 const size_t kNumSimulcastStreams = 3;
6459 SetUpSimulcast(true, false);
6460
6461 // Get and set the rtp encoding parameters.
6462 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6463 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6464 for (const auto& encoding : parameters.encodings) {
6465 EXPECT_FALSE(encoding.max_framerate);
6466 }
6467
6468 // Change the value and set it on the VideoChannel.
6469 parameters.encodings[0].max_framerate = 10;
6470 parameters.encodings[1].max_framerate = 20;
6471 parameters.encodings[2].max_framerate = 25;
6472 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6473
6474 // Verify that the bitrates are set on the VideoChannel.
6475 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6476 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6477 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6478 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6479 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6480}
6481
Åsa Persson23eba222018-10-02 14:47:06 +02006482TEST_F(WebRtcVideoChannelTest,
6483 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6484 const size_t kNumSimulcastStreams = 3;
6485 SetUpSimulcast(true, false);
6486
6487 // Get and set the rtp encoding parameters.
6488 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6489 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6490
6491 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6492 parameters.encodings[0].num_temporal_layers = 0;
6493 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6494 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6495 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6496 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6497 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6498}
6499
6500TEST_F(WebRtcVideoChannelTest,
6501 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6502 const size_t kNumSimulcastStreams = 3;
6503 SetUpSimulcast(true, false);
6504
6505 // Get and set the rtp encoding parameters.
6506 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6507 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6508
6509 // No/all layers should be set.
6510 parameters.encodings[0].num_temporal_layers = 1;
6511 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6512 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6513
6514 // Different values not supported.
6515 parameters.encodings[0].num_temporal_layers = 1;
6516 parameters.encodings[1].num_temporal_layers = 2;
6517 parameters.encodings[2].num_temporal_layers = 2;
6518 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6519 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6520}
6521
6522TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6523 const size_t kNumSimulcastStreams = 3;
6524 SetUpSimulcast(true, false);
6525
6526 // Get and set the rtp encoding parameters.
6527 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6528 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6529 for (const auto& encoding : parameters.encodings)
6530 EXPECT_FALSE(encoding.num_temporal_layers);
6531
6532 // Change the value and set it on the VideoChannel.
6533 parameters.encodings[0].num_temporal_layers = 3;
6534 parameters.encodings[1].num_temporal_layers = 3;
6535 parameters.encodings[2].num_temporal_layers = 3;
6536 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6537
6538 // Verify that the number of temporal layers are set on the VideoChannel.
6539 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6540 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6541 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6542 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6543 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6544}
6545
6546TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6547 const size_t kNumSimulcastStreams = 3;
6548 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6549
6550 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006551 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006552 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006553 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006554 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006555 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006556
6557 // Get and set the rtp encoding parameters.
6558 // Change the value and set it on the VideoChannel.
6559 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6560 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6561 parameters.encodings[0].num_temporal_layers = 2;
6562 parameters.encodings[1].num_temporal_layers = 2;
6563 parameters.encodings[2].num_temporal_layers = 2;
6564 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6565
6566 // Verify that the new value is propagated down to the encoder.
6567 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6568 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6569 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6570 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6571 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6572 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6573 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6574 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6575
6576 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6577 // VideoStreams are created appropriately for the simulcast case.
6578 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6579 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6580 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6581 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6582
6583 // No parameter changed, encoder should not be reconfigured.
6584 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6585 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6586
6587 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6588}
6589
6590TEST_F(WebRtcVideoChannelTest,
6591 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6592 const size_t kDefaultNumTemporalLayers = 3;
6593 const size_t kNumSimulcastStreams = 3;
6594 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6595
6596 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006597 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006598 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006599 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006600 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006601 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006602
6603 // Change rtp encoding parameters, num_temporal_layers not changed.
6604 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6605 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6606 parameters.encodings[0].min_bitrate_bps = 33000;
6607 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6608
6609 // Verify that no value is propagated down to the encoder.
6610 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6611 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6612 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6613 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6614 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6615 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6616
6617 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6618 // VideoStreams are created appropriately for the simulcast case.
6619 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6620 EXPECT_EQ(kDefaultNumTemporalLayers,
6621 stream->GetVideoStreams()[0].num_temporal_layers);
6622 EXPECT_EQ(kDefaultNumTemporalLayers,
6623 stream->GetVideoStreams()[1].num_temporal_layers);
6624 EXPECT_EQ(kDefaultNumTemporalLayers,
6625 stream->GetVideoStreams()[2].num_temporal_layers);
6626
6627 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6628}
6629
Åsa Persson8c1bf952018-09-13 10:42:19 +02006630TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6631 const size_t kNumSimulcastStreams = 3;
6632 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6633
6634 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006635 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006636 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006637 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006638 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006639 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006640
6641 // Get and set the rtp encoding parameters.
6642 // Change the value and set it on the VideoChannel.
6643 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6644 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6645 parameters.encodings[0].max_framerate = 15;
6646 parameters.encodings[1].max_framerate = 25;
6647 parameters.encodings[2].max_framerate = 20;
6648 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6649
6650 // Verify that the new value propagated down to the encoder.
6651 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6652 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6653 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6654 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6655 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6656 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6657 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6658 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6659
6660 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6661 // VideoStreams are created appropriately for the simulcast case.
6662 // Currently the maximum |max_framerate| is used.
6663 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6664 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6665 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6666 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6667
6668 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6669}
6670
6671TEST_F(WebRtcVideoChannelTest,
6672 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6673 const size_t kNumSimulcastStreams = 3;
6674 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6675 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6676
6677 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006678 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006679 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006680 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006681 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006682 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006683
6684 // Get and set the rtp encoding parameters.
6685 // Change the value and set it on the VideoChannel.
6686 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6687 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6688 parameters.encodings[0].max_framerate = 15;
6689 parameters.encodings[2].max_framerate = 20;
6690 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6691
6692 // Verify that the new value propagated down to the encoder.
6693 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6694 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6695 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6696 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6697 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6698 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6699 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6700
6701 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6702 // VideoStreams are created appropriately for the simulcast case.
6703 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6704 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6705 EXPECT_EQ(kDefaultVideoMaxFramerate,
6706 stream->GetVideoStreams()[0].max_framerate);
6707 EXPECT_EQ(kDefaultVideoMaxFramerate,
6708 stream->GetVideoStreams()[1].max_framerate);
6709 EXPECT_EQ(kDefaultVideoMaxFramerate,
6710 stream->GetVideoStreams()[2].max_framerate);
6711
6712 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6713}
6714
Åsa Persson55659812018-06-18 17:51:32 +02006715TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6716 const size_t kNumSimulcastStreams = 3;
6717 SetUpSimulcast(true, false);
6718
6719 // Get and set the rtp encoding parameters.
6720 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6721 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6722 for (const auto& encoding : parameters.encodings) {
6723 EXPECT_FALSE(encoding.min_bitrate_bps);
6724 EXPECT_FALSE(encoding.max_bitrate_bps);
6725 }
6726
6727 // Change the value and set it on the VideoChannel.
6728 parameters.encodings[0].min_bitrate_bps = 100000;
6729 parameters.encodings[0].max_bitrate_bps = 200000;
6730 parameters.encodings[1].min_bitrate_bps = 300000;
6731 parameters.encodings[1].max_bitrate_bps = 400000;
6732 parameters.encodings[2].min_bitrate_bps = 500000;
6733 parameters.encodings[2].max_bitrate_bps = 600000;
6734 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6735
6736 // Verify that the bitrates are set on the VideoChannel.
6737 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6738 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6739 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6740 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6741 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6742 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6743 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6744 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6745}
6746
6747TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6748 const size_t kNumSimulcastStreams = 3;
6749 SetUpSimulcast(true, false);
6750
6751 // Get and set the rtp encoding parameters.
6752 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6753 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6754
6755 // Max bitrate lower than min bitrate should fail.
6756 parameters.encodings[2].min_bitrate_bps = 100000;
6757 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6758 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6759 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6760}
6761
6762// Test that min and max bitrate values set via RtpParameters are correctly
6763// propagated to the underlying encoder, and that the target is set to 3/4 of
6764// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6765// that are used if no min/max are specified).
6766TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6767 const size_t kNumSimulcastStreams = 3;
6768 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6769
6770 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006771 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006772 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006773 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006774 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006775 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006776
6777 // Get and set the rtp encoding parameters.
6778 // Change the value and set it on the VideoChannel.
6779 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6780 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6781 parameters.encodings[0].min_bitrate_bps = 100000;
6782 parameters.encodings[0].max_bitrate_bps = 200000;
6783 parameters.encodings[1].min_bitrate_bps = 300000;
6784 parameters.encodings[1].max_bitrate_bps = 400000;
6785 parameters.encodings[2].min_bitrate_bps = 500000;
6786 parameters.encodings[2].max_bitrate_bps = 600000;
6787 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6788
6789 // Verify that the new value propagated down to the encoder.
6790 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6791 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6792 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6793 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6794 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6795 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6796 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6797 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6798 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6799 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6800 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6801
6802 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6803 // VideoStreams are created appropriately for the simulcast case.
6804 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6805 // Target bitrate: 200000 * 3 / 4 = 150000.
6806 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6807 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6808 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6809 // Target bitrate: 400000 * 3 / 4 = 300000.
6810 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6811 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6812 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6813 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6814 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6815 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6816 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6817
6818 // No parameter changed, encoder should not be reconfigured.
6819 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6820 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6821
6822 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6823}
6824
6825// Test to only specify the min or max bitrate value for a layer via
6826// RtpParameters. The unspecified min/max and target value should be set to the
6827// simulcast default that is used if no min/max are specified.
6828TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6829 const size_t kNumSimulcastStreams = 3;
6830 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6831 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6832
6833 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006834 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006835 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006836 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006837 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006838 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006839
6840 // Get and set the rtp encoding parameters.
6841 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6842 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6843
6844 // Change the value and set it on the VideoChannel.
6845 // Layer 0: only configure min bitrate.
6846 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6847 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6848 // Layer 1: only configure max bitrate.
6849 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6850 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6851 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6852
6853 // Verify that the new value propagated down to the encoder.
6854 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6855 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6856 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6857 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6858 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6859 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6860 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6861 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6862 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6863 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6864
6865 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6866 // VideoStreams are created appropriately for the simulcast case.
6867 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6868 // Layer 0: min configured bitrate should overwrite min default.
6869 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6870 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6871 stream->GetVideoStreams()[0].target_bitrate_bps);
6872 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6873 stream->GetVideoStreams()[0].max_bitrate_bps);
6874 // Layer 1: max configured bitrate should overwrite max default.
6875 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6876 stream->GetVideoStreams()[1].min_bitrate_bps);
6877 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6878 stream->GetVideoStreams()[1].target_bitrate_bps);
6879 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6880 // Layer 2: min and max bitrate not configured, default expected.
6881 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6882 stream->GetVideoStreams()[2].min_bitrate_bps);
6883 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6884 stream->GetVideoStreams()[2].target_bitrate_bps);
6885 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6886 stream->GetVideoStreams()[2].max_bitrate_bps);
6887
6888 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6889}
6890
6891// Test that specifying the min (or max) bitrate value for a layer via
6892// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6893// unspecified values accordingly.
6894TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6895 const size_t kNumSimulcastStreams = 3;
6896 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6897 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6898
6899 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006900 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006901 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006902 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006903 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006904 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006905
6906 // Get and set the rtp encoding parameters.
6907 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6908 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6909
6910 // Change the value and set it on the VideoChannel.
6911 // For layer 0, set the min bitrate above the default max.
6912 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6913 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6914 // For layer 1, set the max bitrate below the default min.
6915 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6916 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6917 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6918
6919 // Verify that the new value propagated down to the encoder.
6920 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6921 // VideoStreams are created appropriately for the simulcast case.
6922 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6923 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6924 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6925 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6926 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6927 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6928 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6929 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6930 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6931 // Layer 2: min and max bitrate not configured, default expected.
6932 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6933 stream->GetVideoStreams()[2].min_bitrate_bps);
6934 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6935 stream->GetVideoStreams()[2].target_bitrate_bps);
6936 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6937 stream->GetVideoStreams()[2].max_bitrate_bps);
6938
6939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6940}
6941
6942TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6943 const size_t kNumSimulcastStreams = 3;
6944 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6945 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6946
6947 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006948 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006949 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006950 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006951 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006952 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006953
6954 // Set max bitrate for all but the highest layer.
6955 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6956 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6957 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6958 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6959 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6960
6961 // Set max bandwidth equal to total max bitrate.
6962 send_parameters_.max_bandwidth_bps =
6963 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6964 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6965 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6966
6967 // No bitrate above the total max to give to the highest layer.
6968 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6969 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6970 stream->GetVideoStreams()[2].max_bitrate_bps);
6971
6972 // Set max bandwidth above the total max bitrate.
6973 send_parameters_.max_bandwidth_bps =
6974 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6975 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6976 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6977
6978 // The highest layer has no max bitrate set -> the bitrate above the total
6979 // max should be given to the highest layer.
6980 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6981 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6982 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6983 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6984 stream->GetVideoStreams()[2].max_bitrate_bps);
6985
6986 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6987}
6988
6989TEST_F(WebRtcVideoChannelTest,
6990 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6991 const size_t kNumSimulcastStreams = 3;
6992 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6993 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6994 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6995
6996 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006997 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006998 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006999 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02007000 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007001 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02007002
7003 // Set max bitrate for the highest layer.
7004 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7005 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
7006 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
7007 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
7008
7009 // Set max bandwidth above the total max bitrate.
7010 send_parameters_.max_bandwidth_bps =
7011 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
7012 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
7013 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
7014
7015 // The highest layer has the max bitrate set -> the bitrate above the total
7016 // max should not be given to the highest layer.
7017 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
7018 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
7019 stream->GetVideoStreams()[2].max_bitrate_bps);
7020
7021 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7022}
7023
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007024// Test that min and max bitrate values set via RtpParameters are correctly
7025// propagated to the underlying encoder for a single stream.
7026TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
7027 FakeVideoSendStream* stream = AddSendStream();
7028 EXPECT_TRUE(channel_->SetSend(true));
7029 EXPECT_TRUE(stream->IsSending());
7030
7031 // Set min and max bitrate.
7032 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7033 EXPECT_EQ(1u, parameters.encodings.size());
7034 parameters.encodings[0].min_bitrate_bps = 80000;
7035 parameters.encodings[0].max_bitrate_bps = 150000;
7036 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
7037
7038 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
7039 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
7040 EXPECT_EQ(1u, encoder_config.number_of_streams);
7041 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
7042 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
7043 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
7044
7045 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
7046 // VideoStreams are created appropriately.
7047 EXPECT_EQ(1u, stream->GetVideoStreams().size());
7048 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
7049 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
7050 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
7051}
7052
7053// Test the default min and max bitrate value are correctly propagated to the
7054// underlying encoder for a single stream (when the values are not set via
7055// RtpParameters).
7056TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
7057 FakeVideoSendStream* stream = AddSendStream();
7058 EXPECT_TRUE(channel_->SetSend(true));
7059 EXPECT_TRUE(stream->IsSending());
7060
7061 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
7062 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
7063 EXPECT_EQ(1u, encoder_config.number_of_streams);
7064 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
7065 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
7066 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
7067
7068 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
7069 // VideoStreams are created appropriately.
7070 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02007071 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007072 stream->GetVideoStreams()[0].min_bitrate_bps);
7073 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
7074 stream->GetVideoStreams()[0].min_bitrate_bps);
7075 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
7076 stream->GetVideoStreams()[0].target_bitrate_bps);
7077}
7078
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007079// Test that a stream will not be sending if its encoding is made inactive
7080// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08007081TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07007082 FakeVideoSendStream* stream = AddSendStream();
7083 EXPECT_TRUE(channel_->SetSend(true));
7084 EXPECT_TRUE(stream->IsSending());
7085
7086 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007087 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07007088 ASSERT_EQ(1u, parameters.encodings.size());
7089 ASSERT_TRUE(parameters.encodings[0].active);
7090 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08007091 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007092 EXPECT_FALSE(stream->IsSending());
7093
7094 // Now change it back to active and verify we resume sending.
7095 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08007096 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007097 EXPECT_TRUE(stream->IsSending());
7098}
7099
Seth Hampson8234ead2018-02-02 15:16:24 -08007100// Tests that when active is updated for any simulcast layer then the send
7101// stream's sending state will be updated and it will be reconfigured with the
7102// new appropriate active simulcast streams.
7103TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
7104 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02007105 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08007106 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
7107 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
7108 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
7109 uint32_t primary_ssrc = stream_params.first_ssrc();
7110
Niels Möller805a27e2019-01-21 12:21:27 +01007111 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01007112 // frame. This allows us to test that ReconfigureEncoder is called
7113 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01007114 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08007115 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01007116 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08007117 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007118 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
7119 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
7120 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08007121
7122 // Check that all encodings are initially active.
7123 webrtc::RtpParameters parameters =
7124 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007125 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007126 EXPECT_TRUE(parameters.encodings[0].active);
7127 EXPECT_TRUE(parameters.encodings[1].active);
7128 EXPECT_TRUE(parameters.encodings[2].active);
7129 EXPECT_TRUE(fake_video_send_stream->IsSending());
7130
7131 // Only turn on only the middle stream.
7132 parameters.encodings[0].active = false;
7133 parameters.encodings[1].active = true;
7134 parameters.encodings[2].active = false;
7135 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7136 // Verify that the active fields are set on the VideoChannel.
7137 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007138 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007139 EXPECT_FALSE(parameters.encodings[0].active);
7140 EXPECT_TRUE(parameters.encodings[1].active);
7141 EXPECT_FALSE(parameters.encodings[2].active);
7142 // Check that the VideoSendStream is updated appropriately. This means its
7143 // send state was updated and it was reconfigured.
7144 EXPECT_TRUE(fake_video_send_stream->IsSending());
7145 std::vector<webrtc::VideoStream> simulcast_streams =
7146 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007147 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007148 EXPECT_FALSE(simulcast_streams[0].active);
7149 EXPECT_TRUE(simulcast_streams[1].active);
7150 EXPECT_FALSE(simulcast_streams[2].active);
7151
7152 // Turn off all streams.
7153 parameters.encodings[0].active = false;
7154 parameters.encodings[1].active = false;
7155 parameters.encodings[2].active = false;
7156 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7157 // Verify that the active fields are set on the VideoChannel.
7158 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007159 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007160 EXPECT_FALSE(parameters.encodings[0].active);
7161 EXPECT_FALSE(parameters.encodings[1].active);
7162 EXPECT_FALSE(parameters.encodings[2].active);
7163 // Check that the VideoSendStream is off.
7164 EXPECT_FALSE(fake_video_send_stream->IsSending());
7165 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007166 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007167 EXPECT_FALSE(simulcast_streams[0].active);
7168 EXPECT_FALSE(simulcast_streams[1].active);
7169 EXPECT_FALSE(simulcast_streams[2].active);
7170
Niels Möllerff40b142018-04-09 08:49:14 +02007171 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007172}
7173
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007174// Test that if a stream is reconfigured (due to a codec change or other
7175// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007176TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007177 InactiveStreamDoesntStartSendingWhenReconfigured) {
7178 // Set an initial codec list, which will be modified later.
7179 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007180 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7181 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007182 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7183
7184 FakeVideoSendStream* stream = AddSendStream();
7185 EXPECT_TRUE(channel_->SetSend(true));
7186 EXPECT_TRUE(stream->IsSending());
7187
7188 // Get current parameters and change "active" to false.
7189 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7190 ASSERT_EQ(1u, parameters.encodings.size());
7191 ASSERT_TRUE(parameters.encodings[0].active);
7192 parameters.encodings[0].active = false;
7193 EXPECT_EQ(1u, GetFakeSendStreams().size());
7194 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007195 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007196 EXPECT_FALSE(stream->IsSending());
7197
7198 // Reorder the codec list, causing the stream to be reconfigured.
7199 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007200 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7201 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007202 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7203 auto new_streams = GetFakeSendStreams();
7204 // Assert that a new underlying stream was created due to the codec change.
7205 // Otherwise, this test isn't testing what it set out to test.
7206 EXPECT_EQ(1u, GetFakeSendStreams().size());
7207 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7208
7209 // Verify that we still are not sending anything, due to the inactive
7210 // encoding.
7211 EXPECT_FALSE(new_streams[0]->IsSending());
7212}
7213
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007214// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007215TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007216 AddSendStream();
7217 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007218 parameters.codecs.push_back(GetEngineCodec("VP8"));
7219 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007220 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7221
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007222 webrtc::RtpParameters rtp_parameters =
7223 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007224 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007225 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7226 rtp_parameters.codecs[0]);
7227 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7228 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007229}
7230
Florent Castellidacec712018-05-24 16:24:21 +02007231// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7232TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7233 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7234 params.cname = "rtcpcname";
7235 AddSendStream(params);
7236
7237 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7238 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7239}
7240
deadbeeffb2aced2017-01-06 23:05:37 -08007241// Test that RtpParameters for send stream has one encoding and it has
7242// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007243TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007244 AddSendStream();
7245
7246 webrtc::RtpParameters rtp_parameters =
7247 channel_->GetRtpSendParameters(last_ssrc_);
7248 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007249 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007250}
7251
Florent Castelliabe301f2018-06-12 18:33:49 +02007252TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7253 AddSendStream();
7254
7255 webrtc::RtpParameters rtp_parameters =
7256 channel_->GetRtpSendParameters(last_ssrc_);
7257 rtp_parameters.header_extensions.emplace_back();
7258
7259 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7260
7261 webrtc::RTCError result =
7262 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7263 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7264}
7265
Florent Castelli87b3c512018-07-18 16:00:28 +02007266TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7267 AddSendStream();
7268
Niels Möller805a27e2019-01-21 12:21:27 +01007269 webrtc::test::FrameForwarder frame_forwarder;
7270 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007271
7272 webrtc::RtpParameters rtp_parameters =
7273 channel_->GetRtpSendParameters(last_ssrc_);
7274 EXPECT_EQ(rtp_parameters.degradation_preference,
7275 webrtc::DegradationPreference::BALANCED);
7276 rtp_parameters.degradation_preference =
7277 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7278
7279 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7280
7281 webrtc::RtpParameters updated_rtp_parameters =
7282 channel_->GetRtpSendParameters(last_ssrc_);
7283 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7284 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7285
7286 // Remove the source since it will be destroyed before the channel
7287 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7288}
7289
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007290// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007291TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007292 AddSendStream();
7293 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007294 parameters.codecs.push_back(GetEngineCodec("VP8"));
7295 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007296 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7297
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007298 webrtc::RtpParameters initial_params =
7299 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007300
7301 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007302 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007303
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007304 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7305 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7306}
7307
7308// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007309TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007310 AddRecvStream();
7311 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007312 parameters.codecs.push_back(GetEngineCodec("VP8"));
7313 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007314 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7315
7316 webrtc::RtpParameters rtp_parameters =
7317 channel_->GetRtpReceiveParameters(last_ssrc_);
7318 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007319 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7320 rtp_parameters.codecs[0]);
7321 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7322 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007323}
7324
johan073ece42016-08-26 02:59:47 -07007325#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007326TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007327#else
eladalonf1841382017-06-12 01:16:46 -07007328TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007329#endif
johan3859c892016-08-05 09:19:25 -07007330 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007331 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007332 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007333 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007334 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007335 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007336 parameters.codecs.push_back(kH264sprop2);
7337 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7338
7339 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7340 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7341 webrtc::RtpParameters rtp_parameters =
7342 channel_->GetRtpReceiveParameters(last_ssrc_);
7343 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7344 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7345 ASSERT_EQ(2u, cfg.decoders.size());
7346 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007347 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007348 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007349 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7350 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007351 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007352
7353 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007354 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007355 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007356 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7357 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007358 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007359}
7360
sakal1fd95952016-06-22 00:46:15 -07007361// Test that RtpParameters for receive stream has one encoding and it has
7362// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007363TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007364 AddRecvStream();
7365
7366 webrtc::RtpParameters rtp_parameters =
7367 channel_->GetRtpReceiveParameters(last_ssrc_);
7368 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007369 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007370}
7371
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007372// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007373TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007374 AddRecvStream();
7375 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007376 parameters.codecs.push_back(GetEngineCodec("VP8"));
7377 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007378 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7379
7380 webrtc::RtpParameters initial_params =
7381 channel_->GetRtpReceiveParameters(last_ssrc_);
7382
7383 // We should be able to set the params we just got.
7384 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7385
7386 // ... And this shouldn't change the params returned by
7387 // GetRtpReceiveParameters.
7388 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007389}
7390
deadbeef3bc15102017-04-20 19:25:07 -07007391// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7392// aren't signaled. It should always return an empty "RtpEncodingParameters",
7393// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007394TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007395 // Call necessary methods to configure receiving a default stream as
7396 // soon as it arrives.
7397 cricket::VideoRecvParameters parameters;
7398 parameters.codecs.push_back(GetEngineCodec("VP8"));
7399 parameters.codecs.push_back(GetEngineCodec("VP9"));
7400 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7401
7402 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7403 // stream. Should return nothing.
7404 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7405
7406 // Set a sink for an unsignaled stream.
7407 cricket::FakeVideoRenderer renderer;
7408 // Value of "0" means "unsignaled stream".
7409 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7410
7411 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7412 // in this method means "unsignaled stream".
7413 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7414 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7415 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7416
7417 // Receive VP8 packet.
7418 uint8_t data[kMinRtpPacketLen];
7419 cricket::RtpHeader rtpHeader;
7420 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7421 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7422 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7423 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7424 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007425 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007426
7427 // The |ssrc| member should still be unset.
7428 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7429 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7430 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7431}
7432
eladalonf1841382017-06-12 01:16:46 -07007433void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007434 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007435 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007436
7437 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007438 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007439 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007440 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007441
7442 if (receiver_first) {
7443 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7444 std::vector<FakeVideoReceiveStream*> receive_streams =
7445 fake_call_->GetVideoReceiveStreams();
7446 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007447 // Default local SSRC when we have no sender.
7448 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7449 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007450 }
7451 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7452 if (!receiver_first)
7453 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7454 std::vector<FakeVideoReceiveStream*> receive_streams =
7455 fake_call_->GetVideoReceiveStreams();
7456 ASSERT_EQ(1u, receive_streams.size());
7457 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007458
7459 // Removing first sender should fall back to another (in this case the second)
7460 // local send stream's SSRC.
7461 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7462 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007463 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007464 ASSERT_EQ(1u, receive_streams.size());
7465 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7466
7467 // Removing the last sender should fall back to default local SSRC.
7468 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007469 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007470 ASSERT_EQ(1u, receive_streams.size());
7471 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7472 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007473}
7474
eladalonf1841382017-06-12 01:16:46 -07007475TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007476 TestReceiverLocalSsrcConfiguration(false);
7477}
7478
eladalonf1841382017-06-12 01:16:46 -07007479TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007480 TestReceiverLocalSsrcConfiguration(true);
7481}
7482
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007483class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007484 public:
eladalonf1841382017-06-12 01:16:46 -07007485 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007486 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007487 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7488 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007489 mock_rate_allocator_factory_(
Mirko Bonadei317a1f02019-09-17 17:06:18 +02007490 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007491 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007492 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007493 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007494 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007495 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007496
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007497 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007498 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007499 channel_.reset(engine_.CreateMediaChannel(
7500 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7501 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007502 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007503 last_ssrc_ = 123;
7504 }
7505
7506 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007507 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007508 int capture_width,
7509 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007510 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007511 size_t expected_num_streams,
7512 bool screenshare,
7513 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007514 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007515 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007516 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007517 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007518
Peter Boström0c4e06b2015-10-07 12:23:21 +02007519 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007520 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007521 ssrcs.resize(num_configured_streams);
7522
sprangf24a0642017-02-28 13:23:26 -08007523 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007524 // Send a full-size frame to trigger a stream reconfiguration to use all
7525 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007526 webrtc::test::FrameForwarder frame_forwarder;
7527 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7528 rtc::kNumMicrosecsPerSec / 30);
7529
sprangf24a0642017-02-28 13:23:26 -08007530 VideoOptions options;
7531 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007532 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007533 EXPECT_TRUE(
7534 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007535 // Fetch the latest stream since SetVideoSend() may recreate it if the
7536 // screen content setting is changed.
7537 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007538 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007539 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007540
Zach Stein3ca452b2018-01-18 10:01:24 -08007541 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7542 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7543
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007544 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7545 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007546 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007547
sprang429600d2017-01-26 06:12:26 -08007548 std::vector<webrtc::VideoStream> expected_streams;
Florent Castelli66b38602019-07-10 16:57:57 +02007549 if (num_configured_streams > 1 || conference_mode) {
sprang429600d2017-01-26 06:12:26 -08007550 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007551 num_configured_streams, capture_width, capture_height,
Florent Castelli66b38602019-07-10 16:57:57 +02007552 webrtc::kDefaultBitratePriority, kDefaultQpMax,
7553 screenshare && conference_mode, true);
7554 if (screenshare && conference_mode) {
sprang3ebabf12017-02-16 07:35:22 -08007555 for (const webrtc::VideoStream& stream : expected_streams) {
7556 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007557 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7558 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007559 }
7560 }
sprang429600d2017-01-26 06:12:26 -08007561 } else {
7562 webrtc::VideoStream stream;
7563 stream.width = capture_width;
7564 stream.height = capture_height;
7565 stream.max_framerate = kDefaultVideoMaxFramerate;
Elad Alon80f53b72019-10-11 16:19:43 +02007566 stream.min_bitrate_bps = webrtc::kDefaultMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007567 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007568 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007569 stream.max_qp = kDefaultQpMax;
7570 expected_streams.push_back(stream);
7571 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007572
7573 ASSERT_EQ(expected_streams.size(), video_streams.size());
7574
7575 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007576 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007577 for (size_t i = 0; i < num_streams; ++i) {
7578 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7579 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7580
7581 EXPECT_GT(video_streams[i].max_framerate, 0);
7582 EXPECT_EQ(expected_streams[i].max_framerate,
7583 video_streams[i].max_framerate);
7584
7585 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7586 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7587 video_streams[i].min_bitrate_bps);
7588
7589 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7590 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7591 video_streams[i].target_bitrate_bps);
7592
7593 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7594 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7595 video_streams[i].max_bitrate_bps);
7596
7597 EXPECT_GT(video_streams[i].max_qp, 0);
7598 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7599
Florent Castelli66b38602019-07-10 16:57:57 +02007600 EXPECT_EQ(num_configured_streams > 1 || conference_mode,
Sergey Silkina796a7e2018-03-01 15:11:29 +01007601 expected_streams[i].num_temporal_layers.has_value());
7602
7603 if (conference_mode) {
7604 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7605 video_streams[i].num_temporal_layers);
7606 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007607
7608 if (i == num_streams - 1) {
7609 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7610 } else {
7611 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7612 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007613 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007614
Niels Möllerff40b142018-04-09 08:49:14 +02007615 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007616 }
7617
7618 FakeVideoSendStream* AddSendStream() {
7619 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7620 }
7621
7622 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007623 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007624 EXPECT_TRUE(channel_->AddSendStream(sp));
7625 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007626 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007627 EXPECT_EQ(num_streams + 1, streams.size());
7628 return streams[streams.size() - 1];
7629 }
7630
7631 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007632 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007633 }
7634
7635 FakeVideoReceiveStream* AddRecvStream() {
7636 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7637 }
7638
7639 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007640 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007641 EXPECT_TRUE(channel_->AddRecvStream(sp));
7642 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007643 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007644 EXPECT_EQ(num_streams + 1, streams.size());
7645 return streams[streams.size() - 1];
7646 }
7647
Danil Chapovalov83bbe912019-08-07 12:24:53 +02007648 webrtc::RtcEventLogNull event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007649 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007650 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7651 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007652 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7653 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007654 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007655 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007656 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007657};
7658
eladalonf1841382017-06-12 01:16:46 -07007659TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007660 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7661 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007662}
7663
eladalonf1841382017-06-12 01:16:46 -07007664TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007665 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7666 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007667}
7668
7669// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007670TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007671 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7672 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007673}
sprang429600d2017-01-26 06:12:26 -08007674
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007675TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Florent Castelli66b38602019-07-10 16:57:57 +02007676 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007677 false);
7678}
7679
eladalonf1841382017-06-12 01:16:46 -07007680TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007681 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7682 true);
7683}
7684
Florent Castelli66b38602019-07-10 16:57:57 +02007685TEST_F(WebRtcVideoChannelSimulcastTest, SimulcastScreenshareWithoutConference) {
7686 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
sprangfe627f32017-03-29 08:24:59 -07007687 false);
7688}
7689
Chen Xing90f3b892019-06-25 10:16:14 +02007690TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7691 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007692
Chen Xing90f3b892019-06-25 10:16:14 +02007693 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007694 EXPECT_TRUE(SetDefaultCodec());
7695 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007696 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007697
Chen Xing90f3b892019-06-25 10:16:14 +02007698 // Send and receive one frame.
7699 SendFrame();
7700 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007701
Chen Xing90f3b892019-06-25 10:16:14 +02007702 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7703 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7704 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007705
Chen Xing90f3b892019-06-25 10:16:14 +02007706 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7707 EXPECT_EQ(source.source_id(), kSsrc);
7708 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7709 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7710 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007711
Chen Xing90f3b892019-06-25 10:16:14 +02007712 // Send and receive another frame.
7713 SendFrame();
7714 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007715
Chen Xing90f3b892019-06-25 10:16:14 +02007716 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7717 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7718 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007719
Chen Xing90f3b892019-06-25 10:16:14 +02007720 source = channel_->GetSources(kSsrc)[0];
7721 EXPECT_EQ(source.source_id(), kSsrc);
7722 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7723 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7724 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007725
Chen Xing90f3b892019-06-25 10:16:14 +02007726 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7727 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007728}
7729
Amit Hilbuchb000b712019-02-25 10:22:14 -08007730TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7731 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7732
7733 std::vector<std::string> rids = {"f", "h", "q"};
7734 std::vector<cricket::RidDescription> rid_descriptions;
7735 for (const auto& rid : rids) {
7736 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7737 }
7738 sp.set_rids(rid_descriptions);
7739
7740 ASSERT_TRUE(channel_->AddSendStream(sp));
7741 const auto& streams = fake_call_->GetVideoSendStreams();
7742 ASSERT_EQ(1u, streams.size());
7743 auto stream = streams[0];
7744 ASSERT_NE(stream, nullptr);
7745 const auto& config = stream->GetConfig();
7746 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7747}
7748
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007749} // namespace cricket