blob: 36a0e14a387408f971ef2e5784497bd86e854bdf [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller039743e2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Seth Hampson24722b32017-12-22 09:36:42 -080018#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070019#include "api/test/mock_video_decoder_factory.h"
20#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020021#include "api/units/time_delta.h"
Åsa Persson23eba222018-10-02 14:47:06 +020022#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020023#include "api/video_codecs/builtin_video_decoder_factory.h"
24#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020025#include "api/video_codecs/sdp_video_format.h"
26#include "api/video_codecs/video_decoder_factory.h"
27#include "api/video_codecs/video_encoder.h"
28#include "api/video_codecs/video_encoder_factory.h"
29#include "call/flexfec_receive_stream.h"
30#include "common_video/h264/profile_level_id.h"
31#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020032#include "media/base/fakenetworkinterface.h"
33#include "media/base/fakevideocapturer.h"
34#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/base/mediaconstants.h"
36#include "media/base/rtputils.h"
37#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020038#include "media/engine/constants.h"
39#include "media/engine/fakewebrtccall.h"
40#include "media/engine/fakewebrtcvideoengine.h"
41#include "media/engine/simulcast.h"
42#include "media/engine/webrtcvideoengine.h"
43#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020044#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020045#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020046#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020047#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020048#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "rtc_base/stringutils.h"
50#include "test/field_trial.h"
51#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000052
Tommi85959932018-02-07 19:26:06 +010053using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010054using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070055using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010056using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070057
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000058namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000059static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000060
noahricd10a68e2015-07-10 11:27:55 -070061static const uint8_t kRedRtxPayloadType = 125;
62
Niels Möller6557d0c2018-04-11 15:18:34 +020063static const uint32_t kTimeout = 5000U;
64static const uint32_t kDefaultReceiveSsrc = 0;
65static const uint32_t kSsrc = 1234u;
66static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
67static const int kVideoWidth = 640;
68static const int kVideoHeight = 360;
69static const int kFramerate = 30;
70
Peter Boström0c4e06b2015-10-07 12:23:21 +020071static const uint32_t kSsrcs1[] = {1};
72static const uint32_t kSsrcs3[] = {1, 2, 3};
73static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080074static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020075static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080076static const uint32_t kDefaultRecvSsrc = 0;
77
pbos@webrtc.org3c107582014-07-20 15:27:35 +000078static const char kUnsupportedExtensionName[] =
79 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000080
magjed509e4fe2016-11-18 01:34:11 -080081cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
82 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020083 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080084}
85
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000086void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
87 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
88 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
89 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
90 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
91 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
92 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
93 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080094 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
95 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000096 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
97}
98
magjed725e4842016-11-16 00:48:13 -080099// Return true if any codec in |codecs| is an RTX codec with associated payload
100// type |payload_type|.
101bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
102 int payload_type) {
103 for (const cricket::VideoCodec& codec : codecs) {
104 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200105 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800106 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
107 &associated_payload_type) &&
108 associated_payload_type == payload_type) {
109 return true;
110 }
111 }
112 return false;
113}
114
nisseca5706d2017-09-11 02:32:16 -0700115// TODO(nisse): Duplicated in call.cc.
116const int* FindKeyByValue(const std::map<int, int>& m, int v) {
117 for (const auto& kv : m) {
118 if (kv.second == v)
119 return &kv.first;
120 }
121 return nullptr;
122}
123
Yves Gerey665174f2018-06-19 15:03:05 +0200124bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
125 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700126 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
127 payload_type) != nullptr;
128}
129
130// Check that there's an Rtx payload type for each decoder.
131bool VerifyRtxReceiveAssociations(
132 const webrtc::VideoReceiveStream::Config& config) {
133 for (const auto& decoder : config.decoders) {
134 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
135 return false;
136 }
137 return true;
138}
139
brandtrffc61182016-11-28 06:02:22 -0800140rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700141 int width,
142 int height) {
143 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
144 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800145 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700146 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000147}
148
Shao Changbine62202f2015-04-21 20:24:50 +0800149void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
150 const std::map<int, int>& rtx_types) {
151 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200152 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800153 EXPECT_TRUE(it != rtx_types.end() &&
154 it->second == config.rtp.rtx.payload_type);
155
brandtrb5f2c3f2016-10-04 23:28:39 -0700156 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
157 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800158 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700159 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800160 }
161}
kthelgason2bc68642017-02-07 07:02:22 -0800162
163cricket::MediaConfig GetMediaConfig() {
164 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100165 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800166 return media_config;
167}
nisse26e3abb2017-08-25 04:44:25 -0700168
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200169// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
170int GetMaxDefaultBitrateBps(size_t width, size_t height) {
171 if (width * height <= 320 * 240) {
172 return 600000;
173 } else if (width * height <= 640 * 480) {
174 return 1700000;
175 } else if (width * height <= 960 * 540) {
176 return 2000000;
177 } else {
178 return 2500000;
179 }
180}
181
Niels Möller731a2c22018-07-30 15:08:07 +0200182class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
183 public:
184 MOCK_METHOD2(AddOrUpdateSink,
185 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
186 const rtc::VideoSinkWants& wants));
187 MOCK_METHOD1(RemoveSink,
188 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
189};
190
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000191} // namespace
192
Yves Gerey665174f2018-06-19 15:03:05 +0200193#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200194 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200195 EXPECT_EQ((w), renderer_.width()); \
196 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200197 EXPECT_EQ(0, renderer_.errors());
198
Yves Gerey665174f2018-06-19 15:03:05 +0200199#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200201 EXPECT_EQ((w), (r).width()); \
202 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ(0, (r).errors());
204
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000205namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700206class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000207 public:
eladalonf1841382017-06-12 01:16:46 -0700208 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
209 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700210 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700211 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200212 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
213 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200214 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200215 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200216 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200217 decoder_factory_)) {
218 // Ensure fake clock doesn't return 0, which will cause some initializations
219 // fail inside RTP senders.
220 fake_clock_.AdvanceTimeMicros(1);
221 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000222
223 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200224 void AssignDefaultAptRtxTypes();
225 void AssignDefaultCodec();
226
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100227 // Find the index of the codec in the engine with the given name. The codec
228 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100229 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100230
magjed509e4fe2016-11-18 01:34:11 -0800231 // Find the codec in the engine with the given name. The codec must be
232 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100233 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800234
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200235 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000236
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200237 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000238 const std::vector<VideoCodec>& codecs);
239
Peter Boströme4499152016-02-05 11:13:28 +0100240 void TestExtendedEncoderOveruse(bool use_external_encoder);
241
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200242 // Has to be the first one, so it is initialized before the call or there is a
243 // race condition in the clock access.
244 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700245 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700246 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700247 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000248 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800249 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200250 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
251 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700252 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000253 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800254 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000255};
256
eladalonf1841382017-06-12 01:16:46 -0700257TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200258 encoder_factory_->AddSupportedVideoCodecType("VP8");
259 AssignDefaultCodec();
260
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000261 std::vector<VideoCodec> engine_codecs = engine_.codecs();
262 for (size_t i = 0; i < engine_codecs.size(); ++i) {
263 if (engine_codecs[i].name != kRtxCodecName)
264 continue;
265 int associated_payload_type;
266 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000267 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000268 EXPECT_EQ(default_codec_.id, associated_payload_type);
269 return;
270 }
271 FAIL() << "No RTX codec found among default codecs.";
272}
273
eladalonf1841382017-06-12 01:16:46 -0700274TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100275 RtpCapabilities capabilities = engine_.GetCapabilities();
276 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700277 for (const RtpExtension& extension : capabilities.header_extensions) {
278 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
279 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000280 return;
281 }
282 }
283 FAIL() << "Timestamp offset extension not in header-extension list.";
284}
285
eladalonf1841382017-06-12 01:16:46 -0700286TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100287 RtpCapabilities capabilities = engine_.GetCapabilities();
288 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700289 for (const RtpExtension& extension : capabilities.header_extensions) {
290 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
291 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000292 return;
293 }
294 }
295 FAIL() << "Absolute Sender Time extension not in header-extension list.";
296}
297
eladalonf1841382017-06-12 01:16:46 -0700298TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100299 RtpCapabilities capabilities = engine_.GetCapabilities();
300 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700301 for (const RtpExtension& extension : capabilities.header_extensions) {
302 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
303 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700304 return;
305 }
306 }
307 FAIL() << "Transport sequence number extension not in header-extension list.";
308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100311 RtpCapabilities capabilities = engine_.GetCapabilities();
312 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700313 for (const RtpExtension& extension : capabilities.header_extensions) {
314 if (extension.uri == RtpExtension::kVideoRotationUri) {
315 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700316 return;
317 }
318 }
319 FAIL() << "Video Rotation extension not in header-extension list.";
320}
321
philipel1e054862018-10-08 16:13:53 +0200322class WebRtcVideoEngineTestWithGenericDescriptor
323 : public WebRtcVideoEngineTest {
324 public:
325 WebRtcVideoEngineTestWithGenericDescriptor()
326 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
327};
328
329TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
330 RtpCapabilities capabilities = engine_.GetCapabilities();
331 ASSERT_FALSE(capabilities.header_extensions.empty());
332 for (const RtpExtension& extension : capabilities.header_extensions) {
333 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
334 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
335 return;
336 }
337 }
338 FAIL() << "Generic descriptor extension not in header-extension list.";
339}
340
eladalonf1841382017-06-12 01:16:46 -0700341TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200342 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700343 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200344 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700345
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200346 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200348 std::unique_ptr<VideoMediaChannel> channel(
349 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700350 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
351
352 // Add CVO extension.
353 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800354 cricket::VideoSendParameters parameters;
355 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200356 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700357 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200358 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359
Niels Möller731a2c22018-07-30 15:08:07 +0200360 EXPECT_CALL(
361 video_source,
362 AddOrUpdateSink(testing::_,
363 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700364 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200365 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366
367 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200368 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369
370 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200371 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200372 EXPECT_CALL(
373 video_source,
374 AddOrUpdateSink(testing::_,
375 Field(&rtc::VideoSinkWants::rotation_applied, true)));
376
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200377 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378}
379
eladalonf1841382017-06-12 01:16:46 -0700380TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200381 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800382 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200383 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800384
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200385 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800386
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200387 std::unique_ptr<VideoMediaChannel> channel(
388 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800389 // Add CVO extension.
390 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800391 cricket::VideoSendParameters parameters;
392 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800393 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700394 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800395 EXPECT_TRUE(channel->SetSendParameters(parameters));
396 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
397
Niels Möller731a2c22018-07-30 15:08:07 +0200398 // Set source.
399 EXPECT_CALL(
400 video_source,
401 AddOrUpdateSink(testing::_,
402 Field(&rtc::VideoSinkWants::rotation_applied, false)));
403 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800404}
405
eladalonf1841382017-06-12 01:16:46 -0700406TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200407 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700408
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200409 encoder_factory_->AddSupportedVideoCodecType("VP8");
410 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700411
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200412 std::unique_ptr<VideoMediaChannel> channel(
413 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700414 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
415
416 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200417 EXPECT_CALL(
418 video_source,
419 AddOrUpdateSink(testing::_,
420 Field(&rtc::VideoSinkWants::rotation_applied, true)));
421 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700422
perkjcaafdba2016-03-20 07:34:29 -0700423 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200424 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700425
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700426 // Add CVO extension.
427 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800428 cricket::VideoSendParameters parameters;
429 parameters.codecs.push_back(GetEngineCodec("VP8"));
430 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200431 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700432 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700433 // Also remove the first codec to trigger a codec change as well.
434 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200435 EXPECT_CALL(
436 video_source,
437 AddOrUpdateSink(testing::_,
438 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200439 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440
441 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200442 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700443
444 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200445 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200446 EXPECT_CALL(
447 video_source,
448 AddOrUpdateSink(testing::_,
449 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200450 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700451}
452
eladalonf1841382017-06-12 01:16:46 -0700453TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200454 encoder_factory_->AddSupportedVideoCodecType("VP8");
455
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700456 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
457 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000458
459 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
460
461 EXPECT_FALSE(channel->SetSend(true))
462 << "Channel should not start without codecs.";
463 EXPECT_TRUE(channel->SetSend(false))
464 << "Channel should be stoppable even without set codecs.";
465}
466
eladalonf1841382017-06-12 01:16:46 -0700467TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200468 encoder_factory_->AddSupportedVideoCodecType("VP8");
469
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700470 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
471 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000472 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
473 VideoMediaInfo info;
474 channel->GetStats(&info);
475}
476
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200477TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200478 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000479
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200480 std::unique_ptr<VideoMediaChannel> channel(
481 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800482 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000483
484 EXPECT_TRUE(
485 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200486 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000487 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100488 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200489 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000490 EXPECT_EQ(cricket::CS_RUNNING,
491 capturer.Start(capturer.GetSupportedFormats()->front()));
492 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100493 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
495 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000496 kTimeout);
497
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200498 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100499 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000500
501 // Setting codecs of the same type should not reallocate any encoders
502 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800503 cricket::VideoSendParameters parameters;
504 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200505 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507
508 // Remove stream previously added to free the external encoder instance.
509 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511}
512
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200513// Test that when an encoder factory supports H264, we add an RTX
514// codec for it.
515// TODO(deadbeef): This test should be updated if/when we start
516// adding RTX codecs for unrecognized codec names.
517TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800518 using webrtc::H264::ProfileLevelIdToString;
519 using webrtc::H264::ProfileLevelId;
520 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200521 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
522 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800523 *ProfileLevelIdToString(
524 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200525 webrtc::SdpVideoFormat h264_constrained_high("H264");
526 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800527 *ProfileLevelIdToString(
528 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200529 webrtc::SdpVideoFormat h264_high("H264");
530 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800531 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
532
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200533 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
534 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
535 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700536
magjed725e4842016-11-16 00:48:13 -0800537 // First figure out what payload types the test codecs got assigned.
538 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800539 // Now search for RTX codecs for them. Expect that they all have associated
540 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800541 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200542 codecs,
543 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
544 ->id));
magjed725e4842016-11-16 00:48:13 -0800545 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200546 codecs,
547 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
548 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800549 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200550 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700551}
552
Peter Boström12996152016-05-14 02:03:18 +0200553#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700554TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200555 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100556
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200557 std::unique_ptr<VideoMediaChannel> channel(
558 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100559
560 EXPECT_TRUE(
561 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
562}
Peter Boström12996152016-05-14 02:03:18 +0200563#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100564
eladalonf1841382017-06-12 01:16:46 -0700565TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200566 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100567 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200568 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200569 std::unique_ptr<VideoMediaChannel> channel(
570 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700571
572 EXPECT_TRUE(
573 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
574
Tommi85959932018-02-07 19:26:06 +0100575 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200576 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700577 capturer.Start(cricket::VideoFormat(1280, 720,
578 cricket::VideoFormat::FpsToInterval(60),
579 cricket::FOURCC_I420));
580 channel->SetSend(true);
581
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200582 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700583
584 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700585 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700586 for (int i = 0; i < 10; i++) {
587 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700588 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700589 int64_t interval = timestamp - last_timestamp;
590
591 // Precision changes from nanosecond to millisecond.
592 // Allow error to be no more than 1.
593 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
594
595 last_timestamp = timestamp;
596 }
597
598 capturer.Start(cricket::VideoFormat(1280, 720,
599 cricket::VideoFormat::FpsToInterval(30),
600 cricket::FOURCC_I420));
601
602 EXPECT_TRUE(capturer.CaptureFrame());
603 last_timestamp = stream->GetLastTimestamp();
604 for (int i = 0; i < 10; i++) {
605 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700606 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700607 int64_t interval = timestamp - last_timestamp;
608
609 // Precision changes from nanosecond to millisecond.
610 // Allow error to be no more than 1.
611 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
612
613 last_timestamp = timestamp;
614 }
615
616 // Remove stream previously added to free the external encoder instance.
617 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
618}
619
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200620void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
621 std::vector<VideoCodec> engine_codecs = engine_.codecs();
622 RTC_DCHECK(!engine_codecs.empty());
623 for (const cricket::VideoCodec& codec : engine_codecs) {
624 if (codec.name == "rtx") {
625 int associated_payload_type;
626 if (codec.GetParam(kCodecParamAssociatedPayloadType,
627 &associated_payload_type)) {
628 default_apt_rtx_types_[associated_payload_type] = codec.id;
629 }
630 }
631 }
632}
633
634void WebRtcVideoEngineTest::AssignDefaultCodec() {
635 std::vector<VideoCodec> engine_codecs = engine_.codecs();
636 RTC_DCHECK(!engine_codecs.empty());
637 bool codec_set = false;
638 for (const cricket::VideoCodec& codec : engine_codecs) {
639 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
640 codec.name != "ulpfec") {
641 default_codec_ = codec;
642 codec_set = true;
643 }
644 }
645
646 RTC_DCHECK(codec_set);
647}
648
Oleh Prypina40f8242017-12-21 13:32:23 +0100649size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
650 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100651 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
652 for (size_t i = 0; i < codecs.size(); ++i) {
653 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200654 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200655 continue;
656 // The tests only use H264 Constrained Baseline. Make sure we don't return
657 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200658 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200659 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200660 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
661 if (profile_level_id->profile !=
662 webrtc::H264::kProfileConstrainedBaseline) {
663 continue;
664 }
665 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 return i;
magjed509e4fe2016-11-18 01:34:11 -0800667 }
668 // This point should never be reached.
669 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100670 return -1;
671}
672
673cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
674 const std::string& name) const {
675 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800676}
677
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200678VideoMediaChannel*
679WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700680 VideoMediaChannel* channel = engine_.CreateChannel(
681 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200682 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800683 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200684 for (const webrtc::SdpVideoFormat& format :
685 encoder_factory_->GetSupportedFormats()) {
686 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
687 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
688 engine_codec) == parameters.codecs.end()) {
689 parameters.codecs.push_back(engine_codec);
690 }
691 }
magjed509e4fe2016-11-18 01:34:11 -0800692
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200693 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000694
695 return channel;
696}
697
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200698VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000699 const std::vector<VideoCodec>& codecs) {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700700 VideoMediaChannel* channel = engine_.CreateChannel(
701 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200702 cricket::VideoRecvParameters parameters;
703 parameters.codecs = codecs;
704 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000705
706 return channel;
707}
708
eladalonf1841382017-06-12 01:16:46 -0700709TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200710 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000711
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200712 std::unique_ptr<VideoMediaChannel> channel(
713 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714
Peter Boström0c4e06b2015-10-07 12:23:21 +0200715 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000716
Yves Gerey665174f2018-06-19 15:03:05 +0200717 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000718 EXPECT_TRUE(channel->SetSend(true));
719
Tommi85959932018-02-07 19:26:06 +0100720 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200721 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000722 EXPECT_EQ(cricket::CS_RUNNING,
723 capturer.Start(capturer.GetSupportedFormats()->front()));
724 EXPECT_TRUE(capturer.CaptureFrame());
725
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200726 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000727
728 // Verify that encoders are configured for simulcast through adapter
729 // (increasing resolution and only configured to send one stream each).
730 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200731 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
732 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000733 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200734 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000735 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
736 EXPECT_GT(codec_settings.width, prev_width);
737 prev_width = codec_settings.width;
738 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000739
Niels Möllerff40b142018-04-09 08:49:14 +0200740 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000741
742 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200743 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000744}
745
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200746TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
747 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200748 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000749
Niels Möller4db138e2018-04-19 09:04:13 +0200750 // Set capturer.
751 FakeVideoCapturerWithTaskQueue capturer;
752 EXPECT_EQ(cricket::CS_RUNNING,
753 capturer.Start(capturer.GetSupportedFormats()->front()));
754
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700755 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
756 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200757 cricket::VideoSendParameters parameters;
758 parameters.codecs.push_back(GetEngineCodec("H264"));
759 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000760
761 EXPECT_TRUE(
762 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200763 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
764 // Sending one frame will have allocate the encoder.
765 EXPECT_TRUE(capturer.CaptureFrame());
766
767 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000768
Anders Carlsson67537952018-05-03 11:28:29 +0200769 cricket::VideoSendParameters new_parameters;
770 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
771 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200772
773 // Sending one frame will switch encoder.
774 EXPECT_TRUE(capturer.CaptureFrame());
775
Anders Carlsson8a150d92018-05-14 12:40:04 +0200776 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000777}
778
eladalonf1841382017-06-12 01:16:46 -0700779TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000780 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200781 encoder_factory_->AddSupportedVideoCodecType("VP8");
782 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000783
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700784 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
785 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800786 cricket::VideoSendParameters parameters;
787 parameters.codecs.push_back(GetEngineCodec("VP8"));
788 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000789
Peter Boström0c4e06b2015-10-07 12:23:21 +0200790 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000791
Yves Gerey665174f2018-06-19 15:03:05 +0200792 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000793 EXPECT_TRUE(channel->SetSend(true));
794
795 // Send a fake frame, or else the media engine will configure the simulcast
796 // encoder adapter at a low-enough size that it'll only create a single
797 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100798 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200799 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000800 EXPECT_EQ(cricket::CS_RUNNING,
801 capturer.Start(capturer.GetSupportedFormats()->front()));
802 EXPECT_TRUE(capturer.CaptureFrame());
803
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200804 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
805 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000806 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808
809 channel.reset();
810 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000812}
813
eladalonf1841382017-06-12 01:16:46 -0700814TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000815 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200816 encoder_factory_->AddSupportedVideoCodecType("VP8");
817 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000818
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700819 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
820 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800821 cricket::VideoSendParameters parameters;
822 parameters.codecs.push_back(GetEngineCodec("H264"));
823 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824
825 EXPECT_TRUE(
826 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100827
828 // Send a frame of 720p. This should trigger a "real" encoder initialization.
829 cricket::VideoFormat format(
830 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100831 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200832 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100833 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
834 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200835 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
836 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200837 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000838 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200839 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000840
841 channel.reset();
842 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200843 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000844}
845
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200846TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
847 webrtc::test::ScopedFieldTrials override_field_trials_(
848 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200849 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700850
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700851 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
852 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200853 cricket::VideoSendParameters parameters;
854 parameters.codecs.push_back(GetEngineCodec("H264"));
855 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700856
Peter Boström0c4e06b2015-10-07 12:23:21 +0200857 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700858 EXPECT_TRUE(
859 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100860
861 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700862 cricket::VideoFormat format(
863 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100864 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200865 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100866 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
867 EXPECT_TRUE(capturer.CaptureFrame());
868
Niels Möller4db138e2018-04-19 09:04:13 +0200869 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200870 ASSERT_EQ(1u, encoder_factory_->encoders().size());
871 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
872 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700873 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200874 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200875 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700876}
877
brandtrffc61182016-11-28 06:02:22 -0800878// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700879// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800880//
881// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700882TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800883 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200884 encoder_factory_->AddSupportedVideoCodecType("VP8");
885
brandtrffc61182016-11-28 06:02:22 -0800886 auto is_flexfec = [](const VideoCodec& codec) {
887 if (codec.name == "flexfec-03")
888 return true;
889 return false;
890 };
891
892 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800893 const std::vector<VideoCodec> codecs_before = engine_.codecs();
894 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
895 codecs_before.end(), is_flexfec));
896
897 // FlexFEC is active with field trial.
898 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800899 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800900 const std::vector<VideoCodec> codecs_after = engine_.codecs();
901 EXPECT_NE(codecs_after.end(),
902 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
903}
904
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200905// Test that codecs are added in the order they are reported from the factory.
906TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
907 encoder_factory_->AddSupportedVideoCodecType("VP8");
908 const char* kFakeCodecName = "FakeCodec";
909 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000910
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200911 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100912 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200913 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
914 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000915}
916
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200917// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800918// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200919TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100920 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
921 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100922
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100923 // Set up external encoder factory with first codec, and initialize engine.
924 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
925
brandtrffc61182016-11-28 06:02:22 -0800926 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800927
928 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100929 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800930 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200931 // The codec itself and RTX should have been added.
932 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100933
934 // Check that both fake codecs are present and that the second fake codec
935 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100936 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
937 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100938 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800939}
940
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200941TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
942 const char* kFakeCodecName = "FakeCodec";
943 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
944
945 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
946 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
947}
948
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200949TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
950 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200951 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200952 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800953 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000954
kwiberg686a8ef2016-02-26 03:00:35 -0800955 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200956 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000957
958 EXPECT_TRUE(
959 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200960 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
962 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200963 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200964 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965
966 // Remove stream previously added to free the external decoder instance.
967 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200968 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000969}
970
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200971// Verifies that we can set up decoders.
972TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000973 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
974 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
975 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
976 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200977 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200978 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000979 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800980 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000981
kwiberg686a8ef2016-02-26 03:00:35 -0800982 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200983 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000984
985 EXPECT_TRUE(
986 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200987 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000988}
989
Jonas Oreland49ac5952018-09-26 16:04:32 +0200990// Tests when GetSources is called with non-existing ssrc, it will return an
991// empty list of RtpSource without crashing.
992TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
993 // Setup an recv stream with |kSsrc|.
994 encoder_factory_->AddSupportedVideoCodecType("VP8");
995 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
996 cricket::VideoRecvParameters parameters;
997 parameters.codecs.push_back(GetEngineCodec("VP8"));
998 std::unique_ptr<VideoMediaChannel> channel(
999 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1000
1001 EXPECT_TRUE(
1002 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1003
1004 // Call GetSources with |kSsrc + 1| which doesn't exist.
1005 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1006 EXPECT_EQ(0u, sources.size());
1007}
1008
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001009TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1010 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1011 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1012 WebRtcVideoEngine engine(std::move(encoder_factory),
1013 std::move(decoder_factory));
1014 EXPECT_EQ(0u, engine.codecs().size());
1015}
1016
1017TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1018 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001019 webrtc::MockVideoEncoderFactory* encoder_factory =
1020 new webrtc::MockVideoEncoderFactory();
1021 webrtc::MockVideoDecoderFactory* decoder_factory =
1022 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001023 WebRtcVideoEngine engine(
1024 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1025 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1026 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1027 EXPECT_EQ(0u, engine.codecs().size());
1028 EXPECT_CALL(*encoder_factory, Die());
1029 EXPECT_CALL(*decoder_factory, Die());
1030}
1031
1032// Test full behavior in the video engine when video codec factories of the new
1033// type are injected supporting the single codec Vp8. Check the returned codecs
1034// from the engine and that we will create a Vp8 encoder and decoder using the
1035// new factories.
1036TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1037 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001038 webrtc::MockVideoEncoderFactory* encoder_factory =
1039 new webrtc::MockVideoEncoderFactory();
1040 webrtc::MockVideoDecoderFactory* decoder_factory =
1041 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001042 WebRtcVideoEngine engine(
1043 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1044 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1045 const webrtc::SdpVideoFormat vp8_format("VP8");
1046 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1047 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1048 .WillRepeatedly(testing::Return(supported_formats));
1049
1050 // Verify the codecs from the engine.
1051 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001052 // Verify default codecs has been added correctly.
1053 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001054 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001055
1056 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001058 int vp8_associated_payload;
1059 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1060 &vp8_associated_payload));
1061 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1062
1063 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1064
1065 // RTX codec for RED.
1066 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1067 int red_associated_payload;
1068 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1069 &red_associated_payload));
1070 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1071
1072 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1073
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001074 int associated_payload_type;
1075 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1076 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1077 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1078 // Verify default parameters has been added to the VP8 codec.
1079 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1080
1081 // Mock encoder creation. |engine| take ownership of the encoder.
1082 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1083 codec_info.is_hardware_accelerated = false;
1084 codec_info.has_internal_source = false;
1085 const webrtc::SdpVideoFormat format("VP8");
1086 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1087 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001088 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001089 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001090 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001091 .WillOnce(
1092 ::testing::DoAll(::testing::InvokeWithoutArgs(
1093 [&encoder_created]() { encoder_created.Set(); }),
1094 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095
1096 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001097 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001098 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1099 .WillOnce(testing::Return(decoder));
1100
1101 // Create a call.
1102 webrtc::RtcEventLogNullImpl event_log;
1103 std::unique_ptr<webrtc::Call> call(
1104 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1105
1106 // Create send channel.
1107 const int send_ssrc = 123;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001108 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateChannel(
1109 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001110 cricket::VideoSendParameters send_parameters;
1111 send_parameters.codecs.push_back(engine_codecs.at(0));
1112 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1113 send_channel->OnReadyToSend(true);
1114 EXPECT_TRUE(
1115 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1116 EXPECT_TRUE(send_channel->SetSend(true));
1117
Niels Möller4db138e2018-04-19 09:04:13 +02001118 // Set capturer.
1119 FakeVideoCapturerWithTaskQueue capturer;
1120 EXPECT_EQ(cricket::CS_RUNNING,
1121 capturer.Start(capturer.GetSupportedFormats()->front()));
1122 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1123 // Sending one frame will allocate the encoder.
1124 EXPECT_TRUE(capturer.CaptureFrame());
1125 encoder_created.Wait(kTimeout);
1126
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127 // Create recv channel.
1128 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001129 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1130 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001131 cricket::VideoRecvParameters recv_parameters;
1132 recv_parameters.codecs.push_back(engine_codecs.at(0));
1133 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1134 EXPECT_TRUE(recv_channel->AddRecvStream(
1135 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1136
1137 // Remove streams previously added to free the encoder and decoder instance.
1138 EXPECT_CALL(*encoder_factory, Die());
1139 EXPECT_CALL(*decoder_factory, Die());
1140 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1141 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1142}
1143
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001144// Test behavior when decoder factory fails to create a decoder (returns null).
1145TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1146 // |engine| take ownership of the factories.
1147 webrtc::MockVideoEncoderFactory* encoder_factory =
1148 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1149 webrtc::MockVideoDecoderFactory* decoder_factory =
1150 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1151 WebRtcVideoEngine engine(
1152 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1153 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1154 const webrtc::SdpVideoFormat vp8_format("VP8");
1155 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1156 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1157 .WillRepeatedly(testing::Return(supported_formats));
1158
1159 // Decoder creation fails.
1160 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1161 .WillOnce(testing::Return(nullptr));
1162
1163 // Create a call.
1164 webrtc::RtcEventLogNullImpl event_log;
1165 std::unique_ptr<webrtc::Call> call(
1166 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1167
1168 // Create recv channel.
1169 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001170 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1171 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001172 cricket::VideoRecvParameters recv_parameters;
1173 recv_parameters.codecs.push_back(engine.codecs().front());
1174 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1175 EXPECT_TRUE(recv_channel->AddRecvStream(
1176 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1177
1178 // Remove streams previously added to free the encoder and decoder instance.
1179 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1180}
1181
eladalonf1841382017-06-12 01:16:46 -07001182TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001183 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001184 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001185 std::unique_ptr<VideoMediaChannel> channel(
1186 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001187 ASSERT_TRUE(
1188 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1189 cricket::VideoCodec codec = GetEngineCodec("VP8");
1190 cricket::VideoSendParameters parameters;
1191 parameters.codecs.push_back(codec);
1192 channel->OnReadyToSend(true);
1193 channel->SetSend(true);
1194 ASSERT_TRUE(channel->SetSendParameters(parameters));
1195
Tommi85959932018-02-07 19:26:06 +01001196 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001197 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001198 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001199
1200 EXPECT_EQ(cricket::CS_RUNNING,
1201 capturer.Start(capturer.GetSupportedFormats()->front()));
1202 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001203 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001204 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001205 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001206
Niels Möllerff40b142018-04-09 08:49:14 +02001207 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001208 EXPECT_TRUE(capturer.CaptureFrame());
1209 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001210 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001211
1212 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001213 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001214 EXPECT_TRUE(capturer.CaptureFrame());
1215 // Change to screen content, recreate encoder. For the simulcast encoder
1216 // adapter case, this will result in two calls since InitEncode triggers a
1217 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001218 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001219 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001220 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001221
Niels Möllerff40b142018-04-09 08:49:14 +02001222 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001223 EXPECT_TRUE(capturer.CaptureFrame());
1224 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001225 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001226
1227 options.is_screencast.emplace(false);
1228 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001229 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001230 // Change back to regular video content, update encoder. Also change
1231 // a non |is_screencast| option just to verify it doesn't affect recreation.
1232 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001233 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001234 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001235 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001236
1237 // Remove stream previously added to free the external encoder instance.
1238 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001239 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001240}
1241
Niels Möller6557d0c2018-04-11 15:18:34 +02001242class WebRtcVideoChannelBaseTest : public testing::Test {
1243 protected:
1244 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001245 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001246 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001247
1248 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001249 // One testcase calls SetUp in a loop, only create call_ once.
1250 if (!call_) {
1251 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1252 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001253 cricket::MediaConfig media_config;
1254 // Disabling cpu overuse detection actually disables quality scaling too; it
1255 // implies DegradationPreference kMaintainResolution. Automatic scaling
1256 // needs to be disabled, otherwise, tests which check the size of received
1257 // frames become flaky.
1258 media_config.video.enable_cpu_adaptation = false;
1259 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001260 cricket::VideoOptions(),
1261 webrtc::CryptoOptions()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001262 channel_->OnReadyToSend(true);
1263 EXPECT_TRUE(channel_.get() != NULL);
1264 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001265 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001266 cricket::VideoRecvParameters parameters;
1267 parameters.codecs = engine_.codecs();
1268 channel_->SetRecvParameters(parameters);
1269 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1270 video_capturer_.reset(CreateFakeVideoCapturer());
1271 cricket::VideoFormat format(640, 480,
1272 cricket::VideoFormat::FpsToInterval(kFramerate),
1273 cricket::FOURCC_I420);
1274 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001275 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001276 }
1277
1278 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1279 return new cricket::FakeVideoCapturerWithTaskQueue();
1280 }
1281
1282 // Utility method to setup an additional stream to send and receive video.
1283 // Used to test send and recv between two streams.
1284 void SetUpSecondStream() {
1285 SetUpSecondStreamWithNoRecv();
1286 // Setup recv for second stream.
1287 EXPECT_TRUE(channel_->AddRecvStream(
1288 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1289 // Make the second renderer available for use by a new stream.
1290 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1291 }
1292 // Setup an additional stream just to send video. Defer add recv stream.
1293 // This is required if you want to test unsignalled recv of video rtp packets.
1294 void SetUpSecondStreamWithNoRecv() {
1295 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001296 EXPECT_TRUE(
1297 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001298 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001299 EXPECT_FALSE(
1300 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001301 EXPECT_TRUE(channel_->AddSendStream(
1302 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1303 // We dont add recv for the second stream.
1304
1305 // Setup the receive and renderer for second stream after send.
1306 video_capturer_2_.reset(CreateFakeVideoCapturer());
1307 cricket::VideoFormat format(640, 480,
1308 cricket::VideoFormat::FpsToInterval(kFramerate),
1309 cricket::FOURCC_I420);
1310 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1311
Yves Gerey665174f2018-06-19 15:03:05 +02001312 EXPECT_TRUE(
1313 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001314 }
Yves Gerey665174f2018-06-19 15:03:05 +02001315 virtual void TearDown() { channel_.reset(); }
1316 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001317
1318 bool SetOneCodec(const cricket::VideoCodec& codec) {
1319 cricket::VideoFormat capture_format(
1320 kVideoWidth, kVideoHeight,
1321 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1322
1323 if (video_capturer_) {
1324 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1325 }
1326 if (video_capturer_2_) {
1327 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1328 }
1329
1330 bool sending = channel_->sending();
1331 bool success = SetSend(false);
1332 if (success) {
1333 cricket::VideoSendParameters parameters;
1334 parameters.codecs.push_back(codec);
1335 success = channel_->SetSendParameters(parameters);
1336 }
1337 if (success) {
1338 success = SetSend(sending);
1339 }
1340 return success;
1341 }
Yves Gerey665174f2018-06-19 15:03:05 +02001342 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001343 bool SendFrame() {
1344 if (video_capturer_2_) {
1345 video_capturer_2_->CaptureFrame();
1346 }
1347 return video_capturer_.get() && video_capturer_->CaptureFrame();
1348 }
1349 bool WaitAndSendFrame(int wait_ms) {
1350 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1351 ret &= SendFrame();
1352 return ret;
1353 }
Yves Gerey665174f2018-06-19 15:03:05 +02001354 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001355 int NumRtpBytes(uint32_t ssrc) {
1356 return network_interface_.NumRtpBytes(ssrc);
1357 }
Yves Gerey665174f2018-06-19 15:03:05 +02001358 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 int NumRtpPackets(uint32_t ssrc) {
1360 return network_interface_.NumRtpPackets(ssrc);
1361 }
Yves Gerey665174f2018-06-19 15:03:05 +02001362 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1364 return network_interface_.GetRtpPacket(index);
1365 }
1366 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001367 webrtc::RTPHeader header;
1368 EXPECT_TRUE(ParseRtpPacket(p, &header));
1369 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001370 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001371
Niels Möller6557d0c2018-04-11 15:18:34 +02001372 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001373 webrtc::RTPHeader* header) {
1374 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1375 webrtc::RtpHeaderParser::Create());
1376 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001377 }
1378
1379 // Tests that we can send and receive frames.
1380 void SendAndReceive(const cricket::VideoCodec& codec) {
1381 EXPECT_TRUE(SetOneCodec(codec));
1382 EXPECT_TRUE(SetSend(true));
1383 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1384 EXPECT_EQ(0, renderer_.num_rendered_frames());
1385 EXPECT_TRUE(SendFrame());
1386 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1387 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1388 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1389 }
1390
1391 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001392 int duration_sec,
1393 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001394 EXPECT_TRUE(SetOneCodec(codec));
1395 EXPECT_TRUE(SetSend(true));
1396 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1397 EXPECT_EQ(0, renderer_.num_rendered_frames());
1398 for (int i = 0; i < duration_sec; ++i) {
1399 for (int frame = 1; frame <= fps; ++frame) {
1400 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1401 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1402 }
1403 }
1404 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1405 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1406 }
1407
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1409 cricket::VideoMediaInfo info;
1410 EXPECT_TRUE(channel_->GetStats(&info));
1411 return info.senders[i];
1412 }
1413
1414 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1415 cricket::VideoMediaInfo info;
1416 EXPECT_TRUE(channel_->GetStats(&info));
1417 return info.receivers[i];
1418 }
1419
1420 // Two streams one channel tests.
1421
1422 // Tests that we can send and receive frames.
1423 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1424 SetUpSecondStream();
1425 // Test sending and receiving on first stream.
1426 SendAndReceive(codec);
1427 // Test sending and receiving on second stream.
1428 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1429 EXPECT_GT(NumRtpPackets(), 0);
1430 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1431 }
1432
1433 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1434 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001435 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001436 return engine_codec;
1437 }
1438 // This point should never be reached.
1439 ADD_FAILURE() << "Unrecognized codec name: " << name;
1440 return cricket::VideoCodec();
1441 }
1442
1443 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1444
1445 cricket::StreamParams DefaultSendStreamParams() {
1446 return cricket::StreamParams::CreateLegacy(kSsrc);
1447 }
1448
1449 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001450 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001451 WebRtcVideoEngine engine_;
1452 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1453 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1454 std::unique_ptr<WebRtcVideoChannel> channel_;
1455 cricket::FakeNetworkInterface network_interface_;
1456 cricket::FakeVideoRenderer renderer_;
1457
1458 // Used by test cases where 2 streams are run on the same channel.
1459 cricket::FakeVideoRenderer renderer2_;
1460};
1461
1462// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001463TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001464 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001465 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001466 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1467 EXPECT_FALSE(channel_->sending());
1468 EXPECT_TRUE(SetSend(true));
1469 EXPECT_TRUE(channel_->sending());
1470 EXPECT_TRUE(SendFrame());
1471 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1472 EXPECT_TRUE(SetSend(false));
1473 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001474}
Niels Möller6557d0c2018-04-11 15:18:34 +02001475
1476// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001477TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001478 EXPECT_FALSE(channel_->sending());
1479 EXPECT_FALSE(SetSend(true));
1480 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001481}
Niels Möller6557d0c2018-04-11 15:18:34 +02001482
1483// Test that we properly set the send and recv buffer sizes by the time
1484// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001485TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001486 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1487 EXPECT_TRUE(SetSend(true));
1488 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001489 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001490}
1491
Niels Möller6557d0c2018-04-11 15:18:34 +02001492// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001493TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001494 const int kDurationSec = 3;
1495 const int kFps = 10;
1496 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1497
1498 cricket::VideoMediaInfo info;
1499 EXPECT_TRUE(channel_->GetStats(&info));
1500
1501 ASSERT_EQ(1U, info.senders.size());
1502 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1503 // For webrtc, bytes_sent does not include the RTP header length.
1504 EXPECT_GT(info.senders[0].bytes_sent, 0);
1505 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1506 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1507 ASSERT_TRUE(info.senders[0].codec_payload_type);
1508 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1509 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1510 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1511 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1512 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1513 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1514 EXPECT_GT(info.senders[0].framerate_input, 0);
1515 EXPECT_GT(info.senders[0].framerate_sent, 0);
1516
1517 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1518 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1519 info.send_codecs[DefaultCodec().id]);
1520
1521 ASSERT_EQ(1U, info.receivers.size());
1522 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1523 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1524 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1525 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1526 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1527 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1528 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1529 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1530 EXPECT_EQ(0, info.receivers[0].packets_lost);
1531 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1532 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1533 EXPECT_EQ(0, info.receivers[0].firs_sent);
1534 EXPECT_EQ(0, info.receivers[0].plis_sent);
1535 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1536 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1537 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1538 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1539 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1540 EXPECT_GT(info.receivers[0].framerate_output, 0);
1541
1542 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1543 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1544 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001545}
Niels Möller6557d0c2018-04-11 15:18:34 +02001546
1547// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001548TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001549 cricket::FakeVideoRenderer renderer1, renderer2;
1550 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1551 cricket::VideoSendParameters parameters;
1552 parameters.codecs.push_back(DefaultCodec());
1553 parameters.conference_mode = true;
1554 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1555 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001556 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1557 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001558 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1559 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1560 EXPECT_EQ(0, renderer1.num_rendered_frames());
1561 EXPECT_EQ(0, renderer2.num_rendered_frames());
1562 std::vector<uint32_t> ssrcs;
1563 ssrcs.push_back(1);
1564 ssrcs.push_back(2);
1565 network_interface_.SetConferenceMode(true, ssrcs);
1566 EXPECT_TRUE(SendFrame());
1567 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1568 kTimeout);
1569 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1570 kTimeout);
1571
1572 EXPECT_TRUE(channel_->SetSend(false));
1573
1574 cricket::VideoMediaInfo info;
1575 EXPECT_TRUE(channel_->GetStats(&info));
1576 ASSERT_EQ(1U, info.senders.size());
1577 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1578 // For webrtc, bytes_sent does not include the RTP header length.
1579 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1580 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1581 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1582 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1583
1584 ASSERT_EQ(2U, info.receivers.size());
1585 for (size_t i = 0; i < info.receivers.size(); ++i) {
1586 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1587 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1588 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001589 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001590 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1591 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1592 }
srtee0c2eea2017-12-15 17:44:33 +01001593}
Niels Möller6557d0c2018-04-11 15:18:34 +02001594
1595// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001596TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001597 // Normal setup; note that we set the SSRC explicitly to ensure that
1598 // it will come first in the senders map.
1599 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1600 cricket::VideoSendParameters parameters;
1601 parameters.codecs.push_back(DefaultCodec());
1602 parameters.conference_mode = true;
1603 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001604 EXPECT_TRUE(
1605 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001606 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1607 EXPECT_TRUE(SetSend(true));
1608 EXPECT_TRUE(SendFrame());
1609 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1610 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1611
1612 // Add an additional capturer, and hook up a renderer to receive it.
1613 cricket::FakeVideoRenderer renderer2;
1614 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1615 CreateFakeVideoCapturer());
1616 const int kTestWidth = 160;
1617 const int kTestHeight = 120;
1618 cricket::VideoFormat format(kTestWidth, kTestHeight,
1619 cricket::VideoFormat::FpsToInterval(5),
1620 cricket::FOURCC_I420);
1621 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001622 EXPECT_TRUE(
1623 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001624 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001625 EXPECT_TRUE(
1626 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001627 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1628 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001629 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1630 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001631
1632 // Get stats, and make sure they are correct for two senders. We wait until
1633 // the number of expected packets have been sent to avoid races where we
1634 // check stats before it has been updated.
1635 cricket::VideoMediaInfo info;
1636 for (uint32_t i = 0; i < kTimeout; ++i) {
1637 rtc::Thread::Current()->ProcessMessages(1);
1638 EXPECT_TRUE(channel_->GetStats(&info));
1639 ASSERT_EQ(2U, info.senders.size());
1640 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1641 NumRtpPackets()) {
1642 // Stats have been updated for both sent frames, expectations can be
1643 // checked now.
1644 break;
1645 }
1646 }
1647 EXPECT_EQ(NumRtpPackets(),
1648 info.senders[0].packets_sent + info.senders[1].packets_sent)
1649 << "Timed out while waiting for packet counts for all sent packets.";
1650 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1651 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1652 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1653 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1654 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1655 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1656 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1657 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1658 // The capturer must be unregistered here as it runs out of it's scope next.
1659 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001660}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001663TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001664 cricket::VideoSendParameters parameters;
1665 parameters.codecs.push_back(DefaultCodec());
1666 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1668 parameters.max_bandwidth_bps = 128 * 1024;
1669 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001670}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001671
Niels Möller6557d0c2018-04-11 15:18:34 +02001672// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001673TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001674 EXPECT_TRUE(SetDefaultCodec());
1675 EXPECT_TRUE(SetSend(true));
1676 EXPECT_TRUE(SendFrame());
1677 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001678 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001679 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001680 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1681 EXPECT_EQ(kSsrc, header.ssrc);
1682
Niels Möller6557d0c2018-04-11 15:18:34 +02001683 // Packets are being paced out, so these can mismatch between the first and
1684 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001685 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1686 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001687 EXPECT_EQ(1, NumSentSsrcs());
1688 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1689 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001690}
Niels Möller6557d0c2018-04-11 15:18:34 +02001691
1692// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001693TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 // Remove stream added in Setup.
1695 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1696 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001697 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001698 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1699 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 EXPECT_TRUE(SetSend(true));
1701 EXPECT_TRUE(WaitAndSendFrame(0));
1702 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001703 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001704 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001705 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1706 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001707 // Packets are being paced out, so these can mismatch between the first and
1708 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001709 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1710 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001711 EXPECT_EQ(1, NumSentSsrcs());
1712 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1713 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001714}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001715
Niels Möller6557d0c2018-04-11 15:18:34 +02001716// Test that we can set the default video renderer before and after
1717// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001718TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001719 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1720 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001721
1722 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1723 rtc::SetBE32(packet1.data() + 8, kSsrc);
1724 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1725 EXPECT_TRUE(SetDefaultCodec());
1726 EXPECT_TRUE(SetSend(true));
1727 EXPECT_EQ(0, renderer_.num_rendered_frames());
1728 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1729 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1730 EXPECT_TRUE(SendFrame());
1731 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001732}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001733
Niels Möller6557d0c2018-04-11 15:18:34 +02001734// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001735TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001736 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1737 EXPECT_TRUE(SetSend(true));
1738 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1739 EXPECT_TRUE(SendFrame());
1740 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1741 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001742 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001743 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001744 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1745 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001746 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1747 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001748
1749 // Remove the send stream that was added during Setup.
1750 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1751 int rtp_packets = NumRtpPackets();
1752
Niels Möller6557d0c2018-04-11 15:18:34 +02001753 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001754 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1755 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001756 EXPECT_EQ(rtp_packets, NumRtpPackets());
1757 // Wait 30ms to guarantee the engine does not drop the frame.
1758 EXPECT_TRUE(WaitAndSendFrame(30));
1759 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1760
1761 last_packet = NumRtpPackets() - 1;
1762 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001763 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1764 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001765}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001766
Niels Möller6557d0c2018-04-11 15:18:34 +02001767// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001768TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 cricket::FakeVideoRenderer renderer1, renderer2;
1770 EXPECT_TRUE(SetDefaultCodec());
1771 cricket::VideoSendParameters parameters;
1772 parameters.codecs.push_back(DefaultCodec());
1773 parameters.conference_mode = true;
1774 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1775 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001776 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1777 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001778 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1779 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1780 EXPECT_EQ(0, renderer1.num_rendered_frames());
1781 EXPECT_EQ(0, renderer2.num_rendered_frames());
1782 std::vector<uint32_t> ssrcs;
1783 ssrcs.push_back(1);
1784 ssrcs.push_back(2);
1785 network_interface_.SetConferenceMode(true, ssrcs);
1786 EXPECT_TRUE(SendFrame());
1787 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1788 kTimeout);
1789 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1790 kTimeout);
1791
1792 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1793 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1794 EXPECT_EQ(kVideoWidth, renderer1.width());
1795 EXPECT_EQ(kVideoHeight, renderer1.height());
1796 EXPECT_EQ(kVideoWidth, renderer2.width());
1797 EXPECT_EQ(kVideoHeight, renderer2.height());
1798 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1799 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001800}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001801
Niels Möller6557d0c2018-04-11 15:18:34 +02001802// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001803TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001804 using cricket::VideoCodec;
1805 using cricket::VideoOptions;
1806 using cricket::VideoFormat;
1807 using cricket::FOURCC_I420;
1808
1809 VideoCodec codec = DefaultCodec();
1810 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1811 EXPECT_TRUE(SetOneCodec(codec));
1812 EXPECT_TRUE(SetSend(true));
1813 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1814 EXPECT_EQ(0, renderer_.num_rendered_frames());
1815 EXPECT_TRUE(SendFrame());
1816 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1817 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1818 CreateFakeVideoCapturer());
1819
1820 // TODO(nisse): This testcase fails if we don't configure
1821 // screencast. It's unclear why, I see nothing obvious in this
1822 // test which is related to screencast logic.
1823 VideoOptions video_options;
1824 video_options.is_screencast = true;
1825 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1826
1827 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1828 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1829 // All capturers start generating frames with the same timestamp. ViE does
1830 // not allow the same timestamp to be used. Capture one frame before
1831 // associating the capturer with the channel.
1832 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1833
1834 int captured_frames = 1;
1835 for (int iterations = 0; iterations < 2; ++iterations) {
1836 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1837 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1838 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1839 ++captured_frames;
1840 // Wait until frame of right size is captured.
1841 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001842 format.width == renderer_.width() &&
1843 format.height == renderer_.height() &&
1844 !renderer_.black_frame(),
1845 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001846 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1847 EXPECT_EQ(format.width, renderer_.width());
1848 EXPECT_EQ(format.height, renderer_.height());
1849 captured_frames = renderer_.num_rendered_frames() + 1;
1850 EXPECT_FALSE(renderer_.black_frame());
1851 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1852 // Make sure a black frame is generated within the specified timeout.
1853 // The black frame should be the resolution of the previous frame to
1854 // prevent expensive encoder reconfigurations.
1855 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001856 format.width == renderer_.width() &&
1857 format.height == renderer_.height() &&
1858 renderer_.black_frame(),
1859 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001860 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1861 EXPECT_EQ(format.width, renderer_.width());
1862 EXPECT_EQ(format.height, renderer_.height());
1863 EXPECT_TRUE(renderer_.black_frame());
1864
1865 // The black frame has the same timestamp as the next frame since it's
1866 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1867 // not render a frame with the same timestamp so capture another frame
1868 // with the frame capturer to increment the next frame's timestamp.
1869 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1870 }
srtee0c2eea2017-12-15 17:44:33 +01001871}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001872
Niels Möller6557d0c2018-04-11 15:18:34 +02001873// Tests that if SetVideoSend is called with a NULL capturer after the
1874// capturer was already removed, the application doesn't crash (and no black
1875// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001876TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001877 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1878 EXPECT_TRUE(SetSend(true));
1879 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1880 EXPECT_EQ(0, renderer_.num_rendered_frames());
1881 EXPECT_TRUE(SendFrame());
1882 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1883 // Wait for one frame so they don't get dropped because we send frames too
1884 // tightly.
1885 rtc::Thread::Current()->ProcessMessages(30);
1886 // Remove the capturer.
1887 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1888
1889 // No capturer was added, so this SetVideoSend shouldn't do anything.
1890 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1891 rtc::Thread::Current()->ProcessMessages(300);
1892 // Verify no more frames were sent.
1893 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001894}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001895
Niels Möller6557d0c2018-04-11 15:18:34 +02001896// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001897TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001898 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1899 // interval time to avoid that.
1900 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1901 // interval time to avoid that.
1902 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001903 EXPECT_TRUE(
1904 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001905 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1906 cricket::VideoFormat capture_format(
1907 kVideoWidth, kVideoHeight,
1908 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1909 // Set up additional stream 1.
1910 cricket::FakeVideoRenderer renderer1;
1911 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001912 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001913 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001914 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001915 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1916 CreateFakeVideoCapturer());
1917 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1918 // Set up additional stream 2.
1919 cricket::FakeVideoRenderer renderer2;
1920 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001921 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001922 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001923 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001924 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1925 CreateFakeVideoCapturer());
1926 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1927 // State for all the streams.
1928 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1929 // A limitation in the lmi implementation requires that SetVideoSend() is
1930 // called after SetOneCodec().
1931 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1932 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1933 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1934 EXPECT_TRUE(SetSend(true));
1935 // Test capturer associated with engine.
1936 const int kTestWidth = 160;
1937 const int kTestHeight = 120;
1938 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001939 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1940 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 // Capture a frame with additional capturer2, frames should be received
1942 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001943 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1944 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001945 // Successfully remove the capturer.
1946 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1947 // The capturers must be unregistered here as it runs out of it's scope
1948 // next.
1949 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1950 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001951}
Niels Möller6557d0c2018-04-11 15:18:34 +02001952
1953// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001954TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001955 // Remove the send stream that was added during Setup.
1956 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1957
1958 cricket::StreamParams empty;
1959 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001960 EXPECT_TRUE(
1961 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001962}
Niels Möller6557d0c2018-04-11 15:18:34 +02001963
1964// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001965TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 // Remove stream added in Setup. I.e. remove stream corresponding to default
1967 // channel.
1968 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001969 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001970 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1971 EXPECT_TRUE(channel_->AddSendStream(
1972 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1973 }
1974 // Delete one of the non default channel streams, let the destructor delete
1975 // the remaining ones.
1976 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1977 // Stream should already be deleted.
1978 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001979}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001980
eladalonf1841382017-06-12 01:16:46 -07001981TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001982 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001983}
1984
eladalonf1841382017-06-12 01:16:46 -07001985TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001986 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001987}
1988
eladalonf1841382017-06-12 01:16:46 -07001989TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001990 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001991}
1992
eladalonf1841382017-06-12 01:16:46 -07001993TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001994 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1995 // bitrates. This currently happens at <250k, and two streams sharing 300k
1996 // initially will use QVGA instead of VGA.
1997 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1998 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001999 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002000 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002001 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002002}
2003
eladalonf1841382017-06-12 01:16:46 -07002004class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002005 public:
eladalonf1841382017-06-12 01:16:46 -07002006 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2007 explicit WebRtcVideoChannelTest(const char* field_trials)
2008 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002009 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002010 encoder_factory_->AddSupportedVideoCodecType("VP8");
2011 encoder_factory_->AddSupportedVideoCodecType("VP9");
2012#if defined(WEBRTC_USE_H264)
2013 encoder_factory_->AddSupportedVideoCodecType("H264");
2014#endif
2015
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002016 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002017 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002018 VideoOptions(),
2019 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002020 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002021 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002022 send_parameters_.codecs = engine_.codecs();
2023 recv_parameters_.codecs = engine_.codecs();
2024 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002025 }
2026
2027 protected:
2028 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002029 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002030 }
2031
2032 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002033 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002034 EXPECT_TRUE(channel_->AddSendStream(sp));
2035 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002036 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002037 EXPECT_EQ(num_streams + 1, streams.size());
2038 return streams[streams.size() - 1];
2039 }
2040
2041 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002042 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002043 }
2044
2045 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002046 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002047 }
2048
2049 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002050 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002051 EXPECT_TRUE(channel_->AddRecvStream(sp));
2052 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002053 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002054 EXPECT_EQ(num_streams + 1, streams.size());
2055 return streams[streams.size() - 1];
2056 }
2057
pbos@webrtc.org00873182014-11-25 14:03:34 +00002058 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2059 int expected_min_bitrate_bps,
2060 const char* start_bitrate_kbps,
2061 int expected_start_bitrate_bps,
2062 const char* max_bitrate_kbps,
2063 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002064 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2065 expected_start_bitrate_bps,
2066 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002067 auto& codecs = send_parameters_.codecs;
2068 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002069 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002070 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2071 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2072 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002073 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002074 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002075
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002076 void ExpectSetBitrateParameters(int min_bitrate_bps,
2077 int start_bitrate_bps,
2078 int max_bitrate_bps) {
2079 EXPECT_CALL(
2080 *fake_call_->GetMockTransportControllerSend(),
2081 SetSdpBitrateParameters(AllOf(
2082 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2083 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2084 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2085 }
2086
2087 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2088 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2089 SetSdpBitrateParameters(Field(
2090 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002091 }
2092
Johannes Kron9190b822018-10-29 11:22:05 +01002093 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2094 // For a caller, the answer will be applied in set remote description
2095 // where SetSendParameters() is called.
2096 EXPECT_TRUE(
2097 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2098 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2099 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2100 const webrtc::VideoSendStream::Config& config =
2101 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2102 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2103 }
2104
2105 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2106 // For a callee, the answer will be applied in set local description
2107 // where SetExtmapAllowMixed() and AddSendStream() are called.
2108 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2109 EXPECT_TRUE(
2110 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2111 const webrtc::VideoSendStream::Config& config =
2112 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2113 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2114 }
2115
isheriff6f8d6862016-05-26 11:24:55 -07002116 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002117 // Enable extension.
2118 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002119 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002120 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002121 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002122 FakeVideoSendStream* send_stream =
2123 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2124
2125 // Verify the send extension id.
2126 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2127 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002128 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002129 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002130 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002131 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2132 // receivers.
2133 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2134 ->GetConfig()
2135 .rtp.extensions.empty());
2136
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002137 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002138 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002139 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2140 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002141 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2142
2143 // Verify that adding receive RTP header extensions adds them for existing
2144 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002145 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002146 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002147 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2148 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002149 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002150 }
2151
isheriff6f8d6862016-05-26 11:24:55 -07002152 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002153 // Enable extension.
2154 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002155 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002156 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002157 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002158
2159 FakeVideoReceiveStream* recv_stream =
2160 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2161
2162 // Verify the recv extension id.
2163 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2164 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002165 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002166 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002167 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002168
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002169 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2170 // senders.
2171 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2172 ->GetConfig()
2173 .rtp.extensions.empty());
2174
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002175 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002176 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002177 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2178 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002179 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2180
2181 // Verify that adding receive RTP header extensions adds them for existing
2182 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002183 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002184 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002185 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2186 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002187 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002188 }
2189
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002190 void TestExtensionFilter(const std::vector<std::string>& extensions,
2191 const std::string& expected_extension) {
2192 cricket::VideoSendParameters parameters = send_parameters_;
2193 int expected_id = -1;
2194 int id = 1;
2195 for (const std::string& extension : extensions) {
2196 if (extension == expected_extension)
2197 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002198 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002199 }
2200 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2201 FakeVideoSendStream* send_stream =
2202 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2203
2204 // Verify that only one of them has been set, and that it is the one with
2205 // highest priority (transport sequence number).
2206 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2207 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2208 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002209 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002210 }
2211
asapersson3c81a1a2017-06-14 05:52:21 -07002212 void TestDegradationPreference(bool resolution_scaling_enabled,
2213 bool fps_scaling_enabled);
2214
Erik Språngefbde372015-04-29 16:21:28 +02002215 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002216 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002217 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2218 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002219
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002220 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002221 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002222 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002223 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002224 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002225 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002226 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002227 // Options only take effect on the next frame.
2228 EXPECT_TRUE(capturer->CaptureFrame());
2229
Erik Språng143cec12015-04-28 10:01:41 +02002230 return fake_call_->GetVideoSendStreams().back();
2231 }
2232
Peter Boström2feafdb2015-09-09 14:32:14 +02002233 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2234 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002235 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002236 std::vector<uint32_t> ssrcs;
2237 std::vector<uint32_t> rtx_ssrcs;
2238 uint32_t num_streams = enabled ? 3 : 1;
2239 for (uint32_t i = 0; i < num_streams; ++i) {
2240 uint32_t ssrc = last_ssrc_ + i;
2241 ssrcs.push_back(ssrc);
2242 if (with_rtx) {
2243 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2244 }
Erik Språng143cec12015-04-28 10:01:41 +02002245 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002246 if (with_rtx) {
2247 return AddSendStream(
2248 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2249 }
2250 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002251 }
2252
perkjfa10b552016-10-02 23:45:26 -07002253 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002254 std::vector<FakeVideoSendStream*> streams =
2255 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002256 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002257 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002258 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002259 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002260 }
2261
perkjfa10b552016-10-02 23:45:26 -07002262 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002263 int stream_max,
2264 int expected_encoder_bitrate) {
2265 VideoSendParameters limited_send_params = send_parameters_;
2266 limited_send_params.max_bandwidth_bps = global_max;
2267 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002268 webrtc::RtpParameters parameters =
2269 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002270 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002271 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002272 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002273 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002274 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002275 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002276 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002277 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002278 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002279 }
2280
Åsa Persson55659812018-06-18 17:51:32 +02002281 // Values from kSimulcastConfigs in simulcast.cc.
2282 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2283 std::vector<webrtc::VideoStream> layers(3);
2284 layers[0].min_bitrate_bps = 30000;
2285 layers[0].target_bitrate_bps = 150000;
2286 layers[0].max_bitrate_bps = 200000;
2287 layers[1].min_bitrate_bps = 150000;
2288 layers[1].target_bitrate_bps = 500000;
2289 layers[1].max_bitrate_bps = 700000;
2290 layers[2].min_bitrate_bps = 600000;
2291 layers[2].target_bitrate_bps = 2500000;
2292 layers[2].max_bitrate_bps = 2500000;
2293 return layers;
2294 }
2295
kwiberg686a8ef2016-02-26 03:00:35 -08002296 std::unique_ptr<FakeCall> fake_call_;
2297 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002298 cricket::VideoSendParameters send_parameters_;
2299 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002300 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002301};
2302
eladalonf1841382017-06-12 01:16:46 -07002303TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002304 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002305 const std::string kSyncLabel = "AvSyncLabel";
2306
2307 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002308 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002309 EXPECT_TRUE(channel_->AddRecvStream(sp));
2310
Mirko Bonadeif859e552018-05-30 15:31:29 +02002311 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002312 EXPECT_EQ(kSyncLabel,
2313 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2314 << "SyncGroup should be set based on sync_label";
2315}
2316
eladalonf1841382017-06-12 01:16:46 -07002317TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002318 cricket::VideoSendParameters parameters;
2319 parameters.codecs = engine_.codecs();
2320 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002321 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002322 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002323 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002324
2325 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002326 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2327 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002328 FakeVideoSendStream* send_stream = AddSendStream(
2329 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2330
2331 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2332 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2333 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2334
2335 // Receiver side.
2336 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2337 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002338 EXPECT_FALSE(
2339 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002340 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002341 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002342 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002343 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002344 << "RTX should be mapped for the RED payload type";
2345
brandtr14742122017-01-27 04:53:07 -08002346 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002347}
2348
eladalonf1841382017-06-12 01:16:46 -07002349TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002350 // Setup one channel with an associated RTX stream.
2351 cricket::StreamParams params =
2352 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2353 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2354 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002355 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002356
2357 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2358 << "RTX should be mapped for all decoders/payload types.";
2359 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002360 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002361 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002362}
2363
eladalonf1841382017-06-12 01:16:46 -07002364TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002365 // Setup one channel without an associated RTX stream.
2366 cricket::StreamParams params =
2367 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2368 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002369 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002370}
2371
Johannes Kron9190b822018-10-29 11:22:05 +01002372// Test propagation of extmap allow mixed setting.
2373TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2374 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2375}
2376TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2377 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2378}
2379TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2380 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2381}
2382TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2383 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2384}
2385
eladalonf1841382017-06-12 01:16:46 -07002386TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002387 FakeVideoSendStream* send_stream =
2388 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2389 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2390
2391 FakeVideoReceiveStream* recv_stream =
2392 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2393 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002394}
2395
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002396// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002397TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002398 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002399}
isheriff6f8d6862016-05-26 11:24:55 -07002400
eladalonf1841382017-06-12 01:16:46 -07002401TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002402 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002403}
2404
2405// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002406TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002407 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002408}
isheriff6f8d6862016-05-26 11:24:55 -07002409
eladalonf1841382017-06-12 01:16:46 -07002410TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002411 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002412}
2413
eladalonf1841382017-06-12 01:16:46 -07002414TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002415 // Enable three redundant extensions.
2416 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002417 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2418 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2419 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2420 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002421}
2422
eladalonf1841382017-06-12 01:16:46 -07002423TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002424 // Enable two redundant extensions.
2425 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002426 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2427 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2428 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002429}
2430
stefanc1aeaf02015-10-15 07:26:07 -07002431// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002432TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002433 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002434}
eladalonf1841382017-06-12 01:16:46 -07002435TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002436 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002437}
2438
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002439// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002440TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002441 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002442}
eladalonf1841382017-06-12 01:16:46 -07002443TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002444 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002445}
2446
eladalonf1841382017-06-12 01:16:46 -07002447TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002448 const int kAbsSendTimeId = 1;
2449 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002450 send_parameters_.extensions.push_back(
2451 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2452 send_parameters_.extensions.push_back(
2453 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002454
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002455 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002456 FakeVideoSendStream* send_stream =
2457 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2458
2459 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002460 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002461
2462 // Setting the same extensions (even if in different order) shouldn't
2463 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002464 std::reverse(send_parameters_.extensions.begin(),
2465 send_parameters_.extensions.end());
2466 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002467
2468 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2469
2470 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002471 send_parameters_.extensions.resize(1);
2472 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002473
2474 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2475}
2476
eladalonf1841382017-06-12 01:16:46 -07002477TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002478 const int kTOffsetId = 1;
2479 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002480 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002481 recv_parameters_.extensions.push_back(
2482 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2483 recv_parameters_.extensions.push_back(
2484 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2485 recv_parameters_.extensions.push_back(
2486 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002487
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002488 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002489 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002490 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2491
2492 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002493 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002494
2495 // Setting the same extensions (even if in different order) shouldn't
2496 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002497 std::reverse(recv_parameters_.extensions.begin(),
2498 recv_parameters_.extensions.end());
2499 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002500
2501 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2502
2503 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002504 recv_parameters_.extensions.resize(1);
2505 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002506
2507 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2508}
2509
eladalonf1841382017-06-12 01:16:46 -07002510TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002511 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002512 const int kUnsupportedId = 1;
2513 const int kTOffsetId = 2;
2514
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002515 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002516 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002517 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002518 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002519 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002520 FakeVideoSendStream* send_stream =
2521 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2522
2523 // Only timestamp offset extension is set to send stream,
2524 // unsupported rtp extension is ignored.
2525 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002526 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2527 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002528}
2529
eladalonf1841382017-06-12 01:16:46 -07002530TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002531 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002532 const int kUnsupportedId = 1;
2533 const int kTOffsetId = 2;
2534
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002535 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002536 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002537 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002538 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002539 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002540 FakeVideoReceiveStream* recv_stream =
2541 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2542
2543 // Only timestamp offset extension is set to receive stream,
2544 // unsupported rtp extension is ignored.
2545 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002546 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2547 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002548}
2549
eladalonf1841382017-06-12 01:16:46 -07002550TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002551 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002552 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002553 send_parameters_.extensions.push_back(
2554 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002555 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002556 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2557 }
2558}
2559
eladalonf1841382017-06-12 01:16:46 -07002560TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002561 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002562 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002563 recv_parameters_.extensions.push_back(
2564 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002565 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002566 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2567 }
2568}
2569
eladalonf1841382017-06-12 01:16:46 -07002570TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002571 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002572 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002573 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002574 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002575 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002576 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002577
2578 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002579 send_parameters_.extensions.clear();
2580 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002581 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002582 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2583 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002584}
2585
eladalonf1841382017-06-12 01:16:46 -07002586TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002587 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002588 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002589 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002590 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002591 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002593
2594 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002595 recv_parameters_.extensions.clear();
2596 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002597 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002598 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2599 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002600}
2601
eladalonf1841382017-06-12 01:16:46 -07002602TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002603 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002604 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002605}
2606
eladalonf1841382017-06-12 01:16:46 -07002607TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002608 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002609 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002610}
2611
eladalonf1841382017-06-12 01:16:46 -07002612TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002613 FakeVideoReceiveStream* stream = AddRecvStream();
2614 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002615}
2616
eladalonf1841382017-06-12 01:16:46 -07002617TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002618 FakeVideoReceiveStream* stream = AddRecvStream();
2619 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2620}
2621
eladalonf1841382017-06-12 01:16:46 -07002622TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002623 FakeVideoReceiveStream* stream = AddRecvStream();
2624 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2625
Peter Boström126c03e2015-05-11 12:48:12 +02002626 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002627 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002628 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002629 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2630 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002631 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002632 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2633
2634 // Verify that REMB is turned on when setting default codecs since the
2635 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002636 parameters.codecs = engine_.codecs();
2637 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002638 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002639 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002640}
2641
eladalonf1841382017-06-12 01:16:46 -07002642TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002643 FakeVideoReceiveStream* stream = AddRecvStream();
2644 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2645
2646 // Verify that transport cc feedback is turned off when send(!) codecs without
2647 // transport cc feedback are set.
2648 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002649 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002650 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2651 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2652 stream = fake_call_->GetVideoReceiveStreams()[0];
2653 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2654
2655 // Verify that transport cc feedback is turned on when setting default codecs
2656 // since the default codecs have transport cc feedback enabled.
2657 parameters.codecs = engine_.codecs();
2658 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2659 stream = fake_call_->GetVideoReceiveStreams()[0];
2660 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2661}
2662
eladalonf1841382017-06-12 01:16:46 -07002663TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002664 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002665 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2666
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002667 cricket::VideoSendParameters parameters;
2668 parameters.codecs = engine_.codecs();
2669 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002670 EXPECT_TRUE(channel_->SetSend(true));
2671
2672 // Send side.
2673 FakeVideoSendStream* send_stream =
2674 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2675 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2676
2677 // Receiver side.
2678 FakeVideoReceiveStream* recv_stream =
2679 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2680 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2681
2682 // Nack history size should match between sender and receiver.
2683 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2684 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002685}
2686
eladalonf1841382017-06-12 01:16:46 -07002687TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002688 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002689 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002690
2691 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2692 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2693
2694 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002695 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002696 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002697 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2698 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002699 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2700 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2701 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002702 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2703
Peter Boström67c9df72015-05-11 14:34:58 +02002704 // Verify that NACK is turned on when setting default codecs since the
2705 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002706 parameters.codecs = engine_.codecs();
2707 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002708 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2709 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2710 send_stream = fake_call_->GetVideoSendStreams()[0];
2711 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002712}
2713
Peter Boströme7ba0862016-03-12 00:02:28 +01002714// This test verifies that new frame sizes reconfigures encoders even though not
2715// (yet) sending. The purpose of this is to permit encoding as quickly as
2716// possible once we start sending. Likely the frames being input are from the
2717// same source that will be sent later, which just means that we're ready
2718// earlier.
eladalonf1841382017-06-12 01:16:46 -07002719TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002720 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002721 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002722 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2723 channel_->SetSend(false);
2724
2725 FakeVideoSendStream* stream = AddSendStream();
2726
perkjfa10b552016-10-02 23:45:26 -07002727 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002728 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002729 EXPECT_EQ(0u, streams[0].width);
2730 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002731
Tommi85959932018-02-07 19:26:06 +01002732 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002733 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002734 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2735 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002736 EXPECT_TRUE(capturer.CaptureFrame());
2737
2738 // Frame entered, should be reconfigured to new dimensions.
2739 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002740 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2741 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2742 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002743
Niels Möllerff40b142018-04-09 08:49:14 +02002744 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002745}
2746
eladalonf1841382017-06-12 01:16:46 -07002747TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002748 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002749 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002750 cricket::VideoSendParameters parameters;
2751 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002752 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002753 AddSendStream();
2754
Tommi85959932018-02-07 19:26:06 +01002755 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002756 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002757 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002758 EXPECT_TRUE(
2759 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002760 cricket::VideoFormat capture_format_hd =
2761 capturer.GetSupportedFormats()->front();
2762 EXPECT_EQ(1280, capture_format_hd.width);
2763 EXPECT_EQ(720, capture_format_hd.height);
2764 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2765
2766 EXPECT_TRUE(channel_->SetSend(true));
2767
2768 EXPECT_TRUE(capturer.CaptureFrame());
2769 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2770 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2771
2772 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2773
2774 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002775 webrtc::VideoEncoderConfig encoder_config =
2776 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002777 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002778 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002779 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002780 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2781 streams.front().width);
2782 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2783 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002784 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2785 << "Non-screenshare shouldn't use min-transmit bitrate.";
2786
Niels Möllerff40b142018-04-09 08:49:14 +02002787 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002788 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002789 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002790 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002791 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002792 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002793 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002794 // Send stream recreated after option change.
2795 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2796 send_stream = fake_call_->GetVideoSendStreams().front();
2797 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002798
2799 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002800 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002801 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002802 encoder_config.content_type);
2803 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2804 encoder_config.min_transmit_bitrate_bps);
2805
perkjfa10b552016-10-02 23:45:26 -07002806 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002807 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2808 streams.front().width);
2809 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2810 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002811 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002813}
2814
eladalonf1841382017-06-12 01:16:46 -07002815TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002816 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002817 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002818 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002819 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002820
2821 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002822 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002823 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002824 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002825 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002826 cricket::VideoFormat capture_format_hd =
2827 capturer.GetSupportedFormats()->front();
2828 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2829
2830 EXPECT_TRUE(channel_->SetSend(true));
2831
2832 EXPECT_TRUE(capturer.CaptureFrame());
2833 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2834 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2835
perkj26091b12016-09-01 01:17:40 -07002836 webrtc::VideoEncoderConfig encoder_config =
2837 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002838
2839 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002840 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002841 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002842 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002843
2844 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2845 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002846 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002847 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002848 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002849
Niels Möllerff40b142018-04-09 08:49:14 +02002850 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002851}
2852
eladalonf1841382017-06-12 01:16:46 -07002853TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002854 FakeVideoSendStream* stream = AddSendStream();
2855 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2856}
2857
eladalonf1841382017-06-12 01:16:46 -07002858TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002859 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002860 media_config.video.suspend_below_min_bitrate = true;
2861
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002862 channel_.reset(engine_.CreateChannel(
2863 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002864 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002865
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002866 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002867
2868 FakeVideoSendStream* stream = AddSendStream();
2869 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2870
nisse0db023a2016-03-01 04:29:59 -08002871 media_config.video.suspend_below_min_bitrate = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002872 channel_.reset(engine_.CreateChannel(
2873 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002874 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002875
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002876 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002877
nisse0db023a2016-03-01 04:29:59 -08002878 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002879 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2880}
2881
eladalonf1841382017-06-12 01:16:46 -07002882TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002883 FakeVideoSendStream* stream = AddSendStream();
2884 webrtc::VideoCodecVP8 vp8_settings;
2885 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2886 EXPECT_TRUE(vp8_settings.denoisingOn);
2887}
2888
eladalonf1841382017-06-12 01:16:46 -07002889TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002890 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002891 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002892 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002893
Peter Boström2feafdb2015-09-09 14:32:14 +02002894 // Single-stream settings should apply with RTX as well (verifies that we
2895 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2896 // both RTX and regular SSRCs).
2897 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002898
Tommi85959932018-02-07 19:26:06 +01002899 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002900 EXPECT_EQ(cricket::CS_RUNNING,
2901 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002902 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002903 channel_->SetSend(true);
2904
2905 EXPECT_TRUE(capturer.CaptureFrame());
2906
pbos4cba4eb2015-10-26 11:18:18 -07002907 webrtc::VideoCodecVP8 vp8_settings;
2908 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2909 EXPECT_TRUE(vp8_settings.denoisingOn)
2910 << "VP8 denoising should be on by default.";
2911
nisse05103312016-03-16 02:22:50 -07002912 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002913
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002914 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2915 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002916 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2917 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002918
nisse05103312016-03-16 02:22:50 -07002919 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002920
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002921 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2922 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002923 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2924 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2925
Niels Möllerff40b142018-04-09 08:49:14 +02002926 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002927 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002928 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002929 channel_->SetSend(true);
2930 EXPECT_TRUE(capturer.CaptureFrame());
2931
Mirko Bonadeif859e552018-05-30 15:31:29 +02002932 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002933 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2934 // Autmatic resize off when using simulcast.
2935 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2936 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2937
2938 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002939 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002940 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002941 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002942
nisse05103312016-03-16 02:22:50 -07002943 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002944
Mirko Bonadeif859e552018-05-30 15:31:29 +02002945 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002946 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2947 EXPECT_FALSE(vp8_settings.denoisingOn);
2948 // Resizing and frame dropping always off for screen sharing.
2949 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2950 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2951
nisse05103312016-03-16 02:22:50 -07002952 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002953
2954 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2955 EXPECT_FALSE(vp8_settings.denoisingOn);
2956 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2957 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2958
Niels Möllerff40b142018-04-09 08:49:14 +02002959 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002960}
2961
deadbeef119760a2016-04-04 11:43:27 -07002962// Test that setting the same options doesn't result in the encoder being
2963// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002964TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002965 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002966 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002967
perkjfa10b552016-10-02 23:45:26 -07002968 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002969 EXPECT_EQ(cricket::CS_RUNNING,
2970 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002971 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002972 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002973 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2974 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2975
Niels Möllerff40b142018-04-09 08:49:14 +02002976 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2977 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002978 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002979 // Expect 1 reconfigurations at this point from the initial configuration.
2980 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002981
2982 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002983 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002984 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2985
2986 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002987 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002988 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002989 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2990
Niels Möllerff40b142018-04-09 08:49:14 +02002991 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002992}
2993
eladalonf1841382017-06-12 01:16:46 -07002994class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002995 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002996 Vp9SettingsTest() : Vp9SettingsTest("") {}
2997 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002998 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002999 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003000 }
3001 virtual ~Vp9SettingsTest() {}
3002
3003 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003004 void TearDown() override {
3005 // Remove references to encoder_factory_ since this will be destroyed
3006 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003007 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003008 }
Erik Språng143cec12015-04-28 10:01:41 +02003009};
3010
3011TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003012 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003013 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003014 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003015
Peter Boström2feafdb2015-09-09 14:32:14 +02003016 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003017
Tommi85959932018-02-07 19:26:06 +01003018 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003019 EXPECT_EQ(cricket::CS_RUNNING,
3020 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003021 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003022 channel_->SetSend(true);
3023
3024 EXPECT_TRUE(capturer.CaptureFrame());
3025
pbos4cba4eb2015-10-26 11:18:18 -07003026 webrtc::VideoCodecVP9 vp9_settings;
3027 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003028 EXPECT_TRUE(vp9_settings.denoisingOn)
3029 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003030
nisse05103312016-03-16 02:22:50 -07003031 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003032
Erik Språng143cec12015-04-28 10:01:41 +02003033 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3034 EXPECT_FALSE(vp9_settings.denoisingOn);
3035 // Frame dropping always on for real time video.
3036 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3037
nisse05103312016-03-16 02:22:50 -07003038 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003039
3040 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3041 EXPECT_TRUE(vp9_settings.denoisingOn);
3042 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3043
3044 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003045 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003046 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003047 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003048
nisse05103312016-03-16 02:22:50 -07003049 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003050
3051 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3052 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003053 // Frame dropping always on for screen sharing.
3054 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003055
nisse05103312016-03-16 02:22:50 -07003056 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003057
3058 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3059 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003060 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003061
Niels Möllerff40b142018-04-09 08:49:14 +02003062 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003063}
3064
Sergey Silkinf18072e2018-03-14 10:35:35 +01003065TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3066 cricket::VideoSendParameters parameters;
3067 parameters.codecs.push_back(GetEngineCodec("VP9"));
3068 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3069
3070 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3071
3072 FakeVideoSendStream* stream =
3073 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3074
3075 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3076 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3077
3078 FakeVideoCapturerWithTaskQueue capturer;
3079 EXPECT_EQ(cricket::CS_RUNNING,
3080 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003081 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003082 channel_->SetSend(true);
3083
3084 EXPECT_TRUE(capturer.CaptureFrame());
3085
3086 webrtc::VideoCodecVP9 vp9_settings;
3087 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3088
3089 const size_t kNumSpatialLayers = ssrcs.size();
3090 const size_t kNumTemporalLayers = 3;
3091 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3092 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3093
Niels Möllerff40b142018-04-09 08:49:14 +02003094 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003095}
3096
asaperssonc5dabdd2016-03-21 04:15:50 -07003097class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3098 public:
brandtr468da7c2016-11-22 02:16:47 -08003099 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003100 : Vp9SettingsTest(field_trials) {}
3101
3102 protected:
3103 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3104 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003105 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003106 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3107
3108 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3109
Tommi85959932018-02-07 19:26:06 +01003110 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003111 EXPECT_EQ(cricket::CS_RUNNING,
3112 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003113 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003114 channel_->SetSend(true);
3115
3116 EXPECT_TRUE(capturer.CaptureFrame());
3117
3118 webrtc::VideoCodecVP9 vp9_settings;
3119 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3120 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3121 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3122
Niels Möllerff40b142018-04-09 08:49:14 +02003123 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003124 }
3125};
3126
3127class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3128 public:
3129 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3130};
3131
3132TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3133 const int kNumSpatialLayers = 1;
3134 const int kNumTemporalLayers = 1;
3135 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3136}
3137
3138class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3139 public:
3140 Vp9SettingsTestWithInvalidFlag()
3141 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3142};
3143
3144TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3145 const int kNumSpatialLayers = 1;
3146 const int kNumTemporalLayers = 1;
3147 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3148}
3149
3150class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3151 public:
3152 Vp9SettingsTestWith2SL3TLFlag()
3153 : Vp9SettingsTestWithFieldTrial(
3154 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3155};
3156
3157TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3158 const int kNumSpatialLayers = 2;
3159 const int kNumTemporalLayers = 3;
3160 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3161}
3162
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003163TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3164 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3165 ASSERT_EQ(1u, streams.size());
3166 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3167}
3168
3169TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3170 webrtc::test::ScopedFieldTrials override_field_trials_(
3171 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3172 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3173 ASSERT_EQ(1u, streams.size());
3174 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3175}
3176
asapersson3c81a1a2017-06-14 05:52:21 -07003177TEST_F(WebRtcVideoChannelTest,
3178 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3179 webrtc::test::ScopedFieldTrials override_field_trials_(
3180 "WebRTC-Video-BalancedDegradation/Disabled/");
3181 const bool kResolutionScalingEnabled = true;
3182 const bool kFpsScalingEnabled = false;
3183 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3184}
3185
3186TEST_F(WebRtcVideoChannelTest,
3187 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3188 webrtc::test::ScopedFieldTrials override_field_trials_(
3189 "WebRTC-Video-BalancedDegradation/Enabled/");
3190 const bool kResolutionScalingEnabled = true;
3191 const bool kFpsScalingEnabled = true;
3192 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3193}
3194
eladalonf1841382017-06-12 01:16:46 -07003195TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003196 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003197}
3198
eladalonf1841382017-06-12 01:16:46 -07003199TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003200 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003201}
3202
eladalonf1841382017-06-12 01:16:46 -07003203TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003204 TestCpuAdaptation(true, true);
3205}
3206
eladalonf1841382017-06-12 01:16:46 -07003207TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003208 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003209 cricket::VideoSendParameters parameters;
3210 parameters.codecs.push_back(codec);
3211
kthelgason2bc68642017-02-07 07:02:22 -08003212 MediaConfig media_config = GetMediaConfig();
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003213 channel_.reset(engine_.CreateChannel(
3214 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003215 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003216 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3217
3218 AddSendStream();
3219
Tommi85959932018-02-07 19:26:06 +01003220 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003221 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003222 ASSERT_EQ(cricket::CS_RUNNING,
3223 capturer.Start(capturer.GetSupportedFormats()->front()));
3224 ASSERT_TRUE(channel_->SetSend(true));
3225
3226 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3227 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003228
Niels Möllera6cc0f92018-02-12 17:14:55 +01003229 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003230 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3231 EXPECT_EQ(1280, send_stream->GetLastWidth());
3232 EXPECT_EQ(720, send_stream->GetLastHeight());
3233
3234 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003235 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003236 wants.max_pixel_count =
3237 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003238 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003239 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003240 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3241 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3242 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3243
3244 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003245 wants.max_pixel_count =
3246 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003247 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003248 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003249 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3250 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3251 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3252
3253 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003254 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003255 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003256 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3257 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3258
3259 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003260 int current_pixel_count =
3261 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3262 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3263 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003264 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003265 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003266 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003267 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003268 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003269 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003270 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3271 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3272
sprang84a37592017-02-10 07:04:27 -08003273 // Trigger underuse again, should go back up to full resolution.
3274 current_pixel_count =
3275 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003276 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003277 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003278 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003279 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003280 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003281 EXPECT_EQ(1284, send_stream->GetLastWidth());
3282 EXPECT_EQ(724, send_stream->GetLastHeight());
3283
Niels Möllerff40b142018-04-09 08:49:14 +02003284 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003285}
3286
eladalonf1841382017-06-12 01:16:46 -07003287TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003288 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003289 cricket::VideoSendParameters parameters;
3290 parameters.codecs.push_back(codec);
3291
kthelgason2bc68642017-02-07 07:02:22 -08003292 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003293 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003294 channel_.reset(engine_.CreateChannel(
3295 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003296 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003297 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3298
3299 AddSendStream();
3300
Tommi85959932018-02-07 19:26:06 +01003301 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003302 ASSERT_EQ(cricket::CS_RUNNING,
3303 capturer.Start(capturer.GetSupportedFormats()->front()));
3304 ASSERT_TRUE(channel_->SetSend(true));
3305 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003306 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003307 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003308
3309 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3310 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003311
Niels Möllera6cc0f92018-02-12 17:14:55 +01003312 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003313 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3314 EXPECT_EQ(1280, send_stream->GetLastWidth());
3315 EXPECT_EQ(720, send_stream->GetLastHeight());
3316
3317 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003318 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003319 wants.max_pixel_count =
3320 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003321 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003322 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003323 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3324 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3325 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3326
3327 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003328 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003329 ASSERT_EQ(cricket::CS_RUNNING,
3330 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003331 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003332 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003333 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003334 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003335 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3336 send_stream = fake_call_->GetVideoSendStreams().front();
3337 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003338 EXPECT_EQ(1284, send_stream->GetLastWidth());
3339 EXPECT_EQ(724, send_stream->GetLastHeight());
3340
3341 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003342 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003343 send_stream = fake_call_->GetVideoSendStreams().front();
3344 // We have a new fake send stream, so it doesn't remember the old sink wants.
3345 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003346 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003347 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003348 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003349 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3350 send_stream = fake_call_->GetVideoSendStreams().front();
3351 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003352 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3353 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3354
Niels Möllerff40b142018-04-09 08:49:14 +02003355 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003356}
3357
asapersson3c81a1a2017-06-14 05:52:21 -07003358// TODO(asapersson): Remove this test when the balanced field trial is removed.
3359void WebRtcVideoChannelTest::TestDegradationPreference(
3360 bool resolution_scaling_enabled,
3361 bool fps_scaling_enabled) {
3362 cricket::VideoCodec codec = GetEngineCodec("VP8");
3363 cricket::VideoSendParameters parameters;
3364 parameters.codecs.push_back(codec);
3365
3366 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003367 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003368 channel_.reset(engine_.CreateChannel(
3369 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003370 channel_->OnReadyToSend(true);
3371
3372 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3373
3374 AddSendStream();
3375
Tommi85959932018-02-07 19:26:06 +01003376 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003377 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003378 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003379 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3380 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3381
3382 EXPECT_TRUE(channel_->SetSend(true));
3383
3384 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3385 EXPECT_EQ(resolution_scaling_enabled,
3386 send_stream->resolution_scaling_enabled());
3387 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3388
Niels Möllerff40b142018-04-09 08:49:14 +02003389 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003390}
3391
eladalonf1841382017-06-12 01:16:46 -07003392void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3393 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003394 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003395 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003396 cricket::VideoSendParameters parameters;
3397 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003398
kthelgason2bc68642017-02-07 07:02:22 -08003399 MediaConfig media_config = GetMediaConfig();
3400 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003401 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003402 }
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003403 channel_.reset(engine_.CreateChannel(
3404 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003405 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003406
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003407 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003408
3409 AddSendStream();
3410
Tommi85959932018-02-07 19:26:06 +01003411 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003412 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003413 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003414 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003415 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003416 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003417 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003418
3419 EXPECT_TRUE(channel_->SetSend(true));
3420
solenberge5269742015-09-08 05:13:22 -07003421 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003422
sprangc5d62e22017-04-02 23:53:04 -07003423 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003424 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003425 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3426 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003427
3428 EXPECT_TRUE(capturer.CaptureFrame());
3429 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3430
perkj26752742016-10-24 01:21:16 -07003431 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3432 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003433
Niels Möllerff40b142018-04-09 08:49:14 +02003434 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003435 return;
3436 }
3437
sprangc5d62e22017-04-02 23:53:04 -07003438 if (is_screenshare) {
3439 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3440 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3441 } else {
3442 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3443 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3444 }
3445
perkj803d97f2016-11-01 11:45:46 -07003446 // Trigger overuse.
3447 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3448
3449 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003450 if (is_screenshare) {
3451 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3452 } else {
3453 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3454 }
perkj803d97f2016-11-01 11:45:46 -07003455 send_stream->InjectVideoSinkWants(wants);
3456
sprangc5d62e22017-04-02 23:53:04 -07003457 for (int i = 0; i < kDefaultFps; ++i)
3458 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003459
sprangc5d62e22017-04-02 23:53:04 -07003460 if (is_screenshare) {
3461 // Drops every third frame.
3462 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3463 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3464 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3465 } else {
3466 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3467 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3468 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3469 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003470
3471 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003472 int last_pixel_count =
3473 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003474 if (is_screenshare) {
3475 wants.max_framerate_fps = kDefaultFps;
3476 } else {
3477 wants.max_pixel_count = last_pixel_count * 4;
3478 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3479 }
perkj803d97f2016-11-01 11:45:46 -07003480 send_stream->InjectVideoSinkWants(wants);
3481
sprangc5d62e22017-04-02 23:53:04 -07003482 for (int i = 0; i < kDefaultFps; ++i)
3483 EXPECT_TRUE(capturer.CaptureFrame());
3484
3485 if (is_screenshare) {
3486 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3487 send_stream->GetNumberOfSwappedFrames());
3488 } else {
3489 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3490 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003491
perkj26752742016-10-24 01:21:16 -07003492 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3493 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003494
Niels Möllerff40b142018-04-09 08:49:14 +02003495 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003496}
3497
eladalonf1841382017-06-12 01:16:46 -07003498TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003499 // Start at last timestamp to verify that wraparounds are estimated correctly.
3500 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3501 static const int64_t kInitialNtpTimeMs = 1247891230;
3502 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003503 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003504
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003505 FakeVideoReceiveStream* stream = AddRecvStream();
3506 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003507 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003508
nisse64ec8f82016-09-27 00:17:25 -07003509 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3510 kInitialTimestamp, 0,
3511 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003512 // Initial NTP time is not available on the first frame, but should still be
3513 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003514 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003515
3516 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003517
3518 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3519 // triggers a constant-overflow warning, hence we're calculating it explicitly
3520 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003521 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003522 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3523 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003524 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003525
3526 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003527
3528 // Verify that NTP time has been correctly deduced.
3529 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003530 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003531 ASSERT_EQ(1u, info.receivers.size());
3532 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003533}
3534
eladalonf1841382017-06-12 01:16:46 -07003535TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003536 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003537 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003538
3539 VideoCodec codec;
3540 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003541 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003542
3543 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003544 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3545 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003546 FakeVideoSendStream* stream = AddSendStream(
3547 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003548 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003549
3550 // Make sure NACK and FEC are enabled on the correct payload types.
3551 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003552 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3553 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003554
3555 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3556 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003557 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003558 // TODO(juberti): Check RTCP, PLI, TMMBR.
3559}
3560
brandtr31bd2242017-05-19 05:47:46 -07003561// The following four tests ensures that FlexFEC is not activated by default
3562// when the field trials are not enabled.
3563// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3564// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003565TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003566 FakeVideoSendStream* stream = AddSendStream();
3567 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3568
brandtr3d200bd2017-01-16 06:59:19 -08003569 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003570 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3571 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003572}
3573
eladalonf1841382017-06-12 01:16:46 -07003574TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003575 FakeVideoSendStream* stream = AddSendStream(
3576 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3577 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3578
brandtr3d200bd2017-01-16 06:59:19 -08003579 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003580 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3581 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3582}
3583
Yves Gerey665174f2018-06-19 15:03:05 +02003584TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003585 AddRecvStream();
3586
3587 const std::vector<FakeFlexfecReceiveStream*>& streams =
3588 fake_call_->GetFlexfecReceiveStreams();
3589 EXPECT_TRUE(streams.empty());
3590}
3591
eladalonf1841382017-06-12 01:16:46 -07003592TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003593 AddRecvStream(
3594 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3595
3596 const std::vector<FakeFlexfecReceiveStream*>& streams =
3597 fake_call_->GetFlexfecReceiveStreams();
3598 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003599}
3600
3601// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3602// tests that use this test fixture into the corresponding "non-field trial"
3603// tests.
eladalonf1841382017-06-12 01:16:46 -07003604class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003605 public:
eladalonf1841382017-06-12 01:16:46 -07003606 WebRtcVideoChannelFlexfecRecvTest()
3607 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003608};
3609
eladalonf1841382017-06-12 01:16:46 -07003610TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003611 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3612 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3613 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3614}
3615
eladalonf1841382017-06-12 01:16:46 -07003616TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003617 AddRecvStream();
3618
3619 const std::vector<FakeFlexfecReceiveStream*>& streams =
3620 fake_call_->GetFlexfecReceiveStreams();
3621 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003622
3623 const std::vector<FakeVideoReceiveStream*>& video_streams =
3624 fake_call_->GetVideoReceiveStreams();
3625 ASSERT_EQ(1U, video_streams.size());
3626 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3627 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3628 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003629}
3630
eladalonf1841382017-06-12 01:16:46 -07003631TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003632 AddRecvStream(
3633 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3634
3635 const std::vector<FakeFlexfecReceiveStream*>& streams =
3636 fake_call_->GetFlexfecReceiveStreams();
3637 ASSERT_EQ(1U, streams.size());
3638 const FakeFlexfecReceiveStream* stream = streams.front();
3639 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3640 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3641 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3642 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3643 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003644
3645 const std::vector<FakeVideoReceiveStream*>& video_streams =
3646 fake_call_->GetVideoReceiveStreams();
3647 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003648 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3649 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003650 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003651 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003652 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003653}
3654
eladalonf1841382017-06-12 01:16:46 -07003655TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003656 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3657 cricket::VideoRecvParameters recv_parameters;
3658 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3659 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3660
3661 AddRecvStream(
3662 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3663 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003664 const std::vector<FakeVideoReceiveStream*>& video_streams =
3665 fake_call_->GetVideoReceiveStreams();
3666 ASSERT_EQ(1U, video_streams.size());
3667 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3668 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3669 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003670
3671 // Enable FlexFEC.
3672 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3673 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3674 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3675 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3676 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3677 << "Enabling FlexFEC should not create VideoReceiveStream.";
3678 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3679 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003680 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3681 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003682}
3683
eladalonf1841382017-06-12 01:16:46 -07003684TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003685 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3686 cricket::VideoRecvParameters recv_parameters;
3687 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3688 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3689 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3690
3691 AddRecvStream(
3692 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3693 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003694 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003695 const std::vector<FakeVideoReceiveStream*>& video_streams =
3696 fake_call_->GetVideoReceiveStreams();
3697 ASSERT_EQ(1U, video_streams.size());
3698 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3699 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3700 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003701
3702 // Disable FlexFEC.
3703 recv_parameters.codecs.clear();
3704 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3705 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3706 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3707 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3708 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3709 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3710 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3711 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003712 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3713 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003714}
3715
brandtr31bd2242017-05-19 05:47:46 -07003716// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3717// tests that use this test fixture into the corresponding "non-field trial"
3718// tests.
eladalonf1841382017-06-12 01:16:46 -07003719class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003720 public:
eladalonf1841382017-06-12 01:16:46 -07003721 WebRtcVideoChannelFlexfecSendRecvTest()
3722 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003723 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3724 }
3725};
3726
Yves Gerey665174f2018-06-19 15:03:05 +02003727TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003728 FakeVideoSendStream* stream = AddSendStream();
3729 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3730
brandtr3d200bd2017-01-16 06:59:19 -08003731 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3732 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3733 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003734}
3735
eladalonf1841382017-06-12 01:16:46 -07003736TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003737 FakeVideoSendStream* stream = AddSendStream(
3738 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3739 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3740
brandtr3d200bd2017-01-16 06:59:19 -08003741 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3742 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3743 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3744 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003745}
3746
eladalonf1841382017-06-12 01:16:46 -07003747TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003748 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003749 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003750 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003751
3752 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003753 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003754
brandtrb5f2c3f2016-10-04 23:28:39 -07003755 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3756 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003757}
3758
eladalonf1841382017-06-12 01:16:46 -07003759TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003760 cricket::VideoSendParameters parameters;
3761 parameters.codecs.push_back(GetEngineCodec("VP8"));
3762 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3763
3764 FakeVideoSendStream* stream = AddSendStream();
3765 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3766
brandtr3d200bd2017-01-16 06:59:19 -08003767 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003768}
3769
eladalonf1841382017-06-12 01:16:46 -07003770TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003771 AddRecvStream(
3772 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003773
3774 cricket::VideoRecvParameters recv_parameters;
3775 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3776 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3777 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003778
3779 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3780 fake_call_->GetFlexfecReceiveStreams();
3781 ASSERT_EQ(1U, flexfec_streams.size());
3782 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3783 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3784 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003785 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003786 flexfec_stream_config.payload_type);
3787 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3788 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3789 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3790 const std::vector<FakeVideoReceiveStream*>& video_streams =
3791 fake_call_->GetVideoReceiveStreams();
3792 const FakeVideoReceiveStream* video_stream = video_streams.front();
3793 const webrtc::VideoReceiveStream::Config& video_stream_config =
3794 video_stream->GetConfig();
3795 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3796 flexfec_stream_config.local_ssrc);
3797 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3798 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3799 flexfec_stream_config.rtcp_send_transport);
3800 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3801 // spec-compliant way.
3802 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3803 flexfec_stream_config.transport_cc);
3804 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3805 EXPECT_EQ(video_stream_config.rtp.extensions,
3806 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003807}
3808
brandtr31bd2242017-05-19 05:47:46 -07003809// We should not send FlexFEC, even if we advertise it, unless the right
3810// field trial is set.
3811// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003812TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003813 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3814 cricket::VideoSendParameters parameters;
3815 parameters.codecs.push_back(GetEngineCodec("VP8"));
3816 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3817 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3818
3819 FakeVideoSendStream* stream = AddSendStream();
3820 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3821
3822 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003823 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003824 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3825}
3826
eladalonf1841382017-06-12 01:16:46 -07003827TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003828 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3829 cricket::VideoSendParameters parameters;
3830 parameters.codecs.push_back(GetEngineCodec("VP8"));
3831 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3832 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3833
3834 FakeVideoSendStream* stream = AddSendStream(
3835 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3836 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3837
3838 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003839 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003840 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3841}
3842
eladalonf1841382017-06-12 01:16:46 -07003843TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003844 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003845 const int kUnusedPayloadType = 127;
3846 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3847
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003848 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003849 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003850 parameters.codecs.push_back(rtx_codec);
3851 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003852 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003853}
3854
eladalonf1841382017-06-12 01:16:46 -07003855TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003856 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003857 const int kUnusedPayloadType1 = 126;
3858 const int kUnusedPayloadType2 = 127;
3859 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3860 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3861 {
3862 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3863 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3864 cricket::VideoSendParameters parameters;
3865 parameters.codecs.push_back(GetEngineCodec("VP8"));
3866 parameters.codecs.push_back(rtx_codec);
3867 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3868 }
3869 {
3870 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3871 kUnusedPayloadType1, kUnusedPayloadType2);
3872 cricket::VideoSendParameters parameters;
3873 parameters.codecs.push_back(GetEngineCodec("VP8"));
3874 parameters.codecs.push_back(rtx_codec);
3875 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3876 << "RTX without matching video codec should be rejected.";
3877 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003878}
3879
eladalonf1841382017-06-12 01:16:46 -07003880TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003881 const int kUnusedPayloadType1 = 126;
3882 const int kUnusedPayloadType2 = 127;
3883 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3884 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3885
3886 // SSRCs for RTX.
3887 cricket::StreamParams params =
3888 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3889 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3890 AddSendStream(params);
3891
3892 // Original payload type for RTX.
3893 cricket::VideoSendParameters parameters;
3894 parameters.codecs.push_back(GetEngineCodec("VP8"));
3895 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3896 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3897 parameters.codecs.push_back(rtx_codec);
3898 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3899 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3900 const webrtc::VideoSendStream::Config& config_before =
3901 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3902 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3903 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3904 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3905
3906 // Change payload type for RTX.
3907 parameters.codecs[1].id = kUnusedPayloadType2;
3908 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3909 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3910 const webrtc::VideoSendStream::Config& config_after =
3911 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3912 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3913 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3914 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3915}
3916
eladalonf1841382017-06-12 01:16:46 -07003917TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003918 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003919 parameters.codecs.push_back(GetEngineCodec("VP8"));
3920 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003921 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003922
3923 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003924 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003925
magjed509e4fe2016-11-18 01:34:11 -08003926 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003927
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003928 parameters.codecs.pop_back();
3929 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003930 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003931 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003932 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003933 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003934 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3935}
3936
eladalonf1841382017-06-12 01:16:46 -07003937TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003938 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003939 cricket::VideoSendParameters parameters;
3940 parameters.codecs.push_back(GetEngineCodec("VP8"));
3941 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3942 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3943
3944 FakeVideoSendStream* stream = AddSendStream(
3945 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3946 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3947
brandtr3d200bd2017-01-16 06:59:19 -08003948 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3949 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003950 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3951 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3952
3953 parameters.codecs.pop_back();
3954 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3955 stream = fake_call_->GetVideoSendStreams()[0];
3956 ASSERT_TRUE(stream != nullptr);
3957 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003958 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003959 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003960}
3961
eladalonf1841382017-06-12 01:16:46 -07003962TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003963 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003964 cricket::VideoCodec codec(100, "VP8");
3965 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3966 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003967
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003968 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003969 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003970
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003971 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003972 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003973 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003974
3975 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003976 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003977
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003978 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003979 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3980 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003981 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003982 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003983 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003984 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003985}
3986
eladalonf1841382017-06-12 01:16:46 -07003987TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003988 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3989 200000);
3990}
3991
eladalonf1841382017-06-12 01:16:46 -07003992TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003993 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3994 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3995 ASSERT_EQ(1u, streams.size());
3996 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3997}
3998
eladalonf1841382017-06-12 01:16:46 -07003999TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004000 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004001 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004002}
4003
eladalonf1841382017-06-12 01:16:46 -07004004TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004005 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004006}
4007
eladalonf1841382017-06-12 01:16:46 -07004008TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004009 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4010 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4011 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004012}
4013
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004014// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4015// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004016TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004017 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4018 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4019 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4020 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004021 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004022 ExpectSetBitrateParameters(100000, 200000, 400000);
4023 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4024 // Since the codec isn't changing, start_bitrate_bps should be -1.
4025 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004026
4027 // Decrease max_bandwidth_bps.
4028 send_parameters_.max_bandwidth_bps = 350000;
4029 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004030
4031 // Now try again with the values flipped around.
4032 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4033 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004034 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004035 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004036
4037 // If we change the codec max, max_bandwidth_bps should still apply.
4038 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004039 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004040 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004041}
4042
Yves Gerey665174f2018-06-19 15:03:05 +02004043TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004044 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4045 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004046 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004047 // Setting max bitrate should keep previous min bitrate.
4048 // Setting max bitrate should not reset start bitrate.
4049 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004050 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004051}
4052
eladalonf1841382017-06-12 01:16:46 -07004053TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004054 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004055 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004056 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004057 // -1 means to disable max bitrate (set infinite).
4058 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004059 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004060 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004061}
4062
eladalonf1841382017-06-12 01:16:46 -07004063TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004064 send_parameters_.max_bandwidth_bps = 99999;
4065 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004066 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004067 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004068 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4069 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4070 stream->GetVideoStreams()[0].max_bitrate_bps);
4071
4072 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004073 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004074 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4075 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004076 stream->GetVideoStreams()[0].max_bitrate_bps);
4077}
4078
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004079// Tests that when the codec specific max bitrate and VideoSendParameters
4080// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4081// appropriately.
4082TEST_F(WebRtcVideoChannelTest,
4083 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4084 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4085 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4086 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4087 send_parameters_.max_bandwidth_bps = -1;
4088 AddSendStream();
4089 ExpectSetMaxBitrate(300000);
4090 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4091
4092 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4093 ASSERT_EQ(1u, video_send_streams.size());
4094 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4095 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4096 // First the max bitrate is set based upon the codec param.
4097 EXPECT_EQ(300000,
4098 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4099
4100 // The VideoSendParameters max bitrate overrides the codec's.
4101 send_parameters_.max_bandwidth_bps = 500000;
4102 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4103 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4104 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4105 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4106}
4107
4108// Tests that when the codec specific max bitrate and RtpParameters
4109// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4110// appropriately.
4111TEST_F(WebRtcVideoChannelTest,
4112 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4113 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4114 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4115 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4116 send_parameters_.max_bandwidth_bps = -1;
4117 AddSendStream();
4118 ExpectSetMaxBitrate(300000);
4119 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4120
4121 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4122 ASSERT_EQ(1u, video_send_streams.size());
4123 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4124 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4125 // First the max bitrate is set based upon the codec param.
4126 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4127
4128 // The RtpParameter max bitrate overrides the codec's.
4129 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4130 ASSERT_EQ(1u, parameters.encodings.size());
4131 parameters.encodings[0].max_bitrate_bps = 500000;
4132 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4133 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4134 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4135 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4136}
4137
Åsa Persson55659812018-06-18 17:51:32 +02004138TEST_F(WebRtcVideoChannelTest,
4139 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4140 send_parameters_.max_bandwidth_bps = 99999;
4141 FakeVideoSendStream* stream = AddSendStream();
4142 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4143 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4144 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4145 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4146 stream->GetVideoStreams()[0].max_bitrate_bps);
4147
4148 // Get and set the rtp encoding parameters.
4149 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4150 EXPECT_EQ(1u, parameters.encodings.size());
4151
4152 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4153 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4154 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4155 stream->GetVideoStreams()[0].max_bitrate_bps);
4156
4157 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4158 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4159 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4160 stream->GetVideoStreams()[0].max_bitrate_bps);
4161}
4162
eladalonf1841382017-06-12 01:16:46 -07004163TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004164 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004165 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004166 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004167 channel_->SetSend(true);
4168
4169 FakeVideoSendStream* stream = AddSendStream();
4170
Tommi85959932018-02-07 19:26:06 +01004171 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004172 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004173 EXPECT_EQ(cricket::CS_RUNNING,
4174 capturer.Start(capturer.GetSupportedFormats()->front()));
4175
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004176 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4177 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4178 EXPECT_GT(initial_max_bitrate_bps, 0);
4179
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004180 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4181 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004182 // Insert a frame to update the encoder config.
4183 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004184 streams = stream->GetVideoStreams();
4185 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004186 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004187}
4188
eladalonf1841382017-06-12 01:16:46 -07004189TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004190 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004191 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004192 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004193 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004194 channel_->SetSend(true);
4195
4196 FakeVideoSendStream* stream = AddSendStream(
4197 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4198
4199 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004200 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004201 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004202 EXPECT_EQ(cricket::CS_RUNNING,
4203 capturer.Start(capturer.GetSupportedFormats()->front()));
4204 EXPECT_TRUE(capturer.CaptureFrame());
4205
4206 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4207 ASSERT_GT(streams.size(), 1u)
4208 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004209 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004210 EXPECT_GT(initial_max_bitrate_bps, 0);
4211
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004212 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4213 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004214 // Insert a frame to update the encoder config.
4215 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004216 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004217 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004218 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4219
Niels Möllerff40b142018-04-09 08:49:14 +02004220 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004221}
4222
eladalonf1841382017-06-12 01:16:46 -07004223TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004224 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004225 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004226 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004227 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4228 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004229 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004230 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004231
4232 VideoCodec codec;
4233 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4234 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4235}
4236
eladalonf1841382017-06-12 01:16:46 -07004237TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004238 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004239 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004240 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004241 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004242 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004243 parameters.codecs[0].id = kIncorrectPayloads[i];
4244 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004245 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004246 }
4247}
4248
eladalonf1841382017-06-12 01:16:46 -07004249TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004250 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004251 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004252 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004253 parameters.codecs[0].id = payload_type;
4254 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004255 << "Payload type '" << payload_type << "' rejected.";
4256 }
4257}
4258
deadbeef67cf2c12016-04-13 10:07:16 -07004259// Test that setting the a different set of codecs but with an identical front
4260// codec doesn't result in the stream being recreated.
4261// This may happen when a subsequent negotiation includes fewer codecs, as a
4262// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004263TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004264 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4265 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004266 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4267 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004268 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4269
4270 AddSendStream();
4271 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4272
4273 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004274 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004275 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4276 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4277}
4278
eladalonf1841382017-06-12 01:16:46 -07004279TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004280 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004281 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004282 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004283}
4284
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004285// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004286TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004287 const int kUnusedPayloadType1 = 126;
4288 const int kUnusedPayloadType2 = 127;
4289 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4290 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4291
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004292 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004293 parameters.codecs.push_back(GetEngineCodec("VP8"));
4294 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004295 parameters.codecs.push_back(rtx_codec);
4296 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004297 << "RTX codec without associated payload should be rejected.";
4298
magjed509e4fe2016-11-18 01:34:11 -08004299 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004300 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004301 << "RTX codec with invalid associated payload type should be rejected.";
4302
magjed509e4fe2016-11-18 01:34:11 -08004303 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004304 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004305
magjed509e4fe2016-11-18 01:34:11 -08004306 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004307 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004308 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004309
Yves Gerey665174f2018-06-19 15:03:05 +02004310 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4311 << "RTX codec with another RTX as associated payload type should be "
4312 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004313}
4314
eladalonf1841382017-06-12 01:16:46 -07004315TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004316 const int kUnusedPayloadType1 = 126;
4317 const int kUnusedPayloadType2 = 127;
4318 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4319 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4320
4321 // SSRCs for RTX.
4322 cricket::StreamParams params =
4323 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4324 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4325 AddRecvStream(params);
4326
4327 // Original payload type for RTX.
4328 cricket::VideoRecvParameters parameters;
4329 parameters.codecs.push_back(GetEngineCodec("VP8"));
4330 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4331 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4332 parameters.codecs.push_back(rtx_codec);
4333 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4334 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4335 const webrtc::VideoReceiveStream::Config& config_before =
4336 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004337 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4338 const int* payload_type_before = FindKeyByValue(
4339 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4340 ASSERT_NE(payload_type_before, nullptr);
4341 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004342 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4343
4344 // Change payload type for RTX.
4345 parameters.codecs[1].id = kUnusedPayloadType2;
4346 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4347 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4348 const webrtc::VideoReceiveStream::Config& config_after =
4349 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004350 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4351 const int* payload_type_after = FindKeyByValue(
4352 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4353 ASSERT_NE(payload_type_after, nullptr);
4354 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004355 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4356}
4357
eladalonf1841382017-06-12 01:16:46 -07004358TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004359 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004360 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004361 parameters.codecs[0].id = 99;
4362 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004363}
4364
eladalonf1841382017-06-12 01:16:46 -07004365TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004366 cricket::VideoRecvParameters parameters;
4367 parameters.codecs = engine_.codecs();
4368 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004369
4370 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004371 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004372 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004373 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004374}
4375
eladalonf1841382017-06-12 01:16:46 -07004376TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004377 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004378 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004379 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004380 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004381}
4382
eladalonf1841382017-06-12 01:16:46 -07004383TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004384 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004385 parameters.codecs.push_back(GetEngineCodec("VP8"));
4386 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004387 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004388}
4389
eladalonf1841382017-06-12 01:16:46 -07004390TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004391 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004392 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4393 send_parameters.codecs.push_back(GetEngineCodec("red"));
4394 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004395 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004396
4397 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004398
magjed509e4fe2016-11-18 01:34:11 -08004399 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004400 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004401
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004402 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004403 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004404 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004405 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004406 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004407 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004408 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4409}
4410
eladalonf1841382017-06-12 01:16:46 -07004411TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004412 AddRecvStream(
4413 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004414 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004415 fake_call_->GetFlexfecReceiveStreams();
4416
4417 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004418 const FakeFlexfecReceiveStream* stream = streams.front();
4419 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4420 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4421 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4422 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004423
4424 cricket::VideoRecvParameters recv_parameters;
4425 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4426 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4427 EXPECT_TRUE(streams.empty())
4428 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004429}
4430
eladalonf1841382017-06-12 01:16:46 -07004431TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004432 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004433 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004434 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004435
4436 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004437 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4438 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4439 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004440 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4441 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004442 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004443 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004444 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004445 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004446
4447 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004448 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4449 send_parameters.codecs.push_back(GetEngineCodec("red"));
4450 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004451 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4452 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004453 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004454 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004455 << "ULPFEC should be enabled on the receive stream.";
4456}
4457
eladalonf1841382017-06-12 01:16:46 -07004458TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004459 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004460 AddRecvStream(
4461 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004462 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004463 fake_call_->GetFlexfecReceiveStreams();
4464
4465 cricket::VideoRecvParameters recv_parameters;
4466 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4467 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4468 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4469 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004470 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004471 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004472 stream_with_recv_params->GetConfig().payload_type);
4473 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004474 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004475 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004476 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004477 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004478
4479 cricket::VideoSendParameters send_parameters;
4480 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4481 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4482 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4483 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004484 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004485 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004486 stream_with_send_params->GetConfig().payload_type);
4487 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004488 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004489 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004490 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004491 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004492}
4493
eladalonf1841382017-06-12 01:16:46 -07004494TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004495 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004496 parameters.codecs.push_back(GetEngineCodec("VP8"));
4497 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004498 parameters.codecs[1].id = parameters.codecs[0].id;
4499 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004500}
4501
eladalonf1841382017-06-12 01:16:46 -07004502TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004503 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004504 cricket::VideoRecvParameters parameters;
4505 parameters.codecs.push_back(GetEngineCodec("VP8"));
4506 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4507 parameters.codecs[1].id = parameters.codecs[0].id;
4508 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4509}
4510
eladalonf1841382017-06-12 01:16:46 -07004511TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004512 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004513 parameters.codecs.push_back(GetEngineCodec("VP8"));
4514 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004515 parameters.codecs[1].id = parameters.codecs[0].id;
4516 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004517}
4518
eladalonf1841382017-06-12 01:16:46 -07004519TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004520 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004521 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004522 parameters.codecs.push_back(GetEngineCodec("VP8"));
4523 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004524 parameters.codecs[1].id += 1;
4525 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004526}
4527
deadbeef67cf2c12016-04-13 10:07:16 -07004528// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004529// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004530TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004531 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004532 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004533 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4534 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004535 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004536
4537 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4538 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4539
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004540 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004541 parameters2.codecs.push_back(GetEngineCodec("red"));
4542 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004543 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004544 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4545}
4546
eladalonf1841382017-06-12 01:16:46 -07004547TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004548 EXPECT_FALSE(AddSendStream()->IsSending());
4549}
4550
eladalonf1841382017-06-12 01:16:46 -07004551TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004552 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004553}
4554
eladalonf1841382017-06-12 01:16:46 -07004555TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004556 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004557 EXPECT_FALSE(stream->IsSending());
4558
4559 // false->true
4560 EXPECT_TRUE(channel_->SetSend(true));
4561 EXPECT_TRUE(stream->IsSending());
4562 // true->true
4563 EXPECT_TRUE(channel_->SetSend(true));
4564 EXPECT_TRUE(stream->IsSending());
4565 // true->false
4566 EXPECT_TRUE(channel_->SetSend(false));
4567 EXPECT_FALSE(stream->IsSending());
4568 // false->false
4569 EXPECT_TRUE(channel_->SetSend(false));
4570 EXPECT_FALSE(stream->IsSending());
4571
4572 EXPECT_TRUE(channel_->SetSend(true));
4573 FakeVideoSendStream* new_stream = AddSendStream();
4574 EXPECT_TRUE(new_stream->IsSending())
4575 << "Send stream created after SetSend(true) not sending initially.";
4576}
4577
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004578// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004579TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004580 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004581 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004582 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004583 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004584 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004585
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004586 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4587 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004588 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004589 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004590 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004591
Tim Haloun648d28a2018-10-18 16:52:22 -07004592 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4593 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004594 config.enable_dscp = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004595 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4596 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004597 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004598 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4599
4600 // Create a send stream to configure
4601 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4602 parameters = channel->GetRtpSendParameters(kSsrc);
4603 ASSERT_FALSE(parameters.encodings.empty());
4604
4605 // Various priorities map to various dscp values.
4606 parameters.encodings[0].network_priority = 4.0;
4607 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004608 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004609 parameters.encodings[0].network_priority = 0.5;
4610 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4611 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4612
4613 // A bad priority does not change the dscp value.
4614 parameters.encodings[0].network_priority = 0.0;
4615 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4616 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004617
Tim Haloun6ca98362018-09-17 17:06:08 -07004618 // Packets should also self-identify their dscp in PacketOptions.
4619 const uint8_t kData[10] = {0};
4620 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4621 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004622 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004623
nisse51542be2016-02-12 02:27:06 -08004624 // Verify that setting the option to false resets the
4625 // DiffServCodePoint.
4626 config.enable_dscp = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004627 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4628 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004629 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004630 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004631}
4632
deadbeef13871492015-12-09 12:37:51 -08004633// This test verifies that the RTCP reduced size mode is properly applied to
4634// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004635TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004636 // Create stream, expecting that default mode is "compound".
4637 FakeVideoSendStream* stream1 = AddSendStream();
4638 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004639 webrtc::RtpParameters rtp_parameters =
4640 channel_->GetRtpSendParameters(last_ssrc_);
4641 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004642
4643 // Now enable reduced size mode.
4644 send_parameters_.rtcp.reduced_size = true;
4645 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4646 stream1 = fake_call_->GetVideoSendStreams()[0];
4647 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004648 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4649 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004650
4651 // Create a new stream and ensure it picks up the reduced size mode.
4652 FakeVideoSendStream* stream2 = AddSendStream();
4653 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4654}
4655
4656// This test verifies that the RTCP reduced size mode is properly applied to
4657// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004658TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004659 // Create stream, expecting that default mode is "compound".
4660 FakeVideoReceiveStream* stream1 = AddRecvStream();
4661 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4662
4663 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004664 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4665 // the reduced_size flag should come from that.
4666 send_parameters_.rtcp.reduced_size = true;
4667 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004668 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4669 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4670
4671 // Create a new stream and ensure it picks up the reduced size mode.
4672 FakeVideoReceiveStream* stream2 = AddRecvStream();
4673 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4674}
4675
eladalonf1841382017-06-12 01:16:46 -07004676TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004677 EXPECT_EQ(webrtc::kNetworkUp,
4678 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4679 EXPECT_EQ(webrtc::kNetworkUp,
4680 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004681
4682 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004683 EXPECT_EQ(webrtc::kNetworkDown,
4684 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4685 EXPECT_EQ(webrtc::kNetworkUp,
4686 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004687
4688 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004689 EXPECT_EQ(webrtc::kNetworkUp,
4690 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4691 EXPECT_EQ(webrtc::kNetworkUp,
4692 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004693}
4694
eladalonf1841382017-06-12 01:16:46 -07004695TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004696 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004697 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004698 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004699
4700 AddSendStream();
4701
4702 cricket::VideoMediaInfo info;
4703 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004704 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004705}
4706
eladalonf1841382017-06-12 01:16:46 -07004707TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004708 FakeVideoSendStream* stream = AddSendStream();
4709 webrtc::VideoSendStream::Stats stats;
4710 stats.encoder_implementation_name = "encoder_implementation_name";
4711 stream->SetStats(stats);
4712
4713 cricket::VideoMediaInfo info;
4714 ASSERT_TRUE(channel_->GetStats(&info));
4715 EXPECT_EQ(stats.encoder_implementation_name,
4716 info.senders[0].encoder_implementation_name);
4717}
4718
eladalonf1841382017-06-12 01:16:46 -07004719TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004720 FakeVideoSendStream* stream = AddSendStream();
4721 webrtc::VideoSendStream::Stats stats;
4722 stats.avg_encode_time_ms = 13;
4723 stats.encode_usage_percent = 42;
4724 stream->SetStats(stats);
4725
4726 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004727 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004728 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4729 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4730}
4731
eladalonf1841382017-06-12 01:16:46 -07004732TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004733 FakeVideoSendStream* stream = AddSendStream();
4734 webrtc::VideoSendStream::Stats stats;
4735 stats.frames_encoded = 13;
4736 stream->SetStats(stats);
4737
4738 cricket::VideoMediaInfo info;
4739 ASSERT_TRUE(channel_->GetStats(&info));
4740 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4741}
4742
eladalonf1841382017-06-12 01:16:46 -07004743TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004744 FakeVideoSendStream* stream = AddSendStream();
4745 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004746 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004747 stream->SetStats(stats);
4748
4749 cricket::VideoMediaInfo info;
4750 ASSERT_TRUE(channel_->GetStats(&info));
4751 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4752}
4753
eladalonf1841382017-06-12 01:16:46 -07004754TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004755 FakeVideoSendStream* stream = AddSendStream();
4756 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004757 stats.substreams[17].width = 123;
4758 stats.substreams[17].height = 40;
4759 stats.substreams[42].width = 80;
4760 stats.substreams[42].height = 31;
4761 stats.substreams[11].width = 20;
4762 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004763 stream->SetStats(stats);
4764
4765 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004766 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004767 ASSERT_EQ(1u, info.senders.size());
4768 EXPECT_EQ(123, info.senders[0].send_frame_width);
4769 EXPECT_EQ(90, info.senders[0].send_frame_height);
4770}
4771
eladalonf1841382017-06-12 01:16:46 -07004772TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004773 FakeVideoSendStream* stream = AddSendStream();
4774 webrtc::VideoSendStream::Stats stats;
4775 stats.number_of_cpu_adapt_changes = 2;
4776 stats.cpu_limited_resolution = true;
4777 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004778
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004779 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004780 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004781 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004782 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004783 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004784}
4785
eladalonf1841382017-06-12 01:16:46 -07004786TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004787 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004788 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004789 stats.number_of_cpu_adapt_changes = 2;
4790 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004791 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004792 stream->SetStats(stats);
4793
4794 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004795 EXPECT_TRUE(channel_->GetStats(&info));
4796 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004797 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4798 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004799 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004800 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004801}
4802
eladalonf1841382017-06-12 01:16:46 -07004803TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004804 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4805 FakeVideoSendStream* stream = AddSendStream();
4806 webrtc::VideoSendStream::Stats stats;
4807 stats.bw_limited_resolution = true;
4808 stream->SetStats(stats);
4809
4810 cricket::VideoMediaInfo info;
4811 EXPECT_TRUE(channel_->GetStats(&info));
4812 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004813 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004814 info.senders[0].adapt_reason);
4815}
4816
Yves Gerey665174f2018-06-19 15:03:05 +02004817TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004818 FakeVideoSendStream* stream = AddSendStream();
4819 webrtc::VideoSendStream::Stats stats;
4820 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4821 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4822 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4823
4824 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4825 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4826 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4827
4828 stream->SetStats(stats);
4829
4830 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004831 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004832 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4833 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4834 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4835}
4836
eladalonf1841382017-06-12 01:16:46 -07004837TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004838 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4839 FakeVideoReceiveStream* stream = AddRecvStream();
4840 webrtc::VideoReceiveStream::Stats stats;
4841 stats.rtcp_packet_type_counts.fir_packets = 2;
4842 stats.rtcp_packet_type_counts.nack_packets = 3;
4843 stats.rtcp_packet_type_counts.pli_packets = 4;
4844 stream->SetStats(stats);
4845
4846 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004847 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004848 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004849 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004850 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004851 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004852 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004853 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004854}
4855
eladalonf1841382017-06-12 01:16:46 -07004856TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004857 FakeVideoReceiveStream* stream = AddRecvStream();
4858 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004859 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004860 stats.decode_ms = 2;
4861 stats.max_decode_ms = 3;
4862 stats.current_delay_ms = 4;
4863 stats.target_delay_ms = 5;
4864 stats.jitter_buffer_ms = 6;
4865 stats.min_playout_delay_ms = 7;
4866 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004867 stats.width = 9;
4868 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004869 stats.frame_counts.key_frames = 11;
4870 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004871 stats.frames_rendered = 13;
4872 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004873 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004874 stream->SetStats(stats);
4875
4876 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004877 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004878 EXPECT_EQ(stats.decoder_implementation_name,
4879 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004880 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4881 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4882 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4883 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4884 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4885 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4886 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004887 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4888 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004889 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4890 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004891 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004892 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004893 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004894 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004895}
4896
eladalonf1841382017-06-12 01:16:46 -07004897TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004898 FakeVideoReceiveStream* stream = AddRecvStream();
4899 webrtc::VideoReceiveStream::Stats stats;
4900 stats.rtp_stats.transmitted.payload_bytes = 2;
4901 stats.rtp_stats.transmitted.header_bytes = 3;
4902 stats.rtp_stats.transmitted.padding_bytes = 4;
4903 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004904 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004905 stats.rtcp_stats.fraction_lost = 7;
4906 stream->SetStats(stats);
4907
4908 cricket::VideoMediaInfo info;
4909 ASSERT_TRUE(channel_->GetStats(&info));
4910 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4911 stats.rtp_stats.transmitted.header_bytes +
4912 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004913 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004914 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004915 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004916 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004917 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004918 info.receivers[0].fraction_lost);
4919}
4920
eladalonf1841382017-06-12 01:16:46 -07004921TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004922 AddSendStream();
4923 AddSendStream();
4924 webrtc::Call::Stats stats;
4925 stats.rtt_ms = 123;
4926 fake_call_->SetStats(stats);
4927
4928 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004929 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004930 ASSERT_EQ(2u, info.senders.size());
4931 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4932 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4933}
4934
eladalonf1841382017-06-12 01:16:46 -07004935TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004936 FakeVideoSendStream* stream = AddSendStream();
4937 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004938 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004939 stats.media_bitrate_bps = 123;
4940 stats.substreams[17].total_bitrate_bps = 1;
4941 stats.substreams[17].retransmit_bitrate_bps = 2;
4942 stats.substreams[42].total_bitrate_bps = 3;
4943 stats.substreams[42].retransmit_bitrate_bps = 4;
4944 stream->SetStats(stats);
4945
4946 FakeVideoSendStream* stream2 = AddSendStream();
4947 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004948 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004949 stats2.media_bitrate_bps = 321;
4950 stats2.substreams[13].total_bitrate_bps = 5;
4951 stats2.substreams[13].retransmit_bitrate_bps = 6;
4952 stats2.substreams[21].total_bitrate_bps = 7;
4953 stats2.substreams[21].retransmit_bitrate_bps = 8;
4954 stream2->SetStats(stats2);
4955
4956 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004957 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004958 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004959 BandwidthEstimationInfo bwe_info;
4960 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004961 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4962 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4963 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4964 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004965 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004966 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004967 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004968 bwe_info.actual_enc_bitrate);
4969 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004970 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004971 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004972 << "Bandwidth stats should take all streams into account.";
4973}
4974
eladalonf1841382017-06-12 01:16:46 -07004975TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004976 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004977
Peter Boström0c4e06b2015-10-07 12:23:21 +02004978 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4979 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004980
4981 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4982 const size_t kDataLength = 12;
4983 uint8_t data[kDataLength];
4984 memset(data, 0, sizeof(data));
4985 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004986 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004987 rtc::PacketTime packet_time;
4988 channel_->OnPacketReceived(&packet, packet_time);
4989
4990 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4991 << "No default receive stream created.";
4992 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004993 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004994 << "Default receive stream should not have configured RTX";
4995
4996 EXPECT_TRUE(channel_->AddRecvStream(
4997 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4998 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004999 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005000 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005001 EXPECT_FALSE(
5002 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005003 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005004 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005005 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005006 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005007 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005008 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005009}
5010
eladalonf1841382017-06-12 01:16:46 -07005011TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005012 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005013
Peter Boström0c4e06b2015-10-07 12:23:21 +02005014 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5015 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005016
5017 StreamParams sp =
5018 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5019 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5020
5021 EXPECT_FALSE(channel_->AddSendStream(sp));
5022 EXPECT_FALSE(channel_->AddRecvStream(sp));
5023}
5024
eladalonf1841382017-06-12 01:16:46 -07005025TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005026 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005027
Peter Boström0c4e06b2015-10-07 12:23:21 +02005028 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5029 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005030
5031 StreamParams sp =
5032 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5033
5034 EXPECT_TRUE(channel_->AddSendStream(sp));
5035 EXPECT_TRUE(channel_->AddRecvStream(sp));
5036
5037 // The RTX SSRC is already used in previous streams, using it should fail.
5038 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5039 EXPECT_FALSE(channel_->AddSendStream(sp));
5040 EXPECT_FALSE(channel_->AddRecvStream(sp));
5041
5042 // After removing the original stream this should be fine to add (makes sure
5043 // that RTX ssrcs are not forever taken).
5044 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5045 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5046 EXPECT_TRUE(channel_->AddSendStream(sp));
5047 EXPECT_TRUE(channel_->AddRecvStream(sp));
5048}
5049
eladalonf1841382017-06-12 01:16:46 -07005050TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005051 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005052 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5053 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005054 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005055
Peter Boströmd6f4c252015-03-26 16:23:04 +01005056 StreamParams sp =
5057 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5058
5059 EXPECT_TRUE(channel_->AddSendStream(sp));
5060 EXPECT_TRUE(channel_->AddRecvStream(sp));
5061
5062 // One of the SSRCs is already used in previous streams, using it should fail.
5063 sp = cricket::CreateSimStreamParams("cname",
5064 MAKE_VECTOR(kOverlappingStreamSsrcs));
5065 EXPECT_FALSE(channel_->AddSendStream(sp));
5066 EXPECT_FALSE(channel_->AddRecvStream(sp));
5067
5068 // After removing the original stream this should be fine to add (makes sure
5069 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005070 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5071 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005072 EXPECT_TRUE(channel_->AddSendStream(sp));
5073 EXPECT_TRUE(channel_->AddRecvStream(sp));
5074}
5075
eladalonf1841382017-06-12 01:16:46 -07005076TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005077 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005078
5079 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5080 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5081
5082 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5083 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5084
5085 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5086
5087 static const uint32_t kReceiverSsrcs[] = {3};
5088 static const uint32_t kReceiverRtxSsrcs[] = {2};
5089
5090 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5091 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5092 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5093
5094 cricket::VideoMediaInfo info;
5095 ASSERT_TRUE(channel_->GetStats(&info));
5096
5097 ASSERT_EQ(1u, info.senders.size());
5098 ASSERT_EQ(1u, info.receivers.size());
5099
5100 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5101 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5102 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5103}
5104
eladalonf1841382017-06-12 01:16:46 -07005105TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005106 FakeVideoReceiveStream* stream = AddRecvStream();
5107 webrtc::VideoReceiveStream::Stats stats;
5108 cricket::VideoMediaInfo info;
5109
5110 // Report no codec name before receiving.
5111 stream->SetStats(stats);
5112 ASSERT_TRUE(channel_->GetStats(&info));
5113 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5114
5115 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005116 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005117 stream->SetStats(stats);
5118 ASSERT_TRUE(channel_->GetStats(&info));
5119 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5120
5121 // Report no codec name for unknown playload types.
5122 stats.current_payload_type = 3;
5123 stream->SetStats(stats);
5124 ASSERT_TRUE(channel_->GetStats(&info));
5125 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5126}
5127
Seth Hampson5897a6e2018-04-03 11:16:33 -07005128// Tests that when we add a stream without SSRCs, but contains a stream_id
5129// that it is stored and its stream id is later used when the first packet
5130// arrives to properly create a receive stream with a sync label.
5131TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5132 const char kSyncLabel[] = "sync_label";
5133 cricket::StreamParams unsignaled_stream;
5134 unsignaled_stream.set_stream_ids({kSyncLabel});
5135 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5136 // The stream shouldn't have been created at this point because it doesn't
5137 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005138 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005139
5140 // Create and deliver packet.
5141 const size_t kDataLength = 12;
5142 uint8_t data[kDataLength];
5143 memset(data, 0, sizeof(data));
5144 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5145 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5146 rtc::PacketTime packet_time;
5147 channel_->OnPacketReceived(&packet, packet_time);
5148
5149 // The stream should now be created with the appropriate sync label.
5150 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5151 EXPECT_EQ(kSyncLabel,
5152 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5153
5154 // Removing the unsignaled stream should clear the cache. This time when
5155 // a default video receive stream is created it won't have a sync_group.
5156 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5157 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5158 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5159
5160 channel_->OnPacketReceived(&packet, packet_time);
5161 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5162 EXPECT_TRUE(
5163 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5164}
5165
eladalonf1841382017-06-12 01:16:46 -07005166void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005167 uint8_t payload_type,
5168 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005169 // kRedRtxPayloadType must currently be unused.
5170 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5171
noahricd10a68e2015-07-10 11:27:55 -07005172 // Add a RED RTX codec.
5173 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005174 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005175 recv_parameters_.codecs.push_back(red_rtx_codec);
5176 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005177
5178 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5179 const size_t kDataLength = 12;
5180 uint8_t data[kDataLength];
5181 memset(data, 0, sizeof(data));
5182
5183 rtc::Set8(data, 1, payload_type);
5184 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005185 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005186 rtc::PacketTime packet_time;
5187 channel_->OnPacketReceived(&packet, packet_time);
5188
5189 if (expect_created_receive_stream) {
5190 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5191 << "Should have created a receive stream for payload type: "
5192 << payload_type;
5193 } else {
5194 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5195 << "Shouldn't have created a receive stream for payload type: "
5196 << payload_type;
5197 }
5198}
5199
Åsa Persson2c7149b2018-10-15 09:36:10 +02005200class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5201 public:
5202 WebRtcVideoChannelDiscardUnknownSsrcTest()
5203 : WebRtcVideoChannelTest(
5204 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5205};
5206
5207TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5208 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5209 false /* expect_created_receive_stream */);
5210}
5211
eladalonf1841382017-06-12 01:16:46 -07005212TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005213 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5214 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005215}
5216
eladalonf1841382017-06-12 01:16:46 -07005217TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005218 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5219 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005220}
5221
eladalonf1841382017-06-12 01:16:46 -07005222TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005223 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005224 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5225 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5226 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5227 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005228}
5229
eladalonf1841382017-06-12 01:16:46 -07005230TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005231 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5232 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005233}
5234
eladalonf1841382017-06-12 01:16:46 -07005235TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005236 FlexfecPacketDoesntCreateUnsignalledStream) {
5237 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5238 false /* expect_created_receive_stream */);
5239}
5240
eladalonf1841382017-06-12 01:16:46 -07005241TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005242 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5243 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005244}
5245
mzanaty8a855d62017-02-17 15:46:43 -08005246// Test that receiving any unsignalled SSRC works even if it changes.
5247// The first unsignalled SSRC received will create a default receive stream.
5248// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005249TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005250 // Allow receiving VP8, VP9, H264 (if enabled).
5251 cricket::VideoRecvParameters parameters;
5252 parameters.codecs.push_back(GetEngineCodec("VP8"));
5253 parameters.codecs.push_back(GetEngineCodec("VP9"));
5254
5255#if defined(WEBRTC_USE_H264)
5256 cricket::VideoCodec H264codec(126, "H264");
5257 parameters.codecs.push_back(H264codec);
5258#endif
5259
5260 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5261 // No receive streams yet.
5262 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5263 cricket::FakeVideoRenderer renderer;
5264 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5265
5266 // Receive VP8 packet on first SSRC.
5267 uint8_t data[kMinRtpPacketLen];
5268 cricket::RtpHeader rtpHeader;
5269 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5270 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005271 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005272 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5273 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5274 rtc::PacketTime packet_time;
5275 channel_->OnPacketReceived(&packet, packet_time);
5276 // VP8 packet should create default receive stream.
5277 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005278 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005279 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5280 // Verify that the receive stream sinks to a renderer.
5281 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5282 webrtc::kVideoRotation_0);
5283 recv_stream->InjectFrame(video_frame);
5284 EXPECT_EQ(1, renderer.num_rendered_frames());
5285
5286 // Receive VP9 packet on second SSRC.
5287 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005288 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005289 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5290 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5291 channel_->OnPacketReceived(&packet2, packet_time);
5292 // VP9 packet should replace the default receive SSRC.
5293 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5294 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5295 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5296 // Verify that the receive stream sinks to a renderer.
5297 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005298 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005299 recv_stream->InjectFrame(video_frame2);
5300 EXPECT_EQ(2, renderer.num_rendered_frames());
5301
5302#if defined(WEBRTC_USE_H264)
5303 // Receive H264 packet on third SSRC.
5304 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005305 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005306 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5307 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5308 channel_->OnPacketReceived(&packet3, packet_time);
5309 // H264 packet should replace the default receive SSRC.
5310 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5311 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5312 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5313 // Verify that the receive stream sinks to a renderer.
5314 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005315 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005316 recv_stream->InjectFrame(video_frame3);
5317 EXPECT_EQ(3, renderer.num_rendered_frames());
5318#endif
5319}
5320
brandtr0dc57ea2017-05-29 23:33:31 -07005321// This test verifies that when a new default stream is created for a new
5322// unsignaled SSRC, the new stream does not overwrite any old stream that had
5323// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005324TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005325 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5326 cricket::VideoRecvParameters parameters;
5327 parameters.codecs.push_back(GetEngineCodec("VP8"));
5328 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5329
5330 // No streams signaled and no packets received, so we should not have any
5331 // stream objects created yet.
5332 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5333
5334 // Receive packet on an unsignaled SSRC.
5335 uint8_t data[kMinRtpPacketLen];
5336 cricket::RtpHeader rtp_header;
5337 rtp_header.payload_type = GetEngineCodec("VP8").id;
5338 rtp_header.seq_num = rtp_header.timestamp = 0;
5339 rtp_header.ssrc = kSsrcs3[0];
5340 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5341 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5342 rtc::PacketTime packet_time;
5343 channel_->OnPacketReceived(&packet, packet_time);
5344 // Default receive stream should be created.
5345 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5346 FakeVideoReceiveStream* recv_stream0 =
5347 fake_call_->GetVideoReceiveStreams()[0];
5348 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5349
5350 // Signal the SSRC.
5351 EXPECT_TRUE(
5352 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5353 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5354 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5355 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5356
5357 // Receive packet on a different unsignaled SSRC.
5358 rtp_header.ssrc = kSsrcs3[1];
5359 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5360 packet.SetData(data, sizeof(data));
5361 channel_->OnPacketReceived(&packet, packet_time);
5362 // New default receive stream should be created, but old stream should remain.
5363 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5364 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5365 FakeVideoReceiveStream* recv_stream1 =
5366 fake_call_->GetVideoReceiveStreams()[1];
5367 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5368}
5369
Seth Hampson7c682e02018-05-04 16:28:15 -07005370TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005371 AddSendStream();
5372
Tommi85959932018-02-07 19:26:06 +01005373 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005374 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005375 cricket::VideoFormat capture_format_hd =
5376 capturer.GetSupportedFormats()->front();
5377 EXPECT_EQ(1280, capture_format_hd.width);
5378 EXPECT_EQ(720, capture_format_hd.height);
5379 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5380 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005381 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005382
perkjfa10b552016-10-02 23:45:26 -07005383 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005384 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005385
5386 // TODO(skvlad): Resolve the inconsistency between the interpretation
5387 // of the global bitrate limit for audio and video:
5388 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5389 // max_bandwidth_bps = -1 - remove the bandwidth limit
5390 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005391 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005392
perkjfa10b552016-10-02 23:45:26 -07005393 SetAndExpectMaxBitrate(1000, 0, 1000);
5394 SetAndExpectMaxBitrate(1000, 800, 800);
5395 SetAndExpectMaxBitrate(600, 800, 600);
5396 SetAndExpectMaxBitrate(0, 800, 800);
5397 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005398
Niels Möllerff40b142018-04-09 08:49:14 +02005399 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005400}
5401
eladalonf1841382017-06-12 01:16:46 -07005402TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005403 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005404 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005405 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005406
5407 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005408 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005409 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005410}
5411
eladalonf1841382017-06-12 01:16:46 -07005412TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005413 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005414 FakeVideoSendStream* stream = AddSendStream();
5415
Seth Hampson7c682e02018-05-04 16:28:15 -07005416 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5417 EXPECT_EQ(1UL, parameters.encodings.size());
5418 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5419 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5420
5421 // Note that this is testing the behavior of the FakeVideoSendStream, which
5422 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5423 // we are just testing the behavior of
5424 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005425 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5426 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005427
5428 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5429 // by this amount.
5430 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5431 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5432 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5433 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5434
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005435 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5436 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5437 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5438}
5439
5440TEST_F(WebRtcVideoChannelTest,
5441 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5442 FakeVideoSendStream* stream = AddSendStream();
5443
5444 // Note that this is testing the behavior of the FakeVideoSendStream, which
5445 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5446 // we are just testing the behavior of
5447 // EncoderStreamFactory::CreateEncoderStreams.
5448 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5449 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5450
5451 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5452 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5453 EXPECT_EQ(1UL, parameters.encodings.size());
5454 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5455 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5456
5457 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5458 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5459 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5460}
5461
5462TEST_F(WebRtcVideoChannelTest,
5463 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5464 send_parameters_.max_bandwidth_bps = 99999;
5465 FakeVideoSendStream* stream = AddSendStream();
5466 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5467 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5468 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5469 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5470 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5471 stream->GetVideoStreams()[0].max_bitrate_bps);
5472
5473 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5474 // adjusted down.
5475 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5476 EXPECT_EQ(1UL, parameters.encodings.size());
5477 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5478 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5479 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5480 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5481 stream->GetVideoStreams()[0].min_bitrate_bps);
5482 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5483 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005484}
5485
Åsa Persson8c1bf952018-09-13 10:42:19 +02005486TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5487 FakeVideoSendStream* stream = AddSendStream();
5488
5489 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5490 EXPECT_EQ(1UL, parameters.encodings.size());
5491 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5492 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5493
5494 // Note that this is testing the behavior of the FakeVideoSendStream, which
5495 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5496 // we are just testing the behavior of
5497 // EncoderStreamFactory::CreateEncoderStreams.
5498 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5499 EXPECT_EQ(kDefaultVideoMaxFramerate,
5500 stream->GetVideoStreams()[0].max_framerate);
5501
5502 // Set max framerate and check that VideoStream.max_framerate is set.
5503 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5504 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5505 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5506 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5507
5508 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5509 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5510}
5511
Åsa Persson23eba222018-10-02 14:47:06 +02005512TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5513 FakeVideoSendStream* stream = AddSendStream();
5514
5515 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5516 EXPECT_EQ(1UL, parameters.encodings.size());
5517 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5518 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5519
5520 // Note that this is testing the behavior of the FakeVideoSendStream, which
5521 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5522 // we are just testing the behavior of
5523 // EncoderStreamFactory::CreateEncoderStreams.
5524 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5525 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5526
5527 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5528 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5529 parameters.encodings[0].num_temporal_layers = 2;
5530 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5531
5532 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5533 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5534}
5535
Seth Hampson7c682e02018-05-04 16:28:15 -07005536TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005537 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005538 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005539 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005540 // Two or more encodings should result in failure.
5541 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005542 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005543 // Zero encodings should also fail.
5544 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005545 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005546}
5547
Zach Stein3ca452b2018-01-18 10:01:24 -08005548TEST_F(WebRtcVideoChannelTest,
5549 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5550 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5551 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5552 AddSendStream(sp);
5553
5554 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5555
5556 // Additional encodings should result in failure.
5557 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005558 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005559 // Zero encodings should also fail.
5560 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005561 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005562}
5563
deadbeeffb2aced2017-01-06 23:05:37 -08005564// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005565TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005566 AddSendStream();
5567 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005568 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005569 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005570}
5571
Seth Hampson24722b32017-12-22 09:36:42 -08005572// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5573// a value <= 0, setting the parameters returns false.
5574TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5575 AddSendStream();
5576 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5577 EXPECT_EQ(1UL, parameters.encodings.size());
5578 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5579 parameters.encodings[0].bitrate_priority);
5580
5581 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005582 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005583 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005584 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005585}
5586
5587// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5588// properly on the VideoChannel and propogates down to the video encoder.
5589TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5590 AddSendStream();
5591 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5592 EXPECT_EQ(1UL, parameters.encodings.size());
5593 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5594 parameters.encodings[0].bitrate_priority);
5595
5596 // Change the value and set it on the VideoChannel.
5597 double new_bitrate_priority = 2.0;
5598 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005599 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005600
5601 // Verify that the encoding parameters bitrate_priority is set for the
5602 // VideoChannel.
5603 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5604 EXPECT_EQ(1UL, parameters.encodings.size());
5605 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5606
5607 // Verify that the new value propagated down to the encoder.
5608 std::vector<FakeVideoSendStream*> video_send_streams =
5609 fake_call_->GetVideoSendStreams();
5610 EXPECT_EQ(1UL, video_send_streams.size());
5611 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5612 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5613 // appropriately.
5614 EXPECT_EQ(new_bitrate_priority,
5615 video_send_stream->GetEncoderConfig().bitrate_priority);
5616 // Check that the vector of VideoStreams also was propagated correctly. Note
5617 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5618 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005619 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005620 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5621}
5622
5623// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5624// VideoChannel and the value propogates to the video encoder with all simulcast
5625// streams.
5626TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5627 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005628 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005629 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5630 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5631 AddSendStream(stream_params);
5632 uint32_t primary_ssrc = stream_params.first_ssrc();
5633
Tommi85959932018-02-07 19:26:06 +01005634 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5635 // frame. This creates multiple VideoStreams for all simulcast layers when
5636 // reconfiguring, and allows us to test this behavior.
5637 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005638 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005639 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005640 EXPECT_EQ(cricket::CS_RUNNING,
5641 capturer.Start(cricket::VideoFormat(
5642 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5643 cricket::FOURCC_I420)));
5644 channel_->SetSend(true);
5645 EXPECT_TRUE(capturer.CaptureFrame());
5646 // Get and set the rtp encoding parameters.
5647 webrtc::RtpParameters parameters =
5648 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005649 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005650 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5651 parameters.encodings[0].bitrate_priority);
5652 // Change the value and set it on the VideoChannel.
5653 double new_bitrate_priority = 2.0;
5654 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005655 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005656
5657 // Verify that the encoding parameters priority is set on the VideoChannel.
5658 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005659 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005660 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5661
5662 // Verify that the new value propagated down to the encoder.
5663 std::vector<FakeVideoSendStream*> video_send_streams =
5664 fake_call_->GetVideoSendStreams();
5665 EXPECT_EQ(1UL, video_send_streams.size());
5666 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5667 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5668 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005669 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005670 video_send_stream->GetEncoderConfig().number_of_streams);
5671 EXPECT_EQ(new_bitrate_priority,
5672 video_send_stream->GetEncoderConfig().bitrate_priority);
5673 // Check that the vector of VideoStreams also propagated correctly. The
5674 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5675 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005676 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005677 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005678 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5679 // Since we are only setting bitrate priority per-sender, the other
5680 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005681 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005682 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005683 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005684 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005685 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005686}
5687
Tim Haloun648d28a2018-10-18 16:52:22 -07005688// RTCRtpEncodingParameters.network_priority must be one of a few values
5689// derived from the default priority, corresponding to very-low, low, medium,
5690// or high.
5691TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5692 AddSendStream();
5693 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5694 EXPECT_EQ(1UL, parameters.encodings.size());
5695 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5696 parameters.encodings[0].network_priority);
5697
5698 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5699 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5700 for (auto it : good_values) {
5701 parameters.encodings[0].network_priority = it;
5702 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5703 }
5704 for (auto it : bad_values) {
5705 parameters.encodings[0].network_priority = it;
5706 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5707 }
5708}
5709
Åsa Persson8c1bf952018-09-13 10:42:19 +02005710TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5711 const size_t kNumSimulcastStreams = 3;
5712 SetUpSimulcast(true, false);
5713
5714 // Get and set the rtp encoding parameters.
5715 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5716 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5717 for (const auto& encoding : parameters.encodings) {
5718 EXPECT_FALSE(encoding.max_framerate);
5719 }
5720
5721 // Change the value and set it on the VideoChannel.
5722 parameters.encodings[0].max_framerate = 10;
5723 parameters.encodings[1].max_framerate = 20;
5724 parameters.encodings[2].max_framerate = 25;
5725 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5726
5727 // Verify that the bitrates are set on the VideoChannel.
5728 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5729 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5730 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5731 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5732 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5733}
5734
Åsa Persson23eba222018-10-02 14:47:06 +02005735TEST_F(WebRtcVideoChannelTest,
5736 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5737 const size_t kNumSimulcastStreams = 3;
5738 SetUpSimulcast(true, false);
5739
5740 // Get and set the rtp encoding parameters.
5741 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5742 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5743
5744 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5745 parameters.encodings[0].num_temporal_layers = 0;
5746 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5747 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5748 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5749 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5750 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5751}
5752
5753TEST_F(WebRtcVideoChannelTest,
5754 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5755 const size_t kNumSimulcastStreams = 3;
5756 SetUpSimulcast(true, false);
5757
5758 // Get and set the rtp encoding parameters.
5759 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5760 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5761
5762 // No/all layers should be set.
5763 parameters.encodings[0].num_temporal_layers = 1;
5764 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5765 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5766
5767 // Different values not supported.
5768 parameters.encodings[0].num_temporal_layers = 1;
5769 parameters.encodings[1].num_temporal_layers = 2;
5770 parameters.encodings[2].num_temporal_layers = 2;
5771 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5772 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5773}
5774
5775TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5776 const size_t kNumSimulcastStreams = 3;
5777 SetUpSimulcast(true, false);
5778
5779 // Get and set the rtp encoding parameters.
5780 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5781 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5782 for (const auto& encoding : parameters.encodings)
5783 EXPECT_FALSE(encoding.num_temporal_layers);
5784
5785 // Change the value and set it on the VideoChannel.
5786 parameters.encodings[0].num_temporal_layers = 3;
5787 parameters.encodings[1].num_temporal_layers = 3;
5788 parameters.encodings[2].num_temporal_layers = 3;
5789 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5790
5791 // Verify that the number of temporal layers are set on the VideoChannel.
5792 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5793 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5794 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5795 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5796 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5797}
5798
5799TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5800 const size_t kNumSimulcastStreams = 3;
5801 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5802
5803 // Send a full size frame so all simulcast layers are used when reconfiguring.
5804 FakeVideoCapturerWithTaskQueue capturer;
5805 VideoOptions options;
5806 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5807 EXPECT_EQ(cricket::CS_RUNNING,
5808 capturer.Start(capturer.GetSupportedFormats()->front()));
5809 channel_->SetSend(true);
5810 EXPECT_TRUE(capturer.CaptureFrame());
5811
5812 // Get and set the rtp encoding parameters.
5813 // Change the value and set it on the VideoChannel.
5814 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5815 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5816 parameters.encodings[0].num_temporal_layers = 2;
5817 parameters.encodings[1].num_temporal_layers = 2;
5818 parameters.encodings[2].num_temporal_layers = 2;
5819 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5820
5821 // Verify that the new value is propagated down to the encoder.
5822 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5823 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5824 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5825 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5826 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5827 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5828 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5829 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5830
5831 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5832 // VideoStreams are created appropriately for the simulcast case.
5833 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5834 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5835 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5836 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5837
5838 // No parameter changed, encoder should not be reconfigured.
5839 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5840 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5841
5842 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5843}
5844
5845TEST_F(WebRtcVideoChannelTest,
5846 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5847 const size_t kDefaultNumTemporalLayers = 3;
5848 const size_t kNumSimulcastStreams = 3;
5849 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5850
5851 // Send a full size frame so all simulcast layers are used when reconfiguring.
5852 FakeVideoCapturerWithTaskQueue capturer;
5853 VideoOptions options;
5854 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5855 EXPECT_EQ(cricket::CS_RUNNING,
5856 capturer.Start(capturer.GetSupportedFormats()->front()));
5857 channel_->SetSend(true);
5858 EXPECT_TRUE(capturer.CaptureFrame());
5859
5860 // Change rtp encoding parameters, num_temporal_layers not changed.
5861 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5862 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5863 parameters.encodings[0].min_bitrate_bps = 33000;
5864 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5865
5866 // Verify that no value is propagated down to the encoder.
5867 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5868 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5869 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5870 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5871 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5872 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5873
5874 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5875 // VideoStreams are created appropriately for the simulcast case.
5876 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5877 EXPECT_EQ(kDefaultNumTemporalLayers,
5878 stream->GetVideoStreams()[0].num_temporal_layers);
5879 EXPECT_EQ(kDefaultNumTemporalLayers,
5880 stream->GetVideoStreams()[1].num_temporal_layers);
5881 EXPECT_EQ(kDefaultNumTemporalLayers,
5882 stream->GetVideoStreams()[2].num_temporal_layers);
5883
5884 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5885}
5886
Åsa Persson8c1bf952018-09-13 10:42:19 +02005887TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5888 const size_t kNumSimulcastStreams = 3;
5889 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5890
5891 // Send a full size frame so all simulcast layers are used when reconfiguring.
5892 FakeVideoCapturerWithTaskQueue capturer;
5893 VideoOptions options;
5894 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5895 EXPECT_EQ(cricket::CS_RUNNING,
5896 capturer.Start(capturer.GetSupportedFormats()->front()));
5897 channel_->SetSend(true);
5898 EXPECT_TRUE(capturer.CaptureFrame());
5899
5900 // Get and set the rtp encoding parameters.
5901 // Change the value and set it on the VideoChannel.
5902 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5903 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5904 parameters.encodings[0].max_framerate = 15;
5905 parameters.encodings[1].max_framerate = 25;
5906 parameters.encodings[2].max_framerate = 20;
5907 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5908
5909 // Verify that the new value propagated down to the encoder.
5910 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5911 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5912 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5913 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5914 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5915 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5916 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5917 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5918
5919 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5920 // VideoStreams are created appropriately for the simulcast case.
5921 // Currently the maximum |max_framerate| is used.
5922 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5923 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5924 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5925 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5926
5927 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5928}
5929
5930TEST_F(WebRtcVideoChannelTest,
5931 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5932 const size_t kNumSimulcastStreams = 3;
5933 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5934 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5935
5936 // Send a full size frame so all simulcast layers are used when reconfiguring.
5937 FakeVideoCapturerWithTaskQueue capturer;
5938 VideoOptions options;
5939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5940 EXPECT_EQ(cricket::CS_RUNNING,
5941 capturer.Start(capturer.GetSupportedFormats()->front()));
5942 channel_->SetSend(true);
5943 EXPECT_TRUE(capturer.CaptureFrame());
5944
5945 // Get and set the rtp encoding parameters.
5946 // Change the value and set it on the VideoChannel.
5947 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5948 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5949 parameters.encodings[0].max_framerate = 15;
5950 parameters.encodings[2].max_framerate = 20;
5951 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5952
5953 // Verify that the new value propagated down to the encoder.
5954 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5955 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5956 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5957 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5958 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5959 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5960 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5961
5962 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5963 // VideoStreams are created appropriately for the simulcast case.
5964 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5965 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5966 EXPECT_EQ(kDefaultVideoMaxFramerate,
5967 stream->GetVideoStreams()[0].max_framerate);
5968 EXPECT_EQ(kDefaultVideoMaxFramerate,
5969 stream->GetVideoStreams()[1].max_framerate);
5970 EXPECT_EQ(kDefaultVideoMaxFramerate,
5971 stream->GetVideoStreams()[2].max_framerate);
5972
5973 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5974}
5975
Åsa Persson55659812018-06-18 17:51:32 +02005976TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5977 const size_t kNumSimulcastStreams = 3;
5978 SetUpSimulcast(true, false);
5979
5980 // Get and set the rtp encoding parameters.
5981 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5982 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5983 for (const auto& encoding : parameters.encodings) {
5984 EXPECT_FALSE(encoding.min_bitrate_bps);
5985 EXPECT_FALSE(encoding.max_bitrate_bps);
5986 }
5987
5988 // Change the value and set it on the VideoChannel.
5989 parameters.encodings[0].min_bitrate_bps = 100000;
5990 parameters.encodings[0].max_bitrate_bps = 200000;
5991 parameters.encodings[1].min_bitrate_bps = 300000;
5992 parameters.encodings[1].max_bitrate_bps = 400000;
5993 parameters.encodings[2].min_bitrate_bps = 500000;
5994 parameters.encodings[2].max_bitrate_bps = 600000;
5995 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5996
5997 // Verify that the bitrates are set on the VideoChannel.
5998 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5999 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6000 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6001 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6002 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6003 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6004 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6005 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6006}
6007
6008TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6009 const size_t kNumSimulcastStreams = 3;
6010 SetUpSimulcast(true, false);
6011
6012 // Get and set the rtp encoding parameters.
6013 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6014 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6015
6016 // Max bitrate lower than min bitrate should fail.
6017 parameters.encodings[2].min_bitrate_bps = 100000;
6018 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6019 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6020 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6021}
6022
6023// Test that min and max bitrate values set via RtpParameters are correctly
6024// propagated to the underlying encoder, and that the target is set to 3/4 of
6025// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6026// that are used if no min/max are specified).
6027TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6028 const size_t kNumSimulcastStreams = 3;
6029 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6030
6031 // Send a full size frame so all simulcast layers are used when reconfiguring.
6032 FakeVideoCapturerWithTaskQueue capturer;
6033 VideoOptions options;
6034 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6035 EXPECT_EQ(cricket::CS_RUNNING,
6036 capturer.Start(capturer.GetSupportedFormats()->front()));
6037 channel_->SetSend(true);
6038 EXPECT_TRUE(capturer.CaptureFrame());
6039
6040 // Get and set the rtp encoding parameters.
6041 // Change the value and set it on the VideoChannel.
6042 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6043 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6044 parameters.encodings[0].min_bitrate_bps = 100000;
6045 parameters.encodings[0].max_bitrate_bps = 200000;
6046 parameters.encodings[1].min_bitrate_bps = 300000;
6047 parameters.encodings[1].max_bitrate_bps = 400000;
6048 parameters.encodings[2].min_bitrate_bps = 500000;
6049 parameters.encodings[2].max_bitrate_bps = 600000;
6050 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6051
6052 // Verify that the new value propagated down to the encoder.
6053 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6054 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6055 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6056 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6057 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6058 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6059 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6060 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6061 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6062 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6063 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6064
6065 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6066 // VideoStreams are created appropriately for the simulcast case.
6067 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6068 // Target bitrate: 200000 * 3 / 4 = 150000.
6069 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6070 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6071 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6072 // Target bitrate: 400000 * 3 / 4 = 300000.
6073 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6074 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6075 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6076 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6077 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6078 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6079 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6080
6081 // No parameter changed, encoder should not be reconfigured.
6082 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6083 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6084
6085 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6086}
6087
6088// Test to only specify the min or max bitrate value for a layer via
6089// RtpParameters. The unspecified min/max and target value should be set to the
6090// simulcast default that is used if no min/max are specified.
6091TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6092 const size_t kNumSimulcastStreams = 3;
6093 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6094 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6095
6096 // Send a full size frame so all simulcast layers are used when reconfiguring.
6097 FakeVideoCapturerWithTaskQueue capturer;
6098 VideoOptions options;
6099 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6100 EXPECT_EQ(cricket::CS_RUNNING,
6101 capturer.Start(capturer.GetSupportedFormats()->front()));
6102 channel_->SetSend(true);
6103 EXPECT_TRUE(capturer.CaptureFrame());
6104
6105 // Get and set the rtp encoding parameters.
6106 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6107 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6108
6109 // Change the value and set it on the VideoChannel.
6110 // Layer 0: only configure min bitrate.
6111 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6112 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6113 // Layer 1: only configure max bitrate.
6114 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6115 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6116 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6117
6118 // Verify that the new value propagated down to the encoder.
6119 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6120 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6121 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6122 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6123 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6124 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6125 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6126 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6127 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6128 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6129
6130 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6131 // VideoStreams are created appropriately for the simulcast case.
6132 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6133 // Layer 0: min configured bitrate should overwrite min default.
6134 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6135 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6136 stream->GetVideoStreams()[0].target_bitrate_bps);
6137 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6138 stream->GetVideoStreams()[0].max_bitrate_bps);
6139 // Layer 1: max configured bitrate should overwrite max default.
6140 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6141 stream->GetVideoStreams()[1].min_bitrate_bps);
6142 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6143 stream->GetVideoStreams()[1].target_bitrate_bps);
6144 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6145 // Layer 2: min and max bitrate not configured, default expected.
6146 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6147 stream->GetVideoStreams()[2].min_bitrate_bps);
6148 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6149 stream->GetVideoStreams()[2].target_bitrate_bps);
6150 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6151 stream->GetVideoStreams()[2].max_bitrate_bps);
6152
6153 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6154}
6155
6156// Test that specifying the min (or max) bitrate value for a layer via
6157// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6158// unspecified values accordingly.
6159TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6160 const size_t kNumSimulcastStreams = 3;
6161 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6162 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6163
6164 // Send a full size frame so all simulcast layers are used when reconfiguring.
6165 FakeVideoCapturerWithTaskQueue capturer;
6166 VideoOptions options;
6167 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6168 EXPECT_EQ(cricket::CS_RUNNING,
6169 capturer.Start(capturer.GetSupportedFormats()->front()));
6170 channel_->SetSend(true);
6171 EXPECT_TRUE(capturer.CaptureFrame());
6172
6173 // Get and set the rtp encoding parameters.
6174 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6175 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6176
6177 // Change the value and set it on the VideoChannel.
6178 // For layer 0, set the min bitrate above the default max.
6179 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6180 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6181 // For layer 1, set the max bitrate below the default min.
6182 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6183 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6184 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6185
6186 // Verify that the new value propagated down to the encoder.
6187 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6188 // VideoStreams are created appropriately for the simulcast case.
6189 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6190 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6191 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6192 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6193 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6194 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6195 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6196 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6197 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6198 // Layer 2: min and max bitrate not configured, default expected.
6199 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6200 stream->GetVideoStreams()[2].min_bitrate_bps);
6201 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6202 stream->GetVideoStreams()[2].target_bitrate_bps);
6203 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6204 stream->GetVideoStreams()[2].max_bitrate_bps);
6205
6206 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6207}
6208
6209TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6210 const size_t kNumSimulcastStreams = 3;
6211 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6212 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6213
6214 // Send a full size frame so all simulcast layers are used when reconfiguring.
6215 FakeVideoCapturerWithTaskQueue capturer;
6216 VideoOptions options;
6217 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6218 EXPECT_EQ(cricket::CS_RUNNING,
6219 capturer.Start(capturer.GetSupportedFormats()->front()));
6220 channel_->SetSend(true);
6221 EXPECT_TRUE(capturer.CaptureFrame());
6222
6223 // Set max bitrate for all but the highest layer.
6224 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6225 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6226 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6227 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6228 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6229
6230 // Set max bandwidth equal to total max bitrate.
6231 send_parameters_.max_bandwidth_bps =
6232 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6233 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6234 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6235
6236 // No bitrate above the total max to give to the highest layer.
6237 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6238 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6239 stream->GetVideoStreams()[2].max_bitrate_bps);
6240
6241 // Set max bandwidth above the total max bitrate.
6242 send_parameters_.max_bandwidth_bps =
6243 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6244 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6245 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6246
6247 // The highest layer has no max bitrate set -> the bitrate above the total
6248 // max should be given to the highest layer.
6249 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6250 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6251 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6252 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6253 stream->GetVideoStreams()[2].max_bitrate_bps);
6254
6255 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6256}
6257
6258TEST_F(WebRtcVideoChannelTest,
6259 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6260 const size_t kNumSimulcastStreams = 3;
6261 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6262 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6263 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6264
6265 // Send a full size frame so all simulcast layers are used when reconfiguring.
6266 FakeVideoCapturerWithTaskQueue capturer;
6267 VideoOptions options;
6268 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6269 EXPECT_EQ(cricket::CS_RUNNING,
6270 capturer.Start(capturer.GetSupportedFormats()->front()));
6271 channel_->SetSend(true);
6272 EXPECT_TRUE(capturer.CaptureFrame());
6273
6274 // Set max bitrate for the highest layer.
6275 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6276 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6277 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6278 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6279
6280 // Set max bandwidth above the total max bitrate.
6281 send_parameters_.max_bandwidth_bps =
6282 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6283 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6284 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6285
6286 // The highest layer has the max bitrate set -> the bitrate above the total
6287 // max should not be given to the highest layer.
6288 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6289 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6290 stream->GetVideoStreams()[2].max_bitrate_bps);
6291
6292 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6293}
6294
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006295// Test that min and max bitrate values set via RtpParameters are correctly
6296// propagated to the underlying encoder for a single stream.
6297TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6298 FakeVideoSendStream* stream = AddSendStream();
6299 EXPECT_TRUE(channel_->SetSend(true));
6300 EXPECT_TRUE(stream->IsSending());
6301
6302 // Set min and max bitrate.
6303 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6304 EXPECT_EQ(1u, parameters.encodings.size());
6305 parameters.encodings[0].min_bitrate_bps = 80000;
6306 parameters.encodings[0].max_bitrate_bps = 150000;
6307 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6308
6309 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6310 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6311 EXPECT_EQ(1u, encoder_config.number_of_streams);
6312 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6313 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6314 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6315
6316 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6317 // VideoStreams are created appropriately.
6318 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6319 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6320 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6321 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6322}
6323
6324// Test the default min and max bitrate value are correctly propagated to the
6325// underlying encoder for a single stream (when the values are not set via
6326// RtpParameters).
6327TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6328 FakeVideoSendStream* stream = AddSendStream();
6329 EXPECT_TRUE(channel_->SetSend(true));
6330 EXPECT_TRUE(stream->IsSending());
6331
6332 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6333 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6334 EXPECT_EQ(1u, encoder_config.number_of_streams);
6335 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6336 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6337 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6338
6339 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6340 // VideoStreams are created appropriately.
6341 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6342 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6343 stream->GetVideoStreams()[0].min_bitrate_bps);
6344 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6345 stream->GetVideoStreams()[0].min_bitrate_bps);
6346 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6347 stream->GetVideoStreams()[0].target_bitrate_bps);
6348}
6349
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006350// Test that a stream will not be sending if its encoding is made inactive
6351// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006352TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006353 FakeVideoSendStream* stream = AddSendStream();
6354 EXPECT_TRUE(channel_->SetSend(true));
6355 EXPECT_TRUE(stream->IsSending());
6356
6357 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006358 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006359 ASSERT_EQ(1u, parameters.encodings.size());
6360 ASSERT_TRUE(parameters.encodings[0].active);
6361 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006362 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006363 EXPECT_FALSE(stream->IsSending());
6364
6365 // Now change it back to active and verify we resume sending.
6366 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006367 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006368 EXPECT_TRUE(stream->IsSending());
6369}
6370
Seth Hampson8234ead2018-02-02 15:16:24 -08006371// Tests that when active is updated for any simulcast layer then the send
6372// stream's sending state will be updated and it will be reconfigured with the
6373// new appropriate active simulcast streams.
6374TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6375 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006376 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006377 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6378 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6379 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6380 uint32_t primary_ssrc = stream_params.first_ssrc();
6381
Tommi85959932018-02-07 19:26:06 +01006382 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6383 // frame. This allows us to test that ReconfigureEncoder is called
6384 // appropriately.
6385 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006386 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006387 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006388 EXPECT_EQ(cricket::CS_RUNNING,
6389 capturer.Start(cricket::VideoFormat(
6390 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6391 cricket::FOURCC_I420)));
6392 channel_->SetSend(true);
6393 EXPECT_TRUE(capturer.CaptureFrame());
6394
6395 // Check that all encodings are initially active.
6396 webrtc::RtpParameters parameters =
6397 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006398 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006399 EXPECT_TRUE(parameters.encodings[0].active);
6400 EXPECT_TRUE(parameters.encodings[1].active);
6401 EXPECT_TRUE(parameters.encodings[2].active);
6402 EXPECT_TRUE(fake_video_send_stream->IsSending());
6403
6404 // Only turn on only the middle stream.
6405 parameters.encodings[0].active = false;
6406 parameters.encodings[1].active = true;
6407 parameters.encodings[2].active = false;
6408 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6409 // Verify that the active fields are set on the VideoChannel.
6410 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006411 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006412 EXPECT_FALSE(parameters.encodings[0].active);
6413 EXPECT_TRUE(parameters.encodings[1].active);
6414 EXPECT_FALSE(parameters.encodings[2].active);
6415 // Check that the VideoSendStream is updated appropriately. This means its
6416 // send state was updated and it was reconfigured.
6417 EXPECT_TRUE(fake_video_send_stream->IsSending());
6418 std::vector<webrtc::VideoStream> simulcast_streams =
6419 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006420 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006421 EXPECT_FALSE(simulcast_streams[0].active);
6422 EXPECT_TRUE(simulcast_streams[1].active);
6423 EXPECT_FALSE(simulcast_streams[2].active);
6424
6425 // Turn off all streams.
6426 parameters.encodings[0].active = false;
6427 parameters.encodings[1].active = false;
6428 parameters.encodings[2].active = false;
6429 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6430 // Verify that the active fields are set on the VideoChannel.
6431 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006432 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006433 EXPECT_FALSE(parameters.encodings[0].active);
6434 EXPECT_FALSE(parameters.encodings[1].active);
6435 EXPECT_FALSE(parameters.encodings[2].active);
6436 // Check that the VideoSendStream is off.
6437 EXPECT_FALSE(fake_video_send_stream->IsSending());
6438 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006439 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006440 EXPECT_FALSE(simulcast_streams[0].active);
6441 EXPECT_FALSE(simulcast_streams[1].active);
6442 EXPECT_FALSE(simulcast_streams[2].active);
6443
Niels Möllerff40b142018-04-09 08:49:14 +02006444 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006445}
6446
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006447// Test that if a stream is reconfigured (due to a codec change or other
6448// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006449TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006450 InactiveStreamDoesntStartSendingWhenReconfigured) {
6451 // Set an initial codec list, which will be modified later.
6452 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006453 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6454 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006455 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6456
6457 FakeVideoSendStream* stream = AddSendStream();
6458 EXPECT_TRUE(channel_->SetSend(true));
6459 EXPECT_TRUE(stream->IsSending());
6460
6461 // Get current parameters and change "active" to false.
6462 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6463 ASSERT_EQ(1u, parameters.encodings.size());
6464 ASSERT_TRUE(parameters.encodings[0].active);
6465 parameters.encodings[0].active = false;
6466 EXPECT_EQ(1u, GetFakeSendStreams().size());
6467 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006468 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006469 EXPECT_FALSE(stream->IsSending());
6470
6471 // Reorder the codec list, causing the stream to be reconfigured.
6472 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006473 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6474 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006475 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6476 auto new_streams = GetFakeSendStreams();
6477 // Assert that a new underlying stream was created due to the codec change.
6478 // Otherwise, this test isn't testing what it set out to test.
6479 EXPECT_EQ(1u, GetFakeSendStreams().size());
6480 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6481
6482 // Verify that we still are not sending anything, due to the inactive
6483 // encoding.
6484 EXPECT_FALSE(new_streams[0]->IsSending());
6485}
6486
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006487// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006488TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006489 AddSendStream();
6490 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006491 parameters.codecs.push_back(GetEngineCodec("VP8"));
6492 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006493 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6494
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006495 webrtc::RtpParameters rtp_parameters =
6496 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006497 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006498 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6499 rtp_parameters.codecs[0]);
6500 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6501 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006502}
6503
Florent Castellidacec712018-05-24 16:24:21 +02006504// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6505TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6506 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6507 params.cname = "rtcpcname";
6508 AddSendStream(params);
6509
6510 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6511 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6512}
6513
deadbeeffb2aced2017-01-06 23:05:37 -08006514// Test that RtpParameters for send stream has one encoding and it has
6515// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006516TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006517 AddSendStream();
6518
6519 webrtc::RtpParameters rtp_parameters =
6520 channel_->GetRtpSendParameters(last_ssrc_);
6521 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006522 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006523}
6524
Florent Castelliabe301f2018-06-12 18:33:49 +02006525TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6526 AddSendStream();
6527
6528 webrtc::RtpParameters rtp_parameters =
6529 channel_->GetRtpSendParameters(last_ssrc_);
6530 rtp_parameters.header_extensions.emplace_back();
6531
6532 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6533
6534 webrtc::RTCError result =
6535 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6536 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6537}
6538
Florent Castelli87b3c512018-07-18 16:00:28 +02006539TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6540 AddSendStream();
6541
6542 FakeVideoCapturerWithTaskQueue capturer;
6543 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6544
6545 webrtc::RtpParameters rtp_parameters =
6546 channel_->GetRtpSendParameters(last_ssrc_);
6547 EXPECT_EQ(rtp_parameters.degradation_preference,
6548 webrtc::DegradationPreference::BALANCED);
6549 rtp_parameters.degradation_preference =
6550 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6551
6552 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6553
6554 webrtc::RtpParameters updated_rtp_parameters =
6555 channel_->GetRtpSendParameters(last_ssrc_);
6556 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6557 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6558
6559 // Remove the source since it will be destroyed before the channel
6560 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6561}
6562
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006563// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006564TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006565 AddSendStream();
6566 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006567 parameters.codecs.push_back(GetEngineCodec("VP8"));
6568 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006569 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6570
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006571 webrtc::RtpParameters initial_params =
6572 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006573
6574 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006575 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006576
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006577 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6578 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6579}
6580
6581// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006582TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006583 AddRecvStream();
6584 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006585 parameters.codecs.push_back(GetEngineCodec("VP8"));
6586 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006587 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6588
6589 webrtc::RtpParameters rtp_parameters =
6590 channel_->GetRtpReceiveParameters(last_ssrc_);
6591 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006592 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6593 rtp_parameters.codecs[0]);
6594 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6595 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006596}
6597
johan073ece42016-08-26 02:59:47 -07006598#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006599TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006600#else
eladalonf1841382017-06-12 01:16:46 -07006601TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006602#endif
johan3859c892016-08-05 09:19:25 -07006603 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006604 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006605 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006606 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006607 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006608 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006609 parameters.codecs.push_back(kH264sprop2);
6610 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6611
6612 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6613 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6614 webrtc::RtpParameters rtp_parameters =
6615 channel_->GetRtpReceiveParameters(last_ssrc_);
6616 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6617 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6618 ASSERT_EQ(2u, cfg.decoders.size());
6619 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006620 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006621 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006622 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6623 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006624 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006625
6626 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006627 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006628 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006629 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6630 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006631 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006632}
6633
sakal1fd95952016-06-22 00:46:15 -07006634// Test that RtpParameters for receive stream has one encoding and it has
6635// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006636TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006637 AddRecvStream();
6638
6639 webrtc::RtpParameters rtp_parameters =
6640 channel_->GetRtpReceiveParameters(last_ssrc_);
6641 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006642 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006643}
6644
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006645// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006646TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006647 AddRecvStream();
6648 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006649 parameters.codecs.push_back(GetEngineCodec("VP8"));
6650 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006651 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6652
6653 webrtc::RtpParameters initial_params =
6654 channel_->GetRtpReceiveParameters(last_ssrc_);
6655
6656 // We should be able to set the params we just got.
6657 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6658
6659 // ... And this shouldn't change the params returned by
6660 // GetRtpReceiveParameters.
6661 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006662}
6663
deadbeef3bc15102017-04-20 19:25:07 -07006664// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6665// aren't signaled. It should always return an empty "RtpEncodingParameters",
6666// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006667TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006668 // Call necessary methods to configure receiving a default stream as
6669 // soon as it arrives.
6670 cricket::VideoRecvParameters parameters;
6671 parameters.codecs.push_back(GetEngineCodec("VP8"));
6672 parameters.codecs.push_back(GetEngineCodec("VP9"));
6673 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6674
6675 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6676 // stream. Should return nothing.
6677 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6678
6679 // Set a sink for an unsignaled stream.
6680 cricket::FakeVideoRenderer renderer;
6681 // Value of "0" means "unsignaled stream".
6682 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6683
6684 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6685 // in this method means "unsignaled stream".
6686 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6687 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6688 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6689
6690 // Receive VP8 packet.
6691 uint8_t data[kMinRtpPacketLen];
6692 cricket::RtpHeader rtpHeader;
6693 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6694 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6695 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6696 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6697 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6698 rtc::PacketTime packet_time;
6699 channel_->OnPacketReceived(&packet, packet_time);
6700
6701 // The |ssrc| member should still be unset.
6702 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6703 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6704 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6705}
6706
eladalonf1841382017-06-12 01:16:46 -07006707void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006708 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006709 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006710
6711 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006712 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006713 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006714 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006715
6716 if (receiver_first) {
6717 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6718 std::vector<FakeVideoReceiveStream*> receive_streams =
6719 fake_call_->GetVideoReceiveStreams();
6720 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006721 // Default local SSRC when we have no sender.
6722 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6723 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006724 }
6725 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6726 if (!receiver_first)
6727 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6728 std::vector<FakeVideoReceiveStream*> receive_streams =
6729 fake_call_->GetVideoReceiveStreams();
6730 ASSERT_EQ(1u, receive_streams.size());
6731 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006732
6733 // Removing first sender should fall back to another (in this case the second)
6734 // local send stream's SSRC.
6735 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6736 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006737 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006738 ASSERT_EQ(1u, receive_streams.size());
6739 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6740
6741 // Removing the last sender should fall back to default local SSRC.
6742 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006743 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006744 ASSERT_EQ(1u, receive_streams.size());
6745 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6746 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006747}
6748
eladalonf1841382017-06-12 01:16:46 -07006749TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006750 TestReceiverLocalSsrcConfiguration(false);
6751}
6752
eladalonf1841382017-06-12 01:16:46 -07006753TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006754 TestReceiverLocalSsrcConfiguration(true);
6755}
6756
eladalonf1841382017-06-12 01:16:46 -07006757class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006758 public:
eladalonf1841382017-06-12 01:16:46 -07006759 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006760 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006761 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6762 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006763 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006764 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006765 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006766 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006767 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006768
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006769 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006770 encoder_factory_->AddSupportedVideoCodecType("VP8");
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07006771 channel_.reset(engine_.CreateChannel(&fake_call_, GetMediaConfig(),
6772 VideoOptions(),
6773 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006774 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006775 last_ssrc_ = 123;
6776 }
6777
6778 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006779 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006780 int capture_width,
6781 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006782 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006783 size_t expected_num_streams,
6784 bool screenshare,
6785 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006786 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006787 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006788 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006789 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006790
Peter Boström0c4e06b2015-10-07 12:23:21 +02006791 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006792 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006793 ssrcs.resize(num_configured_streams);
6794
sprangf24a0642017-02-28 13:23:26 -08006795 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006796 // Send a full-size frame to trigger a stream reconfiguration to use all
6797 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006798 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006799 VideoOptions options;
6800 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006801 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006802 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006803 // Fetch the latest stream since SetVideoSend() may recreate it if the
6804 // screen content setting is changed.
6805 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006806 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006807 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006808 cricket::VideoFormat::FpsToInterval(30),
6809 cricket::FOURCC_I420)));
6810 channel_->SetSend(true);
6811 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006812
Zach Stein3ca452b2018-01-18 10:01:24 -08006813 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6814 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6815
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006816 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6817 ASSERT_EQ(expected_num_streams, video_streams.size());
6818
sprang429600d2017-01-26 06:12:26 -08006819 std::vector<webrtc::VideoStream> expected_streams;
6820 if (conference_mode) {
6821 expected_streams = GetSimulcastConfig(
6822 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006823 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006824 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006825 if (screenshare) {
6826 for (const webrtc::VideoStream& stream : expected_streams) {
6827 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006828 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6829 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006830 }
6831 }
sprang429600d2017-01-26 06:12:26 -08006832 } else {
6833 webrtc::VideoStream stream;
6834 stream.width = capture_width;
6835 stream.height = capture_height;
6836 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006837 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006838 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006839 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006840 stream.max_qp = kDefaultQpMax;
6841 expected_streams.push_back(stream);
6842 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006843
6844 ASSERT_EQ(expected_streams.size(), video_streams.size());
6845
6846 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006847 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006848 for (size_t i = 0; i < num_streams; ++i) {
6849 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6850 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6851
6852 EXPECT_GT(video_streams[i].max_framerate, 0);
6853 EXPECT_EQ(expected_streams[i].max_framerate,
6854 video_streams[i].max_framerate);
6855
6856 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6857 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6858 video_streams[i].min_bitrate_bps);
6859
6860 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6861 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6862 video_streams[i].target_bitrate_bps);
6863
6864 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6865 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6866 video_streams[i].max_bitrate_bps);
6867
6868 EXPECT_GT(video_streams[i].max_qp, 0);
6869 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6870
Sergey Silkina796a7e2018-03-01 15:11:29 +01006871 EXPECT_EQ(conference_mode,
6872 expected_streams[i].num_temporal_layers.has_value());
6873
6874 if (conference_mode) {
6875 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6876 video_streams[i].num_temporal_layers);
6877 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006878
6879 if (i == num_streams - 1) {
6880 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6881 } else {
6882 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6883 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006884 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006885
Niels Möllerff40b142018-04-09 08:49:14 +02006886 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006887 }
6888
6889 FakeVideoSendStream* AddSendStream() {
6890 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6891 }
6892
6893 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006894 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006895 EXPECT_TRUE(channel_->AddSendStream(sp));
6896 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006897 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006898 EXPECT_EQ(num_streams + 1, streams.size());
6899 return streams[streams.size() - 1];
6900 }
6901
6902 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006903 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006904 }
6905
6906 FakeVideoReceiveStream* AddRecvStream() {
6907 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6908 }
6909
6910 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006911 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006912 EXPECT_TRUE(channel_->AddRecvStream(sp));
6913 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006914 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006915 EXPECT_EQ(num_streams + 1, streams.size());
6916 return streams[streams.size() - 1];
6917 }
6918
skvlad11a9cbf2016-10-07 11:53:05 -07006919 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006920 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006921 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6922 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006923 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006924 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006925 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006926};
6927
eladalonf1841382017-06-12 01:16:46 -07006928TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006929 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6930 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006931}
6932
eladalonf1841382017-06-12 01:16:46 -07006933TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006934 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6935 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006936}
6937
6938// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006939TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006940 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6941 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006942}
sprang429600d2017-01-26 06:12:26 -08006943
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006944TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006945 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6946 false);
6947}
6948
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006949TEST_F(WebRtcVideoChannelSimulcastTest,
6950 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006951 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6952 true);
6953}
6954
eladalonf1841382017-06-12 01:16:46 -07006955TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006956 webrtc::test::ScopedFieldTrials override_field_trials_(
6957 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006958 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6959 true);
6960}
6961
eladalonf1841382017-06-12 01:16:46 -07006962TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006963 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006964 webrtc::test::ScopedFieldTrials override_field_trials_(
6965 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006966 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6967 false);
6968}
6969
Yves Gereyb6a89422018-10-08 10:08:32 +02006970class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006971 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006972 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006973 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6974 }
6975 rtc::ScopedFakeClock fake_clock_;
6976};
6977
Yves Gereyb6a89422018-10-08 10:08:32 +02006978// The fake clock needs to be initialized before the call, and not
6979// destroyed until after all threads spawned by the test have been stopped.
6980// This mixin ensures that.
6981class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
6982 public WebRtcVideoChannelBaseTest {};
6983
Jonas Oreland49ac5952018-09-26 16:04:32 +02006984TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
6985 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
6986 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
6987
6988 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
6989
6990 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
6991 rtc::SetBE32(packet1.data() + 8, kSsrc);
6992 channel_->SetSink(kDefaultReceiveSsrc, NULL);
6993 EXPECT_TRUE(SetDefaultCodec());
6994 EXPECT_TRUE(SetSend(true));
6995 EXPECT_EQ(0, renderer_.num_rendered_frames());
6996 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
6997
6998 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
6999 EXPECT_EQ(1u, sources.size());
7000 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7001 int64_t timestamp1 = sources[0].timestamp_ms();
7002
7003 // a new packet.
7004 int64_t timeDeltaMs = 1;
7005 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7006 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7007 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7008 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7009
7010 // It only keeps 10s of history.
7011 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7012 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7013 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7014}
7015
7016TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7017 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7018 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7019
7020 uint32_t kCsrc = 4321u;
7021 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7022 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7023
7024 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7025 rtc::SetBE32(packet1.data() + 8, kSsrc);
7026 rtc::SetBE32(packet1.data() + 12, kCsrc);
7027 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7028 EXPECT_TRUE(SetDefaultCodec());
7029 EXPECT_TRUE(SetSend(true));
7030 EXPECT_EQ(0, renderer_.num_rendered_frames());
7031 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7032
7033 {
7034 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7035 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7036 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7037 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7038 // 1 SSRC and 1 CSRC.
7039 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7040 [](const webrtc::RtpSource& source) {
7041 return source.source_type() ==
7042 webrtc::RtpSourceType::SSRC;
7043 }));
7044 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7045 [](const webrtc::RtpSource& source) {
7046 return source.source_type() ==
7047 webrtc::RtpSourceType::CSRC;
7048 }));
7049 }
7050 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7051
7052 // a new packet with only ssrc (i.e no csrc).
7053 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7054 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7055 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7056 rtc::SetBE32(packet2.data() + 8, kSsrc);
7057
7058 int64_t timeDeltaMs = 1;
7059 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7060 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7061
7062 {
7063 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7064 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7065 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7066 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7067 // 1 SSRC and 1 CSRC.
7068 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7069 [](const webrtc::RtpSource& source) {
7070 return source.source_type() ==
7071 webrtc::RtpSourceType::SSRC;
7072 }));
7073 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7074 [](const webrtc::RtpSource& source) {
7075 return source.source_type() ==
7076 webrtc::RtpSourceType::CSRC;
7077 }));
7078 auto ssrcSource = std::find_if(
7079 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7080 return source.source_type() == webrtc::RtpSourceType::SSRC;
7081 });
7082 auto csrcSource = std::find_if(
7083 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7084 return source.source_type() == webrtc::RtpSourceType::CSRC;
7085 });
7086
7087 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7088 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7089 }
7090
7091 // It only keeps 10s of history.
7092 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7093
7094 {
7095 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7096 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7097 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7098 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7099 [](const webrtc::RtpSource& source) {
7100 return source.source_type() ==
7101 webrtc::RtpSourceType::SSRC;
7102 }));
7103 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7104 [](const webrtc::RtpSource& source) {
7105 return source.source_type() ==
7106 webrtc::RtpSourceType::CSRC;
7107 }));
7108 }
7109
7110 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7111 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7112 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7113}
7114
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007115} // namespace cricket