blob: 88aec23c88c15bed69952e95216416c9487ad3b7 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020020#include "api/video_codecs/sdp_video_format.h"
21#include "api/video_codecs/video_decoder_factory.h"
22#include "api/video_codecs/video_encoder.h"
23#include "api/video_codecs/video_encoder_factory.h"
24#include "call/flexfec_receive_stream.h"
25#include "common_video/h264/profile_level_id.h"
26#include "logging/rtc_event_log/rtc_event_log.h"
27#include "media/base/mediaconstants.h"
28#include "media/base/rtputils.h"
29#include "media/base/testutils.h"
30#include "media/base/videoengine_unittest.h"
31#include "media/engine/constants.h"
32#include "media/engine/fakewebrtccall.h"
33#include "media/engine/fakewebrtcvideoengine.h"
Magnus Jedvert7501b1c2017-11-09 13:43:42 +010034#include "media/engine/internalencoderfactory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/engine/simulcast.h"
36#include "media/engine/webrtcvideoengine.h"
37#include "media/engine/webrtcvoiceengine.h"
38#include "rtc_base/arraysize.h"
39#include "rtc_base/gunit.h"
40#include "rtc_base/stringutils.h"
41#include "test/field_trial.h"
42#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000043
Tommi85959932018-02-07 19:26:06 +010044using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010045using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070046using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010047using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070048
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000049namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000050static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000051
noahricd10a68e2015-07-10 11:27:55 -070052static const uint8_t kRedRtxPayloadType = 125;
53
Peter Boström0c4e06b2015-10-07 12:23:21 +020054static const uint32_t kSsrcs1[] = {1};
55static const uint32_t kSsrcs3[] = {1, 2, 3};
56static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080057static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020058static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080059static const uint32_t kDefaultRecvSsrc = 0;
60
pbos@webrtc.org3c107582014-07-20 15:27:35 +000061static const char kUnsupportedExtensionName[] =
62 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000063
magjed509e4fe2016-11-18 01:34:11 -080064cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
65 codec.feedback_params = cricket::FeedbackParams();
66 return codec;
67}
68
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000069void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
70 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
71 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
72 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
73 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
74 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
75 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
76 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080077 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
78 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000079 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
80}
81
magjed725e4842016-11-16 00:48:13 -080082// Return true if any codec in |codecs| is an RTX codec with associated payload
83// type |payload_type|.
84bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
85 int payload_type) {
86 for (const cricket::VideoCodec& codec : codecs) {
87 int associated_payload_type;
88 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
89 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
90 &associated_payload_type) &&
91 associated_payload_type == payload_type) {
92 return true;
93 }
94 }
95 return false;
96}
97
nisseca5706d2017-09-11 02:32:16 -070098// TODO(nisse): Duplicated in call.cc.
99const int* FindKeyByValue(const std::map<int, int>& m, int v) {
100 for (const auto& kv : m) {
101 if (kv.second == v)
102 return &kv.first;
103 }
104 return nullptr;
105}
106
107bool HasRtxReceiveAssociation(
108 const webrtc::VideoReceiveStream::Config& config,
109 int payload_type) {
110 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
111 payload_type) != nullptr;
112}
113
114// Check that there's an Rtx payload type for each decoder.
115bool VerifyRtxReceiveAssociations(
116 const webrtc::VideoReceiveStream::Config& config) {
117 for (const auto& decoder : config.decoders) {
118 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
119 return false;
120 }
121 return true;
122}
123
brandtrffc61182016-11-28 06:02:22 -0800124rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700125 int width,
126 int height) {
127 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
128 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800129 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700130 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000131}
132
Shao Changbine62202f2015-04-21 20:24:50 +0800133void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
134 const std::map<int, int>& rtx_types) {
135 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200136 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800137 EXPECT_TRUE(it != rtx_types.end() &&
138 it->second == config.rtp.rtx.payload_type);
139
brandtrb5f2c3f2016-10-04 23:28:39 -0700140 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
141 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800142 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700143 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800144 }
145}
kthelgason2bc68642017-02-07 07:02:22 -0800146
147cricket::MediaConfig GetMediaConfig() {
148 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100149 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800150 return media_config;
151}
nisse26e3abb2017-08-25 04:44:25 -0700152
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000153} // namespace
154
155namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700156class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000157 public:
eladalonf1841382017-06-12 01:16:46 -0700158 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
159 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700160 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700161 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200162 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
163 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
164 engine_(std::unique_ptr<cricket::WebRtcVideoEncoderFactory>(
165 encoder_factory_),
166 std::unique_ptr<cricket::WebRtcVideoDecoderFactory>(
167 decoder_factory_)) {
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +0000168 std::vector<VideoCodec> engine_codecs = engine_.codecs();
henrikg91d6ede2015-09-17 00:24:34 -0700169 RTC_DCHECK(!engine_codecs.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000170 bool codec_set = false;
magjed509e4fe2016-11-18 01:34:11 -0800171 for (const cricket::VideoCodec& codec : engine_codecs) {
172 if (codec.name == "rtx") {
Shao Changbine62202f2015-04-21 20:24:50 +0800173 int associated_payload_type;
magjed509e4fe2016-11-18 01:34:11 -0800174 if (codec.GetParam(kCodecParamAssociatedPayloadType,
175 &associated_payload_type)) {
176 default_apt_rtx_types_[associated_payload_type] = codec.id;
Shao Changbine62202f2015-04-21 20:24:50 +0800177 }
magjed509e4fe2016-11-18 01:34:11 -0800178 } else if (!codec_set && codec.name != "red" && codec.name != "ulpfec") {
179 default_codec_ = codec;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000180 codec_set = true;
181 }
182 }
183
henrikg91d6ede2015-09-17 00:24:34 -0700184 RTC_DCHECK(codec_set);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000185 }
186
187 protected:
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100188 // Find the index of the codec in the engine with the given name. The codec
189 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100190 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100191
magjed509e4fe2016-11-18 01:34:11 -0800192 // Find the codec in the engine with the given name. The codec must be
193 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100194 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800195
magjed2475ae22017-09-12 04:42:15 -0700196 VideoMediaChannel* SetUpForExternalEncoderFactory();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000197
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000198 VideoMediaChannel* SetUpForExternalDecoderFactory(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000199 const std::vector<VideoCodec>& codecs);
200
Peter Boströme4499152016-02-05 11:13:28 +0100201 void TestExtendedEncoderOveruse(bool use_external_encoder);
202
stefanc1aeaf02015-10-15 07:26:07 -0700203 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700204 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700205 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000206 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800207 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200208 // TODO(magjed): Update all tests to use new video codec factories once the
209 // old factories are deprecated,
210 // https://bugs.chromium.org/p/webrtc/issues/detail?id=7925.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200211 // These factories are owned by the video engine.
212 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
213 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700214 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000215 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800216 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000217};
218
eladalonf1841382017-06-12 01:16:46 -0700219TEST_F(WebRtcVideoEngineTest, AnnouncesVp9AccordingToBuildFlags) {
Peter Boström12996152016-05-14 02:03:18 +0200220 bool claims_vp9_support = false;
221 for (const cricket::VideoCodec& codec : engine_.codecs()) {
222 if (codec.name == "VP9") {
223 claims_vp9_support = true;
224 break;
225 }
226 }
227#if defined(RTC_DISABLE_VP9)
228 EXPECT_FALSE(claims_vp9_support);
229#else
230 EXPECT_TRUE(claims_vp9_support);
231#endif // defined(RTC_DISABLE_VP9)
232}
233
eladalonf1841382017-06-12 01:16:46 -0700234TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000235 std::vector<VideoCodec> engine_codecs = engine_.codecs();
236 for (size_t i = 0; i < engine_codecs.size(); ++i) {
237 if (engine_codecs[i].name != kRtxCodecName)
238 continue;
239 int associated_payload_type;
240 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000241 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000242 EXPECT_EQ(default_codec_.id, associated_payload_type);
243 return;
244 }
245 FAIL() << "No RTX codec found among default codecs.";
246}
247
eladalonf1841382017-06-12 01:16:46 -0700248TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100249 RtpCapabilities capabilities = engine_.GetCapabilities();
250 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700251 for (const RtpExtension& extension : capabilities.header_extensions) {
252 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
253 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000254 return;
255 }
256 }
257 FAIL() << "Timestamp offset extension not in header-extension list.";
258}
259
eladalonf1841382017-06-12 01:16:46 -0700260TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100261 RtpCapabilities capabilities = engine_.GetCapabilities();
262 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700263 for (const RtpExtension& extension : capabilities.header_extensions) {
264 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
265 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000266 return;
267 }
268 }
269 FAIL() << "Absolute Sender Time extension not in header-extension list.";
270}
271
eladalonf1841382017-06-12 01:16:46 -0700272TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100273 RtpCapabilities capabilities = engine_.GetCapabilities();
274 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700275 for (const RtpExtension& extension : capabilities.header_extensions) {
276 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
277 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700278 return;
279 }
280 }
281 FAIL() << "Transport sequence number extension not in header-extension list.";
282}
283
eladalonf1841382017-06-12 01:16:46 -0700284TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100285 RtpCapabilities capabilities = engine_.GetCapabilities();
286 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700287 for (const RtpExtension& extension : capabilities.header_extensions) {
288 if (extension.uri == RtpExtension::kVideoRotationUri) {
289 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700290 return;
291 }
292 }
293 FAIL() << "Video Rotation extension not in header-extension list.";
294}
295
eladalonf1841382017-06-12 01:16:46 -0700296TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700297 // Allocate the capturer first to prevent early destruction before channel's
298 // dtor is called.
Tommi85959932018-02-07 19:26:06 +0100299 FakeVideoCapturerWithTaskQueue capturer;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700300
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200301 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700302
magjed2475ae22017-09-12 04:42:15 -0700303 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700304 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
305
306 // Add CVO extension.
307 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800308 cricket::VideoSendParameters parameters;
309 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200310 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700311 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200312 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700313
314 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200315 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700316
317 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700318 EXPECT_FALSE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700319
320 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200321 parameters.extensions.clear();
322 EXPECT_TRUE(channel->SetSendParameters(parameters));
nisse47ac4622016-05-25 08:47:01 -0700323 EXPECT_TRUE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700324}
325
eladalonf1841382017-06-12 01:16:46 -0700326TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
perkj91e1c152016-03-02 05:34:00 -0800327 // Allocate the capturer first to prevent early destruction before channel's
328 // dtor is called.
Tommi85959932018-02-07 19:26:06 +0100329 FakeVideoCapturerWithTaskQueue capturer;
perkj91e1c152016-03-02 05:34:00 -0800330
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200331 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800332
magjed2475ae22017-09-12 04:42:15 -0700333 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
perkj91e1c152016-03-02 05:34:00 -0800334 // Add CVO extension.
335 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800336 cricket::VideoSendParameters parameters;
337 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800338 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700339 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800340 EXPECT_TRUE(channel->SetSendParameters(parameters));
341 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
342
343 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200344 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
perkj91e1c152016-03-02 05:34:00 -0800345
346 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700347 EXPECT_FALSE(capturer.apply_rotation());
perkj91e1c152016-03-02 05:34:00 -0800348}
349
eladalonf1841382017-06-12 01:16:46 -0700350TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Tommi85959932018-02-07 19:26:06 +0100351 FakeVideoCapturerWithTaskQueue capturer;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700352
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200353 encoder_factory_->AddSupportedVideoCodecType("VP8");
354 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700355
magjed2475ae22017-09-12 04:42:15 -0700356 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700357 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
358
359 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200360 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700361
perkjcaafdba2016-03-20 07:34:29 -0700362 // Verify capturer has turned on applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700363 EXPECT_TRUE(capturer.apply_rotation());
perkjcaafdba2016-03-20 07:34:29 -0700364
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365 // Add CVO extension.
366 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800367 cricket::VideoSendParameters parameters;
368 parameters.codecs.push_back(GetEngineCodec("VP8"));
369 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200370 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700371 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700372 // Also remove the first codec to trigger a codec change as well.
373 parameters.codecs.erase(parameters.codecs.begin());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200374 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700375
376 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700377 EXPECT_FALSE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378
379 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200380 parameters.extensions.clear();
381 EXPECT_TRUE(channel->SetSendParameters(parameters));
nisse47ac4622016-05-25 08:47:01 -0700382 EXPECT_TRUE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700383}
384
eladalonf1841382017-06-12 01:16:46 -0700385TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
kwiberg686a8ef2016-02-26 03:00:35 -0800386 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800387 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000388
389 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
390
391 EXPECT_FALSE(channel->SetSend(true))
392 << "Channel should not start without codecs.";
393 EXPECT_TRUE(channel->SetSend(false))
394 << "Channel should be stoppable even without set codecs.";
395}
396
eladalonf1841382017-06-12 01:16:46 -0700397TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
kwiberg686a8ef2016-02-26 03:00:35 -0800398 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800399 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000400 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
401 VideoMediaInfo info;
402 channel->GetStats(&info);
403}
404
eladalonf1841382017-06-12 01:16:46 -0700405TEST_F(WebRtcVideoEngineTest, UseExternalFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200406 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000407
magjed2475ae22017-09-12 04:42:15 -0700408 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800409 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000410
411 EXPECT_TRUE(
412 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200413 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000414 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100415 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200416 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000417 EXPECT_EQ(cricket::CS_RUNNING,
418 capturer.Start(capturer.GetSupportedFormats()->front()));
419 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100420 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200421 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
422 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000423 kTimeout);
424
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200425 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100426 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000427
428 // Setting codecs of the same type should not reallocate any encoders
429 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800430 cricket::VideoSendParameters parameters;
431 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200432 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200433 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000434
435 // Remove stream previously added to free the external encoder instance.
436 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200437 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000438}
439
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700440// Test that when an external encoder factory supports a codec we don't
441// internally support, we still add an RTX codec for it.
442// TODO(deadbeef): Currently this test is only effective if WebRTC is
443// built with no internal H264 support. This test should be updated
444// if/when we start adding RTX codecs for unrecognized codec names.
eladalonf1841382017-06-12 01:16:46 -0700445TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForExternalCodec) {
magjed725e4842016-11-16 00:48:13 -0800446 using webrtc::H264::ProfileLevelIdToString;
447 using webrtc::H264::ProfileLevelId;
448 using webrtc::H264::kLevel1;
449 cricket::VideoCodec h264_constrained_baseline("H264");
450 h264_constrained_baseline.params[kH264FmtpProfileLevelId] =
451 *ProfileLevelIdToString(
452 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
453 cricket::VideoCodec h264_constrained_high("H264");
454 h264_constrained_high.params[kH264FmtpProfileLevelId] =
455 *ProfileLevelIdToString(
456 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
457 cricket::VideoCodec h264_high("H264");
458 h264_high.params[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
459 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
460
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200461 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
462 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
463 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700464
magjed725e4842016-11-16 00:48:13 -0800465 // First figure out what payload types the test codecs got assigned.
466 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800467 // Now search for RTX codecs for them. Expect that they all have associated
468 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800469 EXPECT_TRUE(HasRtxCodec(
470 codecs, FindMatchingCodec(codecs, h264_constrained_baseline)->id));
471 EXPECT_TRUE(HasRtxCodec(
472 codecs, FindMatchingCodec(codecs, h264_constrained_high)->id));
magjed509e4fe2016-11-18 01:34:11 -0800473 EXPECT_TRUE(HasRtxCodec(
magjed725e4842016-11-16 00:48:13 -0800474 codecs, FindMatchingCodec(codecs, h264_high)->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700475}
476
eladalonf1841382017-06-12 01:16:46 -0700477void WebRtcVideoEngineTest::TestExtendedEncoderOveruse(
Peter Boströme4499152016-02-05 11:13:28 +0100478 bool use_external_encoder) {
kwiberg686a8ef2016-02-26 03:00:35 -0800479 std::unique_ptr<VideoMediaChannel> channel;
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100480 FakeCall* fake_call = new FakeCall();
Peter Boströme4499152016-02-05 11:13:28 +0100481 call_.reset(fake_call);
482 if (use_external_encoder) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200483 encoder_factory_->AddSupportedVideoCodecType("VP8");
magjed2475ae22017-09-12 04:42:15 -0700484 channel.reset(SetUpForExternalEncoderFactory());
Peter Boströme4499152016-02-05 11:13:28 +0100485 } else {
nisse51542be2016-02-12 02:27:06 -0800486 channel.reset(
kthelgason2bc68642017-02-07 07:02:22 -0800487 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
Peter Boströme4499152016-02-05 11:13:28 +0100488 }
489 ASSERT_TRUE(
490 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
magjed509e4fe2016-11-18 01:34:11 -0800491 cricket::VideoSendParameters parameters;
492 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme4499152016-02-05 11:13:28 +0100493 EXPECT_TRUE(channel->SetSendParameters(parameters));
494 EXPECT_TRUE(channel->SetSend(true));
495 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
496
497 EXPECT_EQ(use_external_encoder,
498 stream->GetConfig().encoder_settings.full_overuse_time);
499 // Remove stream previously added to free the external encoder instance.
500 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
501}
502
eladalonf1841382017-06-12 01:16:46 -0700503TEST_F(WebRtcVideoEngineTest, EnablesFullEncoderTimeForExternalEncoders) {
Peter Boströme4499152016-02-05 11:13:28 +0100504 TestExtendedEncoderOveruse(true);
505}
506
eladalonf1841382017-06-12 01:16:46 -0700507TEST_F(WebRtcVideoEngineTest, DisablesFullEncoderTimeForNonExternalEncoders) {
Peter Boströme4499152016-02-05 11:13:28 +0100508 TestExtendedEncoderOveruse(false);
509}
510
Peter Boström12996152016-05-14 02:03:18 +0200511#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700512TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200513 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100514
magjed2475ae22017-09-12 04:42:15 -0700515 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
Peter Boström53eda3d2015-03-27 15:53:18 +0100516
517 EXPECT_TRUE(
518 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
519}
Peter Boström12996152016-05-14 02:03:18 +0200520#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100521
eladalonf1841382017-06-12 01:16:46 -0700522TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200523 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100524 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200525 call_.reset(fake_call);
magjed2475ae22017-09-12 04:42:15 -0700526 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
qiangchenc27d89f2015-07-16 10:27:16 -0700527
528 EXPECT_TRUE(
529 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
530
Tommi85959932018-02-07 19:26:06 +0100531 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200532 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700533 capturer.Start(cricket::VideoFormat(1280, 720,
534 cricket::VideoFormat::FpsToInterval(60),
535 cricket::FOURCC_I420));
536 channel->SetSend(true);
537
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200538 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700539
540 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700541 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700542 for (int i = 0; i < 10; i++) {
543 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700544 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700545 int64_t interval = timestamp - last_timestamp;
546
547 // Precision changes from nanosecond to millisecond.
548 // Allow error to be no more than 1.
549 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
550
551 last_timestamp = timestamp;
552 }
553
554 capturer.Start(cricket::VideoFormat(1280, 720,
555 cricket::VideoFormat::FpsToInterval(30),
556 cricket::FOURCC_I420));
557
558 EXPECT_TRUE(capturer.CaptureFrame());
559 last_timestamp = stream->GetLastTimestamp();
560 for (int i = 0; i < 10; i++) {
561 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700562 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700563 int64_t interval = timestamp - last_timestamp;
564
565 // Precision changes from nanosecond to millisecond.
566 // Allow error to be no more than 1.
567 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
568
569 last_timestamp = timestamp;
570 }
571
572 // Remove stream previously added to free the external encoder instance.
573 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
574}
575
Oleh Prypina40f8242017-12-21 13:32:23 +0100576size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
577 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100578 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
579 for (size_t i = 0; i < codecs.size(); ++i) {
580 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200581 if (!CodecNamesEq(name, engine_codec.name))
582 continue;
583 // The tests only use H264 Constrained Baseline. Make sure we don't return
584 // an internal H264 codec from the engine with a different H264 profile.
585 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
586 const rtc::Optional<webrtc::H264::ProfileLevelId> profile_level_id =
587 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
588 if (profile_level_id->profile !=
589 webrtc::H264::kProfileConstrainedBaseline) {
590 continue;
591 }
592 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100593 return i;
magjed509e4fe2016-11-18 01:34:11 -0800594 }
595 // This point should never be reached.
596 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100597 return -1;
598}
599
600cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
601 const std::string& name) const {
602 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800603}
604
magjed2475ae22017-09-12 04:42:15 -0700605VideoMediaChannel* WebRtcVideoEngineTest::SetUpForExternalEncoderFactory() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000606 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800607 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200608 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800609 // We need to look up the codec in the engine to get the correct payload type.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200610 for (const VideoCodec& codec : encoder_factory_->supported_codecs())
magjed509e4fe2016-11-18 01:34:11 -0800611 parameters.codecs.push_back(GetEngineCodec(codec.name));
612
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200613 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000614
615 return channel;
616}
617
eladalonf1841382017-06-12 01:16:46 -0700618VideoMediaChannel* WebRtcVideoEngineTest::SetUpForExternalDecoderFactory(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000619 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000620 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800621 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200622 cricket::VideoRecvParameters parameters;
623 parameters.codecs = codecs;
624 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000625
626 return channel;
627}
628
eladalonf1841382017-06-12 01:16:46 -0700629TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200630 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000631
magjed2475ae22017-09-12 04:42:15 -0700632 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000633
Peter Boström0c4e06b2015-10-07 12:23:21 +0200634 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000635
636 EXPECT_TRUE(
637 channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
638 EXPECT_TRUE(channel->SetSend(true));
639
Tommi85959932018-02-07 19:26:06 +0100640 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200641 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000642 EXPECT_EQ(cricket::CS_RUNNING,
643 capturer.Start(capturer.GetSupportedFormats()->front()));
644 EXPECT_TRUE(capturer.CaptureFrame());
645
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200646 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000647
648 // Verify that encoders are configured for simulcast through adapter
649 // (increasing resolution and only configured to send one stream each).
650 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200651 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
652 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000653 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200654 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000655 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
656 EXPECT_GT(codec_settings.width, prev_width);
657 prev_width = codec_settings.width;
658 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000659
Niels Möllerff40b142018-04-09 08:49:14 +0200660 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000661
662 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200663 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000664}
665
eladalonf1841382017-06-12 01:16:46 -0700666TEST_F(WebRtcVideoEngineTest, ChannelWithExternalH264CanChangeToInternalVp8) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200667 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000668
magjed2475ae22017-09-12 04:42:15 -0700669 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000670
671 EXPECT_TRUE(
672 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200673 ASSERT_EQ(1u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000674
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200675 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800676 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200677 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200678 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000679}
680
eladalonf1841382017-06-12 01:16:46 -0700681TEST_F(WebRtcVideoEngineTest,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000682 DontUseExternalEncoderFactoryForUnsupportedCodecs) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200683 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000684
kwiberg686a8ef2016-02-26 03:00:35 -0800685 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800686 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800687 cricket::VideoSendParameters parameters;
688 parameters.codecs.push_back(GetEngineCodec("VP8"));
689 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000690
691 EXPECT_TRUE(
692 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000693 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200694 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000695}
696
eladalonf1841382017-06-12 01:16:46 -0700697TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000698 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200699 encoder_factory_->AddSupportedVideoCodecType("VP8");
700 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000701
kwiberg686a8ef2016-02-26 03:00:35 -0800702 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800703 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800704 cricket::VideoSendParameters parameters;
705 parameters.codecs.push_back(GetEngineCodec("VP8"));
706 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000707
Peter Boström0c4e06b2015-10-07 12:23:21 +0200708 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000709
710 EXPECT_TRUE(
711 channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
712 EXPECT_TRUE(channel->SetSend(true));
713
714 // Send a fake frame, or else the media engine will configure the simulcast
715 // encoder adapter at a low-enough size that it'll only create a single
716 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100717 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200718 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000719 EXPECT_EQ(cricket::CS_RUNNING,
720 capturer.Start(capturer.GetSupportedFormats()->front()));
721 EXPECT_TRUE(capturer.CaptureFrame());
722
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200723 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
724 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000725 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200726 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000727
728 channel.reset();
729 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000731}
732
eladalonf1841382017-06-12 01:16:46 -0700733TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000734 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200735 encoder_factory_->AddSupportedVideoCodecType("VP8");
736 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000737
kwiberg686a8ef2016-02-26 03:00:35 -0800738 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800739 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800740 cricket::VideoSendParameters parameters;
741 parameters.codecs.push_back(GetEngineCodec("H264"));
742 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000743
744 EXPECT_TRUE(
745 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200746 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Per21d45d22016-10-30 21:37:57 +0100747
748 // Send a frame of 720p. This should trigger a "real" encoder initialization.
749 cricket::VideoFormat format(
750 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100751 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200752 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100753 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
754 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200755 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000756 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200757 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000758
759 channel.reset();
760 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200761 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000762}
763
eladalonf1841382017-06-12 01:16:46 -0700764TEST_F(WebRtcVideoEngineTest, SimulcastDisabledForH264) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200765 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700766
magjed2475ae22017-09-12 04:42:15 -0700767 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
noahricfdac5162015-08-27 01:59:29 -0700768
Peter Boström0c4e06b2015-10-07 12:23:21 +0200769 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700770 EXPECT_TRUE(
771 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100772
773 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700774 cricket::VideoFormat format(
775 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100776 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200777 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100778 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
779 EXPECT_TRUE(capturer.CaptureFrame());
780
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200781 ASSERT_EQ(1u, encoder_factory_->encoders().size());
782 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
783 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700784 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
785 EXPECT_EQ(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200786 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700787}
788
brandtrffc61182016-11-28 06:02:22 -0800789// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700790// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800791//
792// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700793TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800794 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
795 auto is_flexfec = [](const VideoCodec& codec) {
796 if (codec.name == "flexfec-03")
797 return true;
798 return false;
799 };
800
801 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800802 const std::vector<VideoCodec> codecs_before = engine_.codecs();
803 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
804 codecs_before.end(), is_flexfec));
805
806 // FlexFEC is active with field trial.
807 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800808 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800809 const std::vector<VideoCodec> codecs_after = engine_.codecs();
810 EXPECT_NE(codecs_after.end(),
811 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
812}
813
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100814// Test that external codecs are added after internal SW codecs.
eladalonf1841382017-06-12 01:16:46 -0700815TEST_F(WebRtcVideoEngineTest, ReportSupportedExternalCodecs) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100816 const char* kFakeExternalCodecName = "FakeExternalCodec";
817 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000818
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100819 // The external codec should appear after the internal codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100820 const size_t vp8_index = GetEngineCodecIndex("VP8");
821 const size_t fake_external_codec_index =
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100822 GetEngineCodecIndex(kFakeExternalCodecName);
823 EXPECT_LT(vp8_index, fake_external_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000824}
825
brandtrffc61182016-11-28 06:02:22 -0800826// Test that an external codec that was added after the engine was initialized
827// does show up in the codec list after it was added.
eladalonf1841382017-06-12 01:16:46 -0700828TEST_F(WebRtcVideoEngineTest, ReportSupportedExternalCodecsWithAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100829 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
830 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100831
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100832 // Set up external encoder factory with first codec, and initialize engine.
833 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
834
brandtrffc61182016-11-28 06:02:22 -0800835 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800836
837 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100838 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800839 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
840 EXPECT_EQ(codecs_before.size() + 1, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100841
842 // Check that both fake codecs are present and that the second fake codec
843 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100844 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
845 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100846 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800847}
848
eladalonf1841382017-06-12 01:16:46 -0700849TEST_F(WebRtcVideoEngineTest, RegisterExternalDecodersIfSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200850 decoder_factory_->AddSupportedVideoCodecType(webrtc::kVideoCodecVP8);
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200851 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800852 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000853
kwiberg686a8ef2016-02-26 03:00:35 -0800854 std::unique_ptr<VideoMediaChannel> channel(
magjed2475ae22017-09-12 04:42:15 -0700855 SetUpForExternalDecoderFactory(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000856
857 EXPECT_TRUE(
858 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200859 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000860
861 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200862 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200863 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000864
865 // Remove stream previously added to free the external decoder instance.
866 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200867 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000868}
869
870// Verifies that we can set up decoders that are not internally supported.
eladalonf1841382017-06-12 01:16:46 -0700871TEST_F(WebRtcVideoEngineTest, RegisterExternalH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000872 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
873 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
874 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
875 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200876 encoder_factory_->AddSupportedVideoCodecType("H264");
877 decoder_factory_->AddSupportedVideoCodecType(webrtc::kVideoCodecH264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000878 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800879 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000880
kwiberg686a8ef2016-02-26 03:00:35 -0800881 std::unique_ptr<VideoMediaChannel> channel(
magjed2475ae22017-09-12 04:42:15 -0700882 SetUpForExternalDecoderFactory(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000883
884 EXPECT_TRUE(
885 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200886 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000887}
888
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200889TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
890 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
891 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
892 WebRtcVideoEngine engine(std::move(encoder_factory),
893 std::move(decoder_factory));
894 EXPECT_EQ(0u, engine.codecs().size());
895}
896
897TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
898 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700899 webrtc::MockVideoEncoderFactory* encoder_factory =
900 new webrtc::MockVideoEncoderFactory();
901 webrtc::MockVideoDecoderFactory* decoder_factory =
902 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200903 WebRtcVideoEngine engine(
904 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
905 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
906 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
907 EXPECT_EQ(0u, engine.codecs().size());
908 EXPECT_CALL(*encoder_factory, Die());
909 EXPECT_CALL(*decoder_factory, Die());
910}
911
912// Test full behavior in the video engine when video codec factories of the new
913// type are injected supporting the single codec Vp8. Check the returned codecs
914// from the engine and that we will create a Vp8 encoder and decoder using the
915// new factories.
916TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
917 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700918 webrtc::MockVideoEncoderFactory* encoder_factory =
919 new webrtc::MockVideoEncoderFactory();
920 webrtc::MockVideoDecoderFactory* decoder_factory =
921 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200922 WebRtcVideoEngine engine(
923 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
924 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
925 const webrtc::SdpVideoFormat vp8_format("VP8");
926 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
927 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
928 .WillRepeatedly(testing::Return(supported_formats));
929
930 // Verify the codecs from the engine.
931 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100932 // Verify default codecs has been added correctly.
933 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200934 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100935
936 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200937 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100938 int vp8_associated_payload;
939 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
940 &vp8_associated_payload));
941 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
942
943 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
944
945 // RTX codec for RED.
946 EXPECT_EQ("rtx", engine_codecs.at(3).name);
947 int red_associated_payload;
948 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
949 &red_associated_payload));
950 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
951
952 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
953
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200954 int associated_payload_type;
955 EXPECT_TRUE(engine_codecs.at(1).GetParam(
956 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
957 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
958 // Verify default parameters has been added to the VP8 codec.
959 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
960
961 // Mock encoder creation. |engine| take ownership of the encoder.
962 webrtc::VideoEncoderFactory::CodecInfo codec_info;
963 codec_info.is_hardware_accelerated = false;
964 codec_info.has_internal_source = false;
965 const webrtc::SdpVideoFormat format("VP8");
966 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
967 .WillRepeatedly(testing::Return(codec_info));
968 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder();
969 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
970 .WillOnce(testing::Return(encoder));
971
972 // Mock decoder creation. |engine| take ownership of the decoder.
973 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder();
974 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
975 .WillOnce(testing::Return(decoder));
976
977 // Create a call.
978 webrtc::RtcEventLogNullImpl event_log;
979 std::unique_ptr<webrtc::Call> call(
980 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
981
982 // Create send channel.
983 const int send_ssrc = 123;
984 std::unique_ptr<VideoMediaChannel> send_channel(
985 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
986 cricket::VideoSendParameters send_parameters;
987 send_parameters.codecs.push_back(engine_codecs.at(0));
988 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
989 send_channel->OnReadyToSend(true);
990 EXPECT_TRUE(
991 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
992 EXPECT_TRUE(send_channel->SetSend(true));
993
994 // Create recv channel.
995 const int recv_ssrc = 321;
996 std::unique_ptr<VideoMediaChannel> recv_channel(
997 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
998 cricket::VideoRecvParameters recv_parameters;
999 recv_parameters.codecs.push_back(engine_codecs.at(0));
1000 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1001 EXPECT_TRUE(recv_channel->AddRecvStream(
1002 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1003
1004 // Remove streams previously added to free the encoder and decoder instance.
1005 EXPECT_CALL(*encoder_factory, Die());
1006 EXPECT_CALL(*decoder_factory, Die());
1007 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1008 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1009}
1010
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001011// Test behavior when decoder factory fails to create a decoder (returns null).
1012TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1013 // |engine| take ownership of the factories.
1014 webrtc::MockVideoEncoderFactory* encoder_factory =
1015 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1016 webrtc::MockVideoDecoderFactory* decoder_factory =
1017 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1018 WebRtcVideoEngine engine(
1019 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1020 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1021 const webrtc::SdpVideoFormat vp8_format("VP8");
1022 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1023 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1024 .WillRepeatedly(testing::Return(supported_formats));
1025
1026 // Decoder creation fails.
1027 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1028 .WillOnce(testing::Return(nullptr));
1029
1030 // Create a call.
1031 webrtc::RtcEventLogNullImpl event_log;
1032 std::unique_ptr<webrtc::Call> call(
1033 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1034
1035 // Create recv channel.
1036 const int recv_ssrc = 321;
1037 std::unique_ptr<VideoMediaChannel> recv_channel(
1038 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1039 cricket::VideoRecvParameters recv_parameters;
1040 recv_parameters.codecs.push_back(engine.codecs().front());
1041 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1042 EXPECT_TRUE(recv_channel->AddRecvStream(
1043 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1044
1045 // Remove streams previously added to free the encoder and decoder instance.
1046 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1047}
1048
eladalonf1841382017-06-12 01:16:46 -07001049class WebRtcVideoChannelBaseTest
1050 : public VideoMediaChannelTest<WebRtcVideoEngine, WebRtcVideoChannel> {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001051 protected:
eladalonf1841382017-06-12 01:16:46 -07001052 typedef VideoMediaChannelTest<WebRtcVideoEngine, WebRtcVideoChannel> Base;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001053
magjed509e4fe2016-11-18 01:34:11 -08001054 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1055 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1056 if (CodecNamesEq(name, engine_codec.name))
1057 return engine_codec;
1058 }
1059 // This point should never be reached.
1060 ADD_FAILURE() << "Unrecognized codec name: " << name;
1061 return cricket::VideoCodec();
1062 }
1063
1064 cricket::VideoCodec DefaultCodec() override { return GetEngineCodec("VP8"); }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001065};
1066
sakal1fd95952016-06-22 00:46:15 -07001067// Verifies that id given in stream params is passed to the decoder factory.
eladalonf1841382017-06-12 01:16:46 -07001068TEST_F(WebRtcVideoEngineTest, StreamParamsIdPassedToDecoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001069 decoder_factory_->AddSupportedVideoCodecType(webrtc::kVideoCodecVP8);
sakal1fd95952016-06-22 00:46:15 -07001070 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08001071 parameters.codecs.push_back(GetEngineCodec("VP8"));
sakal1fd95952016-06-22 00:46:15 -07001072
1073 std::unique_ptr<VideoMediaChannel> channel(
magjed2475ae22017-09-12 04:42:15 -07001074 SetUpForExternalDecoderFactory(parameters.codecs));
sakal1fd95952016-06-22 00:46:15 -07001075
1076 StreamParams sp = cricket::StreamParams::CreateLegacy(kSsrc);
1077 sp.id = "FakeStreamParamsId";
1078 EXPECT_TRUE(channel->AddRecvStream(sp));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001079 EXPECT_EQ(1u, decoder_factory_->decoders().size());
sakal1fd95952016-06-22 00:46:15 -07001080
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001081 std::vector<cricket::VideoDecoderParams> params = decoder_factory_->params();
sakal1fd95952016-06-22 00:46:15 -07001082 ASSERT_EQ(1u, params.size());
1083 EXPECT_EQ(sp.id, params[0].receive_stream_id);
1084}
1085
eladalonf1841382017-06-12 01:16:46 -07001086TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001087 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001088 std::unique_ptr<FakeCall> fake_call(new FakeCall());
magjed2475ae22017-09-12 04:42:15 -07001089 std::unique_ptr<VideoMediaChannel> channel(SetUpForExternalEncoderFactory());
sprangf24a0642017-02-28 13:23:26 -08001090 ASSERT_TRUE(
1091 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1092 cricket::VideoCodec codec = GetEngineCodec("VP8");
1093 cricket::VideoSendParameters parameters;
1094 parameters.codecs.push_back(codec);
1095 channel->OnReadyToSend(true);
1096 channel->SetSend(true);
1097 ASSERT_TRUE(channel->SetSendParameters(parameters));
1098
Tommi85959932018-02-07 19:26:06 +01001099 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001100 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001101 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001102
1103 EXPECT_EQ(cricket::CS_RUNNING,
1104 capturer.Start(capturer.GetSupportedFormats()->front()));
1105 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001106 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
sprangf24a0642017-02-28 13:23:26 -08001107 EXPECT_EQ(webrtc::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001108 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001109
Niels Möllerff40b142018-04-09 08:49:14 +02001110 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001111 EXPECT_TRUE(capturer.CaptureFrame());
1112 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001113 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001114
1115 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001116 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001117 EXPECT_TRUE(capturer.CaptureFrame());
1118 // Change to screen content, recreate encoder. For the simulcast encoder
1119 // adapter case, this will result in two calls since InitEncode triggers a
1120 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001121 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
sprangf24a0642017-02-28 13:23:26 -08001122 EXPECT_EQ(webrtc::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001123 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001124
Niels Möllerff40b142018-04-09 08:49:14 +02001125 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001126 EXPECT_TRUE(capturer.CaptureFrame());
1127 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001128 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001129
1130 options.is_screencast.emplace(false);
1131 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001132 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001133 // Change back to regular video content, update encoder. Also change
1134 // a non |is_screencast| option just to verify it doesn't affect recreation.
1135 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001136 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
sprangf24a0642017-02-28 13:23:26 -08001137 EXPECT_EQ(webrtc::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001138 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001139
1140 // Remove stream previously added to free the external encoder instance.
1141 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001142 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001143}
1144
srtee0c2eea2017-12-15 17:44:33 +01001145TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
1146 Base::SetSend();
1147}
1148TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
1149 Base::SetSendWithoutCodecs();
1150}
1151TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
1152 Base::SetSendSetsTransportBufferSizes();
1153}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001154
srtee0c2eea2017-12-15 17:44:33 +01001155TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
1156 Base::GetStats();
1157}
1158TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
1159 Base::GetStatsMultipleRecvStreams();
1160}
1161TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
1162 Base::GetStatsMultipleSendStreams();
1163}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001164
srtee0c2eea2017-12-15 17:44:33 +01001165TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
1166 Base::SetSendBandwidth();
1167}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001168
srtee0c2eea2017-12-15 17:44:33 +01001169TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
1170 Base::SetSendSsrc();
1171}
1172TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
1173 Base::SetSendSsrcAfterSetCodecs();
1174}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001175
srtee0c2eea2017-12-15 17:44:33 +01001176TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
1177 Base::SetSink();
1178}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001179
srtee0c2eea2017-12-15 17:44:33 +01001180TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
1181 Base::AddRemoveSendStreams();
1182}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001183
srtee0c2eea2017-12-15 17:44:33 +01001184TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
1185 Base::SimulateConference();
1186}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001187
srtee0c2eea2017-12-15 17:44:33 +01001188TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
1189 Base::AddRemoveCapturer();
1190}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001191
srtee0c2eea2017-12-15 17:44:33 +01001192TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
1193 Base::RemoveCapturerWithoutAdd();
1194}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001195
srtee0c2eea2017-12-15 17:44:33 +01001196TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
1197 Base::AddRemoveCapturerMultipleSources();
1198}
1199TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
1200 Base::RejectEmptyStreamParams();
1201}
1202TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
1203 Base::MultipleSendStreams();
1204}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001205
eladalonf1841382017-06-12 01:16:46 -07001206TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001207 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001208}
1209
eladalonf1841382017-06-12 01:16:46 -07001210TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001211 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001212}
1213
eladalonf1841382017-06-12 01:16:46 -07001214TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001215 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001216}
1217
eladalonf1841382017-06-12 01:16:46 -07001218TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001219 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1220 // bitrates. This currently happens at <250k, and two streams sharing 300k
1221 // initially will use QVGA instead of VGA.
1222 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1223 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001224 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02001225 codec.params[kCodecParamStartBitrate] = "1000000";
1226 Base::TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001227}
1228
eladalonf1841382017-06-12 01:16:46 -07001229class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001230 public:
eladalonf1841382017-06-12 01:16:46 -07001231 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
1232 explicit WebRtcVideoChannelTest(const char* field_trials)
1233 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001234 void SetUp() override {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001235 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08001236 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
1237 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08001238 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001239 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001240 send_parameters_.codecs = engine_.codecs();
1241 recv_parameters_.codecs = engine_.codecs();
1242 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001243 }
1244
1245 protected:
1246 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001247 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001248 }
1249
1250 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001251 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001252 EXPECT_TRUE(channel_->AddSendStream(sp));
1253 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001254 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001255 EXPECT_EQ(num_streams + 1, streams.size());
1256 return streams[streams.size() - 1];
1257 }
1258
1259 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001260 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001261 }
1262
1263 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001264 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001265 }
1266
1267 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001268 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001269 EXPECT_TRUE(channel_->AddRecvStream(sp));
1270 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001271 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001272 EXPECT_EQ(num_streams + 1, streams.size());
1273 return streams[streams.size() - 1];
1274 }
1275
pbos@webrtc.org00873182014-11-25 14:03:34 +00001276 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
1277 int expected_min_bitrate_bps,
1278 const char* start_bitrate_kbps,
1279 int expected_start_bitrate_bps,
1280 const char* max_bitrate_kbps,
1281 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001282 ExpectSetBitrateParameters(expected_min_bitrate_bps,
1283 expected_start_bitrate_bps,
1284 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001285 auto& codecs = send_parameters_.codecs;
1286 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08001287 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00001288 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
1289 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
1290 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001291 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001292 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001293
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001294 void ExpectSetBitrateParameters(int min_bitrate_bps,
1295 int start_bitrate_bps,
1296 int max_bitrate_bps) {
1297 EXPECT_CALL(
1298 *fake_call_->GetMockTransportControllerSend(),
1299 SetSdpBitrateParameters(AllOf(
1300 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
1301 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
1302 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
1303 }
1304
1305 void ExpectSetMaxBitrate(int max_bitrate_bps) {
1306 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
1307 SetSdpBitrateParameters(Field(
1308 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001309 }
1310
isheriff6f8d6862016-05-26 11:24:55 -07001311 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001312 // Enable extension.
1313 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001314 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07001315 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001316 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001317 FakeVideoSendStream* send_stream =
1318 AddSendStream(cricket::StreamParams::CreateLegacy(123));
1319
1320 // Verify the send extension id.
1321 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
1322 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07001323 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001324 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001325 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001326 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
1327 // receivers.
1328 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
1329 ->GetConfig()
1330 .rtp.extensions.empty());
1331
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00001332 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001333 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02001334 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
1335 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00001336 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
1337
1338 // Verify that adding receive RTP header extensions adds them for existing
1339 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001340 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02001341 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00001342 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
1343 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07001344 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001345 }
1346
isheriff6f8d6862016-05-26 11:24:55 -07001347 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001348 // Enable extension.
1349 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001350 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07001351 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001352 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001353
1354 FakeVideoReceiveStream* recv_stream =
1355 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
1356
1357 // Verify the recv extension id.
1358 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
1359 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07001360 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001361 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001362 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00001363
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001364 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
1365 // senders.
1366 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
1367 ->GetConfig()
1368 .rtp.extensions.empty());
1369
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00001370 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001371 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02001372 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
1373 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00001374 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
1375
1376 // Verify that adding receive RTP header extensions adds them for existing
1377 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001378 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02001379 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00001380 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
1381 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07001382 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001383 }
1384
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001385 void TestExtensionFilter(const std::vector<std::string>& extensions,
1386 const std::string& expected_extension) {
1387 cricket::VideoSendParameters parameters = send_parameters_;
1388 int expected_id = -1;
1389 int id = 1;
1390 for (const std::string& extension : extensions) {
1391 if (extension == expected_extension)
1392 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07001393 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001394 }
1395 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1396 FakeVideoSendStream* send_stream =
1397 AddSendStream(cricket::StreamParams::CreateLegacy(123));
1398
1399 // Verify that only one of them has been set, and that it is the one with
1400 // highest priority (transport sequence number).
1401 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
1402 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
1403 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07001404 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001405 }
1406
asapersson3c81a1a2017-06-14 05:52:21 -07001407 void TestDegradationPreference(bool resolution_scaling_enabled,
1408 bool fps_scaling_enabled);
1409
Erik Språngefbde372015-04-29 16:21:28 +02001410 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02001411 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08001412 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
1413 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001414
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001415 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07001416 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01001417 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08001418 bool enabled) {
nisse05103312016-03-16 02:22:50 -07001419 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01001420 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02001421 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08001422 // Options only take effect on the next frame.
1423 EXPECT_TRUE(capturer->CaptureFrame());
1424
Erik Språng143cec12015-04-28 10:01:41 +02001425 return fake_call_->GetVideoSendStreams().back();
1426 }
1427
Peter Boström2feafdb2015-09-09 14:32:14 +02001428 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
1429 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02001430 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02001431 std::vector<uint32_t> ssrcs;
1432 std::vector<uint32_t> rtx_ssrcs;
1433 uint32_t num_streams = enabled ? 3 : 1;
1434 for (uint32_t i = 0; i < num_streams; ++i) {
1435 uint32_t ssrc = last_ssrc_ + i;
1436 ssrcs.push_back(ssrc);
1437 if (with_rtx) {
1438 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
1439 }
Erik Språng143cec12015-04-28 10:01:41 +02001440 }
Peter Boström2feafdb2015-09-09 14:32:14 +02001441 if (with_rtx) {
1442 return AddSendStream(
1443 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
1444 }
1445 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02001446 }
1447
perkjfa10b552016-10-02 23:45:26 -07001448 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07001449 std::vector<FakeVideoSendStream*> streams =
1450 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07001451 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07001452 FakeVideoSendStream* stream = streams[streams.size() - 1];
perkjfa10b552016-10-02 23:45:26 -07001453 EXPECT_EQ(1, stream->GetEncoderConfig().number_of_streams);
1454 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07001455 }
1456
perkjfa10b552016-10-02 23:45:26 -07001457 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07001458 int stream_max,
1459 int expected_encoder_bitrate) {
1460 VideoSendParameters limited_send_params = send_parameters_;
1461 limited_send_params.max_bandwidth_bps = global_max;
1462 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07001463 webrtc::RtpParameters parameters =
1464 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07001465 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01001466 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08001467 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07001468 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07001469 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07001470 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01001471 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07001472 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07001473 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07001474 }
1475
kwiberg686a8ef2016-02-26 03:00:35 -08001476 std::unique_ptr<FakeCall> fake_call_;
1477 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001478 cricket::VideoSendParameters send_parameters_;
1479 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02001480 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001481};
1482
eladalonf1841382017-06-12 01:16:46 -07001483TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02001484 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07001485 const std::string kSyncLabel = "AvSyncLabel";
1486
1487 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08001488 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07001489 EXPECT_TRUE(channel_->AddRecvStream(sp));
1490
1491 EXPECT_EQ(1, fake_call_->GetVideoReceiveStreams().size());
1492 EXPECT_EQ(kSyncLabel,
1493 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
1494 << "SyncGroup should be set based on sync_label";
1495}
1496
eladalonf1841382017-06-12 01:16:46 -07001497TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001498 cricket::VideoSendParameters parameters;
1499 parameters.codecs = engine_.codecs();
1500 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001501 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08001502 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001503 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001504
1505 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02001506 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
1507 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001508 FakeVideoSendStream* send_stream = AddSendStream(
1509 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
1510
1511 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
1512 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
1513 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
1514
1515 // Receiver side.
1516 FakeVideoReceiveStream* recv_stream = AddRecvStream(
1517 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07001518 EXPECT_FALSE(
1519 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07001520 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02001521 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07001522 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
1523 GetEngineCodec("red").id))
1524 << "RTX should be mapped for the RED payload type";
1525
brandtr14742122017-01-27 04:53:07 -08001526 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001527}
1528
eladalonf1841382017-06-12 01:16:46 -07001529TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00001530 // Setup one channel with an associated RTX stream.
1531 cricket::StreamParams params =
1532 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
1533 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
1534 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08001535 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07001536
1537 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
1538 << "RTX should be mapped for all decoders/payload types.";
1539 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
1540 GetEngineCodec("red").id))
1541 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001542}
1543
eladalonf1841382017-06-12 01:16:46 -07001544TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00001545 // Setup one channel without an associated RTX stream.
1546 cricket::StreamParams params =
1547 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
1548 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08001549 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001550}
1551
eladalonf1841382017-06-12 01:16:46 -07001552TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001553 FakeVideoSendStream* send_stream =
1554 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
1555 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
1556
1557 FakeVideoReceiveStream* recv_stream =
1558 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
1559 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001560}
1561
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001562// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07001563TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07001564 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001565}
isheriff6f8d6862016-05-26 11:24:55 -07001566
eladalonf1841382017-06-12 01:16:46 -07001567TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07001568 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001569}
1570
1571// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07001572TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07001573 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00001574}
isheriff6f8d6862016-05-26 11:24:55 -07001575
eladalonf1841382017-06-12 01:16:46 -07001576TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07001577 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001578}
1579
eladalonf1841382017-06-12 01:16:46 -07001580TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001581 // Enable three redundant extensions.
1582 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07001583 extensions.push_back(RtpExtension::kAbsSendTimeUri);
1584 extensions.push_back(RtpExtension::kTimestampOffsetUri);
1585 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
1586 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001587}
1588
eladalonf1841382017-06-12 01:16:46 -07001589TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001590 // Enable two redundant extensions.
1591 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07001592 extensions.push_back(RtpExtension::kAbsSendTimeUri);
1593 extensions.push_back(RtpExtension::kTimestampOffsetUri);
1594 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001595}
1596
stefanc1aeaf02015-10-15 07:26:07 -07001597// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07001598TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07001599 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07001600}
eladalonf1841382017-06-12 01:16:46 -07001601TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07001602 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07001603}
1604
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07001605// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07001606TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07001607 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07001608}
eladalonf1841382017-06-12 01:16:46 -07001609TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07001610 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07001611}
1612
eladalonf1841382017-06-12 01:16:46 -07001613TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001614 const int kAbsSendTimeId = 1;
1615 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07001616 send_parameters_.extensions.push_back(
1617 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
1618 send_parameters_.extensions.push_back(
1619 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001620
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001621 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001622 FakeVideoSendStream* send_stream =
1623 AddSendStream(cricket::StreamParams::CreateLegacy(123));
1624
1625 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01001626 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001627
1628 // Setting the same extensions (even if in different order) shouldn't
1629 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001630 std::reverse(send_parameters_.extensions.begin(),
1631 send_parameters_.extensions.end());
1632 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001633
1634 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
1635
1636 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001637 send_parameters_.extensions.resize(1);
1638 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001639
1640 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
1641}
1642
eladalonf1841382017-06-12 01:16:46 -07001643TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001644 const int kTOffsetId = 1;
1645 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07001646 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07001647 recv_parameters_.extensions.push_back(
1648 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
1649 recv_parameters_.extensions.push_back(
1650 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
1651 recv_parameters_.extensions.push_back(
1652 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001653
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001654 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02001655 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001656 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
1657
1658 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02001659 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001660
1661 // Setting the same extensions (even if in different order) shouldn't
1662 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001663 std::reverse(recv_parameters_.extensions.begin(),
1664 recv_parameters_.extensions.end());
1665 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001666
1667 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
1668
1669 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001670 recv_parameters_.extensions.resize(1);
1671 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00001672
1673 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
1674}
1675
eladalonf1841382017-06-12 01:16:46 -07001676TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001677 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001678 const int kUnsupportedId = 1;
1679 const int kTOffsetId = 2;
1680
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001681 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001682 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001683 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001684 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001685 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001686 FakeVideoSendStream* send_stream =
1687 AddSendStream(cricket::StreamParams::CreateLegacy(123));
1688
1689 // Only timestamp offset extension is set to send stream,
1690 // unsupported rtp extension is ignored.
1691 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07001692 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
1693 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001694}
1695
eladalonf1841382017-06-12 01:16:46 -07001696TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001697 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001698 const int kUnsupportedId = 1;
1699 const int kTOffsetId = 2;
1700
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001701 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001702 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001703 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001704 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001705 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001706 FakeVideoReceiveStream* recv_stream =
1707 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
1708
1709 // Only timestamp offset extension is set to receive stream,
1710 // unsupported rtp extension is ignored.
1711 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07001712 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
1713 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001714}
1715
eladalonf1841382017-06-12 01:16:46 -07001716TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02001717 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00001718 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07001719 send_parameters_.extensions.push_back(
1720 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001721 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001722 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
1723 }
1724}
1725
eladalonf1841382017-06-12 01:16:46 -07001726TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02001727 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00001728 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07001729 recv_parameters_.extensions.push_back(
1730 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001731 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001732 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
1733 }
1734}
1735
eladalonf1841382017-06-12 01:16:46 -07001736TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001737 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001738 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001739 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001740 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001741 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001742 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001743
1744 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001745 send_parameters_.extensions.clear();
1746 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001747 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001748 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
1749 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001750}
1751
eladalonf1841382017-06-12 01:16:46 -07001752TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001753 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001754 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001755 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001756 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001757 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001758 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001759
1760 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001761 recv_parameters_.extensions.clear();
1762 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07001763 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001764 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
1765 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00001766}
1767
eladalonf1841382017-06-12 01:16:46 -07001768TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001769 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001770 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001771}
1772
eladalonf1841382017-06-12 01:16:46 -07001773TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02001774 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07001775 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02001776}
1777
eladalonf1841382017-06-12 01:16:46 -07001778TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00001779 FakeVideoReceiveStream* stream = AddRecvStream();
1780 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001781}
1782
eladalonf1841382017-06-12 01:16:46 -07001783TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08001784 FakeVideoReceiveStream* stream = AddRecvStream();
1785 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
1786}
1787
eladalonf1841382017-06-12 01:16:46 -07001788TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00001789 FakeVideoReceiveStream* stream = AddRecvStream();
1790 EXPECT_TRUE(stream->GetConfig().rtp.remb);
1791
Peter Boström126c03e2015-05-11 12:48:12 +02001792 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001793 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08001794 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001795 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
1796 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001797 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00001798 EXPECT_FALSE(stream->GetConfig().rtp.remb);
1799
1800 // Verify that REMB is turned on when setting default codecs since the
1801 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001802 parameters.codecs = engine_.codecs();
1803 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001804 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00001805 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001806}
1807
eladalonf1841382017-06-12 01:16:46 -07001808TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08001809 FakeVideoReceiveStream* stream = AddRecvStream();
1810 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
1811
1812 // Verify that transport cc feedback is turned off when send(!) codecs without
1813 // transport cc feedback are set.
1814 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08001815 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08001816 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
1817 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1818 stream = fake_call_->GetVideoReceiveStreams()[0];
1819 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
1820
1821 // Verify that transport cc feedback is turned on when setting default codecs
1822 // since the default codecs have transport cc feedback enabled.
1823 parameters.codecs = engine_.codecs();
1824 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1825 stream = fake_call_->GetVideoReceiveStreams()[0];
1826 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
1827}
1828
eladalonf1841382017-06-12 01:16:46 -07001829TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00001830 VerifyCodecHasDefaultFeedbackParams(default_codec_);
1831
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001832 cricket::VideoSendParameters parameters;
1833 parameters.codecs = engine_.codecs();
1834 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00001835 EXPECT_TRUE(channel_->SetSend(true));
1836
1837 // Send side.
1838 FakeVideoSendStream* send_stream =
1839 AddSendStream(cricket::StreamParams::CreateLegacy(1));
1840 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
1841
1842 // Receiver side.
1843 FakeVideoReceiveStream* recv_stream =
1844 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
1845 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
1846
1847 // Nack history size should match between sender and receiver.
1848 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
1849 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001850}
1851
eladalonf1841382017-06-12 01:16:46 -07001852TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02001853 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02001854 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02001855
1856 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
1857 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
1858
1859 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001860 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08001861 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001862 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
1863 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02001864 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
1865 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
1866 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00001867 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
1868
Peter Boström67c9df72015-05-11 14:34:58 +02001869 // Verify that NACK is turned on when setting default codecs since the
1870 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001871 parameters.codecs = engine_.codecs();
1872 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02001873 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
1874 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
1875 send_stream = fake_call_->GetVideoSendStreams()[0];
1876 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00001877}
1878
Peter Boströme7ba0862016-03-12 00:02:28 +01001879// This test verifies that new frame sizes reconfigures encoders even though not
1880// (yet) sending. The purpose of this is to permit encoding as quickly as
1881// possible once we start sending. Likely the frames being input are from the
1882// same source that will be sent later, which just means that we're ready
1883// earlier.
eladalonf1841382017-06-12 01:16:46 -07001884TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01001885 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08001886 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01001887 ASSERT_TRUE(channel_->SetSendParameters(parameters));
1888 channel_->SetSend(false);
1889
1890 FakeVideoSendStream* stream = AddSendStream();
1891
perkjfa10b552016-10-02 23:45:26 -07001892 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01001893 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07001894 EXPECT_EQ(0u, streams[0].width);
1895 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01001896
Tommi85959932018-02-07 19:26:06 +01001897 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02001898 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07001899 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
1900 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01001901 EXPECT_TRUE(capturer.CaptureFrame());
1902
1903 // Frame entered, should be reconfigured to new dimensions.
1904 streams = stream->GetVideoStreams();
perkj26752742016-10-24 01:21:16 -07001905 EXPECT_EQ(capture_format.width, streams[0].width);
1906 EXPECT_EQ(capture_format.height, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01001907
Niels Möllerff40b142018-04-09 08:49:14 +02001908 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01001909}
1910
eladalonf1841382017-06-12 01:16:46 -07001911TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00001912 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08001913 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001914 cricket::VideoSendParameters parameters;
1915 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001916 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00001917 AddSendStream();
1918
Tommi85959932018-02-07 19:26:06 +01001919 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07001920 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01001921 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möllerff40b142018-04-09 08:49:14 +02001922 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
deadbeef5a4a75a2016-06-02 16:23:38 -07001923 &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00001924 cricket::VideoFormat capture_format_hd =
1925 capturer.GetSupportedFormats()->front();
1926 EXPECT_EQ(1280, capture_format_hd.width);
1927 EXPECT_EQ(720, capture_format_hd.height);
1928 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
1929
1930 EXPECT_TRUE(channel_->SetSend(true));
1931
1932 EXPECT_TRUE(capturer.CaptureFrame());
1933 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
1934 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
1935
1936 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
1937
1938 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07001939 webrtc::VideoEncoderConfig encoder_config =
1940 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02001941 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00001942 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07001943 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
1944 EXPECT_EQ(capture_format_hd.width, streams.front().width);
1945 EXPECT_EQ(capture_format_hd.height, streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00001946 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
1947 << "Non-screenshare shouldn't use min-transmit bitrate.";
1948
Niels Möllerff40b142018-04-09 08:49:14 +02001949 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08001950 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07001951 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01001952 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07001953 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02001954 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08001955 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08001956 // Send stream recreated after option change.
1957 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
1958 send_stream = fake_call_->GetVideoSendStreams().front();
1959 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00001960
1961 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07001962 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02001963 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00001964 encoder_config.content_type);
1965 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
1966 encoder_config.min_transmit_bitrate_bps);
1967
perkjfa10b552016-10-02 23:45:26 -07001968 streams = send_stream->GetVideoStreams();
1969 EXPECT_EQ(capture_format_hd.width, streams.front().width);
1970 EXPECT_EQ(capture_format_hd.height, streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01001971 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02001972 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00001973}
1974
eladalonf1841382017-06-12 01:16:46 -07001975TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00001976 ConferenceModeScreencastConfiguresTemporalLayer) {
Erik Språng2c4c9142015-06-24 11:24:44 +02001977 static const int kConferenceScreencastTemporalBitrateBps =
1978 ScreenshareLayerConfig::GetDefault().tl0_bitrate_kbps * 1000;
nisse4b4dc862016-02-17 05:25:36 -08001979 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001980 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00001981
1982 AddSendStream();
nisse05103312016-03-16 02:22:50 -07001983 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01001984 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01001985 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02001986 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00001987 cricket::VideoFormat capture_format_hd =
1988 capturer.GetSupportedFormats()->front();
1989 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
1990
1991 EXPECT_TRUE(channel_->SetSend(true));
1992
1993 EXPECT_TRUE(capturer.CaptureFrame());
1994 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
1995 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
1996
perkj26091b12016-09-01 01:17:40 -07001997 webrtc::VideoEncoderConfig encoder_config =
1998 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00001999
2000 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002001 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002002 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002003 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002004
2005 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2006 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002007 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002008 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002009 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002010
Niels Möllerff40b142018-04-09 08:49:14 +02002011 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002012}
2013
eladalonf1841382017-06-12 01:16:46 -07002014TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002015 FakeVideoSendStream* stream = AddSendStream();
2016 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2017}
2018
eladalonf1841382017-06-12 01:16:46 -07002019TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002020 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002021 media_config.video.suspend_below_min_bitrate = true;
2022
2023 channel_.reset(
2024 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002025 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002026
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002027 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002028
2029 FakeVideoSendStream* stream = AddSendStream();
2030 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2031
nisse0db023a2016-03-01 04:29:59 -08002032 media_config.video.suspend_below_min_bitrate = false;
2033 channel_.reset(
2034 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002035 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002036
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002037 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002038
nisse0db023a2016-03-01 04:29:59 -08002039 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002040 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2041}
2042
eladalonf1841382017-06-12 01:16:46 -07002043TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002044 FakeVideoSendStream* stream = AddSendStream();
2045 webrtc::VideoCodecVP8 vp8_settings;
2046 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2047 EXPECT_TRUE(vp8_settings.denoisingOn);
2048}
2049
eladalonf1841382017-06-12 01:16:46 -07002050TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002051 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002052 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002053 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002054
Peter Boström2feafdb2015-09-09 14:32:14 +02002055 // Single-stream settings should apply with RTX as well (verifies that we
2056 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2057 // both RTX and regular SSRCs).
2058 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002059
Tommi85959932018-02-07 19:26:06 +01002060 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002061 EXPECT_EQ(cricket::CS_RUNNING,
2062 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002063 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002064 channel_->SetSend(true);
2065
2066 EXPECT_TRUE(capturer.CaptureFrame());
2067
pbos4cba4eb2015-10-26 11:18:18 -07002068 webrtc::VideoCodecVP8 vp8_settings;
2069 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2070 EXPECT_TRUE(vp8_settings.denoisingOn)
2071 << "VP8 denoising should be on by default.";
2072
nisse05103312016-03-16 02:22:50 -07002073 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002074
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002075 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2076 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002077 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2078 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002079
nisse05103312016-03-16 02:22:50 -07002080 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002081
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002082 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2083 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002084 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2085 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2086
Niels Möllerff40b142018-04-09 08:49:14 +02002087 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002088 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002089 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002090 channel_->SetSend(true);
2091 EXPECT_TRUE(capturer.CaptureFrame());
2092
2093 EXPECT_EQ(3, stream->GetVideoStreams().size());
2094 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2095 // Autmatic resize off when using simulcast.
2096 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2097 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2098
2099 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002100 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002101 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002102 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002103
nisse05103312016-03-16 02:22:50 -07002104 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002105
2106 EXPECT_EQ(1, stream->GetVideoStreams().size());
2107 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2108 EXPECT_FALSE(vp8_settings.denoisingOn);
2109 // Resizing and frame dropping always off for screen sharing.
2110 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2111 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2112
nisse05103312016-03-16 02:22:50 -07002113 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002114
2115 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2116 EXPECT_FALSE(vp8_settings.denoisingOn);
2117 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2118 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2119
Niels Möllerff40b142018-04-09 08:49:14 +02002120 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002121}
2122
deadbeef119760a2016-04-04 11:43:27 -07002123// Test that setting the same options doesn't result in the encoder being
2124// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002125TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002126 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002127 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002128
perkjfa10b552016-10-02 23:45:26 -07002129 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002130 EXPECT_EQ(cricket::CS_RUNNING,
2131 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002132 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002133 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002134 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2135 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2136
Niels Möllerff40b142018-04-09 08:49:14 +02002137 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2138 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002139 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002140 // Expect 1 reconfigurations at this point from the initial configuration.
2141 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002142
2143 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002144 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002145 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2146
2147 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002148 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002149 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002150 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2151
Niels Möllerff40b142018-04-09 08:49:14 +02002152 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002153}
2154
eladalonf1841382017-06-12 01:16:46 -07002155class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002156 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002157 Vp9SettingsTest() : Vp9SettingsTest("") {}
2158 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002159 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002160 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002161 }
2162 virtual ~Vp9SettingsTest() {}
2163
2164 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002165 void TearDown() override {
2166 // Remove references to encoder_factory_ since this will be destroyed
2167 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002168 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002169 }
Erik Språng143cec12015-04-28 10:01:41 +02002170};
2171
2172TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002173 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002174 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002175 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002176
Peter Boström2feafdb2015-09-09 14:32:14 +02002177 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002178
Tommi85959932018-02-07 19:26:06 +01002179 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002180 EXPECT_EQ(cricket::CS_RUNNING,
2181 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002182 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002183 channel_->SetSend(true);
2184
2185 EXPECT_TRUE(capturer.CaptureFrame());
2186
pbos4cba4eb2015-10-26 11:18:18 -07002187 webrtc::VideoCodecVP9 vp9_settings;
2188 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002189 EXPECT_TRUE(vp9_settings.denoisingOn)
2190 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07002191
nisse05103312016-03-16 02:22:50 -07002192 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002193
Erik Språng143cec12015-04-28 10:01:41 +02002194 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2195 EXPECT_FALSE(vp9_settings.denoisingOn);
2196 // Frame dropping always on for real time video.
2197 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2198
nisse05103312016-03-16 02:22:50 -07002199 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002200
2201 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2202 EXPECT_TRUE(vp9_settings.denoisingOn);
2203 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2204
2205 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07002206 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002207 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002208 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002209
nisse05103312016-03-16 02:22:50 -07002210 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002211
2212 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2213 EXPECT_FALSE(vp9_settings.denoisingOn);
2214 // Frame dropping always off for screen sharing.
2215 EXPECT_FALSE(vp9_settings.frameDroppingOn);
2216
nisse05103312016-03-16 02:22:50 -07002217 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002218
2219 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2220 EXPECT_FALSE(vp9_settings.denoisingOn);
2221 EXPECT_FALSE(vp9_settings.frameDroppingOn);
2222
Niels Möllerff40b142018-04-09 08:49:14 +02002223 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002224}
2225
Sergey Silkinf18072e2018-03-14 10:35:35 +01002226TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
2227 cricket::VideoSendParameters parameters;
2228 parameters.codecs.push_back(GetEngineCodec("VP9"));
2229 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2230
2231 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
2232
2233 FakeVideoSendStream* stream =
2234 AddSendStream(CreateSimStreamParams("cname", ssrcs));
2235
2236 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2237 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
2238
2239 FakeVideoCapturerWithTaskQueue capturer;
2240 EXPECT_EQ(cricket::CS_RUNNING,
2241 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002242 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01002243 channel_->SetSend(true);
2244
2245 EXPECT_TRUE(capturer.CaptureFrame());
2246
2247 webrtc::VideoCodecVP9 vp9_settings;
2248 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2249
2250 const size_t kNumSpatialLayers = ssrcs.size();
2251 const size_t kNumTemporalLayers = 3;
2252 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
2253 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
2254
Niels Möllerff40b142018-04-09 08:49:14 +02002255 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01002256}
2257
asaperssonc5dabdd2016-03-21 04:15:50 -07002258class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
2259 public:
brandtr468da7c2016-11-22 02:16:47 -08002260 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07002261 : Vp9SettingsTest(field_trials) {}
2262
2263 protected:
2264 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
2265 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002266 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07002267 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2268
2269 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
2270
Tommi85959932018-02-07 19:26:06 +01002271 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07002272 EXPECT_EQ(cricket::CS_RUNNING,
2273 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002274 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07002275 channel_->SetSend(true);
2276
2277 EXPECT_TRUE(capturer.CaptureFrame());
2278
2279 webrtc::VideoCodecVP9 vp9_settings;
2280 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2281 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
2282 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
2283
Niels Möllerff40b142018-04-09 08:49:14 +02002284 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07002285 }
2286};
2287
2288class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
2289 public:
2290 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
2291};
2292
2293TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
2294 const int kNumSpatialLayers = 1;
2295 const int kNumTemporalLayers = 1;
2296 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
2297}
2298
2299class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
2300 public:
2301 Vp9SettingsTestWithInvalidFlag()
2302 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
2303};
2304
2305TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
2306 const int kNumSpatialLayers = 1;
2307 const int kNumTemporalLayers = 1;
2308 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
2309}
2310
2311class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
2312 public:
2313 Vp9SettingsTestWith2SL3TLFlag()
2314 : Vp9SettingsTestWithFieldTrial(
2315 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
2316};
2317
2318TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
2319 const int kNumSpatialLayers = 2;
2320 const int kNumTemporalLayers = 3;
2321 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
2322}
2323
Åsa Persson45bbc8a2017-11-13 10:16:47 +01002324TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
2325 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
2326 ASSERT_EQ(1u, streams.size());
2327 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
2328}
2329
2330TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
2331 webrtc::test::ScopedFieldTrials override_field_trials_(
2332 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
2333 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
2334 ASSERT_EQ(1u, streams.size());
2335 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
2336}
2337
asapersson3c81a1a2017-06-14 05:52:21 -07002338TEST_F(WebRtcVideoChannelTest,
2339 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
2340 webrtc::test::ScopedFieldTrials override_field_trials_(
2341 "WebRTC-Video-BalancedDegradation/Disabled/");
2342 const bool kResolutionScalingEnabled = true;
2343 const bool kFpsScalingEnabled = false;
2344 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
2345}
2346
2347TEST_F(WebRtcVideoChannelTest,
2348 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
2349 webrtc::test::ScopedFieldTrials override_field_trials_(
2350 "WebRTC-Video-BalancedDegradation/Enabled/");
2351 const bool kResolutionScalingEnabled = true;
2352 const bool kFpsScalingEnabled = true;
2353 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
2354}
2355
eladalonf1841382017-06-12 01:16:46 -07002356TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02002357 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002358}
2359
eladalonf1841382017-06-12 01:16:46 -07002360TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02002361 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002362}
2363
eladalonf1841382017-06-12 01:16:46 -07002364TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02002365 TestCpuAdaptation(true, true);
2366}
2367
eladalonf1841382017-06-12 01:16:46 -07002368TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08002369 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08002370 cricket::VideoSendParameters parameters;
2371 parameters.codecs.push_back(codec);
2372
kthelgason2bc68642017-02-07 07:02:22 -08002373 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08002374 channel_.reset(
2375 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002376 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08002377 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2378
2379 AddSendStream();
2380
Tommi85959932018-02-07 19:26:06 +01002381 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002382 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002383 ASSERT_EQ(cricket::CS_RUNNING,
2384 capturer.Start(capturer.GetSupportedFormats()->front()));
2385 ASSERT_TRUE(channel_->SetSend(true));
2386
2387 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2388 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08002389
Niels Möllera6cc0f92018-02-12 17:14:55 +01002390 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08002391 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2392 EXPECT_EQ(1280, send_stream->GetLastWidth());
2393 EXPECT_EQ(720, send_stream->GetLastHeight());
2394
2395 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07002396 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07002397 wants.max_pixel_count =
2398 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07002399 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01002400 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08002401 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
2402 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
2403 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
2404
2405 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07002406 wants.max_pixel_count =
2407 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07002408 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01002409 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08002410 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
2411 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
2412 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
2413
2414 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01002415 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07002416 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08002417 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
2418 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
2419
2420 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08002421 int current_pixel_count =
2422 send_stream->GetLastWidth() * send_stream->GetLastHeight();
2423 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
2424 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07002425 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08002426 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01002427 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07002428 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01002429 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07002430 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08002431 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
2432 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
2433
sprang84a37592017-02-10 07:04:27 -08002434 // Trigger underuse again, should go back up to full resolution.
2435 current_pixel_count =
2436 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07002437 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01002438 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07002439 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01002440 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07002441 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08002442 EXPECT_EQ(1284, send_stream->GetLastWidth());
2443 EXPECT_EQ(724, send_stream->GetLastHeight());
2444
Niels Möllerff40b142018-04-09 08:49:14 +02002445 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08002446}
2447
eladalonf1841382017-06-12 01:16:46 -07002448TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08002449 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02002450 cricket::VideoSendParameters parameters;
2451 parameters.codecs.push_back(codec);
2452
kthelgason2bc68642017-02-07 07:02:22 -08002453 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01002454 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02002455 channel_.reset(
2456 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002457 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02002458 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2459
2460 AddSendStream();
2461
Tommi85959932018-02-07 19:26:06 +01002462 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02002463 ASSERT_EQ(cricket::CS_RUNNING,
2464 capturer.Start(capturer.GetSupportedFormats()->front()));
2465 ASSERT_TRUE(channel_->SetSend(true));
2466 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002467 camera_options.is_screencast = false;
Niels Möllerff40b142018-04-09 08:49:14 +02002468 channel_->SetVideoSend(last_ssrc_, &camera_options,
deadbeef5a4a75a2016-06-02 16:23:38 -07002469 &capturer);
Per766ad3b2016-04-05 15:23:49 +02002470
2471 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2472 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02002473
Niels Möllera6cc0f92018-02-12 17:14:55 +01002474 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02002475 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2476 EXPECT_EQ(1280, send_stream->GetLastWidth());
2477 EXPECT_EQ(720, send_stream->GetLastHeight());
2478
2479 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07002480 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07002481 wants.max_pixel_count =
2482 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07002483 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01002484 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02002485 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
2486 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
2487 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
2488
2489 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01002490 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02002491 ASSERT_EQ(cricket::CS_RUNNING,
2492 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02002493 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002494 screenshare_options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002495 channel_->SetVideoSend(last_ssrc_, &screenshare_options,
deadbeef5a4a75a2016-06-02 16:23:38 -07002496 &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01002497 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08002498 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2499 send_stream = fake_call_->GetVideoSendStreams().front();
2500 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02002501 EXPECT_EQ(1284, send_stream->GetLastWidth());
2502 EXPECT_EQ(724, send_stream->GetLastHeight());
2503
2504 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Niels Möllerff40b142018-04-09 08:49:14 +02002505 channel_->SetVideoSend(last_ssrc_, &camera_options,
deadbeef5a4a75a2016-06-02 16:23:38 -07002506 &capturer);
sprangf24a0642017-02-28 13:23:26 -08002507 send_stream = fake_call_->GetVideoSendStreams().front();
2508 // We have a new fake send stream, so it doesn't remember the old sink wants.
2509 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07002510 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08002511 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01002512 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08002513 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
2514 send_stream = fake_call_->GetVideoSendStreams().front();
2515 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02002516 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
2517 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
2518
Niels Möllerff40b142018-04-09 08:49:14 +02002519 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02002520}
2521
asapersson3c81a1a2017-06-14 05:52:21 -07002522// TODO(asapersson): Remove this test when the balanced field trial is removed.
2523void WebRtcVideoChannelTest::TestDegradationPreference(
2524 bool resolution_scaling_enabled,
2525 bool fps_scaling_enabled) {
2526 cricket::VideoCodec codec = GetEngineCodec("VP8");
2527 cricket::VideoSendParameters parameters;
2528 parameters.codecs.push_back(codec);
2529
2530 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01002531 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07002532 channel_.reset(
2533 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
2534 channel_->OnReadyToSend(true);
2535
2536 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2537
2538 AddSendStream();
2539
Tommi85959932018-02-07 19:26:06 +01002540 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07002541 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02002542 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07002543 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2544 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
2545
2546 EXPECT_TRUE(channel_->SetSend(true));
2547
2548 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2549 EXPECT_EQ(resolution_scaling_enabled,
2550 send_stream->resolution_scaling_enabled());
2551 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
2552
Niels Möllerff40b142018-04-09 08:49:14 +02002553 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07002554}
2555
eladalonf1841382017-06-12 01:16:46 -07002556void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
2557 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07002558 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08002559 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002560 cricket::VideoSendParameters parameters;
2561 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08002562
kthelgason2bc68642017-02-07 07:02:22 -08002563 MediaConfig media_config = GetMediaConfig();
2564 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01002565 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002566 }
nisse51542be2016-02-12 02:27:06 -08002567 channel_.reset(
2568 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002569 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08002570
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002571 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002572
2573 AddSendStream();
2574
Tommi85959932018-02-07 19:26:06 +01002575 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002576 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002577 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02002578 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07002579 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07002580 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07002581 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002582
2583 EXPECT_TRUE(channel_->SetSend(true));
2584
solenberge5269742015-09-08 05:13:22 -07002585 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08002586
sprangc5d62e22017-04-02 23:53:04 -07002587 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07002588 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07002589 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
2590 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08002591
2592 EXPECT_TRUE(capturer.CaptureFrame());
2593 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2594
perkj26752742016-10-24 01:21:16 -07002595 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
2596 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08002597
Niels Möllerff40b142018-04-09 08:49:14 +02002598 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08002599 return;
2600 }
2601
sprangc5d62e22017-04-02 23:53:04 -07002602 if (is_screenshare) {
2603 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
2604 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
2605 } else {
2606 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
2607 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
2608 }
2609
perkj803d97f2016-11-01 11:45:46 -07002610 // Trigger overuse.
2611 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2612
2613 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07002614 if (is_screenshare) {
2615 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
2616 } else {
2617 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
2618 }
perkj803d97f2016-11-01 11:45:46 -07002619 send_stream->InjectVideoSinkWants(wants);
2620
sprangc5d62e22017-04-02 23:53:04 -07002621 for (int i = 0; i < kDefaultFps; ++i)
2622 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002623
sprangc5d62e22017-04-02 23:53:04 -07002624 if (is_screenshare) {
2625 // Drops every third frame.
2626 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
2627 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
2628 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
2629 } else {
2630 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
2631 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
2632 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
2633 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002634
2635 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08002636 int last_pixel_count =
2637 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07002638 if (is_screenshare) {
2639 wants.max_framerate_fps = kDefaultFps;
2640 } else {
2641 wants.max_pixel_count = last_pixel_count * 4;
2642 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
2643 }
perkj803d97f2016-11-01 11:45:46 -07002644 send_stream->InjectVideoSinkWants(wants);
2645
sprangc5d62e22017-04-02 23:53:04 -07002646 for (int i = 0; i < kDefaultFps; ++i)
2647 EXPECT_TRUE(capturer.CaptureFrame());
2648
2649 if (is_screenshare) {
2650 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
2651 send_stream->GetNumberOfSwappedFrames());
2652 } else {
2653 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
2654 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002655
perkj26752742016-10-24 01:21:16 -07002656 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
2657 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002658
Niels Möllerff40b142018-04-09 08:49:14 +02002659 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002660}
2661
eladalonf1841382017-06-12 01:16:46 -07002662TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002663 // Start at last timestamp to verify that wraparounds are estimated correctly.
2664 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
2665 static const int64_t kInitialNtpTimeMs = 1247891230;
2666 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002667 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002668
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002669 FakeVideoReceiveStream* stream = AddRecvStream();
2670 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08002671 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002672
nisse64ec8f82016-09-27 00:17:25 -07002673 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
2674 kInitialTimestamp, 0,
2675 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002676 // Initial NTP time is not available on the first frame, but should still be
2677 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07002678 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002679
2680 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002681
2682 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
2683 // triggers a constant-overflow warning, hence we're calculating it explicitly
2684 // here.
2685 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
2686 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07002687 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002688
2689 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002690
2691 // Verify that NTP time has been correctly deduced.
2692 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00002693 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00002694 ASSERT_EQ(1u, info.receivers.size());
2695 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002696}
2697
eladalonf1841382017-06-12 01:16:46 -07002698TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002699 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002700
2701 VideoCodec codec;
2702 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00002703 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002704
2705 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002706 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2707 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002708 FakeVideoSendStream* stream = AddSendStream(
2709 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07002710 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002711
2712 // Make sure NACK and FEC are enabled on the correct payload types.
2713 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08002714 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
2715 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00002716
2717 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
2718 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08002719 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002720 // TODO(juberti): Check RTCP, PLI, TMMBR.
2721}
2722
brandtr31bd2242017-05-19 05:47:46 -07002723// The following four tests ensures that FlexFEC is not activated by default
2724// when the field trials are not enabled.
2725// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
2726// default.
eladalonf1841382017-06-12 01:16:46 -07002727TEST_F(WebRtcVideoChannelTest,
brandtr31bd2242017-05-19 05:47:46 -07002728 FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08002729 FakeVideoSendStream* stream = AddSendStream();
2730 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2731
brandtr3d200bd2017-01-16 06:59:19 -08002732 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07002733 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
2734 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08002735}
2736
eladalonf1841382017-06-12 01:16:46 -07002737TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08002738 FakeVideoSendStream* stream = AddSendStream(
2739 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
2740 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2741
brandtr3d200bd2017-01-16 06:59:19 -08002742 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07002743 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
2744 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
2745}
2746
eladalonf1841382017-06-12 01:16:46 -07002747TEST_F(WebRtcVideoChannelTest,
brandtr31bd2242017-05-19 05:47:46 -07002748 FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
2749 AddRecvStream();
2750
2751 const std::vector<FakeFlexfecReceiveStream*>& streams =
2752 fake_call_->GetFlexfecReceiveStreams();
2753 EXPECT_TRUE(streams.empty());
2754}
2755
eladalonf1841382017-06-12 01:16:46 -07002756TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07002757 AddRecvStream(
2758 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
2759
2760 const std::vector<FakeFlexfecReceiveStream*>& streams =
2761 fake_call_->GetFlexfecReceiveStreams();
2762 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08002763}
2764
2765// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
2766// tests that use this test fixture into the corresponding "non-field trial"
2767// tests.
eladalonf1841382017-06-12 01:16:46 -07002768class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08002769 public:
eladalonf1841382017-06-12 01:16:46 -07002770 WebRtcVideoChannelFlexfecRecvTest()
2771 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08002772};
2773
eladalonf1841382017-06-12 01:16:46 -07002774TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08002775 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
2776 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
2777 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
2778}
2779
eladalonf1841382017-06-12 01:16:46 -07002780TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07002781 AddRecvStream();
2782
2783 const std::vector<FakeFlexfecReceiveStream*>& streams =
2784 fake_call_->GetFlexfecReceiveStreams();
2785 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01002786
2787 const std::vector<FakeVideoReceiveStream*>& video_streams =
2788 fake_call_->GetVideoReceiveStreams();
2789 ASSERT_EQ(1U, video_streams.size());
2790 const FakeVideoReceiveStream& video_stream = *video_streams.front();
2791 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
2792 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07002793}
2794
eladalonf1841382017-06-12 01:16:46 -07002795TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07002796 AddRecvStream(
2797 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
2798
2799 const std::vector<FakeFlexfecReceiveStream*>& streams =
2800 fake_call_->GetFlexfecReceiveStreams();
2801 ASSERT_EQ(1U, streams.size());
2802 const FakeFlexfecReceiveStream* stream = streams.front();
2803 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
2804 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
2805 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
2806 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
2807 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07002808
2809 const std::vector<FakeVideoReceiveStream*>& video_streams =
2810 fake_call_->GetVideoReceiveStreams();
2811 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01002812 const FakeVideoReceiveStream& video_stream = *video_streams.front();
2813 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07002814 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01002815 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07002816 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07002817}
2818
eladalonf1841382017-06-12 01:16:46 -07002819TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07002820 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
2821 cricket::VideoRecvParameters recv_parameters;
2822 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
2823 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
2824
2825 AddRecvStream(
2826 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
2827 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01002828 const std::vector<FakeVideoReceiveStream*>& video_streams =
2829 fake_call_->GetVideoReceiveStreams();
2830 ASSERT_EQ(1U, video_streams.size());
2831 const FakeVideoReceiveStream& video_stream = *video_streams.front();
2832 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
2833 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07002834
2835 // Enable FlexFEC.
2836 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
2837 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
2838 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
2839 << "Enabling FlexFEC should create FlexfecReceiveStream.";
2840 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
2841 << "Enabling FlexFEC should not create VideoReceiveStream.";
2842 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
2843 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01002844 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
2845 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07002846}
2847
eladalonf1841382017-06-12 01:16:46 -07002848TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07002849 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
2850 cricket::VideoRecvParameters recv_parameters;
2851 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
2852 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
2853 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
2854
2855 AddRecvStream(
2856 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
2857 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07002858 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01002859 const std::vector<FakeVideoReceiveStream*>& video_streams =
2860 fake_call_->GetVideoReceiveStreams();
2861 ASSERT_EQ(1U, video_streams.size());
2862 const FakeVideoReceiveStream& video_stream = *video_streams.front();
2863 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
2864 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07002865
2866 // Disable FlexFEC.
2867 recv_parameters.codecs.clear();
2868 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
2869 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
2870 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
2871 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
2872 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
2873 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
2874 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
2875 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01002876 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
2877 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07002878}
2879
brandtr31bd2242017-05-19 05:47:46 -07002880// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
2881// tests that use this test fixture into the corresponding "non-field trial"
2882// tests.
eladalonf1841382017-06-12 01:16:46 -07002883class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07002884 public:
eladalonf1841382017-06-12 01:16:46 -07002885 WebRtcVideoChannelFlexfecSendRecvTest()
2886 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07002887 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
2888 }
2889};
2890
eladalonf1841382017-06-12 01:16:46 -07002891TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07002892 SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08002893 FakeVideoSendStream* stream = AddSendStream();
2894 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2895
brandtr3d200bd2017-01-16 06:59:19 -08002896 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
2897 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
2898 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08002899}
2900
eladalonf1841382017-06-12 01:16:46 -07002901TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08002902 FakeVideoSendStream* stream = AddSendStream(
2903 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
2904 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2905
brandtr3d200bd2017-01-16 06:59:19 -08002906 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
2907 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
2908 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
2909 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08002910}
2911
eladalonf1841382017-06-12 01:16:46 -07002912TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002913 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002914 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002915 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002916
2917 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07002918 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002919
brandtrb5f2c3f2016-10-04 23:28:39 -07002920 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
2921 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002922}
2923
eladalonf1841382017-06-12 01:16:46 -07002924TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08002925 cricket::VideoSendParameters parameters;
2926 parameters.codecs.push_back(GetEngineCodec("VP8"));
2927 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2928
2929 FakeVideoSendStream* stream = AddSendStream();
2930 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2931
brandtr3d200bd2017-01-16 06:59:19 -08002932 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08002933}
2934
eladalonf1841382017-06-12 01:16:46 -07002935TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08002936 AddRecvStream(
2937 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08002938
2939 cricket::VideoRecvParameters recv_parameters;
2940 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
2941 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
2942 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08002943
2944 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
2945 fake_call_->GetFlexfecReceiveStreams();
2946 ASSERT_EQ(1U, flexfec_streams.size());
2947 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
2948 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
2949 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08002950 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08002951 flexfec_stream_config.payload_type);
2952 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
2953 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
2954 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
2955 const std::vector<FakeVideoReceiveStream*>& video_streams =
2956 fake_call_->GetVideoReceiveStreams();
2957 const FakeVideoReceiveStream* video_stream = video_streams.front();
2958 const webrtc::VideoReceiveStream::Config& video_stream_config =
2959 video_stream->GetConfig();
2960 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
2961 flexfec_stream_config.local_ssrc);
2962 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
2963 EXPECT_EQ(video_stream_config.rtcp_send_transport,
2964 flexfec_stream_config.rtcp_send_transport);
2965 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
2966 // spec-compliant way.
2967 EXPECT_EQ(video_stream_config.rtp.transport_cc,
2968 flexfec_stream_config.transport_cc);
2969 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
2970 EXPECT_EQ(video_stream_config.rtp.extensions,
2971 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08002972}
2973
brandtr31bd2242017-05-19 05:47:46 -07002974// We should not send FlexFEC, even if we advertise it, unless the right
2975// field trial is set.
2976// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07002977TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07002978 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
2979 cricket::VideoSendParameters parameters;
2980 parameters.codecs.push_back(GetEngineCodec("VP8"));
2981 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
2982 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2983
2984 FakeVideoSendStream* stream = AddSendStream();
2985 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2986
2987 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
2988 EXPECT_EQ(0, config.rtp.flexfec.ssrc);
2989 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
2990}
2991
eladalonf1841382017-06-12 01:16:46 -07002992TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07002993 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
2994 cricket::VideoSendParameters parameters;
2995 parameters.codecs.push_back(GetEngineCodec("VP8"));
2996 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
2997 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2998
2999 FakeVideoSendStream* stream = AddSendStream(
3000 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3001 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3002
3003 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
3004 EXPECT_EQ(0, config.rtp.flexfec.ssrc);
3005 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3006}
3007
eladalonf1841382017-06-12 01:16:46 -07003008TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003009 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003010 const int kUnusedPayloadType = 127;
3011 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3012
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003013 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003014 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003015 parameters.codecs.push_back(rtx_codec);
3016 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003017 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003018}
3019
eladalonf1841382017-06-12 01:16:46 -07003020TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003021 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003022 const int kUnusedPayloadType1 = 126;
3023 const int kUnusedPayloadType2 = 127;
3024 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3025 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3026 {
3027 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3028 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3029 cricket::VideoSendParameters parameters;
3030 parameters.codecs.push_back(GetEngineCodec("VP8"));
3031 parameters.codecs.push_back(rtx_codec);
3032 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3033 }
3034 {
3035 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3036 kUnusedPayloadType1, kUnusedPayloadType2);
3037 cricket::VideoSendParameters parameters;
3038 parameters.codecs.push_back(GetEngineCodec("VP8"));
3039 parameters.codecs.push_back(rtx_codec);
3040 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3041 << "RTX without matching video codec should be rejected.";
3042 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003043}
3044
eladalonf1841382017-06-12 01:16:46 -07003045TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003046 const int kUnusedPayloadType1 = 126;
3047 const int kUnusedPayloadType2 = 127;
3048 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3049 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3050
3051 // SSRCs for RTX.
3052 cricket::StreamParams params =
3053 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3054 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3055 AddSendStream(params);
3056
3057 // Original payload type for RTX.
3058 cricket::VideoSendParameters parameters;
3059 parameters.codecs.push_back(GetEngineCodec("VP8"));
3060 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3061 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3062 parameters.codecs.push_back(rtx_codec);
3063 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3064 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3065 const webrtc::VideoSendStream::Config& config_before =
3066 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3067 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3068 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3069 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3070
3071 // Change payload type for RTX.
3072 parameters.codecs[1].id = kUnusedPayloadType2;
3073 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3074 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3075 const webrtc::VideoSendStream::Config& config_after =
3076 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3077 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3078 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3079 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3080}
3081
eladalonf1841382017-06-12 01:16:46 -07003082TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003083 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003084 parameters.codecs.push_back(GetEngineCodec("VP8"));
3085 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003086 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003087
3088 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003089 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003090
magjed509e4fe2016-11-18 01:34:11 -08003091 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003092
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003093 parameters.codecs.pop_back();
3094 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003095 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003096 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003097 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003098 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003099 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3100}
3101
eladalonf1841382017-06-12 01:16:46 -07003102TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003103 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003104 cricket::VideoSendParameters parameters;
3105 parameters.codecs.push_back(GetEngineCodec("VP8"));
3106 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3107 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3108
3109 FakeVideoSendStream* stream = AddSendStream(
3110 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3111 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3112
brandtr3d200bd2017-01-16 06:59:19 -08003113 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3114 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003115 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3116 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3117
3118 parameters.codecs.pop_back();
3119 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3120 stream = fake_call_->GetVideoSendStreams()[0];
3121 ASSERT_TRUE(stream != nullptr);
3122 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003123 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003124 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003125}
3126
eladalonf1841382017-06-12 01:16:46 -07003127TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003128 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003129 cricket::VideoCodec codec(100, "VP8");
3130 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3131 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003132
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003133 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003134 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003135
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003136 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003137 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003138 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003139
3140 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003141 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003142
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003143 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003144 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3145 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003146 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003147 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003148 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003149 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003150}
3151
eladalonf1841382017-06-12 01:16:46 -07003152TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003153 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3154 200000);
3155}
3156
eladalonf1841382017-06-12 01:16:46 -07003157TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003158 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3159 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3160 ASSERT_EQ(1u, streams.size());
3161 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3162}
3163
eladalonf1841382017-06-12 01:16:46 -07003164TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003165 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003166 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003167}
3168
eladalonf1841382017-06-12 01:16:46 -07003169TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003170 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003171}
3172
eladalonf1841382017-06-12 01:16:46 -07003173TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003174 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3175 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3176 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003177}
3178
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003179// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3180// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003181TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003182 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3183 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3184 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3185 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003186 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003187 ExpectSetBitrateParameters(100000, 200000, 400000);
3188 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3189 // Since the codec isn't changing, start_bitrate_bps should be -1.
3190 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003191
3192 // Decrease max_bandwidth_bps.
3193 send_parameters_.max_bandwidth_bps = 350000;
3194 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003195
3196 // Now try again with the values flipped around.
3197 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3198 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003199 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003200 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003201
3202 // If we change the codec max, max_bandwidth_bps should still apply.
3203 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003204 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003205 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003206}
3207
eladalonf1841382017-06-12 01:16:46 -07003208TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003209 SetMaxSendBandwidthShouldPreserveOtherBitrates) {
3210 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3211 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003212 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003213 // Setting max bitrate should keep previous min bitrate.
3214 // Setting max bitrate should not reset start bitrate.
3215 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003216 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00003217}
3218
eladalonf1841382017-06-12 01:16:46 -07003219TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003220 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003221 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003222 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08003223 // -1 means to disable max bitrate (set infinite).
3224 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003225 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003226 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003227}
3228
eladalonf1841382017-06-12 01:16:46 -07003229TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07003230 send_parameters_.max_bandwidth_bps = 99999;
3231 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003232 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003233 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07003234 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3235 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3236 stream->GetVideoStreams()[0].max_bitrate_bps);
3237
3238 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003239 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003240 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3241 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07003242 stream->GetVideoStreams()[0].max_bitrate_bps);
3243}
3244
eladalonf1841382017-06-12 01:16:46 -07003245TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003246 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003247 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003248 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003249 channel_->SetSend(true);
3250
3251 FakeVideoSendStream* stream = AddSendStream();
3252
Tommi85959932018-02-07 19:26:06 +01003253 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003254 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01003255 EXPECT_EQ(cricket::CS_RUNNING,
3256 capturer.Start(capturer.GetSupportedFormats()->front()));
3257
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003258 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
3259 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
3260 EXPECT_GT(initial_max_bitrate_bps, 0);
3261
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003262 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
3263 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01003264 // Insert a frame to update the encoder config.
3265 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003266 streams = stream->GetVideoStreams();
3267 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02003268 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003269}
3270
eladalonf1841382017-06-12 01:16:46 -07003271TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003272 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003273 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003274 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003275 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003276 channel_->SetSend(true);
3277
3278 FakeVideoSendStream* stream = AddSendStream(
3279 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
3280
3281 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01003282 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003283 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003284 EXPECT_EQ(cricket::CS_RUNNING,
3285 capturer.Start(capturer.GetSupportedFormats()->front()));
3286 EXPECT_TRUE(capturer.CaptureFrame());
3287
3288 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
3289 ASSERT_GT(streams.size(), 1u)
3290 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07003291 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003292 EXPECT_GT(initial_max_bitrate_bps, 0);
3293
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003294 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
3295 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01003296 // Insert a frame to update the encoder config.
3297 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003298 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07003299 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003300 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
3301
Niels Möllerff40b142018-04-09 08:49:14 +02003302 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01003303}
3304
eladalonf1841382017-06-12 01:16:46 -07003305TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003306 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003307 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003308 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003309 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
3310 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00003311 EXPECT_EQ(static_cast<unsigned int>(atoi(kMaxQuantization)),
3312 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003313
3314 VideoCodec codec;
3315 EXPECT_TRUE(channel_->GetSendCodec(&codec));
3316 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
3317}
3318
eladalonf1841382017-06-12 01:16:46 -07003319TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003320 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00003321 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003322 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003323 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00003324 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003325 parameters.codecs[0].id = kIncorrectPayloads[i];
3326 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00003327 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003328 }
3329}
3330
eladalonf1841382017-06-12 01:16:46 -07003331TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003332 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003333 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08003334 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003335 parameters.codecs[0].id = payload_type;
3336 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003337 << "Payload type '" << payload_type << "' rejected.";
3338 }
3339}
3340
deadbeef67cf2c12016-04-13 10:07:16 -07003341// Test that setting the a different set of codecs but with an identical front
3342// codec doesn't result in the stream being recreated.
3343// This may happen when a subsequent negotiation includes fewer codecs, as a
3344// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07003345TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07003346 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
3347 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08003348 parameters1.codecs.push_back(GetEngineCodec("VP8"));
3349 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07003350 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
3351
3352 AddSendStream();
3353 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
3354
3355 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08003356 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07003357 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
3358 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
3359}
3360
eladalonf1841382017-06-12 01:16:46 -07003361TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003362 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003363 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003364 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003365}
3366
pbos@webrtc.orge322a172014-06-13 11:47:28 +00003367// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07003368TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08003369 const int kUnusedPayloadType1 = 126;
3370 const int kUnusedPayloadType2 = 127;
3371 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3372 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3373
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003374 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003375 parameters.codecs.push_back(GetEngineCodec("VP8"));
3376 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003377 parameters.codecs.push_back(rtx_codec);
3378 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00003379 << "RTX codec without associated payload should be rejected.";
3380
magjed509e4fe2016-11-18 01:34:11 -08003381 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003382 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00003383 << "RTX codec with invalid associated payload type should be rejected.";
3384
magjed509e4fe2016-11-18 01:34:11 -08003385 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003386 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00003387
magjed509e4fe2016-11-18 01:34:11 -08003388 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00003389 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003390 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00003391
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003392 EXPECT_FALSE(channel_->SetRecvParameters(parameters)) <<
3393 "RTX codec with another RTX as associated payload type should be "
3394 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00003395}
3396
eladalonf1841382017-06-12 01:16:46 -07003397TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003398 const int kUnusedPayloadType1 = 126;
3399 const int kUnusedPayloadType2 = 127;
3400 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3401 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3402
3403 // SSRCs for RTX.
3404 cricket::StreamParams params =
3405 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3406 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3407 AddRecvStream(params);
3408
3409 // Original payload type for RTX.
3410 cricket::VideoRecvParameters parameters;
3411 parameters.codecs.push_back(GetEngineCodec("VP8"));
3412 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3413 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3414 parameters.codecs.push_back(rtx_codec);
3415 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
3416 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
3417 const webrtc::VideoReceiveStream::Config& config_before =
3418 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07003419 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
3420 const int* payload_type_before = FindKeyByValue(
3421 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
3422 ASSERT_NE(payload_type_before, nullptr);
3423 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08003424 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
3425
3426 // Change payload type for RTX.
3427 parameters.codecs[1].id = kUnusedPayloadType2;
3428 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
3429 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
3430 const webrtc::VideoReceiveStream::Config& config_after =
3431 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07003432 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
3433 const int* payload_type_after = FindKeyByValue(
3434 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
3435 ASSERT_NE(payload_type_after, nullptr);
3436 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08003437 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
3438}
3439
eladalonf1841382017-06-12 01:16:46 -07003440TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003441 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003442 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003443 parameters.codecs[0].id = 99;
3444 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003445}
3446
eladalonf1841382017-06-12 01:16:46 -07003447TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003448 cricket::VideoRecvParameters parameters;
3449 parameters.codecs = engine_.codecs();
3450 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00003451
3452 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02003453 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00003454 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].payload_name);
3455 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003456}
3457
eladalonf1841382017-06-12 01:16:46 -07003458TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003459 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003460 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07003461 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003462 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003463}
3464
eladalonf1841382017-06-12 01:16:46 -07003465TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003466 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003467 parameters.codecs.push_back(GetEngineCodec("VP8"));
3468 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003469 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003470}
3471
eladalonf1841382017-06-12 01:16:46 -07003472TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003473 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08003474 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
3475 send_parameters.codecs.push_back(GetEngineCodec("red"));
3476 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003477 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00003478
3479 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00003480
magjed509e4fe2016-11-18 01:34:11 -08003481 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07003482 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00003483
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003484 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08003485 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003486 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003487 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003488 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07003489 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003490 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3491}
3492
eladalonf1841382017-06-12 01:16:46 -07003493TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003494 AddRecvStream(
3495 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003496 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08003497 fake_call_->GetFlexfecReceiveStreams();
3498
3499 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08003500 const FakeFlexfecReceiveStream* stream = streams.front();
3501 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
3502 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
3503 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
3504 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003505
3506 cricket::VideoRecvParameters recv_parameters;
3507 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3508 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3509 EXPECT_TRUE(streams.empty())
3510 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003511}
3512
eladalonf1841382017-06-12 01:16:46 -07003513TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02003514 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08003515 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07003516 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02003517
3518 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08003519 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3520 recv_parameters.codecs.push_back(GetEngineCodec("red"));
3521 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02003522 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3523 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003524 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08003525 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07003526 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003527 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02003528
3529 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08003530 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
3531 send_parameters.codecs.push_back(GetEngineCodec("red"));
3532 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02003533 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3534 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08003535 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07003536 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003537 << "ULPFEC should be enabled on the receive stream.";
3538}
3539
eladalonf1841382017-06-12 01:16:46 -07003540TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003541 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003542 AddRecvStream(
3543 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003544 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08003545 fake_call_->GetFlexfecReceiveStreams();
3546
3547 cricket::VideoRecvParameters recv_parameters;
3548 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3549 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3550 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3551 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08003552 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08003553 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08003554 stream_with_recv_params->GetConfig().payload_type);
3555 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003556 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08003557 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08003558 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08003559 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003560
3561 cricket::VideoSendParameters send_parameters;
3562 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
3563 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3564 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3565 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08003566 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08003567 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08003568 stream_with_send_params->GetConfig().payload_type);
3569 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003570 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08003571 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08003572 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08003573 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02003574}
3575
eladalonf1841382017-06-12 01:16:46 -07003576TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003577 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003578 parameters.codecs.push_back(GetEngineCodec("VP8"));
3579 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003580 parameters.codecs[1].id = parameters.codecs[0].id;
3581 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003582}
3583
eladalonf1841382017-06-12 01:16:46 -07003584TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003585 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08003586 cricket::VideoRecvParameters parameters;
3587 parameters.codecs.push_back(GetEngineCodec("VP8"));
3588 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3589 parameters.codecs[1].id = parameters.codecs[0].id;
3590 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
3591}
3592
eladalonf1841382017-06-12 01:16:46 -07003593TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003594 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003595 parameters.codecs.push_back(GetEngineCodec("VP8"));
3596 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003597 parameters.codecs[1].id = parameters.codecs[0].id;
3598 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003599}
3600
eladalonf1841382017-06-12 01:16:46 -07003601TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003602 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003603 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003604 parameters.codecs.push_back(GetEngineCodec("VP8"));
3605 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003606 parameters.codecs[1].id += 1;
3607 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003608}
3609
deadbeef67cf2c12016-04-13 10:07:16 -07003610// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07003611// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07003612TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07003613 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003614 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08003615 parameters1.codecs.push_back(GetEngineCodec("VP8"));
3616 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003617 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07003618
3619 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
3620 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
3621
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003622 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08003623 parameters2.codecs.push_back(GetEngineCodec("red"));
3624 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003625 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07003626 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
3627}
3628
eladalonf1841382017-06-12 01:16:46 -07003629TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003630 EXPECT_FALSE(AddSendStream()->IsSending());
3631}
3632
eladalonf1841382017-06-12 01:16:46 -07003633TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00003634 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003635}
3636
eladalonf1841382017-06-12 01:16:46 -07003637TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00003638 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003639 EXPECT_FALSE(stream->IsSending());
3640
3641 // false->true
3642 EXPECT_TRUE(channel_->SetSend(true));
3643 EXPECT_TRUE(stream->IsSending());
3644 // true->true
3645 EXPECT_TRUE(channel_->SetSend(true));
3646 EXPECT_TRUE(stream->IsSending());
3647 // true->false
3648 EXPECT_TRUE(channel_->SetSend(false));
3649 EXPECT_FALSE(stream->IsSending());
3650 // false->false
3651 EXPECT_TRUE(channel_->SetSend(false));
3652 EXPECT_FALSE(stream->IsSending());
3653
3654 EXPECT_TRUE(channel_->SetSend(true));
3655 FakeVideoSendStream* new_stream = AddSendStream();
3656 EXPECT_TRUE(new_stream->IsSending())
3657 << "Send stream created after SetSend(true) not sending initially.";
3658}
3659
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00003660// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07003661TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08003662 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00003663 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08003664 MediaConfig config;
kwiberg686a8ef2016-02-26 03:00:35 -08003665 std::unique_ptr<VideoMediaChannel> channel;
nisse51542be2016-02-12 02:27:06 -08003666
3667 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
3668 channel->SetInterface(network_interface.get());
3669 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00003670 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08003671
3672 config.enable_dscp = true;
3673 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
3674 channel->SetInterface(network_interface.get());
3675 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
3676
3677 // Verify that setting the option to false resets the
3678 // DiffServCodePoint.
3679 config.enable_dscp = false;
3680 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
3681 channel->SetInterface(network_interface.get());
3682 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003683}
3684
deadbeef13871492015-12-09 12:37:51 -08003685// This test verifies that the RTCP reduced size mode is properly applied to
3686// send video streams.
eladalonf1841382017-06-12 01:16:46 -07003687TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08003688 // Create stream, expecting that default mode is "compound".
3689 FakeVideoSendStream* stream1 = AddSendStream();
3690 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
3691
3692 // Now enable reduced size mode.
3693 send_parameters_.rtcp.reduced_size = true;
3694 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3695 stream1 = fake_call_->GetVideoSendStreams()[0];
3696 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
3697
3698 // Create a new stream and ensure it picks up the reduced size mode.
3699 FakeVideoSendStream* stream2 = AddSendStream();
3700 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
3701}
3702
3703// This test verifies that the RTCP reduced size mode is properly applied to
3704// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07003705TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08003706 // Create stream, expecting that default mode is "compound".
3707 FakeVideoReceiveStream* stream1 = AddRecvStream();
3708 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
3709
3710 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07003711 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
3712 // the reduced_size flag should come from that.
3713 send_parameters_.rtcp.reduced_size = true;
3714 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08003715 stream1 = fake_call_->GetVideoReceiveStreams()[0];
3716 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
3717
3718 // Create a new stream and ensure it picks up the reduced size mode.
3719 FakeVideoReceiveStream* stream2 = AddRecvStream();
3720 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
3721}
3722
eladalonf1841382017-06-12 01:16:46 -07003723TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07003724 EXPECT_EQ(webrtc::kNetworkUp,
3725 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
3726 EXPECT_EQ(webrtc::kNetworkUp,
3727 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00003728
3729 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07003730 EXPECT_EQ(webrtc::kNetworkDown,
3731 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
3732 EXPECT_EQ(webrtc::kNetworkUp,
3733 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00003734
3735 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07003736 EXPECT_EQ(webrtc::kNetworkUp,
3737 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
3738 EXPECT_EQ(webrtc::kNetworkUp,
3739 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003740}
3741
eladalonf1841382017-06-12 01:16:46 -07003742TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003743 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003744 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003745 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01003746
3747 AddSendStream();
3748
3749 cricket::VideoMediaInfo info;
3750 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08003751 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01003752}
3753
eladalonf1841382017-06-12 01:16:46 -07003754TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01003755 FakeVideoSendStream* stream = AddSendStream();
3756 webrtc::VideoSendStream::Stats stats;
3757 stats.encoder_implementation_name = "encoder_implementation_name";
3758 stream->SetStats(stats);
3759
3760 cricket::VideoMediaInfo info;
3761 ASSERT_TRUE(channel_->GetStats(&info));
3762 EXPECT_EQ(stats.encoder_implementation_name,
3763 info.senders[0].encoder_implementation_name);
3764}
3765
eladalonf1841382017-06-12 01:16:46 -07003766TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00003767 FakeVideoSendStream* stream = AddSendStream();
3768 webrtc::VideoSendStream::Stats stats;
3769 stats.avg_encode_time_ms = 13;
3770 stats.encode_usage_percent = 42;
3771 stream->SetStats(stats);
3772
3773 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003774 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00003775 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
3776 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
3777}
3778
eladalonf1841382017-06-12 01:16:46 -07003779TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07003780 FakeVideoSendStream* stream = AddSendStream();
3781 webrtc::VideoSendStream::Stats stats;
3782 stats.frames_encoded = 13;
3783 stream->SetStats(stats);
3784
3785 cricket::VideoMediaInfo info;
3786 ASSERT_TRUE(channel_->GetStats(&info));
3787 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
3788}
3789
eladalonf1841382017-06-12 01:16:46 -07003790TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07003791 FakeVideoSendStream* stream = AddSendStream();
3792 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01003793 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07003794 stream->SetStats(stats);
3795
3796 cricket::VideoMediaInfo info;
3797 ASSERT_TRUE(channel_->GetStats(&info));
3798 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
3799}
3800
eladalonf1841382017-06-12 01:16:46 -07003801TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00003802 FakeVideoSendStream* stream = AddSendStream();
3803 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00003804 stats.substreams[17].width = 123;
3805 stats.substreams[17].height = 40;
3806 stats.substreams[42].width = 80;
3807 stats.substreams[42].height = 31;
3808 stats.substreams[11].width = 20;
3809 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00003810 stream->SetStats(stats);
3811
3812 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003813 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00003814 ASSERT_EQ(1u, info.senders.size());
3815 EXPECT_EQ(123, info.senders[0].send_frame_width);
3816 EXPECT_EQ(90, info.senders[0].send_frame_height);
3817}
3818
eladalonf1841382017-06-12 01:16:46 -07003819TEST_F(WebRtcVideoChannelTest, GetStatsReportsPreferredBitrate) {
Pera48ddb72016-09-29 11:48:50 +02003820 FakeVideoSendStream* stream = AddSendStream();
3821 webrtc::VideoSendStream::Stats stats;
3822 stats.preferred_media_bitrate_bps = 5;
3823 stream->SetStats(stats);
3824
3825 cricket::VideoMediaInfo info;
3826 ASSERT_TRUE(channel_->GetStats(&info));
3827 ASSERT_EQ(1u, info.senders.size());
3828 EXPECT_EQ(5, info.senders[0].preferred_bitrate);
3829}
3830
eladalonf1841382017-06-12 01:16:46 -07003831TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07003832 FakeVideoSendStream* stream = AddSendStream();
3833 webrtc::VideoSendStream::Stats stats;
3834 stats.number_of_cpu_adapt_changes = 2;
3835 stats.cpu_limited_resolution = true;
3836 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00003837
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00003838 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003839 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00003840 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07003841 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07003842 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00003843}
3844
eladalonf1841382017-06-12 01:16:46 -07003845TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07003846 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08003847 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07003848 stats.number_of_cpu_adapt_changes = 2;
3849 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08003850 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07003851 stream->SetStats(stats);
3852
3853 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08003854 EXPECT_TRUE(channel_->GetStats(&info));
3855 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07003856 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
3857 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08003858 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07003859 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08003860}
3861
eladalonf1841382017-06-12 01:16:46 -07003862TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08003863 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
3864 FakeVideoSendStream* stream = AddSendStream();
3865 webrtc::VideoSendStream::Stats stats;
3866 stats.bw_limited_resolution = true;
3867 stream->SetStats(stats);
3868
3869 cricket::VideoMediaInfo info;
3870 EXPECT_TRUE(channel_->GetStats(&info));
3871 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07003872 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08003873 info.senders[0].adapt_reason);
3874}
3875
eladalonf1841382017-06-12 01:16:46 -07003876TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00003877 GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
3878 FakeVideoSendStream* stream = AddSendStream();
3879 webrtc::VideoSendStream::Stats stats;
3880 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
3881 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
3882 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
3883
3884 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
3885 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
3886 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
3887
3888 stream->SetStats(stats);
3889
3890 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003891 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00003892 EXPECT_EQ(7, info.senders[0].firs_rcvd);
3893 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
3894 EXPECT_EQ(13, info.senders[0].plis_rcvd);
3895}
3896
eladalonf1841382017-06-12 01:16:46 -07003897TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00003898 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
3899 FakeVideoReceiveStream* stream = AddRecvStream();
3900 webrtc::VideoReceiveStream::Stats stats;
3901 stats.rtcp_packet_type_counts.fir_packets = 2;
3902 stats.rtcp_packet_type_counts.nack_packets = 3;
3903 stats.rtcp_packet_type_counts.pli_packets = 4;
3904 stream->SetStats(stats);
3905
3906 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003907 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00003908 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
3909 info.receivers[0].firs_sent);
3910 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
3911 info.receivers[0].nacks_sent);
3912 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
3913 info.receivers[0].plis_sent);
3914}
3915
eladalonf1841382017-06-12 01:16:46 -07003916TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00003917 FakeVideoReceiveStream* stream = AddRecvStream();
3918 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01003919 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00003920 stats.decode_ms = 2;
3921 stats.max_decode_ms = 3;
3922 stats.current_delay_ms = 4;
3923 stats.target_delay_ms = 5;
3924 stats.jitter_buffer_ms = 6;
3925 stats.min_playout_delay_ms = 7;
3926 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07003927 stats.width = 9;
3928 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08003929 stats.frame_counts.key_frames = 11;
3930 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08003931 stats.frames_rendered = 13;
3932 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01003933 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00003934 stream->SetStats(stats);
3935
3936 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003937 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01003938 EXPECT_EQ(stats.decoder_implementation_name,
3939 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00003940 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
3941 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
3942 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
3943 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
3944 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
3945 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
3946 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07003947 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
3948 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
hbos42f6d2f2017-01-20 03:56:50 -08003949 EXPECT_EQ(stats.frame_counts.key_frames + stats.frame_counts.delta_frames,
3950 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08003951 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07003952 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08003953 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00003954}
3955
eladalonf1841382017-06-12 01:16:46 -07003956TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02003957 FakeVideoReceiveStream* stream = AddRecvStream();
3958 webrtc::VideoReceiveStream::Stats stats;
3959 stats.rtp_stats.transmitted.payload_bytes = 2;
3960 stats.rtp_stats.transmitted.header_bytes = 3;
3961 stats.rtp_stats.transmitted.padding_bytes = 4;
3962 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07003963 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02003964 stats.rtcp_stats.fraction_lost = 7;
3965 stream->SetStats(stats);
3966
3967 cricket::VideoMediaInfo info;
3968 ASSERT_TRUE(channel_->GetStats(&info));
3969 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
3970 stats.rtp_stats.transmitted.header_bytes +
3971 stats.rtp_stats.transmitted.padding_bytes,
3972 info.receivers[0].bytes_rcvd);
3973 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
3974 info.receivers[0].packets_rcvd);
srte186d9c32017-08-04 05:03:53 -07003975 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02003976 EXPECT_EQ(static_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
3977 info.receivers[0].fraction_lost);
3978}
3979
eladalonf1841382017-06-12 01:16:46 -07003980TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00003981 AddSendStream();
3982 AddSendStream();
3983 webrtc::Call::Stats stats;
3984 stats.rtt_ms = 123;
3985 fake_call_->SetStats(stats);
3986
3987 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003988 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00003989 ASSERT_EQ(2u, info.senders.size());
3990 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
3991 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
3992}
3993
eladalonf1841382017-06-12 01:16:46 -07003994TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00003995 FakeVideoSendStream* stream = AddSendStream();
3996 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00003997 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00003998 stats.media_bitrate_bps = 123;
3999 stats.substreams[17].total_bitrate_bps = 1;
4000 stats.substreams[17].retransmit_bitrate_bps = 2;
4001 stats.substreams[42].total_bitrate_bps = 3;
4002 stats.substreams[42].retransmit_bitrate_bps = 4;
4003 stream->SetStats(stats);
4004
4005 FakeVideoSendStream* stream2 = AddSendStream();
4006 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004007 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004008 stats2.media_bitrate_bps = 321;
4009 stats2.substreams[13].total_bitrate_bps = 5;
4010 stats2.substreams[13].retransmit_bitrate_bps = 6;
4011 stats2.substreams[21].total_bitrate_bps = 7;
4012 stats2.substreams[21].retransmit_bitrate_bps = 8;
4013 stream2->SetStats(stats2);
4014
4015 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004016 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004017 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004018 BandwidthEstimationInfo bwe_info;
4019 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004020 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4021 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4022 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4023 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004024 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004025 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004026 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004027 bwe_info.actual_enc_bitrate);
4028 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004029 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004030 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004031 << "Bandwidth stats should take all streams into account.";
4032}
4033
eladalonf1841382017-06-12 01:16:46 -07004034TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004035 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004036
Peter Boström0c4e06b2015-10-07 12:23:21 +02004037 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4038 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004039
4040 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4041 const size_t kDataLength = 12;
4042 uint8_t data[kDataLength];
4043 memset(data, 0, sizeof(data));
4044 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004045 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004046 rtc::PacketTime packet_time;
4047 channel_->OnPacketReceived(&packet, packet_time);
4048
4049 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4050 << "No default receive stream created.";
4051 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004052 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004053 << "Default receive stream should not have configured RTX";
4054
4055 EXPECT_TRUE(channel_->AddRecvStream(
4056 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4057 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004058 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004059 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004060 EXPECT_FALSE(
4061 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004062 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004063 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004064 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
4065 GetEngineCodec("red").id))
4066 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004067 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004068}
4069
eladalonf1841382017-06-12 01:16:46 -07004070TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004071 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004072
Peter Boström0c4e06b2015-10-07 12:23:21 +02004073 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4074 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004075
4076 StreamParams sp =
4077 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4078 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4079
4080 EXPECT_FALSE(channel_->AddSendStream(sp));
4081 EXPECT_FALSE(channel_->AddRecvStream(sp));
4082}
4083
eladalonf1841382017-06-12 01:16:46 -07004084TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004085 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004086
Peter Boström0c4e06b2015-10-07 12:23:21 +02004087 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4088 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004089
4090 StreamParams sp =
4091 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4092
4093 EXPECT_TRUE(channel_->AddSendStream(sp));
4094 EXPECT_TRUE(channel_->AddRecvStream(sp));
4095
4096 // The RTX SSRC is already used in previous streams, using it should fail.
4097 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4098 EXPECT_FALSE(channel_->AddSendStream(sp));
4099 EXPECT_FALSE(channel_->AddRecvStream(sp));
4100
4101 // After removing the original stream this should be fine to add (makes sure
4102 // that RTX ssrcs are not forever taken).
4103 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4104 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4105 EXPECT_TRUE(channel_->AddSendStream(sp));
4106 EXPECT_TRUE(channel_->AddRecvStream(sp));
4107}
4108
eladalonf1841382017-06-12 01:16:46 -07004109TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004110 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004111 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4112 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004113 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004114
Peter Boströmd6f4c252015-03-26 16:23:04 +01004115 StreamParams sp =
4116 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4117
4118 EXPECT_TRUE(channel_->AddSendStream(sp));
4119 EXPECT_TRUE(channel_->AddRecvStream(sp));
4120
4121 // One of the SSRCs is already used in previous streams, using it should fail.
4122 sp = cricket::CreateSimStreamParams("cname",
4123 MAKE_VECTOR(kOverlappingStreamSsrcs));
4124 EXPECT_FALSE(channel_->AddSendStream(sp));
4125 EXPECT_FALSE(channel_->AddRecvStream(sp));
4126
4127 // After removing the original stream this should be fine to add (makes sure
4128 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02004129 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
4130 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004131 EXPECT_TRUE(channel_->AddSendStream(sp));
4132 EXPECT_TRUE(channel_->AddRecvStream(sp));
4133}
4134
eladalonf1841382017-06-12 01:16:46 -07004135TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004136 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02004137
4138 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
4139 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
4140
4141 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
4142 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
4143
4144 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
4145
4146 static const uint32_t kReceiverSsrcs[] = {3};
4147 static const uint32_t kReceiverRtxSsrcs[] = {2};
4148
4149 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
4150 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
4151 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
4152
4153 cricket::VideoMediaInfo info;
4154 ASSERT_TRUE(channel_->GetStats(&info));
4155
4156 ASSERT_EQ(1u, info.senders.size());
4157 ASSERT_EQ(1u, info.receivers.size());
4158
4159 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
4160 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
4161 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
4162}
4163
eladalonf1841382017-06-12 01:16:46 -07004164TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07004165 FakeVideoReceiveStream* stream = AddRecvStream();
4166 webrtc::VideoReceiveStream::Stats stats;
4167 cricket::VideoMediaInfo info;
4168
4169 // Report no codec name before receiving.
4170 stream->SetStats(stats);
4171 ASSERT_TRUE(channel_->GetStats(&info));
4172 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4173
4174 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08004175 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07004176 stream->SetStats(stats);
4177 ASSERT_TRUE(channel_->GetStats(&info));
4178 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
4179
4180 // Report no codec name for unknown playload types.
4181 stats.current_payload_type = 3;
4182 stream->SetStats(stats);
4183 ASSERT_TRUE(channel_->GetStats(&info));
4184 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4185}
4186
Seth Hampson5897a6e2018-04-03 11:16:33 -07004187// Tests that when we add a stream without SSRCs, but contains a stream_id
4188// that it is stored and its stream id is later used when the first packet
4189// arrives to properly create a receive stream with a sync label.
4190TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
4191 const char kSyncLabel[] = "sync_label";
4192 cricket::StreamParams unsignaled_stream;
4193 unsignaled_stream.set_stream_ids({kSyncLabel});
4194 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
4195 // The stream shouldn't have been created at this point because it doesn't
4196 // have any SSRCs.
4197 EXPECT_EQ(0, fake_call_->GetVideoReceiveStreams().size());
4198
4199 // Create and deliver packet.
4200 const size_t kDataLength = 12;
4201 uint8_t data[kDataLength];
4202 memset(data, 0, sizeof(data));
4203 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
4204 rtc::CopyOnWriteBuffer packet(data, kDataLength);
4205 rtc::PacketTime packet_time;
4206 channel_->OnPacketReceived(&packet, packet_time);
4207
4208 // The stream should now be created with the appropriate sync label.
4209 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4210 EXPECT_EQ(kSyncLabel,
4211 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
4212
4213 // Removing the unsignaled stream should clear the cache. This time when
4214 // a default video receive stream is created it won't have a sync_group.
4215 ASSERT_TRUE(channel_->RemoveRecvStream(0));
4216 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
4217 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4218
4219 channel_->OnPacketReceived(&packet, packet_time);
4220 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4221 EXPECT_TRUE(
4222 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
4223}
4224
eladalonf1841382017-06-12 01:16:46 -07004225void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07004226 uint8_t payload_type,
4227 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08004228 // kRedRtxPayloadType must currently be unused.
4229 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
4230
noahricd10a68e2015-07-10 11:27:55 -07004231 // Add a RED RTX codec.
4232 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08004233 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004234 recv_parameters_.codecs.push_back(red_rtx_codec);
4235 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07004236
4237 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4238 const size_t kDataLength = 12;
4239 uint8_t data[kDataLength];
4240 memset(data, 0, sizeof(data));
4241
4242 rtc::Set8(data, 1, payload_type);
4243 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07004244 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07004245 rtc::PacketTime packet_time;
4246 channel_->OnPacketReceived(&packet, packet_time);
4247
4248 if (expect_created_receive_stream) {
4249 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4250 << "Should have created a receive stream for payload type: "
4251 << payload_type;
4252 } else {
4253 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
4254 << "Shouldn't have created a receive stream for payload type: "
4255 << payload_type;
4256 }
4257}
4258
eladalonf1841382017-06-12 01:16:46 -07004259TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08004260 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
4261 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07004262}
4263
eladalonf1841382017-06-12 01:16:46 -07004264TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08004265 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
4266 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07004267}
4268
eladalonf1841382017-06-12 01:16:46 -07004269TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08004270 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
4271 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
4272 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
4273 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07004274}
4275
eladalonf1841382017-06-12 01:16:46 -07004276TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08004277 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
4278 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07004279}
4280
eladalonf1841382017-06-12 01:16:46 -07004281TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08004282 FlexfecPacketDoesntCreateUnsignalledStream) {
4283 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
4284 false /* expect_created_receive_stream */);
4285}
4286
eladalonf1841382017-06-12 01:16:46 -07004287TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08004288 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
4289 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07004290}
4291
mzanaty8a855d62017-02-17 15:46:43 -08004292// Test that receiving any unsignalled SSRC works even if it changes.
4293// The first unsignalled SSRC received will create a default receive stream.
4294// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07004295TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08004296 // Allow receiving VP8, VP9, H264 (if enabled).
4297 cricket::VideoRecvParameters parameters;
4298 parameters.codecs.push_back(GetEngineCodec("VP8"));
4299 parameters.codecs.push_back(GetEngineCodec("VP9"));
4300
4301#if defined(WEBRTC_USE_H264)
4302 cricket::VideoCodec H264codec(126, "H264");
4303 parameters.codecs.push_back(H264codec);
4304#endif
4305
4306 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4307 // No receive streams yet.
4308 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4309 cricket::FakeVideoRenderer renderer;
4310 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
4311
4312 // Receive VP8 packet on first SSRC.
4313 uint8_t data[kMinRtpPacketLen];
4314 cricket::RtpHeader rtpHeader;
4315 rtpHeader.payload_type = GetEngineCodec("VP8").id;
4316 rtpHeader.seq_num = rtpHeader.timestamp = 0;
4317 rtpHeader.ssrc = kIncomingUnsignalledSsrc+1;
4318 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
4319 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
4320 rtc::PacketTime packet_time;
4321 channel_->OnPacketReceived(&packet, packet_time);
4322 // VP8 packet should create default receive stream.
4323 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4324 FakeVideoReceiveStream* recv_stream =
4325 fake_call_->GetVideoReceiveStreams()[0];
4326 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
4327 // Verify that the receive stream sinks to a renderer.
4328 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
4329 webrtc::kVideoRotation_0);
4330 recv_stream->InjectFrame(video_frame);
4331 EXPECT_EQ(1, renderer.num_rendered_frames());
4332
4333 // Receive VP9 packet on second SSRC.
4334 rtpHeader.payload_type = GetEngineCodec("VP9").id;
4335 rtpHeader.ssrc = kIncomingUnsignalledSsrc+2;
4336 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
4337 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
4338 channel_->OnPacketReceived(&packet2, packet_time);
4339 // VP9 packet should replace the default receive SSRC.
4340 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4341 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
4342 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
4343 // Verify that the receive stream sinks to a renderer.
4344 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07004345 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08004346 recv_stream->InjectFrame(video_frame2);
4347 EXPECT_EQ(2, renderer.num_rendered_frames());
4348
4349#if defined(WEBRTC_USE_H264)
4350 // Receive H264 packet on third SSRC.
4351 rtpHeader.payload_type = 126;
4352 rtpHeader.ssrc = kIncomingUnsignalledSsrc+3;
4353 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
4354 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
4355 channel_->OnPacketReceived(&packet3, packet_time);
4356 // H264 packet should replace the default receive SSRC.
4357 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4358 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
4359 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
4360 // Verify that the receive stream sinks to a renderer.
4361 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07004362 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08004363 recv_stream->InjectFrame(video_frame3);
4364 EXPECT_EQ(3, renderer.num_rendered_frames());
4365#endif
4366}
4367
brandtr0dc57ea2017-05-29 23:33:31 -07004368// This test verifies that when a new default stream is created for a new
4369// unsignaled SSRC, the new stream does not overwrite any old stream that had
4370// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07004371TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07004372 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
4373 cricket::VideoRecvParameters parameters;
4374 parameters.codecs.push_back(GetEngineCodec("VP8"));
4375 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4376
4377 // No streams signaled and no packets received, so we should not have any
4378 // stream objects created yet.
4379 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4380
4381 // Receive packet on an unsignaled SSRC.
4382 uint8_t data[kMinRtpPacketLen];
4383 cricket::RtpHeader rtp_header;
4384 rtp_header.payload_type = GetEngineCodec("VP8").id;
4385 rtp_header.seq_num = rtp_header.timestamp = 0;
4386 rtp_header.ssrc = kSsrcs3[0];
4387 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
4388 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
4389 rtc::PacketTime packet_time;
4390 channel_->OnPacketReceived(&packet, packet_time);
4391 // Default receive stream should be created.
4392 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4393 FakeVideoReceiveStream* recv_stream0 =
4394 fake_call_->GetVideoReceiveStreams()[0];
4395 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
4396
4397 // Signal the SSRC.
4398 EXPECT_TRUE(
4399 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
4400 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4401 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
4402 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
4403
4404 // Receive packet on a different unsignaled SSRC.
4405 rtp_header.ssrc = kSsrcs3[1];
4406 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
4407 packet.SetData(data, sizeof(data));
4408 channel_->OnPacketReceived(&packet, packet_time);
4409 // New default receive stream should be created, but old stream should remain.
4410 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
4411 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
4412 FakeVideoReceiveStream* recv_stream1 =
4413 fake_call_->GetVideoReceiveStreams()[1];
4414 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
4415}
4416
eladalonf1841382017-06-12 01:16:46 -07004417TEST_F(WebRtcVideoChannelTest, CanSentMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07004418 AddSendStream();
4419
Tommi85959932018-02-07 19:26:06 +01004420 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004421 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07004422 cricket::VideoFormat capture_format_hd =
4423 capturer.GetSupportedFormats()->front();
4424 EXPECT_EQ(1280, capture_format_hd.width);
4425 EXPECT_EQ(720, capture_format_hd.height);
4426 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
4427 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07004428 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07004429
perkjfa10b552016-10-02 23:45:26 -07004430 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08004431 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07004432
4433 // TODO(skvlad): Resolve the inconsistency between the interpretation
4434 // of the global bitrate limit for audio and video:
4435 // - Audio: max_bandwidth_bps = 0 - fail the operation,
4436 // max_bandwidth_bps = -1 - remove the bandwidth limit
4437 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08004438 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07004439
perkjfa10b552016-10-02 23:45:26 -07004440 SetAndExpectMaxBitrate(1000, 0, 1000);
4441 SetAndExpectMaxBitrate(1000, 800, 800);
4442 SetAndExpectMaxBitrate(600, 800, 600);
4443 SetAndExpectMaxBitrate(0, 800, 800);
4444 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07004445
Niels Möllerff40b142018-04-09 08:49:14 +02004446 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07004447}
4448
eladalonf1841382017-06-12 01:16:46 -07004449TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07004450 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004451 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07004452 EXPECT_EQ(0, nonexistent_parameters.encodings.size());
4453
4454 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004455 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08004456 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07004457}
4458
eladalonf1841382017-06-12 01:16:46 -07004459TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004460 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07004461 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004462 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07004463 // Two or more encodings should result in failure.
4464 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08004465 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08004466 // Zero encodings should also fail.
4467 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08004468 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08004469}
4470
Zach Stein3ca452b2018-01-18 10:01:24 -08004471TEST_F(WebRtcVideoChannelTest,
4472 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
4473 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
4474 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
4475 AddSendStream(sp);
4476
4477 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4478
4479 // Additional encodings should result in failure.
4480 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08004481 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08004482 // Zero encodings should also fail.
4483 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08004484 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08004485}
4486
deadbeeffb2aced2017-01-06 23:05:37 -08004487// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07004488TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08004489 AddSendStream();
4490 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01004491 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08004492 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07004493}
4494
Seth Hampson24722b32017-12-22 09:36:42 -08004495// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
4496// a value <= 0, setting the parameters returns false.
4497TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
4498 AddSendStream();
4499 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4500 EXPECT_EQ(1UL, parameters.encodings.size());
4501 EXPECT_EQ(webrtc::kDefaultBitratePriority,
4502 parameters.encodings[0].bitrate_priority);
4503
4504 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08004505 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08004506 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08004507 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08004508}
4509
4510// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
4511// properly on the VideoChannel and propogates down to the video encoder.
4512TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
4513 AddSendStream();
4514 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4515 EXPECT_EQ(1UL, parameters.encodings.size());
4516 EXPECT_EQ(webrtc::kDefaultBitratePriority,
4517 parameters.encodings[0].bitrate_priority);
4518
4519 // Change the value and set it on the VideoChannel.
4520 double new_bitrate_priority = 2.0;
4521 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08004522 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08004523
4524 // Verify that the encoding parameters bitrate_priority is set for the
4525 // VideoChannel.
4526 parameters = channel_->GetRtpSendParameters(last_ssrc_);
4527 EXPECT_EQ(1UL, parameters.encodings.size());
4528 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
4529
4530 // Verify that the new value propagated down to the encoder.
4531 std::vector<FakeVideoSendStream*> video_send_streams =
4532 fake_call_->GetVideoSendStreams();
4533 EXPECT_EQ(1UL, video_send_streams.size());
4534 FakeVideoSendStream* video_send_stream = video_send_streams.front();
4535 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
4536 // appropriately.
4537 EXPECT_EQ(new_bitrate_priority,
4538 video_send_stream->GetEncoderConfig().bitrate_priority);
4539 // Check that the vector of VideoStreams also was propagated correctly. Note
4540 // that this is testing the behavior of the FakeVideoSendStream, which mimics
4541 // the calls to CreateEncoderStreams to get the VideoStreams.
4542 EXPECT_EQ(rtc::Optional<double>(new_bitrate_priority),
4543 video_send_stream->GetVideoStreams()[0].bitrate_priority);
4544}
4545
4546// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
4547// VideoChannel and the value propogates to the video encoder with all simulcast
4548// streams.
4549TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
4550 // Create the stream params with multiple ssrcs for simulcast.
4551 const int kNumSimulcastStreams = 3;
4552 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
4553 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
4554 AddSendStream(stream_params);
4555 uint32_t primary_ssrc = stream_params.first_ssrc();
4556
Tommi85959932018-02-07 19:26:06 +01004557 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
4558 // frame. This creates multiple VideoStreams for all simulcast layers when
4559 // reconfiguring, and allows us to test this behavior.
4560 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08004561 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02004562 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08004563 EXPECT_EQ(cricket::CS_RUNNING,
4564 capturer.Start(cricket::VideoFormat(
4565 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
4566 cricket::FOURCC_I420)));
4567 channel_->SetSend(true);
4568 EXPECT_TRUE(capturer.CaptureFrame());
4569 // Get and set the rtp encoding parameters.
4570 webrtc::RtpParameters parameters =
4571 channel_->GetRtpSendParameters(primary_ssrc);
Zach Stein3ca452b2018-01-18 10:01:24 -08004572 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08004573 EXPECT_EQ(webrtc::kDefaultBitratePriority,
4574 parameters.encodings[0].bitrate_priority);
4575 // Change the value and set it on the VideoChannel.
4576 double new_bitrate_priority = 2.0;
4577 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08004578 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08004579
4580 // Verify that the encoding parameters priority is set on the VideoChannel.
4581 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Zach Stein3ca452b2018-01-18 10:01:24 -08004582 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08004583 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
4584
4585 // Verify that the new value propagated down to the encoder.
4586 std::vector<FakeVideoSendStream*> video_send_streams =
4587 fake_call_->GetVideoSendStreams();
4588 EXPECT_EQ(1UL, video_send_streams.size());
4589 FakeVideoSendStream* video_send_stream = video_send_streams.front();
4590 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
4591 // appropriately.
4592 EXPECT_EQ(kNumSimulcastStreams,
4593 video_send_stream->GetEncoderConfig().number_of_streams);
4594 EXPECT_EQ(new_bitrate_priority,
4595 video_send_stream->GetEncoderConfig().bitrate_priority);
4596 // Check that the vector of VideoStreams also propagated correctly. The
4597 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
4598 // these are created appropriately for the simulcast case.
4599 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
4600 EXPECT_EQ(rtc::Optional<double>(new_bitrate_priority),
4601 video_send_stream->GetVideoStreams()[0].bitrate_priority);
4602 // Since we are only setting bitrate priority per-sender, the other
4603 // VideoStreams should have a bitrate priority of 0.
4604 EXPECT_EQ(rtc::nullopt,
4605 video_send_stream->GetVideoStreams()[1].bitrate_priority);
4606 EXPECT_EQ(rtc::nullopt,
4607 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02004608 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08004609}
4610
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07004611// Test that a stream will not be sending if its encoding is made inactive
4612// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08004613TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07004614 FakeVideoSendStream* stream = AddSendStream();
4615 EXPECT_TRUE(channel_->SetSend(true));
4616 EXPECT_TRUE(stream->IsSending());
4617
4618 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004619 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07004620 ASSERT_EQ(1u, parameters.encodings.size());
4621 ASSERT_TRUE(parameters.encodings[0].active);
4622 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08004623 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07004624 EXPECT_FALSE(stream->IsSending());
4625
4626 // Now change it back to active and verify we resume sending.
4627 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08004628 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07004629 EXPECT_TRUE(stream->IsSending());
4630}
4631
Seth Hampson8234ead2018-02-02 15:16:24 -08004632// Tests that when active is updated for any simulcast layer then the send
4633// stream's sending state will be updated and it will be reconfigured with the
4634// new appropriate active simulcast streams.
4635TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
4636 // Create the stream params with multiple ssrcs for simulcast.
4637 const int kNumSimulcastStreams = 3;
4638 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
4639 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
4640 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
4641 uint32_t primary_ssrc = stream_params.first_ssrc();
4642
Tommi85959932018-02-07 19:26:06 +01004643 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
4644 // frame. This allows us to test that ReconfigureEncoder is called
4645 // appropriately.
4646 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08004647 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02004648 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08004649 EXPECT_EQ(cricket::CS_RUNNING,
4650 capturer.Start(cricket::VideoFormat(
4651 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
4652 cricket::FOURCC_I420)));
4653 channel_->SetSend(true);
4654 EXPECT_TRUE(capturer.CaptureFrame());
4655
4656 // Check that all encodings are initially active.
4657 webrtc::RtpParameters parameters =
4658 channel_->GetRtpSendParameters(primary_ssrc);
4659 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
4660 EXPECT_TRUE(parameters.encodings[0].active);
4661 EXPECT_TRUE(parameters.encodings[1].active);
4662 EXPECT_TRUE(parameters.encodings[2].active);
4663 EXPECT_TRUE(fake_video_send_stream->IsSending());
4664
4665 // Only turn on only the middle stream.
4666 parameters.encodings[0].active = false;
4667 parameters.encodings[1].active = true;
4668 parameters.encodings[2].active = false;
4669 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
4670 // Verify that the active fields are set on the VideoChannel.
4671 parameters = channel_->GetRtpSendParameters(primary_ssrc);
4672 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
4673 EXPECT_FALSE(parameters.encodings[0].active);
4674 EXPECT_TRUE(parameters.encodings[1].active);
4675 EXPECT_FALSE(parameters.encodings[2].active);
4676 // Check that the VideoSendStream is updated appropriately. This means its
4677 // send state was updated and it was reconfigured.
4678 EXPECT_TRUE(fake_video_send_stream->IsSending());
4679 std::vector<webrtc::VideoStream> simulcast_streams =
4680 fake_video_send_stream->GetVideoStreams();
4681 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
4682 EXPECT_FALSE(simulcast_streams[0].active);
4683 EXPECT_TRUE(simulcast_streams[1].active);
4684 EXPECT_FALSE(simulcast_streams[2].active);
4685
4686 // Turn off all streams.
4687 parameters.encodings[0].active = false;
4688 parameters.encodings[1].active = false;
4689 parameters.encodings[2].active = false;
4690 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
4691 // Verify that the active fields are set on the VideoChannel.
4692 parameters = channel_->GetRtpSendParameters(primary_ssrc);
4693 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
4694 EXPECT_FALSE(parameters.encodings[0].active);
4695 EXPECT_FALSE(parameters.encodings[1].active);
4696 EXPECT_FALSE(parameters.encodings[2].active);
4697 // Check that the VideoSendStream is off.
4698 EXPECT_FALSE(fake_video_send_stream->IsSending());
4699 simulcast_streams = fake_video_send_stream->GetVideoStreams();
4700 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
4701 EXPECT_FALSE(simulcast_streams[0].active);
4702 EXPECT_FALSE(simulcast_streams[1].active);
4703 EXPECT_FALSE(simulcast_streams[2].active);
4704
Niels Möllerff40b142018-04-09 08:49:14 +02004705 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08004706}
4707
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07004708// Test that if a stream is reconfigured (due to a codec change or other
4709// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07004710TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07004711 InactiveStreamDoesntStartSendingWhenReconfigured) {
4712 // Set an initial codec list, which will be modified later.
4713 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004714 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4715 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07004716 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4717
4718 FakeVideoSendStream* stream = AddSendStream();
4719 EXPECT_TRUE(channel_->SetSend(true));
4720 EXPECT_TRUE(stream->IsSending());
4721
4722 // Get current parameters and change "active" to false.
4723 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4724 ASSERT_EQ(1u, parameters.encodings.size());
4725 ASSERT_TRUE(parameters.encodings[0].active);
4726 parameters.encodings[0].active = false;
4727 EXPECT_EQ(1u, GetFakeSendStreams().size());
4728 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08004729 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07004730 EXPECT_FALSE(stream->IsSending());
4731
4732 // Reorder the codec list, causing the stream to be reconfigured.
4733 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004734 parameters2.codecs.push_back(GetEngineCodec("VP9"));
4735 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07004736 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4737 auto new_streams = GetFakeSendStreams();
4738 // Assert that a new underlying stream was created due to the codec change.
4739 // Otherwise, this test isn't testing what it set out to test.
4740 EXPECT_EQ(1u, GetFakeSendStreams().size());
4741 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
4742
4743 // Verify that we still are not sending anything, due to the inactive
4744 // encoding.
4745 EXPECT_FALSE(new_streams[0]->IsSending());
4746}
4747
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004748// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07004749TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004750 AddSendStream();
4751 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004752 parameters.codecs.push_back(GetEngineCodec("VP8"));
4753 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004754 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4755
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004756 webrtc::RtpParameters rtp_parameters =
4757 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004758 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08004759 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
4760 rtp_parameters.codecs[0]);
4761 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
4762 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004763}
4764
deadbeeffb2aced2017-01-06 23:05:37 -08004765// Test that RtpParameters for send stream has one encoding and it has
4766// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07004767TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08004768 AddSendStream();
4769
4770 webrtc::RtpParameters rtp_parameters =
4771 channel_->GetRtpSendParameters(last_ssrc_);
4772 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01004773 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08004774}
4775
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004776// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07004777TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004778 AddSendStream();
4779 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004780 parameters.codecs.push_back(GetEngineCodec("VP8"));
4781 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004782 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4783
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004784 webrtc::RtpParameters initial_params =
4785 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004786
4787 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08004788 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004789
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004790 // ... And this shouldn't change the params returned by GetRtpSendParameters.
4791 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
4792}
4793
4794// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07004795TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004796 AddRecvStream();
4797 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004798 parameters.codecs.push_back(GetEngineCodec("VP8"));
4799 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004800 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4801
4802 webrtc::RtpParameters rtp_parameters =
4803 channel_->GetRtpReceiveParameters(last_ssrc_);
4804 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08004805 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
4806 rtp_parameters.codecs[0]);
4807 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
4808 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004809}
4810
johan073ece42016-08-26 02:59:47 -07004811#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07004812TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07004813#else
eladalonf1841382017-06-12 01:16:46 -07004814TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07004815#endif
johan3859c892016-08-05 09:19:25 -07004816 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07004817 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08004818 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07004819 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07004820 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08004821 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07004822 parameters.codecs.push_back(kH264sprop2);
4823 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4824
4825 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4826 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
4827 webrtc::RtpParameters rtp_parameters =
4828 channel_->GetRtpReceiveParameters(last_ssrc_);
4829 ASSERT_EQ(2u, rtp_parameters.codecs.size());
4830 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
4831 ASSERT_EQ(2u, cfg.decoders.size());
4832 EXPECT_EQ(101, cfg.decoders[0].payload_type);
4833 EXPECT_EQ("H264", cfg.decoders[0].payload_name);
magjed5dfac562016-11-25 03:56:37 -08004834 const auto it0 =
4835 cfg.decoders[0].codec_params.find(kH264FmtpSpropParameterSets);
4836 ASSERT_TRUE(it0 != cfg.decoders[0].codec_params.end());
4837 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07004838
4839 EXPECT_EQ(102, cfg.decoders[1].payload_type);
4840 EXPECT_EQ("H264", cfg.decoders[1].payload_name);
magjed5dfac562016-11-25 03:56:37 -08004841 const auto it1 =
4842 cfg.decoders[1].codec_params.find(kH264FmtpSpropParameterSets);
4843 ASSERT_TRUE(it1 != cfg.decoders[1].codec_params.end());
4844 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07004845}
4846
sakal1fd95952016-06-22 00:46:15 -07004847// Test that RtpParameters for receive stream has one encoding and it has
4848// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07004849TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07004850 AddRecvStream();
4851
4852 webrtc::RtpParameters rtp_parameters =
4853 channel_->GetRtpReceiveParameters(last_ssrc_);
4854 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01004855 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07004856}
4857
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004858// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07004859TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004860 AddRecvStream();
4861 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004862 parameters.codecs.push_back(GetEngineCodec("VP8"));
4863 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07004864 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4865
4866 webrtc::RtpParameters initial_params =
4867 channel_->GetRtpReceiveParameters(last_ssrc_);
4868
4869 // We should be able to set the params we just got.
4870 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
4871
4872 // ... And this shouldn't change the params returned by
4873 // GetRtpReceiveParameters.
4874 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07004875}
4876
deadbeef3bc15102017-04-20 19:25:07 -07004877// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
4878// aren't signaled. It should always return an empty "RtpEncodingParameters",
4879// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07004880TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07004881 // Call necessary methods to configure receiving a default stream as
4882 // soon as it arrives.
4883 cricket::VideoRecvParameters parameters;
4884 parameters.codecs.push_back(GetEngineCodec("VP8"));
4885 parameters.codecs.push_back(GetEngineCodec("VP9"));
4886 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4887
4888 // Call GetRtpReceiveParameters before configured to receive an unsignaled
4889 // stream. Should return nothing.
4890 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
4891
4892 // Set a sink for an unsignaled stream.
4893 cricket::FakeVideoRenderer renderer;
4894 // Value of "0" means "unsignaled stream".
4895 EXPECT_TRUE(channel_->SetSink(0, &renderer));
4896
4897 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
4898 // in this method means "unsignaled stream".
4899 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
4900 ASSERT_EQ(1u, rtp_parameters.encodings.size());
4901 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
4902
4903 // Receive VP8 packet.
4904 uint8_t data[kMinRtpPacketLen];
4905 cricket::RtpHeader rtpHeader;
4906 rtpHeader.payload_type = GetEngineCodec("VP8").id;
4907 rtpHeader.seq_num = rtpHeader.timestamp = 0;
4908 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
4909 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
4910 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
4911 rtc::PacketTime packet_time;
4912 channel_->OnPacketReceived(&packet, packet_time);
4913
4914 // The |ssrc| member should still be unset.
4915 rtp_parameters = channel_->GetRtpReceiveParameters(0);
4916 ASSERT_EQ(1u, rtp_parameters.encodings.size());
4917 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
4918}
4919
eladalonf1841382017-06-12 01:16:46 -07004920void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02004921 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004922 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02004923
4924 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02004925 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02004926 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02004927 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02004928
4929 if (receiver_first) {
4930 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
4931 std::vector<FakeVideoReceiveStream*> receive_streams =
4932 fake_call_->GetVideoReceiveStreams();
4933 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02004934 // Default local SSRC when we have no sender.
4935 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
4936 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02004937 }
4938 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
4939 if (!receiver_first)
4940 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
4941 std::vector<FakeVideoReceiveStream*> receive_streams =
4942 fake_call_->GetVideoReceiveStreams();
4943 ASSERT_EQ(1u, receive_streams.size());
4944 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02004945
4946 // Removing first sender should fall back to another (in this case the second)
4947 // local send stream's SSRC.
4948 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
4949 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
4950 receive_streams =
4951 fake_call_->GetVideoReceiveStreams();
4952 ASSERT_EQ(1u, receive_streams.size());
4953 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
4954
4955 // Removing the last sender should fall back to default local SSRC.
4956 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
4957 receive_streams =
4958 fake_call_->GetVideoReceiveStreams();
4959 ASSERT_EQ(1u, receive_streams.size());
4960 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
4961 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02004962}
4963
eladalonf1841382017-06-12 01:16:46 -07004964TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02004965 TestReceiverLocalSsrcConfiguration(false);
4966}
4967
eladalonf1841382017-06-12 01:16:46 -07004968TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02004969 TestReceiverLocalSsrcConfiguration(true);
4970}
4971
eladalonf1841382017-06-12 01:16:46 -07004972class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00004973 public:
eladalonf1841382017-06-12 01:16:46 -07004974 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004975 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02004976 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
4977 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
4978 engine_(std::unique_ptr<cricket::WebRtcVideoEncoderFactory>(
4979 encoder_factory_),
4980 std::unique_ptr<cricket::WebRtcVideoDecoderFactory>(
4981 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07004982 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00004983
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00004984 void SetUp() override {
nisse51542be2016-02-12 02:27:06 -08004985 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08004986 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08004987 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00004988 last_ssrc_ = 123;
4989 }
4990
4991 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00004992 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07004993 int capture_width,
4994 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00004995 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08004996 size_t expected_num_streams,
4997 bool screenshare,
4998 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004999 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005000 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08005001 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005002 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005003
Peter Boström0c4e06b2015-10-07 12:23:21 +02005004 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07005005 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005006 ssrcs.resize(num_configured_streams);
5007
sprangf24a0642017-02-28 13:23:26 -08005008 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00005009 // Send a full-size frame to trigger a stream reconfiguration to use all
5010 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01005011 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08005012 VideoOptions options;
5013 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01005014 options.is_screencast = screenshare;
deadbeef5a4a75a2016-06-02 16:23:38 -07005015 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02005016 channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08005017 // Fetch the latest stream since SetVideoSend() may recreate it if the
5018 // screen content setting is changed.
5019 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00005020 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07005021 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00005022 cricket::VideoFormat::FpsToInterval(30),
5023 cricket::FOURCC_I420)));
5024 channel_->SetSend(true);
5025 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005026
Zach Stein3ca452b2018-01-18 10:01:24 -08005027 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
5028 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
5029
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005030 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5031 ASSERT_EQ(expected_num_streams, video_streams.size());
5032
sprang429600d2017-01-26 06:12:26 -08005033 std::vector<webrtc::VideoStream> expected_streams;
5034 if (conference_mode) {
5035 expected_streams = GetSimulcastConfig(
5036 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08005037 webrtc::kDefaultBitratePriority, kDefaultQpMax,
5038 kDefaultVideoMaxFramerate, screenshare);
sprang3ebabf12017-02-16 07:35:22 -08005039 if (screenshare) {
5040 for (const webrtc::VideoStream& stream : expected_streams) {
5041 // Never scale screen content.
5042 EXPECT_EQ(stream.width, capture_width);
5043 EXPECT_EQ(stream.height, capture_height);
5044 }
5045 }
sprang429600d2017-01-26 06:12:26 -08005046 } else {
5047 webrtc::VideoStream stream;
5048 stream.width = capture_width;
5049 stream.height = capture_height;
5050 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01005051 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08005052 int max_bitrate_kbps;
5053 if (capture_width * capture_height <= 320 * 240) {
5054 max_bitrate_kbps = 600;
5055 } else if (capture_width * capture_height <= 640 * 480) {
5056 max_bitrate_kbps = 1700;
5057 } else if (capture_width * capture_height <= 960 * 540) {
5058 max_bitrate_kbps = 2000;
5059 } else {
5060 max_bitrate_kbps = 2500;
5061 }
5062 stream.target_bitrate_bps = stream.max_bitrate_bps =
5063 max_bitrate_kbps * 1000;
5064 stream.max_qp = kDefaultQpMax;
5065 expected_streams.push_back(stream);
5066 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005067
5068 ASSERT_EQ(expected_streams.size(), video_streams.size());
5069
5070 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005071 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005072 for (size_t i = 0; i < num_streams; ++i) {
5073 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
5074 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
5075
5076 EXPECT_GT(video_streams[i].max_framerate, 0);
5077 EXPECT_EQ(expected_streams[i].max_framerate,
5078 video_streams[i].max_framerate);
5079
5080 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
5081 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
5082 video_streams[i].min_bitrate_bps);
5083
5084 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
5085 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
5086 video_streams[i].target_bitrate_bps);
5087
5088 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
5089 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
5090 video_streams[i].max_bitrate_bps);
5091
5092 EXPECT_GT(video_streams[i].max_qp, 0);
5093 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
5094
Sergey Silkina796a7e2018-03-01 15:11:29 +01005095 EXPECT_EQ(conference_mode,
5096 expected_streams[i].num_temporal_layers.has_value());
5097
5098 if (conference_mode) {
5099 EXPECT_EQ(expected_streams[i].num_temporal_layers,
5100 video_streams[i].num_temporal_layers);
5101 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005102
5103 if (i == num_streams - 1) {
5104 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
5105 } else {
5106 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
5107 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005108 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005109
Niels Möllerff40b142018-04-09 08:49:14 +02005110 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005111 }
5112
5113 FakeVideoSendStream* AddSendStream() {
5114 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
5115 }
5116
5117 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
5118 size_t num_streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005119 fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005120 EXPECT_TRUE(channel_->AddSendStream(sp));
5121 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005122 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005123 EXPECT_EQ(num_streams + 1, streams.size());
5124 return streams[streams.size() - 1];
5125 }
5126
5127 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005128 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005129 }
5130
5131 FakeVideoReceiveStream* AddRecvStream() {
5132 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
5133 }
5134
5135 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
5136 size_t num_streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005137 fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005138 EXPECT_TRUE(channel_->AddRecvStream(sp));
5139 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005140 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005141 EXPECT_EQ(num_streams + 1, streams.size());
5142 return streams[streams.size() - 1];
5143 }
5144
skvlad11a9cbf2016-10-07 11:53:05 -07005145 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02005146 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02005147 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
5148 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07005149 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08005150 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02005151 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005152};
5153
eladalonf1841382017-06-12 01:16:46 -07005154TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08005155 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
5156 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005157}
5158
eladalonf1841382017-06-12 01:16:46 -07005159TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08005160 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
5161 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005162}
5163
5164// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07005165TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08005166 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
5167 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00005168}
sprang429600d2017-01-26 06:12:26 -08005169
eladalonf1841382017-06-12 01:16:46 -07005170TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
sprang429600d2017-01-26 06:12:26 -08005171 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
5172 false);
5173}
5174
eladalonf1841382017-06-12 01:16:46 -07005175TEST_F(WebRtcVideoChannelSimulcastTest,
sprang429600d2017-01-26 06:12:26 -08005176 SetSendCodecsForConferenceModeScreenshare) {
5177 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
5178 true);
5179}
5180
eladalonf1841382017-06-12 01:16:46 -07005181TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08005182 webrtc::test::ScopedFieldTrials override_field_trials_(
5183 "WebRTC-SimulcastScreenshare/Enabled/");
5184 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
5185 true);
5186}
5187
eladalonf1841382017-06-12 01:16:46 -07005188TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07005189 NoSimulcastScreenshareWithoutConference) {
5190 webrtc::test::ScopedFieldTrials override_field_trials_(
5191 "WebRTC-SimulcastScreenshare/Enabled/");
5192 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
5193 false);
5194}
5195
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00005196} // namespace cricket