blob: 5361a95f4db82ccdc1a0ea285580e079b475dfae [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020020#include "api/video_codecs/builtin_video_decoder_factory.h"
21#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020022#include "api/video_codecs/sdp_video_format.h"
23#include "api/video_codecs/video_decoder_factory.h"
24#include "api/video_codecs/video_encoder.h"
25#include "api/video_codecs/video_encoder_factory.h"
26#include "call/flexfec_receive_stream.h"
27#include "common_video/h264/profile_level_id.h"
28#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020029#include "media/base/fakenetworkinterface.h"
30#include "media/base/fakevideocapturer.h"
31#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "media/base/mediaconstants.h"
33#include "media/base/rtputils.h"
34#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/engine/constants.h"
36#include "media/engine/fakewebrtccall.h"
37#include "media/engine/fakewebrtcvideoengine.h"
38#include "media/engine/simulcast.h"
39#include "media/engine/webrtcvideoengine.h"
40#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020041#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020042#include "rtc_base/arraysize.h"
43#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020044#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020045#include "rtc_base/stringutils.h"
46#include "test/field_trial.h"
47#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000048
Tommi85959932018-02-07 19:26:06 +010049using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010050using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070051using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010052using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070053
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000054namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000055static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000056
noahricd10a68e2015-07-10 11:27:55 -070057static const uint8_t kRedRtxPayloadType = 125;
58
Niels Möller6557d0c2018-04-11 15:18:34 +020059static const uint32_t kTimeout = 5000U;
60static const uint32_t kDefaultReceiveSsrc = 0;
61static const uint32_t kSsrc = 1234u;
62static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
63static const int kVideoWidth = 640;
64static const int kVideoHeight = 360;
65static const int kFramerate = 30;
66
Peter Boström0c4e06b2015-10-07 12:23:21 +020067static const uint32_t kSsrcs1[] = {1};
68static const uint32_t kSsrcs3[] = {1, 2, 3};
69static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080070static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020071static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080072static const uint32_t kDefaultRecvSsrc = 0;
73
pbos@webrtc.org3c107582014-07-20 15:27:35 +000074static const char kUnsupportedExtensionName[] =
75 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000076
magjed509e4fe2016-11-18 01:34:11 -080077cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
78 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020079 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080080}
81
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000082void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
83 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
84 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
85 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
86 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
87 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
88 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
89 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080090 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
91 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000092 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
93}
94
magjed725e4842016-11-16 00:48:13 -080095// Return true if any codec in |codecs| is an RTX codec with associated payload
96// type |payload_type|.
97bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
98 int payload_type) {
99 for (const cricket::VideoCodec& codec : codecs) {
100 int associated_payload_type;
101 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
102 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
103 &associated_payload_type) &&
104 associated_payload_type == payload_type) {
105 return true;
106 }
107 }
108 return false;
109}
110
nisseca5706d2017-09-11 02:32:16 -0700111// TODO(nisse): Duplicated in call.cc.
112const int* FindKeyByValue(const std::map<int, int>& m, int v) {
113 for (const auto& kv : m) {
114 if (kv.second == v)
115 return &kv.first;
116 }
117 return nullptr;
118}
119
Yves Gerey665174f2018-06-19 15:03:05 +0200120bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
121 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700122 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
123 payload_type) != nullptr;
124}
125
126// Check that there's an Rtx payload type for each decoder.
127bool VerifyRtxReceiveAssociations(
128 const webrtc::VideoReceiveStream::Config& config) {
129 for (const auto& decoder : config.decoders) {
130 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
131 return false;
132 }
133 return true;
134}
135
brandtrffc61182016-11-28 06:02:22 -0800136rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700137 int width,
138 int height) {
139 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
140 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800141 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700142 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000143}
144
Shao Changbine62202f2015-04-21 20:24:50 +0800145void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
146 const std::map<int, int>& rtx_types) {
147 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200148 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800149 EXPECT_TRUE(it != rtx_types.end() &&
150 it->second == config.rtp.rtx.payload_type);
151
brandtrb5f2c3f2016-10-04 23:28:39 -0700152 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
153 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800154 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700155 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800156 }
157}
kthelgason2bc68642017-02-07 07:02:22 -0800158
159cricket::MediaConfig GetMediaConfig() {
160 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100161 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800162 return media_config;
163}
nisse26e3abb2017-08-25 04:44:25 -0700164
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200165// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
166int GetMaxDefaultBitrateBps(size_t width, size_t height) {
167 if (width * height <= 320 * 240) {
168 return 600000;
169 } else if (width * height <= 640 * 480) {
170 return 1700000;
171 } else if (width * height <= 960 * 540) {
172 return 2000000;
173 } else {
174 return 2500000;
175 }
176}
177
Niels Möller731a2c22018-07-30 15:08:07 +0200178class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
179 public:
180 MOCK_METHOD2(AddOrUpdateSink,
181 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
182 const rtc::VideoSinkWants& wants));
183 MOCK_METHOD1(RemoveSink,
184 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
185};
186
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000187} // namespace
188
Yves Gerey665174f2018-06-19 15:03:05 +0200189#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200190 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200191 EXPECT_EQ((w), renderer_.width()); \
192 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200193 EXPECT_EQ(0, renderer_.errors());
194
Yves Gerey665174f2018-06-19 15:03:05 +0200195#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200196 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200197 EXPECT_EQ((w), (r).width()); \
198 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ(0, (r).errors());
200
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000201namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700202class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000203 public:
eladalonf1841382017-06-12 01:16:46 -0700204 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
205 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700206 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700207 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200208 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
209 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200210 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200211 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200212 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200213 decoder_factory_)) {}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000214
215 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200216 void AssignDefaultAptRtxTypes();
217 void AssignDefaultCodec();
218
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100219 // Find the index of the codec in the engine with the given name. The codec
220 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100221 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100222
magjed509e4fe2016-11-18 01:34:11 -0800223 // Find the codec in the engine with the given name. The codec must be
224 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100225 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800226
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200227 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000228
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200229 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000230 const std::vector<VideoCodec>& codecs);
231
Peter Boströme4499152016-02-05 11:13:28 +0100232 void TestExtendedEncoderOveruse(bool use_external_encoder);
233
stefanc1aeaf02015-10-15 07:26:07 -0700234 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700235 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700236 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000237 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800238 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200239 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
240 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700241 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000242 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800243 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000244};
245
eladalonf1841382017-06-12 01:16:46 -0700246TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200247 encoder_factory_->AddSupportedVideoCodecType("VP8");
248 AssignDefaultCodec();
249
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000250 std::vector<VideoCodec> engine_codecs = engine_.codecs();
251 for (size_t i = 0; i < engine_codecs.size(); ++i) {
252 if (engine_codecs[i].name != kRtxCodecName)
253 continue;
254 int associated_payload_type;
255 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000256 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000257 EXPECT_EQ(default_codec_.id, associated_payload_type);
258 return;
259 }
260 FAIL() << "No RTX codec found among default codecs.";
261}
262
eladalonf1841382017-06-12 01:16:46 -0700263TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100264 RtpCapabilities capabilities = engine_.GetCapabilities();
265 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700266 for (const RtpExtension& extension : capabilities.header_extensions) {
267 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
268 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000269 return;
270 }
271 }
272 FAIL() << "Timestamp offset extension not in header-extension list.";
273}
274
eladalonf1841382017-06-12 01:16:46 -0700275TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100276 RtpCapabilities capabilities = engine_.GetCapabilities();
277 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700278 for (const RtpExtension& extension : capabilities.header_extensions) {
279 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
280 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000281 return;
282 }
283 }
284 FAIL() << "Absolute Sender Time extension not in header-extension list.";
285}
286
eladalonf1841382017-06-12 01:16:46 -0700287TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100288 RtpCapabilities capabilities = engine_.GetCapabilities();
289 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700290 for (const RtpExtension& extension : capabilities.header_extensions) {
291 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
292 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700293 return;
294 }
295 }
296 FAIL() << "Transport sequence number extension not in header-extension list.";
297}
298
eladalonf1841382017-06-12 01:16:46 -0700299TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100300 RtpCapabilities capabilities = engine_.GetCapabilities();
301 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700302 for (const RtpExtension& extension : capabilities.header_extensions) {
303 if (extension.uri == RtpExtension::kVideoRotationUri) {
304 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700305 return;
306 }
307 }
308 FAIL() << "Video Rotation extension not in header-extension list.";
309}
310
eladalonf1841382017-06-12 01:16:46 -0700311TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200312 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700313 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200314 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700315
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200316 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700317
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200318 std::unique_ptr<VideoMediaChannel> channel(
319 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700320 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
321
322 // Add CVO extension.
323 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800324 cricket::VideoSendParameters parameters;
325 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200326 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700327 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200328 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700329
Niels Möller731a2c22018-07-30 15:08:07 +0200330 EXPECT_CALL(
331 video_source,
332 AddOrUpdateSink(testing::_,
333 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700334 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200335 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700336
337 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200338 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700339
340 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200341 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200342 EXPECT_CALL(
343 video_source,
344 AddOrUpdateSink(testing::_,
345 Field(&rtc::VideoSinkWants::rotation_applied, true)));
346
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200347 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348}
349
eladalonf1841382017-06-12 01:16:46 -0700350TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200351 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800352 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200353 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800354
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200355 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800356
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200357 std::unique_ptr<VideoMediaChannel> channel(
358 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800359 // Add CVO extension.
360 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800361 cricket::VideoSendParameters parameters;
362 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800363 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700364 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800365 EXPECT_TRUE(channel->SetSendParameters(parameters));
366 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
367
Niels Möller731a2c22018-07-30 15:08:07 +0200368 // Set source.
369 EXPECT_CALL(
370 video_source,
371 AddOrUpdateSink(testing::_,
372 Field(&rtc::VideoSinkWants::rotation_applied, false)));
373 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800374}
375
eladalonf1841382017-06-12 01:16:46 -0700376TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200377 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200379 encoder_factory_->AddSupportedVideoCodecType("VP8");
380 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700381
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200382 std::unique_ptr<VideoMediaChannel> channel(
383 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700384 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
385
386 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200387 EXPECT_CALL(
388 video_source,
389 AddOrUpdateSink(testing::_,
390 Field(&rtc::VideoSinkWants::rotation_applied, true)));
391 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392
perkjcaafdba2016-03-20 07:34:29 -0700393 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200394 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700395
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700396 // Add CVO extension.
397 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800398 cricket::VideoSendParameters parameters;
399 parameters.codecs.push_back(GetEngineCodec("VP8"));
400 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200401 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700402 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700403 // Also remove the first codec to trigger a codec change as well.
404 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200405 EXPECT_CALL(
406 video_source,
407 AddOrUpdateSink(testing::_,
408 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200409 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700410
411 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200412 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700413
414 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200415 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200416 EXPECT_CALL(
417 video_source,
418 AddOrUpdateSink(testing::_,
419 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200420 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700421}
422
eladalonf1841382017-06-12 01:16:46 -0700423TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200424 encoder_factory_->AddSupportedVideoCodecType("VP8");
425
kwiberg686a8ef2016-02-26 03:00:35 -0800426 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800427 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000428
429 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
430
431 EXPECT_FALSE(channel->SetSend(true))
432 << "Channel should not start without codecs.";
433 EXPECT_TRUE(channel->SetSend(false))
434 << "Channel should be stoppable even without set codecs.";
435}
436
eladalonf1841382017-06-12 01:16:46 -0700437TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200438 encoder_factory_->AddSupportedVideoCodecType("VP8");
439
kwiberg686a8ef2016-02-26 03:00:35 -0800440 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800441 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000442 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
443 VideoMediaInfo info;
444 channel->GetStats(&info);
445}
446
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200447TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200448 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000449
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200450 std::unique_ptr<VideoMediaChannel> channel(
451 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800452 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000453
454 EXPECT_TRUE(
455 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200456 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000457 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100458 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200459 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000460 EXPECT_EQ(cricket::CS_RUNNING,
461 capturer.Start(capturer.GetSupportedFormats()->front()));
462 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100463 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200464 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
465 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000466 kTimeout);
467
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200468 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100469 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000470
471 // Setting codecs of the same type should not reallocate any encoders
472 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800473 cricket::VideoSendParameters parameters;
474 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200475 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200476 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000477
478 // Remove stream previously added to free the external encoder instance.
479 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200480 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000481}
482
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200483// Test that when an encoder factory supports H264, we add an RTX
484// codec for it.
485// TODO(deadbeef): This test should be updated if/when we start
486// adding RTX codecs for unrecognized codec names.
487TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800488 using webrtc::H264::ProfileLevelIdToString;
489 using webrtc::H264::ProfileLevelId;
490 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200491 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
492 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800493 *ProfileLevelIdToString(
494 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200495 webrtc::SdpVideoFormat h264_constrained_high("H264");
496 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800497 *ProfileLevelIdToString(
498 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200499 webrtc::SdpVideoFormat h264_high("H264");
500 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800501 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
502
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200503 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
504 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
505 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700506
magjed725e4842016-11-16 00:48:13 -0800507 // First figure out what payload types the test codecs got assigned.
508 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800509 // Now search for RTX codecs for them. Expect that they all have associated
510 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800511 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200512 codecs,
513 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
514 ->id));
magjed725e4842016-11-16 00:48:13 -0800515 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200516 codecs,
517 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
518 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800519 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200520 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700521}
522
Peter Boström12996152016-05-14 02:03:18 +0200523#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700524TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200525 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100526
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200527 std::unique_ptr<VideoMediaChannel> channel(
528 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100529
530 EXPECT_TRUE(
531 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
532}
Peter Boström12996152016-05-14 02:03:18 +0200533#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100534
eladalonf1841382017-06-12 01:16:46 -0700535TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200536 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100537 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200538 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200539 std::unique_ptr<VideoMediaChannel> channel(
540 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700541
542 EXPECT_TRUE(
543 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
544
Tommi85959932018-02-07 19:26:06 +0100545 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200546 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700547 capturer.Start(cricket::VideoFormat(1280, 720,
548 cricket::VideoFormat::FpsToInterval(60),
549 cricket::FOURCC_I420));
550 channel->SetSend(true);
551
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200552 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700553
554 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700555 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700556 for (int i = 0; i < 10; i++) {
557 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700558 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700559 int64_t interval = timestamp - last_timestamp;
560
561 // Precision changes from nanosecond to millisecond.
562 // Allow error to be no more than 1.
563 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
564
565 last_timestamp = timestamp;
566 }
567
568 capturer.Start(cricket::VideoFormat(1280, 720,
569 cricket::VideoFormat::FpsToInterval(30),
570 cricket::FOURCC_I420));
571
572 EXPECT_TRUE(capturer.CaptureFrame());
573 last_timestamp = stream->GetLastTimestamp();
574 for (int i = 0; i < 10; i++) {
575 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700576 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700577 int64_t interval = timestamp - last_timestamp;
578
579 // Precision changes from nanosecond to millisecond.
580 // Allow error to be no more than 1.
581 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
582
583 last_timestamp = timestamp;
584 }
585
586 // Remove stream previously added to free the external encoder instance.
587 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
588}
589
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200590void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
591 std::vector<VideoCodec> engine_codecs = engine_.codecs();
592 RTC_DCHECK(!engine_codecs.empty());
593 for (const cricket::VideoCodec& codec : engine_codecs) {
594 if (codec.name == "rtx") {
595 int associated_payload_type;
596 if (codec.GetParam(kCodecParamAssociatedPayloadType,
597 &associated_payload_type)) {
598 default_apt_rtx_types_[associated_payload_type] = codec.id;
599 }
600 }
601 }
602}
603
604void WebRtcVideoEngineTest::AssignDefaultCodec() {
605 std::vector<VideoCodec> engine_codecs = engine_.codecs();
606 RTC_DCHECK(!engine_codecs.empty());
607 bool codec_set = false;
608 for (const cricket::VideoCodec& codec : engine_codecs) {
609 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
610 codec.name != "ulpfec") {
611 default_codec_ = codec;
612 codec_set = true;
613 }
614 }
615
616 RTC_DCHECK(codec_set);
617}
618
Oleh Prypina40f8242017-12-21 13:32:23 +0100619size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
620 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100621 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
622 for (size_t i = 0; i < codecs.size(); ++i) {
623 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200624 if (!CodecNamesEq(name, engine_codec.name))
625 continue;
626 // The tests only use H264 Constrained Baseline. Make sure we don't return
627 // an internal H264 codec from the engine with a different H264 profile.
628 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200629 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200630 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
631 if (profile_level_id->profile !=
632 webrtc::H264::kProfileConstrainedBaseline) {
633 continue;
634 }
635 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100636 return i;
magjed509e4fe2016-11-18 01:34:11 -0800637 }
638 // This point should never be reached.
639 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100640 return -1;
641}
642
643cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
644 const std::string& name) const {
645 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800646}
647
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200648VideoMediaChannel*
649WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000650 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800651 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200652 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800653 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200654 for (const webrtc::SdpVideoFormat& format :
655 encoder_factory_->GetSupportedFormats()) {
656 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
657 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
658 engine_codec) == parameters.codecs.end()) {
659 parameters.codecs.push_back(engine_codec);
660 }
661 }
magjed509e4fe2016-11-18 01:34:11 -0800662
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200663 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000664
665 return channel;
666}
667
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200668VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000669 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000670 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800671 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200672 cricket::VideoRecvParameters parameters;
673 parameters.codecs = codecs;
674 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000675
676 return channel;
677}
678
eladalonf1841382017-06-12 01:16:46 -0700679TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200680 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000681
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200682 std::unique_ptr<VideoMediaChannel> channel(
683 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000684
Peter Boström0c4e06b2015-10-07 12:23:21 +0200685 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000686
Yves Gerey665174f2018-06-19 15:03:05 +0200687 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000688 EXPECT_TRUE(channel->SetSend(true));
689
Tommi85959932018-02-07 19:26:06 +0100690 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200691 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000692 EXPECT_EQ(cricket::CS_RUNNING,
693 capturer.Start(capturer.GetSupportedFormats()->front()));
694 EXPECT_TRUE(capturer.CaptureFrame());
695
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200696 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000697
698 // Verify that encoders are configured for simulcast through adapter
699 // (increasing resolution and only configured to send one stream each).
700 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200701 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
702 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000703 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200704 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000705 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
706 EXPECT_GT(codec_settings.width, prev_width);
707 prev_width = codec_settings.width;
708 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000709
Niels Möllerff40b142018-04-09 08:49:14 +0200710 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000711
712 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200713 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714}
715
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200716TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
717 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200718 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000719
Niels Möller4db138e2018-04-19 09:04:13 +0200720 // Set capturer.
721 FakeVideoCapturerWithTaskQueue capturer;
722 EXPECT_EQ(cricket::CS_RUNNING,
723 capturer.Start(capturer.GetSupportedFormats()->front()));
724
Anders Carlsson67537952018-05-03 11:28:29 +0200725 std::unique_ptr<VideoMediaChannel> channel(
726 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
727 cricket::VideoSendParameters parameters;
728 parameters.codecs.push_back(GetEngineCodec("H264"));
729 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000730
731 EXPECT_TRUE(
732 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200733 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
734 // Sending one frame will have allocate the encoder.
735 EXPECT_TRUE(capturer.CaptureFrame());
736
737 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000738
Anders Carlsson67537952018-05-03 11:28:29 +0200739 cricket::VideoSendParameters new_parameters;
740 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
741 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200742
743 // Sending one frame will switch encoder.
744 EXPECT_TRUE(capturer.CaptureFrame());
745
Anders Carlsson8a150d92018-05-14 12:40:04 +0200746 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000747}
748
eladalonf1841382017-06-12 01:16:46 -0700749TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000750 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200751 encoder_factory_->AddSupportedVideoCodecType("VP8");
752 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000753
kwiberg686a8ef2016-02-26 03:00:35 -0800754 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800755 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800756 cricket::VideoSendParameters parameters;
757 parameters.codecs.push_back(GetEngineCodec("VP8"));
758 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000759
Peter Boström0c4e06b2015-10-07 12:23:21 +0200760 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000761
Yves Gerey665174f2018-06-19 15:03:05 +0200762 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000763 EXPECT_TRUE(channel->SetSend(true));
764
765 // Send a fake frame, or else the media engine will configure the simulcast
766 // encoder adapter at a low-enough size that it'll only create a single
767 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100768 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200769 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000770 EXPECT_EQ(cricket::CS_RUNNING,
771 capturer.Start(capturer.GetSupportedFormats()->front()));
772 EXPECT_TRUE(capturer.CaptureFrame());
773
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200774 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
775 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000776 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000778
779 channel.reset();
780 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200781 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782}
783
eladalonf1841382017-06-12 01:16:46 -0700784TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000785 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200786 encoder_factory_->AddSupportedVideoCodecType("VP8");
787 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000788
kwiberg686a8ef2016-02-26 03:00:35 -0800789 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800790 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800791 cricket::VideoSendParameters parameters;
792 parameters.codecs.push_back(GetEngineCodec("H264"));
793 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000794
795 EXPECT_TRUE(
796 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100797
798 // Send a frame of 720p. This should trigger a "real" encoder initialization.
799 cricket::VideoFormat format(
800 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100801 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200802 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100803 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
804 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200805 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
806 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200809 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000810
811 channel.reset();
812 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200813 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000814}
815
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200816TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
817 webrtc::test::ScopedFieldTrials override_field_trials_(
818 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200819 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700820
Anders Carlsson67537952018-05-03 11:28:29 +0200821 std::unique_ptr<VideoMediaChannel> channel(
822 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
823 cricket::VideoSendParameters parameters;
824 parameters.codecs.push_back(GetEngineCodec("H264"));
825 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700826
Peter Boström0c4e06b2015-10-07 12:23:21 +0200827 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700828 EXPECT_TRUE(
829 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100830
831 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700832 cricket::VideoFormat format(
833 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100834 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200835 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100836 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
837 EXPECT_TRUE(capturer.CaptureFrame());
838
Niels Möller4db138e2018-04-19 09:04:13 +0200839 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200840 ASSERT_EQ(1u, encoder_factory_->encoders().size());
841 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
842 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700843 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200844 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200845 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700846}
847
brandtrffc61182016-11-28 06:02:22 -0800848// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700849// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800850//
851// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700852TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800853 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200854 encoder_factory_->AddSupportedVideoCodecType("VP8");
855
brandtrffc61182016-11-28 06:02:22 -0800856 auto is_flexfec = [](const VideoCodec& codec) {
857 if (codec.name == "flexfec-03")
858 return true;
859 return false;
860 };
861
862 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800863 const std::vector<VideoCodec> codecs_before = engine_.codecs();
864 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
865 codecs_before.end(), is_flexfec));
866
867 // FlexFEC is active with field trial.
868 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800869 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800870 const std::vector<VideoCodec> codecs_after = engine_.codecs();
871 EXPECT_NE(codecs_after.end(),
872 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
873}
874
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200875// Test that codecs are added in the order they are reported from the factory.
876TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
877 encoder_factory_->AddSupportedVideoCodecType("VP8");
878 const char* kFakeCodecName = "FakeCodec";
879 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000880
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200881 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100882 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200883 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
884 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000885}
886
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200887// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800888// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200889TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100890 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
891 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100892
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100893 // Set up external encoder factory with first codec, and initialize engine.
894 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
895
brandtrffc61182016-11-28 06:02:22 -0800896 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800897
898 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100899 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800900 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200901 // The codec itself and RTX should have been added.
902 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100903
904 // Check that both fake codecs are present and that the second fake codec
905 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100906 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
907 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100908 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800909}
910
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200911TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
912 const char* kFakeCodecName = "FakeCodec";
913 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
914
915 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
916 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
917}
918
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200919TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
920 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200921 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200922 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800923 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000924
kwiberg686a8ef2016-02-26 03:00:35 -0800925 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200926 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000927
928 EXPECT_TRUE(
929 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200930 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000931
932 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200933 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200934 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000935
936 // Remove stream previously added to free the external decoder instance.
937 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200938 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000939}
940
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200941// Verifies that we can set up decoders.
942TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000943 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
944 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
945 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
946 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200947 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200948 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000949 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800950 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000951
kwiberg686a8ef2016-02-26 03:00:35 -0800952 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200953 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000954
955 EXPECT_TRUE(
956 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200957 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000958}
959
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200960TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
961 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
962 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
963 WebRtcVideoEngine engine(std::move(encoder_factory),
964 std::move(decoder_factory));
965 EXPECT_EQ(0u, engine.codecs().size());
966}
967
968TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
969 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700970 webrtc::MockVideoEncoderFactory* encoder_factory =
971 new webrtc::MockVideoEncoderFactory();
972 webrtc::MockVideoDecoderFactory* decoder_factory =
973 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200974 WebRtcVideoEngine engine(
975 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
976 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
977 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
978 EXPECT_EQ(0u, engine.codecs().size());
979 EXPECT_CALL(*encoder_factory, Die());
980 EXPECT_CALL(*decoder_factory, Die());
981}
982
983// Test full behavior in the video engine when video codec factories of the new
984// type are injected supporting the single codec Vp8. Check the returned codecs
985// from the engine and that we will create a Vp8 encoder and decoder using the
986// new factories.
987TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
988 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700989 webrtc::MockVideoEncoderFactory* encoder_factory =
990 new webrtc::MockVideoEncoderFactory();
991 webrtc::MockVideoDecoderFactory* decoder_factory =
992 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200993 WebRtcVideoEngine engine(
994 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
995 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
996 const webrtc::SdpVideoFormat vp8_format("VP8");
997 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
998 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
999 .WillRepeatedly(testing::Return(supported_formats));
1000
1001 // Verify the codecs from the engine.
1002 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001003 // Verify default codecs has been added correctly.
1004 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001005 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001006
1007 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001008 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001009 int vp8_associated_payload;
1010 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1011 &vp8_associated_payload));
1012 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1013
1014 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1015
1016 // RTX codec for RED.
1017 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1018 int red_associated_payload;
1019 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1020 &red_associated_payload));
1021 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1022
1023 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1024
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001025 int associated_payload_type;
1026 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1027 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1028 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1029 // Verify default parameters has been added to the VP8 codec.
1030 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1031
1032 // Mock encoder creation. |engine| take ownership of the encoder.
1033 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1034 codec_info.is_hardware_accelerated = false;
1035 codec_info.has_internal_source = false;
1036 const webrtc::SdpVideoFormat format("VP8");
1037 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1038 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001039 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001040 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001042 .WillOnce(
1043 ::testing::DoAll(::testing::InvokeWithoutArgs(
1044 [&encoder_created]() { encoder_created.Set(); }),
1045 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001046
1047 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001048 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001049 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1050 .WillOnce(testing::Return(decoder));
1051
1052 // Create a call.
1053 webrtc::RtcEventLogNullImpl event_log;
1054 std::unique_ptr<webrtc::Call> call(
1055 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1056
1057 // Create send channel.
1058 const int send_ssrc = 123;
1059 std::unique_ptr<VideoMediaChannel> send_channel(
1060 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1061 cricket::VideoSendParameters send_parameters;
1062 send_parameters.codecs.push_back(engine_codecs.at(0));
1063 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1064 send_channel->OnReadyToSend(true);
1065 EXPECT_TRUE(
1066 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1067 EXPECT_TRUE(send_channel->SetSend(true));
1068
Niels Möller4db138e2018-04-19 09:04:13 +02001069 // Set capturer.
1070 FakeVideoCapturerWithTaskQueue capturer;
1071 EXPECT_EQ(cricket::CS_RUNNING,
1072 capturer.Start(capturer.GetSupportedFormats()->front()));
1073 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1074 // Sending one frame will allocate the encoder.
1075 EXPECT_TRUE(capturer.CaptureFrame());
1076 encoder_created.Wait(kTimeout);
1077
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001078 // Create recv channel.
1079 const int recv_ssrc = 321;
1080 std::unique_ptr<VideoMediaChannel> recv_channel(
1081 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1082 cricket::VideoRecvParameters recv_parameters;
1083 recv_parameters.codecs.push_back(engine_codecs.at(0));
1084 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1085 EXPECT_TRUE(recv_channel->AddRecvStream(
1086 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1087
1088 // Remove streams previously added to free the encoder and decoder instance.
1089 EXPECT_CALL(*encoder_factory, Die());
1090 EXPECT_CALL(*decoder_factory, Die());
1091 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1092 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1093}
1094
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001095// Test behavior when decoder factory fails to create a decoder (returns null).
1096TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1097 // |engine| take ownership of the factories.
1098 webrtc::MockVideoEncoderFactory* encoder_factory =
1099 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1100 webrtc::MockVideoDecoderFactory* decoder_factory =
1101 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1102 WebRtcVideoEngine engine(
1103 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1104 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1105 const webrtc::SdpVideoFormat vp8_format("VP8");
1106 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1107 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1108 .WillRepeatedly(testing::Return(supported_formats));
1109
1110 // Decoder creation fails.
1111 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1112 .WillOnce(testing::Return(nullptr));
1113
1114 // Create a call.
1115 webrtc::RtcEventLogNullImpl event_log;
1116 std::unique_ptr<webrtc::Call> call(
1117 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1118
1119 // Create recv channel.
1120 const int recv_ssrc = 321;
1121 std::unique_ptr<VideoMediaChannel> recv_channel(
1122 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1123 cricket::VideoRecvParameters recv_parameters;
1124 recv_parameters.codecs.push_back(engine.codecs().front());
1125 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1126 EXPECT_TRUE(recv_channel->AddRecvStream(
1127 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1128
1129 // Remove streams previously added to free the encoder and decoder instance.
1130 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1131}
1132
eladalonf1841382017-06-12 01:16:46 -07001133TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001134 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001135 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001136 std::unique_ptr<VideoMediaChannel> channel(
1137 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001138 ASSERT_TRUE(
1139 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1140 cricket::VideoCodec codec = GetEngineCodec("VP8");
1141 cricket::VideoSendParameters parameters;
1142 parameters.codecs.push_back(codec);
1143 channel->OnReadyToSend(true);
1144 channel->SetSend(true);
1145 ASSERT_TRUE(channel->SetSendParameters(parameters));
1146
Tommi85959932018-02-07 19:26:06 +01001147 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001148 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001149 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001150
1151 EXPECT_EQ(cricket::CS_RUNNING,
1152 capturer.Start(capturer.GetSupportedFormats()->front()));
1153 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001154 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001155 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001156 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001157
Niels Möllerff40b142018-04-09 08:49:14 +02001158 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001159 EXPECT_TRUE(capturer.CaptureFrame());
1160 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001161 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001162
1163 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001164 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001165 EXPECT_TRUE(capturer.CaptureFrame());
1166 // Change to screen content, recreate encoder. For the simulcast encoder
1167 // adapter case, this will result in two calls since InitEncode triggers a
1168 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001169 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001170 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001171 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001172
Niels Möllerff40b142018-04-09 08:49:14 +02001173 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001174 EXPECT_TRUE(capturer.CaptureFrame());
1175 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001176 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001177
1178 options.is_screencast.emplace(false);
1179 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001180 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001181 // Change back to regular video content, update encoder. Also change
1182 // a non |is_screencast| option just to verify it doesn't affect recreation.
1183 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001184 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001185 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001186 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001187
1188 // Remove stream previously added to free the external encoder instance.
1189 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001190 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001191}
1192
Niels Möller6557d0c2018-04-11 15:18:34 +02001193class WebRtcVideoChannelBaseTest : public testing::Test {
1194 protected:
1195 WebRtcVideoChannelBaseTest()
1196 : call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001197 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1198 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001199
1200 virtual void SetUp() {
1201 cricket::MediaConfig media_config;
1202 // Disabling cpu overuse detection actually disables quality scaling too; it
1203 // implies DegradationPreference kMaintainResolution. Automatic scaling
1204 // needs to be disabled, otherwise, tests which check the size of received
1205 // frames become flaky.
1206 media_config.video.enable_cpu_adaptation = false;
1207 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
1208 cricket::VideoOptions()));
1209 channel_->OnReadyToSend(true);
1210 EXPECT_TRUE(channel_.get() != NULL);
1211 network_interface_.SetDestination(channel_.get());
1212 channel_->SetInterface(&network_interface_);
1213 cricket::VideoRecvParameters parameters;
1214 parameters.codecs = engine_.codecs();
1215 channel_->SetRecvParameters(parameters);
1216 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1217 video_capturer_.reset(CreateFakeVideoCapturer());
1218 cricket::VideoFormat format(640, 480,
1219 cricket::VideoFormat::FpsToInterval(kFramerate),
1220 cricket::FOURCC_I420);
1221 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001222 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001223 }
1224
1225 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1226 return new cricket::FakeVideoCapturerWithTaskQueue();
1227 }
1228
1229 // Utility method to setup an additional stream to send and receive video.
1230 // Used to test send and recv between two streams.
1231 void SetUpSecondStream() {
1232 SetUpSecondStreamWithNoRecv();
1233 // Setup recv for second stream.
1234 EXPECT_TRUE(channel_->AddRecvStream(
1235 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1236 // Make the second renderer available for use by a new stream.
1237 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1238 }
1239 // Setup an additional stream just to send video. Defer add recv stream.
1240 // This is required if you want to test unsignalled recv of video rtp packets.
1241 void SetUpSecondStreamWithNoRecv() {
1242 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001243 EXPECT_TRUE(
1244 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001245 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001246 EXPECT_FALSE(
1247 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001248 EXPECT_TRUE(channel_->AddSendStream(
1249 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1250 // We dont add recv for the second stream.
1251
1252 // Setup the receive and renderer for second stream after send.
1253 video_capturer_2_.reset(CreateFakeVideoCapturer());
1254 cricket::VideoFormat format(640, 480,
1255 cricket::VideoFormat::FpsToInterval(kFramerate),
1256 cricket::FOURCC_I420);
1257 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1258
Yves Gerey665174f2018-06-19 15:03:05 +02001259 EXPECT_TRUE(
1260 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001261 }
Yves Gerey665174f2018-06-19 15:03:05 +02001262 virtual void TearDown() { channel_.reset(); }
1263 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001264
1265 bool SetOneCodec(const cricket::VideoCodec& codec) {
1266 cricket::VideoFormat capture_format(
1267 kVideoWidth, kVideoHeight,
1268 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1269
1270 if (video_capturer_) {
1271 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1272 }
1273 if (video_capturer_2_) {
1274 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1275 }
1276
1277 bool sending = channel_->sending();
1278 bool success = SetSend(false);
1279 if (success) {
1280 cricket::VideoSendParameters parameters;
1281 parameters.codecs.push_back(codec);
1282 success = channel_->SetSendParameters(parameters);
1283 }
1284 if (success) {
1285 success = SetSend(sending);
1286 }
1287 return success;
1288 }
Yves Gerey665174f2018-06-19 15:03:05 +02001289 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001290 bool SendFrame() {
1291 if (video_capturer_2_) {
1292 video_capturer_2_->CaptureFrame();
1293 }
1294 return video_capturer_.get() && video_capturer_->CaptureFrame();
1295 }
1296 bool WaitAndSendFrame(int wait_ms) {
1297 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1298 ret &= SendFrame();
1299 return ret;
1300 }
Yves Gerey665174f2018-06-19 15:03:05 +02001301 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001302 int NumRtpBytes(uint32_t ssrc) {
1303 return network_interface_.NumRtpBytes(ssrc);
1304 }
Yves Gerey665174f2018-06-19 15:03:05 +02001305 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001306 int NumRtpPackets(uint32_t ssrc) {
1307 return network_interface_.NumRtpPackets(ssrc);
1308 }
Yves Gerey665174f2018-06-19 15:03:05 +02001309 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001310 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1311 return network_interface_.GetRtpPacket(index);
1312 }
1313 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001314 webrtc::RTPHeader header;
1315 EXPECT_TRUE(ParseRtpPacket(p, &header));
1316 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001317 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001318
Niels Möller6557d0c2018-04-11 15:18:34 +02001319 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001320 webrtc::RTPHeader* header) {
1321 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1322 webrtc::RtpHeaderParser::Create());
1323 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001324 }
1325
1326 // Tests that we can send and receive frames.
1327 void SendAndReceive(const cricket::VideoCodec& codec) {
1328 EXPECT_TRUE(SetOneCodec(codec));
1329 EXPECT_TRUE(SetSend(true));
1330 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1331 EXPECT_EQ(0, renderer_.num_rendered_frames());
1332 EXPECT_TRUE(SendFrame());
1333 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1334 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1335 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1336 }
1337
1338 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001339 int duration_sec,
1340 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001341 EXPECT_TRUE(SetOneCodec(codec));
1342 EXPECT_TRUE(SetSend(true));
1343 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1344 EXPECT_EQ(0, renderer_.num_rendered_frames());
1345 for (int i = 0; i < duration_sec; ++i) {
1346 for (int frame = 1; frame <= fps; ++frame) {
1347 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1348 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1349 }
1350 }
1351 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1352 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1353 }
1354
Niels Möller6557d0c2018-04-11 15:18:34 +02001355 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1356 cricket::VideoMediaInfo info;
1357 EXPECT_TRUE(channel_->GetStats(&info));
1358 return info.senders[i];
1359 }
1360
1361 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1362 cricket::VideoMediaInfo info;
1363 EXPECT_TRUE(channel_->GetStats(&info));
1364 return info.receivers[i];
1365 }
1366
1367 // Two streams one channel tests.
1368
1369 // Tests that we can send and receive frames.
1370 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1371 SetUpSecondStream();
1372 // Test sending and receiving on first stream.
1373 SendAndReceive(codec);
1374 // Test sending and receiving on second stream.
1375 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1376 EXPECT_GT(NumRtpPackets(), 0);
1377 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1378 }
1379
1380 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1381 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1382 if (CodecNamesEq(name, engine_codec.name))
1383 return engine_codec;
1384 }
1385 // This point should never be reached.
1386 ADD_FAILURE() << "Unrecognized codec name: " << name;
1387 return cricket::VideoCodec();
1388 }
1389
1390 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1391
1392 cricket::StreamParams DefaultSendStreamParams() {
1393 return cricket::StreamParams::CreateLegacy(kSsrc);
1394 }
1395
1396 webrtc::RtcEventLogNullImpl event_log_;
1397 const std::unique_ptr<webrtc::Call> call_;
1398 WebRtcVideoEngine engine_;
1399 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1400 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1401 std::unique_ptr<WebRtcVideoChannel> channel_;
1402 cricket::FakeNetworkInterface network_interface_;
1403 cricket::FakeVideoRenderer renderer_;
1404
1405 // Used by test cases where 2 streams are run on the same channel.
1406 cricket::FakeVideoRenderer renderer2_;
1407};
1408
1409// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001410TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001411 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001412 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001413 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1414 EXPECT_FALSE(channel_->sending());
1415 EXPECT_TRUE(SetSend(true));
1416 EXPECT_TRUE(channel_->sending());
1417 EXPECT_TRUE(SendFrame());
1418 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1419 EXPECT_TRUE(SetSend(false));
1420 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001421}
Niels Möller6557d0c2018-04-11 15:18:34 +02001422
1423// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001424TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001425 EXPECT_FALSE(channel_->sending());
1426 EXPECT_FALSE(SetSend(true));
1427 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001428}
Niels Möller6557d0c2018-04-11 15:18:34 +02001429
1430// Test that we properly set the send and recv buffer sizes by the time
1431// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001432TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001433 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1434 EXPECT_TRUE(SetSend(true));
1435 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1436 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001437}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001438
Niels Möller6557d0c2018-04-11 15:18:34 +02001439// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001440TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001441 const int kDurationSec = 3;
1442 const int kFps = 10;
1443 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1444
1445 cricket::VideoMediaInfo info;
1446 EXPECT_TRUE(channel_->GetStats(&info));
1447
1448 ASSERT_EQ(1U, info.senders.size());
1449 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1450 // For webrtc, bytes_sent does not include the RTP header length.
1451 EXPECT_GT(info.senders[0].bytes_sent, 0);
1452 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1453 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1454 ASSERT_TRUE(info.senders[0].codec_payload_type);
1455 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1456 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1457 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1458 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1459 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1460 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1461 EXPECT_GT(info.senders[0].framerate_input, 0);
1462 EXPECT_GT(info.senders[0].framerate_sent, 0);
1463
1464 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1465 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1466 info.send_codecs[DefaultCodec().id]);
1467
1468 ASSERT_EQ(1U, info.receivers.size());
1469 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1470 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1471 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1472 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1473 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1474 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1475 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1476 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1477 EXPECT_EQ(0, info.receivers[0].packets_lost);
1478 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1479 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1480 EXPECT_EQ(0, info.receivers[0].firs_sent);
1481 EXPECT_EQ(0, info.receivers[0].plis_sent);
1482 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1483 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1484 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1485 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1486 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1487 EXPECT_GT(info.receivers[0].framerate_output, 0);
1488
1489 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1490 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1491 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001492}
Niels Möller6557d0c2018-04-11 15:18:34 +02001493
1494// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001495TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001496 cricket::FakeVideoRenderer renderer1, renderer2;
1497 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1498 cricket::VideoSendParameters parameters;
1499 parameters.codecs.push_back(DefaultCodec());
1500 parameters.conference_mode = true;
1501 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1502 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001503 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1504 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001505 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1506 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1507 EXPECT_EQ(0, renderer1.num_rendered_frames());
1508 EXPECT_EQ(0, renderer2.num_rendered_frames());
1509 std::vector<uint32_t> ssrcs;
1510 ssrcs.push_back(1);
1511 ssrcs.push_back(2);
1512 network_interface_.SetConferenceMode(true, ssrcs);
1513 EXPECT_TRUE(SendFrame());
1514 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1515 kTimeout);
1516 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1517 kTimeout);
1518
1519 EXPECT_TRUE(channel_->SetSend(false));
1520
1521 cricket::VideoMediaInfo info;
1522 EXPECT_TRUE(channel_->GetStats(&info));
1523 ASSERT_EQ(1U, info.senders.size());
1524 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1525 // For webrtc, bytes_sent does not include the RTP header length.
1526 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1527 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1528 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1529 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1530
1531 ASSERT_EQ(2U, info.receivers.size());
1532 for (size_t i = 0; i < info.receivers.size(); ++i) {
1533 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1534 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1535 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001536 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001537 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1538 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1539 }
srtee0c2eea2017-12-15 17:44:33 +01001540}
Niels Möller6557d0c2018-04-11 15:18:34 +02001541
1542// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001543TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001544 // Normal setup; note that we set the SSRC explicitly to ensure that
1545 // it will come first in the senders map.
1546 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1547 cricket::VideoSendParameters parameters;
1548 parameters.codecs.push_back(DefaultCodec());
1549 parameters.conference_mode = true;
1550 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001551 EXPECT_TRUE(
1552 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001553 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1554 EXPECT_TRUE(SetSend(true));
1555 EXPECT_TRUE(SendFrame());
1556 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1557 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1558
1559 // Add an additional capturer, and hook up a renderer to receive it.
1560 cricket::FakeVideoRenderer renderer2;
1561 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1562 CreateFakeVideoCapturer());
1563 const int kTestWidth = 160;
1564 const int kTestHeight = 120;
1565 cricket::VideoFormat format(kTestWidth, kTestHeight,
1566 cricket::VideoFormat::FpsToInterval(5),
1567 cricket::FOURCC_I420);
1568 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001569 EXPECT_TRUE(
1570 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001571 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001572 EXPECT_TRUE(
1573 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001574 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1575 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001576 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1577 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001578
1579 // Get stats, and make sure they are correct for two senders. We wait until
1580 // the number of expected packets have been sent to avoid races where we
1581 // check stats before it has been updated.
1582 cricket::VideoMediaInfo info;
1583 for (uint32_t i = 0; i < kTimeout; ++i) {
1584 rtc::Thread::Current()->ProcessMessages(1);
1585 EXPECT_TRUE(channel_->GetStats(&info));
1586 ASSERT_EQ(2U, info.senders.size());
1587 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1588 NumRtpPackets()) {
1589 // Stats have been updated for both sent frames, expectations can be
1590 // checked now.
1591 break;
1592 }
1593 }
1594 EXPECT_EQ(NumRtpPackets(),
1595 info.senders[0].packets_sent + info.senders[1].packets_sent)
1596 << "Timed out while waiting for packet counts for all sent packets.";
1597 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1598 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1599 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1600 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1601 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1602 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1603 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1604 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1605 // The capturer must be unregistered here as it runs out of it's scope next.
1606 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001607}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001608
Niels Möller6557d0c2018-04-11 15:18:34 +02001609// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001610TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001611 cricket::VideoSendParameters parameters;
1612 parameters.codecs.push_back(DefaultCodec());
1613 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1614 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1615 parameters.max_bandwidth_bps = 128 * 1024;
1616 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001617}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001618
Niels Möller6557d0c2018-04-11 15:18:34 +02001619// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001620TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001621 EXPECT_TRUE(SetDefaultCodec());
1622 EXPECT_TRUE(SetSend(true));
1623 EXPECT_TRUE(SendFrame());
1624 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001625 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001626 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001627 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1628 EXPECT_EQ(kSsrc, header.ssrc);
1629
Niels Möller6557d0c2018-04-11 15:18:34 +02001630 // Packets are being paced out, so these can mismatch between the first and
1631 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001632 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1633 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001634 EXPECT_EQ(1, NumSentSsrcs());
1635 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1636 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001637}
Niels Möller6557d0c2018-04-11 15:18:34 +02001638
1639// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001640TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001641 // Remove stream added in Setup.
1642 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1643 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001644 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001645 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1646 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001647 EXPECT_TRUE(SetSend(true));
1648 EXPECT_TRUE(WaitAndSendFrame(0));
1649 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001650 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001651 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001652 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1653 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001654 // Packets are being paced out, so these can mismatch between the first and
1655 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001656 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1657 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001658 EXPECT_EQ(1, NumSentSsrcs());
1659 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1660 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001661}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001662
Niels Möller6557d0c2018-04-11 15:18:34 +02001663// Test that we can set the default video renderer before and after
1664// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001665TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001666 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1667 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001668
1669 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1670 rtc::SetBE32(packet1.data() + 8, kSsrc);
1671 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1672 EXPECT_TRUE(SetDefaultCodec());
1673 EXPECT_TRUE(SetSend(true));
1674 EXPECT_EQ(0, renderer_.num_rendered_frames());
1675 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1676 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1677 EXPECT_TRUE(SendFrame());
1678 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001679}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001680
Niels Möller6557d0c2018-04-11 15:18:34 +02001681// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001682TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001683 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1684 EXPECT_TRUE(SetSend(true));
1685 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1686 EXPECT_TRUE(SendFrame());
1687 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1688 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001689 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001690 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001691 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1692 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001693 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1694 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001695
1696 // Remove the send stream that was added during Setup.
1697 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1698 int rtp_packets = NumRtpPackets();
1699
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001701 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1702 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001703 EXPECT_EQ(rtp_packets, NumRtpPackets());
1704 // Wait 30ms to guarantee the engine does not drop the frame.
1705 EXPECT_TRUE(WaitAndSendFrame(30));
1706 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1707
1708 last_packet = NumRtpPackets() - 1;
1709 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001710 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1711 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001712}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001713
Niels Möller6557d0c2018-04-11 15:18:34 +02001714// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001715TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001716 cricket::FakeVideoRenderer renderer1, renderer2;
1717 EXPECT_TRUE(SetDefaultCodec());
1718 cricket::VideoSendParameters parameters;
1719 parameters.codecs.push_back(DefaultCodec());
1720 parameters.conference_mode = true;
1721 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1722 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001723 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1724 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1726 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1727 EXPECT_EQ(0, renderer1.num_rendered_frames());
1728 EXPECT_EQ(0, renderer2.num_rendered_frames());
1729 std::vector<uint32_t> ssrcs;
1730 ssrcs.push_back(1);
1731 ssrcs.push_back(2);
1732 network_interface_.SetConferenceMode(true, ssrcs);
1733 EXPECT_TRUE(SendFrame());
1734 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1735 kTimeout);
1736 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1737 kTimeout);
1738
1739 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1740 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1741 EXPECT_EQ(kVideoWidth, renderer1.width());
1742 EXPECT_EQ(kVideoHeight, renderer1.height());
1743 EXPECT_EQ(kVideoWidth, renderer2.width());
1744 EXPECT_EQ(kVideoHeight, renderer2.height());
1745 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1746 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001747}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001748
Niels Möller6557d0c2018-04-11 15:18:34 +02001749// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001750TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001751 using cricket::VideoCodec;
1752 using cricket::VideoOptions;
1753 using cricket::VideoFormat;
1754 using cricket::FOURCC_I420;
1755
1756 VideoCodec codec = DefaultCodec();
1757 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1758 EXPECT_TRUE(SetOneCodec(codec));
1759 EXPECT_TRUE(SetSend(true));
1760 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1761 EXPECT_EQ(0, renderer_.num_rendered_frames());
1762 EXPECT_TRUE(SendFrame());
1763 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1764 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1765 CreateFakeVideoCapturer());
1766
1767 // TODO(nisse): This testcase fails if we don't configure
1768 // screencast. It's unclear why, I see nothing obvious in this
1769 // test which is related to screencast logic.
1770 VideoOptions video_options;
1771 video_options.is_screencast = true;
1772 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1773
1774 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1775 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1776 // All capturers start generating frames with the same timestamp. ViE does
1777 // not allow the same timestamp to be used. Capture one frame before
1778 // associating the capturer with the channel.
1779 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1780
1781 int captured_frames = 1;
1782 for (int iterations = 0; iterations < 2; ++iterations) {
1783 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1784 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1785 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1786 ++captured_frames;
1787 // Wait until frame of right size is captured.
1788 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001789 format.width == renderer_.width() &&
1790 format.height == renderer_.height() &&
1791 !renderer_.black_frame(),
1792 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001793 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1794 EXPECT_EQ(format.width, renderer_.width());
1795 EXPECT_EQ(format.height, renderer_.height());
1796 captured_frames = renderer_.num_rendered_frames() + 1;
1797 EXPECT_FALSE(renderer_.black_frame());
1798 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1799 // Make sure a black frame is generated within the specified timeout.
1800 // The black frame should be the resolution of the previous frame to
1801 // prevent expensive encoder reconfigurations.
1802 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001803 format.width == renderer_.width() &&
1804 format.height == renderer_.height() &&
1805 renderer_.black_frame(),
1806 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001807 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1808 EXPECT_EQ(format.width, renderer_.width());
1809 EXPECT_EQ(format.height, renderer_.height());
1810 EXPECT_TRUE(renderer_.black_frame());
1811
1812 // The black frame has the same timestamp as the next frame since it's
1813 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1814 // not render a frame with the same timestamp so capture another frame
1815 // with the frame capturer to increment the next frame's timestamp.
1816 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1817 }
srtee0c2eea2017-12-15 17:44:33 +01001818}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001819
Niels Möller6557d0c2018-04-11 15:18:34 +02001820// Tests that if SetVideoSend is called with a NULL capturer after the
1821// capturer was already removed, the application doesn't crash (and no black
1822// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001823TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001824 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1825 EXPECT_TRUE(SetSend(true));
1826 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1827 EXPECT_EQ(0, renderer_.num_rendered_frames());
1828 EXPECT_TRUE(SendFrame());
1829 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1830 // Wait for one frame so they don't get dropped because we send frames too
1831 // tightly.
1832 rtc::Thread::Current()->ProcessMessages(30);
1833 // Remove the capturer.
1834 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1835
1836 // No capturer was added, so this SetVideoSend shouldn't do anything.
1837 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1838 rtc::Thread::Current()->ProcessMessages(300);
1839 // Verify no more frames were sent.
1840 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001841}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001842
Niels Möller6557d0c2018-04-11 15:18:34 +02001843// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001844TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001845 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1846 // interval time to avoid that.
1847 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1848 // interval time to avoid that.
1849 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001850 EXPECT_TRUE(
1851 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001852 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1853 cricket::VideoFormat capture_format(
1854 kVideoWidth, kVideoHeight,
1855 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1856 // Set up additional stream 1.
1857 cricket::FakeVideoRenderer renderer1;
1858 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001859 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001860 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001861 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001862 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1863 CreateFakeVideoCapturer());
1864 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1865 // Set up additional stream 2.
1866 cricket::FakeVideoRenderer renderer2;
1867 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001868 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001869 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001870 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001871 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1872 CreateFakeVideoCapturer());
1873 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1874 // State for all the streams.
1875 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1876 // A limitation in the lmi implementation requires that SetVideoSend() is
1877 // called after SetOneCodec().
1878 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1879 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1880 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1881 EXPECT_TRUE(SetSend(true));
1882 // Test capturer associated with engine.
1883 const int kTestWidth = 160;
1884 const int kTestHeight = 120;
1885 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001886 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1887 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001888 // Capture a frame with additional capturer2, frames should be received
1889 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001890 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1891 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001892 // Successfully remove the capturer.
1893 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1894 // The capturers must be unregistered here as it runs out of it's scope
1895 // next.
1896 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1897 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001898}
Niels Möller6557d0c2018-04-11 15:18:34 +02001899
1900// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001901TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001902 // Remove the send stream that was added during Setup.
1903 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1904
1905 cricket::StreamParams empty;
1906 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001907 EXPECT_TRUE(
1908 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001909}
Niels Möller6557d0c2018-04-11 15:18:34 +02001910
1911// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001912TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001913 // Remove stream added in Setup. I.e. remove stream corresponding to default
1914 // channel.
1915 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001916 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001917 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1918 EXPECT_TRUE(channel_->AddSendStream(
1919 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1920 }
1921 // Delete one of the non default channel streams, let the destructor delete
1922 // the remaining ones.
1923 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1924 // Stream should already be deleted.
1925 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001926}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001927
eladalonf1841382017-06-12 01:16:46 -07001928TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001929 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001930}
1931
eladalonf1841382017-06-12 01:16:46 -07001932TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001933 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001934}
1935
eladalonf1841382017-06-12 01:16:46 -07001936TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001937 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001938}
1939
eladalonf1841382017-06-12 01:16:46 -07001940TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001941 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1942 // bitrates. This currently happens at <250k, and two streams sharing 300k
1943 // initially will use QVGA instead of VGA.
1944 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1945 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001946 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02001947 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02001948 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001949}
1950
eladalonf1841382017-06-12 01:16:46 -07001951class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001952 public:
eladalonf1841382017-06-12 01:16:46 -07001953 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
1954 explicit WebRtcVideoChannelTest(const char* field_trials)
1955 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001956 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001957 encoder_factory_->AddSupportedVideoCodecType("VP8");
1958 encoder_factory_->AddSupportedVideoCodecType("VP9");
1959#if defined(WEBRTC_USE_H264)
1960 encoder_factory_->AddSupportedVideoCodecType("H264");
1961#endif
1962
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001963 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08001964 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
1965 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08001966 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001967 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001968 send_parameters_.codecs = engine_.codecs();
1969 recv_parameters_.codecs = engine_.codecs();
1970 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001971 }
1972
1973 protected:
1974 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001975 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001976 }
1977
1978 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001979 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001980 EXPECT_TRUE(channel_->AddSendStream(sp));
1981 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001982 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001983 EXPECT_EQ(num_streams + 1, streams.size());
1984 return streams[streams.size() - 1];
1985 }
1986
1987 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001988 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001989 }
1990
1991 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001992 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001993 }
1994
1995 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001996 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001997 EXPECT_TRUE(channel_->AddRecvStream(sp));
1998 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00001999 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002000 EXPECT_EQ(num_streams + 1, streams.size());
2001 return streams[streams.size() - 1];
2002 }
2003
pbos@webrtc.org00873182014-11-25 14:03:34 +00002004 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2005 int expected_min_bitrate_bps,
2006 const char* start_bitrate_kbps,
2007 int expected_start_bitrate_bps,
2008 const char* max_bitrate_kbps,
2009 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002010 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2011 expected_start_bitrate_bps,
2012 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002013 auto& codecs = send_parameters_.codecs;
2014 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002015 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002016 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2017 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2018 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002019 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002020 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002021
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002022 void ExpectSetBitrateParameters(int min_bitrate_bps,
2023 int start_bitrate_bps,
2024 int max_bitrate_bps) {
2025 EXPECT_CALL(
2026 *fake_call_->GetMockTransportControllerSend(),
2027 SetSdpBitrateParameters(AllOf(
2028 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2029 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2030 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2031 }
2032
2033 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2034 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2035 SetSdpBitrateParameters(Field(
2036 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002037 }
2038
isheriff6f8d6862016-05-26 11:24:55 -07002039 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002040 // Enable extension.
2041 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002042 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002043 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002044 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002045 FakeVideoSendStream* send_stream =
2046 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2047
2048 // Verify the send extension id.
2049 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2050 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002051 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002052 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002053 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002054 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2055 // receivers.
2056 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2057 ->GetConfig()
2058 .rtp.extensions.empty());
2059
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002060 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002061 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002062 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2063 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002064 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2065
2066 // Verify that adding receive RTP header extensions adds them for existing
2067 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002068 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002069 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002070 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2071 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002072 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002073 }
2074
isheriff6f8d6862016-05-26 11:24:55 -07002075 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002076 // Enable extension.
2077 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002078 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002079 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002080 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002081
2082 FakeVideoReceiveStream* recv_stream =
2083 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2084
2085 // Verify the recv extension id.
2086 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2087 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002088 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002089 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002090 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002091
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002092 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2093 // senders.
2094 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2095 ->GetConfig()
2096 .rtp.extensions.empty());
2097
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002098 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002099 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002100 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2101 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002102 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2103
2104 // Verify that adding receive RTP header extensions adds them for existing
2105 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002106 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002107 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002108 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2109 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002110 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002111 }
2112
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002113 void TestExtensionFilter(const std::vector<std::string>& extensions,
2114 const std::string& expected_extension) {
2115 cricket::VideoSendParameters parameters = send_parameters_;
2116 int expected_id = -1;
2117 int id = 1;
2118 for (const std::string& extension : extensions) {
2119 if (extension == expected_extension)
2120 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002121 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002122 }
2123 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2124 FakeVideoSendStream* send_stream =
2125 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2126
2127 // Verify that only one of them has been set, and that it is the one with
2128 // highest priority (transport sequence number).
2129 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2130 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2131 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002132 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002133 }
2134
asapersson3c81a1a2017-06-14 05:52:21 -07002135 void TestDegradationPreference(bool resolution_scaling_enabled,
2136 bool fps_scaling_enabled);
2137
Erik Språngefbde372015-04-29 16:21:28 +02002138 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002139 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002140 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2141 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002142
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002143 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002144 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002145 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002146 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002147 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002148 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002149 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002150 // Options only take effect on the next frame.
2151 EXPECT_TRUE(capturer->CaptureFrame());
2152
Erik Språng143cec12015-04-28 10:01:41 +02002153 return fake_call_->GetVideoSendStreams().back();
2154 }
2155
Peter Boström2feafdb2015-09-09 14:32:14 +02002156 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2157 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002158 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002159 std::vector<uint32_t> ssrcs;
2160 std::vector<uint32_t> rtx_ssrcs;
2161 uint32_t num_streams = enabled ? 3 : 1;
2162 for (uint32_t i = 0; i < num_streams; ++i) {
2163 uint32_t ssrc = last_ssrc_ + i;
2164 ssrcs.push_back(ssrc);
2165 if (with_rtx) {
2166 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2167 }
Erik Språng143cec12015-04-28 10:01:41 +02002168 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002169 if (with_rtx) {
2170 return AddSendStream(
2171 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2172 }
2173 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002174 }
2175
perkjfa10b552016-10-02 23:45:26 -07002176 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002177 std::vector<FakeVideoSendStream*> streams =
2178 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002179 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002180 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002181 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002182 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002183 }
2184
perkjfa10b552016-10-02 23:45:26 -07002185 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002186 int stream_max,
2187 int expected_encoder_bitrate) {
2188 VideoSendParameters limited_send_params = send_parameters_;
2189 limited_send_params.max_bandwidth_bps = global_max;
2190 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002191 webrtc::RtpParameters parameters =
2192 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002193 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002194 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002195 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002196 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002197 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002198 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002199 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002200 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002201 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002202 }
2203
Åsa Persson55659812018-06-18 17:51:32 +02002204 // Values from kSimulcastConfigs in simulcast.cc.
2205 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2206 std::vector<webrtc::VideoStream> layers(3);
2207 layers[0].min_bitrate_bps = 30000;
2208 layers[0].target_bitrate_bps = 150000;
2209 layers[0].max_bitrate_bps = 200000;
2210 layers[1].min_bitrate_bps = 150000;
2211 layers[1].target_bitrate_bps = 500000;
2212 layers[1].max_bitrate_bps = 700000;
2213 layers[2].min_bitrate_bps = 600000;
2214 layers[2].target_bitrate_bps = 2500000;
2215 layers[2].max_bitrate_bps = 2500000;
2216 return layers;
2217 }
2218
kwiberg686a8ef2016-02-26 03:00:35 -08002219 std::unique_ptr<FakeCall> fake_call_;
2220 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002221 cricket::VideoSendParameters send_parameters_;
2222 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002223 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002224};
2225
eladalonf1841382017-06-12 01:16:46 -07002226TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002227 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002228 const std::string kSyncLabel = "AvSyncLabel";
2229
2230 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002231 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002232 EXPECT_TRUE(channel_->AddRecvStream(sp));
2233
Mirko Bonadeif859e552018-05-30 15:31:29 +02002234 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002235 EXPECT_EQ(kSyncLabel,
2236 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2237 << "SyncGroup should be set based on sync_label";
2238}
2239
eladalonf1841382017-06-12 01:16:46 -07002240TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002241 cricket::VideoSendParameters parameters;
2242 parameters.codecs = engine_.codecs();
2243 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002244 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002245 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002246 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002247
2248 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002249 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2250 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002251 FakeVideoSendStream* send_stream = AddSendStream(
2252 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2253
2254 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2255 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2256 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2257
2258 // Receiver side.
2259 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2260 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002261 EXPECT_FALSE(
2262 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002263 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002264 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002265 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002266 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002267 << "RTX should be mapped for the RED payload type";
2268
brandtr14742122017-01-27 04:53:07 -08002269 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002270}
2271
eladalonf1841382017-06-12 01:16:46 -07002272TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002273 // Setup one channel with an associated RTX stream.
2274 cricket::StreamParams params =
2275 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2276 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2277 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002278 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002279
2280 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2281 << "RTX should be mapped for all decoders/payload types.";
2282 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002283 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002284 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002285}
2286
eladalonf1841382017-06-12 01:16:46 -07002287TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002288 // Setup one channel without an associated RTX stream.
2289 cricket::StreamParams params =
2290 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2291 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002292 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002293}
2294
eladalonf1841382017-06-12 01:16:46 -07002295TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002296 FakeVideoSendStream* send_stream =
2297 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2298 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2299
2300 FakeVideoReceiveStream* recv_stream =
2301 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2302 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002303}
2304
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002305// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002306TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002307 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002308}
isheriff6f8d6862016-05-26 11:24:55 -07002309
eladalonf1841382017-06-12 01:16:46 -07002310TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002311 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002312}
2313
2314// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002315TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002316 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002317}
isheriff6f8d6862016-05-26 11:24:55 -07002318
eladalonf1841382017-06-12 01:16:46 -07002319TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002320 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002321}
2322
eladalonf1841382017-06-12 01:16:46 -07002323TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002324 // Enable three redundant extensions.
2325 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002326 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2327 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2328 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2329 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002330}
2331
eladalonf1841382017-06-12 01:16:46 -07002332TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002333 // Enable two redundant extensions.
2334 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002335 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2336 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2337 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002338}
2339
stefanc1aeaf02015-10-15 07:26:07 -07002340// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002341TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002342 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002343}
eladalonf1841382017-06-12 01:16:46 -07002344TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002345 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002346}
2347
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002348// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002349TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002350 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002351}
eladalonf1841382017-06-12 01:16:46 -07002352TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002353 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002354}
2355
eladalonf1841382017-06-12 01:16:46 -07002356TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002357 const int kAbsSendTimeId = 1;
2358 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002359 send_parameters_.extensions.push_back(
2360 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2361 send_parameters_.extensions.push_back(
2362 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002363
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002364 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002365 FakeVideoSendStream* send_stream =
2366 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2367
2368 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002369 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002370
2371 // Setting the same extensions (even if in different order) shouldn't
2372 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002373 std::reverse(send_parameters_.extensions.begin(),
2374 send_parameters_.extensions.end());
2375 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002376
2377 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2378
2379 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002380 send_parameters_.extensions.resize(1);
2381 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002382
2383 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2384}
2385
eladalonf1841382017-06-12 01:16:46 -07002386TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002387 const int kTOffsetId = 1;
2388 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002389 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002390 recv_parameters_.extensions.push_back(
2391 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2392 recv_parameters_.extensions.push_back(
2393 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2394 recv_parameters_.extensions.push_back(
2395 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002396
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002397 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002398 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002399 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2400
2401 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002402 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002403
2404 // Setting the same extensions (even if in different order) shouldn't
2405 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002406 std::reverse(recv_parameters_.extensions.begin(),
2407 recv_parameters_.extensions.end());
2408 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002409
2410 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2411
2412 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002413 recv_parameters_.extensions.resize(1);
2414 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002415
2416 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2417}
2418
eladalonf1841382017-06-12 01:16:46 -07002419TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002420 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002421 const int kUnsupportedId = 1;
2422 const int kTOffsetId = 2;
2423
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002424 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002425 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002426 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002427 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002428 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002429 FakeVideoSendStream* send_stream =
2430 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2431
2432 // Only timestamp offset extension is set to send stream,
2433 // unsupported rtp extension is ignored.
2434 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002435 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2436 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002437}
2438
eladalonf1841382017-06-12 01:16:46 -07002439TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002440 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002441 const int kUnsupportedId = 1;
2442 const int kTOffsetId = 2;
2443
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002444 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002445 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002446 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002447 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002448 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002449 FakeVideoReceiveStream* recv_stream =
2450 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2451
2452 // Only timestamp offset extension is set to receive stream,
2453 // unsupported rtp extension is ignored.
2454 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002455 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2456 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002457}
2458
eladalonf1841382017-06-12 01:16:46 -07002459TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002460 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002461 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002462 send_parameters_.extensions.push_back(
2463 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002464 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002465 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2466 }
2467}
2468
eladalonf1841382017-06-12 01:16:46 -07002469TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002470 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002471 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002472 recv_parameters_.extensions.push_back(
2473 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002474 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002475 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2476 }
2477}
2478
eladalonf1841382017-06-12 01:16:46 -07002479TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002480 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002481 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002482 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002483 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002484 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002485 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002486
2487 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002488 send_parameters_.extensions.clear();
2489 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002490 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002491 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2492 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002493}
2494
eladalonf1841382017-06-12 01:16:46 -07002495TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002496 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002497 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002498 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002499 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002500 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002501 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002502
2503 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002504 recv_parameters_.extensions.clear();
2505 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002506 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002507 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2508 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002509}
2510
eladalonf1841382017-06-12 01:16:46 -07002511TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002512 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002513 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002514}
2515
eladalonf1841382017-06-12 01:16:46 -07002516TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002517 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002518 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002519}
2520
eladalonf1841382017-06-12 01:16:46 -07002521TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002522 FakeVideoReceiveStream* stream = AddRecvStream();
2523 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002524}
2525
eladalonf1841382017-06-12 01:16:46 -07002526TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002527 FakeVideoReceiveStream* stream = AddRecvStream();
2528 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2529}
2530
eladalonf1841382017-06-12 01:16:46 -07002531TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002532 FakeVideoReceiveStream* stream = AddRecvStream();
2533 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2534
Peter Boström126c03e2015-05-11 12:48:12 +02002535 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002536 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002537 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002538 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2539 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002540 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002541 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2542
2543 // Verify that REMB is turned on when setting default codecs since the
2544 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002545 parameters.codecs = engine_.codecs();
2546 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002547 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002548 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002549}
2550
eladalonf1841382017-06-12 01:16:46 -07002551TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002552 FakeVideoReceiveStream* stream = AddRecvStream();
2553 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2554
2555 // Verify that transport cc feedback is turned off when send(!) codecs without
2556 // transport cc feedback are set.
2557 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002558 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002559 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2560 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2561 stream = fake_call_->GetVideoReceiveStreams()[0];
2562 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2563
2564 // Verify that transport cc feedback is turned on when setting default codecs
2565 // since the default codecs have transport cc feedback enabled.
2566 parameters.codecs = engine_.codecs();
2567 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2568 stream = fake_call_->GetVideoReceiveStreams()[0];
2569 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2570}
2571
eladalonf1841382017-06-12 01:16:46 -07002572TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002573 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002574 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2575
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002576 cricket::VideoSendParameters parameters;
2577 parameters.codecs = engine_.codecs();
2578 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002579 EXPECT_TRUE(channel_->SetSend(true));
2580
2581 // Send side.
2582 FakeVideoSendStream* send_stream =
2583 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2584 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2585
2586 // Receiver side.
2587 FakeVideoReceiveStream* recv_stream =
2588 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2589 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2590
2591 // Nack history size should match between sender and receiver.
2592 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2593 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002594}
2595
eladalonf1841382017-06-12 01:16:46 -07002596TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002597 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002598 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002599
2600 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2601 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2602
2603 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002604 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002605 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002606 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2607 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002608 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2609 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2610 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002611 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2612
Peter Boström67c9df72015-05-11 14:34:58 +02002613 // Verify that NACK is turned on when setting default codecs since the
2614 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002615 parameters.codecs = engine_.codecs();
2616 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002617 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2618 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2619 send_stream = fake_call_->GetVideoSendStreams()[0];
2620 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002621}
2622
Peter Boströme7ba0862016-03-12 00:02:28 +01002623// This test verifies that new frame sizes reconfigures encoders even though not
2624// (yet) sending. The purpose of this is to permit encoding as quickly as
2625// possible once we start sending. Likely the frames being input are from the
2626// same source that will be sent later, which just means that we're ready
2627// earlier.
eladalonf1841382017-06-12 01:16:46 -07002628TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002629 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002630 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002631 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2632 channel_->SetSend(false);
2633
2634 FakeVideoSendStream* stream = AddSendStream();
2635
perkjfa10b552016-10-02 23:45:26 -07002636 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002637 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002638 EXPECT_EQ(0u, streams[0].width);
2639 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002640
Tommi85959932018-02-07 19:26:06 +01002641 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002642 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002643 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2644 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002645 EXPECT_TRUE(capturer.CaptureFrame());
2646
2647 // Frame entered, should be reconfigured to new dimensions.
2648 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002649 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2650 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2651 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002652
Niels Möllerff40b142018-04-09 08:49:14 +02002653 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002654}
2655
eladalonf1841382017-06-12 01:16:46 -07002656TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002657 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002658 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002659 cricket::VideoSendParameters parameters;
2660 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002661 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002662 AddSendStream();
2663
Tommi85959932018-02-07 19:26:06 +01002664 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002665 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002666 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002667 EXPECT_TRUE(
2668 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002669 cricket::VideoFormat capture_format_hd =
2670 capturer.GetSupportedFormats()->front();
2671 EXPECT_EQ(1280, capture_format_hd.width);
2672 EXPECT_EQ(720, capture_format_hd.height);
2673 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2674
2675 EXPECT_TRUE(channel_->SetSend(true));
2676
2677 EXPECT_TRUE(capturer.CaptureFrame());
2678 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2679 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2680
2681 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2682
2683 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002684 webrtc::VideoEncoderConfig encoder_config =
2685 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002686 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002687 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002688 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002689 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2690 streams.front().width);
2691 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2692 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002693 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2694 << "Non-screenshare shouldn't use min-transmit bitrate.";
2695
Niels Möllerff40b142018-04-09 08:49:14 +02002696 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002697 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002698 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002699 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002700 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002701 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002702 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002703 // Send stream recreated after option change.
2704 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2705 send_stream = fake_call_->GetVideoSendStreams().front();
2706 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002707
2708 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002709 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002710 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002711 encoder_config.content_type);
2712 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2713 encoder_config.min_transmit_bitrate_bps);
2714
perkjfa10b552016-10-02 23:45:26 -07002715 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002716 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2717 streams.front().width);
2718 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2719 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002720 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002721 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002722}
2723
eladalonf1841382017-06-12 01:16:46 -07002724TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002725 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002726 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002727 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002728 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002729
2730 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002731 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002732 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002733 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002734 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002735 cricket::VideoFormat capture_format_hd =
2736 capturer.GetSupportedFormats()->front();
2737 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2738
2739 EXPECT_TRUE(channel_->SetSend(true));
2740
2741 EXPECT_TRUE(capturer.CaptureFrame());
2742 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2743 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2744
perkj26091b12016-09-01 01:17:40 -07002745 webrtc::VideoEncoderConfig encoder_config =
2746 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002747
2748 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002749 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002750 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002751 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002752
2753 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2754 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002755 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002756 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002757 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002758
Niels Möllerff40b142018-04-09 08:49:14 +02002759 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002760}
2761
eladalonf1841382017-06-12 01:16:46 -07002762TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002763 FakeVideoSendStream* stream = AddSendStream();
2764 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2765}
2766
eladalonf1841382017-06-12 01:16:46 -07002767TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002768 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002769 media_config.video.suspend_below_min_bitrate = true;
2770
2771 channel_.reset(
2772 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002773 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002774
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002775 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002776
2777 FakeVideoSendStream* stream = AddSendStream();
2778 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2779
nisse0db023a2016-03-01 04:29:59 -08002780 media_config.video.suspend_below_min_bitrate = false;
2781 channel_.reset(
2782 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002783 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002784
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002785 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002786
nisse0db023a2016-03-01 04:29:59 -08002787 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002788 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2789}
2790
eladalonf1841382017-06-12 01:16:46 -07002791TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002792 FakeVideoSendStream* stream = AddSendStream();
2793 webrtc::VideoCodecVP8 vp8_settings;
2794 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2795 EXPECT_TRUE(vp8_settings.denoisingOn);
2796}
2797
eladalonf1841382017-06-12 01:16:46 -07002798TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002799 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002800 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002801 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002802
Peter Boström2feafdb2015-09-09 14:32:14 +02002803 // Single-stream settings should apply with RTX as well (verifies that we
2804 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2805 // both RTX and regular SSRCs).
2806 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002807
Tommi85959932018-02-07 19:26:06 +01002808 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002809 EXPECT_EQ(cricket::CS_RUNNING,
2810 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002811 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002812 channel_->SetSend(true);
2813
2814 EXPECT_TRUE(capturer.CaptureFrame());
2815
pbos4cba4eb2015-10-26 11:18:18 -07002816 webrtc::VideoCodecVP8 vp8_settings;
2817 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2818 EXPECT_TRUE(vp8_settings.denoisingOn)
2819 << "VP8 denoising should be on by default.";
2820
nisse05103312016-03-16 02:22:50 -07002821 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002822
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002823 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2824 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002825 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2826 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002827
nisse05103312016-03-16 02:22:50 -07002828 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002829
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002830 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2831 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002832 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2833 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2834
Niels Möllerff40b142018-04-09 08:49:14 +02002835 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002836 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002837 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002838 channel_->SetSend(true);
2839 EXPECT_TRUE(capturer.CaptureFrame());
2840
Mirko Bonadeif859e552018-05-30 15:31:29 +02002841 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002842 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2843 // Autmatic resize off when using simulcast.
2844 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2845 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2846
2847 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002848 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002849 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002850 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002851
nisse05103312016-03-16 02:22:50 -07002852 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002853
Mirko Bonadeif859e552018-05-30 15:31:29 +02002854 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002855 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2856 EXPECT_FALSE(vp8_settings.denoisingOn);
2857 // Resizing and frame dropping always off for screen sharing.
2858 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2859 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2860
nisse05103312016-03-16 02:22:50 -07002861 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002862
2863 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2864 EXPECT_FALSE(vp8_settings.denoisingOn);
2865 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2866 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2867
Niels Möllerff40b142018-04-09 08:49:14 +02002868 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002869}
2870
deadbeef119760a2016-04-04 11:43:27 -07002871// Test that setting the same options doesn't result in the encoder being
2872// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002873TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002874 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002875 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002876
perkjfa10b552016-10-02 23:45:26 -07002877 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002878 EXPECT_EQ(cricket::CS_RUNNING,
2879 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002880 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002881 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002882 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2883 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2884
Niels Möllerff40b142018-04-09 08:49:14 +02002885 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2886 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002887 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002888 // Expect 1 reconfigurations at this point from the initial configuration.
2889 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002890
2891 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002892 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002893 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2894
2895 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002896 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002897 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002898 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2899
Niels Möllerff40b142018-04-09 08:49:14 +02002900 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002901}
2902
eladalonf1841382017-06-12 01:16:46 -07002903class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002904 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002905 Vp9SettingsTest() : Vp9SettingsTest("") {}
2906 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002907 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002908 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002909 }
2910 virtual ~Vp9SettingsTest() {}
2911
2912 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002913 void TearDown() override {
2914 // Remove references to encoder_factory_ since this will be destroyed
2915 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002916 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002917 }
Erik Språng143cec12015-04-28 10:01:41 +02002918};
2919
2920TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002921 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002922 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002923 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002924
Peter Boström2feafdb2015-09-09 14:32:14 +02002925 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002926
Tommi85959932018-02-07 19:26:06 +01002927 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002928 EXPECT_EQ(cricket::CS_RUNNING,
2929 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002930 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002931 channel_->SetSend(true);
2932
2933 EXPECT_TRUE(capturer.CaptureFrame());
2934
pbos4cba4eb2015-10-26 11:18:18 -07002935 webrtc::VideoCodecVP9 vp9_settings;
2936 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002937 EXPECT_TRUE(vp9_settings.denoisingOn)
2938 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07002939
nisse05103312016-03-16 02:22:50 -07002940 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002941
Erik Språng143cec12015-04-28 10:01:41 +02002942 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2943 EXPECT_FALSE(vp9_settings.denoisingOn);
2944 // Frame dropping always on for real time video.
2945 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2946
nisse05103312016-03-16 02:22:50 -07002947 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002948
2949 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2950 EXPECT_TRUE(vp9_settings.denoisingOn);
2951 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2952
2953 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07002954 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002955 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002956 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002957
nisse05103312016-03-16 02:22:50 -07002958 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002959
2960 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2961 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02002962 // Frame dropping always on for screen sharing.
2963 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002964
nisse05103312016-03-16 02:22:50 -07002965 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002966
2967 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2968 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02002969 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002970
Niels Möllerff40b142018-04-09 08:49:14 +02002971 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002972}
2973
Sergey Silkinf18072e2018-03-14 10:35:35 +01002974TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
2975 cricket::VideoSendParameters parameters;
2976 parameters.codecs.push_back(GetEngineCodec("VP9"));
2977 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2978
2979 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
2980
2981 FakeVideoSendStream* stream =
2982 AddSendStream(CreateSimStreamParams("cname", ssrcs));
2983
2984 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
2985 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
2986
2987 FakeVideoCapturerWithTaskQueue capturer;
2988 EXPECT_EQ(cricket::CS_RUNNING,
2989 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002990 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01002991 channel_->SetSend(true);
2992
2993 EXPECT_TRUE(capturer.CaptureFrame());
2994
2995 webrtc::VideoCodecVP9 vp9_settings;
2996 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2997
2998 const size_t kNumSpatialLayers = ssrcs.size();
2999 const size_t kNumTemporalLayers = 3;
3000 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3001 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3002
Niels Möllerff40b142018-04-09 08:49:14 +02003003 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003004}
3005
asaperssonc5dabdd2016-03-21 04:15:50 -07003006class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3007 public:
brandtr468da7c2016-11-22 02:16:47 -08003008 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003009 : Vp9SettingsTest(field_trials) {}
3010
3011 protected:
3012 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3013 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003014 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003015 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3016
3017 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3018
Tommi85959932018-02-07 19:26:06 +01003019 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003020 EXPECT_EQ(cricket::CS_RUNNING,
3021 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003022 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003023 channel_->SetSend(true);
3024
3025 EXPECT_TRUE(capturer.CaptureFrame());
3026
3027 webrtc::VideoCodecVP9 vp9_settings;
3028 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3029 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3030 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3031
Niels Möllerff40b142018-04-09 08:49:14 +02003032 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003033 }
3034};
3035
3036class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3037 public:
3038 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3039};
3040
3041TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3042 const int kNumSpatialLayers = 1;
3043 const int kNumTemporalLayers = 1;
3044 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3045}
3046
3047class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3048 public:
3049 Vp9SettingsTestWithInvalidFlag()
3050 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3051};
3052
3053TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3054 const int kNumSpatialLayers = 1;
3055 const int kNumTemporalLayers = 1;
3056 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3057}
3058
3059class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3060 public:
3061 Vp9SettingsTestWith2SL3TLFlag()
3062 : Vp9SettingsTestWithFieldTrial(
3063 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3064};
3065
3066TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3067 const int kNumSpatialLayers = 2;
3068 const int kNumTemporalLayers = 3;
3069 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3070}
3071
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003072TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3073 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3074 ASSERT_EQ(1u, streams.size());
3075 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3076}
3077
3078TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3079 webrtc::test::ScopedFieldTrials override_field_trials_(
3080 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3081 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3082 ASSERT_EQ(1u, streams.size());
3083 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3084}
3085
asapersson3c81a1a2017-06-14 05:52:21 -07003086TEST_F(WebRtcVideoChannelTest,
3087 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3088 webrtc::test::ScopedFieldTrials override_field_trials_(
3089 "WebRTC-Video-BalancedDegradation/Disabled/");
3090 const bool kResolutionScalingEnabled = true;
3091 const bool kFpsScalingEnabled = false;
3092 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3093}
3094
3095TEST_F(WebRtcVideoChannelTest,
3096 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3097 webrtc::test::ScopedFieldTrials override_field_trials_(
3098 "WebRTC-Video-BalancedDegradation/Enabled/");
3099 const bool kResolutionScalingEnabled = true;
3100 const bool kFpsScalingEnabled = true;
3101 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3102}
3103
eladalonf1841382017-06-12 01:16:46 -07003104TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003105 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003106}
3107
eladalonf1841382017-06-12 01:16:46 -07003108TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003109 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003110}
3111
eladalonf1841382017-06-12 01:16:46 -07003112TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003113 TestCpuAdaptation(true, true);
3114}
3115
eladalonf1841382017-06-12 01:16:46 -07003116TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003117 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003118 cricket::VideoSendParameters parameters;
3119 parameters.codecs.push_back(codec);
3120
kthelgason2bc68642017-02-07 07:02:22 -08003121 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08003122 channel_.reset(
3123 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003124 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003125 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3126
3127 AddSendStream();
3128
Tommi85959932018-02-07 19:26:06 +01003129 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003130 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003131 ASSERT_EQ(cricket::CS_RUNNING,
3132 capturer.Start(capturer.GetSupportedFormats()->front()));
3133 ASSERT_TRUE(channel_->SetSend(true));
3134
3135 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3136 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003137
Niels Möllera6cc0f92018-02-12 17:14:55 +01003138 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003139 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3140 EXPECT_EQ(1280, send_stream->GetLastWidth());
3141 EXPECT_EQ(720, send_stream->GetLastHeight());
3142
3143 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003144 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003145 wants.max_pixel_count =
3146 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003147 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003148 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003149 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3150 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3151 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3152
3153 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003154 wants.max_pixel_count =
3155 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003156 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003157 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003158 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3159 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3160 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3161
3162 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003163 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003164 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003165 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3166 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3167
3168 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003169 int current_pixel_count =
3170 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3171 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3172 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003173 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003174 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003175 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003176 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003177 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003178 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003179 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3180 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3181
sprang84a37592017-02-10 07:04:27 -08003182 // Trigger underuse again, should go back up to full resolution.
3183 current_pixel_count =
3184 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003185 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003186 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003187 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003188 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003189 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003190 EXPECT_EQ(1284, send_stream->GetLastWidth());
3191 EXPECT_EQ(724, send_stream->GetLastHeight());
3192
Niels Möllerff40b142018-04-09 08:49:14 +02003193 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003194}
3195
eladalonf1841382017-06-12 01:16:46 -07003196TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003197 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003198 cricket::VideoSendParameters parameters;
3199 parameters.codecs.push_back(codec);
3200
kthelgason2bc68642017-02-07 07:02:22 -08003201 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003202 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02003203 channel_.reset(
3204 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003205 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003206 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3207
3208 AddSendStream();
3209
Tommi85959932018-02-07 19:26:06 +01003210 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003211 ASSERT_EQ(cricket::CS_RUNNING,
3212 capturer.Start(capturer.GetSupportedFormats()->front()));
3213 ASSERT_TRUE(channel_->SetSend(true));
3214 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003215 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003216 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003217
3218 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3219 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003220
Niels Möllera6cc0f92018-02-12 17:14:55 +01003221 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003222 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3223 EXPECT_EQ(1280, send_stream->GetLastWidth());
3224 EXPECT_EQ(720, send_stream->GetLastHeight());
3225
3226 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003227 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003228 wants.max_pixel_count =
3229 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003230 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003231 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003232 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3233 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3234 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3235
3236 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003237 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003238 ASSERT_EQ(cricket::CS_RUNNING,
3239 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003240 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003241 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003242 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003243 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003244 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3245 send_stream = fake_call_->GetVideoSendStreams().front();
3246 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003247 EXPECT_EQ(1284, send_stream->GetLastWidth());
3248 EXPECT_EQ(724, send_stream->GetLastHeight());
3249
3250 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003251 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003252 send_stream = fake_call_->GetVideoSendStreams().front();
3253 // We have a new fake send stream, so it doesn't remember the old sink wants.
3254 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003255 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003256 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003257 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003258 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3259 send_stream = fake_call_->GetVideoSendStreams().front();
3260 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003261 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3262 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3263
Niels Möllerff40b142018-04-09 08:49:14 +02003264 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003265}
3266
asapersson3c81a1a2017-06-14 05:52:21 -07003267// TODO(asapersson): Remove this test when the balanced field trial is removed.
3268void WebRtcVideoChannelTest::TestDegradationPreference(
3269 bool resolution_scaling_enabled,
3270 bool fps_scaling_enabled) {
3271 cricket::VideoCodec codec = GetEngineCodec("VP8");
3272 cricket::VideoSendParameters parameters;
3273 parameters.codecs.push_back(codec);
3274
3275 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003276 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07003277 channel_.reset(
3278 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
3279 channel_->OnReadyToSend(true);
3280
3281 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3282
3283 AddSendStream();
3284
Tommi85959932018-02-07 19:26:06 +01003285 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003286 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003287 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003288 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3289 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3290
3291 EXPECT_TRUE(channel_->SetSend(true));
3292
3293 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3294 EXPECT_EQ(resolution_scaling_enabled,
3295 send_stream->resolution_scaling_enabled());
3296 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3297
Niels Möllerff40b142018-04-09 08:49:14 +02003298 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003299}
3300
eladalonf1841382017-06-12 01:16:46 -07003301void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3302 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003303 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003304 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003305 cricket::VideoSendParameters parameters;
3306 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003307
kthelgason2bc68642017-02-07 07:02:22 -08003308 MediaConfig media_config = GetMediaConfig();
3309 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003310 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003311 }
nisse51542be2016-02-12 02:27:06 -08003312 channel_.reset(
3313 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003314 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003315
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003316 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003317
3318 AddSendStream();
3319
Tommi85959932018-02-07 19:26:06 +01003320 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003321 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003322 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003323 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003324 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003325 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003326 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003327
3328 EXPECT_TRUE(channel_->SetSend(true));
3329
solenberge5269742015-09-08 05:13:22 -07003330 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003331
sprangc5d62e22017-04-02 23:53:04 -07003332 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003333 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003334 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3335 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003336
3337 EXPECT_TRUE(capturer.CaptureFrame());
3338 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3339
perkj26752742016-10-24 01:21:16 -07003340 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3341 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003342
Niels Möllerff40b142018-04-09 08:49:14 +02003343 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003344 return;
3345 }
3346
sprangc5d62e22017-04-02 23:53:04 -07003347 if (is_screenshare) {
3348 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3349 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3350 } else {
3351 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3352 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3353 }
3354
perkj803d97f2016-11-01 11:45:46 -07003355 // Trigger overuse.
3356 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3357
3358 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003359 if (is_screenshare) {
3360 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3361 } else {
3362 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3363 }
perkj803d97f2016-11-01 11:45:46 -07003364 send_stream->InjectVideoSinkWants(wants);
3365
sprangc5d62e22017-04-02 23:53:04 -07003366 for (int i = 0; i < kDefaultFps; ++i)
3367 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003368
sprangc5d62e22017-04-02 23:53:04 -07003369 if (is_screenshare) {
3370 // Drops every third frame.
3371 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3372 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3373 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3374 } else {
3375 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3376 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3377 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3378 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003379
3380 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003381 int last_pixel_count =
3382 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003383 if (is_screenshare) {
3384 wants.max_framerate_fps = kDefaultFps;
3385 } else {
3386 wants.max_pixel_count = last_pixel_count * 4;
3387 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3388 }
perkj803d97f2016-11-01 11:45:46 -07003389 send_stream->InjectVideoSinkWants(wants);
3390
sprangc5d62e22017-04-02 23:53:04 -07003391 for (int i = 0; i < kDefaultFps; ++i)
3392 EXPECT_TRUE(capturer.CaptureFrame());
3393
3394 if (is_screenshare) {
3395 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3396 send_stream->GetNumberOfSwappedFrames());
3397 } else {
3398 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3399 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003400
perkj26752742016-10-24 01:21:16 -07003401 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3402 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003403
Niels Möllerff40b142018-04-09 08:49:14 +02003404 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003405}
3406
eladalonf1841382017-06-12 01:16:46 -07003407TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003408 // Start at last timestamp to verify that wraparounds are estimated correctly.
3409 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3410 static const int64_t kInitialNtpTimeMs = 1247891230;
3411 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003412 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003413
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003414 FakeVideoReceiveStream* stream = AddRecvStream();
3415 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003416 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003417
nisse64ec8f82016-09-27 00:17:25 -07003418 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3419 kInitialTimestamp, 0,
3420 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003421 // Initial NTP time is not available on the first frame, but should still be
3422 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003423 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003424
3425 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003426
3427 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3428 // triggers a constant-overflow warning, hence we're calculating it explicitly
3429 // here.
3430 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3431 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003432 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003433
3434 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003435
3436 // Verify that NTP time has been correctly deduced.
3437 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003438 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003439 ASSERT_EQ(1u, info.receivers.size());
3440 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003441}
3442
eladalonf1841382017-06-12 01:16:46 -07003443TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003444 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003445 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003446
3447 VideoCodec codec;
3448 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003449 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003450
3451 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003452 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3453 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003454 FakeVideoSendStream* stream = AddSendStream(
3455 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003456 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003457
3458 // Make sure NACK and FEC are enabled on the correct payload types.
3459 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003460 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3461 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003462
3463 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3464 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003465 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003466 // TODO(juberti): Check RTCP, PLI, TMMBR.
3467}
3468
brandtr31bd2242017-05-19 05:47:46 -07003469// The following four tests ensures that FlexFEC is not activated by default
3470// when the field trials are not enabled.
3471// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3472// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003473TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003474 FakeVideoSendStream* stream = AddSendStream();
3475 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3476
brandtr3d200bd2017-01-16 06:59:19 -08003477 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003478 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3479 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003480}
3481
eladalonf1841382017-06-12 01:16:46 -07003482TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003483 FakeVideoSendStream* stream = AddSendStream(
3484 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3485 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3486
brandtr3d200bd2017-01-16 06:59:19 -08003487 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003488 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3489 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3490}
3491
Yves Gerey665174f2018-06-19 15:03:05 +02003492TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003493 AddRecvStream();
3494
3495 const std::vector<FakeFlexfecReceiveStream*>& streams =
3496 fake_call_->GetFlexfecReceiveStreams();
3497 EXPECT_TRUE(streams.empty());
3498}
3499
eladalonf1841382017-06-12 01:16:46 -07003500TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003501 AddRecvStream(
3502 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3503
3504 const std::vector<FakeFlexfecReceiveStream*>& streams =
3505 fake_call_->GetFlexfecReceiveStreams();
3506 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003507}
3508
3509// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3510// tests that use this test fixture into the corresponding "non-field trial"
3511// tests.
eladalonf1841382017-06-12 01:16:46 -07003512class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003513 public:
eladalonf1841382017-06-12 01:16:46 -07003514 WebRtcVideoChannelFlexfecRecvTest()
3515 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003516};
3517
eladalonf1841382017-06-12 01:16:46 -07003518TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003519 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3520 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3521 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3522}
3523
eladalonf1841382017-06-12 01:16:46 -07003524TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003525 AddRecvStream();
3526
3527 const std::vector<FakeFlexfecReceiveStream*>& streams =
3528 fake_call_->GetFlexfecReceiveStreams();
3529 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003530
3531 const std::vector<FakeVideoReceiveStream*>& video_streams =
3532 fake_call_->GetVideoReceiveStreams();
3533 ASSERT_EQ(1U, video_streams.size());
3534 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3535 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3536 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003537}
3538
eladalonf1841382017-06-12 01:16:46 -07003539TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003540 AddRecvStream(
3541 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3542
3543 const std::vector<FakeFlexfecReceiveStream*>& streams =
3544 fake_call_->GetFlexfecReceiveStreams();
3545 ASSERT_EQ(1U, streams.size());
3546 const FakeFlexfecReceiveStream* stream = streams.front();
3547 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3548 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3549 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3550 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3551 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003552
3553 const std::vector<FakeVideoReceiveStream*>& video_streams =
3554 fake_call_->GetVideoReceiveStreams();
3555 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003556 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3557 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003558 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003559 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003560 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003561}
3562
eladalonf1841382017-06-12 01:16:46 -07003563TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003564 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3565 cricket::VideoRecvParameters recv_parameters;
3566 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3567 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3568
3569 AddRecvStream(
3570 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3571 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003572 const std::vector<FakeVideoReceiveStream*>& video_streams =
3573 fake_call_->GetVideoReceiveStreams();
3574 ASSERT_EQ(1U, video_streams.size());
3575 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3576 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3577 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003578
3579 // Enable FlexFEC.
3580 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3581 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3582 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3583 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3584 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3585 << "Enabling FlexFEC should not create VideoReceiveStream.";
3586 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3587 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003588 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3589 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003590}
3591
eladalonf1841382017-06-12 01:16:46 -07003592TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003593 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3594 cricket::VideoRecvParameters recv_parameters;
3595 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3596 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3597 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3598
3599 AddRecvStream(
3600 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3601 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003602 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003603 const std::vector<FakeVideoReceiveStream*>& video_streams =
3604 fake_call_->GetVideoReceiveStreams();
3605 ASSERT_EQ(1U, video_streams.size());
3606 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3607 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3608 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003609
3610 // Disable FlexFEC.
3611 recv_parameters.codecs.clear();
3612 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3613 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3614 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3615 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3616 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3617 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3618 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3619 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003620 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3621 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003622}
3623
brandtr31bd2242017-05-19 05:47:46 -07003624// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3625// tests that use this test fixture into the corresponding "non-field trial"
3626// tests.
eladalonf1841382017-06-12 01:16:46 -07003627class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003628 public:
eladalonf1841382017-06-12 01:16:46 -07003629 WebRtcVideoChannelFlexfecSendRecvTest()
3630 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003631 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3632 }
3633};
3634
Yves Gerey665174f2018-06-19 15:03:05 +02003635TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003636 FakeVideoSendStream* stream = AddSendStream();
3637 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3638
brandtr3d200bd2017-01-16 06:59:19 -08003639 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3640 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3641 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003642}
3643
eladalonf1841382017-06-12 01:16:46 -07003644TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003645 FakeVideoSendStream* stream = AddSendStream(
3646 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3647 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3648
brandtr3d200bd2017-01-16 06:59:19 -08003649 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3650 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3651 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3652 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003653}
3654
eladalonf1841382017-06-12 01:16:46 -07003655TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003656 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003657 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003658 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003659
3660 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003661 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003662
brandtrb5f2c3f2016-10-04 23:28:39 -07003663 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3664 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003665}
3666
eladalonf1841382017-06-12 01:16:46 -07003667TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003668 cricket::VideoSendParameters parameters;
3669 parameters.codecs.push_back(GetEngineCodec("VP8"));
3670 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3671
3672 FakeVideoSendStream* stream = AddSendStream();
3673 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3674
brandtr3d200bd2017-01-16 06:59:19 -08003675 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003676}
3677
eladalonf1841382017-06-12 01:16:46 -07003678TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003679 AddRecvStream(
3680 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003681
3682 cricket::VideoRecvParameters recv_parameters;
3683 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3684 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3685 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003686
3687 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3688 fake_call_->GetFlexfecReceiveStreams();
3689 ASSERT_EQ(1U, flexfec_streams.size());
3690 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3691 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3692 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003693 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003694 flexfec_stream_config.payload_type);
3695 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3696 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3697 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3698 const std::vector<FakeVideoReceiveStream*>& video_streams =
3699 fake_call_->GetVideoReceiveStreams();
3700 const FakeVideoReceiveStream* video_stream = video_streams.front();
3701 const webrtc::VideoReceiveStream::Config& video_stream_config =
3702 video_stream->GetConfig();
3703 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3704 flexfec_stream_config.local_ssrc);
3705 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3706 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3707 flexfec_stream_config.rtcp_send_transport);
3708 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3709 // spec-compliant way.
3710 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3711 flexfec_stream_config.transport_cc);
3712 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3713 EXPECT_EQ(video_stream_config.rtp.extensions,
3714 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003715}
3716
brandtr31bd2242017-05-19 05:47:46 -07003717// We should not send FlexFEC, even if we advertise it, unless the right
3718// field trial is set.
3719// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003720TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003721 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3722 cricket::VideoSendParameters parameters;
3723 parameters.codecs.push_back(GetEngineCodec("VP8"));
3724 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3725 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3726
3727 FakeVideoSendStream* stream = AddSendStream();
3728 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3729
3730 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003731 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003732 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3733}
3734
eladalonf1841382017-06-12 01:16:46 -07003735TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003736 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3737 cricket::VideoSendParameters parameters;
3738 parameters.codecs.push_back(GetEngineCodec("VP8"));
3739 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3740 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3741
3742 FakeVideoSendStream* stream = AddSendStream(
3743 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3744 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3745
3746 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003747 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003748 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3749}
3750
eladalonf1841382017-06-12 01:16:46 -07003751TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003752 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003753 const int kUnusedPayloadType = 127;
3754 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3755
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003756 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003757 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003758 parameters.codecs.push_back(rtx_codec);
3759 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003760 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003761}
3762
eladalonf1841382017-06-12 01:16:46 -07003763TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003764 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003765 const int kUnusedPayloadType1 = 126;
3766 const int kUnusedPayloadType2 = 127;
3767 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3768 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3769 {
3770 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3771 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3772 cricket::VideoSendParameters parameters;
3773 parameters.codecs.push_back(GetEngineCodec("VP8"));
3774 parameters.codecs.push_back(rtx_codec);
3775 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3776 }
3777 {
3778 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3779 kUnusedPayloadType1, kUnusedPayloadType2);
3780 cricket::VideoSendParameters parameters;
3781 parameters.codecs.push_back(GetEngineCodec("VP8"));
3782 parameters.codecs.push_back(rtx_codec);
3783 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3784 << "RTX without matching video codec should be rejected.";
3785 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003786}
3787
eladalonf1841382017-06-12 01:16:46 -07003788TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003789 const int kUnusedPayloadType1 = 126;
3790 const int kUnusedPayloadType2 = 127;
3791 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3792 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3793
3794 // SSRCs for RTX.
3795 cricket::StreamParams params =
3796 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3797 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3798 AddSendStream(params);
3799
3800 // Original payload type for RTX.
3801 cricket::VideoSendParameters parameters;
3802 parameters.codecs.push_back(GetEngineCodec("VP8"));
3803 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3804 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3805 parameters.codecs.push_back(rtx_codec);
3806 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3807 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3808 const webrtc::VideoSendStream::Config& config_before =
3809 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3810 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3811 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3812 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3813
3814 // Change payload type for RTX.
3815 parameters.codecs[1].id = kUnusedPayloadType2;
3816 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3817 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3818 const webrtc::VideoSendStream::Config& config_after =
3819 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3820 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3821 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3822 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3823}
3824
eladalonf1841382017-06-12 01:16:46 -07003825TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003826 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003827 parameters.codecs.push_back(GetEngineCodec("VP8"));
3828 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003829 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003830
3831 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003832 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003833
magjed509e4fe2016-11-18 01:34:11 -08003834 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003835
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003836 parameters.codecs.pop_back();
3837 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003838 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003839 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003840 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003841 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003842 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3843}
3844
eladalonf1841382017-06-12 01:16:46 -07003845TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003846 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003847 cricket::VideoSendParameters parameters;
3848 parameters.codecs.push_back(GetEngineCodec("VP8"));
3849 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3850 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3851
3852 FakeVideoSendStream* stream = AddSendStream(
3853 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3854 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3855
brandtr3d200bd2017-01-16 06:59:19 -08003856 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3857 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003858 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3859 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3860
3861 parameters.codecs.pop_back();
3862 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3863 stream = fake_call_->GetVideoSendStreams()[0];
3864 ASSERT_TRUE(stream != nullptr);
3865 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003866 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003867 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003868}
3869
eladalonf1841382017-06-12 01:16:46 -07003870TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003871 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003872 cricket::VideoCodec codec(100, "VP8");
3873 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3874 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003875
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003876 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003877 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003878
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003879 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003880 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003881 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003882
3883 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003884 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003885
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003886 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003887 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3888 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003889 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003890 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003891 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003892 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003893}
3894
eladalonf1841382017-06-12 01:16:46 -07003895TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003896 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3897 200000);
3898}
3899
eladalonf1841382017-06-12 01:16:46 -07003900TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003901 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3902 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3903 ASSERT_EQ(1u, streams.size());
3904 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3905}
3906
eladalonf1841382017-06-12 01:16:46 -07003907TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003908 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003909 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003910}
3911
eladalonf1841382017-06-12 01:16:46 -07003912TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003913 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003914}
3915
eladalonf1841382017-06-12 01:16:46 -07003916TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003917 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3918 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3919 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003920}
3921
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003922// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3923// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003924TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003925 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3926 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3927 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3928 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003929 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003930 ExpectSetBitrateParameters(100000, 200000, 400000);
3931 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3932 // Since the codec isn't changing, start_bitrate_bps should be -1.
3933 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003934
3935 // Decrease max_bandwidth_bps.
3936 send_parameters_.max_bandwidth_bps = 350000;
3937 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003938
3939 // Now try again with the values flipped around.
3940 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3941 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003942 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003943 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003944
3945 // If we change the codec max, max_bandwidth_bps should still apply.
3946 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003947 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003948 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003949}
3950
Yves Gerey665174f2018-06-19 15:03:05 +02003951TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003952 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3953 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003954 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003955 // Setting max bitrate should keep previous min bitrate.
3956 // Setting max bitrate should not reset start bitrate.
3957 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003958 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00003959}
3960
eladalonf1841382017-06-12 01:16:46 -07003961TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003962 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003963 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003964 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08003965 // -1 means to disable max bitrate (set infinite).
3966 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003967 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003968 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003969}
3970
eladalonf1841382017-06-12 01:16:46 -07003971TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07003972 send_parameters_.max_bandwidth_bps = 99999;
3973 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003974 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003975 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07003976 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3977 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3978 stream->GetVideoStreams()[0].max_bitrate_bps);
3979
3980 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003981 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003982 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3983 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07003984 stream->GetVideoStreams()[0].max_bitrate_bps);
3985}
3986
Seth Hampsonfeec91e2018-07-13 10:41:10 -07003987// Tests that when the codec specific max bitrate and VideoSendParameters
3988// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
3989// appropriately.
3990TEST_F(WebRtcVideoChannelTest,
3991 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
3992 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3993 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3994 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3995 send_parameters_.max_bandwidth_bps = -1;
3996 AddSendStream();
3997 ExpectSetMaxBitrate(300000);
3998 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3999
4000 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4001 ASSERT_EQ(1u, video_send_streams.size());
4002 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4003 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4004 // First the max bitrate is set based upon the codec param.
4005 EXPECT_EQ(300000,
4006 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4007
4008 // The VideoSendParameters max bitrate overrides the codec's.
4009 send_parameters_.max_bandwidth_bps = 500000;
4010 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4011 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4012 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4013 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4014}
4015
4016// Tests that when the codec specific max bitrate and RtpParameters
4017// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4018// appropriately.
4019TEST_F(WebRtcVideoChannelTest,
4020 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4021 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4022 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4023 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4024 send_parameters_.max_bandwidth_bps = -1;
4025 AddSendStream();
4026 ExpectSetMaxBitrate(300000);
4027 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4028
4029 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4030 ASSERT_EQ(1u, video_send_streams.size());
4031 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4032 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4033 // First the max bitrate is set based upon the codec param.
4034 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4035
4036 // The RtpParameter max bitrate overrides the codec's.
4037 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4038 ASSERT_EQ(1u, parameters.encodings.size());
4039 parameters.encodings[0].max_bitrate_bps = 500000;
4040 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4041 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4042 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4043 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4044}
4045
Åsa Persson55659812018-06-18 17:51:32 +02004046TEST_F(WebRtcVideoChannelTest,
4047 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4048 send_parameters_.max_bandwidth_bps = 99999;
4049 FakeVideoSendStream* stream = AddSendStream();
4050 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4051 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4052 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4053 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4054 stream->GetVideoStreams()[0].max_bitrate_bps);
4055
4056 // Get and set the rtp encoding parameters.
4057 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4058 EXPECT_EQ(1u, parameters.encodings.size());
4059
4060 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4061 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4062 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4063 stream->GetVideoStreams()[0].max_bitrate_bps);
4064
4065 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4066 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4067 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4068 stream->GetVideoStreams()[0].max_bitrate_bps);
4069}
4070
eladalonf1841382017-06-12 01:16:46 -07004071TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004072 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004073 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004074 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004075 channel_->SetSend(true);
4076
4077 FakeVideoSendStream* stream = AddSendStream();
4078
Tommi85959932018-02-07 19:26:06 +01004079 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004080 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004081 EXPECT_EQ(cricket::CS_RUNNING,
4082 capturer.Start(capturer.GetSupportedFormats()->front()));
4083
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004084 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4085 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4086 EXPECT_GT(initial_max_bitrate_bps, 0);
4087
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004088 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4089 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004090 // Insert a frame to update the encoder config.
4091 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004092 streams = stream->GetVideoStreams();
4093 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004094 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004095}
4096
eladalonf1841382017-06-12 01:16:46 -07004097TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004098 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004099 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004100 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004101 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004102 channel_->SetSend(true);
4103
4104 FakeVideoSendStream* stream = AddSendStream(
4105 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4106
4107 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004108 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004109 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004110 EXPECT_EQ(cricket::CS_RUNNING,
4111 capturer.Start(capturer.GetSupportedFormats()->front()));
4112 EXPECT_TRUE(capturer.CaptureFrame());
4113
4114 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4115 ASSERT_GT(streams.size(), 1u)
4116 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004117 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004118 EXPECT_GT(initial_max_bitrate_bps, 0);
4119
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004120 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4121 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004122 // Insert a frame to update the encoder config.
4123 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004124 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004125 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004126 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4127
Niels Möllerff40b142018-04-09 08:49:14 +02004128 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004129}
4130
eladalonf1841382017-06-12 01:16:46 -07004131TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004132 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004133 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004134 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004135 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4136 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004137 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004138 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004139
4140 VideoCodec codec;
4141 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4142 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4143}
4144
eladalonf1841382017-06-12 01:16:46 -07004145TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004146 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004147 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004148 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004149 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004150 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004151 parameters.codecs[0].id = kIncorrectPayloads[i];
4152 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004153 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004154 }
4155}
4156
eladalonf1841382017-06-12 01:16:46 -07004157TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004158 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004159 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004160 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004161 parameters.codecs[0].id = payload_type;
4162 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004163 << "Payload type '" << payload_type << "' rejected.";
4164 }
4165}
4166
deadbeef67cf2c12016-04-13 10:07:16 -07004167// Test that setting the a different set of codecs but with an identical front
4168// codec doesn't result in the stream being recreated.
4169// This may happen when a subsequent negotiation includes fewer codecs, as a
4170// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004171TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004172 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4173 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004174 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4175 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004176 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4177
4178 AddSendStream();
4179 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4180
4181 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004182 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004183 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4184 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4185}
4186
eladalonf1841382017-06-12 01:16:46 -07004187TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004188 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004189 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004190 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004191}
4192
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004193// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004194TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004195 const int kUnusedPayloadType1 = 126;
4196 const int kUnusedPayloadType2 = 127;
4197 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4198 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4199
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004200 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004201 parameters.codecs.push_back(GetEngineCodec("VP8"));
4202 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004203 parameters.codecs.push_back(rtx_codec);
4204 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004205 << "RTX codec without associated payload should be rejected.";
4206
magjed509e4fe2016-11-18 01:34:11 -08004207 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004208 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004209 << "RTX codec with invalid associated payload type should be rejected.";
4210
magjed509e4fe2016-11-18 01:34:11 -08004211 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004212 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004213
magjed509e4fe2016-11-18 01:34:11 -08004214 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004215 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004216 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004217
Yves Gerey665174f2018-06-19 15:03:05 +02004218 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4219 << "RTX codec with another RTX as associated payload type should be "
4220 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004221}
4222
eladalonf1841382017-06-12 01:16:46 -07004223TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004224 const int kUnusedPayloadType1 = 126;
4225 const int kUnusedPayloadType2 = 127;
4226 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4227 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4228
4229 // SSRCs for RTX.
4230 cricket::StreamParams params =
4231 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4232 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4233 AddRecvStream(params);
4234
4235 // Original payload type for RTX.
4236 cricket::VideoRecvParameters parameters;
4237 parameters.codecs.push_back(GetEngineCodec("VP8"));
4238 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4239 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4240 parameters.codecs.push_back(rtx_codec);
4241 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4242 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4243 const webrtc::VideoReceiveStream::Config& config_before =
4244 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004245 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4246 const int* payload_type_before = FindKeyByValue(
4247 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4248 ASSERT_NE(payload_type_before, nullptr);
4249 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004250 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4251
4252 // Change payload type for RTX.
4253 parameters.codecs[1].id = kUnusedPayloadType2;
4254 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4255 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4256 const webrtc::VideoReceiveStream::Config& config_after =
4257 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004258 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4259 const int* payload_type_after = FindKeyByValue(
4260 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4261 ASSERT_NE(payload_type_after, nullptr);
4262 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004263 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4264}
4265
eladalonf1841382017-06-12 01:16:46 -07004266TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004267 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004268 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004269 parameters.codecs[0].id = 99;
4270 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004271}
4272
eladalonf1841382017-06-12 01:16:46 -07004273TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004274 cricket::VideoRecvParameters parameters;
4275 parameters.codecs = engine_.codecs();
4276 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004277
4278 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004279 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004280 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].payload_name);
4281 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004282}
4283
eladalonf1841382017-06-12 01:16:46 -07004284TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004285 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004286 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004287 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004288 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004289}
4290
eladalonf1841382017-06-12 01:16:46 -07004291TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004292 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004293 parameters.codecs.push_back(GetEngineCodec("VP8"));
4294 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004295 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004296}
4297
eladalonf1841382017-06-12 01:16:46 -07004298TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004299 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004300 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4301 send_parameters.codecs.push_back(GetEngineCodec("red"));
4302 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004303 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004304
4305 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004306
magjed509e4fe2016-11-18 01:34:11 -08004307 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004308 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004309
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004310 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004311 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004312 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004313 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004314 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004315 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004316 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4317}
4318
eladalonf1841382017-06-12 01:16:46 -07004319TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004320 AddRecvStream(
4321 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004322 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004323 fake_call_->GetFlexfecReceiveStreams();
4324
4325 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004326 const FakeFlexfecReceiveStream* stream = streams.front();
4327 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4328 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4329 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4330 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004331
4332 cricket::VideoRecvParameters recv_parameters;
4333 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4334 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4335 EXPECT_TRUE(streams.empty())
4336 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004337}
4338
eladalonf1841382017-06-12 01:16:46 -07004339TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004340 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004341 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004342 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004343
4344 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004345 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4346 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4347 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004348 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4349 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004350 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004351 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004352 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004353 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004354
4355 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004356 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4357 send_parameters.codecs.push_back(GetEngineCodec("red"));
4358 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004359 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4360 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004361 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004362 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004363 << "ULPFEC should be enabled on the receive stream.";
4364}
4365
eladalonf1841382017-06-12 01:16:46 -07004366TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004367 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004368 AddRecvStream(
4369 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004370 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004371 fake_call_->GetFlexfecReceiveStreams();
4372
4373 cricket::VideoRecvParameters recv_parameters;
4374 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4375 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4376 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4377 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004378 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004379 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004380 stream_with_recv_params->GetConfig().payload_type);
4381 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004382 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004383 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004384 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004385 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004386
4387 cricket::VideoSendParameters send_parameters;
4388 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4389 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4390 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4391 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004392 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004393 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004394 stream_with_send_params->GetConfig().payload_type);
4395 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004396 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004397 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004398 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004399 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004400}
4401
eladalonf1841382017-06-12 01:16:46 -07004402TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004403 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004404 parameters.codecs.push_back(GetEngineCodec("VP8"));
4405 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004406 parameters.codecs[1].id = parameters.codecs[0].id;
4407 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004408}
4409
eladalonf1841382017-06-12 01:16:46 -07004410TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004411 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004412 cricket::VideoRecvParameters parameters;
4413 parameters.codecs.push_back(GetEngineCodec("VP8"));
4414 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4415 parameters.codecs[1].id = parameters.codecs[0].id;
4416 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4417}
4418
eladalonf1841382017-06-12 01:16:46 -07004419TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004420 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004421 parameters.codecs.push_back(GetEngineCodec("VP8"));
4422 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004423 parameters.codecs[1].id = parameters.codecs[0].id;
4424 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004425}
4426
eladalonf1841382017-06-12 01:16:46 -07004427TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004428 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004429 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004430 parameters.codecs.push_back(GetEngineCodec("VP8"));
4431 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004432 parameters.codecs[1].id += 1;
4433 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004434}
4435
deadbeef67cf2c12016-04-13 10:07:16 -07004436// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004437// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004438TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004439 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004440 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004441 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4442 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004443 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004444
4445 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4446 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4447
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004448 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004449 parameters2.codecs.push_back(GetEngineCodec("red"));
4450 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004451 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004452 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4453}
4454
eladalonf1841382017-06-12 01:16:46 -07004455TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004456 EXPECT_FALSE(AddSendStream()->IsSending());
4457}
4458
eladalonf1841382017-06-12 01:16:46 -07004459TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004460 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004461}
4462
eladalonf1841382017-06-12 01:16:46 -07004463TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004464 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004465 EXPECT_FALSE(stream->IsSending());
4466
4467 // false->true
4468 EXPECT_TRUE(channel_->SetSend(true));
4469 EXPECT_TRUE(stream->IsSending());
4470 // true->true
4471 EXPECT_TRUE(channel_->SetSend(true));
4472 EXPECT_TRUE(stream->IsSending());
4473 // true->false
4474 EXPECT_TRUE(channel_->SetSend(false));
4475 EXPECT_FALSE(stream->IsSending());
4476 // false->false
4477 EXPECT_TRUE(channel_->SetSend(false));
4478 EXPECT_FALSE(stream->IsSending());
4479
4480 EXPECT_TRUE(channel_->SetSend(true));
4481 FakeVideoSendStream* new_stream = AddSendStream();
4482 EXPECT_TRUE(new_stream->IsSending())
4483 << "Send stream created after SetSend(true) not sending initially.";
4484}
4485
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004486// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004487TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004488 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004489 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004490 MediaConfig config;
kwiberg686a8ef2016-02-26 03:00:35 -08004491 std::unique_ptr<VideoMediaChannel> channel;
nisse51542be2016-02-12 02:27:06 -08004492
4493 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4494 channel->SetInterface(network_interface.get());
4495 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004496 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004497
4498 config.enable_dscp = true;
4499 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4500 channel->SetInterface(network_interface.get());
4501 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
4502
4503 // Verify that setting the option to false resets the
4504 // DiffServCodePoint.
4505 config.enable_dscp = false;
4506 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4507 channel->SetInterface(network_interface.get());
4508 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004509}
4510
deadbeef13871492015-12-09 12:37:51 -08004511// This test verifies that the RTCP reduced size mode is properly applied to
4512// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004513TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004514 // Create stream, expecting that default mode is "compound".
4515 FakeVideoSendStream* stream1 = AddSendStream();
4516 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004517 webrtc::RtpParameters rtp_parameters =
4518 channel_->GetRtpSendParameters(last_ssrc_);
4519 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004520
4521 // Now enable reduced size mode.
4522 send_parameters_.rtcp.reduced_size = true;
4523 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4524 stream1 = fake_call_->GetVideoSendStreams()[0];
4525 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004526 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4527 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004528
4529 // Create a new stream and ensure it picks up the reduced size mode.
4530 FakeVideoSendStream* stream2 = AddSendStream();
4531 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4532}
4533
4534// This test verifies that the RTCP reduced size mode is properly applied to
4535// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004536TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004537 // Create stream, expecting that default mode is "compound".
4538 FakeVideoReceiveStream* stream1 = AddRecvStream();
4539 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4540
4541 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004542 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4543 // the reduced_size flag should come from that.
4544 send_parameters_.rtcp.reduced_size = true;
4545 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004546 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4547 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4548
4549 // Create a new stream and ensure it picks up the reduced size mode.
4550 FakeVideoReceiveStream* stream2 = AddRecvStream();
4551 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4552}
4553
eladalonf1841382017-06-12 01:16:46 -07004554TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004555 EXPECT_EQ(webrtc::kNetworkUp,
4556 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4557 EXPECT_EQ(webrtc::kNetworkUp,
4558 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004559
4560 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004561 EXPECT_EQ(webrtc::kNetworkDown,
4562 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4563 EXPECT_EQ(webrtc::kNetworkUp,
4564 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004565
4566 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004567 EXPECT_EQ(webrtc::kNetworkUp,
4568 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4569 EXPECT_EQ(webrtc::kNetworkUp,
4570 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004571}
4572
eladalonf1841382017-06-12 01:16:46 -07004573TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004574 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004575 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004576 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004577
4578 AddSendStream();
4579
4580 cricket::VideoMediaInfo info;
4581 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004582 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004583}
4584
eladalonf1841382017-06-12 01:16:46 -07004585TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004586 FakeVideoSendStream* stream = AddSendStream();
4587 webrtc::VideoSendStream::Stats stats;
4588 stats.encoder_implementation_name = "encoder_implementation_name";
4589 stream->SetStats(stats);
4590
4591 cricket::VideoMediaInfo info;
4592 ASSERT_TRUE(channel_->GetStats(&info));
4593 EXPECT_EQ(stats.encoder_implementation_name,
4594 info.senders[0].encoder_implementation_name);
4595}
4596
eladalonf1841382017-06-12 01:16:46 -07004597TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004598 FakeVideoSendStream* stream = AddSendStream();
4599 webrtc::VideoSendStream::Stats stats;
4600 stats.avg_encode_time_ms = 13;
4601 stats.encode_usage_percent = 42;
4602 stream->SetStats(stats);
4603
4604 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004605 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004606 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4607 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4608}
4609
eladalonf1841382017-06-12 01:16:46 -07004610TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004611 FakeVideoSendStream* stream = AddSendStream();
4612 webrtc::VideoSendStream::Stats stats;
4613 stats.frames_encoded = 13;
4614 stream->SetStats(stats);
4615
4616 cricket::VideoMediaInfo info;
4617 ASSERT_TRUE(channel_->GetStats(&info));
4618 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4619}
4620
eladalonf1841382017-06-12 01:16:46 -07004621TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004622 FakeVideoSendStream* stream = AddSendStream();
4623 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004624 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004625 stream->SetStats(stats);
4626
4627 cricket::VideoMediaInfo info;
4628 ASSERT_TRUE(channel_->GetStats(&info));
4629 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4630}
4631
eladalonf1841382017-06-12 01:16:46 -07004632TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004633 FakeVideoSendStream* stream = AddSendStream();
4634 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004635 stats.substreams[17].width = 123;
4636 stats.substreams[17].height = 40;
4637 stats.substreams[42].width = 80;
4638 stats.substreams[42].height = 31;
4639 stats.substreams[11].width = 20;
4640 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004641 stream->SetStats(stats);
4642
4643 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004644 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004645 ASSERT_EQ(1u, info.senders.size());
4646 EXPECT_EQ(123, info.senders[0].send_frame_width);
4647 EXPECT_EQ(90, info.senders[0].send_frame_height);
4648}
4649
eladalonf1841382017-06-12 01:16:46 -07004650TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004651 FakeVideoSendStream* stream = AddSendStream();
4652 webrtc::VideoSendStream::Stats stats;
4653 stats.number_of_cpu_adapt_changes = 2;
4654 stats.cpu_limited_resolution = true;
4655 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004656
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004657 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004658 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004659 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004660 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004661 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004662}
4663
eladalonf1841382017-06-12 01:16:46 -07004664TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004665 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004666 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004667 stats.number_of_cpu_adapt_changes = 2;
4668 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004669 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004670 stream->SetStats(stats);
4671
4672 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004673 EXPECT_TRUE(channel_->GetStats(&info));
4674 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004675 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4676 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004677 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004678 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004679}
4680
eladalonf1841382017-06-12 01:16:46 -07004681TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004682 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4683 FakeVideoSendStream* stream = AddSendStream();
4684 webrtc::VideoSendStream::Stats stats;
4685 stats.bw_limited_resolution = true;
4686 stream->SetStats(stats);
4687
4688 cricket::VideoMediaInfo info;
4689 EXPECT_TRUE(channel_->GetStats(&info));
4690 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004691 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004692 info.senders[0].adapt_reason);
4693}
4694
Yves Gerey665174f2018-06-19 15:03:05 +02004695TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004696 FakeVideoSendStream* stream = AddSendStream();
4697 webrtc::VideoSendStream::Stats stats;
4698 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4699 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4700 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4701
4702 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4703 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4704 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4705
4706 stream->SetStats(stats);
4707
4708 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004709 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004710 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4711 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4712 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4713}
4714
eladalonf1841382017-06-12 01:16:46 -07004715TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004716 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4717 FakeVideoReceiveStream* stream = AddRecvStream();
4718 webrtc::VideoReceiveStream::Stats stats;
4719 stats.rtcp_packet_type_counts.fir_packets = 2;
4720 stats.rtcp_packet_type_counts.nack_packets = 3;
4721 stats.rtcp_packet_type_counts.pli_packets = 4;
4722 stream->SetStats(stats);
4723
4724 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004725 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004726 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004727 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004728 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004729 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004730 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004731 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004732}
4733
eladalonf1841382017-06-12 01:16:46 -07004734TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004735 FakeVideoReceiveStream* stream = AddRecvStream();
4736 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004737 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004738 stats.decode_ms = 2;
4739 stats.max_decode_ms = 3;
4740 stats.current_delay_ms = 4;
4741 stats.target_delay_ms = 5;
4742 stats.jitter_buffer_ms = 6;
4743 stats.min_playout_delay_ms = 7;
4744 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004745 stats.width = 9;
4746 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004747 stats.frame_counts.key_frames = 11;
4748 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004749 stats.frames_rendered = 13;
4750 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004751 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004752 stream->SetStats(stats);
4753
4754 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004755 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004756 EXPECT_EQ(stats.decoder_implementation_name,
4757 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004758 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4759 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4760 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4761 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4762 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4763 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4764 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004765 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4766 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004767 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4768 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004769 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004770 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004771 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004772 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004773}
4774
eladalonf1841382017-06-12 01:16:46 -07004775TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004776 FakeVideoReceiveStream* stream = AddRecvStream();
4777 webrtc::VideoReceiveStream::Stats stats;
4778 stats.rtp_stats.transmitted.payload_bytes = 2;
4779 stats.rtp_stats.transmitted.header_bytes = 3;
4780 stats.rtp_stats.transmitted.padding_bytes = 4;
4781 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004782 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004783 stats.rtcp_stats.fraction_lost = 7;
4784 stream->SetStats(stats);
4785
4786 cricket::VideoMediaInfo info;
4787 ASSERT_TRUE(channel_->GetStats(&info));
4788 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4789 stats.rtp_stats.transmitted.header_bytes +
4790 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004791 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004792 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004793 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004794 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004795 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004796 info.receivers[0].fraction_lost);
4797}
4798
eladalonf1841382017-06-12 01:16:46 -07004799TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004800 AddSendStream();
4801 AddSendStream();
4802 webrtc::Call::Stats stats;
4803 stats.rtt_ms = 123;
4804 fake_call_->SetStats(stats);
4805
4806 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004807 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004808 ASSERT_EQ(2u, info.senders.size());
4809 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4810 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4811}
4812
eladalonf1841382017-06-12 01:16:46 -07004813TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004814 FakeVideoSendStream* stream = AddSendStream();
4815 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004816 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004817 stats.media_bitrate_bps = 123;
4818 stats.substreams[17].total_bitrate_bps = 1;
4819 stats.substreams[17].retransmit_bitrate_bps = 2;
4820 stats.substreams[42].total_bitrate_bps = 3;
4821 stats.substreams[42].retransmit_bitrate_bps = 4;
4822 stream->SetStats(stats);
4823
4824 FakeVideoSendStream* stream2 = AddSendStream();
4825 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004826 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004827 stats2.media_bitrate_bps = 321;
4828 stats2.substreams[13].total_bitrate_bps = 5;
4829 stats2.substreams[13].retransmit_bitrate_bps = 6;
4830 stats2.substreams[21].total_bitrate_bps = 7;
4831 stats2.substreams[21].retransmit_bitrate_bps = 8;
4832 stream2->SetStats(stats2);
4833
4834 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004835 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004836 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004837 BandwidthEstimationInfo bwe_info;
4838 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004839 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4840 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4841 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4842 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004843 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004844 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004845 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004846 bwe_info.actual_enc_bitrate);
4847 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004848 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004849 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004850 << "Bandwidth stats should take all streams into account.";
4851}
4852
eladalonf1841382017-06-12 01:16:46 -07004853TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004854 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004855
Peter Boström0c4e06b2015-10-07 12:23:21 +02004856 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4857 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004858
4859 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4860 const size_t kDataLength = 12;
4861 uint8_t data[kDataLength];
4862 memset(data, 0, sizeof(data));
4863 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004864 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004865 rtc::PacketTime packet_time;
4866 channel_->OnPacketReceived(&packet, packet_time);
4867
4868 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4869 << "No default receive stream created.";
4870 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004871 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004872 << "Default receive stream should not have configured RTX";
4873
4874 EXPECT_TRUE(channel_->AddRecvStream(
4875 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4876 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004877 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004878 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004879 EXPECT_FALSE(
4880 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004881 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004882 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004883 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004884 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004885 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004886 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004887}
4888
eladalonf1841382017-06-12 01:16:46 -07004889TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004890 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004891
Peter Boström0c4e06b2015-10-07 12:23:21 +02004892 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4893 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004894
4895 StreamParams sp =
4896 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4897 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4898
4899 EXPECT_FALSE(channel_->AddSendStream(sp));
4900 EXPECT_FALSE(channel_->AddRecvStream(sp));
4901}
4902
eladalonf1841382017-06-12 01:16:46 -07004903TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004904 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004905
Peter Boström0c4e06b2015-10-07 12:23:21 +02004906 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4907 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004908
4909 StreamParams sp =
4910 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4911
4912 EXPECT_TRUE(channel_->AddSendStream(sp));
4913 EXPECT_TRUE(channel_->AddRecvStream(sp));
4914
4915 // The RTX SSRC is already used in previous streams, using it should fail.
4916 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4917 EXPECT_FALSE(channel_->AddSendStream(sp));
4918 EXPECT_FALSE(channel_->AddRecvStream(sp));
4919
4920 // After removing the original stream this should be fine to add (makes sure
4921 // that RTX ssrcs are not forever taken).
4922 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4923 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4924 EXPECT_TRUE(channel_->AddSendStream(sp));
4925 EXPECT_TRUE(channel_->AddRecvStream(sp));
4926}
4927
eladalonf1841382017-06-12 01:16:46 -07004928TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004929 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004930 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4931 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004932 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004933
Peter Boströmd6f4c252015-03-26 16:23:04 +01004934 StreamParams sp =
4935 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4936
4937 EXPECT_TRUE(channel_->AddSendStream(sp));
4938 EXPECT_TRUE(channel_->AddRecvStream(sp));
4939
4940 // One of the SSRCs is already used in previous streams, using it should fail.
4941 sp = cricket::CreateSimStreamParams("cname",
4942 MAKE_VECTOR(kOverlappingStreamSsrcs));
4943 EXPECT_FALSE(channel_->AddSendStream(sp));
4944 EXPECT_FALSE(channel_->AddRecvStream(sp));
4945
4946 // After removing the original stream this should be fine to add (makes sure
4947 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02004948 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
4949 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004950 EXPECT_TRUE(channel_->AddSendStream(sp));
4951 EXPECT_TRUE(channel_->AddRecvStream(sp));
4952}
4953
eladalonf1841382017-06-12 01:16:46 -07004954TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004955 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02004956
4957 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
4958 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
4959
4960 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
4961 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
4962
4963 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
4964
4965 static const uint32_t kReceiverSsrcs[] = {3};
4966 static const uint32_t kReceiverRtxSsrcs[] = {2};
4967
4968 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
4969 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
4970 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
4971
4972 cricket::VideoMediaInfo info;
4973 ASSERT_TRUE(channel_->GetStats(&info));
4974
4975 ASSERT_EQ(1u, info.senders.size());
4976 ASSERT_EQ(1u, info.receivers.size());
4977
4978 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
4979 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
4980 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
4981}
4982
eladalonf1841382017-06-12 01:16:46 -07004983TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07004984 FakeVideoReceiveStream* stream = AddRecvStream();
4985 webrtc::VideoReceiveStream::Stats stats;
4986 cricket::VideoMediaInfo info;
4987
4988 // Report no codec name before receiving.
4989 stream->SetStats(stats);
4990 ASSERT_TRUE(channel_->GetStats(&info));
4991 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4992
4993 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08004994 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07004995 stream->SetStats(stats);
4996 ASSERT_TRUE(channel_->GetStats(&info));
4997 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
4998
4999 // Report no codec name for unknown playload types.
5000 stats.current_payload_type = 3;
5001 stream->SetStats(stats);
5002 ASSERT_TRUE(channel_->GetStats(&info));
5003 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5004}
5005
Seth Hampson5897a6e2018-04-03 11:16:33 -07005006// Tests that when we add a stream without SSRCs, but contains a stream_id
5007// that it is stored and its stream id is later used when the first packet
5008// arrives to properly create a receive stream with a sync label.
5009TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5010 const char kSyncLabel[] = "sync_label";
5011 cricket::StreamParams unsignaled_stream;
5012 unsignaled_stream.set_stream_ids({kSyncLabel});
5013 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5014 // The stream shouldn't have been created at this point because it doesn't
5015 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005016 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005017
5018 // Create and deliver packet.
5019 const size_t kDataLength = 12;
5020 uint8_t data[kDataLength];
5021 memset(data, 0, sizeof(data));
5022 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5023 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5024 rtc::PacketTime packet_time;
5025 channel_->OnPacketReceived(&packet, packet_time);
5026
5027 // The stream should now be created with the appropriate sync label.
5028 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5029 EXPECT_EQ(kSyncLabel,
5030 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5031
5032 // Removing the unsignaled stream should clear the cache. This time when
5033 // a default video receive stream is created it won't have a sync_group.
5034 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5035 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5036 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5037
5038 channel_->OnPacketReceived(&packet, packet_time);
5039 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5040 EXPECT_TRUE(
5041 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5042}
5043
eladalonf1841382017-06-12 01:16:46 -07005044void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005045 uint8_t payload_type,
5046 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005047 // kRedRtxPayloadType must currently be unused.
5048 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5049
noahricd10a68e2015-07-10 11:27:55 -07005050 // Add a RED RTX codec.
5051 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005052 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005053 recv_parameters_.codecs.push_back(red_rtx_codec);
5054 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005055
5056 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5057 const size_t kDataLength = 12;
5058 uint8_t data[kDataLength];
5059 memset(data, 0, sizeof(data));
5060
5061 rtc::Set8(data, 1, payload_type);
5062 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005063 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005064 rtc::PacketTime packet_time;
5065 channel_->OnPacketReceived(&packet, packet_time);
5066
5067 if (expect_created_receive_stream) {
5068 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5069 << "Should have created a receive stream for payload type: "
5070 << payload_type;
5071 } else {
5072 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5073 << "Shouldn't have created a receive stream for payload type: "
5074 << payload_type;
5075 }
5076}
5077
eladalonf1841382017-06-12 01:16:46 -07005078TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005079 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5080 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005081}
5082
eladalonf1841382017-06-12 01:16:46 -07005083TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005084 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5085 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005086}
5087
eladalonf1841382017-06-12 01:16:46 -07005088TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005089 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005090 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5091 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5092 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5093 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005094}
5095
eladalonf1841382017-06-12 01:16:46 -07005096TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005097 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5098 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005099}
5100
eladalonf1841382017-06-12 01:16:46 -07005101TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005102 FlexfecPacketDoesntCreateUnsignalledStream) {
5103 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5104 false /* expect_created_receive_stream */);
5105}
5106
eladalonf1841382017-06-12 01:16:46 -07005107TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005108 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5109 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005110}
5111
mzanaty8a855d62017-02-17 15:46:43 -08005112// Test that receiving any unsignalled SSRC works even if it changes.
5113// The first unsignalled SSRC received will create a default receive stream.
5114// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005115TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005116 // Allow receiving VP8, VP9, H264 (if enabled).
5117 cricket::VideoRecvParameters parameters;
5118 parameters.codecs.push_back(GetEngineCodec("VP8"));
5119 parameters.codecs.push_back(GetEngineCodec("VP9"));
5120
5121#if defined(WEBRTC_USE_H264)
5122 cricket::VideoCodec H264codec(126, "H264");
5123 parameters.codecs.push_back(H264codec);
5124#endif
5125
5126 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5127 // No receive streams yet.
5128 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5129 cricket::FakeVideoRenderer renderer;
5130 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5131
5132 // Receive VP8 packet on first SSRC.
5133 uint8_t data[kMinRtpPacketLen];
5134 cricket::RtpHeader rtpHeader;
5135 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5136 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005137 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005138 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5139 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5140 rtc::PacketTime packet_time;
5141 channel_->OnPacketReceived(&packet, packet_time);
5142 // VP8 packet should create default receive stream.
5143 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005144 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005145 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5146 // Verify that the receive stream sinks to a renderer.
5147 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5148 webrtc::kVideoRotation_0);
5149 recv_stream->InjectFrame(video_frame);
5150 EXPECT_EQ(1, renderer.num_rendered_frames());
5151
5152 // Receive VP9 packet on second SSRC.
5153 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005154 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005155 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5156 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5157 channel_->OnPacketReceived(&packet2, packet_time);
5158 // VP9 packet should replace the default receive SSRC.
5159 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5160 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5161 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5162 // Verify that the receive stream sinks to a renderer.
5163 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005164 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005165 recv_stream->InjectFrame(video_frame2);
5166 EXPECT_EQ(2, renderer.num_rendered_frames());
5167
5168#if defined(WEBRTC_USE_H264)
5169 // Receive H264 packet on third SSRC.
5170 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005171 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005172 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5173 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5174 channel_->OnPacketReceived(&packet3, packet_time);
5175 // H264 packet should replace the default receive SSRC.
5176 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5177 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5178 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5179 // Verify that the receive stream sinks to a renderer.
5180 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005181 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005182 recv_stream->InjectFrame(video_frame3);
5183 EXPECT_EQ(3, renderer.num_rendered_frames());
5184#endif
5185}
5186
brandtr0dc57ea2017-05-29 23:33:31 -07005187// This test verifies that when a new default stream is created for a new
5188// unsignaled SSRC, the new stream does not overwrite any old stream that had
5189// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005190TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005191 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5192 cricket::VideoRecvParameters parameters;
5193 parameters.codecs.push_back(GetEngineCodec("VP8"));
5194 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5195
5196 // No streams signaled and no packets received, so we should not have any
5197 // stream objects created yet.
5198 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5199
5200 // Receive packet on an unsignaled SSRC.
5201 uint8_t data[kMinRtpPacketLen];
5202 cricket::RtpHeader rtp_header;
5203 rtp_header.payload_type = GetEngineCodec("VP8").id;
5204 rtp_header.seq_num = rtp_header.timestamp = 0;
5205 rtp_header.ssrc = kSsrcs3[0];
5206 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5207 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5208 rtc::PacketTime packet_time;
5209 channel_->OnPacketReceived(&packet, packet_time);
5210 // Default receive stream should be created.
5211 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5212 FakeVideoReceiveStream* recv_stream0 =
5213 fake_call_->GetVideoReceiveStreams()[0];
5214 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5215
5216 // Signal the SSRC.
5217 EXPECT_TRUE(
5218 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5219 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5220 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5221 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5222
5223 // Receive packet on a different unsignaled SSRC.
5224 rtp_header.ssrc = kSsrcs3[1];
5225 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5226 packet.SetData(data, sizeof(data));
5227 channel_->OnPacketReceived(&packet, packet_time);
5228 // New default receive stream should be created, but old stream should remain.
5229 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5230 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5231 FakeVideoReceiveStream* recv_stream1 =
5232 fake_call_->GetVideoReceiveStreams()[1];
5233 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5234}
5235
Seth Hampson7c682e02018-05-04 16:28:15 -07005236TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005237 AddSendStream();
5238
Tommi85959932018-02-07 19:26:06 +01005239 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005240 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005241 cricket::VideoFormat capture_format_hd =
5242 capturer.GetSupportedFormats()->front();
5243 EXPECT_EQ(1280, capture_format_hd.width);
5244 EXPECT_EQ(720, capture_format_hd.height);
5245 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5246 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005247 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005248
perkjfa10b552016-10-02 23:45:26 -07005249 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005250 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005251
5252 // TODO(skvlad): Resolve the inconsistency between the interpretation
5253 // of the global bitrate limit for audio and video:
5254 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5255 // max_bandwidth_bps = -1 - remove the bandwidth limit
5256 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005257 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005258
perkjfa10b552016-10-02 23:45:26 -07005259 SetAndExpectMaxBitrate(1000, 0, 1000);
5260 SetAndExpectMaxBitrate(1000, 800, 800);
5261 SetAndExpectMaxBitrate(600, 800, 600);
5262 SetAndExpectMaxBitrate(0, 800, 800);
5263 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005264
Niels Möllerff40b142018-04-09 08:49:14 +02005265 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005266}
5267
eladalonf1841382017-06-12 01:16:46 -07005268TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005269 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005270 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005271 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005272
5273 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005274 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005275 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005276}
5277
eladalonf1841382017-06-12 01:16:46 -07005278TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005279 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005280 FakeVideoSendStream* stream = AddSendStream();
5281
Seth Hampson7c682e02018-05-04 16:28:15 -07005282 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5283 EXPECT_EQ(1UL, parameters.encodings.size());
5284 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5285 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5286
5287 // Note that this is testing the behavior of the FakeVideoSendStream, which
5288 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5289 // we are just testing the behavior of
5290 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005291 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5292 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005293
5294 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5295 // by this amount.
5296 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5297 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5298 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5299 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5300
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005301 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5302 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5303 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5304}
5305
5306TEST_F(WebRtcVideoChannelTest,
5307 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5308 FakeVideoSendStream* stream = AddSendStream();
5309
5310 // Note that this is testing the behavior of the FakeVideoSendStream, which
5311 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5312 // we are just testing the behavior of
5313 // EncoderStreamFactory::CreateEncoderStreams.
5314 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5315 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5316
5317 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5318 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5319 EXPECT_EQ(1UL, parameters.encodings.size());
5320 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5321 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5322
5323 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5324 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5325 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5326}
5327
5328TEST_F(WebRtcVideoChannelTest,
5329 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5330 send_parameters_.max_bandwidth_bps = 99999;
5331 FakeVideoSendStream* stream = AddSendStream();
5332 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5333 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5334 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5335 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5336 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5337 stream->GetVideoStreams()[0].max_bitrate_bps);
5338
5339 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5340 // adjusted down.
5341 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5342 EXPECT_EQ(1UL, parameters.encodings.size());
5343 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5344 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5345 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5346 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5347 stream->GetVideoStreams()[0].min_bitrate_bps);
5348 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5349 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005350}
5351
5352TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005353 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005354 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005355 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005356 // Two or more encodings should result in failure.
5357 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005358 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005359 // Zero encodings should also fail.
5360 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005361 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005362}
5363
Zach Stein3ca452b2018-01-18 10:01:24 -08005364TEST_F(WebRtcVideoChannelTest,
5365 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5366 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5367 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5368 AddSendStream(sp);
5369
5370 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5371
5372 // Additional encodings should result in failure.
5373 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005374 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005375 // Zero encodings should also fail.
5376 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005377 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005378}
5379
deadbeeffb2aced2017-01-06 23:05:37 -08005380// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005381TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005382 AddSendStream();
5383 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005384 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005385 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005386}
5387
Seth Hampson24722b32017-12-22 09:36:42 -08005388// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5389// a value <= 0, setting the parameters returns false.
5390TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5391 AddSendStream();
5392 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5393 EXPECT_EQ(1UL, parameters.encodings.size());
5394 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5395 parameters.encodings[0].bitrate_priority);
5396
5397 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005398 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005399 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005400 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005401}
5402
5403// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5404// properly on the VideoChannel and propogates down to the video encoder.
5405TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5406 AddSendStream();
5407 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5408 EXPECT_EQ(1UL, parameters.encodings.size());
5409 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5410 parameters.encodings[0].bitrate_priority);
5411
5412 // Change the value and set it on the VideoChannel.
5413 double new_bitrate_priority = 2.0;
5414 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005415 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005416
5417 // Verify that the encoding parameters bitrate_priority is set for the
5418 // VideoChannel.
5419 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5420 EXPECT_EQ(1UL, parameters.encodings.size());
5421 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5422
5423 // Verify that the new value propagated down to the encoder.
5424 std::vector<FakeVideoSendStream*> video_send_streams =
5425 fake_call_->GetVideoSendStreams();
5426 EXPECT_EQ(1UL, video_send_streams.size());
5427 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5428 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5429 // appropriately.
5430 EXPECT_EQ(new_bitrate_priority,
5431 video_send_stream->GetEncoderConfig().bitrate_priority);
5432 // Check that the vector of VideoStreams also was propagated correctly. Note
5433 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5434 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005435 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005436 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5437}
5438
5439// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5440// VideoChannel and the value propogates to the video encoder with all simulcast
5441// streams.
5442TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5443 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005444 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005445 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5446 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5447 AddSendStream(stream_params);
5448 uint32_t primary_ssrc = stream_params.first_ssrc();
5449
Tommi85959932018-02-07 19:26:06 +01005450 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5451 // frame. This creates multiple VideoStreams for all simulcast layers when
5452 // reconfiguring, and allows us to test this behavior.
5453 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005454 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005455 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005456 EXPECT_EQ(cricket::CS_RUNNING,
5457 capturer.Start(cricket::VideoFormat(
5458 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5459 cricket::FOURCC_I420)));
5460 channel_->SetSend(true);
5461 EXPECT_TRUE(capturer.CaptureFrame());
5462 // Get and set the rtp encoding parameters.
5463 webrtc::RtpParameters parameters =
5464 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005465 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005466 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5467 parameters.encodings[0].bitrate_priority);
5468 // Change the value and set it on the VideoChannel.
5469 double new_bitrate_priority = 2.0;
5470 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005471 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005472
5473 // Verify that the encoding parameters priority is set on the VideoChannel.
5474 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005475 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005476 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5477
5478 // Verify that the new value propagated down to the encoder.
5479 std::vector<FakeVideoSendStream*> video_send_streams =
5480 fake_call_->GetVideoSendStreams();
5481 EXPECT_EQ(1UL, video_send_streams.size());
5482 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5483 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5484 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005485 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005486 video_send_stream->GetEncoderConfig().number_of_streams);
5487 EXPECT_EQ(new_bitrate_priority,
5488 video_send_stream->GetEncoderConfig().bitrate_priority);
5489 // Check that the vector of VideoStreams also propagated correctly. The
5490 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5491 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005492 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005493 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005494 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5495 // Since we are only setting bitrate priority per-sender, the other
5496 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005497 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005498 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005499 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005500 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005501 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005502}
5503
Åsa Persson55659812018-06-18 17:51:32 +02005504TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5505 const size_t kNumSimulcastStreams = 3;
5506 SetUpSimulcast(true, false);
5507
5508 // Get and set the rtp encoding parameters.
5509 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5510 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5511 for (const auto& encoding : parameters.encodings) {
5512 EXPECT_FALSE(encoding.min_bitrate_bps);
5513 EXPECT_FALSE(encoding.max_bitrate_bps);
5514 }
5515
5516 // Change the value and set it on the VideoChannel.
5517 parameters.encodings[0].min_bitrate_bps = 100000;
5518 parameters.encodings[0].max_bitrate_bps = 200000;
5519 parameters.encodings[1].min_bitrate_bps = 300000;
5520 parameters.encodings[1].max_bitrate_bps = 400000;
5521 parameters.encodings[2].min_bitrate_bps = 500000;
5522 parameters.encodings[2].max_bitrate_bps = 600000;
5523 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5524
5525 // Verify that the bitrates are set on the VideoChannel.
5526 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5527 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5528 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5529 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5530 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5531 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5532 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5533 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5534}
5535
5536TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5537 const size_t kNumSimulcastStreams = 3;
5538 SetUpSimulcast(true, false);
5539
5540 // Get and set the rtp encoding parameters.
5541 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5542 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5543
5544 // Max bitrate lower than min bitrate should fail.
5545 parameters.encodings[2].min_bitrate_bps = 100000;
5546 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5547 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5548 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5549}
5550
5551// Test that min and max bitrate values set via RtpParameters are correctly
5552// propagated to the underlying encoder, and that the target is set to 3/4 of
5553// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5554// that are used if no min/max are specified).
5555TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5556 const size_t kNumSimulcastStreams = 3;
5557 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5558
5559 // Send a full size frame so all simulcast layers are used when reconfiguring.
5560 FakeVideoCapturerWithTaskQueue capturer;
5561 VideoOptions options;
5562 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5563 EXPECT_EQ(cricket::CS_RUNNING,
5564 capturer.Start(capturer.GetSupportedFormats()->front()));
5565 channel_->SetSend(true);
5566 EXPECT_TRUE(capturer.CaptureFrame());
5567
5568 // Get and set the rtp encoding parameters.
5569 // Change the value and set it on the VideoChannel.
5570 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5571 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5572 parameters.encodings[0].min_bitrate_bps = 100000;
5573 parameters.encodings[0].max_bitrate_bps = 200000;
5574 parameters.encodings[1].min_bitrate_bps = 300000;
5575 parameters.encodings[1].max_bitrate_bps = 400000;
5576 parameters.encodings[2].min_bitrate_bps = 500000;
5577 parameters.encodings[2].max_bitrate_bps = 600000;
5578 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5579
5580 // Verify that the new value propagated down to the encoder.
5581 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5582 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5583 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5584 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5585 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5586 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5587 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5588 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
5589 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
5590 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
5591 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
5592
5593 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5594 // VideoStreams are created appropriately for the simulcast case.
5595 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5596 // Target bitrate: 200000 * 3 / 4 = 150000.
5597 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
5598 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5599 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
5600 // Target bitrate: 400000 * 3 / 4 = 300000.
5601 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
5602 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
5603 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
5604 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
5605 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
5606 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
5607 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
5608
5609 // No parameter changed, encoder should not be reconfigured.
5610 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5611 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5612
5613 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5614}
5615
5616// Test to only specify the min or max bitrate value for a layer via
5617// RtpParameters. The unspecified min/max and target value should be set to the
5618// simulcast default that is used if no min/max are specified.
5619TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
5620 const size_t kNumSimulcastStreams = 3;
5621 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5622 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5623
5624 // Send a full size frame so all simulcast layers are used when reconfiguring.
5625 FakeVideoCapturerWithTaskQueue capturer;
5626 VideoOptions options;
5627 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5628 EXPECT_EQ(cricket::CS_RUNNING,
5629 capturer.Start(capturer.GetSupportedFormats()->front()));
5630 channel_->SetSend(true);
5631 EXPECT_TRUE(capturer.CaptureFrame());
5632
5633 // Get and set the rtp encoding parameters.
5634 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5635 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5636
5637 // Change the value and set it on the VideoChannel.
5638 // Layer 0: only configure min bitrate.
5639 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
5640 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5641 // Layer 1: only configure max bitrate.
5642 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
5643 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5644 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5645
5646 // Verify that the new value propagated down to the encoder.
5647 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5648 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5649 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5650 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5651 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
5652 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5653 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
5654 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
5655 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
5656 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
5657
5658 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5659 // VideoStreams are created appropriately for the simulcast case.
5660 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5661 // Layer 0: min configured bitrate should overwrite min default.
5662 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5663 EXPECT_EQ(kDefault[0].target_bitrate_bps,
5664 stream->GetVideoStreams()[0].target_bitrate_bps);
5665 EXPECT_EQ(kDefault[0].max_bitrate_bps,
5666 stream->GetVideoStreams()[0].max_bitrate_bps);
5667 // Layer 1: max configured bitrate should overwrite max default.
5668 EXPECT_EQ(kDefault[1].min_bitrate_bps,
5669 stream->GetVideoStreams()[1].min_bitrate_bps);
5670 EXPECT_EQ(kDefault[1].target_bitrate_bps,
5671 stream->GetVideoStreams()[1].target_bitrate_bps);
5672 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5673 // Layer 2: min and max bitrate not configured, default expected.
5674 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5675 stream->GetVideoStreams()[2].min_bitrate_bps);
5676 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5677 stream->GetVideoStreams()[2].target_bitrate_bps);
5678 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5679 stream->GetVideoStreams()[2].max_bitrate_bps);
5680
5681 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5682}
5683
5684// Test that specifying the min (or max) bitrate value for a layer via
5685// RtpParameters above (or below) the simulcast default max (or min) adjusts the
5686// unspecified values accordingly.
5687TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
5688 const size_t kNumSimulcastStreams = 3;
5689 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5690 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5691
5692 // Send a full size frame so all simulcast layers are used when reconfiguring.
5693 FakeVideoCapturerWithTaskQueue capturer;
5694 VideoOptions options;
5695 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5696 EXPECT_EQ(cricket::CS_RUNNING,
5697 capturer.Start(capturer.GetSupportedFormats()->front()));
5698 channel_->SetSend(true);
5699 EXPECT_TRUE(capturer.CaptureFrame());
5700
5701 // Get and set the rtp encoding parameters.
5702 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5703 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5704
5705 // Change the value and set it on the VideoChannel.
5706 // For layer 0, set the min bitrate above the default max.
5707 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
5708 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5709 // For layer 1, set the max bitrate below the default min.
5710 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
5711 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5712 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5713
5714 // Verify that the new value propagated down to the encoder.
5715 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5716 // VideoStreams are created appropriately for the simulcast case.
5717 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5718 // Layer 0: Min bitrate above default max (target/max should be adjusted).
5719 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5720 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
5721 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
5722 // Layer 1: Max bitrate below default min (min/target should be adjusted).
5723 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
5724 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
5725 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5726 // Layer 2: min and max bitrate not configured, default expected.
5727 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5728 stream->GetVideoStreams()[2].min_bitrate_bps);
5729 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5730 stream->GetVideoStreams()[2].target_bitrate_bps);
5731 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5732 stream->GetVideoStreams()[2].max_bitrate_bps);
5733
5734 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5735}
5736
5737TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
5738 const size_t kNumSimulcastStreams = 3;
5739 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5740 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5741
5742 // Send a full size frame so all simulcast layers are used when reconfiguring.
5743 FakeVideoCapturerWithTaskQueue capturer;
5744 VideoOptions options;
5745 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5746 EXPECT_EQ(cricket::CS_RUNNING,
5747 capturer.Start(capturer.GetSupportedFormats()->front()));
5748 channel_->SetSend(true);
5749 EXPECT_TRUE(capturer.CaptureFrame());
5750
5751 // Set max bitrate for all but the highest layer.
5752 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5753 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5754 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
5755 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
5756 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5757
5758 // Set max bandwidth equal to total max bitrate.
5759 send_parameters_.max_bandwidth_bps =
5760 GetTotalMaxBitrateBps(stream->GetVideoStreams());
5761 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5762 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5763
5764 // No bitrate above the total max to give to the highest layer.
5765 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5766 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5767 stream->GetVideoStreams()[2].max_bitrate_bps);
5768
5769 // Set max bandwidth above the total max bitrate.
5770 send_parameters_.max_bandwidth_bps =
5771 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5772 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5773 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5774
5775 // The highest layer has no max bitrate set -> the bitrate above the total
5776 // max should be given to the highest layer.
5777 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5778 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5779 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
5780 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
5781 stream->GetVideoStreams()[2].max_bitrate_bps);
5782
5783 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5784}
5785
5786TEST_F(WebRtcVideoChannelTest,
5787 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
5788 const size_t kNumSimulcastStreams = 3;
5789 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5790 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
5791 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5792
5793 // Send a full size frame so all simulcast layers are used when reconfiguring.
5794 FakeVideoCapturerWithTaskQueue capturer;
5795 VideoOptions options;
5796 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5797 EXPECT_EQ(cricket::CS_RUNNING,
5798 capturer.Start(capturer.GetSupportedFormats()->front()));
5799 channel_->SetSend(true);
5800 EXPECT_TRUE(capturer.CaptureFrame());
5801
5802 // Set max bitrate for the highest layer.
5803 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5804 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5805 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
5806 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5807
5808 // Set max bandwidth above the total max bitrate.
5809 send_parameters_.max_bandwidth_bps =
5810 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5811 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5812 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5813
5814 // The highest layer has the max bitrate set -> the bitrate above the total
5815 // max should not be given to the highest layer.
5816 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5817 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
5818 stream->GetVideoStreams()[2].max_bitrate_bps);
5819
5820 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5821}
5822
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005823// Test that min and max bitrate values set via RtpParameters are correctly
5824// propagated to the underlying encoder for a single stream.
5825TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
5826 FakeVideoSendStream* stream = AddSendStream();
5827 EXPECT_TRUE(channel_->SetSend(true));
5828 EXPECT_TRUE(stream->IsSending());
5829
5830 // Set min and max bitrate.
5831 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5832 EXPECT_EQ(1u, parameters.encodings.size());
5833 parameters.encodings[0].min_bitrate_bps = 80000;
5834 parameters.encodings[0].max_bitrate_bps = 150000;
5835 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5836
5837 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5838 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5839 EXPECT_EQ(1u, encoder_config.number_of_streams);
5840 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
5841 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5842 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5843
5844 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5845 // VideoStreams are created appropriately.
5846 EXPECT_EQ(1u, stream->GetVideoStreams().size());
5847 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
5848 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5849 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
5850}
5851
5852// Test the default min and max bitrate value are correctly propagated to the
5853// underlying encoder for a single stream (when the values are not set via
5854// RtpParameters).
5855TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
5856 FakeVideoSendStream* stream = AddSendStream();
5857 EXPECT_TRUE(channel_->SetSend(true));
5858 EXPECT_TRUE(stream->IsSending());
5859
5860 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5861 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5862 EXPECT_EQ(1u, encoder_config.number_of_streams);
5863 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
5864 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
5865 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5866
5867 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5868 // VideoStreams are created appropriately.
5869 EXPECT_EQ(1u, stream->GetVideoStreams().size());
5870 EXPECT_EQ(cricket::kMinVideoBitrateBps,
5871 stream->GetVideoStreams()[0].min_bitrate_bps);
5872 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
5873 stream->GetVideoStreams()[0].min_bitrate_bps);
5874 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
5875 stream->GetVideoStreams()[0].target_bitrate_bps);
5876}
5877
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005878// Test that a stream will not be sending if its encoding is made inactive
5879// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08005880TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07005881 FakeVideoSendStream* stream = AddSendStream();
5882 EXPECT_TRUE(channel_->SetSend(true));
5883 EXPECT_TRUE(stream->IsSending());
5884
5885 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005886 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07005887 ASSERT_EQ(1u, parameters.encodings.size());
5888 ASSERT_TRUE(parameters.encodings[0].active);
5889 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08005890 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005891 EXPECT_FALSE(stream->IsSending());
5892
5893 // Now change it back to active and verify we resume sending.
5894 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08005895 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005896 EXPECT_TRUE(stream->IsSending());
5897}
5898
Seth Hampson8234ead2018-02-02 15:16:24 -08005899// Tests that when active is updated for any simulcast layer then the send
5900// stream's sending state will be updated and it will be reconfigured with the
5901// new appropriate active simulcast streams.
5902TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
5903 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005904 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08005905 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5906 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5907 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
5908 uint32_t primary_ssrc = stream_params.first_ssrc();
5909
Tommi85959932018-02-07 19:26:06 +01005910 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5911 // frame. This allows us to test that ReconfigureEncoder is called
5912 // appropriately.
5913 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08005914 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005915 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08005916 EXPECT_EQ(cricket::CS_RUNNING,
5917 capturer.Start(cricket::VideoFormat(
5918 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5919 cricket::FOURCC_I420)));
5920 channel_->SetSend(true);
5921 EXPECT_TRUE(capturer.CaptureFrame());
5922
5923 // Check that all encodings are initially active.
5924 webrtc::RtpParameters parameters =
5925 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005926 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005927 EXPECT_TRUE(parameters.encodings[0].active);
5928 EXPECT_TRUE(parameters.encodings[1].active);
5929 EXPECT_TRUE(parameters.encodings[2].active);
5930 EXPECT_TRUE(fake_video_send_stream->IsSending());
5931
5932 // Only turn on only the middle stream.
5933 parameters.encodings[0].active = false;
5934 parameters.encodings[1].active = true;
5935 parameters.encodings[2].active = false;
5936 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5937 // Verify that the active fields are set on the VideoChannel.
5938 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005939 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005940 EXPECT_FALSE(parameters.encodings[0].active);
5941 EXPECT_TRUE(parameters.encodings[1].active);
5942 EXPECT_FALSE(parameters.encodings[2].active);
5943 // Check that the VideoSendStream is updated appropriately. This means its
5944 // send state was updated and it was reconfigured.
5945 EXPECT_TRUE(fake_video_send_stream->IsSending());
5946 std::vector<webrtc::VideoStream> simulcast_streams =
5947 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02005948 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005949 EXPECT_FALSE(simulcast_streams[0].active);
5950 EXPECT_TRUE(simulcast_streams[1].active);
5951 EXPECT_FALSE(simulcast_streams[2].active);
5952
5953 // Turn off all streams.
5954 parameters.encodings[0].active = false;
5955 parameters.encodings[1].active = false;
5956 parameters.encodings[2].active = false;
5957 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5958 // Verify that the active fields are set on the VideoChannel.
5959 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005960 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005961 EXPECT_FALSE(parameters.encodings[0].active);
5962 EXPECT_FALSE(parameters.encodings[1].active);
5963 EXPECT_FALSE(parameters.encodings[2].active);
5964 // Check that the VideoSendStream is off.
5965 EXPECT_FALSE(fake_video_send_stream->IsSending());
5966 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02005967 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005968 EXPECT_FALSE(simulcast_streams[0].active);
5969 EXPECT_FALSE(simulcast_streams[1].active);
5970 EXPECT_FALSE(simulcast_streams[2].active);
5971
Niels Möllerff40b142018-04-09 08:49:14 +02005972 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08005973}
5974
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005975// Test that if a stream is reconfigured (due to a codec change or other
5976// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07005977TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005978 InactiveStreamDoesntStartSendingWhenReconfigured) {
5979 // Set an initial codec list, which will be modified later.
5980 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08005981 parameters1.codecs.push_back(GetEngineCodec("VP8"));
5982 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005983 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
5984
5985 FakeVideoSendStream* stream = AddSendStream();
5986 EXPECT_TRUE(channel_->SetSend(true));
5987 EXPECT_TRUE(stream->IsSending());
5988
5989 // Get current parameters and change "active" to false.
5990 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5991 ASSERT_EQ(1u, parameters.encodings.size());
5992 ASSERT_TRUE(parameters.encodings[0].active);
5993 parameters.encodings[0].active = false;
5994 EXPECT_EQ(1u, GetFakeSendStreams().size());
5995 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08005996 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005997 EXPECT_FALSE(stream->IsSending());
5998
5999 // Reorder the codec list, causing the stream to be reconfigured.
6000 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006001 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6002 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006003 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6004 auto new_streams = GetFakeSendStreams();
6005 // Assert that a new underlying stream was created due to the codec change.
6006 // Otherwise, this test isn't testing what it set out to test.
6007 EXPECT_EQ(1u, GetFakeSendStreams().size());
6008 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6009
6010 // Verify that we still are not sending anything, due to the inactive
6011 // encoding.
6012 EXPECT_FALSE(new_streams[0]->IsSending());
6013}
6014
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006015// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006016TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006017 AddSendStream();
6018 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006019 parameters.codecs.push_back(GetEngineCodec("VP8"));
6020 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006021 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6022
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006023 webrtc::RtpParameters rtp_parameters =
6024 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006025 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006026 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6027 rtp_parameters.codecs[0]);
6028 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6029 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006030}
6031
Florent Castellidacec712018-05-24 16:24:21 +02006032// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6033TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6034 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6035 params.cname = "rtcpcname";
6036 AddSendStream(params);
6037
6038 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6039 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6040}
6041
deadbeeffb2aced2017-01-06 23:05:37 -08006042// Test that RtpParameters for send stream has one encoding and it has
6043// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006044TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006045 AddSendStream();
6046
6047 webrtc::RtpParameters rtp_parameters =
6048 channel_->GetRtpSendParameters(last_ssrc_);
6049 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006050 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006051}
6052
Florent Castelliabe301f2018-06-12 18:33:49 +02006053TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6054 AddSendStream();
6055
6056 webrtc::RtpParameters rtp_parameters =
6057 channel_->GetRtpSendParameters(last_ssrc_);
6058 rtp_parameters.header_extensions.emplace_back();
6059
6060 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6061
6062 webrtc::RTCError result =
6063 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6064 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6065}
6066
Florent Castelli87b3c512018-07-18 16:00:28 +02006067TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6068 AddSendStream();
6069
6070 FakeVideoCapturerWithTaskQueue capturer;
6071 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6072
6073 webrtc::RtpParameters rtp_parameters =
6074 channel_->GetRtpSendParameters(last_ssrc_);
6075 EXPECT_EQ(rtp_parameters.degradation_preference,
6076 webrtc::DegradationPreference::BALANCED);
6077 rtp_parameters.degradation_preference =
6078 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6079
6080 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6081
6082 webrtc::RtpParameters updated_rtp_parameters =
6083 channel_->GetRtpSendParameters(last_ssrc_);
6084 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6085 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6086
6087 // Remove the source since it will be destroyed before the channel
6088 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6089}
6090
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006091// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006092TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006093 AddSendStream();
6094 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006095 parameters.codecs.push_back(GetEngineCodec("VP8"));
6096 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006097 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6098
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006099 webrtc::RtpParameters initial_params =
6100 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006101
6102 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006103 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006104
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006105 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6106 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6107}
6108
6109// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006110TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006111 AddRecvStream();
6112 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006113 parameters.codecs.push_back(GetEngineCodec("VP8"));
6114 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006115 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6116
6117 webrtc::RtpParameters rtp_parameters =
6118 channel_->GetRtpReceiveParameters(last_ssrc_);
6119 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006120 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6121 rtp_parameters.codecs[0]);
6122 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6123 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006124}
6125
johan073ece42016-08-26 02:59:47 -07006126#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006127TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006128#else
eladalonf1841382017-06-12 01:16:46 -07006129TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006130#endif
johan3859c892016-08-05 09:19:25 -07006131 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006132 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006133 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006134 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006135 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006136 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006137 parameters.codecs.push_back(kH264sprop2);
6138 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6139
6140 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6141 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6142 webrtc::RtpParameters rtp_parameters =
6143 channel_->GetRtpReceiveParameters(last_ssrc_);
6144 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6145 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6146 ASSERT_EQ(2u, cfg.decoders.size());
6147 EXPECT_EQ(101, cfg.decoders[0].payload_type);
6148 EXPECT_EQ("H264", cfg.decoders[0].payload_name);
magjed5dfac562016-11-25 03:56:37 -08006149 const auto it0 =
6150 cfg.decoders[0].codec_params.find(kH264FmtpSpropParameterSets);
6151 ASSERT_TRUE(it0 != cfg.decoders[0].codec_params.end());
6152 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006153
6154 EXPECT_EQ(102, cfg.decoders[1].payload_type);
6155 EXPECT_EQ("H264", cfg.decoders[1].payload_name);
magjed5dfac562016-11-25 03:56:37 -08006156 const auto it1 =
6157 cfg.decoders[1].codec_params.find(kH264FmtpSpropParameterSets);
6158 ASSERT_TRUE(it1 != cfg.decoders[1].codec_params.end());
6159 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006160}
6161
sakal1fd95952016-06-22 00:46:15 -07006162// Test that RtpParameters for receive stream has one encoding and it has
6163// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006164TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006165 AddRecvStream();
6166
6167 webrtc::RtpParameters rtp_parameters =
6168 channel_->GetRtpReceiveParameters(last_ssrc_);
6169 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006170 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006171}
6172
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006173// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006174TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006175 AddRecvStream();
6176 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006177 parameters.codecs.push_back(GetEngineCodec("VP8"));
6178 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006179 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6180
6181 webrtc::RtpParameters initial_params =
6182 channel_->GetRtpReceiveParameters(last_ssrc_);
6183
6184 // We should be able to set the params we just got.
6185 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6186
6187 // ... And this shouldn't change the params returned by
6188 // GetRtpReceiveParameters.
6189 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006190}
6191
deadbeef3bc15102017-04-20 19:25:07 -07006192// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6193// aren't signaled. It should always return an empty "RtpEncodingParameters",
6194// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006195TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006196 // Call necessary methods to configure receiving a default stream as
6197 // soon as it arrives.
6198 cricket::VideoRecvParameters parameters;
6199 parameters.codecs.push_back(GetEngineCodec("VP8"));
6200 parameters.codecs.push_back(GetEngineCodec("VP9"));
6201 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6202
6203 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6204 // stream. Should return nothing.
6205 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6206
6207 // Set a sink for an unsignaled stream.
6208 cricket::FakeVideoRenderer renderer;
6209 // Value of "0" means "unsignaled stream".
6210 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6211
6212 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6213 // in this method means "unsignaled stream".
6214 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6215 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6216 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6217
6218 // Receive VP8 packet.
6219 uint8_t data[kMinRtpPacketLen];
6220 cricket::RtpHeader rtpHeader;
6221 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6222 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6223 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6224 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6225 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6226 rtc::PacketTime packet_time;
6227 channel_->OnPacketReceived(&packet, packet_time);
6228
6229 // The |ssrc| member should still be unset.
6230 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6231 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6232 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6233}
6234
eladalonf1841382017-06-12 01:16:46 -07006235void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006236 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006237 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006238
6239 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006240 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006241 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006242 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006243
6244 if (receiver_first) {
6245 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6246 std::vector<FakeVideoReceiveStream*> receive_streams =
6247 fake_call_->GetVideoReceiveStreams();
6248 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006249 // Default local SSRC when we have no sender.
6250 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6251 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006252 }
6253 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6254 if (!receiver_first)
6255 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6256 std::vector<FakeVideoReceiveStream*> receive_streams =
6257 fake_call_->GetVideoReceiveStreams();
6258 ASSERT_EQ(1u, receive_streams.size());
6259 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006260
6261 // Removing first sender should fall back to another (in this case the second)
6262 // local send stream's SSRC.
6263 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6264 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006265 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006266 ASSERT_EQ(1u, receive_streams.size());
6267 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6268
6269 // Removing the last sender should fall back to default local SSRC.
6270 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006271 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006272 ASSERT_EQ(1u, receive_streams.size());
6273 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6274 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006275}
6276
eladalonf1841382017-06-12 01:16:46 -07006277TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006278 TestReceiverLocalSsrcConfiguration(false);
6279}
6280
eladalonf1841382017-06-12 01:16:46 -07006281TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006282 TestReceiverLocalSsrcConfiguration(true);
6283}
6284
eladalonf1841382017-06-12 01:16:46 -07006285class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006286 public:
eladalonf1841382017-06-12 01:16:46 -07006287 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006288 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006289 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6290 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006291 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006292 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006293 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006294 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006295 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006296
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006297 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006298 encoder_factory_->AddSupportedVideoCodecType("VP8");
nisse51542be2016-02-12 02:27:06 -08006299 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08006300 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006301 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006302 last_ssrc_ = 123;
6303 }
6304
6305 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006306 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006307 int capture_width,
6308 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006309 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006310 size_t expected_num_streams,
6311 bool screenshare,
6312 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006313 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006314 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006315 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006316 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006317
Peter Boström0c4e06b2015-10-07 12:23:21 +02006318 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006319 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006320 ssrcs.resize(num_configured_streams);
6321
sprangf24a0642017-02-28 13:23:26 -08006322 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006323 // Send a full-size frame to trigger a stream reconfiguration to use all
6324 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006325 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006326 VideoOptions options;
6327 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006328 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006329 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006330 // Fetch the latest stream since SetVideoSend() may recreate it if the
6331 // screen content setting is changed.
6332 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006333 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006334 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006335 cricket::VideoFormat::FpsToInterval(30),
6336 cricket::FOURCC_I420)));
6337 channel_->SetSend(true);
6338 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006339
Zach Stein3ca452b2018-01-18 10:01:24 -08006340 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6341 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6342
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006343 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6344 ASSERT_EQ(expected_num_streams, video_streams.size());
6345
sprang429600d2017-01-26 06:12:26 -08006346 std::vector<webrtc::VideoStream> expected_streams;
6347 if (conference_mode) {
6348 expected_streams = GetSimulcastConfig(
6349 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006350 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006351 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006352 if (screenshare) {
6353 for (const webrtc::VideoStream& stream : expected_streams) {
6354 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006355 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6356 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006357 }
6358 }
sprang429600d2017-01-26 06:12:26 -08006359 } else {
6360 webrtc::VideoStream stream;
6361 stream.width = capture_width;
6362 stream.height = capture_height;
6363 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006364 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006365 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006366 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006367 stream.max_qp = kDefaultQpMax;
6368 expected_streams.push_back(stream);
6369 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006370
6371 ASSERT_EQ(expected_streams.size(), video_streams.size());
6372
6373 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006374 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006375 for (size_t i = 0; i < num_streams; ++i) {
6376 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6377 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6378
6379 EXPECT_GT(video_streams[i].max_framerate, 0);
6380 EXPECT_EQ(expected_streams[i].max_framerate,
6381 video_streams[i].max_framerate);
6382
6383 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6384 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6385 video_streams[i].min_bitrate_bps);
6386
6387 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6388 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6389 video_streams[i].target_bitrate_bps);
6390
6391 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6392 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6393 video_streams[i].max_bitrate_bps);
6394
6395 EXPECT_GT(video_streams[i].max_qp, 0);
6396 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6397
Sergey Silkina796a7e2018-03-01 15:11:29 +01006398 EXPECT_EQ(conference_mode,
6399 expected_streams[i].num_temporal_layers.has_value());
6400
6401 if (conference_mode) {
6402 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6403 video_streams[i].num_temporal_layers);
6404 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006405
6406 if (i == num_streams - 1) {
6407 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6408 } else {
6409 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6410 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006411 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006412
Niels Möllerff40b142018-04-09 08:49:14 +02006413 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006414 }
6415
6416 FakeVideoSendStream* AddSendStream() {
6417 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6418 }
6419
6420 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006421 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006422 EXPECT_TRUE(channel_->AddSendStream(sp));
6423 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006424 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006425 EXPECT_EQ(num_streams + 1, streams.size());
6426 return streams[streams.size() - 1];
6427 }
6428
6429 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006430 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006431 }
6432
6433 FakeVideoReceiveStream* AddRecvStream() {
6434 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6435 }
6436
6437 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006438 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006439 EXPECT_TRUE(channel_->AddRecvStream(sp));
6440 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006441 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006442 EXPECT_EQ(num_streams + 1, streams.size());
6443 return streams[streams.size() - 1];
6444 }
6445
skvlad11a9cbf2016-10-07 11:53:05 -07006446 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006447 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006448 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6449 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006450 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006451 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006452 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006453};
6454
eladalonf1841382017-06-12 01:16:46 -07006455TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006456 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6457 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006458}
6459
eladalonf1841382017-06-12 01:16:46 -07006460TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006461 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6462 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006463}
6464
6465// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006466TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006467 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6468 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006469}
sprang429600d2017-01-26 06:12:26 -08006470
eladalonf1841382017-06-12 01:16:46 -07006471TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006472 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6473 true);
6474}
6475
eladalonf1841382017-06-12 01:16:46 -07006476TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006477 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07006478 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6479 false);
6480}
6481
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00006482} // namespace cricket