blob: 5dbd329ee9a730af04eeea07e4b43fbe665259f3 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020020#include "api/video_codecs/builtin_video_decoder_factory.h"
21#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020022#include "api/video_codecs/sdp_video_format.h"
23#include "api/video_codecs/video_decoder_factory.h"
24#include "api/video_codecs/video_encoder.h"
25#include "api/video_codecs/video_encoder_factory.h"
26#include "call/flexfec_receive_stream.h"
27#include "common_video/h264/profile_level_id.h"
28#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020029#include "media/base/fakenetworkinterface.h"
30#include "media/base/fakevideocapturer.h"
31#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "media/base/mediaconstants.h"
33#include "media/base/rtputils.h"
34#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/engine/constants.h"
36#include "media/engine/fakewebrtccall.h"
37#include "media/engine/fakewebrtcvideoengine.h"
38#include "media/engine/simulcast.h"
39#include "media/engine/webrtcvideoengine.h"
40#include "media/engine/webrtcvoiceengine.h"
41#include "rtc_base/arraysize.h"
42#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020043#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "rtc_base/stringutils.h"
45#include "test/field_trial.h"
46#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000047
Tommi85959932018-02-07 19:26:06 +010048using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010049using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070050using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010051using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070052
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000053namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000054static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000055
noahricd10a68e2015-07-10 11:27:55 -070056static const uint8_t kRedRtxPayloadType = 125;
57
Niels Möller6557d0c2018-04-11 15:18:34 +020058static const uint32_t kTimeout = 5000U;
59static const uint32_t kDefaultReceiveSsrc = 0;
60static const uint32_t kSsrc = 1234u;
61static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
62static const int kVideoWidth = 640;
63static const int kVideoHeight = 360;
64static const int kFramerate = 30;
65
Peter Boström0c4e06b2015-10-07 12:23:21 +020066static const uint32_t kSsrcs1[] = {1};
67static const uint32_t kSsrcs3[] = {1, 2, 3};
68static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080069static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020070static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080071static const uint32_t kDefaultRecvSsrc = 0;
72
pbos@webrtc.org3c107582014-07-20 15:27:35 +000073static const char kUnsupportedExtensionName[] =
74 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000075
magjed509e4fe2016-11-18 01:34:11 -080076cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
77 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020078 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080079}
80
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000081void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
82 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
83 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
84 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
85 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
86 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
87 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
88 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080089 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000091 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
92}
93
magjed725e4842016-11-16 00:48:13 -080094// Return true if any codec in |codecs| is an RTX codec with associated payload
95// type |payload_type|.
96bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
97 int payload_type) {
98 for (const cricket::VideoCodec& codec : codecs) {
99 int associated_payload_type;
100 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
101 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
102 &associated_payload_type) &&
103 associated_payload_type == payload_type) {
104 return true;
105 }
106 }
107 return false;
108}
109
nisseca5706d2017-09-11 02:32:16 -0700110// TODO(nisse): Duplicated in call.cc.
111const int* FindKeyByValue(const std::map<int, int>& m, int v) {
112 for (const auto& kv : m) {
113 if (kv.second == v)
114 return &kv.first;
115 }
116 return nullptr;
117}
118
Yves Gerey665174f2018-06-19 15:03:05 +0200119bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
120 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700121 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
122 payload_type) != nullptr;
123}
124
125// Check that there's an Rtx payload type for each decoder.
126bool VerifyRtxReceiveAssociations(
127 const webrtc::VideoReceiveStream::Config& config) {
128 for (const auto& decoder : config.decoders) {
129 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
130 return false;
131 }
132 return true;
133}
134
brandtrffc61182016-11-28 06:02:22 -0800135rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700136 int width,
137 int height) {
138 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
139 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800140 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700141 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000142}
143
Shao Changbine62202f2015-04-21 20:24:50 +0800144void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
145 const std::map<int, int>& rtx_types) {
146 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200147 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800148 EXPECT_TRUE(it != rtx_types.end() &&
149 it->second == config.rtp.rtx.payload_type);
150
brandtrb5f2c3f2016-10-04 23:28:39 -0700151 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
152 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800153 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700154 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800155 }
156}
kthelgason2bc68642017-02-07 07:02:22 -0800157
158cricket::MediaConfig GetMediaConfig() {
159 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100160 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800161 return media_config;
162}
nisse26e3abb2017-08-25 04:44:25 -0700163
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200164// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
165int GetMaxDefaultBitrateBps(size_t width, size_t height) {
166 if (width * height <= 320 * 240) {
167 return 600000;
168 } else if (width * height <= 640 * 480) {
169 return 1700000;
170 } else if (width * height <= 960 * 540) {
171 return 2000000;
172 } else {
173 return 2500000;
174 }
175}
176
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000177} // namespace
178
Yves Gerey665174f2018-06-19 15:03:05 +0200179#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200180 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200181 EXPECT_EQ((w), renderer_.width()); \
182 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200183 EXPECT_EQ(0, renderer_.errors());
184
Yves Gerey665174f2018-06-19 15:03:05 +0200185#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200186 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200187 EXPECT_EQ((w), (r).width()); \
188 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200189 EXPECT_EQ(0, (r).errors());
190
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000191namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700192class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000193 public:
eladalonf1841382017-06-12 01:16:46 -0700194 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
195 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700196 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700197 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200198 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
199 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200200 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200201 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200202 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200203 decoder_factory_)) {}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000204
205 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200206 void AssignDefaultAptRtxTypes();
207 void AssignDefaultCodec();
208
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100209 // Find the index of the codec in the engine with the given name. The codec
210 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100211 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100212
magjed509e4fe2016-11-18 01:34:11 -0800213 // Find the codec in the engine with the given name. The codec must be
214 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100215 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800216
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200217 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000218
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200219 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000220 const std::vector<VideoCodec>& codecs);
221
Peter Boströme4499152016-02-05 11:13:28 +0100222 void TestExtendedEncoderOveruse(bool use_external_encoder);
223
stefanc1aeaf02015-10-15 07:26:07 -0700224 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700225 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700226 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000227 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800228 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200229 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
230 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700231 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000232 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800233 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000234};
235
eladalonf1841382017-06-12 01:16:46 -0700236TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200237 encoder_factory_->AddSupportedVideoCodecType("VP8");
238 AssignDefaultCodec();
239
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000240 std::vector<VideoCodec> engine_codecs = engine_.codecs();
241 for (size_t i = 0; i < engine_codecs.size(); ++i) {
242 if (engine_codecs[i].name != kRtxCodecName)
243 continue;
244 int associated_payload_type;
245 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000246 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000247 EXPECT_EQ(default_codec_.id, associated_payload_type);
248 return;
249 }
250 FAIL() << "No RTX codec found among default codecs.";
251}
252
eladalonf1841382017-06-12 01:16:46 -0700253TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100254 RtpCapabilities capabilities = engine_.GetCapabilities();
255 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700256 for (const RtpExtension& extension : capabilities.header_extensions) {
257 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
258 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000259 return;
260 }
261 }
262 FAIL() << "Timestamp offset extension not in header-extension list.";
263}
264
eladalonf1841382017-06-12 01:16:46 -0700265TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100266 RtpCapabilities capabilities = engine_.GetCapabilities();
267 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700268 for (const RtpExtension& extension : capabilities.header_extensions) {
269 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
270 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000271 return;
272 }
273 }
274 FAIL() << "Absolute Sender Time extension not in header-extension list.";
275}
276
eladalonf1841382017-06-12 01:16:46 -0700277TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100278 RtpCapabilities capabilities = engine_.GetCapabilities();
279 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700280 for (const RtpExtension& extension : capabilities.header_extensions) {
281 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
282 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700283 return;
284 }
285 }
286 FAIL() << "Transport sequence number extension not in header-extension list.";
287}
288
eladalonf1841382017-06-12 01:16:46 -0700289TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100290 RtpCapabilities capabilities = engine_.GetCapabilities();
291 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700292 for (const RtpExtension& extension : capabilities.header_extensions) {
293 if (extension.uri == RtpExtension::kVideoRotationUri) {
294 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700295 return;
296 }
297 }
298 FAIL() << "Video Rotation extension not in header-extension list.";
299}
300
eladalonf1841382017-06-12 01:16:46 -0700301TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700302 // Allocate the capturer first to prevent early destruction before channel's
303 // dtor is called.
Tommi85959932018-02-07 19:26:06 +0100304 FakeVideoCapturerWithTaskQueue capturer;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700305
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200306 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700307
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200308 std::unique_ptr<VideoMediaChannel> channel(
309 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700310 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
311
312 // Add CVO extension.
313 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800314 cricket::VideoSendParameters parameters;
315 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200316 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700317 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200318 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700319
320 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200321 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700322
323 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700324 EXPECT_FALSE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700325
326 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200327 parameters.extensions.clear();
328 EXPECT_TRUE(channel->SetSendParameters(parameters));
nisse47ac4622016-05-25 08:47:01 -0700329 EXPECT_TRUE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700330}
331
eladalonf1841382017-06-12 01:16:46 -0700332TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
perkj91e1c152016-03-02 05:34:00 -0800333 // Allocate the capturer first to prevent early destruction before channel's
334 // dtor is called.
Tommi85959932018-02-07 19:26:06 +0100335 FakeVideoCapturerWithTaskQueue capturer;
perkj91e1c152016-03-02 05:34:00 -0800336
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200337 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800338
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200339 std::unique_ptr<VideoMediaChannel> channel(
340 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800341 // Add CVO extension.
342 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800343 cricket::VideoSendParameters parameters;
344 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800345 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700346 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800347 EXPECT_TRUE(channel->SetSendParameters(parameters));
348 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
349
350 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200351 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
perkj91e1c152016-03-02 05:34:00 -0800352
353 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700354 EXPECT_FALSE(capturer.apply_rotation());
perkj91e1c152016-03-02 05:34:00 -0800355}
356
eladalonf1841382017-06-12 01:16:46 -0700357TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Tommi85959932018-02-07 19:26:06 +0100358 FakeVideoCapturerWithTaskQueue capturer;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200360 encoder_factory_->AddSupportedVideoCodecType("VP8");
361 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700362
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200363 std::unique_ptr<VideoMediaChannel> channel(
364 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
366
367 // Set capturer.
Niels Möllerff40b142018-04-09 08:49:14 +0200368 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369
perkjcaafdba2016-03-20 07:34:29 -0700370 // Verify capturer has turned on applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700371 EXPECT_TRUE(capturer.apply_rotation());
perkjcaafdba2016-03-20 07:34:29 -0700372
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373 // Add CVO extension.
374 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800375 cricket::VideoSendParameters parameters;
376 parameters.codecs.push_back(GetEngineCodec("VP8"));
377 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200378 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700379 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700380 // Also remove the first codec to trigger a codec change as well.
381 parameters.codecs.erase(parameters.codecs.begin());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200382 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700383
384 // Verify capturer has turned off applying rotation.
nisse47ac4622016-05-25 08:47:01 -0700385 EXPECT_FALSE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700386
387 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200388 parameters.extensions.clear();
389 EXPECT_TRUE(channel->SetSendParameters(parameters));
nisse47ac4622016-05-25 08:47:01 -0700390 EXPECT_TRUE(capturer.apply_rotation());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700391}
392
eladalonf1841382017-06-12 01:16:46 -0700393TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200394 encoder_factory_->AddSupportedVideoCodecType("VP8");
395
kwiberg686a8ef2016-02-26 03:00:35 -0800396 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800397 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000398
399 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
400
401 EXPECT_FALSE(channel->SetSend(true))
402 << "Channel should not start without codecs.";
403 EXPECT_TRUE(channel->SetSend(false))
404 << "Channel should be stoppable even without set codecs.";
405}
406
eladalonf1841382017-06-12 01:16:46 -0700407TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200408 encoder_factory_->AddSupportedVideoCodecType("VP8");
409
kwiberg686a8ef2016-02-26 03:00:35 -0800410 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800411 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000412 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
413 VideoMediaInfo info;
414 channel->GetStats(&info);
415}
416
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200417TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200418 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000419
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200420 std::unique_ptr<VideoMediaChannel> channel(
421 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800422 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000423
424 EXPECT_TRUE(
425 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200426 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000427 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100428 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200429 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000430 EXPECT_EQ(cricket::CS_RUNNING,
431 capturer.Start(capturer.GetSupportedFormats()->front()));
432 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100433 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200434 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
435 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000436 kTimeout);
437
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200438 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100439 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000440
441 // Setting codecs of the same type should not reallocate any encoders
442 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800443 cricket::VideoSendParameters parameters;
444 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200445 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200446 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000447
448 // Remove stream previously added to free the external encoder instance.
449 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200450 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000451}
452
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200453// Test that when an encoder factory supports H264, we add an RTX
454// codec for it.
455// TODO(deadbeef): This test should be updated if/when we start
456// adding RTX codecs for unrecognized codec names.
457TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800458 using webrtc::H264::ProfileLevelIdToString;
459 using webrtc::H264::ProfileLevelId;
460 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200461 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
462 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800463 *ProfileLevelIdToString(
464 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200465 webrtc::SdpVideoFormat h264_constrained_high("H264");
466 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800467 *ProfileLevelIdToString(
468 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200469 webrtc::SdpVideoFormat h264_high("H264");
470 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800471 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
472
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200473 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
474 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
475 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700476
magjed725e4842016-11-16 00:48:13 -0800477 // First figure out what payload types the test codecs got assigned.
478 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800479 // Now search for RTX codecs for them. Expect that they all have associated
480 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800481 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200482 codecs,
483 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
484 ->id));
magjed725e4842016-11-16 00:48:13 -0800485 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200486 codecs,
487 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
488 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800489 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200490 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700491}
492
Peter Boström12996152016-05-14 02:03:18 +0200493#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700494TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200495 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100496
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200497 std::unique_ptr<VideoMediaChannel> channel(
498 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100499
500 EXPECT_TRUE(
501 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
502}
Peter Boström12996152016-05-14 02:03:18 +0200503#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100504
eladalonf1841382017-06-12 01:16:46 -0700505TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100507 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200508 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200509 std::unique_ptr<VideoMediaChannel> channel(
510 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700511
512 EXPECT_TRUE(
513 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
514
Tommi85959932018-02-07 19:26:06 +0100515 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200516 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700517 capturer.Start(cricket::VideoFormat(1280, 720,
518 cricket::VideoFormat::FpsToInterval(60),
519 cricket::FOURCC_I420));
520 channel->SetSend(true);
521
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200522 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700523
524 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700525 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700526 for (int i = 0; i < 10; i++) {
527 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700528 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700529 int64_t interval = timestamp - last_timestamp;
530
531 // Precision changes from nanosecond to millisecond.
532 // Allow error to be no more than 1.
533 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
534
535 last_timestamp = timestamp;
536 }
537
538 capturer.Start(cricket::VideoFormat(1280, 720,
539 cricket::VideoFormat::FpsToInterval(30),
540 cricket::FOURCC_I420));
541
542 EXPECT_TRUE(capturer.CaptureFrame());
543 last_timestamp = stream->GetLastTimestamp();
544 for (int i = 0; i < 10; i++) {
545 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700546 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700547 int64_t interval = timestamp - last_timestamp;
548
549 // Precision changes from nanosecond to millisecond.
550 // Allow error to be no more than 1.
551 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
552
553 last_timestamp = timestamp;
554 }
555
556 // Remove stream previously added to free the external encoder instance.
557 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
558}
559
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200560void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
561 std::vector<VideoCodec> engine_codecs = engine_.codecs();
562 RTC_DCHECK(!engine_codecs.empty());
563 for (const cricket::VideoCodec& codec : engine_codecs) {
564 if (codec.name == "rtx") {
565 int associated_payload_type;
566 if (codec.GetParam(kCodecParamAssociatedPayloadType,
567 &associated_payload_type)) {
568 default_apt_rtx_types_[associated_payload_type] = codec.id;
569 }
570 }
571 }
572}
573
574void WebRtcVideoEngineTest::AssignDefaultCodec() {
575 std::vector<VideoCodec> engine_codecs = engine_.codecs();
576 RTC_DCHECK(!engine_codecs.empty());
577 bool codec_set = false;
578 for (const cricket::VideoCodec& codec : engine_codecs) {
579 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
580 codec.name != "ulpfec") {
581 default_codec_ = codec;
582 codec_set = true;
583 }
584 }
585
586 RTC_DCHECK(codec_set);
587}
588
Oleh Prypina40f8242017-12-21 13:32:23 +0100589size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
590 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100591 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
592 for (size_t i = 0; i < codecs.size(); ++i) {
593 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200594 if (!CodecNamesEq(name, engine_codec.name))
595 continue;
596 // The tests only use H264 Constrained Baseline. Make sure we don't return
597 // an internal H264 codec from the engine with a different H264 profile.
598 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200599 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200600 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
601 if (profile_level_id->profile !=
602 webrtc::H264::kProfileConstrainedBaseline) {
603 continue;
604 }
605 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100606 return i;
magjed509e4fe2016-11-18 01:34:11 -0800607 }
608 // This point should never be reached.
609 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100610 return -1;
611}
612
613cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
614 const std::string& name) const {
615 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800616}
617
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200618VideoMediaChannel*
619WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000620 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800621 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200622 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800623 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200624 for (const webrtc::SdpVideoFormat& format :
625 encoder_factory_->GetSupportedFormats()) {
626 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
627 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
628 engine_codec) == parameters.codecs.end()) {
629 parameters.codecs.push_back(engine_codec);
630 }
631 }
magjed509e4fe2016-11-18 01:34:11 -0800632
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200633 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000634
635 return channel;
636}
637
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200638VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000639 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000640 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800641 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200642 cricket::VideoRecvParameters parameters;
643 parameters.codecs = codecs;
644 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000645
646 return channel;
647}
648
eladalonf1841382017-06-12 01:16:46 -0700649TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200650 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000651
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200652 std::unique_ptr<VideoMediaChannel> channel(
653 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000654
Peter Boström0c4e06b2015-10-07 12:23:21 +0200655 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000656
Yves Gerey665174f2018-06-19 15:03:05 +0200657 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000658 EXPECT_TRUE(channel->SetSend(true));
659
Tommi85959932018-02-07 19:26:06 +0100660 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200661 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000662 EXPECT_EQ(cricket::CS_RUNNING,
663 capturer.Start(capturer.GetSupportedFormats()->front()));
664 EXPECT_TRUE(capturer.CaptureFrame());
665
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200666 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000667
668 // Verify that encoders are configured for simulcast through adapter
669 // (increasing resolution and only configured to send one stream each).
670 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200671 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
672 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000673 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200674 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000675 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
676 EXPECT_GT(codec_settings.width, prev_width);
677 prev_width = codec_settings.width;
678 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000679
Niels Möllerff40b142018-04-09 08:49:14 +0200680 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000681
682 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200683 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000684}
685
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200686TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
687 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200688 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000689
Niels Möller4db138e2018-04-19 09:04:13 +0200690 // Set capturer.
691 FakeVideoCapturerWithTaskQueue capturer;
692 EXPECT_EQ(cricket::CS_RUNNING,
693 capturer.Start(capturer.GetSupportedFormats()->front()));
694
Anders Carlsson67537952018-05-03 11:28:29 +0200695 std::unique_ptr<VideoMediaChannel> channel(
696 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
697 cricket::VideoSendParameters parameters;
698 parameters.codecs.push_back(GetEngineCodec("H264"));
699 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000700
701 EXPECT_TRUE(
702 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200703 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
704 // Sending one frame will have allocate the encoder.
705 EXPECT_TRUE(capturer.CaptureFrame());
706
707 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000708
Anders Carlsson67537952018-05-03 11:28:29 +0200709 cricket::VideoSendParameters new_parameters;
710 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
711 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200712
713 // Sending one frame will switch encoder.
714 EXPECT_TRUE(capturer.CaptureFrame());
715
Anders Carlsson8a150d92018-05-14 12:40:04 +0200716 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000717}
718
eladalonf1841382017-06-12 01:16:46 -0700719TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000720 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200721 encoder_factory_->AddSupportedVideoCodecType("VP8");
722 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000723
kwiberg686a8ef2016-02-26 03:00:35 -0800724 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800725 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800726 cricket::VideoSendParameters parameters;
727 parameters.codecs.push_back(GetEngineCodec("VP8"));
728 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000729
Peter Boström0c4e06b2015-10-07 12:23:21 +0200730 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000731
Yves Gerey665174f2018-06-19 15:03:05 +0200732 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000733 EXPECT_TRUE(channel->SetSend(true));
734
735 // Send a fake frame, or else the media engine will configure the simulcast
736 // encoder adapter at a low-enough size that it'll only create a single
737 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100738 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200739 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000740 EXPECT_EQ(cricket::CS_RUNNING,
741 capturer.Start(capturer.GetSupportedFormats()->front()));
742 EXPECT_TRUE(capturer.CaptureFrame());
743
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200744 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
745 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000746 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200747 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000748
749 channel.reset();
750 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200751 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000752}
753
eladalonf1841382017-06-12 01:16:46 -0700754TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000755 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200756 encoder_factory_->AddSupportedVideoCodecType("VP8");
757 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000758
kwiberg686a8ef2016-02-26 03:00:35 -0800759 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800760 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800761 cricket::VideoSendParameters parameters;
762 parameters.codecs.push_back(GetEngineCodec("H264"));
763 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000764
765 EXPECT_TRUE(
766 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100767
768 // Send a frame of 720p. This should trigger a "real" encoder initialization.
769 cricket::VideoFormat format(
770 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100771 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200772 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100773 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
774 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200775 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
776 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000778 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200779 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000780
781 channel.reset();
782 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200783 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000784}
785
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200786TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
787 webrtc::test::ScopedFieldTrials override_field_trials_(
788 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200789 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700790
Anders Carlsson67537952018-05-03 11:28:29 +0200791 std::unique_ptr<VideoMediaChannel> channel(
792 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
793 cricket::VideoSendParameters parameters;
794 parameters.codecs.push_back(GetEngineCodec("H264"));
795 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700796
Peter Boström0c4e06b2015-10-07 12:23:21 +0200797 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700798 EXPECT_TRUE(
799 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100800
801 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700802 cricket::VideoFormat format(
803 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100804 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200805 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100806 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
807 EXPECT_TRUE(capturer.CaptureFrame());
808
Niels Möller4db138e2018-04-19 09:04:13 +0200809 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200810 ASSERT_EQ(1u, encoder_factory_->encoders().size());
811 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
812 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700813 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200814 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200815 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700816}
817
brandtrffc61182016-11-28 06:02:22 -0800818// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700819// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800820//
821// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700822TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800823 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200824 encoder_factory_->AddSupportedVideoCodecType("VP8");
825
brandtrffc61182016-11-28 06:02:22 -0800826 auto is_flexfec = [](const VideoCodec& codec) {
827 if (codec.name == "flexfec-03")
828 return true;
829 return false;
830 };
831
832 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800833 const std::vector<VideoCodec> codecs_before = engine_.codecs();
834 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
835 codecs_before.end(), is_flexfec));
836
837 // FlexFEC is active with field trial.
838 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800839 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800840 const std::vector<VideoCodec> codecs_after = engine_.codecs();
841 EXPECT_NE(codecs_after.end(),
842 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
843}
844
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200845// Test that codecs are added in the order they are reported from the factory.
846TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
847 encoder_factory_->AddSupportedVideoCodecType("VP8");
848 const char* kFakeCodecName = "FakeCodec";
849 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000850
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200851 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100852 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200853 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
854 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000855}
856
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200857// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800858// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200859TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100860 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
861 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100862
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100863 // Set up external encoder factory with first codec, and initialize engine.
864 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
865
brandtrffc61182016-11-28 06:02:22 -0800866 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800867
868 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100869 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800870 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
871 EXPECT_EQ(codecs_before.size() + 1, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100872
873 // Check that both fake codecs are present and that the second fake codec
874 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100875 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
876 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100877 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800878}
879
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200880TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
881 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200882 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200883 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800884 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000885
kwiberg686a8ef2016-02-26 03:00:35 -0800886 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200887 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000888
889 EXPECT_TRUE(
890 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200891 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000892
893 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200894 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200895 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000896
897 // Remove stream previously added to free the external decoder instance.
898 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200899 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000900}
901
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200902// Verifies that we can set up decoders.
903TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000904 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
905 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
906 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
907 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200908 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200909 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000910 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800911 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000912
kwiberg686a8ef2016-02-26 03:00:35 -0800913 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200914 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000915
916 EXPECT_TRUE(
917 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200918 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000919}
920
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200921TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
922 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
923 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
924 WebRtcVideoEngine engine(std::move(encoder_factory),
925 std::move(decoder_factory));
926 EXPECT_EQ(0u, engine.codecs().size());
927}
928
929TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
930 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700931 webrtc::MockVideoEncoderFactory* encoder_factory =
932 new webrtc::MockVideoEncoderFactory();
933 webrtc::MockVideoDecoderFactory* decoder_factory =
934 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200935 WebRtcVideoEngine engine(
936 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
937 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
938 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
939 EXPECT_EQ(0u, engine.codecs().size());
940 EXPECT_CALL(*encoder_factory, Die());
941 EXPECT_CALL(*decoder_factory, Die());
942}
943
944// Test full behavior in the video engine when video codec factories of the new
945// type are injected supporting the single codec Vp8. Check the returned codecs
946// from the engine and that we will create a Vp8 encoder and decoder using the
947// new factories.
948TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
949 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700950 webrtc::MockVideoEncoderFactory* encoder_factory =
951 new webrtc::MockVideoEncoderFactory();
952 webrtc::MockVideoDecoderFactory* decoder_factory =
953 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200954 WebRtcVideoEngine engine(
955 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
956 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
957 const webrtc::SdpVideoFormat vp8_format("VP8");
958 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
959 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
960 .WillRepeatedly(testing::Return(supported_formats));
961
962 // Verify the codecs from the engine.
963 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100964 // Verify default codecs has been added correctly.
965 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200966 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100967
968 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200969 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100970 int vp8_associated_payload;
971 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
972 &vp8_associated_payload));
973 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
974
975 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
976
977 // RTX codec for RED.
978 EXPECT_EQ("rtx", engine_codecs.at(3).name);
979 int red_associated_payload;
980 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
981 &red_associated_payload));
982 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
983
984 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
985
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200986 int associated_payload_type;
987 EXPECT_TRUE(engine_codecs.at(1).GetParam(
988 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
989 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
990 // Verify default parameters has been added to the VP8 codec.
991 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
992
993 // Mock encoder creation. |engine| take ownership of the encoder.
994 webrtc::VideoEncoderFactory::CodecInfo codec_info;
995 codec_info.is_hardware_accelerated = false;
996 codec_info.has_internal_source = false;
997 const webrtc::SdpVideoFormat format("VP8");
998 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
999 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001000 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001001 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001002 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001003 .WillOnce(
1004 ::testing::DoAll(::testing::InvokeWithoutArgs(
1005 [&encoder_created]() { encoder_created.Set(); }),
1006 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001007
1008 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001009 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001010 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1011 .WillOnce(testing::Return(decoder));
1012
1013 // Create a call.
1014 webrtc::RtcEventLogNullImpl event_log;
1015 std::unique_ptr<webrtc::Call> call(
1016 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1017
1018 // Create send channel.
1019 const int send_ssrc = 123;
1020 std::unique_ptr<VideoMediaChannel> send_channel(
1021 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1022 cricket::VideoSendParameters send_parameters;
1023 send_parameters.codecs.push_back(engine_codecs.at(0));
1024 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1025 send_channel->OnReadyToSend(true);
1026 EXPECT_TRUE(
1027 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1028 EXPECT_TRUE(send_channel->SetSend(true));
1029
Niels Möller4db138e2018-04-19 09:04:13 +02001030 // Set capturer.
1031 FakeVideoCapturerWithTaskQueue capturer;
1032 EXPECT_EQ(cricket::CS_RUNNING,
1033 capturer.Start(capturer.GetSupportedFormats()->front()));
1034 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1035 // Sending one frame will allocate the encoder.
1036 EXPECT_TRUE(capturer.CaptureFrame());
1037 encoder_created.Wait(kTimeout);
1038
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001039 // Create recv channel.
1040 const int recv_ssrc = 321;
1041 std::unique_ptr<VideoMediaChannel> recv_channel(
1042 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1043 cricket::VideoRecvParameters recv_parameters;
1044 recv_parameters.codecs.push_back(engine_codecs.at(0));
1045 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1046 EXPECT_TRUE(recv_channel->AddRecvStream(
1047 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1048
1049 // Remove streams previously added to free the encoder and decoder instance.
1050 EXPECT_CALL(*encoder_factory, Die());
1051 EXPECT_CALL(*decoder_factory, Die());
1052 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1053 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1054}
1055
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001056// Test behavior when decoder factory fails to create a decoder (returns null).
1057TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1058 // |engine| take ownership of the factories.
1059 webrtc::MockVideoEncoderFactory* encoder_factory =
1060 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1061 webrtc::MockVideoDecoderFactory* decoder_factory =
1062 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1063 WebRtcVideoEngine engine(
1064 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1065 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1066 const webrtc::SdpVideoFormat vp8_format("VP8");
1067 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1068 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1069 .WillRepeatedly(testing::Return(supported_formats));
1070
1071 // Decoder creation fails.
1072 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1073 .WillOnce(testing::Return(nullptr));
1074
1075 // Create a call.
1076 webrtc::RtcEventLogNullImpl event_log;
1077 std::unique_ptr<webrtc::Call> call(
1078 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1079
1080 // Create recv channel.
1081 const int recv_ssrc = 321;
1082 std::unique_ptr<VideoMediaChannel> recv_channel(
1083 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1084 cricket::VideoRecvParameters recv_parameters;
1085 recv_parameters.codecs.push_back(engine.codecs().front());
1086 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1087 EXPECT_TRUE(recv_channel->AddRecvStream(
1088 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1089
1090 // Remove streams previously added to free the encoder and decoder instance.
1091 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1092}
1093
eladalonf1841382017-06-12 01:16:46 -07001094TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001095 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001096 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001097 std::unique_ptr<VideoMediaChannel> channel(
1098 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001099 ASSERT_TRUE(
1100 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1101 cricket::VideoCodec codec = GetEngineCodec("VP8");
1102 cricket::VideoSendParameters parameters;
1103 parameters.codecs.push_back(codec);
1104 channel->OnReadyToSend(true);
1105 channel->SetSend(true);
1106 ASSERT_TRUE(channel->SetSendParameters(parameters));
1107
Tommi85959932018-02-07 19:26:06 +01001108 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001109 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001110 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001111
1112 EXPECT_EQ(cricket::CS_RUNNING,
1113 capturer.Start(capturer.GetSupportedFormats()->front()));
1114 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001115 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001116 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001117 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001118
Niels Möllerff40b142018-04-09 08:49:14 +02001119 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001120 EXPECT_TRUE(capturer.CaptureFrame());
1121 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001122 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001123
1124 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001125 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001126 EXPECT_TRUE(capturer.CaptureFrame());
1127 // Change to screen content, recreate encoder. For the simulcast encoder
1128 // adapter case, this will result in two calls since InitEncode triggers a
1129 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001130 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001131 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001132 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001133
Niels Möllerff40b142018-04-09 08:49:14 +02001134 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001135 EXPECT_TRUE(capturer.CaptureFrame());
1136 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001137 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001138
1139 options.is_screencast.emplace(false);
1140 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001141 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001142 // Change back to regular video content, update encoder. Also change
1143 // a non |is_screencast| option just to verify it doesn't affect recreation.
1144 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001145 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001146 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001147 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001148
1149 // Remove stream previously added to free the external encoder instance.
1150 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001151 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001152}
1153
Niels Möller6557d0c2018-04-11 15:18:34 +02001154class WebRtcVideoChannelBaseTest : public testing::Test {
1155 protected:
1156 WebRtcVideoChannelBaseTest()
1157 : call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001158 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1159 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001160
1161 virtual void SetUp() {
1162 cricket::MediaConfig media_config;
1163 // Disabling cpu overuse detection actually disables quality scaling too; it
1164 // implies DegradationPreference kMaintainResolution. Automatic scaling
1165 // needs to be disabled, otherwise, tests which check the size of received
1166 // frames become flaky.
1167 media_config.video.enable_cpu_adaptation = false;
1168 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
1169 cricket::VideoOptions()));
1170 channel_->OnReadyToSend(true);
1171 EXPECT_TRUE(channel_.get() != NULL);
1172 network_interface_.SetDestination(channel_.get());
1173 channel_->SetInterface(&network_interface_);
1174 cricket::VideoRecvParameters parameters;
1175 parameters.codecs = engine_.codecs();
1176 channel_->SetRecvParameters(parameters);
1177 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1178 video_capturer_.reset(CreateFakeVideoCapturer());
1179 cricket::VideoFormat format(640, 480,
1180 cricket::VideoFormat::FpsToInterval(kFramerate),
1181 cricket::FOURCC_I420);
1182 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001183 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001184 }
1185
1186 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1187 return new cricket::FakeVideoCapturerWithTaskQueue();
1188 }
1189
1190 // Utility method to setup an additional stream to send and receive video.
1191 // Used to test send and recv between two streams.
1192 void SetUpSecondStream() {
1193 SetUpSecondStreamWithNoRecv();
1194 // Setup recv for second stream.
1195 EXPECT_TRUE(channel_->AddRecvStream(
1196 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1197 // Make the second renderer available for use by a new stream.
1198 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1199 }
1200 // Setup an additional stream just to send video. Defer add recv stream.
1201 // This is required if you want to test unsignalled recv of video rtp packets.
1202 void SetUpSecondStreamWithNoRecv() {
1203 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001204 EXPECT_TRUE(
1205 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001206 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001207 EXPECT_FALSE(
1208 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001209 EXPECT_TRUE(channel_->AddSendStream(
1210 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1211 // We dont add recv for the second stream.
1212
1213 // Setup the receive and renderer for second stream after send.
1214 video_capturer_2_.reset(CreateFakeVideoCapturer());
1215 cricket::VideoFormat format(640, 480,
1216 cricket::VideoFormat::FpsToInterval(kFramerate),
1217 cricket::FOURCC_I420);
1218 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1219
Yves Gerey665174f2018-06-19 15:03:05 +02001220 EXPECT_TRUE(
1221 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001222 }
Yves Gerey665174f2018-06-19 15:03:05 +02001223 virtual void TearDown() { channel_.reset(); }
1224 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001225
1226 bool SetOneCodec(const cricket::VideoCodec& codec) {
1227 cricket::VideoFormat capture_format(
1228 kVideoWidth, kVideoHeight,
1229 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1230
1231 if (video_capturer_) {
1232 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1233 }
1234 if (video_capturer_2_) {
1235 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1236 }
1237
1238 bool sending = channel_->sending();
1239 bool success = SetSend(false);
1240 if (success) {
1241 cricket::VideoSendParameters parameters;
1242 parameters.codecs.push_back(codec);
1243 success = channel_->SetSendParameters(parameters);
1244 }
1245 if (success) {
1246 success = SetSend(sending);
1247 }
1248 return success;
1249 }
Yves Gerey665174f2018-06-19 15:03:05 +02001250 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001251 bool SendFrame() {
1252 if (video_capturer_2_) {
1253 video_capturer_2_->CaptureFrame();
1254 }
1255 return video_capturer_.get() && video_capturer_->CaptureFrame();
1256 }
1257 bool WaitAndSendFrame(int wait_ms) {
1258 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1259 ret &= SendFrame();
1260 return ret;
1261 }
Yves Gerey665174f2018-06-19 15:03:05 +02001262 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001263 int NumRtpBytes(uint32_t ssrc) {
1264 return network_interface_.NumRtpBytes(ssrc);
1265 }
Yves Gerey665174f2018-06-19 15:03:05 +02001266 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001267 int NumRtpPackets(uint32_t ssrc) {
1268 return network_interface_.NumRtpPackets(ssrc);
1269 }
Yves Gerey665174f2018-06-19 15:03:05 +02001270 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001271 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1272 return network_interface_.GetRtpPacket(index);
1273 }
1274 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
1275 int pt = -1;
1276 ParseRtpPacket(p, NULL, &pt, NULL, NULL, NULL, NULL);
1277 return pt;
1278 }
1279 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
1280 bool* x,
1281 int* pt,
1282 int* seqnum,
1283 uint32_t* tstamp,
1284 uint32_t* ssrc,
1285 std::string* payload) {
1286 rtc::ByteBufferReader buf(p->data<char>(), p->size());
1287 uint8_t u08 = 0;
1288 uint16_t u16 = 0;
1289 uint32_t u32 = 0;
1290
1291 // Read X and CC fields.
Yves Gerey665174f2018-06-19 15:03:05 +02001292 if (!buf.ReadUInt8(&u08))
1293 return false;
Niels Möller6557d0c2018-04-11 15:18:34 +02001294 bool extension = ((u08 & 0x10) != 0);
1295 uint8_t cc = (u08 & 0x0F);
Yves Gerey665174f2018-06-19 15:03:05 +02001296 if (x)
1297 *x = extension;
Niels Möller6557d0c2018-04-11 15:18:34 +02001298
1299 // Read PT field.
Yves Gerey665174f2018-06-19 15:03:05 +02001300 if (!buf.ReadUInt8(&u08))
1301 return false;
1302 if (pt)
1303 *pt = (u08 & 0x7F);
Niels Möller6557d0c2018-04-11 15:18:34 +02001304
1305 // Read Sequence Number field.
Yves Gerey665174f2018-06-19 15:03:05 +02001306 if (!buf.ReadUInt16(&u16))
1307 return false;
1308 if (seqnum)
1309 *seqnum = u16;
Niels Möller6557d0c2018-04-11 15:18:34 +02001310
1311 // Read Timestamp field.
Yves Gerey665174f2018-06-19 15:03:05 +02001312 if (!buf.ReadUInt32(&u32))
1313 return false;
1314 if (tstamp)
1315 *tstamp = u32;
Niels Möller6557d0c2018-04-11 15:18:34 +02001316
1317 // Read SSRC field.
Yves Gerey665174f2018-06-19 15:03:05 +02001318 if (!buf.ReadUInt32(&u32))
1319 return false;
1320 if (ssrc)
1321 *ssrc = u32;
Niels Möller6557d0c2018-04-11 15:18:34 +02001322
1323 // Skip CSRCs.
1324 for (uint8_t i = 0; i < cc; ++i) {
Yves Gerey665174f2018-06-19 15:03:05 +02001325 if (!buf.ReadUInt32(&u32))
1326 return false;
Niels Möller6557d0c2018-04-11 15:18:34 +02001327 }
1328
1329 // Skip extension header.
1330 if (extension) {
1331 // Read Profile-specific extension header ID
Yves Gerey665174f2018-06-19 15:03:05 +02001332 if (!buf.ReadUInt16(&u16))
1333 return false;
Niels Möller6557d0c2018-04-11 15:18:34 +02001334
1335 // Read Extension header length
Yves Gerey665174f2018-06-19 15:03:05 +02001336 if (!buf.ReadUInt16(&u16))
1337 return false;
Niels Möller6557d0c2018-04-11 15:18:34 +02001338 uint16_t ext_header_len = u16;
1339
1340 // Read Extension header
1341 for (uint16_t i = 0; i < ext_header_len; ++i) {
Yves Gerey665174f2018-06-19 15:03:05 +02001342 if (!buf.ReadUInt32(&u32))
1343 return false;
Niels Möller6557d0c2018-04-11 15:18:34 +02001344 }
1345 }
1346
1347 if (payload) {
1348 return buf.ReadString(payload, buf.Length());
1349 }
1350 return true;
1351 }
1352
1353 // Tests that we can send and receive frames.
1354 void SendAndReceive(const cricket::VideoCodec& codec) {
1355 EXPECT_TRUE(SetOneCodec(codec));
1356 EXPECT_TRUE(SetSend(true));
1357 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1358 EXPECT_EQ(0, renderer_.num_rendered_frames());
1359 EXPECT_TRUE(SendFrame());
1360 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1361 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1362 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1363 }
1364
1365 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001366 int duration_sec,
1367 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001368 EXPECT_TRUE(SetOneCodec(codec));
1369 EXPECT_TRUE(SetSend(true));
1370 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1371 EXPECT_EQ(0, renderer_.num_rendered_frames());
1372 for (int i = 0; i < duration_sec; ++i) {
1373 for (int frame = 1; frame <= fps; ++frame) {
1374 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1375 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1376 }
1377 }
1378 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1379 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1380 }
1381
Niels Möller6557d0c2018-04-11 15:18:34 +02001382 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1383 cricket::VideoMediaInfo info;
1384 EXPECT_TRUE(channel_->GetStats(&info));
1385 return info.senders[i];
1386 }
1387
1388 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1389 cricket::VideoMediaInfo info;
1390 EXPECT_TRUE(channel_->GetStats(&info));
1391 return info.receivers[i];
1392 }
1393
1394 // Two streams one channel tests.
1395
1396 // Tests that we can send and receive frames.
1397 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1398 SetUpSecondStream();
1399 // Test sending and receiving on first stream.
1400 SendAndReceive(codec);
1401 // Test sending and receiving on second stream.
1402 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1403 EXPECT_GT(NumRtpPackets(), 0);
1404 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1405 }
1406
1407 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1408 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1409 if (CodecNamesEq(name, engine_codec.name))
1410 return engine_codec;
1411 }
1412 // This point should never be reached.
1413 ADD_FAILURE() << "Unrecognized codec name: " << name;
1414 return cricket::VideoCodec();
1415 }
1416
1417 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1418
1419 cricket::StreamParams DefaultSendStreamParams() {
1420 return cricket::StreamParams::CreateLegacy(kSsrc);
1421 }
1422
1423 webrtc::RtcEventLogNullImpl event_log_;
1424 const std::unique_ptr<webrtc::Call> call_;
1425 WebRtcVideoEngine engine_;
1426 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1427 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1428 std::unique_ptr<WebRtcVideoChannel> channel_;
1429 cricket::FakeNetworkInterface network_interface_;
1430 cricket::FakeVideoRenderer renderer_;
1431
1432 // Used by test cases where 2 streams are run on the same channel.
1433 cricket::FakeVideoRenderer renderer2_;
1434};
1435
1436// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001437TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001438 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001439 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001440 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1441 EXPECT_FALSE(channel_->sending());
1442 EXPECT_TRUE(SetSend(true));
1443 EXPECT_TRUE(channel_->sending());
1444 EXPECT_TRUE(SendFrame());
1445 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1446 EXPECT_TRUE(SetSend(false));
1447 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001448}
Niels Möller6557d0c2018-04-11 15:18:34 +02001449
1450// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001451TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001452 EXPECT_FALSE(channel_->sending());
1453 EXPECT_FALSE(SetSend(true));
1454 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001455}
Niels Möller6557d0c2018-04-11 15:18:34 +02001456
1457// Test that we properly set the send and recv buffer sizes by the time
1458// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001459TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001460 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1461 EXPECT_TRUE(SetSend(true));
1462 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1463 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001464}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001465
Niels Möller6557d0c2018-04-11 15:18:34 +02001466// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001467TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001468 const int kDurationSec = 3;
1469 const int kFps = 10;
1470 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1471
1472 cricket::VideoMediaInfo info;
1473 EXPECT_TRUE(channel_->GetStats(&info));
1474
1475 ASSERT_EQ(1U, info.senders.size());
1476 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1477 // For webrtc, bytes_sent does not include the RTP header length.
1478 EXPECT_GT(info.senders[0].bytes_sent, 0);
1479 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1480 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1481 ASSERT_TRUE(info.senders[0].codec_payload_type);
1482 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1483 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1484 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1485 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1486 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1487 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1488 EXPECT_GT(info.senders[0].framerate_input, 0);
1489 EXPECT_GT(info.senders[0].framerate_sent, 0);
1490
1491 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1492 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1493 info.send_codecs[DefaultCodec().id]);
1494
1495 ASSERT_EQ(1U, info.receivers.size());
1496 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1497 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1498 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1499 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1500 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1501 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1502 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1503 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1504 EXPECT_EQ(0, info.receivers[0].packets_lost);
1505 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1506 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1507 EXPECT_EQ(0, info.receivers[0].firs_sent);
1508 EXPECT_EQ(0, info.receivers[0].plis_sent);
1509 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1510 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1511 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1512 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1513 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1514 EXPECT_GT(info.receivers[0].framerate_output, 0);
1515
1516 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1517 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1518 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001519}
Niels Möller6557d0c2018-04-11 15:18:34 +02001520
1521// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001522TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001523 cricket::FakeVideoRenderer renderer1, renderer2;
1524 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1525 cricket::VideoSendParameters parameters;
1526 parameters.codecs.push_back(DefaultCodec());
1527 parameters.conference_mode = true;
1528 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1529 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001530 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1531 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001532 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1533 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1534 EXPECT_EQ(0, renderer1.num_rendered_frames());
1535 EXPECT_EQ(0, renderer2.num_rendered_frames());
1536 std::vector<uint32_t> ssrcs;
1537 ssrcs.push_back(1);
1538 ssrcs.push_back(2);
1539 network_interface_.SetConferenceMode(true, ssrcs);
1540 EXPECT_TRUE(SendFrame());
1541 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1542 kTimeout);
1543 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1544 kTimeout);
1545
1546 EXPECT_TRUE(channel_->SetSend(false));
1547
1548 cricket::VideoMediaInfo info;
1549 EXPECT_TRUE(channel_->GetStats(&info));
1550 ASSERT_EQ(1U, info.senders.size());
1551 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1552 // For webrtc, bytes_sent does not include the RTP header length.
1553 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1554 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1555 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1556 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1557
1558 ASSERT_EQ(2U, info.receivers.size());
1559 for (size_t i = 0; i < info.receivers.size(); ++i) {
1560 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1561 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1562 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001563 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001564 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1565 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1566 }
srtee0c2eea2017-12-15 17:44:33 +01001567}
Niels Möller6557d0c2018-04-11 15:18:34 +02001568
1569// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001570TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001571 // Normal setup; note that we set the SSRC explicitly to ensure that
1572 // it will come first in the senders map.
1573 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1574 cricket::VideoSendParameters parameters;
1575 parameters.codecs.push_back(DefaultCodec());
1576 parameters.conference_mode = true;
1577 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001578 EXPECT_TRUE(
1579 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001580 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1581 EXPECT_TRUE(SetSend(true));
1582 EXPECT_TRUE(SendFrame());
1583 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1584 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1585
1586 // Add an additional capturer, and hook up a renderer to receive it.
1587 cricket::FakeVideoRenderer renderer2;
1588 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1589 CreateFakeVideoCapturer());
1590 const int kTestWidth = 160;
1591 const int kTestHeight = 120;
1592 cricket::VideoFormat format(kTestWidth, kTestHeight,
1593 cricket::VideoFormat::FpsToInterval(5),
1594 cricket::FOURCC_I420);
1595 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001596 EXPECT_TRUE(
1597 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001598 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001599 EXPECT_TRUE(
1600 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001601 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1602 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001603 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1604 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001605
1606 // Get stats, and make sure they are correct for two senders. We wait until
1607 // the number of expected packets have been sent to avoid races where we
1608 // check stats before it has been updated.
1609 cricket::VideoMediaInfo info;
1610 for (uint32_t i = 0; i < kTimeout; ++i) {
1611 rtc::Thread::Current()->ProcessMessages(1);
1612 EXPECT_TRUE(channel_->GetStats(&info));
1613 ASSERT_EQ(2U, info.senders.size());
1614 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1615 NumRtpPackets()) {
1616 // Stats have been updated for both sent frames, expectations can be
1617 // checked now.
1618 break;
1619 }
1620 }
1621 EXPECT_EQ(NumRtpPackets(),
1622 info.senders[0].packets_sent + info.senders[1].packets_sent)
1623 << "Timed out while waiting for packet counts for all sent packets.";
1624 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1625 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1626 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1627 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1628 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1629 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1630 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1631 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1632 // The capturer must be unregistered here as it runs out of it's scope next.
1633 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001634}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001635
Niels Möller6557d0c2018-04-11 15:18:34 +02001636// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001637TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001638 cricket::VideoSendParameters parameters;
1639 parameters.codecs.push_back(DefaultCodec());
1640 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1641 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1642 parameters.max_bandwidth_bps = 128 * 1024;
1643 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001644}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001645
Niels Möller6557d0c2018-04-11 15:18:34 +02001646// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001647TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001648 EXPECT_TRUE(SetDefaultCodec());
1649 EXPECT_TRUE(SetSend(true));
1650 EXPECT_TRUE(SendFrame());
1651 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1652 uint32_t ssrc = 0;
1653 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1654 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
1655 EXPECT_EQ(kSsrc, ssrc);
1656 // Packets are being paced out, so these can mismatch between the first and
1657 // second call to NumRtpPackets until pending packets are paced out.
1658 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(ssrc), kTimeout);
1659 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(ssrc), kTimeout);
1660 EXPECT_EQ(1, NumSentSsrcs());
1661 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1662 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001663}
Niels Möller6557d0c2018-04-11 15:18:34 +02001664
1665// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001666TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001667 // Remove stream added in Setup.
1668 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1669 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001670 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001671 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1672 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001673 EXPECT_TRUE(SetSend(true));
1674 EXPECT_TRUE(WaitAndSendFrame(0));
1675 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1676 uint32_t ssrc = 0;
1677 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1678 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
1679 EXPECT_EQ(999u, ssrc);
1680 // Packets are being paced out, so these can mismatch between the first and
1681 // second call to NumRtpPackets until pending packets are paced out.
1682 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(ssrc), kTimeout);
1683 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(ssrc), kTimeout);
1684 EXPECT_EQ(1, NumSentSsrcs());
1685 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1686 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001687}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001688
Niels Möller6557d0c2018-04-11 15:18:34 +02001689// Test that we can set the default video renderer before and after
1690// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001691TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001692 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1693 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001694
1695 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1696 rtc::SetBE32(packet1.data() + 8, kSsrc);
1697 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1698 EXPECT_TRUE(SetDefaultCodec());
1699 EXPECT_TRUE(SetSend(true));
1700 EXPECT_EQ(0, renderer_.num_rendered_frames());
1701 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1702 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1703 EXPECT_TRUE(SendFrame());
1704 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001705}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001706
Niels Möller6557d0c2018-04-11 15:18:34 +02001707// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001708TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001709 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1710 EXPECT_TRUE(SetSend(true));
1711 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1712 EXPECT_TRUE(SendFrame());
1713 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1714 EXPECT_GT(NumRtpPackets(), 0);
1715 uint32_t ssrc = 0;
1716 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001717 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1718 GetRtpPacket(static_cast<int>(last_packet)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001719 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
1720 EXPECT_EQ(kSsrc, ssrc);
1721
1722 // Remove the send stream that was added during Setup.
1723 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1724 int rtp_packets = NumRtpPackets();
1725
Niels Möller6557d0c2018-04-11 15:18:34 +02001726 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001727 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1728 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001729 EXPECT_EQ(rtp_packets, NumRtpPackets());
1730 // Wait 30ms to guarantee the engine does not drop the frame.
1731 EXPECT_TRUE(WaitAndSendFrame(30));
1732 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1733
1734 last_packet = NumRtpPackets() - 1;
1735 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
1736 ParseRtpPacket(p.get(), NULL, NULL, NULL, NULL, &ssrc, NULL);
1737 EXPECT_EQ(789u, ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001738}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001739
Niels Möller6557d0c2018-04-11 15:18:34 +02001740// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001741TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001742 cricket::FakeVideoRenderer renderer1, renderer2;
1743 EXPECT_TRUE(SetDefaultCodec());
1744 cricket::VideoSendParameters parameters;
1745 parameters.codecs.push_back(DefaultCodec());
1746 parameters.conference_mode = true;
1747 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1748 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001749 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1750 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001751 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1752 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1753 EXPECT_EQ(0, renderer1.num_rendered_frames());
1754 EXPECT_EQ(0, renderer2.num_rendered_frames());
1755 std::vector<uint32_t> ssrcs;
1756 ssrcs.push_back(1);
1757 ssrcs.push_back(2);
1758 network_interface_.SetConferenceMode(true, ssrcs);
1759 EXPECT_TRUE(SendFrame());
1760 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1761 kTimeout);
1762 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1763 kTimeout);
1764
1765 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1766 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1767 EXPECT_EQ(kVideoWidth, renderer1.width());
1768 EXPECT_EQ(kVideoHeight, renderer1.height());
1769 EXPECT_EQ(kVideoWidth, renderer2.width());
1770 EXPECT_EQ(kVideoHeight, renderer2.height());
1771 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1772 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001773}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001774
Niels Möller6557d0c2018-04-11 15:18:34 +02001775// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001776TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001777 using cricket::VideoCodec;
1778 using cricket::VideoOptions;
1779 using cricket::VideoFormat;
1780 using cricket::FOURCC_I420;
1781
1782 VideoCodec codec = DefaultCodec();
1783 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1784 EXPECT_TRUE(SetOneCodec(codec));
1785 EXPECT_TRUE(SetSend(true));
1786 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1787 EXPECT_EQ(0, renderer_.num_rendered_frames());
1788 EXPECT_TRUE(SendFrame());
1789 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1790 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1791 CreateFakeVideoCapturer());
1792
1793 // TODO(nisse): This testcase fails if we don't configure
1794 // screencast. It's unclear why, I see nothing obvious in this
1795 // test which is related to screencast logic.
1796 VideoOptions video_options;
1797 video_options.is_screencast = true;
1798 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1799
1800 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1801 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1802 // All capturers start generating frames with the same timestamp. ViE does
1803 // not allow the same timestamp to be used. Capture one frame before
1804 // associating the capturer with the channel.
1805 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1806
1807 int captured_frames = 1;
1808 for (int iterations = 0; iterations < 2; ++iterations) {
1809 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1810 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1811 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1812 ++captured_frames;
1813 // Wait until frame of right size is captured.
1814 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001815 format.width == renderer_.width() &&
1816 format.height == renderer_.height() &&
1817 !renderer_.black_frame(),
1818 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001819 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1820 EXPECT_EQ(format.width, renderer_.width());
1821 EXPECT_EQ(format.height, renderer_.height());
1822 captured_frames = renderer_.num_rendered_frames() + 1;
1823 EXPECT_FALSE(renderer_.black_frame());
1824 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1825 // Make sure a black frame is generated within the specified timeout.
1826 // The black frame should be the resolution of the previous frame to
1827 // prevent expensive encoder reconfigurations.
1828 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001829 format.width == renderer_.width() &&
1830 format.height == renderer_.height() &&
1831 renderer_.black_frame(),
1832 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001833 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1834 EXPECT_EQ(format.width, renderer_.width());
1835 EXPECT_EQ(format.height, renderer_.height());
1836 EXPECT_TRUE(renderer_.black_frame());
1837
1838 // The black frame has the same timestamp as the next frame since it's
1839 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1840 // not render a frame with the same timestamp so capture another frame
1841 // with the frame capturer to increment the next frame's timestamp.
1842 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1843 }
srtee0c2eea2017-12-15 17:44:33 +01001844}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001845
Niels Möller6557d0c2018-04-11 15:18:34 +02001846// Tests that if SetVideoSend is called with a NULL capturer after the
1847// capturer was already removed, the application doesn't crash (and no black
1848// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001849TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001850 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1851 EXPECT_TRUE(SetSend(true));
1852 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1853 EXPECT_EQ(0, renderer_.num_rendered_frames());
1854 EXPECT_TRUE(SendFrame());
1855 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1856 // Wait for one frame so they don't get dropped because we send frames too
1857 // tightly.
1858 rtc::Thread::Current()->ProcessMessages(30);
1859 // Remove the capturer.
1860 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1861
1862 // No capturer was added, so this SetVideoSend shouldn't do anything.
1863 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1864 rtc::Thread::Current()->ProcessMessages(300);
1865 // Verify no more frames were sent.
1866 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001867}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001868
Niels Möller6557d0c2018-04-11 15:18:34 +02001869// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001870TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001871 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1872 // interval time to avoid that.
1873 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1874 // interval time to avoid that.
1875 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001876 EXPECT_TRUE(
1877 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001878 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1879 cricket::VideoFormat capture_format(
1880 kVideoWidth, kVideoHeight,
1881 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1882 // Set up additional stream 1.
1883 cricket::FakeVideoRenderer renderer1;
1884 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001885 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001886 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001887 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001888 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1889 CreateFakeVideoCapturer());
1890 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1891 // Set up additional stream 2.
1892 cricket::FakeVideoRenderer renderer2;
1893 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001894 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001895 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001896 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001897 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1898 CreateFakeVideoCapturer());
1899 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1900 // State for all the streams.
1901 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1902 // A limitation in the lmi implementation requires that SetVideoSend() is
1903 // called after SetOneCodec().
1904 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1905 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1906 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1907 EXPECT_TRUE(SetSend(true));
1908 // Test capturer associated with engine.
1909 const int kTestWidth = 160;
1910 const int kTestHeight = 120;
1911 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001912 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1913 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001914 // Capture a frame with additional capturer2, frames should be received
1915 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001916 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1917 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001918 // Successfully remove the capturer.
1919 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1920 // The capturers must be unregistered here as it runs out of it's scope
1921 // next.
1922 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1923 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001924}
Niels Möller6557d0c2018-04-11 15:18:34 +02001925
1926// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001927TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001928 // Remove the send stream that was added during Setup.
1929 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1930
1931 cricket::StreamParams empty;
1932 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001933 EXPECT_TRUE(
1934 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001935}
Niels Möller6557d0c2018-04-11 15:18:34 +02001936
1937// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001938TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001939 // Remove stream added in Setup. I.e. remove stream corresponding to default
1940 // channel.
1941 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001942 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001943 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1944 EXPECT_TRUE(channel_->AddSendStream(
1945 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1946 }
1947 // Delete one of the non default channel streams, let the destructor delete
1948 // the remaining ones.
1949 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1950 // Stream should already be deleted.
1951 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001952}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001953
eladalonf1841382017-06-12 01:16:46 -07001954TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001955 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001956}
1957
eladalonf1841382017-06-12 01:16:46 -07001958TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001959 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001960}
1961
eladalonf1841382017-06-12 01:16:46 -07001962TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001963 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001964}
1965
eladalonf1841382017-06-12 01:16:46 -07001966TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001967 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1968 // bitrates. This currently happens at <250k, and two streams sharing 300k
1969 // initially will use QVGA instead of VGA.
1970 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1971 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001972 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02001973 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02001974 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001975}
1976
eladalonf1841382017-06-12 01:16:46 -07001977class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001978 public:
eladalonf1841382017-06-12 01:16:46 -07001979 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
1980 explicit WebRtcVideoChannelTest(const char* field_trials)
1981 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00001982 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001983 encoder_factory_->AddSupportedVideoCodecType("VP8");
1984 encoder_factory_->AddSupportedVideoCodecType("VP9");
1985#if defined(WEBRTC_USE_H264)
1986 encoder_factory_->AddSupportedVideoCodecType("H264");
1987#endif
1988
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001989 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08001990 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
1991 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08001992 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001993 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001994 send_parameters_.codecs = engine_.codecs();
1995 recv_parameters_.codecs = engine_.codecs();
1996 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001997 }
1998
1999 protected:
2000 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002001 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002002 }
2003
2004 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002005 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002006 EXPECT_TRUE(channel_->AddSendStream(sp));
2007 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002008 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002009 EXPECT_EQ(num_streams + 1, streams.size());
2010 return streams[streams.size() - 1];
2011 }
2012
2013 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002014 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002015 }
2016
2017 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002018 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002019 }
2020
2021 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002022 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002023 EXPECT_TRUE(channel_->AddRecvStream(sp));
2024 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002025 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002026 EXPECT_EQ(num_streams + 1, streams.size());
2027 return streams[streams.size() - 1];
2028 }
2029
pbos@webrtc.org00873182014-11-25 14:03:34 +00002030 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2031 int expected_min_bitrate_bps,
2032 const char* start_bitrate_kbps,
2033 int expected_start_bitrate_bps,
2034 const char* max_bitrate_kbps,
2035 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002036 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2037 expected_start_bitrate_bps,
2038 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002039 auto& codecs = send_parameters_.codecs;
2040 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002041 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002042 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2043 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2044 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002045 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002046 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002047
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002048 void ExpectSetBitrateParameters(int min_bitrate_bps,
2049 int start_bitrate_bps,
2050 int max_bitrate_bps) {
2051 EXPECT_CALL(
2052 *fake_call_->GetMockTransportControllerSend(),
2053 SetSdpBitrateParameters(AllOf(
2054 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2055 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2056 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2057 }
2058
2059 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2060 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2061 SetSdpBitrateParameters(Field(
2062 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002063 }
2064
isheriff6f8d6862016-05-26 11:24:55 -07002065 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002066 // Enable extension.
2067 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002068 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002069 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002070 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002071 FakeVideoSendStream* send_stream =
2072 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2073
2074 // Verify the send extension id.
2075 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2076 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002077 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002078 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002079 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002080 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2081 // receivers.
2082 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2083 ->GetConfig()
2084 .rtp.extensions.empty());
2085
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002086 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002087 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002088 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2089 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002090 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2091
2092 // Verify that adding receive RTP header extensions adds them for existing
2093 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002094 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002095 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002096 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2097 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002098 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002099 }
2100
isheriff6f8d6862016-05-26 11:24:55 -07002101 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002102 // Enable extension.
2103 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002104 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002105 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002106 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002107
2108 FakeVideoReceiveStream* recv_stream =
2109 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2110
2111 // Verify the recv extension id.
2112 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2113 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002114 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002115 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002116 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002117
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002118 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2119 // senders.
2120 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2121 ->GetConfig()
2122 .rtp.extensions.empty());
2123
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002124 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002125 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002126 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2127 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002128 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2129
2130 // Verify that adding receive RTP header extensions adds them for existing
2131 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002132 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002133 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002134 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2135 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002136 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002137 }
2138
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002139 void TestExtensionFilter(const std::vector<std::string>& extensions,
2140 const std::string& expected_extension) {
2141 cricket::VideoSendParameters parameters = send_parameters_;
2142 int expected_id = -1;
2143 int id = 1;
2144 for (const std::string& extension : extensions) {
2145 if (extension == expected_extension)
2146 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002147 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002148 }
2149 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2150 FakeVideoSendStream* send_stream =
2151 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2152
2153 // Verify that only one of them has been set, and that it is the one with
2154 // highest priority (transport sequence number).
2155 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2156 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2157 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002158 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002159 }
2160
asapersson3c81a1a2017-06-14 05:52:21 -07002161 void TestDegradationPreference(bool resolution_scaling_enabled,
2162 bool fps_scaling_enabled);
2163
Erik Språngefbde372015-04-29 16:21:28 +02002164 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002165 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002166 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2167 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002168
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002169 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002170 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002171 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002172 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002173 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002174 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002175 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002176 // Options only take effect on the next frame.
2177 EXPECT_TRUE(capturer->CaptureFrame());
2178
Erik Språng143cec12015-04-28 10:01:41 +02002179 return fake_call_->GetVideoSendStreams().back();
2180 }
2181
Peter Boström2feafdb2015-09-09 14:32:14 +02002182 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2183 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002184 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002185 std::vector<uint32_t> ssrcs;
2186 std::vector<uint32_t> rtx_ssrcs;
2187 uint32_t num_streams = enabled ? 3 : 1;
2188 for (uint32_t i = 0; i < num_streams; ++i) {
2189 uint32_t ssrc = last_ssrc_ + i;
2190 ssrcs.push_back(ssrc);
2191 if (with_rtx) {
2192 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2193 }
Erik Språng143cec12015-04-28 10:01:41 +02002194 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002195 if (with_rtx) {
2196 return AddSendStream(
2197 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2198 }
2199 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002200 }
2201
perkjfa10b552016-10-02 23:45:26 -07002202 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002203 std::vector<FakeVideoSendStream*> streams =
2204 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002205 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002206 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002207 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002208 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002209 }
2210
perkjfa10b552016-10-02 23:45:26 -07002211 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002212 int stream_max,
2213 int expected_encoder_bitrate) {
2214 VideoSendParameters limited_send_params = send_parameters_;
2215 limited_send_params.max_bandwidth_bps = global_max;
2216 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002217 webrtc::RtpParameters parameters =
2218 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002219 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002220 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002221 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002222 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002223 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002224 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002225 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002226 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002227 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002228 }
2229
Åsa Persson55659812018-06-18 17:51:32 +02002230 // Values from kSimulcastConfigs in simulcast.cc.
2231 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2232 std::vector<webrtc::VideoStream> layers(3);
2233 layers[0].min_bitrate_bps = 30000;
2234 layers[0].target_bitrate_bps = 150000;
2235 layers[0].max_bitrate_bps = 200000;
2236 layers[1].min_bitrate_bps = 150000;
2237 layers[1].target_bitrate_bps = 500000;
2238 layers[1].max_bitrate_bps = 700000;
2239 layers[2].min_bitrate_bps = 600000;
2240 layers[2].target_bitrate_bps = 2500000;
2241 layers[2].max_bitrate_bps = 2500000;
2242 return layers;
2243 }
2244
kwiberg686a8ef2016-02-26 03:00:35 -08002245 std::unique_ptr<FakeCall> fake_call_;
2246 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002247 cricket::VideoSendParameters send_parameters_;
2248 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002249 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002250};
2251
eladalonf1841382017-06-12 01:16:46 -07002252TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002253 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002254 const std::string kSyncLabel = "AvSyncLabel";
2255
2256 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002257 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002258 EXPECT_TRUE(channel_->AddRecvStream(sp));
2259
Mirko Bonadeif859e552018-05-30 15:31:29 +02002260 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002261 EXPECT_EQ(kSyncLabel,
2262 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2263 << "SyncGroup should be set based on sync_label";
2264}
2265
eladalonf1841382017-06-12 01:16:46 -07002266TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002267 cricket::VideoSendParameters parameters;
2268 parameters.codecs = engine_.codecs();
2269 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002270 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002271 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002272 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002273
2274 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002275 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2276 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002277 FakeVideoSendStream* send_stream = AddSendStream(
2278 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2279
2280 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2281 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2282 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2283
2284 // Receiver side.
2285 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2286 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002287 EXPECT_FALSE(
2288 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002289 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002290 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002291 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002292 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002293 << "RTX should be mapped for the RED payload type";
2294
brandtr14742122017-01-27 04:53:07 -08002295 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002296}
2297
eladalonf1841382017-06-12 01:16:46 -07002298TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002299 // Setup one channel with an associated RTX stream.
2300 cricket::StreamParams params =
2301 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2302 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2303 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002304 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002305
2306 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2307 << "RTX should be mapped for all decoders/payload types.";
2308 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002309 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002310 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002311}
2312
eladalonf1841382017-06-12 01:16:46 -07002313TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002314 // Setup one channel without an associated RTX stream.
2315 cricket::StreamParams params =
2316 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2317 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002318 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002319}
2320
eladalonf1841382017-06-12 01:16:46 -07002321TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002322 FakeVideoSendStream* send_stream =
2323 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2324 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2325
2326 FakeVideoReceiveStream* recv_stream =
2327 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2328 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002329}
2330
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002331// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002332TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002333 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002334}
isheriff6f8d6862016-05-26 11:24:55 -07002335
eladalonf1841382017-06-12 01:16:46 -07002336TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002337 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002338}
2339
2340// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002341TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002342 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002343}
isheriff6f8d6862016-05-26 11:24:55 -07002344
eladalonf1841382017-06-12 01:16:46 -07002345TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002346 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002347}
2348
eladalonf1841382017-06-12 01:16:46 -07002349TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002350 // Enable three redundant extensions.
2351 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002352 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2353 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2354 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2355 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002356}
2357
eladalonf1841382017-06-12 01:16:46 -07002358TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002359 // Enable two redundant extensions.
2360 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002361 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2362 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2363 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002364}
2365
stefanc1aeaf02015-10-15 07:26:07 -07002366// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002367TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002368 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002369}
eladalonf1841382017-06-12 01:16:46 -07002370TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002371 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002372}
2373
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002374// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002375TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002376 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002377}
eladalonf1841382017-06-12 01:16:46 -07002378TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002379 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002380}
2381
eladalonf1841382017-06-12 01:16:46 -07002382TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002383 const int kAbsSendTimeId = 1;
2384 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002385 send_parameters_.extensions.push_back(
2386 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2387 send_parameters_.extensions.push_back(
2388 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002389
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002390 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002391 FakeVideoSendStream* send_stream =
2392 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2393
2394 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002395 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002396
2397 // Setting the same extensions (even if in different order) shouldn't
2398 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002399 std::reverse(send_parameters_.extensions.begin(),
2400 send_parameters_.extensions.end());
2401 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002402
2403 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2404
2405 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002406 send_parameters_.extensions.resize(1);
2407 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002408
2409 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2410}
2411
eladalonf1841382017-06-12 01:16:46 -07002412TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002413 const int kTOffsetId = 1;
2414 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002415 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002416 recv_parameters_.extensions.push_back(
2417 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2418 recv_parameters_.extensions.push_back(
2419 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2420 recv_parameters_.extensions.push_back(
2421 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002422
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002423 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002424 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002425 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2426
2427 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002428 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002429
2430 // Setting the same extensions (even if in different order) shouldn't
2431 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002432 std::reverse(recv_parameters_.extensions.begin(),
2433 recv_parameters_.extensions.end());
2434 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002435
2436 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2437
2438 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002439 recv_parameters_.extensions.resize(1);
2440 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002441
2442 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2443}
2444
eladalonf1841382017-06-12 01:16:46 -07002445TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002446 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002447 const int kUnsupportedId = 1;
2448 const int kTOffsetId = 2;
2449
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002450 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002451 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002452 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002453 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002454 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002455 FakeVideoSendStream* send_stream =
2456 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2457
2458 // Only timestamp offset extension is set to send stream,
2459 // unsupported rtp extension is ignored.
2460 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002461 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2462 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002463}
2464
eladalonf1841382017-06-12 01:16:46 -07002465TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002466 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002467 const int kUnsupportedId = 1;
2468 const int kTOffsetId = 2;
2469
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002470 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002471 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002472 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002473 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002474 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002475 FakeVideoReceiveStream* recv_stream =
2476 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2477
2478 // Only timestamp offset extension is set to receive stream,
2479 // unsupported rtp extension is ignored.
2480 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002481 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2482 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002483}
2484
eladalonf1841382017-06-12 01:16:46 -07002485TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002486 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002487 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002488 send_parameters_.extensions.push_back(
2489 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002490 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002491 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2492 }
2493}
2494
eladalonf1841382017-06-12 01:16:46 -07002495TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002496 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002497 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002498 recv_parameters_.extensions.push_back(
2499 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002500 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002501 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2502 }
2503}
2504
eladalonf1841382017-06-12 01:16:46 -07002505TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002506 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002507 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002508 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002509 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002510 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002511 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002512
2513 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002514 send_parameters_.extensions.clear();
2515 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002516 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002517 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2518 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002519}
2520
eladalonf1841382017-06-12 01:16:46 -07002521TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002522 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002523 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002524 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002525 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002526 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002527 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002528
2529 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002530 recv_parameters_.extensions.clear();
2531 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002532 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002533 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2534 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002535}
2536
eladalonf1841382017-06-12 01:16:46 -07002537TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002538 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002539 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002540}
2541
eladalonf1841382017-06-12 01:16:46 -07002542TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002543 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002544 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002545}
2546
eladalonf1841382017-06-12 01:16:46 -07002547TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002548 FakeVideoReceiveStream* stream = AddRecvStream();
2549 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002550}
2551
eladalonf1841382017-06-12 01:16:46 -07002552TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002553 FakeVideoReceiveStream* stream = AddRecvStream();
2554 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2555}
2556
eladalonf1841382017-06-12 01:16:46 -07002557TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002558 FakeVideoReceiveStream* stream = AddRecvStream();
2559 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2560
Peter Boström126c03e2015-05-11 12:48:12 +02002561 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002562 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002563 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002564 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2565 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002566 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002567 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2568
2569 // Verify that REMB is turned on when setting default codecs since the
2570 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002571 parameters.codecs = engine_.codecs();
2572 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002573 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002574 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002575}
2576
eladalonf1841382017-06-12 01:16:46 -07002577TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002578 FakeVideoReceiveStream* stream = AddRecvStream();
2579 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2580
2581 // Verify that transport cc feedback is turned off when send(!) codecs without
2582 // transport cc feedback are set.
2583 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002584 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002585 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2586 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2587 stream = fake_call_->GetVideoReceiveStreams()[0];
2588 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2589
2590 // Verify that transport cc feedback is turned on when setting default codecs
2591 // since the default codecs have transport cc feedback enabled.
2592 parameters.codecs = engine_.codecs();
2593 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2594 stream = fake_call_->GetVideoReceiveStreams()[0];
2595 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2596}
2597
eladalonf1841382017-06-12 01:16:46 -07002598TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002599 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002600 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2601
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002602 cricket::VideoSendParameters parameters;
2603 parameters.codecs = engine_.codecs();
2604 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002605 EXPECT_TRUE(channel_->SetSend(true));
2606
2607 // Send side.
2608 FakeVideoSendStream* send_stream =
2609 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2610 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2611
2612 // Receiver side.
2613 FakeVideoReceiveStream* recv_stream =
2614 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2615 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2616
2617 // Nack history size should match between sender and receiver.
2618 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2619 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002620}
2621
eladalonf1841382017-06-12 01:16:46 -07002622TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002623 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002624 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002625
2626 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2627 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2628
2629 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002630 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002631 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002632 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2633 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002634 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2635 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2636 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002637 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2638
Peter Boström67c9df72015-05-11 14:34:58 +02002639 // Verify that NACK is turned on when setting default codecs since the
2640 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002641 parameters.codecs = engine_.codecs();
2642 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002643 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2644 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2645 send_stream = fake_call_->GetVideoSendStreams()[0];
2646 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002647}
2648
Peter Boströme7ba0862016-03-12 00:02:28 +01002649// This test verifies that new frame sizes reconfigures encoders even though not
2650// (yet) sending. The purpose of this is to permit encoding as quickly as
2651// possible once we start sending. Likely the frames being input are from the
2652// same source that will be sent later, which just means that we're ready
2653// earlier.
eladalonf1841382017-06-12 01:16:46 -07002654TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002655 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002656 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002657 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2658 channel_->SetSend(false);
2659
2660 FakeVideoSendStream* stream = AddSendStream();
2661
perkjfa10b552016-10-02 23:45:26 -07002662 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002663 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002664 EXPECT_EQ(0u, streams[0].width);
2665 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002666
Tommi85959932018-02-07 19:26:06 +01002667 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002668 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002669 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2670 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002671 EXPECT_TRUE(capturer.CaptureFrame());
2672
2673 // Frame entered, should be reconfigured to new dimensions.
2674 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002675 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2676 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2677 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002678
Niels Möllerff40b142018-04-09 08:49:14 +02002679 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002680}
2681
eladalonf1841382017-06-12 01:16:46 -07002682TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002683 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002684 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002685 cricket::VideoSendParameters parameters;
2686 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002687 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002688 AddSendStream();
2689
Tommi85959932018-02-07 19:26:06 +01002690 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002691 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002692 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002693 EXPECT_TRUE(
2694 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002695 cricket::VideoFormat capture_format_hd =
2696 capturer.GetSupportedFormats()->front();
2697 EXPECT_EQ(1280, capture_format_hd.width);
2698 EXPECT_EQ(720, capture_format_hd.height);
2699 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2700
2701 EXPECT_TRUE(channel_->SetSend(true));
2702
2703 EXPECT_TRUE(capturer.CaptureFrame());
2704 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2705 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2706
2707 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2708
2709 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002710 webrtc::VideoEncoderConfig encoder_config =
2711 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002712 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002713 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002714 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002715 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2716 streams.front().width);
2717 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2718 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002719 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2720 << "Non-screenshare shouldn't use min-transmit bitrate.";
2721
Niels Möllerff40b142018-04-09 08:49:14 +02002722 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002723 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002724 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002725 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002726 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002727 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002728 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002729 // Send stream recreated after option change.
2730 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2731 send_stream = fake_call_->GetVideoSendStreams().front();
2732 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002733
2734 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002735 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002736 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002737 encoder_config.content_type);
2738 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2739 encoder_config.min_transmit_bitrate_bps);
2740
perkjfa10b552016-10-02 23:45:26 -07002741 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002742 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2743 streams.front().width);
2744 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2745 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002746 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002747 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002748}
2749
eladalonf1841382017-06-12 01:16:46 -07002750TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002751 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002752 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002753 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002754 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002755
2756 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002757 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002758 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002759 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002760 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002761 cricket::VideoFormat capture_format_hd =
2762 capturer.GetSupportedFormats()->front();
2763 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2764
2765 EXPECT_TRUE(channel_->SetSend(true));
2766
2767 EXPECT_TRUE(capturer.CaptureFrame());
2768 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2769 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2770
perkj26091b12016-09-01 01:17:40 -07002771 webrtc::VideoEncoderConfig encoder_config =
2772 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002773
2774 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002775 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002776 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002777 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002778
2779 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2780 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002781 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002782 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002783 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002784
Niels Möllerff40b142018-04-09 08:49:14 +02002785 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002786}
2787
eladalonf1841382017-06-12 01:16:46 -07002788TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002789 FakeVideoSendStream* stream = AddSendStream();
2790 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2791}
2792
eladalonf1841382017-06-12 01:16:46 -07002793TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002794 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002795 media_config.video.suspend_below_min_bitrate = true;
2796
2797 channel_.reset(
2798 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002799 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002800
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002801 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002802
2803 FakeVideoSendStream* stream = AddSendStream();
2804 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2805
nisse0db023a2016-03-01 04:29:59 -08002806 media_config.video.suspend_below_min_bitrate = false;
2807 channel_.reset(
2808 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002809 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002810
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002811 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002812
nisse0db023a2016-03-01 04:29:59 -08002813 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002814 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2815}
2816
eladalonf1841382017-06-12 01:16:46 -07002817TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002818 FakeVideoSendStream* stream = AddSendStream();
2819 webrtc::VideoCodecVP8 vp8_settings;
2820 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2821 EXPECT_TRUE(vp8_settings.denoisingOn);
2822}
2823
eladalonf1841382017-06-12 01:16:46 -07002824TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002825 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002826 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002827 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002828
Peter Boström2feafdb2015-09-09 14:32:14 +02002829 // Single-stream settings should apply with RTX as well (verifies that we
2830 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2831 // both RTX and regular SSRCs).
2832 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002833
Tommi85959932018-02-07 19:26:06 +01002834 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002835 EXPECT_EQ(cricket::CS_RUNNING,
2836 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002837 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002838 channel_->SetSend(true);
2839
2840 EXPECT_TRUE(capturer.CaptureFrame());
2841
pbos4cba4eb2015-10-26 11:18:18 -07002842 webrtc::VideoCodecVP8 vp8_settings;
2843 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2844 EXPECT_TRUE(vp8_settings.denoisingOn)
2845 << "VP8 denoising should be on by default.";
2846
nisse05103312016-03-16 02:22:50 -07002847 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002848
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002849 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2850 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002851 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2852 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002853
nisse05103312016-03-16 02:22:50 -07002854 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002855
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002856 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2857 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002858 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2859 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2860
Niels Möllerff40b142018-04-09 08:49:14 +02002861 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002862 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002863 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002864 channel_->SetSend(true);
2865 EXPECT_TRUE(capturer.CaptureFrame());
2866
Mirko Bonadeif859e552018-05-30 15:31:29 +02002867 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002868 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2869 // Autmatic resize off when using simulcast.
2870 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2871 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2872
2873 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002874 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002875 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002876 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002877
nisse05103312016-03-16 02:22:50 -07002878 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002879
Mirko Bonadeif859e552018-05-30 15:31:29 +02002880 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002881 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2882 EXPECT_FALSE(vp8_settings.denoisingOn);
2883 // Resizing and frame dropping always off for screen sharing.
2884 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2885 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2886
nisse05103312016-03-16 02:22:50 -07002887 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002888
2889 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2890 EXPECT_FALSE(vp8_settings.denoisingOn);
2891 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2892 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2893
Niels Möllerff40b142018-04-09 08:49:14 +02002894 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002895}
2896
deadbeef119760a2016-04-04 11:43:27 -07002897// Test that setting the same options doesn't result in the encoder being
2898// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002899TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002900 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002901 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002902
perkjfa10b552016-10-02 23:45:26 -07002903 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002904 EXPECT_EQ(cricket::CS_RUNNING,
2905 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002906 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002907 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002908 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2909 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2910
Niels Möllerff40b142018-04-09 08:49:14 +02002911 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2912 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002913 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002914 // Expect 1 reconfigurations at this point from the initial configuration.
2915 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002916
2917 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002918 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002919 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2920
2921 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002922 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002923 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002924 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2925
Niels Möllerff40b142018-04-09 08:49:14 +02002926 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002927}
2928
eladalonf1841382017-06-12 01:16:46 -07002929class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002930 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002931 Vp9SettingsTest() : Vp9SettingsTest("") {}
2932 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002933 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002934 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002935 }
2936 virtual ~Vp9SettingsTest() {}
2937
2938 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002939 void TearDown() override {
2940 // Remove references to encoder_factory_ since this will be destroyed
2941 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002942 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002943 }
Erik Språng143cec12015-04-28 10:01:41 +02002944};
2945
2946TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002947 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002948 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002949 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002950
Peter Boström2feafdb2015-09-09 14:32:14 +02002951 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002952
Tommi85959932018-02-07 19:26:06 +01002953 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002954 EXPECT_EQ(cricket::CS_RUNNING,
2955 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002956 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002957 channel_->SetSend(true);
2958
2959 EXPECT_TRUE(capturer.CaptureFrame());
2960
pbos4cba4eb2015-10-26 11:18:18 -07002961 webrtc::VideoCodecVP9 vp9_settings;
2962 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002963 EXPECT_TRUE(vp9_settings.denoisingOn)
2964 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07002965
nisse05103312016-03-16 02:22:50 -07002966 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002967
Erik Språng143cec12015-04-28 10:01:41 +02002968 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2969 EXPECT_FALSE(vp9_settings.denoisingOn);
2970 // Frame dropping always on for real time video.
2971 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2972
nisse05103312016-03-16 02:22:50 -07002973 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002974
2975 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2976 EXPECT_TRUE(vp9_settings.denoisingOn);
2977 EXPECT_TRUE(vp9_settings.frameDroppingOn);
2978
2979 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07002980 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002981 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002982 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002983
nisse05103312016-03-16 02:22:50 -07002984 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002985
2986 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2987 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02002988 // Frame dropping always on for screen sharing.
2989 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002990
nisse05103312016-03-16 02:22:50 -07002991 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002992
2993 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
2994 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02002995 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002996
Niels Möllerff40b142018-04-09 08:49:14 +02002997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002998}
2999
Sergey Silkinf18072e2018-03-14 10:35:35 +01003000TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3001 cricket::VideoSendParameters parameters;
3002 parameters.codecs.push_back(GetEngineCodec("VP9"));
3003 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3004
3005 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3006
3007 FakeVideoSendStream* stream =
3008 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3009
3010 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3011 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3012
3013 FakeVideoCapturerWithTaskQueue capturer;
3014 EXPECT_EQ(cricket::CS_RUNNING,
3015 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003016 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003017 channel_->SetSend(true);
3018
3019 EXPECT_TRUE(capturer.CaptureFrame());
3020
3021 webrtc::VideoCodecVP9 vp9_settings;
3022 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3023
3024 const size_t kNumSpatialLayers = ssrcs.size();
3025 const size_t kNumTemporalLayers = 3;
3026 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3027 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3028
Niels Möllerff40b142018-04-09 08:49:14 +02003029 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003030}
3031
asaperssonc5dabdd2016-03-21 04:15:50 -07003032class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3033 public:
brandtr468da7c2016-11-22 02:16:47 -08003034 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003035 : Vp9SettingsTest(field_trials) {}
3036
3037 protected:
3038 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3039 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003040 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003041 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3042
3043 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3044
Tommi85959932018-02-07 19:26:06 +01003045 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003046 EXPECT_EQ(cricket::CS_RUNNING,
3047 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003048 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003049 channel_->SetSend(true);
3050
3051 EXPECT_TRUE(capturer.CaptureFrame());
3052
3053 webrtc::VideoCodecVP9 vp9_settings;
3054 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3055 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3056 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3057
Niels Möllerff40b142018-04-09 08:49:14 +02003058 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003059 }
3060};
3061
3062class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3063 public:
3064 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3065};
3066
3067TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3068 const int kNumSpatialLayers = 1;
3069 const int kNumTemporalLayers = 1;
3070 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3071}
3072
3073class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3074 public:
3075 Vp9SettingsTestWithInvalidFlag()
3076 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3077};
3078
3079TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3080 const int kNumSpatialLayers = 1;
3081 const int kNumTemporalLayers = 1;
3082 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3083}
3084
3085class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3086 public:
3087 Vp9SettingsTestWith2SL3TLFlag()
3088 : Vp9SettingsTestWithFieldTrial(
3089 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3090};
3091
3092TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3093 const int kNumSpatialLayers = 2;
3094 const int kNumTemporalLayers = 3;
3095 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3096}
3097
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003098TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3099 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3100 ASSERT_EQ(1u, streams.size());
3101 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3102}
3103
3104TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3105 webrtc::test::ScopedFieldTrials override_field_trials_(
3106 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3107 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3108 ASSERT_EQ(1u, streams.size());
3109 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3110}
3111
asapersson3c81a1a2017-06-14 05:52:21 -07003112TEST_F(WebRtcVideoChannelTest,
3113 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3114 webrtc::test::ScopedFieldTrials override_field_trials_(
3115 "WebRTC-Video-BalancedDegradation/Disabled/");
3116 const bool kResolutionScalingEnabled = true;
3117 const bool kFpsScalingEnabled = false;
3118 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3119}
3120
3121TEST_F(WebRtcVideoChannelTest,
3122 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3123 webrtc::test::ScopedFieldTrials override_field_trials_(
3124 "WebRTC-Video-BalancedDegradation/Enabled/");
3125 const bool kResolutionScalingEnabled = true;
3126 const bool kFpsScalingEnabled = true;
3127 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3128}
3129
eladalonf1841382017-06-12 01:16:46 -07003130TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003131 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003132}
3133
eladalonf1841382017-06-12 01:16:46 -07003134TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003135 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003136}
3137
eladalonf1841382017-06-12 01:16:46 -07003138TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003139 TestCpuAdaptation(true, true);
3140}
3141
eladalonf1841382017-06-12 01:16:46 -07003142TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003143 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003144 cricket::VideoSendParameters parameters;
3145 parameters.codecs.push_back(codec);
3146
kthelgason2bc68642017-02-07 07:02:22 -08003147 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08003148 channel_.reset(
3149 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003150 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003151 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3152
3153 AddSendStream();
3154
Tommi85959932018-02-07 19:26:06 +01003155 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003156 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003157 ASSERT_EQ(cricket::CS_RUNNING,
3158 capturer.Start(capturer.GetSupportedFormats()->front()));
3159 ASSERT_TRUE(channel_->SetSend(true));
3160
3161 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3162 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003163
Niels Möllera6cc0f92018-02-12 17:14:55 +01003164 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003165 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3166 EXPECT_EQ(1280, send_stream->GetLastWidth());
3167 EXPECT_EQ(720, send_stream->GetLastHeight());
3168
3169 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003170 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003171 wants.max_pixel_count =
3172 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003173 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003174 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003175 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3176 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3177 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3178
3179 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003180 wants.max_pixel_count =
3181 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003182 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003183 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003184 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3185 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3186 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3187
3188 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003189 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003190 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003191 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3192 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3193
3194 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003195 int current_pixel_count =
3196 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3197 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3198 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003199 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003200 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003201 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003202 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003203 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003204 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003205 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3206 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3207
sprang84a37592017-02-10 07:04:27 -08003208 // Trigger underuse again, should go back up to full resolution.
3209 current_pixel_count =
3210 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003211 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003212 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003213 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003214 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003215 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003216 EXPECT_EQ(1284, send_stream->GetLastWidth());
3217 EXPECT_EQ(724, send_stream->GetLastHeight());
3218
Niels Möllerff40b142018-04-09 08:49:14 +02003219 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003220}
3221
eladalonf1841382017-06-12 01:16:46 -07003222TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003223 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003224 cricket::VideoSendParameters parameters;
3225 parameters.codecs.push_back(codec);
3226
kthelgason2bc68642017-02-07 07:02:22 -08003227 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003228 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02003229 channel_.reset(
3230 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003231 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003232 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3233
3234 AddSendStream();
3235
Tommi85959932018-02-07 19:26:06 +01003236 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003237 ASSERT_EQ(cricket::CS_RUNNING,
3238 capturer.Start(capturer.GetSupportedFormats()->front()));
3239 ASSERT_TRUE(channel_->SetSend(true));
3240 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003241 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003242 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003243
3244 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3245 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003246
Niels Möllera6cc0f92018-02-12 17:14:55 +01003247 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003248 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3249 EXPECT_EQ(1280, send_stream->GetLastWidth());
3250 EXPECT_EQ(720, send_stream->GetLastHeight());
3251
3252 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003253 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003254 wants.max_pixel_count =
3255 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003256 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003257 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003258 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3259 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3260 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3261
3262 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003263 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003264 ASSERT_EQ(cricket::CS_RUNNING,
3265 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003266 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003267 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003268 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003269 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003270 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3271 send_stream = fake_call_->GetVideoSendStreams().front();
3272 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003273 EXPECT_EQ(1284, send_stream->GetLastWidth());
3274 EXPECT_EQ(724, send_stream->GetLastHeight());
3275
3276 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003277 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003278 send_stream = fake_call_->GetVideoSendStreams().front();
3279 // We have a new fake send stream, so it doesn't remember the old sink wants.
3280 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003281 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003282 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003283 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003284 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3285 send_stream = fake_call_->GetVideoSendStreams().front();
3286 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003287 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3288 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3289
Niels Möllerff40b142018-04-09 08:49:14 +02003290 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003291}
3292
asapersson3c81a1a2017-06-14 05:52:21 -07003293// TODO(asapersson): Remove this test when the balanced field trial is removed.
3294void WebRtcVideoChannelTest::TestDegradationPreference(
3295 bool resolution_scaling_enabled,
3296 bool fps_scaling_enabled) {
3297 cricket::VideoCodec codec = GetEngineCodec("VP8");
3298 cricket::VideoSendParameters parameters;
3299 parameters.codecs.push_back(codec);
3300
3301 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003302 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07003303 channel_.reset(
3304 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
3305 channel_->OnReadyToSend(true);
3306
3307 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3308
3309 AddSendStream();
3310
Tommi85959932018-02-07 19:26:06 +01003311 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003312 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003313 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003314 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3315 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3316
3317 EXPECT_TRUE(channel_->SetSend(true));
3318
3319 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3320 EXPECT_EQ(resolution_scaling_enabled,
3321 send_stream->resolution_scaling_enabled());
3322 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3323
Niels Möllerff40b142018-04-09 08:49:14 +02003324 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003325}
3326
eladalonf1841382017-06-12 01:16:46 -07003327void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3328 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003329 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003330 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003331 cricket::VideoSendParameters parameters;
3332 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003333
kthelgason2bc68642017-02-07 07:02:22 -08003334 MediaConfig media_config = GetMediaConfig();
3335 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003336 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003337 }
nisse51542be2016-02-12 02:27:06 -08003338 channel_.reset(
3339 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003340 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003341
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003342 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003343
3344 AddSendStream();
3345
Tommi85959932018-02-07 19:26:06 +01003346 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003347 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003348 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003349 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003350 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003351 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003352 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003353
3354 EXPECT_TRUE(channel_->SetSend(true));
3355
solenberge5269742015-09-08 05:13:22 -07003356 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003357
sprangc5d62e22017-04-02 23:53:04 -07003358 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003359 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003360 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3361 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003362
3363 EXPECT_TRUE(capturer.CaptureFrame());
3364 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3365
perkj26752742016-10-24 01:21:16 -07003366 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3367 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003368
Niels Möllerff40b142018-04-09 08:49:14 +02003369 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003370 return;
3371 }
3372
sprangc5d62e22017-04-02 23:53:04 -07003373 if (is_screenshare) {
3374 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3375 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3376 } else {
3377 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3378 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3379 }
3380
perkj803d97f2016-11-01 11:45:46 -07003381 // Trigger overuse.
3382 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3383
3384 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003385 if (is_screenshare) {
3386 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3387 } else {
3388 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3389 }
perkj803d97f2016-11-01 11:45:46 -07003390 send_stream->InjectVideoSinkWants(wants);
3391
sprangc5d62e22017-04-02 23:53:04 -07003392 for (int i = 0; i < kDefaultFps; ++i)
3393 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003394
sprangc5d62e22017-04-02 23:53:04 -07003395 if (is_screenshare) {
3396 // Drops every third frame.
3397 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3398 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3399 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3400 } else {
3401 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3402 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3403 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3404 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003405
3406 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003407 int last_pixel_count =
3408 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003409 if (is_screenshare) {
3410 wants.max_framerate_fps = kDefaultFps;
3411 } else {
3412 wants.max_pixel_count = last_pixel_count * 4;
3413 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3414 }
perkj803d97f2016-11-01 11:45:46 -07003415 send_stream->InjectVideoSinkWants(wants);
3416
sprangc5d62e22017-04-02 23:53:04 -07003417 for (int i = 0; i < kDefaultFps; ++i)
3418 EXPECT_TRUE(capturer.CaptureFrame());
3419
3420 if (is_screenshare) {
3421 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3422 send_stream->GetNumberOfSwappedFrames());
3423 } else {
3424 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3425 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003426
perkj26752742016-10-24 01:21:16 -07003427 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3428 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003429
Niels Möllerff40b142018-04-09 08:49:14 +02003430 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003431}
3432
eladalonf1841382017-06-12 01:16:46 -07003433TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003434 // Start at last timestamp to verify that wraparounds are estimated correctly.
3435 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3436 static const int64_t kInitialNtpTimeMs = 1247891230;
3437 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003438 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003439
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003440 FakeVideoReceiveStream* stream = AddRecvStream();
3441 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003442 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003443
nisse64ec8f82016-09-27 00:17:25 -07003444 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3445 kInitialTimestamp, 0,
3446 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003447 // Initial NTP time is not available on the first frame, but should still be
3448 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003449 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003450
3451 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003452
3453 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3454 // triggers a constant-overflow warning, hence we're calculating it explicitly
3455 // here.
3456 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3457 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003458 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003459
3460 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003461
3462 // Verify that NTP time has been correctly deduced.
3463 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003464 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003465 ASSERT_EQ(1u, info.receivers.size());
3466 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003467}
3468
eladalonf1841382017-06-12 01:16:46 -07003469TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003470 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003471 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003472
3473 VideoCodec codec;
3474 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003475 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003476
3477 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003478 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3479 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003480 FakeVideoSendStream* stream = AddSendStream(
3481 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003482 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003483
3484 // Make sure NACK and FEC are enabled on the correct payload types.
3485 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003486 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3487 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003488
3489 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3490 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003491 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003492 // TODO(juberti): Check RTCP, PLI, TMMBR.
3493}
3494
brandtr31bd2242017-05-19 05:47:46 -07003495// The following four tests ensures that FlexFEC is not activated by default
3496// when the field trials are not enabled.
3497// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3498// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003499TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003500 FakeVideoSendStream* stream = AddSendStream();
3501 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3502
brandtr3d200bd2017-01-16 06:59:19 -08003503 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003504 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3505 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003506}
3507
eladalonf1841382017-06-12 01:16:46 -07003508TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003509 FakeVideoSendStream* stream = AddSendStream(
3510 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3511 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3512
brandtr3d200bd2017-01-16 06:59:19 -08003513 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003514 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3515 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3516}
3517
Yves Gerey665174f2018-06-19 15:03:05 +02003518TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003519 AddRecvStream();
3520
3521 const std::vector<FakeFlexfecReceiveStream*>& streams =
3522 fake_call_->GetFlexfecReceiveStreams();
3523 EXPECT_TRUE(streams.empty());
3524}
3525
eladalonf1841382017-06-12 01:16:46 -07003526TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003527 AddRecvStream(
3528 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3529
3530 const std::vector<FakeFlexfecReceiveStream*>& streams =
3531 fake_call_->GetFlexfecReceiveStreams();
3532 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003533}
3534
3535// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3536// tests that use this test fixture into the corresponding "non-field trial"
3537// tests.
eladalonf1841382017-06-12 01:16:46 -07003538class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003539 public:
eladalonf1841382017-06-12 01:16:46 -07003540 WebRtcVideoChannelFlexfecRecvTest()
3541 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003542};
3543
eladalonf1841382017-06-12 01:16:46 -07003544TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003545 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3546 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3547 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3548}
3549
eladalonf1841382017-06-12 01:16:46 -07003550TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003551 AddRecvStream();
3552
3553 const std::vector<FakeFlexfecReceiveStream*>& streams =
3554 fake_call_->GetFlexfecReceiveStreams();
3555 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003556
3557 const std::vector<FakeVideoReceiveStream*>& video_streams =
3558 fake_call_->GetVideoReceiveStreams();
3559 ASSERT_EQ(1U, video_streams.size());
3560 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3561 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3562 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003563}
3564
eladalonf1841382017-06-12 01:16:46 -07003565TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003566 AddRecvStream(
3567 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3568
3569 const std::vector<FakeFlexfecReceiveStream*>& streams =
3570 fake_call_->GetFlexfecReceiveStreams();
3571 ASSERT_EQ(1U, streams.size());
3572 const FakeFlexfecReceiveStream* stream = streams.front();
3573 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3574 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3575 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3576 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3577 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003578
3579 const std::vector<FakeVideoReceiveStream*>& video_streams =
3580 fake_call_->GetVideoReceiveStreams();
3581 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003582 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3583 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003584 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003585 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003586 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003587}
3588
eladalonf1841382017-06-12 01:16:46 -07003589TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003590 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3591 cricket::VideoRecvParameters recv_parameters;
3592 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3593 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3594
3595 AddRecvStream(
3596 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3597 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003598 const std::vector<FakeVideoReceiveStream*>& video_streams =
3599 fake_call_->GetVideoReceiveStreams();
3600 ASSERT_EQ(1U, video_streams.size());
3601 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3602 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3603 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003604
3605 // Enable FlexFEC.
3606 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3607 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3608 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3609 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3610 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3611 << "Enabling FlexFEC should not create VideoReceiveStream.";
3612 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3613 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003614 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3615 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003616}
3617
eladalonf1841382017-06-12 01:16:46 -07003618TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003619 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3620 cricket::VideoRecvParameters recv_parameters;
3621 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3622 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3623 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3624
3625 AddRecvStream(
3626 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3627 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003628 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003629 const std::vector<FakeVideoReceiveStream*>& video_streams =
3630 fake_call_->GetVideoReceiveStreams();
3631 ASSERT_EQ(1U, video_streams.size());
3632 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3633 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3634 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003635
3636 // Disable FlexFEC.
3637 recv_parameters.codecs.clear();
3638 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3639 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3640 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3641 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3642 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3643 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3644 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3645 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003646 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3647 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003648}
3649
brandtr31bd2242017-05-19 05:47:46 -07003650// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3651// tests that use this test fixture into the corresponding "non-field trial"
3652// tests.
eladalonf1841382017-06-12 01:16:46 -07003653class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003654 public:
eladalonf1841382017-06-12 01:16:46 -07003655 WebRtcVideoChannelFlexfecSendRecvTest()
3656 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003657 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3658 }
3659};
3660
Yves Gerey665174f2018-06-19 15:03:05 +02003661TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003662 FakeVideoSendStream* stream = AddSendStream();
3663 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3664
brandtr3d200bd2017-01-16 06:59:19 -08003665 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3666 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3667 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003668}
3669
eladalonf1841382017-06-12 01:16:46 -07003670TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003671 FakeVideoSendStream* stream = AddSendStream(
3672 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3673 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3674
brandtr3d200bd2017-01-16 06:59:19 -08003675 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3676 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3677 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3678 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003679}
3680
eladalonf1841382017-06-12 01:16:46 -07003681TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003682 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003683 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003684 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003685
3686 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003687 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003688
brandtrb5f2c3f2016-10-04 23:28:39 -07003689 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3690 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003691}
3692
eladalonf1841382017-06-12 01:16:46 -07003693TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003694 cricket::VideoSendParameters parameters;
3695 parameters.codecs.push_back(GetEngineCodec("VP8"));
3696 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3697
3698 FakeVideoSendStream* stream = AddSendStream();
3699 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3700
brandtr3d200bd2017-01-16 06:59:19 -08003701 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003702}
3703
eladalonf1841382017-06-12 01:16:46 -07003704TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003705 AddRecvStream(
3706 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003707
3708 cricket::VideoRecvParameters recv_parameters;
3709 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3710 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3711 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003712
3713 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3714 fake_call_->GetFlexfecReceiveStreams();
3715 ASSERT_EQ(1U, flexfec_streams.size());
3716 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3717 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3718 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003719 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003720 flexfec_stream_config.payload_type);
3721 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3722 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3723 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3724 const std::vector<FakeVideoReceiveStream*>& video_streams =
3725 fake_call_->GetVideoReceiveStreams();
3726 const FakeVideoReceiveStream* video_stream = video_streams.front();
3727 const webrtc::VideoReceiveStream::Config& video_stream_config =
3728 video_stream->GetConfig();
3729 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3730 flexfec_stream_config.local_ssrc);
3731 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3732 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3733 flexfec_stream_config.rtcp_send_transport);
3734 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3735 // spec-compliant way.
3736 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3737 flexfec_stream_config.transport_cc);
3738 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3739 EXPECT_EQ(video_stream_config.rtp.extensions,
3740 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003741}
3742
brandtr31bd2242017-05-19 05:47:46 -07003743// We should not send FlexFEC, even if we advertise it, unless the right
3744// field trial is set.
3745// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003746TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003747 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3748 cricket::VideoSendParameters parameters;
3749 parameters.codecs.push_back(GetEngineCodec("VP8"));
3750 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3751 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3752
3753 FakeVideoSendStream* stream = AddSendStream();
3754 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3755
3756 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003757 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003758 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3759}
3760
eladalonf1841382017-06-12 01:16:46 -07003761TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003762 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3763 cricket::VideoSendParameters parameters;
3764 parameters.codecs.push_back(GetEngineCodec("VP8"));
3765 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3766 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3767
3768 FakeVideoSendStream* stream = AddSendStream(
3769 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3770 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3771
3772 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003773 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003774 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3775}
3776
eladalonf1841382017-06-12 01:16:46 -07003777TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003778 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003779 const int kUnusedPayloadType = 127;
3780 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3781
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003782 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003783 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003784 parameters.codecs.push_back(rtx_codec);
3785 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003786 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003787}
3788
eladalonf1841382017-06-12 01:16:46 -07003789TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003790 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003791 const int kUnusedPayloadType1 = 126;
3792 const int kUnusedPayloadType2 = 127;
3793 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3794 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3795 {
3796 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3797 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3798 cricket::VideoSendParameters parameters;
3799 parameters.codecs.push_back(GetEngineCodec("VP8"));
3800 parameters.codecs.push_back(rtx_codec);
3801 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3802 }
3803 {
3804 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3805 kUnusedPayloadType1, kUnusedPayloadType2);
3806 cricket::VideoSendParameters parameters;
3807 parameters.codecs.push_back(GetEngineCodec("VP8"));
3808 parameters.codecs.push_back(rtx_codec);
3809 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3810 << "RTX without matching video codec should be rejected.";
3811 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003812}
3813
eladalonf1841382017-06-12 01:16:46 -07003814TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003815 const int kUnusedPayloadType1 = 126;
3816 const int kUnusedPayloadType2 = 127;
3817 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3818 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3819
3820 // SSRCs for RTX.
3821 cricket::StreamParams params =
3822 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3823 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3824 AddSendStream(params);
3825
3826 // Original payload type for RTX.
3827 cricket::VideoSendParameters parameters;
3828 parameters.codecs.push_back(GetEngineCodec("VP8"));
3829 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3830 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3831 parameters.codecs.push_back(rtx_codec);
3832 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3833 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3834 const webrtc::VideoSendStream::Config& config_before =
3835 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3836 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3837 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3838 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3839
3840 // Change payload type for RTX.
3841 parameters.codecs[1].id = kUnusedPayloadType2;
3842 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3843 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3844 const webrtc::VideoSendStream::Config& config_after =
3845 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3846 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3847 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3848 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3849}
3850
eladalonf1841382017-06-12 01:16:46 -07003851TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003852 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003853 parameters.codecs.push_back(GetEngineCodec("VP8"));
3854 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003855 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003856
3857 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003858 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003859
magjed509e4fe2016-11-18 01:34:11 -08003860 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003861
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003862 parameters.codecs.pop_back();
3863 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003864 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003865 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003866 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003867 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003868 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3869}
3870
eladalonf1841382017-06-12 01:16:46 -07003871TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003872 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003873 cricket::VideoSendParameters parameters;
3874 parameters.codecs.push_back(GetEngineCodec("VP8"));
3875 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3876 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3877
3878 FakeVideoSendStream* stream = AddSendStream(
3879 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3880 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3881
brandtr3d200bd2017-01-16 06:59:19 -08003882 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3883 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003884 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3885 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3886
3887 parameters.codecs.pop_back();
3888 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3889 stream = fake_call_->GetVideoSendStreams()[0];
3890 ASSERT_TRUE(stream != nullptr);
3891 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003892 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003893 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003894}
3895
eladalonf1841382017-06-12 01:16:46 -07003896TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003897 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003898 cricket::VideoCodec codec(100, "VP8");
3899 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3900 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003901
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003902 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003903 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003904
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003905 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003906 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003907 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003908
3909 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003910 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003911
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003912 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003913 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3914 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003915 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003916 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003917 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003918 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003919}
3920
eladalonf1841382017-06-12 01:16:46 -07003921TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003922 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3923 200000);
3924}
3925
eladalonf1841382017-06-12 01:16:46 -07003926TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003927 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3928 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3929 ASSERT_EQ(1u, streams.size());
3930 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3931}
3932
eladalonf1841382017-06-12 01:16:46 -07003933TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003934 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003935 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003936}
3937
eladalonf1841382017-06-12 01:16:46 -07003938TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003939 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003940}
3941
eladalonf1841382017-06-12 01:16:46 -07003942TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003943 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3944 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3945 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003946}
3947
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003948// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3949// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003950TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003951 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3952 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3953 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3954 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003955 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003956 ExpectSetBitrateParameters(100000, 200000, 400000);
3957 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3958 // Since the codec isn't changing, start_bitrate_bps should be -1.
3959 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003960
3961 // Decrease max_bandwidth_bps.
3962 send_parameters_.max_bandwidth_bps = 350000;
3963 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003964
3965 // Now try again with the values flipped around.
3966 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3967 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003968 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003969 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003970
3971 // If we change the codec max, max_bandwidth_bps should still apply.
3972 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003973 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003974 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003975}
3976
Yves Gerey665174f2018-06-19 15:03:05 +02003977TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003978 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3979 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003980 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003981 // Setting max bitrate should keep previous min bitrate.
3982 // Setting max bitrate should not reset start bitrate.
3983 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003984 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00003985}
3986
eladalonf1841382017-06-12 01:16:46 -07003987TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003988 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003989 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003990 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08003991 // -1 means to disable max bitrate (set infinite).
3992 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003993 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003994 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003995}
3996
eladalonf1841382017-06-12 01:16:46 -07003997TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07003998 send_parameters_.max_bandwidth_bps = 99999;
3999 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004000 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004001 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004002 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4003 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4004 stream->GetVideoStreams()[0].max_bitrate_bps);
4005
4006 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004007 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004008 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4009 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004010 stream->GetVideoStreams()[0].max_bitrate_bps);
4011}
4012
Åsa Persson55659812018-06-18 17:51:32 +02004013TEST_F(WebRtcVideoChannelTest,
4014 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4015 send_parameters_.max_bandwidth_bps = 99999;
4016 FakeVideoSendStream* stream = AddSendStream();
4017 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4018 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4019 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4020 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4021 stream->GetVideoStreams()[0].max_bitrate_bps);
4022
4023 // Get and set the rtp encoding parameters.
4024 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4025 EXPECT_EQ(1u, parameters.encodings.size());
4026
4027 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4028 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4029 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4030 stream->GetVideoStreams()[0].max_bitrate_bps);
4031
4032 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4033 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4034 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4035 stream->GetVideoStreams()[0].max_bitrate_bps);
4036}
4037
eladalonf1841382017-06-12 01:16:46 -07004038TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004039 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004040 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004041 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004042 channel_->SetSend(true);
4043
4044 FakeVideoSendStream* stream = AddSendStream();
4045
Tommi85959932018-02-07 19:26:06 +01004046 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004047 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004048 EXPECT_EQ(cricket::CS_RUNNING,
4049 capturer.Start(capturer.GetSupportedFormats()->front()));
4050
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004051 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4052 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4053 EXPECT_GT(initial_max_bitrate_bps, 0);
4054
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004055 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4056 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004057 // Insert a frame to update the encoder config.
4058 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004059 streams = stream->GetVideoStreams();
4060 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004061 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004062}
4063
eladalonf1841382017-06-12 01:16:46 -07004064TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004065 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004066 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004067 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004068 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004069 channel_->SetSend(true);
4070
4071 FakeVideoSendStream* stream = AddSendStream(
4072 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4073
4074 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004075 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004076 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004077 EXPECT_EQ(cricket::CS_RUNNING,
4078 capturer.Start(capturer.GetSupportedFormats()->front()));
4079 EXPECT_TRUE(capturer.CaptureFrame());
4080
4081 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4082 ASSERT_GT(streams.size(), 1u)
4083 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004084 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004085 EXPECT_GT(initial_max_bitrate_bps, 0);
4086
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004087 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4088 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004089 // Insert a frame to update the encoder config.
4090 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004091 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004092 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004093 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4094
Niels Möllerff40b142018-04-09 08:49:14 +02004095 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004096}
4097
eladalonf1841382017-06-12 01:16:46 -07004098TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004099 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004100 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004101 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004102 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4103 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004104 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004105 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004106
4107 VideoCodec codec;
4108 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4109 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4110}
4111
eladalonf1841382017-06-12 01:16:46 -07004112TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004113 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004114 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004115 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004116 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004117 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004118 parameters.codecs[0].id = kIncorrectPayloads[i];
4119 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004120 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004121 }
4122}
4123
eladalonf1841382017-06-12 01:16:46 -07004124TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004125 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004126 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004127 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004128 parameters.codecs[0].id = payload_type;
4129 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004130 << "Payload type '" << payload_type << "' rejected.";
4131 }
4132}
4133
deadbeef67cf2c12016-04-13 10:07:16 -07004134// Test that setting the a different set of codecs but with an identical front
4135// codec doesn't result in the stream being recreated.
4136// This may happen when a subsequent negotiation includes fewer codecs, as a
4137// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004138TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004139 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4140 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004141 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4142 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004143 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4144
4145 AddSendStream();
4146 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4147
4148 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004149 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004150 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4151 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4152}
4153
eladalonf1841382017-06-12 01:16:46 -07004154TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004155 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004156 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004157 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004158}
4159
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004160// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004161TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004162 const int kUnusedPayloadType1 = 126;
4163 const int kUnusedPayloadType2 = 127;
4164 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4165 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4166
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004167 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004168 parameters.codecs.push_back(GetEngineCodec("VP8"));
4169 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004170 parameters.codecs.push_back(rtx_codec);
4171 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004172 << "RTX codec without associated payload should be rejected.";
4173
magjed509e4fe2016-11-18 01:34:11 -08004174 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004175 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004176 << "RTX codec with invalid associated payload type should be rejected.";
4177
magjed509e4fe2016-11-18 01:34:11 -08004178 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004179 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004180
magjed509e4fe2016-11-18 01:34:11 -08004181 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004182 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004183 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004184
Yves Gerey665174f2018-06-19 15:03:05 +02004185 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4186 << "RTX codec with another RTX as associated payload type should be "
4187 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004188}
4189
eladalonf1841382017-06-12 01:16:46 -07004190TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004191 const int kUnusedPayloadType1 = 126;
4192 const int kUnusedPayloadType2 = 127;
4193 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4194 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4195
4196 // SSRCs for RTX.
4197 cricket::StreamParams params =
4198 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4199 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4200 AddRecvStream(params);
4201
4202 // Original payload type for RTX.
4203 cricket::VideoRecvParameters parameters;
4204 parameters.codecs.push_back(GetEngineCodec("VP8"));
4205 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4206 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4207 parameters.codecs.push_back(rtx_codec);
4208 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4209 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4210 const webrtc::VideoReceiveStream::Config& config_before =
4211 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004212 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4213 const int* payload_type_before = FindKeyByValue(
4214 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4215 ASSERT_NE(payload_type_before, nullptr);
4216 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004217 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4218
4219 // Change payload type for RTX.
4220 parameters.codecs[1].id = kUnusedPayloadType2;
4221 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4222 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4223 const webrtc::VideoReceiveStream::Config& config_after =
4224 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004225 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4226 const int* payload_type_after = FindKeyByValue(
4227 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4228 ASSERT_NE(payload_type_after, nullptr);
4229 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004230 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4231}
4232
eladalonf1841382017-06-12 01:16:46 -07004233TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004234 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004235 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004236 parameters.codecs[0].id = 99;
4237 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004238}
4239
eladalonf1841382017-06-12 01:16:46 -07004240TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004241 cricket::VideoRecvParameters parameters;
4242 parameters.codecs = engine_.codecs();
4243 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004244
4245 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004246 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004247 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].payload_name);
4248 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004249}
4250
eladalonf1841382017-06-12 01:16:46 -07004251TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004252 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004253 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004254 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004255 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004256}
4257
eladalonf1841382017-06-12 01:16:46 -07004258TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004259 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004260 parameters.codecs.push_back(GetEngineCodec("VP8"));
4261 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004262 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004263}
4264
eladalonf1841382017-06-12 01:16:46 -07004265TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004266 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004267 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4268 send_parameters.codecs.push_back(GetEngineCodec("red"));
4269 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004270 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004271
4272 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004273
magjed509e4fe2016-11-18 01:34:11 -08004274 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004275 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004276
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004277 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004278 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004279 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004280 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004281 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004282 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004283 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4284}
4285
eladalonf1841382017-06-12 01:16:46 -07004286TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004287 AddRecvStream(
4288 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004289 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004290 fake_call_->GetFlexfecReceiveStreams();
4291
4292 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004293 const FakeFlexfecReceiveStream* stream = streams.front();
4294 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4295 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4296 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4297 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004298
4299 cricket::VideoRecvParameters recv_parameters;
4300 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4301 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4302 EXPECT_TRUE(streams.empty())
4303 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004304}
4305
eladalonf1841382017-06-12 01:16:46 -07004306TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004307 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004308 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004309 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004310
4311 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004312 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4313 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4314 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004315 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4316 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004317 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004318 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004319 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004320 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004321
4322 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004323 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4324 send_parameters.codecs.push_back(GetEngineCodec("red"));
4325 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004326 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4327 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004328 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004329 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004330 << "ULPFEC should be enabled on the receive stream.";
4331}
4332
eladalonf1841382017-06-12 01:16:46 -07004333TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004334 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004335 AddRecvStream(
4336 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004337 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004338 fake_call_->GetFlexfecReceiveStreams();
4339
4340 cricket::VideoRecvParameters recv_parameters;
4341 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4342 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4343 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4344 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004345 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004346 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004347 stream_with_recv_params->GetConfig().payload_type);
4348 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004349 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004350 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004351 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004352 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004353
4354 cricket::VideoSendParameters send_parameters;
4355 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4356 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4357 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4358 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004359 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004360 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004361 stream_with_send_params->GetConfig().payload_type);
4362 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004363 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004364 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004365 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004366 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004367}
4368
eladalonf1841382017-06-12 01:16:46 -07004369TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004370 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004371 parameters.codecs.push_back(GetEngineCodec("VP8"));
4372 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004373 parameters.codecs[1].id = parameters.codecs[0].id;
4374 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004375}
4376
eladalonf1841382017-06-12 01:16:46 -07004377TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004378 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004379 cricket::VideoRecvParameters parameters;
4380 parameters.codecs.push_back(GetEngineCodec("VP8"));
4381 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4382 parameters.codecs[1].id = parameters.codecs[0].id;
4383 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4384}
4385
eladalonf1841382017-06-12 01:16:46 -07004386TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004387 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004388 parameters.codecs.push_back(GetEngineCodec("VP8"));
4389 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004390 parameters.codecs[1].id = parameters.codecs[0].id;
4391 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004392}
4393
eladalonf1841382017-06-12 01:16:46 -07004394TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004395 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004396 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004397 parameters.codecs.push_back(GetEngineCodec("VP8"));
4398 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004399 parameters.codecs[1].id += 1;
4400 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004401}
4402
deadbeef67cf2c12016-04-13 10:07:16 -07004403// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004404// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004405TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004406 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004407 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004408 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4409 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004410 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004411
4412 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4413 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4414
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004415 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004416 parameters2.codecs.push_back(GetEngineCodec("red"));
4417 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004418 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004419 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4420}
4421
eladalonf1841382017-06-12 01:16:46 -07004422TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004423 EXPECT_FALSE(AddSendStream()->IsSending());
4424}
4425
eladalonf1841382017-06-12 01:16:46 -07004426TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004427 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004428}
4429
eladalonf1841382017-06-12 01:16:46 -07004430TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004431 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004432 EXPECT_FALSE(stream->IsSending());
4433
4434 // false->true
4435 EXPECT_TRUE(channel_->SetSend(true));
4436 EXPECT_TRUE(stream->IsSending());
4437 // true->true
4438 EXPECT_TRUE(channel_->SetSend(true));
4439 EXPECT_TRUE(stream->IsSending());
4440 // true->false
4441 EXPECT_TRUE(channel_->SetSend(false));
4442 EXPECT_FALSE(stream->IsSending());
4443 // false->false
4444 EXPECT_TRUE(channel_->SetSend(false));
4445 EXPECT_FALSE(stream->IsSending());
4446
4447 EXPECT_TRUE(channel_->SetSend(true));
4448 FakeVideoSendStream* new_stream = AddSendStream();
4449 EXPECT_TRUE(new_stream->IsSending())
4450 << "Send stream created after SetSend(true) not sending initially.";
4451}
4452
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004453// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004454TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004455 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004456 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004457 MediaConfig config;
kwiberg686a8ef2016-02-26 03:00:35 -08004458 std::unique_ptr<VideoMediaChannel> channel;
nisse51542be2016-02-12 02:27:06 -08004459
4460 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4461 channel->SetInterface(network_interface.get());
4462 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004463 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004464
4465 config.enable_dscp = true;
4466 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4467 channel->SetInterface(network_interface.get());
4468 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
4469
4470 // Verify that setting the option to false resets the
4471 // DiffServCodePoint.
4472 config.enable_dscp = false;
4473 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4474 channel->SetInterface(network_interface.get());
4475 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004476}
4477
deadbeef13871492015-12-09 12:37:51 -08004478// This test verifies that the RTCP reduced size mode is properly applied to
4479// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004480TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004481 // Create stream, expecting that default mode is "compound".
4482 FakeVideoSendStream* stream1 = AddSendStream();
4483 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004484 webrtc::RtpParameters rtp_parameters =
4485 channel_->GetRtpSendParameters(last_ssrc_);
4486 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004487
4488 // Now enable reduced size mode.
4489 send_parameters_.rtcp.reduced_size = true;
4490 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4491 stream1 = fake_call_->GetVideoSendStreams()[0];
4492 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004493 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4494 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004495
4496 // Create a new stream and ensure it picks up the reduced size mode.
4497 FakeVideoSendStream* stream2 = AddSendStream();
4498 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4499}
4500
4501// This test verifies that the RTCP reduced size mode is properly applied to
4502// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004503TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004504 // Create stream, expecting that default mode is "compound".
4505 FakeVideoReceiveStream* stream1 = AddRecvStream();
4506 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4507
4508 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004509 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4510 // the reduced_size flag should come from that.
4511 send_parameters_.rtcp.reduced_size = true;
4512 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004513 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4514 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4515
4516 // Create a new stream and ensure it picks up the reduced size mode.
4517 FakeVideoReceiveStream* stream2 = AddRecvStream();
4518 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4519}
4520
eladalonf1841382017-06-12 01:16:46 -07004521TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004522 EXPECT_EQ(webrtc::kNetworkUp,
4523 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4524 EXPECT_EQ(webrtc::kNetworkUp,
4525 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004526
4527 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004528 EXPECT_EQ(webrtc::kNetworkDown,
4529 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4530 EXPECT_EQ(webrtc::kNetworkUp,
4531 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004532
4533 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004534 EXPECT_EQ(webrtc::kNetworkUp,
4535 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4536 EXPECT_EQ(webrtc::kNetworkUp,
4537 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004538}
4539
eladalonf1841382017-06-12 01:16:46 -07004540TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004541 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004542 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004543 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004544
4545 AddSendStream();
4546
4547 cricket::VideoMediaInfo info;
4548 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004549 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004550}
4551
eladalonf1841382017-06-12 01:16:46 -07004552TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004553 FakeVideoSendStream* stream = AddSendStream();
4554 webrtc::VideoSendStream::Stats stats;
4555 stats.encoder_implementation_name = "encoder_implementation_name";
4556 stream->SetStats(stats);
4557
4558 cricket::VideoMediaInfo info;
4559 ASSERT_TRUE(channel_->GetStats(&info));
4560 EXPECT_EQ(stats.encoder_implementation_name,
4561 info.senders[0].encoder_implementation_name);
4562}
4563
eladalonf1841382017-06-12 01:16:46 -07004564TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004565 FakeVideoSendStream* stream = AddSendStream();
4566 webrtc::VideoSendStream::Stats stats;
4567 stats.avg_encode_time_ms = 13;
4568 stats.encode_usage_percent = 42;
4569 stream->SetStats(stats);
4570
4571 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004572 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004573 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4574 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4575}
4576
eladalonf1841382017-06-12 01:16:46 -07004577TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004578 FakeVideoSendStream* stream = AddSendStream();
4579 webrtc::VideoSendStream::Stats stats;
4580 stats.frames_encoded = 13;
4581 stream->SetStats(stats);
4582
4583 cricket::VideoMediaInfo info;
4584 ASSERT_TRUE(channel_->GetStats(&info));
4585 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4586}
4587
eladalonf1841382017-06-12 01:16:46 -07004588TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004589 FakeVideoSendStream* stream = AddSendStream();
4590 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004591 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004592 stream->SetStats(stats);
4593
4594 cricket::VideoMediaInfo info;
4595 ASSERT_TRUE(channel_->GetStats(&info));
4596 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4597}
4598
eladalonf1841382017-06-12 01:16:46 -07004599TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004600 FakeVideoSendStream* stream = AddSendStream();
4601 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004602 stats.substreams[17].width = 123;
4603 stats.substreams[17].height = 40;
4604 stats.substreams[42].width = 80;
4605 stats.substreams[42].height = 31;
4606 stats.substreams[11].width = 20;
4607 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004608 stream->SetStats(stats);
4609
4610 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004611 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004612 ASSERT_EQ(1u, info.senders.size());
4613 EXPECT_EQ(123, info.senders[0].send_frame_width);
4614 EXPECT_EQ(90, info.senders[0].send_frame_height);
4615}
4616
eladalonf1841382017-06-12 01:16:46 -07004617TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004618 FakeVideoSendStream* stream = AddSendStream();
4619 webrtc::VideoSendStream::Stats stats;
4620 stats.number_of_cpu_adapt_changes = 2;
4621 stats.cpu_limited_resolution = true;
4622 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004623
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004624 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004625 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004626 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004627 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004628 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004629}
4630
eladalonf1841382017-06-12 01:16:46 -07004631TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004632 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004633 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004634 stats.number_of_cpu_adapt_changes = 2;
4635 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004636 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004637 stream->SetStats(stats);
4638
4639 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004640 EXPECT_TRUE(channel_->GetStats(&info));
4641 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004642 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4643 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004644 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004645 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004646}
4647
eladalonf1841382017-06-12 01:16:46 -07004648TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004649 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4650 FakeVideoSendStream* stream = AddSendStream();
4651 webrtc::VideoSendStream::Stats stats;
4652 stats.bw_limited_resolution = true;
4653 stream->SetStats(stats);
4654
4655 cricket::VideoMediaInfo info;
4656 EXPECT_TRUE(channel_->GetStats(&info));
4657 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004658 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004659 info.senders[0].adapt_reason);
4660}
4661
Yves Gerey665174f2018-06-19 15:03:05 +02004662TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004663 FakeVideoSendStream* stream = AddSendStream();
4664 webrtc::VideoSendStream::Stats stats;
4665 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4666 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4667 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4668
4669 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4670 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4671 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4672
4673 stream->SetStats(stats);
4674
4675 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004676 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004677 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4678 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4679 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4680}
4681
eladalonf1841382017-06-12 01:16:46 -07004682TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004683 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4684 FakeVideoReceiveStream* stream = AddRecvStream();
4685 webrtc::VideoReceiveStream::Stats stats;
4686 stats.rtcp_packet_type_counts.fir_packets = 2;
4687 stats.rtcp_packet_type_counts.nack_packets = 3;
4688 stats.rtcp_packet_type_counts.pli_packets = 4;
4689 stream->SetStats(stats);
4690
4691 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004692 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004693 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004694 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004695 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004696 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004697 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004698 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004699}
4700
eladalonf1841382017-06-12 01:16:46 -07004701TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004702 FakeVideoReceiveStream* stream = AddRecvStream();
4703 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004704 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004705 stats.decode_ms = 2;
4706 stats.max_decode_ms = 3;
4707 stats.current_delay_ms = 4;
4708 stats.target_delay_ms = 5;
4709 stats.jitter_buffer_ms = 6;
4710 stats.min_playout_delay_ms = 7;
4711 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004712 stats.width = 9;
4713 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004714 stats.frame_counts.key_frames = 11;
4715 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004716 stats.frames_rendered = 13;
4717 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004718 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004719 stream->SetStats(stats);
4720
4721 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004722 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004723 EXPECT_EQ(stats.decoder_implementation_name,
4724 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004725 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4726 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4727 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4728 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4729 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4730 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4731 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004732 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4733 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004734 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4735 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004736 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004737 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004738 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004739 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004740}
4741
eladalonf1841382017-06-12 01:16:46 -07004742TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004743 FakeVideoReceiveStream* stream = AddRecvStream();
4744 webrtc::VideoReceiveStream::Stats stats;
4745 stats.rtp_stats.transmitted.payload_bytes = 2;
4746 stats.rtp_stats.transmitted.header_bytes = 3;
4747 stats.rtp_stats.transmitted.padding_bytes = 4;
4748 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004749 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004750 stats.rtcp_stats.fraction_lost = 7;
4751 stream->SetStats(stats);
4752
4753 cricket::VideoMediaInfo info;
4754 ASSERT_TRUE(channel_->GetStats(&info));
4755 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4756 stats.rtp_stats.transmitted.header_bytes +
4757 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004758 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004759 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004760 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004761 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004762 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004763 info.receivers[0].fraction_lost);
4764}
4765
eladalonf1841382017-06-12 01:16:46 -07004766TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004767 AddSendStream();
4768 AddSendStream();
4769 webrtc::Call::Stats stats;
4770 stats.rtt_ms = 123;
4771 fake_call_->SetStats(stats);
4772
4773 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004774 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004775 ASSERT_EQ(2u, info.senders.size());
4776 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4777 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4778}
4779
eladalonf1841382017-06-12 01:16:46 -07004780TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004781 FakeVideoSendStream* stream = AddSendStream();
4782 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004783 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004784 stats.media_bitrate_bps = 123;
4785 stats.substreams[17].total_bitrate_bps = 1;
4786 stats.substreams[17].retransmit_bitrate_bps = 2;
4787 stats.substreams[42].total_bitrate_bps = 3;
4788 stats.substreams[42].retransmit_bitrate_bps = 4;
4789 stream->SetStats(stats);
4790
4791 FakeVideoSendStream* stream2 = AddSendStream();
4792 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004793 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004794 stats2.media_bitrate_bps = 321;
4795 stats2.substreams[13].total_bitrate_bps = 5;
4796 stats2.substreams[13].retransmit_bitrate_bps = 6;
4797 stats2.substreams[21].total_bitrate_bps = 7;
4798 stats2.substreams[21].retransmit_bitrate_bps = 8;
4799 stream2->SetStats(stats2);
4800
4801 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004802 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004803 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004804 BandwidthEstimationInfo bwe_info;
4805 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004806 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4807 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4808 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4809 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004810 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004811 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004812 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004813 bwe_info.actual_enc_bitrate);
4814 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004815 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004816 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004817 << "Bandwidth stats should take all streams into account.";
4818}
4819
eladalonf1841382017-06-12 01:16:46 -07004820TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004821 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004822
Peter Boström0c4e06b2015-10-07 12:23:21 +02004823 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4824 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004825
4826 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4827 const size_t kDataLength = 12;
4828 uint8_t data[kDataLength];
4829 memset(data, 0, sizeof(data));
4830 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004831 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004832 rtc::PacketTime packet_time;
4833 channel_->OnPacketReceived(&packet, packet_time);
4834
4835 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4836 << "No default receive stream created.";
4837 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004838 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004839 << "Default receive stream should not have configured RTX";
4840
4841 EXPECT_TRUE(channel_->AddRecvStream(
4842 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4843 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004844 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004845 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004846 EXPECT_FALSE(
4847 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004848 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004849 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004850 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004851 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004852 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004853 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004854}
4855
eladalonf1841382017-06-12 01:16:46 -07004856TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004857 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004858
Peter Boström0c4e06b2015-10-07 12:23:21 +02004859 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4860 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004861
4862 StreamParams sp =
4863 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4864 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4865
4866 EXPECT_FALSE(channel_->AddSendStream(sp));
4867 EXPECT_FALSE(channel_->AddRecvStream(sp));
4868}
4869
eladalonf1841382017-06-12 01:16:46 -07004870TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004871 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004872
Peter Boström0c4e06b2015-10-07 12:23:21 +02004873 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4874 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004875
4876 StreamParams sp =
4877 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4878
4879 EXPECT_TRUE(channel_->AddSendStream(sp));
4880 EXPECT_TRUE(channel_->AddRecvStream(sp));
4881
4882 // The RTX SSRC is already used in previous streams, using it should fail.
4883 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4884 EXPECT_FALSE(channel_->AddSendStream(sp));
4885 EXPECT_FALSE(channel_->AddRecvStream(sp));
4886
4887 // After removing the original stream this should be fine to add (makes sure
4888 // that RTX ssrcs are not forever taken).
4889 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4890 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4891 EXPECT_TRUE(channel_->AddSendStream(sp));
4892 EXPECT_TRUE(channel_->AddRecvStream(sp));
4893}
4894
eladalonf1841382017-06-12 01:16:46 -07004895TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004896 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004897 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4898 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004899 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004900
Peter Boströmd6f4c252015-03-26 16:23:04 +01004901 StreamParams sp =
4902 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4903
4904 EXPECT_TRUE(channel_->AddSendStream(sp));
4905 EXPECT_TRUE(channel_->AddRecvStream(sp));
4906
4907 // One of the SSRCs is already used in previous streams, using it should fail.
4908 sp = cricket::CreateSimStreamParams("cname",
4909 MAKE_VECTOR(kOverlappingStreamSsrcs));
4910 EXPECT_FALSE(channel_->AddSendStream(sp));
4911 EXPECT_FALSE(channel_->AddRecvStream(sp));
4912
4913 // After removing the original stream this should be fine to add (makes sure
4914 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02004915 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
4916 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004917 EXPECT_TRUE(channel_->AddSendStream(sp));
4918 EXPECT_TRUE(channel_->AddRecvStream(sp));
4919}
4920
eladalonf1841382017-06-12 01:16:46 -07004921TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004922 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02004923
4924 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
4925 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
4926
4927 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
4928 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
4929
4930 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
4931
4932 static const uint32_t kReceiverSsrcs[] = {3};
4933 static const uint32_t kReceiverRtxSsrcs[] = {2};
4934
4935 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
4936 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
4937 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
4938
4939 cricket::VideoMediaInfo info;
4940 ASSERT_TRUE(channel_->GetStats(&info));
4941
4942 ASSERT_EQ(1u, info.senders.size());
4943 ASSERT_EQ(1u, info.receivers.size());
4944
4945 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
4946 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
4947 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
4948}
4949
eladalonf1841382017-06-12 01:16:46 -07004950TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07004951 FakeVideoReceiveStream* stream = AddRecvStream();
4952 webrtc::VideoReceiveStream::Stats stats;
4953 cricket::VideoMediaInfo info;
4954
4955 // Report no codec name before receiving.
4956 stream->SetStats(stats);
4957 ASSERT_TRUE(channel_->GetStats(&info));
4958 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4959
4960 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08004961 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07004962 stream->SetStats(stats);
4963 ASSERT_TRUE(channel_->GetStats(&info));
4964 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
4965
4966 // Report no codec name for unknown playload types.
4967 stats.current_payload_type = 3;
4968 stream->SetStats(stats);
4969 ASSERT_TRUE(channel_->GetStats(&info));
4970 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4971}
4972
Seth Hampson5897a6e2018-04-03 11:16:33 -07004973// Tests that when we add a stream without SSRCs, but contains a stream_id
4974// that it is stored and its stream id is later used when the first packet
4975// arrives to properly create a receive stream with a sync label.
4976TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
4977 const char kSyncLabel[] = "sync_label";
4978 cricket::StreamParams unsignaled_stream;
4979 unsignaled_stream.set_stream_ids({kSyncLabel});
4980 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
4981 // The stream shouldn't have been created at this point because it doesn't
4982 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02004983 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07004984
4985 // Create and deliver packet.
4986 const size_t kDataLength = 12;
4987 uint8_t data[kDataLength];
4988 memset(data, 0, sizeof(data));
4989 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
4990 rtc::CopyOnWriteBuffer packet(data, kDataLength);
4991 rtc::PacketTime packet_time;
4992 channel_->OnPacketReceived(&packet, packet_time);
4993
4994 // The stream should now be created with the appropriate sync label.
4995 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4996 EXPECT_EQ(kSyncLabel,
4997 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
4998
4999 // Removing the unsignaled stream should clear the cache. This time when
5000 // a default video receive stream is created it won't have a sync_group.
5001 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5002 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5003 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5004
5005 channel_->OnPacketReceived(&packet, packet_time);
5006 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5007 EXPECT_TRUE(
5008 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5009}
5010
eladalonf1841382017-06-12 01:16:46 -07005011void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005012 uint8_t payload_type,
5013 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005014 // kRedRtxPayloadType must currently be unused.
5015 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5016
noahricd10a68e2015-07-10 11:27:55 -07005017 // Add a RED RTX codec.
5018 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005019 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005020 recv_parameters_.codecs.push_back(red_rtx_codec);
5021 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005022
5023 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5024 const size_t kDataLength = 12;
5025 uint8_t data[kDataLength];
5026 memset(data, 0, sizeof(data));
5027
5028 rtc::Set8(data, 1, payload_type);
5029 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005030 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005031 rtc::PacketTime packet_time;
5032 channel_->OnPacketReceived(&packet, packet_time);
5033
5034 if (expect_created_receive_stream) {
5035 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5036 << "Should have created a receive stream for payload type: "
5037 << payload_type;
5038 } else {
5039 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5040 << "Shouldn't have created a receive stream for payload type: "
5041 << payload_type;
5042 }
5043}
5044
eladalonf1841382017-06-12 01:16:46 -07005045TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005046 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5047 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005048}
5049
eladalonf1841382017-06-12 01:16:46 -07005050TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005051 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5052 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005053}
5054
eladalonf1841382017-06-12 01:16:46 -07005055TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005056 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005057 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5058 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5059 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5060 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005061}
5062
eladalonf1841382017-06-12 01:16:46 -07005063TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005064 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5065 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005066}
5067
eladalonf1841382017-06-12 01:16:46 -07005068TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005069 FlexfecPacketDoesntCreateUnsignalledStream) {
5070 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5071 false /* expect_created_receive_stream */);
5072}
5073
eladalonf1841382017-06-12 01:16:46 -07005074TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005075 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5076 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005077}
5078
mzanaty8a855d62017-02-17 15:46:43 -08005079// Test that receiving any unsignalled SSRC works even if it changes.
5080// The first unsignalled SSRC received will create a default receive stream.
5081// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005082TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005083 // Allow receiving VP8, VP9, H264 (if enabled).
5084 cricket::VideoRecvParameters parameters;
5085 parameters.codecs.push_back(GetEngineCodec("VP8"));
5086 parameters.codecs.push_back(GetEngineCodec("VP9"));
5087
5088#if defined(WEBRTC_USE_H264)
5089 cricket::VideoCodec H264codec(126, "H264");
5090 parameters.codecs.push_back(H264codec);
5091#endif
5092
5093 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5094 // No receive streams yet.
5095 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5096 cricket::FakeVideoRenderer renderer;
5097 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5098
5099 // Receive VP8 packet on first SSRC.
5100 uint8_t data[kMinRtpPacketLen];
5101 cricket::RtpHeader rtpHeader;
5102 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5103 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005104 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005105 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5106 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5107 rtc::PacketTime packet_time;
5108 channel_->OnPacketReceived(&packet, packet_time);
5109 // VP8 packet should create default receive stream.
5110 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005111 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005112 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5113 // Verify that the receive stream sinks to a renderer.
5114 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5115 webrtc::kVideoRotation_0);
5116 recv_stream->InjectFrame(video_frame);
5117 EXPECT_EQ(1, renderer.num_rendered_frames());
5118
5119 // Receive VP9 packet on second SSRC.
5120 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005121 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005122 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5123 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5124 channel_->OnPacketReceived(&packet2, packet_time);
5125 // VP9 packet should replace the default receive SSRC.
5126 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5127 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5128 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5129 // Verify that the receive stream sinks to a renderer.
5130 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005131 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005132 recv_stream->InjectFrame(video_frame2);
5133 EXPECT_EQ(2, renderer.num_rendered_frames());
5134
5135#if defined(WEBRTC_USE_H264)
5136 // Receive H264 packet on third SSRC.
5137 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005138 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005139 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5140 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5141 channel_->OnPacketReceived(&packet3, packet_time);
5142 // H264 packet should replace the default receive SSRC.
5143 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5144 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5145 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5146 // Verify that the receive stream sinks to a renderer.
5147 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005148 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005149 recv_stream->InjectFrame(video_frame3);
5150 EXPECT_EQ(3, renderer.num_rendered_frames());
5151#endif
5152}
5153
brandtr0dc57ea2017-05-29 23:33:31 -07005154// This test verifies that when a new default stream is created for a new
5155// unsignaled SSRC, the new stream does not overwrite any old stream that had
5156// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005157TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005158 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5159 cricket::VideoRecvParameters parameters;
5160 parameters.codecs.push_back(GetEngineCodec("VP8"));
5161 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5162
5163 // No streams signaled and no packets received, so we should not have any
5164 // stream objects created yet.
5165 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5166
5167 // Receive packet on an unsignaled SSRC.
5168 uint8_t data[kMinRtpPacketLen];
5169 cricket::RtpHeader rtp_header;
5170 rtp_header.payload_type = GetEngineCodec("VP8").id;
5171 rtp_header.seq_num = rtp_header.timestamp = 0;
5172 rtp_header.ssrc = kSsrcs3[0];
5173 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5174 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5175 rtc::PacketTime packet_time;
5176 channel_->OnPacketReceived(&packet, packet_time);
5177 // Default receive stream should be created.
5178 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5179 FakeVideoReceiveStream* recv_stream0 =
5180 fake_call_->GetVideoReceiveStreams()[0];
5181 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5182
5183 // Signal the SSRC.
5184 EXPECT_TRUE(
5185 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5186 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5187 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5188 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5189
5190 // Receive packet on a different unsignaled SSRC.
5191 rtp_header.ssrc = kSsrcs3[1];
5192 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5193 packet.SetData(data, sizeof(data));
5194 channel_->OnPacketReceived(&packet, packet_time);
5195 // New default receive stream should be created, but old stream should remain.
5196 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5197 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5198 FakeVideoReceiveStream* recv_stream1 =
5199 fake_call_->GetVideoReceiveStreams()[1];
5200 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5201}
5202
Seth Hampson7c682e02018-05-04 16:28:15 -07005203TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005204 AddSendStream();
5205
Tommi85959932018-02-07 19:26:06 +01005206 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005207 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005208 cricket::VideoFormat capture_format_hd =
5209 capturer.GetSupportedFormats()->front();
5210 EXPECT_EQ(1280, capture_format_hd.width);
5211 EXPECT_EQ(720, capture_format_hd.height);
5212 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5213 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005214 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005215
perkjfa10b552016-10-02 23:45:26 -07005216 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005217 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005218
5219 // TODO(skvlad): Resolve the inconsistency between the interpretation
5220 // of the global bitrate limit for audio and video:
5221 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5222 // max_bandwidth_bps = -1 - remove the bandwidth limit
5223 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005224 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005225
perkjfa10b552016-10-02 23:45:26 -07005226 SetAndExpectMaxBitrate(1000, 0, 1000);
5227 SetAndExpectMaxBitrate(1000, 800, 800);
5228 SetAndExpectMaxBitrate(600, 800, 600);
5229 SetAndExpectMaxBitrate(0, 800, 800);
5230 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005231
Niels Möllerff40b142018-04-09 08:49:14 +02005232 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005233}
5234
eladalonf1841382017-06-12 01:16:46 -07005235TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005236 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005237 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005238 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005239
5240 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005241 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005242 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005243}
5244
eladalonf1841382017-06-12 01:16:46 -07005245TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005246 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005247 FakeVideoSendStream* stream = AddSendStream();
5248
Seth Hampson7c682e02018-05-04 16:28:15 -07005249 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5250 EXPECT_EQ(1UL, parameters.encodings.size());
5251 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5252 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5253
5254 // Note that this is testing the behavior of the FakeVideoSendStream, which
5255 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5256 // we are just testing the behavior of
5257 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005258 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5259 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005260
5261 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5262 // by this amount.
5263 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5264 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5265 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5266 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5267
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005268 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5269 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5270 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5271}
5272
5273TEST_F(WebRtcVideoChannelTest,
5274 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5275 FakeVideoSendStream* stream = AddSendStream();
5276
5277 // Note that this is testing the behavior of the FakeVideoSendStream, which
5278 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5279 // we are just testing the behavior of
5280 // EncoderStreamFactory::CreateEncoderStreams.
5281 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5282 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5283
5284 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5285 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5286 EXPECT_EQ(1UL, parameters.encodings.size());
5287 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5288 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5289
5290 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5291 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5292 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5293}
5294
5295TEST_F(WebRtcVideoChannelTest,
5296 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5297 send_parameters_.max_bandwidth_bps = 99999;
5298 FakeVideoSendStream* stream = AddSendStream();
5299 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5300 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5301 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5302 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5303 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5304 stream->GetVideoStreams()[0].max_bitrate_bps);
5305
5306 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5307 // adjusted down.
5308 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5309 EXPECT_EQ(1UL, parameters.encodings.size());
5310 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5311 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5312 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5313 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5314 stream->GetVideoStreams()[0].min_bitrate_bps);
5315 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5316 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005317}
5318
5319TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005320 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005321 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005322 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005323 // Two or more encodings should result in failure.
5324 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005325 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005326 // Zero encodings should also fail.
5327 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005328 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005329}
5330
Zach Stein3ca452b2018-01-18 10:01:24 -08005331TEST_F(WebRtcVideoChannelTest,
5332 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5333 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5334 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5335 AddSendStream(sp);
5336
5337 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5338
5339 // Additional encodings should result in failure.
5340 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005341 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005342 // Zero encodings should also fail.
5343 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005344 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005345}
5346
deadbeeffb2aced2017-01-06 23:05:37 -08005347// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005348TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005349 AddSendStream();
5350 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005351 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005352 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005353}
5354
Seth Hampson24722b32017-12-22 09:36:42 -08005355// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5356// a value <= 0, setting the parameters returns false.
5357TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5358 AddSendStream();
5359 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5360 EXPECT_EQ(1UL, parameters.encodings.size());
5361 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5362 parameters.encodings[0].bitrate_priority);
5363
5364 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005365 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005366 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005367 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005368}
5369
5370// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5371// properly on the VideoChannel and propogates down to the video encoder.
5372TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5373 AddSendStream();
5374 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5375 EXPECT_EQ(1UL, parameters.encodings.size());
5376 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5377 parameters.encodings[0].bitrate_priority);
5378
5379 // Change the value and set it on the VideoChannel.
5380 double new_bitrate_priority = 2.0;
5381 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005382 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005383
5384 // Verify that the encoding parameters bitrate_priority is set for the
5385 // VideoChannel.
5386 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5387 EXPECT_EQ(1UL, parameters.encodings.size());
5388 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5389
5390 // Verify that the new value propagated down to the encoder.
5391 std::vector<FakeVideoSendStream*> video_send_streams =
5392 fake_call_->GetVideoSendStreams();
5393 EXPECT_EQ(1UL, video_send_streams.size());
5394 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5395 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5396 // appropriately.
5397 EXPECT_EQ(new_bitrate_priority,
5398 video_send_stream->GetEncoderConfig().bitrate_priority);
5399 // Check that the vector of VideoStreams also was propagated correctly. Note
5400 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5401 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005402 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005403 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5404}
5405
5406// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5407// VideoChannel and the value propogates to the video encoder with all simulcast
5408// streams.
5409TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5410 // Create the stream params with multiple ssrcs for simulcast.
5411 const int kNumSimulcastStreams = 3;
5412 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5413 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5414 AddSendStream(stream_params);
5415 uint32_t primary_ssrc = stream_params.first_ssrc();
5416
Tommi85959932018-02-07 19:26:06 +01005417 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5418 // frame. This creates multiple VideoStreams for all simulcast layers when
5419 // reconfiguring, and allows us to test this behavior.
5420 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005421 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005422 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005423 EXPECT_EQ(cricket::CS_RUNNING,
5424 capturer.Start(cricket::VideoFormat(
5425 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5426 cricket::FOURCC_I420)));
5427 channel_->SetSend(true);
5428 EXPECT_TRUE(capturer.CaptureFrame());
5429 // Get and set the rtp encoding parameters.
5430 webrtc::RtpParameters parameters =
5431 channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005432 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5433 parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005434 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5435 parameters.encodings[0].bitrate_priority);
5436 // Change the value and set it on the VideoChannel.
5437 double new_bitrate_priority = 2.0;
5438 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005439 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005440
5441 // Verify that the encoding parameters priority is set on the VideoChannel.
5442 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005443 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5444 parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005445 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5446
5447 // Verify that the new value propagated down to the encoder.
5448 std::vector<FakeVideoSendStream*> video_send_streams =
5449 fake_call_->GetVideoSendStreams();
5450 EXPECT_EQ(1UL, video_send_streams.size());
5451 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5452 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5453 // appropriately.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005454 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
Seth Hampson24722b32017-12-22 09:36:42 -08005455 video_send_stream->GetEncoderConfig().number_of_streams);
5456 EXPECT_EQ(new_bitrate_priority,
5457 video_send_stream->GetEncoderConfig().bitrate_priority);
5458 // Check that the vector of VideoStreams also propagated correctly. The
5459 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5460 // these are created appropriately for the simulcast case.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005461 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5462 video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005463 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005464 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5465 // Since we are only setting bitrate priority per-sender, the other
5466 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005467 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005468 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005469 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005470 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005471 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005472}
5473
Åsa Persson55659812018-06-18 17:51:32 +02005474TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5475 const size_t kNumSimulcastStreams = 3;
5476 SetUpSimulcast(true, false);
5477
5478 // Get and set the rtp encoding parameters.
5479 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5480 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5481 for (const auto& encoding : parameters.encodings) {
5482 EXPECT_FALSE(encoding.min_bitrate_bps);
5483 EXPECT_FALSE(encoding.max_bitrate_bps);
5484 }
5485
5486 // Change the value and set it on the VideoChannel.
5487 parameters.encodings[0].min_bitrate_bps = 100000;
5488 parameters.encodings[0].max_bitrate_bps = 200000;
5489 parameters.encodings[1].min_bitrate_bps = 300000;
5490 parameters.encodings[1].max_bitrate_bps = 400000;
5491 parameters.encodings[2].min_bitrate_bps = 500000;
5492 parameters.encodings[2].max_bitrate_bps = 600000;
5493 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5494
5495 // Verify that the bitrates are set on the VideoChannel.
5496 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5497 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5498 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5499 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5500 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5501 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5502 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5503 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5504}
5505
5506TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5507 const size_t kNumSimulcastStreams = 3;
5508 SetUpSimulcast(true, false);
5509
5510 // Get and set the rtp encoding parameters.
5511 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5512 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5513
5514 // Max bitrate lower than min bitrate should fail.
5515 parameters.encodings[2].min_bitrate_bps = 100000;
5516 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5517 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5518 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5519}
5520
5521// Test that min and max bitrate values set via RtpParameters are correctly
5522// propagated to the underlying encoder, and that the target is set to 3/4 of
5523// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5524// that are used if no min/max are specified).
5525TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5526 const size_t kNumSimulcastStreams = 3;
5527 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5528
5529 // Send a full size frame so all simulcast layers are used when reconfiguring.
5530 FakeVideoCapturerWithTaskQueue capturer;
5531 VideoOptions options;
5532 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5533 EXPECT_EQ(cricket::CS_RUNNING,
5534 capturer.Start(capturer.GetSupportedFormats()->front()));
5535 channel_->SetSend(true);
5536 EXPECT_TRUE(capturer.CaptureFrame());
5537
5538 // Get and set the rtp encoding parameters.
5539 // Change the value and set it on the VideoChannel.
5540 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5541 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5542 parameters.encodings[0].min_bitrate_bps = 100000;
5543 parameters.encodings[0].max_bitrate_bps = 200000;
5544 parameters.encodings[1].min_bitrate_bps = 300000;
5545 parameters.encodings[1].max_bitrate_bps = 400000;
5546 parameters.encodings[2].min_bitrate_bps = 500000;
5547 parameters.encodings[2].max_bitrate_bps = 600000;
5548 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5549
5550 // Verify that the new value propagated down to the encoder.
5551 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5552 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5553 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5554 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5555 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5556 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5557 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5558 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
5559 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
5560 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
5561 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
5562
5563 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5564 // VideoStreams are created appropriately for the simulcast case.
5565 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5566 // Target bitrate: 200000 * 3 / 4 = 150000.
5567 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
5568 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5569 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
5570 // Target bitrate: 400000 * 3 / 4 = 300000.
5571 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
5572 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
5573 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
5574 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
5575 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
5576 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
5577 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
5578
5579 // No parameter changed, encoder should not be reconfigured.
5580 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5581 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5582
5583 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5584}
5585
5586// Test to only specify the min or max bitrate value for a layer via
5587// RtpParameters. The unspecified min/max and target value should be set to the
5588// simulcast default that is used if no min/max are specified.
5589TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
5590 const size_t kNumSimulcastStreams = 3;
5591 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5592 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5593
5594 // Send a full size frame so all simulcast layers are used when reconfiguring.
5595 FakeVideoCapturerWithTaskQueue capturer;
5596 VideoOptions options;
5597 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5598 EXPECT_EQ(cricket::CS_RUNNING,
5599 capturer.Start(capturer.GetSupportedFormats()->front()));
5600 channel_->SetSend(true);
5601 EXPECT_TRUE(capturer.CaptureFrame());
5602
5603 // Get and set the rtp encoding parameters.
5604 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5605 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5606
5607 // Change the value and set it on the VideoChannel.
5608 // Layer 0: only configure min bitrate.
5609 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
5610 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5611 // Layer 1: only configure max bitrate.
5612 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
5613 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5614 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5615
5616 // Verify that the new value propagated down to the encoder.
5617 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5618 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5619 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5620 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5621 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
5622 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5623 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
5624 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
5625 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
5626 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
5627
5628 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5629 // VideoStreams are created appropriately for the simulcast case.
5630 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5631 // Layer 0: min configured bitrate should overwrite min default.
5632 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5633 EXPECT_EQ(kDefault[0].target_bitrate_bps,
5634 stream->GetVideoStreams()[0].target_bitrate_bps);
5635 EXPECT_EQ(kDefault[0].max_bitrate_bps,
5636 stream->GetVideoStreams()[0].max_bitrate_bps);
5637 // Layer 1: max configured bitrate should overwrite max default.
5638 EXPECT_EQ(kDefault[1].min_bitrate_bps,
5639 stream->GetVideoStreams()[1].min_bitrate_bps);
5640 EXPECT_EQ(kDefault[1].target_bitrate_bps,
5641 stream->GetVideoStreams()[1].target_bitrate_bps);
5642 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5643 // Layer 2: min and max bitrate not configured, default expected.
5644 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5645 stream->GetVideoStreams()[2].min_bitrate_bps);
5646 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5647 stream->GetVideoStreams()[2].target_bitrate_bps);
5648 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5649 stream->GetVideoStreams()[2].max_bitrate_bps);
5650
5651 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5652}
5653
5654// Test that specifying the min (or max) bitrate value for a layer via
5655// RtpParameters above (or below) the simulcast default max (or min) adjusts the
5656// unspecified values accordingly.
5657TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
5658 const size_t kNumSimulcastStreams = 3;
5659 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5660 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5661
5662 // Send a full size frame so all simulcast layers are used when reconfiguring.
5663 FakeVideoCapturerWithTaskQueue capturer;
5664 VideoOptions options;
5665 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5666 EXPECT_EQ(cricket::CS_RUNNING,
5667 capturer.Start(capturer.GetSupportedFormats()->front()));
5668 channel_->SetSend(true);
5669 EXPECT_TRUE(capturer.CaptureFrame());
5670
5671 // Get and set the rtp encoding parameters.
5672 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5673 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5674
5675 // Change the value and set it on the VideoChannel.
5676 // For layer 0, set the min bitrate above the default max.
5677 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
5678 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5679 // For layer 1, set the max bitrate below the default min.
5680 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
5681 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5682 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5683
5684 // Verify that the new value propagated down to the encoder.
5685 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5686 // VideoStreams are created appropriately for the simulcast case.
5687 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5688 // Layer 0: Min bitrate above default max (target/max should be adjusted).
5689 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5690 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
5691 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
5692 // Layer 1: Max bitrate below default min (min/target should be adjusted).
5693 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
5694 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
5695 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5696 // Layer 2: min and max bitrate not configured, default expected.
5697 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5698 stream->GetVideoStreams()[2].min_bitrate_bps);
5699 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5700 stream->GetVideoStreams()[2].target_bitrate_bps);
5701 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5702 stream->GetVideoStreams()[2].max_bitrate_bps);
5703
5704 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5705}
5706
5707TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
5708 const size_t kNumSimulcastStreams = 3;
5709 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5710 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5711
5712 // Send a full size frame so all simulcast layers are used when reconfiguring.
5713 FakeVideoCapturerWithTaskQueue capturer;
5714 VideoOptions options;
5715 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5716 EXPECT_EQ(cricket::CS_RUNNING,
5717 capturer.Start(capturer.GetSupportedFormats()->front()));
5718 channel_->SetSend(true);
5719 EXPECT_TRUE(capturer.CaptureFrame());
5720
5721 // Set max bitrate for all but the highest layer.
5722 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5723 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5724 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
5725 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
5726 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5727
5728 // Set max bandwidth equal to total max bitrate.
5729 send_parameters_.max_bandwidth_bps =
5730 GetTotalMaxBitrateBps(stream->GetVideoStreams());
5731 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5732 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5733
5734 // No bitrate above the total max to give to the highest layer.
5735 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5736 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5737 stream->GetVideoStreams()[2].max_bitrate_bps);
5738
5739 // Set max bandwidth above the total max bitrate.
5740 send_parameters_.max_bandwidth_bps =
5741 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5742 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5743 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5744
5745 // The highest layer has no max bitrate set -> the bitrate above the total
5746 // max should be given to the highest layer.
5747 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5748 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5749 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
5750 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
5751 stream->GetVideoStreams()[2].max_bitrate_bps);
5752
5753 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5754}
5755
5756TEST_F(WebRtcVideoChannelTest,
5757 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
5758 const size_t kNumSimulcastStreams = 3;
5759 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5760 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
5761 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5762
5763 // Send a full size frame so all simulcast layers are used when reconfiguring.
5764 FakeVideoCapturerWithTaskQueue capturer;
5765 VideoOptions options;
5766 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5767 EXPECT_EQ(cricket::CS_RUNNING,
5768 capturer.Start(capturer.GetSupportedFormats()->front()));
5769 channel_->SetSend(true);
5770 EXPECT_TRUE(capturer.CaptureFrame());
5771
5772 // Set max bitrate for the highest layer.
5773 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5774 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5775 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
5776 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5777
5778 // Set max bandwidth above the total max bitrate.
5779 send_parameters_.max_bandwidth_bps =
5780 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5781 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5782 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5783
5784 // The highest layer has the max bitrate set -> the bitrate above the total
5785 // max should not be given to the highest layer.
5786 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5787 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
5788 stream->GetVideoStreams()[2].max_bitrate_bps);
5789
5790 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5791}
5792
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005793// Test that min and max bitrate values set via RtpParameters are correctly
5794// propagated to the underlying encoder for a single stream.
5795TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
5796 FakeVideoSendStream* stream = AddSendStream();
5797 EXPECT_TRUE(channel_->SetSend(true));
5798 EXPECT_TRUE(stream->IsSending());
5799
5800 // Set min and max bitrate.
5801 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5802 EXPECT_EQ(1u, parameters.encodings.size());
5803 parameters.encodings[0].min_bitrate_bps = 80000;
5804 parameters.encodings[0].max_bitrate_bps = 150000;
5805 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5806
5807 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5808 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5809 EXPECT_EQ(1u, encoder_config.number_of_streams);
5810 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
5811 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5812 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5813
5814 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5815 // VideoStreams are created appropriately.
5816 EXPECT_EQ(1u, stream->GetVideoStreams().size());
5817 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
5818 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5819 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
5820}
5821
5822// Test the default min and max bitrate value are correctly propagated to the
5823// underlying encoder for a single stream (when the values are not set via
5824// RtpParameters).
5825TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
5826 FakeVideoSendStream* stream = AddSendStream();
5827 EXPECT_TRUE(channel_->SetSend(true));
5828 EXPECT_TRUE(stream->IsSending());
5829
5830 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5831 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5832 EXPECT_EQ(1u, encoder_config.number_of_streams);
5833 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
5834 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
5835 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5836
5837 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5838 // VideoStreams are created appropriately.
5839 EXPECT_EQ(1u, stream->GetVideoStreams().size());
5840 EXPECT_EQ(cricket::kMinVideoBitrateBps,
5841 stream->GetVideoStreams()[0].min_bitrate_bps);
5842 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
5843 stream->GetVideoStreams()[0].min_bitrate_bps);
5844 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
5845 stream->GetVideoStreams()[0].target_bitrate_bps);
5846}
5847
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005848// Test that a stream will not be sending if its encoding is made inactive
5849// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08005850TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07005851 FakeVideoSendStream* stream = AddSendStream();
5852 EXPECT_TRUE(channel_->SetSend(true));
5853 EXPECT_TRUE(stream->IsSending());
5854
5855 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005856 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07005857 ASSERT_EQ(1u, parameters.encodings.size());
5858 ASSERT_TRUE(parameters.encodings[0].active);
5859 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08005860 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005861 EXPECT_FALSE(stream->IsSending());
5862
5863 // Now change it back to active and verify we resume sending.
5864 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08005865 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07005866 EXPECT_TRUE(stream->IsSending());
5867}
5868
Seth Hampson8234ead2018-02-02 15:16:24 -08005869// Tests that when active is updated for any simulcast layer then the send
5870// stream's sending state will be updated and it will be reconfigured with the
5871// new appropriate active simulcast streams.
5872TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
5873 // Create the stream params with multiple ssrcs for simulcast.
5874 const int kNumSimulcastStreams = 3;
5875 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5876 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5877 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
5878 uint32_t primary_ssrc = stream_params.first_ssrc();
5879
Tommi85959932018-02-07 19:26:06 +01005880 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5881 // frame. This allows us to test that ReconfigureEncoder is called
5882 // appropriately.
5883 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08005884 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005885 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08005886 EXPECT_EQ(cricket::CS_RUNNING,
5887 capturer.Start(cricket::VideoFormat(
5888 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5889 cricket::FOURCC_I420)));
5890 channel_->SetSend(true);
5891 EXPECT_TRUE(capturer.CaptureFrame());
5892
5893 // Check that all encodings are initially active.
5894 webrtc::RtpParameters parameters =
5895 channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005896 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5897 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005898 EXPECT_TRUE(parameters.encodings[0].active);
5899 EXPECT_TRUE(parameters.encodings[1].active);
5900 EXPECT_TRUE(parameters.encodings[2].active);
5901 EXPECT_TRUE(fake_video_send_stream->IsSending());
5902
5903 // Only turn on only the middle stream.
5904 parameters.encodings[0].active = false;
5905 parameters.encodings[1].active = true;
5906 parameters.encodings[2].active = false;
5907 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5908 // Verify that the active fields are set on the VideoChannel.
5909 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005910 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5911 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005912 EXPECT_FALSE(parameters.encodings[0].active);
5913 EXPECT_TRUE(parameters.encodings[1].active);
5914 EXPECT_FALSE(parameters.encodings[2].active);
5915 // Check that the VideoSendStream is updated appropriately. This means its
5916 // send state was updated and it was reconfigured.
5917 EXPECT_TRUE(fake_video_send_stream->IsSending());
5918 std::vector<webrtc::VideoStream> simulcast_streams =
5919 fake_video_send_stream->GetVideoStreams();
Mirko Bonadeif859e552018-05-30 15:31:29 +02005920 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5921 simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005922 EXPECT_FALSE(simulcast_streams[0].active);
5923 EXPECT_TRUE(simulcast_streams[1].active);
5924 EXPECT_FALSE(simulcast_streams[2].active);
5925
5926 // Turn off all streams.
5927 parameters.encodings[0].active = false;
5928 parameters.encodings[1].active = false;
5929 parameters.encodings[2].active = false;
5930 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
5931 // Verify that the active fields are set on the VideoChannel.
5932 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005933 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5934 parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005935 EXPECT_FALSE(parameters.encodings[0].active);
5936 EXPECT_FALSE(parameters.encodings[1].active);
5937 EXPECT_FALSE(parameters.encodings[2].active);
5938 // Check that the VideoSendStream is off.
5939 EXPECT_FALSE(fake_video_send_stream->IsSending());
5940 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Mirko Bonadeif859e552018-05-30 15:31:29 +02005941 EXPECT_EQ(rtc::checked_cast<size_t>(kNumSimulcastStreams),
5942 simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08005943 EXPECT_FALSE(simulcast_streams[0].active);
5944 EXPECT_FALSE(simulcast_streams[1].active);
5945 EXPECT_FALSE(simulcast_streams[2].active);
5946
Niels Möllerff40b142018-04-09 08:49:14 +02005947 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08005948}
5949
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005950// Test that if a stream is reconfigured (due to a codec change or other
5951// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07005952TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005953 InactiveStreamDoesntStartSendingWhenReconfigured) {
5954 // Set an initial codec list, which will be modified later.
5955 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08005956 parameters1.codecs.push_back(GetEngineCodec("VP8"));
5957 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005958 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
5959
5960 FakeVideoSendStream* stream = AddSendStream();
5961 EXPECT_TRUE(channel_->SetSend(true));
5962 EXPECT_TRUE(stream->IsSending());
5963
5964 // Get current parameters and change "active" to false.
5965 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5966 ASSERT_EQ(1u, parameters.encodings.size());
5967 ASSERT_TRUE(parameters.encodings[0].active);
5968 parameters.encodings[0].active = false;
5969 EXPECT_EQ(1u, GetFakeSendStreams().size());
5970 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08005971 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005972 EXPECT_FALSE(stream->IsSending());
5973
5974 // Reorder the codec list, causing the stream to be reconfigured.
5975 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08005976 parameters2.codecs.push_back(GetEngineCodec("VP9"));
5977 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07005978 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
5979 auto new_streams = GetFakeSendStreams();
5980 // Assert that a new underlying stream was created due to the codec change.
5981 // Otherwise, this test isn't testing what it set out to test.
5982 EXPECT_EQ(1u, GetFakeSendStreams().size());
5983 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
5984
5985 // Verify that we still are not sending anything, due to the inactive
5986 // encoding.
5987 EXPECT_FALSE(new_streams[0]->IsSending());
5988}
5989
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005990// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07005991TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005992 AddSendStream();
5993 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005994 parameters.codecs.push_back(GetEngineCodec("VP8"));
5995 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07005996 EXPECT_TRUE(channel_->SetSendParameters(parameters));
5997
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005998 webrtc::RtpParameters rtp_parameters =
5999 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006000 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006001 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6002 rtp_parameters.codecs[0]);
6003 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6004 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006005}
6006
Florent Castellidacec712018-05-24 16:24:21 +02006007// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6008TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6009 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6010 params.cname = "rtcpcname";
6011 AddSendStream(params);
6012
6013 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6014 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6015}
6016
deadbeeffb2aced2017-01-06 23:05:37 -08006017// Test that RtpParameters for send stream has one encoding and it has
6018// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006019TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006020 AddSendStream();
6021
6022 webrtc::RtpParameters rtp_parameters =
6023 channel_->GetRtpSendParameters(last_ssrc_);
6024 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006025 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006026}
6027
Florent Castelliabe301f2018-06-12 18:33:49 +02006028TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6029 AddSendStream();
6030
6031 webrtc::RtpParameters rtp_parameters =
6032 channel_->GetRtpSendParameters(last_ssrc_);
6033 rtp_parameters.header_extensions.emplace_back();
6034
6035 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6036
6037 webrtc::RTCError result =
6038 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6039 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6040}
6041
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006042// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006043TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006044 AddSendStream();
6045 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006046 parameters.codecs.push_back(GetEngineCodec("VP8"));
6047 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006048 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6049
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006050 webrtc::RtpParameters initial_params =
6051 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006052
6053 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006054 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006055
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006056 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6057 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6058}
6059
6060// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006061TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006062 AddRecvStream();
6063 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006064 parameters.codecs.push_back(GetEngineCodec("VP8"));
6065 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006066 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6067
6068 webrtc::RtpParameters rtp_parameters =
6069 channel_->GetRtpReceiveParameters(last_ssrc_);
6070 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006071 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6072 rtp_parameters.codecs[0]);
6073 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6074 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006075}
6076
johan073ece42016-08-26 02:59:47 -07006077#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006078TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006079#else
eladalonf1841382017-06-12 01:16:46 -07006080TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006081#endif
johan3859c892016-08-05 09:19:25 -07006082 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006083 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006084 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006085 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006086 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006087 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006088 parameters.codecs.push_back(kH264sprop2);
6089 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6090
6091 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6092 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6093 webrtc::RtpParameters rtp_parameters =
6094 channel_->GetRtpReceiveParameters(last_ssrc_);
6095 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6096 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6097 ASSERT_EQ(2u, cfg.decoders.size());
6098 EXPECT_EQ(101, cfg.decoders[0].payload_type);
6099 EXPECT_EQ("H264", cfg.decoders[0].payload_name);
magjed5dfac562016-11-25 03:56:37 -08006100 const auto it0 =
6101 cfg.decoders[0].codec_params.find(kH264FmtpSpropParameterSets);
6102 ASSERT_TRUE(it0 != cfg.decoders[0].codec_params.end());
6103 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006104
6105 EXPECT_EQ(102, cfg.decoders[1].payload_type);
6106 EXPECT_EQ("H264", cfg.decoders[1].payload_name);
magjed5dfac562016-11-25 03:56:37 -08006107 const auto it1 =
6108 cfg.decoders[1].codec_params.find(kH264FmtpSpropParameterSets);
6109 ASSERT_TRUE(it1 != cfg.decoders[1].codec_params.end());
6110 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006111}
6112
sakal1fd95952016-06-22 00:46:15 -07006113// Test that RtpParameters for receive stream has one encoding and it has
6114// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006115TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006116 AddRecvStream();
6117
6118 webrtc::RtpParameters rtp_parameters =
6119 channel_->GetRtpReceiveParameters(last_ssrc_);
6120 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006121 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006122}
6123
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006124// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006125TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006126 AddRecvStream();
6127 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006128 parameters.codecs.push_back(GetEngineCodec("VP8"));
6129 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006130 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6131
6132 webrtc::RtpParameters initial_params =
6133 channel_->GetRtpReceiveParameters(last_ssrc_);
6134
6135 // We should be able to set the params we just got.
6136 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6137
6138 // ... And this shouldn't change the params returned by
6139 // GetRtpReceiveParameters.
6140 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006141}
6142
deadbeef3bc15102017-04-20 19:25:07 -07006143// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6144// aren't signaled. It should always return an empty "RtpEncodingParameters",
6145// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006146TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006147 // Call necessary methods to configure receiving a default stream as
6148 // soon as it arrives.
6149 cricket::VideoRecvParameters parameters;
6150 parameters.codecs.push_back(GetEngineCodec("VP8"));
6151 parameters.codecs.push_back(GetEngineCodec("VP9"));
6152 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6153
6154 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6155 // stream. Should return nothing.
6156 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6157
6158 // Set a sink for an unsignaled stream.
6159 cricket::FakeVideoRenderer renderer;
6160 // Value of "0" means "unsignaled stream".
6161 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6162
6163 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6164 // in this method means "unsignaled stream".
6165 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6166 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6167 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6168
6169 // Receive VP8 packet.
6170 uint8_t data[kMinRtpPacketLen];
6171 cricket::RtpHeader rtpHeader;
6172 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6173 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6174 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6175 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6176 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6177 rtc::PacketTime packet_time;
6178 channel_->OnPacketReceived(&packet, packet_time);
6179
6180 // The |ssrc| member should still be unset.
6181 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6182 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6183 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6184}
6185
eladalonf1841382017-06-12 01:16:46 -07006186void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006187 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006188 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006189
6190 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006191 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006192 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006193 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006194
6195 if (receiver_first) {
6196 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6197 std::vector<FakeVideoReceiveStream*> receive_streams =
6198 fake_call_->GetVideoReceiveStreams();
6199 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006200 // Default local SSRC when we have no sender.
6201 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6202 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006203 }
6204 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6205 if (!receiver_first)
6206 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6207 std::vector<FakeVideoReceiveStream*> receive_streams =
6208 fake_call_->GetVideoReceiveStreams();
6209 ASSERT_EQ(1u, receive_streams.size());
6210 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006211
6212 // Removing first sender should fall back to another (in this case the second)
6213 // local send stream's SSRC.
6214 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6215 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006216 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006217 ASSERT_EQ(1u, receive_streams.size());
6218 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6219
6220 // Removing the last sender should fall back to default local SSRC.
6221 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006222 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006223 ASSERT_EQ(1u, receive_streams.size());
6224 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6225 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006226}
6227
eladalonf1841382017-06-12 01:16:46 -07006228TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006229 TestReceiverLocalSsrcConfiguration(false);
6230}
6231
eladalonf1841382017-06-12 01:16:46 -07006232TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006233 TestReceiverLocalSsrcConfiguration(true);
6234}
6235
eladalonf1841382017-06-12 01:16:46 -07006236class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006237 public:
eladalonf1841382017-06-12 01:16:46 -07006238 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006239 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006240 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6241 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006242 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006243 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006244 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006245 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006246 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006247
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006248 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006249 encoder_factory_->AddSupportedVideoCodecType("VP8");
nisse51542be2016-02-12 02:27:06 -08006250 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08006251 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006252 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006253 last_ssrc_ = 123;
6254 }
6255
6256 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006257 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006258 int capture_width,
6259 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006260 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006261 size_t expected_num_streams,
6262 bool screenshare,
6263 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006264 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006265 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006266 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006267 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006268
Peter Boström0c4e06b2015-10-07 12:23:21 +02006269 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006270 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006271 ssrcs.resize(num_configured_streams);
6272
sprangf24a0642017-02-28 13:23:26 -08006273 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006274 // Send a full-size frame to trigger a stream reconfiguration to use all
6275 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006276 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006277 VideoOptions options;
6278 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006279 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006280 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006281 // Fetch the latest stream since SetVideoSend() may recreate it if the
6282 // screen content setting is changed.
6283 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006284 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006285 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006286 cricket::VideoFormat::FpsToInterval(30),
6287 cricket::FOURCC_I420)));
6288 channel_->SetSend(true);
6289 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006290
Zach Stein3ca452b2018-01-18 10:01:24 -08006291 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6292 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6293
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006294 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6295 ASSERT_EQ(expected_num_streams, video_streams.size());
6296
sprang429600d2017-01-26 06:12:26 -08006297 std::vector<webrtc::VideoStream> expected_streams;
6298 if (conference_mode) {
6299 expected_streams = GetSimulcastConfig(
6300 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006301 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006302 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006303 if (screenshare) {
6304 for (const webrtc::VideoStream& stream : expected_streams) {
6305 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006306 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6307 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006308 }
6309 }
sprang429600d2017-01-26 06:12:26 -08006310 } else {
6311 webrtc::VideoStream stream;
6312 stream.width = capture_width;
6313 stream.height = capture_height;
6314 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006315 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006316 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006317 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006318 stream.max_qp = kDefaultQpMax;
6319 expected_streams.push_back(stream);
6320 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006321
6322 ASSERT_EQ(expected_streams.size(), video_streams.size());
6323
6324 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006325 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006326 for (size_t i = 0; i < num_streams; ++i) {
6327 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6328 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6329
6330 EXPECT_GT(video_streams[i].max_framerate, 0);
6331 EXPECT_EQ(expected_streams[i].max_framerate,
6332 video_streams[i].max_framerate);
6333
6334 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6335 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6336 video_streams[i].min_bitrate_bps);
6337
6338 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6339 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6340 video_streams[i].target_bitrate_bps);
6341
6342 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6343 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6344 video_streams[i].max_bitrate_bps);
6345
6346 EXPECT_GT(video_streams[i].max_qp, 0);
6347 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6348
Sergey Silkina796a7e2018-03-01 15:11:29 +01006349 EXPECT_EQ(conference_mode,
6350 expected_streams[i].num_temporal_layers.has_value());
6351
6352 if (conference_mode) {
6353 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6354 video_streams[i].num_temporal_layers);
6355 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006356
6357 if (i == num_streams - 1) {
6358 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6359 } else {
6360 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6361 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006362 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006363
Niels Möllerff40b142018-04-09 08:49:14 +02006364 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006365 }
6366
6367 FakeVideoSendStream* AddSendStream() {
6368 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6369 }
6370
6371 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006372 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006373 EXPECT_TRUE(channel_->AddSendStream(sp));
6374 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006375 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006376 EXPECT_EQ(num_streams + 1, streams.size());
6377 return streams[streams.size() - 1];
6378 }
6379
6380 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006381 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006382 }
6383
6384 FakeVideoReceiveStream* AddRecvStream() {
6385 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6386 }
6387
6388 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006389 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006390 EXPECT_TRUE(channel_->AddRecvStream(sp));
6391 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006392 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006393 EXPECT_EQ(num_streams + 1, streams.size());
6394 return streams[streams.size() - 1];
6395 }
6396
skvlad11a9cbf2016-10-07 11:53:05 -07006397 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006398 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006399 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6400 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006401 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006402 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006403 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006404};
6405
eladalonf1841382017-06-12 01:16:46 -07006406TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006407 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6408 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006409}
6410
eladalonf1841382017-06-12 01:16:46 -07006411TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006412 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6413 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006414}
6415
6416// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006417TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006418 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6419 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006420}
sprang429600d2017-01-26 06:12:26 -08006421
eladalonf1841382017-06-12 01:16:46 -07006422TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006423 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6424 false);
6425}
6426
eladalonf1841382017-06-12 01:16:46 -07006427TEST_F(WebRtcVideoChannelSimulcastTest,
sprang429600d2017-01-26 06:12:26 -08006428 SetSendCodecsForConferenceModeScreenshare) {
6429 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6430 true);
6431}
6432
eladalonf1841382017-06-12 01:16:46 -07006433TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006434 webrtc::test::ScopedFieldTrials override_field_trials_(
6435 "WebRTC-SimulcastScreenshare/Enabled/");
6436 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6437 true);
6438}
6439
eladalonf1841382017-06-12 01:16:46 -07006440TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006441 NoSimulcastScreenshareWithoutConference) {
6442 webrtc::test::ScopedFieldTrials override_field_trials_(
6443 "WebRTC-SimulcastScreenshare/Enabled/");
6444 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6445 false);
6446}
6447
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00006448} // namespace cricket