blob: a5a4f98a7497dd62bd307b9eceb99de5c08fb77e [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Seth Hampson24722b32017-12-22 09:36:42 -080017#include "api/rtpparameters.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070018#include "api/test/mock_video_decoder_factory.h"
19#include "api/test/mock_video_encoder_factory.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020020#include "api/video_codecs/builtin_video_decoder_factory.h"
21#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020022#include "api/video_codecs/sdp_video_format.h"
23#include "api/video_codecs/video_decoder_factory.h"
24#include "api/video_codecs/video_encoder.h"
25#include "api/video_codecs/video_encoder_factory.h"
26#include "call/flexfec_receive_stream.h"
27#include "common_video/h264/profile_level_id.h"
28#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020029#include "media/base/fakenetworkinterface.h"
30#include "media/base/fakevideocapturer.h"
31#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020032#include "media/base/mediaconstants.h"
33#include "media/base/rtputils.h"
34#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020035#include "media/engine/constants.h"
36#include "media/engine/fakewebrtccall.h"
37#include "media/engine/fakewebrtcvideoengine.h"
38#include "media/engine/simulcast.h"
39#include "media/engine/webrtcvideoengine.h"
40#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020041#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020042#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020043#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020045#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "rtc_base/stringutils.h"
47#include "test/field_trial.h"
48#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000049
Tommi85959932018-02-07 19:26:06 +010050using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010051using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070052using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010053using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070054
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000055namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000056static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000057
noahricd10a68e2015-07-10 11:27:55 -070058static const uint8_t kRedRtxPayloadType = 125;
59
Niels Möller6557d0c2018-04-11 15:18:34 +020060static const uint32_t kTimeout = 5000U;
61static const uint32_t kDefaultReceiveSsrc = 0;
62static const uint32_t kSsrc = 1234u;
63static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
64static const int kVideoWidth = 640;
65static const int kVideoHeight = 360;
66static const int kFramerate = 30;
67
Peter Boström0c4e06b2015-10-07 12:23:21 +020068static const uint32_t kSsrcs1[] = {1};
69static const uint32_t kSsrcs3[] = {1, 2, 3};
70static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080071static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020072static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080073static const uint32_t kDefaultRecvSsrc = 0;
74
pbos@webrtc.org3c107582014-07-20 15:27:35 +000075static const char kUnsupportedExtensionName[] =
76 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000077
magjed509e4fe2016-11-18 01:34:11 -080078cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
79 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020080 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080081}
82
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000083void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
84 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
85 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
86 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
87 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
88 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
89 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080091 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000093 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
94}
95
magjed725e4842016-11-16 00:48:13 -080096// Return true if any codec in |codecs| is an RTX codec with associated payload
97// type |payload_type|.
98bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
99 int payload_type) {
100 for (const cricket::VideoCodec& codec : codecs) {
101 int associated_payload_type;
102 if (cricket::CodecNamesEq(codec.name.c_str(), "rtx") &&
103 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
104 &associated_payload_type) &&
105 associated_payload_type == payload_type) {
106 return true;
107 }
108 }
109 return false;
110}
111
nisseca5706d2017-09-11 02:32:16 -0700112// TODO(nisse): Duplicated in call.cc.
113const int* FindKeyByValue(const std::map<int, int>& m, int v) {
114 for (const auto& kv : m) {
115 if (kv.second == v)
116 return &kv.first;
117 }
118 return nullptr;
119}
120
Yves Gerey665174f2018-06-19 15:03:05 +0200121bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
122 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700123 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
124 payload_type) != nullptr;
125}
126
127// Check that there's an Rtx payload type for each decoder.
128bool VerifyRtxReceiveAssociations(
129 const webrtc::VideoReceiveStream::Config& config) {
130 for (const auto& decoder : config.decoders) {
131 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
132 return false;
133 }
134 return true;
135}
136
brandtrffc61182016-11-28 06:02:22 -0800137rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700138 int width,
139 int height) {
140 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
141 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800142 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700143 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000144}
145
Shao Changbine62202f2015-04-21 20:24:50 +0800146void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
147 const std::map<int, int>& rtx_types) {
148 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200149 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800150 EXPECT_TRUE(it != rtx_types.end() &&
151 it->second == config.rtp.rtx.payload_type);
152
brandtrb5f2c3f2016-10-04 23:28:39 -0700153 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
154 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800155 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700156 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800157 }
158}
kthelgason2bc68642017-02-07 07:02:22 -0800159
160cricket::MediaConfig GetMediaConfig() {
161 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100162 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800163 return media_config;
164}
nisse26e3abb2017-08-25 04:44:25 -0700165
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200166// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
167int GetMaxDefaultBitrateBps(size_t width, size_t height) {
168 if (width * height <= 320 * 240) {
169 return 600000;
170 } else if (width * height <= 640 * 480) {
171 return 1700000;
172 } else if (width * height <= 960 * 540) {
173 return 2000000;
174 } else {
175 return 2500000;
176 }
177}
178
Niels Möller731a2c22018-07-30 15:08:07 +0200179class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
180 public:
181 MOCK_METHOD2(AddOrUpdateSink,
182 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
183 const rtc::VideoSinkWants& wants));
184 MOCK_METHOD1(RemoveSink,
185 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
186};
187
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000188} // namespace
189
Yves Gerey665174f2018-06-19 15:03:05 +0200190#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200191 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200192 EXPECT_EQ((w), renderer_.width()); \
193 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200194 EXPECT_EQ(0, renderer_.errors());
195
Yves Gerey665174f2018-06-19 15:03:05 +0200196#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200197 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200198 EXPECT_EQ((w), (r).width()); \
199 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ(0, (r).errors());
201
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000202namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700203class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000204 public:
eladalonf1841382017-06-12 01:16:46 -0700205 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
206 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700207 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700208 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200209 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
210 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200211 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200212 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200213 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200214 decoder_factory_)) {
215 // Ensure fake clock doesn't return 0, which will cause some initializations
216 // fail inside RTP senders.
217 fake_clock_.AdvanceTimeMicros(1);
218 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000219
220 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200221 void AssignDefaultAptRtxTypes();
222 void AssignDefaultCodec();
223
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100224 // Find the index of the codec in the engine with the given name. The codec
225 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100226 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100227
magjed509e4fe2016-11-18 01:34:11 -0800228 // Find the codec in the engine with the given name. The codec must be
229 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100230 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800231
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200232 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000233
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200234 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000235 const std::vector<VideoCodec>& codecs);
236
Peter Boströme4499152016-02-05 11:13:28 +0100237 void TestExtendedEncoderOveruse(bool use_external_encoder);
238
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200239 // Has to be the first one, so it is initialized before the call or there is a
240 // race condition in the clock access.
241 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700242 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700243 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700244 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000245 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800246 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200247 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
248 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700249 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000250 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800251 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000252};
253
eladalonf1841382017-06-12 01:16:46 -0700254TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200255 encoder_factory_->AddSupportedVideoCodecType("VP8");
256 AssignDefaultCodec();
257
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000258 std::vector<VideoCodec> engine_codecs = engine_.codecs();
259 for (size_t i = 0; i < engine_codecs.size(); ++i) {
260 if (engine_codecs[i].name != kRtxCodecName)
261 continue;
262 int associated_payload_type;
263 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000264 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000265 EXPECT_EQ(default_codec_.id, associated_payload_type);
266 return;
267 }
268 FAIL() << "No RTX codec found among default codecs.";
269}
270
eladalonf1841382017-06-12 01:16:46 -0700271TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100272 RtpCapabilities capabilities = engine_.GetCapabilities();
273 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700274 for (const RtpExtension& extension : capabilities.header_extensions) {
275 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
276 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000277 return;
278 }
279 }
280 FAIL() << "Timestamp offset extension not in header-extension list.";
281}
282
eladalonf1841382017-06-12 01:16:46 -0700283TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100284 RtpCapabilities capabilities = engine_.GetCapabilities();
285 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700286 for (const RtpExtension& extension : capabilities.header_extensions) {
287 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
288 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000289 return;
290 }
291 }
292 FAIL() << "Absolute Sender Time extension not in header-extension list.";
293}
294
eladalonf1841382017-06-12 01:16:46 -0700295TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100296 RtpCapabilities capabilities = engine_.GetCapabilities();
297 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700298 for (const RtpExtension& extension : capabilities.header_extensions) {
299 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
300 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700301 return;
302 }
303 }
304 FAIL() << "Transport sequence number extension not in header-extension list.";
305}
306
eladalonf1841382017-06-12 01:16:46 -0700307TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100308 RtpCapabilities capabilities = engine_.GetCapabilities();
309 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700310 for (const RtpExtension& extension : capabilities.header_extensions) {
311 if (extension.uri == RtpExtension::kVideoRotationUri) {
312 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700313 return;
314 }
315 }
316 FAIL() << "Video Rotation extension not in header-extension list.";
317}
318
eladalonf1841382017-06-12 01:16:46 -0700319TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200320 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700321 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200322 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700323
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200324 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700325
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200326 std::unique_ptr<VideoMediaChannel> channel(
327 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700328 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
329
330 // Add CVO extension.
331 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800332 cricket::VideoSendParameters parameters;
333 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200334 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700335 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200336 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700337
Niels Möller731a2c22018-07-30 15:08:07 +0200338 EXPECT_CALL(
339 video_source,
340 AddOrUpdateSink(testing::_,
341 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700342 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200343 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700344
345 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200346 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347
348 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200349 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200350 EXPECT_CALL(
351 video_source,
352 AddOrUpdateSink(testing::_,
353 Field(&rtc::VideoSinkWants::rotation_applied, true)));
354
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200355 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700356}
357
eladalonf1841382017-06-12 01:16:46 -0700358TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200359 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800360 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200361 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800362
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200363 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800364
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200365 std::unique_ptr<VideoMediaChannel> channel(
366 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800367 // Add CVO extension.
368 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800369 cricket::VideoSendParameters parameters;
370 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800371 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700372 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800373 EXPECT_TRUE(channel->SetSendParameters(parameters));
374 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
375
Niels Möller731a2c22018-07-30 15:08:07 +0200376 // Set source.
377 EXPECT_CALL(
378 video_source,
379 AddOrUpdateSink(testing::_,
380 Field(&rtc::VideoSinkWants::rotation_applied, false)));
381 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800382}
383
eladalonf1841382017-06-12 01:16:46 -0700384TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200385 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700386
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200387 encoder_factory_->AddSupportedVideoCodecType("VP8");
388 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700389
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200390 std::unique_ptr<VideoMediaChannel> channel(
391 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
393
394 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200395 EXPECT_CALL(
396 video_source,
397 AddOrUpdateSink(testing::_,
398 Field(&rtc::VideoSinkWants::rotation_applied, true)));
399 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700400
perkjcaafdba2016-03-20 07:34:29 -0700401 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200402 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700403
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700404 // Add CVO extension.
405 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800406 cricket::VideoSendParameters parameters;
407 parameters.codecs.push_back(GetEngineCodec("VP8"));
408 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200409 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700410 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700411 // Also remove the first codec to trigger a codec change as well.
412 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200413 EXPECT_CALL(
414 video_source,
415 AddOrUpdateSink(testing::_,
416 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200417 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700418
419 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200420 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700421
422 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200423 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200424 EXPECT_CALL(
425 video_source,
426 AddOrUpdateSink(testing::_,
427 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200428 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700429}
430
eladalonf1841382017-06-12 01:16:46 -0700431TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200432 encoder_factory_->AddSupportedVideoCodecType("VP8");
433
kwiberg686a8ef2016-02-26 03:00:35 -0800434 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800435 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000436
437 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
438
439 EXPECT_FALSE(channel->SetSend(true))
440 << "Channel should not start without codecs.";
441 EXPECT_TRUE(channel->SetSend(false))
442 << "Channel should be stoppable even without set codecs.";
443}
444
eladalonf1841382017-06-12 01:16:46 -0700445TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200446 encoder_factory_->AddSupportedVideoCodecType("VP8");
447
kwiberg686a8ef2016-02-26 03:00:35 -0800448 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800449 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000450 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
451 VideoMediaInfo info;
452 channel->GetStats(&info);
453}
454
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200455TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200456 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000457
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200458 std::unique_ptr<VideoMediaChannel> channel(
459 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800460 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000461
462 EXPECT_TRUE(
463 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200464 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000465 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100466 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200467 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000468 EXPECT_EQ(cricket::CS_RUNNING,
469 capturer.Start(capturer.GetSupportedFormats()->front()));
470 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100471 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200472 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
473 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000474 kTimeout);
475
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200476 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100477 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000478
479 // Setting codecs of the same type should not reallocate any encoders
480 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800481 cricket::VideoSendParameters parameters;
482 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200483 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200484 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000485
486 // Remove stream previously added to free the external encoder instance.
487 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200488 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000489}
490
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200491// Test that when an encoder factory supports H264, we add an RTX
492// codec for it.
493// TODO(deadbeef): This test should be updated if/when we start
494// adding RTX codecs for unrecognized codec names.
495TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800496 using webrtc::H264::ProfileLevelIdToString;
497 using webrtc::H264::ProfileLevelId;
498 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200499 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
500 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800501 *ProfileLevelIdToString(
502 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200503 webrtc::SdpVideoFormat h264_constrained_high("H264");
504 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800505 *ProfileLevelIdToString(
506 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200507 webrtc::SdpVideoFormat h264_high("H264");
508 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800509 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
510
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200511 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
512 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
513 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700514
magjed725e4842016-11-16 00:48:13 -0800515 // First figure out what payload types the test codecs got assigned.
516 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800517 // Now search for RTX codecs for them. Expect that they all have associated
518 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800519 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200520 codecs,
521 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
522 ->id));
magjed725e4842016-11-16 00:48:13 -0800523 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200524 codecs,
525 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
526 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800527 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200528 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700529}
530
Peter Boström12996152016-05-14 02:03:18 +0200531#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700532TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200533 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100534
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200535 std::unique_ptr<VideoMediaChannel> channel(
536 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100537
538 EXPECT_TRUE(
539 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
540}
Peter Boström12996152016-05-14 02:03:18 +0200541#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100542
eladalonf1841382017-06-12 01:16:46 -0700543TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200544 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100545 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200546 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200547 std::unique_ptr<VideoMediaChannel> channel(
548 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700549
550 EXPECT_TRUE(
551 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
552
Tommi85959932018-02-07 19:26:06 +0100553 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200554 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700555 capturer.Start(cricket::VideoFormat(1280, 720,
556 cricket::VideoFormat::FpsToInterval(60),
557 cricket::FOURCC_I420));
558 channel->SetSend(true);
559
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200560 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700561
562 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700563 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700564 for (int i = 0; i < 10; i++) {
565 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700566 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700567 int64_t interval = timestamp - last_timestamp;
568
569 // Precision changes from nanosecond to millisecond.
570 // Allow error to be no more than 1.
571 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
572
573 last_timestamp = timestamp;
574 }
575
576 capturer.Start(cricket::VideoFormat(1280, 720,
577 cricket::VideoFormat::FpsToInterval(30),
578 cricket::FOURCC_I420));
579
580 EXPECT_TRUE(capturer.CaptureFrame());
581 last_timestamp = stream->GetLastTimestamp();
582 for (int i = 0; i < 10; i++) {
583 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700584 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700585 int64_t interval = timestamp - last_timestamp;
586
587 // Precision changes from nanosecond to millisecond.
588 // Allow error to be no more than 1.
589 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
590
591 last_timestamp = timestamp;
592 }
593
594 // Remove stream previously added to free the external encoder instance.
595 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
596}
597
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200598void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
599 std::vector<VideoCodec> engine_codecs = engine_.codecs();
600 RTC_DCHECK(!engine_codecs.empty());
601 for (const cricket::VideoCodec& codec : engine_codecs) {
602 if (codec.name == "rtx") {
603 int associated_payload_type;
604 if (codec.GetParam(kCodecParamAssociatedPayloadType,
605 &associated_payload_type)) {
606 default_apt_rtx_types_[associated_payload_type] = codec.id;
607 }
608 }
609 }
610}
611
612void WebRtcVideoEngineTest::AssignDefaultCodec() {
613 std::vector<VideoCodec> engine_codecs = engine_.codecs();
614 RTC_DCHECK(!engine_codecs.empty());
615 bool codec_set = false;
616 for (const cricket::VideoCodec& codec : engine_codecs) {
617 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
618 codec.name != "ulpfec") {
619 default_codec_ = codec;
620 codec_set = true;
621 }
622 }
623
624 RTC_DCHECK(codec_set);
625}
626
Oleh Prypina40f8242017-12-21 13:32:23 +0100627size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
628 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100629 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
630 for (size_t i = 0; i < codecs.size(); ++i) {
631 const cricket::VideoCodec engine_codec = codecs[i];
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200632 if (!CodecNamesEq(name, engine_codec.name))
633 continue;
634 // The tests only use H264 Constrained Baseline. Make sure we don't return
635 // an internal H264 codec from the engine with a different H264 profile.
636 if (CodecNamesEq(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200637 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200638 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
639 if (profile_level_id->profile !=
640 webrtc::H264::kProfileConstrainedBaseline) {
641 continue;
642 }
643 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100644 return i;
magjed509e4fe2016-11-18 01:34:11 -0800645 }
646 // This point should never be reached.
647 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100648 return -1;
649}
650
651cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
652 const std::string& name) const {
653 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800654}
655
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200656VideoMediaChannel*
657WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
buildbot@webrtc.org1ecbe452014-10-14 20:29:28 +0000658 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800659 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200660 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800661 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200662 for (const webrtc::SdpVideoFormat& format :
663 encoder_factory_->GetSupportedFormats()) {
664 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
665 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
666 engine_codec) == parameters.codecs.end()) {
667 parameters.codecs.push_back(engine_codec);
668 }
669 }
magjed509e4fe2016-11-18 01:34:11 -0800670
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200671 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000672
673 return channel;
674}
675
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200676VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000677 const std::vector<VideoCodec>& codecs) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000678 VideoMediaChannel* channel =
kthelgason2bc68642017-02-07 07:02:22 -0800679 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200680 cricket::VideoRecvParameters parameters;
681 parameters.codecs = codecs;
682 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000683
684 return channel;
685}
686
eladalonf1841382017-06-12 01:16:46 -0700687TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200688 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000689
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200690 std::unique_ptr<VideoMediaChannel> channel(
691 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000692
Peter Boström0c4e06b2015-10-07 12:23:21 +0200693 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000694
Yves Gerey665174f2018-06-19 15:03:05 +0200695 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000696 EXPECT_TRUE(channel->SetSend(true));
697
Tommi85959932018-02-07 19:26:06 +0100698 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200699 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000700 EXPECT_EQ(cricket::CS_RUNNING,
701 capturer.Start(capturer.GetSupportedFormats()->front()));
702 EXPECT_TRUE(capturer.CaptureFrame());
703
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200704 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000705
706 // Verify that encoders are configured for simulcast through adapter
707 // (increasing resolution and only configured to send one stream each).
708 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200709 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
710 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000711 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200712 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000713 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
714 EXPECT_GT(codec_settings.width, prev_width);
715 prev_width = codec_settings.width;
716 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000717
Niels Möllerff40b142018-04-09 08:49:14 +0200718 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000719
720 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200721 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000722}
723
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200724TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
725 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200726 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000727
Niels Möller4db138e2018-04-19 09:04:13 +0200728 // Set capturer.
729 FakeVideoCapturerWithTaskQueue capturer;
730 EXPECT_EQ(cricket::CS_RUNNING,
731 capturer.Start(capturer.GetSupportedFormats()->front()));
732
Anders Carlsson67537952018-05-03 11:28:29 +0200733 std::unique_ptr<VideoMediaChannel> channel(
734 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
735 cricket::VideoSendParameters parameters;
736 parameters.codecs.push_back(GetEngineCodec("H264"));
737 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000738
739 EXPECT_TRUE(
740 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200741 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
742 // Sending one frame will have allocate the encoder.
743 EXPECT_TRUE(capturer.CaptureFrame());
744
745 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000746
Anders Carlsson67537952018-05-03 11:28:29 +0200747 cricket::VideoSendParameters new_parameters;
748 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
749 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200750
751 // Sending one frame will switch encoder.
752 EXPECT_TRUE(capturer.CaptureFrame());
753
Anders Carlsson8a150d92018-05-14 12:40:04 +0200754 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000755}
756
eladalonf1841382017-06-12 01:16:46 -0700757TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000758 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200759 encoder_factory_->AddSupportedVideoCodecType("VP8");
760 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000761
kwiberg686a8ef2016-02-26 03:00:35 -0800762 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800763 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800764 cricket::VideoSendParameters parameters;
765 parameters.codecs.push_back(GetEngineCodec("VP8"));
766 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000767
Peter Boström0c4e06b2015-10-07 12:23:21 +0200768 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000769
Yves Gerey665174f2018-06-19 15:03:05 +0200770 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000771 EXPECT_TRUE(channel->SetSend(true));
772
773 // Send a fake frame, or else the media engine will configure the simulcast
774 // encoder adapter at a low-enough size that it'll only create a single
775 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100776 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200777 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000778 EXPECT_EQ(cricket::CS_RUNNING,
779 capturer.Start(capturer.GetSupportedFormats()->front()));
780 EXPECT_TRUE(capturer.CaptureFrame());
781
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200782 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
783 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000784 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200785 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000786
787 channel.reset();
788 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200789 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000790}
791
eladalonf1841382017-06-12 01:16:46 -0700792TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000793 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200794 encoder_factory_->AddSupportedVideoCodecType("VP8");
795 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000796
kwiberg686a8ef2016-02-26 03:00:35 -0800797 std::unique_ptr<VideoMediaChannel> channel(
kthelgason2bc68642017-02-07 07:02:22 -0800798 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800799 cricket::VideoSendParameters parameters;
800 parameters.codecs.push_back(GetEngineCodec("H264"));
801 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000802
803 EXPECT_TRUE(
804 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100805
806 // Send a frame of 720p. This should trigger a "real" encoder initialization.
807 cricket::VideoFormat format(
808 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100809 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200810 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100811 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
812 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200813 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
814 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200815 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000816 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200817 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000818
819 channel.reset();
820 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200821 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000822}
823
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200824TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
825 webrtc::test::ScopedFieldTrials override_field_trials_(
826 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200827 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700828
Anders Carlsson67537952018-05-03 11:28:29 +0200829 std::unique_ptr<VideoMediaChannel> channel(
830 engine_.CreateChannel(call_.get(), GetMediaConfig(), VideoOptions()));
831 cricket::VideoSendParameters parameters;
832 parameters.codecs.push_back(GetEngineCodec("H264"));
833 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700834
Peter Boström0c4e06b2015-10-07 12:23:21 +0200835 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700836 EXPECT_TRUE(
837 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100838
839 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700840 cricket::VideoFormat format(
841 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100842 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200843 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100844 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
845 EXPECT_TRUE(capturer.CaptureFrame());
846
Niels Möller4db138e2018-04-19 09:04:13 +0200847 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200848 ASSERT_EQ(1u, encoder_factory_->encoders().size());
849 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
850 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700851 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200852 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200853 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700854}
855
brandtrffc61182016-11-28 06:02:22 -0800856// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700857// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800858//
859// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700860TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800861 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200862 encoder_factory_->AddSupportedVideoCodecType("VP8");
863
brandtrffc61182016-11-28 06:02:22 -0800864 auto is_flexfec = [](const VideoCodec& codec) {
865 if (codec.name == "flexfec-03")
866 return true;
867 return false;
868 };
869
870 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800871 const std::vector<VideoCodec> codecs_before = engine_.codecs();
872 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
873 codecs_before.end(), is_flexfec));
874
875 // FlexFEC is active with field trial.
876 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800877 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800878 const std::vector<VideoCodec> codecs_after = engine_.codecs();
879 EXPECT_NE(codecs_after.end(),
880 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
881}
882
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200883// Test that codecs are added in the order they are reported from the factory.
884TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
885 encoder_factory_->AddSupportedVideoCodecType("VP8");
886 const char* kFakeCodecName = "FakeCodec";
887 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000888
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200889 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100890 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200891 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
892 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000893}
894
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200895// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800896// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200897TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100898 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
899 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100900
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100901 // Set up external encoder factory with first codec, and initialize engine.
902 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
903
brandtrffc61182016-11-28 06:02:22 -0800904 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800905
906 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100907 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800908 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200909 // The codec itself and RTX should have been added.
910 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100911
912 // Check that both fake codecs are present and that the second fake codec
913 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100914 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
915 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100916 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800917}
918
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200919TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
920 const char* kFakeCodecName = "FakeCodec";
921 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
922
923 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
924 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
925}
926
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200927TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
928 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200929 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200930 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800931 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000932
kwiberg686a8ef2016-02-26 03:00:35 -0800933 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200934 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000935
936 EXPECT_TRUE(
937 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200938 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000939
940 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200941 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200942 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000943
944 // Remove stream previously added to free the external decoder instance.
945 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200946 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000947}
948
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200949// Verifies that we can set up decoders.
950TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000951 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
952 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
953 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
954 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200955 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200956 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000957 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800958 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000959
kwiberg686a8ef2016-02-26 03:00:35 -0800960 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200961 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000962
963 EXPECT_TRUE(
964 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200965 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000966}
967
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200968TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
969 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
970 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
971 WebRtcVideoEngine engine(std::move(encoder_factory),
972 std::move(decoder_factory));
973 EXPECT_EQ(0u, engine.codecs().size());
974}
975
976TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
977 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700978 webrtc::MockVideoEncoderFactory* encoder_factory =
979 new webrtc::MockVideoEncoderFactory();
980 webrtc::MockVideoDecoderFactory* decoder_factory =
981 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +0200982 WebRtcVideoEngine engine(
983 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
984 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
985 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
986 EXPECT_EQ(0u, engine.codecs().size());
987 EXPECT_CALL(*encoder_factory, Die());
988 EXPECT_CALL(*decoder_factory, Die());
989}
990
991// Test full behavior in the video engine when video codec factories of the new
992// type are injected supporting the single codec Vp8. Check the returned codecs
993// from the engine and that we will create a Vp8 encoder and decoder using the
994// new factories.
995TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
996 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -0700997 webrtc::MockVideoEncoderFactory* encoder_factory =
998 new webrtc::MockVideoEncoderFactory();
999 webrtc::MockVideoDecoderFactory* decoder_factory =
1000 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001001 WebRtcVideoEngine engine(
1002 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1003 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1004 const webrtc::SdpVideoFormat vp8_format("VP8");
1005 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1006 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1007 .WillRepeatedly(testing::Return(supported_formats));
1008
1009 // Verify the codecs from the engine.
1010 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001011 // Verify default codecs has been added correctly.
1012 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001013 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001014
1015 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001016 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001017 int vp8_associated_payload;
1018 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1019 &vp8_associated_payload));
1020 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1021
1022 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1023
1024 // RTX codec for RED.
1025 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1026 int red_associated_payload;
1027 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1028 &red_associated_payload));
1029 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1030
1031 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1032
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001033 int associated_payload_type;
1034 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1035 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1036 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1037 // Verify default parameters has been added to the VP8 codec.
1038 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1039
1040 // Mock encoder creation. |engine| take ownership of the encoder.
1041 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1042 codec_info.is_hardware_accelerated = false;
1043 codec_info.has_internal_source = false;
1044 const webrtc::SdpVideoFormat format("VP8");
1045 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1046 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001047 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möller4db138e2018-04-19 09:04:13 +02001048 rtc::Event encoder_created(false, false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001049 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001050 .WillOnce(
1051 ::testing::DoAll(::testing::InvokeWithoutArgs(
1052 [&encoder_created]() { encoder_created.Set(); }),
1053 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001054
1055 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001056 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1058 .WillOnce(testing::Return(decoder));
1059
1060 // Create a call.
1061 webrtc::RtcEventLogNullImpl event_log;
1062 std::unique_ptr<webrtc::Call> call(
1063 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1064
1065 // Create send channel.
1066 const int send_ssrc = 123;
1067 std::unique_ptr<VideoMediaChannel> send_channel(
1068 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1069 cricket::VideoSendParameters send_parameters;
1070 send_parameters.codecs.push_back(engine_codecs.at(0));
1071 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1072 send_channel->OnReadyToSend(true);
1073 EXPECT_TRUE(
1074 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1075 EXPECT_TRUE(send_channel->SetSend(true));
1076
Niels Möller4db138e2018-04-19 09:04:13 +02001077 // Set capturer.
1078 FakeVideoCapturerWithTaskQueue capturer;
1079 EXPECT_EQ(cricket::CS_RUNNING,
1080 capturer.Start(capturer.GetSupportedFormats()->front()));
1081 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1082 // Sending one frame will allocate the encoder.
1083 EXPECT_TRUE(capturer.CaptureFrame());
1084 encoder_created.Wait(kTimeout);
1085
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001086 // Create recv channel.
1087 const int recv_ssrc = 321;
1088 std::unique_ptr<VideoMediaChannel> recv_channel(
1089 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1090 cricket::VideoRecvParameters recv_parameters;
1091 recv_parameters.codecs.push_back(engine_codecs.at(0));
1092 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1093 EXPECT_TRUE(recv_channel->AddRecvStream(
1094 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1095
1096 // Remove streams previously added to free the encoder and decoder instance.
1097 EXPECT_CALL(*encoder_factory, Die());
1098 EXPECT_CALL(*decoder_factory, Die());
1099 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1100 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1101}
1102
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001103// Test behavior when decoder factory fails to create a decoder (returns null).
1104TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1105 // |engine| take ownership of the factories.
1106 webrtc::MockVideoEncoderFactory* encoder_factory =
1107 new testing::StrictMock<webrtc::MockVideoEncoderFactory>();
1108 webrtc::MockVideoDecoderFactory* decoder_factory =
1109 new testing::StrictMock<webrtc::MockVideoDecoderFactory>();
1110 WebRtcVideoEngine engine(
1111 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
1112 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
1113 const webrtc::SdpVideoFormat vp8_format("VP8");
1114 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1115 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1116 .WillRepeatedly(testing::Return(supported_formats));
1117
1118 // Decoder creation fails.
1119 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1120 .WillOnce(testing::Return(nullptr));
1121
1122 // Create a call.
1123 webrtc::RtcEventLogNullImpl event_log;
1124 std::unique_ptr<webrtc::Call> call(
1125 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1126
1127 // Create recv channel.
1128 const int recv_ssrc = 321;
1129 std::unique_ptr<VideoMediaChannel> recv_channel(
1130 engine.CreateChannel(call.get(), GetMediaConfig(), VideoOptions()));
1131 cricket::VideoRecvParameters recv_parameters;
1132 recv_parameters.codecs.push_back(engine.codecs().front());
1133 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1134 EXPECT_TRUE(recv_channel->AddRecvStream(
1135 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1136
1137 // Remove streams previously added to free the encoder and decoder instance.
1138 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1139}
1140
eladalonf1841382017-06-12 01:16:46 -07001141TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001142 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001143 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001144 std::unique_ptr<VideoMediaChannel> channel(
1145 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001146 ASSERT_TRUE(
1147 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1148 cricket::VideoCodec codec = GetEngineCodec("VP8");
1149 cricket::VideoSendParameters parameters;
1150 parameters.codecs.push_back(codec);
1151 channel->OnReadyToSend(true);
1152 channel->SetSend(true);
1153 ASSERT_TRUE(channel->SetSendParameters(parameters));
1154
Tommi85959932018-02-07 19:26:06 +01001155 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001156 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001157 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001158
1159 EXPECT_EQ(cricket::CS_RUNNING,
1160 capturer.Start(capturer.GetSupportedFormats()->front()));
1161 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001162 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001163 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001164 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001165
Niels Möllerff40b142018-04-09 08:49:14 +02001166 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001167 EXPECT_TRUE(capturer.CaptureFrame());
1168 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001169 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001170
1171 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001172 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001173 EXPECT_TRUE(capturer.CaptureFrame());
1174 // Change to screen content, recreate encoder. For the simulcast encoder
1175 // adapter case, this will result in two calls since InitEncode triggers a
1176 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001177 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001178 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001179 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001180
Niels Möllerff40b142018-04-09 08:49:14 +02001181 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001182 EXPECT_TRUE(capturer.CaptureFrame());
1183 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001184 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001185
1186 options.is_screencast.emplace(false);
1187 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001188 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001189 // Change back to regular video content, update encoder. Also change
1190 // a non |is_screencast| option just to verify it doesn't affect recreation.
1191 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001192 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001193 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001194 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001195
1196 // Remove stream previously added to free the external encoder instance.
1197 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001198 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001199}
1200
Niels Möller6557d0c2018-04-11 15:18:34 +02001201class WebRtcVideoChannelBaseTest : public testing::Test {
1202 protected:
1203 WebRtcVideoChannelBaseTest()
1204 : call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001205 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1206 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001207
1208 virtual void SetUp() {
1209 cricket::MediaConfig media_config;
1210 // Disabling cpu overuse detection actually disables quality scaling too; it
1211 // implies DegradationPreference kMaintainResolution. Automatic scaling
1212 // needs to be disabled, otherwise, tests which check the size of received
1213 // frames become flaky.
1214 media_config.video.enable_cpu_adaptation = false;
1215 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
1216 cricket::VideoOptions()));
1217 channel_->OnReadyToSend(true);
1218 EXPECT_TRUE(channel_.get() != NULL);
1219 network_interface_.SetDestination(channel_.get());
1220 channel_->SetInterface(&network_interface_);
1221 cricket::VideoRecvParameters parameters;
1222 parameters.codecs = engine_.codecs();
1223 channel_->SetRecvParameters(parameters);
1224 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1225 video_capturer_.reset(CreateFakeVideoCapturer());
1226 cricket::VideoFormat format(640, 480,
1227 cricket::VideoFormat::FpsToInterval(kFramerate),
1228 cricket::FOURCC_I420);
1229 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001230 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001231 }
1232
1233 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1234 return new cricket::FakeVideoCapturerWithTaskQueue();
1235 }
1236
1237 // Utility method to setup an additional stream to send and receive video.
1238 // Used to test send and recv between two streams.
1239 void SetUpSecondStream() {
1240 SetUpSecondStreamWithNoRecv();
1241 // Setup recv for second stream.
1242 EXPECT_TRUE(channel_->AddRecvStream(
1243 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1244 // Make the second renderer available for use by a new stream.
1245 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1246 }
1247 // Setup an additional stream just to send video. Defer add recv stream.
1248 // This is required if you want to test unsignalled recv of video rtp packets.
1249 void SetUpSecondStreamWithNoRecv() {
1250 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001251 EXPECT_TRUE(
1252 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001253 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001254 EXPECT_FALSE(
1255 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001256 EXPECT_TRUE(channel_->AddSendStream(
1257 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1258 // We dont add recv for the second stream.
1259
1260 // Setup the receive and renderer for second stream after send.
1261 video_capturer_2_.reset(CreateFakeVideoCapturer());
1262 cricket::VideoFormat format(640, 480,
1263 cricket::VideoFormat::FpsToInterval(kFramerate),
1264 cricket::FOURCC_I420);
1265 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1266
Yves Gerey665174f2018-06-19 15:03:05 +02001267 EXPECT_TRUE(
1268 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001269 }
Yves Gerey665174f2018-06-19 15:03:05 +02001270 virtual void TearDown() { channel_.reset(); }
1271 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001272
1273 bool SetOneCodec(const cricket::VideoCodec& codec) {
1274 cricket::VideoFormat capture_format(
1275 kVideoWidth, kVideoHeight,
1276 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1277
1278 if (video_capturer_) {
1279 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1280 }
1281 if (video_capturer_2_) {
1282 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1283 }
1284
1285 bool sending = channel_->sending();
1286 bool success = SetSend(false);
1287 if (success) {
1288 cricket::VideoSendParameters parameters;
1289 parameters.codecs.push_back(codec);
1290 success = channel_->SetSendParameters(parameters);
1291 }
1292 if (success) {
1293 success = SetSend(sending);
1294 }
1295 return success;
1296 }
Yves Gerey665174f2018-06-19 15:03:05 +02001297 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001298 bool SendFrame() {
1299 if (video_capturer_2_) {
1300 video_capturer_2_->CaptureFrame();
1301 }
1302 return video_capturer_.get() && video_capturer_->CaptureFrame();
1303 }
1304 bool WaitAndSendFrame(int wait_ms) {
1305 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1306 ret &= SendFrame();
1307 return ret;
1308 }
Yves Gerey665174f2018-06-19 15:03:05 +02001309 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001310 int NumRtpBytes(uint32_t ssrc) {
1311 return network_interface_.NumRtpBytes(ssrc);
1312 }
Yves Gerey665174f2018-06-19 15:03:05 +02001313 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001314 int NumRtpPackets(uint32_t ssrc) {
1315 return network_interface_.NumRtpPackets(ssrc);
1316 }
Yves Gerey665174f2018-06-19 15:03:05 +02001317 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001318 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1319 return network_interface_.GetRtpPacket(index);
1320 }
1321 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001322 webrtc::RTPHeader header;
1323 EXPECT_TRUE(ParseRtpPacket(p, &header));
1324 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001325 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001326
Niels Möller6557d0c2018-04-11 15:18:34 +02001327 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001328 webrtc::RTPHeader* header) {
1329 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1330 webrtc::RtpHeaderParser::Create());
1331 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001332 }
1333
1334 // Tests that we can send and receive frames.
1335 void SendAndReceive(const cricket::VideoCodec& codec) {
1336 EXPECT_TRUE(SetOneCodec(codec));
1337 EXPECT_TRUE(SetSend(true));
1338 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1339 EXPECT_EQ(0, renderer_.num_rendered_frames());
1340 EXPECT_TRUE(SendFrame());
1341 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1342 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1343 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1344 }
1345
1346 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001347 int duration_sec,
1348 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001349 EXPECT_TRUE(SetOneCodec(codec));
1350 EXPECT_TRUE(SetSend(true));
1351 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1352 EXPECT_EQ(0, renderer_.num_rendered_frames());
1353 for (int i = 0; i < duration_sec; ++i) {
1354 for (int frame = 1; frame <= fps; ++frame) {
1355 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1356 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1357 }
1358 }
1359 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1360 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1361 }
1362
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1364 cricket::VideoMediaInfo info;
1365 EXPECT_TRUE(channel_->GetStats(&info));
1366 return info.senders[i];
1367 }
1368
1369 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1370 cricket::VideoMediaInfo info;
1371 EXPECT_TRUE(channel_->GetStats(&info));
1372 return info.receivers[i];
1373 }
1374
1375 // Two streams one channel tests.
1376
1377 // Tests that we can send and receive frames.
1378 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1379 SetUpSecondStream();
1380 // Test sending and receiving on first stream.
1381 SendAndReceive(codec);
1382 // Test sending and receiving on second stream.
1383 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1384 EXPECT_GT(NumRtpPackets(), 0);
1385 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1386 }
1387
1388 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1389 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
1390 if (CodecNamesEq(name, engine_codec.name))
1391 return engine_codec;
1392 }
1393 // This point should never be reached.
1394 ADD_FAILURE() << "Unrecognized codec name: " << name;
1395 return cricket::VideoCodec();
1396 }
1397
1398 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1399
1400 cricket::StreamParams DefaultSendStreamParams() {
1401 return cricket::StreamParams::CreateLegacy(kSsrc);
1402 }
1403
1404 webrtc::RtcEventLogNullImpl event_log_;
1405 const std::unique_ptr<webrtc::Call> call_;
1406 WebRtcVideoEngine engine_;
1407 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1408 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1409 std::unique_ptr<WebRtcVideoChannel> channel_;
1410 cricket::FakeNetworkInterface network_interface_;
1411 cricket::FakeVideoRenderer renderer_;
1412
1413 // Used by test cases where 2 streams are run on the same channel.
1414 cricket::FakeVideoRenderer renderer2_;
1415};
1416
1417// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001418TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001419 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001420 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001421 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1422 EXPECT_FALSE(channel_->sending());
1423 EXPECT_TRUE(SetSend(true));
1424 EXPECT_TRUE(channel_->sending());
1425 EXPECT_TRUE(SendFrame());
1426 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1427 EXPECT_TRUE(SetSend(false));
1428 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001429}
Niels Möller6557d0c2018-04-11 15:18:34 +02001430
1431// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001432TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001433 EXPECT_FALSE(channel_->sending());
1434 EXPECT_FALSE(SetSend(true));
1435 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001436}
Niels Möller6557d0c2018-04-11 15:18:34 +02001437
1438// Test that we properly set the send and recv buffer sizes by the time
1439// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001440TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001441 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1442 EXPECT_TRUE(SetSend(true));
1443 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1444 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
srtee0c2eea2017-12-15 17:44:33 +01001445}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001446
Erik Språng820ebd02018-08-20 17:14:25 +02001447// Test that we properly set the send and recv buffer sizes when overriding
1448// via field trials.
1449TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1450 // Set field trial to override the default recv buffer size, and then re-run
1451 // setup where the interface is created and configured.
1452 const int kCustomRecvBufferSize = 123456;
1453 webrtc::test::ScopedFieldTrials field_trial(
1454 "WebRTC-IncreasedReceivebuffers/123456/");
1455 SetUp();
1456
1457 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1458 EXPECT_TRUE(SetSend(true));
1459 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1460 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1461}
1462
1463// Test that we properly set the send and recv buffer sizes when overriding
1464// via field trials with suffix.
1465TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1466 // Set field trial to override the default recv buffer size, and then re-run
1467 // setup where the interface is created and configured.
1468 const int kCustomRecvBufferSize = 123456;
1469 webrtc::test::ScopedFieldTrials field_trial(
1470 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1471 SetUp();
1472
1473 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1474 EXPECT_TRUE(SetSend(true));
1475 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1476 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1477}
1478
1479// Test that we properly set the send and recv buffer sizes when overriding
1480// via field trials that don't make any sense.
1481TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1482 // Set bogus field trial values to override the default recv buffer size, and
1483 // then re-run setup where the interface is created and configured. The
1484 // default value should still be used.
1485
1486 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1487 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1488 field_trial_string += group;
1489 field_trial_string += "/";
1490 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1491 SetUp();
1492
1493 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1494 EXPECT_TRUE(SetSend(true));
1495 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1496 EXPECT_EQ(64 * 1024, network_interface_.recvbuf_size());
1497 }
1498}
1499
Niels Möller6557d0c2018-04-11 15:18:34 +02001500// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001501TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001502 const int kDurationSec = 3;
1503 const int kFps = 10;
1504 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1505
1506 cricket::VideoMediaInfo info;
1507 EXPECT_TRUE(channel_->GetStats(&info));
1508
1509 ASSERT_EQ(1U, info.senders.size());
1510 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1511 // For webrtc, bytes_sent does not include the RTP header length.
1512 EXPECT_GT(info.senders[0].bytes_sent, 0);
1513 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1514 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1515 ASSERT_TRUE(info.senders[0].codec_payload_type);
1516 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1517 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1518 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1519 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1520 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1521 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1522 EXPECT_GT(info.senders[0].framerate_input, 0);
1523 EXPECT_GT(info.senders[0].framerate_sent, 0);
1524
1525 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1526 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1527 info.send_codecs[DefaultCodec().id]);
1528
1529 ASSERT_EQ(1U, info.receivers.size());
1530 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1531 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1532 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1533 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1534 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1535 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1536 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1537 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1538 EXPECT_EQ(0, info.receivers[0].packets_lost);
1539 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1540 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1541 EXPECT_EQ(0, info.receivers[0].firs_sent);
1542 EXPECT_EQ(0, info.receivers[0].plis_sent);
1543 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1544 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1545 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1546 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1547 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1548 EXPECT_GT(info.receivers[0].framerate_output, 0);
1549
1550 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1551 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1552 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001553}
Niels Möller6557d0c2018-04-11 15:18:34 +02001554
1555// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001556TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001557 cricket::FakeVideoRenderer renderer1, renderer2;
1558 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1559 cricket::VideoSendParameters parameters;
1560 parameters.codecs.push_back(DefaultCodec());
1561 parameters.conference_mode = true;
1562 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1563 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001564 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1565 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001566 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1567 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1568 EXPECT_EQ(0, renderer1.num_rendered_frames());
1569 EXPECT_EQ(0, renderer2.num_rendered_frames());
1570 std::vector<uint32_t> ssrcs;
1571 ssrcs.push_back(1);
1572 ssrcs.push_back(2);
1573 network_interface_.SetConferenceMode(true, ssrcs);
1574 EXPECT_TRUE(SendFrame());
1575 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1576 kTimeout);
1577 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1578 kTimeout);
1579
1580 EXPECT_TRUE(channel_->SetSend(false));
1581
1582 cricket::VideoMediaInfo info;
1583 EXPECT_TRUE(channel_->GetStats(&info));
1584 ASSERT_EQ(1U, info.senders.size());
1585 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1586 // For webrtc, bytes_sent does not include the RTP header length.
1587 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1588 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1589 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1590 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1591
1592 ASSERT_EQ(2U, info.receivers.size());
1593 for (size_t i = 0; i < info.receivers.size(); ++i) {
1594 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1595 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1596 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001597 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001598 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1599 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1600 }
srtee0c2eea2017-12-15 17:44:33 +01001601}
Niels Möller6557d0c2018-04-11 15:18:34 +02001602
1603// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001604TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001605 // Normal setup; note that we set the SSRC explicitly to ensure that
1606 // it will come first in the senders map.
1607 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1608 cricket::VideoSendParameters parameters;
1609 parameters.codecs.push_back(DefaultCodec());
1610 parameters.conference_mode = true;
1611 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001612 EXPECT_TRUE(
1613 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001614 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1615 EXPECT_TRUE(SetSend(true));
1616 EXPECT_TRUE(SendFrame());
1617 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1618 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1619
1620 // Add an additional capturer, and hook up a renderer to receive it.
1621 cricket::FakeVideoRenderer renderer2;
1622 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1623 CreateFakeVideoCapturer());
1624 const int kTestWidth = 160;
1625 const int kTestHeight = 120;
1626 cricket::VideoFormat format(kTestWidth, kTestHeight,
1627 cricket::VideoFormat::FpsToInterval(5),
1628 cricket::FOURCC_I420);
1629 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001630 EXPECT_TRUE(
1631 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001632 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001633 EXPECT_TRUE(
1634 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001635 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1636 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001637 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1638 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001639
1640 // Get stats, and make sure they are correct for two senders. We wait until
1641 // the number of expected packets have been sent to avoid races where we
1642 // check stats before it has been updated.
1643 cricket::VideoMediaInfo info;
1644 for (uint32_t i = 0; i < kTimeout; ++i) {
1645 rtc::Thread::Current()->ProcessMessages(1);
1646 EXPECT_TRUE(channel_->GetStats(&info));
1647 ASSERT_EQ(2U, info.senders.size());
1648 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1649 NumRtpPackets()) {
1650 // Stats have been updated for both sent frames, expectations can be
1651 // checked now.
1652 break;
1653 }
1654 }
1655 EXPECT_EQ(NumRtpPackets(),
1656 info.senders[0].packets_sent + info.senders[1].packets_sent)
1657 << "Timed out while waiting for packet counts for all sent packets.";
1658 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1659 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1660 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1661 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1662 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1663 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1664 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1665 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1666 // The capturer must be unregistered here as it runs out of it's scope next.
1667 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001668}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001669
Niels Möller6557d0c2018-04-11 15:18:34 +02001670// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001671TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001672 cricket::VideoSendParameters parameters;
1673 parameters.codecs.push_back(DefaultCodec());
1674 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1675 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1676 parameters.max_bandwidth_bps = 128 * 1024;
1677 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001678}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001679
Niels Möller6557d0c2018-04-11 15:18:34 +02001680// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001681TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001682 EXPECT_TRUE(SetDefaultCodec());
1683 EXPECT_TRUE(SetSend(true));
1684 EXPECT_TRUE(SendFrame());
1685 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001686 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001687 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001688 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1689 EXPECT_EQ(kSsrc, header.ssrc);
1690
Niels Möller6557d0c2018-04-11 15:18:34 +02001691 // Packets are being paced out, so these can mismatch between the first and
1692 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001693 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1694 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001695 EXPECT_EQ(1, NumSentSsrcs());
1696 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1697 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001698}
Niels Möller6557d0c2018-04-11 15:18:34 +02001699
1700// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001701TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001702 // Remove stream added in Setup.
1703 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1704 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001706 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1707 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001708 EXPECT_TRUE(SetSend(true));
1709 EXPECT_TRUE(WaitAndSendFrame(0));
1710 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001711 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001713 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1714 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001715 // Packets are being paced out, so these can mismatch between the first and
1716 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001717 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1718 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001719 EXPECT_EQ(1, NumSentSsrcs());
1720 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1721 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001722}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001723
Niels Möller6557d0c2018-04-11 15:18:34 +02001724// Test that we can set the default video renderer before and after
1725// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001726TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001727 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1728 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001729
1730 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1731 rtc::SetBE32(packet1.data() + 8, kSsrc);
1732 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1733 EXPECT_TRUE(SetDefaultCodec());
1734 EXPECT_TRUE(SetSend(true));
1735 EXPECT_EQ(0, renderer_.num_rendered_frames());
1736 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
1737 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1738 EXPECT_TRUE(SendFrame());
1739 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001740}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001741
Niels Möller6557d0c2018-04-11 15:18:34 +02001742// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001743TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001744 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1745 EXPECT_TRUE(SetSend(true));
1746 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1747 EXPECT_TRUE(SendFrame());
1748 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1749 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001750 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001751 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001752 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1753 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001754 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1755 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001756
1757 // Remove the send stream that was added during Setup.
1758 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1759 int rtp_packets = NumRtpPackets();
1760
Niels Möller6557d0c2018-04-11 15:18:34 +02001761 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001762 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1763 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001764 EXPECT_EQ(rtp_packets, NumRtpPackets());
1765 // Wait 30ms to guarantee the engine does not drop the frame.
1766 EXPECT_TRUE(WaitAndSendFrame(30));
1767 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1768
1769 last_packet = NumRtpPackets() - 1;
1770 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001771 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1772 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001773}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001774
Niels Möller6557d0c2018-04-11 15:18:34 +02001775// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001776TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001777 cricket::FakeVideoRenderer renderer1, renderer2;
1778 EXPECT_TRUE(SetDefaultCodec());
1779 cricket::VideoSendParameters parameters;
1780 parameters.codecs.push_back(DefaultCodec());
1781 parameters.conference_mode = true;
1782 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1783 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001784 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1785 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1787 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1788 EXPECT_EQ(0, renderer1.num_rendered_frames());
1789 EXPECT_EQ(0, renderer2.num_rendered_frames());
1790 std::vector<uint32_t> ssrcs;
1791 ssrcs.push_back(1);
1792 ssrcs.push_back(2);
1793 network_interface_.SetConferenceMode(true, ssrcs);
1794 EXPECT_TRUE(SendFrame());
1795 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1796 kTimeout);
1797 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1798 kTimeout);
1799
1800 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1801 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1802 EXPECT_EQ(kVideoWidth, renderer1.width());
1803 EXPECT_EQ(kVideoHeight, renderer1.height());
1804 EXPECT_EQ(kVideoWidth, renderer2.width());
1805 EXPECT_EQ(kVideoHeight, renderer2.height());
1806 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1807 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001808}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001809
Niels Möller6557d0c2018-04-11 15:18:34 +02001810// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001811TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001812 using cricket::VideoCodec;
1813 using cricket::VideoOptions;
1814 using cricket::VideoFormat;
1815 using cricket::FOURCC_I420;
1816
1817 VideoCodec codec = DefaultCodec();
1818 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1819 EXPECT_TRUE(SetOneCodec(codec));
1820 EXPECT_TRUE(SetSend(true));
1821 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1822 EXPECT_EQ(0, renderer_.num_rendered_frames());
1823 EXPECT_TRUE(SendFrame());
1824 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1825 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1826 CreateFakeVideoCapturer());
1827
1828 // TODO(nisse): This testcase fails if we don't configure
1829 // screencast. It's unclear why, I see nothing obvious in this
1830 // test which is related to screencast logic.
1831 VideoOptions video_options;
1832 video_options.is_screencast = true;
1833 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1834
1835 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1836 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1837 // All capturers start generating frames with the same timestamp. ViE does
1838 // not allow the same timestamp to be used. Capture one frame before
1839 // associating the capturer with the channel.
1840 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1841
1842 int captured_frames = 1;
1843 for (int iterations = 0; iterations < 2; ++iterations) {
1844 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1845 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1846 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1847 ++captured_frames;
1848 // Wait until frame of right size is captured.
1849 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001850 format.width == renderer_.width() &&
1851 format.height == renderer_.height() &&
1852 !renderer_.black_frame(),
1853 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001854 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1855 EXPECT_EQ(format.width, renderer_.width());
1856 EXPECT_EQ(format.height, renderer_.height());
1857 captured_frames = renderer_.num_rendered_frames() + 1;
1858 EXPECT_FALSE(renderer_.black_frame());
1859 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1860 // Make sure a black frame is generated within the specified timeout.
1861 // The black frame should be the resolution of the previous frame to
1862 // prevent expensive encoder reconfigurations.
1863 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001864 format.width == renderer_.width() &&
1865 format.height == renderer_.height() &&
1866 renderer_.black_frame(),
1867 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001868 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1869 EXPECT_EQ(format.width, renderer_.width());
1870 EXPECT_EQ(format.height, renderer_.height());
1871 EXPECT_TRUE(renderer_.black_frame());
1872
1873 // The black frame has the same timestamp as the next frame since it's
1874 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1875 // not render a frame with the same timestamp so capture another frame
1876 // with the frame capturer to increment the next frame's timestamp.
1877 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1878 }
srtee0c2eea2017-12-15 17:44:33 +01001879}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001880
Niels Möller6557d0c2018-04-11 15:18:34 +02001881// Tests that if SetVideoSend is called with a NULL capturer after the
1882// capturer was already removed, the application doesn't crash (and no black
1883// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001884TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001885 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1886 EXPECT_TRUE(SetSend(true));
1887 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1888 EXPECT_EQ(0, renderer_.num_rendered_frames());
1889 EXPECT_TRUE(SendFrame());
1890 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1891 // Wait for one frame so they don't get dropped because we send frames too
1892 // tightly.
1893 rtc::Thread::Current()->ProcessMessages(30);
1894 // Remove the capturer.
1895 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1896
1897 // No capturer was added, so this SetVideoSend shouldn't do anything.
1898 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1899 rtc::Thread::Current()->ProcessMessages(300);
1900 // Verify no more frames were sent.
1901 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001902}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001903
Niels Möller6557d0c2018-04-11 15:18:34 +02001904// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001905TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001906 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1907 // interval time to avoid that.
1908 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1909 // interval time to avoid that.
1910 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001911 EXPECT_TRUE(
1912 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001913 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1914 cricket::VideoFormat capture_format(
1915 kVideoWidth, kVideoHeight,
1916 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1917 // Set up additional stream 1.
1918 cricket::FakeVideoRenderer renderer1;
1919 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001920 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001921 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001922 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1924 CreateFakeVideoCapturer());
1925 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1926 // Set up additional stream 2.
1927 cricket::FakeVideoRenderer renderer2;
1928 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001929 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001930 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001931 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001932 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1933 CreateFakeVideoCapturer());
1934 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1935 // State for all the streams.
1936 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1937 // A limitation in the lmi implementation requires that SetVideoSend() is
1938 // called after SetOneCodec().
1939 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1940 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1941 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1942 EXPECT_TRUE(SetSend(true));
1943 // Test capturer associated with engine.
1944 const int kTestWidth = 160;
1945 const int kTestHeight = 120;
1946 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001947 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1948 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001949 // Capture a frame with additional capturer2, frames should be received
1950 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001951 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1952 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001953 // Successfully remove the capturer.
1954 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1955 // The capturers must be unregistered here as it runs out of it's scope
1956 // next.
1957 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1958 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001959}
Niels Möller6557d0c2018-04-11 15:18:34 +02001960
1961// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001962TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001963 // Remove the send stream that was added during Setup.
1964 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1965
1966 cricket::StreamParams empty;
1967 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001968 EXPECT_TRUE(
1969 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001970}
Niels Möller6557d0c2018-04-11 15:18:34 +02001971
1972// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001973TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001974 // Remove stream added in Setup. I.e. remove stream corresponding to default
1975 // channel.
1976 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001977 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001978 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1979 EXPECT_TRUE(channel_->AddSendStream(
1980 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1981 }
1982 // Delete one of the non default channel streams, let the destructor delete
1983 // the remaining ones.
1984 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1985 // Stream should already be deleted.
1986 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001987}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001988
eladalonf1841382017-06-12 01:16:46 -07001989TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001990 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001991}
1992
eladalonf1841382017-06-12 01:16:46 -07001993TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001994 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001995}
1996
eladalonf1841382017-06-12 01:16:46 -07001997TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001998 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001999}
2000
eladalonf1841382017-06-12 01:16:46 -07002001TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002002 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2003 // bitrates. This currently happens at <250k, and two streams sharing 300k
2004 // initially will use QVGA instead of VGA.
2005 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2006 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002007 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002008 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002009 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002010}
2011
eladalonf1841382017-06-12 01:16:46 -07002012class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002013 public:
eladalonf1841382017-06-12 01:16:46 -07002014 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2015 explicit WebRtcVideoChannelTest(const char* field_trials)
2016 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002017 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002018 encoder_factory_->AddSupportedVideoCodecType("VP8");
2019 encoder_factory_->AddSupportedVideoCodecType("VP9");
2020#if defined(WEBRTC_USE_H264)
2021 encoder_factory_->AddSupportedVideoCodecType("H264");
2022#endif
2023
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002024 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002025 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
2026 VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002027 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002028 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002029 send_parameters_.codecs = engine_.codecs();
2030 recv_parameters_.codecs = engine_.codecs();
2031 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002032 }
2033
2034 protected:
2035 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002036 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002037 }
2038
2039 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002040 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002041 EXPECT_TRUE(channel_->AddSendStream(sp));
2042 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002043 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002044 EXPECT_EQ(num_streams + 1, streams.size());
2045 return streams[streams.size() - 1];
2046 }
2047
2048 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002049 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002050 }
2051
2052 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002053 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002054 }
2055
2056 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002057 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002058 EXPECT_TRUE(channel_->AddRecvStream(sp));
2059 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002060 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002061 EXPECT_EQ(num_streams + 1, streams.size());
2062 return streams[streams.size() - 1];
2063 }
2064
pbos@webrtc.org00873182014-11-25 14:03:34 +00002065 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2066 int expected_min_bitrate_bps,
2067 const char* start_bitrate_kbps,
2068 int expected_start_bitrate_bps,
2069 const char* max_bitrate_kbps,
2070 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002071 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2072 expected_start_bitrate_bps,
2073 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002074 auto& codecs = send_parameters_.codecs;
2075 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002076 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002077 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2078 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2079 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002080 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002081 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002082
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002083 void ExpectSetBitrateParameters(int min_bitrate_bps,
2084 int start_bitrate_bps,
2085 int max_bitrate_bps) {
2086 EXPECT_CALL(
2087 *fake_call_->GetMockTransportControllerSend(),
2088 SetSdpBitrateParameters(AllOf(
2089 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2090 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2091 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2092 }
2093
2094 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2095 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2096 SetSdpBitrateParameters(Field(
2097 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002098 }
2099
isheriff6f8d6862016-05-26 11:24:55 -07002100 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002101 // Enable extension.
2102 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002103 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002104 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002105 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002106 FakeVideoSendStream* send_stream =
2107 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2108
2109 // Verify the send extension id.
2110 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2111 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002112 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002113 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002114 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002115 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2116 // receivers.
2117 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2118 ->GetConfig()
2119 .rtp.extensions.empty());
2120
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002121 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002122 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002123 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2124 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002125 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2126
2127 // Verify that adding receive RTP header extensions adds them for existing
2128 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002129 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002130 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002131 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2132 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002133 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002134 }
2135
isheriff6f8d6862016-05-26 11:24:55 -07002136 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002137 // Enable extension.
2138 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002139 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002140 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002141 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002142
2143 FakeVideoReceiveStream* recv_stream =
2144 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2145
2146 // Verify the recv extension id.
2147 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2148 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002149 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002150 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002151 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002152
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002153 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2154 // senders.
2155 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2156 ->GetConfig()
2157 .rtp.extensions.empty());
2158
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002159 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002160 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002161 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2162 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002163 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2164
2165 // Verify that adding receive RTP header extensions adds them for existing
2166 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002167 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002168 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002169 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2170 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002171 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002172 }
2173
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002174 void TestExtensionFilter(const std::vector<std::string>& extensions,
2175 const std::string& expected_extension) {
2176 cricket::VideoSendParameters parameters = send_parameters_;
2177 int expected_id = -1;
2178 int id = 1;
2179 for (const std::string& extension : extensions) {
2180 if (extension == expected_extension)
2181 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002182 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002183 }
2184 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2185 FakeVideoSendStream* send_stream =
2186 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2187
2188 // Verify that only one of them has been set, and that it is the one with
2189 // highest priority (transport sequence number).
2190 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2191 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2192 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002193 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002194 }
2195
asapersson3c81a1a2017-06-14 05:52:21 -07002196 void TestDegradationPreference(bool resolution_scaling_enabled,
2197 bool fps_scaling_enabled);
2198
Erik Språngefbde372015-04-29 16:21:28 +02002199 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002200 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002201 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2202 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002203
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002204 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002205 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002206 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002207 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002208 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002209 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002210 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002211 // Options only take effect on the next frame.
2212 EXPECT_TRUE(capturer->CaptureFrame());
2213
Erik Språng143cec12015-04-28 10:01:41 +02002214 return fake_call_->GetVideoSendStreams().back();
2215 }
2216
Peter Boström2feafdb2015-09-09 14:32:14 +02002217 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2218 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002219 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002220 std::vector<uint32_t> ssrcs;
2221 std::vector<uint32_t> rtx_ssrcs;
2222 uint32_t num_streams = enabled ? 3 : 1;
2223 for (uint32_t i = 0; i < num_streams; ++i) {
2224 uint32_t ssrc = last_ssrc_ + i;
2225 ssrcs.push_back(ssrc);
2226 if (with_rtx) {
2227 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2228 }
Erik Språng143cec12015-04-28 10:01:41 +02002229 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002230 if (with_rtx) {
2231 return AddSendStream(
2232 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2233 }
2234 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002235 }
2236
perkjfa10b552016-10-02 23:45:26 -07002237 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002238 std::vector<FakeVideoSendStream*> streams =
2239 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002240 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002241 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002242 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002243 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002244 }
2245
perkjfa10b552016-10-02 23:45:26 -07002246 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002247 int stream_max,
2248 int expected_encoder_bitrate) {
2249 VideoSendParameters limited_send_params = send_parameters_;
2250 limited_send_params.max_bandwidth_bps = global_max;
2251 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002252 webrtc::RtpParameters parameters =
2253 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002254 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002255 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002256 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002257 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002258 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002259 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002260 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002261 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002262 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002263 }
2264
Åsa Persson55659812018-06-18 17:51:32 +02002265 // Values from kSimulcastConfigs in simulcast.cc.
2266 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2267 std::vector<webrtc::VideoStream> layers(3);
2268 layers[0].min_bitrate_bps = 30000;
2269 layers[0].target_bitrate_bps = 150000;
2270 layers[0].max_bitrate_bps = 200000;
2271 layers[1].min_bitrate_bps = 150000;
2272 layers[1].target_bitrate_bps = 500000;
2273 layers[1].max_bitrate_bps = 700000;
2274 layers[2].min_bitrate_bps = 600000;
2275 layers[2].target_bitrate_bps = 2500000;
2276 layers[2].max_bitrate_bps = 2500000;
2277 return layers;
2278 }
2279
kwiberg686a8ef2016-02-26 03:00:35 -08002280 std::unique_ptr<FakeCall> fake_call_;
2281 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002282 cricket::VideoSendParameters send_parameters_;
2283 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002284 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002285};
2286
eladalonf1841382017-06-12 01:16:46 -07002287TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002288 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002289 const std::string kSyncLabel = "AvSyncLabel";
2290
2291 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002292 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002293 EXPECT_TRUE(channel_->AddRecvStream(sp));
2294
Mirko Bonadeif859e552018-05-30 15:31:29 +02002295 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002296 EXPECT_EQ(kSyncLabel,
2297 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2298 << "SyncGroup should be set based on sync_label";
2299}
2300
eladalonf1841382017-06-12 01:16:46 -07002301TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002302 cricket::VideoSendParameters parameters;
2303 parameters.codecs = engine_.codecs();
2304 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002305 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002306 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002307 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002308
2309 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002310 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2311 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002312 FakeVideoSendStream* send_stream = AddSendStream(
2313 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2314
2315 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2316 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2317 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2318
2319 // Receiver side.
2320 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2321 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002322 EXPECT_FALSE(
2323 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002324 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002325 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002326 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002327 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002328 << "RTX should be mapped for the RED payload type";
2329
brandtr14742122017-01-27 04:53:07 -08002330 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002331}
2332
eladalonf1841382017-06-12 01:16:46 -07002333TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002334 // Setup one channel with an associated RTX stream.
2335 cricket::StreamParams params =
2336 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2337 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2338 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002339 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002340
2341 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2342 << "RTX should be mapped for all decoders/payload types.";
2343 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002344 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002345 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002346}
2347
eladalonf1841382017-06-12 01:16:46 -07002348TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002349 // Setup one channel without an associated RTX stream.
2350 cricket::StreamParams params =
2351 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2352 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002353 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002354}
2355
eladalonf1841382017-06-12 01:16:46 -07002356TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002357 FakeVideoSendStream* send_stream =
2358 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2359 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2360
2361 FakeVideoReceiveStream* recv_stream =
2362 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2363 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002364}
2365
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002366// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002367TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002368 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002369}
isheriff6f8d6862016-05-26 11:24:55 -07002370
eladalonf1841382017-06-12 01:16:46 -07002371TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002372 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002373}
2374
2375// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002376TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002377 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002378}
isheriff6f8d6862016-05-26 11:24:55 -07002379
eladalonf1841382017-06-12 01:16:46 -07002380TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002381 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002382}
2383
eladalonf1841382017-06-12 01:16:46 -07002384TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002385 // Enable three redundant extensions.
2386 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002387 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2388 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2389 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2390 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002391}
2392
eladalonf1841382017-06-12 01:16:46 -07002393TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002394 // Enable two redundant extensions.
2395 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002396 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2397 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2398 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002399}
2400
stefanc1aeaf02015-10-15 07:26:07 -07002401// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002402TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002403 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002404}
eladalonf1841382017-06-12 01:16:46 -07002405TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002406 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002407}
2408
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002409// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002410TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002411 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002412}
eladalonf1841382017-06-12 01:16:46 -07002413TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002414 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002415}
2416
eladalonf1841382017-06-12 01:16:46 -07002417TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002418 const int kAbsSendTimeId = 1;
2419 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002420 send_parameters_.extensions.push_back(
2421 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2422 send_parameters_.extensions.push_back(
2423 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002424
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002425 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002426 FakeVideoSendStream* send_stream =
2427 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2428
2429 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002430 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002431
2432 // Setting the same extensions (even if in different order) shouldn't
2433 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002434 std::reverse(send_parameters_.extensions.begin(),
2435 send_parameters_.extensions.end());
2436 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002437
2438 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2439
2440 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002441 send_parameters_.extensions.resize(1);
2442 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002443
2444 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2445}
2446
eladalonf1841382017-06-12 01:16:46 -07002447TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002448 const int kTOffsetId = 1;
2449 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002450 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002451 recv_parameters_.extensions.push_back(
2452 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2453 recv_parameters_.extensions.push_back(
2454 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2455 recv_parameters_.extensions.push_back(
2456 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002457
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002458 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002459 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002460 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2461
2462 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002463 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002464
2465 // Setting the same extensions (even if in different order) shouldn't
2466 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002467 std::reverse(recv_parameters_.extensions.begin(),
2468 recv_parameters_.extensions.end());
2469 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002470
2471 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2472
2473 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002474 recv_parameters_.extensions.resize(1);
2475 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002476
2477 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2478}
2479
eladalonf1841382017-06-12 01:16:46 -07002480TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002481 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002482 const int kUnsupportedId = 1;
2483 const int kTOffsetId = 2;
2484
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002485 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002486 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002487 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002488 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002489 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002490 FakeVideoSendStream* send_stream =
2491 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2492
2493 // Only timestamp offset extension is set to send stream,
2494 // unsupported rtp extension is ignored.
2495 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002496 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2497 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002498}
2499
eladalonf1841382017-06-12 01:16:46 -07002500TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002501 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002502 const int kUnsupportedId = 1;
2503 const int kTOffsetId = 2;
2504
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002505 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002506 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002507 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002508 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002509 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002510 FakeVideoReceiveStream* recv_stream =
2511 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2512
2513 // Only timestamp offset extension is set to receive stream,
2514 // unsupported rtp extension is ignored.
2515 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002516 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2517 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002518}
2519
eladalonf1841382017-06-12 01:16:46 -07002520TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002521 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002522 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002523 send_parameters_.extensions.push_back(
2524 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002525 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002526 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2527 }
2528}
2529
eladalonf1841382017-06-12 01:16:46 -07002530TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002531 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002532 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002533 recv_parameters_.extensions.push_back(
2534 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002535 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002536 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2537 }
2538}
2539
eladalonf1841382017-06-12 01:16:46 -07002540TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002541 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002542 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002543 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002544 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002545 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002546 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002547
2548 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002549 send_parameters_.extensions.clear();
2550 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002551 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002552 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2553 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002554}
2555
eladalonf1841382017-06-12 01:16:46 -07002556TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002557 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002558 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002559 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002560 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002561 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002562 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002563
2564 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002565 recv_parameters_.extensions.clear();
2566 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002567 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002568 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2569 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002570}
2571
eladalonf1841382017-06-12 01:16:46 -07002572TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002573 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002574 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002575}
2576
eladalonf1841382017-06-12 01:16:46 -07002577TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002578 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002579 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002580}
2581
eladalonf1841382017-06-12 01:16:46 -07002582TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002583 FakeVideoReceiveStream* stream = AddRecvStream();
2584 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002585}
2586
eladalonf1841382017-06-12 01:16:46 -07002587TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002588 FakeVideoReceiveStream* stream = AddRecvStream();
2589 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2590}
2591
eladalonf1841382017-06-12 01:16:46 -07002592TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002593 FakeVideoReceiveStream* stream = AddRecvStream();
2594 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2595
Peter Boström126c03e2015-05-11 12:48:12 +02002596 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002597 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002598 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002599 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2600 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002601 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002602 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2603
2604 // Verify that REMB is turned on when setting default codecs since the
2605 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002606 parameters.codecs = engine_.codecs();
2607 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002608 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002609 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002610}
2611
eladalonf1841382017-06-12 01:16:46 -07002612TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002613 FakeVideoReceiveStream* stream = AddRecvStream();
2614 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2615
2616 // Verify that transport cc feedback is turned off when send(!) codecs without
2617 // transport cc feedback are set.
2618 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002619 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002620 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2621 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2622 stream = fake_call_->GetVideoReceiveStreams()[0];
2623 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2624
2625 // Verify that transport cc feedback is turned on when setting default codecs
2626 // since the default codecs have transport cc feedback enabled.
2627 parameters.codecs = engine_.codecs();
2628 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2629 stream = fake_call_->GetVideoReceiveStreams()[0];
2630 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2631}
2632
eladalonf1841382017-06-12 01:16:46 -07002633TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002634 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002635 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2636
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002637 cricket::VideoSendParameters parameters;
2638 parameters.codecs = engine_.codecs();
2639 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002640 EXPECT_TRUE(channel_->SetSend(true));
2641
2642 // Send side.
2643 FakeVideoSendStream* send_stream =
2644 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2645 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2646
2647 // Receiver side.
2648 FakeVideoReceiveStream* recv_stream =
2649 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2650 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2651
2652 // Nack history size should match between sender and receiver.
2653 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2654 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002655}
2656
eladalonf1841382017-06-12 01:16:46 -07002657TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002658 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002659 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002660
2661 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2662 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2663
2664 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002665 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002666 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002667 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2668 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002669 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2670 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2671 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002672 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2673
Peter Boström67c9df72015-05-11 14:34:58 +02002674 // Verify that NACK is turned on when setting default codecs since the
2675 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002676 parameters.codecs = engine_.codecs();
2677 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002678 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2679 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2680 send_stream = fake_call_->GetVideoSendStreams()[0];
2681 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002682}
2683
Peter Boströme7ba0862016-03-12 00:02:28 +01002684// This test verifies that new frame sizes reconfigures encoders even though not
2685// (yet) sending. The purpose of this is to permit encoding as quickly as
2686// possible once we start sending. Likely the frames being input are from the
2687// same source that will be sent later, which just means that we're ready
2688// earlier.
eladalonf1841382017-06-12 01:16:46 -07002689TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002690 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002691 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002692 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2693 channel_->SetSend(false);
2694
2695 FakeVideoSendStream* stream = AddSendStream();
2696
perkjfa10b552016-10-02 23:45:26 -07002697 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002698 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002699 EXPECT_EQ(0u, streams[0].width);
2700 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002701
Tommi85959932018-02-07 19:26:06 +01002702 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002703 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002704 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2705 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002706 EXPECT_TRUE(capturer.CaptureFrame());
2707
2708 // Frame entered, should be reconfigured to new dimensions.
2709 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002710 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2711 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2712 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002713
Niels Möllerff40b142018-04-09 08:49:14 +02002714 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002715}
2716
eladalonf1841382017-06-12 01:16:46 -07002717TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002718 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002719 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002720 cricket::VideoSendParameters parameters;
2721 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002722 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002723 AddSendStream();
2724
Tommi85959932018-02-07 19:26:06 +01002725 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002726 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002727 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002728 EXPECT_TRUE(
2729 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002730 cricket::VideoFormat capture_format_hd =
2731 capturer.GetSupportedFormats()->front();
2732 EXPECT_EQ(1280, capture_format_hd.width);
2733 EXPECT_EQ(720, capture_format_hd.height);
2734 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2735
2736 EXPECT_TRUE(channel_->SetSend(true));
2737
2738 EXPECT_TRUE(capturer.CaptureFrame());
2739 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2740 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2741
2742 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2743
2744 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002745 webrtc::VideoEncoderConfig encoder_config =
2746 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002747 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002748 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002749 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002750 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2751 streams.front().width);
2752 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2753 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002754 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2755 << "Non-screenshare shouldn't use min-transmit bitrate.";
2756
Niels Möllerff40b142018-04-09 08:49:14 +02002757 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002758 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002759 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002760 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002761 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002762 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002763 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002764 // Send stream recreated after option change.
2765 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2766 send_stream = fake_call_->GetVideoSendStreams().front();
2767 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002768
2769 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002770 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002771 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002772 encoder_config.content_type);
2773 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2774 encoder_config.min_transmit_bitrate_bps);
2775
perkjfa10b552016-10-02 23:45:26 -07002776 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002777 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2778 streams.front().width);
2779 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2780 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002781 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002782 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002783}
2784
eladalonf1841382017-06-12 01:16:46 -07002785TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002786 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002787 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002788 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002789 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002790
2791 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002792 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002793 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002794 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002795 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002796 cricket::VideoFormat capture_format_hd =
2797 capturer.GetSupportedFormats()->front();
2798 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2799
2800 EXPECT_TRUE(channel_->SetSend(true));
2801
2802 EXPECT_TRUE(capturer.CaptureFrame());
2803 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2804 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2805
perkj26091b12016-09-01 01:17:40 -07002806 webrtc::VideoEncoderConfig encoder_config =
2807 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002808
2809 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002810 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002811 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002812 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002813
2814 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2815 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002816 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002817 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002818 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002819
Niels Möllerff40b142018-04-09 08:49:14 +02002820 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002821}
2822
eladalonf1841382017-06-12 01:16:46 -07002823TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002824 FakeVideoSendStream* stream = AddSendStream();
2825 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2826}
2827
eladalonf1841382017-06-12 01:16:46 -07002828TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002829 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002830 media_config.video.suspend_below_min_bitrate = true;
2831
2832 channel_.reset(
2833 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002834 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002835
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002836 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002837
2838 FakeVideoSendStream* stream = AddSendStream();
2839 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2840
nisse0db023a2016-03-01 04:29:59 -08002841 media_config.video.suspend_below_min_bitrate = false;
2842 channel_.reset(
2843 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002844 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002845
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002846 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002847
nisse0db023a2016-03-01 04:29:59 -08002848 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002849 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2850}
2851
eladalonf1841382017-06-12 01:16:46 -07002852TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002853 FakeVideoSendStream* stream = AddSendStream();
2854 webrtc::VideoCodecVP8 vp8_settings;
2855 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2856 EXPECT_TRUE(vp8_settings.denoisingOn);
2857}
2858
eladalonf1841382017-06-12 01:16:46 -07002859TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002860 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002861 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002862 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002863
Peter Boström2feafdb2015-09-09 14:32:14 +02002864 // Single-stream settings should apply with RTX as well (verifies that we
2865 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2866 // both RTX and regular SSRCs).
2867 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002868
Tommi85959932018-02-07 19:26:06 +01002869 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002870 EXPECT_EQ(cricket::CS_RUNNING,
2871 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002872 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002873 channel_->SetSend(true);
2874
2875 EXPECT_TRUE(capturer.CaptureFrame());
2876
pbos4cba4eb2015-10-26 11:18:18 -07002877 webrtc::VideoCodecVP8 vp8_settings;
2878 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2879 EXPECT_TRUE(vp8_settings.denoisingOn)
2880 << "VP8 denoising should be on by default.";
2881
nisse05103312016-03-16 02:22:50 -07002882 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002883
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002884 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2885 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002886 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2887 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002888
nisse05103312016-03-16 02:22:50 -07002889 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002890
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002891 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2892 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002893 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2894 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2895
Niels Möllerff40b142018-04-09 08:49:14 +02002896 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002897 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002898 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002899 channel_->SetSend(true);
2900 EXPECT_TRUE(capturer.CaptureFrame());
2901
Mirko Bonadeif859e552018-05-30 15:31:29 +02002902 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002903 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2904 // Autmatic resize off when using simulcast.
2905 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2906 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2907
2908 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002909 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002910 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002911 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002912
nisse05103312016-03-16 02:22:50 -07002913 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002914
Mirko Bonadeif859e552018-05-30 15:31:29 +02002915 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002916 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2917 EXPECT_FALSE(vp8_settings.denoisingOn);
2918 // Resizing and frame dropping always off for screen sharing.
2919 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2920 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2921
nisse05103312016-03-16 02:22:50 -07002922 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002923
2924 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2925 EXPECT_FALSE(vp8_settings.denoisingOn);
2926 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2927 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2928
Niels Möllerff40b142018-04-09 08:49:14 +02002929 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002930}
2931
deadbeef119760a2016-04-04 11:43:27 -07002932// Test that setting the same options doesn't result in the encoder being
2933// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002934TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002935 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002936 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002937
perkjfa10b552016-10-02 23:45:26 -07002938 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002939 EXPECT_EQ(cricket::CS_RUNNING,
2940 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002941 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002942 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002943 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2944 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2945
Niels Möllerff40b142018-04-09 08:49:14 +02002946 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2947 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002948 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002949 // Expect 1 reconfigurations at this point from the initial configuration.
2950 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002951
2952 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02002953 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07002954 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2955
2956 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002957 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002958 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002959 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2960
Niels Möllerff40b142018-04-09 08:49:14 +02002961 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002962}
2963
eladalonf1841382017-06-12 01:16:46 -07002964class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002965 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002966 Vp9SettingsTest() : Vp9SettingsTest("") {}
2967 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002968 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002969 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002970 }
2971 virtual ~Vp9SettingsTest() {}
2972
2973 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002974 void TearDown() override {
2975 // Remove references to encoder_factory_ since this will be destroyed
2976 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002977 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002978 }
Erik Språng143cec12015-04-28 10:01:41 +02002979};
2980
2981TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002982 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002983 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002984 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002985
Peter Boström2feafdb2015-09-09 14:32:14 +02002986 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002987
Tommi85959932018-02-07 19:26:06 +01002988 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002989 EXPECT_EQ(cricket::CS_RUNNING,
2990 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002991 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002992 channel_->SetSend(true);
2993
2994 EXPECT_TRUE(capturer.CaptureFrame());
2995
pbos4cba4eb2015-10-26 11:18:18 -07002996 webrtc::VideoCodecVP9 vp9_settings;
2997 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07002998 EXPECT_TRUE(vp9_settings.denoisingOn)
2999 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003000
nisse05103312016-03-16 02:22:50 -07003001 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003002
Erik Språng143cec12015-04-28 10:01:41 +02003003 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3004 EXPECT_FALSE(vp9_settings.denoisingOn);
3005 // Frame dropping always on for real time video.
3006 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3007
nisse05103312016-03-16 02:22:50 -07003008 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003009
3010 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3011 EXPECT_TRUE(vp9_settings.denoisingOn);
3012 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3013
3014 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003015 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003016 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003017 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003018
nisse05103312016-03-16 02:22:50 -07003019 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003020
3021 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3022 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003023 // Frame dropping always on for screen sharing.
3024 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003025
nisse05103312016-03-16 02:22:50 -07003026 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003027
3028 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3029 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003030 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003031
Niels Möllerff40b142018-04-09 08:49:14 +02003032 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003033}
3034
Sergey Silkinf18072e2018-03-14 10:35:35 +01003035TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3036 cricket::VideoSendParameters parameters;
3037 parameters.codecs.push_back(GetEngineCodec("VP9"));
3038 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3039
3040 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3041
3042 FakeVideoSendStream* stream =
3043 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3044
3045 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3046 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3047
3048 FakeVideoCapturerWithTaskQueue capturer;
3049 EXPECT_EQ(cricket::CS_RUNNING,
3050 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003051 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003052 channel_->SetSend(true);
3053
3054 EXPECT_TRUE(capturer.CaptureFrame());
3055
3056 webrtc::VideoCodecVP9 vp9_settings;
3057 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3058
3059 const size_t kNumSpatialLayers = ssrcs.size();
3060 const size_t kNumTemporalLayers = 3;
3061 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3062 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3063
Niels Möllerff40b142018-04-09 08:49:14 +02003064 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003065}
3066
asaperssonc5dabdd2016-03-21 04:15:50 -07003067class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3068 public:
brandtr468da7c2016-11-22 02:16:47 -08003069 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003070 : Vp9SettingsTest(field_trials) {}
3071
3072 protected:
3073 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3074 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003075 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003076 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3077
3078 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3079
Tommi85959932018-02-07 19:26:06 +01003080 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003081 EXPECT_EQ(cricket::CS_RUNNING,
3082 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003083 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003084 channel_->SetSend(true);
3085
3086 EXPECT_TRUE(capturer.CaptureFrame());
3087
3088 webrtc::VideoCodecVP9 vp9_settings;
3089 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3090 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3091 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3092
Niels Möllerff40b142018-04-09 08:49:14 +02003093 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003094 }
3095};
3096
3097class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3098 public:
3099 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3100};
3101
3102TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3103 const int kNumSpatialLayers = 1;
3104 const int kNumTemporalLayers = 1;
3105 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3106}
3107
3108class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3109 public:
3110 Vp9SettingsTestWithInvalidFlag()
3111 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3112};
3113
3114TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3115 const int kNumSpatialLayers = 1;
3116 const int kNumTemporalLayers = 1;
3117 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3118}
3119
3120class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3121 public:
3122 Vp9SettingsTestWith2SL3TLFlag()
3123 : Vp9SettingsTestWithFieldTrial(
3124 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3125};
3126
3127TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3128 const int kNumSpatialLayers = 2;
3129 const int kNumTemporalLayers = 3;
3130 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3131}
3132
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003133TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3134 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3135 ASSERT_EQ(1u, streams.size());
3136 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3137}
3138
3139TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3140 webrtc::test::ScopedFieldTrials override_field_trials_(
3141 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3142 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3143 ASSERT_EQ(1u, streams.size());
3144 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3145}
3146
asapersson3c81a1a2017-06-14 05:52:21 -07003147TEST_F(WebRtcVideoChannelTest,
3148 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3149 webrtc::test::ScopedFieldTrials override_field_trials_(
3150 "WebRTC-Video-BalancedDegradation/Disabled/");
3151 const bool kResolutionScalingEnabled = true;
3152 const bool kFpsScalingEnabled = false;
3153 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3154}
3155
3156TEST_F(WebRtcVideoChannelTest,
3157 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3158 webrtc::test::ScopedFieldTrials override_field_trials_(
3159 "WebRTC-Video-BalancedDegradation/Enabled/");
3160 const bool kResolutionScalingEnabled = true;
3161 const bool kFpsScalingEnabled = true;
3162 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3163}
3164
eladalonf1841382017-06-12 01:16:46 -07003165TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003166 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003167}
3168
eladalonf1841382017-06-12 01:16:46 -07003169TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003170 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003171}
3172
eladalonf1841382017-06-12 01:16:46 -07003173TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003174 TestCpuAdaptation(true, true);
3175}
3176
eladalonf1841382017-06-12 01:16:46 -07003177TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003178 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003179 cricket::VideoSendParameters parameters;
3180 parameters.codecs.push_back(codec);
3181
kthelgason2bc68642017-02-07 07:02:22 -08003182 MediaConfig media_config = GetMediaConfig();
perkj2d5f0912016-02-29 00:04:41 -08003183 channel_.reset(
3184 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003185 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003186 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3187
3188 AddSendStream();
3189
Tommi85959932018-02-07 19:26:06 +01003190 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003191 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003192 ASSERT_EQ(cricket::CS_RUNNING,
3193 capturer.Start(capturer.GetSupportedFormats()->front()));
3194 ASSERT_TRUE(channel_->SetSend(true));
3195
3196 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3197 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003198
Niels Möllera6cc0f92018-02-12 17:14:55 +01003199 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003200 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3201 EXPECT_EQ(1280, send_stream->GetLastWidth());
3202 EXPECT_EQ(720, send_stream->GetLastHeight());
3203
3204 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003205 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003206 wants.max_pixel_count =
3207 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003208 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003209 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003210 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3211 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3212 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3213
3214 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003215 wants.max_pixel_count =
3216 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003217 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003218 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003219 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3220 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3221 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3222
3223 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003224 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003225 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003226 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3227 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3228
3229 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003230 int current_pixel_count =
3231 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3232 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3233 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003234 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003235 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003236 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003237 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003238 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003239 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003240 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3241 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3242
sprang84a37592017-02-10 07:04:27 -08003243 // Trigger underuse again, should go back up to full resolution.
3244 current_pixel_count =
3245 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003246 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003247 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003248 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003249 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003250 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003251 EXPECT_EQ(1284, send_stream->GetLastWidth());
3252 EXPECT_EQ(724, send_stream->GetLastHeight());
3253
Niels Möllerff40b142018-04-09 08:49:14 +02003254 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003255}
3256
eladalonf1841382017-06-12 01:16:46 -07003257TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003258 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003259 cricket::VideoSendParameters parameters;
3260 parameters.codecs.push_back(codec);
3261
kthelgason2bc68642017-02-07 07:02:22 -08003262 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003263 media_config.video.enable_cpu_adaptation = true;
Per766ad3b2016-04-05 15:23:49 +02003264 channel_.reset(
3265 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003266 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003267 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3268
3269 AddSendStream();
3270
Tommi85959932018-02-07 19:26:06 +01003271 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003272 ASSERT_EQ(cricket::CS_RUNNING,
3273 capturer.Start(capturer.GetSupportedFormats()->front()));
3274 ASSERT_TRUE(channel_->SetSend(true));
3275 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003276 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003277 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003278
3279 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3280 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003281
Niels Möllera6cc0f92018-02-12 17:14:55 +01003282 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003283 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3284 EXPECT_EQ(1280, send_stream->GetLastWidth());
3285 EXPECT_EQ(720, send_stream->GetLastHeight());
3286
3287 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003288 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003289 wants.max_pixel_count =
3290 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003291 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003292 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003293 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3294 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3295 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3296
3297 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003298 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003299 ASSERT_EQ(cricket::CS_RUNNING,
3300 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003301 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003302 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003303 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003304 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003305 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3306 send_stream = fake_call_->GetVideoSendStreams().front();
3307 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003308 EXPECT_EQ(1284, send_stream->GetLastWidth());
3309 EXPECT_EQ(724, send_stream->GetLastHeight());
3310
3311 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003312 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003313 send_stream = fake_call_->GetVideoSendStreams().front();
3314 // We have a new fake send stream, so it doesn't remember the old sink wants.
3315 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003316 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003317 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003318 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003319 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3320 send_stream = fake_call_->GetVideoSendStreams().front();
3321 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003322 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3323 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3324
Niels Möllerff40b142018-04-09 08:49:14 +02003325 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003326}
3327
asapersson3c81a1a2017-06-14 05:52:21 -07003328// TODO(asapersson): Remove this test when the balanced field trial is removed.
3329void WebRtcVideoChannelTest::TestDegradationPreference(
3330 bool resolution_scaling_enabled,
3331 bool fps_scaling_enabled) {
3332 cricket::VideoCodec codec = GetEngineCodec("VP8");
3333 cricket::VideoSendParameters parameters;
3334 parameters.codecs.push_back(codec);
3335
3336 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003337 media_config.video.enable_cpu_adaptation = true;
asapersson3c81a1a2017-06-14 05:52:21 -07003338 channel_.reset(
3339 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
3340 channel_->OnReadyToSend(true);
3341
3342 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3343
3344 AddSendStream();
3345
Tommi85959932018-02-07 19:26:06 +01003346 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003347 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003348 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003349 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3350 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3351
3352 EXPECT_TRUE(channel_->SetSend(true));
3353
3354 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3355 EXPECT_EQ(resolution_scaling_enabled,
3356 send_stream->resolution_scaling_enabled());
3357 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3358
Niels Möllerff40b142018-04-09 08:49:14 +02003359 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003360}
3361
eladalonf1841382017-06-12 01:16:46 -07003362void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3363 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003364 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003365 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003366 cricket::VideoSendParameters parameters;
3367 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003368
kthelgason2bc68642017-02-07 07:02:22 -08003369 MediaConfig media_config = GetMediaConfig();
3370 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003371 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003372 }
nisse51542be2016-02-12 02:27:06 -08003373 channel_.reset(
3374 engine_.CreateChannel(fake_call_.get(), media_config, VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003375 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003376
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003377 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003378
3379 AddSendStream();
3380
Tommi85959932018-02-07 19:26:06 +01003381 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003382 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003383 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003384 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003385 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003386 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003387 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003388
3389 EXPECT_TRUE(channel_->SetSend(true));
3390
solenberge5269742015-09-08 05:13:22 -07003391 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003392
sprangc5d62e22017-04-02 23:53:04 -07003393 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003394 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003395 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3396 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003397
3398 EXPECT_TRUE(capturer.CaptureFrame());
3399 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3400
perkj26752742016-10-24 01:21:16 -07003401 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3402 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003403
Niels Möllerff40b142018-04-09 08:49:14 +02003404 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003405 return;
3406 }
3407
sprangc5d62e22017-04-02 23:53:04 -07003408 if (is_screenshare) {
3409 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3410 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3411 } else {
3412 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3413 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3414 }
3415
perkj803d97f2016-11-01 11:45:46 -07003416 // Trigger overuse.
3417 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3418
3419 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003420 if (is_screenshare) {
3421 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3422 } else {
3423 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3424 }
perkj803d97f2016-11-01 11:45:46 -07003425 send_stream->InjectVideoSinkWants(wants);
3426
sprangc5d62e22017-04-02 23:53:04 -07003427 for (int i = 0; i < kDefaultFps; ++i)
3428 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003429
sprangc5d62e22017-04-02 23:53:04 -07003430 if (is_screenshare) {
3431 // Drops every third frame.
3432 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3433 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3434 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3435 } else {
3436 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3437 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3438 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3439 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003440
3441 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003442 int last_pixel_count =
3443 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003444 if (is_screenshare) {
3445 wants.max_framerate_fps = kDefaultFps;
3446 } else {
3447 wants.max_pixel_count = last_pixel_count * 4;
3448 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3449 }
perkj803d97f2016-11-01 11:45:46 -07003450 send_stream->InjectVideoSinkWants(wants);
3451
sprangc5d62e22017-04-02 23:53:04 -07003452 for (int i = 0; i < kDefaultFps; ++i)
3453 EXPECT_TRUE(capturer.CaptureFrame());
3454
3455 if (is_screenshare) {
3456 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3457 send_stream->GetNumberOfSwappedFrames());
3458 } else {
3459 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3460 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003461
perkj26752742016-10-24 01:21:16 -07003462 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3463 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003464
Niels Möllerff40b142018-04-09 08:49:14 +02003465 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003466}
3467
eladalonf1841382017-06-12 01:16:46 -07003468TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003469 // Start at last timestamp to verify that wraparounds are estimated correctly.
3470 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3471 static const int64_t kInitialNtpTimeMs = 1247891230;
3472 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003473 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003474
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003475 FakeVideoReceiveStream* stream = AddRecvStream();
3476 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003477 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003478
nisse64ec8f82016-09-27 00:17:25 -07003479 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3480 kInitialTimestamp, 0,
3481 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003482 // Initial NTP time is not available on the first frame, but should still be
3483 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003484 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003485
3486 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003487
3488 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3489 // triggers a constant-overflow warning, hence we're calculating it explicitly
3490 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003491 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003492 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3493 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003494 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003495
3496 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003497
3498 // Verify that NTP time has been correctly deduced.
3499 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003500 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003501 ASSERT_EQ(1u, info.receivers.size());
3502 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003503}
3504
eladalonf1841382017-06-12 01:16:46 -07003505TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003506 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003507 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003508
3509 VideoCodec codec;
3510 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003511 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003512
3513 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003514 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3515 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003516 FakeVideoSendStream* stream = AddSendStream(
3517 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003518 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003519
3520 // Make sure NACK and FEC are enabled on the correct payload types.
3521 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003522 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3523 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003524
3525 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3526 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003527 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003528 // TODO(juberti): Check RTCP, PLI, TMMBR.
3529}
3530
brandtr31bd2242017-05-19 05:47:46 -07003531// The following four tests ensures that FlexFEC is not activated by default
3532// when the field trials are not enabled.
3533// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3534// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003535TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003536 FakeVideoSendStream* stream = AddSendStream();
3537 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3538
brandtr3d200bd2017-01-16 06:59:19 -08003539 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003540 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3541 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003542}
3543
eladalonf1841382017-06-12 01:16:46 -07003544TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003545 FakeVideoSendStream* stream = AddSendStream(
3546 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3547 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3548
brandtr3d200bd2017-01-16 06:59:19 -08003549 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003550 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3551 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3552}
3553
Yves Gerey665174f2018-06-19 15:03:05 +02003554TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003555 AddRecvStream();
3556
3557 const std::vector<FakeFlexfecReceiveStream*>& streams =
3558 fake_call_->GetFlexfecReceiveStreams();
3559 EXPECT_TRUE(streams.empty());
3560}
3561
eladalonf1841382017-06-12 01:16:46 -07003562TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003563 AddRecvStream(
3564 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3565
3566 const std::vector<FakeFlexfecReceiveStream*>& streams =
3567 fake_call_->GetFlexfecReceiveStreams();
3568 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003569}
3570
3571// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3572// tests that use this test fixture into the corresponding "non-field trial"
3573// tests.
eladalonf1841382017-06-12 01:16:46 -07003574class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003575 public:
eladalonf1841382017-06-12 01:16:46 -07003576 WebRtcVideoChannelFlexfecRecvTest()
3577 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003578};
3579
eladalonf1841382017-06-12 01:16:46 -07003580TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003581 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3582 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3583 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3584}
3585
eladalonf1841382017-06-12 01:16:46 -07003586TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003587 AddRecvStream();
3588
3589 const std::vector<FakeFlexfecReceiveStream*>& streams =
3590 fake_call_->GetFlexfecReceiveStreams();
3591 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003592
3593 const std::vector<FakeVideoReceiveStream*>& video_streams =
3594 fake_call_->GetVideoReceiveStreams();
3595 ASSERT_EQ(1U, video_streams.size());
3596 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3597 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3598 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003599}
3600
eladalonf1841382017-06-12 01:16:46 -07003601TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003602 AddRecvStream(
3603 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3604
3605 const std::vector<FakeFlexfecReceiveStream*>& streams =
3606 fake_call_->GetFlexfecReceiveStreams();
3607 ASSERT_EQ(1U, streams.size());
3608 const FakeFlexfecReceiveStream* stream = streams.front();
3609 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3610 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3611 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3612 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3613 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003614
3615 const std::vector<FakeVideoReceiveStream*>& video_streams =
3616 fake_call_->GetVideoReceiveStreams();
3617 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003618 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3619 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003620 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003621 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003622 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003623}
3624
eladalonf1841382017-06-12 01:16:46 -07003625TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003626 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3627 cricket::VideoRecvParameters recv_parameters;
3628 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3629 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3630
3631 AddRecvStream(
3632 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3633 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003634 const std::vector<FakeVideoReceiveStream*>& video_streams =
3635 fake_call_->GetVideoReceiveStreams();
3636 ASSERT_EQ(1U, video_streams.size());
3637 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3638 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3639 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003640
3641 // Enable FlexFEC.
3642 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3643 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3644 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3645 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3646 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3647 << "Enabling FlexFEC should not create VideoReceiveStream.";
3648 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3649 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003650 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3651 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003652}
3653
eladalonf1841382017-06-12 01:16:46 -07003654TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003655 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3656 cricket::VideoRecvParameters recv_parameters;
3657 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3658 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3659 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3660
3661 AddRecvStream(
3662 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3663 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003664 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003665 const std::vector<FakeVideoReceiveStream*>& video_streams =
3666 fake_call_->GetVideoReceiveStreams();
3667 ASSERT_EQ(1U, video_streams.size());
3668 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3669 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3670 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003671
3672 // Disable FlexFEC.
3673 recv_parameters.codecs.clear();
3674 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3675 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3676 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3677 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3678 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3679 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3680 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3681 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003682 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3683 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003684}
3685
brandtr31bd2242017-05-19 05:47:46 -07003686// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3687// tests that use this test fixture into the corresponding "non-field trial"
3688// tests.
eladalonf1841382017-06-12 01:16:46 -07003689class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003690 public:
eladalonf1841382017-06-12 01:16:46 -07003691 WebRtcVideoChannelFlexfecSendRecvTest()
3692 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003693 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3694 }
3695};
3696
Yves Gerey665174f2018-06-19 15:03:05 +02003697TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003698 FakeVideoSendStream* stream = AddSendStream();
3699 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3700
brandtr3d200bd2017-01-16 06:59:19 -08003701 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3702 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3703 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003704}
3705
eladalonf1841382017-06-12 01:16:46 -07003706TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003707 FakeVideoSendStream* stream = AddSendStream(
3708 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3709 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3710
brandtr3d200bd2017-01-16 06:59:19 -08003711 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3712 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3713 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3714 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003715}
3716
eladalonf1841382017-06-12 01:16:46 -07003717TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003718 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003719 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003720 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003721
3722 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003723 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003724
brandtrb5f2c3f2016-10-04 23:28:39 -07003725 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3726 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003727}
3728
eladalonf1841382017-06-12 01:16:46 -07003729TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003730 cricket::VideoSendParameters parameters;
3731 parameters.codecs.push_back(GetEngineCodec("VP8"));
3732 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3733
3734 FakeVideoSendStream* stream = AddSendStream();
3735 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3736
brandtr3d200bd2017-01-16 06:59:19 -08003737 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003738}
3739
eladalonf1841382017-06-12 01:16:46 -07003740TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003741 AddRecvStream(
3742 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003743
3744 cricket::VideoRecvParameters recv_parameters;
3745 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3746 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3747 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003748
3749 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3750 fake_call_->GetFlexfecReceiveStreams();
3751 ASSERT_EQ(1U, flexfec_streams.size());
3752 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3753 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3754 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003755 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003756 flexfec_stream_config.payload_type);
3757 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3758 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3759 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3760 const std::vector<FakeVideoReceiveStream*>& video_streams =
3761 fake_call_->GetVideoReceiveStreams();
3762 const FakeVideoReceiveStream* video_stream = video_streams.front();
3763 const webrtc::VideoReceiveStream::Config& video_stream_config =
3764 video_stream->GetConfig();
3765 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3766 flexfec_stream_config.local_ssrc);
3767 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3768 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3769 flexfec_stream_config.rtcp_send_transport);
3770 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3771 // spec-compliant way.
3772 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3773 flexfec_stream_config.transport_cc);
3774 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3775 EXPECT_EQ(video_stream_config.rtp.extensions,
3776 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003777}
3778
brandtr31bd2242017-05-19 05:47:46 -07003779// We should not send FlexFEC, even if we advertise it, unless the right
3780// field trial is set.
3781// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003782TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003783 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3784 cricket::VideoSendParameters parameters;
3785 parameters.codecs.push_back(GetEngineCodec("VP8"));
3786 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3787 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3788
3789 FakeVideoSendStream* stream = AddSendStream();
3790 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3791
3792 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003793 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003794 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3795}
3796
eladalonf1841382017-06-12 01:16:46 -07003797TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003798 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3799 cricket::VideoSendParameters parameters;
3800 parameters.codecs.push_back(GetEngineCodec("VP8"));
3801 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3802 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3803
3804 FakeVideoSendStream* stream = AddSendStream(
3805 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3806 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3807
3808 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003809 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003810 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3811}
3812
eladalonf1841382017-06-12 01:16:46 -07003813TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003814 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003815 const int kUnusedPayloadType = 127;
3816 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3817
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003818 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003819 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003820 parameters.codecs.push_back(rtx_codec);
3821 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003822 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003823}
3824
eladalonf1841382017-06-12 01:16:46 -07003825TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003826 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003827 const int kUnusedPayloadType1 = 126;
3828 const int kUnusedPayloadType2 = 127;
3829 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3830 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3831 {
3832 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3833 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3834 cricket::VideoSendParameters parameters;
3835 parameters.codecs.push_back(GetEngineCodec("VP8"));
3836 parameters.codecs.push_back(rtx_codec);
3837 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3838 }
3839 {
3840 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3841 kUnusedPayloadType1, kUnusedPayloadType2);
3842 cricket::VideoSendParameters parameters;
3843 parameters.codecs.push_back(GetEngineCodec("VP8"));
3844 parameters.codecs.push_back(rtx_codec);
3845 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3846 << "RTX without matching video codec should be rejected.";
3847 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003848}
3849
eladalonf1841382017-06-12 01:16:46 -07003850TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003851 const int kUnusedPayloadType1 = 126;
3852 const int kUnusedPayloadType2 = 127;
3853 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3854 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3855
3856 // SSRCs for RTX.
3857 cricket::StreamParams params =
3858 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3859 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3860 AddSendStream(params);
3861
3862 // Original payload type for RTX.
3863 cricket::VideoSendParameters parameters;
3864 parameters.codecs.push_back(GetEngineCodec("VP8"));
3865 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3866 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3867 parameters.codecs.push_back(rtx_codec);
3868 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3869 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3870 const webrtc::VideoSendStream::Config& config_before =
3871 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3872 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3873 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3874 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3875
3876 // Change payload type for RTX.
3877 parameters.codecs[1].id = kUnusedPayloadType2;
3878 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3879 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3880 const webrtc::VideoSendStream::Config& config_after =
3881 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3882 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3883 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3884 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3885}
3886
eladalonf1841382017-06-12 01:16:46 -07003887TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003888 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003889 parameters.codecs.push_back(GetEngineCodec("VP8"));
3890 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003891 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003892
3893 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003894 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003895
magjed509e4fe2016-11-18 01:34:11 -08003896 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003897
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003898 parameters.codecs.pop_back();
3899 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003900 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003901 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003902 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003903 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003904 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3905}
3906
eladalonf1841382017-06-12 01:16:46 -07003907TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003908 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003909 cricket::VideoSendParameters parameters;
3910 parameters.codecs.push_back(GetEngineCodec("VP8"));
3911 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3912 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3913
3914 FakeVideoSendStream* stream = AddSendStream(
3915 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3916 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3917
brandtr3d200bd2017-01-16 06:59:19 -08003918 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3919 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003920 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3921 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3922
3923 parameters.codecs.pop_back();
3924 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3925 stream = fake_call_->GetVideoSendStreams()[0];
3926 ASSERT_TRUE(stream != nullptr);
3927 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003928 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003929 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003930}
3931
eladalonf1841382017-06-12 01:16:46 -07003932TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003933 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003934 cricket::VideoCodec codec(100, "VP8");
3935 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3936 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003937
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003938 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003939 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003940
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003941 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003942 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003943 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003944
3945 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003946 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003947
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003948 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003949 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3950 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003951 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003952 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003953 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003954 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003955}
3956
eladalonf1841382017-06-12 01:16:46 -07003957TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003958 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3959 200000);
3960}
3961
eladalonf1841382017-06-12 01:16:46 -07003962TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003963 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3964 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3965 ASSERT_EQ(1u, streams.size());
3966 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3967}
3968
eladalonf1841382017-06-12 01:16:46 -07003969TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003970 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003971 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003972}
3973
eladalonf1841382017-06-12 01:16:46 -07003974TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003975 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003976}
3977
eladalonf1841382017-06-12 01:16:46 -07003978TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003979 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3980 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3981 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003982}
3983
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003984// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3985// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003986TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003987 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3988 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3989 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3990 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003991 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003992 ExpectSetBitrateParameters(100000, 200000, 400000);
3993 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3994 // Since the codec isn't changing, start_bitrate_bps should be -1.
3995 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003996
3997 // Decrease max_bandwidth_bps.
3998 send_parameters_.max_bandwidth_bps = 350000;
3999 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004000
4001 // Now try again with the values flipped around.
4002 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4003 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004004 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004005 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004006
4007 // If we change the codec max, max_bandwidth_bps should still apply.
4008 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004009 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004010 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004011}
4012
Yves Gerey665174f2018-06-19 15:03:05 +02004013TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004014 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4015 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004016 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004017 // Setting max bitrate should keep previous min bitrate.
4018 // Setting max bitrate should not reset start bitrate.
4019 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004020 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004021}
4022
eladalonf1841382017-06-12 01:16:46 -07004023TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004024 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004025 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004026 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004027 // -1 means to disable max bitrate (set infinite).
4028 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004029 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004030 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004031}
4032
eladalonf1841382017-06-12 01:16:46 -07004033TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004034 send_parameters_.max_bandwidth_bps = 99999;
4035 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004036 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004037 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004038 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4039 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4040 stream->GetVideoStreams()[0].max_bitrate_bps);
4041
4042 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004043 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004044 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4045 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004046 stream->GetVideoStreams()[0].max_bitrate_bps);
4047}
4048
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004049// Tests that when the codec specific max bitrate and VideoSendParameters
4050// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4051// appropriately.
4052TEST_F(WebRtcVideoChannelTest,
4053 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4054 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4055 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4056 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4057 send_parameters_.max_bandwidth_bps = -1;
4058 AddSendStream();
4059 ExpectSetMaxBitrate(300000);
4060 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4061
4062 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4063 ASSERT_EQ(1u, video_send_streams.size());
4064 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4065 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4066 // First the max bitrate is set based upon the codec param.
4067 EXPECT_EQ(300000,
4068 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4069
4070 // The VideoSendParameters max bitrate overrides the codec's.
4071 send_parameters_.max_bandwidth_bps = 500000;
4072 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4073 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4074 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4075 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4076}
4077
4078// Tests that when the codec specific max bitrate and RtpParameters
4079// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4080// appropriately.
4081TEST_F(WebRtcVideoChannelTest,
4082 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4083 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4084 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4085 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4086 send_parameters_.max_bandwidth_bps = -1;
4087 AddSendStream();
4088 ExpectSetMaxBitrate(300000);
4089 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4090
4091 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4092 ASSERT_EQ(1u, video_send_streams.size());
4093 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4094 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4095 // First the max bitrate is set based upon the codec param.
4096 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4097
4098 // The RtpParameter max bitrate overrides the codec's.
4099 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4100 ASSERT_EQ(1u, parameters.encodings.size());
4101 parameters.encodings[0].max_bitrate_bps = 500000;
4102 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4103 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4104 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4105 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4106}
4107
Åsa Persson55659812018-06-18 17:51:32 +02004108TEST_F(WebRtcVideoChannelTest,
4109 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4110 send_parameters_.max_bandwidth_bps = 99999;
4111 FakeVideoSendStream* stream = AddSendStream();
4112 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4113 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4114 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4115 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4116 stream->GetVideoStreams()[0].max_bitrate_bps);
4117
4118 // Get and set the rtp encoding parameters.
4119 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4120 EXPECT_EQ(1u, parameters.encodings.size());
4121
4122 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4123 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4124 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4125 stream->GetVideoStreams()[0].max_bitrate_bps);
4126
4127 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4128 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4129 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4130 stream->GetVideoStreams()[0].max_bitrate_bps);
4131}
4132
eladalonf1841382017-06-12 01:16:46 -07004133TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004134 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004135 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004136 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004137 channel_->SetSend(true);
4138
4139 FakeVideoSendStream* stream = AddSendStream();
4140
Tommi85959932018-02-07 19:26:06 +01004141 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004142 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004143 EXPECT_EQ(cricket::CS_RUNNING,
4144 capturer.Start(capturer.GetSupportedFormats()->front()));
4145
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004146 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4147 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4148 EXPECT_GT(initial_max_bitrate_bps, 0);
4149
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004150 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4151 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004152 // Insert a frame to update the encoder config.
4153 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004154 streams = stream->GetVideoStreams();
4155 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004156 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004157}
4158
eladalonf1841382017-06-12 01:16:46 -07004159TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004160 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004161 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004162 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004163 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004164 channel_->SetSend(true);
4165
4166 FakeVideoSendStream* stream = AddSendStream(
4167 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4168
4169 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004170 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004171 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004172 EXPECT_EQ(cricket::CS_RUNNING,
4173 capturer.Start(capturer.GetSupportedFormats()->front()));
4174 EXPECT_TRUE(capturer.CaptureFrame());
4175
4176 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4177 ASSERT_GT(streams.size(), 1u)
4178 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004179 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004180 EXPECT_GT(initial_max_bitrate_bps, 0);
4181
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004182 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4183 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004184 // Insert a frame to update the encoder config.
4185 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004186 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004187 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004188 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4189
Niels Möllerff40b142018-04-09 08:49:14 +02004190 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004191}
4192
eladalonf1841382017-06-12 01:16:46 -07004193TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004194 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004195 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004196 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004197 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4198 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004199 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004200 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004201
4202 VideoCodec codec;
4203 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4204 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4205}
4206
eladalonf1841382017-06-12 01:16:46 -07004207TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004208 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004209 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004210 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004211 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004212 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004213 parameters.codecs[0].id = kIncorrectPayloads[i];
4214 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004215 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004216 }
4217}
4218
eladalonf1841382017-06-12 01:16:46 -07004219TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004220 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004221 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004222 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004223 parameters.codecs[0].id = payload_type;
4224 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004225 << "Payload type '" << payload_type << "' rejected.";
4226 }
4227}
4228
deadbeef67cf2c12016-04-13 10:07:16 -07004229// Test that setting the a different set of codecs but with an identical front
4230// codec doesn't result in the stream being recreated.
4231// This may happen when a subsequent negotiation includes fewer codecs, as a
4232// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004233TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004234 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4235 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004236 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4237 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004238 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4239
4240 AddSendStream();
4241 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4242
4243 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004244 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004245 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4246 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4247}
4248
eladalonf1841382017-06-12 01:16:46 -07004249TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004250 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004251 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004252 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004253}
4254
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004255// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004256TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004257 const int kUnusedPayloadType1 = 126;
4258 const int kUnusedPayloadType2 = 127;
4259 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4260 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4261
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004262 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004263 parameters.codecs.push_back(GetEngineCodec("VP8"));
4264 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004265 parameters.codecs.push_back(rtx_codec);
4266 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004267 << "RTX codec without associated payload should be rejected.";
4268
magjed509e4fe2016-11-18 01:34:11 -08004269 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004270 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004271 << "RTX codec with invalid associated payload type should be rejected.";
4272
magjed509e4fe2016-11-18 01:34:11 -08004273 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004274 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004275
magjed509e4fe2016-11-18 01:34:11 -08004276 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004277 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004278 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004279
Yves Gerey665174f2018-06-19 15:03:05 +02004280 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4281 << "RTX codec with another RTX as associated payload type should be "
4282 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004283}
4284
eladalonf1841382017-06-12 01:16:46 -07004285TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004286 const int kUnusedPayloadType1 = 126;
4287 const int kUnusedPayloadType2 = 127;
4288 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4289 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4290
4291 // SSRCs for RTX.
4292 cricket::StreamParams params =
4293 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4294 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4295 AddRecvStream(params);
4296
4297 // Original payload type for RTX.
4298 cricket::VideoRecvParameters parameters;
4299 parameters.codecs.push_back(GetEngineCodec("VP8"));
4300 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4301 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4302 parameters.codecs.push_back(rtx_codec);
4303 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4304 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4305 const webrtc::VideoReceiveStream::Config& config_before =
4306 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004307 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4308 const int* payload_type_before = FindKeyByValue(
4309 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4310 ASSERT_NE(payload_type_before, nullptr);
4311 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004312 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4313
4314 // Change payload type for RTX.
4315 parameters.codecs[1].id = kUnusedPayloadType2;
4316 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4317 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4318 const webrtc::VideoReceiveStream::Config& config_after =
4319 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004320 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4321 const int* payload_type_after = FindKeyByValue(
4322 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4323 ASSERT_NE(payload_type_after, nullptr);
4324 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004325 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4326}
4327
eladalonf1841382017-06-12 01:16:46 -07004328TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004329 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004330 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004331 parameters.codecs[0].id = 99;
4332 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004333}
4334
eladalonf1841382017-06-12 01:16:46 -07004335TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004336 cricket::VideoRecvParameters parameters;
4337 parameters.codecs = engine_.codecs();
4338 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004339
4340 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004341 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004342 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004343 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004344}
4345
eladalonf1841382017-06-12 01:16:46 -07004346TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004347 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004348 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004349 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004350 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004351}
4352
eladalonf1841382017-06-12 01:16:46 -07004353TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004354 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004355 parameters.codecs.push_back(GetEngineCodec("VP8"));
4356 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004357 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004358}
4359
eladalonf1841382017-06-12 01:16:46 -07004360TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004361 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004362 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4363 send_parameters.codecs.push_back(GetEngineCodec("red"));
4364 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004365 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004366
4367 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004368
magjed509e4fe2016-11-18 01:34:11 -08004369 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004370 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004371
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004372 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004373 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004374 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004375 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004376 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004377 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004378 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4379}
4380
eladalonf1841382017-06-12 01:16:46 -07004381TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004382 AddRecvStream(
4383 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004384 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004385 fake_call_->GetFlexfecReceiveStreams();
4386
4387 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004388 const FakeFlexfecReceiveStream* stream = streams.front();
4389 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4390 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4391 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4392 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004393
4394 cricket::VideoRecvParameters recv_parameters;
4395 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4396 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4397 EXPECT_TRUE(streams.empty())
4398 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004399}
4400
eladalonf1841382017-06-12 01:16:46 -07004401TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004402 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004403 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004404 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004405
4406 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004407 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4408 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4409 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004410 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4411 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004412 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004413 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004414 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004415 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004416
4417 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004418 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4419 send_parameters.codecs.push_back(GetEngineCodec("red"));
4420 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004421 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4422 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004423 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004424 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004425 << "ULPFEC should be enabled on the receive stream.";
4426}
4427
eladalonf1841382017-06-12 01:16:46 -07004428TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004429 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004430 AddRecvStream(
4431 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004432 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004433 fake_call_->GetFlexfecReceiveStreams();
4434
4435 cricket::VideoRecvParameters recv_parameters;
4436 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4437 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4438 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4439 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004440 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004441 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004442 stream_with_recv_params->GetConfig().payload_type);
4443 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004444 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004445 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004446 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004447 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004448
4449 cricket::VideoSendParameters send_parameters;
4450 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4451 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4452 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4453 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004454 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004455 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004456 stream_with_send_params->GetConfig().payload_type);
4457 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004458 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004459 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004460 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004461 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004462}
4463
eladalonf1841382017-06-12 01:16:46 -07004464TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004465 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004466 parameters.codecs.push_back(GetEngineCodec("VP8"));
4467 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004468 parameters.codecs[1].id = parameters.codecs[0].id;
4469 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004470}
4471
eladalonf1841382017-06-12 01:16:46 -07004472TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004473 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004474 cricket::VideoRecvParameters parameters;
4475 parameters.codecs.push_back(GetEngineCodec("VP8"));
4476 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4477 parameters.codecs[1].id = parameters.codecs[0].id;
4478 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4479}
4480
eladalonf1841382017-06-12 01:16:46 -07004481TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004482 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004483 parameters.codecs.push_back(GetEngineCodec("VP8"));
4484 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004485 parameters.codecs[1].id = parameters.codecs[0].id;
4486 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004487}
4488
eladalonf1841382017-06-12 01:16:46 -07004489TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004490 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004491 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004492 parameters.codecs.push_back(GetEngineCodec("VP8"));
4493 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004494 parameters.codecs[1].id += 1;
4495 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004496}
4497
deadbeef67cf2c12016-04-13 10:07:16 -07004498// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004499// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004500TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004501 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004502 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004503 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4504 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004505 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004506
4507 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4508 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4509
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004510 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004511 parameters2.codecs.push_back(GetEngineCodec("red"));
4512 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004513 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004514 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4515}
4516
eladalonf1841382017-06-12 01:16:46 -07004517TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004518 EXPECT_FALSE(AddSendStream()->IsSending());
4519}
4520
eladalonf1841382017-06-12 01:16:46 -07004521TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004522 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004523}
4524
eladalonf1841382017-06-12 01:16:46 -07004525TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004526 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004527 EXPECT_FALSE(stream->IsSending());
4528
4529 // false->true
4530 EXPECT_TRUE(channel_->SetSend(true));
4531 EXPECT_TRUE(stream->IsSending());
4532 // true->true
4533 EXPECT_TRUE(channel_->SetSend(true));
4534 EXPECT_TRUE(stream->IsSending());
4535 // true->false
4536 EXPECT_TRUE(channel_->SetSend(false));
4537 EXPECT_FALSE(stream->IsSending());
4538 // false->false
4539 EXPECT_TRUE(channel_->SetSend(false));
4540 EXPECT_FALSE(stream->IsSending());
4541
4542 EXPECT_TRUE(channel_->SetSend(true));
4543 FakeVideoSendStream* new_stream = AddSendStream();
4544 EXPECT_TRUE(new_stream->IsSending())
4545 << "Send stream created after SetSend(true) not sending initially.";
4546}
4547
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004548// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004549TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004550 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004551 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004552 MediaConfig config;
kwiberg686a8ef2016-02-26 03:00:35 -08004553 std::unique_ptr<VideoMediaChannel> channel;
nisse51542be2016-02-12 02:27:06 -08004554
4555 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4556 channel->SetInterface(network_interface.get());
4557 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004558 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004559
4560 config.enable_dscp = true;
4561 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4562 channel->SetInterface(network_interface.get());
4563 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
4564
4565 // Verify that setting the option to false resets the
4566 // DiffServCodePoint.
4567 config.enable_dscp = false;
4568 channel.reset(engine_.CreateChannel(call_.get(), config, VideoOptions()));
4569 channel->SetInterface(network_interface.get());
4570 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004571}
4572
deadbeef13871492015-12-09 12:37:51 -08004573// This test verifies that the RTCP reduced size mode is properly applied to
4574// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004575TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004576 // Create stream, expecting that default mode is "compound".
4577 FakeVideoSendStream* stream1 = AddSendStream();
4578 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004579 webrtc::RtpParameters rtp_parameters =
4580 channel_->GetRtpSendParameters(last_ssrc_);
4581 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004582
4583 // Now enable reduced size mode.
4584 send_parameters_.rtcp.reduced_size = true;
4585 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4586 stream1 = fake_call_->GetVideoSendStreams()[0];
4587 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004588 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4589 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004590
4591 // Create a new stream and ensure it picks up the reduced size mode.
4592 FakeVideoSendStream* stream2 = AddSendStream();
4593 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4594}
4595
4596// This test verifies that the RTCP reduced size mode is properly applied to
4597// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004598TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004599 // Create stream, expecting that default mode is "compound".
4600 FakeVideoReceiveStream* stream1 = AddRecvStream();
4601 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4602
4603 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004604 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4605 // the reduced_size flag should come from that.
4606 send_parameters_.rtcp.reduced_size = true;
4607 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004608 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4609 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4610
4611 // Create a new stream and ensure it picks up the reduced size mode.
4612 FakeVideoReceiveStream* stream2 = AddRecvStream();
4613 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4614}
4615
eladalonf1841382017-06-12 01:16:46 -07004616TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004617 EXPECT_EQ(webrtc::kNetworkUp,
4618 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4619 EXPECT_EQ(webrtc::kNetworkUp,
4620 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004621
4622 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004623 EXPECT_EQ(webrtc::kNetworkDown,
4624 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4625 EXPECT_EQ(webrtc::kNetworkUp,
4626 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004627
4628 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004629 EXPECT_EQ(webrtc::kNetworkUp,
4630 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4631 EXPECT_EQ(webrtc::kNetworkUp,
4632 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004633}
4634
eladalonf1841382017-06-12 01:16:46 -07004635TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004636 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004637 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004638 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004639
4640 AddSendStream();
4641
4642 cricket::VideoMediaInfo info;
4643 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004644 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004645}
4646
eladalonf1841382017-06-12 01:16:46 -07004647TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004648 FakeVideoSendStream* stream = AddSendStream();
4649 webrtc::VideoSendStream::Stats stats;
4650 stats.encoder_implementation_name = "encoder_implementation_name";
4651 stream->SetStats(stats);
4652
4653 cricket::VideoMediaInfo info;
4654 ASSERT_TRUE(channel_->GetStats(&info));
4655 EXPECT_EQ(stats.encoder_implementation_name,
4656 info.senders[0].encoder_implementation_name);
4657}
4658
eladalonf1841382017-06-12 01:16:46 -07004659TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004660 FakeVideoSendStream* stream = AddSendStream();
4661 webrtc::VideoSendStream::Stats stats;
4662 stats.avg_encode_time_ms = 13;
4663 stats.encode_usage_percent = 42;
4664 stream->SetStats(stats);
4665
4666 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004667 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004668 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4669 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4670}
4671
eladalonf1841382017-06-12 01:16:46 -07004672TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004673 FakeVideoSendStream* stream = AddSendStream();
4674 webrtc::VideoSendStream::Stats stats;
4675 stats.frames_encoded = 13;
4676 stream->SetStats(stats);
4677
4678 cricket::VideoMediaInfo info;
4679 ASSERT_TRUE(channel_->GetStats(&info));
4680 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4681}
4682
eladalonf1841382017-06-12 01:16:46 -07004683TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004684 FakeVideoSendStream* stream = AddSendStream();
4685 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004686 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004687 stream->SetStats(stats);
4688
4689 cricket::VideoMediaInfo info;
4690 ASSERT_TRUE(channel_->GetStats(&info));
4691 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4692}
4693
eladalonf1841382017-06-12 01:16:46 -07004694TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004695 FakeVideoSendStream* stream = AddSendStream();
4696 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004697 stats.substreams[17].width = 123;
4698 stats.substreams[17].height = 40;
4699 stats.substreams[42].width = 80;
4700 stats.substreams[42].height = 31;
4701 stats.substreams[11].width = 20;
4702 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004703 stream->SetStats(stats);
4704
4705 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004706 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004707 ASSERT_EQ(1u, info.senders.size());
4708 EXPECT_EQ(123, info.senders[0].send_frame_width);
4709 EXPECT_EQ(90, info.senders[0].send_frame_height);
4710}
4711
eladalonf1841382017-06-12 01:16:46 -07004712TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004713 FakeVideoSendStream* stream = AddSendStream();
4714 webrtc::VideoSendStream::Stats stats;
4715 stats.number_of_cpu_adapt_changes = 2;
4716 stats.cpu_limited_resolution = true;
4717 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004718
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004719 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004720 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004721 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004722 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004723 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004724}
4725
eladalonf1841382017-06-12 01:16:46 -07004726TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004727 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004728 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004729 stats.number_of_cpu_adapt_changes = 2;
4730 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004731 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004732 stream->SetStats(stats);
4733
4734 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004735 EXPECT_TRUE(channel_->GetStats(&info));
4736 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004737 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4738 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004739 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004740 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004741}
4742
eladalonf1841382017-06-12 01:16:46 -07004743TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004744 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4745 FakeVideoSendStream* stream = AddSendStream();
4746 webrtc::VideoSendStream::Stats stats;
4747 stats.bw_limited_resolution = true;
4748 stream->SetStats(stats);
4749
4750 cricket::VideoMediaInfo info;
4751 EXPECT_TRUE(channel_->GetStats(&info));
4752 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004753 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004754 info.senders[0].adapt_reason);
4755}
4756
Yves Gerey665174f2018-06-19 15:03:05 +02004757TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004758 FakeVideoSendStream* stream = AddSendStream();
4759 webrtc::VideoSendStream::Stats stats;
4760 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4761 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4762 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4763
4764 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4765 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4766 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4767
4768 stream->SetStats(stats);
4769
4770 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004771 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004772 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4773 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4774 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4775}
4776
eladalonf1841382017-06-12 01:16:46 -07004777TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004778 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4779 FakeVideoReceiveStream* stream = AddRecvStream();
4780 webrtc::VideoReceiveStream::Stats stats;
4781 stats.rtcp_packet_type_counts.fir_packets = 2;
4782 stats.rtcp_packet_type_counts.nack_packets = 3;
4783 stats.rtcp_packet_type_counts.pli_packets = 4;
4784 stream->SetStats(stats);
4785
4786 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004787 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004788 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004789 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004790 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004791 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004792 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004793 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004794}
4795
eladalonf1841382017-06-12 01:16:46 -07004796TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004797 FakeVideoReceiveStream* stream = AddRecvStream();
4798 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004799 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004800 stats.decode_ms = 2;
4801 stats.max_decode_ms = 3;
4802 stats.current_delay_ms = 4;
4803 stats.target_delay_ms = 5;
4804 stats.jitter_buffer_ms = 6;
4805 stats.min_playout_delay_ms = 7;
4806 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004807 stats.width = 9;
4808 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004809 stats.frame_counts.key_frames = 11;
4810 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004811 stats.frames_rendered = 13;
4812 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004813 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004814 stream->SetStats(stats);
4815
4816 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004817 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004818 EXPECT_EQ(stats.decoder_implementation_name,
4819 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004820 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4821 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4822 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4823 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4824 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4825 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4826 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004827 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4828 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004829 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4830 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004831 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004832 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004833 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004834 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004835}
4836
eladalonf1841382017-06-12 01:16:46 -07004837TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004838 FakeVideoReceiveStream* stream = AddRecvStream();
4839 webrtc::VideoReceiveStream::Stats stats;
4840 stats.rtp_stats.transmitted.payload_bytes = 2;
4841 stats.rtp_stats.transmitted.header_bytes = 3;
4842 stats.rtp_stats.transmitted.padding_bytes = 4;
4843 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004844 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004845 stats.rtcp_stats.fraction_lost = 7;
4846 stream->SetStats(stats);
4847
4848 cricket::VideoMediaInfo info;
4849 ASSERT_TRUE(channel_->GetStats(&info));
4850 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4851 stats.rtp_stats.transmitted.header_bytes +
4852 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004853 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004854 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004855 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004856 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004857 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004858 info.receivers[0].fraction_lost);
4859}
4860
eladalonf1841382017-06-12 01:16:46 -07004861TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004862 AddSendStream();
4863 AddSendStream();
4864 webrtc::Call::Stats stats;
4865 stats.rtt_ms = 123;
4866 fake_call_->SetStats(stats);
4867
4868 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004869 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004870 ASSERT_EQ(2u, info.senders.size());
4871 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4872 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4873}
4874
eladalonf1841382017-06-12 01:16:46 -07004875TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004876 FakeVideoSendStream* stream = AddSendStream();
4877 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004878 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004879 stats.media_bitrate_bps = 123;
4880 stats.substreams[17].total_bitrate_bps = 1;
4881 stats.substreams[17].retransmit_bitrate_bps = 2;
4882 stats.substreams[42].total_bitrate_bps = 3;
4883 stats.substreams[42].retransmit_bitrate_bps = 4;
4884 stream->SetStats(stats);
4885
4886 FakeVideoSendStream* stream2 = AddSendStream();
4887 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004888 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004889 stats2.media_bitrate_bps = 321;
4890 stats2.substreams[13].total_bitrate_bps = 5;
4891 stats2.substreams[13].retransmit_bitrate_bps = 6;
4892 stats2.substreams[21].total_bitrate_bps = 7;
4893 stats2.substreams[21].retransmit_bitrate_bps = 8;
4894 stream2->SetStats(stats2);
4895
4896 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004897 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004898 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004899 BandwidthEstimationInfo bwe_info;
4900 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004901 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4902 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4903 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4904 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004905 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004906 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004907 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004908 bwe_info.actual_enc_bitrate);
4909 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004910 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004911 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004912 << "Bandwidth stats should take all streams into account.";
4913}
4914
eladalonf1841382017-06-12 01:16:46 -07004915TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004916 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004917
Peter Boström0c4e06b2015-10-07 12:23:21 +02004918 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4919 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004920
4921 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4922 const size_t kDataLength = 12;
4923 uint8_t data[kDataLength];
4924 memset(data, 0, sizeof(data));
4925 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004926 rtc::CopyOnWriteBuffer packet(data, kDataLength);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004927 rtc::PacketTime packet_time;
4928 channel_->OnPacketReceived(&packet, packet_time);
4929
4930 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4931 << "No default receive stream created.";
4932 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004933 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004934 << "Default receive stream should not have configured RTX";
4935
4936 EXPECT_TRUE(channel_->AddRecvStream(
4937 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4938 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004939 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004940 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004941 EXPECT_FALSE(
4942 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004943 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004944 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004945 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004946 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004947 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004948 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004949}
4950
eladalonf1841382017-06-12 01:16:46 -07004951TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004952 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004953
Peter Boström0c4e06b2015-10-07 12:23:21 +02004954 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4955 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004956
4957 StreamParams sp =
4958 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4959 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4960
4961 EXPECT_FALSE(channel_->AddSendStream(sp));
4962 EXPECT_FALSE(channel_->AddRecvStream(sp));
4963}
4964
eladalonf1841382017-06-12 01:16:46 -07004965TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004966 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004967
Peter Boström0c4e06b2015-10-07 12:23:21 +02004968 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4969 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004970
4971 StreamParams sp =
4972 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4973
4974 EXPECT_TRUE(channel_->AddSendStream(sp));
4975 EXPECT_TRUE(channel_->AddRecvStream(sp));
4976
4977 // The RTX SSRC is already used in previous streams, using it should fail.
4978 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4979 EXPECT_FALSE(channel_->AddSendStream(sp));
4980 EXPECT_FALSE(channel_->AddRecvStream(sp));
4981
4982 // After removing the original stream this should be fine to add (makes sure
4983 // that RTX ssrcs are not forever taken).
4984 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4985 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4986 EXPECT_TRUE(channel_->AddSendStream(sp));
4987 EXPECT_TRUE(channel_->AddRecvStream(sp));
4988}
4989
eladalonf1841382017-06-12 01:16:46 -07004990TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004991 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004992 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4993 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004994 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004995
Peter Boströmd6f4c252015-03-26 16:23:04 +01004996 StreamParams sp =
4997 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4998
4999 EXPECT_TRUE(channel_->AddSendStream(sp));
5000 EXPECT_TRUE(channel_->AddRecvStream(sp));
5001
5002 // One of the SSRCs is already used in previous streams, using it should fail.
5003 sp = cricket::CreateSimStreamParams("cname",
5004 MAKE_VECTOR(kOverlappingStreamSsrcs));
5005 EXPECT_FALSE(channel_->AddSendStream(sp));
5006 EXPECT_FALSE(channel_->AddRecvStream(sp));
5007
5008 // After removing the original stream this should be fine to add (makes sure
5009 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005010 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5011 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005012 EXPECT_TRUE(channel_->AddSendStream(sp));
5013 EXPECT_TRUE(channel_->AddRecvStream(sp));
5014}
5015
eladalonf1841382017-06-12 01:16:46 -07005016TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005017 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005018
5019 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5020 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5021
5022 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5023 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5024
5025 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5026
5027 static const uint32_t kReceiverSsrcs[] = {3};
5028 static const uint32_t kReceiverRtxSsrcs[] = {2};
5029
5030 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5031 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5032 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5033
5034 cricket::VideoMediaInfo info;
5035 ASSERT_TRUE(channel_->GetStats(&info));
5036
5037 ASSERT_EQ(1u, info.senders.size());
5038 ASSERT_EQ(1u, info.receivers.size());
5039
5040 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5041 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5042 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5043}
5044
eladalonf1841382017-06-12 01:16:46 -07005045TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005046 FakeVideoReceiveStream* stream = AddRecvStream();
5047 webrtc::VideoReceiveStream::Stats stats;
5048 cricket::VideoMediaInfo info;
5049
5050 // Report no codec name before receiving.
5051 stream->SetStats(stats);
5052 ASSERT_TRUE(channel_->GetStats(&info));
5053 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5054
5055 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005056 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005057 stream->SetStats(stats);
5058 ASSERT_TRUE(channel_->GetStats(&info));
5059 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5060
5061 // Report no codec name for unknown playload types.
5062 stats.current_payload_type = 3;
5063 stream->SetStats(stats);
5064 ASSERT_TRUE(channel_->GetStats(&info));
5065 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5066}
5067
Seth Hampson5897a6e2018-04-03 11:16:33 -07005068// Tests that when we add a stream without SSRCs, but contains a stream_id
5069// that it is stored and its stream id is later used when the first packet
5070// arrives to properly create a receive stream with a sync label.
5071TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5072 const char kSyncLabel[] = "sync_label";
5073 cricket::StreamParams unsignaled_stream;
5074 unsignaled_stream.set_stream_ids({kSyncLabel});
5075 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5076 // The stream shouldn't have been created at this point because it doesn't
5077 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005078 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005079
5080 // Create and deliver packet.
5081 const size_t kDataLength = 12;
5082 uint8_t data[kDataLength];
5083 memset(data, 0, sizeof(data));
5084 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5085 rtc::CopyOnWriteBuffer packet(data, kDataLength);
5086 rtc::PacketTime packet_time;
5087 channel_->OnPacketReceived(&packet, packet_time);
5088
5089 // The stream should now be created with the appropriate sync label.
5090 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5091 EXPECT_EQ(kSyncLabel,
5092 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5093
5094 // Removing the unsignaled stream should clear the cache. This time when
5095 // a default video receive stream is created it won't have a sync_group.
5096 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5097 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5098 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5099
5100 channel_->OnPacketReceived(&packet, packet_time);
5101 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5102 EXPECT_TRUE(
5103 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5104}
5105
eladalonf1841382017-06-12 01:16:46 -07005106void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005107 uint8_t payload_type,
5108 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005109 // kRedRtxPayloadType must currently be unused.
5110 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5111
noahricd10a68e2015-07-10 11:27:55 -07005112 // Add a RED RTX codec.
5113 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005114 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005115 recv_parameters_.codecs.push_back(red_rtx_codec);
5116 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005117
5118 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5119 const size_t kDataLength = 12;
5120 uint8_t data[kDataLength];
5121 memset(data, 0, sizeof(data));
5122
5123 rtc::Set8(data, 1, payload_type);
5124 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005125 rtc::CopyOnWriteBuffer packet(data, kDataLength);
noahricd10a68e2015-07-10 11:27:55 -07005126 rtc::PacketTime packet_time;
5127 channel_->OnPacketReceived(&packet, packet_time);
5128
5129 if (expect_created_receive_stream) {
5130 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5131 << "Should have created a receive stream for payload type: "
5132 << payload_type;
5133 } else {
5134 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5135 << "Shouldn't have created a receive stream for payload type: "
5136 << payload_type;
5137 }
5138}
5139
eladalonf1841382017-06-12 01:16:46 -07005140TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005141 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5142 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005143}
5144
eladalonf1841382017-06-12 01:16:46 -07005145TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005146 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5147 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005148}
5149
eladalonf1841382017-06-12 01:16:46 -07005150TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005151 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005152 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5153 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5154 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5155 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005156}
5157
eladalonf1841382017-06-12 01:16:46 -07005158TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005159 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5160 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005161}
5162
eladalonf1841382017-06-12 01:16:46 -07005163TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005164 FlexfecPacketDoesntCreateUnsignalledStream) {
5165 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5166 false /* expect_created_receive_stream */);
5167}
5168
eladalonf1841382017-06-12 01:16:46 -07005169TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005170 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5171 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005172}
5173
mzanaty8a855d62017-02-17 15:46:43 -08005174// Test that receiving any unsignalled SSRC works even if it changes.
5175// The first unsignalled SSRC received will create a default receive stream.
5176// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005177TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005178 // Allow receiving VP8, VP9, H264 (if enabled).
5179 cricket::VideoRecvParameters parameters;
5180 parameters.codecs.push_back(GetEngineCodec("VP8"));
5181 parameters.codecs.push_back(GetEngineCodec("VP9"));
5182
5183#if defined(WEBRTC_USE_H264)
5184 cricket::VideoCodec H264codec(126, "H264");
5185 parameters.codecs.push_back(H264codec);
5186#endif
5187
5188 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5189 // No receive streams yet.
5190 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5191 cricket::FakeVideoRenderer renderer;
5192 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5193
5194 // Receive VP8 packet on first SSRC.
5195 uint8_t data[kMinRtpPacketLen];
5196 cricket::RtpHeader rtpHeader;
5197 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5198 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005199 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005200 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5201 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5202 rtc::PacketTime packet_time;
5203 channel_->OnPacketReceived(&packet, packet_time);
5204 // VP8 packet should create default receive stream.
5205 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005206 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005207 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5208 // Verify that the receive stream sinks to a renderer.
5209 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5210 webrtc::kVideoRotation_0);
5211 recv_stream->InjectFrame(video_frame);
5212 EXPECT_EQ(1, renderer.num_rendered_frames());
5213
5214 // Receive VP9 packet on second SSRC.
5215 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005216 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005217 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5218 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
5219 channel_->OnPacketReceived(&packet2, packet_time);
5220 // VP9 packet should replace the default receive SSRC.
5221 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5222 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5223 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5224 // Verify that the receive stream sinks to a renderer.
5225 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005226 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005227 recv_stream->InjectFrame(video_frame2);
5228 EXPECT_EQ(2, renderer.num_rendered_frames());
5229
5230#if defined(WEBRTC_USE_H264)
5231 // Receive H264 packet on third SSRC.
5232 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005233 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005234 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5235 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
5236 channel_->OnPacketReceived(&packet3, packet_time);
5237 // H264 packet should replace the default receive SSRC.
5238 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5239 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5240 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5241 // Verify that the receive stream sinks to a renderer.
5242 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005243 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005244 recv_stream->InjectFrame(video_frame3);
5245 EXPECT_EQ(3, renderer.num_rendered_frames());
5246#endif
5247}
5248
brandtr0dc57ea2017-05-29 23:33:31 -07005249// This test verifies that when a new default stream is created for a new
5250// unsignaled SSRC, the new stream does not overwrite any old stream that had
5251// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005252TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005253 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5254 cricket::VideoRecvParameters parameters;
5255 parameters.codecs.push_back(GetEngineCodec("VP8"));
5256 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5257
5258 // No streams signaled and no packets received, so we should not have any
5259 // stream objects created yet.
5260 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5261
5262 // Receive packet on an unsignaled SSRC.
5263 uint8_t data[kMinRtpPacketLen];
5264 cricket::RtpHeader rtp_header;
5265 rtp_header.payload_type = GetEngineCodec("VP8").id;
5266 rtp_header.seq_num = rtp_header.timestamp = 0;
5267 rtp_header.ssrc = kSsrcs3[0];
5268 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5269 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
5270 rtc::PacketTime packet_time;
5271 channel_->OnPacketReceived(&packet, packet_time);
5272 // Default receive stream should be created.
5273 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5274 FakeVideoReceiveStream* recv_stream0 =
5275 fake_call_->GetVideoReceiveStreams()[0];
5276 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5277
5278 // Signal the SSRC.
5279 EXPECT_TRUE(
5280 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5281 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5282 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5283 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5284
5285 // Receive packet on a different unsignaled SSRC.
5286 rtp_header.ssrc = kSsrcs3[1];
5287 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5288 packet.SetData(data, sizeof(data));
5289 channel_->OnPacketReceived(&packet, packet_time);
5290 // New default receive stream should be created, but old stream should remain.
5291 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5292 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5293 FakeVideoReceiveStream* recv_stream1 =
5294 fake_call_->GetVideoReceiveStreams()[1];
5295 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5296}
5297
Seth Hampson7c682e02018-05-04 16:28:15 -07005298TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005299 AddSendStream();
5300
Tommi85959932018-02-07 19:26:06 +01005301 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005302 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005303 cricket::VideoFormat capture_format_hd =
5304 capturer.GetSupportedFormats()->front();
5305 EXPECT_EQ(1280, capture_format_hd.width);
5306 EXPECT_EQ(720, capture_format_hd.height);
5307 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5308 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005309 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005310
perkjfa10b552016-10-02 23:45:26 -07005311 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005312 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005313
5314 // TODO(skvlad): Resolve the inconsistency between the interpretation
5315 // of the global bitrate limit for audio and video:
5316 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5317 // max_bandwidth_bps = -1 - remove the bandwidth limit
5318 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005319 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005320
perkjfa10b552016-10-02 23:45:26 -07005321 SetAndExpectMaxBitrate(1000, 0, 1000);
5322 SetAndExpectMaxBitrate(1000, 800, 800);
5323 SetAndExpectMaxBitrate(600, 800, 600);
5324 SetAndExpectMaxBitrate(0, 800, 800);
5325 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005326
Niels Möllerff40b142018-04-09 08:49:14 +02005327 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005328}
5329
eladalonf1841382017-06-12 01:16:46 -07005330TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005331 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005332 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005333 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005334
5335 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005336 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005337 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005338}
5339
eladalonf1841382017-06-12 01:16:46 -07005340TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005341 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005342 FakeVideoSendStream* stream = AddSendStream();
5343
Seth Hampson7c682e02018-05-04 16:28:15 -07005344 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5345 EXPECT_EQ(1UL, parameters.encodings.size());
5346 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5347 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5348
5349 // Note that this is testing the behavior of the FakeVideoSendStream, which
5350 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5351 // we are just testing the behavior of
5352 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005353 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5354 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005355
5356 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5357 // by this amount.
5358 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5359 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5360 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5361 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5362
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005363 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5364 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5365 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5366}
5367
5368TEST_F(WebRtcVideoChannelTest,
5369 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5370 FakeVideoSendStream* stream = AddSendStream();
5371
5372 // Note that this is testing the behavior of the FakeVideoSendStream, which
5373 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5374 // we are just testing the behavior of
5375 // EncoderStreamFactory::CreateEncoderStreams.
5376 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5377 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5378
5379 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5380 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5381 EXPECT_EQ(1UL, parameters.encodings.size());
5382 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5383 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5384
5385 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5386 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5387 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5388}
5389
5390TEST_F(WebRtcVideoChannelTest,
5391 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5392 send_parameters_.max_bandwidth_bps = 99999;
5393 FakeVideoSendStream* stream = AddSendStream();
5394 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5395 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5396 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5397 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5398 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5399 stream->GetVideoStreams()[0].max_bitrate_bps);
5400
5401 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5402 // adjusted down.
5403 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5404 EXPECT_EQ(1UL, parameters.encodings.size());
5405 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5406 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5407 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5408 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5409 stream->GetVideoStreams()[0].min_bitrate_bps);
5410 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5411 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005412}
5413
Åsa Persson8c1bf952018-09-13 10:42:19 +02005414TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5415 FakeVideoSendStream* stream = AddSendStream();
5416
5417 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5418 EXPECT_EQ(1UL, parameters.encodings.size());
5419 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5420 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5421
5422 // Note that this is testing the behavior of the FakeVideoSendStream, which
5423 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5424 // we are just testing the behavior of
5425 // EncoderStreamFactory::CreateEncoderStreams.
5426 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5427 EXPECT_EQ(kDefaultVideoMaxFramerate,
5428 stream->GetVideoStreams()[0].max_framerate);
5429
5430 // Set max framerate and check that VideoStream.max_framerate is set.
5431 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5432 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5433 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5434 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5435
5436 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5437 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5438}
5439
Seth Hampson7c682e02018-05-04 16:28:15 -07005440TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005441 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005442 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005443 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005444 // Two or more encodings should result in failure.
5445 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005446 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005447 // Zero encodings should also fail.
5448 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005449 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005450}
5451
Zach Stein3ca452b2018-01-18 10:01:24 -08005452TEST_F(WebRtcVideoChannelTest,
5453 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5454 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5455 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5456 AddSendStream(sp);
5457
5458 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5459
5460 // Additional encodings should result in failure.
5461 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005462 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005463 // Zero encodings should also fail.
5464 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005465 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005466}
5467
deadbeeffb2aced2017-01-06 23:05:37 -08005468// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005469TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005470 AddSendStream();
5471 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005472 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005473 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005474}
5475
Seth Hampson24722b32017-12-22 09:36:42 -08005476// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5477// a value <= 0, setting the parameters returns false.
5478TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5479 AddSendStream();
5480 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5481 EXPECT_EQ(1UL, parameters.encodings.size());
5482 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5483 parameters.encodings[0].bitrate_priority);
5484
5485 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005486 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005487 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005488 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005489}
5490
5491// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5492// properly on the VideoChannel and propogates down to the video encoder.
5493TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5494 AddSendStream();
5495 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5496 EXPECT_EQ(1UL, parameters.encodings.size());
5497 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5498 parameters.encodings[0].bitrate_priority);
5499
5500 // Change the value and set it on the VideoChannel.
5501 double new_bitrate_priority = 2.0;
5502 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005503 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005504
5505 // Verify that the encoding parameters bitrate_priority is set for the
5506 // VideoChannel.
5507 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5508 EXPECT_EQ(1UL, parameters.encodings.size());
5509 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5510
5511 // Verify that the new value propagated down to the encoder.
5512 std::vector<FakeVideoSendStream*> video_send_streams =
5513 fake_call_->GetVideoSendStreams();
5514 EXPECT_EQ(1UL, video_send_streams.size());
5515 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5516 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5517 // appropriately.
5518 EXPECT_EQ(new_bitrate_priority,
5519 video_send_stream->GetEncoderConfig().bitrate_priority);
5520 // Check that the vector of VideoStreams also was propagated correctly. Note
5521 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5522 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005523 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005524 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5525}
5526
5527// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5528// VideoChannel and the value propogates to the video encoder with all simulcast
5529// streams.
5530TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5531 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005532 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005533 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5534 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5535 AddSendStream(stream_params);
5536 uint32_t primary_ssrc = stream_params.first_ssrc();
5537
Tommi85959932018-02-07 19:26:06 +01005538 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5539 // frame. This creates multiple VideoStreams for all simulcast layers when
5540 // reconfiguring, and allows us to test this behavior.
5541 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005542 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005543 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005544 EXPECT_EQ(cricket::CS_RUNNING,
5545 capturer.Start(cricket::VideoFormat(
5546 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5547 cricket::FOURCC_I420)));
5548 channel_->SetSend(true);
5549 EXPECT_TRUE(capturer.CaptureFrame());
5550 // Get and set the rtp encoding parameters.
5551 webrtc::RtpParameters parameters =
5552 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005553 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005554 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5555 parameters.encodings[0].bitrate_priority);
5556 // Change the value and set it on the VideoChannel.
5557 double new_bitrate_priority = 2.0;
5558 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005559 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005560
5561 // Verify that the encoding parameters priority is set on the VideoChannel.
5562 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005563 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005564 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5565
5566 // Verify that the new value propagated down to the encoder.
5567 std::vector<FakeVideoSendStream*> video_send_streams =
5568 fake_call_->GetVideoSendStreams();
5569 EXPECT_EQ(1UL, video_send_streams.size());
5570 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5571 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5572 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005573 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005574 video_send_stream->GetEncoderConfig().number_of_streams);
5575 EXPECT_EQ(new_bitrate_priority,
5576 video_send_stream->GetEncoderConfig().bitrate_priority);
5577 // Check that the vector of VideoStreams also propagated correctly. The
5578 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5579 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005580 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005581 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005582 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5583 // Since we are only setting bitrate priority per-sender, the other
5584 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005585 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005586 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005587 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005588 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005589 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005590}
5591
Åsa Persson8c1bf952018-09-13 10:42:19 +02005592TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5593 const size_t kNumSimulcastStreams = 3;
5594 SetUpSimulcast(true, false);
5595
5596 // Get and set the rtp encoding parameters.
5597 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5598 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5599 for (const auto& encoding : parameters.encodings) {
5600 EXPECT_FALSE(encoding.max_framerate);
5601 }
5602
5603 // Change the value and set it on the VideoChannel.
5604 parameters.encodings[0].max_framerate = 10;
5605 parameters.encodings[1].max_framerate = 20;
5606 parameters.encodings[2].max_framerate = 25;
5607 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5608
5609 // Verify that the bitrates are set on the VideoChannel.
5610 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5611 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5612 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5613 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5614 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5615}
5616
5617TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5618 const size_t kNumSimulcastStreams = 3;
5619 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5620
5621 // Send a full size frame so all simulcast layers are used when reconfiguring.
5622 FakeVideoCapturerWithTaskQueue capturer;
5623 VideoOptions options;
5624 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5625 EXPECT_EQ(cricket::CS_RUNNING,
5626 capturer.Start(capturer.GetSupportedFormats()->front()));
5627 channel_->SetSend(true);
5628 EXPECT_TRUE(capturer.CaptureFrame());
5629
5630 // Get and set the rtp encoding parameters.
5631 // Change the value and set it on the VideoChannel.
5632 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5633 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5634 parameters.encodings[0].max_framerate = 15;
5635 parameters.encodings[1].max_framerate = 25;
5636 parameters.encodings[2].max_framerate = 20;
5637 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5638
5639 // Verify that the new value propagated down to the encoder.
5640 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5641 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5642 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5643 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5644 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5645 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5646 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5647 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5648
5649 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5650 // VideoStreams are created appropriately for the simulcast case.
5651 // Currently the maximum |max_framerate| is used.
5652 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5653 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5654 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5655 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5656
5657 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5658}
5659
5660TEST_F(WebRtcVideoChannelTest,
5661 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5662 const size_t kNumSimulcastStreams = 3;
5663 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5664 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5665
5666 // Send a full size frame so all simulcast layers are used when reconfiguring.
5667 FakeVideoCapturerWithTaskQueue capturer;
5668 VideoOptions options;
5669 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5670 EXPECT_EQ(cricket::CS_RUNNING,
5671 capturer.Start(capturer.GetSupportedFormats()->front()));
5672 channel_->SetSend(true);
5673 EXPECT_TRUE(capturer.CaptureFrame());
5674
5675 // Get and set the rtp encoding parameters.
5676 // Change the value and set it on the VideoChannel.
5677 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5678 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5679 parameters.encodings[0].max_framerate = 15;
5680 parameters.encodings[2].max_framerate = 20;
5681 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5682
5683 // Verify that the new value propagated down to the encoder.
5684 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5685 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5686 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5687 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5688 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5689 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5690 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5691
5692 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5693 // VideoStreams are created appropriately for the simulcast case.
5694 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5695 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5696 EXPECT_EQ(kDefaultVideoMaxFramerate,
5697 stream->GetVideoStreams()[0].max_framerate);
5698 EXPECT_EQ(kDefaultVideoMaxFramerate,
5699 stream->GetVideoStreams()[1].max_framerate);
5700 EXPECT_EQ(kDefaultVideoMaxFramerate,
5701 stream->GetVideoStreams()[2].max_framerate);
5702
5703 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5704}
5705
Åsa Persson55659812018-06-18 17:51:32 +02005706TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5707 const size_t kNumSimulcastStreams = 3;
5708 SetUpSimulcast(true, false);
5709
5710 // Get and set the rtp encoding parameters.
5711 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5712 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5713 for (const auto& encoding : parameters.encodings) {
5714 EXPECT_FALSE(encoding.min_bitrate_bps);
5715 EXPECT_FALSE(encoding.max_bitrate_bps);
5716 }
5717
5718 // Change the value and set it on the VideoChannel.
5719 parameters.encodings[0].min_bitrate_bps = 100000;
5720 parameters.encodings[0].max_bitrate_bps = 200000;
5721 parameters.encodings[1].min_bitrate_bps = 300000;
5722 parameters.encodings[1].max_bitrate_bps = 400000;
5723 parameters.encodings[2].min_bitrate_bps = 500000;
5724 parameters.encodings[2].max_bitrate_bps = 600000;
5725 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5726
5727 // Verify that the bitrates are set on the VideoChannel.
5728 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5729 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5730 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
5731 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
5732 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
5733 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
5734 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
5735 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
5736}
5737
5738TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
5739 const size_t kNumSimulcastStreams = 3;
5740 SetUpSimulcast(true, false);
5741
5742 // Get and set the rtp encoding parameters.
5743 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5744 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5745
5746 // Max bitrate lower than min bitrate should fail.
5747 parameters.encodings[2].min_bitrate_bps = 100000;
5748 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
5749 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5750 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5751}
5752
5753// Test that min and max bitrate values set via RtpParameters are correctly
5754// propagated to the underlying encoder, and that the target is set to 3/4 of
5755// the maximum (3/4 was chosen because it's similar to the simulcast defaults
5756// that are used if no min/max are specified).
5757TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
5758 const size_t kNumSimulcastStreams = 3;
5759 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5760
5761 // Send a full size frame so all simulcast layers are used when reconfiguring.
5762 FakeVideoCapturerWithTaskQueue capturer;
5763 VideoOptions options;
5764 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5765 EXPECT_EQ(cricket::CS_RUNNING,
5766 capturer.Start(capturer.GetSupportedFormats()->front()));
5767 channel_->SetSend(true);
5768 EXPECT_TRUE(capturer.CaptureFrame());
5769
5770 // Get and set the rtp encoding parameters.
5771 // Change the value and set it on the VideoChannel.
5772 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5773 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5774 parameters.encodings[0].min_bitrate_bps = 100000;
5775 parameters.encodings[0].max_bitrate_bps = 200000;
5776 parameters.encodings[1].min_bitrate_bps = 300000;
5777 parameters.encodings[1].max_bitrate_bps = 400000;
5778 parameters.encodings[2].min_bitrate_bps = 500000;
5779 parameters.encodings[2].max_bitrate_bps = 600000;
5780 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5781
5782 // Verify that the new value propagated down to the encoder.
5783 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5784 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5785 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5786 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5787 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5788 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
5789 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
5790 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
5791 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
5792 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
5793 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
5794
5795 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5796 // VideoStreams are created appropriately for the simulcast case.
5797 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5798 // Target bitrate: 200000 * 3 / 4 = 150000.
5799 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
5800 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
5801 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
5802 // Target bitrate: 400000 * 3 / 4 = 300000.
5803 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
5804 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
5805 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
5806 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
5807 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
5808 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
5809 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
5810
5811 // No parameter changed, encoder should not be reconfigured.
5812 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5813 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5814
5815 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5816}
5817
5818// Test to only specify the min or max bitrate value for a layer via
5819// RtpParameters. The unspecified min/max and target value should be set to the
5820// simulcast default that is used if no min/max are specified.
5821TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
5822 const size_t kNumSimulcastStreams = 3;
5823 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5824 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5825
5826 // Send a full size frame so all simulcast layers are used when reconfiguring.
5827 FakeVideoCapturerWithTaskQueue capturer;
5828 VideoOptions options;
5829 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5830 EXPECT_EQ(cricket::CS_RUNNING,
5831 capturer.Start(capturer.GetSupportedFormats()->front()));
5832 channel_->SetSend(true);
5833 EXPECT_TRUE(capturer.CaptureFrame());
5834
5835 // Get and set the rtp encoding parameters.
5836 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5837 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5838
5839 // Change the value and set it on the VideoChannel.
5840 // Layer 0: only configure min bitrate.
5841 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
5842 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5843 // Layer 1: only configure max bitrate.
5844 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
5845 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5846 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5847
5848 // Verify that the new value propagated down to the encoder.
5849 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5850 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5851 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5852 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5853 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
5854 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
5855 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
5856 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
5857 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
5858 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
5859
5860 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5861 // VideoStreams are created appropriately for the simulcast case.
5862 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5863 // Layer 0: min configured bitrate should overwrite min default.
5864 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5865 EXPECT_EQ(kDefault[0].target_bitrate_bps,
5866 stream->GetVideoStreams()[0].target_bitrate_bps);
5867 EXPECT_EQ(kDefault[0].max_bitrate_bps,
5868 stream->GetVideoStreams()[0].max_bitrate_bps);
5869 // Layer 1: max configured bitrate should overwrite max default.
5870 EXPECT_EQ(kDefault[1].min_bitrate_bps,
5871 stream->GetVideoStreams()[1].min_bitrate_bps);
5872 EXPECT_EQ(kDefault[1].target_bitrate_bps,
5873 stream->GetVideoStreams()[1].target_bitrate_bps);
5874 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5875 // Layer 2: min and max bitrate not configured, default expected.
5876 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5877 stream->GetVideoStreams()[2].min_bitrate_bps);
5878 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5879 stream->GetVideoStreams()[2].target_bitrate_bps);
5880 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5881 stream->GetVideoStreams()[2].max_bitrate_bps);
5882
5883 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5884}
5885
5886// Test that specifying the min (or max) bitrate value for a layer via
5887// RtpParameters above (or below) the simulcast default max (or min) adjusts the
5888// unspecified values accordingly.
5889TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
5890 const size_t kNumSimulcastStreams = 3;
5891 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5892 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5893
5894 // Send a full size frame so all simulcast layers are used when reconfiguring.
5895 FakeVideoCapturerWithTaskQueue capturer;
5896 VideoOptions options;
5897 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5898 EXPECT_EQ(cricket::CS_RUNNING,
5899 capturer.Start(capturer.GetSupportedFormats()->front()));
5900 channel_->SetSend(true);
5901 EXPECT_TRUE(capturer.CaptureFrame());
5902
5903 // Get and set the rtp encoding parameters.
5904 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5905 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5906
5907 // Change the value and set it on the VideoChannel.
5908 // For layer 0, set the min bitrate above the default max.
5909 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
5910 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
5911 // For layer 1, set the max bitrate below the default min.
5912 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
5913 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
5914 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5915
5916 // Verify that the new value propagated down to the encoder.
5917 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5918 // VideoStreams are created appropriately for the simulcast case.
5919 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5920 // Layer 0: Min bitrate above default max (target/max should be adjusted).
5921 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
5922 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
5923 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
5924 // Layer 1: Max bitrate below default min (min/target should be adjusted).
5925 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
5926 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
5927 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
5928 // Layer 2: min and max bitrate not configured, default expected.
5929 EXPECT_EQ(kDefault[2].min_bitrate_bps,
5930 stream->GetVideoStreams()[2].min_bitrate_bps);
5931 EXPECT_EQ(kDefault[2].target_bitrate_bps,
5932 stream->GetVideoStreams()[2].target_bitrate_bps);
5933 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5934 stream->GetVideoStreams()[2].max_bitrate_bps);
5935
5936 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5937}
5938
5939TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
5940 const size_t kNumSimulcastStreams = 3;
5941 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5942 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5943
5944 // Send a full size frame so all simulcast layers are used when reconfiguring.
5945 FakeVideoCapturerWithTaskQueue capturer;
5946 VideoOptions options;
5947 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5948 EXPECT_EQ(cricket::CS_RUNNING,
5949 capturer.Start(capturer.GetSupportedFormats()->front()));
5950 channel_->SetSend(true);
5951 EXPECT_TRUE(capturer.CaptureFrame());
5952
5953 // Set max bitrate for all but the highest layer.
5954 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5955 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5956 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
5957 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
5958 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5959
5960 // Set max bandwidth equal to total max bitrate.
5961 send_parameters_.max_bandwidth_bps =
5962 GetTotalMaxBitrateBps(stream->GetVideoStreams());
5963 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5964 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5965
5966 // No bitrate above the total max to give to the highest layer.
5967 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5968 EXPECT_EQ(kDefault[2].max_bitrate_bps,
5969 stream->GetVideoStreams()[2].max_bitrate_bps);
5970
5971 // Set max bandwidth above the total max bitrate.
5972 send_parameters_.max_bandwidth_bps =
5973 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
5974 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5975 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5976
5977 // The highest layer has no max bitrate set -> the bitrate above the total
5978 // max should be given to the highest layer.
5979 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5980 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5981 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
5982 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
5983 stream->GetVideoStreams()[2].max_bitrate_bps);
5984
5985 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5986}
5987
5988TEST_F(WebRtcVideoChannelTest,
5989 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
5990 const size_t kNumSimulcastStreams = 3;
5991 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5992 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
5993 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5994
5995 // Send a full size frame so all simulcast layers are used when reconfiguring.
5996 FakeVideoCapturerWithTaskQueue capturer;
5997 VideoOptions options;
5998 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5999 EXPECT_EQ(cricket::CS_RUNNING,
6000 capturer.Start(capturer.GetSupportedFormats()->front()));
6001 channel_->SetSend(true);
6002 EXPECT_TRUE(capturer.CaptureFrame());
6003
6004 // Set max bitrate for the highest layer.
6005 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6006 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6007 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6008 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6009
6010 // Set max bandwidth above the total max bitrate.
6011 send_parameters_.max_bandwidth_bps =
6012 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6013 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6014 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6015
6016 // The highest layer has the max bitrate set -> the bitrate above the total
6017 // max should not be given to the highest layer.
6018 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6019 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6020 stream->GetVideoStreams()[2].max_bitrate_bps);
6021
6022 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6023}
6024
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006025// Test that min and max bitrate values set via RtpParameters are correctly
6026// propagated to the underlying encoder for a single stream.
6027TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6028 FakeVideoSendStream* stream = AddSendStream();
6029 EXPECT_TRUE(channel_->SetSend(true));
6030 EXPECT_TRUE(stream->IsSending());
6031
6032 // Set min and max bitrate.
6033 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6034 EXPECT_EQ(1u, parameters.encodings.size());
6035 parameters.encodings[0].min_bitrate_bps = 80000;
6036 parameters.encodings[0].max_bitrate_bps = 150000;
6037 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6038
6039 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6040 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6041 EXPECT_EQ(1u, encoder_config.number_of_streams);
6042 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6043 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6044 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6045
6046 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6047 // VideoStreams are created appropriately.
6048 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6049 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6050 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6051 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6052}
6053
6054// Test the default min and max bitrate value are correctly propagated to the
6055// underlying encoder for a single stream (when the values are not set via
6056// RtpParameters).
6057TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6058 FakeVideoSendStream* stream = AddSendStream();
6059 EXPECT_TRUE(channel_->SetSend(true));
6060 EXPECT_TRUE(stream->IsSending());
6061
6062 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6063 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6064 EXPECT_EQ(1u, encoder_config.number_of_streams);
6065 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6066 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6067 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6068
6069 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6070 // VideoStreams are created appropriately.
6071 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6072 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6073 stream->GetVideoStreams()[0].min_bitrate_bps);
6074 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6075 stream->GetVideoStreams()[0].min_bitrate_bps);
6076 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6077 stream->GetVideoStreams()[0].target_bitrate_bps);
6078}
6079
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006080// Test that a stream will not be sending if its encoding is made inactive
6081// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006082TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006083 FakeVideoSendStream* stream = AddSendStream();
6084 EXPECT_TRUE(channel_->SetSend(true));
6085 EXPECT_TRUE(stream->IsSending());
6086
6087 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006088 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006089 ASSERT_EQ(1u, parameters.encodings.size());
6090 ASSERT_TRUE(parameters.encodings[0].active);
6091 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006092 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006093 EXPECT_FALSE(stream->IsSending());
6094
6095 // Now change it back to active and verify we resume sending.
6096 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006097 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006098 EXPECT_TRUE(stream->IsSending());
6099}
6100
Seth Hampson8234ead2018-02-02 15:16:24 -08006101// Tests that when active is updated for any simulcast layer then the send
6102// stream's sending state will be updated and it will be reconfigured with the
6103// new appropriate active simulcast streams.
6104TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6105 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006106 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006107 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6108 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6109 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6110 uint32_t primary_ssrc = stream_params.first_ssrc();
6111
Tommi85959932018-02-07 19:26:06 +01006112 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6113 // frame. This allows us to test that ReconfigureEncoder is called
6114 // appropriately.
6115 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006116 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006117 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006118 EXPECT_EQ(cricket::CS_RUNNING,
6119 capturer.Start(cricket::VideoFormat(
6120 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6121 cricket::FOURCC_I420)));
6122 channel_->SetSend(true);
6123 EXPECT_TRUE(capturer.CaptureFrame());
6124
6125 // Check that all encodings are initially active.
6126 webrtc::RtpParameters parameters =
6127 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006128 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006129 EXPECT_TRUE(parameters.encodings[0].active);
6130 EXPECT_TRUE(parameters.encodings[1].active);
6131 EXPECT_TRUE(parameters.encodings[2].active);
6132 EXPECT_TRUE(fake_video_send_stream->IsSending());
6133
6134 // Only turn on only the middle stream.
6135 parameters.encodings[0].active = false;
6136 parameters.encodings[1].active = true;
6137 parameters.encodings[2].active = false;
6138 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6139 // Verify that the active fields are set on the VideoChannel.
6140 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006141 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006142 EXPECT_FALSE(parameters.encodings[0].active);
6143 EXPECT_TRUE(parameters.encodings[1].active);
6144 EXPECT_FALSE(parameters.encodings[2].active);
6145 // Check that the VideoSendStream is updated appropriately. This means its
6146 // send state was updated and it was reconfigured.
6147 EXPECT_TRUE(fake_video_send_stream->IsSending());
6148 std::vector<webrtc::VideoStream> simulcast_streams =
6149 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006150 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006151 EXPECT_FALSE(simulcast_streams[0].active);
6152 EXPECT_TRUE(simulcast_streams[1].active);
6153 EXPECT_FALSE(simulcast_streams[2].active);
6154
6155 // Turn off all streams.
6156 parameters.encodings[0].active = false;
6157 parameters.encodings[1].active = false;
6158 parameters.encodings[2].active = false;
6159 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6160 // Verify that the active fields are set on the VideoChannel.
6161 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006162 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006163 EXPECT_FALSE(parameters.encodings[0].active);
6164 EXPECT_FALSE(parameters.encodings[1].active);
6165 EXPECT_FALSE(parameters.encodings[2].active);
6166 // Check that the VideoSendStream is off.
6167 EXPECT_FALSE(fake_video_send_stream->IsSending());
6168 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006169 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006170 EXPECT_FALSE(simulcast_streams[0].active);
6171 EXPECT_FALSE(simulcast_streams[1].active);
6172 EXPECT_FALSE(simulcast_streams[2].active);
6173
Niels Möllerff40b142018-04-09 08:49:14 +02006174 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006175}
6176
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006177// Test that if a stream is reconfigured (due to a codec change or other
6178// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006179TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006180 InactiveStreamDoesntStartSendingWhenReconfigured) {
6181 // Set an initial codec list, which will be modified later.
6182 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006183 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6184 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006185 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6186
6187 FakeVideoSendStream* stream = AddSendStream();
6188 EXPECT_TRUE(channel_->SetSend(true));
6189 EXPECT_TRUE(stream->IsSending());
6190
6191 // Get current parameters and change "active" to false.
6192 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6193 ASSERT_EQ(1u, parameters.encodings.size());
6194 ASSERT_TRUE(parameters.encodings[0].active);
6195 parameters.encodings[0].active = false;
6196 EXPECT_EQ(1u, GetFakeSendStreams().size());
6197 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006198 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006199 EXPECT_FALSE(stream->IsSending());
6200
6201 // Reorder the codec list, causing the stream to be reconfigured.
6202 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006203 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6204 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006205 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6206 auto new_streams = GetFakeSendStreams();
6207 // Assert that a new underlying stream was created due to the codec change.
6208 // Otherwise, this test isn't testing what it set out to test.
6209 EXPECT_EQ(1u, GetFakeSendStreams().size());
6210 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6211
6212 // Verify that we still are not sending anything, due to the inactive
6213 // encoding.
6214 EXPECT_FALSE(new_streams[0]->IsSending());
6215}
6216
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006217// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006218TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006219 AddSendStream();
6220 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006221 parameters.codecs.push_back(GetEngineCodec("VP8"));
6222 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006223 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6224
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006225 webrtc::RtpParameters rtp_parameters =
6226 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006227 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006228 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6229 rtp_parameters.codecs[0]);
6230 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6231 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006232}
6233
Florent Castellidacec712018-05-24 16:24:21 +02006234// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6235TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6236 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6237 params.cname = "rtcpcname";
6238 AddSendStream(params);
6239
6240 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6241 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6242}
6243
deadbeeffb2aced2017-01-06 23:05:37 -08006244// Test that RtpParameters for send stream has one encoding and it has
6245// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006246TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006247 AddSendStream();
6248
6249 webrtc::RtpParameters rtp_parameters =
6250 channel_->GetRtpSendParameters(last_ssrc_);
6251 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006252 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006253}
6254
Florent Castelliabe301f2018-06-12 18:33:49 +02006255TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6256 AddSendStream();
6257
6258 webrtc::RtpParameters rtp_parameters =
6259 channel_->GetRtpSendParameters(last_ssrc_);
6260 rtp_parameters.header_extensions.emplace_back();
6261
6262 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6263
6264 webrtc::RTCError result =
6265 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6266 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6267}
6268
Florent Castelli87b3c512018-07-18 16:00:28 +02006269TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6270 AddSendStream();
6271
6272 FakeVideoCapturerWithTaskQueue capturer;
6273 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6274
6275 webrtc::RtpParameters rtp_parameters =
6276 channel_->GetRtpSendParameters(last_ssrc_);
6277 EXPECT_EQ(rtp_parameters.degradation_preference,
6278 webrtc::DegradationPreference::BALANCED);
6279 rtp_parameters.degradation_preference =
6280 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6281
6282 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6283
6284 webrtc::RtpParameters updated_rtp_parameters =
6285 channel_->GetRtpSendParameters(last_ssrc_);
6286 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6287 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6288
6289 // Remove the source since it will be destroyed before the channel
6290 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6291}
6292
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006293// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006294TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006295 AddSendStream();
6296 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006297 parameters.codecs.push_back(GetEngineCodec("VP8"));
6298 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006299 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6300
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006301 webrtc::RtpParameters initial_params =
6302 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006303
6304 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006305 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006306
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006307 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6308 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6309}
6310
6311// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006312TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006313 AddRecvStream();
6314 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006315 parameters.codecs.push_back(GetEngineCodec("VP8"));
6316 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006317 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6318
6319 webrtc::RtpParameters rtp_parameters =
6320 channel_->GetRtpReceiveParameters(last_ssrc_);
6321 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006322 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6323 rtp_parameters.codecs[0]);
6324 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6325 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006326}
6327
johan073ece42016-08-26 02:59:47 -07006328#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006329TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006330#else
eladalonf1841382017-06-12 01:16:46 -07006331TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006332#endif
johan3859c892016-08-05 09:19:25 -07006333 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006334 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006335 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006336 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006337 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006338 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006339 parameters.codecs.push_back(kH264sprop2);
6340 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6341
6342 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6343 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6344 webrtc::RtpParameters rtp_parameters =
6345 channel_->GetRtpReceiveParameters(last_ssrc_);
6346 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6347 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6348 ASSERT_EQ(2u, cfg.decoders.size());
6349 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006350 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006351 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006352 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6353 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006354 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006355
6356 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006357 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006358 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006359 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6360 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006361 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006362}
6363
sakal1fd95952016-06-22 00:46:15 -07006364// Test that RtpParameters for receive stream has one encoding and it has
6365// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006366TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006367 AddRecvStream();
6368
6369 webrtc::RtpParameters rtp_parameters =
6370 channel_->GetRtpReceiveParameters(last_ssrc_);
6371 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006372 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006373}
6374
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006375// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006376TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006377 AddRecvStream();
6378 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006379 parameters.codecs.push_back(GetEngineCodec("VP8"));
6380 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006381 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6382
6383 webrtc::RtpParameters initial_params =
6384 channel_->GetRtpReceiveParameters(last_ssrc_);
6385
6386 // We should be able to set the params we just got.
6387 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6388
6389 // ... And this shouldn't change the params returned by
6390 // GetRtpReceiveParameters.
6391 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006392}
6393
deadbeef3bc15102017-04-20 19:25:07 -07006394// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6395// aren't signaled. It should always return an empty "RtpEncodingParameters",
6396// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006397TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006398 // Call necessary methods to configure receiving a default stream as
6399 // soon as it arrives.
6400 cricket::VideoRecvParameters parameters;
6401 parameters.codecs.push_back(GetEngineCodec("VP8"));
6402 parameters.codecs.push_back(GetEngineCodec("VP9"));
6403 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6404
6405 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6406 // stream. Should return nothing.
6407 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6408
6409 // Set a sink for an unsignaled stream.
6410 cricket::FakeVideoRenderer renderer;
6411 // Value of "0" means "unsignaled stream".
6412 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6413
6414 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6415 // in this method means "unsignaled stream".
6416 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6417 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6418 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6419
6420 // Receive VP8 packet.
6421 uint8_t data[kMinRtpPacketLen];
6422 cricket::RtpHeader rtpHeader;
6423 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6424 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6425 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6426 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6427 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
6428 rtc::PacketTime packet_time;
6429 channel_->OnPacketReceived(&packet, packet_time);
6430
6431 // The |ssrc| member should still be unset.
6432 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6433 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6434 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6435}
6436
eladalonf1841382017-06-12 01:16:46 -07006437void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006438 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006439 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006440
6441 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006442 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006443 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006444 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006445
6446 if (receiver_first) {
6447 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6448 std::vector<FakeVideoReceiveStream*> receive_streams =
6449 fake_call_->GetVideoReceiveStreams();
6450 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006451 // Default local SSRC when we have no sender.
6452 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6453 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006454 }
6455 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6456 if (!receiver_first)
6457 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6458 std::vector<FakeVideoReceiveStream*> receive_streams =
6459 fake_call_->GetVideoReceiveStreams();
6460 ASSERT_EQ(1u, receive_streams.size());
6461 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006462
6463 // Removing first sender should fall back to another (in this case the second)
6464 // local send stream's SSRC.
6465 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6466 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006467 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006468 ASSERT_EQ(1u, receive_streams.size());
6469 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6470
6471 // Removing the last sender should fall back to default local SSRC.
6472 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006473 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006474 ASSERT_EQ(1u, receive_streams.size());
6475 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6476 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006477}
6478
eladalonf1841382017-06-12 01:16:46 -07006479TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006480 TestReceiverLocalSsrcConfiguration(false);
6481}
6482
eladalonf1841382017-06-12 01:16:46 -07006483TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006484 TestReceiverLocalSsrcConfiguration(true);
6485}
6486
eladalonf1841382017-06-12 01:16:46 -07006487class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006488 public:
eladalonf1841382017-06-12 01:16:46 -07006489 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006490 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006491 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6492 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006493 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006494 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006495 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006496 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006497 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006498
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006499 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006500 encoder_factory_->AddSupportedVideoCodecType("VP8");
nisse51542be2016-02-12 02:27:06 -08006501 channel_.reset(
kthelgason2bc68642017-02-07 07:02:22 -08006502 engine_.CreateChannel(&fake_call_, GetMediaConfig(), VideoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006503 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006504 last_ssrc_ = 123;
6505 }
6506
6507 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006508 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006509 int capture_width,
6510 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006511 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006512 size_t expected_num_streams,
6513 bool screenshare,
6514 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006515 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006516 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006517 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006518 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006519
Peter Boström0c4e06b2015-10-07 12:23:21 +02006520 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006521 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006522 ssrcs.resize(num_configured_streams);
6523
sprangf24a0642017-02-28 13:23:26 -08006524 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006525 // Send a full-size frame to trigger a stream reconfiguration to use all
6526 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006527 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006528 VideoOptions options;
6529 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006530 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006531 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006532 // Fetch the latest stream since SetVideoSend() may recreate it if the
6533 // screen content setting is changed.
6534 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006535 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006536 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006537 cricket::VideoFormat::FpsToInterval(30),
6538 cricket::FOURCC_I420)));
6539 channel_->SetSend(true);
6540 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006541
Zach Stein3ca452b2018-01-18 10:01:24 -08006542 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6543 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6544
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006545 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6546 ASSERT_EQ(expected_num_streams, video_streams.size());
6547
sprang429600d2017-01-26 06:12:26 -08006548 std::vector<webrtc::VideoStream> expected_streams;
6549 if (conference_mode) {
6550 expected_streams = GetSimulcastConfig(
6551 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006552 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006553 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006554 if (screenshare) {
6555 for (const webrtc::VideoStream& stream : expected_streams) {
6556 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006557 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6558 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006559 }
6560 }
sprang429600d2017-01-26 06:12:26 -08006561 } else {
6562 webrtc::VideoStream stream;
6563 stream.width = capture_width;
6564 stream.height = capture_height;
6565 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006566 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006567 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006568 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006569 stream.max_qp = kDefaultQpMax;
6570 expected_streams.push_back(stream);
6571 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006572
6573 ASSERT_EQ(expected_streams.size(), video_streams.size());
6574
6575 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006576 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006577 for (size_t i = 0; i < num_streams; ++i) {
6578 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6579 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6580
6581 EXPECT_GT(video_streams[i].max_framerate, 0);
6582 EXPECT_EQ(expected_streams[i].max_framerate,
6583 video_streams[i].max_framerate);
6584
6585 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6586 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6587 video_streams[i].min_bitrate_bps);
6588
6589 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6590 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6591 video_streams[i].target_bitrate_bps);
6592
6593 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6594 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6595 video_streams[i].max_bitrate_bps);
6596
6597 EXPECT_GT(video_streams[i].max_qp, 0);
6598 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6599
Sergey Silkina796a7e2018-03-01 15:11:29 +01006600 EXPECT_EQ(conference_mode,
6601 expected_streams[i].num_temporal_layers.has_value());
6602
6603 if (conference_mode) {
6604 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6605 video_streams[i].num_temporal_layers);
6606 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006607
6608 if (i == num_streams - 1) {
6609 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6610 } else {
6611 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6612 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006613 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006614
Niels Möllerff40b142018-04-09 08:49:14 +02006615 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006616 }
6617
6618 FakeVideoSendStream* AddSendStream() {
6619 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6620 }
6621
6622 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006623 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006624 EXPECT_TRUE(channel_->AddSendStream(sp));
6625 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006626 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006627 EXPECT_EQ(num_streams + 1, streams.size());
6628 return streams[streams.size() - 1];
6629 }
6630
6631 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006632 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006633 }
6634
6635 FakeVideoReceiveStream* AddRecvStream() {
6636 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6637 }
6638
6639 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006640 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006641 EXPECT_TRUE(channel_->AddRecvStream(sp));
6642 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006643 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006644 EXPECT_EQ(num_streams + 1, streams.size());
6645 return streams[streams.size() - 1];
6646 }
6647
skvlad11a9cbf2016-10-07 11:53:05 -07006648 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006649 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006650 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6651 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -07006652 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006653 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006654 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006655};
6656
eladalonf1841382017-06-12 01:16:46 -07006657TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006658 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6659 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006660}
6661
eladalonf1841382017-06-12 01:16:46 -07006662TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006663 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6664 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006665}
6666
6667// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006668TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006669 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6670 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006671}
sprang429600d2017-01-26 06:12:26 -08006672
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006673TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006674 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6675 false);
6676}
6677
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006678TEST_F(WebRtcVideoChannelSimulcastTest,
6679 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006680 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6681 true);
6682}
6683
eladalonf1841382017-06-12 01:16:46 -07006684TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006685 webrtc::test::ScopedFieldTrials override_field_trials_(
6686 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006687 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6688 true);
6689}
6690
eladalonf1841382017-06-12 01:16:46 -07006691TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006692 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006693 webrtc::test::ScopedFieldTrials override_field_trials_(
6694 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006695 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6696 false);
6697}
6698
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00006699} // namespace cricket