blob: 2b5a01dd2132eb0720722f8d6934804bce2ebf79 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070013#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000014#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000015
Steve Anton2c9ebef2019-01-28 17:27:58 -080016#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010017#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020018#include "absl/strings/match.h"
Steve Anton10542f22019-01-11 09:11:00 -080019#include "api/rtp_parameters.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070020#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080021#include "api/test/mock_video_bitrate_allocator.h"
22#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070023#include "api/test/mock_video_decoder_factory.h"
24#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020025#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010027#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020028#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020029#include "api/video_codecs/builtin_video_decoder_factory.h"
30#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020031#include "api/video_codecs/sdp_video_format.h"
32#include "api/video_codecs/video_decoder_factory.h"
33#include "api/video_codecs/video_encoder.h"
34#include "api/video_codecs/video_encoder_factory.h"
35#include "call/flexfec_receive_stream.h"
36#include "common_video/h264/profile_level_id.h"
37#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010038#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080039#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080040#include "media/base/fake_video_renderer.h"
41#include "media/base/media_constants.h"
42#include "media/base/rtp_utils.h"
43#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/engine/fake_webrtc_call.h"
46#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020047#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080048#include "media/engine/webrtc_video_engine.h"
49#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020050#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020051#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080052#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020053#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020054#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080055#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020056#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010057#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020058#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000059
Mirko Bonadei6a489f22019-04-09 15:11:12 +020060using ::testing::Field;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010061using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070062using webrtc::RtpExtension;
63
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000064namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000065static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000066
noahricd10a68e2015-07-10 11:27:55 -070067static const uint8_t kRedRtxPayloadType = 125;
68
Niels Möller6557d0c2018-04-11 15:18:34 +020069static const uint32_t kTimeout = 5000U;
70static const uint32_t kDefaultReceiveSsrc = 0;
71static const uint32_t kSsrc = 1234u;
72static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
73static const int kVideoWidth = 640;
74static const int kVideoHeight = 360;
75static const int kFramerate = 30;
76
Peter Boström0c4e06b2015-10-07 12:23:21 +020077static const uint32_t kSsrcs1[] = {1};
78static const uint32_t kSsrcs3[] = {1, 2, 3};
79static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080080static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020081static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080082static const uint32_t kDefaultRecvSsrc = 0;
83
pbos@webrtc.org3c107582014-07-20 15:27:35 +000084static const char kUnsupportedExtensionName[] =
85 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000086
magjed509e4fe2016-11-18 01:34:11 -080087cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
88 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020089 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080090}
91
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000092void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
93 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
94 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
95 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
96 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
97 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
98 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
99 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800100 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
101 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000102 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
103}
104
magjed725e4842016-11-16 00:48:13 -0800105// Return true if any codec in |codecs| is an RTX codec with associated payload
106// type |payload_type|.
107bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
108 int payload_type) {
109 for (const cricket::VideoCodec& codec : codecs) {
110 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200111 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800112 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
113 &associated_payload_type) &&
114 associated_payload_type == payload_type) {
115 return true;
116 }
117 }
118 return false;
119}
120
nisseca5706d2017-09-11 02:32:16 -0700121// TODO(nisse): Duplicated in call.cc.
122const int* FindKeyByValue(const std::map<int, int>& m, int v) {
123 for (const auto& kv : m) {
124 if (kv.second == v)
125 return &kv.first;
126 }
127 return nullptr;
128}
129
Yves Gerey665174f2018-06-19 15:03:05 +0200130bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
131 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700132 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
133 payload_type) != nullptr;
134}
135
136// Check that there's an Rtx payload type for each decoder.
137bool VerifyRtxReceiveAssociations(
138 const webrtc::VideoReceiveStream::Config& config) {
139 for (const auto& decoder : config.decoders) {
140 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
141 return false;
142 }
143 return true;
144}
145
brandtrffc61182016-11-28 06:02:22 -0800146rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700147 int width,
148 int height) {
149 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
150 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800151 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700152 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000153}
154
Shao Changbine62202f2015-04-21 20:24:50 +0800155void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
156 const std::map<int, int>& rtx_types) {
157 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200158 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800159 EXPECT_TRUE(it != rtx_types.end() &&
160 it->second == config.rtp.rtx.payload_type);
161
brandtrb5f2c3f2016-10-04 23:28:39 -0700162 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
163 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800164 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700165 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800166 }
167}
kthelgason2bc68642017-02-07 07:02:22 -0800168
169cricket::MediaConfig GetMediaConfig() {
170 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100171 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800172 return media_config;
173}
nisse26e3abb2017-08-25 04:44:25 -0700174
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200175// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
176int GetMaxDefaultBitrateBps(size_t width, size_t height) {
177 if (width * height <= 320 * 240) {
178 return 600000;
179 } else if (width * height <= 640 * 480) {
180 return 1700000;
181 } else if (width * height <= 960 * 540) {
182 return 2000000;
183 } else {
184 return 2500000;
185 }
186}
187
Niels Möller731a2c22018-07-30 15:08:07 +0200188class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
189 public:
190 MOCK_METHOD2(AddOrUpdateSink,
191 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
192 const rtc::VideoSinkWants& wants));
193 MOCK_METHOD1(RemoveSink,
194 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
195};
196
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000197} // namespace
198
Yves Gerey665174f2018-06-19 15:03:05 +0200199#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200201 EXPECT_EQ((w), renderer_.width()); \
202 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ(0, renderer_.errors());
204
Yves Gerey665174f2018-06-19 15:03:05 +0200205#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200207 EXPECT_EQ((w), (r).width()); \
208 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200209 EXPECT_EQ(0, (r).errors());
210
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000211namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700212class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000213 public:
eladalonf1841382017-06-12 01:16:46 -0700214 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
215 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700216 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700217 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200218 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
219 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200220 video_bitrate_allocator_factory_(
221 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200222 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200223 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200224 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200225 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200226 // Ensure fake clock doesn't return 0, which will cause some initializations
227 // fail inside RTP senders.
228 fake_clock_.AdvanceTimeMicros(1);
229 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000230
231 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200232 void AssignDefaultAptRtxTypes();
233 void AssignDefaultCodec();
234
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100235 // Find the index of the codec in the engine with the given name. The codec
236 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100237 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100238
magjed509e4fe2016-11-18 01:34:11 -0800239 // Find the codec in the engine with the given name. The codec must be
240 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100241 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800242
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200243 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000244
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200245 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000246 const std::vector<VideoCodec>& codecs);
247
Elad Alon157540a2019-02-08 23:37:52 +0100248 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100249
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200250 // Has to be the first one, so it is initialized before the call or there is a
251 // race condition in the clock access.
252 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700253 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700254 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700255 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000256 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800257 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200258 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
259 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200260 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
261 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700262 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000263 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800264 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000265};
266
eladalonf1841382017-06-12 01:16:46 -0700267TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200268 encoder_factory_->AddSupportedVideoCodecType("VP8");
269 AssignDefaultCodec();
270
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000271 std::vector<VideoCodec> engine_codecs = engine_.codecs();
272 for (size_t i = 0; i < engine_codecs.size(); ++i) {
273 if (engine_codecs[i].name != kRtxCodecName)
274 continue;
275 int associated_payload_type;
276 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000277 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000278 EXPECT_EQ(default_codec_.id, associated_payload_type);
279 return;
280 }
281 FAIL() << "No RTX codec found among default codecs.";
282}
283
eladalonf1841382017-06-12 01:16:46 -0700284TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100285 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000286}
287
eladalonf1841382017-06-12 01:16:46 -0700288TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100289 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000290}
291
eladalonf1841382017-06-12 01:16:46 -0700292TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100293 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700294}
295
eladalonf1841382017-06-12 01:16:46 -0700296TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100297 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
298}
299
300TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
301 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
302}
303
304TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
305 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
306}
307
308TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
309 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
310}
311
312TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
313 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100314}
315
316TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100317 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
318}
319
Elad Alonccb9b752019-02-19 13:01:31 +0100320TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
321 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
322}
323
324TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
325 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700326}
327
philipel1e054862018-10-08 16:13:53 +0200328class WebRtcVideoEngineTestWithGenericDescriptor
329 : public WebRtcVideoEngineTest {
330 public:
331 WebRtcVideoEngineTestWithGenericDescriptor()
332 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
333};
334
Elad Alonccb9b752019-02-19 13:01:31 +0100335TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
336 AdvertiseGenericDescriptor00) {
337 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
338}
339
340TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
341 AdvertiseGenericDescriptor01) {
342 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200343}
344
eladalonf1841382017-06-12 01:16:46 -0700345TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200346 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200348 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700349
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200350 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700351
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200352 std::unique_ptr<VideoMediaChannel> channel(
353 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700354 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
355
356 // Add CVO extension.
357 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800358 cricket::VideoSendParameters parameters;
359 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200360 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700361 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200362 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363
Niels Möller731a2c22018-07-30 15:08:07 +0200364 EXPECT_CALL(
365 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200366 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200367 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700368 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200369 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700370
371 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200372 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
374 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200375 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200376 EXPECT_CALL(
377 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200378 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200379 Field(&rtc::VideoSinkWants::rotation_applied, true)));
380
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200381 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700382}
383
eladalonf1841382017-06-12 01:16:46 -0700384TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200385 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800386 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200387 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800388
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200389 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800390
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200391 std::unique_ptr<VideoMediaChannel> channel(
392 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800393 // Add CVO extension.
394 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800395 cricket::VideoSendParameters parameters;
396 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800397 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700398 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800399 EXPECT_TRUE(channel->SetSendParameters(parameters));
400 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
401
Niels Möller731a2c22018-07-30 15:08:07 +0200402 // Set source.
403 EXPECT_CALL(
404 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200405 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200406 Field(&rtc::VideoSinkWants::rotation_applied, false)));
407 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800408}
409
eladalonf1841382017-06-12 01:16:46 -0700410TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200411 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700412
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200413 encoder_factory_->AddSupportedVideoCodecType("VP8");
414 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700415
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200416 std::unique_ptr<VideoMediaChannel> channel(
417 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700418 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
419
420 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200421 EXPECT_CALL(
422 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200423 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200424 Field(&rtc::VideoSinkWants::rotation_applied, true)));
425 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700426
perkjcaafdba2016-03-20 07:34:29 -0700427 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200428 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700429
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700430 // Add CVO extension.
431 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800432 cricket::VideoSendParameters parameters;
433 parameters.codecs.push_back(GetEngineCodec("VP8"));
434 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200435 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700436 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700437 // Also remove the first codec to trigger a codec change as well.
438 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200439 EXPECT_CALL(
440 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200441 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200442 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200443 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700444
445 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200446 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700447
448 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200449 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200450 EXPECT_CALL(
451 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200452 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200453 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200454 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700455}
456
eladalonf1841382017-06-12 01:16:46 -0700457TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200458 encoder_factory_->AddSupportedVideoCodecType("VP8");
459
Sebastian Jansson84848f22018-11-16 10:40:36 +0100460 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200461 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
462 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000463
464 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
465
466 EXPECT_FALSE(channel->SetSend(true))
467 << "Channel should not start without codecs.";
468 EXPECT_TRUE(channel->SetSend(false))
469 << "Channel should be stoppable even without set codecs.";
470}
471
eladalonf1841382017-06-12 01:16:46 -0700472TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200473 encoder_factory_->AddSupportedVideoCodecType("VP8");
474
Sebastian Jansson84848f22018-11-16 10:40:36 +0100475 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200476 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
477 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000478 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
479 VideoMediaInfo info;
480 channel->GetStats(&info);
481}
482
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200483TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200484 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000485
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200486 std::unique_ptr<VideoMediaChannel> channel(
487 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800488 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000489
490 EXPECT_TRUE(
491 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200492 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000493 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100494 webrtc::test::FrameForwarder frame_forwarder;
495 cricket::FakeFrameSource frame_source(1280, 720,
496 rtc::kNumMicrosecsPerSec / 30);
497 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
498 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100499 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200500 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
501 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000502 kTimeout);
503
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200504 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100505 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000506
507 // Setting codecs of the same type should not reallocate any encoders
508 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800509 cricket::VideoSendParameters parameters;
510 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200511 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200512 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000513
514 // Remove stream previously added to free the external encoder instance.
515 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200516 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000517}
518
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200519// Test that when an encoder factory supports H264, we add an RTX
520// codec for it.
521// TODO(deadbeef): This test should be updated if/when we start
522// adding RTX codecs for unrecognized codec names.
523TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800524 using webrtc::H264::ProfileLevelIdToString;
525 using webrtc::H264::ProfileLevelId;
526 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200527 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
528 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800529 *ProfileLevelIdToString(
530 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200531 webrtc::SdpVideoFormat h264_constrained_high("H264");
532 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800533 *ProfileLevelIdToString(
534 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200535 webrtc::SdpVideoFormat h264_high("H264");
536 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800537 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
538
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200539 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
540 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
541 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700542
magjed725e4842016-11-16 00:48:13 -0800543 // First figure out what payload types the test codecs got assigned.
544 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800545 // Now search for RTX codecs for them. Expect that they all have associated
546 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800547 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200548 codecs,
549 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
550 ->id));
magjed725e4842016-11-16 00:48:13 -0800551 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200552 codecs,
553 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
554 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800555 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200556 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700557}
558
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100559#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700560TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200561 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100562
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200563 std::unique_ptr<VideoMediaChannel> channel(
564 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100565
566 EXPECT_TRUE(
567 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
568}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100569#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100570
eladalonf1841382017-06-12 01:16:46 -0700571TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200572 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100573 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200574 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200575 std::unique_ptr<VideoMediaChannel> channel(
576 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700577
578 EXPECT_TRUE(
579 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
580
Niels Möllerd0f0f682019-01-14 09:09:53 +0100581 webrtc::test::FrameForwarder frame_forwarder;
582 cricket::FakeFrameSource frame_source(1280, 720,
583 rtc::kNumMicrosecsPerSec / 60);
584 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700585 channel->SetSend(true);
586
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200587 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700588
Niels Möllerd0f0f682019-01-14 09:09:53 +0100589 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700590 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700591 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100592 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700593 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700594 int64_t interval = timestamp - last_timestamp;
595
596 // Precision changes from nanosecond to millisecond.
597 // Allow error to be no more than 1.
598 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
599
600 last_timestamp = timestamp;
601 }
602
Niels Möllerd0f0f682019-01-14 09:09:53 +0100603 frame_forwarder.IncomingCapturedFrame(
604 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
605 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700606 last_timestamp = stream->GetLastTimestamp();
607 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100608 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
609 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
610 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700611 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700612 int64_t interval = timestamp - last_timestamp;
613
614 // Precision changes from nanosecond to millisecond.
615 // Allow error to be no more than 1.
616 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
617
618 last_timestamp = timestamp;
619 }
620
621 // Remove stream previously added to free the external encoder instance.
622 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
623}
624
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200625void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
626 std::vector<VideoCodec> engine_codecs = engine_.codecs();
627 RTC_DCHECK(!engine_codecs.empty());
628 for (const cricket::VideoCodec& codec : engine_codecs) {
629 if (codec.name == "rtx") {
630 int associated_payload_type;
631 if (codec.GetParam(kCodecParamAssociatedPayloadType,
632 &associated_payload_type)) {
633 default_apt_rtx_types_[associated_payload_type] = codec.id;
634 }
635 }
636 }
637}
638
639void WebRtcVideoEngineTest::AssignDefaultCodec() {
640 std::vector<VideoCodec> engine_codecs = engine_.codecs();
641 RTC_DCHECK(!engine_codecs.empty());
642 bool codec_set = false;
643 for (const cricket::VideoCodec& codec : engine_codecs) {
644 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
645 codec.name != "ulpfec") {
646 default_codec_ = codec;
647 codec_set = true;
648 }
649 }
650
651 RTC_DCHECK(codec_set);
652}
653
Oleh Prypina40f8242017-12-21 13:32:23 +0100654size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
655 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100656 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
657 for (size_t i = 0; i < codecs.size(); ++i) {
658 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200659 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200660 continue;
661 // The tests only use H264 Constrained Baseline. Make sure we don't return
662 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200663 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200664 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200665 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
666 if (profile_level_id->profile !=
667 webrtc::H264::kProfileConstrainedBaseline) {
668 continue;
669 }
670 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100671 return i;
magjed509e4fe2016-11-18 01:34:11 -0800672 }
673 // This point should never be reached.
674 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100675 return -1;
676}
677
678cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
679 const std::string& name) const {
680 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800681}
682
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200683VideoMediaChannel*
684WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100685 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200686 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
687 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200688 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800689 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200690 for (const webrtc::SdpVideoFormat& format :
691 encoder_factory_->GetSupportedFormats()) {
692 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800693 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200694 parameters.codecs.push_back(engine_codec);
695 }
696 }
magjed509e4fe2016-11-18 01:34:11 -0800697
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200698 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000699
700 return channel;
701}
702
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200703VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000704 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100705 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200706 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
707 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200708 cricket::VideoRecvParameters parameters;
709 parameters.codecs = codecs;
710 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000711
712 return channel;
713}
714
Elad Alon157540a2019-02-08 23:37:52 +0100715void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
716 bool supported) const {
717 const RtpCapabilities capabilities = engine_.GetCapabilities();
718 if (supported) {
719 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200720 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100721 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200722 EXPECT_THAT(capabilities.header_extensions,
723 ::testing::Each(::testing::Field(&RtpExtension::uri,
724 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100725 }
726}
727
eladalonf1841382017-06-12 01:16:46 -0700728TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200729 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000730
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200731 std::unique_ptr<VideoMediaChannel> channel(
732 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000733
Peter Boström0c4e06b2015-10-07 12:23:21 +0200734 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000735
Yves Gerey665174f2018-06-19 15:03:05 +0200736 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000737 EXPECT_TRUE(channel->SetSend(true));
738
Niels Möller805a27e2019-01-21 12:21:27 +0100739 webrtc::test::FrameForwarder frame_forwarder;
740 cricket::FakeFrameSource frame_source(1280, 720,
741 rtc::kNumMicrosecsPerSec / 60);
742 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
743 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000744
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200745 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000746
747 // Verify that encoders are configured for simulcast through adapter
748 // (increasing resolution and only configured to send one stream each).
749 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200750 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
751 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000752 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200753 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000754 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
755 EXPECT_GT(codec_settings.width, prev_width);
756 prev_width = codec_settings.width;
757 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000758
Niels Möllerff40b142018-04-09 08:49:14 +0200759 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000760
761 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200762 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000763}
764
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200765TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
766 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200767 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000768
Niels Möllerd0f0f682019-01-14 09:09:53 +0100769 // Frame source.
770 webrtc::test::FrameForwarder frame_forwarder;
771 cricket::FakeFrameSource frame_source(1280, 720,
772 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200773
Sebastian Jansson84848f22018-11-16 10:40:36 +0100774 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200775 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
776 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200777 cricket::VideoSendParameters parameters;
778 parameters.codecs.push_back(GetEngineCodec("H264"));
779 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000780
781 EXPECT_TRUE(
782 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100783 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200784 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100785 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200786
787 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000788
Anders Carlsson67537952018-05-03 11:28:29 +0200789 cricket::VideoSendParameters new_parameters;
790 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
791 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200792
793 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100794 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200795
Anders Carlsson8a150d92018-05-14 12:40:04 +0200796 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000797}
798
eladalonf1841382017-06-12 01:16:46 -0700799TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000800 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200801 encoder_factory_->AddSupportedVideoCodecType("VP8");
802 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000803
Sebastian Jansson84848f22018-11-16 10:40:36 +0100804 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200805 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
806 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800807 cricket::VideoSendParameters parameters;
808 parameters.codecs.push_back(GetEngineCodec("VP8"));
809 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000810
Peter Boström0c4e06b2015-10-07 12:23:21 +0200811 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000812
Yves Gerey665174f2018-06-19 15:03:05 +0200813 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814 EXPECT_TRUE(channel->SetSend(true));
815
816 // Send a fake frame, or else the media engine will configure the simulcast
817 // encoder adapter at a low-enough size that it'll only create a single
818 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100819 webrtc::test::FrameForwarder frame_forwarder;
820 cricket::FakeFrameSource frame_source(1280, 720,
821 rtc::kNumMicrosecsPerSec / 30);
822 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
823 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200825 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
826 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000827 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200828 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000829
830 channel.reset();
831 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200832 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000833}
834
eladalonf1841382017-06-12 01:16:46 -0700835TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200837 encoder_factory_->AddSupportedVideoCodecType("VP8");
838 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000839
Sebastian Jansson84848f22018-11-16 10:40:36 +0100840 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200841 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
842 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800843 cricket::VideoSendParameters parameters;
844 parameters.codecs.push_back(GetEngineCodec("H264"));
845 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000846
847 EXPECT_TRUE(
848 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100849
850 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100851 webrtc::test::FrameForwarder frame_forwarder;
852 cricket::FakeFrameSource frame_source(1280, 720,
853 rtc::kNumMicrosecsPerSec / 30);
854 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
855 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200856 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
857 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200858 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000859 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200860 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000861
862 channel.reset();
863 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200864 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000865}
866
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200867TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
868 webrtc::test::ScopedFieldTrials override_field_trials_(
869 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200870 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700871
Sebastian Jansson84848f22018-11-16 10:40:36 +0100872 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200873 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
874 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200875 cricket::VideoSendParameters parameters;
876 parameters.codecs.push_back(GetEngineCodec("H264"));
877 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700878
Peter Boström0c4e06b2015-10-07 12:23:21 +0200879 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700880 EXPECT_TRUE(
881 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100882
883 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100884 webrtc::test::FrameForwarder frame_forwarder;
885 cricket::FakeFrameSource frame_source(1280, 720,
886 rtc::kNumMicrosecsPerSec / 30);
887 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
888 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100889
Niels Möller4db138e2018-04-19 09:04:13 +0200890 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200891 ASSERT_EQ(1u, encoder_factory_->encoders().size());
892 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
893 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700894 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200895 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200896 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700897}
898
brandtrffc61182016-11-28 06:02:22 -0800899// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700900// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800901//
902// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700903TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800904 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200905 encoder_factory_->AddSupportedVideoCodecType("VP8");
906
Steve Anton2c9ebef2019-01-28 17:27:58 -0800907 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800908
909 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800910 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800911
912 // FlexFEC is active with field trial.
913 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800914 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800915 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800916}
917
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200918// Test that codecs are added in the order they are reported from the factory.
919TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
920 encoder_factory_->AddSupportedVideoCodecType("VP8");
921 const char* kFakeCodecName = "FakeCodec";
922 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000923
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200924 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100925 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200926 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
927 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000928}
929
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200930// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800931// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200932TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100933 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
934 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100935
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100936 // Set up external encoder factory with first codec, and initialize engine.
937 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
938
brandtrffc61182016-11-28 06:02:22 -0800939 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800940
941 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100942 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800943 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200944 // The codec itself and RTX should have been added.
945 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100946
947 // Check that both fake codecs are present and that the second fake codec
948 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100949 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
950 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100951 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800952}
953
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200954TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
955 const char* kFakeCodecName = "FakeCodec";
956 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
957
958 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
959 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
960}
961
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200962TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
963 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200964 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200965 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800966 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000967
kwiberg686a8ef2016-02-26 03:00:35 -0800968 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200969 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000970
971 EXPECT_TRUE(
972 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200973 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000974
975 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200976 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200977 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000978
979 // Remove stream previously added to free the external decoder instance.
980 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200981 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000982}
983
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200984// Verifies that we can set up decoders.
985TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000986 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
987 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
988 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
989 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200990 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200991 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000992 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800993 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000994
kwiberg686a8ef2016-02-26 03:00:35 -0800995 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200996 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000997
998 EXPECT_TRUE(
999 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001000 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001001}
1002
Jonas Oreland49ac5952018-09-26 16:04:32 +02001003// Tests when GetSources is called with non-existing ssrc, it will return an
1004// empty list of RtpSource without crashing.
1005TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1006 // Setup an recv stream with |kSsrc|.
1007 encoder_factory_->AddSupportedVideoCodecType("VP8");
1008 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1009 cricket::VideoRecvParameters parameters;
1010 parameters.codecs.push_back(GetEngineCodec("VP8"));
1011 std::unique_ptr<VideoMediaChannel> channel(
1012 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1013
1014 EXPECT_TRUE(
1015 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1016
1017 // Call GetSources with |kSsrc + 1| which doesn't exist.
1018 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1019 EXPECT_EQ(0u, sources.size());
1020}
1021
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001022TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1023 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1024 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1025 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001026 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001027 EXPECT_EQ(0u, engine.codecs().size());
1028}
1029
1030TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1031 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001032 webrtc::MockVideoEncoderFactory* encoder_factory =
1033 new webrtc::MockVideoEncoderFactory();
1034 webrtc::MockVideoDecoderFactory* decoder_factory =
1035 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001036 WebRtcVideoEngine engine(
1037 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001038 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001039 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1040 EXPECT_EQ(0u, engine.codecs().size());
1041 EXPECT_CALL(*encoder_factory, Die());
1042 EXPECT_CALL(*decoder_factory, Die());
1043}
1044
1045// Test full behavior in the video engine when video codec factories of the new
1046// type are injected supporting the single codec Vp8. Check the returned codecs
1047// from the engine and that we will create a Vp8 encoder and decoder using the
1048// new factories.
1049TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1050 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001051 webrtc::MockVideoEncoderFactory* encoder_factory =
1052 new webrtc::MockVideoEncoderFactory();
1053 webrtc::MockVideoDecoderFactory* decoder_factory =
1054 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001055 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1056 rate_allocator_factory =
1057 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001058 EXPECT_CALL(*rate_allocator_factory,
1059 CreateVideoBitrateAllocatorProxy(Field(
1060 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001061 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001062 WebRtcVideoEngine engine(
1063 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001064 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001065 const webrtc::SdpVideoFormat vp8_format("VP8");
1066 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1067 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001068 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001069
1070 // Verify the codecs from the engine.
1071 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001072 // Verify default codecs has been added correctly.
1073 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001074 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001075
1076 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001077 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001078 int vp8_associated_payload;
1079 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1080 &vp8_associated_payload));
1081 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1082
1083 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1084
1085 // RTX codec for RED.
1086 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1087 int red_associated_payload;
1088 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1089 &red_associated_payload));
1090 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1091
1092 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1093
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001094 int associated_payload_type;
1095 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1096 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1097 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1098 // Verify default parameters has been added to the VP8 codec.
1099 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1100
1101 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001102 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1103 codec_info.is_hardware_accelerated = false;
1104 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001105 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001106 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001107 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001108 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001109 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001110 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001111 .WillOnce(
1112 ::testing::DoAll(::testing::InvokeWithoutArgs(
1113 [&encoder_created]() { encoder_created.Set(); }),
1114 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001115
1116 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001117 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001118 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001119 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001120
1121 // Create a call.
1122 webrtc::RtcEventLogNullImpl event_log;
1123 std::unique_ptr<webrtc::Call> call(
1124 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1125
1126 // Create send channel.
1127 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001128 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001129 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1130 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001131 cricket::VideoSendParameters send_parameters;
1132 send_parameters.codecs.push_back(engine_codecs.at(0));
1133 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1134 send_channel->OnReadyToSend(true);
1135 EXPECT_TRUE(
1136 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1137 EXPECT_TRUE(send_channel->SetSend(true));
1138
Niels Möller4db138e2018-04-19 09:04:13 +02001139 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001140 webrtc::test::FrameForwarder frame_forwarder;
1141 cricket::FakeFrameSource frame_source(1280, 720,
1142 rtc::kNumMicrosecsPerSec / 30);
1143 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001144 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001145 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001146 encoder_created.Wait(kTimeout);
1147
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001148 // Create recv channel.
1149 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001150 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001151 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1152 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001153 cricket::VideoRecvParameters recv_parameters;
1154 recv_parameters.codecs.push_back(engine_codecs.at(0));
1155 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1156 EXPECT_TRUE(recv_channel->AddRecvStream(
1157 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1158
1159 // Remove streams previously added to free the encoder and decoder instance.
1160 EXPECT_CALL(*encoder_factory, Die());
1161 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001162 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001163 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1164 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1165}
1166
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001167// Test behavior when decoder factory fails to create a decoder (returns null).
1168TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1169 // |engine| take ownership of the factories.
1170 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001171 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001172 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001173 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001174 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1175 rate_allocator_factory =
1176 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001177 WebRtcVideoEngine engine(
1178 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001179 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001180 const webrtc::SdpVideoFormat vp8_format("VP8");
1181 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1182 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001183 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001184
1185 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001186 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1187 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001188
1189 // Create a call.
1190 webrtc::RtcEventLogNullImpl event_log;
1191 std::unique_ptr<webrtc::Call> call(
1192 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1193
1194 // Create recv channel.
1195 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001196 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001197 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1198 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001199 cricket::VideoRecvParameters recv_parameters;
1200 recv_parameters.codecs.push_back(engine.codecs().front());
1201 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1202 EXPECT_TRUE(recv_channel->AddRecvStream(
1203 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1204
1205 // Remove streams previously added to free the encoder and decoder instance.
1206 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1207}
1208
eladalonf1841382017-06-12 01:16:46 -07001209TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001210 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001211 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001212 std::unique_ptr<VideoMediaChannel> channel(
1213 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001214 ASSERT_TRUE(
1215 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1216 cricket::VideoCodec codec = GetEngineCodec("VP8");
1217 cricket::VideoSendParameters parameters;
1218 parameters.codecs.push_back(codec);
1219 channel->OnReadyToSend(true);
1220 channel->SetSend(true);
1221 ASSERT_TRUE(channel->SetSendParameters(parameters));
1222
Niels Möller805a27e2019-01-21 12:21:27 +01001223 webrtc::test::FrameForwarder frame_forwarder;
1224 cricket::FakeFrameSource frame_source(1280, 720,
1225 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001226 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001227 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001228
Niels Möller805a27e2019-01-21 12:21:27 +01001229 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001230 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001231 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001232 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001233
Niels Möller805a27e2019-01-21 12:21:27 +01001234 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1235 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001236 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001237 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001238
1239 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001240 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1241 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001242 // Change to screen content, recreate encoder. For the simulcast encoder
1243 // adapter case, this will result in two calls since InitEncode triggers a
1244 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001245 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001246 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001247 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001248
Niels Möller805a27e2019-01-21 12:21:27 +01001249 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1250 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001251 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001252 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001253
1254 options.is_screencast.emplace(false);
1255 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001256 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001257 // Change back to regular video content, update encoder. Also change
1258 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001259 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001260 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001261 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001262 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001263
1264 // Remove stream previously added to free the external encoder instance.
1265 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001266 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001267}
1268
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001269class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001270 protected:
1271 WebRtcVideoChannelBaseTest()
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001272 : video_bitrate_allocator_factory_(
1273 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1274 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1275 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001276
1277 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001278 // One testcase calls SetUp in a loop, only create call_ once.
1279 if (!call_) {
1280 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1281 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001282 cricket::MediaConfig media_config;
1283 // Disabling cpu overuse detection actually disables quality scaling too; it
1284 // implies DegradationPreference kMaintainResolution. Automatic scaling
1285 // needs to be disabled, otherwise, tests which check the size of received
1286 // frames become flaky.
1287 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001288 channel_.reset(
1289 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1290 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001291 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001292 channel_->OnReadyToSend(true);
1293 EXPECT_TRUE(channel_.get() != NULL);
1294 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001295 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001296 cricket::VideoRecvParameters parameters;
1297 parameters.codecs = engine_.codecs();
1298 channel_->SetRecvParameters(parameters);
1299 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001300 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1301 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1302 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1303 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001304 }
1305
1306 // Utility method to setup an additional stream to send and receive video.
1307 // Used to test send and recv between two streams.
1308 void SetUpSecondStream() {
1309 SetUpSecondStreamWithNoRecv();
1310 // Setup recv for second stream.
1311 EXPECT_TRUE(channel_->AddRecvStream(
1312 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1313 // Make the second renderer available for use by a new stream.
1314 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1315 }
1316 // Setup an additional stream just to send video. Defer add recv stream.
1317 // This is required if you want to test unsignalled recv of video rtp packets.
1318 void SetUpSecondStreamWithNoRecv() {
1319 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001320 EXPECT_TRUE(
1321 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001322 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001323 EXPECT_FALSE(
1324 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001325 EXPECT_TRUE(channel_->AddSendStream(
1326 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1327 // We dont add recv for the second stream.
1328
1329 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001330 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001331 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001332 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001333 }
Yves Gerey665174f2018-06-19 15:03:05 +02001334 virtual void TearDown() { channel_.reset(); }
1335 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001336
1337 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001338 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1339 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001340
1341 bool sending = channel_->sending();
1342 bool success = SetSend(false);
1343 if (success) {
1344 cricket::VideoSendParameters parameters;
1345 parameters.codecs.push_back(codec);
1346 success = channel_->SetSendParameters(parameters);
1347 }
1348 if (success) {
1349 success = SetSend(sending);
1350 }
1351 return success;
1352 }
Yves Gerey665174f2018-06-19 15:03:05 +02001353 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001354 void SendFrame() {
1355 if (frame_forwarder_2_) {
1356 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001357 }
Niels Möller805a27e2019-01-21 12:21:27 +01001358 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 }
1360 bool WaitAndSendFrame(int wait_ms) {
1361 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001362 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 return ret;
1364 }
Yves Gerey665174f2018-06-19 15:03:05 +02001365 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001366 int NumRtpBytes(uint32_t ssrc) {
1367 return network_interface_.NumRtpBytes(ssrc);
1368 }
Yves Gerey665174f2018-06-19 15:03:05 +02001369 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001370 int NumRtpPackets(uint32_t ssrc) {
1371 return network_interface_.NumRtpPackets(ssrc);
1372 }
Yves Gerey665174f2018-06-19 15:03:05 +02001373 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001374 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1375 return network_interface_.GetRtpPacket(index);
1376 }
1377 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001378 webrtc::RTPHeader header;
1379 EXPECT_TRUE(ParseRtpPacket(p, &header));
1380 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001381 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001382
Niels Möller6557d0c2018-04-11 15:18:34 +02001383 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001384 webrtc::RTPHeader* header) {
1385 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1386 webrtc::RtpHeaderParser::Create());
1387 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001388 }
1389
1390 // Tests that we can send and receive frames.
1391 void SendAndReceive(const cricket::VideoCodec& codec) {
1392 EXPECT_TRUE(SetOneCodec(codec));
1393 EXPECT_TRUE(SetSend(true));
1394 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1395 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001396 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1398 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1399 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1400 }
1401
1402 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001403 int duration_sec,
1404 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001405 EXPECT_TRUE(SetOneCodec(codec));
1406 EXPECT_TRUE(SetSend(true));
1407 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1408 EXPECT_EQ(0, renderer_.num_rendered_frames());
1409 for (int i = 0; i < duration_sec; ++i) {
1410 for (int frame = 1; frame <= fps; ++frame) {
1411 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1412 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1413 }
1414 }
1415 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1416 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1417 }
1418
Niels Möller6557d0c2018-04-11 15:18:34 +02001419 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1420 cricket::VideoMediaInfo info;
1421 EXPECT_TRUE(channel_->GetStats(&info));
1422 return info.senders[i];
1423 }
1424
1425 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1426 cricket::VideoMediaInfo info;
1427 EXPECT_TRUE(channel_->GetStats(&info));
1428 return info.receivers[i];
1429 }
1430
1431 // Two streams one channel tests.
1432
1433 // Tests that we can send and receive frames.
1434 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1435 SetUpSecondStream();
1436 // Test sending and receiving on first stream.
1437 SendAndReceive(codec);
1438 // Test sending and receiving on second stream.
1439 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1440 EXPECT_GT(NumRtpPackets(), 0);
1441 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1442 }
1443
1444 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1445 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001446 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001447 return engine_codec;
1448 }
1449 // This point should never be reached.
1450 ADD_FAILURE() << "Unrecognized codec name: " << name;
1451 return cricket::VideoCodec();
1452 }
1453
1454 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1455
1456 cricket::StreamParams DefaultSendStreamParams() {
1457 return cricket::StreamParams::CreateLegacy(kSsrc);
1458 }
1459
1460 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001461 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001462 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1463 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001464 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001465
1466 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1467 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1468 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1469
Niels Möller6557d0c2018-04-11 15:18:34 +02001470 std::unique_ptr<WebRtcVideoChannel> channel_;
1471 cricket::FakeNetworkInterface network_interface_;
1472 cricket::FakeVideoRenderer renderer_;
1473
1474 // Used by test cases where 2 streams are run on the same channel.
1475 cricket::FakeVideoRenderer renderer2_;
1476};
1477
1478// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001479TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001480 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001481 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001482 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1483 EXPECT_FALSE(channel_->sending());
1484 EXPECT_TRUE(SetSend(true));
1485 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001486 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001487 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1488 EXPECT_TRUE(SetSend(false));
1489 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001490}
Niels Möller6557d0c2018-04-11 15:18:34 +02001491
1492// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001493TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001494 EXPECT_FALSE(channel_->sending());
1495 EXPECT_FALSE(SetSend(true));
1496 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001497}
Niels Möller6557d0c2018-04-11 15:18:34 +02001498
1499// Test that we properly set the send and recv buffer sizes by the time
1500// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001501TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001502 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1503 EXPECT_TRUE(SetSend(true));
1504 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001505 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001506}
1507
Johannes Kron5a0665b2019-04-08 10:35:50 +02001508// Test that we properly set the send and recv buffer sizes when overriding
1509// via field trials.
1510TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1511 // Set field trial to override the default recv buffer size, and then re-run
1512 // setup where the interface is created and configured.
1513 const int kCustomRecvBufferSize = 123456;
1514 webrtc::test::ScopedFieldTrials field_trial(
1515 "WebRTC-IncreasedReceivebuffers/123456/");
1516 SetUp();
1517
1518 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1519 EXPECT_TRUE(SetSend(true));
1520 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1521 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1522}
1523
1524// Test that we properly set the send and recv buffer sizes when overriding
1525// via field trials with suffix.
1526TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1527 // Set field trial to override the default recv buffer size, and then re-run
1528 // setup where the interface is created and configured.
1529 const int kCustomRecvBufferSize = 123456;
1530 webrtc::test::ScopedFieldTrials field_trial(
1531 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1532 SetUp();
1533
1534 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1535 EXPECT_TRUE(SetSend(true));
1536 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1537 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1538}
1539
1540// Test that we properly set the send and recv buffer sizes when overriding
1541// via field trials that don't make any sense.
1542TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1543 // Set bogus field trial values to override the default recv buffer size, and
1544 // then re-run setup where the interface is created and configured. The
1545 // default value should still be used.
1546
1547 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1548 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1549 field_trial_string += group;
1550 field_trial_string += "/";
1551 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1552 SetUp();
1553
1554 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1555 EXPECT_TRUE(SetSend(true));
1556 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1557 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1558 }
1559}
1560
Niels Möller6557d0c2018-04-11 15:18:34 +02001561// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001562TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001563 const int kDurationSec = 3;
1564 const int kFps = 10;
1565 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1566
1567 cricket::VideoMediaInfo info;
1568 EXPECT_TRUE(channel_->GetStats(&info));
1569
1570 ASSERT_EQ(1U, info.senders.size());
1571 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1572 // For webrtc, bytes_sent does not include the RTP header length.
1573 EXPECT_GT(info.senders[0].bytes_sent, 0);
1574 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1575 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1576 ASSERT_TRUE(info.senders[0].codec_payload_type);
1577 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1578 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1579 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1580 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1581 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1582 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1583 EXPECT_GT(info.senders[0].framerate_input, 0);
1584 EXPECT_GT(info.senders[0].framerate_sent, 0);
1585
1586 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1587 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1588 info.send_codecs[DefaultCodec().id]);
1589
1590 ASSERT_EQ(1U, info.receivers.size());
1591 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1592 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1593 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1594 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1595 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1596 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1597 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1598 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1599 EXPECT_EQ(0, info.receivers[0].packets_lost);
1600 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1601 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1602 EXPECT_EQ(0, info.receivers[0].firs_sent);
1603 EXPECT_EQ(0, info.receivers[0].plis_sent);
1604 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1605 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1606 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1607 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1608 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1609 EXPECT_GT(info.receivers[0].framerate_output, 0);
1610
1611 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1612 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1613 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001614}
Niels Möller6557d0c2018-04-11 15:18:34 +02001615
1616// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001617TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001618 cricket::FakeVideoRenderer renderer1, renderer2;
1619 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1620 cricket::VideoSendParameters parameters;
1621 parameters.codecs.push_back(DefaultCodec());
1622 parameters.conference_mode = true;
1623 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1624 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001625 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1626 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001627 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1628 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1629 EXPECT_EQ(0, renderer1.num_rendered_frames());
1630 EXPECT_EQ(0, renderer2.num_rendered_frames());
1631 std::vector<uint32_t> ssrcs;
1632 ssrcs.push_back(1);
1633 ssrcs.push_back(2);
1634 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001635 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001636 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1637 kTimeout);
1638 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1639 kTimeout);
1640
1641 EXPECT_TRUE(channel_->SetSend(false));
1642
1643 cricket::VideoMediaInfo info;
1644 EXPECT_TRUE(channel_->GetStats(&info));
1645 ASSERT_EQ(1U, info.senders.size());
1646 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1647 // For webrtc, bytes_sent does not include the RTP header length.
1648 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1649 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1650 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1651 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1652
1653 ASSERT_EQ(2U, info.receivers.size());
1654 for (size_t i = 0; i < info.receivers.size(); ++i) {
1655 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1656 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1657 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001658 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001659 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1660 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1661 }
srtee0c2eea2017-12-15 17:44:33 +01001662}
Niels Möller6557d0c2018-04-11 15:18:34 +02001663
1664// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001665TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001666 // Normal setup; note that we set the SSRC explicitly to ensure that
1667 // it will come first in the senders map.
1668 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1669 cricket::VideoSendParameters parameters;
1670 parameters.codecs.push_back(DefaultCodec());
1671 parameters.conference_mode = true;
1672 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001673 EXPECT_TRUE(
1674 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001675 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1676 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001677 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001678 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1679 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1680
1681 // Add an additional capturer, and hook up a renderer to receive it.
1682 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001683 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001684 const int kTestWidth = 160;
1685 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001686 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1687 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001688 EXPECT_TRUE(
1689 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001690 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001691 EXPECT_TRUE(
1692 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001693 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001694 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001695 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1696 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001697
1698 // Get stats, and make sure they are correct for two senders. We wait until
1699 // the number of expected packets have been sent to avoid races where we
1700 // check stats before it has been updated.
1701 cricket::VideoMediaInfo info;
1702 for (uint32_t i = 0; i < kTimeout; ++i) {
1703 rtc::Thread::Current()->ProcessMessages(1);
1704 EXPECT_TRUE(channel_->GetStats(&info));
1705 ASSERT_EQ(2U, info.senders.size());
1706 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1707 NumRtpPackets()) {
1708 // Stats have been updated for both sent frames, expectations can be
1709 // checked now.
1710 break;
1711 }
1712 }
1713 EXPECT_EQ(NumRtpPackets(),
1714 info.senders[0].packets_sent + info.senders[1].packets_sent)
1715 << "Timed out while waiting for packet counts for all sent packets.";
1716 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1717 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1718 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1719 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1720 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1721 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1722 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1723 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1724 // The capturer must be unregistered here as it runs out of it's scope next.
1725 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001726}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001727
Niels Möller6557d0c2018-04-11 15:18:34 +02001728// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001729TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 cricket::VideoSendParameters parameters;
1731 parameters.codecs.push_back(DefaultCodec());
1732 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1733 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1734 parameters.max_bandwidth_bps = 128 * 1024;
1735 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001736}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001737
Niels Möller6557d0c2018-04-11 15:18:34 +02001738// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001739TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001740 EXPECT_TRUE(SetDefaultCodec());
1741 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001742 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001743 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001744 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001745 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001746 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1747 EXPECT_EQ(kSsrc, header.ssrc);
1748
Niels Möller6557d0c2018-04-11 15:18:34 +02001749 // Packets are being paced out, so these can mismatch between the first and
1750 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001751 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1752 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001753 EXPECT_EQ(1, NumSentSsrcs());
1754 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1755 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001756}
Niels Möller6557d0c2018-04-11 15:18:34 +02001757
1758// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001759TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001760 // Remove stream added in Setup.
1761 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1762 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001763 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001764 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001765 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001766 EXPECT_TRUE(SetSend(true));
1767 EXPECT_TRUE(WaitAndSendFrame(0));
1768 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001769 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001770 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001771 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1772 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001773 // Packets are being paced out, so these can mismatch between the first and
1774 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001775 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1776 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001777 EXPECT_EQ(1, NumSentSsrcs());
1778 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1779 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001780}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001781
Niels Möller6557d0c2018-04-11 15:18:34 +02001782// Test that we can set the default video renderer before and after
1783// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001784TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001785 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1786 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001787
1788 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1789 rtc::SetBE32(packet1.data() + 8, kSsrc);
1790 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1791 EXPECT_TRUE(SetDefaultCodec());
1792 EXPECT_TRUE(SetSend(true));
1793 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001794 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001796 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001797 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001798}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001799
Niels Möller6557d0c2018-04-11 15:18:34 +02001800// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001801TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001802 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1803 EXPECT_TRUE(SetSend(true));
1804 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001805 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001806 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1807 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001808 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001809 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001810 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1811 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001812 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1813 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001814
1815 // Remove the send stream that was added during Setup.
1816 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1817 int rtp_packets = NumRtpPackets();
1818
Niels Möller6557d0c2018-04-11 15:18:34 +02001819 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001820 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001821 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001822 EXPECT_EQ(rtp_packets, NumRtpPackets());
1823 // Wait 30ms to guarantee the engine does not drop the frame.
1824 EXPECT_TRUE(WaitAndSendFrame(30));
1825 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1826
1827 last_packet = NumRtpPackets() - 1;
1828 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001829 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1830 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001831}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001832
Niels Möller6557d0c2018-04-11 15:18:34 +02001833// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001834TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001835 cricket::FakeVideoRenderer renderer1, renderer2;
1836 EXPECT_TRUE(SetDefaultCodec());
1837 cricket::VideoSendParameters parameters;
1838 parameters.codecs.push_back(DefaultCodec());
1839 parameters.conference_mode = true;
1840 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1841 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001842 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1843 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001844 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1845 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1846 EXPECT_EQ(0, renderer1.num_rendered_frames());
1847 EXPECT_EQ(0, renderer2.num_rendered_frames());
1848 std::vector<uint32_t> ssrcs;
1849 ssrcs.push_back(1);
1850 ssrcs.push_back(2);
1851 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001852 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001853 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1854 kTimeout);
1855 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1856 kTimeout);
1857
1858 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1859 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1860 EXPECT_EQ(kVideoWidth, renderer1.width());
1861 EXPECT_EQ(kVideoHeight, renderer1.height());
1862 EXPECT_EQ(kVideoWidth, renderer2.width());
1863 EXPECT_EQ(kVideoHeight, renderer2.height());
1864 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1865 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001866}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001867
Niels Möller6557d0c2018-04-11 15:18:34 +02001868// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001869TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001870 using cricket::VideoCodec;
1871 using cricket::VideoOptions;
1872 using cricket::VideoFormat;
1873 using cricket::FOURCC_I420;
1874
1875 VideoCodec codec = DefaultCodec();
1876 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1877 EXPECT_TRUE(SetOneCodec(codec));
1878 EXPECT_TRUE(SetSend(true));
1879 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1880 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001881 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001882 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001883
1884 webrtc::test::FrameForwarder frame_forwarder;
1885 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1886 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001887
1888 // TODO(nisse): This testcase fails if we don't configure
1889 // screencast. It's unclear why, I see nothing obvious in this
1890 // test which is related to screencast logic.
1891 VideoOptions video_options;
1892 video_options.is_screencast = true;
1893 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1894
Niels Möller6557d0c2018-04-11 15:18:34 +02001895 int captured_frames = 1;
1896 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001897 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001898 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001899 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1900
Niels Möller6557d0c2018-04-11 15:18:34 +02001901 ++captured_frames;
1902 // Wait until frame of right size is captured.
1903 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001904 480 == renderer_.width() &&
1905 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001906 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001907 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001908 EXPECT_EQ(480, renderer_.width());
1909 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001910 captured_frames = renderer_.num_rendered_frames() + 1;
1911 EXPECT_FALSE(renderer_.black_frame());
1912 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1913 // Make sure a black frame is generated within the specified timeout.
1914 // The black frame should be the resolution of the previous frame to
1915 // prevent expensive encoder reconfigurations.
1916 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001917 480 == renderer_.width() &&
1918 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001919 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001920 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001921 EXPECT_EQ(480, renderer_.width());
1922 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 EXPECT_TRUE(renderer_.black_frame());
1924
1925 // The black frame has the same timestamp as the next frame since it's
1926 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1927 // not render a frame with the same timestamp so capture another frame
1928 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001929 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001930 }
srtee0c2eea2017-12-15 17:44:33 +01001931}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001932
Niels Möller6557d0c2018-04-11 15:18:34 +02001933// Tests that if SetVideoSend is called with a NULL capturer after the
1934// capturer was already removed, the application doesn't crash (and no black
1935// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001936TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001937 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1938 EXPECT_TRUE(SetSend(true));
1939 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1940 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001941 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001942 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1943 // Wait for one frame so they don't get dropped because we send frames too
1944 // tightly.
1945 rtc::Thread::Current()->ProcessMessages(30);
1946 // Remove the capturer.
1947 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1948
1949 // No capturer was added, so this SetVideoSend shouldn't do anything.
1950 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1951 rtc::Thread::Current()->ProcessMessages(300);
1952 // Verify no more frames were sent.
1953 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001954}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001955
Niels Möller6557d0c2018-04-11 15:18:34 +02001956// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001957TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1959 // interval time to avoid that.
1960 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1961 // interval time to avoid that.
1962 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001963 EXPECT_TRUE(
1964 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001965 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1966 cricket::VideoFormat capture_format(
1967 kVideoWidth, kVideoHeight,
1968 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1969 // Set up additional stream 1.
1970 cricket::FakeVideoRenderer renderer1;
1971 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001972 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001974 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001975
1976 webrtc::test::FrameForwarder frame_forwarder1;
1977 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1978 rtc::kNumMicrosecsPerSec / kFramerate);
1979
Niels Möller6557d0c2018-04-11 15:18:34 +02001980 // Set up additional stream 2.
1981 cricket::FakeVideoRenderer renderer2;
1982 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001983 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001984 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001985 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01001986 webrtc::test::FrameForwarder frame_forwarder2;
1987
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 // State for all the streams.
1989 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1990 // A limitation in the lmi implementation requires that SetVideoSend() is
1991 // called after SetOneCodec().
1992 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01001993 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
1994 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02001995 EXPECT_TRUE(SetSend(true));
1996 // Test capturer associated with engine.
1997 const int kTestWidth = 160;
1998 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001999 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2000 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2001 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002002 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2003 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002005 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2006 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2007 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002008 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2009 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002010 // Successfully remove the capturer.
2011 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2012 // The capturers must be unregistered here as it runs out of it's scope
2013 // next.
2014 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2015 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002016}
Niels Möller6557d0c2018-04-11 15:18:34 +02002017
2018// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002019TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002020 // Remove the send stream that was added during Setup.
2021 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2022
2023 cricket::StreamParams empty;
2024 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002025 EXPECT_TRUE(
2026 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002027}
Niels Möller6557d0c2018-04-11 15:18:34 +02002028
2029// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002030TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002031 // Remove stream added in Setup. I.e. remove stream corresponding to default
2032 // channel.
2033 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002034 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002035 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2036 EXPECT_TRUE(channel_->AddSendStream(
2037 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2038 }
2039 // Delete one of the non default channel streams, let the destructor delete
2040 // the remaining ones.
2041 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2042 // Stream should already be deleted.
2043 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002044}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002045
eladalonf1841382017-06-12 01:16:46 -07002046TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002047 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002048}
2049
eladalonf1841382017-06-12 01:16:46 -07002050TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002051 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002052}
2053
eladalonf1841382017-06-12 01:16:46 -07002054TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002055 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002056}
2057
eladalonf1841382017-06-12 01:16:46 -07002058TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002059 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2060 // bitrates. This currently happens at <250k, and two streams sharing 300k
2061 // initially will use QVGA instead of VGA.
2062 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2063 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002064 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002065 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002066 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002067}
2068
eladalonf1841382017-06-12 01:16:46 -07002069class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002070 public:
eladalonf1841382017-06-12 01:16:46 -07002071 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2072 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002073 : WebRtcVideoEngineTest(field_trials),
2074 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2075 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002076 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002077 encoder_factory_->AddSupportedVideoCodecType("VP8");
2078 encoder_factory_->AddSupportedVideoCodecType("VP9");
2079#if defined(WEBRTC_USE_H264)
2080 encoder_factory_->AddSupportedVideoCodecType("H264");
2081#endif
2082
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002083 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002084 channel_.reset(engine_.CreateMediaChannel(
2085 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2086 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002087 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002088 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002089 send_parameters_.codecs = engine_.codecs();
2090 recv_parameters_.codecs = engine_.codecs();
2091 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002092 }
2093
2094 protected:
2095 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002096 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002097 }
2098
2099 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002100 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002101 EXPECT_TRUE(channel_->AddSendStream(sp));
2102 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002103 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002104 EXPECT_EQ(num_streams + 1, streams.size());
2105 return streams[streams.size() - 1];
2106 }
2107
2108 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002109 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002110 }
2111
2112 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002113 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002114 }
2115
2116 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002117 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002118 EXPECT_TRUE(channel_->AddRecvStream(sp));
2119 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002120 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002121 EXPECT_EQ(num_streams + 1, streams.size());
2122 return streams[streams.size() - 1];
2123 }
2124
pbos@webrtc.org00873182014-11-25 14:03:34 +00002125 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2126 int expected_min_bitrate_bps,
2127 const char* start_bitrate_kbps,
2128 int expected_start_bitrate_bps,
2129 const char* max_bitrate_kbps,
2130 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002131 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2132 expected_start_bitrate_bps,
2133 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002134 auto& codecs = send_parameters_.codecs;
2135 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002136 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002137 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2138 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2139 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002140 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002141 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002142
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002143 void ExpectSetBitrateParameters(int min_bitrate_bps,
2144 int start_bitrate_bps,
2145 int max_bitrate_bps) {
2146 EXPECT_CALL(
2147 *fake_call_->GetMockTransportControllerSend(),
2148 SetSdpBitrateParameters(AllOf(
2149 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2150 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2151 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2152 }
2153
2154 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2155 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2156 SetSdpBitrateParameters(Field(
2157 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002158 }
2159
Johannes Kron9190b822018-10-29 11:22:05 +01002160 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2161 // For a caller, the answer will be applied in set remote description
2162 // where SetSendParameters() is called.
2163 EXPECT_TRUE(
2164 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2165 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2166 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2167 const webrtc::VideoSendStream::Config& config =
2168 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2169 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2170 }
2171
2172 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2173 // For a callee, the answer will be applied in set local description
2174 // where SetExtmapAllowMixed() and AddSendStream() are called.
2175 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2176 EXPECT_TRUE(
2177 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2178 const webrtc::VideoSendStream::Config& config =
2179 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2180 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2181 }
2182
isheriff6f8d6862016-05-26 11:24:55 -07002183 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002184 // Enable extension.
2185 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002186 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002187 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002188 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002189 FakeVideoSendStream* send_stream =
2190 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2191
2192 // Verify the send extension id.
2193 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2194 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002195 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002196 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002197 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002198 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2199 // receivers.
2200 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2201 ->GetConfig()
2202 .rtp.extensions.empty());
2203
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002204 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002205 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002206 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2207 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002208 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2209
2210 // Verify that adding receive RTP header extensions adds them for existing
2211 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002212 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002213 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002214 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2215 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002216 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002217 }
2218
isheriff6f8d6862016-05-26 11:24:55 -07002219 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002220 // Enable extension.
2221 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002222 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002223 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002224 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002225
2226 FakeVideoReceiveStream* recv_stream =
2227 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2228
2229 // Verify the recv extension id.
2230 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2231 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002232 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002233 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002234 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002235
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002236 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2237 // senders.
2238 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2239 ->GetConfig()
2240 .rtp.extensions.empty());
2241
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002242 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002243 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002244 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2245 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002246 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2247
2248 // Verify that adding receive RTP header extensions adds them for existing
2249 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002250 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002251 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002252 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2253 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002254 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002255 }
2256
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002257 void TestExtensionFilter(const std::vector<std::string>& extensions,
2258 const std::string& expected_extension) {
2259 cricket::VideoSendParameters parameters = send_parameters_;
2260 int expected_id = -1;
2261 int id = 1;
2262 for (const std::string& extension : extensions) {
2263 if (extension == expected_extension)
2264 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002265 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002266 }
2267 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2268 FakeVideoSendStream* send_stream =
2269 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2270
2271 // Verify that only one of them has been set, and that it is the one with
2272 // highest priority (transport sequence number).
2273 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2274 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2275 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002276 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002277 }
2278
asapersson3c81a1a2017-06-14 05:52:21 -07002279 void TestDegradationPreference(bool resolution_scaling_enabled,
2280 bool fps_scaling_enabled);
2281
Erik Språngefbde372015-04-29 16:21:28 +02002282 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002283 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002284 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2285 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002286
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002287 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002288 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002289 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002290 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002291 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002292 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002293 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002294 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002295 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002296
Erik Språng143cec12015-04-28 10:01:41 +02002297 return fake_call_->GetVideoSendStreams().back();
2298 }
2299
Peter Boström2feafdb2015-09-09 14:32:14 +02002300 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2301 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002302 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002303 std::vector<uint32_t> ssrcs;
2304 std::vector<uint32_t> rtx_ssrcs;
2305 uint32_t num_streams = enabled ? 3 : 1;
2306 for (uint32_t i = 0; i < num_streams; ++i) {
2307 uint32_t ssrc = last_ssrc_ + i;
2308 ssrcs.push_back(ssrc);
2309 if (with_rtx) {
2310 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2311 }
Erik Språng143cec12015-04-28 10:01:41 +02002312 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002313 if (with_rtx) {
2314 return AddSendStream(
2315 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2316 }
2317 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002318 }
2319
perkjfa10b552016-10-02 23:45:26 -07002320 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002321 std::vector<FakeVideoSendStream*> streams =
2322 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002323 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002324 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002325 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002326 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002327 }
2328
perkjfa10b552016-10-02 23:45:26 -07002329 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002330 int stream_max,
2331 int expected_encoder_bitrate) {
2332 VideoSendParameters limited_send_params = send_parameters_;
2333 limited_send_params.max_bandwidth_bps = global_max;
2334 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002335 webrtc::RtpParameters parameters =
2336 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002337 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002338 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002339 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002340 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002341 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002342 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002343 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002344 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002345 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002346 }
2347
Åsa Persson55659812018-06-18 17:51:32 +02002348 // Values from kSimulcastConfigs in simulcast.cc.
2349 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2350 std::vector<webrtc::VideoStream> layers(3);
2351 layers[0].min_bitrate_bps = 30000;
2352 layers[0].target_bitrate_bps = 150000;
2353 layers[0].max_bitrate_bps = 200000;
2354 layers[1].min_bitrate_bps = 150000;
2355 layers[1].target_bitrate_bps = 500000;
2356 layers[1].max_bitrate_bps = 700000;
2357 layers[2].min_bitrate_bps = 600000;
2358 layers[2].target_bitrate_bps = 2500000;
2359 layers[2].max_bitrate_bps = 2500000;
2360 return layers;
2361 }
2362
Niels Möller805a27e2019-01-21 12:21:27 +01002363 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002364 std::unique_ptr<FakeCall> fake_call_;
2365 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002366 cricket::VideoSendParameters send_parameters_;
2367 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002368 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002369};
2370
eladalonf1841382017-06-12 01:16:46 -07002371TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002372 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002373 const std::string kSyncLabel = "AvSyncLabel";
2374
2375 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002376 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002377 EXPECT_TRUE(channel_->AddRecvStream(sp));
2378
Mirko Bonadeif859e552018-05-30 15:31:29 +02002379 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002380 EXPECT_EQ(kSyncLabel,
2381 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2382 << "SyncGroup should be set based on sync_label";
2383}
2384
eladalonf1841382017-06-12 01:16:46 -07002385TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002386 cricket::VideoSendParameters parameters;
2387 parameters.codecs = engine_.codecs();
2388 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002389 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002390 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002391 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002392
2393 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002394 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2395 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002396 FakeVideoSendStream* send_stream = AddSendStream(
2397 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2398
2399 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2400 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2401 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2402
2403 // Receiver side.
2404 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2405 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002406 EXPECT_FALSE(
2407 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002408 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002409 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002410 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002411 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002412 << "RTX should be mapped for the RED payload type";
2413
brandtr14742122017-01-27 04:53:07 -08002414 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002415}
2416
eladalonf1841382017-06-12 01:16:46 -07002417TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002418 // Setup one channel with an associated RTX stream.
2419 cricket::StreamParams params =
2420 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2421 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2422 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002423 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002424
2425 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2426 << "RTX should be mapped for all decoders/payload types.";
2427 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002428 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002429 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002430}
2431
eladalonf1841382017-06-12 01:16:46 -07002432TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002433 // Setup one channel without an associated RTX stream.
2434 cricket::StreamParams params =
2435 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2436 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002437 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002438}
2439
Johannes Kron9190b822018-10-29 11:22:05 +01002440// Test propagation of extmap allow mixed setting.
2441TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2442 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2443}
2444TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2445 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2446}
2447TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2448 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2449}
2450TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2451 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2452}
2453
eladalonf1841382017-06-12 01:16:46 -07002454TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002455 FakeVideoSendStream* send_stream =
2456 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2457 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2458
2459 FakeVideoReceiveStream* recv_stream =
2460 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2461 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002462}
2463
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002464// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002465TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002466 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002467}
isheriff6f8d6862016-05-26 11:24:55 -07002468
eladalonf1841382017-06-12 01:16:46 -07002469TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002470 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002471}
2472
2473// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002474TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002475 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002476}
isheriff6f8d6862016-05-26 11:24:55 -07002477
eladalonf1841382017-06-12 01:16:46 -07002478TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002479 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002480}
2481
eladalonf1841382017-06-12 01:16:46 -07002482TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002483 // Enable three redundant extensions.
2484 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002485 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2486 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2487 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2488 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002489}
2490
eladalonf1841382017-06-12 01:16:46 -07002491TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002492 // Enable two redundant extensions.
2493 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002494 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2495 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2496 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002497}
2498
stefanc1aeaf02015-10-15 07:26:07 -07002499// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002500TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002501 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002502}
eladalonf1841382017-06-12 01:16:46 -07002503TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002504 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002505}
2506
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002507// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002508TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002509 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002510}
eladalonf1841382017-06-12 01:16:46 -07002511TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002512 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002513}
2514
eladalonf1841382017-06-12 01:16:46 -07002515TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002516 const int kAbsSendTimeId = 1;
2517 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002518 send_parameters_.extensions.push_back(
2519 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2520 send_parameters_.extensions.push_back(
2521 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002522
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002523 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002524 FakeVideoSendStream* send_stream =
2525 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2526
2527 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002528 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002529
2530 // Setting the same extensions (even if in different order) shouldn't
2531 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002532 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002533 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002534
2535 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2536
2537 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002538 send_parameters_.extensions.resize(1);
2539 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002540
2541 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2542}
2543
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002545 const int kTOffsetId = 1;
2546 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002547 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002548 recv_parameters_.extensions.push_back(
2549 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2550 recv_parameters_.extensions.push_back(
2551 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2552 recv_parameters_.extensions.push_back(
2553 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002554
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002555 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002556 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002557 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2558
2559 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002560 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002561
2562 // Setting the same extensions (even if in different order) shouldn't
2563 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002564 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002565 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002566
2567 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2568
2569 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002570 recv_parameters_.extensions.resize(1);
2571 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002572
2573 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2574}
2575
eladalonf1841382017-06-12 01:16:46 -07002576TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002577 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002578 const int kUnsupportedId = 1;
2579 const int kTOffsetId = 2;
2580
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002581 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002582 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002583 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002584 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002585 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002586 FakeVideoSendStream* send_stream =
2587 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2588
2589 // Only timestamp offset extension is set to send stream,
2590 // unsupported rtp extension is ignored.
2591 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002592 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2593 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002594}
2595
eladalonf1841382017-06-12 01:16:46 -07002596TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002597 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002598 const int kUnsupportedId = 1;
2599 const int kTOffsetId = 2;
2600
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002601 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002602 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002603 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002604 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002605 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002606 FakeVideoReceiveStream* recv_stream =
2607 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2608
2609 // Only timestamp offset extension is set to receive stream,
2610 // unsupported rtp extension is ignored.
2611 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002612 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2613 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002614}
2615
eladalonf1841382017-06-12 01:16:46 -07002616TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002617 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002618 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002619 send_parameters_.extensions.push_back(
2620 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002621 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002622 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2623 }
2624}
2625
eladalonf1841382017-06-12 01:16:46 -07002626TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002627 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002628 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002629 recv_parameters_.extensions.push_back(
2630 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002631 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002632 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2633 }
2634}
2635
eladalonf1841382017-06-12 01:16:46 -07002636TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002637 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002638 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002639 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002640 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002641 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002642 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002643
2644 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 send_parameters_.extensions.clear();
2646 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002647 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002648 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2649 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002650}
2651
eladalonf1841382017-06-12 01:16:46 -07002652TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002653 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002654 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002655 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002656 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002657 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002658 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002659
2660 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002661 recv_parameters_.extensions.clear();
2662 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002663 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002664 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2665 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002666}
2667
eladalonf1841382017-06-12 01:16:46 -07002668TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002669 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002670 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002671}
2672
eladalonf1841382017-06-12 01:16:46 -07002673TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002674 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002675 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002676}
2677
eladalonf1841382017-06-12 01:16:46 -07002678TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002679 FakeVideoReceiveStream* stream = AddRecvStream();
2680 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002681}
2682
eladalonf1841382017-06-12 01:16:46 -07002683TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002684 FakeVideoReceiveStream* stream = AddRecvStream();
2685 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2686}
2687
eladalonf1841382017-06-12 01:16:46 -07002688TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002689 FakeVideoReceiveStream* stream = AddRecvStream();
2690 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2691
Peter Boström126c03e2015-05-11 12:48:12 +02002692 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002693 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002694 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002695 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2696 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002697 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002698 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2699
2700 // Verify that REMB is turned on when setting default codecs since the
2701 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002702 parameters.codecs = engine_.codecs();
2703 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002704 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002705 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002706}
2707
eladalonf1841382017-06-12 01:16:46 -07002708TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002709 FakeVideoReceiveStream* stream = AddRecvStream();
2710 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2711
2712 // Verify that transport cc feedback is turned off when send(!) codecs without
2713 // transport cc feedback are set.
2714 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002715 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002716 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2717 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2718 stream = fake_call_->GetVideoReceiveStreams()[0];
2719 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2720
2721 // Verify that transport cc feedback is turned on when setting default codecs
2722 // since the default codecs have transport cc feedback enabled.
2723 parameters.codecs = engine_.codecs();
2724 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2725 stream = fake_call_->GetVideoReceiveStreams()[0];
2726 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2727}
2728
eladalonf1841382017-06-12 01:16:46 -07002729TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002730 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002731 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2732
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002733 cricket::VideoSendParameters parameters;
2734 parameters.codecs = engine_.codecs();
2735 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002736 EXPECT_TRUE(channel_->SetSend(true));
2737
2738 // Send side.
2739 FakeVideoSendStream* send_stream =
2740 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2741 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2742
2743 // Receiver side.
2744 FakeVideoReceiveStream* recv_stream =
2745 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2746 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2747
2748 // Nack history size should match between sender and receiver.
2749 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2750 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002751}
2752
eladalonf1841382017-06-12 01:16:46 -07002753TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002754 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002755 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002756
2757 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2758 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2759
2760 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002761 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002762 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002763 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2764 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002765 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2766 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2767 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002768 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2769
Peter Boström67c9df72015-05-11 14:34:58 +02002770 // Verify that NACK is turned on when setting default codecs since the
2771 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002772 parameters.codecs = engine_.codecs();
2773 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002774 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2775 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2776 send_stream = fake_call_->GetVideoSendStreams()[0];
2777 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002778}
2779
Peter Boströme7ba0862016-03-12 00:02:28 +01002780// This test verifies that new frame sizes reconfigures encoders even though not
2781// (yet) sending. The purpose of this is to permit encoding as quickly as
2782// possible once we start sending. Likely the frames being input are from the
2783// same source that will be sent later, which just means that we're ready
2784// earlier.
eladalonf1841382017-06-12 01:16:46 -07002785TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002786 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002787 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002788 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2789 channel_->SetSend(false);
2790
2791 FakeVideoSendStream* stream = AddSendStream();
2792
perkjfa10b552016-10-02 23:45:26 -07002793 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002794 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002795 EXPECT_EQ(0u, streams[0].width);
2796 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002797
Niels Möller805a27e2019-01-21 12:21:27 +01002798 webrtc::test::FrameForwarder frame_forwarder;
2799 cricket::FakeFrameSource frame_source(1280, 720,
2800 rtc::kNumMicrosecsPerSec / 30);
2801
2802 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2803 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002804
2805 // Frame entered, should be reconfigured to new dimensions.
2806 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002807 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2808 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002809
Niels Möllerff40b142018-04-09 08:49:14 +02002810 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002811}
2812
eladalonf1841382017-06-12 01:16:46 -07002813TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002814 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002815 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002816 cricket::VideoSendParameters parameters;
2817 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002818 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002819 AddSendStream();
2820
Niels Möller805a27e2019-01-21 12:21:27 +01002821 webrtc::test::FrameForwarder frame_forwarder;
2822 cricket::FakeFrameSource frame_source(1280, 720,
2823 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002824 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002825 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002826 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2827 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002828
2829 EXPECT_TRUE(channel_->SetSend(true));
2830
Niels Möller805a27e2019-01-21 12:21:27 +01002831 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002832 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2833 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2834
2835 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2836
2837 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002838 webrtc::VideoEncoderConfig encoder_config =
2839 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002840 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002841 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002842 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002843 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2844 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002845 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2846 << "Non-screenshare shouldn't use min-transmit bitrate.";
2847
Niels Möllerff40b142018-04-09 08:49:14 +02002848 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002849 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002850 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002851 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002852 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2853 &frame_forwarder));
2854 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002855 // Send stream recreated after option change.
2856 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2857 send_stream = fake_call_->GetVideoSendStreams().front();
2858 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002859
2860 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002861 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002862 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002863 encoder_config.content_type);
2864 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2865 encoder_config.min_transmit_bitrate_bps);
2866
perkjfa10b552016-10-02 23:45:26 -07002867 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002868 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2869 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002870 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002871 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002872}
2873
eladalonf1841382017-06-12 01:16:46 -07002874TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002875 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002876 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002877 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002878 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002879
2880 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002881 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002882 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002883 webrtc::test::FrameForwarder frame_forwarder;
2884 cricket::FakeFrameSource frame_source(1280, 720,
2885 rtc::kNumMicrosecsPerSec / 30);
2886 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002887 EXPECT_TRUE(channel_->SetSend(true));
2888
Niels Möller805a27e2019-01-21 12:21:27 +01002889 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002890 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2891 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2892
perkj26091b12016-09-01 01:17:40 -07002893 webrtc::VideoEncoderConfig encoder_config =
2894 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002895
2896 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002897 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002898 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002899 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002900
2901 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2902 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002903 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002904 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002905 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002906
Niels Möllerff40b142018-04-09 08:49:14 +02002907 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002908}
2909
eladalonf1841382017-06-12 01:16:46 -07002910TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002911 FakeVideoSendStream* stream = AddSendStream();
2912 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2913}
2914
eladalonf1841382017-06-12 01:16:46 -07002915TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002916 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002917 media_config.video.suspend_below_min_bitrate = true;
2918
Sebastian Jansson84848f22018-11-16 10:40:36 +01002919 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002920 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
2921 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002922 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002923
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002924 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002925
2926 FakeVideoSendStream* stream = AddSendStream();
2927 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2928
nisse0db023a2016-03-01 04:29:59 -08002929 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002930 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002931 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
2932 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002933 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002934
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002935 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002936
nisse0db023a2016-03-01 04:29:59 -08002937 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002938 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2939}
2940
eladalonf1841382017-06-12 01:16:46 -07002941TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002942 FakeVideoSendStream* stream = AddSendStream();
2943 webrtc::VideoCodecVP8 vp8_settings;
2944 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2945 EXPECT_TRUE(vp8_settings.denoisingOn);
2946}
2947
eladalonf1841382017-06-12 01:16:46 -07002948TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002949 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002950 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002951 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002952
Peter Boström2feafdb2015-09-09 14:32:14 +02002953 // Single-stream settings should apply with RTX as well (verifies that we
2954 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2955 // both RTX and regular SSRCs).
2956 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002957
Niels Möller805a27e2019-01-21 12:21:27 +01002958 webrtc::test::FrameForwarder frame_forwarder;
2959 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002960 channel_->SetSend(true);
2961
Niels Möller805a27e2019-01-21 12:21:27 +01002962 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002963
pbos4cba4eb2015-10-26 11:18:18 -07002964 webrtc::VideoCodecVP8 vp8_settings;
2965 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2966 EXPECT_TRUE(vp8_settings.denoisingOn)
2967 << "VP8 denoising should be on by default.";
2968
Niels Möller805a27e2019-01-21 12:21:27 +01002969 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002970
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002971 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2972 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002973 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2974 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002975
Niels Möller805a27e2019-01-21 12:21:27 +01002976 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002977
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002978 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2979 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002980 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2981 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2982
Niels Möllerff40b142018-04-09 08:49:14 +02002983 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002984 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01002985 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002986 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01002987 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002988
Mirko Bonadeif859e552018-05-30 15:31:29 +02002989 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002990 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2991 // Autmatic resize off when using simulcast.
2992 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2993 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2994
2995 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002996 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002997 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002998 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01002999
Niels Möller805a27e2019-01-21 12:21:27 +01003000 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003001
Mirko Bonadeif859e552018-05-30 15:31:29 +02003002 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003003 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3004 EXPECT_FALSE(vp8_settings.denoisingOn);
3005 // Resizing and frame dropping always off for screen sharing.
3006 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3007 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3008
Niels Möller805a27e2019-01-21 12:21:27 +01003009 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003010
3011 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3012 EXPECT_FALSE(vp8_settings.denoisingOn);
3013 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3014 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3015
Niels Möllerff40b142018-04-09 08:49:14 +02003016 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003017}
3018
deadbeef119760a2016-04-04 11:43:27 -07003019// Test that setting the same options doesn't result in the encoder being
3020// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003021TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003022 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003023 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003024
perkjfa10b552016-10-02 23:45:26 -07003025 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003026 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003027 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003028 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3029 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3030
Niels Möller805a27e2019-01-21 12:21:27 +01003031 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3032 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3033 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003034 // Expect 1 reconfigurations at this point from the initial configuration.
3035 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003036
3037 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003038 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003039 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3040
3041 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003042 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003043 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003044 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3045
Niels Möllerff40b142018-04-09 08:49:14 +02003046 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003047}
3048
eladalonf1841382017-06-12 01:16:46 -07003049class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003050 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003051 Vp9SettingsTest() : Vp9SettingsTest("") {}
3052 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003053 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003054 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003055 }
3056 virtual ~Vp9SettingsTest() {}
3057
3058 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003059 void TearDown() override {
3060 // Remove references to encoder_factory_ since this will be destroyed
3061 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003062 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003063 }
Erik Språng143cec12015-04-28 10:01:41 +02003064};
3065
3066TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003067 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003068 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003069 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003070
Peter Boström2feafdb2015-09-09 14:32:14 +02003071 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003072
Niels Möller805a27e2019-01-21 12:21:27 +01003073 webrtc::test::FrameForwarder frame_forwarder;
3074 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003075 channel_->SetSend(true);
3076
Niels Möller805a27e2019-01-21 12:21:27 +01003077 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003078
pbos4cba4eb2015-10-26 11:18:18 -07003079 webrtc::VideoCodecVP9 vp9_settings;
3080 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003081 EXPECT_TRUE(vp9_settings.denoisingOn)
3082 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003083
Niels Möller805a27e2019-01-21 12:21:27 +01003084 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003085
Erik Språng143cec12015-04-28 10:01:41 +02003086 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3087 EXPECT_FALSE(vp9_settings.denoisingOn);
3088 // Frame dropping always on for real time video.
3089 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3090
Niels Möller805a27e2019-01-21 12:21:27 +01003091 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003092
3093 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3094 EXPECT_TRUE(vp9_settings.denoisingOn);
3095 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3096
3097 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003098 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003099 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003100 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003101
Niels Möller805a27e2019-01-21 12:21:27 +01003102 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003103
3104 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3105 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003106 // Frame dropping always on for screen sharing.
3107 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003108
Niels Möller805a27e2019-01-21 12:21:27 +01003109 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003110
3111 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3112 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003113 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003114
Niels Möllerff40b142018-04-09 08:49:14 +02003115 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003116}
3117
Sergey Silkinf18072e2018-03-14 10:35:35 +01003118TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3119 cricket::VideoSendParameters parameters;
3120 parameters.codecs.push_back(GetEngineCodec("VP9"));
3121 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3122
3123 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3124
3125 FakeVideoSendStream* stream =
3126 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3127
3128 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003129
Niels Möller805a27e2019-01-21 12:21:27 +01003130 webrtc::test::FrameForwarder frame_forwarder;
3131 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003132 channel_->SetSend(true);
3133
Niels Möller805a27e2019-01-21 12:21:27 +01003134 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003135
3136 webrtc::VideoCodecVP9 vp9_settings;
3137 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3138
3139 const size_t kNumSpatialLayers = ssrcs.size();
3140 const size_t kNumTemporalLayers = 3;
3141 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3142 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3143
Niels Möllerff40b142018-04-09 08:49:14 +02003144 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003145}
3146
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003147TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3148 cricket::VideoSendParameters parameters;
3149 parameters.codecs.push_back(GetEngineCodec("VP9"));
3150 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3151
3152 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3153
3154 FakeVideoSendStream* stream =
3155 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3156
3157 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3158
3159 // Despite 3 ssrcs provided, single layer is used.
3160 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3161
3162 webrtc::test::FrameForwarder frame_forwarder;
3163 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3164 channel_->SetSend(true);
3165
3166 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3167
3168 webrtc::VideoCodecVP9 vp9_settings;
3169 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3170
3171 const size_t kNumSpatialLayers = ssrcs.size();
3172 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3173
3174 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3175}
3176
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003177TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3178 cricket::VideoSendParameters send_parameters;
3179 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3180 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3181
3182 const size_t kNumSpatialLayers = 3;
3183 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3184
3185 FakeVideoSendStream* stream =
3186 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3187
3188 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3189 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3190 ASSERT_TRUE(parameters.encodings[0].active);
3191 ASSERT_TRUE(parameters.encodings[1].active);
3192 ASSERT_TRUE(parameters.encodings[2].active);
3193 // Invert value to verify copying.
3194 parameters.encodings[1].active = false;
3195 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3196
3197 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3198
3199 // number_of_streams should be 1 since all spatial layers are sent on the
3200 // same SSRC. But encoding parameters of all layers is supposed to be copied
3201 // and stored in simulcast_layers[].
3202 EXPECT_EQ(1u, encoder_config.number_of_streams);
3203 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3204 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3205 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3206 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3207}
3208
Sergey Silkincf267052019-04-09 11:40:09 +02003209class Vp9SettingsTestWithFieldTrial
3210 : public Vp9SettingsTest,
3211 public ::testing::WithParamInterface<
3212 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003213 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003214 Vp9SettingsTestWithFieldTrial()
3215 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3216 num_spatial_layers_(::testing::get<1>(GetParam())),
3217 num_temporal_layers_(::testing::get<2>(GetParam())),
3218 inter_layer_pred_(::testing::get<3>(GetParam())) {}
3219
3220 void VerifySettings(int num_spatial_layers,
3221 int num_temporal_layers,
3222 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003223 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003224 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003225 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3226
3227 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3228
Niels Möller805a27e2019-01-21 12:21:27 +01003229 webrtc::test::FrameForwarder frame_forwarder;
3230 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003231 channel_->SetSend(true);
3232
Niels Möller805a27e2019-01-21 12:21:27 +01003233 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003234
3235 webrtc::VideoCodecVP9 vp9_settings;
3236 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3237 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3238 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkincf267052019-04-09 11:40:09 +02003239 EXPECT_EQ(inter_layer_pred_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003240
Niels Möllerff40b142018-04-09 08:49:14 +02003241 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003242 }
Sergey Silkincf267052019-04-09 11:40:09 +02003243
3244 const uint8_t num_spatial_layers_;
3245 const uint8_t num_temporal_layers_;
3246 const webrtc::InterLayerPredMode inter_layer_pred_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003247};
3248
Sergey Silkincf267052019-04-09 11:40:09 +02003249TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
3250 VerifySettings(num_spatial_layers_, num_temporal_layers_, inter_layer_pred_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003251}
3252
Sergey Silkincf267052019-04-09 11:40:09 +02003253INSTANTIATE_TEST_SUITE_P(
3254 ,
3255 Vp9SettingsTestWithFieldTrial,
3256 ::testing::Values(
3257 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3258 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3259 1,
3260 1,
3261 webrtc::InterLayerPredMode::kOnKeyPic),
3262 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3263 2,
3264 3,
3265 webrtc::InterLayerPredMode::kOnKeyPic),
3266 std::make_tuple("WebRTC-Vp9InterLayerPred/0/",
3267 1,
3268 1,
3269 webrtc::InterLayerPredMode::kOff),
3270 std::make_tuple("WebRTC-Vp9InterLayerPred/1/",
3271 1,
3272 1,
3273 webrtc::InterLayerPredMode::kOn),
3274 std::make_tuple("WebRTC-Vp9InterLayerPred/2/",
3275 1,
3276 1,
3277 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003278
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003279TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3280 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3281 ASSERT_EQ(1u, streams.size());
3282 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3283}
3284
3285TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3286 webrtc::test::ScopedFieldTrials override_field_trials_(
3287 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3288 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3289 ASSERT_EQ(1u, streams.size());
3290 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3291}
3292
asapersson3c81a1a2017-06-14 05:52:21 -07003293TEST_F(WebRtcVideoChannelTest,
3294 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3295 webrtc::test::ScopedFieldTrials override_field_trials_(
3296 "WebRTC-Video-BalancedDegradation/Disabled/");
3297 const bool kResolutionScalingEnabled = true;
3298 const bool kFpsScalingEnabled = false;
3299 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3300}
3301
3302TEST_F(WebRtcVideoChannelTest,
3303 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3304 webrtc::test::ScopedFieldTrials override_field_trials_(
3305 "WebRTC-Video-BalancedDegradation/Enabled/");
3306 const bool kResolutionScalingEnabled = true;
3307 const bool kFpsScalingEnabled = true;
3308 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3309}
3310
eladalonf1841382017-06-12 01:16:46 -07003311TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003312 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003313}
3314
eladalonf1841382017-06-12 01:16:46 -07003315TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003316 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003317}
3318
Niels Möller3de32e62019-01-18 08:42:18 +01003319TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3320 TestCpuAdaptation(false, true);
3321}
3322
eladalonf1841382017-06-12 01:16:46 -07003323TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003324 TestCpuAdaptation(true, true);
3325}
3326
eladalonf1841382017-06-12 01:16:46 -07003327TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003328 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003329 cricket::VideoSendParameters parameters;
3330 parameters.codecs.push_back(codec);
3331
kthelgason2bc68642017-02-07 07:02:22 -08003332 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003333 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003334 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003335 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3336 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003337 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003338 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3339
3340 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003341 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003342
Per766ad3b2016-04-05 15:23:49 +02003343 ASSERT_TRUE(channel_->SetSend(true));
3344 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003345 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003346 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003347
3348 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3349 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003350
Niels Möllerdcc70292019-01-15 16:32:38 +01003351 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3352 // Dont' expect anything on framerate_scaling_enabled, since the default is
3353 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003354
Niels Möllerdcc70292019-01-15 16:32:38 +01003355 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003356 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003357 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003358 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003359 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3360 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003361 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003362
Niels Möllerdcc70292019-01-15 16:32:38 +01003363 // Switch back to the normal capturer. Expect resolution scaling to be
3364 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003365 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3366 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003367 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3368 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003369 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003370
Niels Möllerff40b142018-04-09 08:49:14 +02003371 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003372}
3373
asapersson3c81a1a2017-06-14 05:52:21 -07003374// TODO(asapersson): Remove this test when the balanced field trial is removed.
3375void WebRtcVideoChannelTest::TestDegradationPreference(
3376 bool resolution_scaling_enabled,
3377 bool fps_scaling_enabled) {
3378 cricket::VideoCodec codec = GetEngineCodec("VP8");
3379 cricket::VideoSendParameters parameters;
3380 parameters.codecs.push_back(codec);
3381
3382 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003383 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003384 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003385 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3386 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003387 channel_->OnReadyToSend(true);
3388
3389 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3390
3391 AddSendStream();
3392
Niels Möller805a27e2019-01-21 12:21:27 +01003393 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003394 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003395 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003396
3397 EXPECT_TRUE(channel_->SetSend(true));
3398
3399 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3400 EXPECT_EQ(resolution_scaling_enabled,
3401 send_stream->resolution_scaling_enabled());
3402 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3403
Niels Möllerff40b142018-04-09 08:49:14 +02003404 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003405}
3406
eladalonf1841382017-06-12 01:16:46 -07003407void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3408 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003409 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003410 cricket::VideoSendParameters parameters;
3411 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003412
kthelgason2bc68642017-02-07 07:02:22 -08003413 MediaConfig media_config = GetMediaConfig();
3414 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003415 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003416 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003417 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003418 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3419 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003420 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003421
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003422 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003423
3424 AddSendStream();
3425
Niels Möller805a27e2019-01-21 12:21:27 +01003426 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003427 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003428 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003429 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003430
3431 EXPECT_TRUE(channel_->SetSend(true));
3432
solenberge5269742015-09-08 05:13:22 -07003433 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003434
sprangc5d62e22017-04-02 23:53:04 -07003435 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003436 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003437 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003438 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003439 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3440 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3441 } else {
3442 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3443 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3444 }
Niels Möllerff40b142018-04-09 08:49:14 +02003445 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003446}
3447
eladalonf1841382017-06-12 01:16:46 -07003448TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003449 // Start at last timestamp to verify that wraparounds are estimated correctly.
3450 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3451 static const int64_t kInitialNtpTimeMs = 1247891230;
3452 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003453 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003454
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003455 FakeVideoReceiveStream* stream = AddRecvStream();
3456 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003457 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003458
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003459 webrtc::VideoFrame video_frame =
3460 webrtc::VideoFrame::Builder()
3461 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3462 .set_timestamp_rtp(kInitialTimestamp)
3463 .set_timestamp_us(0)
3464 .set_rotation(webrtc::kVideoRotation_0)
3465 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003466 // Initial NTP time is not available on the first frame, but should still be
3467 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003468 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003469
3470 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003471
3472 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3473 // triggers a constant-overflow warning, hence we're calculating it explicitly
3474 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003475 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003476 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3477 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003478 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003479
3480 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003481
3482 // Verify that NTP time has been correctly deduced.
3483 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003484 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003485 ASSERT_EQ(1u, info.receivers.size());
3486 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003487}
3488
eladalonf1841382017-06-12 01:16:46 -07003489TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003490 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003491 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003492
3493 VideoCodec codec;
3494 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003495 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003496
3497 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003498 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3499 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003500 FakeVideoSendStream* stream = AddSendStream(
3501 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003502 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003503
3504 // Make sure NACK and FEC are enabled on the correct payload types.
3505 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003506 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3507 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003508
3509 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3510 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003511 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003512 // TODO(juberti): Check RTCP, PLI, TMMBR.
3513}
3514
brandtr31bd2242017-05-19 05:47:46 -07003515// The following four tests ensures that FlexFEC is not activated by default
3516// when the field trials are not enabled.
3517// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3518// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003519TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003520 FakeVideoSendStream* stream = AddSendStream();
3521 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3522
brandtr3d200bd2017-01-16 06:59:19 -08003523 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003524 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3525 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003526}
3527
eladalonf1841382017-06-12 01:16:46 -07003528TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003529 FakeVideoSendStream* stream = AddSendStream(
3530 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3531 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3532
brandtr3d200bd2017-01-16 06:59:19 -08003533 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003534 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3535 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3536}
3537
Yves Gerey665174f2018-06-19 15:03:05 +02003538TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003539 AddRecvStream();
3540
3541 const std::vector<FakeFlexfecReceiveStream*>& streams =
3542 fake_call_->GetFlexfecReceiveStreams();
3543 EXPECT_TRUE(streams.empty());
3544}
3545
eladalonf1841382017-06-12 01:16:46 -07003546TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003547 AddRecvStream(
3548 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3549
3550 const std::vector<FakeFlexfecReceiveStream*>& streams =
3551 fake_call_->GetFlexfecReceiveStreams();
3552 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003553}
3554
3555// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3556// tests that use this test fixture into the corresponding "non-field trial"
3557// tests.
eladalonf1841382017-06-12 01:16:46 -07003558class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003559 public:
eladalonf1841382017-06-12 01:16:46 -07003560 WebRtcVideoChannelFlexfecRecvTest()
3561 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003562};
3563
eladalonf1841382017-06-12 01:16:46 -07003564TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003565 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3566 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3567 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3568}
3569
eladalonf1841382017-06-12 01:16:46 -07003570TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003571 AddRecvStream();
3572
3573 const std::vector<FakeFlexfecReceiveStream*>& streams =
3574 fake_call_->GetFlexfecReceiveStreams();
3575 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003576
3577 const std::vector<FakeVideoReceiveStream*>& video_streams =
3578 fake_call_->GetVideoReceiveStreams();
3579 ASSERT_EQ(1U, video_streams.size());
3580 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3581 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3582 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003583}
3584
eladalonf1841382017-06-12 01:16:46 -07003585TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003586 AddRecvStream(
3587 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3588
3589 const std::vector<FakeFlexfecReceiveStream*>& streams =
3590 fake_call_->GetFlexfecReceiveStreams();
3591 ASSERT_EQ(1U, streams.size());
3592 const FakeFlexfecReceiveStream* stream = streams.front();
3593 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3594 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3595 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3596 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3597 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003598
3599 const std::vector<FakeVideoReceiveStream*>& video_streams =
3600 fake_call_->GetVideoReceiveStreams();
3601 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003602 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3603 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003604 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003605 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003606 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003607}
3608
eladalonf1841382017-06-12 01:16:46 -07003609TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003610 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3611 cricket::VideoRecvParameters recv_parameters;
3612 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3613 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3614
3615 AddRecvStream(
3616 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3617 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003618 const std::vector<FakeVideoReceiveStream*>& video_streams =
3619 fake_call_->GetVideoReceiveStreams();
3620 ASSERT_EQ(1U, video_streams.size());
3621 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3622 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3623 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003624
3625 // Enable FlexFEC.
3626 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3627 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3628 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3629 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3630 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3631 << "Enabling FlexFEC should not create VideoReceiveStream.";
3632 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3633 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003634 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3635 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003636}
3637
eladalonf1841382017-06-12 01:16:46 -07003638TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003639 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3640 cricket::VideoRecvParameters recv_parameters;
3641 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3642 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3643 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3644
3645 AddRecvStream(
3646 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3647 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003648 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003649 const std::vector<FakeVideoReceiveStream*>& video_streams =
3650 fake_call_->GetVideoReceiveStreams();
3651 ASSERT_EQ(1U, video_streams.size());
3652 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3653 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3654 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003655
3656 // Disable FlexFEC.
3657 recv_parameters.codecs.clear();
3658 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3659 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3660 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3661 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3662 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3663 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3664 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3665 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003666 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3667 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003668}
3669
brandtr31bd2242017-05-19 05:47:46 -07003670// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3671// tests that use this test fixture into the corresponding "non-field trial"
3672// tests.
eladalonf1841382017-06-12 01:16:46 -07003673class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003674 public:
eladalonf1841382017-06-12 01:16:46 -07003675 WebRtcVideoChannelFlexfecSendRecvTest()
3676 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003677 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3678 }
3679};
3680
Yves Gerey665174f2018-06-19 15:03:05 +02003681TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003682 FakeVideoSendStream* stream = AddSendStream();
3683 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3684
brandtr3d200bd2017-01-16 06:59:19 -08003685 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3686 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3687 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003688}
3689
eladalonf1841382017-06-12 01:16:46 -07003690TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003691 FakeVideoSendStream* stream = AddSendStream(
3692 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3693 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3694
brandtr3d200bd2017-01-16 06:59:19 -08003695 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3696 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3697 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3698 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003699}
3700
eladalonf1841382017-06-12 01:16:46 -07003701TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003702 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003703 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003704 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003705
3706 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003707 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003708
brandtrb5f2c3f2016-10-04 23:28:39 -07003709 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3710 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003711}
3712
eladalonf1841382017-06-12 01:16:46 -07003713TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003714 cricket::VideoSendParameters parameters;
3715 parameters.codecs.push_back(GetEngineCodec("VP8"));
3716 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3717
3718 FakeVideoSendStream* stream = AddSendStream();
3719 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3720
brandtr3d200bd2017-01-16 06:59:19 -08003721 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003722}
3723
eladalonf1841382017-06-12 01:16:46 -07003724TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003725 AddRecvStream(
3726 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003727
3728 cricket::VideoRecvParameters recv_parameters;
3729 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3730 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3731 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003732
3733 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3734 fake_call_->GetFlexfecReceiveStreams();
3735 ASSERT_EQ(1U, flexfec_streams.size());
3736 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3737 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3738 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003739 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003740 flexfec_stream_config.payload_type);
3741 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3742 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3743 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3744 const std::vector<FakeVideoReceiveStream*>& video_streams =
3745 fake_call_->GetVideoReceiveStreams();
3746 const FakeVideoReceiveStream* video_stream = video_streams.front();
3747 const webrtc::VideoReceiveStream::Config& video_stream_config =
3748 video_stream->GetConfig();
3749 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3750 flexfec_stream_config.local_ssrc);
3751 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3752 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3753 flexfec_stream_config.rtcp_send_transport);
3754 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3755 // spec-compliant way.
3756 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3757 flexfec_stream_config.transport_cc);
3758 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3759 EXPECT_EQ(video_stream_config.rtp.extensions,
3760 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003761}
3762
brandtr31bd2242017-05-19 05:47:46 -07003763// We should not send FlexFEC, even if we advertise it, unless the right
3764// field trial is set.
3765// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003766TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003767 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3768 cricket::VideoSendParameters parameters;
3769 parameters.codecs.push_back(GetEngineCodec("VP8"));
3770 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3771 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3772
3773 FakeVideoSendStream* stream = AddSendStream();
3774 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3775
3776 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003777 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003778 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3779}
3780
eladalonf1841382017-06-12 01:16:46 -07003781TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003782 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3783 cricket::VideoSendParameters parameters;
3784 parameters.codecs.push_back(GetEngineCodec("VP8"));
3785 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3786 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3787
3788 FakeVideoSendStream* stream = AddSendStream(
3789 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3790 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3791
3792 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003793 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003794 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3795}
3796
eladalonf1841382017-06-12 01:16:46 -07003797TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003798 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003799 const int kUnusedPayloadType = 127;
3800 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3801
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003802 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003803 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003804 parameters.codecs.push_back(rtx_codec);
3805 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003806 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003807}
3808
eladalonf1841382017-06-12 01:16:46 -07003809TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003810 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003811 const int kUnusedPayloadType1 = 126;
3812 const int kUnusedPayloadType2 = 127;
3813 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3814 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3815 {
3816 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3817 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3818 cricket::VideoSendParameters parameters;
3819 parameters.codecs.push_back(GetEngineCodec("VP8"));
3820 parameters.codecs.push_back(rtx_codec);
3821 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3822 }
3823 {
3824 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3825 kUnusedPayloadType1, kUnusedPayloadType2);
3826 cricket::VideoSendParameters parameters;
3827 parameters.codecs.push_back(GetEngineCodec("VP8"));
3828 parameters.codecs.push_back(rtx_codec);
3829 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3830 << "RTX without matching video codec should be rejected.";
3831 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003832}
3833
eladalonf1841382017-06-12 01:16:46 -07003834TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003835 const int kUnusedPayloadType1 = 126;
3836 const int kUnusedPayloadType2 = 127;
3837 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3838 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3839
3840 // SSRCs for RTX.
3841 cricket::StreamParams params =
3842 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3843 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3844 AddSendStream(params);
3845
3846 // Original payload type for RTX.
3847 cricket::VideoSendParameters parameters;
3848 parameters.codecs.push_back(GetEngineCodec("VP8"));
3849 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3850 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3851 parameters.codecs.push_back(rtx_codec);
3852 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3853 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3854 const webrtc::VideoSendStream::Config& config_before =
3855 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3856 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3857 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3858 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3859
3860 // Change payload type for RTX.
3861 parameters.codecs[1].id = kUnusedPayloadType2;
3862 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3863 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3864 const webrtc::VideoSendStream::Config& config_after =
3865 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3866 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3867 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3868 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3869}
3870
eladalonf1841382017-06-12 01:16:46 -07003871TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003872 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003873 parameters.codecs.push_back(GetEngineCodec("VP8"));
3874 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003875 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003876
3877 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003878 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003879
magjed509e4fe2016-11-18 01:34:11 -08003880 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003881
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003882 parameters.codecs.pop_back();
3883 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003884 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003885 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003886 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003887 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003888 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3889}
3890
eladalonf1841382017-06-12 01:16:46 -07003891TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003892 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003893 cricket::VideoSendParameters parameters;
3894 parameters.codecs.push_back(GetEngineCodec("VP8"));
3895 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3896 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3897
3898 FakeVideoSendStream* stream = AddSendStream(
3899 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3900 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3901
brandtr3d200bd2017-01-16 06:59:19 -08003902 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3903 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003904 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3905 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3906
3907 parameters.codecs.pop_back();
3908 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3909 stream = fake_call_->GetVideoSendStreams()[0];
3910 ASSERT_TRUE(stream != nullptr);
3911 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003912 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003913 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003914}
3915
eladalonf1841382017-06-12 01:16:46 -07003916TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003917 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003918 cricket::VideoCodec codec(100, "VP8");
3919 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3920 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003921
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003922 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003923 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003924
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003925 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003926 webrtc::test::FrameForwarder frame_forwarder;
3927 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003928
3929 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003930 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003931
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003932 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003933 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3934 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003935 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003936 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003937 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003938 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003939}
3940
eladalonf1841382017-06-12 01:16:46 -07003941TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003942 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3943 200000);
3944}
3945
eladalonf1841382017-06-12 01:16:46 -07003946TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003947 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3948 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3949 ASSERT_EQ(1u, streams.size());
3950 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3951}
3952
eladalonf1841382017-06-12 01:16:46 -07003953TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003954 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003955 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003956}
3957
eladalonf1841382017-06-12 01:16:46 -07003958TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003959 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003960}
3961
eladalonf1841382017-06-12 01:16:46 -07003962TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003963 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3964 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3965 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003966}
3967
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003968// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3969// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003970TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003971 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3972 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3973 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3974 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003975 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003976 ExpectSetBitrateParameters(100000, 200000, 400000);
3977 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3978 // Since the codec isn't changing, start_bitrate_bps should be -1.
3979 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003980
3981 // Decrease max_bandwidth_bps.
3982 send_parameters_.max_bandwidth_bps = 350000;
3983 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003984
3985 // Now try again with the values flipped around.
3986 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3987 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003988 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003989 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003990
3991 // If we change the codec max, max_bandwidth_bps should still apply.
3992 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003993 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003994 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003995}
3996
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07003997// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3998// are present in the same send parameters, the settings are combined correctly.
3999TEST_F(WebRtcVideoChannelTest,
4000 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4001 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4002 // Transport.
4003 webrtc::MediaTransportSettings settings;
4004 settings.is_caller = true;
4005 webrtc::FakeMediaTransport fake_media_transport(settings);
4006 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4007 new cricket::FakeNetworkInterface);
4008 channel_->SetInterface(network_interface.get(), &fake_media_transport);
4009
4010 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4011 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4012 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4013 send_parameters_.max_bandwidth_bps = 400000;
4014 {
4015 // We expect max_bandwidth_bps to take priority, if set.
4016 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4017 ASSERT_EQ(1u,
4018 fake_media_transport.target_rate_constraints_in_order().size());
4019 const webrtc::MediaTransportTargetRateConstraints& constraint =
4020 fake_media_transport.target_rate_constraints_in_order()[0];
4021 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4022 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4023 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4024 }
4025
4026 {
4027 // Decrease max_bandwidth_bps.
4028 send_parameters_.max_bandwidth_bps = 350000;
4029 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4030 ASSERT_EQ(2u,
4031 fake_media_transport.target_rate_constraints_in_order().size());
4032 const webrtc::MediaTransportTargetRateConstraints& constraint =
4033 fake_media_transport.target_rate_constraints_in_order()[1];
4034
4035 // Since the codec isn't changing, start_bitrate_bps should be 0.
4036 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4037 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4038 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4039 }
4040
4041 {
4042 // Now try again with the values flipped around.
4043 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4044 send_parameters_.max_bandwidth_bps = 300000;
4045 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4046 ASSERT_EQ(3u,
4047 fake_media_transport.target_rate_constraints_in_order().size());
4048 const webrtc::MediaTransportTargetRateConstraints& constraint =
4049 fake_media_transport.target_rate_constraints_in_order()[2];
4050
4051 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4052 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4053 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4054 }
4055
4056 {
4057 // Now try again with the values flipped around.
4058 // If we change the codec max, max_bandwidth_bps should still apply.
4059 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4060 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4061 ASSERT_EQ(4u,
4062 fake_media_transport.target_rate_constraints_in_order().size());
4063 const webrtc::MediaTransportTargetRateConstraints& constraint =
4064 fake_media_transport.target_rate_constraints_in_order()[3];
4065
4066 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4067 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4068 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4069 }
4070}
4071
Yves Gerey665174f2018-06-19 15:03:05 +02004072TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004073 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4074 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004075 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004076 // Setting max bitrate should keep previous min bitrate.
4077 // Setting max bitrate should not reset start bitrate.
4078 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004079 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004080}
4081
eladalonf1841382017-06-12 01:16:46 -07004082TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004083 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004084 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004085 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004086 // -1 means to disable max bitrate (set infinite).
4087 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004088 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004089 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004090}
4091
eladalonf1841382017-06-12 01:16:46 -07004092TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004093 send_parameters_.max_bandwidth_bps = 99999;
4094 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004095 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004096 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004097 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4098 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4099 stream->GetVideoStreams()[0].max_bitrate_bps);
4100
4101 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004102 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004103 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4104 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004105 stream->GetVideoStreams()[0].max_bitrate_bps);
4106}
4107
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004108// Tests that when the codec specific max bitrate and VideoSendParameters
4109// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4110// appropriately.
4111TEST_F(WebRtcVideoChannelTest,
4112 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4113 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4114 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4115 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4116 send_parameters_.max_bandwidth_bps = -1;
4117 AddSendStream();
4118 ExpectSetMaxBitrate(300000);
4119 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4120
4121 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4122 ASSERT_EQ(1u, video_send_streams.size());
4123 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4124 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4125 // First the max bitrate is set based upon the codec param.
4126 EXPECT_EQ(300000,
4127 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4128
4129 // The VideoSendParameters max bitrate overrides the codec's.
4130 send_parameters_.max_bandwidth_bps = 500000;
4131 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4132 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4133 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4134 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4135}
4136
4137// Tests that when the codec specific max bitrate and RtpParameters
4138// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4139// appropriately.
4140TEST_F(WebRtcVideoChannelTest,
4141 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4142 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4143 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4144 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4145 send_parameters_.max_bandwidth_bps = -1;
4146 AddSendStream();
4147 ExpectSetMaxBitrate(300000);
4148 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4149
4150 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4151 ASSERT_EQ(1u, video_send_streams.size());
4152 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4153 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4154 // First the max bitrate is set based upon the codec param.
4155 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4156
4157 // The RtpParameter max bitrate overrides the codec's.
4158 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4159 ASSERT_EQ(1u, parameters.encodings.size());
4160 parameters.encodings[0].max_bitrate_bps = 500000;
4161 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4162 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4163 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4164 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4165}
4166
Åsa Persson55659812018-06-18 17:51:32 +02004167TEST_F(WebRtcVideoChannelTest,
4168 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4169 send_parameters_.max_bandwidth_bps = 99999;
4170 FakeVideoSendStream* stream = AddSendStream();
4171 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4172 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4173 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4174 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4175 stream->GetVideoStreams()[0].max_bitrate_bps);
4176
4177 // Get and set the rtp encoding parameters.
4178 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4179 EXPECT_EQ(1u, parameters.encodings.size());
4180
4181 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4182 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4183 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4184 stream->GetVideoStreams()[0].max_bitrate_bps);
4185
4186 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4187 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4188 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4189 stream->GetVideoStreams()[0].max_bitrate_bps);
4190}
4191
eladalonf1841382017-06-12 01:16:46 -07004192TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004193 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004194 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004195 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004196 channel_->SetSend(true);
4197
4198 FakeVideoSendStream* stream = AddSendStream();
4199
Niels Möller805a27e2019-01-21 12:21:27 +01004200 webrtc::test::FrameForwarder frame_forwarder;
4201 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004202
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004203 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4204 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4205 EXPECT_GT(initial_max_bitrate_bps, 0);
4206
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004207 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4208 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004209 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004210 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004211 streams = stream->GetVideoStreams();
4212 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004213 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004214}
4215
eladalonf1841382017-06-12 01:16:46 -07004216TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004217 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004218 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004219 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004220 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004221 channel_->SetSend(true);
4222
4223 FakeVideoSendStream* stream = AddSendStream(
4224 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4225
4226 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004227 webrtc::test::FrameForwarder frame_forwarder;
4228 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4229 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004230
4231 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4232 ASSERT_GT(streams.size(), 1u)
4233 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004234 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004235 EXPECT_GT(initial_max_bitrate_bps, 0);
4236
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004237 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4238 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004239 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004240 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004241 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004242 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004243 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4244
Niels Möllerff40b142018-04-09 08:49:14 +02004245 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004246}
4247
eladalonf1841382017-06-12 01:16:46 -07004248TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004249 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004250 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004251 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004252 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4253 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004254 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004255 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004256
4257 VideoCodec codec;
4258 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4259 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4260}
4261
eladalonf1841382017-06-12 01:16:46 -07004262TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004263 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004264 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004265 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004266 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004267 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004268 parameters.codecs[0].id = kIncorrectPayloads[i];
4269 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004270 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004271 }
4272}
4273
eladalonf1841382017-06-12 01:16:46 -07004274TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004275 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004276 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004277 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004278 parameters.codecs[0].id = payload_type;
4279 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004280 << "Payload type '" << payload_type << "' rejected.";
4281 }
4282}
4283
deadbeef67cf2c12016-04-13 10:07:16 -07004284// Test that setting the a different set of codecs but with an identical front
4285// codec doesn't result in the stream being recreated.
4286// This may happen when a subsequent negotiation includes fewer codecs, as a
4287// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004288TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004289 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4290 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004291 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4292 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004293 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4294
4295 AddSendStream();
4296 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4297
4298 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004299 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004300 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4301 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4302}
4303
eladalonf1841382017-06-12 01:16:46 -07004304TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004305 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004306 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004307 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004308}
4309
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004310// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004311TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004312 const int kUnusedPayloadType1 = 126;
4313 const int kUnusedPayloadType2 = 127;
4314 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4315 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4316
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004317 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004318 parameters.codecs.push_back(GetEngineCodec("VP8"));
4319 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004320 parameters.codecs.push_back(rtx_codec);
4321 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004322 << "RTX codec without associated payload should be rejected.";
4323
magjed509e4fe2016-11-18 01:34:11 -08004324 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004325 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004326 << "RTX codec with invalid associated payload type should be rejected.";
4327
magjed509e4fe2016-11-18 01:34:11 -08004328 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004329 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004330
magjed509e4fe2016-11-18 01:34:11 -08004331 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004332 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004333 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004334
Yves Gerey665174f2018-06-19 15:03:05 +02004335 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4336 << "RTX codec with another RTX as associated payload type should be "
4337 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004338}
4339
eladalonf1841382017-06-12 01:16:46 -07004340TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004341 const int kUnusedPayloadType1 = 126;
4342 const int kUnusedPayloadType2 = 127;
4343 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4344 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4345
4346 // SSRCs for RTX.
4347 cricket::StreamParams params =
4348 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4349 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4350 AddRecvStream(params);
4351
4352 // Original payload type for RTX.
4353 cricket::VideoRecvParameters parameters;
4354 parameters.codecs.push_back(GetEngineCodec("VP8"));
4355 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4356 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4357 parameters.codecs.push_back(rtx_codec);
4358 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4359 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4360 const webrtc::VideoReceiveStream::Config& config_before =
4361 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004362 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4363 const int* payload_type_before = FindKeyByValue(
4364 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4365 ASSERT_NE(payload_type_before, nullptr);
4366 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004367 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4368
4369 // Change payload type for RTX.
4370 parameters.codecs[1].id = kUnusedPayloadType2;
4371 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4372 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4373 const webrtc::VideoReceiveStream::Config& config_after =
4374 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004375 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4376 const int* payload_type_after = FindKeyByValue(
4377 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4378 ASSERT_NE(payload_type_after, nullptr);
4379 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004380 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4381}
4382
eladalonf1841382017-06-12 01:16:46 -07004383TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004384 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004385 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004386 parameters.codecs[0].id = 99;
4387 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004388}
4389
eladalonf1841382017-06-12 01:16:46 -07004390TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004391 cricket::VideoRecvParameters parameters;
4392 parameters.codecs = engine_.codecs();
4393 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004394
4395 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004396 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004397 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004398 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004399}
4400
eladalonf1841382017-06-12 01:16:46 -07004401TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004402 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004403 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004404 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004405 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004406}
4407
eladalonf1841382017-06-12 01:16:46 -07004408TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004409 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004410 parameters.codecs.push_back(GetEngineCodec("VP8"));
4411 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004412 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004413}
4414
eladalonf1841382017-06-12 01:16:46 -07004415TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004416 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004417 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4418 send_parameters.codecs.push_back(GetEngineCodec("red"));
4419 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004420 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004421
4422 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004423
magjed509e4fe2016-11-18 01:34:11 -08004424 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004425 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004426
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004427 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004428 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004429 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004430 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004431 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004432 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004433 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4434}
4435
eladalonf1841382017-06-12 01:16:46 -07004436TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004437 AddRecvStream(
4438 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004439 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004440 fake_call_->GetFlexfecReceiveStreams();
4441
4442 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004443 const FakeFlexfecReceiveStream* stream = streams.front();
4444 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4445 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4446 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4447 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004448
4449 cricket::VideoRecvParameters recv_parameters;
4450 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4451 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4452 EXPECT_TRUE(streams.empty())
4453 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004454}
4455
eladalonf1841382017-06-12 01:16:46 -07004456TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004457 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004458 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004459 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004460
4461 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004462 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4463 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4464 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004465 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4466 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004467 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004468 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004469 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004470 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004471
4472 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004473 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4474 send_parameters.codecs.push_back(GetEngineCodec("red"));
4475 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004476 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4477 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004478 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004479 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004480 << "ULPFEC should be enabled on the receive stream.";
4481}
4482
eladalonf1841382017-06-12 01:16:46 -07004483TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004484 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004485 AddRecvStream(
4486 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004487 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004488 fake_call_->GetFlexfecReceiveStreams();
4489
4490 cricket::VideoRecvParameters recv_parameters;
4491 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4492 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4493 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4494 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004495 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004496 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004497 stream_with_recv_params->GetConfig().payload_type);
4498 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004499 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004500 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004501 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004502 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004503
4504 cricket::VideoSendParameters send_parameters;
4505 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4506 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4507 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4508 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004509 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004510 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004511 stream_with_send_params->GetConfig().payload_type);
4512 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004513 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004514 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004515 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004516 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004517}
4518
eladalonf1841382017-06-12 01:16:46 -07004519TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004520 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004521 parameters.codecs.push_back(GetEngineCodec("VP8"));
4522 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004523 parameters.codecs[1].id = parameters.codecs[0].id;
4524 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004525}
4526
eladalonf1841382017-06-12 01:16:46 -07004527TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004528 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004529 cricket::VideoRecvParameters parameters;
4530 parameters.codecs.push_back(GetEngineCodec("VP8"));
4531 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4532 parameters.codecs[1].id = parameters.codecs[0].id;
4533 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4534}
4535
eladalonf1841382017-06-12 01:16:46 -07004536TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004537 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004538 parameters.codecs.push_back(GetEngineCodec("VP8"));
4539 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004540 parameters.codecs[1].id = parameters.codecs[0].id;
4541 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004542}
4543
eladalonf1841382017-06-12 01:16:46 -07004544TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004545 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004546 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004547 parameters.codecs.push_back(GetEngineCodec("VP8"));
4548 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004549 parameters.codecs[1].id += 1;
4550 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004551}
4552
deadbeef67cf2c12016-04-13 10:07:16 -07004553// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004554// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004555TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004556 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004557 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004558 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4559 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004560 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004561
4562 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4563 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4564
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004565 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004566 parameters2.codecs.push_back(GetEngineCodec("red"));
4567 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004568 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004569 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4570}
4571
eladalonf1841382017-06-12 01:16:46 -07004572TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004573 EXPECT_FALSE(AddSendStream()->IsSending());
4574}
4575
eladalonf1841382017-06-12 01:16:46 -07004576TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004577 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004578}
4579
eladalonf1841382017-06-12 01:16:46 -07004580TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004581 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004582 EXPECT_FALSE(stream->IsSending());
4583
4584 // false->true
4585 EXPECT_TRUE(channel_->SetSend(true));
4586 EXPECT_TRUE(stream->IsSending());
4587 // true->true
4588 EXPECT_TRUE(channel_->SetSend(true));
4589 EXPECT_TRUE(stream->IsSending());
4590 // true->false
4591 EXPECT_TRUE(channel_->SetSend(false));
4592 EXPECT_FALSE(stream->IsSending());
4593 // false->false
4594 EXPECT_TRUE(channel_->SetSend(false));
4595 EXPECT_FALSE(stream->IsSending());
4596
4597 EXPECT_TRUE(channel_->SetSend(true));
4598 FakeVideoSendStream* new_stream = AddSendStream();
4599 EXPECT_TRUE(new_stream->IsSending())
4600 << "Send stream created after SetSend(true) not sending initially.";
4601}
4602
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004603// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004604TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004605 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004606 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004607 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004608 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004609 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004610
Sebastian Jansson84848f22018-11-16 10:40:36 +01004611 channel.reset(
4612 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004613 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4614 video_bitrate_allocator_factory_.get())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004615 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004616 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004617 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004618
Tim Haloun648d28a2018-10-18 16:52:22 -07004619 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4620 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004621 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004622 channel.reset(
4623 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004624 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4625 video_bitrate_allocator_factory_.get())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004626 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004627 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4628
4629 // Create a send stream to configure
4630 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4631 parameters = channel->GetRtpSendParameters(kSsrc);
4632 ASSERT_FALSE(parameters.encodings.empty());
4633
4634 // Various priorities map to various dscp values.
4635 parameters.encodings[0].network_priority = 4.0;
4636 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004637 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004638 parameters.encodings[0].network_priority = 0.5;
4639 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4640 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4641
4642 // A bad priority does not change the dscp value.
4643 parameters.encodings[0].network_priority = 0.0;
4644 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4645 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004646
Tim Haloun6ca98362018-09-17 17:06:08 -07004647 // Packets should also self-identify their dscp in PacketOptions.
4648 const uint8_t kData[10] = {0};
4649 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4650 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004651 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004652
nisse51542be2016-02-12 02:27:06 -08004653 // Verify that setting the option to false resets the
4654 // DiffServCodePoint.
4655 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004656 channel.reset(
4657 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004658 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4659 video_bitrate_allocator_factory_.get())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004660 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004661 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004662}
4663
deadbeef13871492015-12-09 12:37:51 -08004664// This test verifies that the RTCP reduced size mode is properly applied to
4665// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004666TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004667 // Create stream, expecting that default mode is "compound".
4668 FakeVideoSendStream* stream1 = AddSendStream();
4669 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004670 webrtc::RtpParameters rtp_parameters =
4671 channel_->GetRtpSendParameters(last_ssrc_);
4672 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004673
4674 // Now enable reduced size mode.
4675 send_parameters_.rtcp.reduced_size = true;
4676 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4677 stream1 = fake_call_->GetVideoSendStreams()[0];
4678 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004679 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4680 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004681
4682 // Create a new stream and ensure it picks up the reduced size mode.
4683 FakeVideoSendStream* stream2 = AddSendStream();
4684 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4685}
4686
4687// This test verifies that the RTCP reduced size mode is properly applied to
4688// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004689TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004690 // Create stream, expecting that default mode is "compound".
4691 FakeVideoReceiveStream* stream1 = AddRecvStream();
4692 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4693
4694 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004695 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4696 // the reduced_size flag should come from that.
4697 send_parameters_.rtcp.reduced_size = true;
4698 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004699 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4700 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4701
4702 // Create a new stream and ensure it picks up the reduced size mode.
4703 FakeVideoReceiveStream* stream2 = AddRecvStream();
4704 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4705}
4706
eladalonf1841382017-06-12 01:16:46 -07004707TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004708 EXPECT_EQ(webrtc::kNetworkUp,
4709 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4710 EXPECT_EQ(webrtc::kNetworkUp,
4711 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004712
4713 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004714 EXPECT_EQ(webrtc::kNetworkDown,
4715 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4716 EXPECT_EQ(webrtc::kNetworkUp,
4717 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004718
4719 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004720 EXPECT_EQ(webrtc::kNetworkUp,
4721 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4722 EXPECT_EQ(webrtc::kNetworkUp,
4723 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004724}
4725
eladalonf1841382017-06-12 01:16:46 -07004726TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004727 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004728 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004729 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004730
4731 AddSendStream();
4732
4733 cricket::VideoMediaInfo info;
4734 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004735 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004736}
4737
eladalonf1841382017-06-12 01:16:46 -07004738TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004739 FakeVideoSendStream* stream = AddSendStream();
4740 webrtc::VideoSendStream::Stats stats;
4741 stats.encoder_implementation_name = "encoder_implementation_name";
4742 stream->SetStats(stats);
4743
4744 cricket::VideoMediaInfo info;
4745 ASSERT_TRUE(channel_->GetStats(&info));
4746 EXPECT_EQ(stats.encoder_implementation_name,
4747 info.senders[0].encoder_implementation_name);
4748}
4749
eladalonf1841382017-06-12 01:16:46 -07004750TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004751 FakeVideoSendStream* stream = AddSendStream();
4752 webrtc::VideoSendStream::Stats stats;
4753 stats.avg_encode_time_ms = 13;
4754 stats.encode_usage_percent = 42;
4755 stream->SetStats(stats);
4756
4757 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004758 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004759 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4760 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4761}
4762
eladalonf1841382017-06-12 01:16:46 -07004763TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004764 FakeVideoSendStream* stream = AddSendStream();
4765 webrtc::VideoSendStream::Stats stats;
4766 stats.frames_encoded = 13;
4767 stream->SetStats(stats);
4768
4769 cricket::VideoMediaInfo info;
4770 ASSERT_TRUE(channel_->GetStats(&info));
4771 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4772}
4773
eladalonf1841382017-06-12 01:16:46 -07004774TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004775 FakeVideoSendStream* stream = AddSendStream();
4776 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004777 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004778 stream->SetStats(stats);
4779
4780 cricket::VideoMediaInfo info;
4781 ASSERT_TRUE(channel_->GetStats(&info));
4782 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4783}
4784
eladalonf1841382017-06-12 01:16:46 -07004785TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004786 FakeVideoSendStream* stream = AddSendStream();
4787 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004788 stats.substreams[17].width = 123;
4789 stats.substreams[17].height = 40;
4790 stats.substreams[42].width = 80;
4791 stats.substreams[42].height = 31;
4792 stats.substreams[11].width = 20;
4793 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004794 stream->SetStats(stats);
4795
4796 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004797 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004798 ASSERT_EQ(1u, info.senders.size());
4799 EXPECT_EQ(123, info.senders[0].send_frame_width);
4800 EXPECT_EQ(90, info.senders[0].send_frame_height);
4801}
4802
eladalonf1841382017-06-12 01:16:46 -07004803TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004804 FakeVideoSendStream* stream = AddSendStream();
4805 webrtc::VideoSendStream::Stats stats;
4806 stats.number_of_cpu_adapt_changes = 2;
4807 stats.cpu_limited_resolution = true;
4808 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004809
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004810 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004811 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004812 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004813 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004814 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004815}
4816
eladalonf1841382017-06-12 01:16:46 -07004817TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004818 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004819 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004820 stats.number_of_cpu_adapt_changes = 2;
4821 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004822 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004823 stream->SetStats(stats);
4824
4825 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004826 EXPECT_TRUE(channel_->GetStats(&info));
4827 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004828 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4829 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004830 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004831 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004832}
4833
eladalonf1841382017-06-12 01:16:46 -07004834TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004835 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4836 FakeVideoSendStream* stream = AddSendStream();
4837 webrtc::VideoSendStream::Stats stats;
4838 stats.bw_limited_resolution = true;
4839 stream->SetStats(stats);
4840
4841 cricket::VideoMediaInfo info;
4842 EXPECT_TRUE(channel_->GetStats(&info));
4843 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004844 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004845 info.senders[0].adapt_reason);
4846}
4847
Yves Gerey665174f2018-06-19 15:03:05 +02004848TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004849 FakeVideoSendStream* stream = AddSendStream();
4850 webrtc::VideoSendStream::Stats stats;
4851 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4852 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4853 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4854
4855 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4856 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4857 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4858
4859 stream->SetStats(stats);
4860
4861 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004862 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004863 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4864 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4865 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4866}
4867
eladalonf1841382017-06-12 01:16:46 -07004868TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004869 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4870 FakeVideoReceiveStream* stream = AddRecvStream();
4871 webrtc::VideoReceiveStream::Stats stats;
4872 stats.rtcp_packet_type_counts.fir_packets = 2;
4873 stats.rtcp_packet_type_counts.nack_packets = 3;
4874 stats.rtcp_packet_type_counts.pli_packets = 4;
4875 stream->SetStats(stats);
4876
4877 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004878 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004879 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004880 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004881 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004882 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004883 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004884 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004885}
4886
eladalonf1841382017-06-12 01:16:46 -07004887TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004888 FakeVideoReceiveStream* stream = AddRecvStream();
4889 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004890 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004891 stats.decode_ms = 2;
4892 stats.max_decode_ms = 3;
4893 stats.current_delay_ms = 4;
4894 stats.target_delay_ms = 5;
4895 stats.jitter_buffer_ms = 6;
4896 stats.min_playout_delay_ms = 7;
4897 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004898 stats.width = 9;
4899 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004900 stats.frame_counts.key_frames = 11;
4901 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004902 stats.frames_rendered = 13;
4903 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004904 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004905 stream->SetStats(stats);
4906
4907 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004908 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004909 EXPECT_EQ(stats.decoder_implementation_name,
4910 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004911 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4912 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4913 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4914 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4915 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4916 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4917 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004918 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4919 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004920 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4921 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004922 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004923 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004924 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004925 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004926}
4927
eladalonf1841382017-06-12 01:16:46 -07004928TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004929 FakeVideoReceiveStream* stream = AddRecvStream();
4930 webrtc::VideoReceiveStream::Stats stats;
4931 stats.rtp_stats.transmitted.payload_bytes = 2;
4932 stats.rtp_stats.transmitted.header_bytes = 3;
4933 stats.rtp_stats.transmitted.padding_bytes = 4;
4934 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004935 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004936 stats.rtcp_stats.fraction_lost = 7;
4937 stream->SetStats(stats);
4938
4939 cricket::VideoMediaInfo info;
4940 ASSERT_TRUE(channel_->GetStats(&info));
4941 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4942 stats.rtp_stats.transmitted.header_bytes +
4943 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004944 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004945 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004946 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004947 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004948 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004949 info.receivers[0].fraction_lost);
4950}
4951
eladalonf1841382017-06-12 01:16:46 -07004952TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004953 AddSendStream();
4954 AddSendStream();
4955 webrtc::Call::Stats stats;
4956 stats.rtt_ms = 123;
4957 fake_call_->SetStats(stats);
4958
4959 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004960 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004961 ASSERT_EQ(2u, info.senders.size());
4962 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4963 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4964}
4965
eladalonf1841382017-06-12 01:16:46 -07004966TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004967 FakeVideoSendStream* stream = AddSendStream();
4968 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004969 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004970 stats.media_bitrate_bps = 123;
4971 stats.substreams[17].total_bitrate_bps = 1;
4972 stats.substreams[17].retransmit_bitrate_bps = 2;
4973 stats.substreams[42].total_bitrate_bps = 3;
4974 stats.substreams[42].retransmit_bitrate_bps = 4;
4975 stream->SetStats(stats);
4976
4977 FakeVideoSendStream* stream2 = AddSendStream();
4978 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004979 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004980 stats2.media_bitrate_bps = 321;
4981 stats2.substreams[13].total_bitrate_bps = 5;
4982 stats2.substreams[13].retransmit_bitrate_bps = 6;
4983 stats2.substreams[21].total_bitrate_bps = 7;
4984 stats2.substreams[21].retransmit_bitrate_bps = 8;
4985 stream2->SetStats(stats2);
4986
4987 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004988 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004989 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004990 BandwidthEstimationInfo bwe_info;
4991 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004992 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4993 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4994 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4995 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004996 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004997 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004998 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004999 bwe_info.actual_enc_bitrate);
5000 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005001 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005002 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005003 << "Bandwidth stats should take all streams into account.";
5004}
5005
eladalonf1841382017-06-12 01:16:46 -07005006TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005007 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005008
Peter Boström0c4e06b2015-10-07 12:23:21 +02005009 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5010 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005011
5012 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5013 const size_t kDataLength = 12;
5014 uint8_t data[kDataLength];
5015 memset(data, 0, sizeof(data));
5016 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005017 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005018 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005019
5020 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5021 << "No default receive stream created.";
5022 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005023 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005024 << "Default receive stream should not have configured RTX";
5025
5026 EXPECT_TRUE(channel_->AddRecvStream(
5027 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5028 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005029 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005030 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005031 EXPECT_FALSE(
5032 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005033 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005034 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005035 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005036 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005037 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005038 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005039}
5040
eladalonf1841382017-06-12 01:16:46 -07005041TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005042 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005043
Peter Boström0c4e06b2015-10-07 12:23:21 +02005044 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5045 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005046
5047 StreamParams sp =
5048 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5049 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5050
5051 EXPECT_FALSE(channel_->AddSendStream(sp));
5052 EXPECT_FALSE(channel_->AddRecvStream(sp));
5053}
5054
eladalonf1841382017-06-12 01:16:46 -07005055TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005056 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005057
Peter Boström0c4e06b2015-10-07 12:23:21 +02005058 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5059 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005060
5061 StreamParams sp =
5062 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5063
5064 EXPECT_TRUE(channel_->AddSendStream(sp));
5065 EXPECT_TRUE(channel_->AddRecvStream(sp));
5066
5067 // The RTX SSRC is already used in previous streams, using it should fail.
5068 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5069 EXPECT_FALSE(channel_->AddSendStream(sp));
5070 EXPECT_FALSE(channel_->AddRecvStream(sp));
5071
5072 // After removing the original stream this should be fine to add (makes sure
5073 // that RTX ssrcs are not forever taken).
5074 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5075 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5076 EXPECT_TRUE(channel_->AddSendStream(sp));
5077 EXPECT_TRUE(channel_->AddRecvStream(sp));
5078}
5079
eladalonf1841382017-06-12 01:16:46 -07005080TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005081 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005082 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5083 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005084 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005085
Peter Boströmd6f4c252015-03-26 16:23:04 +01005086 StreamParams sp =
5087 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5088
5089 EXPECT_TRUE(channel_->AddSendStream(sp));
5090 EXPECT_TRUE(channel_->AddRecvStream(sp));
5091
5092 // One of the SSRCs is already used in previous streams, using it should fail.
5093 sp = cricket::CreateSimStreamParams("cname",
5094 MAKE_VECTOR(kOverlappingStreamSsrcs));
5095 EXPECT_FALSE(channel_->AddSendStream(sp));
5096 EXPECT_FALSE(channel_->AddRecvStream(sp));
5097
5098 // After removing the original stream this should be fine to add (makes sure
5099 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005100 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5101 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005102 EXPECT_TRUE(channel_->AddSendStream(sp));
5103 EXPECT_TRUE(channel_->AddRecvStream(sp));
5104}
5105
eladalonf1841382017-06-12 01:16:46 -07005106TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005107 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005108
5109 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5110 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5111
5112 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5113 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5114
5115 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5116
5117 static const uint32_t kReceiverSsrcs[] = {3};
5118 static const uint32_t kReceiverRtxSsrcs[] = {2};
5119
5120 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5121 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5122 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5123
5124 cricket::VideoMediaInfo info;
5125 ASSERT_TRUE(channel_->GetStats(&info));
5126
5127 ASSERT_EQ(1u, info.senders.size());
5128 ASSERT_EQ(1u, info.receivers.size());
5129
5130 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5131 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5132 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5133}
5134
eladalonf1841382017-06-12 01:16:46 -07005135TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005136 FakeVideoReceiveStream* stream = AddRecvStream();
5137 webrtc::VideoReceiveStream::Stats stats;
5138 cricket::VideoMediaInfo info;
5139
5140 // Report no codec name before receiving.
5141 stream->SetStats(stats);
5142 ASSERT_TRUE(channel_->GetStats(&info));
5143 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5144
5145 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005146 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005147 stream->SetStats(stats);
5148 ASSERT_TRUE(channel_->GetStats(&info));
5149 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5150
5151 // Report no codec name for unknown playload types.
5152 stats.current_payload_type = 3;
5153 stream->SetStats(stats);
5154 ASSERT_TRUE(channel_->GetStats(&info));
5155 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5156}
5157
Seth Hampson5897a6e2018-04-03 11:16:33 -07005158// Tests that when we add a stream without SSRCs, but contains a stream_id
5159// that it is stored and its stream id is later used when the first packet
5160// arrives to properly create a receive stream with a sync label.
5161TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5162 const char kSyncLabel[] = "sync_label";
5163 cricket::StreamParams unsignaled_stream;
5164 unsignaled_stream.set_stream_ids({kSyncLabel});
5165 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5166 // The stream shouldn't have been created at this point because it doesn't
5167 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005168 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005169
5170 // Create and deliver packet.
5171 const size_t kDataLength = 12;
5172 uint8_t data[kDataLength];
5173 memset(data, 0, sizeof(data));
5174 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5175 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005176 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005177
5178 // The stream should now be created with the appropriate sync label.
5179 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5180 EXPECT_EQ(kSyncLabel,
5181 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5182
5183 // Removing the unsignaled stream should clear the cache. This time when
5184 // a default video receive stream is created it won't have a sync_group.
5185 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5186 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5187 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5188
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005189 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005190 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5191 EXPECT_TRUE(
5192 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5193}
5194
Ruslan Burakov493a6502019-02-27 15:32:48 +01005195// Test BaseMinimumPlayoutDelayMs on receive streams.
5196TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5197 // Test that set won't work for non-existing receive streams.
5198 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5199 // Test that get won't work for non-existing receive streams.
5200 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5201
5202 EXPECT_TRUE(AddRecvStream());
5203 // Test that set works for the existing receive stream.
5204 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5205 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5206 EXPECT_TRUE(recv_stream);
5207 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5208 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5209 200);
5210}
5211
5212// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5213TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5214 absl::optional<int> delay_ms;
5215 const FakeVideoReceiveStream* recv_stream;
5216
5217 // Set default stream with SSRC 0
5218 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5219 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5220
5221 // Spawn an unsignaled stream by sending a packet, it should inherit
5222 // default delay 200.
5223 const size_t kDataLength = 12;
5224 uint8_t data[kDataLength];
5225 memset(data, 0, sizeof(data));
5226 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5227 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005228 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005229
5230 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5231 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5232 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5233 EXPECT_EQ(200, delay_ms.value_or(0));
5234
5235 // Check that now if we change delay for SSRC 0 it will change delay for the
5236 // default receiving stream as well.
5237 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5238 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5239 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5240 EXPECT_EQ(300, delay_ms.value_or(0));
5241 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5242 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5243}
5244
eladalonf1841382017-06-12 01:16:46 -07005245void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005246 uint8_t payload_type,
5247 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005248 // kRedRtxPayloadType must currently be unused.
5249 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5250
noahricd10a68e2015-07-10 11:27:55 -07005251 // Add a RED RTX codec.
5252 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005253 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005254 recv_parameters_.codecs.push_back(red_rtx_codec);
5255 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005256
5257 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5258 const size_t kDataLength = 12;
5259 uint8_t data[kDataLength];
5260 memset(data, 0, sizeof(data));
5261
5262 rtc::Set8(data, 1, payload_type);
5263 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005264 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005265 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005266
5267 if (expect_created_receive_stream) {
5268 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5269 << "Should have created a receive stream for payload type: "
5270 << payload_type;
5271 } else {
5272 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5273 << "Shouldn't have created a receive stream for payload type: "
5274 << payload_type;
5275 }
5276}
5277
Åsa Persson2c7149b2018-10-15 09:36:10 +02005278class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5279 public:
5280 WebRtcVideoChannelDiscardUnknownSsrcTest()
5281 : WebRtcVideoChannelTest(
5282 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5283};
5284
5285TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5286 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5287 false /* expect_created_receive_stream */);
5288}
5289
eladalonf1841382017-06-12 01:16:46 -07005290TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005291 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5292 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005293}
5294
eladalonf1841382017-06-12 01:16:46 -07005295TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005296 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5297 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005298}
5299
eladalonf1841382017-06-12 01:16:46 -07005300TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005301 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005302 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5303 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5304 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5305 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005306}
5307
eladalonf1841382017-06-12 01:16:46 -07005308TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005309 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5310 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005311}
5312
eladalonf1841382017-06-12 01:16:46 -07005313TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005314 FlexfecPacketDoesntCreateUnsignalledStream) {
5315 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5316 false /* expect_created_receive_stream */);
5317}
5318
eladalonf1841382017-06-12 01:16:46 -07005319TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005320 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5321 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005322}
5323
mzanaty8a855d62017-02-17 15:46:43 -08005324// Test that receiving any unsignalled SSRC works even if it changes.
5325// The first unsignalled SSRC received will create a default receive stream.
5326// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005327TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005328 // Allow receiving VP8, VP9, H264 (if enabled).
5329 cricket::VideoRecvParameters parameters;
5330 parameters.codecs.push_back(GetEngineCodec("VP8"));
5331 parameters.codecs.push_back(GetEngineCodec("VP9"));
5332
5333#if defined(WEBRTC_USE_H264)
5334 cricket::VideoCodec H264codec(126, "H264");
5335 parameters.codecs.push_back(H264codec);
5336#endif
5337
5338 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5339 // No receive streams yet.
5340 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5341 cricket::FakeVideoRenderer renderer;
5342 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5343
5344 // Receive VP8 packet on first SSRC.
5345 uint8_t data[kMinRtpPacketLen];
5346 cricket::RtpHeader rtpHeader;
5347 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5348 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005349 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005350 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5351 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005352 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005353 // VP8 packet should create default receive stream.
5354 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005355 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005356 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5357 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005358 webrtc::VideoFrame video_frame =
5359 webrtc::VideoFrame::Builder()
5360 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5361 .set_timestamp_rtp(100)
5362 .set_timestamp_us(0)
5363 .set_rotation(webrtc::kVideoRotation_0)
5364 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005365 recv_stream->InjectFrame(video_frame);
5366 EXPECT_EQ(1, renderer.num_rendered_frames());
5367
5368 // Receive VP9 packet on second SSRC.
5369 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005370 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005371 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5372 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005373 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005374 // VP9 packet should replace the default receive SSRC.
5375 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5376 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5377 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5378 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005379 webrtc::VideoFrame video_frame2 =
5380 webrtc::VideoFrame::Builder()
5381 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5382 .set_timestamp_rtp(200)
5383 .set_timestamp_us(0)
5384 .set_rotation(webrtc::kVideoRotation_0)
5385 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005386 recv_stream->InjectFrame(video_frame2);
5387 EXPECT_EQ(2, renderer.num_rendered_frames());
5388
5389#if defined(WEBRTC_USE_H264)
5390 // Receive H264 packet on third SSRC.
5391 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005392 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005393 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5394 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005395 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005396 // H264 packet should replace the default receive SSRC.
5397 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5398 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5399 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5400 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005401 webrtc::VideoFrame video_frame3 =
5402 webrtc::VideoFrame::Builder()
5403 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5404 .set_timestamp_rtp(300)
5405 .set_timestamp_us(0)
5406 .set_rotation(webrtc::kVideoRotation_0)
5407 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005408 recv_stream->InjectFrame(video_frame3);
5409 EXPECT_EQ(3, renderer.num_rendered_frames());
5410#endif
5411}
5412
brandtr0dc57ea2017-05-29 23:33:31 -07005413// This test verifies that when a new default stream is created for a new
5414// unsignaled SSRC, the new stream does not overwrite any old stream that had
5415// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005416TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005417 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5418 cricket::VideoRecvParameters parameters;
5419 parameters.codecs.push_back(GetEngineCodec("VP8"));
5420 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5421
5422 // No streams signaled and no packets received, so we should not have any
5423 // stream objects created yet.
5424 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5425
5426 // Receive packet on an unsignaled SSRC.
5427 uint8_t data[kMinRtpPacketLen];
5428 cricket::RtpHeader rtp_header;
5429 rtp_header.payload_type = GetEngineCodec("VP8").id;
5430 rtp_header.seq_num = rtp_header.timestamp = 0;
5431 rtp_header.ssrc = kSsrcs3[0];
5432 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5433 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005434 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005435 // Default receive stream should be created.
5436 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5437 FakeVideoReceiveStream* recv_stream0 =
5438 fake_call_->GetVideoReceiveStreams()[0];
5439 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5440
5441 // Signal the SSRC.
5442 EXPECT_TRUE(
5443 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5444 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5445 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5446 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5447
5448 // Receive packet on a different unsignaled SSRC.
5449 rtp_header.ssrc = kSsrcs3[1];
5450 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5451 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005452 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005453 // New default receive stream should be created, but old stream should remain.
5454 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5455 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5456 FakeVideoReceiveStream* recv_stream1 =
5457 fake_call_->GetVideoReceiveStreams()[1];
5458 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5459}
5460
Seth Hampson7c682e02018-05-04 16:28:15 -07005461TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005462 AddSendStream();
5463
Niels Möller805a27e2019-01-21 12:21:27 +01005464 webrtc::test::FrameForwarder frame_forwarder;
5465 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005466 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005467 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005468
perkjfa10b552016-10-02 23:45:26 -07005469 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005470 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005471
5472 // TODO(skvlad): Resolve the inconsistency between the interpretation
5473 // of the global bitrate limit for audio and video:
5474 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5475 // max_bandwidth_bps = -1 - remove the bandwidth limit
5476 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005477 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005478
perkjfa10b552016-10-02 23:45:26 -07005479 SetAndExpectMaxBitrate(1000, 0, 1000);
5480 SetAndExpectMaxBitrate(1000, 800, 800);
5481 SetAndExpectMaxBitrate(600, 800, 600);
5482 SetAndExpectMaxBitrate(0, 800, 800);
5483 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005484
Niels Möllerff40b142018-04-09 08:49:14 +02005485 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005486}
5487
eladalonf1841382017-06-12 01:16:46 -07005488TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005489 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005490 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005491 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005492
5493 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005494 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005495 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005496}
5497
eladalonf1841382017-06-12 01:16:46 -07005498TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005499 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005500 FakeVideoSendStream* stream = AddSendStream();
5501
Seth Hampson7c682e02018-05-04 16:28:15 -07005502 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5503 EXPECT_EQ(1UL, parameters.encodings.size());
5504 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5505 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5506
5507 // Note that this is testing the behavior of the FakeVideoSendStream, which
5508 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5509 // we are just testing the behavior of
5510 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005511 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5512 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005513
5514 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5515 // by this amount.
5516 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5517 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5518 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5519 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5520
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005521 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5522 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5523 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5524}
5525
5526TEST_F(WebRtcVideoChannelTest,
5527 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5528 FakeVideoSendStream* stream = AddSendStream();
5529
5530 // Note that this is testing the behavior of the FakeVideoSendStream, which
5531 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5532 // we are just testing the behavior of
5533 // EncoderStreamFactory::CreateEncoderStreams.
5534 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5535 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5536
5537 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5538 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5539 EXPECT_EQ(1UL, parameters.encodings.size());
5540 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5541 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5542
5543 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5544 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5545 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5546}
5547
5548TEST_F(WebRtcVideoChannelTest,
5549 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5550 send_parameters_.max_bandwidth_bps = 99999;
5551 FakeVideoSendStream* stream = AddSendStream();
5552 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5553 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5554 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5555 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5556 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5557 stream->GetVideoStreams()[0].max_bitrate_bps);
5558
5559 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5560 // adjusted down.
5561 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5562 EXPECT_EQ(1UL, parameters.encodings.size());
5563 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5564 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5565 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5566 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5567 stream->GetVideoStreams()[0].min_bitrate_bps);
5568 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5569 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005570}
5571
Åsa Persson8c1bf952018-09-13 10:42:19 +02005572TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5573 FakeVideoSendStream* stream = AddSendStream();
5574
5575 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5576 EXPECT_EQ(1UL, parameters.encodings.size());
5577 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5578 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5579
5580 // Note that this is testing the behavior of the FakeVideoSendStream, which
5581 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5582 // we are just testing the behavior of
5583 // EncoderStreamFactory::CreateEncoderStreams.
5584 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5585 EXPECT_EQ(kDefaultVideoMaxFramerate,
5586 stream->GetVideoStreams()[0].max_framerate);
5587
5588 // Set max framerate and check that VideoStream.max_framerate is set.
5589 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5590 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5591 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5592 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5593
5594 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5595 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5596}
5597
Åsa Persson23eba222018-10-02 14:47:06 +02005598TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5599 FakeVideoSendStream* stream = AddSendStream();
5600
5601 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5602 EXPECT_EQ(1UL, parameters.encodings.size());
5603 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5604 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5605
5606 // Note that this is testing the behavior of the FakeVideoSendStream, which
5607 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5608 // we are just testing the behavior of
5609 // EncoderStreamFactory::CreateEncoderStreams.
5610 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5611 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5612
5613 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5614 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5615 parameters.encodings[0].num_temporal_layers = 2;
5616 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5617
5618 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5619 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5620}
5621
Seth Hampson7c682e02018-05-04 16:28:15 -07005622TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005623 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005624 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005625 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005626 // Two or more encodings should result in failure.
5627 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005628 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005629 // Zero encodings should also fail.
5630 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005631 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005632}
5633
Zach Stein3ca452b2018-01-18 10:01:24 -08005634TEST_F(WebRtcVideoChannelTest,
5635 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5636 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5637 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5638 AddSendStream(sp);
5639
5640 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5641
5642 // Additional encodings should result in failure.
5643 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005644 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005645 // Zero encodings should also fail.
5646 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005647 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005648}
5649
deadbeeffb2aced2017-01-06 23:05:37 -08005650// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005651TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005652 AddSendStream();
5653 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005654 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005655 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005656}
5657
Seth Hampson24722b32017-12-22 09:36:42 -08005658// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5659// a value <= 0, setting the parameters returns false.
5660TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5661 AddSendStream();
5662 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5663 EXPECT_EQ(1UL, parameters.encodings.size());
5664 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5665 parameters.encodings[0].bitrate_priority);
5666
5667 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005668 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005669 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005670 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005671}
5672
5673// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5674// properly on the VideoChannel and propogates down to the video encoder.
5675TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5676 AddSendStream();
5677 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5678 EXPECT_EQ(1UL, parameters.encodings.size());
5679 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5680 parameters.encodings[0].bitrate_priority);
5681
5682 // Change the value and set it on the VideoChannel.
5683 double new_bitrate_priority = 2.0;
5684 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005685 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005686
5687 // Verify that the encoding parameters bitrate_priority is set for the
5688 // VideoChannel.
5689 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5690 EXPECT_EQ(1UL, parameters.encodings.size());
5691 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5692
5693 // Verify that the new value propagated down to the encoder.
5694 std::vector<FakeVideoSendStream*> video_send_streams =
5695 fake_call_->GetVideoSendStreams();
5696 EXPECT_EQ(1UL, video_send_streams.size());
5697 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5698 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5699 // appropriately.
5700 EXPECT_EQ(new_bitrate_priority,
5701 video_send_stream->GetEncoderConfig().bitrate_priority);
5702 // Check that the vector of VideoStreams also was propagated correctly. Note
5703 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5704 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005705 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005706 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5707}
5708
5709// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5710// VideoChannel and the value propogates to the video encoder with all simulcast
5711// streams.
5712TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5713 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005714 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005715 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5716 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5717 AddSendStream(stream_params);
5718 uint32_t primary_ssrc = stream_params.first_ssrc();
5719
Niels Möller805a27e2019-01-21 12:21:27 +01005720 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005721 // frame. This creates multiple VideoStreams for all simulcast layers when
5722 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005723 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005724 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005725 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005726 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005727 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5728 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5729 rtc::kNumMicrosecsPerSec / 30));
5730
Seth Hampson24722b32017-12-22 09:36:42 -08005731 // Get and set the rtp encoding parameters.
5732 webrtc::RtpParameters parameters =
5733 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005734 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005735 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5736 parameters.encodings[0].bitrate_priority);
5737 // Change the value and set it on the VideoChannel.
5738 double new_bitrate_priority = 2.0;
5739 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005740 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005741
5742 // Verify that the encoding parameters priority is set on the VideoChannel.
5743 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005744 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005745 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5746
5747 // Verify that the new value propagated down to the encoder.
5748 std::vector<FakeVideoSendStream*> video_send_streams =
5749 fake_call_->GetVideoSendStreams();
5750 EXPECT_EQ(1UL, video_send_streams.size());
5751 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5752 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5753 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005754 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005755 video_send_stream->GetEncoderConfig().number_of_streams);
5756 EXPECT_EQ(new_bitrate_priority,
5757 video_send_stream->GetEncoderConfig().bitrate_priority);
5758 // Check that the vector of VideoStreams also propagated correctly. The
5759 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5760 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005761 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005762 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005763 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5764 // Since we are only setting bitrate priority per-sender, the other
5765 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005766 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005767 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005768 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005769 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005770 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005771}
5772
Tim Haloun648d28a2018-10-18 16:52:22 -07005773// RTCRtpEncodingParameters.network_priority must be one of a few values
5774// derived from the default priority, corresponding to very-low, low, medium,
5775// or high.
5776TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5777 AddSendStream();
5778 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5779 EXPECT_EQ(1UL, parameters.encodings.size());
5780 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5781 parameters.encodings[0].network_priority);
5782
5783 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5784 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5785 for (auto it : good_values) {
5786 parameters.encodings[0].network_priority = it;
5787 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5788 }
5789 for (auto it : bad_values) {
5790 parameters.encodings[0].network_priority = it;
5791 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5792 }
5793}
5794
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005795TEST_F(WebRtcVideoChannelTest,
5796 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005797 VideoSendParameters parameters;
5798 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005799 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5800 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5801
5802 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005803 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005804
5805 VideoOptions options;
5806 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5807 channel_->SetSend(true);
5808
5809 // Try layers in natural order (smallest to largest).
5810 {
5811 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5812 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5813 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5814 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5815 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5816 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5817 ASSERT_TRUE(result.ok());
5818
5819 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5820
5821 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5822 ASSERT_EQ(3u, video_streams.size());
5823 EXPECT_EQ(320u, video_streams[0].width);
5824 EXPECT_EQ(180u, video_streams[0].height);
5825 EXPECT_EQ(640u, video_streams[1].width);
5826 EXPECT_EQ(360u, video_streams[1].height);
5827 EXPECT_EQ(1280u, video_streams[2].width);
5828 EXPECT_EQ(720u, video_streams[2].height);
5829 }
5830
5831 // Try layers in reverse natural order (largest to smallest).
5832 {
5833 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5834 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5835 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5836 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5837 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5838 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5839 ASSERT_TRUE(result.ok());
5840
5841 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5842
5843 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5844 ASSERT_EQ(3u, video_streams.size());
5845 EXPECT_EQ(1280u, video_streams[0].width);
5846 EXPECT_EQ(720u, video_streams[0].height);
5847 EXPECT_EQ(640u, video_streams[1].width);
5848 EXPECT_EQ(360u, video_streams[1].height);
5849 EXPECT_EQ(320u, video_streams[2].width);
5850 EXPECT_EQ(180u, video_streams[2].height);
5851 }
5852
5853 // Try layers in mixed order.
5854 {
5855 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5856 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5857 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5858 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5859 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5860 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5861 ASSERT_TRUE(result.ok());
5862
5863 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5864
5865 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5866 ASSERT_EQ(3u, video_streams.size());
5867 EXPECT_EQ(128u, video_streams[0].width);
5868 EXPECT_EQ(72u, video_streams[0].height);
5869 EXPECT_EQ(640u, video_streams[1].width);
5870 EXPECT_EQ(360u, video_streams[1].height);
5871 EXPECT_EQ(320u, video_streams[2].width);
5872 EXPECT_EQ(180u, video_streams[2].height);
5873 }
5874
5875 // Try with a missing scale setting, defaults to 1.0 if any other is set.
5876 {
5877 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5878 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5879 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5880 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
5881 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5882 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5883 ASSERT_TRUE(result.ok());
5884
5885 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5886
5887 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5888 ASSERT_EQ(3u, video_streams.size());
5889 EXPECT_EQ(1280u, video_streams[0].width);
5890 EXPECT_EQ(720u, video_streams[0].height);
5891 EXPECT_EQ(1280u, video_streams[1].width);
5892 EXPECT_EQ(720u, video_streams[1].height);
5893 EXPECT_EQ(320u, video_streams[2].width);
5894 EXPECT_EQ(180u, video_streams[2].height);
5895 }
5896
5897 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5898}
5899
5900TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01005901 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
5902 // Ensure that the top layer has width and height divisible by 2^3,
5903 // so that the bottom layer has width and height divisible by 2.
5904 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
5905 // the number of simulcast layers set by the app.
5906 webrtc::test::ScopedFieldTrials field_trial(
5907 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
5908
5909 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
5910 VideoSendParameters parameters;
5911 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
5912 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5913 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5914 webrtc::test::FrameForwarder frame_forwarder;
5915 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
5916 &frame_forwarder));
5917 channel_->SetSend(true);
5918
5919 // Set |scale_resolution_down_by|'s.
5920 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5921 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
5922 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5923 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5924 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5925 const auto result =
5926 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5927 ASSERT_TRUE(result.ok());
5928
5929 // Use a capture resolution whose width and height are not divisible by 2^3.
5930 // (See field trial set at the top of the test.)
5931 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
5932 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5933
5934 // Ensure the scaling is correct.
5935 const auto video_streams = stream->GetVideoStreams();
5936 ASSERT_EQ(video_streams.size(), 3u);
5937 // Ensure that we round the capture resolution down for the top layer...
5938 EXPECT_EQ(video_streams[0].width, 2000u);
5939 EXPECT_EQ(video_streams[0].height, 1200u);
5940 EXPECT_EQ(video_streams[1].width, 1000u);
5941 EXPECT_EQ(video_streams[1].height, 600u);
5942 // ...and that the bottom layer has a width/height divisible by 2.
5943 EXPECT_EQ(video_streams[2].width, 500u);
5944 EXPECT_EQ(video_streams[2].height, 300u);
5945
5946 // Tear down.
5947 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5948}
5949
5950TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005951 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005952 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
5953 VideoSendParameters parameters;
5954 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005955 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5956 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5957
5958 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005959 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005960
5961 VideoOptions options;
5962 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5963 channel_->SetSend(true);
5964
5965 // Try layers in natural order (smallest to largest).
5966 {
5967 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5968 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5969 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5970 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5971 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5972 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5973 ASSERT_TRUE(result.ok());
5974
5975 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5976
5977 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5978 ASSERT_EQ(3u, video_streams.size());
5979 EXPECT_EQ(320u, video_streams[0].width);
5980 EXPECT_EQ(180u, video_streams[0].height);
5981 EXPECT_EQ(640u, video_streams[1].width);
5982 EXPECT_EQ(360u, video_streams[1].height);
5983 EXPECT_EQ(1280u, video_streams[2].width);
5984 EXPECT_EQ(720u, video_streams[2].height);
5985 }
5986
5987 // Try layers in reverse natural order (largest to smallest).
5988 {
5989 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5990 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5991 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5992 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5993 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5994 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5995 ASSERT_TRUE(result.ok());
5996
5997 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5998
5999 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6000 ASSERT_EQ(3u, video_streams.size());
6001 EXPECT_EQ(1280u, video_streams[0].width);
6002 EXPECT_EQ(720u, video_streams[0].height);
6003 EXPECT_EQ(640u, video_streams[1].width);
6004 EXPECT_EQ(360u, video_streams[1].height);
6005 EXPECT_EQ(320u, video_streams[2].width);
6006 EXPECT_EQ(180u, video_streams[2].height);
6007 }
6008
6009 // Try layers in mixed order.
6010 {
6011 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6012 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6013 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6014 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6015 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6016 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6017 ASSERT_TRUE(result.ok());
6018
6019 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6020
6021 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6022 ASSERT_EQ(3u, video_streams.size());
6023 EXPECT_EQ(128u, video_streams[0].width);
6024 EXPECT_EQ(72u, video_streams[0].height);
6025 EXPECT_EQ(640u, video_streams[1].width);
6026 EXPECT_EQ(360u, video_streams[1].height);
6027 EXPECT_EQ(320u, video_streams[2].width);
6028 EXPECT_EQ(180u, video_streams[2].height);
6029 }
6030
6031 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6032 {
6033 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6034 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6035 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6036 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6037 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6038 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6039 ASSERT_TRUE(result.ok());
6040
6041 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6042
6043 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6044 ASSERT_EQ(3u, video_streams.size());
6045 EXPECT_EQ(1280u, video_streams[0].width);
6046 EXPECT_EQ(720u, video_streams[0].height);
6047 EXPECT_EQ(1280u, video_streams[1].width);
6048 EXPECT_EQ(720u, video_streams[1].height);
6049 EXPECT_EQ(320u, video_streams[2].width);
6050 EXPECT_EQ(180u, video_streams[2].height);
6051 }
6052 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6053}
6054
Rasmus Brandt9387b522019-02-05 14:23:26 +01006055TEST_F(WebRtcVideoChannelTest,
6056 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6057 // Ensure that the top layer has width and height divisible by 2^3,
6058 // so that the bottom layer has width and height divisible by 2.
6059 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6060 // the number of simulcast layers set by the app.
6061 webrtc::test::ScopedFieldTrials field_trial(
6062 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6063
6064 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6065 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6066 VideoSendParameters parameters;
6067 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6068 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6069 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6070 webrtc::test::FrameForwarder frame_forwarder;
6071 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6072 &frame_forwarder));
6073 channel_->SetSend(true);
6074
6075 // Set |scale_resolution_down_by|'s.
6076 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6077 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6078 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6079 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6080 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6081 const auto result =
6082 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6083 ASSERT_TRUE(result.ok());
6084
6085 // Use a capture resolution whose width and height are not divisible by 2^3.
6086 // (See field trial set at the top of the test.)
6087 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6088 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6089
6090 // Ensure the scaling is correct.
6091 const auto video_streams = stream->GetVideoStreams();
6092 ASSERT_EQ(video_streams.size(), 3u);
6093 // Ensure that we round the capture resolution down for the top layer...
6094 EXPECT_EQ(video_streams[0].width, 2000u);
6095 EXPECT_EQ(video_streams[0].height, 1200u);
6096 EXPECT_EQ(video_streams[1].width, 1000u);
6097 EXPECT_EQ(video_streams[1].height, 600u);
6098 // ...and that the bottom layer has a width/height divisible by 2.
6099 EXPECT_EQ(video_streams[2].width, 500u);
6100 EXPECT_EQ(video_streams[2].height, 300u);
6101
6102 // Tear down.
6103 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6104}
6105
Åsa Persson8c1bf952018-09-13 10:42:19 +02006106TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6107 const size_t kNumSimulcastStreams = 3;
6108 SetUpSimulcast(true, false);
6109
6110 // Get and set the rtp encoding parameters.
6111 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6112 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6113 for (const auto& encoding : parameters.encodings) {
6114 EXPECT_FALSE(encoding.max_framerate);
6115 }
6116
6117 // Change the value and set it on the VideoChannel.
6118 parameters.encodings[0].max_framerate = 10;
6119 parameters.encodings[1].max_framerate = 20;
6120 parameters.encodings[2].max_framerate = 25;
6121 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6122
6123 // Verify that the bitrates are set on the VideoChannel.
6124 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6125 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6126 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6127 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6128 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6129}
6130
Åsa Persson23eba222018-10-02 14:47:06 +02006131TEST_F(WebRtcVideoChannelTest,
6132 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6133 const size_t kNumSimulcastStreams = 3;
6134 SetUpSimulcast(true, false);
6135
6136 // Get and set the rtp encoding parameters.
6137 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6138 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6139
6140 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6141 parameters.encodings[0].num_temporal_layers = 0;
6142 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6143 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6144 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6145 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6146 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6147}
6148
6149TEST_F(WebRtcVideoChannelTest,
6150 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6151 const size_t kNumSimulcastStreams = 3;
6152 SetUpSimulcast(true, false);
6153
6154 // Get and set the rtp encoding parameters.
6155 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6156 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6157
6158 // No/all layers should be set.
6159 parameters.encodings[0].num_temporal_layers = 1;
6160 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6161 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6162
6163 // Different values not supported.
6164 parameters.encodings[0].num_temporal_layers = 1;
6165 parameters.encodings[1].num_temporal_layers = 2;
6166 parameters.encodings[2].num_temporal_layers = 2;
6167 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6168 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6169}
6170
6171TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6172 const size_t kNumSimulcastStreams = 3;
6173 SetUpSimulcast(true, false);
6174
6175 // Get and set the rtp encoding parameters.
6176 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6177 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6178 for (const auto& encoding : parameters.encodings)
6179 EXPECT_FALSE(encoding.num_temporal_layers);
6180
6181 // Change the value and set it on the VideoChannel.
6182 parameters.encodings[0].num_temporal_layers = 3;
6183 parameters.encodings[1].num_temporal_layers = 3;
6184 parameters.encodings[2].num_temporal_layers = 3;
6185 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6186
6187 // Verify that the number of temporal layers are set on the VideoChannel.
6188 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6189 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6190 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6191 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6192 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6193}
6194
6195TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6196 const size_t kNumSimulcastStreams = 3;
6197 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6198
6199 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006200 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006201 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006202 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006203 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006204 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006205
6206 // Get and set the rtp encoding parameters.
6207 // Change the value and set it on the VideoChannel.
6208 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6209 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6210 parameters.encodings[0].num_temporal_layers = 2;
6211 parameters.encodings[1].num_temporal_layers = 2;
6212 parameters.encodings[2].num_temporal_layers = 2;
6213 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6214
6215 // Verify that the new value is propagated down to the encoder.
6216 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6217 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6218 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6219 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6220 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6221 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6222 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6223 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6224
6225 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6226 // VideoStreams are created appropriately for the simulcast case.
6227 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6228 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6229 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6230 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6231
6232 // No parameter changed, encoder should not be reconfigured.
6233 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6234 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6235
6236 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6237}
6238
6239TEST_F(WebRtcVideoChannelTest,
6240 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6241 const size_t kDefaultNumTemporalLayers = 3;
6242 const size_t kNumSimulcastStreams = 3;
6243 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6244
6245 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006246 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006247 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006248 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006249 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006250 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006251
6252 // Change rtp encoding parameters, num_temporal_layers not changed.
6253 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6254 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6255 parameters.encodings[0].min_bitrate_bps = 33000;
6256 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6257
6258 // Verify that no value is propagated down to the encoder.
6259 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6260 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6261 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6262 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6263 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6264 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6265
6266 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6267 // VideoStreams are created appropriately for the simulcast case.
6268 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6269 EXPECT_EQ(kDefaultNumTemporalLayers,
6270 stream->GetVideoStreams()[0].num_temporal_layers);
6271 EXPECT_EQ(kDefaultNumTemporalLayers,
6272 stream->GetVideoStreams()[1].num_temporal_layers);
6273 EXPECT_EQ(kDefaultNumTemporalLayers,
6274 stream->GetVideoStreams()[2].num_temporal_layers);
6275
6276 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6277}
6278
Åsa Persson8c1bf952018-09-13 10:42:19 +02006279TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6280 const size_t kNumSimulcastStreams = 3;
6281 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6282
6283 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006284 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006285 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006286 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006287 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006288 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006289
6290 // Get and set the rtp encoding parameters.
6291 // Change the value and set it on the VideoChannel.
6292 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6293 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6294 parameters.encodings[0].max_framerate = 15;
6295 parameters.encodings[1].max_framerate = 25;
6296 parameters.encodings[2].max_framerate = 20;
6297 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6298
6299 // Verify that the new value propagated down to the encoder.
6300 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6301 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6302 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6303 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6304 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6305 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6306 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6307 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6308
6309 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6310 // VideoStreams are created appropriately for the simulcast case.
6311 // Currently the maximum |max_framerate| is used.
6312 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6313 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6314 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6315 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6316
6317 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6318}
6319
6320TEST_F(WebRtcVideoChannelTest,
6321 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6322 const size_t kNumSimulcastStreams = 3;
6323 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6324 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6325
6326 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006327 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006328 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006329 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006330 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006331 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006332
6333 // Get and set the rtp encoding parameters.
6334 // Change the value and set it on the VideoChannel.
6335 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6336 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6337 parameters.encodings[0].max_framerate = 15;
6338 parameters.encodings[2].max_framerate = 20;
6339 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6340
6341 // Verify that the new value propagated down to the encoder.
6342 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6343 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6344 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6345 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6346 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6347 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6348 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6349
6350 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6351 // VideoStreams are created appropriately for the simulcast case.
6352 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6353 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6354 EXPECT_EQ(kDefaultVideoMaxFramerate,
6355 stream->GetVideoStreams()[0].max_framerate);
6356 EXPECT_EQ(kDefaultVideoMaxFramerate,
6357 stream->GetVideoStreams()[1].max_framerate);
6358 EXPECT_EQ(kDefaultVideoMaxFramerate,
6359 stream->GetVideoStreams()[2].max_framerate);
6360
6361 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6362}
6363
Åsa Persson55659812018-06-18 17:51:32 +02006364TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6365 const size_t kNumSimulcastStreams = 3;
6366 SetUpSimulcast(true, false);
6367
6368 // Get and set the rtp encoding parameters.
6369 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6370 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6371 for (const auto& encoding : parameters.encodings) {
6372 EXPECT_FALSE(encoding.min_bitrate_bps);
6373 EXPECT_FALSE(encoding.max_bitrate_bps);
6374 }
6375
6376 // Change the value and set it on the VideoChannel.
6377 parameters.encodings[0].min_bitrate_bps = 100000;
6378 parameters.encodings[0].max_bitrate_bps = 200000;
6379 parameters.encodings[1].min_bitrate_bps = 300000;
6380 parameters.encodings[1].max_bitrate_bps = 400000;
6381 parameters.encodings[2].min_bitrate_bps = 500000;
6382 parameters.encodings[2].max_bitrate_bps = 600000;
6383 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6384
6385 // Verify that the bitrates are set on the VideoChannel.
6386 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6387 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6388 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6389 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6390 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6391 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6392 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6393 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6394}
6395
6396TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6397 const size_t kNumSimulcastStreams = 3;
6398 SetUpSimulcast(true, false);
6399
6400 // Get and set the rtp encoding parameters.
6401 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6402 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6403
6404 // Max bitrate lower than min bitrate should fail.
6405 parameters.encodings[2].min_bitrate_bps = 100000;
6406 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6407 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6408 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6409}
6410
6411// Test that min and max bitrate values set via RtpParameters are correctly
6412// propagated to the underlying encoder, and that the target is set to 3/4 of
6413// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6414// that are used if no min/max are specified).
6415TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6416 const size_t kNumSimulcastStreams = 3;
6417 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6418
6419 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006420 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006421 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006422 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006423 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006424 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006425
6426 // Get and set the rtp encoding parameters.
6427 // Change the value and set it on the VideoChannel.
6428 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6429 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6430 parameters.encodings[0].min_bitrate_bps = 100000;
6431 parameters.encodings[0].max_bitrate_bps = 200000;
6432 parameters.encodings[1].min_bitrate_bps = 300000;
6433 parameters.encodings[1].max_bitrate_bps = 400000;
6434 parameters.encodings[2].min_bitrate_bps = 500000;
6435 parameters.encodings[2].max_bitrate_bps = 600000;
6436 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6437
6438 // Verify that the new value propagated down to the encoder.
6439 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6440 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6441 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6442 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6443 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6444 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6445 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6446 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6447 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6448 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6449 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6450
6451 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6452 // VideoStreams are created appropriately for the simulcast case.
6453 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6454 // Target bitrate: 200000 * 3 / 4 = 150000.
6455 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6456 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6457 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6458 // Target bitrate: 400000 * 3 / 4 = 300000.
6459 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6460 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6461 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6462 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6463 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6464 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6465 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6466
6467 // No parameter changed, encoder should not be reconfigured.
6468 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6469 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6470
6471 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6472}
6473
6474// Test to only specify the min or max bitrate value for a layer via
6475// RtpParameters. The unspecified min/max and target value should be set to the
6476// simulcast default that is used if no min/max are specified.
6477TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6478 const size_t kNumSimulcastStreams = 3;
6479 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6480 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6481
6482 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006483 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006484 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006485 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006486 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006487 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006488
6489 // Get and set the rtp encoding parameters.
6490 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6491 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6492
6493 // Change the value and set it on the VideoChannel.
6494 // Layer 0: only configure min bitrate.
6495 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6496 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6497 // Layer 1: only configure max bitrate.
6498 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6499 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6500 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6501
6502 // Verify that the new value propagated down to the encoder.
6503 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6504 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6505 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6506 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6507 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6508 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6509 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6510 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6511 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6512 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6513
6514 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6515 // VideoStreams are created appropriately for the simulcast case.
6516 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6517 // Layer 0: min configured bitrate should overwrite min default.
6518 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6519 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6520 stream->GetVideoStreams()[0].target_bitrate_bps);
6521 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6522 stream->GetVideoStreams()[0].max_bitrate_bps);
6523 // Layer 1: max configured bitrate should overwrite max default.
6524 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6525 stream->GetVideoStreams()[1].min_bitrate_bps);
6526 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6527 stream->GetVideoStreams()[1].target_bitrate_bps);
6528 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6529 // Layer 2: min and max bitrate not configured, default expected.
6530 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6531 stream->GetVideoStreams()[2].min_bitrate_bps);
6532 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6533 stream->GetVideoStreams()[2].target_bitrate_bps);
6534 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6535 stream->GetVideoStreams()[2].max_bitrate_bps);
6536
6537 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6538}
6539
6540// Test that specifying the min (or max) bitrate value for a layer via
6541// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6542// unspecified values accordingly.
6543TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6544 const size_t kNumSimulcastStreams = 3;
6545 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6546 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6547
6548 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006549 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006550 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006551 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006552 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006553 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006554
6555 // Get and set the rtp encoding parameters.
6556 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6557 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6558
6559 // Change the value and set it on the VideoChannel.
6560 // For layer 0, set the min bitrate above the default max.
6561 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6562 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6563 // For layer 1, set the max bitrate below the default min.
6564 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6565 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6566 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6567
6568 // Verify that the new value propagated down to the encoder.
6569 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6570 // VideoStreams are created appropriately for the simulcast case.
6571 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6572 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6573 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6574 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6575 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6576 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6577 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6578 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6579 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6580 // Layer 2: min and max bitrate not configured, default expected.
6581 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6582 stream->GetVideoStreams()[2].min_bitrate_bps);
6583 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6584 stream->GetVideoStreams()[2].target_bitrate_bps);
6585 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6586 stream->GetVideoStreams()[2].max_bitrate_bps);
6587
6588 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6589}
6590
6591TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6592 const size_t kNumSimulcastStreams = 3;
6593 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6594 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6595
6596 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006597 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006598 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006599 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006600 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006601 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006602
6603 // Set max bitrate for all but the highest layer.
6604 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6605 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6606 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6607 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6608 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6609
6610 // Set max bandwidth equal to total max bitrate.
6611 send_parameters_.max_bandwidth_bps =
6612 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6613 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6614 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6615
6616 // No bitrate above the total max to give to the highest layer.
6617 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6618 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6619 stream->GetVideoStreams()[2].max_bitrate_bps);
6620
6621 // Set max bandwidth above the total max bitrate.
6622 send_parameters_.max_bandwidth_bps =
6623 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6624 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6625 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6626
6627 // The highest layer has no max bitrate set -> the bitrate above the total
6628 // max should be given to the highest layer.
6629 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6630 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6631 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6632 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6633 stream->GetVideoStreams()[2].max_bitrate_bps);
6634
6635 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6636}
6637
6638TEST_F(WebRtcVideoChannelTest,
6639 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6640 const size_t kNumSimulcastStreams = 3;
6641 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6642 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6643 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6644
6645 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006646 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006647 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006648 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006649 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006650 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006651
6652 // Set max bitrate for the highest layer.
6653 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6654 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6655 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6656 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6657
6658 // Set max bandwidth above the total max bitrate.
6659 send_parameters_.max_bandwidth_bps =
6660 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6661 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6662 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6663
6664 // The highest layer has the max bitrate set -> the bitrate above the total
6665 // max should not be given to the highest layer.
6666 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6667 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6668 stream->GetVideoStreams()[2].max_bitrate_bps);
6669
6670 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6671}
6672
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006673// Test that min and max bitrate values set via RtpParameters are correctly
6674// propagated to the underlying encoder for a single stream.
6675TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6676 FakeVideoSendStream* stream = AddSendStream();
6677 EXPECT_TRUE(channel_->SetSend(true));
6678 EXPECT_TRUE(stream->IsSending());
6679
6680 // Set min and max bitrate.
6681 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6682 EXPECT_EQ(1u, parameters.encodings.size());
6683 parameters.encodings[0].min_bitrate_bps = 80000;
6684 parameters.encodings[0].max_bitrate_bps = 150000;
6685 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6686
6687 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6688 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6689 EXPECT_EQ(1u, encoder_config.number_of_streams);
6690 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6691 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6692 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6693
6694 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6695 // VideoStreams are created appropriately.
6696 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6697 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6698 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6699 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6700}
6701
6702// Test the default min and max bitrate value are correctly propagated to the
6703// underlying encoder for a single stream (when the values are not set via
6704// RtpParameters).
6705TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6706 FakeVideoSendStream* stream = AddSendStream();
6707 EXPECT_TRUE(channel_->SetSend(true));
6708 EXPECT_TRUE(stream->IsSending());
6709
6710 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6711 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6712 EXPECT_EQ(1u, encoder_config.number_of_streams);
6713 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6714 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6715 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6716
6717 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6718 // VideoStreams are created appropriately.
6719 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6720 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6721 stream->GetVideoStreams()[0].min_bitrate_bps);
6722 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6723 stream->GetVideoStreams()[0].min_bitrate_bps);
6724 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6725 stream->GetVideoStreams()[0].target_bitrate_bps);
6726}
6727
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006728// Test that a stream will not be sending if its encoding is made inactive
6729// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006730TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006731 FakeVideoSendStream* stream = AddSendStream();
6732 EXPECT_TRUE(channel_->SetSend(true));
6733 EXPECT_TRUE(stream->IsSending());
6734
6735 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006736 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006737 ASSERT_EQ(1u, parameters.encodings.size());
6738 ASSERT_TRUE(parameters.encodings[0].active);
6739 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006740 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006741 EXPECT_FALSE(stream->IsSending());
6742
6743 // Now change it back to active and verify we resume sending.
6744 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006745 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006746 EXPECT_TRUE(stream->IsSending());
6747}
6748
Seth Hampson8234ead2018-02-02 15:16:24 -08006749// Tests that when active is updated for any simulcast layer then the send
6750// stream's sending state will be updated and it will be reconfigured with the
6751// new appropriate active simulcast streams.
6752TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6753 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006754 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006755 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6756 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6757 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6758 uint32_t primary_ssrc = stream_params.first_ssrc();
6759
Niels Möller805a27e2019-01-21 12:21:27 +01006760 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006761 // frame. This allows us to test that ReconfigureEncoder is called
6762 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006763 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006764 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006765 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006766 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006767 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6768 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6769 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006770
6771 // Check that all encodings are initially active.
6772 webrtc::RtpParameters parameters =
6773 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006774 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006775 EXPECT_TRUE(parameters.encodings[0].active);
6776 EXPECT_TRUE(parameters.encodings[1].active);
6777 EXPECT_TRUE(parameters.encodings[2].active);
6778 EXPECT_TRUE(fake_video_send_stream->IsSending());
6779
6780 // Only turn on only the middle stream.
6781 parameters.encodings[0].active = false;
6782 parameters.encodings[1].active = true;
6783 parameters.encodings[2].active = false;
6784 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6785 // Verify that the active fields are set on the VideoChannel.
6786 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006787 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006788 EXPECT_FALSE(parameters.encodings[0].active);
6789 EXPECT_TRUE(parameters.encodings[1].active);
6790 EXPECT_FALSE(parameters.encodings[2].active);
6791 // Check that the VideoSendStream is updated appropriately. This means its
6792 // send state was updated and it was reconfigured.
6793 EXPECT_TRUE(fake_video_send_stream->IsSending());
6794 std::vector<webrtc::VideoStream> simulcast_streams =
6795 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006796 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006797 EXPECT_FALSE(simulcast_streams[0].active);
6798 EXPECT_TRUE(simulcast_streams[1].active);
6799 EXPECT_FALSE(simulcast_streams[2].active);
6800
6801 // Turn off all streams.
6802 parameters.encodings[0].active = false;
6803 parameters.encodings[1].active = false;
6804 parameters.encodings[2].active = false;
6805 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6806 // Verify that the active fields are set on the VideoChannel.
6807 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006808 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006809 EXPECT_FALSE(parameters.encodings[0].active);
6810 EXPECT_FALSE(parameters.encodings[1].active);
6811 EXPECT_FALSE(parameters.encodings[2].active);
6812 // Check that the VideoSendStream is off.
6813 EXPECT_FALSE(fake_video_send_stream->IsSending());
6814 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006815 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006816 EXPECT_FALSE(simulcast_streams[0].active);
6817 EXPECT_FALSE(simulcast_streams[1].active);
6818 EXPECT_FALSE(simulcast_streams[2].active);
6819
Niels Möllerff40b142018-04-09 08:49:14 +02006820 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006821}
6822
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006823// Test that if a stream is reconfigured (due to a codec change or other
6824// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006825TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006826 InactiveStreamDoesntStartSendingWhenReconfigured) {
6827 // Set an initial codec list, which will be modified later.
6828 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006829 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6830 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006831 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6832
6833 FakeVideoSendStream* stream = AddSendStream();
6834 EXPECT_TRUE(channel_->SetSend(true));
6835 EXPECT_TRUE(stream->IsSending());
6836
6837 // Get current parameters and change "active" to false.
6838 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6839 ASSERT_EQ(1u, parameters.encodings.size());
6840 ASSERT_TRUE(parameters.encodings[0].active);
6841 parameters.encodings[0].active = false;
6842 EXPECT_EQ(1u, GetFakeSendStreams().size());
6843 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006844 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006845 EXPECT_FALSE(stream->IsSending());
6846
6847 // Reorder the codec list, causing the stream to be reconfigured.
6848 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006849 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6850 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006851 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6852 auto new_streams = GetFakeSendStreams();
6853 // Assert that a new underlying stream was created due to the codec change.
6854 // Otherwise, this test isn't testing what it set out to test.
6855 EXPECT_EQ(1u, GetFakeSendStreams().size());
6856 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6857
6858 // Verify that we still are not sending anything, due to the inactive
6859 // encoding.
6860 EXPECT_FALSE(new_streams[0]->IsSending());
6861}
6862
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006863// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006864TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006865 AddSendStream();
6866 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006867 parameters.codecs.push_back(GetEngineCodec("VP8"));
6868 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006869 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6870
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006871 webrtc::RtpParameters rtp_parameters =
6872 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006873 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006874 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6875 rtp_parameters.codecs[0]);
6876 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6877 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006878}
6879
Florent Castellidacec712018-05-24 16:24:21 +02006880// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6881TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6882 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6883 params.cname = "rtcpcname";
6884 AddSendStream(params);
6885
6886 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6887 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6888}
6889
deadbeeffb2aced2017-01-06 23:05:37 -08006890// Test that RtpParameters for send stream has one encoding and it has
6891// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006892TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006893 AddSendStream();
6894
6895 webrtc::RtpParameters rtp_parameters =
6896 channel_->GetRtpSendParameters(last_ssrc_);
6897 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006898 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006899}
6900
Florent Castelliabe301f2018-06-12 18:33:49 +02006901TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6902 AddSendStream();
6903
6904 webrtc::RtpParameters rtp_parameters =
6905 channel_->GetRtpSendParameters(last_ssrc_);
6906 rtp_parameters.header_extensions.emplace_back();
6907
6908 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6909
6910 webrtc::RTCError result =
6911 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6912 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6913}
6914
Florent Castelli87b3c512018-07-18 16:00:28 +02006915TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6916 AddSendStream();
6917
Niels Möller805a27e2019-01-21 12:21:27 +01006918 webrtc::test::FrameForwarder frame_forwarder;
6919 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02006920
6921 webrtc::RtpParameters rtp_parameters =
6922 channel_->GetRtpSendParameters(last_ssrc_);
6923 EXPECT_EQ(rtp_parameters.degradation_preference,
6924 webrtc::DegradationPreference::BALANCED);
6925 rtp_parameters.degradation_preference =
6926 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6927
6928 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6929
6930 webrtc::RtpParameters updated_rtp_parameters =
6931 channel_->GetRtpSendParameters(last_ssrc_);
6932 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6933 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6934
6935 // Remove the source since it will be destroyed before the channel
6936 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6937}
6938
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006939// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006940TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006941 AddSendStream();
6942 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006943 parameters.codecs.push_back(GetEngineCodec("VP8"));
6944 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006945 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6946
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006947 webrtc::RtpParameters initial_params =
6948 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006949
6950 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006951 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006952
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006953 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6954 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6955}
6956
6957// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006958TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006959 AddRecvStream();
6960 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006961 parameters.codecs.push_back(GetEngineCodec("VP8"));
6962 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006963 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6964
6965 webrtc::RtpParameters rtp_parameters =
6966 channel_->GetRtpReceiveParameters(last_ssrc_);
6967 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006968 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6969 rtp_parameters.codecs[0]);
6970 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6971 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006972}
6973
johan073ece42016-08-26 02:59:47 -07006974#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006975TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006976#else
eladalonf1841382017-06-12 01:16:46 -07006977TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006978#endif
johan3859c892016-08-05 09:19:25 -07006979 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006980 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006981 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006982 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006983 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006984 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006985 parameters.codecs.push_back(kH264sprop2);
6986 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6987
6988 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6989 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6990 webrtc::RtpParameters rtp_parameters =
6991 channel_->GetRtpReceiveParameters(last_ssrc_);
6992 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6993 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6994 ASSERT_EQ(2u, cfg.decoders.size());
6995 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006996 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006997 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006998 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6999 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007000 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007001
7002 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007003 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007004 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007005 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7006 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007007 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007008}
7009
sakal1fd95952016-06-22 00:46:15 -07007010// Test that RtpParameters for receive stream has one encoding and it has
7011// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007012TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007013 AddRecvStream();
7014
7015 webrtc::RtpParameters rtp_parameters =
7016 channel_->GetRtpReceiveParameters(last_ssrc_);
7017 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007018 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007019}
7020
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007021// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007022TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007023 AddRecvStream();
7024 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007025 parameters.codecs.push_back(GetEngineCodec("VP8"));
7026 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007027 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7028
7029 webrtc::RtpParameters initial_params =
7030 channel_->GetRtpReceiveParameters(last_ssrc_);
7031
7032 // We should be able to set the params we just got.
7033 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7034
7035 // ... And this shouldn't change the params returned by
7036 // GetRtpReceiveParameters.
7037 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007038}
7039
deadbeef3bc15102017-04-20 19:25:07 -07007040// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7041// aren't signaled. It should always return an empty "RtpEncodingParameters",
7042// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007043TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007044 // Call necessary methods to configure receiving a default stream as
7045 // soon as it arrives.
7046 cricket::VideoRecvParameters parameters;
7047 parameters.codecs.push_back(GetEngineCodec("VP8"));
7048 parameters.codecs.push_back(GetEngineCodec("VP9"));
7049 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7050
7051 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7052 // stream. Should return nothing.
7053 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7054
7055 // Set a sink for an unsignaled stream.
7056 cricket::FakeVideoRenderer renderer;
7057 // Value of "0" means "unsignaled stream".
7058 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7059
7060 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7061 // in this method means "unsignaled stream".
7062 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7063 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7064 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7065
7066 // Receive VP8 packet.
7067 uint8_t data[kMinRtpPacketLen];
7068 cricket::RtpHeader rtpHeader;
7069 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7070 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7071 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7072 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7073 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007074 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007075
7076 // The |ssrc| member should still be unset.
7077 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7078 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7079 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7080}
7081
eladalonf1841382017-06-12 01:16:46 -07007082void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007083 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007084 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007085
7086 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007087 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007088 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007089 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007090
7091 if (receiver_first) {
7092 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7093 std::vector<FakeVideoReceiveStream*> receive_streams =
7094 fake_call_->GetVideoReceiveStreams();
7095 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007096 // Default local SSRC when we have no sender.
7097 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7098 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007099 }
7100 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7101 if (!receiver_first)
7102 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7103 std::vector<FakeVideoReceiveStream*> receive_streams =
7104 fake_call_->GetVideoReceiveStreams();
7105 ASSERT_EQ(1u, receive_streams.size());
7106 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007107
7108 // Removing first sender should fall back to another (in this case the second)
7109 // local send stream's SSRC.
7110 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7111 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007112 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007113 ASSERT_EQ(1u, receive_streams.size());
7114 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7115
7116 // Removing the last sender should fall back to default local SSRC.
7117 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007118 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007119 ASSERT_EQ(1u, receive_streams.size());
7120 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7121 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007122}
7123
eladalonf1841382017-06-12 01:16:46 -07007124TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007125 TestReceiverLocalSsrcConfiguration(false);
7126}
7127
eladalonf1841382017-06-12 01:16:46 -07007128TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007129 TestReceiverLocalSsrcConfiguration(true);
7130}
7131
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007132class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007133 public:
eladalonf1841382017-06-12 01:16:46 -07007134 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007135 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007136 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7137 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007138 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007139 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007140 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007141 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007142 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007143 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007144 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007145
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007146 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007147 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007148 channel_.reset(engine_.CreateMediaChannel(
7149 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7150 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007151 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007152 last_ssrc_ = 123;
7153 }
7154
7155 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007156 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007157 int capture_width,
7158 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007159 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007160 size_t expected_num_streams,
7161 bool screenshare,
7162 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007163 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007164 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007165 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007166 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007167
Peter Boström0c4e06b2015-10-07 12:23:21 +02007168 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007169 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007170 ssrcs.resize(num_configured_streams);
7171
sprangf24a0642017-02-28 13:23:26 -08007172 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007173 // Send a full-size frame to trigger a stream reconfiguration to use all
7174 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007175 webrtc::test::FrameForwarder frame_forwarder;
7176 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7177 rtc::kNumMicrosecsPerSec / 30);
7178
sprangf24a0642017-02-28 13:23:26 -08007179 VideoOptions options;
7180 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007181 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007182 EXPECT_TRUE(
7183 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007184 // Fetch the latest stream since SetVideoSend() may recreate it if the
7185 // screen content setting is changed.
7186 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007187 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007188 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007189
Zach Stein3ca452b2018-01-18 10:01:24 -08007190 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7191 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7192
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007193 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7194 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007195 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007196
sprang429600d2017-01-26 06:12:26 -08007197 std::vector<webrtc::VideoStream> expected_streams;
7198 if (conference_mode) {
7199 expected_streams = GetSimulcastConfig(
7200 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08007201 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02007202 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08007203 if (screenshare) {
7204 for (const webrtc::VideoStream& stream : expected_streams) {
7205 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007206 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7207 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007208 }
7209 }
sprang429600d2017-01-26 06:12:26 -08007210 } else {
7211 webrtc::VideoStream stream;
7212 stream.width = capture_width;
7213 stream.height = capture_height;
7214 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007215 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007216 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007217 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007218 stream.max_qp = kDefaultQpMax;
7219 expected_streams.push_back(stream);
7220 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007221
7222 ASSERT_EQ(expected_streams.size(), video_streams.size());
7223
7224 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007225 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007226 for (size_t i = 0; i < num_streams; ++i) {
7227 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7228 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7229
7230 EXPECT_GT(video_streams[i].max_framerate, 0);
7231 EXPECT_EQ(expected_streams[i].max_framerate,
7232 video_streams[i].max_framerate);
7233
7234 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7235 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7236 video_streams[i].min_bitrate_bps);
7237
7238 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7239 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7240 video_streams[i].target_bitrate_bps);
7241
7242 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7243 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7244 video_streams[i].max_bitrate_bps);
7245
7246 EXPECT_GT(video_streams[i].max_qp, 0);
7247 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7248
Sergey Silkina796a7e2018-03-01 15:11:29 +01007249 EXPECT_EQ(conference_mode,
7250 expected_streams[i].num_temporal_layers.has_value());
7251
7252 if (conference_mode) {
7253 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7254 video_streams[i].num_temporal_layers);
7255 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007256
7257 if (i == num_streams - 1) {
7258 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7259 } else {
7260 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7261 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007262 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007263
Niels Möllerff40b142018-04-09 08:49:14 +02007264 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007265 }
7266
7267 FakeVideoSendStream* AddSendStream() {
7268 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7269 }
7270
7271 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007272 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007273 EXPECT_TRUE(channel_->AddSendStream(sp));
7274 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007275 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007276 EXPECT_EQ(num_streams + 1, streams.size());
7277 return streams[streams.size() - 1];
7278 }
7279
7280 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007281 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007282 }
7283
7284 FakeVideoReceiveStream* AddRecvStream() {
7285 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7286 }
7287
7288 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007289 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007290 EXPECT_TRUE(channel_->AddRecvStream(sp));
7291 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007292 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007293 EXPECT_EQ(num_streams + 1, streams.size());
7294 return streams[streams.size() - 1];
7295 }
7296
skvlad11a9cbf2016-10-07 11:53:05 -07007297 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007298 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007299 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7300 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007301 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7302 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007303 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007304 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007305 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007306};
7307
eladalonf1841382017-06-12 01:16:46 -07007308TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007309 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7310 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007311}
7312
eladalonf1841382017-06-12 01:16:46 -07007313TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007314 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7315 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007316}
7317
7318// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007319TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007320 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7321 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007322}
sprang429600d2017-01-26 06:12:26 -08007323
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007324TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007325 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7326 false);
7327}
7328
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007329TEST_F(WebRtcVideoChannelSimulcastTest,
7330 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007331 webrtc::test::ScopedFieldTrials field_trials(
7332 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007333 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7334 true);
7335}
7336
eladalonf1841382017-06-12 01:16:46 -07007337TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007338 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7339 true);
7340}
7341
eladalonf1841382017-06-12 01:16:46 -07007342TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007343 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007344 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7345 false);
7346}
7347
Yves Gereyb6a89422018-10-08 10:08:32 +02007348class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007349 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02007350 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007351 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7352 }
7353 rtc::ScopedFakeClock fake_clock_;
7354};
7355
Yves Gereyb6a89422018-10-08 10:08:32 +02007356// The fake clock needs to be initialized before the call, and not
7357// destroyed until after all threads spawned by the test have been stopped.
7358// This mixin ensures that.
7359class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7360 public WebRtcVideoChannelBaseTest {};
7361
Jonas Oreland49ac5952018-09-26 16:04:32 +02007362TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7363 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7364 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7365
7366 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7367
7368 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7369 rtc::SetBE32(packet1.data() + 8, kSsrc);
7370 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7371 EXPECT_TRUE(SetDefaultCodec());
7372 EXPECT_TRUE(SetSend(true));
7373 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007374 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007375
7376 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7377 EXPECT_EQ(1u, sources.size());
7378 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7379 int64_t timestamp1 = sources[0].timestamp_ms();
7380
7381 // a new packet.
7382 int64_t timeDeltaMs = 1;
7383 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007384 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007385 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7386 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7387
7388 // It only keeps 10s of history.
7389 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7390 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7391 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7392}
7393
7394TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7395 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7396 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7397
7398 uint32_t kCsrc = 4321u;
7399 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7400 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7401
7402 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7403 rtc::SetBE32(packet1.data() + 8, kSsrc);
7404 rtc::SetBE32(packet1.data() + 12, kCsrc);
7405 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7406 EXPECT_TRUE(SetDefaultCodec());
7407 EXPECT_TRUE(SetSend(true));
7408 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007409 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007410
7411 {
7412 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7413 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7414 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7415 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7416 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007417 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7418 return source.source_type() == webrtc::RtpSourceType::SSRC;
7419 }));
7420 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7421 return source.source_type() == webrtc::RtpSourceType::CSRC;
7422 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007423 }
7424 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7425
7426 // a new packet with only ssrc (i.e no csrc).
7427 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7428 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7429 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7430 rtc::SetBE32(packet2.data() + 8, kSsrc);
7431
7432 int64_t timeDeltaMs = 1;
7433 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007434 channel_->OnPacketReceived(packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007435
7436 {
7437 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7438 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7439 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7440 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7441 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007442 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7443 return source.source_type() == webrtc::RtpSourceType::SSRC;
7444 }));
7445 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7446 return source.source_type() == webrtc::RtpSourceType::CSRC;
7447 }));
7448 auto ssrcSource =
7449 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007450 return source.source_type() == webrtc::RtpSourceType::SSRC;
7451 });
Steve Anton2c9ebef2019-01-28 17:27:58 -08007452 auto csrcSource =
7453 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007454 return source.source_type() == webrtc::RtpSourceType::CSRC;
7455 });
7456
7457 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7458 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7459 }
7460
7461 // It only keeps 10s of history.
7462 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7463
7464 {
7465 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7466 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7467 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
Steve Anton2c9ebef2019-01-28 17:27:58 -08007468 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7469 return source.source_type() == webrtc::RtpSourceType::SSRC;
7470 }));
7471 EXPECT_EQ(0, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7472 return source.source_type() == webrtc::RtpSourceType::CSRC;
7473 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007474 }
7475
7476 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7477 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7478 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7479}
7480
Amit Hilbuchb000b712019-02-25 10:22:14 -08007481TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7482 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7483
7484 std::vector<std::string> rids = {"f", "h", "q"};
7485 std::vector<cricket::RidDescription> rid_descriptions;
7486 for (const auto& rid : rids) {
7487 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7488 }
7489 sp.set_rids(rid_descriptions);
7490
7491 ASSERT_TRUE(channel_->AddSendStream(sp));
7492 const auto& streams = fake_call_->GetVideoSendStreams();
7493 ASSERT_EQ(1u, streams.size());
7494 auto stream = streams[0];
7495 ASSERT_NE(stream, nullptr);
7496 const auto& config = stream->GetConfig();
7497 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7498}
7499
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007500} // namespace cricket