blob: 4ba3c489dcad197f4d568a71e2c888bf3b6dd90f [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller039743e2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Seth Hampson24722b32017-12-22 09:36:42 -080018#include "api/rtpparameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080019#include "api/test/mock_video_bitrate_allocator.h"
20#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070021#include "api/test/mock_video_decoder_factory.h"
22#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020023#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080024#include "api/video/builtin_video_bitrate_allocator_factory.h"
Åsa Persson23eba222018-10-02 14:47:06 +020025#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020026#include "api/video_codecs/builtin_video_decoder_factory.h"
27#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "api/video_codecs/sdp_video_format.h"
29#include "api/video_codecs/video_decoder_factory.h"
30#include "api/video_codecs/video_encoder.h"
31#include "api/video_codecs/video_encoder_factory.h"
32#include "call/flexfec_receive_stream.h"
33#include "common_video/h264/profile_level_id.h"
34#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020035#include "media/base/fakenetworkinterface.h"
36#include "media/base/fakevideocapturer.h"
37#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020038#include "media/base/mediaconstants.h"
39#include "media/base/rtputils.h"
40#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020041#include "media/engine/constants.h"
42#include "media/engine/fakewebrtccall.h"
43#include "media/engine/fakewebrtcvideoengine.h"
44#include "media/engine/simulcast.h"
45#include "media/engine/webrtcvideoengine.h"
46#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020047#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020049#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020051#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "rtc_base/stringutils.h"
53#include "test/field_trial.h"
54#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000055
Tommi85959932018-02-07 19:26:06 +010056using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010057using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070058using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010059using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070060
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000061namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000062static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000063
noahricd10a68e2015-07-10 11:27:55 -070064static const uint8_t kRedRtxPayloadType = 125;
65
Niels Möller6557d0c2018-04-11 15:18:34 +020066static const uint32_t kTimeout = 5000U;
67static const uint32_t kDefaultReceiveSsrc = 0;
68static const uint32_t kSsrc = 1234u;
69static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
70static const int kVideoWidth = 640;
71static const int kVideoHeight = 360;
72static const int kFramerate = 30;
73
Peter Boström0c4e06b2015-10-07 12:23:21 +020074static const uint32_t kSsrcs1[] = {1};
75static const uint32_t kSsrcs3[] = {1, 2, 3};
76static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080077static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020078static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080079static const uint32_t kDefaultRecvSsrc = 0;
80
pbos@webrtc.org3c107582014-07-20 15:27:35 +000081static const char kUnsupportedExtensionName[] =
82 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000083
magjed509e4fe2016-11-18 01:34:11 -080084cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
85 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020086 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080087}
88
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000089void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
91 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
93 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
95 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
96 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080097 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
98 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000099 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
100}
101
magjed725e4842016-11-16 00:48:13 -0800102// Return true if any codec in |codecs| is an RTX codec with associated payload
103// type |payload_type|.
104bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
105 int payload_type) {
106 for (const cricket::VideoCodec& codec : codecs) {
107 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200108 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800109 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
110 &associated_payload_type) &&
111 associated_payload_type == payload_type) {
112 return true;
113 }
114 }
115 return false;
116}
117
nisseca5706d2017-09-11 02:32:16 -0700118// TODO(nisse): Duplicated in call.cc.
119const int* FindKeyByValue(const std::map<int, int>& m, int v) {
120 for (const auto& kv : m) {
121 if (kv.second == v)
122 return &kv.first;
123 }
124 return nullptr;
125}
126
Yves Gerey665174f2018-06-19 15:03:05 +0200127bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
128 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700129 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
130 payload_type) != nullptr;
131}
132
133// Check that there's an Rtx payload type for each decoder.
134bool VerifyRtxReceiveAssociations(
135 const webrtc::VideoReceiveStream::Config& config) {
136 for (const auto& decoder : config.decoders) {
137 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
138 return false;
139 }
140 return true;
141}
142
brandtrffc61182016-11-28 06:02:22 -0800143rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700144 int width,
145 int height) {
146 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
147 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800148 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700149 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000150}
151
Shao Changbine62202f2015-04-21 20:24:50 +0800152void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
153 const std::map<int, int>& rtx_types) {
154 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200155 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800156 EXPECT_TRUE(it != rtx_types.end() &&
157 it->second == config.rtp.rtx.payload_type);
158
brandtrb5f2c3f2016-10-04 23:28:39 -0700159 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
160 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800161 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700162 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800163 }
164}
kthelgason2bc68642017-02-07 07:02:22 -0800165
166cricket::MediaConfig GetMediaConfig() {
167 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100168 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800169 return media_config;
170}
nisse26e3abb2017-08-25 04:44:25 -0700171
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200172// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
173int GetMaxDefaultBitrateBps(size_t width, size_t height) {
174 if (width * height <= 320 * 240) {
175 return 600000;
176 } else if (width * height <= 640 * 480) {
177 return 1700000;
178 } else if (width * height <= 960 * 540) {
179 return 2000000;
180 } else {
181 return 2500000;
182 }
183}
184
Niels Möller731a2c22018-07-30 15:08:07 +0200185class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
186 public:
187 MOCK_METHOD2(AddOrUpdateSink,
188 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
189 const rtc::VideoSinkWants& wants));
190 MOCK_METHOD1(RemoveSink,
191 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
192};
193
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000194} // namespace
195
Yves Gerey665174f2018-06-19 15:03:05 +0200196#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200197 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200198 EXPECT_EQ((w), renderer_.width()); \
199 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ(0, renderer_.errors());
201
Yves Gerey665174f2018-06-19 15:03:05 +0200202#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200204 EXPECT_EQ((w), (r).width()); \
205 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ(0, (r).errors());
207
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000208namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700209class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000210 public:
eladalonf1841382017-06-12 01:16:46 -0700211 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
212 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700213 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700214 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200215 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
216 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200217 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200218 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200219 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800220 decoder_factory_),
221 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200222 // Ensure fake clock doesn't return 0, which will cause some initializations
223 // fail inside RTP senders.
224 fake_clock_.AdvanceTimeMicros(1);
225 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000226
227 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200228 void AssignDefaultAptRtxTypes();
229 void AssignDefaultCodec();
230
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100231 // Find the index of the codec in the engine with the given name. The codec
232 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100233 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100234
magjed509e4fe2016-11-18 01:34:11 -0800235 // Find the codec in the engine with the given name. The codec must be
236 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100237 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800238
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200239 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000240
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200241 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000242 const std::vector<VideoCodec>& codecs);
243
Peter Boströme4499152016-02-05 11:13:28 +0100244 void TestExtendedEncoderOveruse(bool use_external_encoder);
245
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200246 // Has to be the first one, so it is initialized before the call or there is a
247 // race condition in the clock access.
248 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700249 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700250 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700251 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000252 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800253 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200254 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
255 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700256 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000257 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800258 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000259};
260
eladalonf1841382017-06-12 01:16:46 -0700261TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200262 encoder_factory_->AddSupportedVideoCodecType("VP8");
263 AssignDefaultCodec();
264
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000265 std::vector<VideoCodec> engine_codecs = engine_.codecs();
266 for (size_t i = 0; i < engine_codecs.size(); ++i) {
267 if (engine_codecs[i].name != kRtxCodecName)
268 continue;
269 int associated_payload_type;
270 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000271 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000272 EXPECT_EQ(default_codec_.id, associated_payload_type);
273 return;
274 }
275 FAIL() << "No RTX codec found among default codecs.";
276}
277
eladalonf1841382017-06-12 01:16:46 -0700278TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100279 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100280 EXPECT_THAT(
281 capabilities.header_extensions,
282 testing::Contains(RtpExtension(RtpExtension::kTimestampOffsetUri,
283 RtpExtension::kTimestampOffsetDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000284}
285
eladalonf1841382017-06-12 01:16:46 -0700286TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100287 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100288 EXPECT_THAT(
289 capabilities.header_extensions,
290 testing::Contains(RtpExtension(RtpExtension::kAbsSendTimeUri,
291 RtpExtension::kAbsSendTimeDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000292}
293
eladalonf1841382017-06-12 01:16:46 -0700294TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100295 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100296 EXPECT_THAT(capabilities.header_extensions,
297 testing::Contains(RtpExtension(
298 RtpExtension::kTransportSequenceNumberUri,
299 RtpExtension::kTransportSequenceNumberDefaultId)));
stefanc1aeaf02015-10-15 07:26:07 -0700300}
301
eladalonf1841382017-06-12 01:16:46 -0700302TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100303 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100304 EXPECT_THAT(
305 capabilities.header_extensions,
306 testing::Contains(RtpExtension(RtpExtension::kVideoRotationUri,
307 RtpExtension::kVideoRotationDefaultId)));
308}
309
310TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
311 RtpCapabilities capabilities = engine_.GetCapabilities();
312 EXPECT_THAT(
313 capabilities.header_extensions,
314 testing::Contains(RtpExtension(RtpExtension::kColorSpaceUri,
315 RtpExtension::kColorSpaceDefaultId)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700316}
317
philipel1e054862018-10-08 16:13:53 +0200318class WebRtcVideoEngineTestWithGenericDescriptor
319 : public WebRtcVideoEngineTest {
320 public:
321 WebRtcVideoEngineTestWithGenericDescriptor()
322 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
323};
324
325TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
326 RtpCapabilities capabilities = engine_.GetCapabilities();
327 ASSERT_FALSE(capabilities.header_extensions.empty());
328 for (const RtpExtension& extension : capabilities.header_extensions) {
329 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
330 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
331 return;
332 }
333 }
334 FAIL() << "Generic descriptor extension not in header-extension list.";
335}
336
eladalonf1841382017-06-12 01:16:46 -0700337TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200338 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700339 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200340 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700341
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200342 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700343
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200344 std::unique_ptr<VideoMediaChannel> channel(
345 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
347
348 // Add CVO extension.
349 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800350 cricket::VideoSendParameters parameters;
351 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200352 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700353 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200354 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700355
Niels Möller731a2c22018-07-30 15:08:07 +0200356 EXPECT_CALL(
357 video_source,
358 AddOrUpdateSink(testing::_,
359 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700360 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200361 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700362
363 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200364 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365
366 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200367 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200368 EXPECT_CALL(
369 video_source,
370 AddOrUpdateSink(testing::_,
371 Field(&rtc::VideoSinkWants::rotation_applied, true)));
372
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200373 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700374}
375
eladalonf1841382017-06-12 01:16:46 -0700376TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200377 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800378 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200379 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800380
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200381 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800382
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200383 std::unique_ptr<VideoMediaChannel> channel(
384 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800385 // Add CVO extension.
386 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800387 cricket::VideoSendParameters parameters;
388 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800389 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700390 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800391 EXPECT_TRUE(channel->SetSendParameters(parameters));
392 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
393
Niels Möller731a2c22018-07-30 15:08:07 +0200394 // Set source.
395 EXPECT_CALL(
396 video_source,
397 AddOrUpdateSink(testing::_,
398 Field(&rtc::VideoSinkWants::rotation_applied, false)));
399 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800400}
401
eladalonf1841382017-06-12 01:16:46 -0700402TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200403 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700404
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200405 encoder_factory_->AddSupportedVideoCodecType("VP8");
406 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700407
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200408 std::unique_ptr<VideoMediaChannel> channel(
409 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700410 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
411
412 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200413 EXPECT_CALL(
414 video_source,
415 AddOrUpdateSink(testing::_,
416 Field(&rtc::VideoSinkWants::rotation_applied, true)));
417 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700418
perkjcaafdba2016-03-20 07:34:29 -0700419 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200420 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700421
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700422 // Add CVO extension.
423 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800424 cricket::VideoSendParameters parameters;
425 parameters.codecs.push_back(GetEngineCodec("VP8"));
426 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200427 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700428 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700429 // Also remove the first codec to trigger a codec change as well.
430 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200431 EXPECT_CALL(
432 video_source,
433 AddOrUpdateSink(testing::_,
434 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200435 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700436
437 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200438 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700439
440 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200441 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200442 EXPECT_CALL(
443 video_source,
444 AddOrUpdateSink(testing::_,
445 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200446 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700447}
448
eladalonf1841382017-06-12 01:16:46 -0700449TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200450 encoder_factory_->AddSupportedVideoCodecType("VP8");
451
Sebastian Jansson84848f22018-11-16 10:40:36 +0100452 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700453 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000454
455 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
456
457 EXPECT_FALSE(channel->SetSend(true))
458 << "Channel should not start without codecs.";
459 EXPECT_TRUE(channel->SetSend(false))
460 << "Channel should be stoppable even without set codecs.";
461}
462
eladalonf1841382017-06-12 01:16:46 -0700463TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200464 encoder_factory_->AddSupportedVideoCodecType("VP8");
465
Sebastian Jansson84848f22018-11-16 10:40:36 +0100466 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700467 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000468 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
469 VideoMediaInfo info;
470 channel->GetStats(&info);
471}
472
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200473TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200474 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000475
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200476 std::unique_ptr<VideoMediaChannel> channel(
477 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800478 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000479
480 EXPECT_TRUE(
481 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200482 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000483 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100484 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200485 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000486 EXPECT_EQ(cricket::CS_RUNNING,
487 capturer.Start(capturer.GetSupportedFormats()->front()));
488 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100489 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200490 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
491 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000492 kTimeout);
493
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100495 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000496
497 // Setting codecs of the same type should not reallocate any encoders
498 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800499 cricket::VideoSendParameters parameters;
500 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200501 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200502 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000503
504 // Remove stream previously added to free the external encoder instance.
505 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507}
508
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200509// Test that when an encoder factory supports H264, we add an RTX
510// codec for it.
511// TODO(deadbeef): This test should be updated if/when we start
512// adding RTX codecs for unrecognized codec names.
513TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800514 using webrtc::H264::ProfileLevelIdToString;
515 using webrtc::H264::ProfileLevelId;
516 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200517 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
518 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800519 *ProfileLevelIdToString(
520 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200521 webrtc::SdpVideoFormat h264_constrained_high("H264");
522 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800523 *ProfileLevelIdToString(
524 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200525 webrtc::SdpVideoFormat h264_high("H264");
526 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800527 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
528
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200529 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
530 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
531 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700532
magjed725e4842016-11-16 00:48:13 -0800533 // First figure out what payload types the test codecs got assigned.
534 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800535 // Now search for RTX codecs for them. Expect that they all have associated
536 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800537 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200538 codecs,
539 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
540 ->id));
magjed725e4842016-11-16 00:48:13 -0800541 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200542 codecs,
543 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
544 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800545 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200546 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700547}
548
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100549#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700550TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200551 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100552
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200553 std::unique_ptr<VideoMediaChannel> channel(
554 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100555
556 EXPECT_TRUE(
557 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
558}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100559#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100560
eladalonf1841382017-06-12 01:16:46 -0700561TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200562 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100563 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200564 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200565 std::unique_ptr<VideoMediaChannel> channel(
566 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700567
568 EXPECT_TRUE(
569 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
570
Tommi85959932018-02-07 19:26:06 +0100571 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200572 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700573 capturer.Start(cricket::VideoFormat(1280, 720,
574 cricket::VideoFormat::FpsToInterval(60),
575 cricket::FOURCC_I420));
576 channel->SetSend(true);
577
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200578 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700579
580 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700581 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700582 for (int i = 0; i < 10; i++) {
583 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700584 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700585 int64_t interval = timestamp - last_timestamp;
586
587 // Precision changes from nanosecond to millisecond.
588 // Allow error to be no more than 1.
589 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
590
591 last_timestamp = timestamp;
592 }
593
594 capturer.Start(cricket::VideoFormat(1280, 720,
595 cricket::VideoFormat::FpsToInterval(30),
596 cricket::FOURCC_I420));
597
598 EXPECT_TRUE(capturer.CaptureFrame());
599 last_timestamp = stream->GetLastTimestamp();
600 for (int i = 0; i < 10; i++) {
601 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700602 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700603 int64_t interval = timestamp - last_timestamp;
604
605 // Precision changes from nanosecond to millisecond.
606 // Allow error to be no more than 1.
607 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
608
609 last_timestamp = timestamp;
610 }
611
612 // Remove stream previously added to free the external encoder instance.
613 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
614}
615
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200616void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
617 std::vector<VideoCodec> engine_codecs = engine_.codecs();
618 RTC_DCHECK(!engine_codecs.empty());
619 for (const cricket::VideoCodec& codec : engine_codecs) {
620 if (codec.name == "rtx") {
621 int associated_payload_type;
622 if (codec.GetParam(kCodecParamAssociatedPayloadType,
623 &associated_payload_type)) {
624 default_apt_rtx_types_[associated_payload_type] = codec.id;
625 }
626 }
627 }
628}
629
630void WebRtcVideoEngineTest::AssignDefaultCodec() {
631 std::vector<VideoCodec> engine_codecs = engine_.codecs();
632 RTC_DCHECK(!engine_codecs.empty());
633 bool codec_set = false;
634 for (const cricket::VideoCodec& codec : engine_codecs) {
635 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
636 codec.name != "ulpfec") {
637 default_codec_ = codec;
638 codec_set = true;
639 }
640 }
641
642 RTC_DCHECK(codec_set);
643}
644
Oleh Prypina40f8242017-12-21 13:32:23 +0100645size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
646 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100647 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
648 for (size_t i = 0; i < codecs.size(); ++i) {
649 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200650 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200651 continue;
652 // The tests only use H264 Constrained Baseline. Make sure we don't return
653 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200654 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200655 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200656 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
657 if (profile_level_id->profile !=
658 webrtc::H264::kProfileConstrainedBaseline) {
659 continue;
660 }
661 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100662 return i;
magjed509e4fe2016-11-18 01:34:11 -0800663 }
664 // This point should never be reached.
665 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 return -1;
667}
668
669cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
670 const std::string& name) const {
671 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800672}
673
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200674VideoMediaChannel*
675WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100676 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700677 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200678 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800679 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200680 for (const webrtc::SdpVideoFormat& format :
681 encoder_factory_->GetSupportedFormats()) {
682 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
683 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
684 engine_codec) == parameters.codecs.end()) {
685 parameters.codecs.push_back(engine_codec);
686 }
687 }
magjed509e4fe2016-11-18 01:34:11 -0800688
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200689 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000690
691 return channel;
692}
693
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200694VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000695 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100696 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700697 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200698 cricket::VideoRecvParameters parameters;
699 parameters.codecs = codecs;
700 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000701
702 return channel;
703}
704
eladalonf1841382017-06-12 01:16:46 -0700705TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200706 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000707
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200708 std::unique_ptr<VideoMediaChannel> channel(
709 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000710
Peter Boström0c4e06b2015-10-07 12:23:21 +0200711 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000712
Yves Gerey665174f2018-06-19 15:03:05 +0200713 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000714 EXPECT_TRUE(channel->SetSend(true));
715
Tommi85959932018-02-07 19:26:06 +0100716 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200717 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000718 EXPECT_EQ(cricket::CS_RUNNING,
719 capturer.Start(capturer.GetSupportedFormats()->front()));
720 EXPECT_TRUE(capturer.CaptureFrame());
721
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200722 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000723
724 // Verify that encoders are configured for simulcast through adapter
725 // (increasing resolution and only configured to send one stream each).
726 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200727 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
728 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000729 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000731 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
732 EXPECT_GT(codec_settings.width, prev_width);
733 prev_width = codec_settings.width;
734 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000735
Niels Möllerff40b142018-04-09 08:49:14 +0200736 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000737
738 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200739 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000740}
741
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200742TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
743 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200744 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000745
Niels Möller4db138e2018-04-19 09:04:13 +0200746 // Set capturer.
747 FakeVideoCapturerWithTaskQueue capturer;
748 EXPECT_EQ(cricket::CS_RUNNING,
749 capturer.Start(capturer.GetSupportedFormats()->front()));
750
Sebastian Jansson84848f22018-11-16 10:40:36 +0100751 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700752 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200753 cricket::VideoSendParameters parameters;
754 parameters.codecs.push_back(GetEngineCodec("H264"));
755 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000756
757 EXPECT_TRUE(
758 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200759 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
760 // Sending one frame will have allocate the encoder.
761 EXPECT_TRUE(capturer.CaptureFrame());
762
763 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000764
Anders Carlsson67537952018-05-03 11:28:29 +0200765 cricket::VideoSendParameters new_parameters;
766 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
767 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200768
769 // Sending one frame will switch encoder.
770 EXPECT_TRUE(capturer.CaptureFrame());
771
Anders Carlsson8a150d92018-05-14 12:40:04 +0200772 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000773}
774
eladalonf1841382017-06-12 01:16:46 -0700775TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000776 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->AddSupportedVideoCodecType("VP8");
778 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779
Sebastian Jansson84848f22018-11-16 10:40:36 +0100780 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700781 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800782 cricket::VideoSendParameters parameters;
783 parameters.codecs.push_back(GetEngineCodec("VP8"));
784 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000785
Peter Boström0c4e06b2015-10-07 12:23:21 +0200786 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000787
Yves Gerey665174f2018-06-19 15:03:05 +0200788 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000789 EXPECT_TRUE(channel->SetSend(true));
790
791 // Send a fake frame, or else the media engine will configure the simulcast
792 // encoder adapter at a low-enough size that it'll only create a single
793 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100794 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200795 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000796 EXPECT_EQ(cricket::CS_RUNNING,
797 capturer.Start(capturer.GetSupportedFormats()->front()));
798 EXPECT_TRUE(capturer.CaptureFrame());
799
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200800 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
801 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000802 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200803 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804
805 channel.reset();
806 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200807 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000808}
809
eladalonf1841382017-06-12 01:16:46 -0700810TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000811 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200812 encoder_factory_->AddSupportedVideoCodecType("VP8");
813 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000814
Sebastian Jansson84848f22018-11-16 10:40:36 +0100815 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700816 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800817 cricket::VideoSendParameters parameters;
818 parameters.codecs.push_back(GetEngineCodec("H264"));
819 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
821 EXPECT_TRUE(
822 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100823
824 // Send a frame of 720p. This should trigger a "real" encoder initialization.
825 cricket::VideoFormat format(
826 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100827 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200828 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100829 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
830 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200831 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
832 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200833 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200835 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
837 channel.reset();
838 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200839 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000840}
841
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200842TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
843 webrtc::test::ScopedFieldTrials override_field_trials_(
844 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200845 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700846
Sebastian Jansson84848f22018-11-16 10:40:36 +0100847 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700848 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200849 cricket::VideoSendParameters parameters;
850 parameters.codecs.push_back(GetEngineCodec("H264"));
851 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700852
Peter Boström0c4e06b2015-10-07 12:23:21 +0200853 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700854 EXPECT_TRUE(
855 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100856
857 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700858 cricket::VideoFormat format(
859 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100860 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200861 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100862 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
863 EXPECT_TRUE(capturer.CaptureFrame());
864
Niels Möller4db138e2018-04-19 09:04:13 +0200865 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200866 ASSERT_EQ(1u, encoder_factory_->encoders().size());
867 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
868 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700869 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200870 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200871 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700872}
873
brandtrffc61182016-11-28 06:02:22 -0800874// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700875// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800876//
877// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700878TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800879 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200880 encoder_factory_->AddSupportedVideoCodecType("VP8");
881
brandtrffc61182016-11-28 06:02:22 -0800882 auto is_flexfec = [](const VideoCodec& codec) {
883 if (codec.name == "flexfec-03")
884 return true;
885 return false;
886 };
887
888 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800889 const std::vector<VideoCodec> codecs_before = engine_.codecs();
890 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
891 codecs_before.end(), is_flexfec));
892
893 // FlexFEC is active with field trial.
894 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800895 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800896 const std::vector<VideoCodec> codecs_after = engine_.codecs();
897 EXPECT_NE(codecs_after.end(),
898 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
899}
900
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200901// Test that codecs are added in the order they are reported from the factory.
902TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
903 encoder_factory_->AddSupportedVideoCodecType("VP8");
904 const char* kFakeCodecName = "FakeCodec";
905 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000906
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200907 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100908 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200909 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
910 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000911}
912
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200913// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800914// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200915TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100916 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
917 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100918
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100919 // Set up external encoder factory with first codec, and initialize engine.
920 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
921
brandtrffc61182016-11-28 06:02:22 -0800922 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800923
924 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100925 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800926 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200927 // The codec itself and RTX should have been added.
928 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100929
930 // Check that both fake codecs are present and that the second fake codec
931 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100932 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
933 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100934 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800935}
936
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200937TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
938 const char* kFakeCodecName = "FakeCodec";
939 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
940
941 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
942 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
943}
944
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200945TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
946 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200947 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200948 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800949 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000950
kwiberg686a8ef2016-02-26 03:00:35 -0800951 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200952 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000953
954 EXPECT_TRUE(
955 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200956 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000957
958 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200959 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200960 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
962 // Remove stream previously added to free the external decoder instance.
963 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200964 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965}
966
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200967// Verifies that we can set up decoders.
968TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000969 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
970 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
971 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
972 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200973 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200974 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000975 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800976 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000977
kwiberg686a8ef2016-02-26 03:00:35 -0800978 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200979 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000980
981 EXPECT_TRUE(
982 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200983 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000984}
985
Jonas Oreland49ac5952018-09-26 16:04:32 +0200986// Tests when GetSources is called with non-existing ssrc, it will return an
987// empty list of RtpSource without crashing.
988TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
989 // Setup an recv stream with |kSsrc|.
990 encoder_factory_->AddSupportedVideoCodecType("VP8");
991 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
992 cricket::VideoRecvParameters parameters;
993 parameters.codecs.push_back(GetEngineCodec("VP8"));
994 std::unique_ptr<VideoMediaChannel> channel(
995 SetRecvParamsWithSupportedCodecs(parameters.codecs));
996
997 EXPECT_TRUE(
998 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
999
1000 // Call GetSources with |kSsrc + 1| which doesn't exist.
1001 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1002 EXPECT_EQ(0u, sources.size());
1003}
1004
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001005TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1006 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1007 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001008 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001009 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001010 std::move(decoder_factory),
1011 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001012 EXPECT_EQ(0u, engine.codecs().size());
1013}
1014
1015TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1016 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001017 webrtc::MockVideoEncoderFactory* encoder_factory =
1018 new webrtc::MockVideoEncoderFactory();
1019 webrtc::MockVideoDecoderFactory* decoder_factory =
1020 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001021 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1022 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001023 WebRtcVideoEngine engine(
1024 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001025 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1026 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1027 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001028 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1029 EXPECT_EQ(0u, engine.codecs().size());
1030 EXPECT_CALL(*encoder_factory, Die());
1031 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001032 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001033}
1034
1035// Test full behavior in the video engine when video codec factories of the new
1036// type are injected supporting the single codec Vp8. Check the returned codecs
1037// from the engine and that we will create a Vp8 encoder and decoder using the
1038// new factories.
1039TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1040 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001041 webrtc::MockVideoEncoderFactory* encoder_factory =
1042 new webrtc::MockVideoEncoderFactory();
1043 webrtc::MockVideoDecoderFactory* decoder_factory =
1044 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001045 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1046 new webrtc::MockVideoBitrateAllocatorFactory();
1047 EXPECT_CALL(*rate_allocator_factory,
1048 CreateVideoBitrateAllocatorProxy(Field(
1049 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1050 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001051 WebRtcVideoEngine engine(
1052 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001053 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1054 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1055 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001056 const webrtc::SdpVideoFormat vp8_format("VP8");
1057 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1058 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1059 .WillRepeatedly(testing::Return(supported_formats));
1060
1061 // Verify the codecs from the engine.
1062 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001063 // Verify default codecs has been added correctly.
1064 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001065 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001066
1067 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001068 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001069 int vp8_associated_payload;
1070 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1071 &vp8_associated_payload));
1072 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1073
1074 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1075
1076 // RTX codec for RED.
1077 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1078 int red_associated_payload;
1079 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1080 &red_associated_payload));
1081 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1082
1083 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1084
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001085 int associated_payload_type;
1086 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1087 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1088 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1089 // Verify default parameters has been added to the VP8 codec.
1090 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1091
1092 // Mock encoder creation. |engine| take ownership of the encoder.
1093 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1094 codec_info.is_hardware_accelerated = false;
1095 codec_info.has_internal_source = false;
1096 const webrtc::SdpVideoFormat format("VP8");
1097 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1098 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001099 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001100 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001101 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001102 .WillOnce(
1103 ::testing::DoAll(::testing::InvokeWithoutArgs(
1104 [&encoder_created]() { encoder_created.Set(); }),
1105 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001106
1107 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001108 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001109 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1110 .WillOnce(testing::Return(decoder));
1111
1112 // Create a call.
1113 webrtc::RtcEventLogNullImpl event_log;
1114 std::unique_ptr<webrtc::Call> call(
1115 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1116
1117 // Create send channel.
1118 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001119 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001120 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001121 cricket::VideoSendParameters send_parameters;
1122 send_parameters.codecs.push_back(engine_codecs.at(0));
1123 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1124 send_channel->OnReadyToSend(true);
1125 EXPECT_TRUE(
1126 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1127 EXPECT_TRUE(send_channel->SetSend(true));
1128
Niels Möller4db138e2018-04-19 09:04:13 +02001129 // Set capturer.
1130 FakeVideoCapturerWithTaskQueue capturer;
1131 EXPECT_EQ(cricket::CS_RUNNING,
1132 capturer.Start(capturer.GetSupportedFormats()->front()));
1133 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1134 // Sending one frame will allocate the encoder.
1135 EXPECT_TRUE(capturer.CaptureFrame());
1136 encoder_created.Wait(kTimeout);
1137
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001138 // Create recv channel.
1139 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001140 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001141 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001142 cricket::VideoRecvParameters recv_parameters;
1143 recv_parameters.codecs.push_back(engine_codecs.at(0));
1144 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1145 EXPECT_TRUE(recv_channel->AddRecvStream(
1146 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1147
1148 // Remove streams previously added to free the encoder and decoder instance.
1149 EXPECT_CALL(*encoder_factory, Die());
1150 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001151 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001152 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1153 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1154}
1155
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001156// Test behavior when decoder factory fails to create a decoder (returns null).
1157TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1158 // |engine| take ownership of the factories.
1159 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001160 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001161 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001162 new webrtc::MockVideoDecoderFactory();
1163 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1164 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001165 WebRtcVideoEngine engine(
1166 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001167 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1168 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1169 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001170 const webrtc::SdpVideoFormat vp8_format("VP8");
1171 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1172 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1173 .WillRepeatedly(testing::Return(supported_formats));
1174
1175 // Decoder creation fails.
1176 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1177 .WillOnce(testing::Return(nullptr));
1178
1179 // Create a call.
1180 webrtc::RtcEventLogNullImpl event_log;
1181 std::unique_ptr<webrtc::Call> call(
1182 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1183
1184 // Create recv channel.
1185 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001186 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001187 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001188 cricket::VideoRecvParameters recv_parameters;
1189 recv_parameters.codecs.push_back(engine.codecs().front());
1190 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1191 EXPECT_TRUE(recv_channel->AddRecvStream(
1192 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1193
1194 // Remove streams previously added to free the encoder and decoder instance.
1195 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1196}
1197
eladalonf1841382017-06-12 01:16:46 -07001198TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001199 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001200 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001201 std::unique_ptr<VideoMediaChannel> channel(
1202 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001203 ASSERT_TRUE(
1204 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1205 cricket::VideoCodec codec = GetEngineCodec("VP8");
1206 cricket::VideoSendParameters parameters;
1207 parameters.codecs.push_back(codec);
1208 channel->OnReadyToSend(true);
1209 channel->SetSend(true);
1210 ASSERT_TRUE(channel->SetSendParameters(parameters));
1211
Tommi85959932018-02-07 19:26:06 +01001212 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001213 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001214 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001215
1216 EXPECT_EQ(cricket::CS_RUNNING,
1217 capturer.Start(capturer.GetSupportedFormats()->front()));
1218 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001219 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001220 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001221 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001222
Niels Möllerff40b142018-04-09 08:49:14 +02001223 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001224 EXPECT_TRUE(capturer.CaptureFrame());
1225 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001226 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001227
1228 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001229 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001230 EXPECT_TRUE(capturer.CaptureFrame());
1231 // Change to screen content, recreate encoder. For the simulcast encoder
1232 // adapter case, this will result in two calls since InitEncode triggers a
1233 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001234 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001235 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001236 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001237
Niels Möllerff40b142018-04-09 08:49:14 +02001238 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001239 EXPECT_TRUE(capturer.CaptureFrame());
1240 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001241 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001242
1243 options.is_screencast.emplace(false);
1244 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001245 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001246 // Change back to regular video content, update encoder. Also change
1247 // a non |is_screencast| option just to verify it doesn't affect recreation.
1248 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001249 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001250 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001251 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001252
1253 // Remove stream previously added to free the external encoder instance.
1254 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001255 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001256}
1257
Niels Möller6557d0c2018-04-11 15:18:34 +02001258class WebRtcVideoChannelBaseTest : public testing::Test {
1259 protected:
1260 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001261 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001262 webrtc::CreateBuiltinVideoDecoderFactory(),
1263 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001264
1265 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001266 // One testcase calls SetUp in a loop, only create call_ once.
1267 if (!call_) {
1268 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1269 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001270 cricket::MediaConfig media_config;
1271 // Disabling cpu overuse detection actually disables quality scaling too; it
1272 // implies DegradationPreference kMaintainResolution. Automatic scaling
1273 // needs to be disabled, otherwise, tests which check the size of received
1274 // frames become flaky.
1275 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001276 channel_.reset(
1277 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1278 call_.get(), media_config, cricket::VideoOptions(),
1279 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001280 channel_->OnReadyToSend(true);
1281 EXPECT_TRUE(channel_.get() != NULL);
1282 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001283 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001284 cricket::VideoRecvParameters parameters;
1285 parameters.codecs = engine_.codecs();
1286 channel_->SetRecvParameters(parameters);
1287 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1288 video_capturer_.reset(CreateFakeVideoCapturer());
1289 cricket::VideoFormat format(640, 480,
1290 cricket::VideoFormat::FpsToInterval(kFramerate),
1291 cricket::FOURCC_I420);
1292 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001293 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001294 }
1295
1296 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1297 return new cricket::FakeVideoCapturerWithTaskQueue();
1298 }
1299
1300 // Utility method to setup an additional stream to send and receive video.
1301 // Used to test send and recv between two streams.
1302 void SetUpSecondStream() {
1303 SetUpSecondStreamWithNoRecv();
1304 // Setup recv for second stream.
1305 EXPECT_TRUE(channel_->AddRecvStream(
1306 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1307 // Make the second renderer available for use by a new stream.
1308 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1309 }
1310 // Setup an additional stream just to send video. Defer add recv stream.
1311 // This is required if you want to test unsignalled recv of video rtp packets.
1312 void SetUpSecondStreamWithNoRecv() {
1313 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001314 EXPECT_TRUE(
1315 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001317 EXPECT_FALSE(
1318 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001319 EXPECT_TRUE(channel_->AddSendStream(
1320 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1321 // We dont add recv for the second stream.
1322
1323 // Setup the receive and renderer for second stream after send.
1324 video_capturer_2_.reset(CreateFakeVideoCapturer());
1325 cricket::VideoFormat format(640, 480,
1326 cricket::VideoFormat::FpsToInterval(kFramerate),
1327 cricket::FOURCC_I420);
1328 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1329
Yves Gerey665174f2018-06-19 15:03:05 +02001330 EXPECT_TRUE(
1331 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001332 }
Yves Gerey665174f2018-06-19 15:03:05 +02001333 virtual void TearDown() { channel_.reset(); }
1334 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001335
1336 bool SetOneCodec(const cricket::VideoCodec& codec) {
1337 cricket::VideoFormat capture_format(
1338 kVideoWidth, kVideoHeight,
1339 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1340
1341 if (video_capturer_) {
1342 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1343 }
1344 if (video_capturer_2_) {
1345 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1346 }
1347
1348 bool sending = channel_->sending();
1349 bool success = SetSend(false);
1350 if (success) {
1351 cricket::VideoSendParameters parameters;
1352 parameters.codecs.push_back(codec);
1353 success = channel_->SetSendParameters(parameters);
1354 }
1355 if (success) {
1356 success = SetSend(sending);
1357 }
1358 return success;
1359 }
Yves Gerey665174f2018-06-19 15:03:05 +02001360 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001361 bool SendFrame() {
1362 if (video_capturer_2_) {
1363 video_capturer_2_->CaptureFrame();
1364 }
1365 return video_capturer_.get() && video_capturer_->CaptureFrame();
1366 }
1367 bool WaitAndSendFrame(int wait_ms) {
1368 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1369 ret &= SendFrame();
1370 return ret;
1371 }
Yves Gerey665174f2018-06-19 15:03:05 +02001372 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001373 int NumRtpBytes(uint32_t ssrc) {
1374 return network_interface_.NumRtpBytes(ssrc);
1375 }
Yves Gerey665174f2018-06-19 15:03:05 +02001376 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001377 int NumRtpPackets(uint32_t ssrc) {
1378 return network_interface_.NumRtpPackets(ssrc);
1379 }
Yves Gerey665174f2018-06-19 15:03:05 +02001380 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001381 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1382 return network_interface_.GetRtpPacket(index);
1383 }
1384 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001385 webrtc::RTPHeader header;
1386 EXPECT_TRUE(ParseRtpPacket(p, &header));
1387 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001388 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001389
Niels Möller6557d0c2018-04-11 15:18:34 +02001390 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001391 webrtc::RTPHeader* header) {
1392 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1393 webrtc::RtpHeaderParser::Create());
1394 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001395 }
1396
1397 // Tests that we can send and receive frames.
1398 void SendAndReceive(const cricket::VideoCodec& codec) {
1399 EXPECT_TRUE(SetOneCodec(codec));
1400 EXPECT_TRUE(SetSend(true));
1401 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1402 EXPECT_EQ(0, renderer_.num_rendered_frames());
1403 EXPECT_TRUE(SendFrame());
1404 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1405 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1406 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1407 }
1408
1409 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001410 int duration_sec,
1411 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001412 EXPECT_TRUE(SetOneCodec(codec));
1413 EXPECT_TRUE(SetSend(true));
1414 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1415 EXPECT_EQ(0, renderer_.num_rendered_frames());
1416 for (int i = 0; i < duration_sec; ++i) {
1417 for (int frame = 1; frame <= fps; ++frame) {
1418 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1419 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1420 }
1421 }
1422 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1423 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1424 }
1425
Niels Möller6557d0c2018-04-11 15:18:34 +02001426 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1427 cricket::VideoMediaInfo info;
1428 EXPECT_TRUE(channel_->GetStats(&info));
1429 return info.senders[i];
1430 }
1431
1432 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1433 cricket::VideoMediaInfo info;
1434 EXPECT_TRUE(channel_->GetStats(&info));
1435 return info.receivers[i];
1436 }
1437
1438 // Two streams one channel tests.
1439
1440 // Tests that we can send and receive frames.
1441 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1442 SetUpSecondStream();
1443 // Test sending and receiving on first stream.
1444 SendAndReceive(codec);
1445 // Test sending and receiving on second stream.
1446 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1447 EXPECT_GT(NumRtpPackets(), 0);
1448 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1449 }
1450
1451 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1452 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001453 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001454 return engine_codec;
1455 }
1456 // This point should never be reached.
1457 ADD_FAILURE() << "Unrecognized codec name: " << name;
1458 return cricket::VideoCodec();
1459 }
1460
1461 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1462
1463 cricket::StreamParams DefaultSendStreamParams() {
1464 return cricket::StreamParams::CreateLegacy(kSsrc);
1465 }
1466
1467 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001468 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001469 WebRtcVideoEngine engine_;
1470 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1471 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1472 std::unique_ptr<WebRtcVideoChannel> channel_;
1473 cricket::FakeNetworkInterface network_interface_;
1474 cricket::FakeVideoRenderer renderer_;
1475
1476 // Used by test cases where 2 streams are run on the same channel.
1477 cricket::FakeVideoRenderer renderer2_;
1478};
1479
1480// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001481TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001482 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001483 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001484 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1485 EXPECT_FALSE(channel_->sending());
1486 EXPECT_TRUE(SetSend(true));
1487 EXPECT_TRUE(channel_->sending());
1488 EXPECT_TRUE(SendFrame());
1489 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1490 EXPECT_TRUE(SetSend(false));
1491 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001492}
Niels Möller6557d0c2018-04-11 15:18:34 +02001493
1494// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001495TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001496 EXPECT_FALSE(channel_->sending());
1497 EXPECT_FALSE(SetSend(true));
1498 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001499}
Niels Möller6557d0c2018-04-11 15:18:34 +02001500
1501// Test that we properly set the send and recv buffer sizes by the time
1502// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001503TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001504 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1505 EXPECT_TRUE(SetSend(true));
1506 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001507 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001508}
1509
Niels Möller6557d0c2018-04-11 15:18:34 +02001510// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001511TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001512 const int kDurationSec = 3;
1513 const int kFps = 10;
1514 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1515
1516 cricket::VideoMediaInfo info;
1517 EXPECT_TRUE(channel_->GetStats(&info));
1518
1519 ASSERT_EQ(1U, info.senders.size());
1520 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1521 // For webrtc, bytes_sent does not include the RTP header length.
1522 EXPECT_GT(info.senders[0].bytes_sent, 0);
1523 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1524 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1525 ASSERT_TRUE(info.senders[0].codec_payload_type);
1526 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1527 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1528 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1529 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1530 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1531 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1532 EXPECT_GT(info.senders[0].framerate_input, 0);
1533 EXPECT_GT(info.senders[0].framerate_sent, 0);
1534
1535 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1536 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1537 info.send_codecs[DefaultCodec().id]);
1538
1539 ASSERT_EQ(1U, info.receivers.size());
1540 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1541 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1542 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1543 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1544 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1545 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1546 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1547 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1548 EXPECT_EQ(0, info.receivers[0].packets_lost);
1549 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1550 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1551 EXPECT_EQ(0, info.receivers[0].firs_sent);
1552 EXPECT_EQ(0, info.receivers[0].plis_sent);
1553 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1554 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1555 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1556 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1557 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1558 EXPECT_GT(info.receivers[0].framerate_output, 0);
1559
1560 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1561 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1562 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001563}
Niels Möller6557d0c2018-04-11 15:18:34 +02001564
1565// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001566TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001567 cricket::FakeVideoRenderer renderer1, renderer2;
1568 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1569 cricket::VideoSendParameters parameters;
1570 parameters.codecs.push_back(DefaultCodec());
1571 parameters.conference_mode = true;
1572 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1573 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001574 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1575 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001576 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1577 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1578 EXPECT_EQ(0, renderer1.num_rendered_frames());
1579 EXPECT_EQ(0, renderer2.num_rendered_frames());
1580 std::vector<uint32_t> ssrcs;
1581 ssrcs.push_back(1);
1582 ssrcs.push_back(2);
1583 network_interface_.SetConferenceMode(true, ssrcs);
1584 EXPECT_TRUE(SendFrame());
1585 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1586 kTimeout);
1587 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1588 kTimeout);
1589
1590 EXPECT_TRUE(channel_->SetSend(false));
1591
1592 cricket::VideoMediaInfo info;
1593 EXPECT_TRUE(channel_->GetStats(&info));
1594 ASSERT_EQ(1U, info.senders.size());
1595 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1596 // For webrtc, bytes_sent does not include the RTP header length.
1597 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1598 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1599 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1600 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1601
1602 ASSERT_EQ(2U, info.receivers.size());
1603 for (size_t i = 0; i < info.receivers.size(); ++i) {
1604 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1605 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1606 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001607 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001608 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1609 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1610 }
srtee0c2eea2017-12-15 17:44:33 +01001611}
Niels Möller6557d0c2018-04-11 15:18:34 +02001612
1613// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001614TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001615 // Normal setup; note that we set the SSRC explicitly to ensure that
1616 // it will come first in the senders map.
1617 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1618 cricket::VideoSendParameters parameters;
1619 parameters.codecs.push_back(DefaultCodec());
1620 parameters.conference_mode = true;
1621 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001622 EXPECT_TRUE(
1623 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001624 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1625 EXPECT_TRUE(SetSend(true));
1626 EXPECT_TRUE(SendFrame());
1627 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1628 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1629
1630 // Add an additional capturer, and hook up a renderer to receive it.
1631 cricket::FakeVideoRenderer renderer2;
1632 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1633 CreateFakeVideoCapturer());
1634 const int kTestWidth = 160;
1635 const int kTestHeight = 120;
1636 cricket::VideoFormat format(kTestWidth, kTestHeight,
1637 cricket::VideoFormat::FpsToInterval(5),
1638 cricket::FOURCC_I420);
1639 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001640 EXPECT_TRUE(
1641 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001642 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001643 EXPECT_TRUE(
1644 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001645 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1646 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001647 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1648 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001649
1650 // Get stats, and make sure they are correct for two senders. We wait until
1651 // the number of expected packets have been sent to avoid races where we
1652 // check stats before it has been updated.
1653 cricket::VideoMediaInfo info;
1654 for (uint32_t i = 0; i < kTimeout; ++i) {
1655 rtc::Thread::Current()->ProcessMessages(1);
1656 EXPECT_TRUE(channel_->GetStats(&info));
1657 ASSERT_EQ(2U, info.senders.size());
1658 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1659 NumRtpPackets()) {
1660 // Stats have been updated for both sent frames, expectations can be
1661 // checked now.
1662 break;
1663 }
1664 }
1665 EXPECT_EQ(NumRtpPackets(),
1666 info.senders[0].packets_sent + info.senders[1].packets_sent)
1667 << "Timed out while waiting for packet counts for all sent packets.";
1668 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1669 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1670 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1671 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1672 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1673 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1674 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1675 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1676 // The capturer must be unregistered here as it runs out of it's scope next.
1677 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001678}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001679
Niels Möller6557d0c2018-04-11 15:18:34 +02001680// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001681TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001682 cricket::VideoSendParameters parameters;
1683 parameters.codecs.push_back(DefaultCodec());
1684 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1685 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1686 parameters.max_bandwidth_bps = 128 * 1024;
1687 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001688}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001689
Niels Möller6557d0c2018-04-11 15:18:34 +02001690// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001691TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001692 EXPECT_TRUE(SetDefaultCodec());
1693 EXPECT_TRUE(SetSend(true));
1694 EXPECT_TRUE(SendFrame());
1695 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001696 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001697 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001698 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1699 EXPECT_EQ(kSsrc, header.ssrc);
1700
Niels Möller6557d0c2018-04-11 15:18:34 +02001701 // Packets are being paced out, so these can mismatch between the first and
1702 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001703 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1704 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_EQ(1, NumSentSsrcs());
1706 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1707 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001708}
Niels Möller6557d0c2018-04-11 15:18:34 +02001709
1710// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001711TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 // Remove stream added in Setup.
1713 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1714 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001715 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001716 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1717 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001718 EXPECT_TRUE(SetSend(true));
1719 EXPECT_TRUE(WaitAndSendFrame(0));
1720 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001721 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001722 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001723 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1724 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 // Packets are being paced out, so these can mismatch between the first and
1726 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001727 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1728 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001729 EXPECT_EQ(1, NumSentSsrcs());
1730 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1731 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001732}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001733
Niels Möller6557d0c2018-04-11 15:18:34 +02001734// Test that we can set the default video renderer before and after
1735// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001736TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001737 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1738 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001739
1740 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1741 rtc::SetBE32(packet1.data() + 8, kSsrc);
1742 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1743 EXPECT_TRUE(SetDefaultCodec());
1744 EXPECT_TRUE(SetSend(true));
1745 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001746 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001747 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1748 EXPECT_TRUE(SendFrame());
1749 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001750}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001751
Niels Möller6557d0c2018-04-11 15:18:34 +02001752// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001753TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001754 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1755 EXPECT_TRUE(SetSend(true));
1756 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1757 EXPECT_TRUE(SendFrame());
1758 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1759 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001760 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001761 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001762 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1763 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001764 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1765 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001766
1767 // Remove the send stream that was added during Setup.
1768 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1769 int rtp_packets = NumRtpPackets();
1770
Niels Möller6557d0c2018-04-11 15:18:34 +02001771 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001772 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1773 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001774 EXPECT_EQ(rtp_packets, NumRtpPackets());
1775 // Wait 30ms to guarantee the engine does not drop the frame.
1776 EXPECT_TRUE(WaitAndSendFrame(30));
1777 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1778
1779 last_packet = NumRtpPackets() - 1;
1780 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001781 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1782 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001783}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001784
Niels Möller6557d0c2018-04-11 15:18:34 +02001785// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001786TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001787 cricket::FakeVideoRenderer renderer1, renderer2;
1788 EXPECT_TRUE(SetDefaultCodec());
1789 cricket::VideoSendParameters parameters;
1790 parameters.codecs.push_back(DefaultCodec());
1791 parameters.conference_mode = true;
1792 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1793 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001794 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1795 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001796 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1797 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1798 EXPECT_EQ(0, renderer1.num_rendered_frames());
1799 EXPECT_EQ(0, renderer2.num_rendered_frames());
1800 std::vector<uint32_t> ssrcs;
1801 ssrcs.push_back(1);
1802 ssrcs.push_back(2);
1803 network_interface_.SetConferenceMode(true, ssrcs);
1804 EXPECT_TRUE(SendFrame());
1805 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1806 kTimeout);
1807 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1808 kTimeout);
1809
1810 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1811 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1812 EXPECT_EQ(kVideoWidth, renderer1.width());
1813 EXPECT_EQ(kVideoHeight, renderer1.height());
1814 EXPECT_EQ(kVideoWidth, renderer2.width());
1815 EXPECT_EQ(kVideoHeight, renderer2.height());
1816 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1817 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001818}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001819
Niels Möller6557d0c2018-04-11 15:18:34 +02001820// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001821TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001822 using cricket::VideoCodec;
1823 using cricket::VideoOptions;
1824 using cricket::VideoFormat;
1825 using cricket::FOURCC_I420;
1826
1827 VideoCodec codec = DefaultCodec();
1828 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1829 EXPECT_TRUE(SetOneCodec(codec));
1830 EXPECT_TRUE(SetSend(true));
1831 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1832 EXPECT_EQ(0, renderer_.num_rendered_frames());
1833 EXPECT_TRUE(SendFrame());
1834 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1835 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1836 CreateFakeVideoCapturer());
1837
1838 // TODO(nisse): This testcase fails if we don't configure
1839 // screencast. It's unclear why, I see nothing obvious in this
1840 // test which is related to screencast logic.
1841 VideoOptions video_options;
1842 video_options.is_screencast = true;
1843 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1844
1845 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1846 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1847 // All capturers start generating frames with the same timestamp. ViE does
1848 // not allow the same timestamp to be used. Capture one frame before
1849 // associating the capturer with the channel.
1850 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1851
1852 int captured_frames = 1;
1853 for (int iterations = 0; iterations < 2; ++iterations) {
1854 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1855 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1856 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1857 ++captured_frames;
1858 // Wait until frame of right size is captured.
1859 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001860 format.width == renderer_.width() &&
1861 format.height == renderer_.height() &&
1862 !renderer_.black_frame(),
1863 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001864 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1865 EXPECT_EQ(format.width, renderer_.width());
1866 EXPECT_EQ(format.height, renderer_.height());
1867 captured_frames = renderer_.num_rendered_frames() + 1;
1868 EXPECT_FALSE(renderer_.black_frame());
1869 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1870 // Make sure a black frame is generated within the specified timeout.
1871 // The black frame should be the resolution of the previous frame to
1872 // prevent expensive encoder reconfigurations.
1873 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001874 format.width == renderer_.width() &&
1875 format.height == renderer_.height() &&
1876 renderer_.black_frame(),
1877 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001878 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1879 EXPECT_EQ(format.width, renderer_.width());
1880 EXPECT_EQ(format.height, renderer_.height());
1881 EXPECT_TRUE(renderer_.black_frame());
1882
1883 // The black frame has the same timestamp as the next frame since it's
1884 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1885 // not render a frame with the same timestamp so capture another frame
1886 // with the frame capturer to increment the next frame's timestamp.
1887 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1888 }
srtee0c2eea2017-12-15 17:44:33 +01001889}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001890
Niels Möller6557d0c2018-04-11 15:18:34 +02001891// Tests that if SetVideoSend is called with a NULL capturer after the
1892// capturer was already removed, the application doesn't crash (and no black
1893// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001894TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001895 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1896 EXPECT_TRUE(SetSend(true));
1897 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1898 EXPECT_EQ(0, renderer_.num_rendered_frames());
1899 EXPECT_TRUE(SendFrame());
1900 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1901 // Wait for one frame so they don't get dropped because we send frames too
1902 // tightly.
1903 rtc::Thread::Current()->ProcessMessages(30);
1904 // Remove the capturer.
1905 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1906
1907 // No capturer was added, so this SetVideoSend shouldn't do anything.
1908 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1909 rtc::Thread::Current()->ProcessMessages(300);
1910 // Verify no more frames were sent.
1911 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001912}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001913
Niels Möller6557d0c2018-04-11 15:18:34 +02001914// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001915TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1917 // interval time to avoid that.
1918 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1919 // interval time to avoid that.
1920 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001921 EXPECT_TRUE(
1922 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1924 cricket::VideoFormat capture_format(
1925 kVideoWidth, kVideoHeight,
1926 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1927 // Set up additional stream 1.
1928 cricket::FakeVideoRenderer renderer1;
1929 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001930 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001931 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001932 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001933 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1934 CreateFakeVideoCapturer());
1935 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1936 // Set up additional stream 2.
1937 cricket::FakeVideoRenderer renderer2;
1938 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001939 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001940 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001941 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001942 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1943 CreateFakeVideoCapturer());
1944 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1945 // State for all the streams.
1946 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1947 // A limitation in the lmi implementation requires that SetVideoSend() is
1948 // called after SetOneCodec().
1949 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1950 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1951 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1952 EXPECT_TRUE(SetSend(true));
1953 // Test capturer associated with engine.
1954 const int kTestWidth = 160;
1955 const int kTestHeight = 120;
1956 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001957 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1958 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001959 // Capture a frame with additional capturer2, frames should be received
1960 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001961 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1962 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001963 // Successfully remove the capturer.
1964 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1965 // The capturers must be unregistered here as it runs out of it's scope
1966 // next.
1967 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1968 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001969}
Niels Möller6557d0c2018-04-11 15:18:34 +02001970
1971// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001972TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 // Remove the send stream that was added during Setup.
1974 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1975
1976 cricket::StreamParams empty;
1977 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001978 EXPECT_TRUE(
1979 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001980}
Niels Möller6557d0c2018-04-11 15:18:34 +02001981
1982// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001983TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001984 // Remove stream added in Setup. I.e. remove stream corresponding to default
1985 // channel.
1986 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001987 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1989 EXPECT_TRUE(channel_->AddSendStream(
1990 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1991 }
1992 // Delete one of the non default channel streams, let the destructor delete
1993 // the remaining ones.
1994 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1995 // Stream should already be deleted.
1996 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001997}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001998
eladalonf1841382017-06-12 01:16:46 -07001999TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002000 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002001}
2002
eladalonf1841382017-06-12 01:16:46 -07002003TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002004 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002005}
2006
eladalonf1841382017-06-12 01:16:46 -07002007TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002008 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002009}
2010
eladalonf1841382017-06-12 01:16:46 -07002011TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002012 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2013 // bitrates. This currently happens at <250k, and two streams sharing 300k
2014 // initially will use QVGA instead of VGA.
2015 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2016 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002017 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002018 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002020}
2021
eladalonf1841382017-06-12 01:16:46 -07002022class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002023 public:
eladalonf1841382017-06-12 01:16:46 -07002024 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2025 explicit WebRtcVideoChannelTest(const char* field_trials)
2026 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002027 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002028 encoder_factory_->AddSupportedVideoCodecType("VP8");
2029 encoder_factory_->AddSupportedVideoCodecType("VP9");
2030#if defined(WEBRTC_USE_H264)
2031 encoder_factory_->AddSupportedVideoCodecType("H264");
2032#endif
2033
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002034 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002035 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2036 GetMediaConfig(), VideoOptions(),
2037 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002038 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002039 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002040 send_parameters_.codecs = engine_.codecs();
2041 recv_parameters_.codecs = engine_.codecs();
2042 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002043 }
2044
2045 protected:
2046 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002047 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002048 }
2049
2050 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002051 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002052 EXPECT_TRUE(channel_->AddSendStream(sp));
2053 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002054 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002055 EXPECT_EQ(num_streams + 1, streams.size());
2056 return streams[streams.size() - 1];
2057 }
2058
2059 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002060 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002061 }
2062
2063 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002064 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002065 }
2066
2067 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002068 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002069 EXPECT_TRUE(channel_->AddRecvStream(sp));
2070 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002071 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002072 EXPECT_EQ(num_streams + 1, streams.size());
2073 return streams[streams.size() - 1];
2074 }
2075
pbos@webrtc.org00873182014-11-25 14:03:34 +00002076 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2077 int expected_min_bitrate_bps,
2078 const char* start_bitrate_kbps,
2079 int expected_start_bitrate_bps,
2080 const char* max_bitrate_kbps,
2081 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002082 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2083 expected_start_bitrate_bps,
2084 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002085 auto& codecs = send_parameters_.codecs;
2086 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002087 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002088 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2089 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2090 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002091 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002092 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002093
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002094 void ExpectSetBitrateParameters(int min_bitrate_bps,
2095 int start_bitrate_bps,
2096 int max_bitrate_bps) {
2097 EXPECT_CALL(
2098 *fake_call_->GetMockTransportControllerSend(),
2099 SetSdpBitrateParameters(AllOf(
2100 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2101 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2102 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2103 }
2104
2105 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2106 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2107 SetSdpBitrateParameters(Field(
2108 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002109 }
2110
Johannes Kron9190b822018-10-29 11:22:05 +01002111 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2112 // For a caller, the answer will be applied in set remote description
2113 // where SetSendParameters() is called.
2114 EXPECT_TRUE(
2115 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2116 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2117 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2118 const webrtc::VideoSendStream::Config& config =
2119 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2120 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2121 }
2122
2123 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2124 // For a callee, the answer will be applied in set local description
2125 // where SetExtmapAllowMixed() and AddSendStream() are called.
2126 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2127 EXPECT_TRUE(
2128 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2129 const webrtc::VideoSendStream::Config& config =
2130 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2131 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2132 }
2133
isheriff6f8d6862016-05-26 11:24:55 -07002134 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002135 // Enable extension.
2136 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002137 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002138 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002139 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002140 FakeVideoSendStream* send_stream =
2141 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2142
2143 // Verify the send extension id.
2144 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2145 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002146 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002147 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002148 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002149 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2150 // receivers.
2151 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2152 ->GetConfig()
2153 .rtp.extensions.empty());
2154
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002155 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002156 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002157 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2158 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002159 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2160
2161 // Verify that adding receive RTP header extensions adds them for existing
2162 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002163 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002164 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002165 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2166 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002167 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002168 }
2169
isheriff6f8d6862016-05-26 11:24:55 -07002170 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002171 // Enable extension.
2172 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002173 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002174 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002175 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002176
2177 FakeVideoReceiveStream* recv_stream =
2178 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2179
2180 // Verify the recv extension id.
2181 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2182 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002183 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002184 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002185 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002186
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002187 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2188 // senders.
2189 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2190 ->GetConfig()
2191 .rtp.extensions.empty());
2192
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002193 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002194 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002195 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2196 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002197 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2198
2199 // Verify that adding receive RTP header extensions adds them for existing
2200 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002201 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002202 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002203 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2204 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002205 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002206 }
2207
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002208 void TestExtensionFilter(const std::vector<std::string>& extensions,
2209 const std::string& expected_extension) {
2210 cricket::VideoSendParameters parameters = send_parameters_;
2211 int expected_id = -1;
2212 int id = 1;
2213 for (const std::string& extension : extensions) {
2214 if (extension == expected_extension)
2215 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002216 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002217 }
2218 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2219 FakeVideoSendStream* send_stream =
2220 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2221
2222 // Verify that only one of them has been set, and that it is the one with
2223 // highest priority (transport sequence number).
2224 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2225 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2226 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002227 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002228 }
2229
asapersson3c81a1a2017-06-14 05:52:21 -07002230 void TestDegradationPreference(bool resolution_scaling_enabled,
2231 bool fps_scaling_enabled);
2232
Erik Språngefbde372015-04-29 16:21:28 +02002233 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002234 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002235 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2236 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002237
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002238 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002239 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002240 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002241 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002242 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002243 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002244 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002245 // Options only take effect on the next frame.
2246 EXPECT_TRUE(capturer->CaptureFrame());
2247
Erik Språng143cec12015-04-28 10:01:41 +02002248 return fake_call_->GetVideoSendStreams().back();
2249 }
2250
Peter Boström2feafdb2015-09-09 14:32:14 +02002251 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2252 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002253 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002254 std::vector<uint32_t> ssrcs;
2255 std::vector<uint32_t> rtx_ssrcs;
2256 uint32_t num_streams = enabled ? 3 : 1;
2257 for (uint32_t i = 0; i < num_streams; ++i) {
2258 uint32_t ssrc = last_ssrc_ + i;
2259 ssrcs.push_back(ssrc);
2260 if (with_rtx) {
2261 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2262 }
Erik Språng143cec12015-04-28 10:01:41 +02002263 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002264 if (with_rtx) {
2265 return AddSendStream(
2266 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2267 }
2268 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002269 }
2270
perkjfa10b552016-10-02 23:45:26 -07002271 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002272 std::vector<FakeVideoSendStream*> streams =
2273 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002274 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002275 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002276 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002277 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002278 }
2279
perkjfa10b552016-10-02 23:45:26 -07002280 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002281 int stream_max,
2282 int expected_encoder_bitrate) {
2283 VideoSendParameters limited_send_params = send_parameters_;
2284 limited_send_params.max_bandwidth_bps = global_max;
2285 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002286 webrtc::RtpParameters parameters =
2287 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002288 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002289 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002290 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002291 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002292 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002293 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002294 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002295 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002296 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002297 }
2298
Åsa Persson55659812018-06-18 17:51:32 +02002299 // Values from kSimulcastConfigs in simulcast.cc.
2300 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2301 std::vector<webrtc::VideoStream> layers(3);
2302 layers[0].min_bitrate_bps = 30000;
2303 layers[0].target_bitrate_bps = 150000;
2304 layers[0].max_bitrate_bps = 200000;
2305 layers[1].min_bitrate_bps = 150000;
2306 layers[1].target_bitrate_bps = 500000;
2307 layers[1].max_bitrate_bps = 700000;
2308 layers[2].min_bitrate_bps = 600000;
2309 layers[2].target_bitrate_bps = 2500000;
2310 layers[2].max_bitrate_bps = 2500000;
2311 return layers;
2312 }
2313
kwiberg686a8ef2016-02-26 03:00:35 -08002314 std::unique_ptr<FakeCall> fake_call_;
2315 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002316 cricket::VideoSendParameters send_parameters_;
2317 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002318 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002319};
2320
eladalonf1841382017-06-12 01:16:46 -07002321TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002322 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002323 const std::string kSyncLabel = "AvSyncLabel";
2324
2325 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002326 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002327 EXPECT_TRUE(channel_->AddRecvStream(sp));
2328
Mirko Bonadeif859e552018-05-30 15:31:29 +02002329 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002330 EXPECT_EQ(kSyncLabel,
2331 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2332 << "SyncGroup should be set based on sync_label";
2333}
2334
eladalonf1841382017-06-12 01:16:46 -07002335TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002336 cricket::VideoSendParameters parameters;
2337 parameters.codecs = engine_.codecs();
2338 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002339 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002340 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002341 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002342
2343 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002344 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2345 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002346 FakeVideoSendStream* send_stream = AddSendStream(
2347 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2348
2349 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2350 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2351 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2352
2353 // Receiver side.
2354 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2355 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002356 EXPECT_FALSE(
2357 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002358 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002359 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002360 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002361 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002362 << "RTX should be mapped for the RED payload type";
2363
brandtr14742122017-01-27 04:53:07 -08002364 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002365}
2366
eladalonf1841382017-06-12 01:16:46 -07002367TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002368 // Setup one channel with an associated RTX stream.
2369 cricket::StreamParams params =
2370 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2371 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2372 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002373 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002374
2375 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2376 << "RTX should be mapped for all decoders/payload types.";
2377 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002378 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002379 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002380}
2381
eladalonf1841382017-06-12 01:16:46 -07002382TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002383 // Setup one channel without an associated RTX stream.
2384 cricket::StreamParams params =
2385 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2386 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002387 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002388}
2389
Johannes Kron9190b822018-10-29 11:22:05 +01002390// Test propagation of extmap allow mixed setting.
2391TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2392 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2393}
2394TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2395 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2396}
2397TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2398 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2399}
2400TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2401 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2402}
2403
eladalonf1841382017-06-12 01:16:46 -07002404TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002405 FakeVideoSendStream* send_stream =
2406 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2407 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2408
2409 FakeVideoReceiveStream* recv_stream =
2410 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2411 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002412}
2413
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002414// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002415TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002416 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002417}
isheriff6f8d6862016-05-26 11:24:55 -07002418
eladalonf1841382017-06-12 01:16:46 -07002419TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002420 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002421}
2422
2423// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002424TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002425 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002426}
isheriff6f8d6862016-05-26 11:24:55 -07002427
eladalonf1841382017-06-12 01:16:46 -07002428TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002429 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002430}
2431
eladalonf1841382017-06-12 01:16:46 -07002432TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002433 // Enable three redundant extensions.
2434 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002435 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2436 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2437 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2438 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002439}
2440
eladalonf1841382017-06-12 01:16:46 -07002441TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002442 // Enable two redundant extensions.
2443 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002444 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2445 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2446 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002447}
2448
stefanc1aeaf02015-10-15 07:26:07 -07002449// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002450TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002451 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002452}
eladalonf1841382017-06-12 01:16:46 -07002453TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002454 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002455}
2456
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002457// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002458TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002459 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002460}
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002462 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002463}
2464
eladalonf1841382017-06-12 01:16:46 -07002465TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002466 const int kAbsSendTimeId = 1;
2467 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002468 send_parameters_.extensions.push_back(
2469 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2470 send_parameters_.extensions.push_back(
2471 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002472
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002473 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002474 FakeVideoSendStream* send_stream =
2475 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2476
2477 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002478 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002479
2480 // Setting the same extensions (even if in different order) shouldn't
2481 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002482 std::reverse(send_parameters_.extensions.begin(),
2483 send_parameters_.extensions.end());
2484 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002485
2486 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2487
2488 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002489 send_parameters_.extensions.resize(1);
2490 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002491
2492 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2493}
2494
eladalonf1841382017-06-12 01:16:46 -07002495TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002496 const int kTOffsetId = 1;
2497 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002498 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002499 recv_parameters_.extensions.push_back(
2500 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2501 recv_parameters_.extensions.push_back(
2502 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2503 recv_parameters_.extensions.push_back(
2504 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002505
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002506 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002507 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002508 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2509
2510 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002511 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002512
2513 // Setting the same extensions (even if in different order) shouldn't
2514 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002515 std::reverse(recv_parameters_.extensions.begin(),
2516 recv_parameters_.extensions.end());
2517 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002518
2519 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2520
2521 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002522 recv_parameters_.extensions.resize(1);
2523 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002524
2525 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2526}
2527
eladalonf1841382017-06-12 01:16:46 -07002528TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002529 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002530 const int kUnsupportedId = 1;
2531 const int kTOffsetId = 2;
2532
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002533 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002534 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002535 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002536 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002537 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002538 FakeVideoSendStream* send_stream =
2539 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2540
2541 // Only timestamp offset extension is set to send stream,
2542 // unsupported rtp extension is ignored.
2543 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002544 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2545 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002546}
2547
eladalonf1841382017-06-12 01:16:46 -07002548TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002549 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002550 const int kUnsupportedId = 1;
2551 const int kTOffsetId = 2;
2552
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002553 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002554 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002555 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002556 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002557 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002558 FakeVideoReceiveStream* recv_stream =
2559 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2560
2561 // Only timestamp offset extension is set to receive stream,
2562 // unsupported rtp extension is ignored.
2563 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002564 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2565 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002566}
2567
eladalonf1841382017-06-12 01:16:46 -07002568TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002569 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002570 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002571 send_parameters_.extensions.push_back(
2572 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002573 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002574 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2575 }
2576}
2577
eladalonf1841382017-06-12 01:16:46 -07002578TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002579 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002580 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002581 recv_parameters_.extensions.push_back(
2582 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002583 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002584 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2585 }
2586}
2587
eladalonf1841382017-06-12 01:16:46 -07002588TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002589 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002590 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002591 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002593 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002594 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002595
2596 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002597 send_parameters_.extensions.clear();
2598 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002599 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002600 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2601 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002602}
2603
eladalonf1841382017-06-12 01:16:46 -07002604TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002605 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002606 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002607 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002608 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002609 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002610 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002611
2612 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 recv_parameters_.extensions.clear();
2614 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002615 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002616 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2617 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002618}
2619
eladalonf1841382017-06-12 01:16:46 -07002620TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002621 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002622 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002623}
2624
eladalonf1841382017-06-12 01:16:46 -07002625TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002626 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002627 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002628}
2629
eladalonf1841382017-06-12 01:16:46 -07002630TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002631 FakeVideoReceiveStream* stream = AddRecvStream();
2632 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002633}
2634
eladalonf1841382017-06-12 01:16:46 -07002635TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002636 FakeVideoReceiveStream* stream = AddRecvStream();
2637 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2638}
2639
eladalonf1841382017-06-12 01:16:46 -07002640TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002641 FakeVideoReceiveStream* stream = AddRecvStream();
2642 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2643
Peter Boström126c03e2015-05-11 12:48:12 +02002644 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002646 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002647 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2648 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002649 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002650 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2651
2652 // Verify that REMB is turned on when setting default codecs since the
2653 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002654 parameters.codecs = engine_.codecs();
2655 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002656 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002657 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002658}
2659
eladalonf1841382017-06-12 01:16:46 -07002660TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002661 FakeVideoReceiveStream* stream = AddRecvStream();
2662 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2663
2664 // Verify that transport cc feedback is turned off when send(!) codecs without
2665 // transport cc feedback are set.
2666 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002667 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002668 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2669 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2670 stream = fake_call_->GetVideoReceiveStreams()[0];
2671 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2672
2673 // Verify that transport cc feedback is turned on when setting default codecs
2674 // since the default codecs have transport cc feedback enabled.
2675 parameters.codecs = engine_.codecs();
2676 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2677 stream = fake_call_->GetVideoReceiveStreams()[0];
2678 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2679}
2680
eladalonf1841382017-06-12 01:16:46 -07002681TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002682 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002683 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2684
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002685 cricket::VideoSendParameters parameters;
2686 parameters.codecs = engine_.codecs();
2687 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002688 EXPECT_TRUE(channel_->SetSend(true));
2689
2690 // Send side.
2691 FakeVideoSendStream* send_stream =
2692 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2693 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2694
2695 // Receiver side.
2696 FakeVideoReceiveStream* recv_stream =
2697 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2698 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2699
2700 // Nack history size should match between sender and receiver.
2701 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2702 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002703}
2704
eladalonf1841382017-06-12 01:16:46 -07002705TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002706 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002707 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002708
2709 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2710 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2711
2712 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002713 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002714 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002715 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2716 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002717 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2718 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2719 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002720 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2721
Peter Boström67c9df72015-05-11 14:34:58 +02002722 // Verify that NACK is turned on when setting default codecs since the
2723 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002724 parameters.codecs = engine_.codecs();
2725 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002726 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2727 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2728 send_stream = fake_call_->GetVideoSendStreams()[0];
2729 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002730}
2731
Peter Boströme7ba0862016-03-12 00:02:28 +01002732// This test verifies that new frame sizes reconfigures encoders even though not
2733// (yet) sending. The purpose of this is to permit encoding as quickly as
2734// possible once we start sending. Likely the frames being input are from the
2735// same source that will be sent later, which just means that we're ready
2736// earlier.
eladalonf1841382017-06-12 01:16:46 -07002737TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002738 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002739 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002740 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2741 channel_->SetSend(false);
2742
2743 FakeVideoSendStream* stream = AddSendStream();
2744
perkjfa10b552016-10-02 23:45:26 -07002745 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002746 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002747 EXPECT_EQ(0u, streams[0].width);
2748 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002749
Tommi85959932018-02-07 19:26:06 +01002750 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002751 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002752 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2753 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002754 EXPECT_TRUE(capturer.CaptureFrame());
2755
2756 // Frame entered, should be reconfigured to new dimensions.
2757 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002758 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2759 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2760 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002761
Niels Möllerff40b142018-04-09 08:49:14 +02002762 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002763}
2764
eladalonf1841382017-06-12 01:16:46 -07002765TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002766 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002767 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002768 cricket::VideoSendParameters parameters;
2769 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002770 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002771 AddSendStream();
2772
Tommi85959932018-02-07 19:26:06 +01002773 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002774 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002775 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002776 EXPECT_TRUE(
2777 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002778 cricket::VideoFormat capture_format_hd =
2779 capturer.GetSupportedFormats()->front();
2780 EXPECT_EQ(1280, capture_format_hd.width);
2781 EXPECT_EQ(720, capture_format_hd.height);
2782 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2783
2784 EXPECT_TRUE(channel_->SetSend(true));
2785
2786 EXPECT_TRUE(capturer.CaptureFrame());
2787 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2788 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2789
2790 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2791
2792 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002793 webrtc::VideoEncoderConfig encoder_config =
2794 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002795 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002796 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002797 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002798 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2799 streams.front().width);
2800 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2801 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002802 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2803 << "Non-screenshare shouldn't use min-transmit bitrate.";
2804
Niels Möllerff40b142018-04-09 08:49:14 +02002805 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002806 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002807 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002808 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002809 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002810 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002811 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002812 // Send stream recreated after option change.
2813 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2814 send_stream = fake_call_->GetVideoSendStreams().front();
2815 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002816
2817 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002818 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002819 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002820 encoder_config.content_type);
2821 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2822 encoder_config.min_transmit_bitrate_bps);
2823
perkjfa10b552016-10-02 23:45:26 -07002824 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002825 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2826 streams.front().width);
2827 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2828 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002829 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002830 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002831}
2832
eladalonf1841382017-06-12 01:16:46 -07002833TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002834 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002835 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002836 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002837 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002838
2839 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002840 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002841 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002842 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002843 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002844 cricket::VideoFormat capture_format_hd =
2845 capturer.GetSupportedFormats()->front();
2846 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2847
2848 EXPECT_TRUE(channel_->SetSend(true));
2849
2850 EXPECT_TRUE(capturer.CaptureFrame());
2851 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2852 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2853
perkj26091b12016-09-01 01:17:40 -07002854 webrtc::VideoEncoderConfig encoder_config =
2855 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002856
2857 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002858 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002859 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002860 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002861
2862 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2863 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002864 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002865 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002866 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002867
Niels Möllerff40b142018-04-09 08:49:14 +02002868 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002869}
2870
eladalonf1841382017-06-12 01:16:46 -07002871TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002872 FakeVideoSendStream* stream = AddSendStream();
2873 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2874}
2875
eladalonf1841382017-06-12 01:16:46 -07002876TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002877 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002878 media_config.video.suspend_below_min_bitrate = true;
2879
Sebastian Jansson84848f22018-11-16 10:40:36 +01002880 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002881 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002882 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002883
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002884 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002885
2886 FakeVideoSendStream* stream = AddSendStream();
2887 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2888
nisse0db023a2016-03-01 04:29:59 -08002889 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002890 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002891 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002892 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002893
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002894 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002895
nisse0db023a2016-03-01 04:29:59 -08002896 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002897 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2898}
2899
eladalonf1841382017-06-12 01:16:46 -07002900TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002901 FakeVideoSendStream* stream = AddSendStream();
2902 webrtc::VideoCodecVP8 vp8_settings;
2903 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2904 EXPECT_TRUE(vp8_settings.denoisingOn);
2905}
2906
eladalonf1841382017-06-12 01:16:46 -07002907TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002908 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002909 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002910 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002911
Peter Boström2feafdb2015-09-09 14:32:14 +02002912 // Single-stream settings should apply with RTX as well (verifies that we
2913 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2914 // both RTX and regular SSRCs).
2915 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002916
Tommi85959932018-02-07 19:26:06 +01002917 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002918 EXPECT_EQ(cricket::CS_RUNNING,
2919 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002920 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002921 channel_->SetSend(true);
2922
2923 EXPECT_TRUE(capturer.CaptureFrame());
2924
pbos4cba4eb2015-10-26 11:18:18 -07002925 webrtc::VideoCodecVP8 vp8_settings;
2926 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2927 EXPECT_TRUE(vp8_settings.denoisingOn)
2928 << "VP8 denoising should be on by default.";
2929
nisse05103312016-03-16 02:22:50 -07002930 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002931
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002932 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2933 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002934 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2935 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002936
nisse05103312016-03-16 02:22:50 -07002937 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002938
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002939 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2940 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002941 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2942 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2943
Niels Möllerff40b142018-04-09 08:49:14 +02002944 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002945 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002946 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002947 channel_->SetSend(true);
2948 EXPECT_TRUE(capturer.CaptureFrame());
2949
Mirko Bonadeif859e552018-05-30 15:31:29 +02002950 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002951 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2952 // Autmatic resize off when using simulcast.
2953 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2954 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2955
2956 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002957 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002958 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002959 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002960
nisse05103312016-03-16 02:22:50 -07002961 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002962
Mirko Bonadeif859e552018-05-30 15:31:29 +02002963 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002964 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2965 EXPECT_FALSE(vp8_settings.denoisingOn);
2966 // Resizing and frame dropping always off for screen sharing.
2967 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2968 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2969
nisse05103312016-03-16 02:22:50 -07002970 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002971
2972 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2973 EXPECT_FALSE(vp8_settings.denoisingOn);
2974 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2975 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2976
Niels Möllerff40b142018-04-09 08:49:14 +02002977 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002978}
2979
deadbeef119760a2016-04-04 11:43:27 -07002980// Test that setting the same options doesn't result in the encoder being
2981// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002982TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002983 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002984 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002985
perkjfa10b552016-10-02 23:45:26 -07002986 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002987 EXPECT_EQ(cricket::CS_RUNNING,
2988 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002989 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002990 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002991 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2992 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2993
Niels Möllerff40b142018-04-09 08:49:14 +02002994 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2995 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002996 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002997 // Expect 1 reconfigurations at this point from the initial configuration.
2998 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002999
3000 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02003001 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07003002 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3003
3004 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003005 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003006 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003007 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3008
Niels Möllerff40b142018-04-09 08:49:14 +02003009 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003010}
3011
eladalonf1841382017-06-12 01:16:46 -07003012class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003013 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003014 Vp9SettingsTest() : Vp9SettingsTest("") {}
3015 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003016 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003017 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003018 }
3019 virtual ~Vp9SettingsTest() {}
3020
3021 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003022 void TearDown() override {
3023 // Remove references to encoder_factory_ since this will be destroyed
3024 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003025 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003026 }
Erik Språng143cec12015-04-28 10:01:41 +02003027};
3028
3029TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003030 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003031 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003032 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003033
Peter Boström2feafdb2015-09-09 14:32:14 +02003034 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003035
Tommi85959932018-02-07 19:26:06 +01003036 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003037 EXPECT_EQ(cricket::CS_RUNNING,
3038 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003039 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003040 channel_->SetSend(true);
3041
3042 EXPECT_TRUE(capturer.CaptureFrame());
3043
pbos4cba4eb2015-10-26 11:18:18 -07003044 webrtc::VideoCodecVP9 vp9_settings;
3045 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003046 EXPECT_TRUE(vp9_settings.denoisingOn)
3047 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003048
nisse05103312016-03-16 02:22:50 -07003049 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003050
Erik Språng143cec12015-04-28 10:01:41 +02003051 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3052 EXPECT_FALSE(vp9_settings.denoisingOn);
3053 // Frame dropping always on for real time video.
3054 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3055
nisse05103312016-03-16 02:22:50 -07003056 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003057
3058 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3059 EXPECT_TRUE(vp9_settings.denoisingOn);
3060 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3061
3062 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003063 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003064 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003065 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003066
nisse05103312016-03-16 02:22:50 -07003067 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003068
3069 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3070 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003071 // Frame dropping always on for screen sharing.
3072 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003073
nisse05103312016-03-16 02:22:50 -07003074 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003075
3076 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3077 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003078 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003079
Niels Möllerff40b142018-04-09 08:49:14 +02003080 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003081}
3082
Sergey Silkinf18072e2018-03-14 10:35:35 +01003083TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3084 cricket::VideoSendParameters parameters;
3085 parameters.codecs.push_back(GetEngineCodec("VP9"));
3086 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3087
3088 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3089
3090 FakeVideoSendStream* stream =
3091 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3092
3093 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3094 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3095
3096 FakeVideoCapturerWithTaskQueue capturer;
3097 EXPECT_EQ(cricket::CS_RUNNING,
3098 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003099 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003100 channel_->SetSend(true);
3101
3102 EXPECT_TRUE(capturer.CaptureFrame());
3103
3104 webrtc::VideoCodecVP9 vp9_settings;
3105 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3106
3107 const size_t kNumSpatialLayers = ssrcs.size();
3108 const size_t kNumTemporalLayers = 3;
3109 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3110 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3111
Niels Möllerff40b142018-04-09 08:49:14 +02003112 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003113}
3114
asaperssonc5dabdd2016-03-21 04:15:50 -07003115class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3116 public:
brandtr468da7c2016-11-22 02:16:47 -08003117 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003118 : Vp9SettingsTest(field_trials) {}
3119
3120 protected:
3121 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3122 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003123 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003124 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3125
3126 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3127
Tommi85959932018-02-07 19:26:06 +01003128 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003129 EXPECT_EQ(cricket::CS_RUNNING,
3130 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003131 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003132 channel_->SetSend(true);
3133
3134 EXPECT_TRUE(capturer.CaptureFrame());
3135
3136 webrtc::VideoCodecVP9 vp9_settings;
3137 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3138 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3139 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3140
Niels Möllerff40b142018-04-09 08:49:14 +02003141 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003142 }
3143};
3144
3145class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3146 public:
3147 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3148};
3149
3150TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3151 const int kNumSpatialLayers = 1;
3152 const int kNumTemporalLayers = 1;
3153 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3154}
3155
3156class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3157 public:
3158 Vp9SettingsTestWithInvalidFlag()
3159 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3160};
3161
3162TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3163 const int kNumSpatialLayers = 1;
3164 const int kNumTemporalLayers = 1;
3165 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3166}
3167
3168class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3169 public:
3170 Vp9SettingsTestWith2SL3TLFlag()
3171 : Vp9SettingsTestWithFieldTrial(
3172 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3173};
3174
3175TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3176 const int kNumSpatialLayers = 2;
3177 const int kNumTemporalLayers = 3;
3178 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3179}
3180
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003181TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3182 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3183 ASSERT_EQ(1u, streams.size());
3184 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3185}
3186
3187TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3188 webrtc::test::ScopedFieldTrials override_field_trials_(
3189 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3190 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3191 ASSERT_EQ(1u, streams.size());
3192 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3193}
3194
asapersson3c81a1a2017-06-14 05:52:21 -07003195TEST_F(WebRtcVideoChannelTest,
3196 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3197 webrtc::test::ScopedFieldTrials override_field_trials_(
3198 "WebRTC-Video-BalancedDegradation/Disabled/");
3199 const bool kResolutionScalingEnabled = true;
3200 const bool kFpsScalingEnabled = false;
3201 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3202}
3203
3204TEST_F(WebRtcVideoChannelTest,
3205 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3206 webrtc::test::ScopedFieldTrials override_field_trials_(
3207 "WebRTC-Video-BalancedDegradation/Enabled/");
3208 const bool kResolutionScalingEnabled = true;
3209 const bool kFpsScalingEnabled = true;
3210 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3211}
3212
eladalonf1841382017-06-12 01:16:46 -07003213TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003214 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003215}
3216
eladalonf1841382017-06-12 01:16:46 -07003217TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003218 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003219}
3220
eladalonf1841382017-06-12 01:16:46 -07003221TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003222 TestCpuAdaptation(true, true);
3223}
3224
eladalonf1841382017-06-12 01:16:46 -07003225TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003226 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003227 cricket::VideoSendParameters parameters;
3228 parameters.codecs.push_back(codec);
3229
kthelgason2bc68642017-02-07 07:02:22 -08003230 MediaConfig media_config = GetMediaConfig();
Sebastian Jansson84848f22018-11-16 10:40:36 +01003231 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003232 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003233 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003234 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3235
3236 AddSendStream();
3237
Tommi85959932018-02-07 19:26:06 +01003238 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003239 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003240 ASSERT_EQ(cricket::CS_RUNNING,
3241 capturer.Start(capturer.GetSupportedFormats()->front()));
3242 ASSERT_TRUE(channel_->SetSend(true));
3243
3244 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3245 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003246
Niels Möllera6cc0f92018-02-12 17:14:55 +01003247 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003248 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3249 EXPECT_EQ(1280, send_stream->GetLastWidth());
3250 EXPECT_EQ(720, send_stream->GetLastHeight());
3251
3252 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003253 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003254 wants.max_pixel_count =
3255 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003256 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003257 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003258 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3259 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3260 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3261
3262 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003263 wants.max_pixel_count =
3264 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003265 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003266 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003267 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3268 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3269 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3270
3271 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003272 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003273 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003274 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3275 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3276
3277 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003278 int current_pixel_count =
3279 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3280 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3281 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003282 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003283 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003284 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003285 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003286 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003287 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003288 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3289 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3290
sprang84a37592017-02-10 07:04:27 -08003291 // Trigger underuse again, should go back up to full resolution.
3292 current_pixel_count =
3293 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003294 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003295 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003296 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003297 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003298 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003299 EXPECT_EQ(1284, send_stream->GetLastWidth());
3300 EXPECT_EQ(724, send_stream->GetLastHeight());
3301
Niels Möllerff40b142018-04-09 08:49:14 +02003302 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003303}
3304
eladalonf1841382017-06-12 01:16:46 -07003305TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003306 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003307 cricket::VideoSendParameters parameters;
3308 parameters.codecs.push_back(codec);
3309
kthelgason2bc68642017-02-07 07:02:22 -08003310 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003311 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003312 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003313 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003314 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003315 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3316
3317 AddSendStream();
3318
Tommi85959932018-02-07 19:26:06 +01003319 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003320 ASSERT_EQ(cricket::CS_RUNNING,
3321 capturer.Start(capturer.GetSupportedFormats()->front()));
3322 ASSERT_TRUE(channel_->SetSend(true));
3323 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003324 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003325 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003326
3327 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3328 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003329
Niels Möllera6cc0f92018-02-12 17:14:55 +01003330 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003331 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3332 EXPECT_EQ(1280, send_stream->GetLastWidth());
3333 EXPECT_EQ(720, send_stream->GetLastHeight());
3334
3335 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003336 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003337 wants.max_pixel_count =
3338 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003339 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003340 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003341 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3342 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3343 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3344
3345 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003346 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003347 ASSERT_EQ(cricket::CS_RUNNING,
3348 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003349 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003350 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003351 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003352 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003353 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3354 send_stream = fake_call_->GetVideoSendStreams().front();
3355 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003356 EXPECT_EQ(1284, send_stream->GetLastWidth());
3357 EXPECT_EQ(724, send_stream->GetLastHeight());
3358
3359 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003360 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003361 send_stream = fake_call_->GetVideoSendStreams().front();
3362 // We have a new fake send stream, so it doesn't remember the old sink wants.
3363 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003364 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003365 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003366 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003367 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3368 send_stream = fake_call_->GetVideoSendStreams().front();
3369 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003370 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3371 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3372
Niels Möllerff40b142018-04-09 08:49:14 +02003373 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003374}
3375
asapersson3c81a1a2017-06-14 05:52:21 -07003376// TODO(asapersson): Remove this test when the balanced field trial is removed.
3377void WebRtcVideoChannelTest::TestDegradationPreference(
3378 bool resolution_scaling_enabled,
3379 bool fps_scaling_enabled) {
3380 cricket::VideoCodec codec = GetEngineCodec("VP8");
3381 cricket::VideoSendParameters parameters;
3382 parameters.codecs.push_back(codec);
3383
3384 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003385 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003386 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003387 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003388 channel_->OnReadyToSend(true);
3389
3390 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3391
3392 AddSendStream();
3393
Tommi85959932018-02-07 19:26:06 +01003394 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003395 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003396 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003397 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3398 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3399
3400 EXPECT_TRUE(channel_->SetSend(true));
3401
3402 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3403 EXPECT_EQ(resolution_scaling_enabled,
3404 send_stream->resolution_scaling_enabled());
3405 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3406
Niels Möllerff40b142018-04-09 08:49:14 +02003407 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003408}
3409
eladalonf1841382017-06-12 01:16:46 -07003410void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3411 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003412 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003413 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003414 cricket::VideoSendParameters parameters;
3415 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003416
kthelgason2bc68642017-02-07 07:02:22 -08003417 MediaConfig media_config = GetMediaConfig();
3418 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003419 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003420 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003421 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003422 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003423 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003424
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003425 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003426
3427 AddSendStream();
3428
Tommi85959932018-02-07 19:26:06 +01003429 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003430 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003431 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003432 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003433 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003434 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003435 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003436
3437 EXPECT_TRUE(channel_->SetSend(true));
3438
solenberge5269742015-09-08 05:13:22 -07003439 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003440
sprangc5d62e22017-04-02 23:53:04 -07003441 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003442 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003443 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3444 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003445
3446 EXPECT_TRUE(capturer.CaptureFrame());
3447 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3448
perkj26752742016-10-24 01:21:16 -07003449 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3450 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003451
Niels Möllerff40b142018-04-09 08:49:14 +02003452 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003453 return;
3454 }
3455
sprangc5d62e22017-04-02 23:53:04 -07003456 if (is_screenshare) {
3457 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3458 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3459 } else {
3460 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3461 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3462 }
3463
perkj803d97f2016-11-01 11:45:46 -07003464 // Trigger overuse.
3465 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3466
3467 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003468 if (is_screenshare) {
3469 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3470 } else {
3471 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3472 }
perkj803d97f2016-11-01 11:45:46 -07003473 send_stream->InjectVideoSinkWants(wants);
3474
sprangc5d62e22017-04-02 23:53:04 -07003475 for (int i = 0; i < kDefaultFps; ++i)
3476 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003477
sprangc5d62e22017-04-02 23:53:04 -07003478 if (is_screenshare) {
3479 // Drops every third frame.
3480 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3481 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3482 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3483 } else {
3484 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3485 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3486 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3487 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003488
3489 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003490 int last_pixel_count =
3491 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003492 if (is_screenshare) {
3493 wants.max_framerate_fps = kDefaultFps;
3494 } else {
3495 wants.max_pixel_count = last_pixel_count * 4;
3496 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3497 }
perkj803d97f2016-11-01 11:45:46 -07003498 send_stream->InjectVideoSinkWants(wants);
3499
sprangc5d62e22017-04-02 23:53:04 -07003500 for (int i = 0; i < kDefaultFps; ++i)
3501 EXPECT_TRUE(capturer.CaptureFrame());
3502
3503 if (is_screenshare) {
3504 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3505 send_stream->GetNumberOfSwappedFrames());
3506 } else {
3507 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3508 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003509
perkj26752742016-10-24 01:21:16 -07003510 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3511 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003512
Niels Möllerff40b142018-04-09 08:49:14 +02003513 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003514}
3515
eladalonf1841382017-06-12 01:16:46 -07003516TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003517 // Start at last timestamp to verify that wraparounds are estimated correctly.
3518 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3519 static const int64_t kInitialNtpTimeMs = 1247891230;
3520 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003521 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003522
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003523 FakeVideoReceiveStream* stream = AddRecvStream();
3524 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003525 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003526
nisse64ec8f82016-09-27 00:17:25 -07003527 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3528 kInitialTimestamp, 0,
3529 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003530 // Initial NTP time is not available on the first frame, but should still be
3531 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003532 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003533
3534 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003535
3536 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3537 // triggers a constant-overflow warning, hence we're calculating it explicitly
3538 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003539 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003540 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3541 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003542 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003543
3544 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003545
3546 // Verify that NTP time has been correctly deduced.
3547 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003548 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003549 ASSERT_EQ(1u, info.receivers.size());
3550 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003551}
3552
eladalonf1841382017-06-12 01:16:46 -07003553TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003554 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003555 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003556
3557 VideoCodec codec;
3558 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003559 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003560
3561 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003562 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3563 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003564 FakeVideoSendStream* stream = AddSendStream(
3565 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003566 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003567
3568 // Make sure NACK and FEC are enabled on the correct payload types.
3569 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003570 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3571 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003572
3573 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3574 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003575 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003576 // TODO(juberti): Check RTCP, PLI, TMMBR.
3577}
3578
brandtr31bd2242017-05-19 05:47:46 -07003579// The following four tests ensures that FlexFEC is not activated by default
3580// when the field trials are not enabled.
3581// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3582// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003583TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003584 FakeVideoSendStream* stream = AddSendStream();
3585 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3586
brandtr3d200bd2017-01-16 06:59:19 -08003587 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003588 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3589 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003590}
3591
eladalonf1841382017-06-12 01:16:46 -07003592TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003593 FakeVideoSendStream* stream = AddSendStream(
3594 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3595 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3596
brandtr3d200bd2017-01-16 06:59:19 -08003597 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003598 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3599 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3600}
3601
Yves Gerey665174f2018-06-19 15:03:05 +02003602TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003603 AddRecvStream();
3604
3605 const std::vector<FakeFlexfecReceiveStream*>& streams =
3606 fake_call_->GetFlexfecReceiveStreams();
3607 EXPECT_TRUE(streams.empty());
3608}
3609
eladalonf1841382017-06-12 01:16:46 -07003610TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003611 AddRecvStream(
3612 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3613
3614 const std::vector<FakeFlexfecReceiveStream*>& streams =
3615 fake_call_->GetFlexfecReceiveStreams();
3616 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003617}
3618
3619// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3620// tests that use this test fixture into the corresponding "non-field trial"
3621// tests.
eladalonf1841382017-06-12 01:16:46 -07003622class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003623 public:
eladalonf1841382017-06-12 01:16:46 -07003624 WebRtcVideoChannelFlexfecRecvTest()
3625 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003626};
3627
eladalonf1841382017-06-12 01:16:46 -07003628TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003629 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3630 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3631 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3632}
3633
eladalonf1841382017-06-12 01:16:46 -07003634TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003635 AddRecvStream();
3636
3637 const std::vector<FakeFlexfecReceiveStream*>& streams =
3638 fake_call_->GetFlexfecReceiveStreams();
3639 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003640
3641 const std::vector<FakeVideoReceiveStream*>& video_streams =
3642 fake_call_->GetVideoReceiveStreams();
3643 ASSERT_EQ(1U, video_streams.size());
3644 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3645 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3646 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003647}
3648
eladalonf1841382017-06-12 01:16:46 -07003649TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003650 AddRecvStream(
3651 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3652
3653 const std::vector<FakeFlexfecReceiveStream*>& streams =
3654 fake_call_->GetFlexfecReceiveStreams();
3655 ASSERT_EQ(1U, streams.size());
3656 const FakeFlexfecReceiveStream* stream = streams.front();
3657 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3658 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3659 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3660 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3661 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003662
3663 const std::vector<FakeVideoReceiveStream*>& video_streams =
3664 fake_call_->GetVideoReceiveStreams();
3665 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003666 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3667 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003668 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003669 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003670 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003671}
3672
eladalonf1841382017-06-12 01:16:46 -07003673TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003674 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3675 cricket::VideoRecvParameters recv_parameters;
3676 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3677 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3678
3679 AddRecvStream(
3680 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3681 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003682 const std::vector<FakeVideoReceiveStream*>& video_streams =
3683 fake_call_->GetVideoReceiveStreams();
3684 ASSERT_EQ(1U, video_streams.size());
3685 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3686 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3687 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003688
3689 // Enable FlexFEC.
3690 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3691 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3692 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3693 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3694 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3695 << "Enabling FlexFEC should not create VideoReceiveStream.";
3696 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3697 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003698 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3699 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003700}
3701
eladalonf1841382017-06-12 01:16:46 -07003702TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003703 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3704 cricket::VideoRecvParameters recv_parameters;
3705 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3706 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3707 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3708
3709 AddRecvStream(
3710 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3711 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003712 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003713 const std::vector<FakeVideoReceiveStream*>& video_streams =
3714 fake_call_->GetVideoReceiveStreams();
3715 ASSERT_EQ(1U, video_streams.size());
3716 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3717 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3718 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003719
3720 // Disable FlexFEC.
3721 recv_parameters.codecs.clear();
3722 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3723 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3724 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3725 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3726 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3727 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3728 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3729 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003730 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3731 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003732}
3733
brandtr31bd2242017-05-19 05:47:46 -07003734// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3735// tests that use this test fixture into the corresponding "non-field trial"
3736// tests.
eladalonf1841382017-06-12 01:16:46 -07003737class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003738 public:
eladalonf1841382017-06-12 01:16:46 -07003739 WebRtcVideoChannelFlexfecSendRecvTest()
3740 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003741 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3742 }
3743};
3744
Yves Gerey665174f2018-06-19 15:03:05 +02003745TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003746 FakeVideoSendStream* stream = AddSendStream();
3747 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3748
brandtr3d200bd2017-01-16 06:59:19 -08003749 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3750 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3751 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003752}
3753
eladalonf1841382017-06-12 01:16:46 -07003754TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003755 FakeVideoSendStream* stream = AddSendStream(
3756 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3757 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3758
brandtr3d200bd2017-01-16 06:59:19 -08003759 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3760 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3761 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3762 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003763}
3764
eladalonf1841382017-06-12 01:16:46 -07003765TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003766 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003767 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003768 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003769
3770 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003771 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003772
brandtrb5f2c3f2016-10-04 23:28:39 -07003773 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3774 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003775}
3776
eladalonf1841382017-06-12 01:16:46 -07003777TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003778 cricket::VideoSendParameters parameters;
3779 parameters.codecs.push_back(GetEngineCodec("VP8"));
3780 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3781
3782 FakeVideoSendStream* stream = AddSendStream();
3783 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3784
brandtr3d200bd2017-01-16 06:59:19 -08003785 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003786}
3787
eladalonf1841382017-06-12 01:16:46 -07003788TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003789 AddRecvStream(
3790 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003791
3792 cricket::VideoRecvParameters recv_parameters;
3793 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3794 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3795 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003796
3797 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3798 fake_call_->GetFlexfecReceiveStreams();
3799 ASSERT_EQ(1U, flexfec_streams.size());
3800 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3801 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3802 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003803 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003804 flexfec_stream_config.payload_type);
3805 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3806 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3807 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3808 const std::vector<FakeVideoReceiveStream*>& video_streams =
3809 fake_call_->GetVideoReceiveStreams();
3810 const FakeVideoReceiveStream* video_stream = video_streams.front();
3811 const webrtc::VideoReceiveStream::Config& video_stream_config =
3812 video_stream->GetConfig();
3813 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3814 flexfec_stream_config.local_ssrc);
3815 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3816 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3817 flexfec_stream_config.rtcp_send_transport);
3818 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3819 // spec-compliant way.
3820 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3821 flexfec_stream_config.transport_cc);
3822 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3823 EXPECT_EQ(video_stream_config.rtp.extensions,
3824 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003825}
3826
brandtr31bd2242017-05-19 05:47:46 -07003827// We should not send FlexFEC, even if we advertise it, unless the right
3828// field trial is set.
3829// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003830TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003831 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3832 cricket::VideoSendParameters parameters;
3833 parameters.codecs.push_back(GetEngineCodec("VP8"));
3834 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3835 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3836
3837 FakeVideoSendStream* stream = AddSendStream();
3838 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3839
3840 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003841 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003842 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3843}
3844
eladalonf1841382017-06-12 01:16:46 -07003845TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003846 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3847 cricket::VideoSendParameters parameters;
3848 parameters.codecs.push_back(GetEngineCodec("VP8"));
3849 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3850 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3851
3852 FakeVideoSendStream* stream = AddSendStream(
3853 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3854 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3855
3856 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003857 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003858 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3859}
3860
eladalonf1841382017-06-12 01:16:46 -07003861TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003862 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003863 const int kUnusedPayloadType = 127;
3864 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3865
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003866 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003867 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003868 parameters.codecs.push_back(rtx_codec);
3869 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003870 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003871}
3872
eladalonf1841382017-06-12 01:16:46 -07003873TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003874 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003875 const int kUnusedPayloadType1 = 126;
3876 const int kUnusedPayloadType2 = 127;
3877 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3878 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3879 {
3880 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3881 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3882 cricket::VideoSendParameters parameters;
3883 parameters.codecs.push_back(GetEngineCodec("VP8"));
3884 parameters.codecs.push_back(rtx_codec);
3885 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3886 }
3887 {
3888 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3889 kUnusedPayloadType1, kUnusedPayloadType2);
3890 cricket::VideoSendParameters parameters;
3891 parameters.codecs.push_back(GetEngineCodec("VP8"));
3892 parameters.codecs.push_back(rtx_codec);
3893 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3894 << "RTX without matching video codec should be rejected.";
3895 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003896}
3897
eladalonf1841382017-06-12 01:16:46 -07003898TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003899 const int kUnusedPayloadType1 = 126;
3900 const int kUnusedPayloadType2 = 127;
3901 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3902 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3903
3904 // SSRCs for RTX.
3905 cricket::StreamParams params =
3906 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3907 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3908 AddSendStream(params);
3909
3910 // Original payload type for RTX.
3911 cricket::VideoSendParameters parameters;
3912 parameters.codecs.push_back(GetEngineCodec("VP8"));
3913 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3914 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3915 parameters.codecs.push_back(rtx_codec);
3916 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3917 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3918 const webrtc::VideoSendStream::Config& config_before =
3919 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3920 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3921 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3922 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3923
3924 // Change payload type for RTX.
3925 parameters.codecs[1].id = kUnusedPayloadType2;
3926 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3927 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3928 const webrtc::VideoSendStream::Config& config_after =
3929 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3930 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3931 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3932 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3933}
3934
eladalonf1841382017-06-12 01:16:46 -07003935TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003936 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003937 parameters.codecs.push_back(GetEngineCodec("VP8"));
3938 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003939 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003940
3941 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003942 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003943
magjed509e4fe2016-11-18 01:34:11 -08003944 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003945
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003946 parameters.codecs.pop_back();
3947 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003948 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003949 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003950 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003951 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003952 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3953}
3954
eladalonf1841382017-06-12 01:16:46 -07003955TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003956 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003957 cricket::VideoSendParameters parameters;
3958 parameters.codecs.push_back(GetEngineCodec("VP8"));
3959 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3960 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3961
3962 FakeVideoSendStream* stream = AddSendStream(
3963 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3964 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3965
brandtr3d200bd2017-01-16 06:59:19 -08003966 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3967 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003968 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3969 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3970
3971 parameters.codecs.pop_back();
3972 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3973 stream = fake_call_->GetVideoSendStreams()[0];
3974 ASSERT_TRUE(stream != nullptr);
3975 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003976 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003977 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003978}
3979
eladalonf1841382017-06-12 01:16:46 -07003980TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003981 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003982 cricket::VideoCodec codec(100, "VP8");
3983 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3984 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003985
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003986 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003987 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003988
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003989 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003990 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003991 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003992
3993 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003994 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003995
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003996 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003997 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3998 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003999 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004000 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004001 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004002 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004003}
4004
eladalonf1841382017-06-12 01:16:46 -07004005TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004006 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4007 200000);
4008}
4009
eladalonf1841382017-06-12 01:16:46 -07004010TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004011 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4012 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4013 ASSERT_EQ(1u, streams.size());
4014 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4015}
4016
eladalonf1841382017-06-12 01:16:46 -07004017TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004018 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004019 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004020}
4021
eladalonf1841382017-06-12 01:16:46 -07004022TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004023 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004024}
4025
eladalonf1841382017-06-12 01:16:46 -07004026TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004027 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4028 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4029 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004030}
4031
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004032// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4033// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004034TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004035 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4036 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4037 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4038 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004039 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004040 ExpectSetBitrateParameters(100000, 200000, 400000);
4041 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4042 // Since the codec isn't changing, start_bitrate_bps should be -1.
4043 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004044
4045 // Decrease max_bandwidth_bps.
4046 send_parameters_.max_bandwidth_bps = 350000;
4047 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004048
4049 // Now try again with the values flipped around.
4050 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4051 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004052 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004053 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004054
4055 // If we change the codec max, max_bandwidth_bps should still apply.
4056 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004057 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004058 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004059}
4060
Yves Gerey665174f2018-06-19 15:03:05 +02004061TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004062 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4063 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004064 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004065 // Setting max bitrate should keep previous min bitrate.
4066 // Setting max bitrate should not reset start bitrate.
4067 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004068 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004069}
4070
eladalonf1841382017-06-12 01:16:46 -07004071TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004072 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004073 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004074 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004075 // -1 means to disable max bitrate (set infinite).
4076 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004077 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004078 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004079}
4080
eladalonf1841382017-06-12 01:16:46 -07004081TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004082 send_parameters_.max_bandwidth_bps = 99999;
4083 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004084 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004085 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004086 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4087 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4088 stream->GetVideoStreams()[0].max_bitrate_bps);
4089
4090 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004091 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004092 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4093 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004094 stream->GetVideoStreams()[0].max_bitrate_bps);
4095}
4096
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004097// Tests that when the codec specific max bitrate and VideoSendParameters
4098// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4099// appropriately.
4100TEST_F(WebRtcVideoChannelTest,
4101 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4102 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4103 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4104 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4105 send_parameters_.max_bandwidth_bps = -1;
4106 AddSendStream();
4107 ExpectSetMaxBitrate(300000);
4108 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4109
4110 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4111 ASSERT_EQ(1u, video_send_streams.size());
4112 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4113 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4114 // First the max bitrate is set based upon the codec param.
4115 EXPECT_EQ(300000,
4116 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4117
4118 // The VideoSendParameters max bitrate overrides the codec's.
4119 send_parameters_.max_bandwidth_bps = 500000;
4120 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4121 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4122 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4123 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4124}
4125
4126// Tests that when the codec specific max bitrate and RtpParameters
4127// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4128// appropriately.
4129TEST_F(WebRtcVideoChannelTest,
4130 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4131 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4132 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4133 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4134 send_parameters_.max_bandwidth_bps = -1;
4135 AddSendStream();
4136 ExpectSetMaxBitrate(300000);
4137 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4138
4139 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4140 ASSERT_EQ(1u, video_send_streams.size());
4141 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4142 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4143 // First the max bitrate is set based upon the codec param.
4144 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4145
4146 // The RtpParameter max bitrate overrides the codec's.
4147 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4148 ASSERT_EQ(1u, parameters.encodings.size());
4149 parameters.encodings[0].max_bitrate_bps = 500000;
4150 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4151 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4152 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4153 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4154}
4155
Åsa Persson55659812018-06-18 17:51:32 +02004156TEST_F(WebRtcVideoChannelTest,
4157 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4158 send_parameters_.max_bandwidth_bps = 99999;
4159 FakeVideoSendStream* stream = AddSendStream();
4160 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4161 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4162 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4163 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4164 stream->GetVideoStreams()[0].max_bitrate_bps);
4165
4166 // Get and set the rtp encoding parameters.
4167 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4168 EXPECT_EQ(1u, parameters.encodings.size());
4169
4170 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4171 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4172 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4173 stream->GetVideoStreams()[0].max_bitrate_bps);
4174
4175 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4176 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4177 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4178 stream->GetVideoStreams()[0].max_bitrate_bps);
4179}
4180
eladalonf1841382017-06-12 01:16:46 -07004181TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004182 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004183 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004184 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004185 channel_->SetSend(true);
4186
4187 FakeVideoSendStream* stream = AddSendStream();
4188
Tommi85959932018-02-07 19:26:06 +01004189 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004190 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004191 EXPECT_EQ(cricket::CS_RUNNING,
4192 capturer.Start(capturer.GetSupportedFormats()->front()));
4193
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004194 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4195 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4196 EXPECT_GT(initial_max_bitrate_bps, 0);
4197
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004198 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4199 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004200 // Insert a frame to update the encoder config.
4201 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004202 streams = stream->GetVideoStreams();
4203 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004204 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004205}
4206
eladalonf1841382017-06-12 01:16:46 -07004207TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004208 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004209 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004210 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004211 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004212 channel_->SetSend(true);
4213
4214 FakeVideoSendStream* stream = AddSendStream(
4215 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4216
4217 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004218 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004219 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004220 EXPECT_EQ(cricket::CS_RUNNING,
4221 capturer.Start(capturer.GetSupportedFormats()->front()));
4222 EXPECT_TRUE(capturer.CaptureFrame());
4223
4224 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4225 ASSERT_GT(streams.size(), 1u)
4226 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004227 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004228 EXPECT_GT(initial_max_bitrate_bps, 0);
4229
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004230 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4231 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004232 // Insert a frame to update the encoder config.
4233 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004234 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004235 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004236 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4237
Niels Möllerff40b142018-04-09 08:49:14 +02004238 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004239}
4240
eladalonf1841382017-06-12 01:16:46 -07004241TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004242 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004243 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004244 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004245 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4246 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004247 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004248 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004249
4250 VideoCodec codec;
4251 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4252 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4253}
4254
eladalonf1841382017-06-12 01:16:46 -07004255TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004256 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004257 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004258 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004259 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004260 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004261 parameters.codecs[0].id = kIncorrectPayloads[i];
4262 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004263 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004264 }
4265}
4266
eladalonf1841382017-06-12 01:16:46 -07004267TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004268 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004269 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004270 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004271 parameters.codecs[0].id = payload_type;
4272 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004273 << "Payload type '" << payload_type << "' rejected.";
4274 }
4275}
4276
deadbeef67cf2c12016-04-13 10:07:16 -07004277// Test that setting the a different set of codecs but with an identical front
4278// codec doesn't result in the stream being recreated.
4279// This may happen when a subsequent negotiation includes fewer codecs, as a
4280// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004281TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004282 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4283 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004284 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4285 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004286 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4287
4288 AddSendStream();
4289 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4290
4291 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004292 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004293 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4294 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4295}
4296
eladalonf1841382017-06-12 01:16:46 -07004297TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004298 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004299 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004300 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004301}
4302
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004303// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004304TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004305 const int kUnusedPayloadType1 = 126;
4306 const int kUnusedPayloadType2 = 127;
4307 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4308 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4309
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004310 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004311 parameters.codecs.push_back(GetEngineCodec("VP8"));
4312 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004313 parameters.codecs.push_back(rtx_codec);
4314 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004315 << "RTX codec without associated payload should be rejected.";
4316
magjed509e4fe2016-11-18 01:34:11 -08004317 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004318 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004319 << "RTX codec with invalid associated payload type should be rejected.";
4320
magjed509e4fe2016-11-18 01:34:11 -08004321 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004322 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004323
magjed509e4fe2016-11-18 01:34:11 -08004324 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004325 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004326 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004327
Yves Gerey665174f2018-06-19 15:03:05 +02004328 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4329 << "RTX codec with another RTX as associated payload type should be "
4330 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004331}
4332
eladalonf1841382017-06-12 01:16:46 -07004333TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004334 const int kUnusedPayloadType1 = 126;
4335 const int kUnusedPayloadType2 = 127;
4336 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4337 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4338
4339 // SSRCs for RTX.
4340 cricket::StreamParams params =
4341 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4342 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4343 AddRecvStream(params);
4344
4345 // Original payload type for RTX.
4346 cricket::VideoRecvParameters parameters;
4347 parameters.codecs.push_back(GetEngineCodec("VP8"));
4348 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4349 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4350 parameters.codecs.push_back(rtx_codec);
4351 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4352 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4353 const webrtc::VideoReceiveStream::Config& config_before =
4354 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004355 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4356 const int* payload_type_before = FindKeyByValue(
4357 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4358 ASSERT_NE(payload_type_before, nullptr);
4359 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004360 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4361
4362 // Change payload type for RTX.
4363 parameters.codecs[1].id = kUnusedPayloadType2;
4364 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4365 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4366 const webrtc::VideoReceiveStream::Config& config_after =
4367 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004368 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4369 const int* payload_type_after = FindKeyByValue(
4370 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4371 ASSERT_NE(payload_type_after, nullptr);
4372 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004373 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4374}
4375
eladalonf1841382017-06-12 01:16:46 -07004376TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004377 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004378 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004379 parameters.codecs[0].id = 99;
4380 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004381}
4382
eladalonf1841382017-06-12 01:16:46 -07004383TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004384 cricket::VideoRecvParameters parameters;
4385 parameters.codecs = engine_.codecs();
4386 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004387
4388 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004389 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004390 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004391 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004392}
4393
eladalonf1841382017-06-12 01:16:46 -07004394TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004395 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004396 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004397 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004398 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004399}
4400
eladalonf1841382017-06-12 01:16:46 -07004401TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004402 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004403 parameters.codecs.push_back(GetEngineCodec("VP8"));
4404 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004405 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004406}
4407
eladalonf1841382017-06-12 01:16:46 -07004408TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004409 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004410 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4411 send_parameters.codecs.push_back(GetEngineCodec("red"));
4412 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004413 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004414
4415 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004416
magjed509e4fe2016-11-18 01:34:11 -08004417 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004418 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004419
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004420 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004421 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004422 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004423 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004424 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004425 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004426 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4427}
4428
eladalonf1841382017-06-12 01:16:46 -07004429TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004430 AddRecvStream(
4431 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004432 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004433 fake_call_->GetFlexfecReceiveStreams();
4434
4435 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004436 const FakeFlexfecReceiveStream* stream = streams.front();
4437 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4438 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4439 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4440 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004441
4442 cricket::VideoRecvParameters recv_parameters;
4443 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4444 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4445 EXPECT_TRUE(streams.empty())
4446 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004447}
4448
eladalonf1841382017-06-12 01:16:46 -07004449TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004450 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004451 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004452 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004453
4454 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004455 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4456 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4457 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004458 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4459 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004460 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004461 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004462 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004463 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004464
4465 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004466 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4467 send_parameters.codecs.push_back(GetEngineCodec("red"));
4468 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004469 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4470 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004471 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004472 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004473 << "ULPFEC should be enabled on the receive stream.";
4474}
4475
eladalonf1841382017-06-12 01:16:46 -07004476TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004477 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004478 AddRecvStream(
4479 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004480 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004481 fake_call_->GetFlexfecReceiveStreams();
4482
4483 cricket::VideoRecvParameters recv_parameters;
4484 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4485 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4486 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4487 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004488 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004489 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004490 stream_with_recv_params->GetConfig().payload_type);
4491 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004492 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004493 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004494 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004495 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004496
4497 cricket::VideoSendParameters send_parameters;
4498 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4499 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4500 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4501 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004502 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004503 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004504 stream_with_send_params->GetConfig().payload_type);
4505 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004506 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004507 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004508 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004509 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004510}
4511
eladalonf1841382017-06-12 01:16:46 -07004512TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004513 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004514 parameters.codecs.push_back(GetEngineCodec("VP8"));
4515 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004516 parameters.codecs[1].id = parameters.codecs[0].id;
4517 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004518}
4519
eladalonf1841382017-06-12 01:16:46 -07004520TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004521 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004522 cricket::VideoRecvParameters parameters;
4523 parameters.codecs.push_back(GetEngineCodec("VP8"));
4524 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4525 parameters.codecs[1].id = parameters.codecs[0].id;
4526 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4527}
4528
eladalonf1841382017-06-12 01:16:46 -07004529TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004530 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004531 parameters.codecs.push_back(GetEngineCodec("VP8"));
4532 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004533 parameters.codecs[1].id = parameters.codecs[0].id;
4534 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004535}
4536
eladalonf1841382017-06-12 01:16:46 -07004537TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004538 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004539 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004540 parameters.codecs.push_back(GetEngineCodec("VP8"));
4541 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004542 parameters.codecs[1].id += 1;
4543 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004544}
4545
deadbeef67cf2c12016-04-13 10:07:16 -07004546// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004547// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004548TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004549 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004550 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004551 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4552 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004553 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004554
4555 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4556 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4557
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004558 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004559 parameters2.codecs.push_back(GetEngineCodec("red"));
4560 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004561 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004562 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4563}
4564
eladalonf1841382017-06-12 01:16:46 -07004565TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004566 EXPECT_FALSE(AddSendStream()->IsSending());
4567}
4568
eladalonf1841382017-06-12 01:16:46 -07004569TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004570 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004571}
4572
eladalonf1841382017-06-12 01:16:46 -07004573TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004574 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004575 EXPECT_FALSE(stream->IsSending());
4576
4577 // false->true
4578 EXPECT_TRUE(channel_->SetSend(true));
4579 EXPECT_TRUE(stream->IsSending());
4580 // true->true
4581 EXPECT_TRUE(channel_->SetSend(true));
4582 EXPECT_TRUE(stream->IsSending());
4583 // true->false
4584 EXPECT_TRUE(channel_->SetSend(false));
4585 EXPECT_FALSE(stream->IsSending());
4586 // false->false
4587 EXPECT_TRUE(channel_->SetSend(false));
4588 EXPECT_FALSE(stream->IsSending());
4589
4590 EXPECT_TRUE(channel_->SetSend(true));
4591 FakeVideoSendStream* new_stream = AddSendStream();
4592 EXPECT_TRUE(new_stream->IsSending())
4593 << "Send stream created after SetSend(true) not sending initially.";
4594}
4595
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004596// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004597TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004598 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004599 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004600 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004601 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004602 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004603
Sebastian Jansson84848f22018-11-16 10:40:36 +01004604 channel.reset(
4605 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4606 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004607 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004608 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004609 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004610
Tim Haloun648d28a2018-10-18 16:52:22 -07004611 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4612 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004613 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004614 channel.reset(
4615 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4616 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004617 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004618 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4619
4620 // Create a send stream to configure
4621 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4622 parameters = channel->GetRtpSendParameters(kSsrc);
4623 ASSERT_FALSE(parameters.encodings.empty());
4624
4625 // Various priorities map to various dscp values.
4626 parameters.encodings[0].network_priority = 4.0;
4627 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004628 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004629 parameters.encodings[0].network_priority = 0.5;
4630 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4631 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4632
4633 // A bad priority does not change the dscp value.
4634 parameters.encodings[0].network_priority = 0.0;
4635 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4636 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004637
Tim Haloun6ca98362018-09-17 17:06:08 -07004638 // Packets should also self-identify their dscp in PacketOptions.
4639 const uint8_t kData[10] = {0};
4640 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4641 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004642 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004643
nisse51542be2016-02-12 02:27:06 -08004644 // Verify that setting the option to false resets the
4645 // DiffServCodePoint.
4646 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004647 channel.reset(
4648 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4649 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004650 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004651 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004652}
4653
deadbeef13871492015-12-09 12:37:51 -08004654// This test verifies that the RTCP reduced size mode is properly applied to
4655// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004656TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004657 // Create stream, expecting that default mode is "compound".
4658 FakeVideoSendStream* stream1 = AddSendStream();
4659 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004660 webrtc::RtpParameters rtp_parameters =
4661 channel_->GetRtpSendParameters(last_ssrc_);
4662 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004663
4664 // Now enable reduced size mode.
4665 send_parameters_.rtcp.reduced_size = true;
4666 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4667 stream1 = fake_call_->GetVideoSendStreams()[0];
4668 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004669 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4670 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004671
4672 // Create a new stream and ensure it picks up the reduced size mode.
4673 FakeVideoSendStream* stream2 = AddSendStream();
4674 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4675}
4676
4677// This test verifies that the RTCP reduced size mode is properly applied to
4678// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004679TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004680 // Create stream, expecting that default mode is "compound".
4681 FakeVideoReceiveStream* stream1 = AddRecvStream();
4682 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4683
4684 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004685 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4686 // the reduced_size flag should come from that.
4687 send_parameters_.rtcp.reduced_size = true;
4688 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004689 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4690 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4691
4692 // Create a new stream and ensure it picks up the reduced size mode.
4693 FakeVideoReceiveStream* stream2 = AddRecvStream();
4694 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4695}
4696
eladalonf1841382017-06-12 01:16:46 -07004697TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004698 EXPECT_EQ(webrtc::kNetworkUp,
4699 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4700 EXPECT_EQ(webrtc::kNetworkUp,
4701 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004702
4703 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004704 EXPECT_EQ(webrtc::kNetworkDown,
4705 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4706 EXPECT_EQ(webrtc::kNetworkUp,
4707 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004708
4709 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004710 EXPECT_EQ(webrtc::kNetworkUp,
4711 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4712 EXPECT_EQ(webrtc::kNetworkUp,
4713 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004714}
4715
eladalonf1841382017-06-12 01:16:46 -07004716TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004717 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004718 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004719 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004720
4721 AddSendStream();
4722
4723 cricket::VideoMediaInfo info;
4724 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004725 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004726}
4727
eladalonf1841382017-06-12 01:16:46 -07004728TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004729 FakeVideoSendStream* stream = AddSendStream();
4730 webrtc::VideoSendStream::Stats stats;
4731 stats.encoder_implementation_name = "encoder_implementation_name";
4732 stream->SetStats(stats);
4733
4734 cricket::VideoMediaInfo info;
4735 ASSERT_TRUE(channel_->GetStats(&info));
4736 EXPECT_EQ(stats.encoder_implementation_name,
4737 info.senders[0].encoder_implementation_name);
4738}
4739
eladalonf1841382017-06-12 01:16:46 -07004740TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004741 FakeVideoSendStream* stream = AddSendStream();
4742 webrtc::VideoSendStream::Stats stats;
4743 stats.avg_encode_time_ms = 13;
4744 stats.encode_usage_percent = 42;
4745 stream->SetStats(stats);
4746
4747 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004748 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004749 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4750 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4751}
4752
eladalonf1841382017-06-12 01:16:46 -07004753TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004754 FakeVideoSendStream* stream = AddSendStream();
4755 webrtc::VideoSendStream::Stats stats;
4756 stats.frames_encoded = 13;
4757 stream->SetStats(stats);
4758
4759 cricket::VideoMediaInfo info;
4760 ASSERT_TRUE(channel_->GetStats(&info));
4761 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4762}
4763
eladalonf1841382017-06-12 01:16:46 -07004764TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004765 FakeVideoSendStream* stream = AddSendStream();
4766 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004767 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004768 stream->SetStats(stats);
4769
4770 cricket::VideoMediaInfo info;
4771 ASSERT_TRUE(channel_->GetStats(&info));
4772 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4773}
4774
eladalonf1841382017-06-12 01:16:46 -07004775TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004776 FakeVideoSendStream* stream = AddSendStream();
4777 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004778 stats.substreams[17].width = 123;
4779 stats.substreams[17].height = 40;
4780 stats.substreams[42].width = 80;
4781 stats.substreams[42].height = 31;
4782 stats.substreams[11].width = 20;
4783 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004784 stream->SetStats(stats);
4785
4786 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004787 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004788 ASSERT_EQ(1u, info.senders.size());
4789 EXPECT_EQ(123, info.senders[0].send_frame_width);
4790 EXPECT_EQ(90, info.senders[0].send_frame_height);
4791}
4792
eladalonf1841382017-06-12 01:16:46 -07004793TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004794 FakeVideoSendStream* stream = AddSendStream();
4795 webrtc::VideoSendStream::Stats stats;
4796 stats.number_of_cpu_adapt_changes = 2;
4797 stats.cpu_limited_resolution = true;
4798 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004799
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004800 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004801 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004802 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004803 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004804 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004805}
4806
eladalonf1841382017-06-12 01:16:46 -07004807TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004808 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004809 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004810 stats.number_of_cpu_adapt_changes = 2;
4811 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004812 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004813 stream->SetStats(stats);
4814
4815 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004816 EXPECT_TRUE(channel_->GetStats(&info));
4817 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004818 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4819 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004820 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004821 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004822}
4823
eladalonf1841382017-06-12 01:16:46 -07004824TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004825 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4826 FakeVideoSendStream* stream = AddSendStream();
4827 webrtc::VideoSendStream::Stats stats;
4828 stats.bw_limited_resolution = true;
4829 stream->SetStats(stats);
4830
4831 cricket::VideoMediaInfo info;
4832 EXPECT_TRUE(channel_->GetStats(&info));
4833 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004834 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004835 info.senders[0].adapt_reason);
4836}
4837
Yves Gerey665174f2018-06-19 15:03:05 +02004838TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004839 FakeVideoSendStream* stream = AddSendStream();
4840 webrtc::VideoSendStream::Stats stats;
4841 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4842 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4843 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4844
4845 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4846 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4847 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4848
4849 stream->SetStats(stats);
4850
4851 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004852 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004853 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4854 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4855 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4856}
4857
eladalonf1841382017-06-12 01:16:46 -07004858TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004859 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4860 FakeVideoReceiveStream* stream = AddRecvStream();
4861 webrtc::VideoReceiveStream::Stats stats;
4862 stats.rtcp_packet_type_counts.fir_packets = 2;
4863 stats.rtcp_packet_type_counts.nack_packets = 3;
4864 stats.rtcp_packet_type_counts.pli_packets = 4;
4865 stream->SetStats(stats);
4866
4867 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004868 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004869 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004870 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004871 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004872 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004873 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004874 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004875}
4876
eladalonf1841382017-06-12 01:16:46 -07004877TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004878 FakeVideoReceiveStream* stream = AddRecvStream();
4879 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004880 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004881 stats.decode_ms = 2;
4882 stats.max_decode_ms = 3;
4883 stats.current_delay_ms = 4;
4884 stats.target_delay_ms = 5;
4885 stats.jitter_buffer_ms = 6;
4886 stats.min_playout_delay_ms = 7;
4887 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004888 stats.width = 9;
4889 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004890 stats.frame_counts.key_frames = 11;
4891 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004892 stats.frames_rendered = 13;
4893 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004894 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004895 stream->SetStats(stats);
4896
4897 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004898 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004899 EXPECT_EQ(stats.decoder_implementation_name,
4900 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004901 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4902 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4903 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4904 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4905 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4906 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4907 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004908 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4909 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004910 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4911 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004912 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004913 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004914 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004915 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004916}
4917
eladalonf1841382017-06-12 01:16:46 -07004918TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004919 FakeVideoReceiveStream* stream = AddRecvStream();
4920 webrtc::VideoReceiveStream::Stats stats;
4921 stats.rtp_stats.transmitted.payload_bytes = 2;
4922 stats.rtp_stats.transmitted.header_bytes = 3;
4923 stats.rtp_stats.transmitted.padding_bytes = 4;
4924 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004925 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004926 stats.rtcp_stats.fraction_lost = 7;
4927 stream->SetStats(stats);
4928
4929 cricket::VideoMediaInfo info;
4930 ASSERT_TRUE(channel_->GetStats(&info));
4931 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4932 stats.rtp_stats.transmitted.header_bytes +
4933 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004934 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004935 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004936 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004937 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004938 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004939 info.receivers[0].fraction_lost);
4940}
4941
eladalonf1841382017-06-12 01:16:46 -07004942TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004943 AddSendStream();
4944 AddSendStream();
4945 webrtc::Call::Stats stats;
4946 stats.rtt_ms = 123;
4947 fake_call_->SetStats(stats);
4948
4949 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004950 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004951 ASSERT_EQ(2u, info.senders.size());
4952 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4953 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4954}
4955
eladalonf1841382017-06-12 01:16:46 -07004956TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004957 FakeVideoSendStream* stream = AddSendStream();
4958 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004959 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004960 stats.media_bitrate_bps = 123;
4961 stats.substreams[17].total_bitrate_bps = 1;
4962 stats.substreams[17].retransmit_bitrate_bps = 2;
4963 stats.substreams[42].total_bitrate_bps = 3;
4964 stats.substreams[42].retransmit_bitrate_bps = 4;
4965 stream->SetStats(stats);
4966
4967 FakeVideoSendStream* stream2 = AddSendStream();
4968 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004969 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004970 stats2.media_bitrate_bps = 321;
4971 stats2.substreams[13].total_bitrate_bps = 5;
4972 stats2.substreams[13].retransmit_bitrate_bps = 6;
4973 stats2.substreams[21].total_bitrate_bps = 7;
4974 stats2.substreams[21].retransmit_bitrate_bps = 8;
4975 stream2->SetStats(stats2);
4976
4977 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004978 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004979 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004980 BandwidthEstimationInfo bwe_info;
4981 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004982 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4983 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4984 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4985 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004986 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004987 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004988 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004989 bwe_info.actual_enc_bitrate);
4990 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004991 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004992 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004993 << "Bandwidth stats should take all streams into account.";
4994}
4995
eladalonf1841382017-06-12 01:16:46 -07004996TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004997 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004998
Peter Boström0c4e06b2015-10-07 12:23:21 +02004999 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5000 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005001
5002 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5003 const size_t kDataLength = 12;
5004 uint8_t data[kDataLength];
5005 memset(data, 0, sizeof(data));
5006 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005007 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005008 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005009
5010 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5011 << "No default receive stream created.";
5012 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005013 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005014 << "Default receive stream should not have configured RTX";
5015
5016 EXPECT_TRUE(channel_->AddRecvStream(
5017 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5018 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005019 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005020 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005021 EXPECT_FALSE(
5022 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005023 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005024 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005025 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005026 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005027 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005028 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005029}
5030
eladalonf1841382017-06-12 01:16:46 -07005031TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005032 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005033
Peter Boström0c4e06b2015-10-07 12:23:21 +02005034 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5035 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005036
5037 StreamParams sp =
5038 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5039 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5040
5041 EXPECT_FALSE(channel_->AddSendStream(sp));
5042 EXPECT_FALSE(channel_->AddRecvStream(sp));
5043}
5044
eladalonf1841382017-06-12 01:16:46 -07005045TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005046 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005047
Peter Boström0c4e06b2015-10-07 12:23:21 +02005048 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5049 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005050
5051 StreamParams sp =
5052 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5053
5054 EXPECT_TRUE(channel_->AddSendStream(sp));
5055 EXPECT_TRUE(channel_->AddRecvStream(sp));
5056
5057 // The RTX SSRC is already used in previous streams, using it should fail.
5058 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5059 EXPECT_FALSE(channel_->AddSendStream(sp));
5060 EXPECT_FALSE(channel_->AddRecvStream(sp));
5061
5062 // After removing the original stream this should be fine to add (makes sure
5063 // that RTX ssrcs are not forever taken).
5064 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5065 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5066 EXPECT_TRUE(channel_->AddSendStream(sp));
5067 EXPECT_TRUE(channel_->AddRecvStream(sp));
5068}
5069
eladalonf1841382017-06-12 01:16:46 -07005070TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005071 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005072 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5073 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005074 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005075
Peter Boströmd6f4c252015-03-26 16:23:04 +01005076 StreamParams sp =
5077 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5078
5079 EXPECT_TRUE(channel_->AddSendStream(sp));
5080 EXPECT_TRUE(channel_->AddRecvStream(sp));
5081
5082 // One of the SSRCs is already used in previous streams, using it should fail.
5083 sp = cricket::CreateSimStreamParams("cname",
5084 MAKE_VECTOR(kOverlappingStreamSsrcs));
5085 EXPECT_FALSE(channel_->AddSendStream(sp));
5086 EXPECT_FALSE(channel_->AddRecvStream(sp));
5087
5088 // After removing the original stream this should be fine to add (makes sure
5089 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005090 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5091 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005092 EXPECT_TRUE(channel_->AddSendStream(sp));
5093 EXPECT_TRUE(channel_->AddRecvStream(sp));
5094}
5095
eladalonf1841382017-06-12 01:16:46 -07005096TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005097 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005098
5099 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5100 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5101
5102 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5103 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5104
5105 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5106
5107 static const uint32_t kReceiverSsrcs[] = {3};
5108 static const uint32_t kReceiverRtxSsrcs[] = {2};
5109
5110 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5111 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5112 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5113
5114 cricket::VideoMediaInfo info;
5115 ASSERT_TRUE(channel_->GetStats(&info));
5116
5117 ASSERT_EQ(1u, info.senders.size());
5118 ASSERT_EQ(1u, info.receivers.size());
5119
5120 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5121 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5122 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5123}
5124
eladalonf1841382017-06-12 01:16:46 -07005125TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005126 FakeVideoReceiveStream* stream = AddRecvStream();
5127 webrtc::VideoReceiveStream::Stats stats;
5128 cricket::VideoMediaInfo info;
5129
5130 // Report no codec name before receiving.
5131 stream->SetStats(stats);
5132 ASSERT_TRUE(channel_->GetStats(&info));
5133 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5134
5135 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005136 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005137 stream->SetStats(stats);
5138 ASSERT_TRUE(channel_->GetStats(&info));
5139 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5140
5141 // Report no codec name for unknown playload types.
5142 stats.current_payload_type = 3;
5143 stream->SetStats(stats);
5144 ASSERT_TRUE(channel_->GetStats(&info));
5145 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5146}
5147
Seth Hampson5897a6e2018-04-03 11:16:33 -07005148// Tests that when we add a stream without SSRCs, but contains a stream_id
5149// that it is stored and its stream id is later used when the first packet
5150// arrives to properly create a receive stream with a sync label.
5151TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5152 const char kSyncLabel[] = "sync_label";
5153 cricket::StreamParams unsignaled_stream;
5154 unsignaled_stream.set_stream_ids({kSyncLabel});
5155 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5156 // The stream shouldn't have been created at this point because it doesn't
5157 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005158 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005159
5160 // Create and deliver packet.
5161 const size_t kDataLength = 12;
5162 uint8_t data[kDataLength];
5163 memset(data, 0, sizeof(data));
5164 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5165 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005166 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005167
5168 // The stream should now be created with the appropriate sync label.
5169 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5170 EXPECT_EQ(kSyncLabel,
5171 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5172
5173 // Removing the unsignaled stream should clear the cache. This time when
5174 // a default video receive stream is created it won't have a sync_group.
5175 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5176 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5177 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5178
Niels Möllere6933812018-11-05 13:01:41 +01005179 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005180 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5181 EXPECT_TRUE(
5182 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5183}
5184
eladalonf1841382017-06-12 01:16:46 -07005185void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005186 uint8_t payload_type,
5187 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005188 // kRedRtxPayloadType must currently be unused.
5189 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5190
noahricd10a68e2015-07-10 11:27:55 -07005191 // Add a RED RTX codec.
5192 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005193 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005194 recv_parameters_.codecs.push_back(red_rtx_codec);
5195 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005196
5197 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5198 const size_t kDataLength = 12;
5199 uint8_t data[kDataLength];
5200 memset(data, 0, sizeof(data));
5201
5202 rtc::Set8(data, 1, payload_type);
5203 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005204 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005205 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005206
5207 if (expect_created_receive_stream) {
5208 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5209 << "Should have created a receive stream for payload type: "
5210 << payload_type;
5211 } else {
5212 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5213 << "Shouldn't have created a receive stream for payload type: "
5214 << payload_type;
5215 }
5216}
5217
Åsa Persson2c7149b2018-10-15 09:36:10 +02005218class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5219 public:
5220 WebRtcVideoChannelDiscardUnknownSsrcTest()
5221 : WebRtcVideoChannelTest(
5222 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5223};
5224
5225TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5226 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5227 false /* expect_created_receive_stream */);
5228}
5229
eladalonf1841382017-06-12 01:16:46 -07005230TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005231 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5232 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005233}
5234
eladalonf1841382017-06-12 01:16:46 -07005235TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005236 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5237 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005238}
5239
eladalonf1841382017-06-12 01:16:46 -07005240TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005241 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005242 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5243 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5244 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5245 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005246}
5247
eladalonf1841382017-06-12 01:16:46 -07005248TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005249 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5250 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005251}
5252
eladalonf1841382017-06-12 01:16:46 -07005253TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005254 FlexfecPacketDoesntCreateUnsignalledStream) {
5255 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5256 false /* expect_created_receive_stream */);
5257}
5258
eladalonf1841382017-06-12 01:16:46 -07005259TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005260 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5261 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005262}
5263
mzanaty8a855d62017-02-17 15:46:43 -08005264// Test that receiving any unsignalled SSRC works even if it changes.
5265// The first unsignalled SSRC received will create a default receive stream.
5266// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005267TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005268 // Allow receiving VP8, VP9, H264 (if enabled).
5269 cricket::VideoRecvParameters parameters;
5270 parameters.codecs.push_back(GetEngineCodec("VP8"));
5271 parameters.codecs.push_back(GetEngineCodec("VP9"));
5272
5273#if defined(WEBRTC_USE_H264)
5274 cricket::VideoCodec H264codec(126, "H264");
5275 parameters.codecs.push_back(H264codec);
5276#endif
5277
5278 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5279 // No receive streams yet.
5280 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5281 cricket::FakeVideoRenderer renderer;
5282 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5283
5284 // Receive VP8 packet on first SSRC.
5285 uint8_t data[kMinRtpPacketLen];
5286 cricket::RtpHeader rtpHeader;
5287 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5288 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005289 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005290 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5291 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005292 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005293 // VP8 packet should create default receive stream.
5294 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005295 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005296 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5297 // Verify that the receive stream sinks to a renderer.
5298 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5299 webrtc::kVideoRotation_0);
5300 recv_stream->InjectFrame(video_frame);
5301 EXPECT_EQ(1, renderer.num_rendered_frames());
5302
5303 // Receive VP9 packet on second SSRC.
5304 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005305 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005306 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5307 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005308 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005309 // VP9 packet should replace the default receive SSRC.
5310 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5311 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5312 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5313 // Verify that the receive stream sinks to a renderer.
5314 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005315 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005316 recv_stream->InjectFrame(video_frame2);
5317 EXPECT_EQ(2, renderer.num_rendered_frames());
5318
5319#if defined(WEBRTC_USE_H264)
5320 // Receive H264 packet on third SSRC.
5321 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005322 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005323 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5324 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005325 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005326 // H264 packet should replace the default receive SSRC.
5327 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5328 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5329 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5330 // Verify that the receive stream sinks to a renderer.
5331 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005332 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005333 recv_stream->InjectFrame(video_frame3);
5334 EXPECT_EQ(3, renderer.num_rendered_frames());
5335#endif
5336}
5337
brandtr0dc57ea2017-05-29 23:33:31 -07005338// This test verifies that when a new default stream is created for a new
5339// unsignaled SSRC, the new stream does not overwrite any old stream that had
5340// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005341TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005342 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5343 cricket::VideoRecvParameters parameters;
5344 parameters.codecs.push_back(GetEngineCodec("VP8"));
5345 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5346
5347 // No streams signaled and no packets received, so we should not have any
5348 // stream objects created yet.
5349 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5350
5351 // Receive packet on an unsignaled SSRC.
5352 uint8_t data[kMinRtpPacketLen];
5353 cricket::RtpHeader rtp_header;
5354 rtp_header.payload_type = GetEngineCodec("VP8").id;
5355 rtp_header.seq_num = rtp_header.timestamp = 0;
5356 rtp_header.ssrc = kSsrcs3[0];
5357 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5358 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005359 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005360 // Default receive stream should be created.
5361 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5362 FakeVideoReceiveStream* recv_stream0 =
5363 fake_call_->GetVideoReceiveStreams()[0];
5364 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5365
5366 // Signal the SSRC.
5367 EXPECT_TRUE(
5368 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5369 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5370 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5371 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5372
5373 // Receive packet on a different unsignaled SSRC.
5374 rtp_header.ssrc = kSsrcs3[1];
5375 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5376 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005377 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005378 // New default receive stream should be created, but old stream should remain.
5379 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5380 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5381 FakeVideoReceiveStream* recv_stream1 =
5382 fake_call_->GetVideoReceiveStreams()[1];
5383 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5384}
5385
Seth Hampson7c682e02018-05-04 16:28:15 -07005386TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005387 AddSendStream();
5388
Tommi85959932018-02-07 19:26:06 +01005389 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005390 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005391 cricket::VideoFormat capture_format_hd =
5392 capturer.GetSupportedFormats()->front();
5393 EXPECT_EQ(1280, capture_format_hd.width);
5394 EXPECT_EQ(720, capture_format_hd.height);
5395 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5396 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005397 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005398
perkjfa10b552016-10-02 23:45:26 -07005399 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005400 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005401
5402 // TODO(skvlad): Resolve the inconsistency between the interpretation
5403 // of the global bitrate limit for audio and video:
5404 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5405 // max_bandwidth_bps = -1 - remove the bandwidth limit
5406 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005407 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005408
perkjfa10b552016-10-02 23:45:26 -07005409 SetAndExpectMaxBitrate(1000, 0, 1000);
5410 SetAndExpectMaxBitrate(1000, 800, 800);
5411 SetAndExpectMaxBitrate(600, 800, 600);
5412 SetAndExpectMaxBitrate(0, 800, 800);
5413 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005414
Niels Möllerff40b142018-04-09 08:49:14 +02005415 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005416}
5417
eladalonf1841382017-06-12 01:16:46 -07005418TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005419 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005420 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005421 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005422
5423 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005424 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005425 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005426}
5427
eladalonf1841382017-06-12 01:16:46 -07005428TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005429 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005430 FakeVideoSendStream* stream = AddSendStream();
5431
Seth Hampson7c682e02018-05-04 16:28:15 -07005432 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5433 EXPECT_EQ(1UL, parameters.encodings.size());
5434 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5435 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5436
5437 // Note that this is testing the behavior of the FakeVideoSendStream, which
5438 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5439 // we are just testing the behavior of
5440 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005441 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5442 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005443
5444 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5445 // by this amount.
5446 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5447 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5448 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5449 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5450
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005451 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5452 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5453 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5454}
5455
5456TEST_F(WebRtcVideoChannelTest,
5457 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5458 FakeVideoSendStream* stream = AddSendStream();
5459
5460 // Note that this is testing the behavior of the FakeVideoSendStream, which
5461 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5462 // we are just testing the behavior of
5463 // EncoderStreamFactory::CreateEncoderStreams.
5464 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5465 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5466
5467 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5468 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5469 EXPECT_EQ(1UL, parameters.encodings.size());
5470 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5471 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5472
5473 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5474 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5475 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5476}
5477
5478TEST_F(WebRtcVideoChannelTest,
5479 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5480 send_parameters_.max_bandwidth_bps = 99999;
5481 FakeVideoSendStream* stream = AddSendStream();
5482 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5483 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5484 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5485 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5486 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5487 stream->GetVideoStreams()[0].max_bitrate_bps);
5488
5489 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5490 // adjusted down.
5491 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5492 EXPECT_EQ(1UL, parameters.encodings.size());
5493 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5494 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5495 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5496 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5497 stream->GetVideoStreams()[0].min_bitrate_bps);
5498 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5499 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005500}
5501
Åsa Persson8c1bf952018-09-13 10:42:19 +02005502TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5503 FakeVideoSendStream* stream = AddSendStream();
5504
5505 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5506 EXPECT_EQ(1UL, parameters.encodings.size());
5507 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5508 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5509
5510 // Note that this is testing the behavior of the FakeVideoSendStream, which
5511 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5512 // we are just testing the behavior of
5513 // EncoderStreamFactory::CreateEncoderStreams.
5514 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5515 EXPECT_EQ(kDefaultVideoMaxFramerate,
5516 stream->GetVideoStreams()[0].max_framerate);
5517
5518 // Set max framerate and check that VideoStream.max_framerate is set.
5519 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5520 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5521 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5522 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5523
5524 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5525 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5526}
5527
Åsa Persson23eba222018-10-02 14:47:06 +02005528TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5529 FakeVideoSendStream* stream = AddSendStream();
5530
5531 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5532 EXPECT_EQ(1UL, parameters.encodings.size());
5533 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5534 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5535
5536 // Note that this is testing the behavior of the FakeVideoSendStream, which
5537 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5538 // we are just testing the behavior of
5539 // EncoderStreamFactory::CreateEncoderStreams.
5540 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5541 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5542
5543 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5544 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5545 parameters.encodings[0].num_temporal_layers = 2;
5546 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5547
5548 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5549 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5550}
5551
Seth Hampson7c682e02018-05-04 16:28:15 -07005552TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005553 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005554 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005555 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005556 // Two or more encodings should result in failure.
5557 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005558 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005559 // Zero encodings should also fail.
5560 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005561 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005562}
5563
Zach Stein3ca452b2018-01-18 10:01:24 -08005564TEST_F(WebRtcVideoChannelTest,
5565 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5566 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5567 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5568 AddSendStream(sp);
5569
5570 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5571
5572 // Additional encodings should result in failure.
5573 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005574 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005575 // Zero encodings should also fail.
5576 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005577 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005578}
5579
deadbeeffb2aced2017-01-06 23:05:37 -08005580// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005581TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005582 AddSendStream();
5583 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005584 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005585 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005586}
5587
Seth Hampson24722b32017-12-22 09:36:42 -08005588// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5589// a value <= 0, setting the parameters returns false.
5590TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5591 AddSendStream();
5592 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5593 EXPECT_EQ(1UL, parameters.encodings.size());
5594 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5595 parameters.encodings[0].bitrate_priority);
5596
5597 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005598 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005599 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005600 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005601}
5602
5603// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5604// properly on the VideoChannel and propogates down to the video encoder.
5605TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5606 AddSendStream();
5607 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5608 EXPECT_EQ(1UL, parameters.encodings.size());
5609 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5610 parameters.encodings[0].bitrate_priority);
5611
5612 // Change the value and set it on the VideoChannel.
5613 double new_bitrate_priority = 2.0;
5614 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005615 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005616
5617 // Verify that the encoding parameters bitrate_priority is set for the
5618 // VideoChannel.
5619 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5620 EXPECT_EQ(1UL, parameters.encodings.size());
5621 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5622
5623 // Verify that the new value propagated down to the encoder.
5624 std::vector<FakeVideoSendStream*> video_send_streams =
5625 fake_call_->GetVideoSendStreams();
5626 EXPECT_EQ(1UL, video_send_streams.size());
5627 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5628 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5629 // appropriately.
5630 EXPECT_EQ(new_bitrate_priority,
5631 video_send_stream->GetEncoderConfig().bitrate_priority);
5632 // Check that the vector of VideoStreams also was propagated correctly. Note
5633 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5634 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005635 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005636 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5637}
5638
5639// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5640// VideoChannel and the value propogates to the video encoder with all simulcast
5641// streams.
5642TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5643 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005644 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005645 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5646 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5647 AddSendStream(stream_params);
5648 uint32_t primary_ssrc = stream_params.first_ssrc();
5649
Tommi85959932018-02-07 19:26:06 +01005650 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5651 // frame. This creates multiple VideoStreams for all simulcast layers when
5652 // reconfiguring, and allows us to test this behavior.
5653 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005654 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005655 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005656 EXPECT_EQ(cricket::CS_RUNNING,
5657 capturer.Start(cricket::VideoFormat(
5658 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5659 cricket::FOURCC_I420)));
5660 channel_->SetSend(true);
5661 EXPECT_TRUE(capturer.CaptureFrame());
5662 // Get and set the rtp encoding parameters.
5663 webrtc::RtpParameters parameters =
5664 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005665 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005666 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5667 parameters.encodings[0].bitrate_priority);
5668 // Change the value and set it on the VideoChannel.
5669 double new_bitrate_priority = 2.0;
5670 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005671 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005672
5673 // Verify that the encoding parameters priority is set on the VideoChannel.
5674 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005675 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005676 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5677
5678 // Verify that the new value propagated down to the encoder.
5679 std::vector<FakeVideoSendStream*> video_send_streams =
5680 fake_call_->GetVideoSendStreams();
5681 EXPECT_EQ(1UL, video_send_streams.size());
5682 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5683 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5684 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005685 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005686 video_send_stream->GetEncoderConfig().number_of_streams);
5687 EXPECT_EQ(new_bitrate_priority,
5688 video_send_stream->GetEncoderConfig().bitrate_priority);
5689 // Check that the vector of VideoStreams also propagated correctly. The
5690 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5691 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005692 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005693 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005694 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5695 // Since we are only setting bitrate priority per-sender, the other
5696 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005697 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005698 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005699 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005700 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005701 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005702}
5703
Tim Haloun648d28a2018-10-18 16:52:22 -07005704// RTCRtpEncodingParameters.network_priority must be one of a few values
5705// derived from the default priority, corresponding to very-low, low, medium,
5706// or high.
5707TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5708 AddSendStream();
5709 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5710 EXPECT_EQ(1UL, parameters.encodings.size());
5711 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5712 parameters.encodings[0].network_priority);
5713
5714 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5715 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5716 for (auto it : good_values) {
5717 parameters.encodings[0].network_priority = it;
5718 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5719 }
5720 for (auto it : bad_values) {
5721 parameters.encodings[0].network_priority = it;
5722 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5723 }
5724}
5725
Åsa Persson8c1bf952018-09-13 10:42:19 +02005726TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5727 const size_t kNumSimulcastStreams = 3;
5728 SetUpSimulcast(true, false);
5729
5730 // Get and set the rtp encoding parameters.
5731 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5732 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5733 for (const auto& encoding : parameters.encodings) {
5734 EXPECT_FALSE(encoding.max_framerate);
5735 }
5736
5737 // Change the value and set it on the VideoChannel.
5738 parameters.encodings[0].max_framerate = 10;
5739 parameters.encodings[1].max_framerate = 20;
5740 parameters.encodings[2].max_framerate = 25;
5741 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5742
5743 // Verify that the bitrates are set on the VideoChannel.
5744 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5745 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5746 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5747 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5748 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5749}
5750
Åsa Persson23eba222018-10-02 14:47:06 +02005751TEST_F(WebRtcVideoChannelTest,
5752 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5753 const size_t kNumSimulcastStreams = 3;
5754 SetUpSimulcast(true, false);
5755
5756 // Get and set the rtp encoding parameters.
5757 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5758 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5759
5760 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5761 parameters.encodings[0].num_temporal_layers = 0;
5762 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5763 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5764 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5765 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5766 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5767}
5768
5769TEST_F(WebRtcVideoChannelTest,
5770 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5771 const size_t kNumSimulcastStreams = 3;
5772 SetUpSimulcast(true, false);
5773
5774 // Get and set the rtp encoding parameters.
5775 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5776 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5777
5778 // No/all layers should be set.
5779 parameters.encodings[0].num_temporal_layers = 1;
5780 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5781 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5782
5783 // Different values not supported.
5784 parameters.encodings[0].num_temporal_layers = 1;
5785 parameters.encodings[1].num_temporal_layers = 2;
5786 parameters.encodings[2].num_temporal_layers = 2;
5787 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5788 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5789}
5790
5791TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5792 const size_t kNumSimulcastStreams = 3;
5793 SetUpSimulcast(true, false);
5794
5795 // Get and set the rtp encoding parameters.
5796 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5797 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5798 for (const auto& encoding : parameters.encodings)
5799 EXPECT_FALSE(encoding.num_temporal_layers);
5800
5801 // Change the value and set it on the VideoChannel.
5802 parameters.encodings[0].num_temporal_layers = 3;
5803 parameters.encodings[1].num_temporal_layers = 3;
5804 parameters.encodings[2].num_temporal_layers = 3;
5805 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5806
5807 // Verify that the number of temporal layers are set on the VideoChannel.
5808 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5809 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5810 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5811 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5812 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5813}
5814
5815TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5816 const size_t kNumSimulcastStreams = 3;
5817 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5818
5819 // Send a full size frame so all simulcast layers are used when reconfiguring.
5820 FakeVideoCapturerWithTaskQueue capturer;
5821 VideoOptions options;
5822 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5823 EXPECT_EQ(cricket::CS_RUNNING,
5824 capturer.Start(capturer.GetSupportedFormats()->front()));
5825 channel_->SetSend(true);
5826 EXPECT_TRUE(capturer.CaptureFrame());
5827
5828 // Get and set the rtp encoding parameters.
5829 // Change the value and set it on the VideoChannel.
5830 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5831 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5832 parameters.encodings[0].num_temporal_layers = 2;
5833 parameters.encodings[1].num_temporal_layers = 2;
5834 parameters.encodings[2].num_temporal_layers = 2;
5835 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5836
5837 // Verify that the new value is propagated down to the encoder.
5838 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5839 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5840 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5841 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5842 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5843 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5844 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5845 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5846
5847 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5848 // VideoStreams are created appropriately for the simulcast case.
5849 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5850 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5851 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5852 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5853
5854 // No parameter changed, encoder should not be reconfigured.
5855 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5856 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5857
5858 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5859}
5860
5861TEST_F(WebRtcVideoChannelTest,
5862 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5863 const size_t kDefaultNumTemporalLayers = 3;
5864 const size_t kNumSimulcastStreams = 3;
5865 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5866
5867 // Send a full size frame so all simulcast layers are used when reconfiguring.
5868 FakeVideoCapturerWithTaskQueue capturer;
5869 VideoOptions options;
5870 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5871 EXPECT_EQ(cricket::CS_RUNNING,
5872 capturer.Start(capturer.GetSupportedFormats()->front()));
5873 channel_->SetSend(true);
5874 EXPECT_TRUE(capturer.CaptureFrame());
5875
5876 // Change rtp encoding parameters, num_temporal_layers not changed.
5877 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5878 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5879 parameters.encodings[0].min_bitrate_bps = 33000;
5880 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5881
5882 // Verify that no value is propagated down to the encoder.
5883 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5884 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5885 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5886 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5887 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5888 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5889
5890 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5891 // VideoStreams are created appropriately for the simulcast case.
5892 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5893 EXPECT_EQ(kDefaultNumTemporalLayers,
5894 stream->GetVideoStreams()[0].num_temporal_layers);
5895 EXPECT_EQ(kDefaultNumTemporalLayers,
5896 stream->GetVideoStreams()[1].num_temporal_layers);
5897 EXPECT_EQ(kDefaultNumTemporalLayers,
5898 stream->GetVideoStreams()[2].num_temporal_layers);
5899
5900 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5901}
5902
Åsa Persson8c1bf952018-09-13 10:42:19 +02005903TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5904 const size_t kNumSimulcastStreams = 3;
5905 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5906
5907 // Send a full size frame so all simulcast layers are used when reconfiguring.
5908 FakeVideoCapturerWithTaskQueue capturer;
5909 VideoOptions options;
5910 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5911 EXPECT_EQ(cricket::CS_RUNNING,
5912 capturer.Start(capturer.GetSupportedFormats()->front()));
5913 channel_->SetSend(true);
5914 EXPECT_TRUE(capturer.CaptureFrame());
5915
5916 // Get and set the rtp encoding parameters.
5917 // Change the value and set it on the VideoChannel.
5918 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5919 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5920 parameters.encodings[0].max_framerate = 15;
5921 parameters.encodings[1].max_framerate = 25;
5922 parameters.encodings[2].max_framerate = 20;
5923 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5924
5925 // Verify that the new value propagated down to the encoder.
5926 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5927 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5928 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5929 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5930 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5931 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5932 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5933 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5934
5935 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5936 // VideoStreams are created appropriately for the simulcast case.
5937 // Currently the maximum |max_framerate| is used.
5938 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5939 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5940 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5941 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5942
5943 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5944}
5945
5946TEST_F(WebRtcVideoChannelTest,
5947 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5948 const size_t kNumSimulcastStreams = 3;
5949 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5950 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5951
5952 // Send a full size frame so all simulcast layers are used when reconfiguring.
5953 FakeVideoCapturerWithTaskQueue capturer;
5954 VideoOptions options;
5955 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5956 EXPECT_EQ(cricket::CS_RUNNING,
5957 capturer.Start(capturer.GetSupportedFormats()->front()));
5958 channel_->SetSend(true);
5959 EXPECT_TRUE(capturer.CaptureFrame());
5960
5961 // Get and set the rtp encoding parameters.
5962 // Change the value and set it on the VideoChannel.
5963 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5964 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5965 parameters.encodings[0].max_framerate = 15;
5966 parameters.encodings[2].max_framerate = 20;
5967 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5968
5969 // Verify that the new value propagated down to the encoder.
5970 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5971 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5972 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5973 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5974 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5975 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5976 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5977
5978 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5979 // VideoStreams are created appropriately for the simulcast case.
5980 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5981 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5982 EXPECT_EQ(kDefaultVideoMaxFramerate,
5983 stream->GetVideoStreams()[0].max_framerate);
5984 EXPECT_EQ(kDefaultVideoMaxFramerate,
5985 stream->GetVideoStreams()[1].max_framerate);
5986 EXPECT_EQ(kDefaultVideoMaxFramerate,
5987 stream->GetVideoStreams()[2].max_framerate);
5988
5989 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5990}
5991
Åsa Persson55659812018-06-18 17:51:32 +02005992TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5993 const size_t kNumSimulcastStreams = 3;
5994 SetUpSimulcast(true, false);
5995
5996 // Get and set the rtp encoding parameters.
5997 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5998 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5999 for (const auto& encoding : parameters.encodings) {
6000 EXPECT_FALSE(encoding.min_bitrate_bps);
6001 EXPECT_FALSE(encoding.max_bitrate_bps);
6002 }
6003
6004 // Change the value and set it on the VideoChannel.
6005 parameters.encodings[0].min_bitrate_bps = 100000;
6006 parameters.encodings[0].max_bitrate_bps = 200000;
6007 parameters.encodings[1].min_bitrate_bps = 300000;
6008 parameters.encodings[1].max_bitrate_bps = 400000;
6009 parameters.encodings[2].min_bitrate_bps = 500000;
6010 parameters.encodings[2].max_bitrate_bps = 600000;
6011 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6012
6013 // Verify that the bitrates are set on the VideoChannel.
6014 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6015 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6016 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6017 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6018 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6019 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6020 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6021 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6022}
6023
6024TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6025 const size_t kNumSimulcastStreams = 3;
6026 SetUpSimulcast(true, false);
6027
6028 // Get and set the rtp encoding parameters.
6029 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6030 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6031
6032 // Max bitrate lower than min bitrate should fail.
6033 parameters.encodings[2].min_bitrate_bps = 100000;
6034 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6035 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6036 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6037}
6038
6039// Test that min and max bitrate values set via RtpParameters are correctly
6040// propagated to the underlying encoder, and that the target is set to 3/4 of
6041// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6042// that are used if no min/max are specified).
6043TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6044 const size_t kNumSimulcastStreams = 3;
6045 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6046
6047 // Send a full size frame so all simulcast layers are used when reconfiguring.
6048 FakeVideoCapturerWithTaskQueue capturer;
6049 VideoOptions options;
6050 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6051 EXPECT_EQ(cricket::CS_RUNNING,
6052 capturer.Start(capturer.GetSupportedFormats()->front()));
6053 channel_->SetSend(true);
6054 EXPECT_TRUE(capturer.CaptureFrame());
6055
6056 // Get and set the rtp encoding parameters.
6057 // Change the value and set it on the VideoChannel.
6058 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6059 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6060 parameters.encodings[0].min_bitrate_bps = 100000;
6061 parameters.encodings[0].max_bitrate_bps = 200000;
6062 parameters.encodings[1].min_bitrate_bps = 300000;
6063 parameters.encodings[1].max_bitrate_bps = 400000;
6064 parameters.encodings[2].min_bitrate_bps = 500000;
6065 parameters.encodings[2].max_bitrate_bps = 600000;
6066 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6067
6068 // Verify that the new value propagated down to the encoder.
6069 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6070 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6071 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6072 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6073 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6074 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6075 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6076 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6077 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6078 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6079 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6080
6081 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6082 // VideoStreams are created appropriately for the simulcast case.
6083 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6084 // Target bitrate: 200000 * 3 / 4 = 150000.
6085 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6086 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6087 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6088 // Target bitrate: 400000 * 3 / 4 = 300000.
6089 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6090 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6091 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6092 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6093 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6094 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6095 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6096
6097 // No parameter changed, encoder should not be reconfigured.
6098 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6099 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6100
6101 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6102}
6103
6104// Test to only specify the min or max bitrate value for a layer via
6105// RtpParameters. The unspecified min/max and target value should be set to the
6106// simulcast default that is used if no min/max are specified.
6107TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6108 const size_t kNumSimulcastStreams = 3;
6109 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6110 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6111
6112 // Send a full size frame so all simulcast layers are used when reconfiguring.
6113 FakeVideoCapturerWithTaskQueue capturer;
6114 VideoOptions options;
6115 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6116 EXPECT_EQ(cricket::CS_RUNNING,
6117 capturer.Start(capturer.GetSupportedFormats()->front()));
6118 channel_->SetSend(true);
6119 EXPECT_TRUE(capturer.CaptureFrame());
6120
6121 // Get and set the rtp encoding parameters.
6122 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6123 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6124
6125 // Change the value and set it on the VideoChannel.
6126 // Layer 0: only configure min bitrate.
6127 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6128 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6129 // Layer 1: only configure max bitrate.
6130 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6131 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6132 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6133
6134 // Verify that the new value propagated down to the encoder.
6135 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6136 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6137 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6138 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6139 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6140 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6141 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6142 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6143 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6144 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6145
6146 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6147 // VideoStreams are created appropriately for the simulcast case.
6148 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6149 // Layer 0: min configured bitrate should overwrite min default.
6150 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6151 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6152 stream->GetVideoStreams()[0].target_bitrate_bps);
6153 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6154 stream->GetVideoStreams()[0].max_bitrate_bps);
6155 // Layer 1: max configured bitrate should overwrite max default.
6156 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6157 stream->GetVideoStreams()[1].min_bitrate_bps);
6158 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6159 stream->GetVideoStreams()[1].target_bitrate_bps);
6160 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6161 // Layer 2: min and max bitrate not configured, default expected.
6162 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6163 stream->GetVideoStreams()[2].min_bitrate_bps);
6164 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6165 stream->GetVideoStreams()[2].target_bitrate_bps);
6166 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6167 stream->GetVideoStreams()[2].max_bitrate_bps);
6168
6169 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6170}
6171
6172// Test that specifying the min (or max) bitrate value for a layer via
6173// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6174// unspecified values accordingly.
6175TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6176 const size_t kNumSimulcastStreams = 3;
6177 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6178 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6179
6180 // Send a full size frame so all simulcast layers are used when reconfiguring.
6181 FakeVideoCapturerWithTaskQueue capturer;
6182 VideoOptions options;
6183 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6184 EXPECT_EQ(cricket::CS_RUNNING,
6185 capturer.Start(capturer.GetSupportedFormats()->front()));
6186 channel_->SetSend(true);
6187 EXPECT_TRUE(capturer.CaptureFrame());
6188
6189 // Get and set the rtp encoding parameters.
6190 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6191 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6192
6193 // Change the value and set it on the VideoChannel.
6194 // For layer 0, set the min bitrate above the default max.
6195 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6196 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6197 // For layer 1, set the max bitrate below the default min.
6198 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6199 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6200 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6201
6202 // Verify that the new value propagated down to the encoder.
6203 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6204 // VideoStreams are created appropriately for the simulcast case.
6205 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6206 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6207 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6208 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6209 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6210 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6211 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6212 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6213 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6214 // Layer 2: min and max bitrate not configured, default expected.
6215 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6216 stream->GetVideoStreams()[2].min_bitrate_bps);
6217 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6218 stream->GetVideoStreams()[2].target_bitrate_bps);
6219 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6220 stream->GetVideoStreams()[2].max_bitrate_bps);
6221
6222 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6223}
6224
6225TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6226 const size_t kNumSimulcastStreams = 3;
6227 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6228 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6229
6230 // Send a full size frame so all simulcast layers are used when reconfiguring.
6231 FakeVideoCapturerWithTaskQueue capturer;
6232 VideoOptions options;
6233 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6234 EXPECT_EQ(cricket::CS_RUNNING,
6235 capturer.Start(capturer.GetSupportedFormats()->front()));
6236 channel_->SetSend(true);
6237 EXPECT_TRUE(capturer.CaptureFrame());
6238
6239 // Set max bitrate for all but the highest layer.
6240 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6241 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6242 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6243 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6244 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6245
6246 // Set max bandwidth equal to total max bitrate.
6247 send_parameters_.max_bandwidth_bps =
6248 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6249 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6250 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6251
6252 // No bitrate above the total max to give to the highest layer.
6253 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6254 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6255 stream->GetVideoStreams()[2].max_bitrate_bps);
6256
6257 // Set max bandwidth above the total max bitrate.
6258 send_parameters_.max_bandwidth_bps =
6259 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6260 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6261 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6262
6263 // The highest layer has no max bitrate set -> the bitrate above the total
6264 // max should be given to the highest layer.
6265 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6266 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6267 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6268 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6269 stream->GetVideoStreams()[2].max_bitrate_bps);
6270
6271 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6272}
6273
6274TEST_F(WebRtcVideoChannelTest,
6275 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6276 const size_t kNumSimulcastStreams = 3;
6277 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6278 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6279 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6280
6281 // Send a full size frame so all simulcast layers are used when reconfiguring.
6282 FakeVideoCapturerWithTaskQueue capturer;
6283 VideoOptions options;
6284 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6285 EXPECT_EQ(cricket::CS_RUNNING,
6286 capturer.Start(capturer.GetSupportedFormats()->front()));
6287 channel_->SetSend(true);
6288 EXPECT_TRUE(capturer.CaptureFrame());
6289
6290 // Set max bitrate for the highest layer.
6291 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6292 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6293 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6294 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6295
6296 // Set max bandwidth above the total max bitrate.
6297 send_parameters_.max_bandwidth_bps =
6298 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6299 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6300 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6301
6302 // The highest layer has the max bitrate set -> the bitrate above the total
6303 // max should not be given to the highest layer.
6304 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6305 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6306 stream->GetVideoStreams()[2].max_bitrate_bps);
6307
6308 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6309}
6310
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006311// Test that min and max bitrate values set via RtpParameters are correctly
6312// propagated to the underlying encoder for a single stream.
6313TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6314 FakeVideoSendStream* stream = AddSendStream();
6315 EXPECT_TRUE(channel_->SetSend(true));
6316 EXPECT_TRUE(stream->IsSending());
6317
6318 // Set min and max bitrate.
6319 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6320 EXPECT_EQ(1u, parameters.encodings.size());
6321 parameters.encodings[0].min_bitrate_bps = 80000;
6322 parameters.encodings[0].max_bitrate_bps = 150000;
6323 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6324
6325 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6326 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6327 EXPECT_EQ(1u, encoder_config.number_of_streams);
6328 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6329 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6330 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6331
6332 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6333 // VideoStreams are created appropriately.
6334 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6335 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6336 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6337 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6338}
6339
6340// Test the default min and max bitrate value are correctly propagated to the
6341// underlying encoder for a single stream (when the values are not set via
6342// RtpParameters).
6343TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6344 FakeVideoSendStream* stream = AddSendStream();
6345 EXPECT_TRUE(channel_->SetSend(true));
6346 EXPECT_TRUE(stream->IsSending());
6347
6348 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6349 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6350 EXPECT_EQ(1u, encoder_config.number_of_streams);
6351 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6352 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6353 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6354
6355 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6356 // VideoStreams are created appropriately.
6357 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6358 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6359 stream->GetVideoStreams()[0].min_bitrate_bps);
6360 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6361 stream->GetVideoStreams()[0].min_bitrate_bps);
6362 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6363 stream->GetVideoStreams()[0].target_bitrate_bps);
6364}
6365
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006366// Test that a stream will not be sending if its encoding is made inactive
6367// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006368TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006369 FakeVideoSendStream* stream = AddSendStream();
6370 EXPECT_TRUE(channel_->SetSend(true));
6371 EXPECT_TRUE(stream->IsSending());
6372
6373 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006374 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006375 ASSERT_EQ(1u, parameters.encodings.size());
6376 ASSERT_TRUE(parameters.encodings[0].active);
6377 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006378 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006379 EXPECT_FALSE(stream->IsSending());
6380
6381 // Now change it back to active and verify we resume sending.
6382 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006383 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006384 EXPECT_TRUE(stream->IsSending());
6385}
6386
Seth Hampson8234ead2018-02-02 15:16:24 -08006387// Tests that when active is updated for any simulcast layer then the send
6388// stream's sending state will be updated and it will be reconfigured with the
6389// new appropriate active simulcast streams.
6390TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6391 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006392 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006393 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6394 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6395 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6396 uint32_t primary_ssrc = stream_params.first_ssrc();
6397
Tommi85959932018-02-07 19:26:06 +01006398 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6399 // frame. This allows us to test that ReconfigureEncoder is called
6400 // appropriately.
6401 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006402 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006403 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006404 EXPECT_EQ(cricket::CS_RUNNING,
6405 capturer.Start(cricket::VideoFormat(
6406 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6407 cricket::FOURCC_I420)));
6408 channel_->SetSend(true);
6409 EXPECT_TRUE(capturer.CaptureFrame());
6410
6411 // Check that all encodings are initially active.
6412 webrtc::RtpParameters parameters =
6413 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006414 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006415 EXPECT_TRUE(parameters.encodings[0].active);
6416 EXPECT_TRUE(parameters.encodings[1].active);
6417 EXPECT_TRUE(parameters.encodings[2].active);
6418 EXPECT_TRUE(fake_video_send_stream->IsSending());
6419
6420 // Only turn on only the middle stream.
6421 parameters.encodings[0].active = false;
6422 parameters.encodings[1].active = true;
6423 parameters.encodings[2].active = false;
6424 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6425 // Verify that the active fields are set on the VideoChannel.
6426 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006427 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006428 EXPECT_FALSE(parameters.encodings[0].active);
6429 EXPECT_TRUE(parameters.encodings[1].active);
6430 EXPECT_FALSE(parameters.encodings[2].active);
6431 // Check that the VideoSendStream is updated appropriately. This means its
6432 // send state was updated and it was reconfigured.
6433 EXPECT_TRUE(fake_video_send_stream->IsSending());
6434 std::vector<webrtc::VideoStream> simulcast_streams =
6435 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006436 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006437 EXPECT_FALSE(simulcast_streams[0].active);
6438 EXPECT_TRUE(simulcast_streams[1].active);
6439 EXPECT_FALSE(simulcast_streams[2].active);
6440
6441 // Turn off all streams.
6442 parameters.encodings[0].active = false;
6443 parameters.encodings[1].active = false;
6444 parameters.encodings[2].active = false;
6445 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6446 // Verify that the active fields are set on the VideoChannel.
6447 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006448 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006449 EXPECT_FALSE(parameters.encodings[0].active);
6450 EXPECT_FALSE(parameters.encodings[1].active);
6451 EXPECT_FALSE(parameters.encodings[2].active);
6452 // Check that the VideoSendStream is off.
6453 EXPECT_FALSE(fake_video_send_stream->IsSending());
6454 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006455 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006456 EXPECT_FALSE(simulcast_streams[0].active);
6457 EXPECT_FALSE(simulcast_streams[1].active);
6458 EXPECT_FALSE(simulcast_streams[2].active);
6459
Niels Möllerff40b142018-04-09 08:49:14 +02006460 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006461}
6462
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006463// Test that if a stream is reconfigured (due to a codec change or other
6464// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006465TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006466 InactiveStreamDoesntStartSendingWhenReconfigured) {
6467 // Set an initial codec list, which will be modified later.
6468 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006469 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6470 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006471 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6472
6473 FakeVideoSendStream* stream = AddSendStream();
6474 EXPECT_TRUE(channel_->SetSend(true));
6475 EXPECT_TRUE(stream->IsSending());
6476
6477 // Get current parameters and change "active" to false.
6478 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6479 ASSERT_EQ(1u, parameters.encodings.size());
6480 ASSERT_TRUE(parameters.encodings[0].active);
6481 parameters.encodings[0].active = false;
6482 EXPECT_EQ(1u, GetFakeSendStreams().size());
6483 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006484 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006485 EXPECT_FALSE(stream->IsSending());
6486
6487 // Reorder the codec list, causing the stream to be reconfigured.
6488 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006489 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6490 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006491 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6492 auto new_streams = GetFakeSendStreams();
6493 // Assert that a new underlying stream was created due to the codec change.
6494 // Otherwise, this test isn't testing what it set out to test.
6495 EXPECT_EQ(1u, GetFakeSendStreams().size());
6496 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6497
6498 // Verify that we still are not sending anything, due to the inactive
6499 // encoding.
6500 EXPECT_FALSE(new_streams[0]->IsSending());
6501}
6502
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006503// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006504TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006505 AddSendStream();
6506 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006507 parameters.codecs.push_back(GetEngineCodec("VP8"));
6508 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006509 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6510
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006511 webrtc::RtpParameters rtp_parameters =
6512 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006513 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006514 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6515 rtp_parameters.codecs[0]);
6516 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6517 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006518}
6519
Florent Castellidacec712018-05-24 16:24:21 +02006520// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6521TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6522 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6523 params.cname = "rtcpcname";
6524 AddSendStream(params);
6525
6526 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6527 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6528}
6529
deadbeeffb2aced2017-01-06 23:05:37 -08006530// Test that RtpParameters for send stream has one encoding and it has
6531// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006532TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006533 AddSendStream();
6534
6535 webrtc::RtpParameters rtp_parameters =
6536 channel_->GetRtpSendParameters(last_ssrc_);
6537 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006538 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006539}
6540
Florent Castelliabe301f2018-06-12 18:33:49 +02006541TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6542 AddSendStream();
6543
6544 webrtc::RtpParameters rtp_parameters =
6545 channel_->GetRtpSendParameters(last_ssrc_);
6546 rtp_parameters.header_extensions.emplace_back();
6547
6548 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6549
6550 webrtc::RTCError result =
6551 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6552 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6553}
6554
Florent Castelli87b3c512018-07-18 16:00:28 +02006555TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6556 AddSendStream();
6557
6558 FakeVideoCapturerWithTaskQueue capturer;
6559 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6560
6561 webrtc::RtpParameters rtp_parameters =
6562 channel_->GetRtpSendParameters(last_ssrc_);
6563 EXPECT_EQ(rtp_parameters.degradation_preference,
6564 webrtc::DegradationPreference::BALANCED);
6565 rtp_parameters.degradation_preference =
6566 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6567
6568 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6569
6570 webrtc::RtpParameters updated_rtp_parameters =
6571 channel_->GetRtpSendParameters(last_ssrc_);
6572 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6573 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6574
6575 // Remove the source since it will be destroyed before the channel
6576 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6577}
6578
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006579// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006580TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006581 AddSendStream();
6582 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006583 parameters.codecs.push_back(GetEngineCodec("VP8"));
6584 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006585 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6586
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006587 webrtc::RtpParameters initial_params =
6588 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006589
6590 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006591 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006592
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006593 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6594 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6595}
6596
6597// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006598TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006599 AddRecvStream();
6600 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006601 parameters.codecs.push_back(GetEngineCodec("VP8"));
6602 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006603 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6604
6605 webrtc::RtpParameters rtp_parameters =
6606 channel_->GetRtpReceiveParameters(last_ssrc_);
6607 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006608 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6609 rtp_parameters.codecs[0]);
6610 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6611 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006612}
6613
johan073ece42016-08-26 02:59:47 -07006614#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006615TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006616#else
eladalonf1841382017-06-12 01:16:46 -07006617TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006618#endif
johan3859c892016-08-05 09:19:25 -07006619 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006620 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006621 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006622 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006623 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006624 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006625 parameters.codecs.push_back(kH264sprop2);
6626 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6627
6628 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6629 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6630 webrtc::RtpParameters rtp_parameters =
6631 channel_->GetRtpReceiveParameters(last_ssrc_);
6632 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6633 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6634 ASSERT_EQ(2u, cfg.decoders.size());
6635 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006636 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006637 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006638 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6639 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006640 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006641
6642 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006643 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006644 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006645 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6646 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006647 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006648}
6649
sakal1fd95952016-06-22 00:46:15 -07006650// Test that RtpParameters for receive stream has one encoding and it has
6651// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006652TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006653 AddRecvStream();
6654
6655 webrtc::RtpParameters rtp_parameters =
6656 channel_->GetRtpReceiveParameters(last_ssrc_);
6657 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006658 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006659}
6660
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006661// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006662TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006663 AddRecvStream();
6664 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006665 parameters.codecs.push_back(GetEngineCodec("VP8"));
6666 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006667 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6668
6669 webrtc::RtpParameters initial_params =
6670 channel_->GetRtpReceiveParameters(last_ssrc_);
6671
6672 // We should be able to set the params we just got.
6673 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6674
6675 // ... And this shouldn't change the params returned by
6676 // GetRtpReceiveParameters.
6677 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006678}
6679
deadbeef3bc15102017-04-20 19:25:07 -07006680// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6681// aren't signaled. It should always return an empty "RtpEncodingParameters",
6682// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006683TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006684 // Call necessary methods to configure receiving a default stream as
6685 // soon as it arrives.
6686 cricket::VideoRecvParameters parameters;
6687 parameters.codecs.push_back(GetEngineCodec("VP8"));
6688 parameters.codecs.push_back(GetEngineCodec("VP9"));
6689 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6690
6691 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6692 // stream. Should return nothing.
6693 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6694
6695 // Set a sink for an unsignaled stream.
6696 cricket::FakeVideoRenderer renderer;
6697 // Value of "0" means "unsignaled stream".
6698 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6699
6700 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6701 // in this method means "unsignaled stream".
6702 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6703 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6704 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6705
6706 // Receive VP8 packet.
6707 uint8_t data[kMinRtpPacketLen];
6708 cricket::RtpHeader rtpHeader;
6709 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6710 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6711 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6712 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6713 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006714 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006715
6716 // The |ssrc| member should still be unset.
6717 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6718 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6719 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6720}
6721
eladalonf1841382017-06-12 01:16:46 -07006722void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006723 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006724 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006725
6726 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006727 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006728 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006729 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006730
6731 if (receiver_first) {
6732 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6733 std::vector<FakeVideoReceiveStream*> receive_streams =
6734 fake_call_->GetVideoReceiveStreams();
6735 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006736 // Default local SSRC when we have no sender.
6737 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6738 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006739 }
6740 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6741 if (!receiver_first)
6742 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6743 std::vector<FakeVideoReceiveStream*> receive_streams =
6744 fake_call_->GetVideoReceiveStreams();
6745 ASSERT_EQ(1u, receive_streams.size());
6746 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006747
6748 // Removing first sender should fall back to another (in this case the second)
6749 // local send stream's SSRC.
6750 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6751 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006752 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006753 ASSERT_EQ(1u, receive_streams.size());
6754 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6755
6756 // Removing the last sender should fall back to default local SSRC.
6757 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006758 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006759 ASSERT_EQ(1u, receive_streams.size());
6760 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6761 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006762}
6763
eladalonf1841382017-06-12 01:16:46 -07006764TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006765 TestReceiverLocalSsrcConfiguration(false);
6766}
6767
eladalonf1841382017-06-12 01:16:46 -07006768TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006769 TestReceiverLocalSsrcConfiguration(true);
6770}
6771
eladalonf1841382017-06-12 01:16:46 -07006772class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006773 public:
eladalonf1841382017-06-12 01:16:46 -07006774 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006775 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006776 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6777 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006778 mock_rate_allocator_factory_(
6779 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006780 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006781 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006782 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006783 decoder_factory_),
6784 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6785 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006786 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006787
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006788 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006789 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01006790 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
6791 VideoOptions(),
6792 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006793 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006794 last_ssrc_ = 123;
6795 }
6796
6797 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006798 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006799 int capture_width,
6800 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006801 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006802 size_t expected_num_streams,
6803 bool screenshare,
6804 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006805 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006806 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006807 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006808 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006809
Peter Boström0c4e06b2015-10-07 12:23:21 +02006810 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006811 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006812 ssrcs.resize(num_configured_streams);
6813
sprangf24a0642017-02-28 13:23:26 -08006814 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006815 // Send a full-size frame to trigger a stream reconfiguration to use all
6816 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006817 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006818 VideoOptions options;
6819 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006820 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006821 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006822 // Fetch the latest stream since SetVideoSend() may recreate it if the
6823 // screen content setting is changed.
6824 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006825 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006826 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006827 cricket::VideoFormat::FpsToInterval(30),
6828 cricket::FOURCC_I420)));
6829 channel_->SetSend(true);
6830 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006831
Zach Stein3ca452b2018-01-18 10:01:24 -08006832 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6833 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6834
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006835 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6836 ASSERT_EQ(expected_num_streams, video_streams.size());
6837
sprang429600d2017-01-26 06:12:26 -08006838 std::vector<webrtc::VideoStream> expected_streams;
6839 if (conference_mode) {
6840 expected_streams = GetSimulcastConfig(
6841 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006842 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006843 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006844 if (screenshare) {
6845 for (const webrtc::VideoStream& stream : expected_streams) {
6846 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006847 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6848 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006849 }
6850 }
sprang429600d2017-01-26 06:12:26 -08006851 } else {
6852 webrtc::VideoStream stream;
6853 stream.width = capture_width;
6854 stream.height = capture_height;
6855 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006856 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006857 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006858 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006859 stream.max_qp = kDefaultQpMax;
6860 expected_streams.push_back(stream);
6861 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006862
6863 ASSERT_EQ(expected_streams.size(), video_streams.size());
6864
6865 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006866 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006867 for (size_t i = 0; i < num_streams; ++i) {
6868 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6869 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6870
6871 EXPECT_GT(video_streams[i].max_framerate, 0);
6872 EXPECT_EQ(expected_streams[i].max_framerate,
6873 video_streams[i].max_framerate);
6874
6875 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6876 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6877 video_streams[i].min_bitrate_bps);
6878
6879 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6880 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6881 video_streams[i].target_bitrate_bps);
6882
6883 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6884 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6885 video_streams[i].max_bitrate_bps);
6886
6887 EXPECT_GT(video_streams[i].max_qp, 0);
6888 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6889
Sergey Silkina796a7e2018-03-01 15:11:29 +01006890 EXPECT_EQ(conference_mode,
6891 expected_streams[i].num_temporal_layers.has_value());
6892
6893 if (conference_mode) {
6894 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6895 video_streams[i].num_temporal_layers);
6896 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006897
6898 if (i == num_streams - 1) {
6899 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6900 } else {
6901 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6902 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006903 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006904
Niels Möllerff40b142018-04-09 08:49:14 +02006905 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006906 }
6907
6908 FakeVideoSendStream* AddSendStream() {
6909 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6910 }
6911
6912 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006913 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006914 EXPECT_TRUE(channel_->AddSendStream(sp));
6915 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006916 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006917 EXPECT_EQ(num_streams + 1, streams.size());
6918 return streams[streams.size() - 1];
6919 }
6920
6921 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006922 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006923 }
6924
6925 FakeVideoReceiveStream* AddRecvStream() {
6926 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6927 }
6928
6929 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006930 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006931 EXPECT_TRUE(channel_->AddRecvStream(sp));
6932 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006933 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006934 EXPECT_EQ(num_streams + 1, streams.size());
6935 return streams[streams.size() - 1];
6936 }
6937
skvlad11a9cbf2016-10-07 11:53:05 -07006938 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006939 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006940 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6941 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006942 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07006943 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006944 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006945 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006946};
6947
eladalonf1841382017-06-12 01:16:46 -07006948TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006949 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6950 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006951}
6952
eladalonf1841382017-06-12 01:16:46 -07006953TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006954 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6955 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006956}
6957
6958// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006959TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006960 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6961 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006962}
sprang429600d2017-01-26 06:12:26 -08006963
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006964TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006965 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6966 false);
6967}
6968
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006969TEST_F(WebRtcVideoChannelSimulcastTest,
6970 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01006971 webrtc::test::ScopedFieldTrials field_trials(
6972 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006973 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6974 true);
6975}
6976
eladalonf1841382017-06-12 01:16:46 -07006977TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006978 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6979 true);
6980}
6981
eladalonf1841382017-06-12 01:16:46 -07006982TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006983 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07006984 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6985 false);
6986}
6987
Yves Gereyb6a89422018-10-08 10:08:32 +02006988class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006989 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006990 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006991 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6992 }
6993 rtc::ScopedFakeClock fake_clock_;
6994};
6995
Yves Gereyb6a89422018-10-08 10:08:32 +02006996// The fake clock needs to be initialized before the call, and not
6997// destroyed until after all threads spawned by the test have been stopped.
6998// This mixin ensures that.
6999class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7000 public WebRtcVideoChannelBaseTest {};
7001
Jonas Oreland49ac5952018-09-26 16:04:32 +02007002TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7003 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7004 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7005
7006 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7007
7008 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7009 rtc::SetBE32(packet1.data() + 8, kSsrc);
7010 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7011 EXPECT_TRUE(SetDefaultCodec());
7012 EXPECT_TRUE(SetSend(true));
7013 EXPECT_EQ(0, renderer_.num_rendered_frames());
7014 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7015
7016 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7017 EXPECT_EQ(1u, sources.size());
7018 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7019 int64_t timestamp1 = sources[0].timestamp_ms();
7020
7021 // a new packet.
7022 int64_t timeDeltaMs = 1;
7023 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7024 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7025 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7026 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7027
7028 // It only keeps 10s of history.
7029 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7030 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7031 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7032}
7033
7034TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7035 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7036 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7037
7038 uint32_t kCsrc = 4321u;
7039 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7040 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7041
7042 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7043 rtc::SetBE32(packet1.data() + 8, kSsrc);
7044 rtc::SetBE32(packet1.data() + 12, kCsrc);
7045 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7046 EXPECT_TRUE(SetDefaultCodec());
7047 EXPECT_TRUE(SetSend(true));
7048 EXPECT_EQ(0, renderer_.num_rendered_frames());
7049 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7050
7051 {
7052 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7053 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7054 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7055 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7056 // 1 SSRC and 1 CSRC.
7057 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7058 [](const webrtc::RtpSource& source) {
7059 return source.source_type() ==
7060 webrtc::RtpSourceType::SSRC;
7061 }));
7062 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7063 [](const webrtc::RtpSource& source) {
7064 return source.source_type() ==
7065 webrtc::RtpSourceType::CSRC;
7066 }));
7067 }
7068 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7069
7070 // a new packet with only ssrc (i.e no csrc).
7071 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7072 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7073 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7074 rtc::SetBE32(packet2.data() + 8, kSsrc);
7075
7076 int64_t timeDeltaMs = 1;
7077 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7078 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7079
7080 {
7081 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7082 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7083 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7084 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7085 // 1 SSRC and 1 CSRC.
7086 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7087 [](const webrtc::RtpSource& source) {
7088 return source.source_type() ==
7089 webrtc::RtpSourceType::SSRC;
7090 }));
7091 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7092 [](const webrtc::RtpSource& source) {
7093 return source.source_type() ==
7094 webrtc::RtpSourceType::CSRC;
7095 }));
7096 auto ssrcSource = std::find_if(
7097 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7098 return source.source_type() == webrtc::RtpSourceType::SSRC;
7099 });
7100 auto csrcSource = std::find_if(
7101 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7102 return source.source_type() == webrtc::RtpSourceType::CSRC;
7103 });
7104
7105 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7106 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7107 }
7108
7109 // It only keeps 10s of history.
7110 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7111
7112 {
7113 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7114 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7115 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7116 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7117 [](const webrtc::RtpSource& source) {
7118 return source.source_type() ==
7119 webrtc::RtpSourceType::SSRC;
7120 }));
7121 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7122 [](const webrtc::RtpSource& source) {
7123 return source.source_type() ==
7124 webrtc::RtpSourceType::CSRC;
7125 }));
7126 }
7127
7128 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7129 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7130 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7131}
7132
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007133} // namespace cricket