blob: 93fcd4f749f4d127dd90979e8df84b3749bbedf8 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller039743e2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Seth Hampson24722b32017-12-22 09:36:42 -080018#include "api/rtpparameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080019#include "api/test/mock_video_bitrate_allocator.h"
20#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070021#include "api/test/mock_video_decoder_factory.h"
22#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020023#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080024#include "api/video/builtin_video_bitrate_allocator_factory.h"
Åsa Persson23eba222018-10-02 14:47:06 +020025#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020026#include "api/video_codecs/builtin_video_decoder_factory.h"
27#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "api/video_codecs/sdp_video_format.h"
29#include "api/video_codecs/video_decoder_factory.h"
30#include "api/video_codecs/video_encoder.h"
31#include "api/video_codecs/video_encoder_factory.h"
32#include "call/flexfec_receive_stream.h"
33#include "common_video/h264/profile_level_id.h"
34#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020035#include "media/base/fakenetworkinterface.h"
36#include "media/base/fakevideocapturer.h"
37#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020038#include "media/base/mediaconstants.h"
39#include "media/base/rtputils.h"
40#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020041#include "media/engine/constants.h"
42#include "media/engine/fakewebrtccall.h"
43#include "media/engine/fakewebrtcvideoengine.h"
44#include "media/engine/simulcast.h"
45#include "media/engine/webrtcvideoengine.h"
46#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020047#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020049#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020051#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "rtc_base/stringutils.h"
53#include "test/field_trial.h"
54#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000055
Tommi85959932018-02-07 19:26:06 +010056using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010057using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070058using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010059using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070060
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000061namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000062static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000063
noahricd10a68e2015-07-10 11:27:55 -070064static const uint8_t kRedRtxPayloadType = 125;
65
Niels Möller6557d0c2018-04-11 15:18:34 +020066static const uint32_t kTimeout = 5000U;
67static const uint32_t kDefaultReceiveSsrc = 0;
68static const uint32_t kSsrc = 1234u;
69static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
70static const int kVideoWidth = 640;
71static const int kVideoHeight = 360;
72static const int kFramerate = 30;
73
Peter Boström0c4e06b2015-10-07 12:23:21 +020074static const uint32_t kSsrcs1[] = {1};
75static const uint32_t kSsrcs3[] = {1, 2, 3};
76static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080077static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020078static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080079static const uint32_t kDefaultRecvSsrc = 0;
80
pbos@webrtc.org3c107582014-07-20 15:27:35 +000081static const char kUnsupportedExtensionName[] =
82 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000083
magjed509e4fe2016-11-18 01:34:11 -080084cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
85 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020086 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080087}
88
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000089void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
91 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
93 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
95 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
96 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080097 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
98 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000099 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
100}
101
magjed725e4842016-11-16 00:48:13 -0800102// Return true if any codec in |codecs| is an RTX codec with associated payload
103// type |payload_type|.
104bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
105 int payload_type) {
106 for (const cricket::VideoCodec& codec : codecs) {
107 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200108 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800109 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
110 &associated_payload_type) &&
111 associated_payload_type == payload_type) {
112 return true;
113 }
114 }
115 return false;
116}
117
nisseca5706d2017-09-11 02:32:16 -0700118// TODO(nisse): Duplicated in call.cc.
119const int* FindKeyByValue(const std::map<int, int>& m, int v) {
120 for (const auto& kv : m) {
121 if (kv.second == v)
122 return &kv.first;
123 }
124 return nullptr;
125}
126
Yves Gerey665174f2018-06-19 15:03:05 +0200127bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
128 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700129 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
130 payload_type) != nullptr;
131}
132
133// Check that there's an Rtx payload type for each decoder.
134bool VerifyRtxReceiveAssociations(
135 const webrtc::VideoReceiveStream::Config& config) {
136 for (const auto& decoder : config.decoders) {
137 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
138 return false;
139 }
140 return true;
141}
142
brandtrffc61182016-11-28 06:02:22 -0800143rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700144 int width,
145 int height) {
146 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
147 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800148 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700149 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000150}
151
Shao Changbine62202f2015-04-21 20:24:50 +0800152void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
153 const std::map<int, int>& rtx_types) {
154 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200155 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800156 EXPECT_TRUE(it != rtx_types.end() &&
157 it->second == config.rtp.rtx.payload_type);
158
brandtrb5f2c3f2016-10-04 23:28:39 -0700159 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
160 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800161 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700162 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800163 }
164}
kthelgason2bc68642017-02-07 07:02:22 -0800165
166cricket::MediaConfig GetMediaConfig() {
167 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100168 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800169 return media_config;
170}
nisse26e3abb2017-08-25 04:44:25 -0700171
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200172// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
173int GetMaxDefaultBitrateBps(size_t width, size_t height) {
174 if (width * height <= 320 * 240) {
175 return 600000;
176 } else if (width * height <= 640 * 480) {
177 return 1700000;
178 } else if (width * height <= 960 * 540) {
179 return 2000000;
180 } else {
181 return 2500000;
182 }
183}
184
Niels Möller731a2c22018-07-30 15:08:07 +0200185class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
186 public:
187 MOCK_METHOD2(AddOrUpdateSink,
188 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
189 const rtc::VideoSinkWants& wants));
190 MOCK_METHOD1(RemoveSink,
191 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
192};
193
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000194} // namespace
195
Yves Gerey665174f2018-06-19 15:03:05 +0200196#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200197 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200198 EXPECT_EQ((w), renderer_.width()); \
199 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ(0, renderer_.errors());
201
Yves Gerey665174f2018-06-19 15:03:05 +0200202#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200204 EXPECT_EQ((w), (r).width()); \
205 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ(0, (r).errors());
207
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000208namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700209class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000210 public:
eladalonf1841382017-06-12 01:16:46 -0700211 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
212 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700213 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700214 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200215 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
216 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200217 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200218 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200219 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800220 decoder_factory_),
221 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200222 // Ensure fake clock doesn't return 0, which will cause some initializations
223 // fail inside RTP senders.
224 fake_clock_.AdvanceTimeMicros(1);
225 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000226
227 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200228 void AssignDefaultAptRtxTypes();
229 void AssignDefaultCodec();
230
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100231 // Find the index of the codec in the engine with the given name. The codec
232 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100233 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100234
magjed509e4fe2016-11-18 01:34:11 -0800235 // Find the codec in the engine with the given name. The codec must be
236 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100237 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800238
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200239 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000240
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200241 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000242 const std::vector<VideoCodec>& codecs);
243
Peter Boströme4499152016-02-05 11:13:28 +0100244 void TestExtendedEncoderOveruse(bool use_external_encoder);
245
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200246 // Has to be the first one, so it is initialized before the call or there is a
247 // race condition in the clock access.
248 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700249 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700250 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700251 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000252 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800253 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200254 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
255 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700256 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000257 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800258 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000259};
260
eladalonf1841382017-06-12 01:16:46 -0700261TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200262 encoder_factory_->AddSupportedVideoCodecType("VP8");
263 AssignDefaultCodec();
264
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000265 std::vector<VideoCodec> engine_codecs = engine_.codecs();
266 for (size_t i = 0; i < engine_codecs.size(); ++i) {
267 if (engine_codecs[i].name != kRtxCodecName)
268 continue;
269 int associated_payload_type;
270 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000271 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000272 EXPECT_EQ(default_codec_.id, associated_payload_type);
273 return;
274 }
275 FAIL() << "No RTX codec found among default codecs.";
276}
277
eladalonf1841382017-06-12 01:16:46 -0700278TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100279 RtpCapabilities capabilities = engine_.GetCapabilities();
280 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700281 for (const RtpExtension& extension : capabilities.header_extensions) {
282 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
283 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000284 return;
285 }
286 }
287 FAIL() << "Timestamp offset extension not in header-extension list.";
288}
289
eladalonf1841382017-06-12 01:16:46 -0700290TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100291 RtpCapabilities capabilities = engine_.GetCapabilities();
292 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700293 for (const RtpExtension& extension : capabilities.header_extensions) {
294 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
295 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000296 return;
297 }
298 }
299 FAIL() << "Absolute Sender Time extension not in header-extension list.";
300}
301
eladalonf1841382017-06-12 01:16:46 -0700302TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100303 RtpCapabilities capabilities = engine_.GetCapabilities();
304 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700305 for (const RtpExtension& extension : capabilities.header_extensions) {
306 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
307 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700308 return;
309 }
310 }
311 FAIL() << "Transport sequence number extension not in header-extension list.";
312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100315 RtpCapabilities capabilities = engine_.GetCapabilities();
316 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700317 for (const RtpExtension& extension : capabilities.header_extensions) {
318 if (extension.uri == RtpExtension::kVideoRotationUri) {
319 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700320 return;
321 }
322 }
323 FAIL() << "Video Rotation extension not in header-extension list.";
324}
325
philipel1e054862018-10-08 16:13:53 +0200326class WebRtcVideoEngineTestWithGenericDescriptor
327 : public WebRtcVideoEngineTest {
328 public:
329 WebRtcVideoEngineTestWithGenericDescriptor()
330 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
331};
332
333TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
334 RtpCapabilities capabilities = engine_.GetCapabilities();
335 ASSERT_FALSE(capabilities.header_extensions.empty());
336 for (const RtpExtension& extension : capabilities.header_extensions) {
337 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
338 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
339 return;
340 }
341 }
342 FAIL() << "Generic descriptor extension not in header-extension list.";
343}
344
eladalonf1841382017-06-12 01:16:46 -0700345TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200346 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200348 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700349
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200350 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700351
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200352 std::unique_ptr<VideoMediaChannel> channel(
353 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700354 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
355
356 // Add CVO extension.
357 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800358 cricket::VideoSendParameters parameters;
359 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200360 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700361 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200362 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363
Niels Möller731a2c22018-07-30 15:08:07 +0200364 EXPECT_CALL(
365 video_source,
366 AddOrUpdateSink(testing::_,
367 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700368 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200369 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700370
371 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200372 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
374 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200375 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200376 EXPECT_CALL(
377 video_source,
378 AddOrUpdateSink(testing::_,
379 Field(&rtc::VideoSinkWants::rotation_applied, true)));
380
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200381 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700382}
383
eladalonf1841382017-06-12 01:16:46 -0700384TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200385 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800386 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200387 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800388
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200389 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800390
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200391 std::unique_ptr<VideoMediaChannel> channel(
392 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800393 // Add CVO extension.
394 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800395 cricket::VideoSendParameters parameters;
396 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800397 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700398 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800399 EXPECT_TRUE(channel->SetSendParameters(parameters));
400 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
401
Niels Möller731a2c22018-07-30 15:08:07 +0200402 // Set source.
403 EXPECT_CALL(
404 video_source,
405 AddOrUpdateSink(testing::_,
406 Field(&rtc::VideoSinkWants::rotation_applied, false)));
407 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800408}
409
eladalonf1841382017-06-12 01:16:46 -0700410TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200411 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700412
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200413 encoder_factory_->AddSupportedVideoCodecType("VP8");
414 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700415
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200416 std::unique_ptr<VideoMediaChannel> channel(
417 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700418 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
419
420 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200421 EXPECT_CALL(
422 video_source,
423 AddOrUpdateSink(testing::_,
424 Field(&rtc::VideoSinkWants::rotation_applied, true)));
425 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700426
perkjcaafdba2016-03-20 07:34:29 -0700427 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200428 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700429
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700430 // Add CVO extension.
431 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800432 cricket::VideoSendParameters parameters;
433 parameters.codecs.push_back(GetEngineCodec("VP8"));
434 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200435 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700436 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700437 // Also remove the first codec to trigger a codec change as well.
438 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200439 EXPECT_CALL(
440 video_source,
441 AddOrUpdateSink(testing::_,
442 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200443 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700444
445 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200446 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700447
448 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200449 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200450 EXPECT_CALL(
451 video_source,
452 AddOrUpdateSink(testing::_,
453 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200454 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700455}
456
eladalonf1841382017-06-12 01:16:46 -0700457TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200458 encoder_factory_->AddSupportedVideoCodecType("VP8");
459
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700460 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
461 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000462
463 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
464
465 EXPECT_FALSE(channel->SetSend(true))
466 << "Channel should not start without codecs.";
467 EXPECT_TRUE(channel->SetSend(false))
468 << "Channel should be stoppable even without set codecs.";
469}
470
eladalonf1841382017-06-12 01:16:46 -0700471TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200472 encoder_factory_->AddSupportedVideoCodecType("VP8");
473
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700474 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
475 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000476 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
477 VideoMediaInfo info;
478 channel->GetStats(&info);
479}
480
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200481TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200482 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000483
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200484 std::unique_ptr<VideoMediaChannel> channel(
485 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800486 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000487
488 EXPECT_TRUE(
489 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200490 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000491 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100492 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200493 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000494 EXPECT_EQ(cricket::CS_RUNNING,
495 capturer.Start(capturer.GetSupportedFormats()->front()));
496 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100497 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200498 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
499 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000500 kTimeout);
501
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200502 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100503 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000504
505 // Setting codecs of the same type should not reallocate any encoders
506 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800507 cricket::VideoSendParameters parameters;
508 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200509 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
512 // Remove stream previously added to free the external encoder instance.
513 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200514 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515}
516
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200517// Test that when an encoder factory supports H264, we add an RTX
518// codec for it.
519// TODO(deadbeef): This test should be updated if/when we start
520// adding RTX codecs for unrecognized codec names.
521TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800522 using webrtc::H264::ProfileLevelIdToString;
523 using webrtc::H264::ProfileLevelId;
524 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200525 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
526 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800527 *ProfileLevelIdToString(
528 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200529 webrtc::SdpVideoFormat h264_constrained_high("H264");
530 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800531 *ProfileLevelIdToString(
532 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200533 webrtc::SdpVideoFormat h264_high("H264");
534 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800535 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
536
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200537 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
538 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
539 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700540
magjed725e4842016-11-16 00:48:13 -0800541 // First figure out what payload types the test codecs got assigned.
542 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800543 // Now search for RTX codecs for them. Expect that they all have associated
544 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800545 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200546 codecs,
547 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
548 ->id));
magjed725e4842016-11-16 00:48:13 -0800549 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200550 codecs,
551 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
552 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800553 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200554 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700555}
556
Peter Boström12996152016-05-14 02:03:18 +0200557#if !defined(RTC_DISABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700558TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200559 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100560
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200561 std::unique_ptr<VideoMediaChannel> channel(
562 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100563
564 EXPECT_TRUE(
565 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
566}
Peter Boström12996152016-05-14 02:03:18 +0200567#endif // !defined(RTC_DISABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100568
eladalonf1841382017-06-12 01:16:46 -0700569TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200570 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100571 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200572 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200573 std::unique_ptr<VideoMediaChannel> channel(
574 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700575
576 EXPECT_TRUE(
577 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
578
Tommi85959932018-02-07 19:26:06 +0100579 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200580 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700581 capturer.Start(cricket::VideoFormat(1280, 720,
582 cricket::VideoFormat::FpsToInterval(60),
583 cricket::FOURCC_I420));
584 channel->SetSend(true);
585
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200586 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700587
588 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700589 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700590 for (int i = 0; i < 10; i++) {
591 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700592 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700593 int64_t interval = timestamp - last_timestamp;
594
595 // Precision changes from nanosecond to millisecond.
596 // Allow error to be no more than 1.
597 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
598
599 last_timestamp = timestamp;
600 }
601
602 capturer.Start(cricket::VideoFormat(1280, 720,
603 cricket::VideoFormat::FpsToInterval(30),
604 cricket::FOURCC_I420));
605
606 EXPECT_TRUE(capturer.CaptureFrame());
607 last_timestamp = stream->GetLastTimestamp();
608 for (int i = 0; i < 10; i++) {
609 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700610 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700611 int64_t interval = timestamp - last_timestamp;
612
613 // Precision changes from nanosecond to millisecond.
614 // Allow error to be no more than 1.
615 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
616
617 last_timestamp = timestamp;
618 }
619
620 // Remove stream previously added to free the external encoder instance.
621 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
622}
623
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200624void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
625 std::vector<VideoCodec> engine_codecs = engine_.codecs();
626 RTC_DCHECK(!engine_codecs.empty());
627 for (const cricket::VideoCodec& codec : engine_codecs) {
628 if (codec.name == "rtx") {
629 int associated_payload_type;
630 if (codec.GetParam(kCodecParamAssociatedPayloadType,
631 &associated_payload_type)) {
632 default_apt_rtx_types_[associated_payload_type] = codec.id;
633 }
634 }
635 }
636}
637
638void WebRtcVideoEngineTest::AssignDefaultCodec() {
639 std::vector<VideoCodec> engine_codecs = engine_.codecs();
640 RTC_DCHECK(!engine_codecs.empty());
641 bool codec_set = false;
642 for (const cricket::VideoCodec& codec : engine_codecs) {
643 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
644 codec.name != "ulpfec") {
645 default_codec_ = codec;
646 codec_set = true;
647 }
648 }
649
650 RTC_DCHECK(codec_set);
651}
652
Oleh Prypina40f8242017-12-21 13:32:23 +0100653size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
654 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100655 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
656 for (size_t i = 0; i < codecs.size(); ++i) {
657 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200658 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200659 continue;
660 // The tests only use H264 Constrained Baseline. Make sure we don't return
661 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200662 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200663 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200664 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
665 if (profile_level_id->profile !=
666 webrtc::H264::kProfileConstrainedBaseline) {
667 continue;
668 }
669 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100670 return i;
magjed509e4fe2016-11-18 01:34:11 -0800671 }
672 // This point should never be reached.
673 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100674 return -1;
675}
676
677cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
678 const std::string& name) const {
679 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800680}
681
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200682VideoMediaChannel*
683WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700684 VideoMediaChannel* channel = engine_.CreateChannel(
685 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200686 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800687 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200688 for (const webrtc::SdpVideoFormat& format :
689 encoder_factory_->GetSupportedFormats()) {
690 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
691 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
692 engine_codec) == parameters.codecs.end()) {
693 parameters.codecs.push_back(engine_codec);
694 }
695 }
magjed509e4fe2016-11-18 01:34:11 -0800696
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200697 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000698
699 return channel;
700}
701
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200702VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000703 const std::vector<VideoCodec>& codecs) {
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700704 VideoMediaChannel* channel = engine_.CreateChannel(
705 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200706 cricket::VideoRecvParameters parameters;
707 parameters.codecs = codecs;
708 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000709
710 return channel;
711}
712
eladalonf1841382017-06-12 01:16:46 -0700713TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200714 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000715
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200716 std::unique_ptr<VideoMediaChannel> channel(
717 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000718
Peter Boström0c4e06b2015-10-07 12:23:21 +0200719 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000720
Yves Gerey665174f2018-06-19 15:03:05 +0200721 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000722 EXPECT_TRUE(channel->SetSend(true));
723
Tommi85959932018-02-07 19:26:06 +0100724 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200725 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000726 EXPECT_EQ(cricket::CS_RUNNING,
727 capturer.Start(capturer.GetSupportedFormats()->front()));
728 EXPECT_TRUE(capturer.CaptureFrame());
729
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000731
732 // Verify that encoders are configured for simulcast through adapter
733 // (increasing resolution and only configured to send one stream each).
734 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200735 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
736 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000737 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200738 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000739 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
740 EXPECT_GT(codec_settings.width, prev_width);
741 prev_width = codec_settings.width;
742 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000743
Niels Möllerff40b142018-04-09 08:49:14 +0200744 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000745
746 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200747 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000748}
749
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200750TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
751 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200752 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000753
Niels Möller4db138e2018-04-19 09:04:13 +0200754 // Set capturer.
755 FakeVideoCapturerWithTaskQueue capturer;
756 EXPECT_EQ(cricket::CS_RUNNING,
757 capturer.Start(capturer.GetSupportedFormats()->front()));
758
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700759 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
760 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200761 cricket::VideoSendParameters parameters;
762 parameters.codecs.push_back(GetEngineCodec("H264"));
763 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000764
765 EXPECT_TRUE(
766 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200767 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
768 // Sending one frame will have allocate the encoder.
769 EXPECT_TRUE(capturer.CaptureFrame());
770
771 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000772
Anders Carlsson67537952018-05-03 11:28:29 +0200773 cricket::VideoSendParameters new_parameters;
774 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
775 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200776
777 // Sending one frame will switch encoder.
778 EXPECT_TRUE(capturer.CaptureFrame());
779
Anders Carlsson8a150d92018-05-14 12:40:04 +0200780 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000781}
782
eladalonf1841382017-06-12 01:16:46 -0700783TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000784 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200785 encoder_factory_->AddSupportedVideoCodecType("VP8");
786 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000787
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700788 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
789 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800790 cricket::VideoSendParameters parameters;
791 parameters.codecs.push_back(GetEngineCodec("VP8"));
792 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000793
Peter Boström0c4e06b2015-10-07 12:23:21 +0200794 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000795
Yves Gerey665174f2018-06-19 15:03:05 +0200796 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000797 EXPECT_TRUE(channel->SetSend(true));
798
799 // Send a fake frame, or else the media engine will configure the simulcast
800 // encoder adapter at a low-enough size that it'll only create a single
801 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100802 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200803 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804 EXPECT_EQ(cricket::CS_RUNNING,
805 capturer.Start(capturer.GetSupportedFormats()->front()));
806 EXPECT_TRUE(capturer.CaptureFrame());
807
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200808 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
809 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000810 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000812
813 channel.reset();
814 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200815 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000816}
817
eladalonf1841382017-06-12 01:16:46 -0700818TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000819 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200820 encoder_factory_->AddSupportedVideoCodecType("VP8");
821 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700823 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
824 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800825 cricket::VideoSendParameters parameters;
826 parameters.codecs.push_back(GetEngineCodec("H264"));
827 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000828
829 EXPECT_TRUE(
830 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100831
832 // Send a frame of 720p. This should trigger a "real" encoder initialization.
833 cricket::VideoFormat format(
834 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100835 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200836 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100837 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
838 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200839 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
840 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200841 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000842 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200843 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000844
845 channel.reset();
846 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000848}
849
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200850TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
851 webrtc::test::ScopedFieldTrials override_field_trials_(
852 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200853 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700854
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700855 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateChannel(
856 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200857 cricket::VideoSendParameters parameters;
858 parameters.codecs.push_back(GetEngineCodec("H264"));
859 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700860
Peter Boström0c4e06b2015-10-07 12:23:21 +0200861 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700862 EXPECT_TRUE(
863 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100864
865 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700866 cricket::VideoFormat format(
867 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100868 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200869 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100870 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
871 EXPECT_TRUE(capturer.CaptureFrame());
872
Niels Möller4db138e2018-04-19 09:04:13 +0200873 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200874 ASSERT_EQ(1u, encoder_factory_->encoders().size());
875 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
876 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700877 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200878 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200879 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700880}
881
brandtrffc61182016-11-28 06:02:22 -0800882// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700883// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800884//
885// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700886TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800887 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200888 encoder_factory_->AddSupportedVideoCodecType("VP8");
889
brandtrffc61182016-11-28 06:02:22 -0800890 auto is_flexfec = [](const VideoCodec& codec) {
891 if (codec.name == "flexfec-03")
892 return true;
893 return false;
894 };
895
896 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800897 const std::vector<VideoCodec> codecs_before = engine_.codecs();
898 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
899 codecs_before.end(), is_flexfec));
900
901 // FlexFEC is active with field trial.
902 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800903 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800904 const std::vector<VideoCodec> codecs_after = engine_.codecs();
905 EXPECT_NE(codecs_after.end(),
906 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
907}
908
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200909// Test that codecs are added in the order they are reported from the factory.
910TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
911 encoder_factory_->AddSupportedVideoCodecType("VP8");
912 const char* kFakeCodecName = "FakeCodec";
913 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000914
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200915 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100916 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200917 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
918 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000919}
920
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200921// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800922// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200923TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100924 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
925 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100926
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100927 // Set up external encoder factory with first codec, and initialize engine.
928 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
929
brandtrffc61182016-11-28 06:02:22 -0800930 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800931
932 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100933 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800934 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200935 // The codec itself and RTX should have been added.
936 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100937
938 // Check that both fake codecs are present and that the second fake codec
939 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100940 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
941 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100942 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800943}
944
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200945TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
946 const char* kFakeCodecName = "FakeCodec";
947 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
948
949 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
950 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
951}
952
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200953TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
954 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200955 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200956 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800957 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000958
kwiberg686a8ef2016-02-26 03:00:35 -0800959 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200960 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
962 EXPECT_TRUE(
963 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200964 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965
966 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200967 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200968 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000969
970 // Remove stream previously added to free the external decoder instance.
971 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200972 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000973}
974
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200975// Verifies that we can set up decoders.
976TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000977 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
978 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
979 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
980 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200981 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200982 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000983 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800984 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000985
kwiberg686a8ef2016-02-26 03:00:35 -0800986 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200987 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000988
989 EXPECT_TRUE(
990 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200991 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000992}
993
Jonas Oreland49ac5952018-09-26 16:04:32 +0200994// Tests when GetSources is called with non-existing ssrc, it will return an
995// empty list of RtpSource without crashing.
996TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
997 // Setup an recv stream with |kSsrc|.
998 encoder_factory_->AddSupportedVideoCodecType("VP8");
999 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1000 cricket::VideoRecvParameters parameters;
1001 parameters.codecs.push_back(GetEngineCodec("VP8"));
1002 std::unique_ptr<VideoMediaChannel> channel(
1003 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1004
1005 EXPECT_TRUE(
1006 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1007
1008 // Call GetSources with |kSsrc + 1| which doesn't exist.
1009 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1010 EXPECT_EQ(0u, sources.size());
1011}
1012
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001013TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1014 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1015 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001016 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001017 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001018 std::move(decoder_factory),
1019 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001020 EXPECT_EQ(0u, engine.codecs().size());
1021}
1022
1023TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1024 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001025 webrtc::MockVideoEncoderFactory* encoder_factory =
1026 new webrtc::MockVideoEncoderFactory();
1027 webrtc::MockVideoDecoderFactory* decoder_factory =
1028 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001029 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1030 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001031 WebRtcVideoEngine engine(
1032 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001033 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1034 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1035 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001036 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1037 EXPECT_EQ(0u, engine.codecs().size());
1038 EXPECT_CALL(*encoder_factory, Die());
1039 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001040 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041}
1042
1043// Test full behavior in the video engine when video codec factories of the new
1044// type are injected supporting the single codec Vp8. Check the returned codecs
1045// from the engine and that we will create a Vp8 encoder and decoder using the
1046// new factories.
1047TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1048 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001049 webrtc::MockVideoEncoderFactory* encoder_factory =
1050 new webrtc::MockVideoEncoderFactory();
1051 webrtc::MockVideoDecoderFactory* decoder_factory =
1052 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001053 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1054 new webrtc::MockVideoBitrateAllocatorFactory();
1055 EXPECT_CALL(*rate_allocator_factory,
1056 CreateVideoBitrateAllocatorProxy(Field(
1057 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1058 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001059 WebRtcVideoEngine engine(
1060 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001061 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1062 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1063 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001064 const webrtc::SdpVideoFormat vp8_format("VP8");
1065 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1066 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1067 .WillRepeatedly(testing::Return(supported_formats));
1068
1069 // Verify the codecs from the engine.
1070 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001071 // Verify default codecs has been added correctly.
1072 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001073 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001074
1075 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001076 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001077 int vp8_associated_payload;
1078 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1079 &vp8_associated_payload));
1080 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1081
1082 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1083
1084 // RTX codec for RED.
1085 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1086 int red_associated_payload;
1087 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1088 &red_associated_payload));
1089 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1090
1091 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1092
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001093 int associated_payload_type;
1094 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1095 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1096 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1097 // Verify default parameters has been added to the VP8 codec.
1098 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1099
1100 // Mock encoder creation. |engine| take ownership of the encoder.
1101 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1102 codec_info.is_hardware_accelerated = false;
1103 codec_info.has_internal_source = false;
1104 const webrtc::SdpVideoFormat format("VP8");
1105 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1106 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001107 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001108 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001109 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001110 .WillOnce(
1111 ::testing::DoAll(::testing::InvokeWithoutArgs(
1112 [&encoder_created]() { encoder_created.Set(); }),
1113 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001114
1115 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001116 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001117 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1118 .WillOnce(testing::Return(decoder));
1119
1120 // Create a call.
1121 webrtc::RtcEventLogNullImpl event_log;
1122 std::unique_ptr<webrtc::Call> call(
1123 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1124
1125 // Create send channel.
1126 const int send_ssrc = 123;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001127 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateChannel(
1128 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001129 cricket::VideoSendParameters send_parameters;
1130 send_parameters.codecs.push_back(engine_codecs.at(0));
1131 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1132 send_channel->OnReadyToSend(true);
1133 EXPECT_TRUE(
1134 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1135 EXPECT_TRUE(send_channel->SetSend(true));
1136
Niels Möller4db138e2018-04-19 09:04:13 +02001137 // Set capturer.
1138 FakeVideoCapturerWithTaskQueue capturer;
1139 EXPECT_EQ(cricket::CS_RUNNING,
1140 capturer.Start(capturer.GetSupportedFormats()->front()));
1141 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1142 // Sending one frame will allocate the encoder.
1143 EXPECT_TRUE(capturer.CaptureFrame());
1144 encoder_created.Wait(kTimeout);
1145
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001146 // Create recv channel.
1147 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001148 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1149 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001150 cricket::VideoRecvParameters recv_parameters;
1151 recv_parameters.codecs.push_back(engine_codecs.at(0));
1152 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1153 EXPECT_TRUE(recv_channel->AddRecvStream(
1154 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1155
1156 // Remove streams previously added to free the encoder and decoder instance.
1157 EXPECT_CALL(*encoder_factory, Die());
1158 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001159 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001160 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1161 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1162}
1163
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001164// Test behavior when decoder factory fails to create a decoder (returns null).
1165TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1166 // |engine| take ownership of the factories.
1167 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001168 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001169 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001170 new webrtc::MockVideoDecoderFactory();
1171 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1172 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001173 WebRtcVideoEngine engine(
1174 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001175 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1176 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1177 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001178 const webrtc::SdpVideoFormat vp8_format("VP8");
1179 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1180 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1181 .WillRepeatedly(testing::Return(supported_formats));
1182
1183 // Decoder creation fails.
1184 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1185 .WillOnce(testing::Return(nullptr));
1186
1187 // Create a call.
1188 webrtc::RtcEventLogNullImpl event_log;
1189 std::unique_ptr<webrtc::Call> call(
1190 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1191
1192 // Create recv channel.
1193 const int recv_ssrc = 321;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001194 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateChannel(
1195 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001196 cricket::VideoRecvParameters recv_parameters;
1197 recv_parameters.codecs.push_back(engine.codecs().front());
1198 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1199 EXPECT_TRUE(recv_channel->AddRecvStream(
1200 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1201
1202 // Remove streams previously added to free the encoder and decoder instance.
1203 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1204}
1205
eladalonf1841382017-06-12 01:16:46 -07001206TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001207 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001208 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001209 std::unique_ptr<VideoMediaChannel> channel(
1210 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001211 ASSERT_TRUE(
1212 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1213 cricket::VideoCodec codec = GetEngineCodec("VP8");
1214 cricket::VideoSendParameters parameters;
1215 parameters.codecs.push_back(codec);
1216 channel->OnReadyToSend(true);
1217 channel->SetSend(true);
1218 ASSERT_TRUE(channel->SetSendParameters(parameters));
1219
Tommi85959932018-02-07 19:26:06 +01001220 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001221 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001222 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001223
1224 EXPECT_EQ(cricket::CS_RUNNING,
1225 capturer.Start(capturer.GetSupportedFormats()->front()));
1226 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001227 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001228 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001229 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001230
Niels Möllerff40b142018-04-09 08:49:14 +02001231 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001232 EXPECT_TRUE(capturer.CaptureFrame());
1233 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001234 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001235
1236 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001237 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001238 EXPECT_TRUE(capturer.CaptureFrame());
1239 // Change to screen content, recreate encoder. For the simulcast encoder
1240 // adapter case, this will result in two calls since InitEncode triggers a
1241 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001242 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001243 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001244 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001245
Niels Möllerff40b142018-04-09 08:49:14 +02001246 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001247 EXPECT_TRUE(capturer.CaptureFrame());
1248 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001249 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001250
1251 options.is_screencast.emplace(false);
1252 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001253 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001254 // Change back to regular video content, update encoder. Also change
1255 // a non |is_screencast| option just to verify it doesn't affect recreation.
1256 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001257 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001258 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001259 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001260
1261 // Remove stream previously added to free the external encoder instance.
1262 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001263 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001264}
1265
Niels Möller6557d0c2018-04-11 15:18:34 +02001266class WebRtcVideoChannelBaseTest : public testing::Test {
1267 protected:
1268 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001269 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001270 webrtc::CreateBuiltinVideoDecoderFactory(),
1271 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001272
1273 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001274 // One testcase calls SetUp in a loop, only create call_ once.
1275 if (!call_) {
1276 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1277 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001278 cricket::MediaConfig media_config;
1279 // Disabling cpu overuse detection actually disables quality scaling too; it
1280 // implies DegradationPreference kMaintainResolution. Automatic scaling
1281 // needs to be disabled, otherwise, tests which check the size of received
1282 // frames become flaky.
1283 media_config.video.enable_cpu_adaptation = false;
1284 channel_.reset(engine_.CreateChannel(call_.get(), media_config,
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001285 cricket::VideoOptions(),
1286 webrtc::CryptoOptions()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001287 channel_->OnReadyToSend(true);
1288 EXPECT_TRUE(channel_.get() != NULL);
1289 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001290 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001291 cricket::VideoRecvParameters parameters;
1292 parameters.codecs = engine_.codecs();
1293 channel_->SetRecvParameters(parameters);
1294 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1295 video_capturer_.reset(CreateFakeVideoCapturer());
1296 cricket::VideoFormat format(640, 480,
1297 cricket::VideoFormat::FpsToInterval(kFramerate),
1298 cricket::FOURCC_I420);
1299 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001300 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001301 }
1302
1303 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1304 return new cricket::FakeVideoCapturerWithTaskQueue();
1305 }
1306
1307 // Utility method to setup an additional stream to send and receive video.
1308 // Used to test send and recv between two streams.
1309 void SetUpSecondStream() {
1310 SetUpSecondStreamWithNoRecv();
1311 // Setup recv for second stream.
1312 EXPECT_TRUE(channel_->AddRecvStream(
1313 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1314 // Make the second renderer available for use by a new stream.
1315 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1316 }
1317 // Setup an additional stream just to send video. Defer add recv stream.
1318 // This is required if you want to test unsignalled recv of video rtp packets.
1319 void SetUpSecondStreamWithNoRecv() {
1320 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001321 EXPECT_TRUE(
1322 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001323 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001324 EXPECT_FALSE(
1325 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001326 EXPECT_TRUE(channel_->AddSendStream(
1327 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1328 // We dont add recv for the second stream.
1329
1330 // Setup the receive and renderer for second stream after send.
1331 video_capturer_2_.reset(CreateFakeVideoCapturer());
1332 cricket::VideoFormat format(640, 480,
1333 cricket::VideoFormat::FpsToInterval(kFramerate),
1334 cricket::FOURCC_I420);
1335 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1336
Yves Gerey665174f2018-06-19 15:03:05 +02001337 EXPECT_TRUE(
1338 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001339 }
Yves Gerey665174f2018-06-19 15:03:05 +02001340 virtual void TearDown() { channel_.reset(); }
1341 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001342
1343 bool SetOneCodec(const cricket::VideoCodec& codec) {
1344 cricket::VideoFormat capture_format(
1345 kVideoWidth, kVideoHeight,
1346 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1347
1348 if (video_capturer_) {
1349 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1350 }
1351 if (video_capturer_2_) {
1352 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1353 }
1354
1355 bool sending = channel_->sending();
1356 bool success = SetSend(false);
1357 if (success) {
1358 cricket::VideoSendParameters parameters;
1359 parameters.codecs.push_back(codec);
1360 success = channel_->SetSendParameters(parameters);
1361 }
1362 if (success) {
1363 success = SetSend(sending);
1364 }
1365 return success;
1366 }
Yves Gerey665174f2018-06-19 15:03:05 +02001367 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001368 bool SendFrame() {
1369 if (video_capturer_2_) {
1370 video_capturer_2_->CaptureFrame();
1371 }
1372 return video_capturer_.get() && video_capturer_->CaptureFrame();
1373 }
1374 bool WaitAndSendFrame(int wait_ms) {
1375 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1376 ret &= SendFrame();
1377 return ret;
1378 }
Yves Gerey665174f2018-06-19 15:03:05 +02001379 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001380 int NumRtpBytes(uint32_t ssrc) {
1381 return network_interface_.NumRtpBytes(ssrc);
1382 }
Yves Gerey665174f2018-06-19 15:03:05 +02001383 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001384 int NumRtpPackets(uint32_t ssrc) {
1385 return network_interface_.NumRtpPackets(ssrc);
1386 }
Yves Gerey665174f2018-06-19 15:03:05 +02001387 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001388 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1389 return network_interface_.GetRtpPacket(index);
1390 }
1391 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001392 webrtc::RTPHeader header;
1393 EXPECT_TRUE(ParseRtpPacket(p, &header));
1394 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001395 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001396
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001398 webrtc::RTPHeader* header) {
1399 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1400 webrtc::RtpHeaderParser::Create());
1401 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001402 }
1403
1404 // Tests that we can send and receive frames.
1405 void SendAndReceive(const cricket::VideoCodec& codec) {
1406 EXPECT_TRUE(SetOneCodec(codec));
1407 EXPECT_TRUE(SetSend(true));
1408 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1409 EXPECT_EQ(0, renderer_.num_rendered_frames());
1410 EXPECT_TRUE(SendFrame());
1411 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1412 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1413 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1414 }
1415
1416 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001417 int duration_sec,
1418 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001419 EXPECT_TRUE(SetOneCodec(codec));
1420 EXPECT_TRUE(SetSend(true));
1421 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1422 EXPECT_EQ(0, renderer_.num_rendered_frames());
1423 for (int i = 0; i < duration_sec; ++i) {
1424 for (int frame = 1; frame <= fps; ++frame) {
1425 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1426 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1427 }
1428 }
1429 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1430 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1431 }
1432
Niels Möller6557d0c2018-04-11 15:18:34 +02001433 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1434 cricket::VideoMediaInfo info;
1435 EXPECT_TRUE(channel_->GetStats(&info));
1436 return info.senders[i];
1437 }
1438
1439 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1440 cricket::VideoMediaInfo info;
1441 EXPECT_TRUE(channel_->GetStats(&info));
1442 return info.receivers[i];
1443 }
1444
1445 // Two streams one channel tests.
1446
1447 // Tests that we can send and receive frames.
1448 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1449 SetUpSecondStream();
1450 // Test sending and receiving on first stream.
1451 SendAndReceive(codec);
1452 // Test sending and receiving on second stream.
1453 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1454 EXPECT_GT(NumRtpPackets(), 0);
1455 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1456 }
1457
1458 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1459 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001460 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001461 return engine_codec;
1462 }
1463 // This point should never be reached.
1464 ADD_FAILURE() << "Unrecognized codec name: " << name;
1465 return cricket::VideoCodec();
1466 }
1467
1468 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1469
1470 cricket::StreamParams DefaultSendStreamParams() {
1471 return cricket::StreamParams::CreateLegacy(kSsrc);
1472 }
1473
1474 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001475 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001476 WebRtcVideoEngine engine_;
1477 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1478 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1479 std::unique_ptr<WebRtcVideoChannel> channel_;
1480 cricket::FakeNetworkInterface network_interface_;
1481 cricket::FakeVideoRenderer renderer_;
1482
1483 // Used by test cases where 2 streams are run on the same channel.
1484 cricket::FakeVideoRenderer renderer2_;
1485};
1486
1487// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001488TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001489 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001490 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001491 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1492 EXPECT_FALSE(channel_->sending());
1493 EXPECT_TRUE(SetSend(true));
1494 EXPECT_TRUE(channel_->sending());
1495 EXPECT_TRUE(SendFrame());
1496 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1497 EXPECT_TRUE(SetSend(false));
1498 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001499}
Niels Möller6557d0c2018-04-11 15:18:34 +02001500
1501// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001502TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001503 EXPECT_FALSE(channel_->sending());
1504 EXPECT_FALSE(SetSend(true));
1505 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001506}
Niels Möller6557d0c2018-04-11 15:18:34 +02001507
1508// Test that we properly set the send and recv buffer sizes by the time
1509// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001510TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001511 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1512 EXPECT_TRUE(SetSend(true));
1513 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001514 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001515}
1516
Niels Möller6557d0c2018-04-11 15:18:34 +02001517// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001518TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001519 const int kDurationSec = 3;
1520 const int kFps = 10;
1521 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1522
1523 cricket::VideoMediaInfo info;
1524 EXPECT_TRUE(channel_->GetStats(&info));
1525
1526 ASSERT_EQ(1U, info.senders.size());
1527 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1528 // For webrtc, bytes_sent does not include the RTP header length.
1529 EXPECT_GT(info.senders[0].bytes_sent, 0);
1530 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1531 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1532 ASSERT_TRUE(info.senders[0].codec_payload_type);
1533 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1534 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1535 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1536 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1537 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1538 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1539 EXPECT_GT(info.senders[0].framerate_input, 0);
1540 EXPECT_GT(info.senders[0].framerate_sent, 0);
1541
1542 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1543 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1544 info.send_codecs[DefaultCodec().id]);
1545
1546 ASSERT_EQ(1U, info.receivers.size());
1547 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1548 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1549 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1550 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1551 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1552 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1553 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1554 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1555 EXPECT_EQ(0, info.receivers[0].packets_lost);
1556 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1557 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1558 EXPECT_EQ(0, info.receivers[0].firs_sent);
1559 EXPECT_EQ(0, info.receivers[0].plis_sent);
1560 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1561 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1562 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1563 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1564 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1565 EXPECT_GT(info.receivers[0].framerate_output, 0);
1566
1567 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1568 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1569 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001570}
Niels Möller6557d0c2018-04-11 15:18:34 +02001571
1572// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001573TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001574 cricket::FakeVideoRenderer renderer1, renderer2;
1575 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1576 cricket::VideoSendParameters parameters;
1577 parameters.codecs.push_back(DefaultCodec());
1578 parameters.conference_mode = true;
1579 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1580 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001581 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1582 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001583 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1584 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1585 EXPECT_EQ(0, renderer1.num_rendered_frames());
1586 EXPECT_EQ(0, renderer2.num_rendered_frames());
1587 std::vector<uint32_t> ssrcs;
1588 ssrcs.push_back(1);
1589 ssrcs.push_back(2);
1590 network_interface_.SetConferenceMode(true, ssrcs);
1591 EXPECT_TRUE(SendFrame());
1592 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1593 kTimeout);
1594 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1595 kTimeout);
1596
1597 EXPECT_TRUE(channel_->SetSend(false));
1598
1599 cricket::VideoMediaInfo info;
1600 EXPECT_TRUE(channel_->GetStats(&info));
1601 ASSERT_EQ(1U, info.senders.size());
1602 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1603 // For webrtc, bytes_sent does not include the RTP header length.
1604 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1605 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1606 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1607 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1608
1609 ASSERT_EQ(2U, info.receivers.size());
1610 for (size_t i = 0; i < info.receivers.size(); ++i) {
1611 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1612 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1613 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001614 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001615 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1616 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1617 }
srtee0c2eea2017-12-15 17:44:33 +01001618}
Niels Möller6557d0c2018-04-11 15:18:34 +02001619
1620// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001621TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001622 // Normal setup; note that we set the SSRC explicitly to ensure that
1623 // it will come first in the senders map.
1624 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1625 cricket::VideoSendParameters parameters;
1626 parameters.codecs.push_back(DefaultCodec());
1627 parameters.conference_mode = true;
1628 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001629 EXPECT_TRUE(
1630 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001631 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1632 EXPECT_TRUE(SetSend(true));
1633 EXPECT_TRUE(SendFrame());
1634 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1635 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1636
1637 // Add an additional capturer, and hook up a renderer to receive it.
1638 cricket::FakeVideoRenderer renderer2;
1639 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1640 CreateFakeVideoCapturer());
1641 const int kTestWidth = 160;
1642 const int kTestHeight = 120;
1643 cricket::VideoFormat format(kTestWidth, kTestHeight,
1644 cricket::VideoFormat::FpsToInterval(5),
1645 cricket::FOURCC_I420);
1646 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001647 EXPECT_TRUE(
1648 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001649 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001650 EXPECT_TRUE(
1651 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001652 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1653 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001654 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1655 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001656
1657 // Get stats, and make sure they are correct for two senders. We wait until
1658 // the number of expected packets have been sent to avoid races where we
1659 // check stats before it has been updated.
1660 cricket::VideoMediaInfo info;
1661 for (uint32_t i = 0; i < kTimeout; ++i) {
1662 rtc::Thread::Current()->ProcessMessages(1);
1663 EXPECT_TRUE(channel_->GetStats(&info));
1664 ASSERT_EQ(2U, info.senders.size());
1665 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1666 NumRtpPackets()) {
1667 // Stats have been updated for both sent frames, expectations can be
1668 // checked now.
1669 break;
1670 }
1671 }
1672 EXPECT_EQ(NumRtpPackets(),
1673 info.senders[0].packets_sent + info.senders[1].packets_sent)
1674 << "Timed out while waiting for packet counts for all sent packets.";
1675 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1676 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1677 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1678 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1679 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1680 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1681 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1682 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1683 // The capturer must be unregistered here as it runs out of it's scope next.
1684 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001685}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001686
Niels Möller6557d0c2018-04-11 15:18:34 +02001687// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001688TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001689 cricket::VideoSendParameters parameters;
1690 parameters.codecs.push_back(DefaultCodec());
1691 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1692 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1693 parameters.max_bandwidth_bps = 128 * 1024;
1694 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001695}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001696
Niels Möller6557d0c2018-04-11 15:18:34 +02001697// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001698TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001699 EXPECT_TRUE(SetDefaultCodec());
1700 EXPECT_TRUE(SetSend(true));
1701 EXPECT_TRUE(SendFrame());
1702 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001703 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001704 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001705 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1706 EXPECT_EQ(kSsrc, header.ssrc);
1707
Niels Möller6557d0c2018-04-11 15:18:34 +02001708 // Packets are being paced out, so these can mismatch between the first and
1709 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001710 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1711 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 EXPECT_EQ(1, NumSentSsrcs());
1713 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1714 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001715}
Niels Möller6557d0c2018-04-11 15:18:34 +02001716
1717// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001718TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001719 // Remove stream added in Setup.
1720 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1721 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001722 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001723 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1724 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 EXPECT_TRUE(SetSend(true));
1726 EXPECT_TRUE(WaitAndSendFrame(0));
1727 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001728 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001729 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001730 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1731 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001732 // Packets are being paced out, so these can mismatch between the first and
1733 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001734 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1735 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001736 EXPECT_EQ(1, NumSentSsrcs());
1737 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1738 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001739}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001740
Niels Möller6557d0c2018-04-11 15:18:34 +02001741// Test that we can set the default video renderer before and after
1742// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001743TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001744 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1745 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001746
1747 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1748 rtc::SetBE32(packet1.data() + 8, kSsrc);
1749 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1750 EXPECT_TRUE(SetDefaultCodec());
1751 EXPECT_TRUE(SetSend(true));
1752 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001753 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001754 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1755 EXPECT_TRUE(SendFrame());
1756 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001757}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001758
Niels Möller6557d0c2018-04-11 15:18:34 +02001759// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001760TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001761 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1762 EXPECT_TRUE(SetSend(true));
1763 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1764 EXPECT_TRUE(SendFrame());
1765 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1766 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001767 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001768 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001769 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1770 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001771 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1772 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001773
1774 // Remove the send stream that was added during Setup.
1775 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1776 int rtp_packets = NumRtpPackets();
1777
Niels Möller6557d0c2018-04-11 15:18:34 +02001778 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001779 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1780 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001781 EXPECT_EQ(rtp_packets, NumRtpPackets());
1782 // Wait 30ms to guarantee the engine does not drop the frame.
1783 EXPECT_TRUE(WaitAndSendFrame(30));
1784 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1785
1786 last_packet = NumRtpPackets() - 1;
1787 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001788 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1789 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001790}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001791
Niels Möller6557d0c2018-04-11 15:18:34 +02001792// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001793TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001794 cricket::FakeVideoRenderer renderer1, renderer2;
1795 EXPECT_TRUE(SetDefaultCodec());
1796 cricket::VideoSendParameters parameters;
1797 parameters.codecs.push_back(DefaultCodec());
1798 parameters.conference_mode = true;
1799 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1800 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001801 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1802 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001803 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1804 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1805 EXPECT_EQ(0, renderer1.num_rendered_frames());
1806 EXPECT_EQ(0, renderer2.num_rendered_frames());
1807 std::vector<uint32_t> ssrcs;
1808 ssrcs.push_back(1);
1809 ssrcs.push_back(2);
1810 network_interface_.SetConferenceMode(true, ssrcs);
1811 EXPECT_TRUE(SendFrame());
1812 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1813 kTimeout);
1814 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1815 kTimeout);
1816
1817 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1818 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1819 EXPECT_EQ(kVideoWidth, renderer1.width());
1820 EXPECT_EQ(kVideoHeight, renderer1.height());
1821 EXPECT_EQ(kVideoWidth, renderer2.width());
1822 EXPECT_EQ(kVideoHeight, renderer2.height());
1823 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1824 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001825}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001826
Niels Möller6557d0c2018-04-11 15:18:34 +02001827// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001828TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001829 using cricket::VideoCodec;
1830 using cricket::VideoOptions;
1831 using cricket::VideoFormat;
1832 using cricket::FOURCC_I420;
1833
1834 VideoCodec codec = DefaultCodec();
1835 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1836 EXPECT_TRUE(SetOneCodec(codec));
1837 EXPECT_TRUE(SetSend(true));
1838 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1839 EXPECT_EQ(0, renderer_.num_rendered_frames());
1840 EXPECT_TRUE(SendFrame());
1841 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1842 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1843 CreateFakeVideoCapturer());
1844
1845 // TODO(nisse): This testcase fails if we don't configure
1846 // screencast. It's unclear why, I see nothing obvious in this
1847 // test which is related to screencast logic.
1848 VideoOptions video_options;
1849 video_options.is_screencast = true;
1850 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1851
1852 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1853 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1854 // All capturers start generating frames with the same timestamp. ViE does
1855 // not allow the same timestamp to be used. Capture one frame before
1856 // associating the capturer with the channel.
1857 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1858
1859 int captured_frames = 1;
1860 for (int iterations = 0; iterations < 2; ++iterations) {
1861 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1862 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1863 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1864 ++captured_frames;
1865 // Wait until frame of right size is captured.
1866 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001867 format.width == renderer_.width() &&
1868 format.height == renderer_.height() &&
1869 !renderer_.black_frame(),
1870 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001871 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1872 EXPECT_EQ(format.width, renderer_.width());
1873 EXPECT_EQ(format.height, renderer_.height());
1874 captured_frames = renderer_.num_rendered_frames() + 1;
1875 EXPECT_FALSE(renderer_.black_frame());
1876 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1877 // Make sure a black frame is generated within the specified timeout.
1878 // The black frame should be the resolution of the previous frame to
1879 // prevent expensive encoder reconfigurations.
1880 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001881 format.width == renderer_.width() &&
1882 format.height == renderer_.height() &&
1883 renderer_.black_frame(),
1884 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001885 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1886 EXPECT_EQ(format.width, renderer_.width());
1887 EXPECT_EQ(format.height, renderer_.height());
1888 EXPECT_TRUE(renderer_.black_frame());
1889
1890 // The black frame has the same timestamp as the next frame since it's
1891 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1892 // not render a frame with the same timestamp so capture another frame
1893 // with the frame capturer to increment the next frame's timestamp.
1894 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1895 }
srtee0c2eea2017-12-15 17:44:33 +01001896}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001897
Niels Möller6557d0c2018-04-11 15:18:34 +02001898// Tests that if SetVideoSend is called with a NULL capturer after the
1899// capturer was already removed, the application doesn't crash (and no black
1900// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001901TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001902 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1903 EXPECT_TRUE(SetSend(true));
1904 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1905 EXPECT_EQ(0, renderer_.num_rendered_frames());
1906 EXPECT_TRUE(SendFrame());
1907 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1908 // Wait for one frame so they don't get dropped because we send frames too
1909 // tightly.
1910 rtc::Thread::Current()->ProcessMessages(30);
1911 // Remove the capturer.
1912 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1913
1914 // No capturer was added, so this SetVideoSend shouldn't do anything.
1915 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1916 rtc::Thread::Current()->ProcessMessages(300);
1917 // Verify no more frames were sent.
1918 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001919}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001920
Niels Möller6557d0c2018-04-11 15:18:34 +02001921// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001922TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1924 // interval time to avoid that.
1925 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1926 // interval time to avoid that.
1927 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001928 EXPECT_TRUE(
1929 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001930 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1931 cricket::VideoFormat capture_format(
1932 kVideoWidth, kVideoHeight,
1933 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1934 // Set up additional stream 1.
1935 cricket::FakeVideoRenderer renderer1;
1936 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001937 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001938 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001939 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001940 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1941 CreateFakeVideoCapturer());
1942 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1943 // Set up additional stream 2.
1944 cricket::FakeVideoRenderer renderer2;
1945 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001946 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001947 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001948 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001949 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1950 CreateFakeVideoCapturer());
1951 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1952 // State for all the streams.
1953 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1954 // A limitation in the lmi implementation requires that SetVideoSend() is
1955 // called after SetOneCodec().
1956 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1957 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1958 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1959 EXPECT_TRUE(SetSend(true));
1960 // Test capturer associated with engine.
1961 const int kTestWidth = 160;
1962 const int kTestHeight = 120;
1963 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001964 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1965 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 // Capture a frame with additional capturer2, frames should be received
1967 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001968 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1969 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001970 // Successfully remove the capturer.
1971 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1972 // The capturers must be unregistered here as it runs out of it's scope
1973 // next.
1974 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1975 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001976}
Niels Möller6557d0c2018-04-11 15:18:34 +02001977
1978// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001979TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001980 // Remove the send stream that was added during Setup.
1981 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1982
1983 cricket::StreamParams empty;
1984 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001985 EXPECT_TRUE(
1986 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001987}
Niels Möller6557d0c2018-04-11 15:18:34 +02001988
1989// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001990TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001991 // Remove stream added in Setup. I.e. remove stream corresponding to default
1992 // channel.
1993 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001994 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001995 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1996 EXPECT_TRUE(channel_->AddSendStream(
1997 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1998 }
1999 // Delete one of the non default channel streams, let the destructor delete
2000 // the remaining ones.
2001 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2002 // Stream should already be deleted.
2003 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002004}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002005
eladalonf1841382017-06-12 01:16:46 -07002006TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002007 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002008}
2009
eladalonf1841382017-06-12 01:16:46 -07002010TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002011 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002012}
2013
eladalonf1841382017-06-12 01:16:46 -07002014TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002015 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002016}
2017
eladalonf1841382017-06-12 01:16:46 -07002018TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002019 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2020 // bitrates. This currently happens at <250k, and two streams sharing 300k
2021 // initially will use QVGA instead of VGA.
2022 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2023 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002024 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002025 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002027}
2028
eladalonf1841382017-06-12 01:16:46 -07002029class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002030 public:
eladalonf1841382017-06-12 01:16:46 -07002031 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2032 explicit WebRtcVideoChannelTest(const char* field_trials)
2033 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002034 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002035 encoder_factory_->AddSupportedVideoCodecType("VP8");
2036 encoder_factory_->AddSupportedVideoCodecType("VP9");
2037#if defined(WEBRTC_USE_H264)
2038 encoder_factory_->AddSupportedVideoCodecType("H264");
2039#endif
2040
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002041 fake_call_.reset(new FakeCall());
kthelgason2bc68642017-02-07 07:02:22 -08002042 channel_.reset(engine_.CreateChannel(fake_call_.get(), GetMediaConfig(),
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002043 VideoOptions(),
2044 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002045 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002046 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002047 send_parameters_.codecs = engine_.codecs();
2048 recv_parameters_.codecs = engine_.codecs();
2049 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002050 }
2051
2052 protected:
2053 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002054 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002055 }
2056
2057 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002058 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002059 EXPECT_TRUE(channel_->AddSendStream(sp));
2060 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002061 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002062 EXPECT_EQ(num_streams + 1, streams.size());
2063 return streams[streams.size() - 1];
2064 }
2065
2066 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002067 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002068 }
2069
2070 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002071 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002072 }
2073
2074 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002075 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002076 EXPECT_TRUE(channel_->AddRecvStream(sp));
2077 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002078 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002079 EXPECT_EQ(num_streams + 1, streams.size());
2080 return streams[streams.size() - 1];
2081 }
2082
pbos@webrtc.org00873182014-11-25 14:03:34 +00002083 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2084 int expected_min_bitrate_bps,
2085 const char* start_bitrate_kbps,
2086 int expected_start_bitrate_bps,
2087 const char* max_bitrate_kbps,
2088 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002089 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2090 expected_start_bitrate_bps,
2091 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002092 auto& codecs = send_parameters_.codecs;
2093 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002094 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002095 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2096 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2097 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002098 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002099 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002100
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002101 void ExpectSetBitrateParameters(int min_bitrate_bps,
2102 int start_bitrate_bps,
2103 int max_bitrate_bps) {
2104 EXPECT_CALL(
2105 *fake_call_->GetMockTransportControllerSend(),
2106 SetSdpBitrateParameters(AllOf(
2107 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2108 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2109 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2110 }
2111
2112 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2113 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2114 SetSdpBitrateParameters(Field(
2115 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002116 }
2117
Johannes Kron9190b822018-10-29 11:22:05 +01002118 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2119 // For a caller, the answer will be applied in set remote description
2120 // where SetSendParameters() is called.
2121 EXPECT_TRUE(
2122 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2123 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2124 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2125 const webrtc::VideoSendStream::Config& config =
2126 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2127 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2128 }
2129
2130 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2131 // For a callee, the answer will be applied in set local description
2132 // where SetExtmapAllowMixed() and AddSendStream() are called.
2133 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2134 EXPECT_TRUE(
2135 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2136 const webrtc::VideoSendStream::Config& config =
2137 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2138 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2139 }
2140
isheriff6f8d6862016-05-26 11:24:55 -07002141 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002142 // Enable extension.
2143 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002144 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002145 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002146 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002147 FakeVideoSendStream* send_stream =
2148 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2149
2150 // Verify the send extension id.
2151 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2152 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002153 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002154 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002155 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002156 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2157 // receivers.
2158 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2159 ->GetConfig()
2160 .rtp.extensions.empty());
2161
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002162 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002163 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002164 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2165 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002166 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2167
2168 // Verify that adding receive RTP header extensions adds them for existing
2169 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002170 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002171 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002172 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2173 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002174 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002175 }
2176
isheriff6f8d6862016-05-26 11:24:55 -07002177 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002178 // Enable extension.
2179 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002180 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002181 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002182 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002183
2184 FakeVideoReceiveStream* recv_stream =
2185 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2186
2187 // Verify the recv extension id.
2188 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2189 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002190 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002191 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002192 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002193
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002194 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2195 // senders.
2196 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2197 ->GetConfig()
2198 .rtp.extensions.empty());
2199
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002200 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002201 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002202 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2203 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002204 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2205
2206 // Verify that adding receive RTP header extensions adds them for existing
2207 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002208 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002209 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002210 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2211 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002212 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002213 }
2214
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002215 void TestExtensionFilter(const std::vector<std::string>& extensions,
2216 const std::string& expected_extension) {
2217 cricket::VideoSendParameters parameters = send_parameters_;
2218 int expected_id = -1;
2219 int id = 1;
2220 for (const std::string& extension : extensions) {
2221 if (extension == expected_extension)
2222 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002223 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002224 }
2225 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2226 FakeVideoSendStream* send_stream =
2227 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2228
2229 // Verify that only one of them has been set, and that it is the one with
2230 // highest priority (transport sequence number).
2231 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2232 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2233 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002234 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002235 }
2236
asapersson3c81a1a2017-06-14 05:52:21 -07002237 void TestDegradationPreference(bool resolution_scaling_enabled,
2238 bool fps_scaling_enabled);
2239
Erik Språngefbde372015-04-29 16:21:28 +02002240 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002241 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002242 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2243 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002244
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002245 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002246 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002247 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002248 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002249 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002250 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002251 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002252 // Options only take effect on the next frame.
2253 EXPECT_TRUE(capturer->CaptureFrame());
2254
Erik Språng143cec12015-04-28 10:01:41 +02002255 return fake_call_->GetVideoSendStreams().back();
2256 }
2257
Peter Boström2feafdb2015-09-09 14:32:14 +02002258 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2259 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002260 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002261 std::vector<uint32_t> ssrcs;
2262 std::vector<uint32_t> rtx_ssrcs;
2263 uint32_t num_streams = enabled ? 3 : 1;
2264 for (uint32_t i = 0; i < num_streams; ++i) {
2265 uint32_t ssrc = last_ssrc_ + i;
2266 ssrcs.push_back(ssrc);
2267 if (with_rtx) {
2268 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2269 }
Erik Språng143cec12015-04-28 10:01:41 +02002270 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002271 if (with_rtx) {
2272 return AddSendStream(
2273 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2274 }
2275 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002276 }
2277
perkjfa10b552016-10-02 23:45:26 -07002278 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002279 std::vector<FakeVideoSendStream*> streams =
2280 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002281 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002282 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002283 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002284 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002285 }
2286
perkjfa10b552016-10-02 23:45:26 -07002287 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002288 int stream_max,
2289 int expected_encoder_bitrate) {
2290 VideoSendParameters limited_send_params = send_parameters_;
2291 limited_send_params.max_bandwidth_bps = global_max;
2292 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002293 webrtc::RtpParameters parameters =
2294 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002295 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002296 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002297 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002298 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002299 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002300 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002301 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002302 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002303 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002304 }
2305
Åsa Persson55659812018-06-18 17:51:32 +02002306 // Values from kSimulcastConfigs in simulcast.cc.
2307 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2308 std::vector<webrtc::VideoStream> layers(3);
2309 layers[0].min_bitrate_bps = 30000;
2310 layers[0].target_bitrate_bps = 150000;
2311 layers[0].max_bitrate_bps = 200000;
2312 layers[1].min_bitrate_bps = 150000;
2313 layers[1].target_bitrate_bps = 500000;
2314 layers[1].max_bitrate_bps = 700000;
2315 layers[2].min_bitrate_bps = 600000;
2316 layers[2].target_bitrate_bps = 2500000;
2317 layers[2].max_bitrate_bps = 2500000;
2318 return layers;
2319 }
2320
kwiberg686a8ef2016-02-26 03:00:35 -08002321 std::unique_ptr<FakeCall> fake_call_;
2322 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002323 cricket::VideoSendParameters send_parameters_;
2324 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002325 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002326};
2327
eladalonf1841382017-06-12 01:16:46 -07002328TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002329 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002330 const std::string kSyncLabel = "AvSyncLabel";
2331
2332 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002333 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002334 EXPECT_TRUE(channel_->AddRecvStream(sp));
2335
Mirko Bonadeif859e552018-05-30 15:31:29 +02002336 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002337 EXPECT_EQ(kSyncLabel,
2338 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2339 << "SyncGroup should be set based on sync_label";
2340}
2341
eladalonf1841382017-06-12 01:16:46 -07002342TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002343 cricket::VideoSendParameters parameters;
2344 parameters.codecs = engine_.codecs();
2345 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002346 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002347 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002348 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002349
2350 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002351 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2352 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002353 FakeVideoSendStream* send_stream = AddSendStream(
2354 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2355
2356 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2357 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2358 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2359
2360 // Receiver side.
2361 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2362 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002363 EXPECT_FALSE(
2364 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002365 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002366 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002367 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002368 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002369 << "RTX should be mapped for the RED payload type";
2370
brandtr14742122017-01-27 04:53:07 -08002371 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002372}
2373
eladalonf1841382017-06-12 01:16:46 -07002374TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002375 // Setup one channel with an associated RTX stream.
2376 cricket::StreamParams params =
2377 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2378 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2379 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002380 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002381
2382 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2383 << "RTX should be mapped for all decoders/payload types.";
2384 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002385 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002386 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002387}
2388
eladalonf1841382017-06-12 01:16:46 -07002389TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002390 // Setup one channel without an associated RTX stream.
2391 cricket::StreamParams params =
2392 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2393 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002394 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002395}
2396
Johannes Kron9190b822018-10-29 11:22:05 +01002397// Test propagation of extmap allow mixed setting.
2398TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2399 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2400}
2401TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2402 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2403}
2404TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2405 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2406}
2407TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2408 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2409}
2410
eladalonf1841382017-06-12 01:16:46 -07002411TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002412 FakeVideoSendStream* send_stream =
2413 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2414 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2415
2416 FakeVideoReceiveStream* recv_stream =
2417 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2418 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002419}
2420
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002421// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002422TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002423 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002424}
isheriff6f8d6862016-05-26 11:24:55 -07002425
eladalonf1841382017-06-12 01:16:46 -07002426TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002427 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002428}
2429
2430// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002431TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002432 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002433}
isheriff6f8d6862016-05-26 11:24:55 -07002434
eladalonf1841382017-06-12 01:16:46 -07002435TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002436 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002437}
2438
eladalonf1841382017-06-12 01:16:46 -07002439TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002440 // Enable three redundant extensions.
2441 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002442 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2443 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2444 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2445 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002446}
2447
eladalonf1841382017-06-12 01:16:46 -07002448TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002449 // Enable two redundant extensions.
2450 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002451 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2452 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2453 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002454}
2455
stefanc1aeaf02015-10-15 07:26:07 -07002456// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002457TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002458 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002459}
eladalonf1841382017-06-12 01:16:46 -07002460TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002461 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002462}
2463
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002464// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002465TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002466 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002467}
eladalonf1841382017-06-12 01:16:46 -07002468TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002469 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002470}
2471
eladalonf1841382017-06-12 01:16:46 -07002472TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002473 const int kAbsSendTimeId = 1;
2474 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002475 send_parameters_.extensions.push_back(
2476 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2477 send_parameters_.extensions.push_back(
2478 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002479
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002480 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002481 FakeVideoSendStream* send_stream =
2482 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2483
2484 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002485 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002486
2487 // Setting the same extensions (even if in different order) shouldn't
2488 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002489 std::reverse(send_parameters_.extensions.begin(),
2490 send_parameters_.extensions.end());
2491 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002492
2493 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2494
2495 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002496 send_parameters_.extensions.resize(1);
2497 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002498
2499 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2500}
2501
eladalonf1841382017-06-12 01:16:46 -07002502TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002503 const int kTOffsetId = 1;
2504 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002505 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002506 recv_parameters_.extensions.push_back(
2507 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2508 recv_parameters_.extensions.push_back(
2509 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2510 recv_parameters_.extensions.push_back(
2511 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002512
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002513 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002514 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002515 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2516
2517 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002518 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002519
2520 // Setting the same extensions (even if in different order) shouldn't
2521 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002522 std::reverse(recv_parameters_.extensions.begin(),
2523 recv_parameters_.extensions.end());
2524 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002525
2526 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2527
2528 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002529 recv_parameters_.extensions.resize(1);
2530 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002531
2532 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2533}
2534
eladalonf1841382017-06-12 01:16:46 -07002535TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002536 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002537 const int kUnsupportedId = 1;
2538 const int kTOffsetId = 2;
2539
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002540 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002541 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002542 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002543 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002544 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002545 FakeVideoSendStream* send_stream =
2546 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2547
2548 // Only timestamp offset extension is set to send stream,
2549 // unsupported rtp extension is ignored.
2550 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002551 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2552 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002553}
2554
eladalonf1841382017-06-12 01:16:46 -07002555TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002556 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002557 const int kUnsupportedId = 1;
2558 const int kTOffsetId = 2;
2559
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002560 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002561 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002562 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002563 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002564 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002565 FakeVideoReceiveStream* recv_stream =
2566 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2567
2568 // Only timestamp offset extension is set to receive stream,
2569 // unsupported rtp extension is ignored.
2570 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002571 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2572 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002573}
2574
eladalonf1841382017-06-12 01:16:46 -07002575TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002576 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002577 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002578 send_parameters_.extensions.push_back(
2579 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002580 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002581 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2582 }
2583}
2584
eladalonf1841382017-06-12 01:16:46 -07002585TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002586 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002587 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002588 recv_parameters_.extensions.push_back(
2589 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002590 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002591 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2592 }
2593}
2594
eladalonf1841382017-06-12 01:16:46 -07002595TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002596 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002597 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002598 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002599 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002600 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002601 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002602
2603 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002604 send_parameters_.extensions.clear();
2605 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002606 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002607 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2608 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002609}
2610
eladalonf1841382017-06-12 01:16:46 -07002611TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002612 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002614 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002615 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002616 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002617 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002618
2619 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002620 recv_parameters_.extensions.clear();
2621 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002622 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2624 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002625}
2626
eladalonf1841382017-06-12 01:16:46 -07002627TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002628 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002629 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002630}
2631
eladalonf1841382017-06-12 01:16:46 -07002632TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002633 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002634 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002635}
2636
eladalonf1841382017-06-12 01:16:46 -07002637TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002638 FakeVideoReceiveStream* stream = AddRecvStream();
2639 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002640}
2641
eladalonf1841382017-06-12 01:16:46 -07002642TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002643 FakeVideoReceiveStream* stream = AddRecvStream();
2644 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2645}
2646
eladalonf1841382017-06-12 01:16:46 -07002647TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002648 FakeVideoReceiveStream* stream = AddRecvStream();
2649 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2650
Peter Boström126c03e2015-05-11 12:48:12 +02002651 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002652 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002653 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002654 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2655 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002656 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002657 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2658
2659 // Verify that REMB is turned on when setting default codecs since the
2660 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002661 parameters.codecs = engine_.codecs();
2662 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002663 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002664 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002665}
2666
eladalonf1841382017-06-12 01:16:46 -07002667TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002668 FakeVideoReceiveStream* stream = AddRecvStream();
2669 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2670
2671 // Verify that transport cc feedback is turned off when send(!) codecs without
2672 // transport cc feedback are set.
2673 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002674 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002675 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2676 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2677 stream = fake_call_->GetVideoReceiveStreams()[0];
2678 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2679
2680 // Verify that transport cc feedback is turned on when setting default codecs
2681 // since the default codecs have transport cc feedback enabled.
2682 parameters.codecs = engine_.codecs();
2683 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2684 stream = fake_call_->GetVideoReceiveStreams()[0];
2685 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2686}
2687
eladalonf1841382017-06-12 01:16:46 -07002688TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002689 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002690 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2691
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002692 cricket::VideoSendParameters parameters;
2693 parameters.codecs = engine_.codecs();
2694 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002695 EXPECT_TRUE(channel_->SetSend(true));
2696
2697 // Send side.
2698 FakeVideoSendStream* send_stream =
2699 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2700 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2701
2702 // Receiver side.
2703 FakeVideoReceiveStream* recv_stream =
2704 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2705 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2706
2707 // Nack history size should match between sender and receiver.
2708 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2709 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002710}
2711
eladalonf1841382017-06-12 01:16:46 -07002712TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002713 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002714 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002715
2716 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2717 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2718
2719 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002720 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002721 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002722 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2723 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002724 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2725 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2726 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002727 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2728
Peter Boström67c9df72015-05-11 14:34:58 +02002729 // Verify that NACK is turned on when setting default codecs since the
2730 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002731 parameters.codecs = engine_.codecs();
2732 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002733 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2734 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2735 send_stream = fake_call_->GetVideoSendStreams()[0];
2736 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002737}
2738
Peter Boströme7ba0862016-03-12 00:02:28 +01002739// This test verifies that new frame sizes reconfigures encoders even though not
2740// (yet) sending. The purpose of this is to permit encoding as quickly as
2741// possible once we start sending. Likely the frames being input are from the
2742// same source that will be sent later, which just means that we're ready
2743// earlier.
eladalonf1841382017-06-12 01:16:46 -07002744TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002745 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002746 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002747 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2748 channel_->SetSend(false);
2749
2750 FakeVideoSendStream* stream = AddSendStream();
2751
perkjfa10b552016-10-02 23:45:26 -07002752 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002753 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002754 EXPECT_EQ(0u, streams[0].width);
2755 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002756
Tommi85959932018-02-07 19:26:06 +01002757 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002758 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002759 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2760 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002761 EXPECT_TRUE(capturer.CaptureFrame());
2762
2763 // Frame entered, should be reconfigured to new dimensions.
2764 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002765 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2766 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2767 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002768
Niels Möllerff40b142018-04-09 08:49:14 +02002769 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002770}
2771
eladalonf1841382017-06-12 01:16:46 -07002772TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002773 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002774 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002775 cricket::VideoSendParameters parameters;
2776 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002777 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002778 AddSendStream();
2779
Tommi85959932018-02-07 19:26:06 +01002780 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002781 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002782 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002783 EXPECT_TRUE(
2784 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002785 cricket::VideoFormat capture_format_hd =
2786 capturer.GetSupportedFormats()->front();
2787 EXPECT_EQ(1280, capture_format_hd.width);
2788 EXPECT_EQ(720, capture_format_hd.height);
2789 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2790
2791 EXPECT_TRUE(channel_->SetSend(true));
2792
2793 EXPECT_TRUE(capturer.CaptureFrame());
2794 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2795 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2796
2797 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2798
2799 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002800 webrtc::VideoEncoderConfig encoder_config =
2801 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002802 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002803 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002804 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002805 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2806 streams.front().width);
2807 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2808 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002809 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2810 << "Non-screenshare shouldn't use min-transmit bitrate.";
2811
Niels Möllerff40b142018-04-09 08:49:14 +02002812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002813 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002814 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002815 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002816 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002817 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002818 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002819 // Send stream recreated after option change.
2820 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2821 send_stream = fake_call_->GetVideoSendStreams().front();
2822 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002823
2824 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002825 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002826 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002827 encoder_config.content_type);
2828 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2829 encoder_config.min_transmit_bitrate_bps);
2830
perkjfa10b552016-10-02 23:45:26 -07002831 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002832 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2833 streams.front().width);
2834 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2835 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002836 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002837 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002838}
2839
eladalonf1841382017-06-12 01:16:46 -07002840TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002841 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002842 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002843 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002844 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002845
2846 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002847 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002848 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002849 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002850 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002851 cricket::VideoFormat capture_format_hd =
2852 capturer.GetSupportedFormats()->front();
2853 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2854
2855 EXPECT_TRUE(channel_->SetSend(true));
2856
2857 EXPECT_TRUE(capturer.CaptureFrame());
2858 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2859 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2860
perkj26091b12016-09-01 01:17:40 -07002861 webrtc::VideoEncoderConfig encoder_config =
2862 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002863
2864 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002865 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002866 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002867 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002868
2869 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2870 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002871 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002872 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002873 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002874
Niels Möllerff40b142018-04-09 08:49:14 +02002875 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002876}
2877
eladalonf1841382017-06-12 01:16:46 -07002878TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002879 FakeVideoSendStream* stream = AddSendStream();
2880 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2881}
2882
eladalonf1841382017-06-12 01:16:46 -07002883TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002884 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002885 media_config.video.suspend_below_min_bitrate = true;
2886
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002887 channel_.reset(engine_.CreateChannel(
2888 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002889 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002890
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002891 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002892
2893 FakeVideoSendStream* stream = AddSendStream();
2894 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2895
nisse0db023a2016-03-01 04:29:59 -08002896 media_config.video.suspend_below_min_bitrate = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002897 channel_.reset(engine_.CreateChannel(
2898 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002899 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002900
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002901 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002902
nisse0db023a2016-03-01 04:29:59 -08002903 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002904 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2905}
2906
eladalonf1841382017-06-12 01:16:46 -07002907TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002908 FakeVideoSendStream* stream = AddSendStream();
2909 webrtc::VideoCodecVP8 vp8_settings;
2910 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2911 EXPECT_TRUE(vp8_settings.denoisingOn);
2912}
2913
eladalonf1841382017-06-12 01:16:46 -07002914TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002915 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002916 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002917 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002918
Peter Boström2feafdb2015-09-09 14:32:14 +02002919 // Single-stream settings should apply with RTX as well (verifies that we
2920 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2921 // both RTX and regular SSRCs).
2922 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002923
Tommi85959932018-02-07 19:26:06 +01002924 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002925 EXPECT_EQ(cricket::CS_RUNNING,
2926 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002927 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002928 channel_->SetSend(true);
2929
2930 EXPECT_TRUE(capturer.CaptureFrame());
2931
pbos4cba4eb2015-10-26 11:18:18 -07002932 webrtc::VideoCodecVP8 vp8_settings;
2933 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2934 EXPECT_TRUE(vp8_settings.denoisingOn)
2935 << "VP8 denoising should be on by default.";
2936
nisse05103312016-03-16 02:22:50 -07002937 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002938
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002939 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2940 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002941 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2942 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002943
nisse05103312016-03-16 02:22:50 -07002944 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002945
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002946 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2947 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002948 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2949 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2950
Niels Möllerff40b142018-04-09 08:49:14 +02002951 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002952 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002953 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002954 channel_->SetSend(true);
2955 EXPECT_TRUE(capturer.CaptureFrame());
2956
Mirko Bonadeif859e552018-05-30 15:31:29 +02002957 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002958 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2959 // Autmatic resize off when using simulcast.
2960 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2961 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2962
2963 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002964 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002965 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002966 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002967
nisse05103312016-03-16 02:22:50 -07002968 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002969
Mirko Bonadeif859e552018-05-30 15:31:29 +02002970 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002971 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2972 EXPECT_FALSE(vp8_settings.denoisingOn);
2973 // Resizing and frame dropping always off for screen sharing.
2974 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2975 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2976
nisse05103312016-03-16 02:22:50 -07002977 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002978
2979 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2980 EXPECT_FALSE(vp8_settings.denoisingOn);
2981 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2982 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2983
Niels Möllerff40b142018-04-09 08:49:14 +02002984 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002985}
2986
deadbeef119760a2016-04-04 11:43:27 -07002987// Test that setting the same options doesn't result in the encoder being
2988// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002989TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002990 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002991 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002992
perkjfa10b552016-10-02 23:45:26 -07002993 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002994 EXPECT_EQ(cricket::CS_RUNNING,
2995 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002996 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002997 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002998 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2999 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3000
Niels Möllerff40b142018-04-09 08:49:14 +02003001 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
3002 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003003 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07003004 // Expect 1 reconfigurations at this point from the initial configuration.
3005 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003006
3007 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02003008 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07003009 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3010
3011 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003012 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003013 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003014 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3015
Niels Möllerff40b142018-04-09 08:49:14 +02003016 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003017}
3018
eladalonf1841382017-06-12 01:16:46 -07003019class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003020 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003021 Vp9SettingsTest() : Vp9SettingsTest("") {}
3022 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003023 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003024 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003025 }
3026 virtual ~Vp9SettingsTest() {}
3027
3028 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003029 void TearDown() override {
3030 // Remove references to encoder_factory_ since this will be destroyed
3031 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003032 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003033 }
Erik Språng143cec12015-04-28 10:01:41 +02003034};
3035
3036TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003037 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003038 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003039 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003040
Peter Boström2feafdb2015-09-09 14:32:14 +02003041 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003042
Tommi85959932018-02-07 19:26:06 +01003043 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003044 EXPECT_EQ(cricket::CS_RUNNING,
3045 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003046 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003047 channel_->SetSend(true);
3048
3049 EXPECT_TRUE(capturer.CaptureFrame());
3050
pbos4cba4eb2015-10-26 11:18:18 -07003051 webrtc::VideoCodecVP9 vp9_settings;
3052 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003053 EXPECT_TRUE(vp9_settings.denoisingOn)
3054 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003055
nisse05103312016-03-16 02:22:50 -07003056 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003057
Erik Språng143cec12015-04-28 10:01:41 +02003058 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3059 EXPECT_FALSE(vp9_settings.denoisingOn);
3060 // Frame dropping always on for real time video.
3061 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3062
nisse05103312016-03-16 02:22:50 -07003063 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003064
3065 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3066 EXPECT_TRUE(vp9_settings.denoisingOn);
3067 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3068
3069 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003070 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003071 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003072 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003073
nisse05103312016-03-16 02:22:50 -07003074 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003075
3076 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3077 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003078 // Frame dropping always on for screen sharing.
3079 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003080
nisse05103312016-03-16 02:22:50 -07003081 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003082
3083 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3084 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003085 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003086
Niels Möllerff40b142018-04-09 08:49:14 +02003087 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003088}
3089
Sergey Silkinf18072e2018-03-14 10:35:35 +01003090TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3091 cricket::VideoSendParameters parameters;
3092 parameters.codecs.push_back(GetEngineCodec("VP9"));
3093 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3094
3095 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3096
3097 FakeVideoSendStream* stream =
3098 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3099
3100 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3101 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3102
3103 FakeVideoCapturerWithTaskQueue capturer;
3104 EXPECT_EQ(cricket::CS_RUNNING,
3105 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003106 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003107 channel_->SetSend(true);
3108
3109 EXPECT_TRUE(capturer.CaptureFrame());
3110
3111 webrtc::VideoCodecVP9 vp9_settings;
3112 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3113
3114 const size_t kNumSpatialLayers = ssrcs.size();
3115 const size_t kNumTemporalLayers = 3;
3116 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3117 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3118
Niels Möllerff40b142018-04-09 08:49:14 +02003119 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003120}
3121
asaperssonc5dabdd2016-03-21 04:15:50 -07003122class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3123 public:
brandtr468da7c2016-11-22 02:16:47 -08003124 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003125 : Vp9SettingsTest(field_trials) {}
3126
3127 protected:
3128 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3129 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003130 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003131 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3132
3133 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3134
Tommi85959932018-02-07 19:26:06 +01003135 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003136 EXPECT_EQ(cricket::CS_RUNNING,
3137 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003138 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003139 channel_->SetSend(true);
3140
3141 EXPECT_TRUE(capturer.CaptureFrame());
3142
3143 webrtc::VideoCodecVP9 vp9_settings;
3144 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3145 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3146 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3147
Niels Möllerff40b142018-04-09 08:49:14 +02003148 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003149 }
3150};
3151
3152class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3153 public:
3154 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3155};
3156
3157TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3158 const int kNumSpatialLayers = 1;
3159 const int kNumTemporalLayers = 1;
3160 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3161}
3162
3163class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3164 public:
3165 Vp9SettingsTestWithInvalidFlag()
3166 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3167};
3168
3169TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3170 const int kNumSpatialLayers = 1;
3171 const int kNumTemporalLayers = 1;
3172 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3173}
3174
3175class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3176 public:
3177 Vp9SettingsTestWith2SL3TLFlag()
3178 : Vp9SettingsTestWithFieldTrial(
3179 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3180};
3181
3182TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3183 const int kNumSpatialLayers = 2;
3184 const int kNumTemporalLayers = 3;
3185 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3186}
3187
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003188TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3189 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3190 ASSERT_EQ(1u, streams.size());
3191 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3192}
3193
3194TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3195 webrtc::test::ScopedFieldTrials override_field_trials_(
3196 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3197 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3198 ASSERT_EQ(1u, streams.size());
3199 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3200}
3201
asapersson3c81a1a2017-06-14 05:52:21 -07003202TEST_F(WebRtcVideoChannelTest,
3203 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3204 webrtc::test::ScopedFieldTrials override_field_trials_(
3205 "WebRTC-Video-BalancedDegradation/Disabled/");
3206 const bool kResolutionScalingEnabled = true;
3207 const bool kFpsScalingEnabled = false;
3208 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3209}
3210
3211TEST_F(WebRtcVideoChannelTest,
3212 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3213 webrtc::test::ScopedFieldTrials override_field_trials_(
3214 "WebRTC-Video-BalancedDegradation/Enabled/");
3215 const bool kResolutionScalingEnabled = true;
3216 const bool kFpsScalingEnabled = true;
3217 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3218}
3219
eladalonf1841382017-06-12 01:16:46 -07003220TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003221 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003222}
3223
eladalonf1841382017-06-12 01:16:46 -07003224TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003225 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003226}
3227
eladalonf1841382017-06-12 01:16:46 -07003228TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003229 TestCpuAdaptation(true, true);
3230}
3231
eladalonf1841382017-06-12 01:16:46 -07003232TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003233 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003234 cricket::VideoSendParameters parameters;
3235 parameters.codecs.push_back(codec);
3236
kthelgason2bc68642017-02-07 07:02:22 -08003237 MediaConfig media_config = GetMediaConfig();
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003238 channel_.reset(engine_.CreateChannel(
3239 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003240 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003241 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3242
3243 AddSendStream();
3244
Tommi85959932018-02-07 19:26:06 +01003245 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003246 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003247 ASSERT_EQ(cricket::CS_RUNNING,
3248 capturer.Start(capturer.GetSupportedFormats()->front()));
3249 ASSERT_TRUE(channel_->SetSend(true));
3250
3251 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3252 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003253
Niels Möllera6cc0f92018-02-12 17:14:55 +01003254 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003255 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3256 EXPECT_EQ(1280, send_stream->GetLastWidth());
3257 EXPECT_EQ(720, send_stream->GetLastHeight());
3258
3259 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003260 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003261 wants.max_pixel_count =
3262 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003263 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003264 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003265 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3266 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3267 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3268
3269 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003270 wants.max_pixel_count =
3271 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003272 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003273 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003274 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3275 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3276 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3277
3278 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003279 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003280 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003281 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3282 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3283
3284 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003285 int current_pixel_count =
3286 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3287 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3288 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003289 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003290 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003291 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003292 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003293 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003294 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003295 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3296 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3297
sprang84a37592017-02-10 07:04:27 -08003298 // Trigger underuse again, should go back up to full resolution.
3299 current_pixel_count =
3300 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003301 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003302 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003303 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003304 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003305 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003306 EXPECT_EQ(1284, send_stream->GetLastWidth());
3307 EXPECT_EQ(724, send_stream->GetLastHeight());
3308
Niels Möllerff40b142018-04-09 08:49:14 +02003309 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003310}
3311
eladalonf1841382017-06-12 01:16:46 -07003312TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003313 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003314 cricket::VideoSendParameters parameters;
3315 parameters.codecs.push_back(codec);
3316
kthelgason2bc68642017-02-07 07:02:22 -08003317 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003318 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003319 channel_.reset(engine_.CreateChannel(
3320 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003321 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003322 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3323
3324 AddSendStream();
3325
Tommi85959932018-02-07 19:26:06 +01003326 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003327 ASSERT_EQ(cricket::CS_RUNNING,
3328 capturer.Start(capturer.GetSupportedFormats()->front()));
3329 ASSERT_TRUE(channel_->SetSend(true));
3330 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003331 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003332 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003333
3334 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3335 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003336
Niels Möllera6cc0f92018-02-12 17:14:55 +01003337 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003338 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3339 EXPECT_EQ(1280, send_stream->GetLastWidth());
3340 EXPECT_EQ(720, send_stream->GetLastHeight());
3341
3342 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003343 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003344 wants.max_pixel_count =
3345 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003346 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003347 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003348 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3349 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3350 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3351
3352 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003353 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003354 ASSERT_EQ(cricket::CS_RUNNING,
3355 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003356 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003357 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003358 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003359 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003360 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3361 send_stream = fake_call_->GetVideoSendStreams().front();
3362 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003363 EXPECT_EQ(1284, send_stream->GetLastWidth());
3364 EXPECT_EQ(724, send_stream->GetLastHeight());
3365
3366 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003367 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003368 send_stream = fake_call_->GetVideoSendStreams().front();
3369 // We have a new fake send stream, so it doesn't remember the old sink wants.
3370 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003371 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003372 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003373 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003374 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3375 send_stream = fake_call_->GetVideoSendStreams().front();
3376 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003377 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3378 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3379
Niels Möllerff40b142018-04-09 08:49:14 +02003380 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003381}
3382
asapersson3c81a1a2017-06-14 05:52:21 -07003383// TODO(asapersson): Remove this test when the balanced field trial is removed.
3384void WebRtcVideoChannelTest::TestDegradationPreference(
3385 bool resolution_scaling_enabled,
3386 bool fps_scaling_enabled) {
3387 cricket::VideoCodec codec = GetEngineCodec("VP8");
3388 cricket::VideoSendParameters parameters;
3389 parameters.codecs.push_back(codec);
3390
3391 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003392 media_config.video.enable_cpu_adaptation = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003393 channel_.reset(engine_.CreateChannel(
3394 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003395 channel_->OnReadyToSend(true);
3396
3397 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3398
3399 AddSendStream();
3400
Tommi85959932018-02-07 19:26:06 +01003401 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003402 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003403 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003404 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3405 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3406
3407 EXPECT_TRUE(channel_->SetSend(true));
3408
3409 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3410 EXPECT_EQ(resolution_scaling_enabled,
3411 send_stream->resolution_scaling_enabled());
3412 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3413
Niels Möllerff40b142018-04-09 08:49:14 +02003414 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003415}
3416
eladalonf1841382017-06-12 01:16:46 -07003417void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3418 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003419 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003420 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003421 cricket::VideoSendParameters parameters;
3422 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003423
kthelgason2bc68642017-02-07 07:02:22 -08003424 MediaConfig media_config = GetMediaConfig();
3425 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003426 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003427 }
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003428 channel_.reset(engine_.CreateChannel(
3429 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003430 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003431
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003432 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003433
3434 AddSendStream();
3435
Tommi85959932018-02-07 19:26:06 +01003436 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003437 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003438 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003439 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003440 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003441 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003442 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003443
3444 EXPECT_TRUE(channel_->SetSend(true));
3445
solenberge5269742015-09-08 05:13:22 -07003446 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003447
sprangc5d62e22017-04-02 23:53:04 -07003448 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003449 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003450 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3451 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003452
3453 EXPECT_TRUE(capturer.CaptureFrame());
3454 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3455
perkj26752742016-10-24 01:21:16 -07003456 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3457 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003458
Niels Möllerff40b142018-04-09 08:49:14 +02003459 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003460 return;
3461 }
3462
sprangc5d62e22017-04-02 23:53:04 -07003463 if (is_screenshare) {
3464 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3465 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3466 } else {
3467 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3468 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3469 }
3470
perkj803d97f2016-11-01 11:45:46 -07003471 // Trigger overuse.
3472 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3473
3474 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003475 if (is_screenshare) {
3476 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3477 } else {
3478 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3479 }
perkj803d97f2016-11-01 11:45:46 -07003480 send_stream->InjectVideoSinkWants(wants);
3481
sprangc5d62e22017-04-02 23:53:04 -07003482 for (int i = 0; i < kDefaultFps; ++i)
3483 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003484
sprangc5d62e22017-04-02 23:53:04 -07003485 if (is_screenshare) {
3486 // Drops every third frame.
3487 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3488 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3489 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3490 } else {
3491 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3492 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3493 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3494 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003495
3496 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003497 int last_pixel_count =
3498 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003499 if (is_screenshare) {
3500 wants.max_framerate_fps = kDefaultFps;
3501 } else {
3502 wants.max_pixel_count = last_pixel_count * 4;
3503 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3504 }
perkj803d97f2016-11-01 11:45:46 -07003505 send_stream->InjectVideoSinkWants(wants);
3506
sprangc5d62e22017-04-02 23:53:04 -07003507 for (int i = 0; i < kDefaultFps; ++i)
3508 EXPECT_TRUE(capturer.CaptureFrame());
3509
3510 if (is_screenshare) {
3511 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3512 send_stream->GetNumberOfSwappedFrames());
3513 } else {
3514 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3515 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003516
perkj26752742016-10-24 01:21:16 -07003517 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3518 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003519
Niels Möllerff40b142018-04-09 08:49:14 +02003520 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003521}
3522
eladalonf1841382017-06-12 01:16:46 -07003523TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003524 // Start at last timestamp to verify that wraparounds are estimated correctly.
3525 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3526 static const int64_t kInitialNtpTimeMs = 1247891230;
3527 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003528 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003529
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003530 FakeVideoReceiveStream* stream = AddRecvStream();
3531 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003532 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003533
nisse64ec8f82016-09-27 00:17:25 -07003534 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3535 kInitialTimestamp, 0,
3536 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003537 // Initial NTP time is not available on the first frame, but should still be
3538 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003539 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003540
3541 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003542
3543 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3544 // triggers a constant-overflow warning, hence we're calculating it explicitly
3545 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003546 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003547 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3548 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003549 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003550
3551 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003552
3553 // Verify that NTP time has been correctly deduced.
3554 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003555 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003556 ASSERT_EQ(1u, info.receivers.size());
3557 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003558}
3559
eladalonf1841382017-06-12 01:16:46 -07003560TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003561 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003562 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003563
3564 VideoCodec codec;
3565 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003566 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003567
3568 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003569 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3570 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003571 FakeVideoSendStream* stream = AddSendStream(
3572 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003573 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003574
3575 // Make sure NACK and FEC are enabled on the correct payload types.
3576 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003577 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3578 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003579
3580 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3581 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003582 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003583 // TODO(juberti): Check RTCP, PLI, TMMBR.
3584}
3585
brandtr31bd2242017-05-19 05:47:46 -07003586// The following four tests ensures that FlexFEC is not activated by default
3587// when the field trials are not enabled.
3588// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3589// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003590TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003591 FakeVideoSendStream* stream = AddSendStream();
3592 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3593
brandtr3d200bd2017-01-16 06:59:19 -08003594 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003595 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3596 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003597}
3598
eladalonf1841382017-06-12 01:16:46 -07003599TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003600 FakeVideoSendStream* stream = AddSendStream(
3601 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3602 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3603
brandtr3d200bd2017-01-16 06:59:19 -08003604 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003605 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3606 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3607}
3608
Yves Gerey665174f2018-06-19 15:03:05 +02003609TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003610 AddRecvStream();
3611
3612 const std::vector<FakeFlexfecReceiveStream*>& streams =
3613 fake_call_->GetFlexfecReceiveStreams();
3614 EXPECT_TRUE(streams.empty());
3615}
3616
eladalonf1841382017-06-12 01:16:46 -07003617TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003618 AddRecvStream(
3619 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3620
3621 const std::vector<FakeFlexfecReceiveStream*>& streams =
3622 fake_call_->GetFlexfecReceiveStreams();
3623 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003624}
3625
3626// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3627// tests that use this test fixture into the corresponding "non-field trial"
3628// tests.
eladalonf1841382017-06-12 01:16:46 -07003629class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003630 public:
eladalonf1841382017-06-12 01:16:46 -07003631 WebRtcVideoChannelFlexfecRecvTest()
3632 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003633};
3634
eladalonf1841382017-06-12 01:16:46 -07003635TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003636 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3637 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3638 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3639}
3640
eladalonf1841382017-06-12 01:16:46 -07003641TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003642 AddRecvStream();
3643
3644 const std::vector<FakeFlexfecReceiveStream*>& streams =
3645 fake_call_->GetFlexfecReceiveStreams();
3646 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003647
3648 const std::vector<FakeVideoReceiveStream*>& video_streams =
3649 fake_call_->GetVideoReceiveStreams();
3650 ASSERT_EQ(1U, video_streams.size());
3651 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3652 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3653 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003654}
3655
eladalonf1841382017-06-12 01:16:46 -07003656TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003657 AddRecvStream(
3658 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3659
3660 const std::vector<FakeFlexfecReceiveStream*>& streams =
3661 fake_call_->GetFlexfecReceiveStreams();
3662 ASSERT_EQ(1U, streams.size());
3663 const FakeFlexfecReceiveStream* stream = streams.front();
3664 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3665 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3666 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3667 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3668 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003669
3670 const std::vector<FakeVideoReceiveStream*>& video_streams =
3671 fake_call_->GetVideoReceiveStreams();
3672 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003673 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3674 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003675 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003676 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003677 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003678}
3679
eladalonf1841382017-06-12 01:16:46 -07003680TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003681 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3682 cricket::VideoRecvParameters recv_parameters;
3683 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3684 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3685
3686 AddRecvStream(
3687 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3688 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003689 const std::vector<FakeVideoReceiveStream*>& video_streams =
3690 fake_call_->GetVideoReceiveStreams();
3691 ASSERT_EQ(1U, video_streams.size());
3692 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3693 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3694 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003695
3696 // Enable FlexFEC.
3697 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3698 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3699 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3700 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3701 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3702 << "Enabling FlexFEC should not create VideoReceiveStream.";
3703 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3704 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003705 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3706 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003707}
3708
eladalonf1841382017-06-12 01:16:46 -07003709TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003710 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3711 cricket::VideoRecvParameters recv_parameters;
3712 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3713 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3714 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3715
3716 AddRecvStream(
3717 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3718 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003719 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003720 const std::vector<FakeVideoReceiveStream*>& video_streams =
3721 fake_call_->GetVideoReceiveStreams();
3722 ASSERT_EQ(1U, video_streams.size());
3723 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3724 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3725 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003726
3727 // Disable FlexFEC.
3728 recv_parameters.codecs.clear();
3729 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3730 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3731 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3732 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3733 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3734 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3735 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3736 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003737 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3738 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003739}
3740
brandtr31bd2242017-05-19 05:47:46 -07003741// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3742// tests that use this test fixture into the corresponding "non-field trial"
3743// tests.
eladalonf1841382017-06-12 01:16:46 -07003744class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003745 public:
eladalonf1841382017-06-12 01:16:46 -07003746 WebRtcVideoChannelFlexfecSendRecvTest()
3747 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003748 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3749 }
3750};
3751
Yves Gerey665174f2018-06-19 15:03:05 +02003752TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003753 FakeVideoSendStream* stream = AddSendStream();
3754 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3755
brandtr3d200bd2017-01-16 06:59:19 -08003756 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3757 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3758 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003759}
3760
eladalonf1841382017-06-12 01:16:46 -07003761TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003762 FakeVideoSendStream* stream = AddSendStream(
3763 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3764 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3765
brandtr3d200bd2017-01-16 06:59:19 -08003766 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3767 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3768 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3769 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003770}
3771
eladalonf1841382017-06-12 01:16:46 -07003772TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003773 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003774 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003775 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003776
3777 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003778 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003779
brandtrb5f2c3f2016-10-04 23:28:39 -07003780 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3781 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003782}
3783
eladalonf1841382017-06-12 01:16:46 -07003784TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003785 cricket::VideoSendParameters parameters;
3786 parameters.codecs.push_back(GetEngineCodec("VP8"));
3787 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3788
3789 FakeVideoSendStream* stream = AddSendStream();
3790 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3791
brandtr3d200bd2017-01-16 06:59:19 -08003792 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003793}
3794
eladalonf1841382017-06-12 01:16:46 -07003795TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003796 AddRecvStream(
3797 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003798
3799 cricket::VideoRecvParameters recv_parameters;
3800 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3801 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3802 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003803
3804 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3805 fake_call_->GetFlexfecReceiveStreams();
3806 ASSERT_EQ(1U, flexfec_streams.size());
3807 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3808 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3809 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003810 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003811 flexfec_stream_config.payload_type);
3812 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3813 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3814 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3815 const std::vector<FakeVideoReceiveStream*>& video_streams =
3816 fake_call_->GetVideoReceiveStreams();
3817 const FakeVideoReceiveStream* video_stream = video_streams.front();
3818 const webrtc::VideoReceiveStream::Config& video_stream_config =
3819 video_stream->GetConfig();
3820 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3821 flexfec_stream_config.local_ssrc);
3822 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3823 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3824 flexfec_stream_config.rtcp_send_transport);
3825 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3826 // spec-compliant way.
3827 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3828 flexfec_stream_config.transport_cc);
3829 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3830 EXPECT_EQ(video_stream_config.rtp.extensions,
3831 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003832}
3833
brandtr31bd2242017-05-19 05:47:46 -07003834// We should not send FlexFEC, even if we advertise it, unless the right
3835// field trial is set.
3836// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003837TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003838 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3839 cricket::VideoSendParameters parameters;
3840 parameters.codecs.push_back(GetEngineCodec("VP8"));
3841 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3842 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3843
3844 FakeVideoSendStream* stream = AddSendStream();
3845 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3846
3847 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003848 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003849 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3850}
3851
eladalonf1841382017-06-12 01:16:46 -07003852TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003853 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3854 cricket::VideoSendParameters parameters;
3855 parameters.codecs.push_back(GetEngineCodec("VP8"));
3856 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3857 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3858
3859 FakeVideoSendStream* stream = AddSendStream(
3860 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3861 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3862
3863 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003864 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003865 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3866}
3867
eladalonf1841382017-06-12 01:16:46 -07003868TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003869 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003870 const int kUnusedPayloadType = 127;
3871 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3872
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003873 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003874 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003875 parameters.codecs.push_back(rtx_codec);
3876 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003877 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003878}
3879
eladalonf1841382017-06-12 01:16:46 -07003880TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003881 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003882 const int kUnusedPayloadType1 = 126;
3883 const int kUnusedPayloadType2 = 127;
3884 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3885 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3886 {
3887 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3888 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3889 cricket::VideoSendParameters parameters;
3890 parameters.codecs.push_back(GetEngineCodec("VP8"));
3891 parameters.codecs.push_back(rtx_codec);
3892 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3893 }
3894 {
3895 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3896 kUnusedPayloadType1, kUnusedPayloadType2);
3897 cricket::VideoSendParameters parameters;
3898 parameters.codecs.push_back(GetEngineCodec("VP8"));
3899 parameters.codecs.push_back(rtx_codec);
3900 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3901 << "RTX without matching video codec should be rejected.";
3902 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003903}
3904
eladalonf1841382017-06-12 01:16:46 -07003905TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003906 const int kUnusedPayloadType1 = 126;
3907 const int kUnusedPayloadType2 = 127;
3908 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3909 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3910
3911 // SSRCs for RTX.
3912 cricket::StreamParams params =
3913 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3914 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3915 AddSendStream(params);
3916
3917 // Original payload type for RTX.
3918 cricket::VideoSendParameters parameters;
3919 parameters.codecs.push_back(GetEngineCodec("VP8"));
3920 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3921 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3922 parameters.codecs.push_back(rtx_codec);
3923 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3924 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3925 const webrtc::VideoSendStream::Config& config_before =
3926 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3927 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3928 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3929 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3930
3931 // Change payload type for RTX.
3932 parameters.codecs[1].id = kUnusedPayloadType2;
3933 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3934 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3935 const webrtc::VideoSendStream::Config& config_after =
3936 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3937 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3938 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3939 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3940}
3941
eladalonf1841382017-06-12 01:16:46 -07003942TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003943 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003944 parameters.codecs.push_back(GetEngineCodec("VP8"));
3945 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003946 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003947
3948 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003949 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003950
magjed509e4fe2016-11-18 01:34:11 -08003951 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003952
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003953 parameters.codecs.pop_back();
3954 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003955 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003956 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003957 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003958 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003959 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3960}
3961
eladalonf1841382017-06-12 01:16:46 -07003962TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003963 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003964 cricket::VideoSendParameters parameters;
3965 parameters.codecs.push_back(GetEngineCodec("VP8"));
3966 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3967 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3968
3969 FakeVideoSendStream* stream = AddSendStream(
3970 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3971 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3972
brandtr3d200bd2017-01-16 06:59:19 -08003973 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3974 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003975 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3976 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3977
3978 parameters.codecs.pop_back();
3979 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3980 stream = fake_call_->GetVideoSendStreams()[0];
3981 ASSERT_TRUE(stream != nullptr);
3982 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003983 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003984 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003985}
3986
eladalonf1841382017-06-12 01:16:46 -07003987TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003988 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003989 cricket::VideoCodec codec(100, "VP8");
3990 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3991 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003992
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003993 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003994 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003995
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003996 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003997 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003998 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003999
4000 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004001 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004002
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004003 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004004 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4005 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004006 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004007 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004008 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004009 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004010}
4011
eladalonf1841382017-06-12 01:16:46 -07004012TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004013 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4014 200000);
4015}
4016
eladalonf1841382017-06-12 01:16:46 -07004017TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004018 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4019 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4020 ASSERT_EQ(1u, streams.size());
4021 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4022}
4023
eladalonf1841382017-06-12 01:16:46 -07004024TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004025 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004026 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004027}
4028
eladalonf1841382017-06-12 01:16:46 -07004029TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004030 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004031}
4032
eladalonf1841382017-06-12 01:16:46 -07004033TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004034 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4035 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4036 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004037}
4038
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004039// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4040// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004041TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004042 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4043 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4044 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4045 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004046 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004047 ExpectSetBitrateParameters(100000, 200000, 400000);
4048 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4049 // Since the codec isn't changing, start_bitrate_bps should be -1.
4050 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004051
4052 // Decrease max_bandwidth_bps.
4053 send_parameters_.max_bandwidth_bps = 350000;
4054 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004055
4056 // Now try again with the values flipped around.
4057 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4058 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004059 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004060 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004061
4062 // If we change the codec max, max_bandwidth_bps should still apply.
4063 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004064 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004065 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004066}
4067
Yves Gerey665174f2018-06-19 15:03:05 +02004068TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004069 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4070 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004071 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004072 // Setting max bitrate should keep previous min bitrate.
4073 // Setting max bitrate should not reset start bitrate.
4074 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004075 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004076}
4077
eladalonf1841382017-06-12 01:16:46 -07004078TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004079 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004080 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004081 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004082 // -1 means to disable max bitrate (set infinite).
4083 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004084 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004085 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004086}
4087
eladalonf1841382017-06-12 01:16:46 -07004088TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004089 send_parameters_.max_bandwidth_bps = 99999;
4090 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004091 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004092 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004093 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4094 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4095 stream->GetVideoStreams()[0].max_bitrate_bps);
4096
4097 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004098 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004099 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4100 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004101 stream->GetVideoStreams()[0].max_bitrate_bps);
4102}
4103
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004104// Tests that when the codec specific max bitrate and VideoSendParameters
4105// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4106// appropriately.
4107TEST_F(WebRtcVideoChannelTest,
4108 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4109 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4110 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4111 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4112 send_parameters_.max_bandwidth_bps = -1;
4113 AddSendStream();
4114 ExpectSetMaxBitrate(300000);
4115 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4116
4117 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4118 ASSERT_EQ(1u, video_send_streams.size());
4119 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4120 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4121 // First the max bitrate is set based upon the codec param.
4122 EXPECT_EQ(300000,
4123 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4124
4125 // The VideoSendParameters max bitrate overrides the codec's.
4126 send_parameters_.max_bandwidth_bps = 500000;
4127 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4128 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4129 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4130 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4131}
4132
4133// Tests that when the codec specific max bitrate and RtpParameters
4134// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4135// appropriately.
4136TEST_F(WebRtcVideoChannelTest,
4137 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4138 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4139 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4140 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4141 send_parameters_.max_bandwidth_bps = -1;
4142 AddSendStream();
4143 ExpectSetMaxBitrate(300000);
4144 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4145
4146 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4147 ASSERT_EQ(1u, video_send_streams.size());
4148 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4149 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4150 // First the max bitrate is set based upon the codec param.
4151 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4152
4153 // The RtpParameter max bitrate overrides the codec's.
4154 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4155 ASSERT_EQ(1u, parameters.encodings.size());
4156 parameters.encodings[0].max_bitrate_bps = 500000;
4157 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4158 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4159 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4160 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4161}
4162
Åsa Persson55659812018-06-18 17:51:32 +02004163TEST_F(WebRtcVideoChannelTest,
4164 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4165 send_parameters_.max_bandwidth_bps = 99999;
4166 FakeVideoSendStream* stream = AddSendStream();
4167 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4168 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4169 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4170 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4171 stream->GetVideoStreams()[0].max_bitrate_bps);
4172
4173 // Get and set the rtp encoding parameters.
4174 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4175 EXPECT_EQ(1u, parameters.encodings.size());
4176
4177 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4178 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4179 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4180 stream->GetVideoStreams()[0].max_bitrate_bps);
4181
4182 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4183 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4184 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4185 stream->GetVideoStreams()[0].max_bitrate_bps);
4186}
4187
eladalonf1841382017-06-12 01:16:46 -07004188TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004189 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004190 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004191 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004192 channel_->SetSend(true);
4193
4194 FakeVideoSendStream* stream = AddSendStream();
4195
Tommi85959932018-02-07 19:26:06 +01004196 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004197 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004198 EXPECT_EQ(cricket::CS_RUNNING,
4199 capturer.Start(capturer.GetSupportedFormats()->front()));
4200
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004201 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4202 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4203 EXPECT_GT(initial_max_bitrate_bps, 0);
4204
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004205 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4206 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004207 // Insert a frame to update the encoder config.
4208 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004209 streams = stream->GetVideoStreams();
4210 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004211 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004212}
4213
eladalonf1841382017-06-12 01:16:46 -07004214TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004215 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004216 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004217 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004218 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004219 channel_->SetSend(true);
4220
4221 FakeVideoSendStream* stream = AddSendStream(
4222 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4223
4224 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004225 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004226 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004227 EXPECT_EQ(cricket::CS_RUNNING,
4228 capturer.Start(capturer.GetSupportedFormats()->front()));
4229 EXPECT_TRUE(capturer.CaptureFrame());
4230
4231 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4232 ASSERT_GT(streams.size(), 1u)
4233 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004234 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004235 EXPECT_GT(initial_max_bitrate_bps, 0);
4236
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004237 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4238 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004239 // Insert a frame to update the encoder config.
4240 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004241 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004242 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004243 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4244
Niels Möllerff40b142018-04-09 08:49:14 +02004245 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004246}
4247
eladalonf1841382017-06-12 01:16:46 -07004248TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004249 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004250 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004251 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004252 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4253 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004254 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004255 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004256
4257 VideoCodec codec;
4258 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4259 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4260}
4261
eladalonf1841382017-06-12 01:16:46 -07004262TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004263 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004264 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004265 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004266 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004267 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004268 parameters.codecs[0].id = kIncorrectPayloads[i];
4269 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004270 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004271 }
4272}
4273
eladalonf1841382017-06-12 01:16:46 -07004274TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004275 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004276 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004277 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004278 parameters.codecs[0].id = payload_type;
4279 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004280 << "Payload type '" << payload_type << "' rejected.";
4281 }
4282}
4283
deadbeef67cf2c12016-04-13 10:07:16 -07004284// Test that setting the a different set of codecs but with an identical front
4285// codec doesn't result in the stream being recreated.
4286// This may happen when a subsequent negotiation includes fewer codecs, as a
4287// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004288TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004289 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4290 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004291 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4292 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004293 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4294
4295 AddSendStream();
4296 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4297
4298 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004299 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004300 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4301 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4302}
4303
eladalonf1841382017-06-12 01:16:46 -07004304TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004305 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004306 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004307 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004308}
4309
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004310// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004311TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004312 const int kUnusedPayloadType1 = 126;
4313 const int kUnusedPayloadType2 = 127;
4314 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4315 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4316
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004317 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004318 parameters.codecs.push_back(GetEngineCodec("VP8"));
4319 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004320 parameters.codecs.push_back(rtx_codec);
4321 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004322 << "RTX codec without associated payload should be rejected.";
4323
magjed509e4fe2016-11-18 01:34:11 -08004324 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004325 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004326 << "RTX codec with invalid associated payload type should be rejected.";
4327
magjed509e4fe2016-11-18 01:34:11 -08004328 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004329 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004330
magjed509e4fe2016-11-18 01:34:11 -08004331 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004332 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004333 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004334
Yves Gerey665174f2018-06-19 15:03:05 +02004335 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4336 << "RTX codec with another RTX as associated payload type should be "
4337 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004338}
4339
eladalonf1841382017-06-12 01:16:46 -07004340TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004341 const int kUnusedPayloadType1 = 126;
4342 const int kUnusedPayloadType2 = 127;
4343 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4344 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4345
4346 // SSRCs for RTX.
4347 cricket::StreamParams params =
4348 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4349 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4350 AddRecvStream(params);
4351
4352 // Original payload type for RTX.
4353 cricket::VideoRecvParameters parameters;
4354 parameters.codecs.push_back(GetEngineCodec("VP8"));
4355 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4356 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4357 parameters.codecs.push_back(rtx_codec);
4358 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4359 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4360 const webrtc::VideoReceiveStream::Config& config_before =
4361 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004362 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4363 const int* payload_type_before = FindKeyByValue(
4364 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4365 ASSERT_NE(payload_type_before, nullptr);
4366 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004367 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4368
4369 // Change payload type for RTX.
4370 parameters.codecs[1].id = kUnusedPayloadType2;
4371 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4372 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4373 const webrtc::VideoReceiveStream::Config& config_after =
4374 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004375 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4376 const int* payload_type_after = FindKeyByValue(
4377 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4378 ASSERT_NE(payload_type_after, nullptr);
4379 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004380 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4381}
4382
eladalonf1841382017-06-12 01:16:46 -07004383TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004384 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004385 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004386 parameters.codecs[0].id = 99;
4387 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004388}
4389
eladalonf1841382017-06-12 01:16:46 -07004390TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004391 cricket::VideoRecvParameters parameters;
4392 parameters.codecs = engine_.codecs();
4393 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004394
4395 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004396 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004397 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004398 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004399}
4400
eladalonf1841382017-06-12 01:16:46 -07004401TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004402 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004403 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004404 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004405 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004406}
4407
eladalonf1841382017-06-12 01:16:46 -07004408TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004409 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004410 parameters.codecs.push_back(GetEngineCodec("VP8"));
4411 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004412 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004413}
4414
eladalonf1841382017-06-12 01:16:46 -07004415TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004416 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004417 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4418 send_parameters.codecs.push_back(GetEngineCodec("red"));
4419 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004420 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004421
4422 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004423
magjed509e4fe2016-11-18 01:34:11 -08004424 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004425 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004426
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004427 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004428 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004429 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004430 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004431 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004432 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004433 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4434}
4435
eladalonf1841382017-06-12 01:16:46 -07004436TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004437 AddRecvStream(
4438 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004439 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004440 fake_call_->GetFlexfecReceiveStreams();
4441
4442 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004443 const FakeFlexfecReceiveStream* stream = streams.front();
4444 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4445 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4446 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4447 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004448
4449 cricket::VideoRecvParameters recv_parameters;
4450 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4451 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4452 EXPECT_TRUE(streams.empty())
4453 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004454}
4455
eladalonf1841382017-06-12 01:16:46 -07004456TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004457 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004458 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004459 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004460
4461 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004462 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4463 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4464 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004465 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4466 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004467 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004468 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004469 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004470 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004471
4472 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004473 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4474 send_parameters.codecs.push_back(GetEngineCodec("red"));
4475 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004476 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4477 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004478 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004479 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004480 << "ULPFEC should be enabled on the receive stream.";
4481}
4482
eladalonf1841382017-06-12 01:16:46 -07004483TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004484 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004485 AddRecvStream(
4486 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004487 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004488 fake_call_->GetFlexfecReceiveStreams();
4489
4490 cricket::VideoRecvParameters recv_parameters;
4491 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4492 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4493 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4494 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004495 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004496 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004497 stream_with_recv_params->GetConfig().payload_type);
4498 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004499 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004500 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004501 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004502 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004503
4504 cricket::VideoSendParameters send_parameters;
4505 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4506 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4507 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4508 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004509 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004510 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004511 stream_with_send_params->GetConfig().payload_type);
4512 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004513 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004514 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004515 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004516 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004517}
4518
eladalonf1841382017-06-12 01:16:46 -07004519TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004520 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004521 parameters.codecs.push_back(GetEngineCodec("VP8"));
4522 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004523 parameters.codecs[1].id = parameters.codecs[0].id;
4524 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004525}
4526
eladalonf1841382017-06-12 01:16:46 -07004527TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004528 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004529 cricket::VideoRecvParameters parameters;
4530 parameters.codecs.push_back(GetEngineCodec("VP8"));
4531 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4532 parameters.codecs[1].id = parameters.codecs[0].id;
4533 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4534}
4535
eladalonf1841382017-06-12 01:16:46 -07004536TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004537 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004538 parameters.codecs.push_back(GetEngineCodec("VP8"));
4539 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004540 parameters.codecs[1].id = parameters.codecs[0].id;
4541 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004542}
4543
eladalonf1841382017-06-12 01:16:46 -07004544TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004545 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004546 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004547 parameters.codecs.push_back(GetEngineCodec("VP8"));
4548 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004549 parameters.codecs[1].id += 1;
4550 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004551}
4552
deadbeef67cf2c12016-04-13 10:07:16 -07004553// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004554// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004555TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004556 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004557 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004558 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4559 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004560 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004561
4562 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4563 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4564
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004565 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004566 parameters2.codecs.push_back(GetEngineCodec("red"));
4567 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004568 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004569 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4570}
4571
eladalonf1841382017-06-12 01:16:46 -07004572TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004573 EXPECT_FALSE(AddSendStream()->IsSending());
4574}
4575
eladalonf1841382017-06-12 01:16:46 -07004576TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004577 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004578}
4579
eladalonf1841382017-06-12 01:16:46 -07004580TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004581 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004582 EXPECT_FALSE(stream->IsSending());
4583
4584 // false->true
4585 EXPECT_TRUE(channel_->SetSend(true));
4586 EXPECT_TRUE(stream->IsSending());
4587 // true->true
4588 EXPECT_TRUE(channel_->SetSend(true));
4589 EXPECT_TRUE(stream->IsSending());
4590 // true->false
4591 EXPECT_TRUE(channel_->SetSend(false));
4592 EXPECT_FALSE(stream->IsSending());
4593 // false->false
4594 EXPECT_TRUE(channel_->SetSend(false));
4595 EXPECT_FALSE(stream->IsSending());
4596
4597 EXPECT_TRUE(channel_->SetSend(true));
4598 FakeVideoSendStream* new_stream = AddSendStream();
4599 EXPECT_TRUE(new_stream->IsSending())
4600 << "Send stream created after SetSend(true) not sending initially.";
4601}
4602
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004603// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004604TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004605 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004606 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004607 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004608 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004609 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004610
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004611 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4612 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004613 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004614 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004615 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004616
Tim Haloun648d28a2018-10-18 16:52:22 -07004617 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4618 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004619 config.enable_dscp = true;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004620 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4621 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004622 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004623 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4624
4625 // Create a send stream to configure
4626 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4627 parameters = channel->GetRtpSendParameters(kSsrc);
4628 ASSERT_FALSE(parameters.encodings.empty());
4629
4630 // Various priorities map to various dscp values.
4631 parameters.encodings[0].network_priority = 4.0;
4632 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004633 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004634 parameters.encodings[0].network_priority = 0.5;
4635 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4636 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4637
4638 // A bad priority does not change the dscp value.
4639 parameters.encodings[0].network_priority = 0.0;
4640 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4641 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004642
Tim Haloun6ca98362018-09-17 17:06:08 -07004643 // Packets should also self-identify their dscp in PacketOptions.
4644 const uint8_t kData[10] = {0};
4645 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4646 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004647 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004648
nisse51542be2016-02-12 02:27:06 -08004649 // Verify that setting the option to false resets the
4650 // DiffServCodePoint.
4651 config.enable_dscp = false;
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07004652 channel.reset(static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateChannel(
4653 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004654 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004655 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004656}
4657
deadbeef13871492015-12-09 12:37:51 -08004658// This test verifies that the RTCP reduced size mode is properly applied to
4659// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004660TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004661 // Create stream, expecting that default mode is "compound".
4662 FakeVideoSendStream* stream1 = AddSendStream();
4663 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004664 webrtc::RtpParameters rtp_parameters =
4665 channel_->GetRtpSendParameters(last_ssrc_);
4666 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004667
4668 // Now enable reduced size mode.
4669 send_parameters_.rtcp.reduced_size = true;
4670 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4671 stream1 = fake_call_->GetVideoSendStreams()[0];
4672 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004673 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4674 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004675
4676 // Create a new stream and ensure it picks up the reduced size mode.
4677 FakeVideoSendStream* stream2 = AddSendStream();
4678 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4679}
4680
4681// This test verifies that the RTCP reduced size mode is properly applied to
4682// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004683TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004684 // Create stream, expecting that default mode is "compound".
4685 FakeVideoReceiveStream* stream1 = AddRecvStream();
4686 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4687
4688 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004689 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4690 // the reduced_size flag should come from that.
4691 send_parameters_.rtcp.reduced_size = true;
4692 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004693 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4694 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4695
4696 // Create a new stream and ensure it picks up the reduced size mode.
4697 FakeVideoReceiveStream* stream2 = AddRecvStream();
4698 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4699}
4700
eladalonf1841382017-06-12 01:16:46 -07004701TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004702 EXPECT_EQ(webrtc::kNetworkUp,
4703 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4704 EXPECT_EQ(webrtc::kNetworkUp,
4705 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004706
4707 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004708 EXPECT_EQ(webrtc::kNetworkDown,
4709 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4710 EXPECT_EQ(webrtc::kNetworkUp,
4711 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004712
4713 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004714 EXPECT_EQ(webrtc::kNetworkUp,
4715 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4716 EXPECT_EQ(webrtc::kNetworkUp,
4717 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004718}
4719
eladalonf1841382017-06-12 01:16:46 -07004720TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004721 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004722 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004723 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004724
4725 AddSendStream();
4726
4727 cricket::VideoMediaInfo info;
4728 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004729 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004730}
4731
eladalonf1841382017-06-12 01:16:46 -07004732TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004733 FakeVideoSendStream* stream = AddSendStream();
4734 webrtc::VideoSendStream::Stats stats;
4735 stats.encoder_implementation_name = "encoder_implementation_name";
4736 stream->SetStats(stats);
4737
4738 cricket::VideoMediaInfo info;
4739 ASSERT_TRUE(channel_->GetStats(&info));
4740 EXPECT_EQ(stats.encoder_implementation_name,
4741 info.senders[0].encoder_implementation_name);
4742}
4743
eladalonf1841382017-06-12 01:16:46 -07004744TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004745 FakeVideoSendStream* stream = AddSendStream();
4746 webrtc::VideoSendStream::Stats stats;
4747 stats.avg_encode_time_ms = 13;
4748 stats.encode_usage_percent = 42;
4749 stream->SetStats(stats);
4750
4751 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004752 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004753 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4754 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4755}
4756
eladalonf1841382017-06-12 01:16:46 -07004757TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004758 FakeVideoSendStream* stream = AddSendStream();
4759 webrtc::VideoSendStream::Stats stats;
4760 stats.frames_encoded = 13;
4761 stream->SetStats(stats);
4762
4763 cricket::VideoMediaInfo info;
4764 ASSERT_TRUE(channel_->GetStats(&info));
4765 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4766}
4767
eladalonf1841382017-06-12 01:16:46 -07004768TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004769 FakeVideoSendStream* stream = AddSendStream();
4770 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004771 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004772 stream->SetStats(stats);
4773
4774 cricket::VideoMediaInfo info;
4775 ASSERT_TRUE(channel_->GetStats(&info));
4776 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4777}
4778
eladalonf1841382017-06-12 01:16:46 -07004779TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004780 FakeVideoSendStream* stream = AddSendStream();
4781 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004782 stats.substreams[17].width = 123;
4783 stats.substreams[17].height = 40;
4784 stats.substreams[42].width = 80;
4785 stats.substreams[42].height = 31;
4786 stats.substreams[11].width = 20;
4787 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004788 stream->SetStats(stats);
4789
4790 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004791 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004792 ASSERT_EQ(1u, info.senders.size());
4793 EXPECT_EQ(123, info.senders[0].send_frame_width);
4794 EXPECT_EQ(90, info.senders[0].send_frame_height);
4795}
4796
eladalonf1841382017-06-12 01:16:46 -07004797TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004798 FakeVideoSendStream* stream = AddSendStream();
4799 webrtc::VideoSendStream::Stats stats;
4800 stats.number_of_cpu_adapt_changes = 2;
4801 stats.cpu_limited_resolution = true;
4802 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004803
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004804 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004805 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004806 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004807 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004808 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004809}
4810
eladalonf1841382017-06-12 01:16:46 -07004811TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004812 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004813 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004814 stats.number_of_cpu_adapt_changes = 2;
4815 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004816 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004817 stream->SetStats(stats);
4818
4819 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004820 EXPECT_TRUE(channel_->GetStats(&info));
4821 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004822 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4823 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004824 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004825 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004826}
4827
eladalonf1841382017-06-12 01:16:46 -07004828TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004829 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4830 FakeVideoSendStream* stream = AddSendStream();
4831 webrtc::VideoSendStream::Stats stats;
4832 stats.bw_limited_resolution = true;
4833 stream->SetStats(stats);
4834
4835 cricket::VideoMediaInfo info;
4836 EXPECT_TRUE(channel_->GetStats(&info));
4837 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004838 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004839 info.senders[0].adapt_reason);
4840}
4841
Yves Gerey665174f2018-06-19 15:03:05 +02004842TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004843 FakeVideoSendStream* stream = AddSendStream();
4844 webrtc::VideoSendStream::Stats stats;
4845 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4846 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4847 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4848
4849 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4850 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4851 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4852
4853 stream->SetStats(stats);
4854
4855 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004856 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004857 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4858 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4859 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4860}
4861
eladalonf1841382017-06-12 01:16:46 -07004862TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004863 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4864 FakeVideoReceiveStream* stream = AddRecvStream();
4865 webrtc::VideoReceiveStream::Stats stats;
4866 stats.rtcp_packet_type_counts.fir_packets = 2;
4867 stats.rtcp_packet_type_counts.nack_packets = 3;
4868 stats.rtcp_packet_type_counts.pli_packets = 4;
4869 stream->SetStats(stats);
4870
4871 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004872 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004873 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004874 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004875 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004876 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004877 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004878 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004879}
4880
eladalonf1841382017-06-12 01:16:46 -07004881TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004882 FakeVideoReceiveStream* stream = AddRecvStream();
4883 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004884 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004885 stats.decode_ms = 2;
4886 stats.max_decode_ms = 3;
4887 stats.current_delay_ms = 4;
4888 stats.target_delay_ms = 5;
4889 stats.jitter_buffer_ms = 6;
4890 stats.min_playout_delay_ms = 7;
4891 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004892 stats.width = 9;
4893 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004894 stats.frame_counts.key_frames = 11;
4895 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004896 stats.frames_rendered = 13;
4897 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004898 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004899 stream->SetStats(stats);
4900
4901 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004902 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004903 EXPECT_EQ(stats.decoder_implementation_name,
4904 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004905 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4906 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4907 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4908 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4909 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4910 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4911 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004912 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4913 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004914 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4915 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004916 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004917 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004918 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004919 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004920}
4921
eladalonf1841382017-06-12 01:16:46 -07004922TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004923 FakeVideoReceiveStream* stream = AddRecvStream();
4924 webrtc::VideoReceiveStream::Stats stats;
4925 stats.rtp_stats.transmitted.payload_bytes = 2;
4926 stats.rtp_stats.transmitted.header_bytes = 3;
4927 stats.rtp_stats.transmitted.padding_bytes = 4;
4928 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004929 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004930 stats.rtcp_stats.fraction_lost = 7;
4931 stream->SetStats(stats);
4932
4933 cricket::VideoMediaInfo info;
4934 ASSERT_TRUE(channel_->GetStats(&info));
4935 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4936 stats.rtp_stats.transmitted.header_bytes +
4937 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004938 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004939 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004940 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004941 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004942 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004943 info.receivers[0].fraction_lost);
4944}
4945
eladalonf1841382017-06-12 01:16:46 -07004946TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004947 AddSendStream();
4948 AddSendStream();
4949 webrtc::Call::Stats stats;
4950 stats.rtt_ms = 123;
4951 fake_call_->SetStats(stats);
4952
4953 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004954 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004955 ASSERT_EQ(2u, info.senders.size());
4956 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4957 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4958}
4959
eladalonf1841382017-06-12 01:16:46 -07004960TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004961 FakeVideoSendStream* stream = AddSendStream();
4962 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004963 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004964 stats.media_bitrate_bps = 123;
4965 stats.substreams[17].total_bitrate_bps = 1;
4966 stats.substreams[17].retransmit_bitrate_bps = 2;
4967 stats.substreams[42].total_bitrate_bps = 3;
4968 stats.substreams[42].retransmit_bitrate_bps = 4;
4969 stream->SetStats(stats);
4970
4971 FakeVideoSendStream* stream2 = AddSendStream();
4972 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004973 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004974 stats2.media_bitrate_bps = 321;
4975 stats2.substreams[13].total_bitrate_bps = 5;
4976 stats2.substreams[13].retransmit_bitrate_bps = 6;
4977 stats2.substreams[21].total_bitrate_bps = 7;
4978 stats2.substreams[21].retransmit_bitrate_bps = 8;
4979 stream2->SetStats(stats2);
4980
4981 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004982 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004983 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004984 BandwidthEstimationInfo bwe_info;
4985 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004986 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4987 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4988 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4989 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004990 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004991 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004992 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004993 bwe_info.actual_enc_bitrate);
4994 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004995 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004996 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004997 << "Bandwidth stats should take all streams into account.";
4998}
4999
eladalonf1841382017-06-12 01:16:46 -07005000TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005001 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005002
Peter Boström0c4e06b2015-10-07 12:23:21 +02005003 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5004 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005005
5006 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5007 const size_t kDataLength = 12;
5008 uint8_t data[kDataLength];
5009 memset(data, 0, sizeof(data));
5010 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005011 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005012 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005013
5014 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5015 << "No default receive stream created.";
5016 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005017 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005018 << "Default receive stream should not have configured RTX";
5019
5020 EXPECT_TRUE(channel_->AddRecvStream(
5021 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5022 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005023 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005024 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005025 EXPECT_FALSE(
5026 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005027 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005028 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005029 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005030 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005031 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005032 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005033}
5034
eladalonf1841382017-06-12 01:16:46 -07005035TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005036 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005037
Peter Boström0c4e06b2015-10-07 12:23:21 +02005038 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5039 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005040
5041 StreamParams sp =
5042 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5043 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5044
5045 EXPECT_FALSE(channel_->AddSendStream(sp));
5046 EXPECT_FALSE(channel_->AddRecvStream(sp));
5047}
5048
eladalonf1841382017-06-12 01:16:46 -07005049TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005050 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005051
Peter Boström0c4e06b2015-10-07 12:23:21 +02005052 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5053 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005054
5055 StreamParams sp =
5056 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5057
5058 EXPECT_TRUE(channel_->AddSendStream(sp));
5059 EXPECT_TRUE(channel_->AddRecvStream(sp));
5060
5061 // The RTX SSRC is already used in previous streams, using it should fail.
5062 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5063 EXPECT_FALSE(channel_->AddSendStream(sp));
5064 EXPECT_FALSE(channel_->AddRecvStream(sp));
5065
5066 // After removing the original stream this should be fine to add (makes sure
5067 // that RTX ssrcs are not forever taken).
5068 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5069 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5070 EXPECT_TRUE(channel_->AddSendStream(sp));
5071 EXPECT_TRUE(channel_->AddRecvStream(sp));
5072}
5073
eladalonf1841382017-06-12 01:16:46 -07005074TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005075 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005076 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5077 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005078 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005079
Peter Boströmd6f4c252015-03-26 16:23:04 +01005080 StreamParams sp =
5081 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5082
5083 EXPECT_TRUE(channel_->AddSendStream(sp));
5084 EXPECT_TRUE(channel_->AddRecvStream(sp));
5085
5086 // One of the SSRCs is already used in previous streams, using it should fail.
5087 sp = cricket::CreateSimStreamParams("cname",
5088 MAKE_VECTOR(kOverlappingStreamSsrcs));
5089 EXPECT_FALSE(channel_->AddSendStream(sp));
5090 EXPECT_FALSE(channel_->AddRecvStream(sp));
5091
5092 // After removing the original stream this should be fine to add (makes sure
5093 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005094 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5095 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005096 EXPECT_TRUE(channel_->AddSendStream(sp));
5097 EXPECT_TRUE(channel_->AddRecvStream(sp));
5098}
5099
eladalonf1841382017-06-12 01:16:46 -07005100TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005101 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005102
5103 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5104 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5105
5106 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5107 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5108
5109 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5110
5111 static const uint32_t kReceiverSsrcs[] = {3};
5112 static const uint32_t kReceiverRtxSsrcs[] = {2};
5113
5114 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5115 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5116 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5117
5118 cricket::VideoMediaInfo info;
5119 ASSERT_TRUE(channel_->GetStats(&info));
5120
5121 ASSERT_EQ(1u, info.senders.size());
5122 ASSERT_EQ(1u, info.receivers.size());
5123
5124 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5125 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5126 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5127}
5128
eladalonf1841382017-06-12 01:16:46 -07005129TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005130 FakeVideoReceiveStream* stream = AddRecvStream();
5131 webrtc::VideoReceiveStream::Stats stats;
5132 cricket::VideoMediaInfo info;
5133
5134 // Report no codec name before receiving.
5135 stream->SetStats(stats);
5136 ASSERT_TRUE(channel_->GetStats(&info));
5137 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5138
5139 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005140 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005141 stream->SetStats(stats);
5142 ASSERT_TRUE(channel_->GetStats(&info));
5143 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5144
5145 // Report no codec name for unknown playload types.
5146 stats.current_payload_type = 3;
5147 stream->SetStats(stats);
5148 ASSERT_TRUE(channel_->GetStats(&info));
5149 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5150}
5151
Seth Hampson5897a6e2018-04-03 11:16:33 -07005152// Tests that when we add a stream without SSRCs, but contains a stream_id
5153// that it is stored and its stream id is later used when the first packet
5154// arrives to properly create a receive stream with a sync label.
5155TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5156 const char kSyncLabel[] = "sync_label";
5157 cricket::StreamParams unsignaled_stream;
5158 unsignaled_stream.set_stream_ids({kSyncLabel});
5159 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5160 // The stream shouldn't have been created at this point because it doesn't
5161 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005162 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005163
5164 // Create and deliver packet.
5165 const size_t kDataLength = 12;
5166 uint8_t data[kDataLength];
5167 memset(data, 0, sizeof(data));
5168 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5169 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005170 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005171
5172 // The stream should now be created with the appropriate sync label.
5173 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5174 EXPECT_EQ(kSyncLabel,
5175 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5176
5177 // Removing the unsignaled stream should clear the cache. This time when
5178 // a default video receive stream is created it won't have a sync_group.
5179 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5180 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5181 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5182
Niels Möllere6933812018-11-05 13:01:41 +01005183 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005184 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5185 EXPECT_TRUE(
5186 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5187}
5188
eladalonf1841382017-06-12 01:16:46 -07005189void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005190 uint8_t payload_type,
5191 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005192 // kRedRtxPayloadType must currently be unused.
5193 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5194
noahricd10a68e2015-07-10 11:27:55 -07005195 // Add a RED RTX codec.
5196 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005197 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005198 recv_parameters_.codecs.push_back(red_rtx_codec);
5199 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005200
5201 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5202 const size_t kDataLength = 12;
5203 uint8_t data[kDataLength];
5204 memset(data, 0, sizeof(data));
5205
5206 rtc::Set8(data, 1, payload_type);
5207 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005208 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005209 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005210
5211 if (expect_created_receive_stream) {
5212 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5213 << "Should have created a receive stream for payload type: "
5214 << payload_type;
5215 } else {
5216 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5217 << "Shouldn't have created a receive stream for payload type: "
5218 << payload_type;
5219 }
5220}
5221
Åsa Persson2c7149b2018-10-15 09:36:10 +02005222class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5223 public:
5224 WebRtcVideoChannelDiscardUnknownSsrcTest()
5225 : WebRtcVideoChannelTest(
5226 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5227};
5228
5229TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5230 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5231 false /* expect_created_receive_stream */);
5232}
5233
eladalonf1841382017-06-12 01:16:46 -07005234TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005235 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5236 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005237}
5238
eladalonf1841382017-06-12 01:16:46 -07005239TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005240 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5241 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005242}
5243
eladalonf1841382017-06-12 01:16:46 -07005244TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005245 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005246 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5247 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5248 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5249 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005250}
5251
eladalonf1841382017-06-12 01:16:46 -07005252TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005253 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5254 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005255}
5256
eladalonf1841382017-06-12 01:16:46 -07005257TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005258 FlexfecPacketDoesntCreateUnsignalledStream) {
5259 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5260 false /* expect_created_receive_stream */);
5261}
5262
eladalonf1841382017-06-12 01:16:46 -07005263TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005264 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5265 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005266}
5267
mzanaty8a855d62017-02-17 15:46:43 -08005268// Test that receiving any unsignalled SSRC works even if it changes.
5269// The first unsignalled SSRC received will create a default receive stream.
5270// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005271TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005272 // Allow receiving VP8, VP9, H264 (if enabled).
5273 cricket::VideoRecvParameters parameters;
5274 parameters.codecs.push_back(GetEngineCodec("VP8"));
5275 parameters.codecs.push_back(GetEngineCodec("VP9"));
5276
5277#if defined(WEBRTC_USE_H264)
5278 cricket::VideoCodec H264codec(126, "H264");
5279 parameters.codecs.push_back(H264codec);
5280#endif
5281
5282 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5283 // No receive streams yet.
5284 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5285 cricket::FakeVideoRenderer renderer;
5286 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5287
5288 // Receive VP8 packet on first SSRC.
5289 uint8_t data[kMinRtpPacketLen];
5290 cricket::RtpHeader rtpHeader;
5291 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5292 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005293 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005294 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5295 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005296 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005297 // VP8 packet should create default receive stream.
5298 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005299 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005300 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5301 // Verify that the receive stream sinks to a renderer.
5302 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5303 webrtc::kVideoRotation_0);
5304 recv_stream->InjectFrame(video_frame);
5305 EXPECT_EQ(1, renderer.num_rendered_frames());
5306
5307 // Receive VP9 packet on second SSRC.
5308 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005309 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005310 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5311 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005312 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005313 // VP9 packet should replace the default receive SSRC.
5314 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5315 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5316 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5317 // Verify that the receive stream sinks to a renderer.
5318 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005319 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005320 recv_stream->InjectFrame(video_frame2);
5321 EXPECT_EQ(2, renderer.num_rendered_frames());
5322
5323#if defined(WEBRTC_USE_H264)
5324 // Receive H264 packet on third SSRC.
5325 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005326 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005327 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5328 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005329 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005330 // H264 packet should replace the default receive SSRC.
5331 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5332 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5333 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5334 // Verify that the receive stream sinks to a renderer.
5335 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005336 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005337 recv_stream->InjectFrame(video_frame3);
5338 EXPECT_EQ(3, renderer.num_rendered_frames());
5339#endif
5340}
5341
brandtr0dc57ea2017-05-29 23:33:31 -07005342// This test verifies that when a new default stream is created for a new
5343// unsignaled SSRC, the new stream does not overwrite any old stream that had
5344// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005345TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005346 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5347 cricket::VideoRecvParameters parameters;
5348 parameters.codecs.push_back(GetEngineCodec("VP8"));
5349 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5350
5351 // No streams signaled and no packets received, so we should not have any
5352 // stream objects created yet.
5353 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5354
5355 // Receive packet on an unsignaled SSRC.
5356 uint8_t data[kMinRtpPacketLen];
5357 cricket::RtpHeader rtp_header;
5358 rtp_header.payload_type = GetEngineCodec("VP8").id;
5359 rtp_header.seq_num = rtp_header.timestamp = 0;
5360 rtp_header.ssrc = kSsrcs3[0];
5361 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5362 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005363 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005364 // Default receive stream should be created.
5365 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5366 FakeVideoReceiveStream* recv_stream0 =
5367 fake_call_->GetVideoReceiveStreams()[0];
5368 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5369
5370 // Signal the SSRC.
5371 EXPECT_TRUE(
5372 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5373 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5374 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5375 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5376
5377 // Receive packet on a different unsignaled SSRC.
5378 rtp_header.ssrc = kSsrcs3[1];
5379 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5380 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005381 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005382 // New default receive stream should be created, but old stream should remain.
5383 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5384 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5385 FakeVideoReceiveStream* recv_stream1 =
5386 fake_call_->GetVideoReceiveStreams()[1];
5387 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5388}
5389
Seth Hampson7c682e02018-05-04 16:28:15 -07005390TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005391 AddSendStream();
5392
Tommi85959932018-02-07 19:26:06 +01005393 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005394 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005395 cricket::VideoFormat capture_format_hd =
5396 capturer.GetSupportedFormats()->front();
5397 EXPECT_EQ(1280, capture_format_hd.width);
5398 EXPECT_EQ(720, capture_format_hd.height);
5399 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5400 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005401 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005402
perkjfa10b552016-10-02 23:45:26 -07005403 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005404 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005405
5406 // TODO(skvlad): Resolve the inconsistency between the interpretation
5407 // of the global bitrate limit for audio and video:
5408 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5409 // max_bandwidth_bps = -1 - remove the bandwidth limit
5410 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005411 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005412
perkjfa10b552016-10-02 23:45:26 -07005413 SetAndExpectMaxBitrate(1000, 0, 1000);
5414 SetAndExpectMaxBitrate(1000, 800, 800);
5415 SetAndExpectMaxBitrate(600, 800, 600);
5416 SetAndExpectMaxBitrate(0, 800, 800);
5417 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005418
Niels Möllerff40b142018-04-09 08:49:14 +02005419 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005420}
5421
eladalonf1841382017-06-12 01:16:46 -07005422TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005423 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005424 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005425 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005426
5427 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005428 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005429 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005430}
5431
eladalonf1841382017-06-12 01:16:46 -07005432TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005433 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005434 FakeVideoSendStream* stream = AddSendStream();
5435
Seth Hampson7c682e02018-05-04 16:28:15 -07005436 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5437 EXPECT_EQ(1UL, parameters.encodings.size());
5438 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5439 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5440
5441 // Note that this is testing the behavior of the FakeVideoSendStream, which
5442 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5443 // we are just testing the behavior of
5444 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005445 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5446 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005447
5448 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5449 // by this amount.
5450 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5451 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5452 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5453 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5454
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005455 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5456 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5457 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5458}
5459
5460TEST_F(WebRtcVideoChannelTest,
5461 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5462 FakeVideoSendStream* stream = AddSendStream();
5463
5464 // Note that this is testing the behavior of the FakeVideoSendStream, which
5465 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5466 // we are just testing the behavior of
5467 // EncoderStreamFactory::CreateEncoderStreams.
5468 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5469 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5470
5471 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5472 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5473 EXPECT_EQ(1UL, parameters.encodings.size());
5474 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5475 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5476
5477 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5478 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5479 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5480}
5481
5482TEST_F(WebRtcVideoChannelTest,
5483 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5484 send_parameters_.max_bandwidth_bps = 99999;
5485 FakeVideoSendStream* stream = AddSendStream();
5486 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5487 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5488 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5489 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5490 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5491 stream->GetVideoStreams()[0].max_bitrate_bps);
5492
5493 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5494 // adjusted down.
5495 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5496 EXPECT_EQ(1UL, parameters.encodings.size());
5497 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5498 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5499 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5500 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5501 stream->GetVideoStreams()[0].min_bitrate_bps);
5502 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5503 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005504}
5505
Åsa Persson8c1bf952018-09-13 10:42:19 +02005506TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5507 FakeVideoSendStream* stream = AddSendStream();
5508
5509 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5510 EXPECT_EQ(1UL, parameters.encodings.size());
5511 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5512 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5513
5514 // Note that this is testing the behavior of the FakeVideoSendStream, which
5515 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5516 // we are just testing the behavior of
5517 // EncoderStreamFactory::CreateEncoderStreams.
5518 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5519 EXPECT_EQ(kDefaultVideoMaxFramerate,
5520 stream->GetVideoStreams()[0].max_framerate);
5521
5522 // Set max framerate and check that VideoStream.max_framerate is set.
5523 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5524 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5525 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5526 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5527
5528 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5529 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5530}
5531
Åsa Persson23eba222018-10-02 14:47:06 +02005532TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5533 FakeVideoSendStream* stream = AddSendStream();
5534
5535 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5536 EXPECT_EQ(1UL, parameters.encodings.size());
5537 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5538 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5539
5540 // Note that this is testing the behavior of the FakeVideoSendStream, which
5541 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5542 // we are just testing the behavior of
5543 // EncoderStreamFactory::CreateEncoderStreams.
5544 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5545 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5546
5547 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5548 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5549 parameters.encodings[0].num_temporal_layers = 2;
5550 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5551
5552 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5553 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5554}
5555
Seth Hampson7c682e02018-05-04 16:28:15 -07005556TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005557 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005558 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005559 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005560 // Two or more encodings should result in failure.
5561 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005562 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005563 // Zero encodings should also fail.
5564 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005565 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005566}
5567
Zach Stein3ca452b2018-01-18 10:01:24 -08005568TEST_F(WebRtcVideoChannelTest,
5569 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5570 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5571 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5572 AddSendStream(sp);
5573
5574 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5575
5576 // Additional encodings should result in failure.
5577 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005578 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005579 // Zero encodings should also fail.
5580 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005581 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005582}
5583
deadbeeffb2aced2017-01-06 23:05:37 -08005584// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005585TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005586 AddSendStream();
5587 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005588 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005589 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005590}
5591
Seth Hampson24722b32017-12-22 09:36:42 -08005592// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5593// a value <= 0, setting the parameters returns false.
5594TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5595 AddSendStream();
5596 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5597 EXPECT_EQ(1UL, parameters.encodings.size());
5598 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5599 parameters.encodings[0].bitrate_priority);
5600
5601 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005602 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005603 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005604 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005605}
5606
5607// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5608// properly on the VideoChannel and propogates down to the video encoder.
5609TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5610 AddSendStream();
5611 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5612 EXPECT_EQ(1UL, parameters.encodings.size());
5613 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5614 parameters.encodings[0].bitrate_priority);
5615
5616 // Change the value and set it on the VideoChannel.
5617 double new_bitrate_priority = 2.0;
5618 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005619 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005620
5621 // Verify that the encoding parameters bitrate_priority is set for the
5622 // VideoChannel.
5623 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5624 EXPECT_EQ(1UL, parameters.encodings.size());
5625 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5626
5627 // Verify that the new value propagated down to the encoder.
5628 std::vector<FakeVideoSendStream*> video_send_streams =
5629 fake_call_->GetVideoSendStreams();
5630 EXPECT_EQ(1UL, video_send_streams.size());
5631 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5632 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5633 // appropriately.
5634 EXPECT_EQ(new_bitrate_priority,
5635 video_send_stream->GetEncoderConfig().bitrate_priority);
5636 // Check that the vector of VideoStreams also was propagated correctly. Note
5637 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5638 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005639 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005640 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5641}
5642
5643// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5644// VideoChannel and the value propogates to the video encoder with all simulcast
5645// streams.
5646TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5647 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005648 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005649 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5650 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5651 AddSendStream(stream_params);
5652 uint32_t primary_ssrc = stream_params.first_ssrc();
5653
Tommi85959932018-02-07 19:26:06 +01005654 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5655 // frame. This creates multiple VideoStreams for all simulcast layers when
5656 // reconfiguring, and allows us to test this behavior.
5657 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005658 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005659 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005660 EXPECT_EQ(cricket::CS_RUNNING,
5661 capturer.Start(cricket::VideoFormat(
5662 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5663 cricket::FOURCC_I420)));
5664 channel_->SetSend(true);
5665 EXPECT_TRUE(capturer.CaptureFrame());
5666 // Get and set the rtp encoding parameters.
5667 webrtc::RtpParameters parameters =
5668 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005669 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005670 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5671 parameters.encodings[0].bitrate_priority);
5672 // Change the value and set it on the VideoChannel.
5673 double new_bitrate_priority = 2.0;
5674 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005675 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005676
5677 // Verify that the encoding parameters priority is set on the VideoChannel.
5678 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005679 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005680 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5681
5682 // Verify that the new value propagated down to the encoder.
5683 std::vector<FakeVideoSendStream*> video_send_streams =
5684 fake_call_->GetVideoSendStreams();
5685 EXPECT_EQ(1UL, video_send_streams.size());
5686 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5687 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5688 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005689 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005690 video_send_stream->GetEncoderConfig().number_of_streams);
5691 EXPECT_EQ(new_bitrate_priority,
5692 video_send_stream->GetEncoderConfig().bitrate_priority);
5693 // Check that the vector of VideoStreams also propagated correctly. The
5694 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5695 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005696 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005697 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005698 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5699 // Since we are only setting bitrate priority per-sender, the other
5700 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005701 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005702 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005703 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005704 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005705 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005706}
5707
Tim Haloun648d28a2018-10-18 16:52:22 -07005708// RTCRtpEncodingParameters.network_priority must be one of a few values
5709// derived from the default priority, corresponding to very-low, low, medium,
5710// or high.
5711TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5712 AddSendStream();
5713 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5714 EXPECT_EQ(1UL, parameters.encodings.size());
5715 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5716 parameters.encodings[0].network_priority);
5717
5718 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5719 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5720 for (auto it : good_values) {
5721 parameters.encodings[0].network_priority = it;
5722 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5723 }
5724 for (auto it : bad_values) {
5725 parameters.encodings[0].network_priority = it;
5726 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5727 }
5728}
5729
Åsa Persson8c1bf952018-09-13 10:42:19 +02005730TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5731 const size_t kNumSimulcastStreams = 3;
5732 SetUpSimulcast(true, false);
5733
5734 // Get and set the rtp encoding parameters.
5735 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5736 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5737 for (const auto& encoding : parameters.encodings) {
5738 EXPECT_FALSE(encoding.max_framerate);
5739 }
5740
5741 // Change the value and set it on the VideoChannel.
5742 parameters.encodings[0].max_framerate = 10;
5743 parameters.encodings[1].max_framerate = 20;
5744 parameters.encodings[2].max_framerate = 25;
5745 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5746
5747 // Verify that the bitrates are set on the VideoChannel.
5748 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5749 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5750 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5751 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5752 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5753}
5754
Åsa Persson23eba222018-10-02 14:47:06 +02005755TEST_F(WebRtcVideoChannelTest,
5756 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5757 const size_t kNumSimulcastStreams = 3;
5758 SetUpSimulcast(true, false);
5759
5760 // Get and set the rtp encoding parameters.
5761 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5762 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5763
5764 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5765 parameters.encodings[0].num_temporal_layers = 0;
5766 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5767 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5768 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5769 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5770 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5771}
5772
5773TEST_F(WebRtcVideoChannelTest,
5774 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5775 const size_t kNumSimulcastStreams = 3;
5776 SetUpSimulcast(true, false);
5777
5778 // Get and set the rtp encoding parameters.
5779 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5780 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5781
5782 // No/all layers should be set.
5783 parameters.encodings[0].num_temporal_layers = 1;
5784 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5785 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5786
5787 // Different values not supported.
5788 parameters.encodings[0].num_temporal_layers = 1;
5789 parameters.encodings[1].num_temporal_layers = 2;
5790 parameters.encodings[2].num_temporal_layers = 2;
5791 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5792 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5793}
5794
5795TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5796 const size_t kNumSimulcastStreams = 3;
5797 SetUpSimulcast(true, false);
5798
5799 // Get and set the rtp encoding parameters.
5800 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5801 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5802 for (const auto& encoding : parameters.encodings)
5803 EXPECT_FALSE(encoding.num_temporal_layers);
5804
5805 // Change the value and set it on the VideoChannel.
5806 parameters.encodings[0].num_temporal_layers = 3;
5807 parameters.encodings[1].num_temporal_layers = 3;
5808 parameters.encodings[2].num_temporal_layers = 3;
5809 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5810
5811 // Verify that the number of temporal layers are set on the VideoChannel.
5812 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5813 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5814 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5815 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5816 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5817}
5818
5819TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5820 const size_t kNumSimulcastStreams = 3;
5821 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5822
5823 // Send a full size frame so all simulcast layers are used when reconfiguring.
5824 FakeVideoCapturerWithTaskQueue capturer;
5825 VideoOptions options;
5826 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5827 EXPECT_EQ(cricket::CS_RUNNING,
5828 capturer.Start(capturer.GetSupportedFormats()->front()));
5829 channel_->SetSend(true);
5830 EXPECT_TRUE(capturer.CaptureFrame());
5831
5832 // Get and set the rtp encoding parameters.
5833 // Change the value and set it on the VideoChannel.
5834 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5835 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5836 parameters.encodings[0].num_temporal_layers = 2;
5837 parameters.encodings[1].num_temporal_layers = 2;
5838 parameters.encodings[2].num_temporal_layers = 2;
5839 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5840
5841 // Verify that the new value is propagated down to the encoder.
5842 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5843 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5844 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5845 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5846 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5847 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5848 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5849 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5850
5851 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5852 // VideoStreams are created appropriately for the simulcast case.
5853 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5854 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5855 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5856 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5857
5858 // No parameter changed, encoder should not be reconfigured.
5859 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5860 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5861
5862 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5863}
5864
5865TEST_F(WebRtcVideoChannelTest,
5866 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5867 const size_t kDefaultNumTemporalLayers = 3;
5868 const size_t kNumSimulcastStreams = 3;
5869 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5870
5871 // Send a full size frame so all simulcast layers are used when reconfiguring.
5872 FakeVideoCapturerWithTaskQueue capturer;
5873 VideoOptions options;
5874 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5875 EXPECT_EQ(cricket::CS_RUNNING,
5876 capturer.Start(capturer.GetSupportedFormats()->front()));
5877 channel_->SetSend(true);
5878 EXPECT_TRUE(capturer.CaptureFrame());
5879
5880 // Change rtp encoding parameters, num_temporal_layers not changed.
5881 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5882 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5883 parameters.encodings[0].min_bitrate_bps = 33000;
5884 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5885
5886 // Verify that no value is propagated down to the encoder.
5887 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5888 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5889 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5890 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5891 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5892 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5893
5894 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5895 // VideoStreams are created appropriately for the simulcast case.
5896 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5897 EXPECT_EQ(kDefaultNumTemporalLayers,
5898 stream->GetVideoStreams()[0].num_temporal_layers);
5899 EXPECT_EQ(kDefaultNumTemporalLayers,
5900 stream->GetVideoStreams()[1].num_temporal_layers);
5901 EXPECT_EQ(kDefaultNumTemporalLayers,
5902 stream->GetVideoStreams()[2].num_temporal_layers);
5903
5904 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5905}
5906
Åsa Persson8c1bf952018-09-13 10:42:19 +02005907TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5908 const size_t kNumSimulcastStreams = 3;
5909 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5910
5911 // Send a full size frame so all simulcast layers are used when reconfiguring.
5912 FakeVideoCapturerWithTaskQueue capturer;
5913 VideoOptions options;
5914 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5915 EXPECT_EQ(cricket::CS_RUNNING,
5916 capturer.Start(capturer.GetSupportedFormats()->front()));
5917 channel_->SetSend(true);
5918 EXPECT_TRUE(capturer.CaptureFrame());
5919
5920 // Get and set the rtp encoding parameters.
5921 // Change the value and set it on the VideoChannel.
5922 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5923 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5924 parameters.encodings[0].max_framerate = 15;
5925 parameters.encodings[1].max_framerate = 25;
5926 parameters.encodings[2].max_framerate = 20;
5927 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5928
5929 // Verify that the new value propagated down to the encoder.
5930 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5931 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5932 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5933 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5934 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5935 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5936 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5937 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5938
5939 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5940 // VideoStreams are created appropriately for the simulcast case.
5941 // Currently the maximum |max_framerate| is used.
5942 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5943 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5944 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5945 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5946
5947 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5948}
5949
5950TEST_F(WebRtcVideoChannelTest,
5951 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5952 const size_t kNumSimulcastStreams = 3;
5953 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5954 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5955
5956 // Send a full size frame so all simulcast layers are used when reconfiguring.
5957 FakeVideoCapturerWithTaskQueue capturer;
5958 VideoOptions options;
5959 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5960 EXPECT_EQ(cricket::CS_RUNNING,
5961 capturer.Start(capturer.GetSupportedFormats()->front()));
5962 channel_->SetSend(true);
5963 EXPECT_TRUE(capturer.CaptureFrame());
5964
5965 // Get and set the rtp encoding parameters.
5966 // Change the value and set it on the VideoChannel.
5967 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5968 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5969 parameters.encodings[0].max_framerate = 15;
5970 parameters.encodings[2].max_framerate = 20;
5971 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5972
5973 // Verify that the new value propagated down to the encoder.
5974 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5975 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5976 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5977 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5978 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5979 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5980 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5981
5982 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5983 // VideoStreams are created appropriately for the simulcast case.
5984 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5985 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5986 EXPECT_EQ(kDefaultVideoMaxFramerate,
5987 stream->GetVideoStreams()[0].max_framerate);
5988 EXPECT_EQ(kDefaultVideoMaxFramerate,
5989 stream->GetVideoStreams()[1].max_framerate);
5990 EXPECT_EQ(kDefaultVideoMaxFramerate,
5991 stream->GetVideoStreams()[2].max_framerate);
5992
5993 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5994}
5995
Åsa Persson55659812018-06-18 17:51:32 +02005996TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
5997 const size_t kNumSimulcastStreams = 3;
5998 SetUpSimulcast(true, false);
5999
6000 // Get and set the rtp encoding parameters.
6001 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6002 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6003 for (const auto& encoding : parameters.encodings) {
6004 EXPECT_FALSE(encoding.min_bitrate_bps);
6005 EXPECT_FALSE(encoding.max_bitrate_bps);
6006 }
6007
6008 // Change the value and set it on the VideoChannel.
6009 parameters.encodings[0].min_bitrate_bps = 100000;
6010 parameters.encodings[0].max_bitrate_bps = 200000;
6011 parameters.encodings[1].min_bitrate_bps = 300000;
6012 parameters.encodings[1].max_bitrate_bps = 400000;
6013 parameters.encodings[2].min_bitrate_bps = 500000;
6014 parameters.encodings[2].max_bitrate_bps = 600000;
6015 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6016
6017 // Verify that the bitrates are set on the VideoChannel.
6018 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6019 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6020 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6021 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6022 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6023 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6024 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6025 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6026}
6027
6028TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6029 const size_t kNumSimulcastStreams = 3;
6030 SetUpSimulcast(true, false);
6031
6032 // Get and set the rtp encoding parameters.
6033 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6034 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6035
6036 // Max bitrate lower than min bitrate should fail.
6037 parameters.encodings[2].min_bitrate_bps = 100000;
6038 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6039 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6040 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6041}
6042
6043// Test that min and max bitrate values set via RtpParameters are correctly
6044// propagated to the underlying encoder, and that the target is set to 3/4 of
6045// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6046// that are used if no min/max are specified).
6047TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6048 const size_t kNumSimulcastStreams = 3;
6049 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6050
6051 // Send a full size frame so all simulcast layers are used when reconfiguring.
6052 FakeVideoCapturerWithTaskQueue capturer;
6053 VideoOptions options;
6054 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6055 EXPECT_EQ(cricket::CS_RUNNING,
6056 capturer.Start(capturer.GetSupportedFormats()->front()));
6057 channel_->SetSend(true);
6058 EXPECT_TRUE(capturer.CaptureFrame());
6059
6060 // Get and set the rtp encoding parameters.
6061 // Change the value and set it on the VideoChannel.
6062 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6063 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6064 parameters.encodings[0].min_bitrate_bps = 100000;
6065 parameters.encodings[0].max_bitrate_bps = 200000;
6066 parameters.encodings[1].min_bitrate_bps = 300000;
6067 parameters.encodings[1].max_bitrate_bps = 400000;
6068 parameters.encodings[2].min_bitrate_bps = 500000;
6069 parameters.encodings[2].max_bitrate_bps = 600000;
6070 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6071
6072 // Verify that the new value propagated down to the encoder.
6073 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6074 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6075 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6076 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6077 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6078 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6079 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6080 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6081 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6082 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6083 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6084
6085 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6086 // VideoStreams are created appropriately for the simulcast case.
6087 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6088 // Target bitrate: 200000 * 3 / 4 = 150000.
6089 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6090 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6091 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6092 // Target bitrate: 400000 * 3 / 4 = 300000.
6093 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6094 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6095 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6096 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6097 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6098 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6099 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6100
6101 // No parameter changed, encoder should not be reconfigured.
6102 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6103 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6104
6105 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6106}
6107
6108// Test to only specify the min or max bitrate value for a layer via
6109// RtpParameters. The unspecified min/max and target value should be set to the
6110// simulcast default that is used if no min/max are specified.
6111TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6112 const size_t kNumSimulcastStreams = 3;
6113 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6114 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6115
6116 // Send a full size frame so all simulcast layers are used when reconfiguring.
6117 FakeVideoCapturerWithTaskQueue capturer;
6118 VideoOptions options;
6119 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6120 EXPECT_EQ(cricket::CS_RUNNING,
6121 capturer.Start(capturer.GetSupportedFormats()->front()));
6122 channel_->SetSend(true);
6123 EXPECT_TRUE(capturer.CaptureFrame());
6124
6125 // Get and set the rtp encoding parameters.
6126 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6127 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6128
6129 // Change the value and set it on the VideoChannel.
6130 // Layer 0: only configure min bitrate.
6131 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6132 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6133 // Layer 1: only configure max bitrate.
6134 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6135 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6136 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6137
6138 // Verify that the new value propagated down to the encoder.
6139 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6140 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6141 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6142 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6143 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6144 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6145 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6146 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6147 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6148 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6149
6150 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6151 // VideoStreams are created appropriately for the simulcast case.
6152 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6153 // Layer 0: min configured bitrate should overwrite min default.
6154 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6155 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6156 stream->GetVideoStreams()[0].target_bitrate_bps);
6157 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6158 stream->GetVideoStreams()[0].max_bitrate_bps);
6159 // Layer 1: max configured bitrate should overwrite max default.
6160 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6161 stream->GetVideoStreams()[1].min_bitrate_bps);
6162 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6163 stream->GetVideoStreams()[1].target_bitrate_bps);
6164 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6165 // Layer 2: min and max bitrate not configured, default expected.
6166 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6167 stream->GetVideoStreams()[2].min_bitrate_bps);
6168 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6169 stream->GetVideoStreams()[2].target_bitrate_bps);
6170 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6171 stream->GetVideoStreams()[2].max_bitrate_bps);
6172
6173 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6174}
6175
6176// Test that specifying the min (or max) bitrate value for a layer via
6177// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6178// unspecified values accordingly.
6179TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6180 const size_t kNumSimulcastStreams = 3;
6181 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6182 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6183
6184 // Send a full size frame so all simulcast layers are used when reconfiguring.
6185 FakeVideoCapturerWithTaskQueue capturer;
6186 VideoOptions options;
6187 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6188 EXPECT_EQ(cricket::CS_RUNNING,
6189 capturer.Start(capturer.GetSupportedFormats()->front()));
6190 channel_->SetSend(true);
6191 EXPECT_TRUE(capturer.CaptureFrame());
6192
6193 // Get and set the rtp encoding parameters.
6194 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6195 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6196
6197 // Change the value and set it on the VideoChannel.
6198 // For layer 0, set the min bitrate above the default max.
6199 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6200 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6201 // For layer 1, set the max bitrate below the default min.
6202 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6203 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6204 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6205
6206 // Verify that the new value propagated down to the encoder.
6207 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6208 // VideoStreams are created appropriately for the simulcast case.
6209 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6210 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6211 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6212 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6213 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6214 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6215 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6216 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6217 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6218 // Layer 2: min and max bitrate not configured, default expected.
6219 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6220 stream->GetVideoStreams()[2].min_bitrate_bps);
6221 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6222 stream->GetVideoStreams()[2].target_bitrate_bps);
6223 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6224 stream->GetVideoStreams()[2].max_bitrate_bps);
6225
6226 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6227}
6228
6229TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6230 const size_t kNumSimulcastStreams = 3;
6231 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6232 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6233
6234 // Send a full size frame so all simulcast layers are used when reconfiguring.
6235 FakeVideoCapturerWithTaskQueue capturer;
6236 VideoOptions options;
6237 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6238 EXPECT_EQ(cricket::CS_RUNNING,
6239 capturer.Start(capturer.GetSupportedFormats()->front()));
6240 channel_->SetSend(true);
6241 EXPECT_TRUE(capturer.CaptureFrame());
6242
6243 // Set max bitrate for all but the highest layer.
6244 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6245 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6246 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6247 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6248 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6249
6250 // Set max bandwidth equal to total max bitrate.
6251 send_parameters_.max_bandwidth_bps =
6252 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6253 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6254 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6255
6256 // No bitrate above the total max to give to the highest layer.
6257 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6258 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6259 stream->GetVideoStreams()[2].max_bitrate_bps);
6260
6261 // Set max bandwidth above the total max bitrate.
6262 send_parameters_.max_bandwidth_bps =
6263 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6264 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6265 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6266
6267 // The highest layer has no max bitrate set -> the bitrate above the total
6268 // max should be given to the highest layer.
6269 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6270 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6271 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6272 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6273 stream->GetVideoStreams()[2].max_bitrate_bps);
6274
6275 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6276}
6277
6278TEST_F(WebRtcVideoChannelTest,
6279 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6280 const size_t kNumSimulcastStreams = 3;
6281 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6282 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6283 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6284
6285 // Send a full size frame so all simulcast layers are used when reconfiguring.
6286 FakeVideoCapturerWithTaskQueue capturer;
6287 VideoOptions options;
6288 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6289 EXPECT_EQ(cricket::CS_RUNNING,
6290 capturer.Start(capturer.GetSupportedFormats()->front()));
6291 channel_->SetSend(true);
6292 EXPECT_TRUE(capturer.CaptureFrame());
6293
6294 // Set max bitrate for the highest layer.
6295 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6296 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6297 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6298 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6299
6300 // Set max bandwidth above the total max bitrate.
6301 send_parameters_.max_bandwidth_bps =
6302 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6303 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6304 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6305
6306 // The highest layer has the max bitrate set -> the bitrate above the total
6307 // max should not be given to the highest layer.
6308 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6309 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6310 stream->GetVideoStreams()[2].max_bitrate_bps);
6311
6312 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6313}
6314
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006315// Test that min and max bitrate values set via RtpParameters are correctly
6316// propagated to the underlying encoder for a single stream.
6317TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6318 FakeVideoSendStream* stream = AddSendStream();
6319 EXPECT_TRUE(channel_->SetSend(true));
6320 EXPECT_TRUE(stream->IsSending());
6321
6322 // Set min and max bitrate.
6323 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6324 EXPECT_EQ(1u, parameters.encodings.size());
6325 parameters.encodings[0].min_bitrate_bps = 80000;
6326 parameters.encodings[0].max_bitrate_bps = 150000;
6327 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6328
6329 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6330 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6331 EXPECT_EQ(1u, encoder_config.number_of_streams);
6332 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6333 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6334 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6335
6336 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6337 // VideoStreams are created appropriately.
6338 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6339 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6340 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6341 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6342}
6343
6344// Test the default min and max bitrate value are correctly propagated to the
6345// underlying encoder for a single stream (when the values are not set via
6346// RtpParameters).
6347TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6348 FakeVideoSendStream* stream = AddSendStream();
6349 EXPECT_TRUE(channel_->SetSend(true));
6350 EXPECT_TRUE(stream->IsSending());
6351
6352 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6353 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6354 EXPECT_EQ(1u, encoder_config.number_of_streams);
6355 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6356 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6357 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6358
6359 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6360 // VideoStreams are created appropriately.
6361 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6362 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6363 stream->GetVideoStreams()[0].min_bitrate_bps);
6364 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6365 stream->GetVideoStreams()[0].min_bitrate_bps);
6366 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6367 stream->GetVideoStreams()[0].target_bitrate_bps);
6368}
6369
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006370// Test that a stream will not be sending if its encoding is made inactive
6371// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006372TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006373 FakeVideoSendStream* stream = AddSendStream();
6374 EXPECT_TRUE(channel_->SetSend(true));
6375 EXPECT_TRUE(stream->IsSending());
6376
6377 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006378 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006379 ASSERT_EQ(1u, parameters.encodings.size());
6380 ASSERT_TRUE(parameters.encodings[0].active);
6381 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006382 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006383 EXPECT_FALSE(stream->IsSending());
6384
6385 // Now change it back to active and verify we resume sending.
6386 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006387 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006388 EXPECT_TRUE(stream->IsSending());
6389}
6390
Seth Hampson8234ead2018-02-02 15:16:24 -08006391// Tests that when active is updated for any simulcast layer then the send
6392// stream's sending state will be updated and it will be reconfigured with the
6393// new appropriate active simulcast streams.
6394TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6395 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006396 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006397 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6398 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6399 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6400 uint32_t primary_ssrc = stream_params.first_ssrc();
6401
Tommi85959932018-02-07 19:26:06 +01006402 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6403 // frame. This allows us to test that ReconfigureEncoder is called
6404 // appropriately.
6405 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006406 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006407 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006408 EXPECT_EQ(cricket::CS_RUNNING,
6409 capturer.Start(cricket::VideoFormat(
6410 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6411 cricket::FOURCC_I420)));
6412 channel_->SetSend(true);
6413 EXPECT_TRUE(capturer.CaptureFrame());
6414
6415 // Check that all encodings are initially active.
6416 webrtc::RtpParameters parameters =
6417 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006418 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006419 EXPECT_TRUE(parameters.encodings[0].active);
6420 EXPECT_TRUE(parameters.encodings[1].active);
6421 EXPECT_TRUE(parameters.encodings[2].active);
6422 EXPECT_TRUE(fake_video_send_stream->IsSending());
6423
6424 // Only turn on only the middle stream.
6425 parameters.encodings[0].active = false;
6426 parameters.encodings[1].active = true;
6427 parameters.encodings[2].active = false;
6428 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6429 // Verify that the active fields are set on the VideoChannel.
6430 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006431 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006432 EXPECT_FALSE(parameters.encodings[0].active);
6433 EXPECT_TRUE(parameters.encodings[1].active);
6434 EXPECT_FALSE(parameters.encodings[2].active);
6435 // Check that the VideoSendStream is updated appropriately. This means its
6436 // send state was updated and it was reconfigured.
6437 EXPECT_TRUE(fake_video_send_stream->IsSending());
6438 std::vector<webrtc::VideoStream> simulcast_streams =
6439 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006440 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006441 EXPECT_FALSE(simulcast_streams[0].active);
6442 EXPECT_TRUE(simulcast_streams[1].active);
6443 EXPECT_FALSE(simulcast_streams[2].active);
6444
6445 // Turn off all streams.
6446 parameters.encodings[0].active = false;
6447 parameters.encodings[1].active = false;
6448 parameters.encodings[2].active = false;
6449 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6450 // Verify that the active fields are set on the VideoChannel.
6451 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006452 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006453 EXPECT_FALSE(parameters.encodings[0].active);
6454 EXPECT_FALSE(parameters.encodings[1].active);
6455 EXPECT_FALSE(parameters.encodings[2].active);
6456 // Check that the VideoSendStream is off.
6457 EXPECT_FALSE(fake_video_send_stream->IsSending());
6458 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006459 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006460 EXPECT_FALSE(simulcast_streams[0].active);
6461 EXPECT_FALSE(simulcast_streams[1].active);
6462 EXPECT_FALSE(simulcast_streams[2].active);
6463
Niels Möllerff40b142018-04-09 08:49:14 +02006464 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006465}
6466
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006467// Test that if a stream is reconfigured (due to a codec change or other
6468// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006469TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006470 InactiveStreamDoesntStartSendingWhenReconfigured) {
6471 // Set an initial codec list, which will be modified later.
6472 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006473 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6474 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006475 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6476
6477 FakeVideoSendStream* stream = AddSendStream();
6478 EXPECT_TRUE(channel_->SetSend(true));
6479 EXPECT_TRUE(stream->IsSending());
6480
6481 // Get current parameters and change "active" to false.
6482 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6483 ASSERT_EQ(1u, parameters.encodings.size());
6484 ASSERT_TRUE(parameters.encodings[0].active);
6485 parameters.encodings[0].active = false;
6486 EXPECT_EQ(1u, GetFakeSendStreams().size());
6487 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006488 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006489 EXPECT_FALSE(stream->IsSending());
6490
6491 // Reorder the codec list, causing the stream to be reconfigured.
6492 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006493 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6494 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006495 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6496 auto new_streams = GetFakeSendStreams();
6497 // Assert that a new underlying stream was created due to the codec change.
6498 // Otherwise, this test isn't testing what it set out to test.
6499 EXPECT_EQ(1u, GetFakeSendStreams().size());
6500 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6501
6502 // Verify that we still are not sending anything, due to the inactive
6503 // encoding.
6504 EXPECT_FALSE(new_streams[0]->IsSending());
6505}
6506
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006507// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006508TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006509 AddSendStream();
6510 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006511 parameters.codecs.push_back(GetEngineCodec("VP8"));
6512 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006513 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6514
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006515 webrtc::RtpParameters rtp_parameters =
6516 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006517 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006518 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6519 rtp_parameters.codecs[0]);
6520 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6521 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006522}
6523
Florent Castellidacec712018-05-24 16:24:21 +02006524// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6525TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6526 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6527 params.cname = "rtcpcname";
6528 AddSendStream(params);
6529
6530 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6531 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6532}
6533
deadbeeffb2aced2017-01-06 23:05:37 -08006534// Test that RtpParameters for send stream has one encoding and it has
6535// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006536TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006537 AddSendStream();
6538
6539 webrtc::RtpParameters rtp_parameters =
6540 channel_->GetRtpSendParameters(last_ssrc_);
6541 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006542 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006543}
6544
Florent Castelliabe301f2018-06-12 18:33:49 +02006545TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6546 AddSendStream();
6547
6548 webrtc::RtpParameters rtp_parameters =
6549 channel_->GetRtpSendParameters(last_ssrc_);
6550 rtp_parameters.header_extensions.emplace_back();
6551
6552 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6553
6554 webrtc::RTCError result =
6555 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6556 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6557}
6558
Florent Castelli87b3c512018-07-18 16:00:28 +02006559TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6560 AddSendStream();
6561
6562 FakeVideoCapturerWithTaskQueue capturer;
6563 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6564
6565 webrtc::RtpParameters rtp_parameters =
6566 channel_->GetRtpSendParameters(last_ssrc_);
6567 EXPECT_EQ(rtp_parameters.degradation_preference,
6568 webrtc::DegradationPreference::BALANCED);
6569 rtp_parameters.degradation_preference =
6570 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6571
6572 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6573
6574 webrtc::RtpParameters updated_rtp_parameters =
6575 channel_->GetRtpSendParameters(last_ssrc_);
6576 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6577 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6578
6579 // Remove the source since it will be destroyed before the channel
6580 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6581}
6582
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006583// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006584TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006585 AddSendStream();
6586 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006587 parameters.codecs.push_back(GetEngineCodec("VP8"));
6588 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006589 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6590
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006591 webrtc::RtpParameters initial_params =
6592 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006593
6594 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006595 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006596
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006597 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6598 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6599}
6600
6601// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006602TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006603 AddRecvStream();
6604 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006605 parameters.codecs.push_back(GetEngineCodec("VP8"));
6606 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006607 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6608
6609 webrtc::RtpParameters rtp_parameters =
6610 channel_->GetRtpReceiveParameters(last_ssrc_);
6611 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006612 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6613 rtp_parameters.codecs[0]);
6614 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6615 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006616}
6617
johan073ece42016-08-26 02:59:47 -07006618#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006619TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006620#else
eladalonf1841382017-06-12 01:16:46 -07006621TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006622#endif
johan3859c892016-08-05 09:19:25 -07006623 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006624 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006625 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006626 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006627 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006628 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006629 parameters.codecs.push_back(kH264sprop2);
6630 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6631
6632 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6633 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6634 webrtc::RtpParameters rtp_parameters =
6635 channel_->GetRtpReceiveParameters(last_ssrc_);
6636 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6637 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6638 ASSERT_EQ(2u, cfg.decoders.size());
6639 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006640 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006641 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006642 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6643 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006644 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006645
6646 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006647 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006648 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006649 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6650 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006651 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006652}
6653
sakal1fd95952016-06-22 00:46:15 -07006654// Test that RtpParameters for receive stream has one encoding and it has
6655// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006656TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006657 AddRecvStream();
6658
6659 webrtc::RtpParameters rtp_parameters =
6660 channel_->GetRtpReceiveParameters(last_ssrc_);
6661 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006662 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006663}
6664
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006665// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006666TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006667 AddRecvStream();
6668 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006669 parameters.codecs.push_back(GetEngineCodec("VP8"));
6670 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006671 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6672
6673 webrtc::RtpParameters initial_params =
6674 channel_->GetRtpReceiveParameters(last_ssrc_);
6675
6676 // We should be able to set the params we just got.
6677 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6678
6679 // ... And this shouldn't change the params returned by
6680 // GetRtpReceiveParameters.
6681 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006682}
6683
deadbeef3bc15102017-04-20 19:25:07 -07006684// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6685// aren't signaled. It should always return an empty "RtpEncodingParameters",
6686// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006687TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006688 // Call necessary methods to configure receiving a default stream as
6689 // soon as it arrives.
6690 cricket::VideoRecvParameters parameters;
6691 parameters.codecs.push_back(GetEngineCodec("VP8"));
6692 parameters.codecs.push_back(GetEngineCodec("VP9"));
6693 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6694
6695 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6696 // stream. Should return nothing.
6697 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6698
6699 // Set a sink for an unsignaled stream.
6700 cricket::FakeVideoRenderer renderer;
6701 // Value of "0" means "unsignaled stream".
6702 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6703
6704 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6705 // in this method means "unsignaled stream".
6706 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6707 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6708 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6709
6710 // Receive VP8 packet.
6711 uint8_t data[kMinRtpPacketLen];
6712 cricket::RtpHeader rtpHeader;
6713 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6714 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6715 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6716 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6717 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006718 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006719
6720 // The |ssrc| member should still be unset.
6721 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6722 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6723 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6724}
6725
eladalonf1841382017-06-12 01:16:46 -07006726void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006727 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006728 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006729
6730 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006731 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006732 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006733 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006734
6735 if (receiver_first) {
6736 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6737 std::vector<FakeVideoReceiveStream*> receive_streams =
6738 fake_call_->GetVideoReceiveStreams();
6739 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006740 // Default local SSRC when we have no sender.
6741 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6742 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006743 }
6744 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6745 if (!receiver_first)
6746 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6747 std::vector<FakeVideoReceiveStream*> receive_streams =
6748 fake_call_->GetVideoReceiveStreams();
6749 ASSERT_EQ(1u, receive_streams.size());
6750 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006751
6752 // Removing first sender should fall back to another (in this case the second)
6753 // local send stream's SSRC.
6754 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6755 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006756 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006757 ASSERT_EQ(1u, receive_streams.size());
6758 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6759
6760 // Removing the last sender should fall back to default local SSRC.
6761 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006762 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006763 ASSERT_EQ(1u, receive_streams.size());
6764 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6765 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006766}
6767
eladalonf1841382017-06-12 01:16:46 -07006768TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006769 TestReceiverLocalSsrcConfiguration(false);
6770}
6771
eladalonf1841382017-06-12 01:16:46 -07006772TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006773 TestReceiverLocalSsrcConfiguration(true);
6774}
6775
eladalonf1841382017-06-12 01:16:46 -07006776class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006777 public:
eladalonf1841382017-06-12 01:16:46 -07006778 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006779 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006780 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6781 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006782 mock_rate_allocator_factory_(
6783 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006784 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006785 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006786 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006787 decoder_factory_),
6788 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6789 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006790 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006791
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006792 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006793 encoder_factory_->AddSupportedVideoCodecType("VP8");
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07006794 channel_.reset(engine_.CreateChannel(&fake_call_, GetMediaConfig(),
6795 VideoOptions(),
6796 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006797 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006798 last_ssrc_ = 123;
6799 }
6800
6801 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006802 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006803 int capture_width,
6804 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006805 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006806 size_t expected_num_streams,
6807 bool screenshare,
6808 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006809 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006810 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006811 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006812 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006813
Peter Boström0c4e06b2015-10-07 12:23:21 +02006814 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006815 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006816 ssrcs.resize(num_configured_streams);
6817
sprangf24a0642017-02-28 13:23:26 -08006818 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006819 // Send a full-size frame to trigger a stream reconfiguration to use all
6820 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006821 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006822 VideoOptions options;
6823 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006824 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006825 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006826 // Fetch the latest stream since SetVideoSend() may recreate it if the
6827 // screen content setting is changed.
6828 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006829 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006830 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006831 cricket::VideoFormat::FpsToInterval(30),
6832 cricket::FOURCC_I420)));
6833 channel_->SetSend(true);
6834 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006835
Zach Stein3ca452b2018-01-18 10:01:24 -08006836 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6837 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6838
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006839 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6840 ASSERT_EQ(expected_num_streams, video_streams.size());
6841
sprang429600d2017-01-26 06:12:26 -08006842 std::vector<webrtc::VideoStream> expected_streams;
6843 if (conference_mode) {
6844 expected_streams = GetSimulcastConfig(
6845 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006846 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006847 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006848 if (screenshare) {
6849 for (const webrtc::VideoStream& stream : expected_streams) {
6850 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006851 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6852 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006853 }
6854 }
sprang429600d2017-01-26 06:12:26 -08006855 } else {
6856 webrtc::VideoStream stream;
6857 stream.width = capture_width;
6858 stream.height = capture_height;
6859 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006860 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006861 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006862 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006863 stream.max_qp = kDefaultQpMax;
6864 expected_streams.push_back(stream);
6865 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006866
6867 ASSERT_EQ(expected_streams.size(), video_streams.size());
6868
6869 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006870 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006871 for (size_t i = 0; i < num_streams; ++i) {
6872 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6873 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6874
6875 EXPECT_GT(video_streams[i].max_framerate, 0);
6876 EXPECT_EQ(expected_streams[i].max_framerate,
6877 video_streams[i].max_framerate);
6878
6879 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6880 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6881 video_streams[i].min_bitrate_bps);
6882
6883 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6884 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6885 video_streams[i].target_bitrate_bps);
6886
6887 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6888 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6889 video_streams[i].max_bitrate_bps);
6890
6891 EXPECT_GT(video_streams[i].max_qp, 0);
6892 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6893
Sergey Silkina796a7e2018-03-01 15:11:29 +01006894 EXPECT_EQ(conference_mode,
6895 expected_streams[i].num_temporal_layers.has_value());
6896
6897 if (conference_mode) {
6898 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6899 video_streams[i].num_temporal_layers);
6900 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006901
6902 if (i == num_streams - 1) {
6903 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6904 } else {
6905 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6906 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006907 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006908
Niels Möllerff40b142018-04-09 08:49:14 +02006909 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006910 }
6911
6912 FakeVideoSendStream* AddSendStream() {
6913 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6914 }
6915
6916 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006917 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006918 EXPECT_TRUE(channel_->AddSendStream(sp));
6919 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006920 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006921 EXPECT_EQ(num_streams + 1, streams.size());
6922 return streams[streams.size() - 1];
6923 }
6924
6925 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006926 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006927 }
6928
6929 FakeVideoReceiveStream* AddRecvStream() {
6930 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6931 }
6932
6933 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006934 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006935 EXPECT_TRUE(channel_->AddRecvStream(sp));
6936 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006937 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006938 EXPECT_EQ(num_streams + 1, streams.size());
6939 return streams[streams.size() - 1];
6940 }
6941
skvlad11a9cbf2016-10-07 11:53:05 -07006942 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006943 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006944 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6945 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006946 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07006947 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006948 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006949 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006950};
6951
eladalonf1841382017-06-12 01:16:46 -07006952TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006953 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6954 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006955}
6956
eladalonf1841382017-06-12 01:16:46 -07006957TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006958 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6959 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006960}
6961
6962// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006963TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006964 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6965 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006966}
sprang429600d2017-01-26 06:12:26 -08006967
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006968TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006969 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6970 false);
6971}
6972
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006973TEST_F(WebRtcVideoChannelSimulcastTest,
6974 SetSendCodecsForConferenceModeScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006975 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6976 true);
6977}
6978
eladalonf1841382017-06-12 01:16:46 -07006979TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
Erik Språngb65aa012018-09-24 11:35:19 +02006980 webrtc::test::ScopedFieldTrials override_field_trials_(
6981 "WebRTC-SimulcastScreenshare/Enabled/");
sprang429600d2017-01-26 06:12:26 -08006982 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6983 true);
6984}
6985
eladalonf1841382017-06-12 01:16:46 -07006986TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006987 NoSimulcastScreenshareWithoutConference) {
Erik Språngb65aa012018-09-24 11:35:19 +02006988 webrtc::test::ScopedFieldTrials override_field_trials_(
6989 "WebRTC-SimulcastScreenshare/Enabled/");
sprangfe627f32017-03-29 08:24:59 -07006990 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6991 false);
6992}
6993
Yves Gereyb6a89422018-10-08 10:08:32 +02006994class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006995 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006996 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006997 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
6998 }
6999 rtc::ScopedFakeClock fake_clock_;
7000};
7001
Yves Gereyb6a89422018-10-08 10:08:32 +02007002// The fake clock needs to be initialized before the call, and not
7003// destroyed until after all threads spawned by the test have been stopped.
7004// This mixin ensures that.
7005class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7006 public WebRtcVideoChannelBaseTest {};
7007
Jonas Oreland49ac5952018-09-26 16:04:32 +02007008TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7009 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7010 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7011
7012 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7013
7014 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7015 rtc::SetBE32(packet1.data() + 8, kSsrc);
7016 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7017 EXPECT_TRUE(SetDefaultCodec());
7018 EXPECT_TRUE(SetSend(true));
7019 EXPECT_EQ(0, renderer_.num_rendered_frames());
7020 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7021
7022 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7023 EXPECT_EQ(1u, sources.size());
7024 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7025 int64_t timestamp1 = sources[0].timestamp_ms();
7026
7027 // a new packet.
7028 int64_t timeDeltaMs = 1;
7029 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7030 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7031 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7032 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7033
7034 // It only keeps 10s of history.
7035 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7036 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7037 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7038}
7039
7040TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7041 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7042 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7043
7044 uint32_t kCsrc = 4321u;
7045 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7046 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7047
7048 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7049 rtc::SetBE32(packet1.data() + 8, kSsrc);
7050 rtc::SetBE32(packet1.data() + 12, kCsrc);
7051 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7052 EXPECT_TRUE(SetDefaultCodec());
7053 EXPECT_TRUE(SetSend(true));
7054 EXPECT_EQ(0, renderer_.num_rendered_frames());
7055 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7056
7057 {
7058 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7059 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7060 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7061 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7062 // 1 SSRC and 1 CSRC.
7063 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7064 [](const webrtc::RtpSource& source) {
7065 return source.source_type() ==
7066 webrtc::RtpSourceType::SSRC;
7067 }));
7068 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7069 [](const webrtc::RtpSource& source) {
7070 return source.source_type() ==
7071 webrtc::RtpSourceType::CSRC;
7072 }));
7073 }
7074 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7075
7076 // a new packet with only ssrc (i.e no csrc).
7077 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7078 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7079 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7080 rtc::SetBE32(packet2.data() + 8, kSsrc);
7081
7082 int64_t timeDeltaMs = 1;
7083 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7084 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7085
7086 {
7087 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7088 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7089 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7090 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7091 // 1 SSRC and 1 CSRC.
7092 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7093 [](const webrtc::RtpSource& source) {
7094 return source.source_type() ==
7095 webrtc::RtpSourceType::SSRC;
7096 }));
7097 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7098 [](const webrtc::RtpSource& source) {
7099 return source.source_type() ==
7100 webrtc::RtpSourceType::CSRC;
7101 }));
7102 auto ssrcSource = std::find_if(
7103 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7104 return source.source_type() == webrtc::RtpSourceType::SSRC;
7105 });
7106 auto csrcSource = std::find_if(
7107 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7108 return source.source_type() == webrtc::RtpSourceType::CSRC;
7109 });
7110
7111 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7112 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7113 }
7114
7115 // It only keeps 10s of history.
7116 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7117
7118 {
7119 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7120 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7121 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7122 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7123 [](const webrtc::RtpSource& source) {
7124 return source.source_type() ==
7125 webrtc::RtpSourceType::SSRC;
7126 }));
7127 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7128 [](const webrtc::RtpSource& source) {
7129 return source.source_type() ==
7130 webrtc::RtpSourceType::CSRC;
7131 }));
7132 }
7133
7134 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7135 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7136 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7137}
7138
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007139} // namespace cricket