blob: 543fa3a71bbf61a687505deb85ce3634bf1912f1 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller039743e2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Seth Hampson24722b32017-12-22 09:36:42 -080018#include "api/rtpparameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080019#include "api/test/mock_video_bitrate_allocator.h"
20#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070021#include "api/test/mock_video_decoder_factory.h"
22#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020023#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080024#include "api/video/builtin_video_bitrate_allocator_factory.h"
Åsa Persson23eba222018-10-02 14:47:06 +020025#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020026#include "api/video_codecs/builtin_video_decoder_factory.h"
27#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "api/video_codecs/sdp_video_format.h"
29#include "api/video_codecs/video_decoder_factory.h"
30#include "api/video_codecs/video_encoder.h"
31#include "api/video_codecs/video_encoder_factory.h"
32#include "call/flexfec_receive_stream.h"
33#include "common_video/h264/profile_level_id.h"
34#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020035#include "media/base/fakenetworkinterface.h"
36#include "media/base/fakevideocapturer.h"
37#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020038#include "media/base/mediaconstants.h"
39#include "media/base/rtputils.h"
40#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020041#include "media/engine/constants.h"
42#include "media/engine/fakewebrtccall.h"
43#include "media/engine/fakewebrtcvideoengine.h"
44#include "media/engine/simulcast.h"
45#include "media/engine/webrtcvideoengine.h"
46#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020047#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020049#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020051#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "rtc_base/stringutils.h"
53#include "test/field_trial.h"
54#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000055
Tommi85959932018-02-07 19:26:06 +010056using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010057using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070058using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010059using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070060
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000061namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000062static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000063
noahricd10a68e2015-07-10 11:27:55 -070064static const uint8_t kRedRtxPayloadType = 125;
65
Niels Möller6557d0c2018-04-11 15:18:34 +020066static const uint32_t kTimeout = 5000U;
67static const uint32_t kDefaultReceiveSsrc = 0;
68static const uint32_t kSsrc = 1234u;
69static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
70static const int kVideoWidth = 640;
71static const int kVideoHeight = 360;
72static const int kFramerate = 30;
73
Peter Boström0c4e06b2015-10-07 12:23:21 +020074static const uint32_t kSsrcs1[] = {1};
75static const uint32_t kSsrcs3[] = {1, 2, 3};
76static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080077static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020078static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080079static const uint32_t kDefaultRecvSsrc = 0;
80
pbos@webrtc.org3c107582014-07-20 15:27:35 +000081static const char kUnsupportedExtensionName[] =
82 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000083
magjed509e4fe2016-11-18 01:34:11 -080084cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
85 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020086 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080087}
88
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000089void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
90 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
91 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
93 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
95 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
96 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080097 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
98 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000099 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
100}
101
magjed725e4842016-11-16 00:48:13 -0800102// Return true if any codec in |codecs| is an RTX codec with associated payload
103// type |payload_type|.
104bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
105 int payload_type) {
106 for (const cricket::VideoCodec& codec : codecs) {
107 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200108 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800109 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
110 &associated_payload_type) &&
111 associated_payload_type == payload_type) {
112 return true;
113 }
114 }
115 return false;
116}
117
nisseca5706d2017-09-11 02:32:16 -0700118// TODO(nisse): Duplicated in call.cc.
119const int* FindKeyByValue(const std::map<int, int>& m, int v) {
120 for (const auto& kv : m) {
121 if (kv.second == v)
122 return &kv.first;
123 }
124 return nullptr;
125}
126
Yves Gerey665174f2018-06-19 15:03:05 +0200127bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
128 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700129 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
130 payload_type) != nullptr;
131}
132
133// Check that there's an Rtx payload type for each decoder.
134bool VerifyRtxReceiveAssociations(
135 const webrtc::VideoReceiveStream::Config& config) {
136 for (const auto& decoder : config.decoders) {
137 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
138 return false;
139 }
140 return true;
141}
142
brandtrffc61182016-11-28 06:02:22 -0800143rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700144 int width,
145 int height) {
146 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
147 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800148 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700149 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000150}
151
Shao Changbine62202f2015-04-21 20:24:50 +0800152void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
153 const std::map<int, int>& rtx_types) {
154 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200155 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800156 EXPECT_TRUE(it != rtx_types.end() &&
157 it->second == config.rtp.rtx.payload_type);
158
brandtrb5f2c3f2016-10-04 23:28:39 -0700159 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
160 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800161 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700162 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800163 }
164}
kthelgason2bc68642017-02-07 07:02:22 -0800165
166cricket::MediaConfig GetMediaConfig() {
167 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100168 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800169 return media_config;
170}
nisse26e3abb2017-08-25 04:44:25 -0700171
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200172// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
173int GetMaxDefaultBitrateBps(size_t width, size_t height) {
174 if (width * height <= 320 * 240) {
175 return 600000;
176 } else if (width * height <= 640 * 480) {
177 return 1700000;
178 } else if (width * height <= 960 * 540) {
179 return 2000000;
180 } else {
181 return 2500000;
182 }
183}
184
Niels Möller731a2c22018-07-30 15:08:07 +0200185class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
186 public:
187 MOCK_METHOD2(AddOrUpdateSink,
188 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
189 const rtc::VideoSinkWants& wants));
190 MOCK_METHOD1(RemoveSink,
191 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
192};
193
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000194} // namespace
195
Yves Gerey665174f2018-06-19 15:03:05 +0200196#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200197 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200198 EXPECT_EQ((w), renderer_.width()); \
199 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ(0, renderer_.errors());
201
Yves Gerey665174f2018-06-19 15:03:05 +0200202#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200204 EXPECT_EQ((w), (r).width()); \
205 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ(0, (r).errors());
207
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000208namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700209class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000210 public:
eladalonf1841382017-06-12 01:16:46 -0700211 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
212 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700213 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700214 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200215 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
216 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200217 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200218 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200219 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800220 decoder_factory_),
221 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200222 // Ensure fake clock doesn't return 0, which will cause some initializations
223 // fail inside RTP senders.
224 fake_clock_.AdvanceTimeMicros(1);
225 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000226
227 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200228 void AssignDefaultAptRtxTypes();
229 void AssignDefaultCodec();
230
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100231 // Find the index of the codec in the engine with the given name. The codec
232 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100233 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100234
magjed509e4fe2016-11-18 01:34:11 -0800235 // Find the codec in the engine with the given name. The codec must be
236 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100237 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800238
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200239 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000240
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200241 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000242 const std::vector<VideoCodec>& codecs);
243
Peter Boströme4499152016-02-05 11:13:28 +0100244 void TestExtendedEncoderOveruse(bool use_external_encoder);
245
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200246 // Has to be the first one, so it is initialized before the call or there is a
247 // race condition in the clock access.
248 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700249 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700250 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700251 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000252 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800253 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200254 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
255 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700256 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000257 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800258 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000259};
260
eladalonf1841382017-06-12 01:16:46 -0700261TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200262 encoder_factory_->AddSupportedVideoCodecType("VP8");
263 AssignDefaultCodec();
264
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000265 std::vector<VideoCodec> engine_codecs = engine_.codecs();
266 for (size_t i = 0; i < engine_codecs.size(); ++i) {
267 if (engine_codecs[i].name != kRtxCodecName)
268 continue;
269 int associated_payload_type;
270 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000271 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000272 EXPECT_EQ(default_codec_.id, associated_payload_type);
273 return;
274 }
275 FAIL() << "No RTX codec found among default codecs.";
276}
277
eladalonf1841382017-06-12 01:16:46 -0700278TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100279 RtpCapabilities capabilities = engine_.GetCapabilities();
280 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700281 for (const RtpExtension& extension : capabilities.header_extensions) {
282 if (extension.uri == RtpExtension::kTimestampOffsetUri) {
283 EXPECT_EQ(RtpExtension::kTimestampOffsetDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000284 return;
285 }
286 }
287 FAIL() << "Timestamp offset extension not in header-extension list.";
288}
289
eladalonf1841382017-06-12 01:16:46 -0700290TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100291 RtpCapabilities capabilities = engine_.GetCapabilities();
292 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700293 for (const RtpExtension& extension : capabilities.header_extensions) {
294 if (extension.uri == RtpExtension::kAbsSendTimeUri) {
295 EXPECT_EQ(RtpExtension::kAbsSendTimeDefaultId, extension.id);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000296 return;
297 }
298 }
299 FAIL() << "Absolute Sender Time extension not in header-extension list.";
300}
301
eladalonf1841382017-06-12 01:16:46 -0700302TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100303 RtpCapabilities capabilities = engine_.GetCapabilities();
304 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700305 for (const RtpExtension& extension : capabilities.header_extensions) {
306 if (extension.uri == RtpExtension::kTransportSequenceNumberUri) {
307 EXPECT_EQ(RtpExtension::kTransportSequenceNumberDefaultId, extension.id);
stefanc1aeaf02015-10-15 07:26:07 -0700308 return;
309 }
310 }
311 FAIL() << "Transport sequence number extension not in header-extension list.";
312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100315 RtpCapabilities capabilities = engine_.GetCapabilities();
316 ASSERT_FALSE(capabilities.header_extensions.empty());
isheriff6f8d6862016-05-26 11:24:55 -0700317 for (const RtpExtension& extension : capabilities.header_extensions) {
318 if (extension.uri == RtpExtension::kVideoRotationUri) {
319 EXPECT_EQ(RtpExtension::kVideoRotationDefaultId, extension.id);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700320 return;
321 }
322 }
323 FAIL() << "Video Rotation extension not in header-extension list.";
324}
325
philipel1e054862018-10-08 16:13:53 +0200326class WebRtcVideoEngineTestWithGenericDescriptor
327 : public WebRtcVideoEngineTest {
328 public:
329 WebRtcVideoEngineTestWithGenericDescriptor()
330 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
331};
332
333TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
334 RtpCapabilities capabilities = engine_.GetCapabilities();
335 ASSERT_FALSE(capabilities.header_extensions.empty());
336 for (const RtpExtension& extension : capabilities.header_extensions) {
337 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
338 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
339 return;
340 }
341 }
342 FAIL() << "Generic descriptor extension not in header-extension list.";
343}
344
eladalonf1841382017-06-12 01:16:46 -0700345TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200346 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700347 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200348 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700349
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200350 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700351
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200352 std::unique_ptr<VideoMediaChannel> channel(
353 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700354 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
355
356 // Add CVO extension.
357 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800358 cricket::VideoSendParameters parameters;
359 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200360 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700361 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200362 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363
Niels Möller731a2c22018-07-30 15:08:07 +0200364 EXPECT_CALL(
365 video_source,
366 AddOrUpdateSink(testing::_,
367 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700368 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200369 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700370
371 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200372 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
374 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200375 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200376 EXPECT_CALL(
377 video_source,
378 AddOrUpdateSink(testing::_,
379 Field(&rtc::VideoSinkWants::rotation_applied, true)));
380
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200381 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700382}
383
eladalonf1841382017-06-12 01:16:46 -0700384TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200385 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800386 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200387 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800388
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200389 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800390
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200391 std::unique_ptr<VideoMediaChannel> channel(
392 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800393 // Add CVO extension.
394 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800395 cricket::VideoSendParameters parameters;
396 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800397 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700398 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800399 EXPECT_TRUE(channel->SetSendParameters(parameters));
400 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
401
Niels Möller731a2c22018-07-30 15:08:07 +0200402 // Set source.
403 EXPECT_CALL(
404 video_source,
405 AddOrUpdateSink(testing::_,
406 Field(&rtc::VideoSinkWants::rotation_applied, false)));
407 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800408}
409
eladalonf1841382017-06-12 01:16:46 -0700410TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200411 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700412
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200413 encoder_factory_->AddSupportedVideoCodecType("VP8");
414 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700415
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200416 std::unique_ptr<VideoMediaChannel> channel(
417 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700418 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
419
420 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200421 EXPECT_CALL(
422 video_source,
423 AddOrUpdateSink(testing::_,
424 Field(&rtc::VideoSinkWants::rotation_applied, true)));
425 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700426
perkjcaafdba2016-03-20 07:34:29 -0700427 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200428 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700429
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700430 // Add CVO extension.
431 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800432 cricket::VideoSendParameters parameters;
433 parameters.codecs.push_back(GetEngineCodec("VP8"));
434 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200435 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700436 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700437 // Also remove the first codec to trigger a codec change as well.
438 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200439 EXPECT_CALL(
440 video_source,
441 AddOrUpdateSink(testing::_,
442 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200443 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700444
445 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200446 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700447
448 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200449 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200450 EXPECT_CALL(
451 video_source,
452 AddOrUpdateSink(testing::_,
453 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200454 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700455}
456
eladalonf1841382017-06-12 01:16:46 -0700457TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200458 encoder_factory_->AddSupportedVideoCodecType("VP8");
459
Sebastian Jansson84848f22018-11-16 10:40:36 +0100460 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700461 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000462
463 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
464
465 EXPECT_FALSE(channel->SetSend(true))
466 << "Channel should not start without codecs.";
467 EXPECT_TRUE(channel->SetSend(false))
468 << "Channel should be stoppable even without set codecs.";
469}
470
eladalonf1841382017-06-12 01:16:46 -0700471TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200472 encoder_factory_->AddSupportedVideoCodecType("VP8");
473
Sebastian Jansson84848f22018-11-16 10:40:36 +0100474 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700475 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000476 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
477 VideoMediaInfo info;
478 channel->GetStats(&info);
479}
480
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200481TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200482 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000483
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200484 std::unique_ptr<VideoMediaChannel> channel(
485 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800486 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000487
488 EXPECT_TRUE(
489 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200490 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000491 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100492 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200493 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000494 EXPECT_EQ(cricket::CS_RUNNING,
495 capturer.Start(capturer.GetSupportedFormats()->front()));
496 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100497 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200498 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
499 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000500 kTimeout);
501
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200502 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100503 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000504
505 // Setting codecs of the same type should not reallocate any encoders
506 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800507 cricket::VideoSendParameters parameters;
508 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200509 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
512 // Remove stream previously added to free the external encoder instance.
513 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200514 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515}
516
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200517// Test that when an encoder factory supports H264, we add an RTX
518// codec for it.
519// TODO(deadbeef): This test should be updated if/when we start
520// adding RTX codecs for unrecognized codec names.
521TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800522 using webrtc::H264::ProfileLevelIdToString;
523 using webrtc::H264::ProfileLevelId;
524 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200525 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
526 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800527 *ProfileLevelIdToString(
528 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200529 webrtc::SdpVideoFormat h264_constrained_high("H264");
530 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800531 *ProfileLevelIdToString(
532 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200533 webrtc::SdpVideoFormat h264_high("H264");
534 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800535 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
536
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200537 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
538 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
539 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700540
magjed725e4842016-11-16 00:48:13 -0800541 // First figure out what payload types the test codecs got assigned.
542 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800543 // Now search for RTX codecs for them. Expect that they all have associated
544 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800545 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200546 codecs,
547 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
548 ->id));
magjed725e4842016-11-16 00:48:13 -0800549 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200550 codecs,
551 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
552 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800553 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200554 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700555}
556
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100557#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700558TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200559 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100560
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200561 std::unique_ptr<VideoMediaChannel> channel(
562 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100563
564 EXPECT_TRUE(
565 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
566}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100567#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100568
eladalonf1841382017-06-12 01:16:46 -0700569TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200570 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100571 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200572 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200573 std::unique_ptr<VideoMediaChannel> channel(
574 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700575
576 EXPECT_TRUE(
577 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
578
Tommi85959932018-02-07 19:26:06 +0100579 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200580 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700581 capturer.Start(cricket::VideoFormat(1280, 720,
582 cricket::VideoFormat::FpsToInterval(60),
583 cricket::FOURCC_I420));
584 channel->SetSend(true);
585
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200586 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700587
588 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700589 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700590 for (int i = 0; i < 10; i++) {
591 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700592 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700593 int64_t interval = timestamp - last_timestamp;
594
595 // Precision changes from nanosecond to millisecond.
596 // Allow error to be no more than 1.
597 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
598
599 last_timestamp = timestamp;
600 }
601
602 capturer.Start(cricket::VideoFormat(1280, 720,
603 cricket::VideoFormat::FpsToInterval(30),
604 cricket::FOURCC_I420));
605
606 EXPECT_TRUE(capturer.CaptureFrame());
607 last_timestamp = stream->GetLastTimestamp();
608 for (int i = 0; i < 10; i++) {
609 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700610 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700611 int64_t interval = timestamp - last_timestamp;
612
613 // Precision changes from nanosecond to millisecond.
614 // Allow error to be no more than 1.
615 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
616
617 last_timestamp = timestamp;
618 }
619
620 // Remove stream previously added to free the external encoder instance.
621 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
622}
623
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200624void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
625 std::vector<VideoCodec> engine_codecs = engine_.codecs();
626 RTC_DCHECK(!engine_codecs.empty());
627 for (const cricket::VideoCodec& codec : engine_codecs) {
628 if (codec.name == "rtx") {
629 int associated_payload_type;
630 if (codec.GetParam(kCodecParamAssociatedPayloadType,
631 &associated_payload_type)) {
632 default_apt_rtx_types_[associated_payload_type] = codec.id;
633 }
634 }
635 }
636}
637
638void WebRtcVideoEngineTest::AssignDefaultCodec() {
639 std::vector<VideoCodec> engine_codecs = engine_.codecs();
640 RTC_DCHECK(!engine_codecs.empty());
641 bool codec_set = false;
642 for (const cricket::VideoCodec& codec : engine_codecs) {
643 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
644 codec.name != "ulpfec") {
645 default_codec_ = codec;
646 codec_set = true;
647 }
648 }
649
650 RTC_DCHECK(codec_set);
651}
652
Oleh Prypina40f8242017-12-21 13:32:23 +0100653size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
654 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100655 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
656 for (size_t i = 0; i < codecs.size(); ++i) {
657 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200658 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200659 continue;
660 // The tests only use H264 Constrained Baseline. Make sure we don't return
661 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200662 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200663 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200664 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
665 if (profile_level_id->profile !=
666 webrtc::H264::kProfileConstrainedBaseline) {
667 continue;
668 }
669 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100670 return i;
magjed509e4fe2016-11-18 01:34:11 -0800671 }
672 // This point should never be reached.
673 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100674 return -1;
675}
676
677cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
678 const std::string& name) const {
679 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800680}
681
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200682VideoMediaChannel*
683WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100684 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700685 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200686 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800687 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200688 for (const webrtc::SdpVideoFormat& format :
689 encoder_factory_->GetSupportedFormats()) {
690 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
691 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
692 engine_codec) == parameters.codecs.end()) {
693 parameters.codecs.push_back(engine_codec);
694 }
695 }
magjed509e4fe2016-11-18 01:34:11 -0800696
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200697 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000698
699 return channel;
700}
701
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200702VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000703 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100704 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700705 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200706 cricket::VideoRecvParameters parameters;
707 parameters.codecs = codecs;
708 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000709
710 return channel;
711}
712
eladalonf1841382017-06-12 01:16:46 -0700713TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200714 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000715
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200716 std::unique_ptr<VideoMediaChannel> channel(
717 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000718
Peter Boström0c4e06b2015-10-07 12:23:21 +0200719 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000720
Yves Gerey665174f2018-06-19 15:03:05 +0200721 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000722 EXPECT_TRUE(channel->SetSend(true));
723
Tommi85959932018-02-07 19:26:06 +0100724 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200725 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000726 EXPECT_EQ(cricket::CS_RUNNING,
727 capturer.Start(capturer.GetSupportedFormats()->front()));
728 EXPECT_TRUE(capturer.CaptureFrame());
729
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200730 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000731
732 // Verify that encoders are configured for simulcast through adapter
733 // (increasing resolution and only configured to send one stream each).
734 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200735 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
736 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000737 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200738 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000739 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
740 EXPECT_GT(codec_settings.width, prev_width);
741 prev_width = codec_settings.width;
742 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000743
Niels Möllerff40b142018-04-09 08:49:14 +0200744 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000745
746 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200747 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000748}
749
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200750TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
751 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200752 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000753
Niels Möller4db138e2018-04-19 09:04:13 +0200754 // Set capturer.
755 FakeVideoCapturerWithTaskQueue capturer;
756 EXPECT_EQ(cricket::CS_RUNNING,
757 capturer.Start(capturer.GetSupportedFormats()->front()));
758
Sebastian Jansson84848f22018-11-16 10:40:36 +0100759 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700760 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200761 cricket::VideoSendParameters parameters;
762 parameters.codecs.push_back(GetEngineCodec("H264"));
763 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000764
765 EXPECT_TRUE(
766 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200767 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
768 // Sending one frame will have allocate the encoder.
769 EXPECT_TRUE(capturer.CaptureFrame());
770
771 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000772
Anders Carlsson67537952018-05-03 11:28:29 +0200773 cricket::VideoSendParameters new_parameters;
774 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
775 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200776
777 // Sending one frame will switch encoder.
778 EXPECT_TRUE(capturer.CaptureFrame());
779
Anders Carlsson8a150d92018-05-14 12:40:04 +0200780 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000781}
782
eladalonf1841382017-06-12 01:16:46 -0700783TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000784 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200785 encoder_factory_->AddSupportedVideoCodecType("VP8");
786 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000787
Sebastian Jansson84848f22018-11-16 10:40:36 +0100788 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700789 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800790 cricket::VideoSendParameters parameters;
791 parameters.codecs.push_back(GetEngineCodec("VP8"));
792 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000793
Peter Boström0c4e06b2015-10-07 12:23:21 +0200794 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000795
Yves Gerey665174f2018-06-19 15:03:05 +0200796 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000797 EXPECT_TRUE(channel->SetSend(true));
798
799 // Send a fake frame, or else the media engine will configure the simulcast
800 // encoder adapter at a low-enough size that it'll only create a single
801 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100802 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200803 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804 EXPECT_EQ(cricket::CS_RUNNING,
805 capturer.Start(capturer.GetSupportedFormats()->front()));
806 EXPECT_TRUE(capturer.CaptureFrame());
807
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200808 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
809 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000810 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000812
813 channel.reset();
814 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200815 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000816}
817
eladalonf1841382017-06-12 01:16:46 -0700818TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000819 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200820 encoder_factory_->AddSupportedVideoCodecType("VP8");
821 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822
Sebastian Jansson84848f22018-11-16 10:40:36 +0100823 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700824 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800825 cricket::VideoSendParameters parameters;
826 parameters.codecs.push_back(GetEngineCodec("H264"));
827 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000828
829 EXPECT_TRUE(
830 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100831
832 // Send a frame of 720p. This should trigger a "real" encoder initialization.
833 cricket::VideoFormat format(
834 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100835 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200836 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100837 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
838 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200839 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
840 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200841 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000842 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200843 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000844
845 channel.reset();
846 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000848}
849
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200850TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
851 webrtc::test::ScopedFieldTrials override_field_trials_(
852 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200853 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700854
Sebastian Jansson84848f22018-11-16 10:40:36 +0100855 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700856 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200857 cricket::VideoSendParameters parameters;
858 parameters.codecs.push_back(GetEngineCodec("H264"));
859 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700860
Peter Boström0c4e06b2015-10-07 12:23:21 +0200861 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700862 EXPECT_TRUE(
863 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100864
865 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700866 cricket::VideoFormat format(
867 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100868 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200869 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100870 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
871 EXPECT_TRUE(capturer.CaptureFrame());
872
Niels Möller4db138e2018-04-19 09:04:13 +0200873 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200874 ASSERT_EQ(1u, encoder_factory_->encoders().size());
875 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
876 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700877 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200878 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200879 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700880}
881
brandtrffc61182016-11-28 06:02:22 -0800882// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700883// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800884//
885// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700886TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800887 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200888 encoder_factory_->AddSupportedVideoCodecType("VP8");
889
brandtrffc61182016-11-28 06:02:22 -0800890 auto is_flexfec = [](const VideoCodec& codec) {
891 if (codec.name == "flexfec-03")
892 return true;
893 return false;
894 };
895
896 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800897 const std::vector<VideoCodec> codecs_before = engine_.codecs();
898 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
899 codecs_before.end(), is_flexfec));
900
901 // FlexFEC is active with field trial.
902 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800903 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800904 const std::vector<VideoCodec> codecs_after = engine_.codecs();
905 EXPECT_NE(codecs_after.end(),
906 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
907}
908
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200909// Test that codecs are added in the order they are reported from the factory.
910TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
911 encoder_factory_->AddSupportedVideoCodecType("VP8");
912 const char* kFakeCodecName = "FakeCodec";
913 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000914
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200915 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100916 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200917 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
918 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000919}
920
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200921// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800922// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200923TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100924 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
925 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100926
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100927 // Set up external encoder factory with first codec, and initialize engine.
928 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
929
brandtrffc61182016-11-28 06:02:22 -0800930 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800931
932 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100933 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800934 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200935 // The codec itself and RTX should have been added.
936 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100937
938 // Check that both fake codecs are present and that the second fake codec
939 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100940 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
941 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100942 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800943}
944
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200945TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
946 const char* kFakeCodecName = "FakeCodec";
947 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
948
949 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
950 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
951}
952
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200953TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
954 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200955 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200956 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800957 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000958
kwiberg686a8ef2016-02-26 03:00:35 -0800959 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200960 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000961
962 EXPECT_TRUE(
963 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200964 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000965
966 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200967 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200968 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000969
970 // Remove stream previously added to free the external decoder instance.
971 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200972 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000973}
974
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200975// Verifies that we can set up decoders.
976TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000977 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
978 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
979 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
980 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200981 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200982 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000983 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800984 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000985
kwiberg686a8ef2016-02-26 03:00:35 -0800986 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200987 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000988
989 EXPECT_TRUE(
990 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200991 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000992}
993
Jonas Oreland49ac5952018-09-26 16:04:32 +0200994// Tests when GetSources is called with non-existing ssrc, it will return an
995// empty list of RtpSource without crashing.
996TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
997 // Setup an recv stream with |kSsrc|.
998 encoder_factory_->AddSupportedVideoCodecType("VP8");
999 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1000 cricket::VideoRecvParameters parameters;
1001 parameters.codecs.push_back(GetEngineCodec("VP8"));
1002 std::unique_ptr<VideoMediaChannel> channel(
1003 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1004
1005 EXPECT_TRUE(
1006 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1007
1008 // Call GetSources with |kSsrc + 1| which doesn't exist.
1009 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1010 EXPECT_EQ(0u, sources.size());
1011}
1012
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001013TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1014 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1015 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001016 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001017 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001018 std::move(decoder_factory),
1019 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001020 EXPECT_EQ(0u, engine.codecs().size());
1021}
1022
1023TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1024 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001025 webrtc::MockVideoEncoderFactory* encoder_factory =
1026 new webrtc::MockVideoEncoderFactory();
1027 webrtc::MockVideoDecoderFactory* decoder_factory =
1028 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001029 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1030 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001031 WebRtcVideoEngine engine(
1032 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001033 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1034 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1035 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001036 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1037 EXPECT_EQ(0u, engine.codecs().size());
1038 EXPECT_CALL(*encoder_factory, Die());
1039 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001040 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041}
1042
1043// Test full behavior in the video engine when video codec factories of the new
1044// type are injected supporting the single codec Vp8. Check the returned codecs
1045// from the engine and that we will create a Vp8 encoder and decoder using the
1046// new factories.
1047TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1048 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001049 webrtc::MockVideoEncoderFactory* encoder_factory =
1050 new webrtc::MockVideoEncoderFactory();
1051 webrtc::MockVideoDecoderFactory* decoder_factory =
1052 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001053 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1054 new webrtc::MockVideoBitrateAllocatorFactory();
1055 EXPECT_CALL(*rate_allocator_factory,
1056 CreateVideoBitrateAllocatorProxy(Field(
1057 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1058 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001059 WebRtcVideoEngine engine(
1060 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001061 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1062 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1063 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001064 const webrtc::SdpVideoFormat vp8_format("VP8");
1065 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1066 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1067 .WillRepeatedly(testing::Return(supported_formats));
1068
1069 // Verify the codecs from the engine.
1070 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001071 // Verify default codecs has been added correctly.
1072 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001073 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001074
1075 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001076 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001077 int vp8_associated_payload;
1078 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1079 &vp8_associated_payload));
1080 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1081
1082 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1083
1084 // RTX codec for RED.
1085 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1086 int red_associated_payload;
1087 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1088 &red_associated_payload));
1089 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1090
1091 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1092
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001093 int associated_payload_type;
1094 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1095 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1096 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1097 // Verify default parameters has been added to the VP8 codec.
1098 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1099
1100 // Mock encoder creation. |engine| take ownership of the encoder.
1101 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1102 codec_info.is_hardware_accelerated = false;
1103 codec_info.has_internal_source = false;
1104 const webrtc::SdpVideoFormat format("VP8");
1105 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1106 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001107 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001108 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001109 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001110 .WillOnce(
1111 ::testing::DoAll(::testing::InvokeWithoutArgs(
1112 [&encoder_created]() { encoder_created.Set(); }),
1113 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001114
1115 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001116 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001117 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1118 .WillOnce(testing::Return(decoder));
1119
1120 // Create a call.
1121 webrtc::RtcEventLogNullImpl event_log;
1122 std::unique_ptr<webrtc::Call> call(
1123 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1124
1125 // Create send channel.
1126 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001127 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001128 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001129 cricket::VideoSendParameters send_parameters;
1130 send_parameters.codecs.push_back(engine_codecs.at(0));
1131 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1132 send_channel->OnReadyToSend(true);
1133 EXPECT_TRUE(
1134 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1135 EXPECT_TRUE(send_channel->SetSend(true));
1136
Niels Möller4db138e2018-04-19 09:04:13 +02001137 // Set capturer.
1138 FakeVideoCapturerWithTaskQueue capturer;
1139 EXPECT_EQ(cricket::CS_RUNNING,
1140 capturer.Start(capturer.GetSupportedFormats()->front()));
1141 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1142 // Sending one frame will allocate the encoder.
1143 EXPECT_TRUE(capturer.CaptureFrame());
1144 encoder_created.Wait(kTimeout);
1145
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001146 // Create recv channel.
1147 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001148 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001149 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001150 cricket::VideoRecvParameters recv_parameters;
1151 recv_parameters.codecs.push_back(engine_codecs.at(0));
1152 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1153 EXPECT_TRUE(recv_channel->AddRecvStream(
1154 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1155
1156 // Remove streams previously added to free the encoder and decoder instance.
1157 EXPECT_CALL(*encoder_factory, Die());
1158 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001159 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001160 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1161 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1162}
1163
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001164// Test behavior when decoder factory fails to create a decoder (returns null).
1165TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1166 // |engine| take ownership of the factories.
1167 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001168 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001169 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001170 new webrtc::MockVideoDecoderFactory();
1171 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1172 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001173 WebRtcVideoEngine engine(
1174 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001175 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1176 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1177 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001178 const webrtc::SdpVideoFormat vp8_format("VP8");
1179 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1180 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1181 .WillRepeatedly(testing::Return(supported_formats));
1182
1183 // Decoder creation fails.
1184 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1185 .WillOnce(testing::Return(nullptr));
1186
1187 // Create a call.
1188 webrtc::RtcEventLogNullImpl event_log;
1189 std::unique_ptr<webrtc::Call> call(
1190 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1191
1192 // Create recv channel.
1193 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001194 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001195 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001196 cricket::VideoRecvParameters recv_parameters;
1197 recv_parameters.codecs.push_back(engine.codecs().front());
1198 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1199 EXPECT_TRUE(recv_channel->AddRecvStream(
1200 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1201
1202 // Remove streams previously added to free the encoder and decoder instance.
1203 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1204}
1205
eladalonf1841382017-06-12 01:16:46 -07001206TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001207 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001208 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001209 std::unique_ptr<VideoMediaChannel> channel(
1210 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001211 ASSERT_TRUE(
1212 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1213 cricket::VideoCodec codec = GetEngineCodec("VP8");
1214 cricket::VideoSendParameters parameters;
1215 parameters.codecs.push_back(codec);
1216 channel->OnReadyToSend(true);
1217 channel->SetSend(true);
1218 ASSERT_TRUE(channel->SetSendParameters(parameters));
1219
Tommi85959932018-02-07 19:26:06 +01001220 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001221 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001222 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001223
1224 EXPECT_EQ(cricket::CS_RUNNING,
1225 capturer.Start(capturer.GetSupportedFormats()->front()));
1226 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001227 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001228 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001229 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001230
Niels Möllerff40b142018-04-09 08:49:14 +02001231 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001232 EXPECT_TRUE(capturer.CaptureFrame());
1233 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001234 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001235
1236 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001237 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001238 EXPECT_TRUE(capturer.CaptureFrame());
1239 // Change to screen content, recreate encoder. For the simulcast encoder
1240 // adapter case, this will result in two calls since InitEncode triggers a
1241 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001242 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001243 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001244 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001245
Niels Möllerff40b142018-04-09 08:49:14 +02001246 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001247 EXPECT_TRUE(capturer.CaptureFrame());
1248 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001249 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001250
1251 options.is_screencast.emplace(false);
1252 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001253 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001254 // Change back to regular video content, update encoder. Also change
1255 // a non |is_screencast| option just to verify it doesn't affect recreation.
1256 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001257 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001258 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001259 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001260
1261 // Remove stream previously added to free the external encoder instance.
1262 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001263 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001264}
1265
Niels Möller6557d0c2018-04-11 15:18:34 +02001266class WebRtcVideoChannelBaseTest : public testing::Test {
1267 protected:
1268 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001269 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001270 webrtc::CreateBuiltinVideoDecoderFactory(),
1271 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001272
1273 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001274 // One testcase calls SetUp in a loop, only create call_ once.
1275 if (!call_) {
1276 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1277 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001278 cricket::MediaConfig media_config;
1279 // Disabling cpu overuse detection actually disables quality scaling too; it
1280 // implies DegradationPreference kMaintainResolution. Automatic scaling
1281 // needs to be disabled, otherwise, tests which check the size of received
1282 // frames become flaky.
1283 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001284 channel_.reset(
1285 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1286 call_.get(), media_config, cricket::VideoOptions(),
1287 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001288 channel_->OnReadyToSend(true);
1289 EXPECT_TRUE(channel_.get() != NULL);
1290 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001291 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001292 cricket::VideoRecvParameters parameters;
1293 parameters.codecs = engine_.codecs();
1294 channel_->SetRecvParameters(parameters);
1295 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1296 video_capturer_.reset(CreateFakeVideoCapturer());
1297 cricket::VideoFormat format(640, 480,
1298 cricket::VideoFormat::FpsToInterval(kFramerate),
1299 cricket::FOURCC_I420);
1300 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001301 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001302 }
1303
1304 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1305 return new cricket::FakeVideoCapturerWithTaskQueue();
1306 }
1307
1308 // Utility method to setup an additional stream to send and receive video.
1309 // Used to test send and recv between two streams.
1310 void SetUpSecondStream() {
1311 SetUpSecondStreamWithNoRecv();
1312 // Setup recv for second stream.
1313 EXPECT_TRUE(channel_->AddRecvStream(
1314 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1315 // Make the second renderer available for use by a new stream.
1316 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1317 }
1318 // Setup an additional stream just to send video. Defer add recv stream.
1319 // This is required if you want to test unsignalled recv of video rtp packets.
1320 void SetUpSecondStreamWithNoRecv() {
1321 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001322 EXPECT_TRUE(
1323 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001324 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001325 EXPECT_FALSE(
1326 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001327 EXPECT_TRUE(channel_->AddSendStream(
1328 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1329 // We dont add recv for the second stream.
1330
1331 // Setup the receive and renderer for second stream after send.
1332 video_capturer_2_.reset(CreateFakeVideoCapturer());
1333 cricket::VideoFormat format(640, 480,
1334 cricket::VideoFormat::FpsToInterval(kFramerate),
1335 cricket::FOURCC_I420);
1336 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1337
Yves Gerey665174f2018-06-19 15:03:05 +02001338 EXPECT_TRUE(
1339 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001340 }
Yves Gerey665174f2018-06-19 15:03:05 +02001341 virtual void TearDown() { channel_.reset(); }
1342 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001343
1344 bool SetOneCodec(const cricket::VideoCodec& codec) {
1345 cricket::VideoFormat capture_format(
1346 kVideoWidth, kVideoHeight,
1347 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1348
1349 if (video_capturer_) {
1350 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1351 }
1352 if (video_capturer_2_) {
1353 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1354 }
1355
1356 bool sending = channel_->sending();
1357 bool success = SetSend(false);
1358 if (success) {
1359 cricket::VideoSendParameters parameters;
1360 parameters.codecs.push_back(codec);
1361 success = channel_->SetSendParameters(parameters);
1362 }
1363 if (success) {
1364 success = SetSend(sending);
1365 }
1366 return success;
1367 }
Yves Gerey665174f2018-06-19 15:03:05 +02001368 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001369 bool SendFrame() {
1370 if (video_capturer_2_) {
1371 video_capturer_2_->CaptureFrame();
1372 }
1373 return video_capturer_.get() && video_capturer_->CaptureFrame();
1374 }
1375 bool WaitAndSendFrame(int wait_ms) {
1376 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1377 ret &= SendFrame();
1378 return ret;
1379 }
Yves Gerey665174f2018-06-19 15:03:05 +02001380 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001381 int NumRtpBytes(uint32_t ssrc) {
1382 return network_interface_.NumRtpBytes(ssrc);
1383 }
Yves Gerey665174f2018-06-19 15:03:05 +02001384 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001385 int NumRtpPackets(uint32_t ssrc) {
1386 return network_interface_.NumRtpPackets(ssrc);
1387 }
Yves Gerey665174f2018-06-19 15:03:05 +02001388 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001389 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1390 return network_interface_.GetRtpPacket(index);
1391 }
1392 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001393 webrtc::RTPHeader header;
1394 EXPECT_TRUE(ParseRtpPacket(p, &header));
1395 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001396 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001397
Niels Möller6557d0c2018-04-11 15:18:34 +02001398 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001399 webrtc::RTPHeader* header) {
1400 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1401 webrtc::RtpHeaderParser::Create());
1402 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001403 }
1404
1405 // Tests that we can send and receive frames.
1406 void SendAndReceive(const cricket::VideoCodec& codec) {
1407 EXPECT_TRUE(SetOneCodec(codec));
1408 EXPECT_TRUE(SetSend(true));
1409 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1410 EXPECT_EQ(0, renderer_.num_rendered_frames());
1411 EXPECT_TRUE(SendFrame());
1412 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1413 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1414 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1415 }
1416
1417 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001418 int duration_sec,
1419 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001420 EXPECT_TRUE(SetOneCodec(codec));
1421 EXPECT_TRUE(SetSend(true));
1422 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1423 EXPECT_EQ(0, renderer_.num_rendered_frames());
1424 for (int i = 0; i < duration_sec; ++i) {
1425 for (int frame = 1; frame <= fps; ++frame) {
1426 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1427 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1428 }
1429 }
1430 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1431 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1432 }
1433
Niels Möller6557d0c2018-04-11 15:18:34 +02001434 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1435 cricket::VideoMediaInfo info;
1436 EXPECT_TRUE(channel_->GetStats(&info));
1437 return info.senders[i];
1438 }
1439
1440 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1441 cricket::VideoMediaInfo info;
1442 EXPECT_TRUE(channel_->GetStats(&info));
1443 return info.receivers[i];
1444 }
1445
1446 // Two streams one channel tests.
1447
1448 // Tests that we can send and receive frames.
1449 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1450 SetUpSecondStream();
1451 // Test sending and receiving on first stream.
1452 SendAndReceive(codec);
1453 // Test sending and receiving on second stream.
1454 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1455 EXPECT_GT(NumRtpPackets(), 0);
1456 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1457 }
1458
1459 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1460 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001461 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001462 return engine_codec;
1463 }
1464 // This point should never be reached.
1465 ADD_FAILURE() << "Unrecognized codec name: " << name;
1466 return cricket::VideoCodec();
1467 }
1468
1469 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1470
1471 cricket::StreamParams DefaultSendStreamParams() {
1472 return cricket::StreamParams::CreateLegacy(kSsrc);
1473 }
1474
1475 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001476 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001477 WebRtcVideoEngine engine_;
1478 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1479 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1480 std::unique_ptr<WebRtcVideoChannel> channel_;
1481 cricket::FakeNetworkInterface network_interface_;
1482 cricket::FakeVideoRenderer renderer_;
1483
1484 // Used by test cases where 2 streams are run on the same channel.
1485 cricket::FakeVideoRenderer renderer2_;
1486};
1487
1488// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001489TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001490 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001491 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001492 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1493 EXPECT_FALSE(channel_->sending());
1494 EXPECT_TRUE(SetSend(true));
1495 EXPECT_TRUE(channel_->sending());
1496 EXPECT_TRUE(SendFrame());
1497 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1498 EXPECT_TRUE(SetSend(false));
1499 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001500}
Niels Möller6557d0c2018-04-11 15:18:34 +02001501
1502// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001503TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001504 EXPECT_FALSE(channel_->sending());
1505 EXPECT_FALSE(SetSend(true));
1506 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001507}
Niels Möller6557d0c2018-04-11 15:18:34 +02001508
1509// Test that we properly set the send and recv buffer sizes by the time
1510// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001511TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001512 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1513 EXPECT_TRUE(SetSend(true));
1514 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001515 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001516}
1517
Niels Möller6557d0c2018-04-11 15:18:34 +02001518// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001519TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001520 const int kDurationSec = 3;
1521 const int kFps = 10;
1522 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1523
1524 cricket::VideoMediaInfo info;
1525 EXPECT_TRUE(channel_->GetStats(&info));
1526
1527 ASSERT_EQ(1U, info.senders.size());
1528 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1529 // For webrtc, bytes_sent does not include the RTP header length.
1530 EXPECT_GT(info.senders[0].bytes_sent, 0);
1531 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1532 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1533 ASSERT_TRUE(info.senders[0].codec_payload_type);
1534 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1535 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1536 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1537 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1538 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1539 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1540 EXPECT_GT(info.senders[0].framerate_input, 0);
1541 EXPECT_GT(info.senders[0].framerate_sent, 0);
1542
1543 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1544 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1545 info.send_codecs[DefaultCodec().id]);
1546
1547 ASSERT_EQ(1U, info.receivers.size());
1548 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1549 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1550 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1551 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1552 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1553 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1554 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1555 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1556 EXPECT_EQ(0, info.receivers[0].packets_lost);
1557 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1558 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1559 EXPECT_EQ(0, info.receivers[0].firs_sent);
1560 EXPECT_EQ(0, info.receivers[0].plis_sent);
1561 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1562 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1563 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1564 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1565 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1566 EXPECT_GT(info.receivers[0].framerate_output, 0);
1567
1568 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1569 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1570 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001571}
Niels Möller6557d0c2018-04-11 15:18:34 +02001572
1573// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001574TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001575 cricket::FakeVideoRenderer renderer1, renderer2;
1576 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1577 cricket::VideoSendParameters parameters;
1578 parameters.codecs.push_back(DefaultCodec());
1579 parameters.conference_mode = true;
1580 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1581 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001582 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1583 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001584 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1585 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1586 EXPECT_EQ(0, renderer1.num_rendered_frames());
1587 EXPECT_EQ(0, renderer2.num_rendered_frames());
1588 std::vector<uint32_t> ssrcs;
1589 ssrcs.push_back(1);
1590 ssrcs.push_back(2);
1591 network_interface_.SetConferenceMode(true, ssrcs);
1592 EXPECT_TRUE(SendFrame());
1593 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1594 kTimeout);
1595 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1596 kTimeout);
1597
1598 EXPECT_TRUE(channel_->SetSend(false));
1599
1600 cricket::VideoMediaInfo info;
1601 EXPECT_TRUE(channel_->GetStats(&info));
1602 ASSERT_EQ(1U, info.senders.size());
1603 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1604 // For webrtc, bytes_sent does not include the RTP header length.
1605 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1606 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1607 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1608 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1609
1610 ASSERT_EQ(2U, info.receivers.size());
1611 for (size_t i = 0; i < info.receivers.size(); ++i) {
1612 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1613 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1614 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001615 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001616 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1617 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1618 }
srtee0c2eea2017-12-15 17:44:33 +01001619}
Niels Möller6557d0c2018-04-11 15:18:34 +02001620
1621// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001622TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001623 // Normal setup; note that we set the SSRC explicitly to ensure that
1624 // it will come first in the senders map.
1625 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1626 cricket::VideoSendParameters parameters;
1627 parameters.codecs.push_back(DefaultCodec());
1628 parameters.conference_mode = true;
1629 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001630 EXPECT_TRUE(
1631 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001632 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1633 EXPECT_TRUE(SetSend(true));
1634 EXPECT_TRUE(SendFrame());
1635 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1636 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1637
1638 // Add an additional capturer, and hook up a renderer to receive it.
1639 cricket::FakeVideoRenderer renderer2;
1640 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1641 CreateFakeVideoCapturer());
1642 const int kTestWidth = 160;
1643 const int kTestHeight = 120;
1644 cricket::VideoFormat format(kTestWidth, kTestHeight,
1645 cricket::VideoFormat::FpsToInterval(5),
1646 cricket::FOURCC_I420);
1647 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001648 EXPECT_TRUE(
1649 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001650 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001651 EXPECT_TRUE(
1652 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001653 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1654 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001655 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1656 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001657
1658 // Get stats, and make sure they are correct for two senders. We wait until
1659 // the number of expected packets have been sent to avoid races where we
1660 // check stats before it has been updated.
1661 cricket::VideoMediaInfo info;
1662 for (uint32_t i = 0; i < kTimeout; ++i) {
1663 rtc::Thread::Current()->ProcessMessages(1);
1664 EXPECT_TRUE(channel_->GetStats(&info));
1665 ASSERT_EQ(2U, info.senders.size());
1666 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1667 NumRtpPackets()) {
1668 // Stats have been updated for both sent frames, expectations can be
1669 // checked now.
1670 break;
1671 }
1672 }
1673 EXPECT_EQ(NumRtpPackets(),
1674 info.senders[0].packets_sent + info.senders[1].packets_sent)
1675 << "Timed out while waiting for packet counts for all sent packets.";
1676 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1677 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1678 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1679 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1680 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1681 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1682 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1683 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1684 // The capturer must be unregistered here as it runs out of it's scope next.
1685 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001686}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001687
Niels Möller6557d0c2018-04-11 15:18:34 +02001688// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001689TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001690 cricket::VideoSendParameters parameters;
1691 parameters.codecs.push_back(DefaultCodec());
1692 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1693 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1694 parameters.max_bandwidth_bps = 128 * 1024;
1695 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001696}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001697
Niels Möller6557d0c2018-04-11 15:18:34 +02001698// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001699TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 EXPECT_TRUE(SetDefaultCodec());
1701 EXPECT_TRUE(SetSend(true));
1702 EXPECT_TRUE(SendFrame());
1703 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001704 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001706 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1707 EXPECT_EQ(kSsrc, header.ssrc);
1708
Niels Möller6557d0c2018-04-11 15:18:34 +02001709 // Packets are being paced out, so these can mismatch between the first and
1710 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001711 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1712 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001713 EXPECT_EQ(1, NumSentSsrcs());
1714 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1715 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001716}
Niels Möller6557d0c2018-04-11 15:18:34 +02001717
1718// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001719TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001720 // Remove stream added in Setup.
1721 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1722 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001723 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001724 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1725 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001726 EXPECT_TRUE(SetSend(true));
1727 EXPECT_TRUE(WaitAndSendFrame(0));
1728 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001729 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001731 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1732 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001733 // Packets are being paced out, so these can mismatch between the first and
1734 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001735 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1736 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001737 EXPECT_EQ(1, NumSentSsrcs());
1738 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1739 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001740}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001741
Niels Möller6557d0c2018-04-11 15:18:34 +02001742// Test that we can set the default video renderer before and after
1743// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001744TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001745 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1746 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001747
1748 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1749 rtc::SetBE32(packet1.data() + 8, kSsrc);
1750 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1751 EXPECT_TRUE(SetDefaultCodec());
1752 EXPECT_TRUE(SetSend(true));
1753 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001754 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001755 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1756 EXPECT_TRUE(SendFrame());
1757 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001758}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001759
Niels Möller6557d0c2018-04-11 15:18:34 +02001760// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001761TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001762 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1763 EXPECT_TRUE(SetSend(true));
1764 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1765 EXPECT_TRUE(SendFrame());
1766 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1767 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001768 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001770 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1771 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001772 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1773 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001774
1775 // Remove the send stream that was added during Setup.
1776 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1777 int rtp_packets = NumRtpPackets();
1778
Niels Möller6557d0c2018-04-11 15:18:34 +02001779 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001780 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1781 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001782 EXPECT_EQ(rtp_packets, NumRtpPackets());
1783 // Wait 30ms to guarantee the engine does not drop the frame.
1784 EXPECT_TRUE(WaitAndSendFrame(30));
1785 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1786
1787 last_packet = NumRtpPackets() - 1;
1788 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001789 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1790 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001791}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001792
Niels Möller6557d0c2018-04-11 15:18:34 +02001793// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001794TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 cricket::FakeVideoRenderer renderer1, renderer2;
1796 EXPECT_TRUE(SetDefaultCodec());
1797 cricket::VideoSendParameters parameters;
1798 parameters.codecs.push_back(DefaultCodec());
1799 parameters.conference_mode = true;
1800 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1801 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001802 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1803 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001804 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1805 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1806 EXPECT_EQ(0, renderer1.num_rendered_frames());
1807 EXPECT_EQ(0, renderer2.num_rendered_frames());
1808 std::vector<uint32_t> ssrcs;
1809 ssrcs.push_back(1);
1810 ssrcs.push_back(2);
1811 network_interface_.SetConferenceMode(true, ssrcs);
1812 EXPECT_TRUE(SendFrame());
1813 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1814 kTimeout);
1815 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1816 kTimeout);
1817
1818 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1819 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1820 EXPECT_EQ(kVideoWidth, renderer1.width());
1821 EXPECT_EQ(kVideoHeight, renderer1.height());
1822 EXPECT_EQ(kVideoWidth, renderer2.width());
1823 EXPECT_EQ(kVideoHeight, renderer2.height());
1824 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1825 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001826}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001827
Niels Möller6557d0c2018-04-11 15:18:34 +02001828// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001829TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001830 using cricket::VideoCodec;
1831 using cricket::VideoOptions;
1832 using cricket::VideoFormat;
1833 using cricket::FOURCC_I420;
1834
1835 VideoCodec codec = DefaultCodec();
1836 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1837 EXPECT_TRUE(SetOneCodec(codec));
1838 EXPECT_TRUE(SetSend(true));
1839 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1840 EXPECT_EQ(0, renderer_.num_rendered_frames());
1841 EXPECT_TRUE(SendFrame());
1842 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1843 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1844 CreateFakeVideoCapturer());
1845
1846 // TODO(nisse): This testcase fails if we don't configure
1847 // screencast. It's unclear why, I see nothing obvious in this
1848 // test which is related to screencast logic.
1849 VideoOptions video_options;
1850 video_options.is_screencast = true;
1851 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1852
1853 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1854 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1855 // All capturers start generating frames with the same timestamp. ViE does
1856 // not allow the same timestamp to be used. Capture one frame before
1857 // associating the capturer with the channel.
1858 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1859
1860 int captured_frames = 1;
1861 for (int iterations = 0; iterations < 2; ++iterations) {
1862 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1863 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1864 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1865 ++captured_frames;
1866 // Wait until frame of right size is captured.
1867 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001868 format.width == renderer_.width() &&
1869 format.height == renderer_.height() &&
1870 !renderer_.black_frame(),
1871 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001872 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1873 EXPECT_EQ(format.width, renderer_.width());
1874 EXPECT_EQ(format.height, renderer_.height());
1875 captured_frames = renderer_.num_rendered_frames() + 1;
1876 EXPECT_FALSE(renderer_.black_frame());
1877 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1878 // Make sure a black frame is generated within the specified timeout.
1879 // The black frame should be the resolution of the previous frame to
1880 // prevent expensive encoder reconfigurations.
1881 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001882 format.width == renderer_.width() &&
1883 format.height == renderer_.height() &&
1884 renderer_.black_frame(),
1885 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001886 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1887 EXPECT_EQ(format.width, renderer_.width());
1888 EXPECT_EQ(format.height, renderer_.height());
1889 EXPECT_TRUE(renderer_.black_frame());
1890
1891 // The black frame has the same timestamp as the next frame since it's
1892 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1893 // not render a frame with the same timestamp so capture another frame
1894 // with the frame capturer to increment the next frame's timestamp.
1895 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1896 }
srtee0c2eea2017-12-15 17:44:33 +01001897}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001898
Niels Möller6557d0c2018-04-11 15:18:34 +02001899// Tests that if SetVideoSend is called with a NULL capturer after the
1900// capturer was already removed, the application doesn't crash (and no black
1901// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001902TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001903 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1904 EXPECT_TRUE(SetSend(true));
1905 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1906 EXPECT_EQ(0, renderer_.num_rendered_frames());
1907 EXPECT_TRUE(SendFrame());
1908 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1909 // Wait for one frame so they don't get dropped because we send frames too
1910 // tightly.
1911 rtc::Thread::Current()->ProcessMessages(30);
1912 // Remove the capturer.
1913 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1914
1915 // No capturer was added, so this SetVideoSend shouldn't do anything.
1916 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1917 rtc::Thread::Current()->ProcessMessages(300);
1918 // Verify no more frames were sent.
1919 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001920}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001921
Niels Möller6557d0c2018-04-11 15:18:34 +02001922// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001923TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001924 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1925 // interval time to avoid that.
1926 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1927 // interval time to avoid that.
1928 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001929 EXPECT_TRUE(
1930 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001931 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1932 cricket::VideoFormat capture_format(
1933 kVideoWidth, kVideoHeight,
1934 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1935 // Set up additional stream 1.
1936 cricket::FakeVideoRenderer renderer1;
1937 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001938 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001939 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001940 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1942 CreateFakeVideoCapturer());
1943 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1944 // Set up additional stream 2.
1945 cricket::FakeVideoRenderer renderer2;
1946 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001947 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001948 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001949 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001950 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1951 CreateFakeVideoCapturer());
1952 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1953 // State for all the streams.
1954 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1955 // A limitation in the lmi implementation requires that SetVideoSend() is
1956 // called after SetOneCodec().
1957 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1958 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1959 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1960 EXPECT_TRUE(SetSend(true));
1961 // Test capturer associated with engine.
1962 const int kTestWidth = 160;
1963 const int kTestHeight = 120;
1964 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001965 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1966 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001967 // Capture a frame with additional capturer2, frames should be received
1968 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001969 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1970 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001971 // Successfully remove the capturer.
1972 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1973 // The capturers must be unregistered here as it runs out of it's scope
1974 // next.
1975 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1976 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001977}
Niels Möller6557d0c2018-04-11 15:18:34 +02001978
1979// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001980TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001981 // Remove the send stream that was added during Setup.
1982 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1983
1984 cricket::StreamParams empty;
1985 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001986 EXPECT_TRUE(
1987 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001988}
Niels Möller6557d0c2018-04-11 15:18:34 +02001989
1990// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001991TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001992 // Remove stream added in Setup. I.e. remove stream corresponding to default
1993 // channel.
1994 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001995 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001996 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1997 EXPECT_TRUE(channel_->AddSendStream(
1998 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1999 }
2000 // Delete one of the non default channel streams, let the destructor delete
2001 // the remaining ones.
2002 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2003 // Stream should already be deleted.
2004 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002005}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002006
eladalonf1841382017-06-12 01:16:46 -07002007TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002008 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002009}
2010
eladalonf1841382017-06-12 01:16:46 -07002011TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002012 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002013}
2014
eladalonf1841382017-06-12 01:16:46 -07002015TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002016 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002017}
2018
eladalonf1841382017-06-12 01:16:46 -07002019TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002020 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2021 // bitrates. This currently happens at <250k, and two streams sharing 300k
2022 // initially will use QVGA instead of VGA.
2023 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2024 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002025 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002026 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002027 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002028}
2029
eladalonf1841382017-06-12 01:16:46 -07002030class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002031 public:
eladalonf1841382017-06-12 01:16:46 -07002032 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2033 explicit WebRtcVideoChannelTest(const char* field_trials)
2034 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002035 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002036 encoder_factory_->AddSupportedVideoCodecType("VP8");
2037 encoder_factory_->AddSupportedVideoCodecType("VP9");
2038#if defined(WEBRTC_USE_H264)
2039 encoder_factory_->AddSupportedVideoCodecType("H264");
2040#endif
2041
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002042 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002043 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2044 GetMediaConfig(), VideoOptions(),
2045 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002046 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002047 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002048 send_parameters_.codecs = engine_.codecs();
2049 recv_parameters_.codecs = engine_.codecs();
2050 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002051 }
2052
2053 protected:
2054 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002055 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002056 }
2057
2058 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002059 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002060 EXPECT_TRUE(channel_->AddSendStream(sp));
2061 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002062 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002063 EXPECT_EQ(num_streams + 1, streams.size());
2064 return streams[streams.size() - 1];
2065 }
2066
2067 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002068 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002069 }
2070
2071 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002072 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002073 }
2074
2075 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002076 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002077 EXPECT_TRUE(channel_->AddRecvStream(sp));
2078 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002079 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002080 EXPECT_EQ(num_streams + 1, streams.size());
2081 return streams[streams.size() - 1];
2082 }
2083
pbos@webrtc.org00873182014-11-25 14:03:34 +00002084 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2085 int expected_min_bitrate_bps,
2086 const char* start_bitrate_kbps,
2087 int expected_start_bitrate_bps,
2088 const char* max_bitrate_kbps,
2089 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002090 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2091 expected_start_bitrate_bps,
2092 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002093 auto& codecs = send_parameters_.codecs;
2094 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002095 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002096 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2097 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2098 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002099 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002100 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002101
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002102 void ExpectSetBitrateParameters(int min_bitrate_bps,
2103 int start_bitrate_bps,
2104 int max_bitrate_bps) {
2105 EXPECT_CALL(
2106 *fake_call_->GetMockTransportControllerSend(),
2107 SetSdpBitrateParameters(AllOf(
2108 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2109 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2110 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2111 }
2112
2113 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2114 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2115 SetSdpBitrateParameters(Field(
2116 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002117 }
2118
Johannes Kron9190b822018-10-29 11:22:05 +01002119 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2120 // For a caller, the answer will be applied in set remote description
2121 // where SetSendParameters() is called.
2122 EXPECT_TRUE(
2123 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2124 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2125 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2126 const webrtc::VideoSendStream::Config& config =
2127 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2128 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2129 }
2130
2131 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2132 // For a callee, the answer will be applied in set local description
2133 // where SetExtmapAllowMixed() and AddSendStream() are called.
2134 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2135 EXPECT_TRUE(
2136 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2137 const webrtc::VideoSendStream::Config& config =
2138 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2139 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2140 }
2141
isheriff6f8d6862016-05-26 11:24:55 -07002142 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002143 // Enable extension.
2144 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002145 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002146 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002147 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002148 FakeVideoSendStream* send_stream =
2149 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2150
2151 // Verify the send extension id.
2152 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2153 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002154 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002155 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002156 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002157 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2158 // receivers.
2159 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2160 ->GetConfig()
2161 .rtp.extensions.empty());
2162
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002163 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002164 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002165 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2166 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002167 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2168
2169 // Verify that adding receive RTP header extensions adds them for existing
2170 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002171 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002172 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002173 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2174 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002175 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002176 }
2177
isheriff6f8d6862016-05-26 11:24:55 -07002178 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002179 // Enable extension.
2180 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002181 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002182 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002183 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002184
2185 FakeVideoReceiveStream* recv_stream =
2186 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2187
2188 // Verify the recv extension id.
2189 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2190 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002191 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002192 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002193 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002194
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002195 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2196 // senders.
2197 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2198 ->GetConfig()
2199 .rtp.extensions.empty());
2200
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002201 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002202 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002203 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2204 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002205 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2206
2207 // Verify that adding receive RTP header extensions adds them for existing
2208 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002209 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002210 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002211 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2212 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002213 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002214 }
2215
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002216 void TestExtensionFilter(const std::vector<std::string>& extensions,
2217 const std::string& expected_extension) {
2218 cricket::VideoSendParameters parameters = send_parameters_;
2219 int expected_id = -1;
2220 int id = 1;
2221 for (const std::string& extension : extensions) {
2222 if (extension == expected_extension)
2223 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002224 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002225 }
2226 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2227 FakeVideoSendStream* send_stream =
2228 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2229
2230 // Verify that only one of them has been set, and that it is the one with
2231 // highest priority (transport sequence number).
2232 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2233 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2234 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002235 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002236 }
2237
asapersson3c81a1a2017-06-14 05:52:21 -07002238 void TestDegradationPreference(bool resolution_scaling_enabled,
2239 bool fps_scaling_enabled);
2240
Erik Språngefbde372015-04-29 16:21:28 +02002241 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002242 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002243 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2244 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002245
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002246 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002247 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002248 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002249 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002250 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002251 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002252 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002253 // Options only take effect on the next frame.
2254 EXPECT_TRUE(capturer->CaptureFrame());
2255
Erik Språng143cec12015-04-28 10:01:41 +02002256 return fake_call_->GetVideoSendStreams().back();
2257 }
2258
Peter Boström2feafdb2015-09-09 14:32:14 +02002259 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2260 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002261 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002262 std::vector<uint32_t> ssrcs;
2263 std::vector<uint32_t> rtx_ssrcs;
2264 uint32_t num_streams = enabled ? 3 : 1;
2265 for (uint32_t i = 0; i < num_streams; ++i) {
2266 uint32_t ssrc = last_ssrc_ + i;
2267 ssrcs.push_back(ssrc);
2268 if (with_rtx) {
2269 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2270 }
Erik Språng143cec12015-04-28 10:01:41 +02002271 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002272 if (with_rtx) {
2273 return AddSendStream(
2274 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2275 }
2276 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002277 }
2278
perkjfa10b552016-10-02 23:45:26 -07002279 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002280 std::vector<FakeVideoSendStream*> streams =
2281 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002282 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002283 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002284 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002285 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002286 }
2287
perkjfa10b552016-10-02 23:45:26 -07002288 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002289 int stream_max,
2290 int expected_encoder_bitrate) {
2291 VideoSendParameters limited_send_params = send_parameters_;
2292 limited_send_params.max_bandwidth_bps = global_max;
2293 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002294 webrtc::RtpParameters parameters =
2295 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002296 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002297 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002298 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002299 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002300 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002301 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002302 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002303 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002304 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002305 }
2306
Åsa Persson55659812018-06-18 17:51:32 +02002307 // Values from kSimulcastConfigs in simulcast.cc.
2308 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2309 std::vector<webrtc::VideoStream> layers(3);
2310 layers[0].min_bitrate_bps = 30000;
2311 layers[0].target_bitrate_bps = 150000;
2312 layers[0].max_bitrate_bps = 200000;
2313 layers[1].min_bitrate_bps = 150000;
2314 layers[1].target_bitrate_bps = 500000;
2315 layers[1].max_bitrate_bps = 700000;
2316 layers[2].min_bitrate_bps = 600000;
2317 layers[2].target_bitrate_bps = 2500000;
2318 layers[2].max_bitrate_bps = 2500000;
2319 return layers;
2320 }
2321
kwiberg686a8ef2016-02-26 03:00:35 -08002322 std::unique_ptr<FakeCall> fake_call_;
2323 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002324 cricket::VideoSendParameters send_parameters_;
2325 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002326 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002327};
2328
eladalonf1841382017-06-12 01:16:46 -07002329TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002330 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002331 const std::string kSyncLabel = "AvSyncLabel";
2332
2333 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002334 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002335 EXPECT_TRUE(channel_->AddRecvStream(sp));
2336
Mirko Bonadeif859e552018-05-30 15:31:29 +02002337 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002338 EXPECT_EQ(kSyncLabel,
2339 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2340 << "SyncGroup should be set based on sync_label";
2341}
2342
eladalonf1841382017-06-12 01:16:46 -07002343TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002344 cricket::VideoSendParameters parameters;
2345 parameters.codecs = engine_.codecs();
2346 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002347 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002348 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002349 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002350
2351 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002352 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2353 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002354 FakeVideoSendStream* send_stream = AddSendStream(
2355 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2356
2357 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2358 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2359 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2360
2361 // Receiver side.
2362 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2363 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002364 EXPECT_FALSE(
2365 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002366 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002367 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002368 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002369 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002370 << "RTX should be mapped for the RED payload type";
2371
brandtr14742122017-01-27 04:53:07 -08002372 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002373}
2374
eladalonf1841382017-06-12 01:16:46 -07002375TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002376 // Setup one channel with an associated RTX stream.
2377 cricket::StreamParams params =
2378 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2379 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2380 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002381 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002382
2383 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2384 << "RTX should be mapped for all decoders/payload types.";
2385 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002386 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002387 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002388}
2389
eladalonf1841382017-06-12 01:16:46 -07002390TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002391 // Setup one channel without an associated RTX stream.
2392 cricket::StreamParams params =
2393 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2394 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002395 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002396}
2397
Johannes Kron9190b822018-10-29 11:22:05 +01002398// Test propagation of extmap allow mixed setting.
2399TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2400 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2401}
2402TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2403 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2404}
2405TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2406 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2407}
2408TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2409 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2410}
2411
eladalonf1841382017-06-12 01:16:46 -07002412TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002413 FakeVideoSendStream* send_stream =
2414 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2415 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2416
2417 FakeVideoReceiveStream* recv_stream =
2418 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2419 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002420}
2421
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002422// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002423TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002424 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002425}
isheriff6f8d6862016-05-26 11:24:55 -07002426
eladalonf1841382017-06-12 01:16:46 -07002427TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002428 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002429}
2430
2431// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002432TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002433 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002434}
isheriff6f8d6862016-05-26 11:24:55 -07002435
eladalonf1841382017-06-12 01:16:46 -07002436TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002437 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002438}
2439
eladalonf1841382017-06-12 01:16:46 -07002440TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002441 // Enable three redundant extensions.
2442 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002443 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2444 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2445 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2446 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002447}
2448
eladalonf1841382017-06-12 01:16:46 -07002449TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002450 // Enable two redundant extensions.
2451 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002452 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2453 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2454 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002455}
2456
stefanc1aeaf02015-10-15 07:26:07 -07002457// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002458TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002459 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002460}
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002462 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002463}
2464
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002465// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002466TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002467 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002468}
eladalonf1841382017-06-12 01:16:46 -07002469TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002470 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002471}
2472
eladalonf1841382017-06-12 01:16:46 -07002473TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002474 const int kAbsSendTimeId = 1;
2475 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002476 send_parameters_.extensions.push_back(
2477 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2478 send_parameters_.extensions.push_back(
2479 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002480
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002481 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002482 FakeVideoSendStream* send_stream =
2483 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2484
2485 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002486 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002487
2488 // Setting the same extensions (even if in different order) shouldn't
2489 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002490 std::reverse(send_parameters_.extensions.begin(),
2491 send_parameters_.extensions.end());
2492 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002493
2494 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2495
2496 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002497 send_parameters_.extensions.resize(1);
2498 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002499
2500 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2501}
2502
eladalonf1841382017-06-12 01:16:46 -07002503TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002504 const int kTOffsetId = 1;
2505 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002506 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002507 recv_parameters_.extensions.push_back(
2508 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2509 recv_parameters_.extensions.push_back(
2510 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2511 recv_parameters_.extensions.push_back(
2512 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002513
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002514 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002515 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002516 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2517
2518 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002519 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002520
2521 // Setting the same extensions (even if in different order) shouldn't
2522 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002523 std::reverse(recv_parameters_.extensions.begin(),
2524 recv_parameters_.extensions.end());
2525 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002526
2527 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2528
2529 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002530 recv_parameters_.extensions.resize(1);
2531 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002532
2533 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2534}
2535
eladalonf1841382017-06-12 01:16:46 -07002536TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002537 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002538 const int kUnsupportedId = 1;
2539 const int kTOffsetId = 2;
2540
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002541 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002542 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002543 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002544 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002545 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002546 FakeVideoSendStream* send_stream =
2547 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2548
2549 // Only timestamp offset extension is set to send stream,
2550 // unsupported rtp extension is ignored.
2551 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002552 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2553 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002554}
2555
eladalonf1841382017-06-12 01:16:46 -07002556TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002557 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002558 const int kUnsupportedId = 1;
2559 const int kTOffsetId = 2;
2560
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002561 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002562 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002563 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002564 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002565 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002566 FakeVideoReceiveStream* recv_stream =
2567 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2568
2569 // Only timestamp offset extension is set to receive stream,
2570 // unsupported rtp extension is ignored.
2571 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002572 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2573 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002574}
2575
eladalonf1841382017-06-12 01:16:46 -07002576TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002577 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002578 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002579 send_parameters_.extensions.push_back(
2580 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002581 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002582 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2583 }
2584}
2585
eladalonf1841382017-06-12 01:16:46 -07002586TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002587 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002588 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002589 recv_parameters_.extensions.push_back(
2590 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002591 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002592 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2593 }
2594}
2595
eladalonf1841382017-06-12 01:16:46 -07002596TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002597 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002598 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002599 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002600 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002601 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002602 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002603
2604 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002605 send_parameters_.extensions.clear();
2606 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002607 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002608 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2609 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002610}
2611
eladalonf1841382017-06-12 01:16:46 -07002612TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002613 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002614 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002615 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002616 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002617 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002618 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002619
2620 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002621 recv_parameters_.extensions.clear();
2622 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002623 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002624 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2625 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002626}
2627
eladalonf1841382017-06-12 01:16:46 -07002628TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002629 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002630 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002631}
2632
eladalonf1841382017-06-12 01:16:46 -07002633TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002634 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002635 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002636}
2637
eladalonf1841382017-06-12 01:16:46 -07002638TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002639 FakeVideoReceiveStream* stream = AddRecvStream();
2640 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002641}
2642
eladalonf1841382017-06-12 01:16:46 -07002643TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002644 FakeVideoReceiveStream* stream = AddRecvStream();
2645 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2646}
2647
eladalonf1841382017-06-12 01:16:46 -07002648TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002649 FakeVideoReceiveStream* stream = AddRecvStream();
2650 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2651
Peter Boström126c03e2015-05-11 12:48:12 +02002652 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002653 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002654 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002655 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2656 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002657 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002658 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2659
2660 // Verify that REMB is turned on when setting default codecs since the
2661 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002662 parameters.codecs = engine_.codecs();
2663 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002664 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002665 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002666}
2667
eladalonf1841382017-06-12 01:16:46 -07002668TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002669 FakeVideoReceiveStream* stream = AddRecvStream();
2670 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2671
2672 // Verify that transport cc feedback is turned off when send(!) codecs without
2673 // transport cc feedback are set.
2674 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002675 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002676 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2677 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2678 stream = fake_call_->GetVideoReceiveStreams()[0];
2679 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2680
2681 // Verify that transport cc feedback is turned on when setting default codecs
2682 // since the default codecs have transport cc feedback enabled.
2683 parameters.codecs = engine_.codecs();
2684 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2685 stream = fake_call_->GetVideoReceiveStreams()[0];
2686 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2687}
2688
eladalonf1841382017-06-12 01:16:46 -07002689TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002690 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002691 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2692
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002693 cricket::VideoSendParameters parameters;
2694 parameters.codecs = engine_.codecs();
2695 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002696 EXPECT_TRUE(channel_->SetSend(true));
2697
2698 // Send side.
2699 FakeVideoSendStream* send_stream =
2700 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2701 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2702
2703 // Receiver side.
2704 FakeVideoReceiveStream* recv_stream =
2705 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2706 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2707
2708 // Nack history size should match between sender and receiver.
2709 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2710 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002711}
2712
eladalonf1841382017-06-12 01:16:46 -07002713TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002714 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002715 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002716
2717 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2718 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2719
2720 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002721 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002722 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002723 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2724 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002725 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2726 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2727 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002728 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2729
Peter Boström67c9df72015-05-11 14:34:58 +02002730 // Verify that NACK is turned on when setting default codecs since the
2731 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002732 parameters.codecs = engine_.codecs();
2733 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002734 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2735 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2736 send_stream = fake_call_->GetVideoSendStreams()[0];
2737 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002738}
2739
Peter Boströme7ba0862016-03-12 00:02:28 +01002740// This test verifies that new frame sizes reconfigures encoders even though not
2741// (yet) sending. The purpose of this is to permit encoding as quickly as
2742// possible once we start sending. Likely the frames being input are from the
2743// same source that will be sent later, which just means that we're ready
2744// earlier.
eladalonf1841382017-06-12 01:16:46 -07002745TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002746 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002747 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002748 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2749 channel_->SetSend(false);
2750
2751 FakeVideoSendStream* stream = AddSendStream();
2752
perkjfa10b552016-10-02 23:45:26 -07002753 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002754 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002755 EXPECT_EQ(0u, streams[0].width);
2756 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002757
Tommi85959932018-02-07 19:26:06 +01002758 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002759 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002760 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2761 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002762 EXPECT_TRUE(capturer.CaptureFrame());
2763
2764 // Frame entered, should be reconfigured to new dimensions.
2765 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002766 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2767 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2768 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002769
Niels Möllerff40b142018-04-09 08:49:14 +02002770 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002771}
2772
eladalonf1841382017-06-12 01:16:46 -07002773TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002774 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002775 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002776 cricket::VideoSendParameters parameters;
2777 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002778 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002779 AddSendStream();
2780
Tommi85959932018-02-07 19:26:06 +01002781 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002782 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002783 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002784 EXPECT_TRUE(
2785 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002786 cricket::VideoFormat capture_format_hd =
2787 capturer.GetSupportedFormats()->front();
2788 EXPECT_EQ(1280, capture_format_hd.width);
2789 EXPECT_EQ(720, capture_format_hd.height);
2790 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2791
2792 EXPECT_TRUE(channel_->SetSend(true));
2793
2794 EXPECT_TRUE(capturer.CaptureFrame());
2795 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2796 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2797
2798 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2799
2800 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002801 webrtc::VideoEncoderConfig encoder_config =
2802 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002803 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002804 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002805 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002806 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2807 streams.front().width);
2808 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2809 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002810 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2811 << "Non-screenshare shouldn't use min-transmit bitrate.";
2812
Niels Möllerff40b142018-04-09 08:49:14 +02002813 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002814 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002815 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002816 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002817 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002818 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002819 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002820 // Send stream recreated after option change.
2821 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2822 send_stream = fake_call_->GetVideoSendStreams().front();
2823 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002824
2825 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002826 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002827 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002828 encoder_config.content_type);
2829 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2830 encoder_config.min_transmit_bitrate_bps);
2831
perkjfa10b552016-10-02 23:45:26 -07002832 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002833 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2834 streams.front().width);
2835 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2836 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002837 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002838 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002839}
2840
eladalonf1841382017-06-12 01:16:46 -07002841TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002842 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002843 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002844 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002845 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002846
2847 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002848 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002849 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002850 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002851 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002852 cricket::VideoFormat capture_format_hd =
2853 capturer.GetSupportedFormats()->front();
2854 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2855
2856 EXPECT_TRUE(channel_->SetSend(true));
2857
2858 EXPECT_TRUE(capturer.CaptureFrame());
2859 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2860 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2861
perkj26091b12016-09-01 01:17:40 -07002862 webrtc::VideoEncoderConfig encoder_config =
2863 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002864
2865 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002866 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002867 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002868 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002869
2870 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2871 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002872 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002873 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002874 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002875
Niels Möllerff40b142018-04-09 08:49:14 +02002876 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002877}
2878
eladalonf1841382017-06-12 01:16:46 -07002879TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002880 FakeVideoSendStream* stream = AddSendStream();
2881 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2882}
2883
eladalonf1841382017-06-12 01:16:46 -07002884TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002885 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002886 media_config.video.suspend_below_min_bitrate = true;
2887
Sebastian Jansson84848f22018-11-16 10:40:36 +01002888 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002889 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002890 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002891
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002892 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002893
2894 FakeVideoSendStream* stream = AddSendStream();
2895 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2896
nisse0db023a2016-03-01 04:29:59 -08002897 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002898 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002899 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002900 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002901
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002902 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002903
nisse0db023a2016-03-01 04:29:59 -08002904 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002905 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2906}
2907
eladalonf1841382017-06-12 01:16:46 -07002908TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002909 FakeVideoSendStream* stream = AddSendStream();
2910 webrtc::VideoCodecVP8 vp8_settings;
2911 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2912 EXPECT_TRUE(vp8_settings.denoisingOn);
2913}
2914
eladalonf1841382017-06-12 01:16:46 -07002915TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002916 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002917 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002918 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002919
Peter Boström2feafdb2015-09-09 14:32:14 +02002920 // Single-stream settings should apply with RTX as well (verifies that we
2921 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2922 // both RTX and regular SSRCs).
2923 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002924
Tommi85959932018-02-07 19:26:06 +01002925 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002926 EXPECT_EQ(cricket::CS_RUNNING,
2927 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002928 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002929 channel_->SetSend(true);
2930
2931 EXPECT_TRUE(capturer.CaptureFrame());
2932
pbos4cba4eb2015-10-26 11:18:18 -07002933 webrtc::VideoCodecVP8 vp8_settings;
2934 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2935 EXPECT_TRUE(vp8_settings.denoisingOn)
2936 << "VP8 denoising should be on by default.";
2937
nisse05103312016-03-16 02:22:50 -07002938 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002939
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002940 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2941 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002942 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2943 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002944
nisse05103312016-03-16 02:22:50 -07002945 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002946
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002947 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2948 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002949 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2950 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2951
Niels Möllerff40b142018-04-09 08:49:14 +02002952 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002953 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002954 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002955 channel_->SetSend(true);
2956 EXPECT_TRUE(capturer.CaptureFrame());
2957
Mirko Bonadeif859e552018-05-30 15:31:29 +02002958 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002959 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2960 // Autmatic resize off when using simulcast.
2961 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2962 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2963
2964 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002965 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002966 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002967 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002968
nisse05103312016-03-16 02:22:50 -07002969 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002970
Mirko Bonadeif859e552018-05-30 15:31:29 +02002971 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002972 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2973 EXPECT_FALSE(vp8_settings.denoisingOn);
2974 // Resizing and frame dropping always off for screen sharing.
2975 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2976 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2977
nisse05103312016-03-16 02:22:50 -07002978 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002979
2980 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2981 EXPECT_FALSE(vp8_settings.denoisingOn);
2982 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2983 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2984
Niels Möllerff40b142018-04-09 08:49:14 +02002985 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002986}
2987
deadbeef119760a2016-04-04 11:43:27 -07002988// Test that setting the same options doesn't result in the encoder being
2989// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002990TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002991 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002992 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002993
perkjfa10b552016-10-02 23:45:26 -07002994 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002995 EXPECT_EQ(cricket::CS_RUNNING,
2996 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002997 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002998 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002999 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3000 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3001
Niels Möllerff40b142018-04-09 08:49:14 +02003002 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
3003 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003004 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07003005 // Expect 1 reconfigurations at this point from the initial configuration.
3006 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003007
3008 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02003009 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07003010 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3011
3012 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003013 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003014 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003015 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3016
Niels Möllerff40b142018-04-09 08:49:14 +02003017 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003018}
3019
eladalonf1841382017-06-12 01:16:46 -07003020class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003021 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003022 Vp9SettingsTest() : Vp9SettingsTest("") {}
3023 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003024 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003025 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003026 }
3027 virtual ~Vp9SettingsTest() {}
3028
3029 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003030 void TearDown() override {
3031 // Remove references to encoder_factory_ since this will be destroyed
3032 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003033 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003034 }
Erik Språng143cec12015-04-28 10:01:41 +02003035};
3036
3037TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003038 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003039 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003040 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003041
Peter Boström2feafdb2015-09-09 14:32:14 +02003042 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003043
Tommi85959932018-02-07 19:26:06 +01003044 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003045 EXPECT_EQ(cricket::CS_RUNNING,
3046 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003047 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003048 channel_->SetSend(true);
3049
3050 EXPECT_TRUE(capturer.CaptureFrame());
3051
pbos4cba4eb2015-10-26 11:18:18 -07003052 webrtc::VideoCodecVP9 vp9_settings;
3053 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003054 EXPECT_TRUE(vp9_settings.denoisingOn)
3055 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003056
nisse05103312016-03-16 02:22:50 -07003057 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003058
Erik Språng143cec12015-04-28 10:01:41 +02003059 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3060 EXPECT_FALSE(vp9_settings.denoisingOn);
3061 // Frame dropping always on for real time video.
3062 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3063
nisse05103312016-03-16 02:22:50 -07003064 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003065
3066 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3067 EXPECT_TRUE(vp9_settings.denoisingOn);
3068 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3069
3070 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003071 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003072 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003073 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003074
nisse05103312016-03-16 02:22:50 -07003075 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003076
3077 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3078 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003079 // Frame dropping always on for screen sharing.
3080 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003081
nisse05103312016-03-16 02:22:50 -07003082 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003083
3084 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3085 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003086 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003087
Niels Möllerff40b142018-04-09 08:49:14 +02003088 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003089}
3090
Sergey Silkinf18072e2018-03-14 10:35:35 +01003091TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3092 cricket::VideoSendParameters parameters;
3093 parameters.codecs.push_back(GetEngineCodec("VP9"));
3094 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3095
3096 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3097
3098 FakeVideoSendStream* stream =
3099 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3100
3101 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3102 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3103
3104 FakeVideoCapturerWithTaskQueue capturer;
3105 EXPECT_EQ(cricket::CS_RUNNING,
3106 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003107 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003108 channel_->SetSend(true);
3109
3110 EXPECT_TRUE(capturer.CaptureFrame());
3111
3112 webrtc::VideoCodecVP9 vp9_settings;
3113 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3114
3115 const size_t kNumSpatialLayers = ssrcs.size();
3116 const size_t kNumTemporalLayers = 3;
3117 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3118 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3119
Niels Möllerff40b142018-04-09 08:49:14 +02003120 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003121}
3122
asaperssonc5dabdd2016-03-21 04:15:50 -07003123class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3124 public:
brandtr468da7c2016-11-22 02:16:47 -08003125 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003126 : Vp9SettingsTest(field_trials) {}
3127
3128 protected:
3129 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3130 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003131 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003132 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3133
3134 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3135
Tommi85959932018-02-07 19:26:06 +01003136 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003137 EXPECT_EQ(cricket::CS_RUNNING,
3138 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003139 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003140 channel_->SetSend(true);
3141
3142 EXPECT_TRUE(capturer.CaptureFrame());
3143
3144 webrtc::VideoCodecVP9 vp9_settings;
3145 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3146 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3147 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3148
Niels Möllerff40b142018-04-09 08:49:14 +02003149 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003150 }
3151};
3152
3153class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3154 public:
3155 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3156};
3157
3158TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3159 const int kNumSpatialLayers = 1;
3160 const int kNumTemporalLayers = 1;
3161 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3162}
3163
3164class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3165 public:
3166 Vp9SettingsTestWithInvalidFlag()
3167 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3168};
3169
3170TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3171 const int kNumSpatialLayers = 1;
3172 const int kNumTemporalLayers = 1;
3173 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3174}
3175
3176class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3177 public:
3178 Vp9SettingsTestWith2SL3TLFlag()
3179 : Vp9SettingsTestWithFieldTrial(
3180 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3181};
3182
3183TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3184 const int kNumSpatialLayers = 2;
3185 const int kNumTemporalLayers = 3;
3186 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3187}
3188
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003189TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3190 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3191 ASSERT_EQ(1u, streams.size());
3192 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3193}
3194
3195TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3196 webrtc::test::ScopedFieldTrials override_field_trials_(
3197 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3198 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3199 ASSERT_EQ(1u, streams.size());
3200 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3201}
3202
asapersson3c81a1a2017-06-14 05:52:21 -07003203TEST_F(WebRtcVideoChannelTest,
3204 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3205 webrtc::test::ScopedFieldTrials override_field_trials_(
3206 "WebRTC-Video-BalancedDegradation/Disabled/");
3207 const bool kResolutionScalingEnabled = true;
3208 const bool kFpsScalingEnabled = false;
3209 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3210}
3211
3212TEST_F(WebRtcVideoChannelTest,
3213 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3214 webrtc::test::ScopedFieldTrials override_field_trials_(
3215 "WebRTC-Video-BalancedDegradation/Enabled/");
3216 const bool kResolutionScalingEnabled = true;
3217 const bool kFpsScalingEnabled = true;
3218 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3219}
3220
eladalonf1841382017-06-12 01:16:46 -07003221TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003222 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003223}
3224
eladalonf1841382017-06-12 01:16:46 -07003225TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003226 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003227}
3228
eladalonf1841382017-06-12 01:16:46 -07003229TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003230 TestCpuAdaptation(true, true);
3231}
3232
eladalonf1841382017-06-12 01:16:46 -07003233TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003234 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003235 cricket::VideoSendParameters parameters;
3236 parameters.codecs.push_back(codec);
3237
kthelgason2bc68642017-02-07 07:02:22 -08003238 MediaConfig media_config = GetMediaConfig();
Sebastian Jansson84848f22018-11-16 10:40:36 +01003239 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003240 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003241 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003242 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3243
3244 AddSendStream();
3245
Tommi85959932018-02-07 19:26:06 +01003246 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003247 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003248 ASSERT_EQ(cricket::CS_RUNNING,
3249 capturer.Start(capturer.GetSupportedFormats()->front()));
3250 ASSERT_TRUE(channel_->SetSend(true));
3251
3252 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3253 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003254
Niels Möllera6cc0f92018-02-12 17:14:55 +01003255 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003256 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3257 EXPECT_EQ(1280, send_stream->GetLastWidth());
3258 EXPECT_EQ(720, send_stream->GetLastHeight());
3259
3260 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003261 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003262 wants.max_pixel_count =
3263 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003264 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003265 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003266 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3267 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3268 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3269
3270 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003271 wants.max_pixel_count =
3272 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003273 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003274 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003275 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3276 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3277 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3278
3279 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003280 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003281 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003282 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3283 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3284
3285 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003286 int current_pixel_count =
3287 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3288 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3289 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003290 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003291 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003292 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003293 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003294 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003295 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003296 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3297 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3298
sprang84a37592017-02-10 07:04:27 -08003299 // Trigger underuse again, should go back up to full resolution.
3300 current_pixel_count =
3301 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003302 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003303 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003304 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003305 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003306 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003307 EXPECT_EQ(1284, send_stream->GetLastWidth());
3308 EXPECT_EQ(724, send_stream->GetLastHeight());
3309
Niels Möllerff40b142018-04-09 08:49:14 +02003310 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003311}
3312
eladalonf1841382017-06-12 01:16:46 -07003313TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003314 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003315 cricket::VideoSendParameters parameters;
3316 parameters.codecs.push_back(codec);
3317
kthelgason2bc68642017-02-07 07:02:22 -08003318 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003319 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003320 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003321 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003322 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003323 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3324
3325 AddSendStream();
3326
Tommi85959932018-02-07 19:26:06 +01003327 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003328 ASSERT_EQ(cricket::CS_RUNNING,
3329 capturer.Start(capturer.GetSupportedFormats()->front()));
3330 ASSERT_TRUE(channel_->SetSend(true));
3331 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003332 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003333 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003334
3335 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3336 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003337
Niels Möllera6cc0f92018-02-12 17:14:55 +01003338 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003339 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3340 EXPECT_EQ(1280, send_stream->GetLastWidth());
3341 EXPECT_EQ(720, send_stream->GetLastHeight());
3342
3343 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003344 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003345 wants.max_pixel_count =
3346 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003347 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003348 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003349 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3350 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3351 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3352
3353 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003354 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003355 ASSERT_EQ(cricket::CS_RUNNING,
3356 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003357 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003358 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003359 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003360 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003361 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3362 send_stream = fake_call_->GetVideoSendStreams().front();
3363 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003364 EXPECT_EQ(1284, send_stream->GetLastWidth());
3365 EXPECT_EQ(724, send_stream->GetLastHeight());
3366
3367 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003368 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003369 send_stream = fake_call_->GetVideoSendStreams().front();
3370 // We have a new fake send stream, so it doesn't remember the old sink wants.
3371 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003372 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003373 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003374 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003375 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3376 send_stream = fake_call_->GetVideoSendStreams().front();
3377 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003378 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3379 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3380
Niels Möllerff40b142018-04-09 08:49:14 +02003381 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003382}
3383
asapersson3c81a1a2017-06-14 05:52:21 -07003384// TODO(asapersson): Remove this test when the balanced field trial is removed.
3385void WebRtcVideoChannelTest::TestDegradationPreference(
3386 bool resolution_scaling_enabled,
3387 bool fps_scaling_enabled) {
3388 cricket::VideoCodec codec = GetEngineCodec("VP8");
3389 cricket::VideoSendParameters parameters;
3390 parameters.codecs.push_back(codec);
3391
3392 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003393 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003394 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003395 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003396 channel_->OnReadyToSend(true);
3397
3398 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3399
3400 AddSendStream();
3401
Tommi85959932018-02-07 19:26:06 +01003402 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003403 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003404 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003405 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3406 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3407
3408 EXPECT_TRUE(channel_->SetSend(true));
3409
3410 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3411 EXPECT_EQ(resolution_scaling_enabled,
3412 send_stream->resolution_scaling_enabled());
3413 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3414
Niels Möllerff40b142018-04-09 08:49:14 +02003415 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003416}
3417
eladalonf1841382017-06-12 01:16:46 -07003418void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3419 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003420 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003421 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003422 cricket::VideoSendParameters parameters;
3423 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003424
kthelgason2bc68642017-02-07 07:02:22 -08003425 MediaConfig media_config = GetMediaConfig();
3426 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003427 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003428 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003429 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003430 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003431 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003432
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003433 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003434
3435 AddSendStream();
3436
Tommi85959932018-02-07 19:26:06 +01003437 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003438 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003439 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003440 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003441 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003442 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003443 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003444
3445 EXPECT_TRUE(channel_->SetSend(true));
3446
solenberge5269742015-09-08 05:13:22 -07003447 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003448
sprangc5d62e22017-04-02 23:53:04 -07003449 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003450 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003451 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3452 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003453
3454 EXPECT_TRUE(capturer.CaptureFrame());
3455 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3456
perkj26752742016-10-24 01:21:16 -07003457 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3458 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003459
Niels Möllerff40b142018-04-09 08:49:14 +02003460 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003461 return;
3462 }
3463
sprangc5d62e22017-04-02 23:53:04 -07003464 if (is_screenshare) {
3465 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3466 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3467 } else {
3468 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3469 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3470 }
3471
perkj803d97f2016-11-01 11:45:46 -07003472 // Trigger overuse.
3473 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3474
3475 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003476 if (is_screenshare) {
3477 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3478 } else {
3479 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3480 }
perkj803d97f2016-11-01 11:45:46 -07003481 send_stream->InjectVideoSinkWants(wants);
3482
sprangc5d62e22017-04-02 23:53:04 -07003483 for (int i = 0; i < kDefaultFps; ++i)
3484 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003485
sprangc5d62e22017-04-02 23:53:04 -07003486 if (is_screenshare) {
3487 // Drops every third frame.
3488 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3489 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3490 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3491 } else {
3492 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3493 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3494 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3495 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003496
3497 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003498 int last_pixel_count =
3499 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003500 if (is_screenshare) {
3501 wants.max_framerate_fps = kDefaultFps;
3502 } else {
3503 wants.max_pixel_count = last_pixel_count * 4;
3504 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3505 }
perkj803d97f2016-11-01 11:45:46 -07003506 send_stream->InjectVideoSinkWants(wants);
3507
sprangc5d62e22017-04-02 23:53:04 -07003508 for (int i = 0; i < kDefaultFps; ++i)
3509 EXPECT_TRUE(capturer.CaptureFrame());
3510
3511 if (is_screenshare) {
3512 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3513 send_stream->GetNumberOfSwappedFrames());
3514 } else {
3515 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3516 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003517
perkj26752742016-10-24 01:21:16 -07003518 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3519 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003520
Niels Möllerff40b142018-04-09 08:49:14 +02003521 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003522}
3523
eladalonf1841382017-06-12 01:16:46 -07003524TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003525 // Start at last timestamp to verify that wraparounds are estimated correctly.
3526 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3527 static const int64_t kInitialNtpTimeMs = 1247891230;
3528 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003529 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003530
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003531 FakeVideoReceiveStream* stream = AddRecvStream();
3532 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003533 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003534
nisse64ec8f82016-09-27 00:17:25 -07003535 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3536 kInitialTimestamp, 0,
3537 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003538 // Initial NTP time is not available on the first frame, but should still be
3539 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003540 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003541
3542 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003543
3544 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3545 // triggers a constant-overflow warning, hence we're calculating it explicitly
3546 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003547 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003548 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3549 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003550 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003551
3552 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003553
3554 // Verify that NTP time has been correctly deduced.
3555 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003556 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003557 ASSERT_EQ(1u, info.receivers.size());
3558 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003559}
3560
eladalonf1841382017-06-12 01:16:46 -07003561TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003562 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003563 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003564
3565 VideoCodec codec;
3566 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003567 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003568
3569 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003570 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3571 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003572 FakeVideoSendStream* stream = AddSendStream(
3573 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003574 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003575
3576 // Make sure NACK and FEC are enabled on the correct payload types.
3577 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003578 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3579 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003580
3581 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3582 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003583 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003584 // TODO(juberti): Check RTCP, PLI, TMMBR.
3585}
3586
brandtr31bd2242017-05-19 05:47:46 -07003587// The following four tests ensures that FlexFEC is not activated by default
3588// when the field trials are not enabled.
3589// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3590// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003591TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003592 FakeVideoSendStream* stream = AddSendStream();
3593 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3594
brandtr3d200bd2017-01-16 06:59:19 -08003595 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003596 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3597 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003598}
3599
eladalonf1841382017-06-12 01:16:46 -07003600TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003601 FakeVideoSendStream* stream = AddSendStream(
3602 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3603 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3604
brandtr3d200bd2017-01-16 06:59:19 -08003605 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003606 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3607 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3608}
3609
Yves Gerey665174f2018-06-19 15:03:05 +02003610TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003611 AddRecvStream();
3612
3613 const std::vector<FakeFlexfecReceiveStream*>& streams =
3614 fake_call_->GetFlexfecReceiveStreams();
3615 EXPECT_TRUE(streams.empty());
3616}
3617
eladalonf1841382017-06-12 01:16:46 -07003618TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003619 AddRecvStream(
3620 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3621
3622 const std::vector<FakeFlexfecReceiveStream*>& streams =
3623 fake_call_->GetFlexfecReceiveStreams();
3624 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003625}
3626
3627// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3628// tests that use this test fixture into the corresponding "non-field trial"
3629// tests.
eladalonf1841382017-06-12 01:16:46 -07003630class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003631 public:
eladalonf1841382017-06-12 01:16:46 -07003632 WebRtcVideoChannelFlexfecRecvTest()
3633 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003634};
3635
eladalonf1841382017-06-12 01:16:46 -07003636TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003637 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3638 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3639 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3640}
3641
eladalonf1841382017-06-12 01:16:46 -07003642TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003643 AddRecvStream();
3644
3645 const std::vector<FakeFlexfecReceiveStream*>& streams =
3646 fake_call_->GetFlexfecReceiveStreams();
3647 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003648
3649 const std::vector<FakeVideoReceiveStream*>& video_streams =
3650 fake_call_->GetVideoReceiveStreams();
3651 ASSERT_EQ(1U, video_streams.size());
3652 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3653 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3654 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003655}
3656
eladalonf1841382017-06-12 01:16:46 -07003657TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003658 AddRecvStream(
3659 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3660
3661 const std::vector<FakeFlexfecReceiveStream*>& streams =
3662 fake_call_->GetFlexfecReceiveStreams();
3663 ASSERT_EQ(1U, streams.size());
3664 const FakeFlexfecReceiveStream* stream = streams.front();
3665 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3666 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3667 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3668 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3669 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003670
3671 const std::vector<FakeVideoReceiveStream*>& video_streams =
3672 fake_call_->GetVideoReceiveStreams();
3673 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003674 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3675 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003676 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003677 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003678 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003679}
3680
eladalonf1841382017-06-12 01:16:46 -07003681TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003682 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3683 cricket::VideoRecvParameters recv_parameters;
3684 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3685 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3686
3687 AddRecvStream(
3688 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3689 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003690 const std::vector<FakeVideoReceiveStream*>& video_streams =
3691 fake_call_->GetVideoReceiveStreams();
3692 ASSERT_EQ(1U, video_streams.size());
3693 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3694 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3695 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003696
3697 // Enable FlexFEC.
3698 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3699 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3700 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3701 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3702 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3703 << "Enabling FlexFEC should not create VideoReceiveStream.";
3704 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3705 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003706 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3707 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003708}
3709
eladalonf1841382017-06-12 01:16:46 -07003710TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003711 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3712 cricket::VideoRecvParameters recv_parameters;
3713 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3714 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3715 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3716
3717 AddRecvStream(
3718 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3719 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003720 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003721 const std::vector<FakeVideoReceiveStream*>& video_streams =
3722 fake_call_->GetVideoReceiveStreams();
3723 ASSERT_EQ(1U, video_streams.size());
3724 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3725 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3726 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003727
3728 // Disable FlexFEC.
3729 recv_parameters.codecs.clear();
3730 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3731 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3732 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3733 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3734 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3735 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3736 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3737 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003738 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3739 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003740}
3741
brandtr31bd2242017-05-19 05:47:46 -07003742// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3743// tests that use this test fixture into the corresponding "non-field trial"
3744// tests.
eladalonf1841382017-06-12 01:16:46 -07003745class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003746 public:
eladalonf1841382017-06-12 01:16:46 -07003747 WebRtcVideoChannelFlexfecSendRecvTest()
3748 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003749 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3750 }
3751};
3752
Yves Gerey665174f2018-06-19 15:03:05 +02003753TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003754 FakeVideoSendStream* stream = AddSendStream();
3755 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3756
brandtr3d200bd2017-01-16 06:59:19 -08003757 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3758 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3759 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003760}
3761
eladalonf1841382017-06-12 01:16:46 -07003762TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003763 FakeVideoSendStream* stream = AddSendStream(
3764 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3765 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3766
brandtr3d200bd2017-01-16 06:59:19 -08003767 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3768 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3769 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3770 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003771}
3772
eladalonf1841382017-06-12 01:16:46 -07003773TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003774 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003775 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003776 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003777
3778 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003779 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003780
brandtrb5f2c3f2016-10-04 23:28:39 -07003781 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3782 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003783}
3784
eladalonf1841382017-06-12 01:16:46 -07003785TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003786 cricket::VideoSendParameters parameters;
3787 parameters.codecs.push_back(GetEngineCodec("VP8"));
3788 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3789
3790 FakeVideoSendStream* stream = AddSendStream();
3791 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3792
brandtr3d200bd2017-01-16 06:59:19 -08003793 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003794}
3795
eladalonf1841382017-06-12 01:16:46 -07003796TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003797 AddRecvStream(
3798 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003799
3800 cricket::VideoRecvParameters recv_parameters;
3801 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3802 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3803 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003804
3805 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3806 fake_call_->GetFlexfecReceiveStreams();
3807 ASSERT_EQ(1U, flexfec_streams.size());
3808 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3809 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3810 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003811 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003812 flexfec_stream_config.payload_type);
3813 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3814 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3815 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3816 const std::vector<FakeVideoReceiveStream*>& video_streams =
3817 fake_call_->GetVideoReceiveStreams();
3818 const FakeVideoReceiveStream* video_stream = video_streams.front();
3819 const webrtc::VideoReceiveStream::Config& video_stream_config =
3820 video_stream->GetConfig();
3821 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3822 flexfec_stream_config.local_ssrc);
3823 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3824 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3825 flexfec_stream_config.rtcp_send_transport);
3826 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3827 // spec-compliant way.
3828 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3829 flexfec_stream_config.transport_cc);
3830 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3831 EXPECT_EQ(video_stream_config.rtp.extensions,
3832 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003833}
3834
brandtr31bd2242017-05-19 05:47:46 -07003835// We should not send FlexFEC, even if we advertise it, unless the right
3836// field trial is set.
3837// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003838TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003839 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3840 cricket::VideoSendParameters parameters;
3841 parameters.codecs.push_back(GetEngineCodec("VP8"));
3842 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3843 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3844
3845 FakeVideoSendStream* stream = AddSendStream();
3846 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3847
3848 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003849 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003850 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3851}
3852
eladalonf1841382017-06-12 01:16:46 -07003853TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003854 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3855 cricket::VideoSendParameters parameters;
3856 parameters.codecs.push_back(GetEngineCodec("VP8"));
3857 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3858 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3859
3860 FakeVideoSendStream* stream = AddSendStream(
3861 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3862 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3863
3864 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003865 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003866 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3867}
3868
eladalonf1841382017-06-12 01:16:46 -07003869TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003870 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003871 const int kUnusedPayloadType = 127;
3872 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3873
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003874 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003875 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003876 parameters.codecs.push_back(rtx_codec);
3877 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003878 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003879}
3880
eladalonf1841382017-06-12 01:16:46 -07003881TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003882 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003883 const int kUnusedPayloadType1 = 126;
3884 const int kUnusedPayloadType2 = 127;
3885 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3886 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3887 {
3888 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3889 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3890 cricket::VideoSendParameters parameters;
3891 parameters.codecs.push_back(GetEngineCodec("VP8"));
3892 parameters.codecs.push_back(rtx_codec);
3893 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3894 }
3895 {
3896 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3897 kUnusedPayloadType1, kUnusedPayloadType2);
3898 cricket::VideoSendParameters parameters;
3899 parameters.codecs.push_back(GetEngineCodec("VP8"));
3900 parameters.codecs.push_back(rtx_codec);
3901 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3902 << "RTX without matching video codec should be rejected.";
3903 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003904}
3905
eladalonf1841382017-06-12 01:16:46 -07003906TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003907 const int kUnusedPayloadType1 = 126;
3908 const int kUnusedPayloadType2 = 127;
3909 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3910 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3911
3912 // SSRCs for RTX.
3913 cricket::StreamParams params =
3914 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3915 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3916 AddSendStream(params);
3917
3918 // Original payload type for RTX.
3919 cricket::VideoSendParameters parameters;
3920 parameters.codecs.push_back(GetEngineCodec("VP8"));
3921 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3922 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3923 parameters.codecs.push_back(rtx_codec);
3924 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3925 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3926 const webrtc::VideoSendStream::Config& config_before =
3927 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3928 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3929 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3930 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3931
3932 // Change payload type for RTX.
3933 parameters.codecs[1].id = kUnusedPayloadType2;
3934 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3935 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3936 const webrtc::VideoSendStream::Config& config_after =
3937 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3938 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3939 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3940 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3941}
3942
eladalonf1841382017-06-12 01:16:46 -07003943TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003944 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003945 parameters.codecs.push_back(GetEngineCodec("VP8"));
3946 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003947 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003948
3949 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003950 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003951
magjed509e4fe2016-11-18 01:34:11 -08003952 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003953
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003954 parameters.codecs.pop_back();
3955 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003956 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003957 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003958 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003959 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003960 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3961}
3962
eladalonf1841382017-06-12 01:16:46 -07003963TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003964 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003965 cricket::VideoSendParameters parameters;
3966 parameters.codecs.push_back(GetEngineCodec("VP8"));
3967 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3968 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3969
3970 FakeVideoSendStream* stream = AddSendStream(
3971 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3972 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3973
brandtr3d200bd2017-01-16 06:59:19 -08003974 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3975 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003976 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3977 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3978
3979 parameters.codecs.pop_back();
3980 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3981 stream = fake_call_->GetVideoSendStreams()[0];
3982 ASSERT_TRUE(stream != nullptr);
3983 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003984 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003985 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003986}
3987
eladalonf1841382017-06-12 01:16:46 -07003988TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003989 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003990 cricket::VideoCodec codec(100, "VP8");
3991 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3992 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003993
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003994 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003995 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003996
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003997 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01003998 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003999 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004000
4001 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004002 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004003
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004004 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004005 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4006 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004007 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004008 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004009 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004010 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004011}
4012
eladalonf1841382017-06-12 01:16:46 -07004013TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004014 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4015 200000);
4016}
4017
eladalonf1841382017-06-12 01:16:46 -07004018TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004019 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4020 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4021 ASSERT_EQ(1u, streams.size());
4022 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4023}
4024
eladalonf1841382017-06-12 01:16:46 -07004025TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004026 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004027 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004028}
4029
eladalonf1841382017-06-12 01:16:46 -07004030TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004031 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004032}
4033
eladalonf1841382017-06-12 01:16:46 -07004034TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004035 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4036 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4037 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004038}
4039
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004040// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4041// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004042TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004043 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4044 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4045 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4046 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004047 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004048 ExpectSetBitrateParameters(100000, 200000, 400000);
4049 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4050 // Since the codec isn't changing, start_bitrate_bps should be -1.
4051 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004052
4053 // Decrease max_bandwidth_bps.
4054 send_parameters_.max_bandwidth_bps = 350000;
4055 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004056
4057 // Now try again with the values flipped around.
4058 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4059 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004060 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004061 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004062
4063 // If we change the codec max, max_bandwidth_bps should still apply.
4064 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004065 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004066 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004067}
4068
Yves Gerey665174f2018-06-19 15:03:05 +02004069TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004070 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4071 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004072 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004073 // Setting max bitrate should keep previous min bitrate.
4074 // Setting max bitrate should not reset start bitrate.
4075 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004076 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004077}
4078
eladalonf1841382017-06-12 01:16:46 -07004079TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004080 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004081 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004082 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004083 // -1 means to disable max bitrate (set infinite).
4084 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004085 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004086 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004087}
4088
eladalonf1841382017-06-12 01:16:46 -07004089TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004090 send_parameters_.max_bandwidth_bps = 99999;
4091 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004092 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004093 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004094 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4095 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4096 stream->GetVideoStreams()[0].max_bitrate_bps);
4097
4098 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004099 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004100 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4101 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004102 stream->GetVideoStreams()[0].max_bitrate_bps);
4103}
4104
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004105// Tests that when the codec specific max bitrate and VideoSendParameters
4106// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4107// appropriately.
4108TEST_F(WebRtcVideoChannelTest,
4109 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4110 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4111 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4112 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4113 send_parameters_.max_bandwidth_bps = -1;
4114 AddSendStream();
4115 ExpectSetMaxBitrate(300000);
4116 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4117
4118 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4119 ASSERT_EQ(1u, video_send_streams.size());
4120 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4121 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4122 // First the max bitrate is set based upon the codec param.
4123 EXPECT_EQ(300000,
4124 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4125
4126 // The VideoSendParameters max bitrate overrides the codec's.
4127 send_parameters_.max_bandwidth_bps = 500000;
4128 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4129 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4130 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4131 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4132}
4133
4134// Tests that when the codec specific max bitrate and RtpParameters
4135// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4136// appropriately.
4137TEST_F(WebRtcVideoChannelTest,
4138 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4139 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4140 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4141 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4142 send_parameters_.max_bandwidth_bps = -1;
4143 AddSendStream();
4144 ExpectSetMaxBitrate(300000);
4145 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4146
4147 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4148 ASSERT_EQ(1u, video_send_streams.size());
4149 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4150 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4151 // First the max bitrate is set based upon the codec param.
4152 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4153
4154 // The RtpParameter max bitrate overrides the codec's.
4155 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4156 ASSERT_EQ(1u, parameters.encodings.size());
4157 parameters.encodings[0].max_bitrate_bps = 500000;
4158 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4159 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4160 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4161 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4162}
4163
Åsa Persson55659812018-06-18 17:51:32 +02004164TEST_F(WebRtcVideoChannelTest,
4165 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4166 send_parameters_.max_bandwidth_bps = 99999;
4167 FakeVideoSendStream* stream = AddSendStream();
4168 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4169 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4170 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4171 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4172 stream->GetVideoStreams()[0].max_bitrate_bps);
4173
4174 // Get and set the rtp encoding parameters.
4175 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4176 EXPECT_EQ(1u, parameters.encodings.size());
4177
4178 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4179 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4180 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4181 stream->GetVideoStreams()[0].max_bitrate_bps);
4182
4183 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4184 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4185 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4186 stream->GetVideoStreams()[0].max_bitrate_bps);
4187}
4188
eladalonf1841382017-06-12 01:16:46 -07004189TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004190 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004191 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004192 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004193 channel_->SetSend(true);
4194
4195 FakeVideoSendStream* stream = AddSendStream();
4196
Tommi85959932018-02-07 19:26:06 +01004197 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004198 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004199 EXPECT_EQ(cricket::CS_RUNNING,
4200 capturer.Start(capturer.GetSupportedFormats()->front()));
4201
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004202 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4203 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4204 EXPECT_GT(initial_max_bitrate_bps, 0);
4205
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4207 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004208 // Insert a frame to update the encoder config.
4209 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004210 streams = stream->GetVideoStreams();
4211 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004212 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004213}
4214
eladalonf1841382017-06-12 01:16:46 -07004215TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004216 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004217 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004218 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004219 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004220 channel_->SetSend(true);
4221
4222 FakeVideoSendStream* stream = AddSendStream(
4223 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4224
4225 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004226 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004227 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004228 EXPECT_EQ(cricket::CS_RUNNING,
4229 capturer.Start(capturer.GetSupportedFormats()->front()));
4230 EXPECT_TRUE(capturer.CaptureFrame());
4231
4232 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4233 ASSERT_GT(streams.size(), 1u)
4234 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004235 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004236 EXPECT_GT(initial_max_bitrate_bps, 0);
4237
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004238 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4239 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004240 // Insert a frame to update the encoder config.
4241 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004242 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004243 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004244 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4245
Niels Möllerff40b142018-04-09 08:49:14 +02004246 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004247}
4248
eladalonf1841382017-06-12 01:16:46 -07004249TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004250 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004251 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004252 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004253 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4254 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004255 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004256 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004257
4258 VideoCodec codec;
4259 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4260 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4261}
4262
eladalonf1841382017-06-12 01:16:46 -07004263TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004264 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004265 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004266 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004267 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004268 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004269 parameters.codecs[0].id = kIncorrectPayloads[i];
4270 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004271 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004272 }
4273}
4274
eladalonf1841382017-06-12 01:16:46 -07004275TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004276 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004277 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004278 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004279 parameters.codecs[0].id = payload_type;
4280 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004281 << "Payload type '" << payload_type << "' rejected.";
4282 }
4283}
4284
deadbeef67cf2c12016-04-13 10:07:16 -07004285// Test that setting the a different set of codecs but with an identical front
4286// codec doesn't result in the stream being recreated.
4287// This may happen when a subsequent negotiation includes fewer codecs, as a
4288// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004289TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004290 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4291 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004292 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4293 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004294 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4295
4296 AddSendStream();
4297 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4298
4299 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004300 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004301 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4302 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4303}
4304
eladalonf1841382017-06-12 01:16:46 -07004305TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004306 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004307 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004308 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004309}
4310
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004311// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004312TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004313 const int kUnusedPayloadType1 = 126;
4314 const int kUnusedPayloadType2 = 127;
4315 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4316 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4317
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004318 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004319 parameters.codecs.push_back(GetEngineCodec("VP8"));
4320 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004321 parameters.codecs.push_back(rtx_codec);
4322 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004323 << "RTX codec without associated payload should be rejected.";
4324
magjed509e4fe2016-11-18 01:34:11 -08004325 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004326 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004327 << "RTX codec with invalid associated payload type should be rejected.";
4328
magjed509e4fe2016-11-18 01:34:11 -08004329 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004330 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004331
magjed509e4fe2016-11-18 01:34:11 -08004332 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004333 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004334 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004335
Yves Gerey665174f2018-06-19 15:03:05 +02004336 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4337 << "RTX codec with another RTX as associated payload type should be "
4338 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004339}
4340
eladalonf1841382017-06-12 01:16:46 -07004341TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004342 const int kUnusedPayloadType1 = 126;
4343 const int kUnusedPayloadType2 = 127;
4344 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4345 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4346
4347 // SSRCs for RTX.
4348 cricket::StreamParams params =
4349 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4350 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4351 AddRecvStream(params);
4352
4353 // Original payload type for RTX.
4354 cricket::VideoRecvParameters parameters;
4355 parameters.codecs.push_back(GetEngineCodec("VP8"));
4356 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4357 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4358 parameters.codecs.push_back(rtx_codec);
4359 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4360 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4361 const webrtc::VideoReceiveStream::Config& config_before =
4362 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004363 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4364 const int* payload_type_before = FindKeyByValue(
4365 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4366 ASSERT_NE(payload_type_before, nullptr);
4367 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004368 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4369
4370 // Change payload type for RTX.
4371 parameters.codecs[1].id = kUnusedPayloadType2;
4372 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4373 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4374 const webrtc::VideoReceiveStream::Config& config_after =
4375 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004376 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4377 const int* payload_type_after = FindKeyByValue(
4378 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4379 ASSERT_NE(payload_type_after, nullptr);
4380 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004381 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4382}
4383
eladalonf1841382017-06-12 01:16:46 -07004384TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004385 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004386 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004387 parameters.codecs[0].id = 99;
4388 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004389}
4390
eladalonf1841382017-06-12 01:16:46 -07004391TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004392 cricket::VideoRecvParameters parameters;
4393 parameters.codecs = engine_.codecs();
4394 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004395
4396 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004397 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004398 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004399 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004400}
4401
eladalonf1841382017-06-12 01:16:46 -07004402TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004403 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004404 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004405 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004406 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004407}
4408
eladalonf1841382017-06-12 01:16:46 -07004409TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004410 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004411 parameters.codecs.push_back(GetEngineCodec("VP8"));
4412 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004413 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004414}
4415
eladalonf1841382017-06-12 01:16:46 -07004416TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004417 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004418 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4419 send_parameters.codecs.push_back(GetEngineCodec("red"));
4420 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004421 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004422
4423 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004424
magjed509e4fe2016-11-18 01:34:11 -08004425 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004426 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004427
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004428 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004429 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004430 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004431 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004432 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004433 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004434 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4435}
4436
eladalonf1841382017-06-12 01:16:46 -07004437TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004438 AddRecvStream(
4439 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004440 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004441 fake_call_->GetFlexfecReceiveStreams();
4442
4443 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004444 const FakeFlexfecReceiveStream* stream = streams.front();
4445 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4446 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4447 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4448 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004449
4450 cricket::VideoRecvParameters recv_parameters;
4451 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4452 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4453 EXPECT_TRUE(streams.empty())
4454 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004455}
4456
eladalonf1841382017-06-12 01:16:46 -07004457TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004458 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004459 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004460 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004461
4462 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004463 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4464 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4465 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004466 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4467 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004468 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004469 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004470 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004471 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004472
4473 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004474 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4475 send_parameters.codecs.push_back(GetEngineCodec("red"));
4476 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004477 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4478 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004479 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004480 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004481 << "ULPFEC should be enabled on the receive stream.";
4482}
4483
eladalonf1841382017-06-12 01:16:46 -07004484TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004485 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004486 AddRecvStream(
4487 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004488 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004489 fake_call_->GetFlexfecReceiveStreams();
4490
4491 cricket::VideoRecvParameters recv_parameters;
4492 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4493 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4494 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4495 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004496 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004497 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004498 stream_with_recv_params->GetConfig().payload_type);
4499 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004500 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004501 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004502 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004503 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004504
4505 cricket::VideoSendParameters send_parameters;
4506 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4507 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4508 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4509 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004510 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004511 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004512 stream_with_send_params->GetConfig().payload_type);
4513 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004514 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004515 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004516 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004517 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004518}
4519
eladalonf1841382017-06-12 01:16:46 -07004520TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004521 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004522 parameters.codecs.push_back(GetEngineCodec("VP8"));
4523 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004524 parameters.codecs[1].id = parameters.codecs[0].id;
4525 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004526}
4527
eladalonf1841382017-06-12 01:16:46 -07004528TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004529 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004530 cricket::VideoRecvParameters parameters;
4531 parameters.codecs.push_back(GetEngineCodec("VP8"));
4532 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4533 parameters.codecs[1].id = parameters.codecs[0].id;
4534 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4535}
4536
eladalonf1841382017-06-12 01:16:46 -07004537TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004538 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004539 parameters.codecs.push_back(GetEngineCodec("VP8"));
4540 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004541 parameters.codecs[1].id = parameters.codecs[0].id;
4542 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004543}
4544
eladalonf1841382017-06-12 01:16:46 -07004545TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004546 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004547 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004548 parameters.codecs.push_back(GetEngineCodec("VP8"));
4549 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004550 parameters.codecs[1].id += 1;
4551 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004552}
4553
deadbeef67cf2c12016-04-13 10:07:16 -07004554// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004555// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004556TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004557 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004558 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004559 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4560 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004561 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004562
4563 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4564 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4565
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004566 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004567 parameters2.codecs.push_back(GetEngineCodec("red"));
4568 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004569 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004570 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4571}
4572
eladalonf1841382017-06-12 01:16:46 -07004573TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004574 EXPECT_FALSE(AddSendStream()->IsSending());
4575}
4576
eladalonf1841382017-06-12 01:16:46 -07004577TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004578 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004579}
4580
eladalonf1841382017-06-12 01:16:46 -07004581TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004582 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004583 EXPECT_FALSE(stream->IsSending());
4584
4585 // false->true
4586 EXPECT_TRUE(channel_->SetSend(true));
4587 EXPECT_TRUE(stream->IsSending());
4588 // true->true
4589 EXPECT_TRUE(channel_->SetSend(true));
4590 EXPECT_TRUE(stream->IsSending());
4591 // true->false
4592 EXPECT_TRUE(channel_->SetSend(false));
4593 EXPECT_FALSE(stream->IsSending());
4594 // false->false
4595 EXPECT_TRUE(channel_->SetSend(false));
4596 EXPECT_FALSE(stream->IsSending());
4597
4598 EXPECT_TRUE(channel_->SetSend(true));
4599 FakeVideoSendStream* new_stream = AddSendStream();
4600 EXPECT_TRUE(new_stream->IsSending())
4601 << "Send stream created after SetSend(true) not sending initially.";
4602}
4603
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004604// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004605TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004606 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004607 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004608 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004609 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004610 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004611
Sebastian Jansson84848f22018-11-16 10:40:36 +01004612 channel.reset(
4613 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4614 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004615 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004616 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004617 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004618
Tim Haloun648d28a2018-10-18 16:52:22 -07004619 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4620 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004621 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004622 channel.reset(
4623 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4624 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004625 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004626 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4627
4628 // Create a send stream to configure
4629 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4630 parameters = channel->GetRtpSendParameters(kSsrc);
4631 ASSERT_FALSE(parameters.encodings.empty());
4632
4633 // Various priorities map to various dscp values.
4634 parameters.encodings[0].network_priority = 4.0;
4635 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004636 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004637 parameters.encodings[0].network_priority = 0.5;
4638 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4639 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4640
4641 // A bad priority does not change the dscp value.
4642 parameters.encodings[0].network_priority = 0.0;
4643 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4644 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004645
Tim Haloun6ca98362018-09-17 17:06:08 -07004646 // Packets should also self-identify their dscp in PacketOptions.
4647 const uint8_t kData[10] = {0};
4648 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4649 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004650 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004651
nisse51542be2016-02-12 02:27:06 -08004652 // Verify that setting the option to false resets the
4653 // DiffServCodePoint.
4654 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004655 channel.reset(
4656 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4657 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004658 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004659 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004660}
4661
deadbeef13871492015-12-09 12:37:51 -08004662// This test verifies that the RTCP reduced size mode is properly applied to
4663// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004664TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004665 // Create stream, expecting that default mode is "compound".
4666 FakeVideoSendStream* stream1 = AddSendStream();
4667 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004668 webrtc::RtpParameters rtp_parameters =
4669 channel_->GetRtpSendParameters(last_ssrc_);
4670 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004671
4672 // Now enable reduced size mode.
4673 send_parameters_.rtcp.reduced_size = true;
4674 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4675 stream1 = fake_call_->GetVideoSendStreams()[0];
4676 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004677 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4678 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004679
4680 // Create a new stream and ensure it picks up the reduced size mode.
4681 FakeVideoSendStream* stream2 = AddSendStream();
4682 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4683}
4684
4685// This test verifies that the RTCP reduced size mode is properly applied to
4686// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004687TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004688 // Create stream, expecting that default mode is "compound".
4689 FakeVideoReceiveStream* stream1 = AddRecvStream();
4690 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4691
4692 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004693 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4694 // the reduced_size flag should come from that.
4695 send_parameters_.rtcp.reduced_size = true;
4696 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004697 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4698 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4699
4700 // Create a new stream and ensure it picks up the reduced size mode.
4701 FakeVideoReceiveStream* stream2 = AddRecvStream();
4702 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4703}
4704
eladalonf1841382017-06-12 01:16:46 -07004705TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004706 EXPECT_EQ(webrtc::kNetworkUp,
4707 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4708 EXPECT_EQ(webrtc::kNetworkUp,
4709 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004710
4711 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004712 EXPECT_EQ(webrtc::kNetworkDown,
4713 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4714 EXPECT_EQ(webrtc::kNetworkUp,
4715 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004716
4717 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004718 EXPECT_EQ(webrtc::kNetworkUp,
4719 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4720 EXPECT_EQ(webrtc::kNetworkUp,
4721 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004722}
4723
eladalonf1841382017-06-12 01:16:46 -07004724TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004725 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004726 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004727 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004728
4729 AddSendStream();
4730
4731 cricket::VideoMediaInfo info;
4732 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004733 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004734}
4735
eladalonf1841382017-06-12 01:16:46 -07004736TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004737 FakeVideoSendStream* stream = AddSendStream();
4738 webrtc::VideoSendStream::Stats stats;
4739 stats.encoder_implementation_name = "encoder_implementation_name";
4740 stream->SetStats(stats);
4741
4742 cricket::VideoMediaInfo info;
4743 ASSERT_TRUE(channel_->GetStats(&info));
4744 EXPECT_EQ(stats.encoder_implementation_name,
4745 info.senders[0].encoder_implementation_name);
4746}
4747
eladalonf1841382017-06-12 01:16:46 -07004748TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004749 FakeVideoSendStream* stream = AddSendStream();
4750 webrtc::VideoSendStream::Stats stats;
4751 stats.avg_encode_time_ms = 13;
4752 stats.encode_usage_percent = 42;
4753 stream->SetStats(stats);
4754
4755 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004756 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004757 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4758 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4759}
4760
eladalonf1841382017-06-12 01:16:46 -07004761TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004762 FakeVideoSendStream* stream = AddSendStream();
4763 webrtc::VideoSendStream::Stats stats;
4764 stats.frames_encoded = 13;
4765 stream->SetStats(stats);
4766
4767 cricket::VideoMediaInfo info;
4768 ASSERT_TRUE(channel_->GetStats(&info));
4769 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4770}
4771
eladalonf1841382017-06-12 01:16:46 -07004772TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004773 FakeVideoSendStream* stream = AddSendStream();
4774 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004775 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004776 stream->SetStats(stats);
4777
4778 cricket::VideoMediaInfo info;
4779 ASSERT_TRUE(channel_->GetStats(&info));
4780 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4781}
4782
eladalonf1841382017-06-12 01:16:46 -07004783TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004784 FakeVideoSendStream* stream = AddSendStream();
4785 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004786 stats.substreams[17].width = 123;
4787 stats.substreams[17].height = 40;
4788 stats.substreams[42].width = 80;
4789 stats.substreams[42].height = 31;
4790 stats.substreams[11].width = 20;
4791 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004792 stream->SetStats(stats);
4793
4794 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004795 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004796 ASSERT_EQ(1u, info.senders.size());
4797 EXPECT_EQ(123, info.senders[0].send_frame_width);
4798 EXPECT_EQ(90, info.senders[0].send_frame_height);
4799}
4800
eladalonf1841382017-06-12 01:16:46 -07004801TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004802 FakeVideoSendStream* stream = AddSendStream();
4803 webrtc::VideoSendStream::Stats stats;
4804 stats.number_of_cpu_adapt_changes = 2;
4805 stats.cpu_limited_resolution = true;
4806 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004807
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004808 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004809 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004810 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004811 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004812 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004813}
4814
eladalonf1841382017-06-12 01:16:46 -07004815TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004816 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004817 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004818 stats.number_of_cpu_adapt_changes = 2;
4819 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004820 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004821 stream->SetStats(stats);
4822
4823 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004824 EXPECT_TRUE(channel_->GetStats(&info));
4825 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004826 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4827 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004828 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004829 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004830}
4831
eladalonf1841382017-06-12 01:16:46 -07004832TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004833 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4834 FakeVideoSendStream* stream = AddSendStream();
4835 webrtc::VideoSendStream::Stats stats;
4836 stats.bw_limited_resolution = true;
4837 stream->SetStats(stats);
4838
4839 cricket::VideoMediaInfo info;
4840 EXPECT_TRUE(channel_->GetStats(&info));
4841 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004842 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004843 info.senders[0].adapt_reason);
4844}
4845
Yves Gerey665174f2018-06-19 15:03:05 +02004846TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004847 FakeVideoSendStream* stream = AddSendStream();
4848 webrtc::VideoSendStream::Stats stats;
4849 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4850 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4851 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4852
4853 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4854 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4855 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4856
4857 stream->SetStats(stats);
4858
4859 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004860 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004861 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4862 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4863 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4864}
4865
eladalonf1841382017-06-12 01:16:46 -07004866TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004867 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4868 FakeVideoReceiveStream* stream = AddRecvStream();
4869 webrtc::VideoReceiveStream::Stats stats;
4870 stats.rtcp_packet_type_counts.fir_packets = 2;
4871 stats.rtcp_packet_type_counts.nack_packets = 3;
4872 stats.rtcp_packet_type_counts.pli_packets = 4;
4873 stream->SetStats(stats);
4874
4875 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004876 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004877 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004878 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004879 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004880 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004881 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004882 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004883}
4884
eladalonf1841382017-06-12 01:16:46 -07004885TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004886 FakeVideoReceiveStream* stream = AddRecvStream();
4887 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004888 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004889 stats.decode_ms = 2;
4890 stats.max_decode_ms = 3;
4891 stats.current_delay_ms = 4;
4892 stats.target_delay_ms = 5;
4893 stats.jitter_buffer_ms = 6;
4894 stats.min_playout_delay_ms = 7;
4895 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004896 stats.width = 9;
4897 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004898 stats.frame_counts.key_frames = 11;
4899 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004900 stats.frames_rendered = 13;
4901 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004902 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004903 stream->SetStats(stats);
4904
4905 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004906 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004907 EXPECT_EQ(stats.decoder_implementation_name,
4908 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004909 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4910 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4911 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4912 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4913 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4914 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4915 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004916 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4917 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004918 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4919 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004920 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004921 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004922 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004923 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004924}
4925
eladalonf1841382017-06-12 01:16:46 -07004926TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004927 FakeVideoReceiveStream* stream = AddRecvStream();
4928 webrtc::VideoReceiveStream::Stats stats;
4929 stats.rtp_stats.transmitted.payload_bytes = 2;
4930 stats.rtp_stats.transmitted.header_bytes = 3;
4931 stats.rtp_stats.transmitted.padding_bytes = 4;
4932 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004933 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004934 stats.rtcp_stats.fraction_lost = 7;
4935 stream->SetStats(stats);
4936
4937 cricket::VideoMediaInfo info;
4938 ASSERT_TRUE(channel_->GetStats(&info));
4939 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4940 stats.rtp_stats.transmitted.header_bytes +
4941 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004942 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004943 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004944 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004945 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004946 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004947 info.receivers[0].fraction_lost);
4948}
4949
eladalonf1841382017-06-12 01:16:46 -07004950TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004951 AddSendStream();
4952 AddSendStream();
4953 webrtc::Call::Stats stats;
4954 stats.rtt_ms = 123;
4955 fake_call_->SetStats(stats);
4956
4957 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004958 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004959 ASSERT_EQ(2u, info.senders.size());
4960 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4961 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4962}
4963
eladalonf1841382017-06-12 01:16:46 -07004964TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004965 FakeVideoSendStream* stream = AddSendStream();
4966 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004967 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004968 stats.media_bitrate_bps = 123;
4969 stats.substreams[17].total_bitrate_bps = 1;
4970 stats.substreams[17].retransmit_bitrate_bps = 2;
4971 stats.substreams[42].total_bitrate_bps = 3;
4972 stats.substreams[42].retransmit_bitrate_bps = 4;
4973 stream->SetStats(stats);
4974
4975 FakeVideoSendStream* stream2 = AddSendStream();
4976 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004977 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004978 stats2.media_bitrate_bps = 321;
4979 stats2.substreams[13].total_bitrate_bps = 5;
4980 stats2.substreams[13].retransmit_bitrate_bps = 6;
4981 stats2.substreams[21].total_bitrate_bps = 7;
4982 stats2.substreams[21].retransmit_bitrate_bps = 8;
4983 stream2->SetStats(stats2);
4984
4985 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004986 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004987 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004988 BandwidthEstimationInfo bwe_info;
4989 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004990 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4991 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4992 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4993 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004994 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004995 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004996 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004997 bwe_info.actual_enc_bitrate);
4998 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004999 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005000 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005001 << "Bandwidth stats should take all streams into account.";
5002}
5003
eladalonf1841382017-06-12 01:16:46 -07005004TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005005 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005006
Peter Boström0c4e06b2015-10-07 12:23:21 +02005007 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5008 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005009
5010 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5011 const size_t kDataLength = 12;
5012 uint8_t data[kDataLength];
5013 memset(data, 0, sizeof(data));
5014 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005015 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005016 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005017
5018 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5019 << "No default receive stream created.";
5020 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005021 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005022 << "Default receive stream should not have configured RTX";
5023
5024 EXPECT_TRUE(channel_->AddRecvStream(
5025 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5026 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005027 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005028 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005029 EXPECT_FALSE(
5030 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005031 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005032 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005033 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005034 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005035 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005036 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005037}
5038
eladalonf1841382017-06-12 01:16:46 -07005039TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005040 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005041
Peter Boström0c4e06b2015-10-07 12:23:21 +02005042 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5043 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005044
5045 StreamParams sp =
5046 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5047 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5048
5049 EXPECT_FALSE(channel_->AddSendStream(sp));
5050 EXPECT_FALSE(channel_->AddRecvStream(sp));
5051}
5052
eladalonf1841382017-06-12 01:16:46 -07005053TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005054 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005055
Peter Boström0c4e06b2015-10-07 12:23:21 +02005056 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5057 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005058
5059 StreamParams sp =
5060 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5061
5062 EXPECT_TRUE(channel_->AddSendStream(sp));
5063 EXPECT_TRUE(channel_->AddRecvStream(sp));
5064
5065 // The RTX SSRC is already used in previous streams, using it should fail.
5066 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5067 EXPECT_FALSE(channel_->AddSendStream(sp));
5068 EXPECT_FALSE(channel_->AddRecvStream(sp));
5069
5070 // After removing the original stream this should be fine to add (makes sure
5071 // that RTX ssrcs are not forever taken).
5072 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5073 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5074 EXPECT_TRUE(channel_->AddSendStream(sp));
5075 EXPECT_TRUE(channel_->AddRecvStream(sp));
5076}
5077
eladalonf1841382017-06-12 01:16:46 -07005078TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005079 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005080 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5081 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005082 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005083
Peter Boströmd6f4c252015-03-26 16:23:04 +01005084 StreamParams sp =
5085 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5086
5087 EXPECT_TRUE(channel_->AddSendStream(sp));
5088 EXPECT_TRUE(channel_->AddRecvStream(sp));
5089
5090 // One of the SSRCs is already used in previous streams, using it should fail.
5091 sp = cricket::CreateSimStreamParams("cname",
5092 MAKE_VECTOR(kOverlappingStreamSsrcs));
5093 EXPECT_FALSE(channel_->AddSendStream(sp));
5094 EXPECT_FALSE(channel_->AddRecvStream(sp));
5095
5096 // After removing the original stream this should be fine to add (makes sure
5097 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005098 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5099 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005100 EXPECT_TRUE(channel_->AddSendStream(sp));
5101 EXPECT_TRUE(channel_->AddRecvStream(sp));
5102}
5103
eladalonf1841382017-06-12 01:16:46 -07005104TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005105 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005106
5107 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5108 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5109
5110 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5111 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5112
5113 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5114
5115 static const uint32_t kReceiverSsrcs[] = {3};
5116 static const uint32_t kReceiverRtxSsrcs[] = {2};
5117
5118 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5119 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5120 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5121
5122 cricket::VideoMediaInfo info;
5123 ASSERT_TRUE(channel_->GetStats(&info));
5124
5125 ASSERT_EQ(1u, info.senders.size());
5126 ASSERT_EQ(1u, info.receivers.size());
5127
5128 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5129 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5130 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5131}
5132
eladalonf1841382017-06-12 01:16:46 -07005133TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005134 FakeVideoReceiveStream* stream = AddRecvStream();
5135 webrtc::VideoReceiveStream::Stats stats;
5136 cricket::VideoMediaInfo info;
5137
5138 // Report no codec name before receiving.
5139 stream->SetStats(stats);
5140 ASSERT_TRUE(channel_->GetStats(&info));
5141 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5142
5143 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005144 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005145 stream->SetStats(stats);
5146 ASSERT_TRUE(channel_->GetStats(&info));
5147 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5148
5149 // Report no codec name for unknown playload types.
5150 stats.current_payload_type = 3;
5151 stream->SetStats(stats);
5152 ASSERT_TRUE(channel_->GetStats(&info));
5153 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5154}
5155
Seth Hampson5897a6e2018-04-03 11:16:33 -07005156// Tests that when we add a stream without SSRCs, but contains a stream_id
5157// that it is stored and its stream id is later used when the first packet
5158// arrives to properly create a receive stream with a sync label.
5159TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5160 const char kSyncLabel[] = "sync_label";
5161 cricket::StreamParams unsignaled_stream;
5162 unsignaled_stream.set_stream_ids({kSyncLabel});
5163 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5164 // The stream shouldn't have been created at this point because it doesn't
5165 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005166 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005167
5168 // Create and deliver packet.
5169 const size_t kDataLength = 12;
5170 uint8_t data[kDataLength];
5171 memset(data, 0, sizeof(data));
5172 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5173 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005174 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005175
5176 // The stream should now be created with the appropriate sync label.
5177 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5178 EXPECT_EQ(kSyncLabel,
5179 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5180
5181 // Removing the unsignaled stream should clear the cache. This time when
5182 // a default video receive stream is created it won't have a sync_group.
5183 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5184 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5185 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5186
Niels Möllere6933812018-11-05 13:01:41 +01005187 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005188 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5189 EXPECT_TRUE(
5190 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5191}
5192
eladalonf1841382017-06-12 01:16:46 -07005193void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005194 uint8_t payload_type,
5195 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005196 // kRedRtxPayloadType must currently be unused.
5197 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5198
noahricd10a68e2015-07-10 11:27:55 -07005199 // Add a RED RTX codec.
5200 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005201 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005202 recv_parameters_.codecs.push_back(red_rtx_codec);
5203 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005204
5205 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5206 const size_t kDataLength = 12;
5207 uint8_t data[kDataLength];
5208 memset(data, 0, sizeof(data));
5209
5210 rtc::Set8(data, 1, payload_type);
5211 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005212 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005213 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005214
5215 if (expect_created_receive_stream) {
5216 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5217 << "Should have created a receive stream for payload type: "
5218 << payload_type;
5219 } else {
5220 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5221 << "Shouldn't have created a receive stream for payload type: "
5222 << payload_type;
5223 }
5224}
5225
Åsa Persson2c7149b2018-10-15 09:36:10 +02005226class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5227 public:
5228 WebRtcVideoChannelDiscardUnknownSsrcTest()
5229 : WebRtcVideoChannelTest(
5230 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5231};
5232
5233TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5234 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5235 false /* expect_created_receive_stream */);
5236}
5237
eladalonf1841382017-06-12 01:16:46 -07005238TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005239 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5240 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005241}
5242
eladalonf1841382017-06-12 01:16:46 -07005243TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005244 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5245 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005246}
5247
eladalonf1841382017-06-12 01:16:46 -07005248TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005249 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005250 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5251 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5252 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5253 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005254}
5255
eladalonf1841382017-06-12 01:16:46 -07005256TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005257 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5258 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005259}
5260
eladalonf1841382017-06-12 01:16:46 -07005261TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005262 FlexfecPacketDoesntCreateUnsignalledStream) {
5263 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5264 false /* expect_created_receive_stream */);
5265}
5266
eladalonf1841382017-06-12 01:16:46 -07005267TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005268 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5269 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005270}
5271
mzanaty8a855d62017-02-17 15:46:43 -08005272// Test that receiving any unsignalled SSRC works even if it changes.
5273// The first unsignalled SSRC received will create a default receive stream.
5274// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005275TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005276 // Allow receiving VP8, VP9, H264 (if enabled).
5277 cricket::VideoRecvParameters parameters;
5278 parameters.codecs.push_back(GetEngineCodec("VP8"));
5279 parameters.codecs.push_back(GetEngineCodec("VP9"));
5280
5281#if defined(WEBRTC_USE_H264)
5282 cricket::VideoCodec H264codec(126, "H264");
5283 parameters.codecs.push_back(H264codec);
5284#endif
5285
5286 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5287 // No receive streams yet.
5288 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5289 cricket::FakeVideoRenderer renderer;
5290 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5291
5292 // Receive VP8 packet on first SSRC.
5293 uint8_t data[kMinRtpPacketLen];
5294 cricket::RtpHeader rtpHeader;
5295 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5296 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005297 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005298 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5299 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005300 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005301 // VP8 packet should create default receive stream.
5302 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005303 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005304 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5305 // Verify that the receive stream sinks to a renderer.
5306 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5307 webrtc::kVideoRotation_0);
5308 recv_stream->InjectFrame(video_frame);
5309 EXPECT_EQ(1, renderer.num_rendered_frames());
5310
5311 // Receive VP9 packet on second SSRC.
5312 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005313 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005314 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5315 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005316 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005317 // VP9 packet should replace the default receive SSRC.
5318 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5319 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5320 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5321 // Verify that the receive stream sinks to a renderer.
5322 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005323 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005324 recv_stream->InjectFrame(video_frame2);
5325 EXPECT_EQ(2, renderer.num_rendered_frames());
5326
5327#if defined(WEBRTC_USE_H264)
5328 // Receive H264 packet on third SSRC.
5329 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005330 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005331 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5332 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005333 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005334 // H264 packet should replace the default receive SSRC.
5335 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5336 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5337 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5338 // Verify that the receive stream sinks to a renderer.
5339 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005340 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005341 recv_stream->InjectFrame(video_frame3);
5342 EXPECT_EQ(3, renderer.num_rendered_frames());
5343#endif
5344}
5345
brandtr0dc57ea2017-05-29 23:33:31 -07005346// This test verifies that when a new default stream is created for a new
5347// unsignaled SSRC, the new stream does not overwrite any old stream that had
5348// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005349TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005350 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5351 cricket::VideoRecvParameters parameters;
5352 parameters.codecs.push_back(GetEngineCodec("VP8"));
5353 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5354
5355 // No streams signaled and no packets received, so we should not have any
5356 // stream objects created yet.
5357 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5358
5359 // Receive packet on an unsignaled SSRC.
5360 uint8_t data[kMinRtpPacketLen];
5361 cricket::RtpHeader rtp_header;
5362 rtp_header.payload_type = GetEngineCodec("VP8").id;
5363 rtp_header.seq_num = rtp_header.timestamp = 0;
5364 rtp_header.ssrc = kSsrcs3[0];
5365 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5366 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005367 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005368 // Default receive stream should be created.
5369 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5370 FakeVideoReceiveStream* recv_stream0 =
5371 fake_call_->GetVideoReceiveStreams()[0];
5372 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5373
5374 // Signal the SSRC.
5375 EXPECT_TRUE(
5376 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5377 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5378 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5379 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5380
5381 // Receive packet on a different unsignaled SSRC.
5382 rtp_header.ssrc = kSsrcs3[1];
5383 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5384 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005385 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005386 // New default receive stream should be created, but old stream should remain.
5387 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5388 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5389 FakeVideoReceiveStream* recv_stream1 =
5390 fake_call_->GetVideoReceiveStreams()[1];
5391 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5392}
5393
Seth Hampson7c682e02018-05-04 16:28:15 -07005394TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005395 AddSendStream();
5396
Tommi85959932018-02-07 19:26:06 +01005397 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005398 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005399 cricket::VideoFormat capture_format_hd =
5400 capturer.GetSupportedFormats()->front();
5401 EXPECT_EQ(1280, capture_format_hd.width);
5402 EXPECT_EQ(720, capture_format_hd.height);
5403 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5404 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005405 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005406
perkjfa10b552016-10-02 23:45:26 -07005407 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005408 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005409
5410 // TODO(skvlad): Resolve the inconsistency between the interpretation
5411 // of the global bitrate limit for audio and video:
5412 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5413 // max_bandwidth_bps = -1 - remove the bandwidth limit
5414 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005415 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005416
perkjfa10b552016-10-02 23:45:26 -07005417 SetAndExpectMaxBitrate(1000, 0, 1000);
5418 SetAndExpectMaxBitrate(1000, 800, 800);
5419 SetAndExpectMaxBitrate(600, 800, 600);
5420 SetAndExpectMaxBitrate(0, 800, 800);
5421 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005422
Niels Möllerff40b142018-04-09 08:49:14 +02005423 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005424}
5425
eladalonf1841382017-06-12 01:16:46 -07005426TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005427 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005428 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005429 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005430
5431 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005432 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005433 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005434}
5435
eladalonf1841382017-06-12 01:16:46 -07005436TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005437 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005438 FakeVideoSendStream* stream = AddSendStream();
5439
Seth Hampson7c682e02018-05-04 16:28:15 -07005440 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5441 EXPECT_EQ(1UL, parameters.encodings.size());
5442 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5443 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5444
5445 // Note that this is testing the behavior of the FakeVideoSendStream, which
5446 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5447 // we are just testing the behavior of
5448 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005449 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5450 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005451
5452 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5453 // by this amount.
5454 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5455 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5456 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5457 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5458
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005459 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5460 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5461 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5462}
5463
5464TEST_F(WebRtcVideoChannelTest,
5465 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5466 FakeVideoSendStream* stream = AddSendStream();
5467
5468 // Note that this is testing the behavior of the FakeVideoSendStream, which
5469 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5470 // we are just testing the behavior of
5471 // EncoderStreamFactory::CreateEncoderStreams.
5472 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5473 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5474
5475 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5476 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5477 EXPECT_EQ(1UL, parameters.encodings.size());
5478 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5479 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5480
5481 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5482 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5483 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5484}
5485
5486TEST_F(WebRtcVideoChannelTest,
5487 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5488 send_parameters_.max_bandwidth_bps = 99999;
5489 FakeVideoSendStream* stream = AddSendStream();
5490 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5491 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5492 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5493 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5494 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5495 stream->GetVideoStreams()[0].max_bitrate_bps);
5496
5497 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5498 // adjusted down.
5499 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5500 EXPECT_EQ(1UL, parameters.encodings.size());
5501 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5502 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5503 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5504 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5505 stream->GetVideoStreams()[0].min_bitrate_bps);
5506 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5507 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005508}
5509
Åsa Persson8c1bf952018-09-13 10:42:19 +02005510TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5511 FakeVideoSendStream* stream = AddSendStream();
5512
5513 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5514 EXPECT_EQ(1UL, parameters.encodings.size());
5515 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5516 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5517
5518 // Note that this is testing the behavior of the FakeVideoSendStream, which
5519 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5520 // we are just testing the behavior of
5521 // EncoderStreamFactory::CreateEncoderStreams.
5522 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5523 EXPECT_EQ(kDefaultVideoMaxFramerate,
5524 stream->GetVideoStreams()[0].max_framerate);
5525
5526 // Set max framerate and check that VideoStream.max_framerate is set.
5527 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5528 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5529 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5530 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5531
5532 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5533 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5534}
5535
Åsa Persson23eba222018-10-02 14:47:06 +02005536TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5537 FakeVideoSendStream* stream = AddSendStream();
5538
5539 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5540 EXPECT_EQ(1UL, parameters.encodings.size());
5541 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5542 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5543
5544 // Note that this is testing the behavior of the FakeVideoSendStream, which
5545 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5546 // we are just testing the behavior of
5547 // EncoderStreamFactory::CreateEncoderStreams.
5548 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5549 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5550
5551 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5552 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5553 parameters.encodings[0].num_temporal_layers = 2;
5554 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5555
5556 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5557 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5558}
5559
Seth Hampson7c682e02018-05-04 16:28:15 -07005560TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005561 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005562 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005563 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005564 // Two or more encodings should result in failure.
5565 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005566 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005567 // Zero encodings should also fail.
5568 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005569 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005570}
5571
Zach Stein3ca452b2018-01-18 10:01:24 -08005572TEST_F(WebRtcVideoChannelTest,
5573 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5574 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5575 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5576 AddSendStream(sp);
5577
5578 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5579
5580 // Additional encodings should result in failure.
5581 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005582 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005583 // Zero encodings should also fail.
5584 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005585 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005586}
5587
deadbeeffb2aced2017-01-06 23:05:37 -08005588// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005589TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005590 AddSendStream();
5591 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005592 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005593 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005594}
5595
Seth Hampson24722b32017-12-22 09:36:42 -08005596// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5597// a value <= 0, setting the parameters returns false.
5598TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5599 AddSendStream();
5600 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5601 EXPECT_EQ(1UL, parameters.encodings.size());
5602 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5603 parameters.encodings[0].bitrate_priority);
5604
5605 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005606 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005607 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005608 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005609}
5610
5611// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5612// properly on the VideoChannel and propogates down to the video encoder.
5613TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5614 AddSendStream();
5615 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5616 EXPECT_EQ(1UL, parameters.encodings.size());
5617 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5618 parameters.encodings[0].bitrate_priority);
5619
5620 // Change the value and set it on the VideoChannel.
5621 double new_bitrate_priority = 2.0;
5622 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005623 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005624
5625 // Verify that the encoding parameters bitrate_priority is set for the
5626 // VideoChannel.
5627 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5628 EXPECT_EQ(1UL, parameters.encodings.size());
5629 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5630
5631 // Verify that the new value propagated down to the encoder.
5632 std::vector<FakeVideoSendStream*> video_send_streams =
5633 fake_call_->GetVideoSendStreams();
5634 EXPECT_EQ(1UL, video_send_streams.size());
5635 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5636 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5637 // appropriately.
5638 EXPECT_EQ(new_bitrate_priority,
5639 video_send_stream->GetEncoderConfig().bitrate_priority);
5640 // Check that the vector of VideoStreams also was propagated correctly. Note
5641 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5642 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005643 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005644 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5645}
5646
5647// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5648// VideoChannel and the value propogates to the video encoder with all simulcast
5649// streams.
5650TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5651 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005652 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005653 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5654 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5655 AddSendStream(stream_params);
5656 uint32_t primary_ssrc = stream_params.first_ssrc();
5657
Tommi85959932018-02-07 19:26:06 +01005658 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5659 // frame. This creates multiple VideoStreams for all simulcast layers when
5660 // reconfiguring, and allows us to test this behavior.
5661 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005662 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005663 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005664 EXPECT_EQ(cricket::CS_RUNNING,
5665 capturer.Start(cricket::VideoFormat(
5666 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5667 cricket::FOURCC_I420)));
5668 channel_->SetSend(true);
5669 EXPECT_TRUE(capturer.CaptureFrame());
5670 // Get and set the rtp encoding parameters.
5671 webrtc::RtpParameters parameters =
5672 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005673 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005674 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5675 parameters.encodings[0].bitrate_priority);
5676 // Change the value and set it on the VideoChannel.
5677 double new_bitrate_priority = 2.0;
5678 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005679 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005680
5681 // Verify that the encoding parameters priority is set on the VideoChannel.
5682 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005683 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005684 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5685
5686 // Verify that the new value propagated down to the encoder.
5687 std::vector<FakeVideoSendStream*> video_send_streams =
5688 fake_call_->GetVideoSendStreams();
5689 EXPECT_EQ(1UL, video_send_streams.size());
5690 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5691 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5692 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005693 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005694 video_send_stream->GetEncoderConfig().number_of_streams);
5695 EXPECT_EQ(new_bitrate_priority,
5696 video_send_stream->GetEncoderConfig().bitrate_priority);
5697 // Check that the vector of VideoStreams also propagated correctly. The
5698 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5699 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005700 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005701 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005702 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5703 // Since we are only setting bitrate priority per-sender, the other
5704 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005705 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005706 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005707 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005708 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005709 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005710}
5711
Tim Haloun648d28a2018-10-18 16:52:22 -07005712// RTCRtpEncodingParameters.network_priority must be one of a few values
5713// derived from the default priority, corresponding to very-low, low, medium,
5714// or high.
5715TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5716 AddSendStream();
5717 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5718 EXPECT_EQ(1UL, parameters.encodings.size());
5719 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5720 parameters.encodings[0].network_priority);
5721
5722 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5723 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5724 for (auto it : good_values) {
5725 parameters.encodings[0].network_priority = it;
5726 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5727 }
5728 for (auto it : bad_values) {
5729 parameters.encodings[0].network_priority = it;
5730 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5731 }
5732}
5733
Åsa Persson8c1bf952018-09-13 10:42:19 +02005734TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5735 const size_t kNumSimulcastStreams = 3;
5736 SetUpSimulcast(true, false);
5737
5738 // Get and set the rtp encoding parameters.
5739 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5740 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5741 for (const auto& encoding : parameters.encodings) {
5742 EXPECT_FALSE(encoding.max_framerate);
5743 }
5744
5745 // Change the value and set it on the VideoChannel.
5746 parameters.encodings[0].max_framerate = 10;
5747 parameters.encodings[1].max_framerate = 20;
5748 parameters.encodings[2].max_framerate = 25;
5749 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5750
5751 // Verify that the bitrates are set on the VideoChannel.
5752 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5753 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5754 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5755 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5756 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5757}
5758
Åsa Persson23eba222018-10-02 14:47:06 +02005759TEST_F(WebRtcVideoChannelTest,
5760 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5761 const size_t kNumSimulcastStreams = 3;
5762 SetUpSimulcast(true, false);
5763
5764 // Get and set the rtp encoding parameters.
5765 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5766 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5767
5768 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5769 parameters.encodings[0].num_temporal_layers = 0;
5770 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5771 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5772 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5773 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5774 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5775}
5776
5777TEST_F(WebRtcVideoChannelTest,
5778 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5779 const size_t kNumSimulcastStreams = 3;
5780 SetUpSimulcast(true, false);
5781
5782 // Get and set the rtp encoding parameters.
5783 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5784 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5785
5786 // No/all layers should be set.
5787 parameters.encodings[0].num_temporal_layers = 1;
5788 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5789 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5790
5791 // Different values not supported.
5792 parameters.encodings[0].num_temporal_layers = 1;
5793 parameters.encodings[1].num_temporal_layers = 2;
5794 parameters.encodings[2].num_temporal_layers = 2;
5795 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5796 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5797}
5798
5799TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5800 const size_t kNumSimulcastStreams = 3;
5801 SetUpSimulcast(true, false);
5802
5803 // Get and set the rtp encoding parameters.
5804 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5805 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5806 for (const auto& encoding : parameters.encodings)
5807 EXPECT_FALSE(encoding.num_temporal_layers);
5808
5809 // Change the value and set it on the VideoChannel.
5810 parameters.encodings[0].num_temporal_layers = 3;
5811 parameters.encodings[1].num_temporal_layers = 3;
5812 parameters.encodings[2].num_temporal_layers = 3;
5813 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5814
5815 // Verify that the number of temporal layers are set on the VideoChannel.
5816 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5817 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5818 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5819 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5820 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5821}
5822
5823TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5824 const size_t kNumSimulcastStreams = 3;
5825 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5826
5827 // Send a full size frame so all simulcast layers are used when reconfiguring.
5828 FakeVideoCapturerWithTaskQueue capturer;
5829 VideoOptions options;
5830 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5831 EXPECT_EQ(cricket::CS_RUNNING,
5832 capturer.Start(capturer.GetSupportedFormats()->front()));
5833 channel_->SetSend(true);
5834 EXPECT_TRUE(capturer.CaptureFrame());
5835
5836 // Get and set the rtp encoding parameters.
5837 // Change the value and set it on the VideoChannel.
5838 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5839 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5840 parameters.encodings[0].num_temporal_layers = 2;
5841 parameters.encodings[1].num_temporal_layers = 2;
5842 parameters.encodings[2].num_temporal_layers = 2;
5843 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5844
5845 // Verify that the new value is propagated down to the encoder.
5846 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5847 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5848 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5849 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5850 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5851 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5852 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5853 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5854
5855 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5856 // VideoStreams are created appropriately for the simulcast case.
5857 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5858 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5859 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5860 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5861
5862 // No parameter changed, encoder should not be reconfigured.
5863 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5864 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5865
5866 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5867}
5868
5869TEST_F(WebRtcVideoChannelTest,
5870 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5871 const size_t kDefaultNumTemporalLayers = 3;
5872 const size_t kNumSimulcastStreams = 3;
5873 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5874
5875 // Send a full size frame so all simulcast layers are used when reconfiguring.
5876 FakeVideoCapturerWithTaskQueue capturer;
5877 VideoOptions options;
5878 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5879 EXPECT_EQ(cricket::CS_RUNNING,
5880 capturer.Start(capturer.GetSupportedFormats()->front()));
5881 channel_->SetSend(true);
5882 EXPECT_TRUE(capturer.CaptureFrame());
5883
5884 // Change rtp encoding parameters, num_temporal_layers not changed.
5885 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5886 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5887 parameters.encodings[0].min_bitrate_bps = 33000;
5888 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5889
5890 // Verify that no value is propagated down to the encoder.
5891 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5892 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5893 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5894 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5895 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5896 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5897
5898 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5899 // VideoStreams are created appropriately for the simulcast case.
5900 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5901 EXPECT_EQ(kDefaultNumTemporalLayers,
5902 stream->GetVideoStreams()[0].num_temporal_layers);
5903 EXPECT_EQ(kDefaultNumTemporalLayers,
5904 stream->GetVideoStreams()[1].num_temporal_layers);
5905 EXPECT_EQ(kDefaultNumTemporalLayers,
5906 stream->GetVideoStreams()[2].num_temporal_layers);
5907
5908 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5909}
5910
Åsa Persson8c1bf952018-09-13 10:42:19 +02005911TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5912 const size_t kNumSimulcastStreams = 3;
5913 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5914
5915 // Send a full size frame so all simulcast layers are used when reconfiguring.
5916 FakeVideoCapturerWithTaskQueue capturer;
5917 VideoOptions options;
5918 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5919 EXPECT_EQ(cricket::CS_RUNNING,
5920 capturer.Start(capturer.GetSupportedFormats()->front()));
5921 channel_->SetSend(true);
5922 EXPECT_TRUE(capturer.CaptureFrame());
5923
5924 // Get and set the rtp encoding parameters.
5925 // Change the value and set it on the VideoChannel.
5926 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5927 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5928 parameters.encodings[0].max_framerate = 15;
5929 parameters.encodings[1].max_framerate = 25;
5930 parameters.encodings[2].max_framerate = 20;
5931 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5932
5933 // Verify that the new value propagated down to the encoder.
5934 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5935 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5936 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5937 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5938 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5939 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5940 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5941 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5942
5943 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5944 // VideoStreams are created appropriately for the simulcast case.
5945 // Currently the maximum |max_framerate| is used.
5946 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5947 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5948 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5949 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5950
5951 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5952}
5953
5954TEST_F(WebRtcVideoChannelTest,
5955 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5956 const size_t kNumSimulcastStreams = 3;
5957 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5958 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5959
5960 // Send a full size frame so all simulcast layers are used when reconfiguring.
5961 FakeVideoCapturerWithTaskQueue capturer;
5962 VideoOptions options;
5963 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5964 EXPECT_EQ(cricket::CS_RUNNING,
5965 capturer.Start(capturer.GetSupportedFormats()->front()));
5966 channel_->SetSend(true);
5967 EXPECT_TRUE(capturer.CaptureFrame());
5968
5969 // Get and set the rtp encoding parameters.
5970 // Change the value and set it on the VideoChannel.
5971 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5972 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5973 parameters.encodings[0].max_framerate = 15;
5974 parameters.encodings[2].max_framerate = 20;
5975 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5976
5977 // Verify that the new value propagated down to the encoder.
5978 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5979 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5980 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5981 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5982 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5983 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
5984 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5985
5986 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5987 // VideoStreams are created appropriately for the simulcast case.
5988 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
5989 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5990 EXPECT_EQ(kDefaultVideoMaxFramerate,
5991 stream->GetVideoStreams()[0].max_framerate);
5992 EXPECT_EQ(kDefaultVideoMaxFramerate,
5993 stream->GetVideoStreams()[1].max_framerate);
5994 EXPECT_EQ(kDefaultVideoMaxFramerate,
5995 stream->GetVideoStreams()[2].max_framerate);
5996
5997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5998}
5999
Åsa Persson55659812018-06-18 17:51:32 +02006000TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6001 const size_t kNumSimulcastStreams = 3;
6002 SetUpSimulcast(true, false);
6003
6004 // Get and set the rtp encoding parameters.
6005 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6006 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6007 for (const auto& encoding : parameters.encodings) {
6008 EXPECT_FALSE(encoding.min_bitrate_bps);
6009 EXPECT_FALSE(encoding.max_bitrate_bps);
6010 }
6011
6012 // Change the value and set it on the VideoChannel.
6013 parameters.encodings[0].min_bitrate_bps = 100000;
6014 parameters.encodings[0].max_bitrate_bps = 200000;
6015 parameters.encodings[1].min_bitrate_bps = 300000;
6016 parameters.encodings[1].max_bitrate_bps = 400000;
6017 parameters.encodings[2].min_bitrate_bps = 500000;
6018 parameters.encodings[2].max_bitrate_bps = 600000;
6019 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6020
6021 // Verify that the bitrates are set on the VideoChannel.
6022 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6023 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6024 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6025 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6026 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6027 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6028 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6029 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6030}
6031
6032TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6033 const size_t kNumSimulcastStreams = 3;
6034 SetUpSimulcast(true, false);
6035
6036 // Get and set the rtp encoding parameters.
6037 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6038 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6039
6040 // Max bitrate lower than min bitrate should fail.
6041 parameters.encodings[2].min_bitrate_bps = 100000;
6042 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6043 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6044 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6045}
6046
6047// Test that min and max bitrate values set via RtpParameters are correctly
6048// propagated to the underlying encoder, and that the target is set to 3/4 of
6049// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6050// that are used if no min/max are specified).
6051TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6052 const size_t kNumSimulcastStreams = 3;
6053 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6054
6055 // Send a full size frame so all simulcast layers are used when reconfiguring.
6056 FakeVideoCapturerWithTaskQueue capturer;
6057 VideoOptions options;
6058 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6059 EXPECT_EQ(cricket::CS_RUNNING,
6060 capturer.Start(capturer.GetSupportedFormats()->front()));
6061 channel_->SetSend(true);
6062 EXPECT_TRUE(capturer.CaptureFrame());
6063
6064 // Get and set the rtp encoding parameters.
6065 // Change the value and set it on the VideoChannel.
6066 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6067 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6068 parameters.encodings[0].min_bitrate_bps = 100000;
6069 parameters.encodings[0].max_bitrate_bps = 200000;
6070 parameters.encodings[1].min_bitrate_bps = 300000;
6071 parameters.encodings[1].max_bitrate_bps = 400000;
6072 parameters.encodings[2].min_bitrate_bps = 500000;
6073 parameters.encodings[2].max_bitrate_bps = 600000;
6074 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6075
6076 // Verify that the new value propagated down to the encoder.
6077 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6078 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6079 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6080 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6081 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6082 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6083 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6084 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6085 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6086 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6087 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6088
6089 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6090 // VideoStreams are created appropriately for the simulcast case.
6091 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6092 // Target bitrate: 200000 * 3 / 4 = 150000.
6093 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6094 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6095 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6096 // Target bitrate: 400000 * 3 / 4 = 300000.
6097 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6098 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6099 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6100 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6101 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6102 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6103 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6104
6105 // No parameter changed, encoder should not be reconfigured.
6106 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6107 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6108
6109 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6110}
6111
6112// Test to only specify the min or max bitrate value for a layer via
6113// RtpParameters. The unspecified min/max and target value should be set to the
6114// simulcast default that is used if no min/max are specified.
6115TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6116 const size_t kNumSimulcastStreams = 3;
6117 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6118 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6119
6120 // Send a full size frame so all simulcast layers are used when reconfiguring.
6121 FakeVideoCapturerWithTaskQueue capturer;
6122 VideoOptions options;
6123 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6124 EXPECT_EQ(cricket::CS_RUNNING,
6125 capturer.Start(capturer.GetSupportedFormats()->front()));
6126 channel_->SetSend(true);
6127 EXPECT_TRUE(capturer.CaptureFrame());
6128
6129 // Get and set the rtp encoding parameters.
6130 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6131 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6132
6133 // Change the value and set it on the VideoChannel.
6134 // Layer 0: only configure min bitrate.
6135 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6136 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6137 // Layer 1: only configure max bitrate.
6138 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6139 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6140 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6141
6142 // Verify that the new value propagated down to the encoder.
6143 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6144 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6145 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6146 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6147 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6148 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6149 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6150 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6151 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6152 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6153
6154 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6155 // VideoStreams are created appropriately for the simulcast case.
6156 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6157 // Layer 0: min configured bitrate should overwrite min default.
6158 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6159 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6160 stream->GetVideoStreams()[0].target_bitrate_bps);
6161 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6162 stream->GetVideoStreams()[0].max_bitrate_bps);
6163 // Layer 1: max configured bitrate should overwrite max default.
6164 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6165 stream->GetVideoStreams()[1].min_bitrate_bps);
6166 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6167 stream->GetVideoStreams()[1].target_bitrate_bps);
6168 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6169 // Layer 2: min and max bitrate not configured, default expected.
6170 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6171 stream->GetVideoStreams()[2].min_bitrate_bps);
6172 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6173 stream->GetVideoStreams()[2].target_bitrate_bps);
6174 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6175 stream->GetVideoStreams()[2].max_bitrate_bps);
6176
6177 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6178}
6179
6180// Test that specifying the min (or max) bitrate value for a layer via
6181// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6182// unspecified values accordingly.
6183TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6184 const size_t kNumSimulcastStreams = 3;
6185 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6186 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6187
6188 // Send a full size frame so all simulcast layers are used when reconfiguring.
6189 FakeVideoCapturerWithTaskQueue capturer;
6190 VideoOptions options;
6191 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6192 EXPECT_EQ(cricket::CS_RUNNING,
6193 capturer.Start(capturer.GetSupportedFormats()->front()));
6194 channel_->SetSend(true);
6195 EXPECT_TRUE(capturer.CaptureFrame());
6196
6197 // Get and set the rtp encoding parameters.
6198 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6199 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6200
6201 // Change the value and set it on the VideoChannel.
6202 // For layer 0, set the min bitrate above the default max.
6203 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6204 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6205 // For layer 1, set the max bitrate below the default min.
6206 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6207 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6208 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6209
6210 // Verify that the new value propagated down to the encoder.
6211 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6212 // VideoStreams are created appropriately for the simulcast case.
6213 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6214 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6215 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6216 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6217 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6218 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6219 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6220 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6221 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6222 // Layer 2: min and max bitrate not configured, default expected.
6223 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6224 stream->GetVideoStreams()[2].min_bitrate_bps);
6225 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6226 stream->GetVideoStreams()[2].target_bitrate_bps);
6227 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6228 stream->GetVideoStreams()[2].max_bitrate_bps);
6229
6230 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6231}
6232
6233TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6234 const size_t kNumSimulcastStreams = 3;
6235 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6236 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6237
6238 // Send a full size frame so all simulcast layers are used when reconfiguring.
6239 FakeVideoCapturerWithTaskQueue capturer;
6240 VideoOptions options;
6241 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6242 EXPECT_EQ(cricket::CS_RUNNING,
6243 capturer.Start(capturer.GetSupportedFormats()->front()));
6244 channel_->SetSend(true);
6245 EXPECT_TRUE(capturer.CaptureFrame());
6246
6247 // Set max bitrate for all but the highest layer.
6248 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6249 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6250 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6251 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6252 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6253
6254 // Set max bandwidth equal to total max bitrate.
6255 send_parameters_.max_bandwidth_bps =
6256 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6257 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6258 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6259
6260 // No bitrate above the total max to give to the highest layer.
6261 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6262 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6263 stream->GetVideoStreams()[2].max_bitrate_bps);
6264
6265 // Set max bandwidth above the total max bitrate.
6266 send_parameters_.max_bandwidth_bps =
6267 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6268 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6269 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6270
6271 // The highest layer has no max bitrate set -> the bitrate above the total
6272 // max should be given to the highest layer.
6273 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6274 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6275 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6276 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6277 stream->GetVideoStreams()[2].max_bitrate_bps);
6278
6279 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6280}
6281
6282TEST_F(WebRtcVideoChannelTest,
6283 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6284 const size_t kNumSimulcastStreams = 3;
6285 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6286 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6287 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6288
6289 // Send a full size frame so all simulcast layers are used when reconfiguring.
6290 FakeVideoCapturerWithTaskQueue capturer;
6291 VideoOptions options;
6292 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6293 EXPECT_EQ(cricket::CS_RUNNING,
6294 capturer.Start(capturer.GetSupportedFormats()->front()));
6295 channel_->SetSend(true);
6296 EXPECT_TRUE(capturer.CaptureFrame());
6297
6298 // Set max bitrate for the highest layer.
6299 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6300 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6301 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6302 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6303
6304 // Set max bandwidth above the total max bitrate.
6305 send_parameters_.max_bandwidth_bps =
6306 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6307 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6308 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6309
6310 // The highest layer has the max bitrate set -> the bitrate above the total
6311 // max should not be given to the highest layer.
6312 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6313 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6314 stream->GetVideoStreams()[2].max_bitrate_bps);
6315
6316 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6317}
6318
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006319// Test that min and max bitrate values set via RtpParameters are correctly
6320// propagated to the underlying encoder for a single stream.
6321TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6322 FakeVideoSendStream* stream = AddSendStream();
6323 EXPECT_TRUE(channel_->SetSend(true));
6324 EXPECT_TRUE(stream->IsSending());
6325
6326 // Set min and max bitrate.
6327 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6328 EXPECT_EQ(1u, parameters.encodings.size());
6329 parameters.encodings[0].min_bitrate_bps = 80000;
6330 parameters.encodings[0].max_bitrate_bps = 150000;
6331 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6332
6333 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6334 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6335 EXPECT_EQ(1u, encoder_config.number_of_streams);
6336 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6337 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6338 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6339
6340 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6341 // VideoStreams are created appropriately.
6342 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6343 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6344 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6345 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6346}
6347
6348// Test the default min and max bitrate value are correctly propagated to the
6349// underlying encoder for a single stream (when the values are not set via
6350// RtpParameters).
6351TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6352 FakeVideoSendStream* stream = AddSendStream();
6353 EXPECT_TRUE(channel_->SetSend(true));
6354 EXPECT_TRUE(stream->IsSending());
6355
6356 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6357 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6358 EXPECT_EQ(1u, encoder_config.number_of_streams);
6359 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6360 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6361 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6362
6363 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6364 // VideoStreams are created appropriately.
6365 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6366 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6367 stream->GetVideoStreams()[0].min_bitrate_bps);
6368 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6369 stream->GetVideoStreams()[0].min_bitrate_bps);
6370 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6371 stream->GetVideoStreams()[0].target_bitrate_bps);
6372}
6373
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006374// Test that a stream will not be sending if its encoding is made inactive
6375// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006376TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006377 FakeVideoSendStream* stream = AddSendStream();
6378 EXPECT_TRUE(channel_->SetSend(true));
6379 EXPECT_TRUE(stream->IsSending());
6380
6381 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006382 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006383 ASSERT_EQ(1u, parameters.encodings.size());
6384 ASSERT_TRUE(parameters.encodings[0].active);
6385 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006386 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006387 EXPECT_FALSE(stream->IsSending());
6388
6389 // Now change it back to active and verify we resume sending.
6390 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006391 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006392 EXPECT_TRUE(stream->IsSending());
6393}
6394
Seth Hampson8234ead2018-02-02 15:16:24 -08006395// Tests that when active is updated for any simulcast layer then the send
6396// stream's sending state will be updated and it will be reconfigured with the
6397// new appropriate active simulcast streams.
6398TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6399 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006400 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006401 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6402 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6403 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6404 uint32_t primary_ssrc = stream_params.first_ssrc();
6405
Tommi85959932018-02-07 19:26:06 +01006406 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6407 // frame. This allows us to test that ReconfigureEncoder is called
6408 // appropriately.
6409 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006410 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006411 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006412 EXPECT_EQ(cricket::CS_RUNNING,
6413 capturer.Start(cricket::VideoFormat(
6414 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6415 cricket::FOURCC_I420)));
6416 channel_->SetSend(true);
6417 EXPECT_TRUE(capturer.CaptureFrame());
6418
6419 // Check that all encodings are initially active.
6420 webrtc::RtpParameters parameters =
6421 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006422 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006423 EXPECT_TRUE(parameters.encodings[0].active);
6424 EXPECT_TRUE(parameters.encodings[1].active);
6425 EXPECT_TRUE(parameters.encodings[2].active);
6426 EXPECT_TRUE(fake_video_send_stream->IsSending());
6427
6428 // Only turn on only the middle stream.
6429 parameters.encodings[0].active = false;
6430 parameters.encodings[1].active = true;
6431 parameters.encodings[2].active = false;
6432 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6433 // Verify that the active fields are set on the VideoChannel.
6434 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006435 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006436 EXPECT_FALSE(parameters.encodings[0].active);
6437 EXPECT_TRUE(parameters.encodings[1].active);
6438 EXPECT_FALSE(parameters.encodings[2].active);
6439 // Check that the VideoSendStream is updated appropriately. This means its
6440 // send state was updated and it was reconfigured.
6441 EXPECT_TRUE(fake_video_send_stream->IsSending());
6442 std::vector<webrtc::VideoStream> simulcast_streams =
6443 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006444 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006445 EXPECT_FALSE(simulcast_streams[0].active);
6446 EXPECT_TRUE(simulcast_streams[1].active);
6447 EXPECT_FALSE(simulcast_streams[2].active);
6448
6449 // Turn off all streams.
6450 parameters.encodings[0].active = false;
6451 parameters.encodings[1].active = false;
6452 parameters.encodings[2].active = false;
6453 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6454 // Verify that the active fields are set on the VideoChannel.
6455 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006456 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006457 EXPECT_FALSE(parameters.encodings[0].active);
6458 EXPECT_FALSE(parameters.encodings[1].active);
6459 EXPECT_FALSE(parameters.encodings[2].active);
6460 // Check that the VideoSendStream is off.
6461 EXPECT_FALSE(fake_video_send_stream->IsSending());
6462 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006463 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006464 EXPECT_FALSE(simulcast_streams[0].active);
6465 EXPECT_FALSE(simulcast_streams[1].active);
6466 EXPECT_FALSE(simulcast_streams[2].active);
6467
Niels Möllerff40b142018-04-09 08:49:14 +02006468 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006469}
6470
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006471// Test that if a stream is reconfigured (due to a codec change or other
6472// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006473TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006474 InactiveStreamDoesntStartSendingWhenReconfigured) {
6475 // Set an initial codec list, which will be modified later.
6476 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006477 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6478 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006479 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6480
6481 FakeVideoSendStream* stream = AddSendStream();
6482 EXPECT_TRUE(channel_->SetSend(true));
6483 EXPECT_TRUE(stream->IsSending());
6484
6485 // Get current parameters and change "active" to false.
6486 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6487 ASSERT_EQ(1u, parameters.encodings.size());
6488 ASSERT_TRUE(parameters.encodings[0].active);
6489 parameters.encodings[0].active = false;
6490 EXPECT_EQ(1u, GetFakeSendStreams().size());
6491 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006492 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006493 EXPECT_FALSE(stream->IsSending());
6494
6495 // Reorder the codec list, causing the stream to be reconfigured.
6496 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006497 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6498 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006499 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6500 auto new_streams = GetFakeSendStreams();
6501 // Assert that a new underlying stream was created due to the codec change.
6502 // Otherwise, this test isn't testing what it set out to test.
6503 EXPECT_EQ(1u, GetFakeSendStreams().size());
6504 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6505
6506 // Verify that we still are not sending anything, due to the inactive
6507 // encoding.
6508 EXPECT_FALSE(new_streams[0]->IsSending());
6509}
6510
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006511// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006512TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006513 AddSendStream();
6514 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006515 parameters.codecs.push_back(GetEngineCodec("VP8"));
6516 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006517 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6518
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006519 webrtc::RtpParameters rtp_parameters =
6520 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006521 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006522 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6523 rtp_parameters.codecs[0]);
6524 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6525 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006526}
6527
Florent Castellidacec712018-05-24 16:24:21 +02006528// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6529TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6530 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6531 params.cname = "rtcpcname";
6532 AddSendStream(params);
6533
6534 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6535 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6536}
6537
deadbeeffb2aced2017-01-06 23:05:37 -08006538// Test that RtpParameters for send stream has one encoding and it has
6539// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006540TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006541 AddSendStream();
6542
6543 webrtc::RtpParameters rtp_parameters =
6544 channel_->GetRtpSendParameters(last_ssrc_);
6545 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006546 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006547}
6548
Florent Castelliabe301f2018-06-12 18:33:49 +02006549TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6550 AddSendStream();
6551
6552 webrtc::RtpParameters rtp_parameters =
6553 channel_->GetRtpSendParameters(last_ssrc_);
6554 rtp_parameters.header_extensions.emplace_back();
6555
6556 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6557
6558 webrtc::RTCError result =
6559 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6560 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6561}
6562
Florent Castelli87b3c512018-07-18 16:00:28 +02006563TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6564 AddSendStream();
6565
6566 FakeVideoCapturerWithTaskQueue capturer;
6567 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6568
6569 webrtc::RtpParameters rtp_parameters =
6570 channel_->GetRtpSendParameters(last_ssrc_);
6571 EXPECT_EQ(rtp_parameters.degradation_preference,
6572 webrtc::DegradationPreference::BALANCED);
6573 rtp_parameters.degradation_preference =
6574 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6575
6576 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6577
6578 webrtc::RtpParameters updated_rtp_parameters =
6579 channel_->GetRtpSendParameters(last_ssrc_);
6580 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6581 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6582
6583 // Remove the source since it will be destroyed before the channel
6584 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6585}
6586
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006587// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006588TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006589 AddSendStream();
6590 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006591 parameters.codecs.push_back(GetEngineCodec("VP8"));
6592 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006593 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6594
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006595 webrtc::RtpParameters initial_params =
6596 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006597
6598 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006599 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006600
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006601 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6602 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6603}
6604
6605// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006606TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006607 AddRecvStream();
6608 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006609 parameters.codecs.push_back(GetEngineCodec("VP8"));
6610 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006611 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6612
6613 webrtc::RtpParameters rtp_parameters =
6614 channel_->GetRtpReceiveParameters(last_ssrc_);
6615 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006616 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6617 rtp_parameters.codecs[0]);
6618 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6619 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006620}
6621
johan073ece42016-08-26 02:59:47 -07006622#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006623TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006624#else
eladalonf1841382017-06-12 01:16:46 -07006625TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006626#endif
johan3859c892016-08-05 09:19:25 -07006627 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006628 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006629 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006630 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006631 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006632 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006633 parameters.codecs.push_back(kH264sprop2);
6634 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6635
6636 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6637 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6638 webrtc::RtpParameters rtp_parameters =
6639 channel_->GetRtpReceiveParameters(last_ssrc_);
6640 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6641 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6642 ASSERT_EQ(2u, cfg.decoders.size());
6643 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006644 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006645 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006646 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6647 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006648 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006649
6650 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006651 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006652 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006653 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6654 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006655 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006656}
6657
sakal1fd95952016-06-22 00:46:15 -07006658// Test that RtpParameters for receive stream has one encoding and it has
6659// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006660TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006661 AddRecvStream();
6662
6663 webrtc::RtpParameters rtp_parameters =
6664 channel_->GetRtpReceiveParameters(last_ssrc_);
6665 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006666 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006667}
6668
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006669// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006670TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006671 AddRecvStream();
6672 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006673 parameters.codecs.push_back(GetEngineCodec("VP8"));
6674 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006675 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6676
6677 webrtc::RtpParameters initial_params =
6678 channel_->GetRtpReceiveParameters(last_ssrc_);
6679
6680 // We should be able to set the params we just got.
6681 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6682
6683 // ... And this shouldn't change the params returned by
6684 // GetRtpReceiveParameters.
6685 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006686}
6687
deadbeef3bc15102017-04-20 19:25:07 -07006688// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6689// aren't signaled. It should always return an empty "RtpEncodingParameters",
6690// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006691TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006692 // Call necessary methods to configure receiving a default stream as
6693 // soon as it arrives.
6694 cricket::VideoRecvParameters parameters;
6695 parameters.codecs.push_back(GetEngineCodec("VP8"));
6696 parameters.codecs.push_back(GetEngineCodec("VP9"));
6697 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6698
6699 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6700 // stream. Should return nothing.
6701 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6702
6703 // Set a sink for an unsignaled stream.
6704 cricket::FakeVideoRenderer renderer;
6705 // Value of "0" means "unsignaled stream".
6706 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6707
6708 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6709 // in this method means "unsignaled stream".
6710 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6711 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6712 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6713
6714 // Receive VP8 packet.
6715 uint8_t data[kMinRtpPacketLen];
6716 cricket::RtpHeader rtpHeader;
6717 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6718 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6719 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6720 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6721 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006722 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006723
6724 // The |ssrc| member should still be unset.
6725 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6726 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6727 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6728}
6729
eladalonf1841382017-06-12 01:16:46 -07006730void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006731 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006732 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006733
6734 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006735 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006736 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006737 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006738
6739 if (receiver_first) {
6740 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6741 std::vector<FakeVideoReceiveStream*> receive_streams =
6742 fake_call_->GetVideoReceiveStreams();
6743 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006744 // Default local SSRC when we have no sender.
6745 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6746 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006747 }
6748 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6749 if (!receiver_first)
6750 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6751 std::vector<FakeVideoReceiveStream*> receive_streams =
6752 fake_call_->GetVideoReceiveStreams();
6753 ASSERT_EQ(1u, receive_streams.size());
6754 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006755
6756 // Removing first sender should fall back to another (in this case the second)
6757 // local send stream's SSRC.
6758 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6759 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006760 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006761 ASSERT_EQ(1u, receive_streams.size());
6762 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6763
6764 // Removing the last sender should fall back to default local SSRC.
6765 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006766 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006767 ASSERT_EQ(1u, receive_streams.size());
6768 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6769 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006770}
6771
eladalonf1841382017-06-12 01:16:46 -07006772TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006773 TestReceiverLocalSsrcConfiguration(false);
6774}
6775
eladalonf1841382017-06-12 01:16:46 -07006776TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006777 TestReceiverLocalSsrcConfiguration(true);
6778}
6779
eladalonf1841382017-06-12 01:16:46 -07006780class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006781 public:
eladalonf1841382017-06-12 01:16:46 -07006782 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006783 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006784 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6785 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006786 mock_rate_allocator_factory_(
6787 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006788 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006789 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006790 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006791 decoder_factory_),
6792 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6793 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006794 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006795
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006796 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006797 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01006798 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
6799 VideoOptions(),
6800 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006801 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006802 last_ssrc_ = 123;
6803 }
6804
6805 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006806 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006807 int capture_width,
6808 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006809 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006810 size_t expected_num_streams,
6811 bool screenshare,
6812 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006813 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006814 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006815 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006816 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006817
Peter Boström0c4e06b2015-10-07 12:23:21 +02006818 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006819 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006820 ssrcs.resize(num_configured_streams);
6821
sprangf24a0642017-02-28 13:23:26 -08006822 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006823 // Send a full-size frame to trigger a stream reconfiguration to use all
6824 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006825 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006826 VideoOptions options;
6827 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006828 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006829 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006830 // Fetch the latest stream since SetVideoSend() may recreate it if the
6831 // screen content setting is changed.
6832 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006833 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006834 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006835 cricket::VideoFormat::FpsToInterval(30),
6836 cricket::FOURCC_I420)));
6837 channel_->SetSend(true);
6838 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006839
Zach Stein3ca452b2018-01-18 10:01:24 -08006840 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6841 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6842
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006843 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6844 ASSERT_EQ(expected_num_streams, video_streams.size());
6845
sprang429600d2017-01-26 06:12:26 -08006846 std::vector<webrtc::VideoStream> expected_streams;
6847 if (conference_mode) {
6848 expected_streams = GetSimulcastConfig(
6849 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006850 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006851 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006852 if (screenshare) {
6853 for (const webrtc::VideoStream& stream : expected_streams) {
6854 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006855 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6856 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006857 }
6858 }
sprang429600d2017-01-26 06:12:26 -08006859 } else {
6860 webrtc::VideoStream stream;
6861 stream.width = capture_width;
6862 stream.height = capture_height;
6863 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006864 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006865 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006866 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006867 stream.max_qp = kDefaultQpMax;
6868 expected_streams.push_back(stream);
6869 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006870
6871 ASSERT_EQ(expected_streams.size(), video_streams.size());
6872
6873 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006874 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006875 for (size_t i = 0; i < num_streams; ++i) {
6876 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6877 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6878
6879 EXPECT_GT(video_streams[i].max_framerate, 0);
6880 EXPECT_EQ(expected_streams[i].max_framerate,
6881 video_streams[i].max_framerate);
6882
6883 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6884 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6885 video_streams[i].min_bitrate_bps);
6886
6887 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6888 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6889 video_streams[i].target_bitrate_bps);
6890
6891 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6892 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6893 video_streams[i].max_bitrate_bps);
6894
6895 EXPECT_GT(video_streams[i].max_qp, 0);
6896 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6897
Sergey Silkina796a7e2018-03-01 15:11:29 +01006898 EXPECT_EQ(conference_mode,
6899 expected_streams[i].num_temporal_layers.has_value());
6900
6901 if (conference_mode) {
6902 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6903 video_streams[i].num_temporal_layers);
6904 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006905
6906 if (i == num_streams - 1) {
6907 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6908 } else {
6909 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6910 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006911 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006912
Niels Möllerff40b142018-04-09 08:49:14 +02006913 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006914 }
6915
6916 FakeVideoSendStream* AddSendStream() {
6917 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6918 }
6919
6920 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006921 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006922 EXPECT_TRUE(channel_->AddSendStream(sp));
6923 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006924 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006925 EXPECT_EQ(num_streams + 1, streams.size());
6926 return streams[streams.size() - 1];
6927 }
6928
6929 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006930 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006931 }
6932
6933 FakeVideoReceiveStream* AddRecvStream() {
6934 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6935 }
6936
6937 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006938 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006939 EXPECT_TRUE(channel_->AddRecvStream(sp));
6940 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006941 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006942 EXPECT_EQ(num_streams + 1, streams.size());
6943 return streams[streams.size() - 1];
6944 }
6945
skvlad11a9cbf2016-10-07 11:53:05 -07006946 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006947 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006948 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6949 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006950 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07006951 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006952 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006953 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006954};
6955
eladalonf1841382017-06-12 01:16:46 -07006956TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006957 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6958 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006959}
6960
eladalonf1841382017-06-12 01:16:46 -07006961TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006962 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6963 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006964}
6965
6966// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006967TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006968 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6969 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006970}
sprang429600d2017-01-26 06:12:26 -08006971
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006972TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006973 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6974 false);
6975}
6976
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006977TEST_F(WebRtcVideoChannelSimulcastTest,
6978 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01006979 webrtc::test::ScopedFieldTrials field_trials(
6980 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006981 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6982 true);
6983}
6984
eladalonf1841382017-06-12 01:16:46 -07006985TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08006986 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
6987 true);
6988}
6989
eladalonf1841382017-06-12 01:16:46 -07006990TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07006991 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07006992 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6993 false);
6994}
6995
Yves Gereyb6a89422018-10-08 10:08:32 +02006996class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006997 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02006998 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02006999 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7000 }
7001 rtc::ScopedFakeClock fake_clock_;
7002};
7003
Yves Gereyb6a89422018-10-08 10:08:32 +02007004// The fake clock needs to be initialized before the call, and not
7005// destroyed until after all threads spawned by the test have been stopped.
7006// This mixin ensures that.
7007class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7008 public WebRtcVideoChannelBaseTest {};
7009
Jonas Oreland49ac5952018-09-26 16:04:32 +02007010TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7011 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7012 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7013
7014 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7015
7016 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7017 rtc::SetBE32(packet1.data() + 8, kSsrc);
7018 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7019 EXPECT_TRUE(SetDefaultCodec());
7020 EXPECT_TRUE(SetSend(true));
7021 EXPECT_EQ(0, renderer_.num_rendered_frames());
7022 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7023
7024 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7025 EXPECT_EQ(1u, sources.size());
7026 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7027 int64_t timestamp1 = sources[0].timestamp_ms();
7028
7029 // a new packet.
7030 int64_t timeDeltaMs = 1;
7031 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7032 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7033 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7034 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7035
7036 // It only keeps 10s of history.
7037 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7038 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7039 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7040}
7041
7042TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7043 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7044 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7045
7046 uint32_t kCsrc = 4321u;
7047 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7048 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7049
7050 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7051 rtc::SetBE32(packet1.data() + 8, kSsrc);
7052 rtc::SetBE32(packet1.data() + 12, kCsrc);
7053 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7054 EXPECT_TRUE(SetDefaultCodec());
7055 EXPECT_TRUE(SetSend(true));
7056 EXPECT_EQ(0, renderer_.num_rendered_frames());
7057 channel_->OnPacketReceived(&packet1, rtc::PacketTime());
7058
7059 {
7060 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7061 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7062 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7063 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7064 // 1 SSRC and 1 CSRC.
7065 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7066 [](const webrtc::RtpSource& source) {
7067 return source.source_type() ==
7068 webrtc::RtpSourceType::SSRC;
7069 }));
7070 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7071 [](const webrtc::RtpSource& source) {
7072 return source.source_type() ==
7073 webrtc::RtpSourceType::CSRC;
7074 }));
7075 }
7076 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7077
7078 // a new packet with only ssrc (i.e no csrc).
7079 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7080 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7081 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7082 rtc::SetBE32(packet2.data() + 8, kSsrc);
7083
7084 int64_t timeDeltaMs = 1;
7085 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
7086 channel_->OnPacketReceived(&packet2, rtc::PacketTime());
7087
7088 {
7089 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7090 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7091 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7092 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7093 // 1 SSRC and 1 CSRC.
7094 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7095 [](const webrtc::RtpSource& source) {
7096 return source.source_type() ==
7097 webrtc::RtpSourceType::SSRC;
7098 }));
7099 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7100 [](const webrtc::RtpSource& source) {
7101 return source.source_type() ==
7102 webrtc::RtpSourceType::CSRC;
7103 }));
7104 auto ssrcSource = std::find_if(
7105 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7106 return source.source_type() == webrtc::RtpSourceType::SSRC;
7107 });
7108 auto csrcSource = std::find_if(
7109 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7110 return source.source_type() == webrtc::RtpSourceType::CSRC;
7111 });
7112
7113 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7114 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7115 }
7116
7117 // It only keeps 10s of history.
7118 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7119
7120 {
7121 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7122 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7123 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7124 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7125 [](const webrtc::RtpSource& source) {
7126 return source.source_type() ==
7127 webrtc::RtpSourceType::SSRC;
7128 }));
7129 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7130 [](const webrtc::RtpSource& source) {
7131 return source.source_type() ==
7132 webrtc::RtpSourceType::CSRC;
7133 }));
7134 }
7135
7136 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7137 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7138 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7139}
7140
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007141} // namespace cricket