blob: 482da39fb4fcfb5fddb9a0ce179d1358bb09dae5 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070013#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000014#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000015
Steve Anton2c9ebef2019-01-28 17:27:58 -080016#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010017#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020018#include "absl/strings/match.h"
Steve Anton10542f22019-01-11 09:11:00 -080019#include "api/rtp_parameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080020#include "api/test/mock_video_bitrate_allocator.h"
21#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070022#include "api/test/mock_video_decoder_factory.h"
23#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020024#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080025#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010026#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020027#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020028#include "api/video_codecs/builtin_video_decoder_factory.h"
29#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020030#include "api/video_codecs/sdp_video_format.h"
31#include "api/video_codecs/video_decoder_factory.h"
32#include "api/video_codecs/video_encoder.h"
33#include "api/video_codecs/video_encoder_factory.h"
34#include "call/flexfec_receive_stream.h"
35#include "common_video/h264/profile_level_id.h"
36#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010037#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080038#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080039#include "media/base/fake_video_renderer.h"
40#include "media/base/media_constants.h"
41#include "media/base/rtp_utils.h"
42#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020043#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/engine/fake_webrtc_call.h"
45#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080047#include "media/engine/webrtc_video_engine.h"
48#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020049#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080051#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020053#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080054#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010056#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000058
Niels Möller805a27e2019-01-21 12:21:27 +010059using testing::Field;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010060using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070061using webrtc::RtpExtension;
62
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000063namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000064static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000065
noahricd10a68e2015-07-10 11:27:55 -070066static const uint8_t kRedRtxPayloadType = 125;
67
Niels Möller6557d0c2018-04-11 15:18:34 +020068static const uint32_t kTimeout = 5000U;
69static const uint32_t kDefaultReceiveSsrc = 0;
70static const uint32_t kSsrc = 1234u;
71static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
72static const int kVideoWidth = 640;
73static const int kVideoHeight = 360;
74static const int kFramerate = 30;
75
Peter Boström0c4e06b2015-10-07 12:23:21 +020076static const uint32_t kSsrcs1[] = {1};
77static const uint32_t kSsrcs3[] = {1, 2, 3};
78static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080079static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020080static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080081static const uint32_t kDefaultRecvSsrc = 0;
82
pbos@webrtc.org3c107582014-07-20 15:27:35 +000083static const char kUnsupportedExtensionName[] =
84 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000085
magjed509e4fe2016-11-18 01:34:11 -080086cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
87 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020088 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080089}
90
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000091void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
92 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
93 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
94 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
95 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
96 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
97 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
98 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080099 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
100 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000101 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
102}
103
magjed725e4842016-11-16 00:48:13 -0800104// Return true if any codec in |codecs| is an RTX codec with associated payload
105// type |payload_type|.
106bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
107 int payload_type) {
108 for (const cricket::VideoCodec& codec : codecs) {
109 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200110 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800111 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
112 &associated_payload_type) &&
113 associated_payload_type == payload_type) {
114 return true;
115 }
116 }
117 return false;
118}
119
nisseca5706d2017-09-11 02:32:16 -0700120// TODO(nisse): Duplicated in call.cc.
121const int* FindKeyByValue(const std::map<int, int>& m, int v) {
122 for (const auto& kv : m) {
123 if (kv.second == v)
124 return &kv.first;
125 }
126 return nullptr;
127}
128
Yves Gerey665174f2018-06-19 15:03:05 +0200129bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
130 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700131 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
132 payload_type) != nullptr;
133}
134
135// Check that there's an Rtx payload type for each decoder.
136bool VerifyRtxReceiveAssociations(
137 const webrtc::VideoReceiveStream::Config& config) {
138 for (const auto& decoder : config.decoders) {
139 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
140 return false;
141 }
142 return true;
143}
144
brandtrffc61182016-11-28 06:02:22 -0800145rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700146 int width,
147 int height) {
148 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
149 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800150 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700151 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000152}
153
Shao Changbine62202f2015-04-21 20:24:50 +0800154void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
155 const std::map<int, int>& rtx_types) {
156 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200157 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800158 EXPECT_TRUE(it != rtx_types.end() &&
159 it->second == config.rtp.rtx.payload_type);
160
brandtrb5f2c3f2016-10-04 23:28:39 -0700161 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
162 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800163 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700164 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800165 }
166}
kthelgason2bc68642017-02-07 07:02:22 -0800167
168cricket::MediaConfig GetMediaConfig() {
169 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100170 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800171 return media_config;
172}
nisse26e3abb2017-08-25 04:44:25 -0700173
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200174// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
175int GetMaxDefaultBitrateBps(size_t width, size_t height) {
176 if (width * height <= 320 * 240) {
177 return 600000;
178 } else if (width * height <= 640 * 480) {
179 return 1700000;
180 } else if (width * height <= 960 * 540) {
181 return 2000000;
182 } else {
183 return 2500000;
184 }
185}
186
Niels Möller731a2c22018-07-30 15:08:07 +0200187class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
188 public:
189 MOCK_METHOD2(AddOrUpdateSink,
190 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
191 const rtc::VideoSinkWants& wants));
192 MOCK_METHOD1(RemoveSink,
193 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
194};
195
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000196} // namespace
197
Yves Gerey665174f2018-06-19 15:03:05 +0200198#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200200 EXPECT_EQ((w), renderer_.width()); \
201 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200202 EXPECT_EQ(0, renderer_.errors());
203
Yves Gerey665174f2018-06-19 15:03:05 +0200204#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200205 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200206 EXPECT_EQ((w), (r).width()); \
207 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200208 EXPECT_EQ(0, (r).errors());
209
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000210namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700211class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000212 public:
eladalonf1841382017-06-12 01:16:46 -0700213 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
214 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700215 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700216 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200217 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
218 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200219 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200220 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200221 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800222 decoder_factory_),
223 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200224 // Ensure fake clock doesn't return 0, which will cause some initializations
225 // fail inside RTP senders.
226 fake_clock_.AdvanceTimeMicros(1);
227 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000228
229 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200230 void AssignDefaultAptRtxTypes();
231 void AssignDefaultCodec();
232
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100233 // Find the index of the codec in the engine with the given name. The codec
234 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100235 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100236
magjed509e4fe2016-11-18 01:34:11 -0800237 // Find the codec in the engine with the given name. The codec must be
238 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100239 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800240
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200241 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000242
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200243 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000244 const std::vector<VideoCodec>& codecs);
245
Elad Alon157540a2019-02-08 23:37:52 +0100246 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100247
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200248 // Has to be the first one, so it is initialized before the call or there is a
249 // race condition in the clock access.
250 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700251 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700252 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700253 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000254 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800255 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200256 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
257 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700258 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000259 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800260 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000261};
262
eladalonf1841382017-06-12 01:16:46 -0700263TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200264 encoder_factory_->AddSupportedVideoCodecType("VP8");
265 AssignDefaultCodec();
266
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000267 std::vector<VideoCodec> engine_codecs = engine_.codecs();
268 for (size_t i = 0; i < engine_codecs.size(); ++i) {
269 if (engine_codecs[i].name != kRtxCodecName)
270 continue;
271 int associated_payload_type;
272 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000273 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000274 EXPECT_EQ(default_codec_.id, associated_payload_type);
275 return;
276 }
277 FAIL() << "No RTX codec found among default codecs.";
278}
279
eladalonf1841382017-06-12 01:16:46 -0700280TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100281 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000282}
283
eladalonf1841382017-06-12 01:16:46 -0700284TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100285 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000286}
287
eladalonf1841382017-06-12 01:16:46 -0700288TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100289 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700290}
291
eladalonf1841382017-06-12 01:16:46 -0700292TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100293 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
294}
295
296TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
297 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
298}
299
300TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
301 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
302}
303
304TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
305 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
306}
307
308TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
309 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100310}
311
312TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100313 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
314}
315
316TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor) {
317 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700318}
319
philipel1e054862018-10-08 16:13:53 +0200320class WebRtcVideoEngineTestWithGenericDescriptor
321 : public WebRtcVideoEngineTest {
322 public:
323 WebRtcVideoEngineTestWithGenericDescriptor()
324 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
325};
326
327TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
Elad Alon157540a2019-02-08 23:37:52 +0100328 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri, true);
philipel1e054862018-10-08 16:13:53 +0200329}
330
eladalonf1841382017-06-12 01:16:46 -0700331TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200332 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700333 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200334 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700335
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200336 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700337
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200338 std::unique_ptr<VideoMediaChannel> channel(
339 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700340 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
341
342 // Add CVO extension.
343 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800344 cricket::VideoSendParameters parameters;
345 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200346 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700347 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200348 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700349
Niels Möller731a2c22018-07-30 15:08:07 +0200350 EXPECT_CALL(
351 video_source,
352 AddOrUpdateSink(testing::_,
353 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700354 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200355 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700356
357 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200358 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359
360 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200361 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200362 EXPECT_CALL(
363 video_source,
364 AddOrUpdateSink(testing::_,
365 Field(&rtc::VideoSinkWants::rotation_applied, true)));
366
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200367 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700368}
369
eladalonf1841382017-06-12 01:16:46 -0700370TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200371 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800372 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200373 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800374
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200375 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800376
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200377 std::unique_ptr<VideoMediaChannel> channel(
378 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800379 // Add CVO extension.
380 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800381 cricket::VideoSendParameters parameters;
382 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800383 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700384 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800385 EXPECT_TRUE(channel->SetSendParameters(parameters));
386 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
387
Niels Möller731a2c22018-07-30 15:08:07 +0200388 // Set source.
389 EXPECT_CALL(
390 video_source,
391 AddOrUpdateSink(testing::_,
392 Field(&rtc::VideoSinkWants::rotation_applied, false)));
393 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800394}
395
eladalonf1841382017-06-12 01:16:46 -0700396TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200397 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700398
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200399 encoder_factory_->AddSupportedVideoCodecType("VP8");
400 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700401
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200402 std::unique_ptr<VideoMediaChannel> channel(
403 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700404 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
405
406 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200407 EXPECT_CALL(
408 video_source,
409 AddOrUpdateSink(testing::_,
410 Field(&rtc::VideoSinkWants::rotation_applied, true)));
411 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700412
perkjcaafdba2016-03-20 07:34:29 -0700413 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200414 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700415
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700416 // Add CVO extension.
417 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800418 cricket::VideoSendParameters parameters;
419 parameters.codecs.push_back(GetEngineCodec("VP8"));
420 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200421 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700422 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700423 // Also remove the first codec to trigger a codec change as well.
424 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200425 EXPECT_CALL(
426 video_source,
427 AddOrUpdateSink(testing::_,
428 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200429 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700430
431 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200432 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700433
434 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200435 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200436 EXPECT_CALL(
437 video_source,
438 AddOrUpdateSink(testing::_,
439 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200440 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700441}
442
eladalonf1841382017-06-12 01:16:46 -0700443TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200444 encoder_factory_->AddSupportedVideoCodecType("VP8");
445
Sebastian Jansson84848f22018-11-16 10:40:36 +0100446 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700447 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000448
449 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
450
451 EXPECT_FALSE(channel->SetSend(true))
452 << "Channel should not start without codecs.";
453 EXPECT_TRUE(channel->SetSend(false))
454 << "Channel should be stoppable even without set codecs.";
455}
456
eladalonf1841382017-06-12 01:16:46 -0700457TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200458 encoder_factory_->AddSupportedVideoCodecType("VP8");
459
Sebastian Jansson84848f22018-11-16 10:40:36 +0100460 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700461 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000462 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
463 VideoMediaInfo info;
464 channel->GetStats(&info);
465}
466
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200467TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200468 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000469
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200470 std::unique_ptr<VideoMediaChannel> channel(
471 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800472 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000473
474 EXPECT_TRUE(
475 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200476 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000477 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100478 webrtc::test::FrameForwarder frame_forwarder;
479 cricket::FakeFrameSource frame_source(1280, 720,
480 rtc::kNumMicrosecsPerSec / 30);
481 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
482 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100483 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200484 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
485 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000486 kTimeout);
487
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200488 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100489 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000490
491 // Setting codecs of the same type should not reallocate any encoders
492 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800493 cricket::VideoSendParameters parameters;
494 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200495 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200496 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000497
498 // Remove stream previously added to free the external encoder instance.
499 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200500 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000501}
502
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200503// Test that when an encoder factory supports H264, we add an RTX
504// codec for it.
505// TODO(deadbeef): This test should be updated if/when we start
506// adding RTX codecs for unrecognized codec names.
507TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800508 using webrtc::H264::ProfileLevelIdToString;
509 using webrtc::H264::ProfileLevelId;
510 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200511 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
512 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800513 *ProfileLevelIdToString(
514 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200515 webrtc::SdpVideoFormat h264_constrained_high("H264");
516 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800517 *ProfileLevelIdToString(
518 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200519 webrtc::SdpVideoFormat h264_high("H264");
520 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800521 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
522
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200523 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
524 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
525 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700526
magjed725e4842016-11-16 00:48:13 -0800527 // First figure out what payload types the test codecs got assigned.
528 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800529 // Now search for RTX codecs for them. Expect that they all have associated
530 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800531 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200532 codecs,
533 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
534 ->id));
magjed725e4842016-11-16 00:48:13 -0800535 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200536 codecs,
537 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
538 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800539 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200540 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700541}
542
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100543#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700544TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200545 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100546
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200547 std::unique_ptr<VideoMediaChannel> channel(
548 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100549
550 EXPECT_TRUE(
551 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
552}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100553#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100554
eladalonf1841382017-06-12 01:16:46 -0700555TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200556 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100557 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200558 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200559 std::unique_ptr<VideoMediaChannel> channel(
560 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700561
562 EXPECT_TRUE(
563 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
564
Niels Möllerd0f0f682019-01-14 09:09:53 +0100565 webrtc::test::FrameForwarder frame_forwarder;
566 cricket::FakeFrameSource frame_source(1280, 720,
567 rtc::kNumMicrosecsPerSec / 60);
568 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700569 channel->SetSend(true);
570
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200571 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700572
Niels Möllerd0f0f682019-01-14 09:09:53 +0100573 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700574 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700575 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100576 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700577 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700578 int64_t interval = timestamp - last_timestamp;
579
580 // Precision changes from nanosecond to millisecond.
581 // Allow error to be no more than 1.
582 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
583
584 last_timestamp = timestamp;
585 }
586
Niels Möllerd0f0f682019-01-14 09:09:53 +0100587 frame_forwarder.IncomingCapturedFrame(
588 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
589 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700590 last_timestamp = stream->GetLastTimestamp();
591 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100592 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
593 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
594 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700595 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700596 int64_t interval = timestamp - last_timestamp;
597
598 // Precision changes from nanosecond to millisecond.
599 // Allow error to be no more than 1.
600 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
601
602 last_timestamp = timestamp;
603 }
604
605 // Remove stream previously added to free the external encoder instance.
606 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
607}
608
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200609void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
610 std::vector<VideoCodec> engine_codecs = engine_.codecs();
611 RTC_DCHECK(!engine_codecs.empty());
612 for (const cricket::VideoCodec& codec : engine_codecs) {
613 if (codec.name == "rtx") {
614 int associated_payload_type;
615 if (codec.GetParam(kCodecParamAssociatedPayloadType,
616 &associated_payload_type)) {
617 default_apt_rtx_types_[associated_payload_type] = codec.id;
618 }
619 }
620 }
621}
622
623void WebRtcVideoEngineTest::AssignDefaultCodec() {
624 std::vector<VideoCodec> engine_codecs = engine_.codecs();
625 RTC_DCHECK(!engine_codecs.empty());
626 bool codec_set = false;
627 for (const cricket::VideoCodec& codec : engine_codecs) {
628 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
629 codec.name != "ulpfec") {
630 default_codec_ = codec;
631 codec_set = true;
632 }
633 }
634
635 RTC_DCHECK(codec_set);
636}
637
Oleh Prypina40f8242017-12-21 13:32:23 +0100638size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
639 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100640 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
641 for (size_t i = 0; i < codecs.size(); ++i) {
642 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200643 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200644 continue;
645 // The tests only use H264 Constrained Baseline. Make sure we don't return
646 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200647 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200648 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200649 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
650 if (profile_level_id->profile !=
651 webrtc::H264::kProfileConstrainedBaseline) {
652 continue;
653 }
654 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100655 return i;
magjed509e4fe2016-11-18 01:34:11 -0800656 }
657 // This point should never be reached.
658 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100659 return -1;
660}
661
662cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
663 const std::string& name) const {
664 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800665}
666
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200667VideoMediaChannel*
668WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100669 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700670 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200671 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800672 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200673 for (const webrtc::SdpVideoFormat& format :
674 encoder_factory_->GetSupportedFormats()) {
675 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800676 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200677 parameters.codecs.push_back(engine_codec);
678 }
679 }
magjed509e4fe2016-11-18 01:34:11 -0800680
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200681 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000682
683 return channel;
684}
685
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200686VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000687 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100688 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700689 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200690 cricket::VideoRecvParameters parameters;
691 parameters.codecs = codecs;
692 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000693
694 return channel;
695}
696
Elad Alon157540a2019-02-08 23:37:52 +0100697void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
698 bool supported) const {
699 const RtpCapabilities capabilities = engine_.GetCapabilities();
700 if (supported) {
701 EXPECT_THAT(capabilities.header_extensions,
702 testing::Contains(testing::Field(&RtpExtension::uri, uri)));
703 } else {
704 EXPECT_THAT(
705 capabilities.header_extensions,
706 testing::Each(testing::Field(&RtpExtension::uri, testing::StrNe(uri))));
707 }
708}
709
eladalonf1841382017-06-12 01:16:46 -0700710TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200711 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000712
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200713 std::unique_ptr<VideoMediaChannel> channel(
714 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000715
Peter Boström0c4e06b2015-10-07 12:23:21 +0200716 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000717
Yves Gerey665174f2018-06-19 15:03:05 +0200718 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000719 EXPECT_TRUE(channel->SetSend(true));
720
Niels Möller805a27e2019-01-21 12:21:27 +0100721 webrtc::test::FrameForwarder frame_forwarder;
722 cricket::FakeFrameSource frame_source(1280, 720,
723 rtc::kNumMicrosecsPerSec / 60);
724 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
725 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000726
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200727 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000728
729 // Verify that encoders are configured for simulcast through adapter
730 // (increasing resolution and only configured to send one stream each).
731 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200732 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
733 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000734 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200735 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000736 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
737 EXPECT_GT(codec_settings.width, prev_width);
738 prev_width = codec_settings.width;
739 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000740
Niels Möllerff40b142018-04-09 08:49:14 +0200741 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000742
743 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200744 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000745}
746
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200747TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
748 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200749 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000750
Niels Möllerd0f0f682019-01-14 09:09:53 +0100751 // Frame source.
752 webrtc::test::FrameForwarder frame_forwarder;
753 cricket::FakeFrameSource frame_source(1280, 720,
754 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200755
Sebastian Jansson84848f22018-11-16 10:40:36 +0100756 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700757 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200758 cricket::VideoSendParameters parameters;
759 parameters.codecs.push_back(GetEngineCodec("H264"));
760 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000761
762 EXPECT_TRUE(
763 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100764 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200765 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100766 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200767
768 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000769
Anders Carlsson67537952018-05-03 11:28:29 +0200770 cricket::VideoSendParameters new_parameters;
771 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
772 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200773
774 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100775 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200776
Anders Carlsson8a150d92018-05-14 12:40:04 +0200777 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000778}
779
eladalonf1841382017-06-12 01:16:46 -0700780TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000781 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200782 encoder_factory_->AddSupportedVideoCodecType("VP8");
783 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000784
Sebastian Jansson84848f22018-11-16 10:40:36 +0100785 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700786 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800787 cricket::VideoSendParameters parameters;
788 parameters.codecs.push_back(GetEngineCodec("VP8"));
789 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000790
Peter Boström0c4e06b2015-10-07 12:23:21 +0200791 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000792
Yves Gerey665174f2018-06-19 15:03:05 +0200793 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000794 EXPECT_TRUE(channel->SetSend(true));
795
796 // Send a fake frame, or else the media engine will configure the simulcast
797 // encoder adapter at a low-enough size that it'll only create a single
798 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100799 webrtc::test::FrameForwarder frame_forwarder;
800 cricket::FakeFrameSource frame_source(1280, 720,
801 rtc::kNumMicrosecsPerSec / 30);
802 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
803 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000804
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200805 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
806 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000807 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200808 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000809
810 channel.reset();
811 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200812 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000813}
814
eladalonf1841382017-06-12 01:16:46 -0700815TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000816 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200817 encoder_factory_->AddSupportedVideoCodecType("VP8");
818 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000819
Sebastian Jansson84848f22018-11-16 10:40:36 +0100820 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700821 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800822 cricket::VideoSendParameters parameters;
823 parameters.codecs.push_back(GetEngineCodec("H264"));
824 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000825
826 EXPECT_TRUE(
827 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100828
829 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100830 webrtc::test::FrameForwarder frame_forwarder;
831 cricket::FakeFrameSource frame_source(1280, 720,
832 rtc::kNumMicrosecsPerSec / 30);
833 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
834 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200835 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
836 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200837 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000838 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200839 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000840
841 channel.reset();
842 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200843 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000844}
845
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200846TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
847 webrtc::test::ScopedFieldTrials override_field_trials_(
848 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200849 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700850
Sebastian Jansson84848f22018-11-16 10:40:36 +0100851 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700852 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200853 cricket::VideoSendParameters parameters;
854 parameters.codecs.push_back(GetEngineCodec("H264"));
855 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700856
Peter Boström0c4e06b2015-10-07 12:23:21 +0200857 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700858 EXPECT_TRUE(
859 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100860
861 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100862 webrtc::test::FrameForwarder frame_forwarder;
863 cricket::FakeFrameSource frame_source(1280, 720,
864 rtc::kNumMicrosecsPerSec / 30);
865 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
866 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100867
Niels Möller4db138e2018-04-19 09:04:13 +0200868 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200869 ASSERT_EQ(1u, encoder_factory_->encoders().size());
870 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
871 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700872 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200873 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200874 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700875}
876
brandtrffc61182016-11-28 06:02:22 -0800877// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700878// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800879//
880// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700881TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800882 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200883 encoder_factory_->AddSupportedVideoCodecType("VP8");
884
Steve Anton2c9ebef2019-01-28 17:27:58 -0800885 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800886
887 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800888 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800889
890 // FlexFEC is active with field trial.
891 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800892 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800893 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800894}
895
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200896// Test that codecs are added in the order they are reported from the factory.
897TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
898 encoder_factory_->AddSupportedVideoCodecType("VP8");
899 const char* kFakeCodecName = "FakeCodec";
900 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000901
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200902 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100903 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200904 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
905 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000906}
907
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200908// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800909// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200910TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100911 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
912 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100913
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100914 // Set up external encoder factory with first codec, and initialize engine.
915 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
916
brandtrffc61182016-11-28 06:02:22 -0800917 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800918
919 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100920 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800921 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200922 // The codec itself and RTX should have been added.
923 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100924
925 // Check that both fake codecs are present and that the second fake codec
926 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100927 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
928 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100929 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800930}
931
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200932TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
933 const char* kFakeCodecName = "FakeCodec";
934 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
935
936 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
937 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
938}
939
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200940TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
941 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200942 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200943 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800944 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000945
kwiberg686a8ef2016-02-26 03:00:35 -0800946 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200947 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000948
949 EXPECT_TRUE(
950 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200951 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000952
953 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200954 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200955 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000956
957 // Remove stream previously added to free the external decoder instance.
958 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200959 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000960}
961
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200962// Verifies that we can set up decoders.
963TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000964 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
965 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
966 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
967 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200968 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200969 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000970 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800971 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000972
kwiberg686a8ef2016-02-26 03:00:35 -0800973 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200974 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000975
976 EXPECT_TRUE(
977 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200978 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000979}
980
Jonas Oreland49ac5952018-09-26 16:04:32 +0200981// Tests when GetSources is called with non-existing ssrc, it will return an
982// empty list of RtpSource without crashing.
983TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
984 // Setup an recv stream with |kSsrc|.
985 encoder_factory_->AddSupportedVideoCodecType("VP8");
986 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
987 cricket::VideoRecvParameters parameters;
988 parameters.codecs.push_back(GetEngineCodec("VP8"));
989 std::unique_ptr<VideoMediaChannel> channel(
990 SetRecvParamsWithSupportedCodecs(parameters.codecs));
991
992 EXPECT_TRUE(
993 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
994
995 // Call GetSources with |kSsrc + 1| which doesn't exist.
996 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
997 EXPECT_EQ(0u, sources.size());
998}
999
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001000TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1001 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1002 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001003 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001004 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001005 std::move(decoder_factory),
1006 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001007 EXPECT_EQ(0u, engine.codecs().size());
1008}
1009
1010TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1011 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001012 webrtc::MockVideoEncoderFactory* encoder_factory =
1013 new webrtc::MockVideoEncoderFactory();
1014 webrtc::MockVideoDecoderFactory* decoder_factory =
1015 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001016 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1017 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001018 WebRtcVideoEngine engine(
1019 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001020 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1021 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1022 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001023 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1024 EXPECT_EQ(0u, engine.codecs().size());
1025 EXPECT_CALL(*encoder_factory, Die());
1026 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001027 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001028}
1029
1030// Test full behavior in the video engine when video codec factories of the new
1031// type are injected supporting the single codec Vp8. Check the returned codecs
1032// from the engine and that we will create a Vp8 encoder and decoder using the
1033// new factories.
1034TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1035 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001036 webrtc::MockVideoEncoderFactory* encoder_factory =
1037 new webrtc::MockVideoEncoderFactory();
1038 webrtc::MockVideoDecoderFactory* decoder_factory =
1039 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001040 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1041 new webrtc::MockVideoBitrateAllocatorFactory();
1042 EXPECT_CALL(*rate_allocator_factory,
1043 CreateVideoBitrateAllocatorProxy(Field(
1044 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1045 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001046 WebRtcVideoEngine engine(
1047 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001048 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1049 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1050 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001051 const webrtc::SdpVideoFormat vp8_format("VP8");
1052 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1053 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1054 .WillRepeatedly(testing::Return(supported_formats));
1055
1056 // Verify the codecs from the engine.
1057 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001058 // Verify default codecs has been added correctly.
1059 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001060 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001061
1062 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001063 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001064 int vp8_associated_payload;
1065 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1066 &vp8_associated_payload));
1067 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1068
1069 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1070
1071 // RTX codec for RED.
1072 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1073 int red_associated_payload;
1074 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1075 &red_associated_payload));
1076 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1077
1078 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1079
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001080 int associated_payload_type;
1081 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1082 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1083 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1084 // Verify default parameters has been added to the VP8 codec.
1085 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1086
1087 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001088 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1089 codec_info.is_hardware_accelerated = false;
1090 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001092 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1093 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001094 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001095 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001096 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001097 .WillOnce(
1098 ::testing::DoAll(::testing::InvokeWithoutArgs(
1099 [&encoder_created]() { encoder_created.Set(); }),
1100 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001101
1102 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001103 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001104 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1105 .WillOnce(testing::Return(decoder));
1106
1107 // Create a call.
1108 webrtc::RtcEventLogNullImpl event_log;
1109 std::unique_ptr<webrtc::Call> call(
1110 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1111
1112 // Create send channel.
1113 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001114 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001115 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001116 cricket::VideoSendParameters send_parameters;
1117 send_parameters.codecs.push_back(engine_codecs.at(0));
1118 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1119 send_channel->OnReadyToSend(true);
1120 EXPECT_TRUE(
1121 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1122 EXPECT_TRUE(send_channel->SetSend(true));
1123
Niels Möller4db138e2018-04-19 09:04:13 +02001124 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001125 webrtc::test::FrameForwarder frame_forwarder;
1126 cricket::FakeFrameSource frame_source(1280, 720,
1127 rtc::kNumMicrosecsPerSec / 30);
1128 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001129 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001130 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001131 encoder_created.Wait(kTimeout);
1132
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001133 // Create recv channel.
1134 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001135 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001136 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137 cricket::VideoRecvParameters recv_parameters;
1138 recv_parameters.codecs.push_back(engine_codecs.at(0));
1139 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1140 EXPECT_TRUE(recv_channel->AddRecvStream(
1141 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1142
1143 // Remove streams previously added to free the encoder and decoder instance.
1144 EXPECT_CALL(*encoder_factory, Die());
1145 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001146 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001147 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1148 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1149}
1150
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001151// Test behavior when decoder factory fails to create a decoder (returns null).
1152TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1153 // |engine| take ownership of the factories.
1154 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001155 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001156 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001157 new webrtc::MockVideoDecoderFactory();
1158 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1159 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001160 WebRtcVideoEngine engine(
1161 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001162 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1163 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1164 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001165 const webrtc::SdpVideoFormat vp8_format("VP8");
1166 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1167 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1168 .WillRepeatedly(testing::Return(supported_formats));
1169
1170 // Decoder creation fails.
1171 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1172 .WillOnce(testing::Return(nullptr));
1173
1174 // Create a call.
1175 webrtc::RtcEventLogNullImpl event_log;
1176 std::unique_ptr<webrtc::Call> call(
1177 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1178
1179 // Create recv channel.
1180 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001181 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001182 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001183 cricket::VideoRecvParameters recv_parameters;
1184 recv_parameters.codecs.push_back(engine.codecs().front());
1185 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1186 EXPECT_TRUE(recv_channel->AddRecvStream(
1187 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1188
1189 // Remove streams previously added to free the encoder and decoder instance.
1190 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1191}
1192
eladalonf1841382017-06-12 01:16:46 -07001193TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001194 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001195 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001196 std::unique_ptr<VideoMediaChannel> channel(
1197 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001198 ASSERT_TRUE(
1199 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1200 cricket::VideoCodec codec = GetEngineCodec("VP8");
1201 cricket::VideoSendParameters parameters;
1202 parameters.codecs.push_back(codec);
1203 channel->OnReadyToSend(true);
1204 channel->SetSend(true);
1205 ASSERT_TRUE(channel->SetSendParameters(parameters));
1206
Niels Möller805a27e2019-01-21 12:21:27 +01001207 webrtc::test::FrameForwarder frame_forwarder;
1208 cricket::FakeFrameSource frame_source(1280, 720,
1209 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001210 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001211 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001212
Niels Möller805a27e2019-01-21 12:21:27 +01001213 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001214 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001215 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001216 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001217
Niels Möller805a27e2019-01-21 12:21:27 +01001218 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1219 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001220 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001221 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001222
1223 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001224 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1225 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001226 // Change to screen content, recreate encoder. For the simulcast encoder
1227 // adapter case, this will result in two calls since InitEncode triggers a
1228 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001229 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001230 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001231 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001232
Niels Möller805a27e2019-01-21 12:21:27 +01001233 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1234 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001235 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001236 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001237
1238 options.is_screencast.emplace(false);
1239 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001240 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001241 // Change back to regular video content, update encoder. Also change
1242 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001243 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001244 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001245 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001246 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001247
1248 // Remove stream previously added to free the external encoder instance.
1249 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001250 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001251}
1252
Niels Möller6557d0c2018-04-11 15:18:34 +02001253class WebRtcVideoChannelBaseTest : public testing::Test {
1254 protected:
1255 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001256 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001257 webrtc::CreateBuiltinVideoDecoderFactory(),
1258 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001259
1260 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001261 // One testcase calls SetUp in a loop, only create call_ once.
1262 if (!call_) {
1263 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1264 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001265 cricket::MediaConfig media_config;
1266 // Disabling cpu overuse detection actually disables quality scaling too; it
1267 // implies DegradationPreference kMaintainResolution. Automatic scaling
1268 // needs to be disabled, otherwise, tests which check the size of received
1269 // frames become flaky.
1270 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001271 channel_.reset(
1272 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1273 call_.get(), media_config, cricket::VideoOptions(),
1274 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001275 channel_->OnReadyToSend(true);
1276 EXPECT_TRUE(channel_.get() != NULL);
1277 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001278 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001279 cricket::VideoRecvParameters parameters;
1280 parameters.codecs = engine_.codecs();
1281 channel_->SetRecvParameters(parameters);
1282 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001283 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1284 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1285 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1286 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001287 }
1288
1289 // Utility method to setup an additional stream to send and receive video.
1290 // Used to test send and recv between two streams.
1291 void SetUpSecondStream() {
1292 SetUpSecondStreamWithNoRecv();
1293 // Setup recv for second stream.
1294 EXPECT_TRUE(channel_->AddRecvStream(
1295 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1296 // Make the second renderer available for use by a new stream.
1297 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1298 }
1299 // Setup an additional stream just to send video. Defer add recv stream.
1300 // This is required if you want to test unsignalled recv of video rtp packets.
1301 void SetUpSecondStreamWithNoRecv() {
1302 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001303 EXPECT_TRUE(
1304 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001305 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001306 EXPECT_FALSE(
1307 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001308 EXPECT_TRUE(channel_->AddSendStream(
1309 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1310 // We dont add recv for the second stream.
1311
1312 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001313 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001314 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001315 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 }
Yves Gerey665174f2018-06-19 15:03:05 +02001317 virtual void TearDown() { channel_.reset(); }
1318 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001319
1320 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001321 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1322 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001323
1324 bool sending = channel_->sending();
1325 bool success = SetSend(false);
1326 if (success) {
1327 cricket::VideoSendParameters parameters;
1328 parameters.codecs.push_back(codec);
1329 success = channel_->SetSendParameters(parameters);
1330 }
1331 if (success) {
1332 success = SetSend(sending);
1333 }
1334 return success;
1335 }
Yves Gerey665174f2018-06-19 15:03:05 +02001336 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001337 void SendFrame() {
1338 if (frame_forwarder_2_) {
1339 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001340 }
Niels Möller805a27e2019-01-21 12:21:27 +01001341 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 }
1343 bool WaitAndSendFrame(int wait_ms) {
1344 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001345 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001346 return ret;
1347 }
Yves Gerey665174f2018-06-19 15:03:05 +02001348 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001349 int NumRtpBytes(uint32_t ssrc) {
1350 return network_interface_.NumRtpBytes(ssrc);
1351 }
Yves Gerey665174f2018-06-19 15:03:05 +02001352 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001353 int NumRtpPackets(uint32_t ssrc) {
1354 return network_interface_.NumRtpPackets(ssrc);
1355 }
Yves Gerey665174f2018-06-19 15:03:05 +02001356 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001357 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1358 return network_interface_.GetRtpPacket(index);
1359 }
1360 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001361 webrtc::RTPHeader header;
1362 EXPECT_TRUE(ParseRtpPacket(p, &header));
1363 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001364 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001365
Niels Möller6557d0c2018-04-11 15:18:34 +02001366 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001367 webrtc::RTPHeader* header) {
1368 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1369 webrtc::RtpHeaderParser::Create());
1370 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001371 }
1372
1373 // Tests that we can send and receive frames.
1374 void SendAndReceive(const cricket::VideoCodec& codec) {
1375 EXPECT_TRUE(SetOneCodec(codec));
1376 EXPECT_TRUE(SetSend(true));
1377 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1378 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001379 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001380 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1381 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1382 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1383 }
1384
1385 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001386 int duration_sec,
1387 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001388 EXPECT_TRUE(SetOneCodec(codec));
1389 EXPECT_TRUE(SetSend(true));
1390 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1391 EXPECT_EQ(0, renderer_.num_rendered_frames());
1392 for (int i = 0; i < duration_sec; ++i) {
1393 for (int frame = 1; frame <= fps; ++frame) {
1394 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1395 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1396 }
1397 }
1398 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1399 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1400 }
1401
Niels Möller6557d0c2018-04-11 15:18:34 +02001402 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1403 cricket::VideoMediaInfo info;
1404 EXPECT_TRUE(channel_->GetStats(&info));
1405 return info.senders[i];
1406 }
1407
1408 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1409 cricket::VideoMediaInfo info;
1410 EXPECT_TRUE(channel_->GetStats(&info));
1411 return info.receivers[i];
1412 }
1413
1414 // Two streams one channel tests.
1415
1416 // Tests that we can send and receive frames.
1417 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1418 SetUpSecondStream();
1419 // Test sending and receiving on first stream.
1420 SendAndReceive(codec);
1421 // Test sending and receiving on second stream.
1422 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1423 EXPECT_GT(NumRtpPackets(), 0);
1424 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1425 }
1426
1427 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1428 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001429 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001430 return engine_codec;
1431 }
1432 // This point should never be reached.
1433 ADD_FAILURE() << "Unrecognized codec name: " << name;
1434 return cricket::VideoCodec();
1435 }
1436
1437 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1438
1439 cricket::StreamParams DefaultSendStreamParams() {
1440 return cricket::StreamParams::CreateLegacy(kSsrc);
1441 }
1442
1443 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001444 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001445 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001446
1447 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1448 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1449 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1450
Niels Möller6557d0c2018-04-11 15:18:34 +02001451 std::unique_ptr<WebRtcVideoChannel> channel_;
1452 cricket::FakeNetworkInterface network_interface_;
1453 cricket::FakeVideoRenderer renderer_;
1454
1455 // Used by test cases where 2 streams are run on the same channel.
1456 cricket::FakeVideoRenderer renderer2_;
1457};
1458
1459// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001460TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001461 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001462 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001463 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1464 EXPECT_FALSE(channel_->sending());
1465 EXPECT_TRUE(SetSend(true));
1466 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001467 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001468 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1469 EXPECT_TRUE(SetSend(false));
1470 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001471}
Niels Möller6557d0c2018-04-11 15:18:34 +02001472
1473// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001474TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001475 EXPECT_FALSE(channel_->sending());
1476 EXPECT_FALSE(SetSend(true));
1477 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001478}
Niels Möller6557d0c2018-04-11 15:18:34 +02001479
1480// Test that we properly set the send and recv buffer sizes by the time
1481// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001482TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001483 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1484 EXPECT_TRUE(SetSend(true));
1485 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001486 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001487}
1488
Niels Möller6557d0c2018-04-11 15:18:34 +02001489// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001490TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001491 const int kDurationSec = 3;
1492 const int kFps = 10;
1493 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1494
1495 cricket::VideoMediaInfo info;
1496 EXPECT_TRUE(channel_->GetStats(&info));
1497
1498 ASSERT_EQ(1U, info.senders.size());
1499 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1500 // For webrtc, bytes_sent does not include the RTP header length.
1501 EXPECT_GT(info.senders[0].bytes_sent, 0);
1502 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1503 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1504 ASSERT_TRUE(info.senders[0].codec_payload_type);
1505 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1506 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1507 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1508 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1509 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1510 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1511 EXPECT_GT(info.senders[0].framerate_input, 0);
1512 EXPECT_GT(info.senders[0].framerate_sent, 0);
1513
1514 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1515 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1516 info.send_codecs[DefaultCodec().id]);
1517
1518 ASSERT_EQ(1U, info.receivers.size());
1519 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1520 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1521 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1522 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1523 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1524 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1525 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1526 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1527 EXPECT_EQ(0, info.receivers[0].packets_lost);
1528 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1529 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1530 EXPECT_EQ(0, info.receivers[0].firs_sent);
1531 EXPECT_EQ(0, info.receivers[0].plis_sent);
1532 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1533 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1534 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1535 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1536 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1537 EXPECT_GT(info.receivers[0].framerate_output, 0);
1538
1539 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1540 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1541 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001542}
Niels Möller6557d0c2018-04-11 15:18:34 +02001543
1544// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001545TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001546 cricket::FakeVideoRenderer renderer1, renderer2;
1547 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1548 cricket::VideoSendParameters parameters;
1549 parameters.codecs.push_back(DefaultCodec());
1550 parameters.conference_mode = true;
1551 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1552 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001553 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1554 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001555 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1556 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1557 EXPECT_EQ(0, renderer1.num_rendered_frames());
1558 EXPECT_EQ(0, renderer2.num_rendered_frames());
1559 std::vector<uint32_t> ssrcs;
1560 ssrcs.push_back(1);
1561 ssrcs.push_back(2);
1562 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001563 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001564 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1565 kTimeout);
1566 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1567 kTimeout);
1568
1569 EXPECT_TRUE(channel_->SetSend(false));
1570
1571 cricket::VideoMediaInfo info;
1572 EXPECT_TRUE(channel_->GetStats(&info));
1573 ASSERT_EQ(1U, info.senders.size());
1574 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1575 // For webrtc, bytes_sent does not include the RTP header length.
1576 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1577 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1578 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1579 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1580
1581 ASSERT_EQ(2U, info.receivers.size());
1582 for (size_t i = 0; i < info.receivers.size(); ++i) {
1583 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1584 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1585 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001586 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001587 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1588 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1589 }
srtee0c2eea2017-12-15 17:44:33 +01001590}
Niels Möller6557d0c2018-04-11 15:18:34 +02001591
1592// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001593TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001594 // Normal setup; note that we set the SSRC explicitly to ensure that
1595 // it will come first in the senders map.
1596 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1597 cricket::VideoSendParameters parameters;
1598 parameters.codecs.push_back(DefaultCodec());
1599 parameters.conference_mode = true;
1600 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001601 EXPECT_TRUE(
1602 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001603 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1604 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001605 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001606 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1607 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1608
1609 // Add an additional capturer, and hook up a renderer to receive it.
1610 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001611 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001612 const int kTestWidth = 160;
1613 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001614 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1615 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001616 EXPECT_TRUE(
1617 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001618 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001619 EXPECT_TRUE(
1620 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001621 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001622 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001623 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1624 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001625
1626 // Get stats, and make sure they are correct for two senders. We wait until
1627 // the number of expected packets have been sent to avoid races where we
1628 // check stats before it has been updated.
1629 cricket::VideoMediaInfo info;
1630 for (uint32_t i = 0; i < kTimeout; ++i) {
1631 rtc::Thread::Current()->ProcessMessages(1);
1632 EXPECT_TRUE(channel_->GetStats(&info));
1633 ASSERT_EQ(2U, info.senders.size());
1634 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1635 NumRtpPackets()) {
1636 // Stats have been updated for both sent frames, expectations can be
1637 // checked now.
1638 break;
1639 }
1640 }
1641 EXPECT_EQ(NumRtpPackets(),
1642 info.senders[0].packets_sent + info.senders[1].packets_sent)
1643 << "Timed out while waiting for packet counts for all sent packets.";
1644 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1645 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1646 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1647 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1648 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1649 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1650 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1651 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1652 // The capturer must be unregistered here as it runs out of it's scope next.
1653 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001654}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001655
Niels Möller6557d0c2018-04-11 15:18:34 +02001656// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001657TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001658 cricket::VideoSendParameters parameters;
1659 parameters.codecs.push_back(DefaultCodec());
1660 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1661 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1662 parameters.max_bandwidth_bps = 128 * 1024;
1663 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001664}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001665
Niels Möller6557d0c2018-04-11 15:18:34 +02001666// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001667TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001668 EXPECT_TRUE(SetDefaultCodec());
1669 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001670 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001671 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001672 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001673 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001674 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1675 EXPECT_EQ(kSsrc, header.ssrc);
1676
Niels Möller6557d0c2018-04-11 15:18:34 +02001677 // Packets are being paced out, so these can mismatch between the first and
1678 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001679 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1680 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001681 EXPECT_EQ(1, NumSentSsrcs());
1682 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1683 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001684}
Niels Möller6557d0c2018-04-11 15:18:34 +02001685
1686// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001687TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001688 // Remove stream added in Setup.
1689 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1690 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001691 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001692 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001693 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 EXPECT_TRUE(SetSend(true));
1695 EXPECT_TRUE(WaitAndSendFrame(0));
1696 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001697 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001698 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001699 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1700 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001701 // Packets are being paced out, so these can mismatch between the first and
1702 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001703 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1704 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_EQ(1, NumSentSsrcs());
1706 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1707 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001708}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001709
Niels Möller6557d0c2018-04-11 15:18:34 +02001710// Test that we can set the default video renderer before and after
1711// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001712TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001713 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1714 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001715
1716 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1717 rtc::SetBE32(packet1.data() + 8, kSsrc);
1718 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1719 EXPECT_TRUE(SetDefaultCodec());
1720 EXPECT_TRUE(SetSend(true));
1721 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001722 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001723 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001724 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001726}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001727
Niels Möller6557d0c2018-04-11 15:18:34 +02001728// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001729TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1731 EXPECT_TRUE(SetSend(true));
1732 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001733 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001734 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1735 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001736 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001737 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001738 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1739 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001740 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1741 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001742
1743 // Remove the send stream that was added during Setup.
1744 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1745 int rtp_packets = NumRtpPackets();
1746
Niels Möller6557d0c2018-04-11 15:18:34 +02001747 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001748 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001749 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001750 EXPECT_EQ(rtp_packets, NumRtpPackets());
1751 // Wait 30ms to guarantee the engine does not drop the frame.
1752 EXPECT_TRUE(WaitAndSendFrame(30));
1753 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1754
1755 last_packet = NumRtpPackets() - 1;
1756 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001757 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1758 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001759}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001760
Niels Möller6557d0c2018-04-11 15:18:34 +02001761// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001762TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001763 cricket::FakeVideoRenderer renderer1, renderer2;
1764 EXPECT_TRUE(SetDefaultCodec());
1765 cricket::VideoSendParameters parameters;
1766 parameters.codecs.push_back(DefaultCodec());
1767 parameters.conference_mode = true;
1768 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1769 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001770 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1771 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001772 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1773 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1774 EXPECT_EQ(0, renderer1.num_rendered_frames());
1775 EXPECT_EQ(0, renderer2.num_rendered_frames());
1776 std::vector<uint32_t> ssrcs;
1777 ssrcs.push_back(1);
1778 ssrcs.push_back(2);
1779 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001780 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001781 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1782 kTimeout);
1783 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1784 kTimeout);
1785
1786 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1787 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1788 EXPECT_EQ(kVideoWidth, renderer1.width());
1789 EXPECT_EQ(kVideoHeight, renderer1.height());
1790 EXPECT_EQ(kVideoWidth, renderer2.width());
1791 EXPECT_EQ(kVideoHeight, renderer2.height());
1792 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1793 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001794}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001795
Niels Möller6557d0c2018-04-11 15:18:34 +02001796// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001797TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001798 using cricket::VideoCodec;
1799 using cricket::VideoOptions;
1800 using cricket::VideoFormat;
1801 using cricket::FOURCC_I420;
1802
1803 VideoCodec codec = DefaultCodec();
1804 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1805 EXPECT_TRUE(SetOneCodec(codec));
1806 EXPECT_TRUE(SetSend(true));
1807 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1808 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001809 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001810 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001811
1812 webrtc::test::FrameForwarder frame_forwarder;
1813 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1814 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001815
1816 // TODO(nisse): This testcase fails if we don't configure
1817 // screencast. It's unclear why, I see nothing obvious in this
1818 // test which is related to screencast logic.
1819 VideoOptions video_options;
1820 video_options.is_screencast = true;
1821 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1822
Niels Möller6557d0c2018-04-11 15:18:34 +02001823 int captured_frames = 1;
1824 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001825 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001826 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001827 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1828
Niels Möller6557d0c2018-04-11 15:18:34 +02001829 ++captured_frames;
1830 // Wait until frame of right size is captured.
1831 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001832 480 == renderer_.width() &&
1833 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001834 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001835 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001836 EXPECT_EQ(480, renderer_.width());
1837 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001838 captured_frames = renderer_.num_rendered_frames() + 1;
1839 EXPECT_FALSE(renderer_.black_frame());
1840 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1841 // Make sure a black frame is generated within the specified timeout.
1842 // The black frame should be the resolution of the previous frame to
1843 // prevent expensive encoder reconfigurations.
1844 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001845 480 == renderer_.width() &&
1846 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001847 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001848 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001849 EXPECT_EQ(480, renderer_.width());
1850 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001851 EXPECT_TRUE(renderer_.black_frame());
1852
1853 // The black frame has the same timestamp as the next frame since it's
1854 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1855 // not render a frame with the same timestamp so capture another frame
1856 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001857 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001858 }
srtee0c2eea2017-12-15 17:44:33 +01001859}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001860
Niels Möller6557d0c2018-04-11 15:18:34 +02001861// Tests that if SetVideoSend is called with a NULL capturer after the
1862// capturer was already removed, the application doesn't crash (and no black
1863// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001864TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001865 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1866 EXPECT_TRUE(SetSend(true));
1867 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1868 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001869 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001870 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1871 // Wait for one frame so they don't get dropped because we send frames too
1872 // tightly.
1873 rtc::Thread::Current()->ProcessMessages(30);
1874 // Remove the capturer.
1875 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1876
1877 // No capturer was added, so this SetVideoSend shouldn't do anything.
1878 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1879 rtc::Thread::Current()->ProcessMessages(300);
1880 // Verify no more frames were sent.
1881 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001882}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001883
Niels Möller6557d0c2018-04-11 15:18:34 +02001884// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001885TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001886 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1887 // interval time to avoid that.
1888 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1889 // interval time to avoid that.
1890 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001891 EXPECT_TRUE(
1892 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001893 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1894 cricket::VideoFormat capture_format(
1895 kVideoWidth, kVideoHeight,
1896 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1897 // Set up additional stream 1.
1898 cricket::FakeVideoRenderer renderer1;
1899 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001900 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001901 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001902 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001903
1904 webrtc::test::FrameForwarder frame_forwarder1;
1905 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1906 rtc::kNumMicrosecsPerSec / kFramerate);
1907
Niels Möller6557d0c2018-04-11 15:18:34 +02001908 // Set up additional stream 2.
1909 cricket::FakeVideoRenderer renderer2;
1910 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001911 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001912 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001913 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01001914 webrtc::test::FrameForwarder frame_forwarder2;
1915
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 // State for all the streams.
1917 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1918 // A limitation in the lmi implementation requires that SetVideoSend() is
1919 // called after SetOneCodec().
1920 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01001921 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
1922 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 EXPECT_TRUE(SetSend(true));
1924 // Test capturer associated with engine.
1925 const int kTestWidth = 160;
1926 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001927 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
1928 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1929 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02001930 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1931 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001932 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01001933 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
1934 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1935 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02001936 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1937 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001938 // Successfully remove the capturer.
1939 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1940 // The capturers must be unregistered here as it runs out of it's scope
1941 // next.
1942 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1943 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001944}
Niels Möller6557d0c2018-04-11 15:18:34 +02001945
1946// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001947TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001948 // Remove the send stream that was added during Setup.
1949 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1950
1951 cricket::StreamParams empty;
1952 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001953 EXPECT_TRUE(
1954 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001955}
Niels Möller6557d0c2018-04-11 15:18:34 +02001956
1957// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001958TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001959 // Remove stream added in Setup. I.e. remove stream corresponding to default
1960 // channel.
1961 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001962 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001963 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1964 EXPECT_TRUE(channel_->AddSendStream(
1965 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1966 }
1967 // Delete one of the non default channel streams, let the destructor delete
1968 // the remaining ones.
1969 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1970 // Stream should already be deleted.
1971 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001972}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001973
eladalonf1841382017-06-12 01:16:46 -07001974TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001975 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001976}
1977
eladalonf1841382017-06-12 01:16:46 -07001978TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08001979 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001980}
1981
eladalonf1841382017-06-12 01:16:46 -07001982TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08001983 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00001984}
1985
eladalonf1841382017-06-12 01:16:46 -07001986TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02001987 // Set a high bitrate to not be downscaled by VP8 due to low initial start
1988 // bitrates. This currently happens at <250k, and two streams sharing 300k
1989 // initially will use QVGA instead of VGA.
1990 // TODO(pbos): Set up the quality scaler so that both senders reliably start
1991 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08001992 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02001993 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02001994 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001995}
1996
eladalonf1841382017-06-12 01:16:46 -07001997class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001998 public:
eladalonf1841382017-06-12 01:16:46 -07001999 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2000 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002001 : WebRtcVideoEngineTest(field_trials),
2002 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2003 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002004 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002005 encoder_factory_->AddSupportedVideoCodecType("VP8");
2006 encoder_factory_->AddSupportedVideoCodecType("VP9");
2007#if defined(WEBRTC_USE_H264)
2008 encoder_factory_->AddSupportedVideoCodecType("H264");
2009#endif
2010
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002011 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002012 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2013 GetMediaConfig(), VideoOptions(),
2014 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002015 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002016 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002017 send_parameters_.codecs = engine_.codecs();
2018 recv_parameters_.codecs = engine_.codecs();
2019 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002020 }
2021
2022 protected:
2023 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002024 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002025 }
2026
2027 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002028 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002029 EXPECT_TRUE(channel_->AddSendStream(sp));
2030 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002031 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002032 EXPECT_EQ(num_streams + 1, streams.size());
2033 return streams[streams.size() - 1];
2034 }
2035
2036 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002037 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002038 }
2039
2040 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002041 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002042 }
2043
2044 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002045 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002046 EXPECT_TRUE(channel_->AddRecvStream(sp));
2047 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002048 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002049 EXPECT_EQ(num_streams + 1, streams.size());
2050 return streams[streams.size() - 1];
2051 }
2052
pbos@webrtc.org00873182014-11-25 14:03:34 +00002053 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2054 int expected_min_bitrate_bps,
2055 const char* start_bitrate_kbps,
2056 int expected_start_bitrate_bps,
2057 const char* max_bitrate_kbps,
2058 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002059 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2060 expected_start_bitrate_bps,
2061 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002062 auto& codecs = send_parameters_.codecs;
2063 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002064 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002065 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2066 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2067 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002068 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002069 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002070
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002071 void ExpectSetBitrateParameters(int min_bitrate_bps,
2072 int start_bitrate_bps,
2073 int max_bitrate_bps) {
2074 EXPECT_CALL(
2075 *fake_call_->GetMockTransportControllerSend(),
2076 SetSdpBitrateParameters(AllOf(
2077 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2078 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2079 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2080 }
2081
2082 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2083 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2084 SetSdpBitrateParameters(Field(
2085 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002086 }
2087
Johannes Kron9190b822018-10-29 11:22:05 +01002088 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2089 // For a caller, the answer will be applied in set remote description
2090 // where SetSendParameters() is called.
2091 EXPECT_TRUE(
2092 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2093 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2094 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2095 const webrtc::VideoSendStream::Config& config =
2096 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2097 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2098 }
2099
2100 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2101 // For a callee, the answer will be applied in set local description
2102 // where SetExtmapAllowMixed() and AddSendStream() are called.
2103 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2104 EXPECT_TRUE(
2105 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2106 const webrtc::VideoSendStream::Config& config =
2107 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2108 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2109 }
2110
isheriff6f8d6862016-05-26 11:24:55 -07002111 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002112 // Enable extension.
2113 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002114 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002115 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002116 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002117 FakeVideoSendStream* send_stream =
2118 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2119
2120 // Verify the send extension id.
2121 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2122 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002123 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002124 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002125 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002126 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2127 // receivers.
2128 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2129 ->GetConfig()
2130 .rtp.extensions.empty());
2131
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002132 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002133 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002134 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2135 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002136 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2137
2138 // Verify that adding receive RTP header extensions adds them for existing
2139 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002140 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002141 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002142 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2143 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002144 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002145 }
2146
isheriff6f8d6862016-05-26 11:24:55 -07002147 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002148 // Enable extension.
2149 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002150 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002151 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002152 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002153
2154 FakeVideoReceiveStream* recv_stream =
2155 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2156
2157 // Verify the recv extension id.
2158 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2159 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002160 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002161 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002162 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002163
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002164 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2165 // senders.
2166 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2167 ->GetConfig()
2168 .rtp.extensions.empty());
2169
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002170 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002171 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002172 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2173 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002174 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2175
2176 // Verify that adding receive RTP header extensions adds them for existing
2177 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002178 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002179 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002180 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2181 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002182 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002183 }
2184
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002185 void TestExtensionFilter(const std::vector<std::string>& extensions,
2186 const std::string& expected_extension) {
2187 cricket::VideoSendParameters parameters = send_parameters_;
2188 int expected_id = -1;
2189 int id = 1;
2190 for (const std::string& extension : extensions) {
2191 if (extension == expected_extension)
2192 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002193 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002194 }
2195 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2196 FakeVideoSendStream* send_stream =
2197 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2198
2199 // Verify that only one of them has been set, and that it is the one with
2200 // highest priority (transport sequence number).
2201 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2202 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2203 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002204 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002205 }
2206
asapersson3c81a1a2017-06-14 05:52:21 -07002207 void TestDegradationPreference(bool resolution_scaling_enabled,
2208 bool fps_scaling_enabled);
2209
Erik Språngefbde372015-04-29 16:21:28 +02002210 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002211 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002212 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2213 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002214
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002215 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002216 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002217 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002218 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002219 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002220 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002221 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002222 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002223 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002224
Erik Språng143cec12015-04-28 10:01:41 +02002225 return fake_call_->GetVideoSendStreams().back();
2226 }
2227
Peter Boström2feafdb2015-09-09 14:32:14 +02002228 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2229 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002230 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002231 std::vector<uint32_t> ssrcs;
2232 std::vector<uint32_t> rtx_ssrcs;
2233 uint32_t num_streams = enabled ? 3 : 1;
2234 for (uint32_t i = 0; i < num_streams; ++i) {
2235 uint32_t ssrc = last_ssrc_ + i;
2236 ssrcs.push_back(ssrc);
2237 if (with_rtx) {
2238 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2239 }
Erik Språng143cec12015-04-28 10:01:41 +02002240 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002241 if (with_rtx) {
2242 return AddSendStream(
2243 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2244 }
2245 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002246 }
2247
perkjfa10b552016-10-02 23:45:26 -07002248 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002249 std::vector<FakeVideoSendStream*> streams =
2250 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002251 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002252 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002253 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002254 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002255 }
2256
perkjfa10b552016-10-02 23:45:26 -07002257 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002258 int stream_max,
2259 int expected_encoder_bitrate) {
2260 VideoSendParameters limited_send_params = send_parameters_;
2261 limited_send_params.max_bandwidth_bps = global_max;
2262 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002263 webrtc::RtpParameters parameters =
2264 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002265 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002266 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002267 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002268 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002269 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002270 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002271 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002272 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002273 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002274 }
2275
Åsa Persson55659812018-06-18 17:51:32 +02002276 // Values from kSimulcastConfigs in simulcast.cc.
2277 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2278 std::vector<webrtc::VideoStream> layers(3);
2279 layers[0].min_bitrate_bps = 30000;
2280 layers[0].target_bitrate_bps = 150000;
2281 layers[0].max_bitrate_bps = 200000;
2282 layers[1].min_bitrate_bps = 150000;
2283 layers[1].target_bitrate_bps = 500000;
2284 layers[1].max_bitrate_bps = 700000;
2285 layers[2].min_bitrate_bps = 600000;
2286 layers[2].target_bitrate_bps = 2500000;
2287 layers[2].max_bitrate_bps = 2500000;
2288 return layers;
2289 }
2290
Niels Möller805a27e2019-01-21 12:21:27 +01002291 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002292 std::unique_ptr<FakeCall> fake_call_;
2293 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002294 cricket::VideoSendParameters send_parameters_;
2295 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002296 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002297};
2298
eladalonf1841382017-06-12 01:16:46 -07002299TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002300 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002301 const std::string kSyncLabel = "AvSyncLabel";
2302
2303 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002304 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002305 EXPECT_TRUE(channel_->AddRecvStream(sp));
2306
Mirko Bonadeif859e552018-05-30 15:31:29 +02002307 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002308 EXPECT_EQ(kSyncLabel,
2309 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2310 << "SyncGroup should be set based on sync_label";
2311}
2312
eladalonf1841382017-06-12 01:16:46 -07002313TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002314 cricket::VideoSendParameters parameters;
2315 parameters.codecs = engine_.codecs();
2316 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002317 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002318 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002319 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002320
2321 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002322 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2323 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002324 FakeVideoSendStream* send_stream = AddSendStream(
2325 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2326
2327 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2328 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2329 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2330
2331 // Receiver side.
2332 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2333 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002334 EXPECT_FALSE(
2335 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002336 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002337 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002338 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002339 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002340 << "RTX should be mapped for the RED payload type";
2341
brandtr14742122017-01-27 04:53:07 -08002342 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002343}
2344
eladalonf1841382017-06-12 01:16:46 -07002345TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002346 // Setup one channel with an associated RTX stream.
2347 cricket::StreamParams params =
2348 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2349 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2350 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002351 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002352
2353 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2354 << "RTX should be mapped for all decoders/payload types.";
2355 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002356 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002357 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002358}
2359
eladalonf1841382017-06-12 01:16:46 -07002360TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002361 // Setup one channel without an associated RTX stream.
2362 cricket::StreamParams params =
2363 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2364 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002365 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002366}
2367
Johannes Kron9190b822018-10-29 11:22:05 +01002368// Test propagation of extmap allow mixed setting.
2369TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2370 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2371}
2372TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2373 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2374}
2375TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2376 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2377}
2378TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2379 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2380}
2381
eladalonf1841382017-06-12 01:16:46 -07002382TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002383 FakeVideoSendStream* send_stream =
2384 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2385 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2386
2387 FakeVideoReceiveStream* recv_stream =
2388 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2389 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002390}
2391
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002392// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002393TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002394 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002395}
isheriff6f8d6862016-05-26 11:24:55 -07002396
eladalonf1841382017-06-12 01:16:46 -07002397TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002398 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002399}
2400
2401// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002402TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002403 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002404}
isheriff6f8d6862016-05-26 11:24:55 -07002405
eladalonf1841382017-06-12 01:16:46 -07002406TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002407 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002408}
2409
eladalonf1841382017-06-12 01:16:46 -07002410TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002411 // Enable three redundant extensions.
2412 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002413 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2414 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2415 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2416 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002417}
2418
eladalonf1841382017-06-12 01:16:46 -07002419TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002420 // Enable two redundant extensions.
2421 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002422 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2423 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2424 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002425}
2426
stefanc1aeaf02015-10-15 07:26:07 -07002427// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002428TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002429 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002430}
eladalonf1841382017-06-12 01:16:46 -07002431TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002432 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002433}
2434
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002435// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002436TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002437 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002438}
eladalonf1841382017-06-12 01:16:46 -07002439TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002440 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002441}
2442
eladalonf1841382017-06-12 01:16:46 -07002443TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002444 const int kAbsSendTimeId = 1;
2445 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002446 send_parameters_.extensions.push_back(
2447 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2448 send_parameters_.extensions.push_back(
2449 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002450
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002451 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002452 FakeVideoSendStream* send_stream =
2453 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2454
2455 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002456 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002457
2458 // Setting the same extensions (even if in different order) shouldn't
2459 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002460 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002461 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002462
2463 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2464
2465 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002466 send_parameters_.extensions.resize(1);
2467 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002468
2469 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2470}
2471
eladalonf1841382017-06-12 01:16:46 -07002472TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002473 const int kTOffsetId = 1;
2474 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002475 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002476 recv_parameters_.extensions.push_back(
2477 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2478 recv_parameters_.extensions.push_back(
2479 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2480 recv_parameters_.extensions.push_back(
2481 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002482
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002483 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002484 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002485 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2486
2487 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002488 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002489
2490 // Setting the same extensions (even if in different order) shouldn't
2491 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002492 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002493 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002494
2495 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2496
2497 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002498 recv_parameters_.extensions.resize(1);
2499 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002500
2501 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2502}
2503
eladalonf1841382017-06-12 01:16:46 -07002504TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002505 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002506 const int kUnsupportedId = 1;
2507 const int kTOffsetId = 2;
2508
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002509 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002510 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002511 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002512 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002513 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002514 FakeVideoSendStream* send_stream =
2515 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2516
2517 // Only timestamp offset extension is set to send stream,
2518 // unsupported rtp extension is ignored.
2519 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002520 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2521 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002522}
2523
eladalonf1841382017-06-12 01:16:46 -07002524TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002525 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002526 const int kUnsupportedId = 1;
2527 const int kTOffsetId = 2;
2528
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002529 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002530 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002531 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002532 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002533 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002534 FakeVideoReceiveStream* recv_stream =
2535 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2536
2537 // Only timestamp offset extension is set to receive stream,
2538 // unsupported rtp extension is ignored.
2539 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002540 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2541 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002542}
2543
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002545 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002546 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002547 send_parameters_.extensions.push_back(
2548 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002549 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002550 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2551 }
2552}
2553
eladalonf1841382017-06-12 01:16:46 -07002554TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002555 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002556 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002557 recv_parameters_.extensions.push_back(
2558 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002559 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002560 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2561 }
2562}
2563
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002565 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002566 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002567 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002568 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002569 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002570 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002571
2572 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002573 send_parameters_.extensions.clear();
2574 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002575 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002576 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2577 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002578}
2579
eladalonf1841382017-06-12 01:16:46 -07002580TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002581 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002582 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002583 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002584 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002585 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002586 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002587
2588 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002589 recv_parameters_.extensions.clear();
2590 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002591 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002592 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2593 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002594}
2595
eladalonf1841382017-06-12 01:16:46 -07002596TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002597 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002598 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002599}
2600
eladalonf1841382017-06-12 01:16:46 -07002601TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002602 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002603 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002604}
2605
eladalonf1841382017-06-12 01:16:46 -07002606TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002607 FakeVideoReceiveStream* stream = AddRecvStream();
2608 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002609}
2610
eladalonf1841382017-06-12 01:16:46 -07002611TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002612 FakeVideoReceiveStream* stream = AddRecvStream();
2613 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2614}
2615
eladalonf1841382017-06-12 01:16:46 -07002616TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002617 FakeVideoReceiveStream* stream = AddRecvStream();
2618 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2619
Peter Boström126c03e2015-05-11 12:48:12 +02002620 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002621 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002622 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2624 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002625 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002626 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2627
2628 // Verify that REMB is turned on when setting default codecs since the
2629 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002630 parameters.codecs = engine_.codecs();
2631 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002632 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002633 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002634}
2635
eladalonf1841382017-06-12 01:16:46 -07002636TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002637 FakeVideoReceiveStream* stream = AddRecvStream();
2638 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2639
2640 // Verify that transport cc feedback is turned off when send(!) codecs without
2641 // transport cc feedback are set.
2642 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002643 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002644 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2645 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2646 stream = fake_call_->GetVideoReceiveStreams()[0];
2647 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2648
2649 // Verify that transport cc feedback is turned on when setting default codecs
2650 // since the default codecs have transport cc feedback enabled.
2651 parameters.codecs = engine_.codecs();
2652 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2653 stream = fake_call_->GetVideoReceiveStreams()[0];
2654 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2655}
2656
eladalonf1841382017-06-12 01:16:46 -07002657TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002658 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002659 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2660
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002661 cricket::VideoSendParameters parameters;
2662 parameters.codecs = engine_.codecs();
2663 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002664 EXPECT_TRUE(channel_->SetSend(true));
2665
2666 // Send side.
2667 FakeVideoSendStream* send_stream =
2668 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2669 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2670
2671 // Receiver side.
2672 FakeVideoReceiveStream* recv_stream =
2673 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2674 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2675
2676 // Nack history size should match between sender and receiver.
2677 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2678 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002679}
2680
eladalonf1841382017-06-12 01:16:46 -07002681TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002682 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002683 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002684
2685 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2686 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2687
2688 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002689 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002690 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002691 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2692 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002693 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2694 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2695 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002696 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2697
Peter Boström67c9df72015-05-11 14:34:58 +02002698 // Verify that NACK is turned on when setting default codecs since the
2699 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002700 parameters.codecs = engine_.codecs();
2701 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002702 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2703 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2704 send_stream = fake_call_->GetVideoSendStreams()[0];
2705 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002706}
2707
Peter Boströme7ba0862016-03-12 00:02:28 +01002708// This test verifies that new frame sizes reconfigures encoders even though not
2709// (yet) sending. The purpose of this is to permit encoding as quickly as
2710// possible once we start sending. Likely the frames being input are from the
2711// same source that will be sent later, which just means that we're ready
2712// earlier.
eladalonf1841382017-06-12 01:16:46 -07002713TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002714 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002715 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002716 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2717 channel_->SetSend(false);
2718
2719 FakeVideoSendStream* stream = AddSendStream();
2720
perkjfa10b552016-10-02 23:45:26 -07002721 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002722 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002723 EXPECT_EQ(0u, streams[0].width);
2724 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002725
Niels Möller805a27e2019-01-21 12:21:27 +01002726 webrtc::test::FrameForwarder frame_forwarder;
2727 cricket::FakeFrameSource frame_source(1280, 720,
2728 rtc::kNumMicrosecsPerSec / 30);
2729
2730 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2731 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002732
2733 // Frame entered, should be reconfigured to new dimensions.
2734 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002735 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2736 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002737
Niels Möllerff40b142018-04-09 08:49:14 +02002738 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002739}
2740
eladalonf1841382017-06-12 01:16:46 -07002741TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002742 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002743 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002744 cricket::VideoSendParameters parameters;
2745 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002746 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002747 AddSendStream();
2748
Niels Möller805a27e2019-01-21 12:21:27 +01002749 webrtc::test::FrameForwarder frame_forwarder;
2750 cricket::FakeFrameSource frame_source(1280, 720,
2751 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002752 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002753 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002754 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2755 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002756
2757 EXPECT_TRUE(channel_->SetSend(true));
2758
Niels Möller805a27e2019-01-21 12:21:27 +01002759 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002760 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2761 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2762
2763 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2764
2765 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002766 webrtc::VideoEncoderConfig encoder_config =
2767 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002768 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002769 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002770 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002771 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2772 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002773 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2774 << "Non-screenshare shouldn't use min-transmit bitrate.";
2775
Niels Möllerff40b142018-04-09 08:49:14 +02002776 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002777 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002778 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002779 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002780 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2781 &frame_forwarder));
2782 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002783 // Send stream recreated after option change.
2784 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2785 send_stream = fake_call_->GetVideoSendStreams().front();
2786 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002787
2788 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002789 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002790 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002791 encoder_config.content_type);
2792 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2793 encoder_config.min_transmit_bitrate_bps);
2794
perkjfa10b552016-10-02 23:45:26 -07002795 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002796 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2797 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002798 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002799 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002800}
2801
eladalonf1841382017-06-12 01:16:46 -07002802TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002803 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002804 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002805 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002806 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002807
2808 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002809 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002810 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002811 webrtc::test::FrameForwarder frame_forwarder;
2812 cricket::FakeFrameSource frame_source(1280, 720,
2813 rtc::kNumMicrosecsPerSec / 30);
2814 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002815 EXPECT_TRUE(channel_->SetSend(true));
2816
Niels Möller805a27e2019-01-21 12:21:27 +01002817 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002818 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2819 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2820
perkj26091b12016-09-01 01:17:40 -07002821 webrtc::VideoEncoderConfig encoder_config =
2822 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002823
2824 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002825 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002826 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002827 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002828
2829 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2830 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002831 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002832 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002833 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002834
Niels Möllerff40b142018-04-09 08:49:14 +02002835 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002836}
2837
eladalonf1841382017-06-12 01:16:46 -07002838TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002839 FakeVideoSendStream* stream = AddSendStream();
2840 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2841}
2842
eladalonf1841382017-06-12 01:16:46 -07002843TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002844 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002845 media_config.video.suspend_below_min_bitrate = true;
2846
Sebastian Jansson84848f22018-11-16 10:40:36 +01002847 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002848 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002849 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002850
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002851 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002852
2853 FakeVideoSendStream* stream = AddSendStream();
2854 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2855
nisse0db023a2016-03-01 04:29:59 -08002856 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002857 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002858 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002859 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002860
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002861 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002862
nisse0db023a2016-03-01 04:29:59 -08002863 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002864 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2865}
2866
eladalonf1841382017-06-12 01:16:46 -07002867TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002868 FakeVideoSendStream* stream = AddSendStream();
2869 webrtc::VideoCodecVP8 vp8_settings;
2870 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2871 EXPECT_TRUE(vp8_settings.denoisingOn);
2872}
2873
eladalonf1841382017-06-12 01:16:46 -07002874TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002875 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002876 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002877 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002878
Peter Boström2feafdb2015-09-09 14:32:14 +02002879 // Single-stream settings should apply with RTX as well (verifies that we
2880 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2881 // both RTX and regular SSRCs).
2882 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002883
Niels Möller805a27e2019-01-21 12:21:27 +01002884 webrtc::test::FrameForwarder frame_forwarder;
2885 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002886 channel_->SetSend(true);
2887
Niels Möller805a27e2019-01-21 12:21:27 +01002888 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002889
pbos4cba4eb2015-10-26 11:18:18 -07002890 webrtc::VideoCodecVP8 vp8_settings;
2891 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2892 EXPECT_TRUE(vp8_settings.denoisingOn)
2893 << "VP8 denoising should be on by default.";
2894
Niels Möller805a27e2019-01-21 12:21:27 +01002895 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002896
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002897 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2898 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002899 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2900 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002901
Niels Möller805a27e2019-01-21 12:21:27 +01002902 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002903
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002904 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2905 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002906 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2907 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2908
Niels Möllerff40b142018-04-09 08:49:14 +02002909 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002910 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01002911 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002912 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01002913 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002914
Mirko Bonadeif859e552018-05-30 15:31:29 +02002915 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002916 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2917 // Autmatic resize off when using simulcast.
2918 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2919 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2920
2921 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002922 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002923 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002924 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01002925
Niels Möller805a27e2019-01-21 12:21:27 +01002926 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002927
Mirko Bonadeif859e552018-05-30 15:31:29 +02002928 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002929 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2930 EXPECT_FALSE(vp8_settings.denoisingOn);
2931 // Resizing and frame dropping always off for screen sharing.
2932 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2933 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2934
Niels Möller805a27e2019-01-21 12:21:27 +01002935 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02002936
2937 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2938 EXPECT_FALSE(vp8_settings.denoisingOn);
2939 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2940 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2941
Niels Möllerff40b142018-04-09 08:49:14 +02002942 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002943}
2944
deadbeef119760a2016-04-04 11:43:27 -07002945// Test that setting the same options doesn't result in the encoder being
2946// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002947TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002948 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01002949 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07002950
perkjfa10b552016-10-02 23:45:26 -07002951 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07002952 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002953 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002954 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2955 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2956
Niels Möller805a27e2019-01-21 12:21:27 +01002957 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
2958 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
2959 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07002960 // Expect 1 reconfigurations at this point from the initial configuration.
2961 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002962
2963 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01002964 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07002965 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
2966
2967 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01002968 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002969 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07002970 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
2971
Niels Möllerff40b142018-04-09 08:49:14 +02002972 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07002973}
2974
eladalonf1841382017-06-12 01:16:46 -07002975class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02002976 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07002977 Vp9SettingsTest() : Vp9SettingsTest("") {}
2978 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07002979 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02002980 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02002981 }
2982 virtual ~Vp9SettingsTest() {}
2983
2984 protected:
Erik Språng143cec12015-04-28 10:01:41 +02002985 void TearDown() override {
2986 // Remove references to encoder_factory_ since this will be destroyed
2987 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002988 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02002989 }
Erik Språng143cec12015-04-28 10:01:41 +02002990};
2991
2992TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002993 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002994 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002995 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02002996
Peter Boström2feafdb2015-09-09 14:32:14 +02002997 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02002998
Niels Möller805a27e2019-01-21 12:21:27 +01002999 webrtc::test::FrameForwarder frame_forwarder;
3000 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003001 channel_->SetSend(true);
3002
Niels Möller805a27e2019-01-21 12:21:27 +01003003 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003004
pbos4cba4eb2015-10-26 11:18:18 -07003005 webrtc::VideoCodecVP9 vp9_settings;
3006 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003007 EXPECT_TRUE(vp9_settings.denoisingOn)
3008 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003009
Niels Möller805a27e2019-01-21 12:21:27 +01003010 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003011
Erik Språng143cec12015-04-28 10:01:41 +02003012 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3013 EXPECT_FALSE(vp9_settings.denoisingOn);
3014 // Frame dropping always on for real time video.
3015 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3016
Niels Möller805a27e2019-01-21 12:21:27 +01003017 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003018
3019 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3020 EXPECT_TRUE(vp9_settings.denoisingOn);
3021 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3022
3023 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003024 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003025 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003026 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003027
Niels Möller805a27e2019-01-21 12:21:27 +01003028 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003029
3030 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3031 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003032 // Frame dropping always on for screen sharing.
3033 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003034
Niels Möller805a27e2019-01-21 12:21:27 +01003035 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003036
3037 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3038 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003039 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003040
Niels Möllerff40b142018-04-09 08:49:14 +02003041 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003042}
3043
Sergey Silkinf18072e2018-03-14 10:35:35 +01003044TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3045 cricket::VideoSendParameters parameters;
3046 parameters.codecs.push_back(GetEngineCodec("VP9"));
3047 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3048
3049 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3050
3051 FakeVideoSendStream* stream =
3052 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3053
3054 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3055 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3056
Niels Möller805a27e2019-01-21 12:21:27 +01003057 webrtc::test::FrameForwarder frame_forwarder;
3058 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003059 channel_->SetSend(true);
3060
Niels Möller805a27e2019-01-21 12:21:27 +01003061 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003062
3063 webrtc::VideoCodecVP9 vp9_settings;
3064 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3065
3066 const size_t kNumSpatialLayers = ssrcs.size();
3067 const size_t kNumTemporalLayers = 3;
3068 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3069 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3070
Niels Möllerff40b142018-04-09 08:49:14 +02003071 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003072}
3073
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003074TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3075 cricket::VideoSendParameters send_parameters;
3076 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3077 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3078
3079 const size_t kNumSpatialLayers = 3;
3080 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3081
3082 FakeVideoSendStream* stream =
3083 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3084
3085 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3086 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3087 ASSERT_TRUE(parameters.encodings[0].active);
3088 ASSERT_TRUE(parameters.encodings[1].active);
3089 ASSERT_TRUE(parameters.encodings[2].active);
3090 // Invert value to verify copying.
3091 parameters.encodings[1].active = false;
3092 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3093
3094 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3095
3096 // number_of_streams should be 1 since all spatial layers are sent on the
3097 // same SSRC. But encoding parameters of all layers is supposed to be copied
3098 // and stored in simulcast_layers[].
3099 EXPECT_EQ(1u, encoder_config.number_of_streams);
3100 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3101 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3102 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3103 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3104}
3105
asaperssonc5dabdd2016-03-21 04:15:50 -07003106class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3107 public:
brandtr468da7c2016-11-22 02:16:47 -08003108 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003109 : Vp9SettingsTest(field_trials) {}
3110
3111 protected:
3112 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3113 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003114 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003115 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3116
3117 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3118
Niels Möller805a27e2019-01-21 12:21:27 +01003119 webrtc::test::FrameForwarder frame_forwarder;
3120 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003121 channel_->SetSend(true);
3122
Niels Möller805a27e2019-01-21 12:21:27 +01003123 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003124
3125 webrtc::VideoCodecVP9 vp9_settings;
3126 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3127 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3128 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3129
Niels Möllerff40b142018-04-09 08:49:14 +02003130 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003131 }
3132};
3133
3134class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3135 public:
3136 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3137};
3138
3139TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3140 const int kNumSpatialLayers = 1;
3141 const int kNumTemporalLayers = 1;
3142 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3143}
3144
3145class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3146 public:
3147 Vp9SettingsTestWithInvalidFlag()
3148 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3149};
3150
3151TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3152 const int kNumSpatialLayers = 1;
3153 const int kNumTemporalLayers = 1;
3154 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3155}
3156
3157class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3158 public:
3159 Vp9SettingsTestWith2SL3TLFlag()
3160 : Vp9SettingsTestWithFieldTrial(
3161 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3162};
3163
3164TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3165 const int kNumSpatialLayers = 2;
3166 const int kNumTemporalLayers = 3;
3167 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3168}
3169
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003170TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3171 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3172 ASSERT_EQ(1u, streams.size());
3173 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3174}
3175
3176TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3177 webrtc::test::ScopedFieldTrials override_field_trials_(
3178 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3179 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3180 ASSERT_EQ(1u, streams.size());
3181 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3182}
3183
asapersson3c81a1a2017-06-14 05:52:21 -07003184TEST_F(WebRtcVideoChannelTest,
3185 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3186 webrtc::test::ScopedFieldTrials override_field_trials_(
3187 "WebRTC-Video-BalancedDegradation/Disabled/");
3188 const bool kResolutionScalingEnabled = true;
3189 const bool kFpsScalingEnabled = false;
3190 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3191}
3192
3193TEST_F(WebRtcVideoChannelTest,
3194 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3195 webrtc::test::ScopedFieldTrials override_field_trials_(
3196 "WebRTC-Video-BalancedDegradation/Enabled/");
3197 const bool kResolutionScalingEnabled = true;
3198 const bool kFpsScalingEnabled = true;
3199 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3200}
3201
eladalonf1841382017-06-12 01:16:46 -07003202TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003203 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003204}
3205
eladalonf1841382017-06-12 01:16:46 -07003206TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003207 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003208}
3209
Niels Möller3de32e62019-01-18 08:42:18 +01003210TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3211 TestCpuAdaptation(false, true);
3212}
3213
eladalonf1841382017-06-12 01:16:46 -07003214TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003215 TestCpuAdaptation(true, true);
3216}
3217
eladalonf1841382017-06-12 01:16:46 -07003218TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003219 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003220 cricket::VideoSendParameters parameters;
3221 parameters.codecs.push_back(codec);
3222
kthelgason2bc68642017-02-07 07:02:22 -08003223 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003224 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003225 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003226 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003227 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003228 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3229
3230 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003231 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003232
Per766ad3b2016-04-05 15:23:49 +02003233 ASSERT_TRUE(channel_->SetSend(true));
3234 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003235 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003236 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003237
3238 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3239 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003240
Niels Möllerdcc70292019-01-15 16:32:38 +01003241 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3242 // Dont' expect anything on framerate_scaling_enabled, since the default is
3243 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003244
Niels Möllerdcc70292019-01-15 16:32:38 +01003245 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003246 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003247 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003248 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003249 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3250 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003251 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003252
Niels Möllerdcc70292019-01-15 16:32:38 +01003253 // Switch back to the normal capturer. Expect resolution scaling to be
3254 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003255 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3256 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003257 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3258 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003259 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003260
Niels Möllerff40b142018-04-09 08:49:14 +02003261 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003262}
3263
asapersson3c81a1a2017-06-14 05:52:21 -07003264// TODO(asapersson): Remove this test when the balanced field trial is removed.
3265void WebRtcVideoChannelTest::TestDegradationPreference(
3266 bool resolution_scaling_enabled,
3267 bool fps_scaling_enabled) {
3268 cricket::VideoCodec codec = GetEngineCodec("VP8");
3269 cricket::VideoSendParameters parameters;
3270 parameters.codecs.push_back(codec);
3271
3272 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003273 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003274 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003275 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003276 channel_->OnReadyToSend(true);
3277
3278 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3279
3280 AddSendStream();
3281
Niels Möller805a27e2019-01-21 12:21:27 +01003282 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003283 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003284 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003285
3286 EXPECT_TRUE(channel_->SetSend(true));
3287
3288 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3289 EXPECT_EQ(resolution_scaling_enabled,
3290 send_stream->resolution_scaling_enabled());
3291 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3292
Niels Möllerff40b142018-04-09 08:49:14 +02003293 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003294}
3295
eladalonf1841382017-06-12 01:16:46 -07003296void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3297 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003298 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003299 cricket::VideoSendParameters parameters;
3300 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003301
kthelgason2bc68642017-02-07 07:02:22 -08003302 MediaConfig media_config = GetMediaConfig();
3303 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003304 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003305 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003306 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003307 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003308 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003309
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003310 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003311
3312 AddSendStream();
3313
Niels Möller805a27e2019-01-21 12:21:27 +01003314 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003315 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003316 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003317 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003318
3319 EXPECT_TRUE(channel_->SetSend(true));
3320
solenberge5269742015-09-08 05:13:22 -07003321 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003322
sprangc5d62e22017-04-02 23:53:04 -07003323 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003324 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003325 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003326 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003327 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3328 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3329 } else {
3330 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3331 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3332 }
Niels Möllerff40b142018-04-09 08:49:14 +02003333 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003334}
3335
eladalonf1841382017-06-12 01:16:46 -07003336TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003337 // Start at last timestamp to verify that wraparounds are estimated correctly.
3338 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3339 static const int64_t kInitialNtpTimeMs = 1247891230;
3340 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003341 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003342
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003343 FakeVideoReceiveStream* stream = AddRecvStream();
3344 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003345 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003346
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003347 webrtc::VideoFrame video_frame =
3348 webrtc::VideoFrame::Builder()
3349 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3350 .set_timestamp_rtp(kInitialTimestamp)
3351 .set_timestamp_us(0)
3352 .set_rotation(webrtc::kVideoRotation_0)
3353 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003354 // Initial NTP time is not available on the first frame, but should still be
3355 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003356 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003357
3358 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003359
3360 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3361 // triggers a constant-overflow warning, hence we're calculating it explicitly
3362 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003363 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003364 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3365 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003366 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003367
3368 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003369
3370 // Verify that NTP time has been correctly deduced.
3371 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003372 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003373 ASSERT_EQ(1u, info.receivers.size());
3374 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003375}
3376
eladalonf1841382017-06-12 01:16:46 -07003377TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003378 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003379 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003380
3381 VideoCodec codec;
3382 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003383 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003384
3385 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003386 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3387 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003388 FakeVideoSendStream* stream = AddSendStream(
3389 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003390 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003391
3392 // Make sure NACK and FEC are enabled on the correct payload types.
3393 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003394 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3395 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003396
3397 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3398 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003399 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003400 // TODO(juberti): Check RTCP, PLI, TMMBR.
3401}
3402
brandtr31bd2242017-05-19 05:47:46 -07003403// The following four tests ensures that FlexFEC is not activated by default
3404// when the field trials are not enabled.
3405// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3406// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003407TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003408 FakeVideoSendStream* stream = AddSendStream();
3409 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3410
brandtr3d200bd2017-01-16 06:59:19 -08003411 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003412 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3413 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003414}
3415
eladalonf1841382017-06-12 01:16:46 -07003416TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003417 FakeVideoSendStream* stream = AddSendStream(
3418 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3419 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3420
brandtr3d200bd2017-01-16 06:59:19 -08003421 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003422 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3423 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3424}
3425
Yves Gerey665174f2018-06-19 15:03:05 +02003426TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003427 AddRecvStream();
3428
3429 const std::vector<FakeFlexfecReceiveStream*>& streams =
3430 fake_call_->GetFlexfecReceiveStreams();
3431 EXPECT_TRUE(streams.empty());
3432}
3433
eladalonf1841382017-06-12 01:16:46 -07003434TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003435 AddRecvStream(
3436 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3437
3438 const std::vector<FakeFlexfecReceiveStream*>& streams =
3439 fake_call_->GetFlexfecReceiveStreams();
3440 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003441}
3442
3443// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3444// tests that use this test fixture into the corresponding "non-field trial"
3445// tests.
eladalonf1841382017-06-12 01:16:46 -07003446class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003447 public:
eladalonf1841382017-06-12 01:16:46 -07003448 WebRtcVideoChannelFlexfecRecvTest()
3449 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003450};
3451
eladalonf1841382017-06-12 01:16:46 -07003452TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003453 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3454 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3455 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3456}
3457
eladalonf1841382017-06-12 01:16:46 -07003458TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003459 AddRecvStream();
3460
3461 const std::vector<FakeFlexfecReceiveStream*>& streams =
3462 fake_call_->GetFlexfecReceiveStreams();
3463 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003464
3465 const std::vector<FakeVideoReceiveStream*>& video_streams =
3466 fake_call_->GetVideoReceiveStreams();
3467 ASSERT_EQ(1U, video_streams.size());
3468 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3469 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3470 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003471}
3472
eladalonf1841382017-06-12 01:16:46 -07003473TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003474 AddRecvStream(
3475 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3476
3477 const std::vector<FakeFlexfecReceiveStream*>& streams =
3478 fake_call_->GetFlexfecReceiveStreams();
3479 ASSERT_EQ(1U, streams.size());
3480 const FakeFlexfecReceiveStream* stream = streams.front();
3481 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3482 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3483 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3484 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3485 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003486
3487 const std::vector<FakeVideoReceiveStream*>& video_streams =
3488 fake_call_->GetVideoReceiveStreams();
3489 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003490 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3491 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003492 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003493 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003494 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003495}
3496
eladalonf1841382017-06-12 01:16:46 -07003497TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003498 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3499 cricket::VideoRecvParameters recv_parameters;
3500 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3501 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3502
3503 AddRecvStream(
3504 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3505 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003506 const std::vector<FakeVideoReceiveStream*>& video_streams =
3507 fake_call_->GetVideoReceiveStreams();
3508 ASSERT_EQ(1U, video_streams.size());
3509 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3510 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3511 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003512
3513 // Enable FlexFEC.
3514 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3515 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3516 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3517 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3518 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3519 << "Enabling FlexFEC should not create VideoReceiveStream.";
3520 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3521 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003522 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3523 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003524}
3525
eladalonf1841382017-06-12 01:16:46 -07003526TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003527 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3528 cricket::VideoRecvParameters recv_parameters;
3529 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3530 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3531 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3532
3533 AddRecvStream(
3534 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3535 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003536 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003537 const std::vector<FakeVideoReceiveStream*>& video_streams =
3538 fake_call_->GetVideoReceiveStreams();
3539 ASSERT_EQ(1U, video_streams.size());
3540 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3541 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3542 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003543
3544 // Disable FlexFEC.
3545 recv_parameters.codecs.clear();
3546 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3547 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3548 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3549 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3550 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3551 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3552 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3553 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003554 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3555 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003556}
3557
brandtr31bd2242017-05-19 05:47:46 -07003558// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3559// tests that use this test fixture into the corresponding "non-field trial"
3560// tests.
eladalonf1841382017-06-12 01:16:46 -07003561class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003562 public:
eladalonf1841382017-06-12 01:16:46 -07003563 WebRtcVideoChannelFlexfecSendRecvTest()
3564 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003565 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3566 }
3567};
3568
Yves Gerey665174f2018-06-19 15:03:05 +02003569TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003570 FakeVideoSendStream* stream = AddSendStream();
3571 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3572
brandtr3d200bd2017-01-16 06:59:19 -08003573 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3574 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3575 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003576}
3577
eladalonf1841382017-06-12 01:16:46 -07003578TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003579 FakeVideoSendStream* stream = AddSendStream(
3580 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3581 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3582
brandtr3d200bd2017-01-16 06:59:19 -08003583 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3584 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3585 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3586 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003587}
3588
eladalonf1841382017-06-12 01:16:46 -07003589TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003590 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003591 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003592 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003593
3594 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003595 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003596
brandtrb5f2c3f2016-10-04 23:28:39 -07003597 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3598 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003599}
3600
eladalonf1841382017-06-12 01:16:46 -07003601TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003602 cricket::VideoSendParameters parameters;
3603 parameters.codecs.push_back(GetEngineCodec("VP8"));
3604 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3605
3606 FakeVideoSendStream* stream = AddSendStream();
3607 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3608
brandtr3d200bd2017-01-16 06:59:19 -08003609 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003610}
3611
eladalonf1841382017-06-12 01:16:46 -07003612TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003613 AddRecvStream(
3614 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003615
3616 cricket::VideoRecvParameters recv_parameters;
3617 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3618 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3619 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003620
3621 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3622 fake_call_->GetFlexfecReceiveStreams();
3623 ASSERT_EQ(1U, flexfec_streams.size());
3624 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3625 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3626 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003627 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003628 flexfec_stream_config.payload_type);
3629 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3630 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3631 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3632 const std::vector<FakeVideoReceiveStream*>& video_streams =
3633 fake_call_->GetVideoReceiveStreams();
3634 const FakeVideoReceiveStream* video_stream = video_streams.front();
3635 const webrtc::VideoReceiveStream::Config& video_stream_config =
3636 video_stream->GetConfig();
3637 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3638 flexfec_stream_config.local_ssrc);
3639 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3640 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3641 flexfec_stream_config.rtcp_send_transport);
3642 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3643 // spec-compliant way.
3644 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3645 flexfec_stream_config.transport_cc);
3646 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3647 EXPECT_EQ(video_stream_config.rtp.extensions,
3648 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003649}
3650
brandtr31bd2242017-05-19 05:47:46 -07003651// We should not send FlexFEC, even if we advertise it, unless the right
3652// field trial is set.
3653// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003654TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003655 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3656 cricket::VideoSendParameters parameters;
3657 parameters.codecs.push_back(GetEngineCodec("VP8"));
3658 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3659 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3660
3661 FakeVideoSendStream* stream = AddSendStream();
3662 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3663
3664 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003665 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003666 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3667}
3668
eladalonf1841382017-06-12 01:16:46 -07003669TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003670 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3671 cricket::VideoSendParameters parameters;
3672 parameters.codecs.push_back(GetEngineCodec("VP8"));
3673 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3674 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3675
3676 FakeVideoSendStream* stream = AddSendStream(
3677 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3678 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3679
3680 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003681 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003682 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3683}
3684
eladalonf1841382017-06-12 01:16:46 -07003685TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003686 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003687 const int kUnusedPayloadType = 127;
3688 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3689
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003690 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003691 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003692 parameters.codecs.push_back(rtx_codec);
3693 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003694 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003695}
3696
eladalonf1841382017-06-12 01:16:46 -07003697TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003698 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003699 const int kUnusedPayloadType1 = 126;
3700 const int kUnusedPayloadType2 = 127;
3701 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3702 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3703 {
3704 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3705 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3706 cricket::VideoSendParameters parameters;
3707 parameters.codecs.push_back(GetEngineCodec("VP8"));
3708 parameters.codecs.push_back(rtx_codec);
3709 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3710 }
3711 {
3712 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3713 kUnusedPayloadType1, kUnusedPayloadType2);
3714 cricket::VideoSendParameters parameters;
3715 parameters.codecs.push_back(GetEngineCodec("VP8"));
3716 parameters.codecs.push_back(rtx_codec);
3717 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3718 << "RTX without matching video codec should be rejected.";
3719 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003720}
3721
eladalonf1841382017-06-12 01:16:46 -07003722TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003723 const int kUnusedPayloadType1 = 126;
3724 const int kUnusedPayloadType2 = 127;
3725 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3726 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3727
3728 // SSRCs for RTX.
3729 cricket::StreamParams params =
3730 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3731 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3732 AddSendStream(params);
3733
3734 // Original payload type for RTX.
3735 cricket::VideoSendParameters parameters;
3736 parameters.codecs.push_back(GetEngineCodec("VP8"));
3737 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3738 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3739 parameters.codecs.push_back(rtx_codec);
3740 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3741 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3742 const webrtc::VideoSendStream::Config& config_before =
3743 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3744 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3745 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3746 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3747
3748 // Change payload type for RTX.
3749 parameters.codecs[1].id = kUnusedPayloadType2;
3750 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3751 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3752 const webrtc::VideoSendStream::Config& config_after =
3753 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3754 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3755 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3756 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3757}
3758
eladalonf1841382017-06-12 01:16:46 -07003759TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003760 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003761 parameters.codecs.push_back(GetEngineCodec("VP8"));
3762 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003763 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003764
3765 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003766 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003767
magjed509e4fe2016-11-18 01:34:11 -08003768 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003769
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003770 parameters.codecs.pop_back();
3771 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003772 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003773 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003774 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003775 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003776 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3777}
3778
eladalonf1841382017-06-12 01:16:46 -07003779TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003780 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003781 cricket::VideoSendParameters parameters;
3782 parameters.codecs.push_back(GetEngineCodec("VP8"));
3783 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3784 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3785
3786 FakeVideoSendStream* stream = AddSendStream(
3787 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3788 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3789
brandtr3d200bd2017-01-16 06:59:19 -08003790 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3791 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003792 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3793 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3794
3795 parameters.codecs.pop_back();
3796 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3797 stream = fake_call_->GetVideoSendStreams()[0];
3798 ASSERT_TRUE(stream != nullptr);
3799 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003800 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003801 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003802}
3803
eladalonf1841382017-06-12 01:16:46 -07003804TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003805 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003806 cricket::VideoCodec codec(100, "VP8");
3807 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3808 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003809
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003810 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003811 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003812
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003813 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003814 webrtc::test::FrameForwarder frame_forwarder;
3815 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003816
3817 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003818 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003819
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003820 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003821 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3822 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003823 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003824 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003825 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003826 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003827}
3828
eladalonf1841382017-06-12 01:16:46 -07003829TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003830 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3831 200000);
3832}
3833
eladalonf1841382017-06-12 01:16:46 -07003834TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003835 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3836 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3837 ASSERT_EQ(1u, streams.size());
3838 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3839}
3840
eladalonf1841382017-06-12 01:16:46 -07003841TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003842 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003843 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003844}
3845
eladalonf1841382017-06-12 01:16:46 -07003846TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003847 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003848}
3849
eladalonf1841382017-06-12 01:16:46 -07003850TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003851 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3852 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3853 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003854}
3855
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003856// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3857// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003858TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003859 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3860 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3861 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3862 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003863 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003864 ExpectSetBitrateParameters(100000, 200000, 400000);
3865 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3866 // Since the codec isn't changing, start_bitrate_bps should be -1.
3867 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003868
3869 // Decrease max_bandwidth_bps.
3870 send_parameters_.max_bandwidth_bps = 350000;
3871 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003872
3873 // Now try again with the values flipped around.
3874 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3875 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003876 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003877 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003878
3879 // If we change the codec max, max_bandwidth_bps should still apply.
3880 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003881 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003882 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003883}
3884
Yves Gerey665174f2018-06-19 15:03:05 +02003885TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003886 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3887 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003888 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003889 // Setting max bitrate should keep previous min bitrate.
3890 // Setting max bitrate should not reset start bitrate.
3891 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003892 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00003893}
3894
eladalonf1841382017-06-12 01:16:46 -07003895TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003896 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003897 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003898 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08003899 // -1 means to disable max bitrate (set infinite).
3900 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003901 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003902 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003903}
3904
eladalonf1841382017-06-12 01:16:46 -07003905TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07003906 send_parameters_.max_bandwidth_bps = 99999;
3907 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003908 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003909 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07003910 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3911 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3912 stream->GetVideoStreams()[0].max_bitrate_bps);
3913
3914 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003915 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07003916 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3917 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07003918 stream->GetVideoStreams()[0].max_bitrate_bps);
3919}
3920
Seth Hampsonfeec91e2018-07-13 10:41:10 -07003921// Tests that when the codec specific max bitrate and VideoSendParameters
3922// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
3923// appropriately.
3924TEST_F(WebRtcVideoChannelTest,
3925 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
3926 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3927 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3928 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3929 send_parameters_.max_bandwidth_bps = -1;
3930 AddSendStream();
3931 ExpectSetMaxBitrate(300000);
3932 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3933
3934 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
3935 ASSERT_EQ(1u, video_send_streams.size());
3936 FakeVideoSendStream* video_send_stream = video_send_streams[0];
3937 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
3938 // First the max bitrate is set based upon the codec param.
3939 EXPECT_EQ(300000,
3940 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
3941
3942 // The VideoSendParameters max bitrate overrides the codec's.
3943 send_parameters_.max_bandwidth_bps = 500000;
3944 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
3945 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3946 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3947 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3948}
3949
3950// Tests that when the codec specific max bitrate and RtpParameters
3951// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
3952// appropriately.
3953TEST_F(WebRtcVideoChannelTest,
3954 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
3955 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3956 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3957 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3958 send_parameters_.max_bandwidth_bps = -1;
3959 AddSendStream();
3960 ExpectSetMaxBitrate(300000);
3961 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3962
3963 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
3964 ASSERT_EQ(1u, video_send_streams.size());
3965 FakeVideoSendStream* video_send_stream = video_send_streams[0];
3966 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3967 // First the max bitrate is set based upon the codec param.
3968 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3969
3970 // The RtpParameter max bitrate overrides the codec's.
3971 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
3972 ASSERT_EQ(1u, parameters.encodings.size());
3973 parameters.encodings[0].max_bitrate_bps = 500000;
3974 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
3975 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
3976 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
3977 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
3978}
3979
Åsa Persson55659812018-06-18 17:51:32 +02003980TEST_F(WebRtcVideoChannelTest,
3981 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
3982 send_parameters_.max_bandwidth_bps = 99999;
3983 FakeVideoSendStream* stream = AddSendStream();
3984 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
3985 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
3986 ASSERT_EQ(1u, stream->GetVideoStreams().size());
3987 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
3988 stream->GetVideoStreams()[0].max_bitrate_bps);
3989
3990 // Get and set the rtp encoding parameters.
3991 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
3992 EXPECT_EQ(1u, parameters.encodings.size());
3993
3994 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
3995 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
3996 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
3997 stream->GetVideoStreams()[0].max_bitrate_bps);
3998
3999 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4000 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4001 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4002 stream->GetVideoStreams()[0].max_bitrate_bps);
4003}
4004
eladalonf1841382017-06-12 01:16:46 -07004005TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004006 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004007 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004008 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004009 channel_->SetSend(true);
4010
4011 FakeVideoSendStream* stream = AddSendStream();
4012
Niels Möller805a27e2019-01-21 12:21:27 +01004013 webrtc::test::FrameForwarder frame_forwarder;
4014 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004015
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004016 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4017 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4018 EXPECT_GT(initial_max_bitrate_bps, 0);
4019
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004020 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4021 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004022 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004023 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004024 streams = stream->GetVideoStreams();
4025 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004026 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004027}
4028
eladalonf1841382017-06-12 01:16:46 -07004029TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004030 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004031 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004032 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004033 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004034 channel_->SetSend(true);
4035
4036 FakeVideoSendStream* stream = AddSendStream(
4037 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4038
4039 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004040 webrtc::test::FrameForwarder frame_forwarder;
4041 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4042 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004043
4044 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4045 ASSERT_GT(streams.size(), 1u)
4046 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004047 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004048 EXPECT_GT(initial_max_bitrate_bps, 0);
4049
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004050 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4051 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004052 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004053 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004054 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004055 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004056 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4057
Niels Möllerff40b142018-04-09 08:49:14 +02004058 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004059}
4060
eladalonf1841382017-06-12 01:16:46 -07004061TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004062 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004063 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004064 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004065 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4066 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004067 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004068 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004069
4070 VideoCodec codec;
4071 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4072 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4073}
4074
eladalonf1841382017-06-12 01:16:46 -07004075TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004076 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004077 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004078 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004079 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004080 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004081 parameters.codecs[0].id = kIncorrectPayloads[i];
4082 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004083 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004084 }
4085}
4086
eladalonf1841382017-06-12 01:16:46 -07004087TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004088 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004089 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004090 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004091 parameters.codecs[0].id = payload_type;
4092 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004093 << "Payload type '" << payload_type << "' rejected.";
4094 }
4095}
4096
deadbeef67cf2c12016-04-13 10:07:16 -07004097// Test that setting the a different set of codecs but with an identical front
4098// codec doesn't result in the stream being recreated.
4099// This may happen when a subsequent negotiation includes fewer codecs, as a
4100// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004101TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004102 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4103 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004104 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4105 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004106 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4107
4108 AddSendStream();
4109 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4110
4111 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004112 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004113 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4114 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4115}
4116
eladalonf1841382017-06-12 01:16:46 -07004117TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004118 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004119 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004120 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004121}
4122
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004123// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004124TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004125 const int kUnusedPayloadType1 = 126;
4126 const int kUnusedPayloadType2 = 127;
4127 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4128 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4129
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004130 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004131 parameters.codecs.push_back(GetEngineCodec("VP8"));
4132 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004133 parameters.codecs.push_back(rtx_codec);
4134 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004135 << "RTX codec without associated payload should be rejected.";
4136
magjed509e4fe2016-11-18 01:34:11 -08004137 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004138 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004139 << "RTX codec with invalid associated payload type should be rejected.";
4140
magjed509e4fe2016-11-18 01:34:11 -08004141 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004142 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004143
magjed509e4fe2016-11-18 01:34:11 -08004144 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004145 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004146 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004147
Yves Gerey665174f2018-06-19 15:03:05 +02004148 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4149 << "RTX codec with another RTX as associated payload type should be "
4150 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004151}
4152
eladalonf1841382017-06-12 01:16:46 -07004153TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004154 const int kUnusedPayloadType1 = 126;
4155 const int kUnusedPayloadType2 = 127;
4156 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4157 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4158
4159 // SSRCs for RTX.
4160 cricket::StreamParams params =
4161 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4162 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4163 AddRecvStream(params);
4164
4165 // Original payload type for RTX.
4166 cricket::VideoRecvParameters parameters;
4167 parameters.codecs.push_back(GetEngineCodec("VP8"));
4168 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4169 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4170 parameters.codecs.push_back(rtx_codec);
4171 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4172 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4173 const webrtc::VideoReceiveStream::Config& config_before =
4174 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004175 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4176 const int* payload_type_before = FindKeyByValue(
4177 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4178 ASSERT_NE(payload_type_before, nullptr);
4179 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004180 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4181
4182 // Change payload type for RTX.
4183 parameters.codecs[1].id = kUnusedPayloadType2;
4184 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4185 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4186 const webrtc::VideoReceiveStream::Config& config_after =
4187 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004188 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4189 const int* payload_type_after = FindKeyByValue(
4190 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4191 ASSERT_NE(payload_type_after, nullptr);
4192 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004193 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4194}
4195
eladalonf1841382017-06-12 01:16:46 -07004196TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004197 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004198 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004199 parameters.codecs[0].id = 99;
4200 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004201}
4202
eladalonf1841382017-06-12 01:16:46 -07004203TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004204 cricket::VideoRecvParameters parameters;
4205 parameters.codecs = engine_.codecs();
4206 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004207
4208 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004209 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004210 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004211 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004212}
4213
eladalonf1841382017-06-12 01:16:46 -07004214TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004215 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004216 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004217 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004218 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004219}
4220
eladalonf1841382017-06-12 01:16:46 -07004221TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004222 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004223 parameters.codecs.push_back(GetEngineCodec("VP8"));
4224 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004225 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004226}
4227
eladalonf1841382017-06-12 01:16:46 -07004228TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004229 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004230 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4231 send_parameters.codecs.push_back(GetEngineCodec("red"));
4232 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004233 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004234
4235 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004236
magjed509e4fe2016-11-18 01:34:11 -08004237 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004238 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004239
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004240 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004241 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004242 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004243 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004244 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004245 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004246 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4247}
4248
eladalonf1841382017-06-12 01:16:46 -07004249TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004250 AddRecvStream(
4251 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004252 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004253 fake_call_->GetFlexfecReceiveStreams();
4254
4255 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004256 const FakeFlexfecReceiveStream* stream = streams.front();
4257 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4258 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4259 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4260 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004261
4262 cricket::VideoRecvParameters recv_parameters;
4263 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4264 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4265 EXPECT_TRUE(streams.empty())
4266 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004267}
4268
eladalonf1841382017-06-12 01:16:46 -07004269TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004270 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004271 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004272 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004273
4274 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004275 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4276 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4277 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004278 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4279 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004280 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004281 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004282 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004283 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004284
4285 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004286 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4287 send_parameters.codecs.push_back(GetEngineCodec("red"));
4288 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004289 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4290 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004291 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004292 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004293 << "ULPFEC should be enabled on the receive stream.";
4294}
4295
eladalonf1841382017-06-12 01:16:46 -07004296TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004297 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004298 AddRecvStream(
4299 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004300 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004301 fake_call_->GetFlexfecReceiveStreams();
4302
4303 cricket::VideoRecvParameters recv_parameters;
4304 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4305 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4306 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4307 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004308 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004309 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004310 stream_with_recv_params->GetConfig().payload_type);
4311 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004312 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004313 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004314 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004315 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004316
4317 cricket::VideoSendParameters send_parameters;
4318 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4319 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4320 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4321 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004322 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004323 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004324 stream_with_send_params->GetConfig().payload_type);
4325 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004326 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004327 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004328 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004329 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004330}
4331
eladalonf1841382017-06-12 01:16:46 -07004332TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004333 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004334 parameters.codecs.push_back(GetEngineCodec("VP8"));
4335 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004336 parameters.codecs[1].id = parameters.codecs[0].id;
4337 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004338}
4339
eladalonf1841382017-06-12 01:16:46 -07004340TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004341 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004342 cricket::VideoRecvParameters parameters;
4343 parameters.codecs.push_back(GetEngineCodec("VP8"));
4344 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4345 parameters.codecs[1].id = parameters.codecs[0].id;
4346 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4347}
4348
eladalonf1841382017-06-12 01:16:46 -07004349TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004350 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004351 parameters.codecs.push_back(GetEngineCodec("VP8"));
4352 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004353 parameters.codecs[1].id = parameters.codecs[0].id;
4354 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004355}
4356
eladalonf1841382017-06-12 01:16:46 -07004357TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004358 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004359 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004360 parameters.codecs.push_back(GetEngineCodec("VP8"));
4361 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004362 parameters.codecs[1].id += 1;
4363 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004364}
4365
deadbeef67cf2c12016-04-13 10:07:16 -07004366// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004367// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004368TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004369 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004370 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004371 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4372 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004373 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004374
4375 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4376 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4377
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004378 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004379 parameters2.codecs.push_back(GetEngineCodec("red"));
4380 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004381 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004382 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4383}
4384
eladalonf1841382017-06-12 01:16:46 -07004385TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004386 EXPECT_FALSE(AddSendStream()->IsSending());
4387}
4388
eladalonf1841382017-06-12 01:16:46 -07004389TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004390 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004391}
4392
eladalonf1841382017-06-12 01:16:46 -07004393TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004394 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004395 EXPECT_FALSE(stream->IsSending());
4396
4397 // false->true
4398 EXPECT_TRUE(channel_->SetSend(true));
4399 EXPECT_TRUE(stream->IsSending());
4400 // true->true
4401 EXPECT_TRUE(channel_->SetSend(true));
4402 EXPECT_TRUE(stream->IsSending());
4403 // true->false
4404 EXPECT_TRUE(channel_->SetSend(false));
4405 EXPECT_FALSE(stream->IsSending());
4406 // false->false
4407 EXPECT_TRUE(channel_->SetSend(false));
4408 EXPECT_FALSE(stream->IsSending());
4409
4410 EXPECT_TRUE(channel_->SetSend(true));
4411 FakeVideoSendStream* new_stream = AddSendStream();
4412 EXPECT_TRUE(new_stream->IsSending())
4413 << "Send stream created after SetSend(true) not sending initially.";
4414}
4415
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004416// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004417TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004418 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004419 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004420 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004421 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004422 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004423
Sebastian Jansson84848f22018-11-16 10:40:36 +01004424 channel.reset(
4425 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4426 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004427 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004428 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004429 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004430
Tim Haloun648d28a2018-10-18 16:52:22 -07004431 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4432 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004433 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004434 channel.reset(
4435 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4436 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004437 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004438 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4439
4440 // Create a send stream to configure
4441 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4442 parameters = channel->GetRtpSendParameters(kSsrc);
4443 ASSERT_FALSE(parameters.encodings.empty());
4444
4445 // Various priorities map to various dscp values.
4446 parameters.encodings[0].network_priority = 4.0;
4447 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004448 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004449 parameters.encodings[0].network_priority = 0.5;
4450 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4451 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4452
4453 // A bad priority does not change the dscp value.
4454 parameters.encodings[0].network_priority = 0.0;
4455 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4456 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004457
Tim Haloun6ca98362018-09-17 17:06:08 -07004458 // Packets should also self-identify their dscp in PacketOptions.
4459 const uint8_t kData[10] = {0};
4460 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4461 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004462 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004463
nisse51542be2016-02-12 02:27:06 -08004464 // Verify that setting the option to false resets the
4465 // DiffServCodePoint.
4466 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004467 channel.reset(
4468 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4469 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004470 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004471 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004472}
4473
deadbeef13871492015-12-09 12:37:51 -08004474// This test verifies that the RTCP reduced size mode is properly applied to
4475// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004476TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004477 // Create stream, expecting that default mode is "compound".
4478 FakeVideoSendStream* stream1 = AddSendStream();
4479 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004480 webrtc::RtpParameters rtp_parameters =
4481 channel_->GetRtpSendParameters(last_ssrc_);
4482 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004483
4484 // Now enable reduced size mode.
4485 send_parameters_.rtcp.reduced_size = true;
4486 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4487 stream1 = fake_call_->GetVideoSendStreams()[0];
4488 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004489 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4490 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004491
4492 // Create a new stream and ensure it picks up the reduced size mode.
4493 FakeVideoSendStream* stream2 = AddSendStream();
4494 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4495}
4496
4497// This test verifies that the RTCP reduced size mode is properly applied to
4498// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004499TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004500 // Create stream, expecting that default mode is "compound".
4501 FakeVideoReceiveStream* stream1 = AddRecvStream();
4502 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4503
4504 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004505 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4506 // the reduced_size flag should come from that.
4507 send_parameters_.rtcp.reduced_size = true;
4508 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004509 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4510 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4511
4512 // Create a new stream and ensure it picks up the reduced size mode.
4513 FakeVideoReceiveStream* stream2 = AddRecvStream();
4514 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4515}
4516
eladalonf1841382017-06-12 01:16:46 -07004517TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004518 EXPECT_EQ(webrtc::kNetworkUp,
4519 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4520 EXPECT_EQ(webrtc::kNetworkUp,
4521 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004522
4523 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004524 EXPECT_EQ(webrtc::kNetworkDown,
4525 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4526 EXPECT_EQ(webrtc::kNetworkUp,
4527 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004528
4529 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004530 EXPECT_EQ(webrtc::kNetworkUp,
4531 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4532 EXPECT_EQ(webrtc::kNetworkUp,
4533 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004534}
4535
eladalonf1841382017-06-12 01:16:46 -07004536TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004537 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004538 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004539 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004540
4541 AddSendStream();
4542
4543 cricket::VideoMediaInfo info;
4544 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004545 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004546}
4547
eladalonf1841382017-06-12 01:16:46 -07004548TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004549 FakeVideoSendStream* stream = AddSendStream();
4550 webrtc::VideoSendStream::Stats stats;
4551 stats.encoder_implementation_name = "encoder_implementation_name";
4552 stream->SetStats(stats);
4553
4554 cricket::VideoMediaInfo info;
4555 ASSERT_TRUE(channel_->GetStats(&info));
4556 EXPECT_EQ(stats.encoder_implementation_name,
4557 info.senders[0].encoder_implementation_name);
4558}
4559
eladalonf1841382017-06-12 01:16:46 -07004560TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004561 FakeVideoSendStream* stream = AddSendStream();
4562 webrtc::VideoSendStream::Stats stats;
4563 stats.avg_encode_time_ms = 13;
4564 stats.encode_usage_percent = 42;
4565 stream->SetStats(stats);
4566
4567 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004568 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004569 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4570 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4571}
4572
eladalonf1841382017-06-12 01:16:46 -07004573TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004574 FakeVideoSendStream* stream = AddSendStream();
4575 webrtc::VideoSendStream::Stats stats;
4576 stats.frames_encoded = 13;
4577 stream->SetStats(stats);
4578
4579 cricket::VideoMediaInfo info;
4580 ASSERT_TRUE(channel_->GetStats(&info));
4581 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4582}
4583
eladalonf1841382017-06-12 01:16:46 -07004584TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004585 FakeVideoSendStream* stream = AddSendStream();
4586 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004587 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004588 stream->SetStats(stats);
4589
4590 cricket::VideoMediaInfo info;
4591 ASSERT_TRUE(channel_->GetStats(&info));
4592 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4593}
4594
eladalonf1841382017-06-12 01:16:46 -07004595TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004596 FakeVideoSendStream* stream = AddSendStream();
4597 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004598 stats.substreams[17].width = 123;
4599 stats.substreams[17].height = 40;
4600 stats.substreams[42].width = 80;
4601 stats.substreams[42].height = 31;
4602 stats.substreams[11].width = 20;
4603 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004604 stream->SetStats(stats);
4605
4606 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004607 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004608 ASSERT_EQ(1u, info.senders.size());
4609 EXPECT_EQ(123, info.senders[0].send_frame_width);
4610 EXPECT_EQ(90, info.senders[0].send_frame_height);
4611}
4612
eladalonf1841382017-06-12 01:16:46 -07004613TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004614 FakeVideoSendStream* stream = AddSendStream();
4615 webrtc::VideoSendStream::Stats stats;
4616 stats.number_of_cpu_adapt_changes = 2;
4617 stats.cpu_limited_resolution = true;
4618 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004619
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004620 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004621 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004622 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004623 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004624 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004625}
4626
eladalonf1841382017-06-12 01:16:46 -07004627TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004628 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004629 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004630 stats.number_of_cpu_adapt_changes = 2;
4631 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004632 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004633 stream->SetStats(stats);
4634
4635 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004636 EXPECT_TRUE(channel_->GetStats(&info));
4637 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004638 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4639 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004640 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004641 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004642}
4643
eladalonf1841382017-06-12 01:16:46 -07004644TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004645 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4646 FakeVideoSendStream* stream = AddSendStream();
4647 webrtc::VideoSendStream::Stats stats;
4648 stats.bw_limited_resolution = true;
4649 stream->SetStats(stats);
4650
4651 cricket::VideoMediaInfo info;
4652 EXPECT_TRUE(channel_->GetStats(&info));
4653 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004654 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004655 info.senders[0].adapt_reason);
4656}
4657
Yves Gerey665174f2018-06-19 15:03:05 +02004658TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004659 FakeVideoSendStream* stream = AddSendStream();
4660 webrtc::VideoSendStream::Stats stats;
4661 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4662 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4663 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4664
4665 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4666 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4667 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4668
4669 stream->SetStats(stats);
4670
4671 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004672 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004673 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4674 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4675 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4676}
4677
eladalonf1841382017-06-12 01:16:46 -07004678TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004679 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4680 FakeVideoReceiveStream* stream = AddRecvStream();
4681 webrtc::VideoReceiveStream::Stats stats;
4682 stats.rtcp_packet_type_counts.fir_packets = 2;
4683 stats.rtcp_packet_type_counts.nack_packets = 3;
4684 stats.rtcp_packet_type_counts.pli_packets = 4;
4685 stream->SetStats(stats);
4686
4687 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004688 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004689 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004690 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004691 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004692 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004693 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004694 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004695}
4696
eladalonf1841382017-06-12 01:16:46 -07004697TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004698 FakeVideoReceiveStream* stream = AddRecvStream();
4699 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004700 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004701 stats.decode_ms = 2;
4702 stats.max_decode_ms = 3;
4703 stats.current_delay_ms = 4;
4704 stats.target_delay_ms = 5;
4705 stats.jitter_buffer_ms = 6;
4706 stats.min_playout_delay_ms = 7;
4707 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004708 stats.width = 9;
4709 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004710 stats.frame_counts.key_frames = 11;
4711 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004712 stats.frames_rendered = 13;
4713 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004714 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004715 stream->SetStats(stats);
4716
4717 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004718 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004719 EXPECT_EQ(stats.decoder_implementation_name,
4720 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004721 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4722 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4723 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4724 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4725 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4726 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4727 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004728 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4729 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004730 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4731 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004732 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004733 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004734 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004735 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004736}
4737
eladalonf1841382017-06-12 01:16:46 -07004738TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004739 FakeVideoReceiveStream* stream = AddRecvStream();
4740 webrtc::VideoReceiveStream::Stats stats;
4741 stats.rtp_stats.transmitted.payload_bytes = 2;
4742 stats.rtp_stats.transmitted.header_bytes = 3;
4743 stats.rtp_stats.transmitted.padding_bytes = 4;
4744 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004745 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004746 stats.rtcp_stats.fraction_lost = 7;
4747 stream->SetStats(stats);
4748
4749 cricket::VideoMediaInfo info;
4750 ASSERT_TRUE(channel_->GetStats(&info));
4751 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4752 stats.rtp_stats.transmitted.header_bytes +
4753 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004754 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004755 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004756 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004757 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004758 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004759 info.receivers[0].fraction_lost);
4760}
4761
eladalonf1841382017-06-12 01:16:46 -07004762TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004763 AddSendStream();
4764 AddSendStream();
4765 webrtc::Call::Stats stats;
4766 stats.rtt_ms = 123;
4767 fake_call_->SetStats(stats);
4768
4769 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004770 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004771 ASSERT_EQ(2u, info.senders.size());
4772 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4773 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4774}
4775
eladalonf1841382017-06-12 01:16:46 -07004776TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004777 FakeVideoSendStream* stream = AddSendStream();
4778 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004779 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004780 stats.media_bitrate_bps = 123;
4781 stats.substreams[17].total_bitrate_bps = 1;
4782 stats.substreams[17].retransmit_bitrate_bps = 2;
4783 stats.substreams[42].total_bitrate_bps = 3;
4784 stats.substreams[42].retransmit_bitrate_bps = 4;
4785 stream->SetStats(stats);
4786
4787 FakeVideoSendStream* stream2 = AddSendStream();
4788 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004789 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004790 stats2.media_bitrate_bps = 321;
4791 stats2.substreams[13].total_bitrate_bps = 5;
4792 stats2.substreams[13].retransmit_bitrate_bps = 6;
4793 stats2.substreams[21].total_bitrate_bps = 7;
4794 stats2.substreams[21].retransmit_bitrate_bps = 8;
4795 stream2->SetStats(stats2);
4796
4797 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004798 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004799 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004800 BandwidthEstimationInfo bwe_info;
4801 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004802 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4803 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4804 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4805 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004806 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004807 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004808 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004809 bwe_info.actual_enc_bitrate);
4810 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004811 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004812 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004813 << "Bandwidth stats should take all streams into account.";
4814}
4815
eladalonf1841382017-06-12 01:16:46 -07004816TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004817 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004818
Peter Boström0c4e06b2015-10-07 12:23:21 +02004819 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4820 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004821
4822 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4823 const size_t kDataLength = 12;
4824 uint8_t data[kDataLength];
4825 memset(data, 0, sizeof(data));
4826 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07004827 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01004828 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004829
4830 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
4831 << "No default receive stream created.";
4832 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08004833 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004834 << "Default receive stream should not have configured RTX";
4835
4836 EXPECT_TRUE(channel_->AddRecvStream(
4837 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
4838 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08004839 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004840 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07004841 EXPECT_FALSE(
4842 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07004843 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02004844 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07004845 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02004846 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07004847 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08004848 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004849}
4850
eladalonf1841382017-06-12 01:16:46 -07004851TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004852 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01004853
Peter Boström0c4e06b2015-10-07 12:23:21 +02004854 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4855 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01004856
4857 StreamParams sp =
4858 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4859 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
4860
4861 EXPECT_FALSE(channel_->AddSendStream(sp));
4862 EXPECT_FALSE(channel_->AddRecvStream(sp));
4863}
4864
eladalonf1841382017-06-12 01:16:46 -07004865TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004866 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004867
Peter Boström0c4e06b2015-10-07 12:23:21 +02004868 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4869 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01004870
4871 StreamParams sp =
4872 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
4873
4874 EXPECT_TRUE(channel_->AddSendStream(sp));
4875 EXPECT_TRUE(channel_->AddRecvStream(sp));
4876
4877 // The RTX SSRC is already used in previous streams, using it should fail.
4878 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
4879 EXPECT_FALSE(channel_->AddSendStream(sp));
4880 EXPECT_FALSE(channel_->AddRecvStream(sp));
4881
4882 // After removing the original stream this should be fine to add (makes sure
4883 // that RTX ssrcs are not forever taken).
4884 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
4885 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
4886 EXPECT_TRUE(channel_->AddSendStream(sp));
4887 EXPECT_TRUE(channel_->AddRecvStream(sp));
4888}
4889
eladalonf1841382017-06-12 01:16:46 -07004890TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01004891 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02004892 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
4893 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004894 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004895
Peter Boströmd6f4c252015-03-26 16:23:04 +01004896 StreamParams sp =
4897 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
4898
4899 EXPECT_TRUE(channel_->AddSendStream(sp));
4900 EXPECT_TRUE(channel_->AddRecvStream(sp));
4901
4902 // One of the SSRCs is already used in previous streams, using it should fail.
4903 sp = cricket::CreateSimStreamParams("cname",
4904 MAKE_VECTOR(kOverlappingStreamSsrcs));
4905 EXPECT_FALSE(channel_->AddSendStream(sp));
4906 EXPECT_FALSE(channel_->AddRecvStream(sp));
4907
4908 // After removing the original stream this should be fine to add (makes sure
4909 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02004910 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
4911 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01004912 EXPECT_TRUE(channel_->AddSendStream(sp));
4913 EXPECT_TRUE(channel_->AddRecvStream(sp));
4914}
4915
eladalonf1841382017-06-12 01:16:46 -07004916TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004917 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02004918
4919 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
4920 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
4921
4922 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
4923 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
4924
4925 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
4926
4927 static const uint32_t kReceiverSsrcs[] = {3};
4928 static const uint32_t kReceiverRtxSsrcs[] = {2};
4929
4930 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
4931 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
4932 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
4933
4934 cricket::VideoMediaInfo info;
4935 ASSERT_TRUE(channel_->GetStats(&info));
4936
4937 ASSERT_EQ(1u, info.senders.size());
4938 ASSERT_EQ(1u, info.receivers.size());
4939
4940 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
4941 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
4942 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
4943}
4944
eladalonf1841382017-06-12 01:16:46 -07004945TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07004946 FakeVideoReceiveStream* stream = AddRecvStream();
4947 webrtc::VideoReceiveStream::Stats stats;
4948 cricket::VideoMediaInfo info;
4949
4950 // Report no codec name before receiving.
4951 stream->SetStats(stats);
4952 ASSERT_TRUE(channel_->GetStats(&info));
4953 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4954
4955 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08004956 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07004957 stream->SetStats(stats);
4958 ASSERT_TRUE(channel_->GetStats(&info));
4959 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
4960
4961 // Report no codec name for unknown playload types.
4962 stats.current_payload_type = 3;
4963 stream->SetStats(stats);
4964 ASSERT_TRUE(channel_->GetStats(&info));
4965 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
4966}
4967
Seth Hampson5897a6e2018-04-03 11:16:33 -07004968// Tests that when we add a stream without SSRCs, but contains a stream_id
4969// that it is stored and its stream id is later used when the first packet
4970// arrives to properly create a receive stream with a sync label.
4971TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
4972 const char kSyncLabel[] = "sync_label";
4973 cricket::StreamParams unsignaled_stream;
4974 unsignaled_stream.set_stream_ids({kSyncLabel});
4975 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
4976 // The stream shouldn't have been created at this point because it doesn't
4977 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02004978 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07004979
4980 // Create and deliver packet.
4981 const size_t kDataLength = 12;
4982 uint8_t data[kDataLength];
4983 memset(data, 0, sizeof(data));
4984 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
4985 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01004986 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07004987
4988 // The stream should now be created with the appropriate sync label.
4989 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
4990 EXPECT_EQ(kSyncLabel,
4991 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
4992
4993 // Removing the unsignaled stream should clear the cache. This time when
4994 // a default video receive stream is created it won't have a sync_group.
4995 ASSERT_TRUE(channel_->RemoveRecvStream(0));
4996 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
4997 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4998
Niels Möllere6933812018-11-05 13:01:41 +01004999 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005000 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5001 EXPECT_TRUE(
5002 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5003}
5004
eladalonf1841382017-06-12 01:16:46 -07005005void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005006 uint8_t payload_type,
5007 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005008 // kRedRtxPayloadType must currently be unused.
5009 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5010
noahricd10a68e2015-07-10 11:27:55 -07005011 // Add a RED RTX codec.
5012 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005013 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005014 recv_parameters_.codecs.push_back(red_rtx_codec);
5015 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005016
5017 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5018 const size_t kDataLength = 12;
5019 uint8_t data[kDataLength];
5020 memset(data, 0, sizeof(data));
5021
5022 rtc::Set8(data, 1, payload_type);
5023 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005024 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005025 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005026
5027 if (expect_created_receive_stream) {
5028 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5029 << "Should have created a receive stream for payload type: "
5030 << payload_type;
5031 } else {
5032 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5033 << "Shouldn't have created a receive stream for payload type: "
5034 << payload_type;
5035 }
5036}
5037
Åsa Persson2c7149b2018-10-15 09:36:10 +02005038class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5039 public:
5040 WebRtcVideoChannelDiscardUnknownSsrcTest()
5041 : WebRtcVideoChannelTest(
5042 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5043};
5044
5045TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5046 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5047 false /* expect_created_receive_stream */);
5048}
5049
eladalonf1841382017-06-12 01:16:46 -07005050TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005051 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5052 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005053}
5054
eladalonf1841382017-06-12 01:16:46 -07005055TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005056 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5057 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005058}
5059
eladalonf1841382017-06-12 01:16:46 -07005060TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005061 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005062 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5063 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5064 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5065 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005066}
5067
eladalonf1841382017-06-12 01:16:46 -07005068TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005069 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5070 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005071}
5072
eladalonf1841382017-06-12 01:16:46 -07005073TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005074 FlexfecPacketDoesntCreateUnsignalledStream) {
5075 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5076 false /* expect_created_receive_stream */);
5077}
5078
eladalonf1841382017-06-12 01:16:46 -07005079TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005080 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5081 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005082}
5083
mzanaty8a855d62017-02-17 15:46:43 -08005084// Test that receiving any unsignalled SSRC works even if it changes.
5085// The first unsignalled SSRC received will create a default receive stream.
5086// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005087TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005088 // Allow receiving VP8, VP9, H264 (if enabled).
5089 cricket::VideoRecvParameters parameters;
5090 parameters.codecs.push_back(GetEngineCodec("VP8"));
5091 parameters.codecs.push_back(GetEngineCodec("VP9"));
5092
5093#if defined(WEBRTC_USE_H264)
5094 cricket::VideoCodec H264codec(126, "H264");
5095 parameters.codecs.push_back(H264codec);
5096#endif
5097
5098 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5099 // No receive streams yet.
5100 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5101 cricket::FakeVideoRenderer renderer;
5102 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5103
5104 // Receive VP8 packet on first SSRC.
5105 uint8_t data[kMinRtpPacketLen];
5106 cricket::RtpHeader rtpHeader;
5107 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5108 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005109 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005110 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5111 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005112 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005113 // VP8 packet should create default receive stream.
5114 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005115 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005116 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5117 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005118 webrtc::VideoFrame video_frame =
5119 webrtc::VideoFrame::Builder()
5120 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5121 .set_timestamp_rtp(100)
5122 .set_timestamp_us(0)
5123 .set_rotation(webrtc::kVideoRotation_0)
5124 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005125 recv_stream->InjectFrame(video_frame);
5126 EXPECT_EQ(1, renderer.num_rendered_frames());
5127
5128 // Receive VP9 packet on second SSRC.
5129 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005130 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005131 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5132 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005133 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005134 // VP9 packet should replace the default receive SSRC.
5135 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5136 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5137 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5138 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005139 webrtc::VideoFrame video_frame2 =
5140 webrtc::VideoFrame::Builder()
5141 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5142 .set_timestamp_rtp(200)
5143 .set_timestamp_us(0)
5144 .set_rotation(webrtc::kVideoRotation_0)
5145 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005146 recv_stream->InjectFrame(video_frame2);
5147 EXPECT_EQ(2, renderer.num_rendered_frames());
5148
5149#if defined(WEBRTC_USE_H264)
5150 // Receive H264 packet on third SSRC.
5151 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005152 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005153 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5154 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005155 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005156 // H264 packet should replace the default receive SSRC.
5157 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5158 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5159 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5160 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005161 webrtc::VideoFrame video_frame3 =
5162 webrtc::VideoFrame::Builder()
5163 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5164 .set_timestamp_rtp(300)
5165 .set_timestamp_us(0)
5166 .set_rotation(webrtc::kVideoRotation_0)
5167 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005168 recv_stream->InjectFrame(video_frame3);
5169 EXPECT_EQ(3, renderer.num_rendered_frames());
5170#endif
5171}
5172
brandtr0dc57ea2017-05-29 23:33:31 -07005173// This test verifies that when a new default stream is created for a new
5174// unsignaled SSRC, the new stream does not overwrite any old stream that had
5175// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005176TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005177 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5178 cricket::VideoRecvParameters parameters;
5179 parameters.codecs.push_back(GetEngineCodec("VP8"));
5180 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5181
5182 // No streams signaled and no packets received, so we should not have any
5183 // stream objects created yet.
5184 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5185
5186 // Receive packet on an unsignaled SSRC.
5187 uint8_t data[kMinRtpPacketLen];
5188 cricket::RtpHeader rtp_header;
5189 rtp_header.payload_type = GetEngineCodec("VP8").id;
5190 rtp_header.seq_num = rtp_header.timestamp = 0;
5191 rtp_header.ssrc = kSsrcs3[0];
5192 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5193 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005194 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005195 // Default receive stream should be created.
5196 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5197 FakeVideoReceiveStream* recv_stream0 =
5198 fake_call_->GetVideoReceiveStreams()[0];
5199 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5200
5201 // Signal the SSRC.
5202 EXPECT_TRUE(
5203 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5204 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5205 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5206 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5207
5208 // Receive packet on a different unsignaled SSRC.
5209 rtp_header.ssrc = kSsrcs3[1];
5210 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5211 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005212 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005213 // New default receive stream should be created, but old stream should remain.
5214 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5215 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5216 FakeVideoReceiveStream* recv_stream1 =
5217 fake_call_->GetVideoReceiveStreams()[1];
5218 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5219}
5220
Seth Hampson7c682e02018-05-04 16:28:15 -07005221TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005222 AddSendStream();
5223
Niels Möller805a27e2019-01-21 12:21:27 +01005224 webrtc::test::FrameForwarder frame_forwarder;
5225 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005226 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005227 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005228
perkjfa10b552016-10-02 23:45:26 -07005229 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005230 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005231
5232 // TODO(skvlad): Resolve the inconsistency between the interpretation
5233 // of the global bitrate limit for audio and video:
5234 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5235 // max_bandwidth_bps = -1 - remove the bandwidth limit
5236 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005237 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005238
perkjfa10b552016-10-02 23:45:26 -07005239 SetAndExpectMaxBitrate(1000, 0, 1000);
5240 SetAndExpectMaxBitrate(1000, 800, 800);
5241 SetAndExpectMaxBitrate(600, 800, 600);
5242 SetAndExpectMaxBitrate(0, 800, 800);
5243 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005244
Niels Möllerff40b142018-04-09 08:49:14 +02005245 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005246}
5247
eladalonf1841382017-06-12 01:16:46 -07005248TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005249 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005250 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005251 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005252
5253 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005254 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005255 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005256}
5257
eladalonf1841382017-06-12 01:16:46 -07005258TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005259 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005260 FakeVideoSendStream* stream = AddSendStream();
5261
Seth Hampson7c682e02018-05-04 16:28:15 -07005262 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5263 EXPECT_EQ(1UL, parameters.encodings.size());
5264 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5265 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5266
5267 // Note that this is testing the behavior of the FakeVideoSendStream, which
5268 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5269 // we are just testing the behavior of
5270 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005271 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5272 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005273
5274 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5275 // by this amount.
5276 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5277 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5278 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5279 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5280
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005281 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5282 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5283 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5284}
5285
5286TEST_F(WebRtcVideoChannelTest,
5287 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5288 FakeVideoSendStream* stream = AddSendStream();
5289
5290 // Note that this is testing the behavior of the FakeVideoSendStream, which
5291 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5292 // we are just testing the behavior of
5293 // EncoderStreamFactory::CreateEncoderStreams.
5294 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5295 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5296
5297 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5298 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5299 EXPECT_EQ(1UL, parameters.encodings.size());
5300 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5301 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5302
5303 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5304 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5305 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5306}
5307
5308TEST_F(WebRtcVideoChannelTest,
5309 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5310 send_parameters_.max_bandwidth_bps = 99999;
5311 FakeVideoSendStream* stream = AddSendStream();
5312 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5313 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5314 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5315 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5316 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5317 stream->GetVideoStreams()[0].max_bitrate_bps);
5318
5319 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5320 // adjusted down.
5321 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5322 EXPECT_EQ(1UL, parameters.encodings.size());
5323 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5324 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5325 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5326 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5327 stream->GetVideoStreams()[0].min_bitrate_bps);
5328 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5329 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005330}
5331
Åsa Persson8c1bf952018-09-13 10:42:19 +02005332TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5333 FakeVideoSendStream* stream = AddSendStream();
5334
5335 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5336 EXPECT_EQ(1UL, parameters.encodings.size());
5337 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5338 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5339
5340 // Note that this is testing the behavior of the FakeVideoSendStream, which
5341 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5342 // we are just testing the behavior of
5343 // EncoderStreamFactory::CreateEncoderStreams.
5344 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5345 EXPECT_EQ(kDefaultVideoMaxFramerate,
5346 stream->GetVideoStreams()[0].max_framerate);
5347
5348 // Set max framerate and check that VideoStream.max_framerate is set.
5349 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5350 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5351 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5352 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5353
5354 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5355 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5356}
5357
Åsa Persson23eba222018-10-02 14:47:06 +02005358TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5359 FakeVideoSendStream* stream = AddSendStream();
5360
5361 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5362 EXPECT_EQ(1UL, parameters.encodings.size());
5363 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5364 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5365
5366 // Note that this is testing the behavior of the FakeVideoSendStream, which
5367 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5368 // we are just testing the behavior of
5369 // EncoderStreamFactory::CreateEncoderStreams.
5370 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5371 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5372
5373 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5374 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5375 parameters.encodings[0].num_temporal_layers = 2;
5376 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5377
5378 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5379 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5380}
5381
Seth Hampson7c682e02018-05-04 16:28:15 -07005382TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005383 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005384 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005385 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005386 // Two or more encodings should result in failure.
5387 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005388 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005389 // Zero encodings should also fail.
5390 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005391 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005392}
5393
Zach Stein3ca452b2018-01-18 10:01:24 -08005394TEST_F(WebRtcVideoChannelTest,
5395 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5396 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5397 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5398 AddSendStream(sp);
5399
5400 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5401
5402 // Additional encodings should result in failure.
5403 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005404 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005405 // Zero encodings should also fail.
5406 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005407 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005408}
5409
deadbeeffb2aced2017-01-06 23:05:37 -08005410// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005411TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005412 AddSendStream();
5413 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005414 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005415 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005416}
5417
Seth Hampson24722b32017-12-22 09:36:42 -08005418// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5419// a value <= 0, setting the parameters returns false.
5420TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5421 AddSendStream();
5422 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5423 EXPECT_EQ(1UL, parameters.encodings.size());
5424 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5425 parameters.encodings[0].bitrate_priority);
5426
5427 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005428 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005429 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005430 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005431}
5432
5433// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5434// properly on the VideoChannel and propogates down to the video encoder.
5435TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5436 AddSendStream();
5437 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5438 EXPECT_EQ(1UL, parameters.encodings.size());
5439 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5440 parameters.encodings[0].bitrate_priority);
5441
5442 // Change the value and set it on the VideoChannel.
5443 double new_bitrate_priority = 2.0;
5444 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005445 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005446
5447 // Verify that the encoding parameters bitrate_priority is set for the
5448 // VideoChannel.
5449 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5450 EXPECT_EQ(1UL, parameters.encodings.size());
5451 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5452
5453 // Verify that the new value propagated down to the encoder.
5454 std::vector<FakeVideoSendStream*> video_send_streams =
5455 fake_call_->GetVideoSendStreams();
5456 EXPECT_EQ(1UL, video_send_streams.size());
5457 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5458 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5459 // appropriately.
5460 EXPECT_EQ(new_bitrate_priority,
5461 video_send_stream->GetEncoderConfig().bitrate_priority);
5462 // Check that the vector of VideoStreams also was propagated correctly. Note
5463 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5464 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005465 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005466 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5467}
5468
5469// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5470// VideoChannel and the value propogates to the video encoder with all simulcast
5471// streams.
5472TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5473 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005474 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005475 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5476 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5477 AddSendStream(stream_params);
5478 uint32_t primary_ssrc = stream_params.first_ssrc();
5479
Niels Möller805a27e2019-01-21 12:21:27 +01005480 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005481 // frame. This creates multiple VideoStreams for all simulcast layers when
5482 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005483 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005484 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005485 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005486 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005487 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5488 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5489 rtc::kNumMicrosecsPerSec / 30));
5490
Seth Hampson24722b32017-12-22 09:36:42 -08005491 // Get and set the rtp encoding parameters.
5492 webrtc::RtpParameters parameters =
5493 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005494 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005495 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5496 parameters.encodings[0].bitrate_priority);
5497 // Change the value and set it on the VideoChannel.
5498 double new_bitrate_priority = 2.0;
5499 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005500 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005501
5502 // Verify that the encoding parameters priority is set on the VideoChannel.
5503 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005504 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005505 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5506
5507 // Verify that the new value propagated down to the encoder.
5508 std::vector<FakeVideoSendStream*> video_send_streams =
5509 fake_call_->GetVideoSendStreams();
5510 EXPECT_EQ(1UL, video_send_streams.size());
5511 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5512 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5513 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005514 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005515 video_send_stream->GetEncoderConfig().number_of_streams);
5516 EXPECT_EQ(new_bitrate_priority,
5517 video_send_stream->GetEncoderConfig().bitrate_priority);
5518 // Check that the vector of VideoStreams also propagated correctly. The
5519 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5520 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005521 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005522 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005523 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5524 // Since we are only setting bitrate priority per-sender, the other
5525 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005526 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005527 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005528 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005529 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005530 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005531}
5532
Tim Haloun648d28a2018-10-18 16:52:22 -07005533// RTCRtpEncodingParameters.network_priority must be one of a few values
5534// derived from the default priority, corresponding to very-low, low, medium,
5535// or high.
5536TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5537 AddSendStream();
5538 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5539 EXPECT_EQ(1UL, parameters.encodings.size());
5540 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5541 parameters.encodings[0].network_priority);
5542
5543 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5544 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5545 for (auto it : good_values) {
5546 parameters.encodings[0].network_priority = it;
5547 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5548 }
5549 for (auto it : bad_values) {
5550 parameters.encodings[0].network_priority = it;
5551 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5552 }
5553}
5554
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005555TEST_F(WebRtcVideoChannelTest,
5556 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005557 VideoSendParameters parameters;
5558 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005559 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5560 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5561
5562 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005563 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005564
5565 VideoOptions options;
5566 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5567 channel_->SetSend(true);
5568
5569 // Try layers in natural order (smallest to largest).
5570 {
5571 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5572 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5573 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5574 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5575 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5576 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5577 ASSERT_TRUE(result.ok());
5578
5579 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5580
5581 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5582 ASSERT_EQ(3u, video_streams.size());
5583 EXPECT_EQ(320u, video_streams[0].width);
5584 EXPECT_EQ(180u, video_streams[0].height);
5585 EXPECT_EQ(640u, video_streams[1].width);
5586 EXPECT_EQ(360u, video_streams[1].height);
5587 EXPECT_EQ(1280u, video_streams[2].width);
5588 EXPECT_EQ(720u, video_streams[2].height);
5589 }
5590
5591 // Try layers in reverse natural order (largest to smallest).
5592 {
5593 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5594 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5595 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5596 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5597 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5598 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5599 ASSERT_TRUE(result.ok());
5600
5601 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5602
5603 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5604 ASSERT_EQ(3u, video_streams.size());
5605 EXPECT_EQ(1280u, video_streams[0].width);
5606 EXPECT_EQ(720u, video_streams[0].height);
5607 EXPECT_EQ(640u, video_streams[1].width);
5608 EXPECT_EQ(360u, video_streams[1].height);
5609 EXPECT_EQ(320u, video_streams[2].width);
5610 EXPECT_EQ(180u, video_streams[2].height);
5611 }
5612
5613 // Try layers in mixed order.
5614 {
5615 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5616 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5617 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5618 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5619 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5620 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5621 ASSERT_TRUE(result.ok());
5622
5623 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5624
5625 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5626 ASSERT_EQ(3u, video_streams.size());
5627 EXPECT_EQ(128u, video_streams[0].width);
5628 EXPECT_EQ(72u, video_streams[0].height);
5629 EXPECT_EQ(640u, video_streams[1].width);
5630 EXPECT_EQ(360u, video_streams[1].height);
5631 EXPECT_EQ(320u, video_streams[2].width);
5632 EXPECT_EQ(180u, video_streams[2].height);
5633 }
5634
5635 // Try with a missing scale setting, defaults to 1.0 if any other is set.
5636 {
5637 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5638 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5639 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5640 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
5641 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5642 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5643 ASSERT_TRUE(result.ok());
5644
5645 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5646
5647 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5648 ASSERT_EQ(3u, video_streams.size());
5649 EXPECT_EQ(1280u, video_streams[0].width);
5650 EXPECT_EQ(720u, video_streams[0].height);
5651 EXPECT_EQ(1280u, video_streams[1].width);
5652 EXPECT_EQ(720u, video_streams[1].height);
5653 EXPECT_EQ(320u, video_streams[2].width);
5654 EXPECT_EQ(180u, video_streams[2].height);
5655 }
5656
5657 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5658}
5659
5660TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01005661 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
5662 // Ensure that the top layer has width and height divisible by 2^3,
5663 // so that the bottom layer has width and height divisible by 2.
5664 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
5665 // the number of simulcast layers set by the app.
5666 webrtc::test::ScopedFieldTrials field_trial(
5667 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
5668
5669 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
5670 VideoSendParameters parameters;
5671 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
5672 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5673 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5674 webrtc::test::FrameForwarder frame_forwarder;
5675 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
5676 &frame_forwarder));
5677 channel_->SetSend(true);
5678
5679 // Set |scale_resolution_down_by|'s.
5680 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5681 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
5682 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5683 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5684 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5685 const auto result =
5686 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5687 ASSERT_TRUE(result.ok());
5688
5689 // Use a capture resolution whose width and height are not divisible by 2^3.
5690 // (See field trial set at the top of the test.)
5691 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
5692 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5693
5694 // Ensure the scaling is correct.
5695 const auto video_streams = stream->GetVideoStreams();
5696 ASSERT_EQ(video_streams.size(), 3u);
5697 // Ensure that we round the capture resolution down for the top layer...
5698 EXPECT_EQ(video_streams[0].width, 2000u);
5699 EXPECT_EQ(video_streams[0].height, 1200u);
5700 EXPECT_EQ(video_streams[1].width, 1000u);
5701 EXPECT_EQ(video_streams[1].height, 600u);
5702 // ...and that the bottom layer has a width/height divisible by 2.
5703 EXPECT_EQ(video_streams[2].width, 500u);
5704 EXPECT_EQ(video_streams[2].height, 300u);
5705
5706 // Tear down.
5707 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5708}
5709
5710TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005711 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005712 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
5713 VideoSendParameters parameters;
5714 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005715 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5716 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5717
5718 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005719 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005720
5721 VideoOptions options;
5722 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5723 channel_->SetSend(true);
5724
5725 // Try layers in natural order (smallest to largest).
5726 {
5727 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5728 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5729 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5730 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5731 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5732 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5733 ASSERT_TRUE(result.ok());
5734
5735 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5736
5737 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5738 ASSERT_EQ(3u, video_streams.size());
5739 EXPECT_EQ(320u, video_streams[0].width);
5740 EXPECT_EQ(180u, video_streams[0].height);
5741 EXPECT_EQ(640u, video_streams[1].width);
5742 EXPECT_EQ(360u, video_streams[1].height);
5743 EXPECT_EQ(1280u, video_streams[2].width);
5744 EXPECT_EQ(720u, video_streams[2].height);
5745 }
5746
5747 // Try layers in reverse natural order (largest to smallest).
5748 {
5749 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5750 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5751 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5752 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5753 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5754 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5755 ASSERT_TRUE(result.ok());
5756
5757 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5758
5759 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5760 ASSERT_EQ(3u, video_streams.size());
5761 EXPECT_EQ(1280u, video_streams[0].width);
5762 EXPECT_EQ(720u, video_streams[0].height);
5763 EXPECT_EQ(640u, video_streams[1].width);
5764 EXPECT_EQ(360u, video_streams[1].height);
5765 EXPECT_EQ(320u, video_streams[2].width);
5766 EXPECT_EQ(180u, video_streams[2].height);
5767 }
5768
5769 // Try layers in mixed order.
5770 {
5771 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5772 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5773 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5774 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5775 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5776 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5777 ASSERT_TRUE(result.ok());
5778
5779 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5780
5781 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5782 ASSERT_EQ(3u, video_streams.size());
5783 EXPECT_EQ(128u, video_streams[0].width);
5784 EXPECT_EQ(72u, video_streams[0].height);
5785 EXPECT_EQ(640u, video_streams[1].width);
5786 EXPECT_EQ(360u, video_streams[1].height);
5787 EXPECT_EQ(320u, video_streams[2].width);
5788 EXPECT_EQ(180u, video_streams[2].height);
5789 }
5790
5791 // Try with a missing scale setting, defaults to 1.0 if any other is set.
5792 {
5793 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5794 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5795 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5796 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
5797 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5798 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5799 ASSERT_TRUE(result.ok());
5800
5801 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5802
5803 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5804 ASSERT_EQ(3u, video_streams.size());
5805 EXPECT_EQ(1280u, video_streams[0].width);
5806 EXPECT_EQ(720u, video_streams[0].height);
5807 EXPECT_EQ(1280u, video_streams[1].width);
5808 EXPECT_EQ(720u, video_streams[1].height);
5809 EXPECT_EQ(320u, video_streams[2].width);
5810 EXPECT_EQ(180u, video_streams[2].height);
5811 }
5812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5813}
5814
Rasmus Brandt9387b522019-02-05 14:23:26 +01005815TEST_F(WebRtcVideoChannelTest,
5816 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
5817 // Ensure that the top layer has width and height divisible by 2^3,
5818 // so that the bottom layer has width and height divisible by 2.
5819 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
5820 // the number of simulcast layers set by the app.
5821 webrtc::test::ScopedFieldTrials field_trial(
5822 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
5823
5824 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
5825 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
5826 VideoSendParameters parameters;
5827 parameters.codecs.push_back(VideoCodec(kH264CodecName));
5828 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5829 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5830 webrtc::test::FrameForwarder frame_forwarder;
5831 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
5832 &frame_forwarder));
5833 channel_->SetSend(true);
5834
5835 // Set |scale_resolution_down_by|'s.
5836 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5837 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
5838 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5839 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5840 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5841 const auto result =
5842 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5843 ASSERT_TRUE(result.ok());
5844
5845 // Use a capture resolution whose width and height are not divisible by 2^3.
5846 // (See field trial set at the top of the test.)
5847 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
5848 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5849
5850 // Ensure the scaling is correct.
5851 const auto video_streams = stream->GetVideoStreams();
5852 ASSERT_EQ(video_streams.size(), 3u);
5853 // Ensure that we round the capture resolution down for the top layer...
5854 EXPECT_EQ(video_streams[0].width, 2000u);
5855 EXPECT_EQ(video_streams[0].height, 1200u);
5856 EXPECT_EQ(video_streams[1].width, 1000u);
5857 EXPECT_EQ(video_streams[1].height, 600u);
5858 // ...and that the bottom layer has a width/height divisible by 2.
5859 EXPECT_EQ(video_streams[2].width, 500u);
5860 EXPECT_EQ(video_streams[2].height, 300u);
5861
5862 // Tear down.
5863 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5864}
5865
Åsa Persson8c1bf952018-09-13 10:42:19 +02005866TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5867 const size_t kNumSimulcastStreams = 3;
5868 SetUpSimulcast(true, false);
5869
5870 // Get and set the rtp encoding parameters.
5871 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5872 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5873 for (const auto& encoding : parameters.encodings) {
5874 EXPECT_FALSE(encoding.max_framerate);
5875 }
5876
5877 // Change the value and set it on the VideoChannel.
5878 parameters.encodings[0].max_framerate = 10;
5879 parameters.encodings[1].max_framerate = 20;
5880 parameters.encodings[2].max_framerate = 25;
5881 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5882
5883 // Verify that the bitrates are set on the VideoChannel.
5884 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5885 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5886 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5887 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5888 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5889}
5890
Åsa Persson23eba222018-10-02 14:47:06 +02005891TEST_F(WebRtcVideoChannelTest,
5892 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5893 const size_t kNumSimulcastStreams = 3;
5894 SetUpSimulcast(true, false);
5895
5896 // Get and set the rtp encoding parameters.
5897 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5898 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5899
5900 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5901 parameters.encodings[0].num_temporal_layers = 0;
5902 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5903 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5904 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5905 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5906 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5907}
5908
5909TEST_F(WebRtcVideoChannelTest,
5910 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5911 const size_t kNumSimulcastStreams = 3;
5912 SetUpSimulcast(true, false);
5913
5914 // Get and set the rtp encoding parameters.
5915 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5916 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5917
5918 // No/all layers should be set.
5919 parameters.encodings[0].num_temporal_layers = 1;
5920 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5921 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5922
5923 // Different values not supported.
5924 parameters.encodings[0].num_temporal_layers = 1;
5925 parameters.encodings[1].num_temporal_layers = 2;
5926 parameters.encodings[2].num_temporal_layers = 2;
5927 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5928 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5929}
5930
5931TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5932 const size_t kNumSimulcastStreams = 3;
5933 SetUpSimulcast(true, false);
5934
5935 // Get and set the rtp encoding parameters.
5936 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5937 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5938 for (const auto& encoding : parameters.encodings)
5939 EXPECT_FALSE(encoding.num_temporal_layers);
5940
5941 // Change the value and set it on the VideoChannel.
5942 parameters.encodings[0].num_temporal_layers = 3;
5943 parameters.encodings[1].num_temporal_layers = 3;
5944 parameters.encodings[2].num_temporal_layers = 3;
5945 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5946
5947 // Verify that the number of temporal layers are set on the VideoChannel.
5948 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5949 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5950 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5951 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5952 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5953}
5954
5955TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5956 const size_t kNumSimulcastStreams = 3;
5957 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5958
5959 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01005960 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02005961 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005962 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02005963 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005964 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02005965
5966 // Get and set the rtp encoding parameters.
5967 // Change the value and set it on the VideoChannel.
5968 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5969 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5970 parameters.encodings[0].num_temporal_layers = 2;
5971 parameters.encodings[1].num_temporal_layers = 2;
5972 parameters.encodings[2].num_temporal_layers = 2;
5973 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5974
5975 // Verify that the new value is propagated down to the encoder.
5976 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5977 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5978 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5979 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5980 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5981 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5982 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5983 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5984
5985 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5986 // VideoStreams are created appropriately for the simulcast case.
5987 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5988 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5989 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5990 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5991
5992 // No parameter changed, encoder should not be reconfigured.
5993 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5994 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5995
5996 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5997}
5998
5999TEST_F(WebRtcVideoChannelTest,
6000 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6001 const size_t kDefaultNumTemporalLayers = 3;
6002 const size_t kNumSimulcastStreams = 3;
6003 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6004
6005 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006006 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006007 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006008 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006009 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006010 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006011
6012 // Change rtp encoding parameters, num_temporal_layers not changed.
6013 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6014 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6015 parameters.encodings[0].min_bitrate_bps = 33000;
6016 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6017
6018 // Verify that no value is propagated down to the encoder.
6019 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6020 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6021 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6022 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6023 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6024 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6025
6026 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6027 // VideoStreams are created appropriately for the simulcast case.
6028 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6029 EXPECT_EQ(kDefaultNumTemporalLayers,
6030 stream->GetVideoStreams()[0].num_temporal_layers);
6031 EXPECT_EQ(kDefaultNumTemporalLayers,
6032 stream->GetVideoStreams()[1].num_temporal_layers);
6033 EXPECT_EQ(kDefaultNumTemporalLayers,
6034 stream->GetVideoStreams()[2].num_temporal_layers);
6035
6036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6037}
6038
Åsa Persson8c1bf952018-09-13 10:42:19 +02006039TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6040 const size_t kNumSimulcastStreams = 3;
6041 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6042
6043 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006044 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006045 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006046 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006047 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006048 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006049
6050 // Get and set the rtp encoding parameters.
6051 // Change the value and set it on the VideoChannel.
6052 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6053 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6054 parameters.encodings[0].max_framerate = 15;
6055 parameters.encodings[1].max_framerate = 25;
6056 parameters.encodings[2].max_framerate = 20;
6057 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6058
6059 // Verify that the new value propagated down to the encoder.
6060 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6061 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6062 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6063 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6064 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6065 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6066 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6067 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6068
6069 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6070 // VideoStreams are created appropriately for the simulcast case.
6071 // Currently the maximum |max_framerate| is used.
6072 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6073 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6074 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6075 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6076
6077 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6078}
6079
6080TEST_F(WebRtcVideoChannelTest,
6081 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6082 const size_t kNumSimulcastStreams = 3;
6083 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6084 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6085
6086 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006087 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006088 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006089 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006090 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006091 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006092
6093 // Get and set the rtp encoding parameters.
6094 // Change the value and set it on the VideoChannel.
6095 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6096 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6097 parameters.encodings[0].max_framerate = 15;
6098 parameters.encodings[2].max_framerate = 20;
6099 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6100
6101 // Verify that the new value propagated down to the encoder.
6102 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6103 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6104 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6105 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6106 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6107 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6108 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6109
6110 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6111 // VideoStreams are created appropriately for the simulcast case.
6112 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6113 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6114 EXPECT_EQ(kDefaultVideoMaxFramerate,
6115 stream->GetVideoStreams()[0].max_framerate);
6116 EXPECT_EQ(kDefaultVideoMaxFramerate,
6117 stream->GetVideoStreams()[1].max_framerate);
6118 EXPECT_EQ(kDefaultVideoMaxFramerate,
6119 stream->GetVideoStreams()[2].max_framerate);
6120
6121 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6122}
6123
Åsa Persson55659812018-06-18 17:51:32 +02006124TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6125 const size_t kNumSimulcastStreams = 3;
6126 SetUpSimulcast(true, false);
6127
6128 // Get and set the rtp encoding parameters.
6129 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6130 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6131 for (const auto& encoding : parameters.encodings) {
6132 EXPECT_FALSE(encoding.min_bitrate_bps);
6133 EXPECT_FALSE(encoding.max_bitrate_bps);
6134 }
6135
6136 // Change the value and set it on the VideoChannel.
6137 parameters.encodings[0].min_bitrate_bps = 100000;
6138 parameters.encodings[0].max_bitrate_bps = 200000;
6139 parameters.encodings[1].min_bitrate_bps = 300000;
6140 parameters.encodings[1].max_bitrate_bps = 400000;
6141 parameters.encodings[2].min_bitrate_bps = 500000;
6142 parameters.encodings[2].max_bitrate_bps = 600000;
6143 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6144
6145 // Verify that the bitrates are set on the VideoChannel.
6146 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6147 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6148 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6149 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6150 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6151 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6152 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6153 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6154}
6155
6156TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6157 const size_t kNumSimulcastStreams = 3;
6158 SetUpSimulcast(true, false);
6159
6160 // Get and set the rtp encoding parameters.
6161 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6162 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6163
6164 // Max bitrate lower than min bitrate should fail.
6165 parameters.encodings[2].min_bitrate_bps = 100000;
6166 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6167 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6168 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6169}
6170
6171// Test that min and max bitrate values set via RtpParameters are correctly
6172// propagated to the underlying encoder, and that the target is set to 3/4 of
6173// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6174// that are used if no min/max are specified).
6175TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6176 const size_t kNumSimulcastStreams = 3;
6177 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6178
6179 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006180 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006181 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006182 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006183 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006184 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006185
6186 // Get and set the rtp encoding parameters.
6187 // Change the value and set it on the VideoChannel.
6188 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6189 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6190 parameters.encodings[0].min_bitrate_bps = 100000;
6191 parameters.encodings[0].max_bitrate_bps = 200000;
6192 parameters.encodings[1].min_bitrate_bps = 300000;
6193 parameters.encodings[1].max_bitrate_bps = 400000;
6194 parameters.encodings[2].min_bitrate_bps = 500000;
6195 parameters.encodings[2].max_bitrate_bps = 600000;
6196 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6197
6198 // Verify that the new value propagated down to the encoder.
6199 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6200 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6201 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6202 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6203 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6204 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6205 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6206 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6207 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6208 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6209 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6210
6211 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6212 // VideoStreams are created appropriately for the simulcast case.
6213 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6214 // Target bitrate: 200000 * 3 / 4 = 150000.
6215 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6216 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6217 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6218 // Target bitrate: 400000 * 3 / 4 = 300000.
6219 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6220 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6221 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6222 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6223 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6224 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6225 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6226
6227 // No parameter changed, encoder should not be reconfigured.
6228 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6229 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6230
6231 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6232}
6233
6234// Test to only specify the min or max bitrate value for a layer via
6235// RtpParameters. The unspecified min/max and target value should be set to the
6236// simulcast default that is used if no min/max are specified.
6237TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6238 const size_t kNumSimulcastStreams = 3;
6239 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6240 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6241
6242 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006243 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006244 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006245 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006246 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006247 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006248
6249 // Get and set the rtp encoding parameters.
6250 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6251 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6252
6253 // Change the value and set it on the VideoChannel.
6254 // Layer 0: only configure min bitrate.
6255 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6256 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6257 // Layer 1: only configure max bitrate.
6258 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6259 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6260 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6261
6262 // Verify that the new value propagated down to the encoder.
6263 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6264 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6265 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6266 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6267 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6268 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6269 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6270 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6271 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6272 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6273
6274 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6275 // VideoStreams are created appropriately for the simulcast case.
6276 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6277 // Layer 0: min configured bitrate should overwrite min default.
6278 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6279 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6280 stream->GetVideoStreams()[0].target_bitrate_bps);
6281 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6282 stream->GetVideoStreams()[0].max_bitrate_bps);
6283 // Layer 1: max configured bitrate should overwrite max default.
6284 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6285 stream->GetVideoStreams()[1].min_bitrate_bps);
6286 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6287 stream->GetVideoStreams()[1].target_bitrate_bps);
6288 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6289 // Layer 2: min and max bitrate not configured, default expected.
6290 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6291 stream->GetVideoStreams()[2].min_bitrate_bps);
6292 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6293 stream->GetVideoStreams()[2].target_bitrate_bps);
6294 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6295 stream->GetVideoStreams()[2].max_bitrate_bps);
6296
6297 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6298}
6299
6300// Test that specifying the min (or max) bitrate value for a layer via
6301// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6302// unspecified values accordingly.
6303TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6304 const size_t kNumSimulcastStreams = 3;
6305 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6306 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6307
6308 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006309 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006310 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006311 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006312 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006313 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006314
6315 // Get and set the rtp encoding parameters.
6316 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6317 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6318
6319 // Change the value and set it on the VideoChannel.
6320 // For layer 0, set the min bitrate above the default max.
6321 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6322 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6323 // For layer 1, set the max bitrate below the default min.
6324 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6325 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6326 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6327
6328 // Verify that the new value propagated down to the encoder.
6329 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6330 // VideoStreams are created appropriately for the simulcast case.
6331 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6332 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6333 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6334 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6335 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6336 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6337 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6338 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6339 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6340 // Layer 2: min and max bitrate not configured, default expected.
6341 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6342 stream->GetVideoStreams()[2].min_bitrate_bps);
6343 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6344 stream->GetVideoStreams()[2].target_bitrate_bps);
6345 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6346 stream->GetVideoStreams()[2].max_bitrate_bps);
6347
6348 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6349}
6350
6351TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6352 const size_t kNumSimulcastStreams = 3;
6353 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6354 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6355
6356 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006357 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006358 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006359 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006360 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006361 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006362
6363 // Set max bitrate for all but the highest layer.
6364 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6365 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6366 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6367 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6368 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6369
6370 // Set max bandwidth equal to total max bitrate.
6371 send_parameters_.max_bandwidth_bps =
6372 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6373 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6374 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6375
6376 // No bitrate above the total max to give to the highest layer.
6377 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6378 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6379 stream->GetVideoStreams()[2].max_bitrate_bps);
6380
6381 // Set max bandwidth above the total max bitrate.
6382 send_parameters_.max_bandwidth_bps =
6383 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6384 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6385 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6386
6387 // The highest layer has no max bitrate set -> the bitrate above the total
6388 // max should be given to the highest layer.
6389 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6390 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6391 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6392 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6393 stream->GetVideoStreams()[2].max_bitrate_bps);
6394
6395 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6396}
6397
6398TEST_F(WebRtcVideoChannelTest,
6399 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6400 const size_t kNumSimulcastStreams = 3;
6401 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6402 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6403 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6404
6405 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006406 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006407 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006408 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006409 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006410 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006411
6412 // Set max bitrate for the highest layer.
6413 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6414 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6415 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6416 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6417
6418 // Set max bandwidth above the total max bitrate.
6419 send_parameters_.max_bandwidth_bps =
6420 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6421 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6422 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6423
6424 // The highest layer has the max bitrate set -> the bitrate above the total
6425 // max should not be given to the highest layer.
6426 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6427 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6428 stream->GetVideoStreams()[2].max_bitrate_bps);
6429
6430 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6431}
6432
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006433// Test that min and max bitrate values set via RtpParameters are correctly
6434// propagated to the underlying encoder for a single stream.
6435TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6436 FakeVideoSendStream* stream = AddSendStream();
6437 EXPECT_TRUE(channel_->SetSend(true));
6438 EXPECT_TRUE(stream->IsSending());
6439
6440 // Set min and max bitrate.
6441 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6442 EXPECT_EQ(1u, parameters.encodings.size());
6443 parameters.encodings[0].min_bitrate_bps = 80000;
6444 parameters.encodings[0].max_bitrate_bps = 150000;
6445 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6446
6447 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6448 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6449 EXPECT_EQ(1u, encoder_config.number_of_streams);
6450 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6451 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6452 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6453
6454 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6455 // VideoStreams are created appropriately.
6456 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6457 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6458 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6459 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6460}
6461
6462// Test the default min and max bitrate value are correctly propagated to the
6463// underlying encoder for a single stream (when the values are not set via
6464// RtpParameters).
6465TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6466 FakeVideoSendStream* stream = AddSendStream();
6467 EXPECT_TRUE(channel_->SetSend(true));
6468 EXPECT_TRUE(stream->IsSending());
6469
6470 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6471 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6472 EXPECT_EQ(1u, encoder_config.number_of_streams);
6473 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6474 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6475 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6476
6477 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6478 // VideoStreams are created appropriately.
6479 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6480 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6481 stream->GetVideoStreams()[0].min_bitrate_bps);
6482 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6483 stream->GetVideoStreams()[0].min_bitrate_bps);
6484 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6485 stream->GetVideoStreams()[0].target_bitrate_bps);
6486}
6487
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006488// Test that a stream will not be sending if its encoding is made inactive
6489// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006490TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006491 FakeVideoSendStream* stream = AddSendStream();
6492 EXPECT_TRUE(channel_->SetSend(true));
6493 EXPECT_TRUE(stream->IsSending());
6494
6495 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006496 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006497 ASSERT_EQ(1u, parameters.encodings.size());
6498 ASSERT_TRUE(parameters.encodings[0].active);
6499 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006500 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006501 EXPECT_FALSE(stream->IsSending());
6502
6503 // Now change it back to active and verify we resume sending.
6504 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006505 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006506 EXPECT_TRUE(stream->IsSending());
6507}
6508
Seth Hampson8234ead2018-02-02 15:16:24 -08006509// Tests that when active is updated for any simulcast layer then the send
6510// stream's sending state will be updated and it will be reconfigured with the
6511// new appropriate active simulcast streams.
6512TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6513 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006514 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006515 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6516 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6517 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6518 uint32_t primary_ssrc = stream_params.first_ssrc();
6519
Niels Möller805a27e2019-01-21 12:21:27 +01006520 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006521 // frame. This allows us to test that ReconfigureEncoder is called
6522 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006523 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006524 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006525 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006526 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006527 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6528 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6529 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006530
6531 // Check that all encodings are initially active.
6532 webrtc::RtpParameters parameters =
6533 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006534 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006535 EXPECT_TRUE(parameters.encodings[0].active);
6536 EXPECT_TRUE(parameters.encodings[1].active);
6537 EXPECT_TRUE(parameters.encodings[2].active);
6538 EXPECT_TRUE(fake_video_send_stream->IsSending());
6539
6540 // Only turn on only the middle stream.
6541 parameters.encodings[0].active = false;
6542 parameters.encodings[1].active = true;
6543 parameters.encodings[2].active = false;
6544 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6545 // Verify that the active fields are set on the VideoChannel.
6546 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006547 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006548 EXPECT_FALSE(parameters.encodings[0].active);
6549 EXPECT_TRUE(parameters.encodings[1].active);
6550 EXPECT_FALSE(parameters.encodings[2].active);
6551 // Check that the VideoSendStream is updated appropriately. This means its
6552 // send state was updated and it was reconfigured.
6553 EXPECT_TRUE(fake_video_send_stream->IsSending());
6554 std::vector<webrtc::VideoStream> simulcast_streams =
6555 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006556 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006557 EXPECT_FALSE(simulcast_streams[0].active);
6558 EXPECT_TRUE(simulcast_streams[1].active);
6559 EXPECT_FALSE(simulcast_streams[2].active);
6560
6561 // Turn off all streams.
6562 parameters.encodings[0].active = false;
6563 parameters.encodings[1].active = false;
6564 parameters.encodings[2].active = false;
6565 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6566 // Verify that the active fields are set on the VideoChannel.
6567 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006568 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006569 EXPECT_FALSE(parameters.encodings[0].active);
6570 EXPECT_FALSE(parameters.encodings[1].active);
6571 EXPECT_FALSE(parameters.encodings[2].active);
6572 // Check that the VideoSendStream is off.
6573 EXPECT_FALSE(fake_video_send_stream->IsSending());
6574 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006575 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006576 EXPECT_FALSE(simulcast_streams[0].active);
6577 EXPECT_FALSE(simulcast_streams[1].active);
6578 EXPECT_FALSE(simulcast_streams[2].active);
6579
Niels Möllerff40b142018-04-09 08:49:14 +02006580 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006581}
6582
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006583// Test that if a stream is reconfigured (due to a codec change or other
6584// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006585TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006586 InactiveStreamDoesntStartSendingWhenReconfigured) {
6587 // Set an initial codec list, which will be modified later.
6588 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006589 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6590 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006591 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6592
6593 FakeVideoSendStream* stream = AddSendStream();
6594 EXPECT_TRUE(channel_->SetSend(true));
6595 EXPECT_TRUE(stream->IsSending());
6596
6597 // Get current parameters and change "active" to false.
6598 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6599 ASSERT_EQ(1u, parameters.encodings.size());
6600 ASSERT_TRUE(parameters.encodings[0].active);
6601 parameters.encodings[0].active = false;
6602 EXPECT_EQ(1u, GetFakeSendStreams().size());
6603 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006604 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006605 EXPECT_FALSE(stream->IsSending());
6606
6607 // Reorder the codec list, causing the stream to be reconfigured.
6608 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006609 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6610 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006611 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6612 auto new_streams = GetFakeSendStreams();
6613 // Assert that a new underlying stream was created due to the codec change.
6614 // Otherwise, this test isn't testing what it set out to test.
6615 EXPECT_EQ(1u, GetFakeSendStreams().size());
6616 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6617
6618 // Verify that we still are not sending anything, due to the inactive
6619 // encoding.
6620 EXPECT_FALSE(new_streams[0]->IsSending());
6621}
6622
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006623// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006624TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006625 AddSendStream();
6626 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006627 parameters.codecs.push_back(GetEngineCodec("VP8"));
6628 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006629 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6630
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006631 webrtc::RtpParameters rtp_parameters =
6632 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006633 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006634 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6635 rtp_parameters.codecs[0]);
6636 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6637 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006638}
6639
Florent Castellidacec712018-05-24 16:24:21 +02006640// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6641TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6642 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6643 params.cname = "rtcpcname";
6644 AddSendStream(params);
6645
6646 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6647 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6648}
6649
deadbeeffb2aced2017-01-06 23:05:37 -08006650// Test that RtpParameters for send stream has one encoding and it has
6651// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006652TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006653 AddSendStream();
6654
6655 webrtc::RtpParameters rtp_parameters =
6656 channel_->GetRtpSendParameters(last_ssrc_);
6657 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006658 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006659}
6660
Florent Castelliabe301f2018-06-12 18:33:49 +02006661TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6662 AddSendStream();
6663
6664 webrtc::RtpParameters rtp_parameters =
6665 channel_->GetRtpSendParameters(last_ssrc_);
6666 rtp_parameters.header_extensions.emplace_back();
6667
6668 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6669
6670 webrtc::RTCError result =
6671 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6672 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6673}
6674
Florent Castelli87b3c512018-07-18 16:00:28 +02006675TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6676 AddSendStream();
6677
Niels Möller805a27e2019-01-21 12:21:27 +01006678 webrtc::test::FrameForwarder frame_forwarder;
6679 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02006680
6681 webrtc::RtpParameters rtp_parameters =
6682 channel_->GetRtpSendParameters(last_ssrc_);
6683 EXPECT_EQ(rtp_parameters.degradation_preference,
6684 webrtc::DegradationPreference::BALANCED);
6685 rtp_parameters.degradation_preference =
6686 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6687
6688 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6689
6690 webrtc::RtpParameters updated_rtp_parameters =
6691 channel_->GetRtpSendParameters(last_ssrc_);
6692 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6693 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6694
6695 // Remove the source since it will be destroyed before the channel
6696 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6697}
6698
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006699// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006700TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006701 AddSendStream();
6702 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006703 parameters.codecs.push_back(GetEngineCodec("VP8"));
6704 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006705 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6706
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006707 webrtc::RtpParameters initial_params =
6708 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006709
6710 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006711 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006712
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006713 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6714 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6715}
6716
6717// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006718TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006719 AddRecvStream();
6720 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006721 parameters.codecs.push_back(GetEngineCodec("VP8"));
6722 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006723 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6724
6725 webrtc::RtpParameters rtp_parameters =
6726 channel_->GetRtpReceiveParameters(last_ssrc_);
6727 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006728 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6729 rtp_parameters.codecs[0]);
6730 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6731 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006732}
6733
johan073ece42016-08-26 02:59:47 -07006734#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006735TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006736#else
eladalonf1841382017-06-12 01:16:46 -07006737TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006738#endif
johan3859c892016-08-05 09:19:25 -07006739 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006740 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006741 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006742 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006743 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006744 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006745 parameters.codecs.push_back(kH264sprop2);
6746 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6747
6748 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6749 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6750 webrtc::RtpParameters rtp_parameters =
6751 channel_->GetRtpReceiveParameters(last_ssrc_);
6752 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6753 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6754 ASSERT_EQ(2u, cfg.decoders.size());
6755 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006756 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006757 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006758 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6759 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006760 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006761
6762 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006763 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006764 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006765 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6766 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006767 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006768}
6769
sakal1fd95952016-06-22 00:46:15 -07006770// Test that RtpParameters for receive stream has one encoding and it has
6771// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006772TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006773 AddRecvStream();
6774
6775 webrtc::RtpParameters rtp_parameters =
6776 channel_->GetRtpReceiveParameters(last_ssrc_);
6777 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006778 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006779}
6780
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006781// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006782TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006783 AddRecvStream();
6784 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006785 parameters.codecs.push_back(GetEngineCodec("VP8"));
6786 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006787 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6788
6789 webrtc::RtpParameters initial_params =
6790 channel_->GetRtpReceiveParameters(last_ssrc_);
6791
6792 // We should be able to set the params we just got.
6793 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6794
6795 // ... And this shouldn't change the params returned by
6796 // GetRtpReceiveParameters.
6797 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006798}
6799
deadbeef3bc15102017-04-20 19:25:07 -07006800// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6801// aren't signaled. It should always return an empty "RtpEncodingParameters",
6802// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006803TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006804 // Call necessary methods to configure receiving a default stream as
6805 // soon as it arrives.
6806 cricket::VideoRecvParameters parameters;
6807 parameters.codecs.push_back(GetEngineCodec("VP8"));
6808 parameters.codecs.push_back(GetEngineCodec("VP9"));
6809 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6810
6811 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6812 // stream. Should return nothing.
6813 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6814
6815 // Set a sink for an unsignaled stream.
6816 cricket::FakeVideoRenderer renderer;
6817 // Value of "0" means "unsignaled stream".
6818 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6819
6820 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6821 // in this method means "unsignaled stream".
6822 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6823 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6824 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6825
6826 // Receive VP8 packet.
6827 uint8_t data[kMinRtpPacketLen];
6828 cricket::RtpHeader rtpHeader;
6829 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6830 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6831 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6832 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6833 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006834 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006835
6836 // The |ssrc| member should still be unset.
6837 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6838 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6839 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6840}
6841
eladalonf1841382017-06-12 01:16:46 -07006842void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006843 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006844 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006845
6846 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006847 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006848 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006849 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006850
6851 if (receiver_first) {
6852 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6853 std::vector<FakeVideoReceiveStream*> receive_streams =
6854 fake_call_->GetVideoReceiveStreams();
6855 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006856 // Default local SSRC when we have no sender.
6857 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6858 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006859 }
6860 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6861 if (!receiver_first)
6862 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6863 std::vector<FakeVideoReceiveStream*> receive_streams =
6864 fake_call_->GetVideoReceiveStreams();
6865 ASSERT_EQ(1u, receive_streams.size());
6866 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006867
6868 // Removing first sender should fall back to another (in this case the second)
6869 // local send stream's SSRC.
6870 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6871 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006872 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006873 ASSERT_EQ(1u, receive_streams.size());
6874 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6875
6876 // Removing the last sender should fall back to default local SSRC.
6877 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006878 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006879 ASSERT_EQ(1u, receive_streams.size());
6880 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6881 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006882}
6883
eladalonf1841382017-06-12 01:16:46 -07006884TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006885 TestReceiverLocalSsrcConfiguration(false);
6886}
6887
eladalonf1841382017-06-12 01:16:46 -07006888TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006889 TestReceiverLocalSsrcConfiguration(true);
6890}
6891
eladalonf1841382017-06-12 01:16:46 -07006892class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006893 public:
eladalonf1841382017-06-12 01:16:46 -07006894 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006895 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006896 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6897 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006898 mock_rate_allocator_factory_(
6899 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006900 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006901 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006902 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006903 decoder_factory_),
6904 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6905 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006906 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006907
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006908 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006909 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01006910 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
6911 VideoOptions(),
6912 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006913 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006914 last_ssrc_ = 123;
6915 }
6916
6917 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006918 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006919 int capture_width,
6920 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006921 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006922 size_t expected_num_streams,
6923 bool screenshare,
6924 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006925 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006926 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006927 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006928 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006929
Peter Boström0c4e06b2015-10-07 12:23:21 +02006930 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006931 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006932 ssrcs.resize(num_configured_streams);
6933
sprangf24a0642017-02-28 13:23:26 -08006934 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006935 // Send a full-size frame to trigger a stream reconfiguration to use all
6936 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01006937 webrtc::test::FrameForwarder frame_forwarder;
6938 cricket::FakeFrameSource frame_source(capture_width, capture_height,
6939 rtc::kNumMicrosecsPerSec / 30);
6940
sprangf24a0642017-02-28 13:23:26 -08006941 VideoOptions options;
6942 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006943 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01006944 EXPECT_TRUE(
6945 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08006946 // Fetch the latest stream since SetVideoSend() may recreate it if the
6947 // screen content setting is changed.
6948 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006949 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006950 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006951
Zach Stein3ca452b2018-01-18 10:01:24 -08006952 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6953 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6954
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006955 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6956 ASSERT_EQ(expected_num_streams, video_streams.size());
6957
sprang429600d2017-01-26 06:12:26 -08006958 std::vector<webrtc::VideoStream> expected_streams;
6959 if (conference_mode) {
6960 expected_streams = GetSimulcastConfig(
6961 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006962 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006963 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006964 if (screenshare) {
6965 for (const webrtc::VideoStream& stream : expected_streams) {
6966 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006967 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6968 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006969 }
6970 }
sprang429600d2017-01-26 06:12:26 -08006971 } else {
6972 webrtc::VideoStream stream;
6973 stream.width = capture_width;
6974 stream.height = capture_height;
6975 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006976 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006977 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006978 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006979 stream.max_qp = kDefaultQpMax;
6980 expected_streams.push_back(stream);
6981 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006982
6983 ASSERT_EQ(expected_streams.size(), video_streams.size());
6984
6985 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006986 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006987 for (size_t i = 0; i < num_streams; ++i) {
6988 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6989 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6990
6991 EXPECT_GT(video_streams[i].max_framerate, 0);
6992 EXPECT_EQ(expected_streams[i].max_framerate,
6993 video_streams[i].max_framerate);
6994
6995 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6996 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6997 video_streams[i].min_bitrate_bps);
6998
6999 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7000 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7001 video_streams[i].target_bitrate_bps);
7002
7003 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7004 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7005 video_streams[i].max_bitrate_bps);
7006
7007 EXPECT_GT(video_streams[i].max_qp, 0);
7008 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7009
Sergey Silkina796a7e2018-03-01 15:11:29 +01007010 EXPECT_EQ(conference_mode,
7011 expected_streams[i].num_temporal_layers.has_value());
7012
7013 if (conference_mode) {
7014 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7015 video_streams[i].num_temporal_layers);
7016 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007017
7018 if (i == num_streams - 1) {
7019 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7020 } else {
7021 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7022 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007023 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007024
Niels Möllerff40b142018-04-09 08:49:14 +02007025 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007026 }
7027
7028 FakeVideoSendStream* AddSendStream() {
7029 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7030 }
7031
7032 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007033 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007034 EXPECT_TRUE(channel_->AddSendStream(sp));
7035 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007036 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007037 EXPECT_EQ(num_streams + 1, streams.size());
7038 return streams[streams.size() - 1];
7039 }
7040
7041 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007042 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007043 }
7044
7045 FakeVideoReceiveStream* AddRecvStream() {
7046 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7047 }
7048
7049 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007050 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007051 EXPECT_TRUE(channel_->AddRecvStream(sp));
7052 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007053 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007054 EXPECT_EQ(num_streams + 1, streams.size());
7055 return streams[streams.size() - 1];
7056 }
7057
skvlad11a9cbf2016-10-07 11:53:05 -07007058 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007059 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007060 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7061 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007062 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007063 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007064 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007065 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007066};
7067
eladalonf1841382017-06-12 01:16:46 -07007068TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007069 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7070 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007071}
7072
eladalonf1841382017-06-12 01:16:46 -07007073TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007074 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7075 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007076}
7077
7078// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007079TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007080 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7081 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007082}
sprang429600d2017-01-26 06:12:26 -08007083
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007084TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007085 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7086 false);
7087}
7088
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007089TEST_F(WebRtcVideoChannelSimulcastTest,
7090 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007091 webrtc::test::ScopedFieldTrials field_trials(
7092 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007093 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7094 true);
7095}
7096
eladalonf1841382017-06-12 01:16:46 -07007097TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007098 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7099 true);
7100}
7101
eladalonf1841382017-06-12 01:16:46 -07007102TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007103 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007104 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7105 false);
7106}
7107
Yves Gereyb6a89422018-10-08 10:08:32 +02007108class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007109 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02007110 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007111 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7112 }
7113 rtc::ScopedFakeClock fake_clock_;
7114};
7115
Yves Gereyb6a89422018-10-08 10:08:32 +02007116// The fake clock needs to be initialized before the call, and not
7117// destroyed until after all threads spawned by the test have been stopped.
7118// This mixin ensures that.
7119class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7120 public WebRtcVideoChannelBaseTest {};
7121
Jonas Oreland49ac5952018-09-26 16:04:32 +02007122TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7123 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7124 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7125
7126 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7127
7128 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7129 rtc::SetBE32(packet1.data() + 8, kSsrc);
7130 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7131 EXPECT_TRUE(SetDefaultCodec());
7132 EXPECT_TRUE(SetSend(true));
7133 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01007134 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007135
7136 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7137 EXPECT_EQ(1u, sources.size());
7138 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7139 int64_t timestamp1 = sources[0].timestamp_ms();
7140
7141 // a new packet.
7142 int64_t timeDeltaMs = 1;
7143 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01007144 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007145 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7146 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7147
7148 // It only keeps 10s of history.
7149 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7150 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7151 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7152}
7153
7154TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7155 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7156 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7157
7158 uint32_t kCsrc = 4321u;
7159 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7160 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7161
7162 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7163 rtc::SetBE32(packet1.data() + 8, kSsrc);
7164 rtc::SetBE32(packet1.data() + 12, kCsrc);
7165 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7166 EXPECT_TRUE(SetDefaultCodec());
7167 EXPECT_TRUE(SetSend(true));
7168 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01007169 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007170
7171 {
7172 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7173 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7174 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7175 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7176 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007177 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7178 return source.source_type() == webrtc::RtpSourceType::SSRC;
7179 }));
7180 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7181 return source.source_type() == webrtc::RtpSourceType::CSRC;
7182 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007183 }
7184 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7185
7186 // a new packet with only ssrc (i.e no csrc).
7187 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7188 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7189 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7190 rtc::SetBE32(packet2.data() + 8, kSsrc);
7191
7192 int64_t timeDeltaMs = 1;
7193 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01007194 channel_->OnPacketReceived(&packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007195
7196 {
7197 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7198 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7199 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7200 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7201 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007202 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7203 return source.source_type() == webrtc::RtpSourceType::SSRC;
7204 }));
7205 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7206 return source.source_type() == webrtc::RtpSourceType::CSRC;
7207 }));
7208 auto ssrcSource =
7209 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007210 return source.source_type() == webrtc::RtpSourceType::SSRC;
7211 });
Steve Anton2c9ebef2019-01-28 17:27:58 -08007212 auto csrcSource =
7213 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007214 return source.source_type() == webrtc::RtpSourceType::CSRC;
7215 });
7216
7217 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7218 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7219 }
7220
7221 // It only keeps 10s of history.
7222 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7223
7224 {
7225 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7226 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7227 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
Steve Anton2c9ebef2019-01-28 17:27:58 -08007228 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7229 return source.source_type() == webrtc::RtpSourceType::SSRC;
7230 }));
7231 EXPECT_EQ(0, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7232 return source.source_type() == webrtc::RtpSourceType::CSRC;
7233 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007234 }
7235
7236 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7237 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7238 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7239}
7240
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007241} // namespace cricket