blob: 31dfb55890939f6a6ace62b74b785efe22596346 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +000011#include <algorithm>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000012#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080013#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Niels Möller039743e2018-10-23 10:07:25 +020017#include "absl/strings/match.h"
Seth Hampson24722b32017-12-22 09:36:42 -080018#include "api/rtpparameters.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080019#include "api/test/mock_video_bitrate_allocator.h"
20#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070021#include "api/test/mock_video_decoder_factory.h"
22#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020023#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080024#include "api/video/builtin_video_bitrate_allocator_factory.h"
Åsa Persson23eba222018-10-02 14:47:06 +020025#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020026#include "api/video_codecs/builtin_video_decoder_factory.h"
27#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020028#include "api/video_codecs/sdp_video_format.h"
29#include "api/video_codecs/video_decoder_factory.h"
30#include "api/video_codecs/video_encoder.h"
31#include "api/video_codecs/video_encoder_factory.h"
32#include "call/flexfec_receive_stream.h"
33#include "common_video/h264/profile_level_id.h"
34#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller6557d0c2018-04-11 15:18:34 +020035#include "media/base/fakenetworkinterface.h"
36#include "media/base/fakevideocapturer.h"
37#include "media/base/fakevideorenderer.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020038#include "media/base/mediaconstants.h"
39#include "media/base/rtputils.h"
40#include "media/base/testutils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020041#include "media/engine/constants.h"
42#include "media/engine/fakewebrtccall.h"
43#include "media/engine/fakewebrtcvideoengine.h"
44#include "media/engine/simulcast.h"
45#include "media/engine/webrtcvideoengine.h"
46#include "media/engine/webrtcvoiceengine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020047#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020048#include "rtc_base/arraysize.h"
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +020049#include "rtc_base/fakeclock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020051#include "rtc_base/numerics/safe_conversions.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "test/field_trial.h"
53#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000054
Tommi85959932018-02-07 19:26:06 +010055using cricket::FakeVideoCapturerWithTaskQueue;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010056using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070057using webrtc::RtpExtension;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010058using testing::Field;
isheriff6f8d6862016-05-26 11:24:55 -070059
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000060namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000061static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000062
noahricd10a68e2015-07-10 11:27:55 -070063static const uint8_t kRedRtxPayloadType = 125;
64
Niels Möller6557d0c2018-04-11 15:18:34 +020065static const uint32_t kTimeout = 5000U;
66static const uint32_t kDefaultReceiveSsrc = 0;
67static const uint32_t kSsrc = 1234u;
68static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
69static const int kVideoWidth = 640;
70static const int kVideoHeight = 360;
71static const int kFramerate = 30;
72
Peter Boström0c4e06b2015-10-07 12:23:21 +020073static const uint32_t kSsrcs1[] = {1};
74static const uint32_t kSsrcs3[] = {1, 2, 3};
75static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080076static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020077static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080078static const uint32_t kDefaultRecvSsrc = 0;
79
pbos@webrtc.org3c107582014-07-20 15:27:35 +000080static const char kUnsupportedExtensionName[] =
81 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000082
magjed509e4fe2016-11-18 01:34:11 -080083cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
84 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020085 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080086}
87
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000088void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
89 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
90 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
91 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
92 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
93 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
94 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
95 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -080096 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
97 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000098 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
99}
100
magjed725e4842016-11-16 00:48:13 -0800101// Return true if any codec in |codecs| is an RTX codec with associated payload
102// type |payload_type|.
103bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
104 int payload_type) {
105 for (const cricket::VideoCodec& codec : codecs) {
106 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200107 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800108 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
109 &associated_payload_type) &&
110 associated_payload_type == payload_type) {
111 return true;
112 }
113 }
114 return false;
115}
116
nisseca5706d2017-09-11 02:32:16 -0700117// TODO(nisse): Duplicated in call.cc.
118const int* FindKeyByValue(const std::map<int, int>& m, int v) {
119 for (const auto& kv : m) {
120 if (kv.second == v)
121 return &kv.first;
122 }
123 return nullptr;
124}
125
Yves Gerey665174f2018-06-19 15:03:05 +0200126bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
127 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700128 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
129 payload_type) != nullptr;
130}
131
132// Check that there's an Rtx payload type for each decoder.
133bool VerifyRtxReceiveAssociations(
134 const webrtc::VideoReceiveStream::Config& config) {
135 for (const auto& decoder : config.decoders) {
136 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
137 return false;
138 }
139 return true;
140}
141
brandtrffc61182016-11-28 06:02:22 -0800142rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700143 int width,
144 int height) {
145 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
146 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800147 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700148 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000149}
150
Shao Changbine62202f2015-04-21 20:24:50 +0800151void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
152 const std::map<int, int>& rtx_types) {
153 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200154 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800155 EXPECT_TRUE(it != rtx_types.end() &&
156 it->second == config.rtp.rtx.payload_type);
157
brandtrb5f2c3f2016-10-04 23:28:39 -0700158 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
159 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800160 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700161 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800162 }
163}
kthelgason2bc68642017-02-07 07:02:22 -0800164
165cricket::MediaConfig GetMediaConfig() {
166 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100167 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800168 return media_config;
169}
nisse26e3abb2017-08-25 04:44:25 -0700170
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200171// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
172int GetMaxDefaultBitrateBps(size_t width, size_t height) {
173 if (width * height <= 320 * 240) {
174 return 600000;
175 } else if (width * height <= 640 * 480) {
176 return 1700000;
177 } else if (width * height <= 960 * 540) {
178 return 2000000;
179 } else {
180 return 2500000;
181 }
182}
183
Niels Möller731a2c22018-07-30 15:08:07 +0200184class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
185 public:
186 MOCK_METHOD2(AddOrUpdateSink,
187 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
188 const rtc::VideoSinkWants& wants));
189 MOCK_METHOD1(RemoveSink,
190 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
191};
192
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000193} // namespace
194
Yves Gerey665174f2018-06-19 15:03:05 +0200195#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200196 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200197 EXPECT_EQ((w), renderer_.width()); \
198 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200199 EXPECT_EQ(0, renderer_.errors());
200
Yves Gerey665174f2018-06-19 15:03:05 +0200201#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200202 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200203 EXPECT_EQ((w), (r).width()); \
204 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200205 EXPECT_EQ(0, (r).errors());
206
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000207namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700208class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000209 public:
eladalonf1841382017-06-12 01:16:46 -0700210 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
211 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700212 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700213 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200214 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
215 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200216 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200217 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200218 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800219 decoder_factory_),
220 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200221 // Ensure fake clock doesn't return 0, which will cause some initializations
222 // fail inside RTP senders.
223 fake_clock_.AdvanceTimeMicros(1);
224 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000225
226 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200227 void AssignDefaultAptRtxTypes();
228 void AssignDefaultCodec();
229
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100230 // Find the index of the codec in the engine with the given name. The codec
231 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100232 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100233
magjed509e4fe2016-11-18 01:34:11 -0800234 // Find the codec in the engine with the given name. The codec must be
235 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100236 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800237
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200238 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000239
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200240 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000241 const std::vector<VideoCodec>& codecs);
242
Peter Boströme4499152016-02-05 11:13:28 +0100243 void TestExtendedEncoderOveruse(bool use_external_encoder);
244
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200245 // Has to be the first one, so it is initialized before the call or there is a
246 // race condition in the clock access.
247 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700248 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700249 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700250 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000251 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800252 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200253 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
254 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700255 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000256 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800257 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000258};
259
eladalonf1841382017-06-12 01:16:46 -0700260TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200261 encoder_factory_->AddSupportedVideoCodecType("VP8");
262 AssignDefaultCodec();
263
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000264 std::vector<VideoCodec> engine_codecs = engine_.codecs();
265 for (size_t i = 0; i < engine_codecs.size(); ++i) {
266 if (engine_codecs[i].name != kRtxCodecName)
267 continue;
268 int associated_payload_type;
269 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000270 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000271 EXPECT_EQ(default_codec_.id, associated_payload_type);
272 return;
273 }
274 FAIL() << "No RTX codec found among default codecs.";
275}
276
eladalonf1841382017-06-12 01:16:46 -0700277TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100278 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100279 EXPECT_THAT(
280 capabilities.header_extensions,
281 testing::Contains(RtpExtension(RtpExtension::kTimestampOffsetUri,
282 RtpExtension::kTimestampOffsetDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000283}
284
eladalonf1841382017-06-12 01:16:46 -0700285TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100286 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100287 EXPECT_THAT(
288 capabilities.header_extensions,
289 testing::Contains(RtpExtension(RtpExtension::kAbsSendTimeUri,
290 RtpExtension::kAbsSendTimeDefaultId)));
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000291}
292
eladalonf1841382017-06-12 01:16:46 -0700293TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100294 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100295 EXPECT_THAT(capabilities.header_extensions,
296 testing::Contains(RtpExtension(
297 RtpExtension::kTransportSequenceNumberUri,
298 RtpExtension::kTransportSequenceNumberDefaultId)));
stefanc1aeaf02015-10-15 07:26:07 -0700299}
300
eladalonf1841382017-06-12 01:16:46 -0700301TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Stefan Holmer9d69c3f2015-12-07 10:45:43 +0100302 RtpCapabilities capabilities = engine_.GetCapabilities();
Johannes Krond0b69a82018-12-03 14:18:53 +0100303 EXPECT_THAT(
304 capabilities.header_extensions,
305 testing::Contains(RtpExtension(RtpExtension::kVideoRotationUri,
306 RtpExtension::kVideoRotationDefaultId)));
307}
308
309TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
310 RtpCapabilities capabilities = engine_.GetCapabilities();
311 EXPECT_THAT(
312 capabilities.header_extensions,
313 testing::Contains(RtpExtension(RtpExtension::kColorSpaceUri,
314 RtpExtension::kColorSpaceDefaultId)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700315}
316
philipel1e054862018-10-08 16:13:53 +0200317class WebRtcVideoEngineTestWithGenericDescriptor
318 : public WebRtcVideoEngineTest {
319 public:
320 WebRtcVideoEngineTestWithGenericDescriptor()
321 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
322};
323
324TEST_F(WebRtcVideoEngineTestWithGenericDescriptor, AdvertiseGenericDescriptor) {
325 RtpCapabilities capabilities = engine_.GetCapabilities();
326 ASSERT_FALSE(capabilities.header_extensions.empty());
327 for (const RtpExtension& extension : capabilities.header_extensions) {
328 if (extension.uri == RtpExtension::kGenericFrameDescriptorUri) {
329 EXPECT_EQ(RtpExtension::kGenericFrameDescriptorDefaultId, extension.id);
330 return;
331 }
332 }
333 FAIL() << "Generic descriptor extension not in header-extension list.";
334}
335
eladalonf1841382017-06-12 01:16:46 -0700336TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200337 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700338 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200339 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700340
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200341 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700342
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200343 std::unique_ptr<VideoMediaChannel> channel(
344 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700345 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
346
347 // Add CVO extension.
348 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800349 cricket::VideoSendParameters parameters;
350 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200351 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700352 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200353 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700354
Niels Möller731a2c22018-07-30 15:08:07 +0200355 EXPECT_CALL(
356 video_source,
357 AddOrUpdateSink(testing::_,
358 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200360 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700361
362 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200363 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700364
365 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200366 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200367 EXPECT_CALL(
368 video_source,
369 AddOrUpdateSink(testing::_,
370 Field(&rtc::VideoSinkWants::rotation_applied, true)));
371
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200372 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373}
374
eladalonf1841382017-06-12 01:16:46 -0700375TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200376 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800377 // dtor is called.
Niels Möller731a2c22018-07-30 15:08:07 +0200378 testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800379
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200380 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800381
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200382 std::unique_ptr<VideoMediaChannel> channel(
383 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800384 // Add CVO extension.
385 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800386 cricket::VideoSendParameters parameters;
387 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800388 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700389 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800390 EXPECT_TRUE(channel->SetSendParameters(parameters));
391 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
392
Niels Möller731a2c22018-07-30 15:08:07 +0200393 // Set source.
394 EXPECT_CALL(
395 video_source,
396 AddOrUpdateSink(testing::_,
397 Field(&rtc::VideoSinkWants::rotation_applied, false)));
398 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800399}
400
eladalonf1841382017-06-12 01:16:46 -0700401TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200402 testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700403
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200404 encoder_factory_->AddSupportedVideoCodecType("VP8");
405 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700406
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200407 std::unique_ptr<VideoMediaChannel> channel(
408 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700409 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
410
411 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200412 EXPECT_CALL(
413 video_source,
414 AddOrUpdateSink(testing::_,
415 Field(&rtc::VideoSinkWants::rotation_applied, true)));
416 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700417
perkjcaafdba2016-03-20 07:34:29 -0700418 // Verify capturer has turned on applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200419 testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700420
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700421 // Add CVO extension.
422 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800423 cricket::VideoSendParameters parameters;
424 parameters.codecs.push_back(GetEngineCodec("VP8"));
425 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200426 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700427 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700428 // Also remove the first codec to trigger a codec change as well.
429 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200430 EXPECT_CALL(
431 video_source,
432 AddOrUpdateSink(testing::_,
433 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200434 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700435
436 // Verify capturer has turned off applying rotation.
Niels Möller731a2c22018-07-30 15:08:07 +0200437 testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700438
439 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200440 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200441 EXPECT_CALL(
442 video_source,
443 AddOrUpdateSink(testing::_,
444 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200445 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700446}
447
eladalonf1841382017-06-12 01:16:46 -0700448TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200449 encoder_factory_->AddSupportedVideoCodecType("VP8");
450
Sebastian Jansson84848f22018-11-16 10:40:36 +0100451 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700452 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000453
454 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
455
456 EXPECT_FALSE(channel->SetSend(true))
457 << "Channel should not start without codecs.";
458 EXPECT_TRUE(channel->SetSend(false))
459 << "Channel should be stoppable even without set codecs.";
460}
461
eladalonf1841382017-06-12 01:16:46 -0700462TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200463 encoder_factory_->AddSupportedVideoCodecType("VP8");
464
Sebastian Jansson84848f22018-11-16 10:40:36 +0100465 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700466 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000467 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
468 VideoMediaInfo info;
469 channel->GetStats(&info);
470}
471
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200472TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200473 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000474
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200475 std::unique_ptr<VideoMediaChannel> channel(
476 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800477 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000478
479 EXPECT_TRUE(
480 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200481 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000482 EXPECT_TRUE(channel->SetSend(true));
Tommi85959932018-02-07 19:26:06 +0100483 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200484 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000485 EXPECT_EQ(cricket::CS_RUNNING,
486 capturer.Start(capturer.GetSupportedFormats()->front()));
487 EXPECT_TRUE(capturer.CaptureFrame());
Per21d45d22016-10-30 21:37:57 +0100488 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200489 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
490 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000491 kTimeout);
492
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200493 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100494 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000495
496 // Setting codecs of the same type should not reallocate any encoders
497 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800498 cricket::VideoSendParameters parameters;
499 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200500 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200501 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000502
503 // Remove stream previously added to free the external encoder instance.
504 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200505 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000506}
507
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200508// Test that when an encoder factory supports H264, we add an RTX
509// codec for it.
510// TODO(deadbeef): This test should be updated if/when we start
511// adding RTX codecs for unrecognized codec names.
512TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800513 using webrtc::H264::ProfileLevelIdToString;
514 using webrtc::H264::ProfileLevelId;
515 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200516 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
517 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800518 *ProfileLevelIdToString(
519 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200520 webrtc::SdpVideoFormat h264_constrained_high("H264");
521 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800522 *ProfileLevelIdToString(
523 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200524 webrtc::SdpVideoFormat h264_high("H264");
525 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800526 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
527
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200528 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
529 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
530 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700531
magjed725e4842016-11-16 00:48:13 -0800532 // First figure out what payload types the test codecs got assigned.
533 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800534 // Now search for RTX codecs for them. Expect that they all have associated
535 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800536 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200537 codecs,
538 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
539 ->id));
magjed725e4842016-11-16 00:48:13 -0800540 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200541 codecs,
542 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
543 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800544 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200545 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700546}
547
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100548#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700549TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200550 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100551
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200552 std::unique_ptr<VideoMediaChannel> channel(
553 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100554
555 EXPECT_TRUE(
556 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
557}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100558#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100559
eladalonf1841382017-06-12 01:16:46 -0700560TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200561 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100562 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200563 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200564 std::unique_ptr<VideoMediaChannel> channel(
565 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700566
567 EXPECT_TRUE(
568 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
569
Tommi85959932018-02-07 19:26:06 +0100570 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200571 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
qiangchenc27d89f2015-07-16 10:27:16 -0700572 capturer.Start(cricket::VideoFormat(1280, 720,
573 cricket::VideoFormat::FpsToInterval(60),
574 cricket::FOURCC_I420));
575 channel->SetSend(true);
576
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200577 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700578
579 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700580 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700581 for (int i = 0; i < 10; i++) {
582 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700583 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700584 int64_t interval = timestamp - last_timestamp;
585
586 // Precision changes from nanosecond to millisecond.
587 // Allow error to be no more than 1.
588 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
589
590 last_timestamp = timestamp;
591 }
592
593 capturer.Start(cricket::VideoFormat(1280, 720,
594 cricket::VideoFormat::FpsToInterval(30),
595 cricket::FOURCC_I420));
596
597 EXPECT_TRUE(capturer.CaptureFrame());
598 last_timestamp = stream->GetLastTimestamp();
599 for (int i = 0; i < 10; i++) {
600 EXPECT_TRUE(capturer.CaptureFrame());
pbos1cb121d2015-09-14 11:38:38 -0700601 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700602 int64_t interval = timestamp - last_timestamp;
603
604 // Precision changes from nanosecond to millisecond.
605 // Allow error to be no more than 1.
606 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
607
608 last_timestamp = timestamp;
609 }
610
611 // Remove stream previously added to free the external encoder instance.
612 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
613}
614
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200615void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
616 std::vector<VideoCodec> engine_codecs = engine_.codecs();
617 RTC_DCHECK(!engine_codecs.empty());
618 for (const cricket::VideoCodec& codec : engine_codecs) {
619 if (codec.name == "rtx") {
620 int associated_payload_type;
621 if (codec.GetParam(kCodecParamAssociatedPayloadType,
622 &associated_payload_type)) {
623 default_apt_rtx_types_[associated_payload_type] = codec.id;
624 }
625 }
626 }
627}
628
629void WebRtcVideoEngineTest::AssignDefaultCodec() {
630 std::vector<VideoCodec> engine_codecs = engine_.codecs();
631 RTC_DCHECK(!engine_codecs.empty());
632 bool codec_set = false;
633 for (const cricket::VideoCodec& codec : engine_codecs) {
634 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
635 codec.name != "ulpfec") {
636 default_codec_ = codec;
637 codec_set = true;
638 }
639 }
640
641 RTC_DCHECK(codec_set);
642}
643
Oleh Prypina40f8242017-12-21 13:32:23 +0100644size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
645 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100646 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
647 for (size_t i = 0; i < codecs.size(); ++i) {
648 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200649 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200650 continue;
651 // The tests only use H264 Constrained Baseline. Make sure we don't return
652 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200653 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200654 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200655 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
656 if (profile_level_id->profile !=
657 webrtc::H264::kProfileConstrainedBaseline) {
658 continue;
659 }
660 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100661 return i;
magjed509e4fe2016-11-18 01:34:11 -0800662 }
663 // This point should never be reached.
664 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100665 return -1;
666}
667
668cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
669 const std::string& name) const {
670 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800671}
672
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200673VideoMediaChannel*
674WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100675 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700676 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200677 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800678 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200679 for (const webrtc::SdpVideoFormat& format :
680 encoder_factory_->GetSupportedFormats()) {
681 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
682 if (std::find(parameters.codecs.begin(), parameters.codecs.end(),
683 engine_codec) == parameters.codecs.end()) {
684 parameters.codecs.push_back(engine_codec);
685 }
686 }
magjed509e4fe2016-11-18 01:34:11 -0800687
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200688 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000689
690 return channel;
691}
692
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200693VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000694 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100695 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700696 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200697 cricket::VideoRecvParameters parameters;
698 parameters.codecs = codecs;
699 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000700
701 return channel;
702}
703
eladalonf1841382017-06-12 01:16:46 -0700704TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200705 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000706
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200707 std::unique_ptr<VideoMediaChannel> channel(
708 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000709
Peter Boström0c4e06b2015-10-07 12:23:21 +0200710 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000711
Yves Gerey665174f2018-06-19 15:03:05 +0200712 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000713 EXPECT_TRUE(channel->SetSend(true));
714
Tommi85959932018-02-07 19:26:06 +0100715 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200716 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000717 EXPECT_EQ(cricket::CS_RUNNING,
718 capturer.Start(capturer.GetSupportedFormats()->front()));
719 EXPECT_TRUE(capturer.CaptureFrame());
720
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200721 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000722
723 // Verify that encoders are configured for simulcast through adapter
724 // (increasing resolution and only configured to send one stream each).
725 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200726 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
727 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000728 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200729 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000730 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
731 EXPECT_GT(codec_settings.width, prev_width);
732 prev_width = codec_settings.width;
733 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000734
Niels Möllerff40b142018-04-09 08:49:14 +0200735 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000736
737 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200738 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000739}
740
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200741TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
742 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200743 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000744
Niels Möller4db138e2018-04-19 09:04:13 +0200745 // Set capturer.
746 FakeVideoCapturerWithTaskQueue capturer;
747 EXPECT_EQ(cricket::CS_RUNNING,
748 capturer.Start(capturer.GetSupportedFormats()->front()));
749
Sebastian Jansson84848f22018-11-16 10:40:36 +0100750 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700751 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200752 cricket::VideoSendParameters parameters;
753 parameters.codecs.push_back(GetEngineCodec("H264"));
754 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000755
756 EXPECT_TRUE(
757 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller4db138e2018-04-19 09:04:13 +0200758 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
759 // Sending one frame will have allocate the encoder.
760 EXPECT_TRUE(capturer.CaptureFrame());
761
762 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000763
Anders Carlsson67537952018-05-03 11:28:29 +0200764 cricket::VideoSendParameters new_parameters;
765 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
766 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200767
768 // Sending one frame will switch encoder.
769 EXPECT_TRUE(capturer.CaptureFrame());
770
Anders Carlsson8a150d92018-05-14 12:40:04 +0200771 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000772}
773
eladalonf1841382017-06-12 01:16:46 -0700774TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000775 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200776 encoder_factory_->AddSupportedVideoCodecType("VP8");
777 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000778
Sebastian Jansson84848f22018-11-16 10:40:36 +0100779 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700780 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800781 cricket::VideoSendParameters parameters;
782 parameters.codecs.push_back(GetEngineCodec("VP8"));
783 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000784
Peter Boström0c4e06b2015-10-07 12:23:21 +0200785 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000786
Yves Gerey665174f2018-06-19 15:03:05 +0200787 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000788 EXPECT_TRUE(channel->SetSend(true));
789
790 // Send a fake frame, or else the media engine will configure the simulcast
791 // encoder adapter at a low-enough size that it'll only create a single
792 // encoder layer.
Tommi85959932018-02-07 19:26:06 +0100793 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200794 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &capturer));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000795 EXPECT_EQ(cricket::CS_RUNNING,
796 capturer.Start(capturer.GetSupportedFormats()->front()));
797 EXPECT_TRUE(capturer.CaptureFrame());
798
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200799 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
800 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000801 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200802 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000803
804 channel.reset();
805 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200806 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000807}
808
eladalonf1841382017-06-12 01:16:46 -0700809TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000810 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 encoder_factory_->AddSupportedVideoCodecType("VP8");
812 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000813
Sebastian Jansson84848f22018-11-16 10:40:36 +0100814 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700815 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800816 cricket::VideoSendParameters parameters;
817 parameters.codecs.push_back(GetEngineCodec("H264"));
818 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000819
820 EXPECT_TRUE(
821 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100822
823 // Send a frame of 720p. This should trigger a "real" encoder initialization.
824 cricket::VideoFormat format(
825 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100826 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200827 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &capturer));
Per21d45d22016-10-30 21:37:57 +0100828 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
829 EXPECT_TRUE(capturer.CaptureFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200830 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
831 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200832 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000833 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200834 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000835
836 channel.reset();
837 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200838 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000839}
840
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200841TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
842 webrtc::test::ScopedFieldTrials override_field_trials_(
843 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200844 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700845
Sebastian Jansson84848f22018-11-16 10:40:36 +0100846 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700847 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200848 cricket::VideoSendParameters parameters;
849 parameters.codecs.push_back(GetEngineCodec("H264"));
850 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700851
Peter Boström0c4e06b2015-10-07 12:23:21 +0200852 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700853 EXPECT_TRUE(
854 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100855
856 // Send a frame of 720p. This should trigger a "real" encoder initialization.
noahricfdac5162015-08-27 01:59:29 -0700857 cricket::VideoFormat format(
858 1280, 720, cricket::VideoFormat::FpsToInterval(30), cricket::FOURCC_I420);
Tommi85959932018-02-07 19:26:06 +0100859 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +0200860 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &capturer));
Peter Boströmce23bee2016-02-02 14:14:30 +0100861 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(format));
862 EXPECT_TRUE(capturer.CaptureFrame());
863
Niels Möller4db138e2018-04-19 09:04:13 +0200864 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200865 ASSERT_EQ(1u, encoder_factory_->encoders().size());
866 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
867 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700868 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200869 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200870 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700871}
872
brandtrffc61182016-11-28 06:02:22 -0800873// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700874// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800875//
876// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700877TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800878 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200879 encoder_factory_->AddSupportedVideoCodecType("VP8");
880
brandtrffc61182016-11-28 06:02:22 -0800881 auto is_flexfec = [](const VideoCodec& codec) {
882 if (codec.name == "flexfec-03")
883 return true;
884 return false;
885 };
886
887 // FlexFEC is not active without field trial.
brandtrffc61182016-11-28 06:02:22 -0800888 const std::vector<VideoCodec> codecs_before = engine_.codecs();
889 EXPECT_EQ(codecs_before.end(), std::find_if(codecs_before.begin(),
890 codecs_before.end(), is_flexfec));
891
892 // FlexFEC is active with field trial.
893 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800894 "WebRTC-FlexFEC-03-Advertised/Enabled/");
brandtrffc61182016-11-28 06:02:22 -0800895 const std::vector<VideoCodec> codecs_after = engine_.codecs();
896 EXPECT_NE(codecs_after.end(),
897 std::find_if(codecs_after.begin(), codecs_after.end(), is_flexfec));
898}
899
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200900// Test that codecs are added in the order they are reported from the factory.
901TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
902 encoder_factory_->AddSupportedVideoCodecType("VP8");
903 const char* kFakeCodecName = "FakeCodec";
904 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000905
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200906 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100907 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200908 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
909 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000910}
911
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200912// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800913// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200914TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100915 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
916 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100917
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100918 // Set up external encoder factory with first codec, and initialize engine.
919 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
920
brandtrffc61182016-11-28 06:02:22 -0800921 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800922
923 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100924 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800925 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200926 // The codec itself and RTX should have been added.
927 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100928
929 // Check that both fake codecs are present and that the second fake codec
930 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100931 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
932 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100933 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800934}
935
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200936TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
937 const char* kFakeCodecName = "FakeCodec";
938 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
939
940 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
941 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
942}
943
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200944TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
945 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200946 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200947 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800948 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000949
kwiberg686a8ef2016-02-26 03:00:35 -0800950 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200951 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000952
953 EXPECT_TRUE(
954 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200955 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000956
957 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200958 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200959 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000960
961 // Remove stream previously added to free the external decoder instance.
962 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200963 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000964}
965
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200966// Verifies that we can set up decoders.
967TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000968 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
969 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
970 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
971 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200972 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200973 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000974 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800975 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000976
kwiberg686a8ef2016-02-26 03:00:35 -0800977 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200978 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000979
980 EXPECT_TRUE(
981 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200982 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000983}
984
Jonas Oreland49ac5952018-09-26 16:04:32 +0200985// Tests when GetSources is called with non-existing ssrc, it will return an
986// empty list of RtpSource without crashing.
987TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
988 // Setup an recv stream with |kSsrc|.
989 encoder_factory_->AddSupportedVideoCodecType("VP8");
990 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
991 cricket::VideoRecvParameters parameters;
992 parameters.codecs.push_back(GetEngineCodec("VP8"));
993 std::unique_ptr<VideoMediaChannel> channel(
994 SetRecvParamsWithSupportedCodecs(parameters.codecs));
995
996 EXPECT_TRUE(
997 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
998
999 // Call GetSources with |kSsrc + 1| which doesn't exist.
1000 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1001 EXPECT_EQ(0u, sources.size());
1002}
1003
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001004TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1005 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1006 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001007 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001008 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001009 std::move(decoder_factory),
1010 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001011 EXPECT_EQ(0u, engine.codecs().size());
1012}
1013
1014TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1015 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001016 webrtc::MockVideoEncoderFactory* encoder_factory =
1017 new webrtc::MockVideoEncoderFactory();
1018 webrtc::MockVideoDecoderFactory* decoder_factory =
1019 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001020 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1021 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001022 WebRtcVideoEngine engine(
1023 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001024 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1025 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1026 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001027 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1028 EXPECT_EQ(0u, engine.codecs().size());
1029 EXPECT_CALL(*encoder_factory, Die());
1030 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001031 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001032}
1033
1034// Test full behavior in the video engine when video codec factories of the new
1035// type are injected supporting the single codec Vp8. Check the returned codecs
1036// from the engine and that we will create a Vp8 encoder and decoder using the
1037// new factories.
1038TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1039 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001040 webrtc::MockVideoEncoderFactory* encoder_factory =
1041 new webrtc::MockVideoEncoderFactory();
1042 webrtc::MockVideoDecoderFactory* decoder_factory =
1043 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001044 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1045 new webrtc::MockVideoBitrateAllocatorFactory();
1046 EXPECT_CALL(*rate_allocator_factory,
1047 CreateVideoBitrateAllocatorProxy(Field(
1048 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
1049 .WillOnce(testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001050 WebRtcVideoEngine engine(
1051 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001052 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1053 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1054 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001055 const webrtc::SdpVideoFormat vp8_format("VP8");
1056 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1057 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1058 .WillRepeatedly(testing::Return(supported_formats));
1059
1060 // Verify the codecs from the engine.
1061 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001062 // Verify default codecs has been added correctly.
1063 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001064 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001065
1066 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001067 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001068 int vp8_associated_payload;
1069 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1070 &vp8_associated_payload));
1071 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1072
1073 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1074
1075 // RTX codec for RED.
1076 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1077 int red_associated_payload;
1078 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1079 &red_associated_payload));
1080 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1081
1082 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1083
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001084 int associated_payload_type;
1085 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1086 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1087 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1088 // Verify default parameters has been added to the VP8 codec.
1089 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1090
1091 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001092 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1093 codec_info.is_hardware_accelerated = false;
1094 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001096 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
1097 .WillRepeatedly(testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001098 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001099 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001100 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001101 .WillOnce(
1102 ::testing::DoAll(::testing::InvokeWithoutArgs(
1103 [&encoder_created]() { encoder_created.Set(); }),
1104 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001105
1106 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001107 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001108 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
1109 .WillOnce(testing::Return(decoder));
1110
1111 // Create a call.
1112 webrtc::RtcEventLogNullImpl event_log;
1113 std::unique_ptr<webrtc::Call> call(
1114 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1115
1116 // Create send channel.
1117 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001118 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001119 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001120 cricket::VideoSendParameters send_parameters;
1121 send_parameters.codecs.push_back(engine_codecs.at(0));
1122 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1123 send_channel->OnReadyToSend(true);
1124 EXPECT_TRUE(
1125 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1126 EXPECT_TRUE(send_channel->SetSend(true));
1127
Niels Möller4db138e2018-04-19 09:04:13 +02001128 // Set capturer.
1129 FakeVideoCapturerWithTaskQueue capturer;
1130 EXPECT_EQ(cricket::CS_RUNNING,
1131 capturer.Start(capturer.GetSupportedFormats()->front()));
1132 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &capturer));
1133 // Sending one frame will allocate the encoder.
1134 EXPECT_TRUE(capturer.CaptureFrame());
1135 encoder_created.Wait(kTimeout);
1136
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137 // Create recv channel.
1138 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001139 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001140 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001141 cricket::VideoRecvParameters recv_parameters;
1142 recv_parameters.codecs.push_back(engine_codecs.at(0));
1143 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1144 EXPECT_TRUE(recv_channel->AddRecvStream(
1145 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1146
1147 // Remove streams previously added to free the encoder and decoder instance.
1148 EXPECT_CALL(*encoder_factory, Die());
1149 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001150 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001151 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1152 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1153}
1154
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001155// Test behavior when decoder factory fails to create a decoder (returns null).
1156TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1157 // |engine| take ownership of the factories.
1158 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001159 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001160 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001161 new webrtc::MockVideoDecoderFactory();
1162 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1163 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001164 WebRtcVideoEngine engine(
1165 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001166 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1167 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1168 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001169 const webrtc::SdpVideoFormat vp8_format("VP8");
1170 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1171 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
1172 .WillRepeatedly(testing::Return(supported_formats));
1173
1174 // Decoder creation fails.
1175 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(testing::_))
1176 .WillOnce(testing::Return(nullptr));
1177
1178 // Create a call.
1179 webrtc::RtcEventLogNullImpl event_log;
1180 std::unique_ptr<webrtc::Call> call(
1181 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1182
1183 // Create recv channel.
1184 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001185 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001186 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001187 cricket::VideoRecvParameters recv_parameters;
1188 recv_parameters.codecs.push_back(engine.codecs().front());
1189 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1190 EXPECT_TRUE(recv_channel->AddRecvStream(
1191 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1192
1193 // Remove streams previously added to free the encoder and decoder instance.
1194 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1195}
1196
eladalonf1841382017-06-12 01:16:46 -07001197TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001198 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001199 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001200 std::unique_ptr<VideoMediaChannel> channel(
1201 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001202 ASSERT_TRUE(
1203 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1204 cricket::VideoCodec codec = GetEngineCodec("VP8");
1205 cricket::VideoSendParameters parameters;
1206 parameters.codecs.push_back(codec);
1207 channel->OnReadyToSend(true);
1208 channel->SetSend(true);
1209 ASSERT_TRUE(channel->SetSendParameters(parameters));
1210
Tommi85959932018-02-07 19:26:06 +01001211 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08001212 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02001213 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001214
1215 EXPECT_EQ(cricket::CS_RUNNING,
1216 capturer.Start(capturer.GetSupportedFormats()->front()));
1217 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001218 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001219 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001220 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001221
Niels Möllerff40b142018-04-09 08:49:14 +02001222 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001223 EXPECT_TRUE(capturer.CaptureFrame());
1224 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001225 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001226
1227 options.is_screencast.emplace(true);
Niels Möllerff40b142018-04-09 08:49:14 +02001228 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001229 EXPECT_TRUE(capturer.CaptureFrame());
1230 // Change to screen content, recreate encoder. For the simulcast encoder
1231 // adapter case, this will result in two calls since InitEncode triggers a
1232 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001233 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001234 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001235 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001236
Niels Möllerff40b142018-04-09 08:49:14 +02001237 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001238 EXPECT_TRUE(capturer.CaptureFrame());
1239 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001240 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001241
1242 options.is_screencast.emplace(false);
1243 options.video_noise_reduction.emplace(false);
Niels Möllerff40b142018-04-09 08:49:14 +02001244 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08001245 // Change back to regular video content, update encoder. Also change
1246 // a non |is_screencast| option just to verify it doesn't affect recreation.
1247 EXPECT_TRUE(capturer.CaptureFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001248 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001249 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001250 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001251
1252 // Remove stream previously added to free the external encoder instance.
1253 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001254 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001255}
1256
Niels Möller6557d0c2018-04-11 15:18:34 +02001257class WebRtcVideoChannelBaseTest : public testing::Test {
1258 protected:
1259 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001260 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001261 webrtc::CreateBuiltinVideoDecoderFactory(),
1262 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001263
1264 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001265 // One testcase calls SetUp in a loop, only create call_ once.
1266 if (!call_) {
1267 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1268 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001269 cricket::MediaConfig media_config;
1270 // Disabling cpu overuse detection actually disables quality scaling too; it
1271 // implies DegradationPreference kMaintainResolution. Automatic scaling
1272 // needs to be disabled, otherwise, tests which check the size of received
1273 // frames become flaky.
1274 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001275 channel_.reset(
1276 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1277 call_.get(), media_config, cricket::VideoOptions(),
1278 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001279 channel_->OnReadyToSend(true);
1280 EXPECT_TRUE(channel_.get() != NULL);
1281 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001282 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001283 cricket::VideoRecvParameters parameters;
1284 parameters.codecs = engine_.codecs();
1285 channel_->SetRecvParameters(parameters);
1286 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
1287 video_capturer_.reset(CreateFakeVideoCapturer());
1288 cricket::VideoFormat format(640, 480,
1289 cricket::VideoFormat::FpsToInterval(kFramerate),
1290 cricket::FOURCC_I420);
1291 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001292 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001293 }
1294
1295 virtual cricket::FakeVideoCapturerWithTaskQueue* CreateFakeVideoCapturer() {
1296 return new cricket::FakeVideoCapturerWithTaskQueue();
1297 }
1298
1299 // Utility method to setup an additional stream to send and receive video.
1300 // Used to test send and recv between two streams.
1301 void SetUpSecondStream() {
1302 SetUpSecondStreamWithNoRecv();
1303 // Setup recv for second stream.
1304 EXPECT_TRUE(channel_->AddRecvStream(
1305 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1306 // Make the second renderer available for use by a new stream.
1307 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1308 }
1309 // Setup an additional stream just to send video. Defer add recv stream.
1310 // This is required if you want to test unsignalled recv of video rtp packets.
1311 void SetUpSecondStreamWithNoRecv() {
1312 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001313 EXPECT_TRUE(
1314 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001315 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001316 EXPECT_FALSE(
1317 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001318 EXPECT_TRUE(channel_->AddSendStream(
1319 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1320 // We dont add recv for the second stream.
1321
1322 // Setup the receive and renderer for second stream after send.
1323 video_capturer_2_.reset(CreateFakeVideoCapturer());
1324 cricket::VideoFormat format(640, 480,
1325 cricket::VideoFormat::FpsToInterval(kFramerate),
1326 cricket::FOURCC_I420);
1327 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(format));
1328
Yves Gerey665174f2018-06-19 15:03:05 +02001329 EXPECT_TRUE(
1330 channel_->SetVideoSend(kSsrc + 2, nullptr, video_capturer_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001331 }
Yves Gerey665174f2018-06-19 15:03:05 +02001332 virtual void TearDown() { channel_.reset(); }
1333 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001334
1335 bool SetOneCodec(const cricket::VideoCodec& codec) {
1336 cricket::VideoFormat capture_format(
1337 kVideoWidth, kVideoHeight,
1338 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1339
1340 if (video_capturer_) {
1341 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_->Start(capture_format));
1342 }
1343 if (video_capturer_2_) {
1344 EXPECT_EQ(cricket::CS_RUNNING, video_capturer_2_->Start(capture_format));
1345 }
1346
1347 bool sending = channel_->sending();
1348 bool success = SetSend(false);
1349 if (success) {
1350 cricket::VideoSendParameters parameters;
1351 parameters.codecs.push_back(codec);
1352 success = channel_->SetSendParameters(parameters);
1353 }
1354 if (success) {
1355 success = SetSend(sending);
1356 }
1357 return success;
1358 }
Yves Gerey665174f2018-06-19 15:03:05 +02001359 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001360 bool SendFrame() {
1361 if (video_capturer_2_) {
1362 video_capturer_2_->CaptureFrame();
1363 }
1364 return video_capturer_.get() && video_capturer_->CaptureFrame();
1365 }
1366 bool WaitAndSendFrame(int wait_ms) {
1367 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
1368 ret &= SendFrame();
1369 return ret;
1370 }
Yves Gerey665174f2018-06-19 15:03:05 +02001371 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001372 int NumRtpBytes(uint32_t ssrc) {
1373 return network_interface_.NumRtpBytes(ssrc);
1374 }
Yves Gerey665174f2018-06-19 15:03:05 +02001375 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001376 int NumRtpPackets(uint32_t ssrc) {
1377 return network_interface_.NumRtpPackets(ssrc);
1378 }
Yves Gerey665174f2018-06-19 15:03:05 +02001379 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001380 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1381 return network_interface_.GetRtpPacket(index);
1382 }
1383 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001384 webrtc::RTPHeader header;
1385 EXPECT_TRUE(ParseRtpPacket(p, &header));
1386 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001387 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001388
Niels Möller6557d0c2018-04-11 15:18:34 +02001389 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001390 webrtc::RTPHeader* header) {
1391 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1392 webrtc::RtpHeaderParser::Create());
1393 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001394 }
1395
1396 // Tests that we can send and receive frames.
1397 void SendAndReceive(const cricket::VideoCodec& codec) {
1398 EXPECT_TRUE(SetOneCodec(codec));
1399 EXPECT_TRUE(SetSend(true));
1400 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1401 EXPECT_EQ(0, renderer_.num_rendered_frames());
1402 EXPECT_TRUE(SendFrame());
1403 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1404 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1405 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1406 }
1407
1408 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001409 int duration_sec,
1410 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001411 EXPECT_TRUE(SetOneCodec(codec));
1412 EXPECT_TRUE(SetSend(true));
1413 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1414 EXPECT_EQ(0, renderer_.num_rendered_frames());
1415 for (int i = 0; i < duration_sec; ++i) {
1416 for (int frame = 1; frame <= fps; ++frame) {
1417 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1418 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1419 }
1420 }
1421 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1422 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1423 }
1424
Niels Möller6557d0c2018-04-11 15:18:34 +02001425 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1426 cricket::VideoMediaInfo info;
1427 EXPECT_TRUE(channel_->GetStats(&info));
1428 return info.senders[i];
1429 }
1430
1431 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1432 cricket::VideoMediaInfo info;
1433 EXPECT_TRUE(channel_->GetStats(&info));
1434 return info.receivers[i];
1435 }
1436
1437 // Two streams one channel tests.
1438
1439 // Tests that we can send and receive frames.
1440 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1441 SetUpSecondStream();
1442 // Test sending and receiving on first stream.
1443 SendAndReceive(codec);
1444 // Test sending and receiving on second stream.
1445 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1446 EXPECT_GT(NumRtpPackets(), 0);
1447 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1448 }
1449
1450 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1451 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001452 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001453 return engine_codec;
1454 }
1455 // This point should never be reached.
1456 ADD_FAILURE() << "Unrecognized codec name: " << name;
1457 return cricket::VideoCodec();
1458 }
1459
1460 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1461
1462 cricket::StreamParams DefaultSendStreamParams() {
1463 return cricket::StreamParams::CreateLegacy(kSsrc);
1464 }
1465
1466 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001467 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001468 WebRtcVideoEngine engine_;
1469 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_;
1470 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> video_capturer_2_;
1471 std::unique_ptr<WebRtcVideoChannel> channel_;
1472 cricket::FakeNetworkInterface network_interface_;
1473 cricket::FakeVideoRenderer renderer_;
1474
1475 // Used by test cases where 2 streams are run on the same channel.
1476 cricket::FakeVideoRenderer renderer2_;
1477};
1478
1479// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001480TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001481 EXPECT_FALSE(channel_->sending());
Yves Gerey665174f2018-06-19 15:03:05 +02001482 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001483 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1484 EXPECT_FALSE(channel_->sending());
1485 EXPECT_TRUE(SetSend(true));
1486 EXPECT_TRUE(channel_->sending());
1487 EXPECT_TRUE(SendFrame());
1488 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1489 EXPECT_TRUE(SetSend(false));
1490 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001491}
Niels Möller6557d0c2018-04-11 15:18:34 +02001492
1493// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001494TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001495 EXPECT_FALSE(channel_->sending());
1496 EXPECT_FALSE(SetSend(true));
1497 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001498}
Niels Möller6557d0c2018-04-11 15:18:34 +02001499
1500// Test that we properly set the send and recv buffer sizes by the time
1501// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001502TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001503 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1504 EXPECT_TRUE(SetSend(true));
1505 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001506 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001507}
1508
Niels Möller6557d0c2018-04-11 15:18:34 +02001509// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001510TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001511 const int kDurationSec = 3;
1512 const int kFps = 10;
1513 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1514
1515 cricket::VideoMediaInfo info;
1516 EXPECT_TRUE(channel_->GetStats(&info));
1517
1518 ASSERT_EQ(1U, info.senders.size());
1519 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1520 // For webrtc, bytes_sent does not include the RTP header length.
1521 EXPECT_GT(info.senders[0].bytes_sent, 0);
1522 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1523 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1524 ASSERT_TRUE(info.senders[0].codec_payload_type);
1525 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1526 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1527 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1528 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1529 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1530 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1531 EXPECT_GT(info.senders[0].framerate_input, 0);
1532 EXPECT_GT(info.senders[0].framerate_sent, 0);
1533
1534 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1535 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1536 info.send_codecs[DefaultCodec().id]);
1537
1538 ASSERT_EQ(1U, info.receivers.size());
1539 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1540 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1541 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1542 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1543 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1544 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1545 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1546 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1547 EXPECT_EQ(0, info.receivers[0].packets_lost);
1548 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1549 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1550 EXPECT_EQ(0, info.receivers[0].firs_sent);
1551 EXPECT_EQ(0, info.receivers[0].plis_sent);
1552 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1553 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1554 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1555 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1556 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1557 EXPECT_GT(info.receivers[0].framerate_output, 0);
1558
1559 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1560 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1561 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001562}
Niels Möller6557d0c2018-04-11 15:18:34 +02001563
1564// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001565TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001566 cricket::FakeVideoRenderer renderer1, renderer2;
1567 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1568 cricket::VideoSendParameters parameters;
1569 parameters.codecs.push_back(DefaultCodec());
1570 parameters.conference_mode = true;
1571 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1572 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001573 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1574 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001575 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1576 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1577 EXPECT_EQ(0, renderer1.num_rendered_frames());
1578 EXPECT_EQ(0, renderer2.num_rendered_frames());
1579 std::vector<uint32_t> ssrcs;
1580 ssrcs.push_back(1);
1581 ssrcs.push_back(2);
1582 network_interface_.SetConferenceMode(true, ssrcs);
1583 EXPECT_TRUE(SendFrame());
1584 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1585 kTimeout);
1586 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1587 kTimeout);
1588
1589 EXPECT_TRUE(channel_->SetSend(false));
1590
1591 cricket::VideoMediaInfo info;
1592 EXPECT_TRUE(channel_->GetStats(&info));
1593 ASSERT_EQ(1U, info.senders.size());
1594 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1595 // For webrtc, bytes_sent does not include the RTP header length.
1596 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1597 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1598 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1599 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1600
1601 ASSERT_EQ(2U, info.receivers.size());
1602 for (size_t i = 0; i < info.receivers.size(); ++i) {
1603 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1604 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1605 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001606 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001607 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1608 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1609 }
srtee0c2eea2017-12-15 17:44:33 +01001610}
Niels Möller6557d0c2018-04-11 15:18:34 +02001611
1612// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001613TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001614 // Normal setup; note that we set the SSRC explicitly to ensure that
1615 // it will come first in the senders map.
1616 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1617 cricket::VideoSendParameters parameters;
1618 parameters.codecs.push_back(DefaultCodec());
1619 parameters.conference_mode = true;
1620 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001621 EXPECT_TRUE(
1622 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001623 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1624 EXPECT_TRUE(SetSend(true));
1625 EXPECT_TRUE(SendFrame());
1626 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1627 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1628
1629 // Add an additional capturer, and hook up a renderer to receive it.
1630 cricket::FakeVideoRenderer renderer2;
1631 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1632 CreateFakeVideoCapturer());
1633 const int kTestWidth = 160;
1634 const int kTestHeight = 120;
1635 cricket::VideoFormat format(kTestWidth, kTestHeight,
1636 cricket::VideoFormat::FpsToInterval(5),
1637 cricket::FOURCC_I420);
1638 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
Yves Gerey665174f2018-06-19 15:03:05 +02001639 EXPECT_TRUE(
1640 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001641 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, capturer.get()));
Yves Gerey665174f2018-06-19 15:03:05 +02001642 EXPECT_TRUE(
1643 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001644 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
1645 EXPECT_TRUE(capturer->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001646 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1647 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001648
1649 // Get stats, and make sure they are correct for two senders. We wait until
1650 // the number of expected packets have been sent to avoid races where we
1651 // check stats before it has been updated.
1652 cricket::VideoMediaInfo info;
1653 for (uint32_t i = 0; i < kTimeout; ++i) {
1654 rtc::Thread::Current()->ProcessMessages(1);
1655 EXPECT_TRUE(channel_->GetStats(&info));
1656 ASSERT_EQ(2U, info.senders.size());
1657 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1658 NumRtpPackets()) {
1659 // Stats have been updated for both sent frames, expectations can be
1660 // checked now.
1661 break;
1662 }
1663 }
1664 EXPECT_EQ(NumRtpPackets(),
1665 info.senders[0].packets_sent + info.senders[1].packets_sent)
1666 << "Timed out while waiting for packet counts for all sent packets.";
1667 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1668 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1669 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1670 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1671 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1672 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1673 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1674 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1675 // The capturer must be unregistered here as it runs out of it's scope next.
1676 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001677}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001678
Niels Möller6557d0c2018-04-11 15:18:34 +02001679// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001680TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001681 cricket::VideoSendParameters parameters;
1682 parameters.codecs.push_back(DefaultCodec());
1683 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1684 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1685 parameters.max_bandwidth_bps = 128 * 1024;
1686 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001687}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001688
Niels Möller6557d0c2018-04-11 15:18:34 +02001689// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001690TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001691 EXPECT_TRUE(SetDefaultCodec());
1692 EXPECT_TRUE(SetSend(true));
1693 EXPECT_TRUE(SendFrame());
1694 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001695 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001696 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001697 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1698 EXPECT_EQ(kSsrc, header.ssrc);
1699
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 // Packets are being paced out, so these can mismatch between the first and
1701 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001702 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1703 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001704 EXPECT_EQ(1, NumSentSsrcs());
1705 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1706 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001707}
Niels Möller6557d0c2018-04-11 15:18:34 +02001708
1709// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001710TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001711 // Remove stream added in Setup.
1712 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1713 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001714 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001715 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
1716 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001717 EXPECT_TRUE(SetSend(true));
1718 EXPECT_TRUE(WaitAndSendFrame(0));
1719 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001720 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001721 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001722 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1723 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001724 // Packets are being paced out, so these can mismatch between the first and
1725 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001726 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1727 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001728 EXPECT_EQ(1, NumSentSsrcs());
1729 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1730 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001731}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001732
Niels Möller6557d0c2018-04-11 15:18:34 +02001733// Test that we can set the default video renderer before and after
1734// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001735TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001736 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1737 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001738
1739 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1740 rtc::SetBE32(packet1.data() + 8, kSsrc);
1741 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1742 EXPECT_TRUE(SetDefaultCodec());
1743 EXPECT_TRUE(SetSend(true));
1744 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möllere6933812018-11-05 13:01:41 +01001745 channel_->OnPacketReceived(&packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001746 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1747 EXPECT_TRUE(SendFrame());
1748 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001749}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001750
Niels Möller6557d0c2018-04-11 15:18:34 +02001751// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001752TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001753 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1754 EXPECT_TRUE(SetSend(true));
1755 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1756 EXPECT_TRUE(SendFrame());
1757 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1758 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001759 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001760 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001761 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1762 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001763 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1764 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001765
1766 // Remove the send stream that was added during Setup.
1767 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1768 int rtp_packets = NumRtpPackets();
1769
Niels Möller6557d0c2018-04-11 15:18:34 +02001770 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001771 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
1772 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, video_capturer_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001773 EXPECT_EQ(rtp_packets, NumRtpPackets());
1774 // Wait 30ms to guarantee the engine does not drop the frame.
1775 EXPECT_TRUE(WaitAndSendFrame(30));
1776 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1777
1778 last_packet = NumRtpPackets() - 1;
1779 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001780 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1781 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001782}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001783
Niels Möller6557d0c2018-04-11 15:18:34 +02001784// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001785TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 cricket::FakeVideoRenderer renderer1, renderer2;
1787 EXPECT_TRUE(SetDefaultCodec());
1788 cricket::VideoSendParameters parameters;
1789 parameters.codecs.push_back(DefaultCodec());
1790 parameters.conference_mode = true;
1791 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1792 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001793 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1794 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1796 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1797 EXPECT_EQ(0, renderer1.num_rendered_frames());
1798 EXPECT_EQ(0, renderer2.num_rendered_frames());
1799 std::vector<uint32_t> ssrcs;
1800 ssrcs.push_back(1);
1801 ssrcs.push_back(2);
1802 network_interface_.SetConferenceMode(true, ssrcs);
1803 EXPECT_TRUE(SendFrame());
1804 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1805 kTimeout);
1806 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1807 kTimeout);
1808
1809 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1810 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1811 EXPECT_EQ(kVideoWidth, renderer1.width());
1812 EXPECT_EQ(kVideoHeight, renderer1.height());
1813 EXPECT_EQ(kVideoWidth, renderer2.width());
1814 EXPECT_EQ(kVideoHeight, renderer2.height());
1815 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1816 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001817}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001818
Niels Möller6557d0c2018-04-11 15:18:34 +02001819// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001820TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001821 using cricket::VideoCodec;
1822 using cricket::VideoOptions;
1823 using cricket::VideoFormat;
1824 using cricket::FOURCC_I420;
1825
1826 VideoCodec codec = DefaultCodec();
1827 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1828 EXPECT_TRUE(SetOneCodec(codec));
1829 EXPECT_TRUE(SetSend(true));
1830 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1831 EXPECT_EQ(0, renderer_.num_rendered_frames());
1832 EXPECT_TRUE(SendFrame());
1833 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1834 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer(
1835 CreateFakeVideoCapturer());
1836
1837 // TODO(nisse): This testcase fails if we don't configure
1838 // screencast. It's unclear why, I see nothing obvious in this
1839 // test which is related to screencast logic.
1840 VideoOptions video_options;
1841 video_options.is_screencast = true;
1842 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1843
1844 VideoFormat format(480, 360, VideoFormat::FpsToInterval(30), FOURCC_I420);
1845 EXPECT_EQ(cricket::CS_RUNNING, capturer->Start(format));
1846 // All capturers start generating frames with the same timestamp. ViE does
1847 // not allow the same timestamp to be used. Capture one frame before
1848 // associating the capturer with the channel.
1849 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1850
1851 int captured_frames = 1;
1852 for (int iterations = 0; iterations < 2; ++iterations) {
1853 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, capturer.get()));
1854 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
1855 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1856 ++captured_frames;
1857 // Wait until frame of right size is captured.
1858 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001859 format.width == renderer_.width() &&
1860 format.height == renderer_.height() &&
1861 !renderer_.black_frame(),
1862 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001863 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1864 EXPECT_EQ(format.width, renderer_.width());
1865 EXPECT_EQ(format.height, renderer_.height());
1866 captured_frames = renderer_.num_rendered_frames() + 1;
1867 EXPECT_FALSE(renderer_.black_frame());
1868 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1869 // Make sure a black frame is generated within the specified timeout.
1870 // The black frame should be the resolution of the previous frame to
1871 // prevent expensive encoder reconfigurations.
1872 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Yves Gerey665174f2018-06-19 15:03:05 +02001873 format.width == renderer_.width() &&
1874 format.height == renderer_.height() &&
1875 renderer_.black_frame(),
1876 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001877 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
1878 EXPECT_EQ(format.width, renderer_.width());
1879 EXPECT_EQ(format.height, renderer_.height());
1880 EXPECT_TRUE(renderer_.black_frame());
1881
1882 // The black frame has the same timestamp as the next frame since it's
1883 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1884 // not render a frame with the same timestamp so capture another frame
1885 // with the frame capturer to increment the next frame's timestamp.
1886 EXPECT_TRUE(capturer->CaptureCustomFrame(format.width, format.height));
1887 }
srtee0c2eea2017-12-15 17:44:33 +01001888}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001889
Niels Möller6557d0c2018-04-11 15:18:34 +02001890// Tests that if SetVideoSend is called with a NULL capturer after the
1891// capturer was already removed, the application doesn't crash (and no black
1892// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001893TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001894 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1895 EXPECT_TRUE(SetSend(true));
1896 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1897 EXPECT_EQ(0, renderer_.num_rendered_frames());
1898 EXPECT_TRUE(SendFrame());
1899 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1900 // Wait for one frame so they don't get dropped because we send frames too
1901 // tightly.
1902 rtc::Thread::Current()->ProcessMessages(30);
1903 // Remove the capturer.
1904 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1905
1906 // No capturer was added, so this SetVideoSend shouldn't do anything.
1907 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1908 rtc::Thread::Current()->ProcessMessages(300);
1909 // Verify no more frames were sent.
1910 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001911}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001912
Niels Möller6557d0c2018-04-11 15:18:34 +02001913// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001914TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001915 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1916 // interval time to avoid that.
1917 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1918 // interval time to avoid that.
1919 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001920 EXPECT_TRUE(
1921 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001922 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1923 cricket::VideoFormat capture_format(
1924 kVideoWidth, kVideoHeight,
1925 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1926 // Set up additional stream 1.
1927 cricket::FakeVideoRenderer renderer1;
1928 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001929 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001930 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001931 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001932 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer1(
1933 CreateFakeVideoCapturer());
1934 EXPECT_EQ(cricket::CS_RUNNING, capturer1->Start(capture_format));
1935 // Set up additional stream 2.
1936 cricket::FakeVideoRenderer renderer2;
1937 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001938 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001939 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001940 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 std::unique_ptr<cricket::FakeVideoCapturerWithTaskQueue> capturer2(
1942 CreateFakeVideoCapturer());
1943 EXPECT_EQ(cricket::CS_RUNNING, capturer2->Start(capture_format));
1944 // State for all the streams.
1945 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1946 // A limitation in the lmi implementation requires that SetVideoSend() is
1947 // called after SetOneCodec().
1948 // TODO(hellner): this seems like an unnecessary constraint, fix it.
1949 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, capturer1.get()));
1950 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, capturer2.get()));
1951 EXPECT_TRUE(SetSend(true));
1952 // Test capturer associated with engine.
1953 const int kTestWidth = 160;
1954 const int kTestHeight = 120;
1955 EXPECT_TRUE(capturer1->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001956 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1957 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 // Capture a frame with additional capturer2, frames should be received
1959 EXPECT_TRUE(capturer2->CaptureCustomFrame(kTestWidth, kTestHeight));
Yves Gerey665174f2018-06-19 15:03:05 +02001960 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1961 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001962 // Successfully remove the capturer.
1963 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1964 // The capturers must be unregistered here as it runs out of it's scope
1965 // next.
1966 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
1967 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01001968}
Niels Möller6557d0c2018-04-11 15:18:34 +02001969
1970// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01001971TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001972 // Remove the send stream that was added during Setup.
1973 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1974
1975 cricket::StreamParams empty;
1976 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02001977 EXPECT_TRUE(
1978 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01001979}
Niels Möller6557d0c2018-04-11 15:18:34 +02001980
1981// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01001982TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001983 // Remove stream added in Setup. I.e. remove stream corresponding to default
1984 // channel.
1985 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02001986 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02001987 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
1988 EXPECT_TRUE(channel_->AddSendStream(
1989 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
1990 }
1991 // Delete one of the non default channel streams, let the destructor delete
1992 // the remaining ones.
1993 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
1994 // Stream should already be deleted.
1995 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01001996}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00001997
eladalonf1841382017-06-12 01:16:46 -07001998TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08001999 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002000}
2001
eladalonf1841382017-06-12 01:16:46 -07002002TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002003 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002004}
2005
eladalonf1841382017-06-12 01:16:46 -07002006TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002007 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002008}
2009
eladalonf1841382017-06-12 01:16:46 -07002010TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002011 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2012 // bitrates. This currently happens at <250k, and two streams sharing 300k
2013 // initially will use QVGA instead of VGA.
2014 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2015 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002016 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002017 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002018 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002019}
2020
eladalonf1841382017-06-12 01:16:46 -07002021class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002022 public:
eladalonf1841382017-06-12 01:16:46 -07002023 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2024 explicit WebRtcVideoChannelTest(const char* field_trials)
2025 : WebRtcVideoEngineTest(field_trials), last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002026 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002027 encoder_factory_->AddSupportedVideoCodecType("VP8");
2028 encoder_factory_->AddSupportedVideoCodecType("VP9");
2029#if defined(WEBRTC_USE_H264)
2030 encoder_factory_->AddSupportedVideoCodecType("H264");
2031#endif
2032
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002033 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002034 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2035 GetMediaConfig(), VideoOptions(),
2036 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002037 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002038 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002039 send_parameters_.codecs = engine_.codecs();
2040 recv_parameters_.codecs = engine_.codecs();
2041 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002042 }
2043
2044 protected:
2045 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002046 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002047 }
2048
2049 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002050 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002051 EXPECT_TRUE(channel_->AddSendStream(sp));
2052 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002053 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002054 EXPECT_EQ(num_streams + 1, streams.size());
2055 return streams[streams.size() - 1];
2056 }
2057
2058 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002059 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002060 }
2061
2062 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002063 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002064 }
2065
2066 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002067 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002068 EXPECT_TRUE(channel_->AddRecvStream(sp));
2069 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002070 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002071 EXPECT_EQ(num_streams + 1, streams.size());
2072 return streams[streams.size() - 1];
2073 }
2074
pbos@webrtc.org00873182014-11-25 14:03:34 +00002075 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2076 int expected_min_bitrate_bps,
2077 const char* start_bitrate_kbps,
2078 int expected_start_bitrate_bps,
2079 const char* max_bitrate_kbps,
2080 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002081 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2082 expected_start_bitrate_bps,
2083 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002084 auto& codecs = send_parameters_.codecs;
2085 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002086 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002087 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2088 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2089 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002090 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002091 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002092
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002093 void ExpectSetBitrateParameters(int min_bitrate_bps,
2094 int start_bitrate_bps,
2095 int max_bitrate_bps) {
2096 EXPECT_CALL(
2097 *fake_call_->GetMockTransportControllerSend(),
2098 SetSdpBitrateParameters(AllOf(
2099 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2100 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2101 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2102 }
2103
2104 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2105 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2106 SetSdpBitrateParameters(Field(
2107 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002108 }
2109
Johannes Kron9190b822018-10-29 11:22:05 +01002110 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2111 // For a caller, the answer will be applied in set remote description
2112 // where SetSendParameters() is called.
2113 EXPECT_TRUE(
2114 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2115 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2116 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2117 const webrtc::VideoSendStream::Config& config =
2118 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2119 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2120 }
2121
2122 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2123 // For a callee, the answer will be applied in set local description
2124 // where SetExtmapAllowMixed() and AddSendStream() are called.
2125 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2126 EXPECT_TRUE(
2127 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2128 const webrtc::VideoSendStream::Config& config =
2129 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2130 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2131 }
2132
isheriff6f8d6862016-05-26 11:24:55 -07002133 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002134 // Enable extension.
2135 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002136 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002137 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002138 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002139 FakeVideoSendStream* send_stream =
2140 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2141
2142 // Verify the send extension id.
2143 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2144 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002145 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002146 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002147 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002148 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2149 // receivers.
2150 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2151 ->GetConfig()
2152 .rtp.extensions.empty());
2153
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002154 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002155 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002156 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2157 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002158 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2159
2160 // Verify that adding receive RTP header extensions adds them for existing
2161 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002162 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002163 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002164 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2165 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002166 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002167 }
2168
isheriff6f8d6862016-05-26 11:24:55 -07002169 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002170 // Enable extension.
2171 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002172 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002173 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002174 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002175
2176 FakeVideoReceiveStream* recv_stream =
2177 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2178
2179 // Verify the recv extension id.
2180 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2181 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002182 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002183 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002184 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002185
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002186 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2187 // senders.
2188 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2189 ->GetConfig()
2190 .rtp.extensions.empty());
2191
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002192 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002193 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002194 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2195 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002196 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2197
2198 // Verify that adding receive RTP header extensions adds them for existing
2199 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002200 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002201 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002202 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2203 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002204 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002205 }
2206
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002207 void TestExtensionFilter(const std::vector<std::string>& extensions,
2208 const std::string& expected_extension) {
2209 cricket::VideoSendParameters parameters = send_parameters_;
2210 int expected_id = -1;
2211 int id = 1;
2212 for (const std::string& extension : extensions) {
2213 if (extension == expected_extension)
2214 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002215 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002216 }
2217 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2218 FakeVideoSendStream* send_stream =
2219 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2220
2221 // Verify that only one of them has been set, and that it is the one with
2222 // highest priority (transport sequence number).
2223 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2224 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2225 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002226 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002227 }
2228
asapersson3c81a1a2017-06-14 05:52:21 -07002229 void TestDegradationPreference(bool resolution_scaling_enabled,
2230 bool fps_scaling_enabled);
2231
Erik Språngefbde372015-04-29 16:21:28 +02002232 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002233 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002234 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2235 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002236
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002237 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002238 uint32_t ssrc,
Tommi85959932018-02-07 19:26:06 +01002239 FakeVideoCapturerWithTaskQueue* capturer,
nisse0db023a2016-03-01 04:29:59 -08002240 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002241 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002242 options.video_noise_reduction = enabled;
Niels Möllerff40b142018-04-09 08:49:14 +02002243 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, capturer));
nisse0db023a2016-03-01 04:29:59 -08002244 // Options only take effect on the next frame.
2245 EXPECT_TRUE(capturer->CaptureFrame());
2246
Erik Språng143cec12015-04-28 10:01:41 +02002247 return fake_call_->GetVideoSendStreams().back();
2248 }
2249
Peter Boström2feafdb2015-09-09 14:32:14 +02002250 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2251 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002252 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002253 std::vector<uint32_t> ssrcs;
2254 std::vector<uint32_t> rtx_ssrcs;
2255 uint32_t num_streams = enabled ? 3 : 1;
2256 for (uint32_t i = 0; i < num_streams; ++i) {
2257 uint32_t ssrc = last_ssrc_ + i;
2258 ssrcs.push_back(ssrc);
2259 if (with_rtx) {
2260 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2261 }
Erik Språng143cec12015-04-28 10:01:41 +02002262 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002263 if (with_rtx) {
2264 return AddSendStream(
2265 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2266 }
2267 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002268 }
2269
perkjfa10b552016-10-02 23:45:26 -07002270 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002271 std::vector<FakeVideoSendStream*> streams =
2272 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002273 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002274 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002275 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002276 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002277 }
2278
perkjfa10b552016-10-02 23:45:26 -07002279 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002280 int stream_max,
2281 int expected_encoder_bitrate) {
2282 VideoSendParameters limited_send_params = send_parameters_;
2283 limited_send_params.max_bandwidth_bps = global_max;
2284 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002285 webrtc::RtpParameters parameters =
2286 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002287 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002288 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002289 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002290 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002291 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002292 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002293 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002294 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002295 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002296 }
2297
Åsa Persson55659812018-06-18 17:51:32 +02002298 // Values from kSimulcastConfigs in simulcast.cc.
2299 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2300 std::vector<webrtc::VideoStream> layers(3);
2301 layers[0].min_bitrate_bps = 30000;
2302 layers[0].target_bitrate_bps = 150000;
2303 layers[0].max_bitrate_bps = 200000;
2304 layers[1].min_bitrate_bps = 150000;
2305 layers[1].target_bitrate_bps = 500000;
2306 layers[1].max_bitrate_bps = 700000;
2307 layers[2].min_bitrate_bps = 600000;
2308 layers[2].target_bitrate_bps = 2500000;
2309 layers[2].max_bitrate_bps = 2500000;
2310 return layers;
2311 }
2312
kwiberg686a8ef2016-02-26 03:00:35 -08002313 std::unique_ptr<FakeCall> fake_call_;
2314 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002315 cricket::VideoSendParameters send_parameters_;
2316 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002317 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002318};
2319
eladalonf1841382017-06-12 01:16:46 -07002320TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002321 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002322 const std::string kSyncLabel = "AvSyncLabel";
2323
2324 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002325 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002326 EXPECT_TRUE(channel_->AddRecvStream(sp));
2327
Mirko Bonadeif859e552018-05-30 15:31:29 +02002328 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002329 EXPECT_EQ(kSyncLabel,
2330 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2331 << "SyncGroup should be set based on sync_label";
2332}
2333
eladalonf1841382017-06-12 01:16:46 -07002334TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002335 cricket::VideoSendParameters parameters;
2336 parameters.codecs = engine_.codecs();
2337 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002338 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002339 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002340 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002341
2342 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002343 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2344 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002345 FakeVideoSendStream* send_stream = AddSendStream(
2346 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2347
2348 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2349 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2350 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2351
2352 // Receiver side.
2353 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2354 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002355 EXPECT_FALSE(
2356 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002357 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002358 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002359 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002360 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002361 << "RTX should be mapped for the RED payload type";
2362
brandtr14742122017-01-27 04:53:07 -08002363 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002364}
2365
eladalonf1841382017-06-12 01:16:46 -07002366TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002367 // Setup one channel with an associated RTX stream.
2368 cricket::StreamParams params =
2369 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2370 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2371 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002372 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002373
2374 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2375 << "RTX should be mapped for all decoders/payload types.";
2376 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002377 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002378 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002379}
2380
eladalonf1841382017-06-12 01:16:46 -07002381TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002382 // Setup one channel without an associated RTX stream.
2383 cricket::StreamParams params =
2384 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2385 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002386 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002387}
2388
Johannes Kron9190b822018-10-29 11:22:05 +01002389// Test propagation of extmap allow mixed setting.
2390TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2391 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2392}
2393TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2394 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2395}
2396TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2397 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2398}
2399TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2400 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2401}
2402
eladalonf1841382017-06-12 01:16:46 -07002403TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002404 FakeVideoSendStream* send_stream =
2405 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2406 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2407
2408 FakeVideoReceiveStream* recv_stream =
2409 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2410 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002411}
2412
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002413// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002414TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002415 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002416}
isheriff6f8d6862016-05-26 11:24:55 -07002417
eladalonf1841382017-06-12 01:16:46 -07002418TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002419 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002420}
2421
2422// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002423TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002424 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002425}
isheriff6f8d6862016-05-26 11:24:55 -07002426
eladalonf1841382017-06-12 01:16:46 -07002427TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002428 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002429}
2430
eladalonf1841382017-06-12 01:16:46 -07002431TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002432 // Enable three redundant extensions.
2433 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002434 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2435 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2436 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2437 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002438}
2439
eladalonf1841382017-06-12 01:16:46 -07002440TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002441 // Enable two redundant extensions.
2442 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002443 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2444 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2445 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002446}
2447
stefanc1aeaf02015-10-15 07:26:07 -07002448// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002449TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002450 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002451}
eladalonf1841382017-06-12 01:16:46 -07002452TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002453 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002454}
2455
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002456// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002457TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002458 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002459}
eladalonf1841382017-06-12 01:16:46 -07002460TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002461 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002462}
2463
eladalonf1841382017-06-12 01:16:46 -07002464TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002465 const int kAbsSendTimeId = 1;
2466 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002467 send_parameters_.extensions.push_back(
2468 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2469 send_parameters_.extensions.push_back(
2470 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002471
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002472 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002473 FakeVideoSendStream* send_stream =
2474 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2475
2476 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002477 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002478
2479 // Setting the same extensions (even if in different order) shouldn't
2480 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002481 std::reverse(send_parameters_.extensions.begin(),
2482 send_parameters_.extensions.end());
2483 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002484
2485 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2486
2487 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002488 send_parameters_.extensions.resize(1);
2489 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002490
2491 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2492}
2493
eladalonf1841382017-06-12 01:16:46 -07002494TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002495 const int kTOffsetId = 1;
2496 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002497 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002498 recv_parameters_.extensions.push_back(
2499 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2500 recv_parameters_.extensions.push_back(
2501 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2502 recv_parameters_.extensions.push_back(
2503 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002504
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002505 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002506 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002507 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2508
2509 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002510 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002511
2512 // Setting the same extensions (even if in different order) shouldn't
2513 // reallocate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002514 std::reverse(recv_parameters_.extensions.begin(),
2515 recv_parameters_.extensions.end());
2516 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002517
2518 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2519
2520 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002521 recv_parameters_.extensions.resize(1);
2522 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002523
2524 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2525}
2526
eladalonf1841382017-06-12 01:16:46 -07002527TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002528 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002529 const int kUnsupportedId = 1;
2530 const int kTOffsetId = 2;
2531
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002532 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002533 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002534 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002535 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002536 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002537 FakeVideoSendStream* send_stream =
2538 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2539
2540 // Only timestamp offset extension is set to send stream,
2541 // unsupported rtp extension is ignored.
2542 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002543 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2544 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002545}
2546
eladalonf1841382017-06-12 01:16:46 -07002547TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002548 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002549 const int kUnsupportedId = 1;
2550 const int kTOffsetId = 2;
2551
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002552 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002553 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002554 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002555 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002556 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002557 FakeVideoReceiveStream* recv_stream =
2558 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2559
2560 // Only timestamp offset extension is set to receive stream,
2561 // unsupported rtp extension is ignored.
2562 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002563 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2564 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002565}
2566
eladalonf1841382017-06-12 01:16:46 -07002567TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002568 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002569 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002570 send_parameters_.extensions.push_back(
2571 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002572 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002573 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2574 }
2575}
2576
eladalonf1841382017-06-12 01:16:46 -07002577TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002578 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002579 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002580 recv_parameters_.extensions.push_back(
2581 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002582 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002583 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2584 }
2585}
2586
eladalonf1841382017-06-12 01:16:46 -07002587TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002588 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002589 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002590 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002591 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002592 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002593 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002594
2595 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002596 send_parameters_.extensions.clear();
2597 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002598 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002599 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2600 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002601}
2602
eladalonf1841382017-06-12 01:16:46 -07002603TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002604 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002605 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002606 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002607 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002608 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002609 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002610
2611 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002612 recv_parameters_.extensions.clear();
2613 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002614 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002615 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2616 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002617}
2618
eladalonf1841382017-06-12 01:16:46 -07002619TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002620 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002621 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002622}
2623
eladalonf1841382017-06-12 01:16:46 -07002624TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002625 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002626 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002627}
2628
eladalonf1841382017-06-12 01:16:46 -07002629TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002630 FakeVideoReceiveStream* stream = AddRecvStream();
2631 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002632}
2633
eladalonf1841382017-06-12 01:16:46 -07002634TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002635 FakeVideoReceiveStream* stream = AddRecvStream();
2636 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2637}
2638
eladalonf1841382017-06-12 01:16:46 -07002639TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002640 FakeVideoReceiveStream* stream = AddRecvStream();
2641 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2642
Peter Boström126c03e2015-05-11 12:48:12 +02002643 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002644 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002645 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002646 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2647 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002648 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002649 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2650
2651 // Verify that REMB is turned on when setting default codecs since the
2652 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002653 parameters.codecs = engine_.codecs();
2654 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002655 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002656 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002657}
2658
eladalonf1841382017-06-12 01:16:46 -07002659TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002660 FakeVideoReceiveStream* stream = AddRecvStream();
2661 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2662
2663 // Verify that transport cc feedback is turned off when send(!) codecs without
2664 // transport cc feedback are set.
2665 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002666 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002667 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2668 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2669 stream = fake_call_->GetVideoReceiveStreams()[0];
2670 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2671
2672 // Verify that transport cc feedback is turned on when setting default codecs
2673 // since the default codecs have transport cc feedback enabled.
2674 parameters.codecs = engine_.codecs();
2675 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2676 stream = fake_call_->GetVideoReceiveStreams()[0];
2677 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2678}
2679
eladalonf1841382017-06-12 01:16:46 -07002680TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002681 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002682 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2683
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002684 cricket::VideoSendParameters parameters;
2685 parameters.codecs = engine_.codecs();
2686 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002687 EXPECT_TRUE(channel_->SetSend(true));
2688
2689 // Send side.
2690 FakeVideoSendStream* send_stream =
2691 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2692 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2693
2694 // Receiver side.
2695 FakeVideoReceiveStream* recv_stream =
2696 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2697 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2698
2699 // Nack history size should match between sender and receiver.
2700 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2701 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002702}
2703
eladalonf1841382017-06-12 01:16:46 -07002704TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002705 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002706 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002707
2708 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2709 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2710
2711 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002712 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002713 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002714 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2715 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002716 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2717 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2718 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002719 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2720
Peter Boström67c9df72015-05-11 14:34:58 +02002721 // Verify that NACK is turned on when setting default codecs since the
2722 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002723 parameters.codecs = engine_.codecs();
2724 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002725 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2726 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2727 send_stream = fake_call_->GetVideoSendStreams()[0];
2728 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002729}
2730
Peter Boströme7ba0862016-03-12 00:02:28 +01002731// This test verifies that new frame sizes reconfigures encoders even though not
2732// (yet) sending. The purpose of this is to permit encoding as quickly as
2733// possible once we start sending. Likely the frames being input are from the
2734// same source that will be sent later, which just means that we're ready
2735// earlier.
eladalonf1841382017-06-12 01:16:46 -07002736TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002737 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002738 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002739 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2740 channel_->SetSend(false);
2741
2742 FakeVideoSendStream* stream = AddSendStream();
2743
perkjfa10b552016-10-02 23:45:26 -07002744 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002745 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002746 EXPECT_EQ(0u, streams[0].width);
2747 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002748
Tommi85959932018-02-07 19:26:06 +01002749 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002750 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj26752742016-10-24 01:21:16 -07002751 VideoFormat capture_format = capturer.GetSupportedFormats()->front();
2752 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
Peter Boströme7ba0862016-03-12 00:02:28 +01002753 EXPECT_TRUE(capturer.CaptureFrame());
2754
2755 // Frame entered, should be reconfigured to new dimensions.
2756 streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002757 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.width), streams[0].width);
2758 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format.height),
2759 streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002760
Niels Möllerff40b142018-04-09 08:49:14 +02002761 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002762}
2763
eladalonf1841382017-06-12 01:16:46 -07002764TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002765 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002766 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002767 cricket::VideoSendParameters parameters;
2768 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002769 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002770 AddSendStream();
2771
Tommi85959932018-02-07 19:26:06 +01002772 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07002773 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002774 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Yves Gerey665174f2018-06-19 15:03:05 +02002775 EXPECT_TRUE(
2776 channel_->SetVideoSend(last_ssrc_, &min_bitrate_options, &capturer));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002777 cricket::VideoFormat capture_format_hd =
2778 capturer.GetSupportedFormats()->front();
2779 EXPECT_EQ(1280, capture_format_hd.width);
2780 EXPECT_EQ(720, capture_format_hd.height);
2781 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2782
2783 EXPECT_TRUE(channel_->SetSend(true));
2784
2785 EXPECT_TRUE(capturer.CaptureFrame());
2786 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2787 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2788
2789 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2790
2791 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002792 webrtc::VideoEncoderConfig encoder_config =
2793 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002794 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002795 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002796 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002797 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2798 streams.front().width);
2799 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2800 streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002801 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2802 << "Non-screenshare shouldn't use min-transmit bitrate.";
2803
Niels Möllerff40b142018-04-09 08:49:14 +02002804 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002805 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002806 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002807 screencast_options.is_screencast = true;
deadbeef5a4a75a2016-06-02 16:23:38 -07002808 EXPECT_TRUE(
Niels Möllerff40b142018-04-09 08:49:14 +02002809 channel_->SetVideoSend(last_ssrc_, &screencast_options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08002810 EXPECT_TRUE(capturer.CaptureFrame());
sprangf24a0642017-02-28 13:23:26 -08002811 // Send stream recreated after option change.
2812 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2813 send_stream = fake_call_->GetVideoSendStreams().front();
2814 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002815
2816 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002817 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002818 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002819 encoder_config.content_type);
2820 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2821 encoder_config.min_transmit_bitrate_bps);
2822
perkjfa10b552016-10-02 23:45:26 -07002823 streams = send_stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002824 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.width),
2825 streams.front().width);
2826 EXPECT_EQ(rtc::checked_cast<size_t>(capture_format_hd.height),
2827 streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002828 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002829 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002830}
2831
eladalonf1841382017-06-12 01:16:46 -07002832TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002833 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002834 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002835 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002836 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002837
2838 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002839 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002840 options.is_screencast = true;
Tommi85959932018-02-07 19:26:06 +01002841 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02002842 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002843 cricket::VideoFormat capture_format_hd =
2844 capturer.GetSupportedFormats()->front();
2845 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
2846
2847 EXPECT_TRUE(channel_->SetSend(true));
2848
2849 EXPECT_TRUE(capturer.CaptureFrame());
2850 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2851 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2852
perkj26091b12016-09-01 01:17:40 -07002853 webrtc::VideoEncoderConfig encoder_config =
2854 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002855
2856 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002857 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002858 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002859 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002860
2861 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2862 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002863 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002864 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002865 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002866
Niels Möllerff40b142018-04-09 08:49:14 +02002867 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002868}
2869
eladalonf1841382017-06-12 01:16:46 -07002870TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002871 FakeVideoSendStream* stream = AddSendStream();
2872 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2873}
2874
eladalonf1841382017-06-12 01:16:46 -07002875TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002876 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002877 media_config.video.suspend_below_min_bitrate = true;
2878
Sebastian Jansson84848f22018-11-16 10:40:36 +01002879 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002880 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002881 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002882
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002883 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002884
2885 FakeVideoSendStream* stream = AddSendStream();
2886 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2887
nisse0db023a2016-03-01 04:29:59 -08002888 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002889 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002890 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002891 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002892
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002893 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002894
nisse0db023a2016-03-01 04:29:59 -08002895 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002896 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2897}
2898
eladalonf1841382017-06-12 01:16:46 -07002899TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002900 FakeVideoSendStream* stream = AddSendStream();
2901 webrtc::VideoCodecVP8 vp8_settings;
2902 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2903 EXPECT_TRUE(vp8_settings.denoisingOn);
2904}
2905
eladalonf1841382017-06-12 01:16:46 -07002906TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002907 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002908 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002909 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002910
Peter Boström2feafdb2015-09-09 14:32:14 +02002911 // Single-stream settings should apply with RTX as well (verifies that we
2912 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2913 // both RTX and regular SSRCs).
2914 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002915
Tommi85959932018-02-07 19:26:06 +01002916 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02002917 EXPECT_EQ(cricket::CS_RUNNING,
2918 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02002919 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002920 channel_->SetSend(true);
2921
2922 EXPECT_TRUE(capturer.CaptureFrame());
2923
pbos4cba4eb2015-10-26 11:18:18 -07002924 webrtc::VideoCodecVP8 vp8_settings;
2925 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2926 EXPECT_TRUE(vp8_settings.denoisingOn)
2927 << "VP8 denoising should be on by default.";
2928
nisse05103312016-03-16 02:22:50 -07002929 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002930
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002931 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2932 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002933 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2934 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002935
nisse05103312016-03-16 02:22:50 -07002936 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002937
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002938 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2939 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002940 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2941 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2942
Niels Möllerff40b142018-04-09 08:49:14 +02002943 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002944 stream = SetUpSimulcast(true, false);
Niels Möllerff40b142018-04-09 08:49:14 +02002945 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02002946 channel_->SetSend(true);
2947 EXPECT_TRUE(capturer.CaptureFrame());
2948
Mirko Bonadeif859e552018-05-30 15:31:29 +02002949 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002950 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2951 // Autmatic resize off when using simulcast.
2952 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2953 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2954
2955 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002956 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002957 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02002958 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
Niels Möller60653ba2016-03-02 11:41:36 +01002959
nisse05103312016-03-16 02:22:50 -07002960 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02002961
Mirko Bonadeif859e552018-05-30 15:31:29 +02002962 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002963 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2964 EXPECT_FALSE(vp8_settings.denoisingOn);
2965 // Resizing and frame dropping always off for screen sharing.
2966 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2967 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2968
nisse05103312016-03-16 02:22:50 -07002969 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02002970
2971 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2972 EXPECT_FALSE(vp8_settings.denoisingOn);
2973 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2974 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2975
Niels Möllerff40b142018-04-09 08:49:14 +02002976 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02002977}
2978
deadbeef119760a2016-04-04 11:43:27 -07002979// Test that setting the same options doesn't result in the encoder being
2980// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07002981TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07002982 VideoOptions options;
Tommi85959932018-02-07 19:26:06 +01002983 FakeVideoCapturerWithTaskQueue capturer;
deadbeef119760a2016-04-04 11:43:27 -07002984
perkjfa10b552016-10-02 23:45:26 -07002985 AddSendStream();
deadbeef119760a2016-04-04 11:43:27 -07002986 EXPECT_EQ(cricket::CS_RUNNING,
2987 capturer.Start(capturer.GetSupportedFormats()->front()));
perkjfa10b552016-10-02 23:45:26 -07002988 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002989 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07002990 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2991 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2992
Niels Möllerff40b142018-04-09 08:49:14 +02002993 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
2994 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07002995 EXPECT_TRUE(capturer.CaptureFrame());
perkjfa10b552016-10-02 23:45:26 -07002996 // Expect 1 reconfigurations at this point from the initial configuration.
2997 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07002998
2999 // Set the options one more time and expect no additional reconfigurations.
Niels Möllerff40b142018-04-09 08:49:14 +02003000 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkjfa10b552016-10-02 23:45:26 -07003001 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3002
3003 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003004 options.video_noise_reduction = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003005 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
deadbeef119760a2016-04-04 11:43:27 -07003006 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3007
Niels Möllerff40b142018-04-09 08:49:14 +02003008 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003009}
3010
eladalonf1841382017-06-12 01:16:46 -07003011class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003012 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003013 Vp9SettingsTest() : Vp9SettingsTest("") {}
3014 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003015 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003016 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003017 }
3018 virtual ~Vp9SettingsTest() {}
3019
3020 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003021 void TearDown() override {
3022 // Remove references to encoder_factory_ since this will be destroyed
3023 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003024 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003025 }
Erik Språng143cec12015-04-28 10:01:41 +02003026};
3027
3028TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003029 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003030 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003031 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003032
Peter Boström2feafdb2015-09-09 14:32:14 +02003033 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003034
Tommi85959932018-02-07 19:26:06 +01003035 FakeVideoCapturerWithTaskQueue capturer;
Erik Språng143cec12015-04-28 10:01:41 +02003036 EXPECT_EQ(cricket::CS_RUNNING,
3037 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003038 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Erik Språng143cec12015-04-28 10:01:41 +02003039 channel_->SetSend(true);
3040
3041 EXPECT_TRUE(capturer.CaptureFrame());
3042
pbos4cba4eb2015-10-26 11:18:18 -07003043 webrtc::VideoCodecVP9 vp9_settings;
3044 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003045 EXPECT_TRUE(vp9_settings.denoisingOn)
3046 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003047
nisse05103312016-03-16 02:22:50 -07003048 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003049
Erik Språng143cec12015-04-28 10:01:41 +02003050 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3051 EXPECT_FALSE(vp9_settings.denoisingOn);
3052 // Frame dropping always on for real time video.
3053 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3054
nisse05103312016-03-16 02:22:50 -07003055 stream = SetDenoisingOption(last_ssrc_, &capturer, true);
Erik Språng143cec12015-04-28 10:01:41 +02003056
3057 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3058 EXPECT_TRUE(vp9_settings.denoisingOn);
3059 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3060
3061 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003062 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003063 options.is_screencast = true;
Niels Möllerff40b142018-04-09 08:49:14 +02003064 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003065
nisse05103312016-03-16 02:22:50 -07003066 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003067
3068 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3069 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003070 // Frame dropping always on for screen sharing.
3071 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003072
nisse05103312016-03-16 02:22:50 -07003073 stream = SetDenoisingOption(last_ssrc_, &capturer, false);
Erik Språng143cec12015-04-28 10:01:41 +02003074
3075 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3076 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003077 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003078
Niels Möllerff40b142018-04-09 08:49:14 +02003079 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003080}
3081
Sergey Silkinf18072e2018-03-14 10:35:35 +01003082TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3083 cricket::VideoSendParameters parameters;
3084 parameters.codecs.push_back(GetEngineCodec("VP9"));
3085 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3086
3087 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3088
3089 FakeVideoSendStream* stream =
3090 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3091
3092 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3093 EXPECT_EQ(ssrcs.size(), config.rtp.ssrcs.size());
3094
3095 FakeVideoCapturerWithTaskQueue capturer;
3096 EXPECT_EQ(cricket::CS_RUNNING,
3097 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003098 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &capturer));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003099 channel_->SetSend(true);
3100
3101 EXPECT_TRUE(capturer.CaptureFrame());
3102
3103 webrtc::VideoCodecVP9 vp9_settings;
3104 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3105
3106 const size_t kNumSpatialLayers = ssrcs.size();
3107 const size_t kNumTemporalLayers = 3;
3108 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3109 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3110
Niels Möllerff40b142018-04-09 08:49:14 +02003111 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003112}
3113
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003114TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3115 cricket::VideoSendParameters send_parameters;
3116 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3117 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3118
3119 const size_t kNumSpatialLayers = 3;
3120 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3121
3122 FakeVideoSendStream* stream =
3123 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3124
3125 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3126 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3127 ASSERT_TRUE(parameters.encodings[0].active);
3128 ASSERT_TRUE(parameters.encodings[1].active);
3129 ASSERT_TRUE(parameters.encodings[2].active);
3130 // Invert value to verify copying.
3131 parameters.encodings[1].active = false;
3132 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3133
3134 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3135
3136 // number_of_streams should be 1 since all spatial layers are sent on the
3137 // same SSRC. But encoding parameters of all layers is supposed to be copied
3138 // and stored in simulcast_layers[].
3139 EXPECT_EQ(1u, encoder_config.number_of_streams);
3140 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3141 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3142 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3143 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3144}
3145
asaperssonc5dabdd2016-03-21 04:15:50 -07003146class Vp9SettingsTestWithFieldTrial : public Vp9SettingsTest {
3147 public:
brandtr468da7c2016-11-22 02:16:47 -08003148 explicit Vp9SettingsTestWithFieldTrial(const char* field_trials)
asaperssonc5dabdd2016-03-21 04:15:50 -07003149 : Vp9SettingsTest(field_trials) {}
3150
3151 protected:
3152 void VerifySettings(int num_spatial_layers, int num_temporal_layers) {
3153 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003154 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003155 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3156
3157 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3158
Tommi85959932018-02-07 19:26:06 +01003159 FakeVideoCapturerWithTaskQueue capturer;
asaperssonc5dabdd2016-03-21 04:15:50 -07003160 EXPECT_EQ(cricket::CS_RUNNING,
3161 capturer.Start(capturer.GetSupportedFormats()->front()));
Niels Möllerff40b142018-04-09 08:49:14 +02003162 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
asaperssonc5dabdd2016-03-21 04:15:50 -07003163 channel_->SetSend(true);
3164
3165 EXPECT_TRUE(capturer.CaptureFrame());
3166
3167 webrtc::VideoCodecVP9 vp9_settings;
3168 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3169 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3170 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
3171
Niels Möllerff40b142018-04-09 08:49:14 +02003172 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003173 }
3174};
3175
3176class Vp9SettingsTestWithNoFlag : public Vp9SettingsTestWithFieldTrial {
3177 public:
3178 Vp9SettingsTestWithNoFlag() : Vp9SettingsTestWithFieldTrial("") {}
3179};
3180
3181TEST_F(Vp9SettingsTestWithNoFlag, VerifySettings) {
3182 const int kNumSpatialLayers = 1;
3183 const int kNumTemporalLayers = 1;
3184 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3185}
3186
3187class Vp9SettingsTestWithInvalidFlag : public Vp9SettingsTestWithFieldTrial {
3188 public:
3189 Vp9SettingsTestWithInvalidFlag()
3190 : Vp9SettingsTestWithFieldTrial("WebRTC-SupportVP9SVC/Default/") {}
3191};
3192
3193TEST_F(Vp9SettingsTestWithInvalidFlag, VerifySettings) {
3194 const int kNumSpatialLayers = 1;
3195 const int kNumTemporalLayers = 1;
3196 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3197}
3198
3199class Vp9SettingsTestWith2SL3TLFlag : public Vp9SettingsTestWithFieldTrial {
3200 public:
3201 Vp9SettingsTestWith2SL3TLFlag()
3202 : Vp9SettingsTestWithFieldTrial(
3203 "WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/") {}
3204};
3205
3206TEST_F(Vp9SettingsTestWith2SL3TLFlag, VerifySettings) {
3207 const int kNumSpatialLayers = 2;
3208 const int kNumTemporalLayers = 3;
3209 VerifySettings(kNumSpatialLayers, kNumTemporalLayers);
3210}
3211
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003212TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3213 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3214 ASSERT_EQ(1u, streams.size());
3215 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3216}
3217
3218TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3219 webrtc::test::ScopedFieldTrials override_field_trials_(
3220 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3221 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3222 ASSERT_EQ(1u, streams.size());
3223 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3224}
3225
asapersson3c81a1a2017-06-14 05:52:21 -07003226TEST_F(WebRtcVideoChannelTest,
3227 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3228 webrtc::test::ScopedFieldTrials override_field_trials_(
3229 "WebRTC-Video-BalancedDegradation/Disabled/");
3230 const bool kResolutionScalingEnabled = true;
3231 const bool kFpsScalingEnabled = false;
3232 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3233}
3234
3235TEST_F(WebRtcVideoChannelTest,
3236 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3237 webrtc::test::ScopedFieldTrials override_field_trials_(
3238 "WebRTC-Video-BalancedDegradation/Enabled/");
3239 const bool kResolutionScalingEnabled = true;
3240 const bool kFpsScalingEnabled = true;
3241 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3242}
3243
eladalonf1841382017-06-12 01:16:46 -07003244TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003245 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003246}
3247
eladalonf1841382017-06-12 01:16:46 -07003248TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003249 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003250}
3251
eladalonf1841382017-06-12 01:16:46 -07003252TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003253 TestCpuAdaptation(true, true);
3254}
3255
eladalonf1841382017-06-12 01:16:46 -07003256TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruseAndChangeResolution) {
magjed509e4fe2016-11-18 01:34:11 -08003257 cricket::VideoCodec codec = GetEngineCodec("VP8");
perkj2d5f0912016-02-29 00:04:41 -08003258 cricket::VideoSendParameters parameters;
3259 parameters.codecs.push_back(codec);
3260
kthelgason2bc68642017-02-07 07:02:22 -08003261 MediaConfig media_config = GetMediaConfig();
Sebastian Jansson84848f22018-11-16 10:40:36 +01003262 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003263 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003264 channel_->OnReadyToSend(true);
perkj2d5f0912016-02-29 00:04:41 -08003265 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3266
3267 AddSendStream();
3268
Tommi85959932018-02-07 19:26:06 +01003269 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02003270 ASSERT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
perkj2d5f0912016-02-29 00:04:41 -08003271 ASSERT_EQ(cricket::CS_RUNNING,
3272 capturer.Start(capturer.GetSupportedFormats()->front()));
3273 ASSERT_TRUE(channel_->SetSend(true));
3274
3275 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3276 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003277
Niels Möllera6cc0f92018-02-12 17:14:55 +01003278 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003279 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3280 EXPECT_EQ(1280, send_stream->GetLastWidth());
3281 EXPECT_EQ(720, send_stream->GetLastHeight());
3282
3283 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003284 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003285 wants.max_pixel_count =
3286 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003287 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003288 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003289 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3290 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3291 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3292
3293 // Trigger overuse again.
sprangc5d62e22017-04-02 23:53:04 -07003294 wants.max_pixel_count =
3295 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003296 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003297 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
perkj2d5f0912016-02-29 00:04:41 -08003298 EXPECT_EQ(3, send_stream->GetNumberOfSwappedFrames());
3299 EXPECT_EQ(1280 * 2 / 4, send_stream->GetLastWidth());
3300 EXPECT_EQ(720 * 2 / 4, send_stream->GetLastHeight());
3301
3302 // Change input resolution.
Niels Möllera6cc0f92018-02-12 17:14:55 +01003303 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003304 EXPECT_EQ(4, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003305 EXPECT_EQ(1284 / 2, send_stream->GetLastWidth());
3306 EXPECT_EQ(724 / 2, send_stream->GetLastHeight());
3307
3308 // Trigger underuse which should go back up in resolution.
sprang84a37592017-02-10 07:04:27 -08003309 int current_pixel_count =
3310 send_stream->GetLastWidth() * send_stream->GetLastHeight();
3311 // Cap the max to 4x the pixel count (assuming max 1/2 x 1/2 scale downs)
3312 // of the current stream, so we don't take too large steps.
sprangc5d62e22017-04-02 23:53:04 -07003313 wants.max_pixel_count = current_pixel_count * 4;
sprang84a37592017-02-10 07:04:27 -08003314 // Default step down is 3/5 pixel count, so go up by 5/3.
Oskar Sundbom78807582017-11-16 11:09:55 +01003315 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003316 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003317 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003318 EXPECT_EQ(5, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003319 EXPECT_EQ(1284 * 3 / 4, send_stream->GetLastWidth());
3320 EXPECT_EQ(724 * 3 / 4, send_stream->GetLastHeight());
3321
sprang84a37592017-02-10 07:04:27 -08003322 // Trigger underuse again, should go back up to full resolution.
3323 current_pixel_count =
3324 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003325 wants.max_pixel_count = current_pixel_count * 4;
Oskar Sundbom78807582017-11-16 11:09:55 +01003326 wants.target_pixel_count = (current_pixel_count * 5 / 3);
perkj803d97f2016-11-01 11:45:46 -07003327 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003328 EXPECT_TRUE(capturer.CaptureCustomFrame(1284, 724));
perkj803d97f2016-11-01 11:45:46 -07003329 EXPECT_EQ(6, send_stream->GetNumberOfSwappedFrames());
perkj2d5f0912016-02-29 00:04:41 -08003330 EXPECT_EQ(1284, send_stream->GetLastWidth());
3331 EXPECT_EQ(724, send_stream->GetLastHeight());
3332
Niels Möllerff40b142018-04-09 08:49:14 +02003333 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003334}
3335
eladalonf1841382017-06-12 01:16:46 -07003336TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003337 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003338 cricket::VideoSendParameters parameters;
3339 parameters.codecs.push_back(codec);
3340
kthelgason2bc68642017-02-07 07:02:22 -08003341 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003342 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003343 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003344 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003345 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003346 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3347
3348 AddSendStream();
3349
Tommi85959932018-02-07 19:26:06 +01003350 FakeVideoCapturerWithTaskQueue capturer;
Per766ad3b2016-04-05 15:23:49 +02003351 ASSERT_EQ(cricket::CS_RUNNING,
3352 capturer.Start(capturer.GetSupportedFormats()->front()));
3353 ASSERT_TRUE(channel_->SetSend(true));
3354 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003355 camera_options.is_screencast = false;
Yves Gerey665174f2018-06-19 15:03:05 +02003356 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
Per766ad3b2016-04-05 15:23:49 +02003357
3358 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3359 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003360
Niels Möllera6cc0f92018-02-12 17:14:55 +01003361 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003362 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3363 EXPECT_EQ(1280, send_stream->GetLastWidth());
3364 EXPECT_EQ(720, send_stream->GetLastHeight());
3365
3366 // Trigger overuse.
perkj803d97f2016-11-01 11:45:46 -07003367 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003368 wants.max_pixel_count =
3369 send_stream->GetLastWidth() * send_stream->GetLastHeight() - 1;
perkj803d97f2016-11-01 11:45:46 -07003370 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003371 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
Per766ad3b2016-04-05 15:23:49 +02003372 EXPECT_EQ(2, send_stream->GetNumberOfSwappedFrames());
3373 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3374 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3375
3376 // Switch to screen share. Expect no CPU adaptation.
Tommi85959932018-02-07 19:26:06 +01003377 FakeVideoCapturerWithTaskQueue screen_share(true);
Per766ad3b2016-04-05 15:23:49 +02003378 ASSERT_EQ(cricket::CS_RUNNING,
3379 screen_share.Start(screen_share.GetSupportedFormats()->front()));
Per766ad3b2016-04-05 15:23:49 +02003380 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003381 screenshare_options.is_screencast = true;
Yves Gerey665174f2018-06-19 15:03:05 +02003382 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &screen_share);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003383 EXPECT_TRUE(screen_share.CaptureCustomFrame(1284, 724));
sprangf24a0642017-02-28 13:23:26 -08003384 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3385 send_stream = fake_call_->GetVideoSendStreams().front();
3386 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003387 EXPECT_EQ(1284, send_stream->GetLastWidth());
3388 EXPECT_EQ(724, send_stream->GetLastHeight());
3389
3390 // Switch back to the normal capturer. Expect the frame to be CPU adapted.
Yves Gerey665174f2018-06-19 15:03:05 +02003391 channel_->SetVideoSend(last_ssrc_, &camera_options, &capturer);
sprangf24a0642017-02-28 13:23:26 -08003392 send_stream = fake_call_->GetVideoSendStreams().front();
3393 // We have a new fake send stream, so it doesn't remember the old sink wants.
3394 // In practice, it will be populated from
mflodmancc3d4422017-08-03 08:27:51 -07003395 // VideoStreamEncoder::VideoSourceProxy::SetSource(), so simulate that here.
sprangf24a0642017-02-28 13:23:26 -08003396 send_stream->InjectVideoSinkWants(wants);
Niels Möllera6cc0f92018-02-12 17:14:55 +01003397 EXPECT_TRUE(capturer.CaptureCustomFrame(1280, 720));
sprangf24a0642017-02-28 13:23:26 -08003398 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3399 send_stream = fake_call_->GetVideoSendStreams().front();
3400 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
Per766ad3b2016-04-05 15:23:49 +02003401 EXPECT_EQ(1280 * 3 / 4, send_stream->GetLastWidth());
3402 EXPECT_EQ(720 * 3 / 4, send_stream->GetLastHeight());
3403
Niels Möllerff40b142018-04-09 08:49:14 +02003404 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003405}
3406
asapersson3c81a1a2017-06-14 05:52:21 -07003407// TODO(asapersson): Remove this test when the balanced field trial is removed.
3408void WebRtcVideoChannelTest::TestDegradationPreference(
3409 bool resolution_scaling_enabled,
3410 bool fps_scaling_enabled) {
3411 cricket::VideoCodec codec = GetEngineCodec("VP8");
3412 cricket::VideoSendParameters parameters;
3413 parameters.codecs.push_back(codec);
3414
3415 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003416 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003417 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003418 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003419 channel_->OnReadyToSend(true);
3420
3421 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3422
3423 AddSendStream();
3424
Tommi85959932018-02-07 19:26:06 +01003425 FakeVideoCapturerWithTaskQueue capturer;
asapersson3c81a1a2017-06-14 05:52:21 -07003426 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02003427 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
asapersson3c81a1a2017-06-14 05:52:21 -07003428 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
3429 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
3430
3431 EXPECT_TRUE(channel_->SetSend(true));
3432
3433 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3434 EXPECT_EQ(resolution_scaling_enabled,
3435 send_stream->resolution_scaling_enabled());
3436 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3437
Niels Möllerff40b142018-04-09 08:49:14 +02003438 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003439}
3440
eladalonf1841382017-06-12 01:16:46 -07003441void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3442 bool is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003443 const int kDefaultFps = 30;
magjed509e4fe2016-11-18 01:34:11 -08003444 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003445 cricket::VideoSendParameters parameters;
3446 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003447
kthelgason2bc68642017-02-07 07:02:22 -08003448 MediaConfig media_config = GetMediaConfig();
3449 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003450 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003451 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003452 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003453 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003454 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003455
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003456 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003457
3458 AddSendStream();
3459
Tommi85959932018-02-07 19:26:06 +01003460 FakeVideoCapturerWithTaskQueue capturer;
nisse05103312016-03-16 02:22:50 -07003461 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003462 options.is_screencast = is_screenshare;
Niels Möllerff40b142018-04-09 08:49:14 +02003463 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
perkj26752742016-10-24 01:21:16 -07003464 cricket::VideoFormat capture_format = capturer.GetSupportedFormats()->front();
sprangc5d62e22017-04-02 23:53:04 -07003465 capture_format.interval = rtc::kNumNanosecsPerSec / kDefaultFps;
perkj26752742016-10-24 01:21:16 -07003466 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003467
3468 EXPECT_TRUE(channel_->SetSend(true));
3469
solenberge5269742015-09-08 05:13:22 -07003470 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003471
sprangc5d62e22017-04-02 23:53:04 -07003472 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003473 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003474 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3475 EXPECT_EQ(is_screenshare, send_stream->framerate_scaling_enabled());
perkj2d5f0912016-02-29 00:04:41 -08003476
3477 EXPECT_TRUE(capturer.CaptureFrame());
3478 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3479
perkj26752742016-10-24 01:21:16 -07003480 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3481 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
perkj2d5f0912016-02-29 00:04:41 -08003482
Niels Möllerff40b142018-04-09 08:49:14 +02003483 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkj2d5f0912016-02-29 00:04:41 -08003484 return;
3485 }
3486
sprangc5d62e22017-04-02 23:53:04 -07003487 if (is_screenshare) {
3488 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3489 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3490 } else {
3491 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3492 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3493 }
3494
perkj803d97f2016-11-01 11:45:46 -07003495 // Trigger overuse.
3496 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3497
3498 rtc::VideoSinkWants wants;
sprangc5d62e22017-04-02 23:53:04 -07003499 if (is_screenshare) {
3500 wants.max_framerate_fps = (kDefaultFps * 2) / 3;
3501 } else {
3502 wants.max_pixel_count = capture_format.width * capture_format.height - 1;
3503 }
perkj803d97f2016-11-01 11:45:46 -07003504 send_stream->InjectVideoSinkWants(wants);
3505
sprangc5d62e22017-04-02 23:53:04 -07003506 for (int i = 0; i < kDefaultFps; ++i)
3507 EXPECT_TRUE(capturer.CaptureFrame());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003508
sprangc5d62e22017-04-02 23:53:04 -07003509 if (is_screenshare) {
3510 // Drops every third frame.
3511 EXPECT_EQ(kDefaultFps * 2 / 3, send_stream->GetNumberOfSwappedFrames());
3512 EXPECT_EQ(send_stream->GetLastWidth(), capture_format.width);
3513 EXPECT_EQ(send_stream->GetLastHeight(), capture_format.height);
3514 } else {
3515 EXPECT_EQ(kDefaultFps, send_stream->GetNumberOfSwappedFrames());
3516 EXPECT_LT(send_stream->GetLastWidth(), capture_format.width);
3517 EXPECT_LT(send_stream->GetLastHeight(), capture_format.height);
3518 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003519
3520 // Trigger underuse which should go back to normal resolution.
sprang84a37592017-02-10 07:04:27 -08003521 int last_pixel_count =
3522 send_stream->GetLastWidth() * send_stream->GetLastHeight();
sprangc5d62e22017-04-02 23:53:04 -07003523 if (is_screenshare) {
3524 wants.max_framerate_fps = kDefaultFps;
3525 } else {
3526 wants.max_pixel_count = last_pixel_count * 4;
3527 wants.target_pixel_count.emplace((last_pixel_count * 5) / 3);
3528 }
perkj803d97f2016-11-01 11:45:46 -07003529 send_stream->InjectVideoSinkWants(wants);
3530
sprangc5d62e22017-04-02 23:53:04 -07003531 for (int i = 0; i < kDefaultFps; ++i)
3532 EXPECT_TRUE(capturer.CaptureFrame());
3533
3534 if (is_screenshare) {
3535 EXPECT_EQ(kDefaultFps + (kDefaultFps * 2 / 3),
3536 send_stream->GetNumberOfSwappedFrames());
3537 } else {
3538 EXPECT_EQ(kDefaultFps * 2, send_stream->GetNumberOfSwappedFrames());
3539 }
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003540
perkj26752742016-10-24 01:21:16 -07003541 EXPECT_EQ(capture_format.width, send_stream->GetLastWidth());
3542 EXPECT_EQ(capture_format.height, send_stream->GetLastHeight());
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003543
Niels Möllerff40b142018-04-09 08:49:14 +02003544 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003545}
3546
eladalonf1841382017-06-12 01:16:46 -07003547TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003548 // Start at last timestamp to verify that wraparounds are estimated correctly.
3549 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3550 static const int64_t kInitialNtpTimeMs = 1247891230;
3551 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003552 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003553
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003554 FakeVideoReceiveStream* stream = AddRecvStream();
3555 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003556 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003557
nisse64ec8f82016-09-27 00:17:25 -07003558 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4),
3559 kInitialTimestamp, 0,
3560 webrtc::kVideoRotation_0);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003561 // Initial NTP time is not available on the first frame, but should still be
3562 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003563 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003564
3565 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003566
3567 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3568 // triggers a constant-overflow warning, hence we're calculating it explicitly
3569 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003570 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003571 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3572 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003573 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003574
3575 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003576
3577 // Verify that NTP time has been correctly deduced.
3578 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003579 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003580 ASSERT_EQ(1u, info.receivers.size());
3581 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003582}
3583
eladalonf1841382017-06-12 01:16:46 -07003584TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003585 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003586 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003587
3588 VideoCodec codec;
3589 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003590 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003591
3592 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003593 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3594 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003595 FakeVideoSendStream* stream = AddSendStream(
3596 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003597 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003598
3599 // Make sure NACK and FEC are enabled on the correct payload types.
3600 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003601 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3602 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003603
3604 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3605 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003606 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003607 // TODO(juberti): Check RTCP, PLI, TMMBR.
3608}
3609
brandtr31bd2242017-05-19 05:47:46 -07003610// The following four tests ensures that FlexFEC is not activated by default
3611// when the field trials are not enabled.
3612// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3613// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003614TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003615 FakeVideoSendStream* stream = AddSendStream();
3616 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3617
brandtr3d200bd2017-01-16 06:59:19 -08003618 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003619 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3620 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003621}
3622
eladalonf1841382017-06-12 01:16:46 -07003623TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003624 FakeVideoSendStream* stream = AddSendStream(
3625 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3626 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3627
brandtr3d200bd2017-01-16 06:59:19 -08003628 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003629 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3630 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3631}
3632
Yves Gerey665174f2018-06-19 15:03:05 +02003633TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003634 AddRecvStream();
3635
3636 const std::vector<FakeFlexfecReceiveStream*>& streams =
3637 fake_call_->GetFlexfecReceiveStreams();
3638 EXPECT_TRUE(streams.empty());
3639}
3640
eladalonf1841382017-06-12 01:16:46 -07003641TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003642 AddRecvStream(
3643 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3644
3645 const std::vector<FakeFlexfecReceiveStream*>& streams =
3646 fake_call_->GetFlexfecReceiveStreams();
3647 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003648}
3649
3650// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3651// tests that use this test fixture into the corresponding "non-field trial"
3652// tests.
eladalonf1841382017-06-12 01:16:46 -07003653class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003654 public:
eladalonf1841382017-06-12 01:16:46 -07003655 WebRtcVideoChannelFlexfecRecvTest()
3656 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003657};
3658
eladalonf1841382017-06-12 01:16:46 -07003659TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003660 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3661 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3662 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3663}
3664
eladalonf1841382017-06-12 01:16:46 -07003665TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003666 AddRecvStream();
3667
3668 const std::vector<FakeFlexfecReceiveStream*>& streams =
3669 fake_call_->GetFlexfecReceiveStreams();
3670 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003671
3672 const std::vector<FakeVideoReceiveStream*>& video_streams =
3673 fake_call_->GetVideoReceiveStreams();
3674 ASSERT_EQ(1U, video_streams.size());
3675 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3676 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3677 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003678}
3679
eladalonf1841382017-06-12 01:16:46 -07003680TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003681 AddRecvStream(
3682 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3683
3684 const std::vector<FakeFlexfecReceiveStream*>& streams =
3685 fake_call_->GetFlexfecReceiveStreams();
3686 ASSERT_EQ(1U, streams.size());
3687 const FakeFlexfecReceiveStream* stream = streams.front();
3688 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3689 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3690 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3691 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3692 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003693
3694 const std::vector<FakeVideoReceiveStream*>& video_streams =
3695 fake_call_->GetVideoReceiveStreams();
3696 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003697 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3698 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003699 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003700 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003701 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003702}
3703
eladalonf1841382017-06-12 01:16:46 -07003704TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003705 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3706 cricket::VideoRecvParameters recv_parameters;
3707 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3708 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3709
3710 AddRecvStream(
3711 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3712 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003713 const std::vector<FakeVideoReceiveStream*>& video_streams =
3714 fake_call_->GetVideoReceiveStreams();
3715 ASSERT_EQ(1U, video_streams.size());
3716 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3717 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3718 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003719
3720 // Enable FlexFEC.
3721 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3722 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3723 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3724 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3725 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3726 << "Enabling FlexFEC should not create VideoReceiveStream.";
3727 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3728 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003729 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3730 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003731}
3732
eladalonf1841382017-06-12 01:16:46 -07003733TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003734 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3735 cricket::VideoRecvParameters recv_parameters;
3736 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3737 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3738 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3739
3740 AddRecvStream(
3741 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3742 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003743 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003744 const std::vector<FakeVideoReceiveStream*>& video_streams =
3745 fake_call_->GetVideoReceiveStreams();
3746 ASSERT_EQ(1U, video_streams.size());
3747 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3748 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3749 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003750
3751 // Disable FlexFEC.
3752 recv_parameters.codecs.clear();
3753 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3754 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3755 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3756 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3757 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3758 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3759 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3760 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003761 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3762 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003763}
3764
brandtr31bd2242017-05-19 05:47:46 -07003765// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3766// tests that use this test fixture into the corresponding "non-field trial"
3767// tests.
eladalonf1841382017-06-12 01:16:46 -07003768class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003769 public:
eladalonf1841382017-06-12 01:16:46 -07003770 WebRtcVideoChannelFlexfecSendRecvTest()
3771 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003772 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3773 }
3774};
3775
Yves Gerey665174f2018-06-19 15:03:05 +02003776TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003777 FakeVideoSendStream* stream = AddSendStream();
3778 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3779
brandtr3d200bd2017-01-16 06:59:19 -08003780 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3781 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3782 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003783}
3784
eladalonf1841382017-06-12 01:16:46 -07003785TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003786 FakeVideoSendStream* stream = AddSendStream(
3787 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3788 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3789
brandtr3d200bd2017-01-16 06:59:19 -08003790 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3791 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3792 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3793 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003794}
3795
eladalonf1841382017-06-12 01:16:46 -07003796TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003797 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003798 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003799 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003800
3801 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003802 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003803
brandtrb5f2c3f2016-10-04 23:28:39 -07003804 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3805 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003806}
3807
eladalonf1841382017-06-12 01:16:46 -07003808TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003809 cricket::VideoSendParameters parameters;
3810 parameters.codecs.push_back(GetEngineCodec("VP8"));
3811 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3812
3813 FakeVideoSendStream* stream = AddSendStream();
3814 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3815
brandtr3d200bd2017-01-16 06:59:19 -08003816 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003817}
3818
eladalonf1841382017-06-12 01:16:46 -07003819TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003820 AddRecvStream(
3821 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003822
3823 cricket::VideoRecvParameters recv_parameters;
3824 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3825 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3826 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003827
3828 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3829 fake_call_->GetFlexfecReceiveStreams();
3830 ASSERT_EQ(1U, flexfec_streams.size());
3831 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3832 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3833 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003834 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003835 flexfec_stream_config.payload_type);
3836 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3837 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3838 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3839 const std::vector<FakeVideoReceiveStream*>& video_streams =
3840 fake_call_->GetVideoReceiveStreams();
3841 const FakeVideoReceiveStream* video_stream = video_streams.front();
3842 const webrtc::VideoReceiveStream::Config& video_stream_config =
3843 video_stream->GetConfig();
3844 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3845 flexfec_stream_config.local_ssrc);
3846 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3847 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3848 flexfec_stream_config.rtcp_send_transport);
3849 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3850 // spec-compliant way.
3851 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3852 flexfec_stream_config.transport_cc);
3853 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3854 EXPECT_EQ(video_stream_config.rtp.extensions,
3855 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003856}
3857
brandtr31bd2242017-05-19 05:47:46 -07003858// We should not send FlexFEC, even if we advertise it, unless the right
3859// field trial is set.
3860// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003861TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003862 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3863 cricket::VideoSendParameters parameters;
3864 parameters.codecs.push_back(GetEngineCodec("VP8"));
3865 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3866 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3867
3868 FakeVideoSendStream* stream = AddSendStream();
3869 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3870
3871 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003872 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003873 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3874}
3875
eladalonf1841382017-06-12 01:16:46 -07003876TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003877 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3878 cricket::VideoSendParameters parameters;
3879 parameters.codecs.push_back(GetEngineCodec("VP8"));
3880 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3881 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3882
3883 FakeVideoSendStream* stream = AddSendStream(
3884 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3885 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3886
3887 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003888 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003889 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3890}
3891
eladalonf1841382017-06-12 01:16:46 -07003892TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003893 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003894 const int kUnusedPayloadType = 127;
3895 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3896
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003897 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003898 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003899 parameters.codecs.push_back(rtx_codec);
3900 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003901 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003902}
3903
eladalonf1841382017-06-12 01:16:46 -07003904TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003905 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003906 const int kUnusedPayloadType1 = 126;
3907 const int kUnusedPayloadType2 = 127;
3908 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3909 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3910 {
3911 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3912 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3913 cricket::VideoSendParameters parameters;
3914 parameters.codecs.push_back(GetEngineCodec("VP8"));
3915 parameters.codecs.push_back(rtx_codec);
3916 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3917 }
3918 {
3919 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3920 kUnusedPayloadType1, kUnusedPayloadType2);
3921 cricket::VideoSendParameters parameters;
3922 parameters.codecs.push_back(GetEngineCodec("VP8"));
3923 parameters.codecs.push_back(rtx_codec);
3924 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3925 << "RTX without matching video codec should be rejected.";
3926 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003927}
3928
eladalonf1841382017-06-12 01:16:46 -07003929TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003930 const int kUnusedPayloadType1 = 126;
3931 const int kUnusedPayloadType2 = 127;
3932 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3933 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3934
3935 // SSRCs for RTX.
3936 cricket::StreamParams params =
3937 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3938 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3939 AddSendStream(params);
3940
3941 // Original payload type for RTX.
3942 cricket::VideoSendParameters parameters;
3943 parameters.codecs.push_back(GetEngineCodec("VP8"));
3944 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3945 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3946 parameters.codecs.push_back(rtx_codec);
3947 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3948 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3949 const webrtc::VideoSendStream::Config& config_before =
3950 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3951 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3952 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3953 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3954
3955 // Change payload type for RTX.
3956 parameters.codecs[1].id = kUnusedPayloadType2;
3957 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3958 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3959 const webrtc::VideoSendStream::Config& config_after =
3960 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3961 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3962 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3963 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3964}
3965
eladalonf1841382017-06-12 01:16:46 -07003966TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003967 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003968 parameters.codecs.push_back(GetEngineCodec("VP8"));
3969 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003970 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003971
3972 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003973 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003974
magjed509e4fe2016-11-18 01:34:11 -08003975 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003976
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003977 parameters.codecs.pop_back();
3978 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003979 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003980 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003981 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003982 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003983 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3984}
3985
eladalonf1841382017-06-12 01:16:46 -07003986TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003987 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003988 cricket::VideoSendParameters parameters;
3989 parameters.codecs.push_back(GetEngineCodec("VP8"));
3990 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3991 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3992
3993 FakeVideoSendStream* stream = AddSendStream(
3994 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3995 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3996
brandtr3d200bd2017-01-16 06:59:19 -08003997 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3998 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003999 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4000 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4001
4002 parameters.codecs.pop_back();
4003 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4004 stream = fake_call_->GetVideoSendStreams()[0];
4005 ASSERT_TRUE(stream != nullptr);
4006 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004007 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004008 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004009}
4010
eladalonf1841382017-06-12 01:16:46 -07004011TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004012 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004013 cricket::VideoCodec codec(100, "VP8");
4014 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4015 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004016
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004017 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004018 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004019
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004020 FakeVideoSendStream* stream = AddSendStream();
Tommi85959932018-02-07 19:26:06 +01004021 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004022 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004023
4024 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004025 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004026
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004027 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004028 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4029 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004030 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004031 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004032 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004033 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004034}
4035
eladalonf1841382017-06-12 01:16:46 -07004036TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004037 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4038 200000);
4039}
4040
eladalonf1841382017-06-12 01:16:46 -07004041TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004042 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4043 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4044 ASSERT_EQ(1u, streams.size());
4045 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4046}
4047
eladalonf1841382017-06-12 01:16:46 -07004048TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004049 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004050 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004051}
4052
eladalonf1841382017-06-12 01:16:46 -07004053TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004054 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004055}
4056
eladalonf1841382017-06-12 01:16:46 -07004057TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004058 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4059 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4060 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004061}
4062
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004063// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4064// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004065TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004066 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4067 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4068 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4069 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004070 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004071 ExpectSetBitrateParameters(100000, 200000, 400000);
4072 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4073 // Since the codec isn't changing, start_bitrate_bps should be -1.
4074 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004075
4076 // Decrease max_bandwidth_bps.
4077 send_parameters_.max_bandwidth_bps = 350000;
4078 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004079
4080 // Now try again with the values flipped around.
4081 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4082 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004083 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004084 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004085
4086 // If we change the codec max, max_bandwidth_bps should still apply.
4087 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004088 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004089 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004090}
4091
Yves Gerey665174f2018-06-19 15:03:05 +02004092TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004093 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4094 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004095 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004096 // Setting max bitrate should keep previous min bitrate.
4097 // Setting max bitrate should not reset start bitrate.
4098 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004099 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004100}
4101
eladalonf1841382017-06-12 01:16:46 -07004102TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004103 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004104 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004105 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004106 // -1 means to disable max bitrate (set infinite).
4107 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004108 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004109 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004110}
4111
eladalonf1841382017-06-12 01:16:46 -07004112TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004113 send_parameters_.max_bandwidth_bps = 99999;
4114 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004115 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004116 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004117 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4118 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4119 stream->GetVideoStreams()[0].max_bitrate_bps);
4120
4121 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004122 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004123 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4124 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004125 stream->GetVideoStreams()[0].max_bitrate_bps);
4126}
4127
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004128// Tests that when the codec specific max bitrate and VideoSendParameters
4129// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4130// appropriately.
4131TEST_F(WebRtcVideoChannelTest,
4132 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4133 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4134 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4135 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4136 send_parameters_.max_bandwidth_bps = -1;
4137 AddSendStream();
4138 ExpectSetMaxBitrate(300000);
4139 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4140
4141 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4142 ASSERT_EQ(1u, video_send_streams.size());
4143 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4144 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4145 // First the max bitrate is set based upon the codec param.
4146 EXPECT_EQ(300000,
4147 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4148
4149 // The VideoSendParameters max bitrate overrides the codec's.
4150 send_parameters_.max_bandwidth_bps = 500000;
4151 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4152 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4153 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4154 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4155}
4156
4157// Tests that when the codec specific max bitrate and RtpParameters
4158// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4159// appropriately.
4160TEST_F(WebRtcVideoChannelTest,
4161 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4162 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4163 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4164 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4165 send_parameters_.max_bandwidth_bps = -1;
4166 AddSendStream();
4167 ExpectSetMaxBitrate(300000);
4168 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4169
4170 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4171 ASSERT_EQ(1u, video_send_streams.size());
4172 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4173 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4174 // First the max bitrate is set based upon the codec param.
4175 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4176
4177 // The RtpParameter max bitrate overrides the codec's.
4178 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4179 ASSERT_EQ(1u, parameters.encodings.size());
4180 parameters.encodings[0].max_bitrate_bps = 500000;
4181 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4182 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4183 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4184 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4185}
4186
Åsa Persson55659812018-06-18 17:51:32 +02004187TEST_F(WebRtcVideoChannelTest,
4188 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4189 send_parameters_.max_bandwidth_bps = 99999;
4190 FakeVideoSendStream* stream = AddSendStream();
4191 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4192 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4193 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4194 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4195 stream->GetVideoStreams()[0].max_bitrate_bps);
4196
4197 // Get and set the rtp encoding parameters.
4198 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4199 EXPECT_EQ(1u, parameters.encodings.size());
4200
4201 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4202 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4203 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4204 stream->GetVideoStreams()[0].max_bitrate_bps);
4205
4206 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4207 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4208 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4209 stream->GetVideoStreams()[0].max_bitrate_bps);
4210}
4211
eladalonf1841382017-06-12 01:16:46 -07004212TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004213 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004214 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004215 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004216 channel_->SetSend(true);
4217
4218 FakeVideoSendStream* stream = AddSendStream();
4219
Tommi85959932018-02-07 19:26:06 +01004220 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004221 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
Peter Boström3afc8c42016-01-27 16:45:21 +01004222 EXPECT_EQ(cricket::CS_RUNNING,
4223 capturer.Start(capturer.GetSupportedFormats()->front()));
4224
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004225 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4226 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4227 EXPECT_GT(initial_max_bitrate_bps, 0);
4228
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004229 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4230 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004231 // Insert a frame to update the encoder config.
4232 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004233 streams = stream->GetVideoStreams();
4234 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004235 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004236}
4237
eladalonf1841382017-06-12 01:16:46 -07004238TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004239 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004240 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004241 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004242 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004243 channel_->SetSend(true);
4244
4245 FakeVideoSendStream* stream = AddSendStream(
4246 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4247
4248 // Send a frame to make sure this scales up to >1 stream (simulcast).
Tommi85959932018-02-07 19:26:06 +01004249 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02004250 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &capturer));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004251 EXPECT_EQ(cricket::CS_RUNNING,
4252 capturer.Start(capturer.GetSupportedFormats()->front()));
4253 EXPECT_TRUE(capturer.CaptureFrame());
4254
4255 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4256 ASSERT_GT(streams.size(), 1u)
4257 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004258 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004259 EXPECT_GT(initial_max_bitrate_bps, 0);
4260
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004261 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4262 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004263 // Insert a frame to update the encoder config.
4264 EXPECT_TRUE(capturer.CaptureFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004265 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004266 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004267 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4268
Niels Möllerff40b142018-04-09 08:49:14 +02004269 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004270}
4271
eladalonf1841382017-06-12 01:16:46 -07004272TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004273 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004274 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004275 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004276 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4277 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004278 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004279 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004280
4281 VideoCodec codec;
4282 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4283 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4284}
4285
eladalonf1841382017-06-12 01:16:46 -07004286TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004287 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004288 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004289 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004290 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004291 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004292 parameters.codecs[0].id = kIncorrectPayloads[i];
4293 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004294 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004295 }
4296}
4297
eladalonf1841382017-06-12 01:16:46 -07004298TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004299 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004300 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004301 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004302 parameters.codecs[0].id = payload_type;
4303 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004304 << "Payload type '" << payload_type << "' rejected.";
4305 }
4306}
4307
deadbeef67cf2c12016-04-13 10:07:16 -07004308// Test that setting the a different set of codecs but with an identical front
4309// codec doesn't result in the stream being recreated.
4310// This may happen when a subsequent negotiation includes fewer codecs, as a
4311// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004312TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004313 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4314 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004315 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4316 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004317 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4318
4319 AddSendStream();
4320 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4321
4322 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004323 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004324 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4325 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4326}
4327
eladalonf1841382017-06-12 01:16:46 -07004328TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004329 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004330 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004331 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004332}
4333
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004334// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004335TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004336 const int kUnusedPayloadType1 = 126;
4337 const int kUnusedPayloadType2 = 127;
4338 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4339 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4340
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004341 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004342 parameters.codecs.push_back(GetEngineCodec("VP8"));
4343 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004344 parameters.codecs.push_back(rtx_codec);
4345 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004346 << "RTX codec without associated payload should be rejected.";
4347
magjed509e4fe2016-11-18 01:34:11 -08004348 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004349 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004350 << "RTX codec with invalid associated payload type should be rejected.";
4351
magjed509e4fe2016-11-18 01:34:11 -08004352 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004353 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004354
magjed509e4fe2016-11-18 01:34:11 -08004355 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004356 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004357 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004358
Yves Gerey665174f2018-06-19 15:03:05 +02004359 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4360 << "RTX codec with another RTX as associated payload type should be "
4361 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004362}
4363
eladalonf1841382017-06-12 01:16:46 -07004364TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004365 const int kUnusedPayloadType1 = 126;
4366 const int kUnusedPayloadType2 = 127;
4367 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4368 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4369
4370 // SSRCs for RTX.
4371 cricket::StreamParams params =
4372 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4373 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4374 AddRecvStream(params);
4375
4376 // Original payload type for RTX.
4377 cricket::VideoRecvParameters parameters;
4378 parameters.codecs.push_back(GetEngineCodec("VP8"));
4379 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4380 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4381 parameters.codecs.push_back(rtx_codec);
4382 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4383 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4384 const webrtc::VideoReceiveStream::Config& config_before =
4385 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004386 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4387 const int* payload_type_before = FindKeyByValue(
4388 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4389 ASSERT_NE(payload_type_before, nullptr);
4390 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004391 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4392
4393 // Change payload type for RTX.
4394 parameters.codecs[1].id = kUnusedPayloadType2;
4395 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4396 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4397 const webrtc::VideoReceiveStream::Config& config_after =
4398 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004399 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4400 const int* payload_type_after = FindKeyByValue(
4401 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4402 ASSERT_NE(payload_type_after, nullptr);
4403 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004404 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4405}
4406
eladalonf1841382017-06-12 01:16:46 -07004407TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004408 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004409 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004410 parameters.codecs[0].id = 99;
4411 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004412}
4413
eladalonf1841382017-06-12 01:16:46 -07004414TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004415 cricket::VideoRecvParameters parameters;
4416 parameters.codecs = engine_.codecs();
4417 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004418
4419 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004420 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004421 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004422 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004423}
4424
eladalonf1841382017-06-12 01:16:46 -07004425TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004426 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004427 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004428 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004429 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004430}
4431
eladalonf1841382017-06-12 01:16:46 -07004432TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004433 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004434 parameters.codecs.push_back(GetEngineCodec("VP8"));
4435 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004436 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004437}
4438
eladalonf1841382017-06-12 01:16:46 -07004439TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004440 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004441 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4442 send_parameters.codecs.push_back(GetEngineCodec("red"));
4443 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004444 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004445
4446 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004447
magjed509e4fe2016-11-18 01:34:11 -08004448 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004449 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004450
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004451 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004452 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004453 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004454 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004455 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004456 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004457 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4458}
4459
eladalonf1841382017-06-12 01:16:46 -07004460TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004461 AddRecvStream(
4462 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004463 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004464 fake_call_->GetFlexfecReceiveStreams();
4465
4466 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004467 const FakeFlexfecReceiveStream* stream = streams.front();
4468 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4469 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4470 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4471 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004472
4473 cricket::VideoRecvParameters recv_parameters;
4474 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4475 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4476 EXPECT_TRUE(streams.empty())
4477 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004478}
4479
eladalonf1841382017-06-12 01:16:46 -07004480TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004481 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004482 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004483 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004484
4485 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004486 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4487 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4488 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004489 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4490 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004491 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004492 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004493 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004494 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004495
4496 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004497 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4498 send_parameters.codecs.push_back(GetEngineCodec("red"));
4499 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004500 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4501 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004502 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004503 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004504 << "ULPFEC should be enabled on the receive stream.";
4505}
4506
eladalonf1841382017-06-12 01:16:46 -07004507TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004508 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004509 AddRecvStream(
4510 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004511 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004512 fake_call_->GetFlexfecReceiveStreams();
4513
4514 cricket::VideoRecvParameters recv_parameters;
4515 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4516 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4517 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4518 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004519 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004520 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004521 stream_with_recv_params->GetConfig().payload_type);
4522 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004523 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004524 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004525 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004526 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004527
4528 cricket::VideoSendParameters send_parameters;
4529 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4530 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4531 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4532 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004533 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004534 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004535 stream_with_send_params->GetConfig().payload_type);
4536 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004537 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004538 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004539 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004540 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004541}
4542
eladalonf1841382017-06-12 01:16:46 -07004543TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004544 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004545 parameters.codecs.push_back(GetEngineCodec("VP8"));
4546 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004547 parameters.codecs[1].id = parameters.codecs[0].id;
4548 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004549}
4550
eladalonf1841382017-06-12 01:16:46 -07004551TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004552 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004553 cricket::VideoRecvParameters parameters;
4554 parameters.codecs.push_back(GetEngineCodec("VP8"));
4555 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4556 parameters.codecs[1].id = parameters.codecs[0].id;
4557 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4558}
4559
eladalonf1841382017-06-12 01:16:46 -07004560TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004561 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004562 parameters.codecs.push_back(GetEngineCodec("VP8"));
4563 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004564 parameters.codecs[1].id = parameters.codecs[0].id;
4565 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004566}
4567
eladalonf1841382017-06-12 01:16:46 -07004568TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004569 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004570 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004571 parameters.codecs.push_back(GetEngineCodec("VP8"));
4572 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004573 parameters.codecs[1].id += 1;
4574 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004575}
4576
deadbeef67cf2c12016-04-13 10:07:16 -07004577// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004578// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004579TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004580 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004581 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004582 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4583 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004584 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004585
4586 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4587 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4588
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004589 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004590 parameters2.codecs.push_back(GetEngineCodec("red"));
4591 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004592 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004593 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4594}
4595
eladalonf1841382017-06-12 01:16:46 -07004596TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004597 EXPECT_FALSE(AddSendStream()->IsSending());
4598}
4599
eladalonf1841382017-06-12 01:16:46 -07004600TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004601 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004602}
4603
eladalonf1841382017-06-12 01:16:46 -07004604TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004605 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004606 EXPECT_FALSE(stream->IsSending());
4607
4608 // false->true
4609 EXPECT_TRUE(channel_->SetSend(true));
4610 EXPECT_TRUE(stream->IsSending());
4611 // true->true
4612 EXPECT_TRUE(channel_->SetSend(true));
4613 EXPECT_TRUE(stream->IsSending());
4614 // true->false
4615 EXPECT_TRUE(channel_->SetSend(false));
4616 EXPECT_FALSE(stream->IsSending());
4617 // false->false
4618 EXPECT_TRUE(channel_->SetSend(false));
4619 EXPECT_FALSE(stream->IsSending());
4620
4621 EXPECT_TRUE(channel_->SetSend(true));
4622 FakeVideoSendStream* new_stream = AddSendStream();
4623 EXPECT_TRUE(new_stream->IsSending())
4624 << "Send stream created after SetSend(true) not sending initially.";
4625}
4626
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004627// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004628TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004629 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004630 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004631 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004632 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004633 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004634
Sebastian Jansson84848f22018-11-16 10:40:36 +01004635 channel.reset(
4636 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4637 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004638 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004639 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004640 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004641
Tim Haloun648d28a2018-10-18 16:52:22 -07004642 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4643 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004644 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004645 channel.reset(
4646 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4647 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004648 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004649 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4650
4651 // Create a send stream to configure
4652 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4653 parameters = channel->GetRtpSendParameters(kSsrc);
4654 ASSERT_FALSE(parameters.encodings.empty());
4655
4656 // Various priorities map to various dscp values.
4657 parameters.encodings[0].network_priority = 4.0;
4658 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004659 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004660 parameters.encodings[0].network_priority = 0.5;
4661 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4662 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4663
4664 // A bad priority does not change the dscp value.
4665 parameters.encodings[0].network_priority = 0.0;
4666 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4667 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004668
Tim Haloun6ca98362018-09-17 17:06:08 -07004669 // Packets should also self-identify their dscp in PacketOptions.
4670 const uint8_t kData[10] = {0};
4671 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4672 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004673 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004674
nisse51542be2016-02-12 02:27:06 -08004675 // Verify that setting the option to false resets the
4676 // DiffServCodePoint.
4677 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004678 channel.reset(
4679 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4680 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004681 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004682 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004683}
4684
deadbeef13871492015-12-09 12:37:51 -08004685// This test verifies that the RTCP reduced size mode is properly applied to
4686// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004687TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004688 // Create stream, expecting that default mode is "compound".
4689 FakeVideoSendStream* stream1 = AddSendStream();
4690 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004691 webrtc::RtpParameters rtp_parameters =
4692 channel_->GetRtpSendParameters(last_ssrc_);
4693 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004694
4695 // Now enable reduced size mode.
4696 send_parameters_.rtcp.reduced_size = true;
4697 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4698 stream1 = fake_call_->GetVideoSendStreams()[0];
4699 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004700 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4701 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004702
4703 // Create a new stream and ensure it picks up the reduced size mode.
4704 FakeVideoSendStream* stream2 = AddSendStream();
4705 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4706}
4707
4708// This test verifies that the RTCP reduced size mode is properly applied to
4709// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004710TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004711 // Create stream, expecting that default mode is "compound".
4712 FakeVideoReceiveStream* stream1 = AddRecvStream();
4713 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4714
4715 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004716 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4717 // the reduced_size flag should come from that.
4718 send_parameters_.rtcp.reduced_size = true;
4719 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004720 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4721 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4722
4723 // Create a new stream and ensure it picks up the reduced size mode.
4724 FakeVideoReceiveStream* stream2 = AddRecvStream();
4725 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4726}
4727
eladalonf1841382017-06-12 01:16:46 -07004728TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004729 EXPECT_EQ(webrtc::kNetworkUp,
4730 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4731 EXPECT_EQ(webrtc::kNetworkUp,
4732 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004733
4734 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004735 EXPECT_EQ(webrtc::kNetworkDown,
4736 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4737 EXPECT_EQ(webrtc::kNetworkUp,
4738 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004739
4740 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004741 EXPECT_EQ(webrtc::kNetworkUp,
4742 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4743 EXPECT_EQ(webrtc::kNetworkUp,
4744 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004745}
4746
eladalonf1841382017-06-12 01:16:46 -07004747TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004748 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004749 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004750 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004751
4752 AddSendStream();
4753
4754 cricket::VideoMediaInfo info;
4755 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004756 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004757}
4758
eladalonf1841382017-06-12 01:16:46 -07004759TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004760 FakeVideoSendStream* stream = AddSendStream();
4761 webrtc::VideoSendStream::Stats stats;
4762 stats.encoder_implementation_name = "encoder_implementation_name";
4763 stream->SetStats(stats);
4764
4765 cricket::VideoMediaInfo info;
4766 ASSERT_TRUE(channel_->GetStats(&info));
4767 EXPECT_EQ(stats.encoder_implementation_name,
4768 info.senders[0].encoder_implementation_name);
4769}
4770
eladalonf1841382017-06-12 01:16:46 -07004771TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004772 FakeVideoSendStream* stream = AddSendStream();
4773 webrtc::VideoSendStream::Stats stats;
4774 stats.avg_encode_time_ms = 13;
4775 stats.encode_usage_percent = 42;
4776 stream->SetStats(stats);
4777
4778 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004779 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004780 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4781 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4782}
4783
eladalonf1841382017-06-12 01:16:46 -07004784TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004785 FakeVideoSendStream* stream = AddSendStream();
4786 webrtc::VideoSendStream::Stats stats;
4787 stats.frames_encoded = 13;
4788 stream->SetStats(stats);
4789
4790 cricket::VideoMediaInfo info;
4791 ASSERT_TRUE(channel_->GetStats(&info));
4792 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4793}
4794
eladalonf1841382017-06-12 01:16:46 -07004795TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004796 FakeVideoSendStream* stream = AddSendStream();
4797 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004798 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004799 stream->SetStats(stats);
4800
4801 cricket::VideoMediaInfo info;
4802 ASSERT_TRUE(channel_->GetStats(&info));
4803 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4804}
4805
eladalonf1841382017-06-12 01:16:46 -07004806TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004807 FakeVideoSendStream* stream = AddSendStream();
4808 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004809 stats.substreams[17].width = 123;
4810 stats.substreams[17].height = 40;
4811 stats.substreams[42].width = 80;
4812 stats.substreams[42].height = 31;
4813 stats.substreams[11].width = 20;
4814 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004815 stream->SetStats(stats);
4816
4817 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004818 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004819 ASSERT_EQ(1u, info.senders.size());
4820 EXPECT_EQ(123, info.senders[0].send_frame_width);
4821 EXPECT_EQ(90, info.senders[0].send_frame_height);
4822}
4823
eladalonf1841382017-06-12 01:16:46 -07004824TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004825 FakeVideoSendStream* stream = AddSendStream();
4826 webrtc::VideoSendStream::Stats stats;
4827 stats.number_of_cpu_adapt_changes = 2;
4828 stats.cpu_limited_resolution = true;
4829 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004830
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004831 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004832 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004833 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004834 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004835 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004836}
4837
eladalonf1841382017-06-12 01:16:46 -07004838TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004839 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004840 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004841 stats.number_of_cpu_adapt_changes = 2;
4842 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004843 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004844 stream->SetStats(stats);
4845
4846 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004847 EXPECT_TRUE(channel_->GetStats(&info));
4848 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004849 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4850 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004851 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004852 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004853}
4854
eladalonf1841382017-06-12 01:16:46 -07004855TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004856 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4857 FakeVideoSendStream* stream = AddSendStream();
4858 webrtc::VideoSendStream::Stats stats;
4859 stats.bw_limited_resolution = true;
4860 stream->SetStats(stats);
4861
4862 cricket::VideoMediaInfo info;
4863 EXPECT_TRUE(channel_->GetStats(&info));
4864 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004865 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004866 info.senders[0].adapt_reason);
4867}
4868
Yves Gerey665174f2018-06-19 15:03:05 +02004869TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004870 FakeVideoSendStream* stream = AddSendStream();
4871 webrtc::VideoSendStream::Stats stats;
4872 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4873 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4874 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4875
4876 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4877 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4878 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4879
4880 stream->SetStats(stats);
4881
4882 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004883 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004884 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4885 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4886 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4887}
4888
eladalonf1841382017-06-12 01:16:46 -07004889TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004890 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4891 FakeVideoReceiveStream* stream = AddRecvStream();
4892 webrtc::VideoReceiveStream::Stats stats;
4893 stats.rtcp_packet_type_counts.fir_packets = 2;
4894 stats.rtcp_packet_type_counts.nack_packets = 3;
4895 stats.rtcp_packet_type_counts.pli_packets = 4;
4896 stream->SetStats(stats);
4897
4898 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004899 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004900 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004901 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004902 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004903 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004904 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004905 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004906}
4907
eladalonf1841382017-06-12 01:16:46 -07004908TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004909 FakeVideoReceiveStream* stream = AddRecvStream();
4910 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004911 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004912 stats.decode_ms = 2;
4913 stats.max_decode_ms = 3;
4914 stats.current_delay_ms = 4;
4915 stats.target_delay_ms = 5;
4916 stats.jitter_buffer_ms = 6;
4917 stats.min_playout_delay_ms = 7;
4918 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004919 stats.width = 9;
4920 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004921 stats.frame_counts.key_frames = 11;
4922 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004923 stats.frames_rendered = 13;
4924 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004925 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004926 stream->SetStats(stats);
4927
4928 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004929 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004930 EXPECT_EQ(stats.decoder_implementation_name,
4931 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004932 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4933 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4934 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4935 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4936 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4937 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4938 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004939 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4940 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004941 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4942 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004943 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004944 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004945 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004946 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004947}
4948
eladalonf1841382017-06-12 01:16:46 -07004949TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004950 FakeVideoReceiveStream* stream = AddRecvStream();
4951 webrtc::VideoReceiveStream::Stats stats;
4952 stats.rtp_stats.transmitted.payload_bytes = 2;
4953 stats.rtp_stats.transmitted.header_bytes = 3;
4954 stats.rtp_stats.transmitted.padding_bytes = 4;
4955 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004956 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004957 stats.rtcp_stats.fraction_lost = 7;
4958 stream->SetStats(stats);
4959
4960 cricket::VideoMediaInfo info;
4961 ASSERT_TRUE(channel_->GetStats(&info));
4962 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4963 stats.rtp_stats.transmitted.header_bytes +
4964 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004965 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004966 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004967 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004968 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004969 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004970 info.receivers[0].fraction_lost);
4971}
4972
eladalonf1841382017-06-12 01:16:46 -07004973TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004974 AddSendStream();
4975 AddSendStream();
4976 webrtc::Call::Stats stats;
4977 stats.rtt_ms = 123;
4978 fake_call_->SetStats(stats);
4979
4980 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004981 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004982 ASSERT_EQ(2u, info.senders.size());
4983 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4984 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4985}
4986
eladalonf1841382017-06-12 01:16:46 -07004987TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004988 FakeVideoSendStream* stream = AddSendStream();
4989 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004990 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004991 stats.media_bitrate_bps = 123;
4992 stats.substreams[17].total_bitrate_bps = 1;
4993 stats.substreams[17].retransmit_bitrate_bps = 2;
4994 stats.substreams[42].total_bitrate_bps = 3;
4995 stats.substreams[42].retransmit_bitrate_bps = 4;
4996 stream->SetStats(stats);
4997
4998 FakeVideoSendStream* stream2 = AddSendStream();
4999 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005000 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005001 stats2.media_bitrate_bps = 321;
5002 stats2.substreams[13].total_bitrate_bps = 5;
5003 stats2.substreams[13].retransmit_bitrate_bps = 6;
5004 stats2.substreams[21].total_bitrate_bps = 7;
5005 stats2.substreams[21].retransmit_bitrate_bps = 8;
5006 stream2->SetStats(stats2);
5007
5008 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005009 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005010 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005011 BandwidthEstimationInfo bwe_info;
5012 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005013 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5014 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5015 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5016 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005017 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005018 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005019 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005020 bwe_info.actual_enc_bitrate);
5021 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005022 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005023 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005024 << "Bandwidth stats should take all streams into account.";
5025}
5026
eladalonf1841382017-06-12 01:16:46 -07005027TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005028 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005029
Peter Boström0c4e06b2015-10-07 12:23:21 +02005030 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5031 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005032
5033 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5034 const size_t kDataLength = 12;
5035 uint8_t data[kDataLength];
5036 memset(data, 0, sizeof(data));
5037 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005038 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005039 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005040
5041 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5042 << "No default receive stream created.";
5043 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005044 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005045 << "Default receive stream should not have configured RTX";
5046
5047 EXPECT_TRUE(channel_->AddRecvStream(
5048 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5049 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005050 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005051 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005052 EXPECT_FALSE(
5053 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005054 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005055 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005056 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005057 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005058 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005059 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005060}
5061
eladalonf1841382017-06-12 01:16:46 -07005062TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005063 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005064
Peter Boström0c4e06b2015-10-07 12:23:21 +02005065 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5066 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005067
5068 StreamParams sp =
5069 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5070 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5071
5072 EXPECT_FALSE(channel_->AddSendStream(sp));
5073 EXPECT_FALSE(channel_->AddRecvStream(sp));
5074}
5075
eladalonf1841382017-06-12 01:16:46 -07005076TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005077 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005078
Peter Boström0c4e06b2015-10-07 12:23:21 +02005079 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5080 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005081
5082 StreamParams sp =
5083 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5084
5085 EXPECT_TRUE(channel_->AddSendStream(sp));
5086 EXPECT_TRUE(channel_->AddRecvStream(sp));
5087
5088 // The RTX SSRC is already used in previous streams, using it should fail.
5089 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5090 EXPECT_FALSE(channel_->AddSendStream(sp));
5091 EXPECT_FALSE(channel_->AddRecvStream(sp));
5092
5093 // After removing the original stream this should be fine to add (makes sure
5094 // that RTX ssrcs are not forever taken).
5095 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5096 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5097 EXPECT_TRUE(channel_->AddSendStream(sp));
5098 EXPECT_TRUE(channel_->AddRecvStream(sp));
5099}
5100
eladalonf1841382017-06-12 01:16:46 -07005101TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005102 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005103 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5104 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005105 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005106
Peter Boströmd6f4c252015-03-26 16:23:04 +01005107 StreamParams sp =
5108 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5109
5110 EXPECT_TRUE(channel_->AddSendStream(sp));
5111 EXPECT_TRUE(channel_->AddRecvStream(sp));
5112
5113 // One of the SSRCs is already used in previous streams, using it should fail.
5114 sp = cricket::CreateSimStreamParams("cname",
5115 MAKE_VECTOR(kOverlappingStreamSsrcs));
5116 EXPECT_FALSE(channel_->AddSendStream(sp));
5117 EXPECT_FALSE(channel_->AddRecvStream(sp));
5118
5119 // After removing the original stream this should be fine to add (makes sure
5120 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005121 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5122 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005123 EXPECT_TRUE(channel_->AddSendStream(sp));
5124 EXPECT_TRUE(channel_->AddRecvStream(sp));
5125}
5126
eladalonf1841382017-06-12 01:16:46 -07005127TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005128 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005129
5130 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5131 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5132
5133 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5134 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5135
5136 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5137
5138 static const uint32_t kReceiverSsrcs[] = {3};
5139 static const uint32_t kReceiverRtxSsrcs[] = {2};
5140
5141 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5142 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5143 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5144
5145 cricket::VideoMediaInfo info;
5146 ASSERT_TRUE(channel_->GetStats(&info));
5147
5148 ASSERT_EQ(1u, info.senders.size());
5149 ASSERT_EQ(1u, info.receivers.size());
5150
5151 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5152 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5153 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5154}
5155
eladalonf1841382017-06-12 01:16:46 -07005156TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005157 FakeVideoReceiveStream* stream = AddRecvStream();
5158 webrtc::VideoReceiveStream::Stats stats;
5159 cricket::VideoMediaInfo info;
5160
5161 // Report no codec name before receiving.
5162 stream->SetStats(stats);
5163 ASSERT_TRUE(channel_->GetStats(&info));
5164 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5165
5166 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005167 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005168 stream->SetStats(stats);
5169 ASSERT_TRUE(channel_->GetStats(&info));
5170 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5171
5172 // Report no codec name for unknown playload types.
5173 stats.current_payload_type = 3;
5174 stream->SetStats(stats);
5175 ASSERT_TRUE(channel_->GetStats(&info));
5176 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5177}
5178
Seth Hampson5897a6e2018-04-03 11:16:33 -07005179// Tests that when we add a stream without SSRCs, but contains a stream_id
5180// that it is stored and its stream id is later used when the first packet
5181// arrives to properly create a receive stream with a sync label.
5182TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5183 const char kSyncLabel[] = "sync_label";
5184 cricket::StreamParams unsignaled_stream;
5185 unsignaled_stream.set_stream_ids({kSyncLabel});
5186 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5187 // The stream shouldn't have been created at this point because it doesn't
5188 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005189 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005190
5191 // Create and deliver packet.
5192 const size_t kDataLength = 12;
5193 uint8_t data[kDataLength];
5194 memset(data, 0, sizeof(data));
5195 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5196 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005197 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005198
5199 // The stream should now be created with the appropriate sync label.
5200 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5201 EXPECT_EQ(kSyncLabel,
5202 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5203
5204 // Removing the unsignaled stream should clear the cache. This time when
5205 // a default video receive stream is created it won't have a sync_group.
5206 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5207 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5208 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5209
Niels Möllere6933812018-11-05 13:01:41 +01005210 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005211 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5212 EXPECT_TRUE(
5213 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5214}
5215
eladalonf1841382017-06-12 01:16:46 -07005216void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005217 uint8_t payload_type,
5218 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005219 // kRedRtxPayloadType must currently be unused.
5220 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5221
noahricd10a68e2015-07-10 11:27:55 -07005222 // Add a RED RTX codec.
5223 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005224 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005225 recv_parameters_.codecs.push_back(red_rtx_codec);
5226 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005227
5228 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5229 const size_t kDataLength = 12;
5230 uint8_t data[kDataLength];
5231 memset(data, 0, sizeof(data));
5232
5233 rtc::Set8(data, 1, payload_type);
5234 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005235 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Niels Möllere6933812018-11-05 13:01:41 +01005236 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005237
5238 if (expect_created_receive_stream) {
5239 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5240 << "Should have created a receive stream for payload type: "
5241 << payload_type;
5242 } else {
5243 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5244 << "Shouldn't have created a receive stream for payload type: "
5245 << payload_type;
5246 }
5247}
5248
Åsa Persson2c7149b2018-10-15 09:36:10 +02005249class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5250 public:
5251 WebRtcVideoChannelDiscardUnknownSsrcTest()
5252 : WebRtcVideoChannelTest(
5253 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5254};
5255
5256TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5257 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5258 false /* expect_created_receive_stream */);
5259}
5260
eladalonf1841382017-06-12 01:16:46 -07005261TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005262 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5263 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005264}
5265
eladalonf1841382017-06-12 01:16:46 -07005266TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005267 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5268 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005269}
5270
eladalonf1841382017-06-12 01:16:46 -07005271TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005272 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005273 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5274 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5275 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5276 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005277}
5278
eladalonf1841382017-06-12 01:16:46 -07005279TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005280 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5281 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005282}
5283
eladalonf1841382017-06-12 01:16:46 -07005284TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005285 FlexfecPacketDoesntCreateUnsignalledStream) {
5286 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5287 false /* expect_created_receive_stream */);
5288}
5289
eladalonf1841382017-06-12 01:16:46 -07005290TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005291 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5292 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005293}
5294
mzanaty8a855d62017-02-17 15:46:43 -08005295// Test that receiving any unsignalled SSRC works even if it changes.
5296// The first unsignalled SSRC received will create a default receive stream.
5297// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005298TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005299 // Allow receiving VP8, VP9, H264 (if enabled).
5300 cricket::VideoRecvParameters parameters;
5301 parameters.codecs.push_back(GetEngineCodec("VP8"));
5302 parameters.codecs.push_back(GetEngineCodec("VP9"));
5303
5304#if defined(WEBRTC_USE_H264)
5305 cricket::VideoCodec H264codec(126, "H264");
5306 parameters.codecs.push_back(H264codec);
5307#endif
5308
5309 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5310 // No receive streams yet.
5311 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5312 cricket::FakeVideoRenderer renderer;
5313 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5314
5315 // Receive VP8 packet on first SSRC.
5316 uint8_t data[kMinRtpPacketLen];
5317 cricket::RtpHeader rtpHeader;
5318 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5319 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005320 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005321 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5322 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005323 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005324 // VP8 packet should create default receive stream.
5325 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005326 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005327 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5328 // Verify that the receive stream sinks to a renderer.
5329 webrtc::VideoFrame video_frame(CreateBlackFrameBuffer(4, 4), 100, 0,
5330 webrtc::kVideoRotation_0);
5331 recv_stream->InjectFrame(video_frame);
5332 EXPECT_EQ(1, renderer.num_rendered_frames());
5333
5334 // Receive VP9 packet on second SSRC.
5335 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005336 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005337 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5338 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005339 channel_->OnPacketReceived(&packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005340 // VP9 packet should replace the default receive SSRC.
5341 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5342 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5343 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5344 // Verify that the receive stream sinks to a renderer.
5345 webrtc::VideoFrame video_frame2(CreateBlackFrameBuffer(4, 4), 200, 0,
ilnik00d802b2017-04-11 10:34:31 -07005346 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005347 recv_stream->InjectFrame(video_frame2);
5348 EXPECT_EQ(2, renderer.num_rendered_frames());
5349
5350#if defined(WEBRTC_USE_H264)
5351 // Receive H264 packet on third SSRC.
5352 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005353 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005354 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5355 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005356 channel_->OnPacketReceived(&packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005357 // H264 packet should replace the default receive SSRC.
5358 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5359 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5360 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5361 // Verify that the receive stream sinks to a renderer.
5362 webrtc::VideoFrame video_frame3(CreateBlackFrameBuffer(4, 4), 300, 0,
ilnik00d802b2017-04-11 10:34:31 -07005363 webrtc::kVideoRotation_0);
mzanaty8a855d62017-02-17 15:46:43 -08005364 recv_stream->InjectFrame(video_frame3);
5365 EXPECT_EQ(3, renderer.num_rendered_frames());
5366#endif
5367}
5368
brandtr0dc57ea2017-05-29 23:33:31 -07005369// This test verifies that when a new default stream is created for a new
5370// unsignaled SSRC, the new stream does not overwrite any old stream that had
5371// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005372TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005373 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5374 cricket::VideoRecvParameters parameters;
5375 parameters.codecs.push_back(GetEngineCodec("VP8"));
5376 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5377
5378 // No streams signaled and no packets received, so we should not have any
5379 // stream objects created yet.
5380 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5381
5382 // Receive packet on an unsignaled SSRC.
5383 uint8_t data[kMinRtpPacketLen];
5384 cricket::RtpHeader rtp_header;
5385 rtp_header.payload_type = GetEngineCodec("VP8").id;
5386 rtp_header.seq_num = rtp_header.timestamp = 0;
5387 rtp_header.ssrc = kSsrcs3[0];
5388 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5389 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005390 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005391 // Default receive stream should be created.
5392 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5393 FakeVideoReceiveStream* recv_stream0 =
5394 fake_call_->GetVideoReceiveStreams()[0];
5395 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5396
5397 // Signal the SSRC.
5398 EXPECT_TRUE(
5399 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5400 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5401 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5402 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5403
5404 // Receive packet on a different unsignaled SSRC.
5405 rtp_header.ssrc = kSsrcs3[1];
5406 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5407 packet.SetData(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01005408 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005409 // New default receive stream should be created, but old stream should remain.
5410 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5411 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5412 FakeVideoReceiveStream* recv_stream1 =
5413 fake_call_->GetVideoReceiveStreams()[1];
5414 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5415}
5416
Seth Hampson7c682e02018-05-04 16:28:15 -07005417TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005418 AddSendStream();
5419
Tommi85959932018-02-07 19:26:06 +01005420 FakeVideoCapturerWithTaskQueue capturer;
Niels Möllerff40b142018-04-09 08:49:14 +02005421 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
skvladdc1c62c2016-03-16 19:07:43 -07005422 cricket::VideoFormat capture_format_hd =
5423 capturer.GetSupportedFormats()->front();
5424 EXPECT_EQ(1280, capture_format_hd.width);
5425 EXPECT_EQ(720, capture_format_hd.height);
5426 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(capture_format_hd));
5427 EXPECT_TRUE(channel_->SetSend(true));
perkjfa10b552016-10-02 23:45:26 -07005428 capturer.CaptureFrame();
skvladdc1c62c2016-03-16 19:07:43 -07005429
perkjfa10b552016-10-02 23:45:26 -07005430 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005431 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005432
5433 // TODO(skvlad): Resolve the inconsistency between the interpretation
5434 // of the global bitrate limit for audio and video:
5435 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5436 // max_bandwidth_bps = -1 - remove the bandwidth limit
5437 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005438 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005439
perkjfa10b552016-10-02 23:45:26 -07005440 SetAndExpectMaxBitrate(1000, 0, 1000);
5441 SetAndExpectMaxBitrate(1000, 800, 800);
5442 SetAndExpectMaxBitrate(600, 800, 600);
5443 SetAndExpectMaxBitrate(0, 800, 800);
5444 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005445
Niels Möllerff40b142018-04-09 08:49:14 +02005446 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005447}
5448
eladalonf1841382017-06-12 01:16:46 -07005449TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005450 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005451 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005452 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005453
5454 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005455 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005456 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005457}
5458
eladalonf1841382017-06-12 01:16:46 -07005459TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005460 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005461 FakeVideoSendStream* stream = AddSendStream();
5462
Seth Hampson7c682e02018-05-04 16:28:15 -07005463 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5464 EXPECT_EQ(1UL, parameters.encodings.size());
5465 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5466 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5467
5468 // Note that this is testing the behavior of the FakeVideoSendStream, which
5469 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5470 // we are just testing the behavior of
5471 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005472 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5473 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005474
5475 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5476 // by this amount.
5477 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5478 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5479 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5480 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5481
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005482 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5483 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5484 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5485}
5486
5487TEST_F(WebRtcVideoChannelTest,
5488 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5489 FakeVideoSendStream* stream = AddSendStream();
5490
5491 // Note that this is testing the behavior of the FakeVideoSendStream, which
5492 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5493 // we are just testing the behavior of
5494 // EncoderStreamFactory::CreateEncoderStreams.
5495 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5496 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5497
5498 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5499 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5500 EXPECT_EQ(1UL, parameters.encodings.size());
5501 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5502 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5503
5504 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5505 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5506 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5507}
5508
5509TEST_F(WebRtcVideoChannelTest,
5510 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5511 send_parameters_.max_bandwidth_bps = 99999;
5512 FakeVideoSendStream* stream = AddSendStream();
5513 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5514 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5515 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5516 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5517 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5518 stream->GetVideoStreams()[0].max_bitrate_bps);
5519
5520 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5521 // adjusted down.
5522 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5523 EXPECT_EQ(1UL, parameters.encodings.size());
5524 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5525 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5526 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5527 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5528 stream->GetVideoStreams()[0].min_bitrate_bps);
5529 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5530 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005531}
5532
Åsa Persson8c1bf952018-09-13 10:42:19 +02005533TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5534 FakeVideoSendStream* stream = AddSendStream();
5535
5536 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5537 EXPECT_EQ(1UL, parameters.encodings.size());
5538 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5539 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5540
5541 // Note that this is testing the behavior of the FakeVideoSendStream, which
5542 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5543 // we are just testing the behavior of
5544 // EncoderStreamFactory::CreateEncoderStreams.
5545 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5546 EXPECT_EQ(kDefaultVideoMaxFramerate,
5547 stream->GetVideoStreams()[0].max_framerate);
5548
5549 // Set max framerate and check that VideoStream.max_framerate is set.
5550 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5551 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5552 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5553 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5554
5555 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5556 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5557}
5558
Åsa Persson23eba222018-10-02 14:47:06 +02005559TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5560 FakeVideoSendStream* stream = AddSendStream();
5561
5562 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5563 EXPECT_EQ(1UL, parameters.encodings.size());
5564 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5565 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5566
5567 // Note that this is testing the behavior of the FakeVideoSendStream, which
5568 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5569 // we are just testing the behavior of
5570 // EncoderStreamFactory::CreateEncoderStreams.
5571 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5572 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5573
5574 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5575 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5576 parameters.encodings[0].num_temporal_layers = 2;
5577 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5578
5579 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5580 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5581}
5582
Seth Hampson7c682e02018-05-04 16:28:15 -07005583TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005584 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005585 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005586 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005587 // Two or more encodings should result in failure.
5588 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005589 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005590 // Zero encodings should also fail.
5591 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005592 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005593}
5594
Zach Stein3ca452b2018-01-18 10:01:24 -08005595TEST_F(WebRtcVideoChannelTest,
5596 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5597 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5598 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5599 AddSendStream(sp);
5600
5601 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5602
5603 // Additional encodings should result in failure.
5604 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005605 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005606 // Zero encodings should also fail.
5607 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005608 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005609}
5610
deadbeeffb2aced2017-01-06 23:05:37 -08005611// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005612TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005613 AddSendStream();
5614 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005615 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005616 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005617}
5618
Seth Hampson24722b32017-12-22 09:36:42 -08005619// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5620// a value <= 0, setting the parameters returns false.
5621TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5622 AddSendStream();
5623 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5624 EXPECT_EQ(1UL, parameters.encodings.size());
5625 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5626 parameters.encodings[0].bitrate_priority);
5627
5628 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005629 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005630 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005631 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005632}
5633
5634// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5635// properly on the VideoChannel and propogates down to the video encoder.
5636TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5637 AddSendStream();
5638 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5639 EXPECT_EQ(1UL, parameters.encodings.size());
5640 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5641 parameters.encodings[0].bitrate_priority);
5642
5643 // Change the value and set it on the VideoChannel.
5644 double new_bitrate_priority = 2.0;
5645 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005646 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005647
5648 // Verify that the encoding parameters bitrate_priority is set for the
5649 // VideoChannel.
5650 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5651 EXPECT_EQ(1UL, parameters.encodings.size());
5652 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5653
5654 // Verify that the new value propagated down to the encoder.
5655 std::vector<FakeVideoSendStream*> video_send_streams =
5656 fake_call_->GetVideoSendStreams();
5657 EXPECT_EQ(1UL, video_send_streams.size());
5658 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5659 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5660 // appropriately.
5661 EXPECT_EQ(new_bitrate_priority,
5662 video_send_stream->GetEncoderConfig().bitrate_priority);
5663 // Check that the vector of VideoStreams also was propagated correctly. Note
5664 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5665 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005666 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005667 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5668}
5669
5670// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5671// VideoChannel and the value propogates to the video encoder with all simulcast
5672// streams.
5673TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5674 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005675 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005676 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5677 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5678 AddSendStream(stream_params);
5679 uint32_t primary_ssrc = stream_params.first_ssrc();
5680
Tommi85959932018-02-07 19:26:06 +01005681 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
5682 // frame. This creates multiple VideoStreams for all simulcast layers when
5683 // reconfiguring, and allows us to test this behavior.
5684 FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson24722b32017-12-22 09:36:42 -08005685 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02005686 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson24722b32017-12-22 09:36:42 -08005687 EXPECT_EQ(cricket::CS_RUNNING,
5688 capturer.Start(cricket::VideoFormat(
5689 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
5690 cricket::FOURCC_I420)));
5691 channel_->SetSend(true);
5692 EXPECT_TRUE(capturer.CaptureFrame());
5693 // Get and set the rtp encoding parameters.
5694 webrtc::RtpParameters parameters =
5695 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005696 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005697 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5698 parameters.encodings[0].bitrate_priority);
5699 // Change the value and set it on the VideoChannel.
5700 double new_bitrate_priority = 2.0;
5701 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005702 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005703
5704 // Verify that the encoding parameters priority is set on the VideoChannel.
5705 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005706 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005707 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5708
5709 // Verify that the new value propagated down to the encoder.
5710 std::vector<FakeVideoSendStream*> video_send_streams =
5711 fake_call_->GetVideoSendStreams();
5712 EXPECT_EQ(1UL, video_send_streams.size());
5713 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5714 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5715 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005716 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005717 video_send_stream->GetEncoderConfig().number_of_streams);
5718 EXPECT_EQ(new_bitrate_priority,
5719 video_send_stream->GetEncoderConfig().bitrate_priority);
5720 // Check that the vector of VideoStreams also propagated correctly. The
5721 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5722 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005723 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005724 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005725 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5726 // Since we are only setting bitrate priority per-sender, the other
5727 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005728 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005729 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005730 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005731 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005732 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005733}
5734
Tim Haloun648d28a2018-10-18 16:52:22 -07005735// RTCRtpEncodingParameters.network_priority must be one of a few values
5736// derived from the default priority, corresponding to very-low, low, medium,
5737// or high.
5738TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5739 AddSendStream();
5740 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5741 EXPECT_EQ(1UL, parameters.encodings.size());
5742 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5743 parameters.encodings[0].network_priority);
5744
5745 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5746 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5747 for (auto it : good_values) {
5748 parameters.encodings[0].network_priority = it;
5749 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5750 }
5751 for (auto it : bad_values) {
5752 parameters.encodings[0].network_priority = it;
5753 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5754 }
5755}
5756
Åsa Persson8c1bf952018-09-13 10:42:19 +02005757TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
5758 const size_t kNumSimulcastStreams = 3;
5759 SetUpSimulcast(true, false);
5760
5761 // Get and set the rtp encoding parameters.
5762 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5763 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5764 for (const auto& encoding : parameters.encodings) {
5765 EXPECT_FALSE(encoding.max_framerate);
5766 }
5767
5768 // Change the value and set it on the VideoChannel.
5769 parameters.encodings[0].max_framerate = 10;
5770 parameters.encodings[1].max_framerate = 20;
5771 parameters.encodings[2].max_framerate = 25;
5772 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5773
5774 // Verify that the bitrates are set on the VideoChannel.
5775 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5776 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5777 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
5778 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
5779 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
5780}
5781
Åsa Persson23eba222018-10-02 14:47:06 +02005782TEST_F(WebRtcVideoChannelTest,
5783 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
5784 const size_t kNumSimulcastStreams = 3;
5785 SetUpSimulcast(true, false);
5786
5787 // Get and set the rtp encoding parameters.
5788 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5789 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5790
5791 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
5792 parameters.encodings[0].num_temporal_layers = 0;
5793 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5794 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5795 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
5796 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
5797 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5798}
5799
5800TEST_F(WebRtcVideoChannelTest,
5801 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
5802 const size_t kNumSimulcastStreams = 3;
5803 SetUpSimulcast(true, false);
5804
5805 // Get and set the rtp encoding parameters.
5806 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5807 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5808
5809 // No/all layers should be set.
5810 parameters.encodings[0].num_temporal_layers = 1;
5811 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5812 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5813
5814 // Different values not supported.
5815 parameters.encodings[0].num_temporal_layers = 1;
5816 parameters.encodings[1].num_temporal_layers = 2;
5817 parameters.encodings[2].num_temporal_layers = 2;
5818 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
5819 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
5820}
5821
5822TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
5823 const size_t kNumSimulcastStreams = 3;
5824 SetUpSimulcast(true, false);
5825
5826 // Get and set the rtp encoding parameters.
5827 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5828 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5829 for (const auto& encoding : parameters.encodings)
5830 EXPECT_FALSE(encoding.num_temporal_layers);
5831
5832 // Change the value and set it on the VideoChannel.
5833 parameters.encodings[0].num_temporal_layers = 3;
5834 parameters.encodings[1].num_temporal_layers = 3;
5835 parameters.encodings[2].num_temporal_layers = 3;
5836 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5837
5838 // Verify that the number of temporal layers are set on the VideoChannel.
5839 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5840 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5841 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
5842 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
5843 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
5844}
5845
5846TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
5847 const size_t kNumSimulcastStreams = 3;
5848 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5849
5850 // Send a full size frame so all simulcast layers are used when reconfiguring.
5851 FakeVideoCapturerWithTaskQueue capturer;
5852 VideoOptions options;
5853 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5854 EXPECT_EQ(cricket::CS_RUNNING,
5855 capturer.Start(capturer.GetSupportedFormats()->front()));
5856 channel_->SetSend(true);
5857 EXPECT_TRUE(capturer.CaptureFrame());
5858
5859 // Get and set the rtp encoding parameters.
5860 // Change the value and set it on the VideoChannel.
5861 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5862 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5863 parameters.encodings[0].num_temporal_layers = 2;
5864 parameters.encodings[1].num_temporal_layers = 2;
5865 parameters.encodings[2].num_temporal_layers = 2;
5866 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5867
5868 // Verify that the new value is propagated down to the encoder.
5869 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5870 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5871 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5872 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5873 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5874 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
5875 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
5876 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
5877
5878 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5879 // VideoStreams are created appropriately for the simulcast case.
5880 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5881 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5882 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
5883 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
5884
5885 // No parameter changed, encoder should not be reconfigured.
5886 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5887 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5888
5889 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5890}
5891
5892TEST_F(WebRtcVideoChannelTest,
5893 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
5894 const size_t kDefaultNumTemporalLayers = 3;
5895 const size_t kNumSimulcastStreams = 3;
5896 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5897
5898 // Send a full size frame so all simulcast layers are used when reconfiguring.
5899 FakeVideoCapturerWithTaskQueue capturer;
5900 VideoOptions options;
5901 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5902 EXPECT_EQ(cricket::CS_RUNNING,
5903 capturer.Start(capturer.GetSupportedFormats()->front()));
5904 channel_->SetSend(true);
5905 EXPECT_TRUE(capturer.CaptureFrame());
5906
5907 // Change rtp encoding parameters, num_temporal_layers not changed.
5908 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5909 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5910 parameters.encodings[0].min_bitrate_bps = 33000;
5911 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5912
5913 // Verify that no value is propagated down to the encoder.
5914 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5915 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5916 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5917 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
5918 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
5919 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
5920
5921 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5922 // VideoStreams are created appropriately for the simulcast case.
5923 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5924 EXPECT_EQ(kDefaultNumTemporalLayers,
5925 stream->GetVideoStreams()[0].num_temporal_layers);
5926 EXPECT_EQ(kDefaultNumTemporalLayers,
5927 stream->GetVideoStreams()[1].num_temporal_layers);
5928 EXPECT_EQ(kDefaultNumTemporalLayers,
5929 stream->GetVideoStreams()[2].num_temporal_layers);
5930
5931 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5932}
5933
Åsa Persson8c1bf952018-09-13 10:42:19 +02005934TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
5935 const size_t kNumSimulcastStreams = 3;
5936 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5937
5938 // Send a full size frame so all simulcast layers are used when reconfiguring.
5939 FakeVideoCapturerWithTaskQueue capturer;
5940 VideoOptions options;
5941 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5942 EXPECT_EQ(cricket::CS_RUNNING,
5943 capturer.Start(capturer.GetSupportedFormats()->front()));
5944 channel_->SetSend(true);
5945 EXPECT_TRUE(capturer.CaptureFrame());
5946
5947 // Get and set the rtp encoding parameters.
5948 // Change the value and set it on the VideoChannel.
5949 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5950 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5951 parameters.encodings[0].max_framerate = 15;
5952 parameters.encodings[1].max_framerate = 25;
5953 parameters.encodings[2].max_framerate = 20;
5954 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5955
5956 // Verify that the new value propagated down to the encoder.
5957 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
5958 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
5959 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
5960 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
5961 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
5962 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
5963 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
5964 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
5965
5966 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
5967 // VideoStreams are created appropriately for the simulcast case.
5968 // Currently the maximum |max_framerate| is used.
5969 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
5970 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
5971 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
5972 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
5973
5974 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5975}
5976
5977TEST_F(WebRtcVideoChannelTest,
5978 DefaultValuePropagatedToEncoderForUnsetFramerate) {
5979 const size_t kNumSimulcastStreams = 3;
5980 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
5981 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5982
5983 // Send a full size frame so all simulcast layers are used when reconfiguring.
5984 FakeVideoCapturerWithTaskQueue capturer;
5985 VideoOptions options;
5986 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
5987 EXPECT_EQ(cricket::CS_RUNNING,
5988 capturer.Start(capturer.GetSupportedFormats()->front()));
5989 channel_->SetSend(true);
5990 EXPECT_TRUE(capturer.CaptureFrame());
5991
5992 // Get and set the rtp encoding parameters.
5993 // Change the value and set it on the VideoChannel.
5994 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5995 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
5996 parameters.encodings[0].max_framerate = 15;
5997 parameters.encodings[2].max_framerate = 20;
5998 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5999
6000 // Verify that the new value propagated down to the encoder.
6001 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6002 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6003 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6004 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6005 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6006 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6007 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6008
6009 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6010 // VideoStreams are created appropriately for the simulcast case.
6011 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6012 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6013 EXPECT_EQ(kDefaultVideoMaxFramerate,
6014 stream->GetVideoStreams()[0].max_framerate);
6015 EXPECT_EQ(kDefaultVideoMaxFramerate,
6016 stream->GetVideoStreams()[1].max_framerate);
6017 EXPECT_EQ(kDefaultVideoMaxFramerate,
6018 stream->GetVideoStreams()[2].max_framerate);
6019
6020 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6021}
6022
Åsa Persson55659812018-06-18 17:51:32 +02006023TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6024 const size_t kNumSimulcastStreams = 3;
6025 SetUpSimulcast(true, false);
6026
6027 // Get and set the rtp encoding parameters.
6028 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6029 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6030 for (const auto& encoding : parameters.encodings) {
6031 EXPECT_FALSE(encoding.min_bitrate_bps);
6032 EXPECT_FALSE(encoding.max_bitrate_bps);
6033 }
6034
6035 // Change the value and set it on the VideoChannel.
6036 parameters.encodings[0].min_bitrate_bps = 100000;
6037 parameters.encodings[0].max_bitrate_bps = 200000;
6038 parameters.encodings[1].min_bitrate_bps = 300000;
6039 parameters.encodings[1].max_bitrate_bps = 400000;
6040 parameters.encodings[2].min_bitrate_bps = 500000;
6041 parameters.encodings[2].max_bitrate_bps = 600000;
6042 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6043
6044 // Verify that the bitrates are set on the VideoChannel.
6045 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6046 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6047 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6048 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6049 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6050 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6051 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6052 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6053}
6054
6055TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6056 const size_t kNumSimulcastStreams = 3;
6057 SetUpSimulcast(true, false);
6058
6059 // Get and set the rtp encoding parameters.
6060 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6061 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6062
6063 // Max bitrate lower than min bitrate should fail.
6064 parameters.encodings[2].min_bitrate_bps = 100000;
6065 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6066 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6067 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6068}
6069
6070// Test that min and max bitrate values set via RtpParameters are correctly
6071// propagated to the underlying encoder, and that the target is set to 3/4 of
6072// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6073// that are used if no min/max are specified).
6074TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6075 const size_t kNumSimulcastStreams = 3;
6076 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6077
6078 // Send a full size frame so all simulcast layers are used when reconfiguring.
6079 FakeVideoCapturerWithTaskQueue capturer;
6080 VideoOptions options;
6081 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6082 EXPECT_EQ(cricket::CS_RUNNING,
6083 capturer.Start(capturer.GetSupportedFormats()->front()));
6084 channel_->SetSend(true);
6085 EXPECT_TRUE(capturer.CaptureFrame());
6086
6087 // Get and set the rtp encoding parameters.
6088 // Change the value and set it on the VideoChannel.
6089 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6090 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6091 parameters.encodings[0].min_bitrate_bps = 100000;
6092 parameters.encodings[0].max_bitrate_bps = 200000;
6093 parameters.encodings[1].min_bitrate_bps = 300000;
6094 parameters.encodings[1].max_bitrate_bps = 400000;
6095 parameters.encodings[2].min_bitrate_bps = 500000;
6096 parameters.encodings[2].max_bitrate_bps = 600000;
6097 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6098
6099 // Verify that the new value propagated down to the encoder.
6100 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6101 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6102 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6103 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6104 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6105 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6106 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6107 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6108 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6109 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6110 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6111
6112 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6113 // VideoStreams are created appropriately for the simulcast case.
6114 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6115 // Target bitrate: 200000 * 3 / 4 = 150000.
6116 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6117 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6118 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6119 // Target bitrate: 400000 * 3 / 4 = 300000.
6120 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6121 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6122 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6123 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6124 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6125 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6126 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6127
6128 // No parameter changed, encoder should not be reconfigured.
6129 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6130 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6131
6132 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6133}
6134
6135// Test to only specify the min or max bitrate value for a layer via
6136// RtpParameters. The unspecified min/max and target value should be set to the
6137// simulcast default that is used if no min/max are specified.
6138TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6139 const size_t kNumSimulcastStreams = 3;
6140 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6141 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6142
6143 // Send a full size frame so all simulcast layers are used when reconfiguring.
6144 FakeVideoCapturerWithTaskQueue capturer;
6145 VideoOptions options;
6146 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6147 EXPECT_EQ(cricket::CS_RUNNING,
6148 capturer.Start(capturer.GetSupportedFormats()->front()));
6149 channel_->SetSend(true);
6150 EXPECT_TRUE(capturer.CaptureFrame());
6151
6152 // Get and set the rtp encoding parameters.
6153 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6154 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6155
6156 // Change the value and set it on the VideoChannel.
6157 // Layer 0: only configure min bitrate.
6158 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6159 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6160 // Layer 1: only configure max bitrate.
6161 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6162 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6163 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6164
6165 // Verify that the new value propagated down to the encoder.
6166 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6167 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6168 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6169 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6170 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6171 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6172 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6173 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6174 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6175 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6176
6177 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6178 // VideoStreams are created appropriately for the simulcast case.
6179 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6180 // Layer 0: min configured bitrate should overwrite min default.
6181 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6182 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6183 stream->GetVideoStreams()[0].target_bitrate_bps);
6184 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6185 stream->GetVideoStreams()[0].max_bitrate_bps);
6186 // Layer 1: max configured bitrate should overwrite max default.
6187 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6188 stream->GetVideoStreams()[1].min_bitrate_bps);
6189 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6190 stream->GetVideoStreams()[1].target_bitrate_bps);
6191 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6192 // Layer 2: min and max bitrate not configured, default expected.
6193 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6194 stream->GetVideoStreams()[2].min_bitrate_bps);
6195 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6196 stream->GetVideoStreams()[2].target_bitrate_bps);
6197 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6198 stream->GetVideoStreams()[2].max_bitrate_bps);
6199
6200 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6201}
6202
6203// Test that specifying the min (or max) bitrate value for a layer via
6204// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6205// unspecified values accordingly.
6206TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6207 const size_t kNumSimulcastStreams = 3;
6208 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6209 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6210
6211 // Send a full size frame so all simulcast layers are used when reconfiguring.
6212 FakeVideoCapturerWithTaskQueue capturer;
6213 VideoOptions options;
6214 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6215 EXPECT_EQ(cricket::CS_RUNNING,
6216 capturer.Start(capturer.GetSupportedFormats()->front()));
6217 channel_->SetSend(true);
6218 EXPECT_TRUE(capturer.CaptureFrame());
6219
6220 // Get and set the rtp encoding parameters.
6221 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6222 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6223
6224 // Change the value and set it on the VideoChannel.
6225 // For layer 0, set the min bitrate above the default max.
6226 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6227 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6228 // For layer 1, set the max bitrate below the default min.
6229 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6230 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6231 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6232
6233 // Verify that the new value propagated down to the encoder.
6234 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6235 // VideoStreams are created appropriately for the simulcast case.
6236 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6237 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6238 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6239 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6240 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6241 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6242 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6243 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6244 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6245 // Layer 2: min and max bitrate not configured, default expected.
6246 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6247 stream->GetVideoStreams()[2].min_bitrate_bps);
6248 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6249 stream->GetVideoStreams()[2].target_bitrate_bps);
6250 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6251 stream->GetVideoStreams()[2].max_bitrate_bps);
6252
6253 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6254}
6255
6256TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6257 const size_t kNumSimulcastStreams = 3;
6258 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6259 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6260
6261 // Send a full size frame so all simulcast layers are used when reconfiguring.
6262 FakeVideoCapturerWithTaskQueue capturer;
6263 VideoOptions options;
6264 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6265 EXPECT_EQ(cricket::CS_RUNNING,
6266 capturer.Start(capturer.GetSupportedFormats()->front()));
6267 channel_->SetSend(true);
6268 EXPECT_TRUE(capturer.CaptureFrame());
6269
6270 // Set max bitrate for all but the highest layer.
6271 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6272 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6273 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6274 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6275 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6276
6277 // Set max bandwidth equal to total max bitrate.
6278 send_parameters_.max_bandwidth_bps =
6279 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6280 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6281 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6282
6283 // No bitrate above the total max to give to the highest layer.
6284 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6285 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6286 stream->GetVideoStreams()[2].max_bitrate_bps);
6287
6288 // Set max bandwidth above the total max bitrate.
6289 send_parameters_.max_bandwidth_bps =
6290 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6291 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6292 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6293
6294 // The highest layer has no max bitrate set -> the bitrate above the total
6295 // max should be given to the highest layer.
6296 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6297 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6298 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6299 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6300 stream->GetVideoStreams()[2].max_bitrate_bps);
6301
6302 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6303}
6304
6305TEST_F(WebRtcVideoChannelTest,
6306 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6307 const size_t kNumSimulcastStreams = 3;
6308 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6309 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6310 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6311
6312 // Send a full size frame so all simulcast layers are used when reconfiguring.
6313 FakeVideoCapturerWithTaskQueue capturer;
6314 VideoOptions options;
6315 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &capturer));
6316 EXPECT_EQ(cricket::CS_RUNNING,
6317 capturer.Start(capturer.GetSupportedFormats()->front()));
6318 channel_->SetSend(true);
6319 EXPECT_TRUE(capturer.CaptureFrame());
6320
6321 // Set max bitrate for the highest layer.
6322 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6323 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6324 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6325 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6326
6327 // Set max bandwidth above the total max bitrate.
6328 send_parameters_.max_bandwidth_bps =
6329 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6330 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6331 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6332
6333 // The highest layer has the max bitrate set -> the bitrate above the total
6334 // max should not be given to the highest layer.
6335 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6336 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6337 stream->GetVideoStreams()[2].max_bitrate_bps);
6338
6339 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6340}
6341
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006342// Test that min and max bitrate values set via RtpParameters are correctly
6343// propagated to the underlying encoder for a single stream.
6344TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6345 FakeVideoSendStream* stream = AddSendStream();
6346 EXPECT_TRUE(channel_->SetSend(true));
6347 EXPECT_TRUE(stream->IsSending());
6348
6349 // Set min and max bitrate.
6350 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6351 EXPECT_EQ(1u, parameters.encodings.size());
6352 parameters.encodings[0].min_bitrate_bps = 80000;
6353 parameters.encodings[0].max_bitrate_bps = 150000;
6354 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6355
6356 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6357 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6358 EXPECT_EQ(1u, encoder_config.number_of_streams);
6359 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6360 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6361 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6362
6363 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6364 // VideoStreams are created appropriately.
6365 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6366 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6367 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6368 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6369}
6370
6371// Test the default min and max bitrate value are correctly propagated to the
6372// underlying encoder for a single stream (when the values are not set via
6373// RtpParameters).
6374TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6375 FakeVideoSendStream* stream = AddSendStream();
6376 EXPECT_TRUE(channel_->SetSend(true));
6377 EXPECT_TRUE(stream->IsSending());
6378
6379 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6380 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6381 EXPECT_EQ(1u, encoder_config.number_of_streams);
6382 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6383 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6384 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6385
6386 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6387 // VideoStreams are created appropriately.
6388 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6389 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6390 stream->GetVideoStreams()[0].min_bitrate_bps);
6391 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6392 stream->GetVideoStreams()[0].min_bitrate_bps);
6393 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6394 stream->GetVideoStreams()[0].target_bitrate_bps);
6395}
6396
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006397// Test that a stream will not be sending if its encoding is made inactive
6398// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006399TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006400 FakeVideoSendStream* stream = AddSendStream();
6401 EXPECT_TRUE(channel_->SetSend(true));
6402 EXPECT_TRUE(stream->IsSending());
6403
6404 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006405 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006406 ASSERT_EQ(1u, parameters.encodings.size());
6407 ASSERT_TRUE(parameters.encodings[0].active);
6408 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006409 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006410 EXPECT_FALSE(stream->IsSending());
6411
6412 // Now change it back to active and verify we resume sending.
6413 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006414 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006415 EXPECT_TRUE(stream->IsSending());
6416}
6417
Seth Hampson8234ead2018-02-02 15:16:24 -08006418// Tests that when active is updated for any simulcast layer then the send
6419// stream's sending state will be updated and it will be reconfigured with the
6420// new appropriate active simulcast streams.
6421TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6422 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006423 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006424 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6425 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6426 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6427 uint32_t primary_ssrc = stream_params.first_ssrc();
6428
Tommi85959932018-02-07 19:26:06 +01006429 // Using the FakeVideoCapturerWithTaskQueue, we manually send a full size
6430 // frame. This allows us to test that ReconfigureEncoder is called
6431 // appropriately.
6432 cricket::FakeVideoCapturerWithTaskQueue capturer;
Seth Hampson8234ead2018-02-02 15:16:24 -08006433 VideoOptions options;
Niels Möllerff40b142018-04-09 08:49:14 +02006434 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &capturer));
Seth Hampson8234ead2018-02-02 15:16:24 -08006435 EXPECT_EQ(cricket::CS_RUNNING,
6436 capturer.Start(cricket::VideoFormat(
6437 1920, 1080, cricket::VideoFormat::FpsToInterval(30),
6438 cricket::FOURCC_I420)));
6439 channel_->SetSend(true);
6440 EXPECT_TRUE(capturer.CaptureFrame());
6441
6442 // Check that all encodings are initially active.
6443 webrtc::RtpParameters parameters =
6444 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006445 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006446 EXPECT_TRUE(parameters.encodings[0].active);
6447 EXPECT_TRUE(parameters.encodings[1].active);
6448 EXPECT_TRUE(parameters.encodings[2].active);
6449 EXPECT_TRUE(fake_video_send_stream->IsSending());
6450
6451 // Only turn on only the middle stream.
6452 parameters.encodings[0].active = false;
6453 parameters.encodings[1].active = true;
6454 parameters.encodings[2].active = false;
6455 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6456 // Verify that the active fields are set on the VideoChannel.
6457 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006458 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006459 EXPECT_FALSE(parameters.encodings[0].active);
6460 EXPECT_TRUE(parameters.encodings[1].active);
6461 EXPECT_FALSE(parameters.encodings[2].active);
6462 // Check that the VideoSendStream is updated appropriately. This means its
6463 // send state was updated and it was reconfigured.
6464 EXPECT_TRUE(fake_video_send_stream->IsSending());
6465 std::vector<webrtc::VideoStream> simulcast_streams =
6466 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006467 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006468 EXPECT_FALSE(simulcast_streams[0].active);
6469 EXPECT_TRUE(simulcast_streams[1].active);
6470 EXPECT_FALSE(simulcast_streams[2].active);
6471
6472 // Turn off all streams.
6473 parameters.encodings[0].active = false;
6474 parameters.encodings[1].active = false;
6475 parameters.encodings[2].active = false;
6476 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6477 // Verify that the active fields are set on the VideoChannel.
6478 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006479 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006480 EXPECT_FALSE(parameters.encodings[0].active);
6481 EXPECT_FALSE(parameters.encodings[1].active);
6482 EXPECT_FALSE(parameters.encodings[2].active);
6483 // Check that the VideoSendStream is off.
6484 EXPECT_FALSE(fake_video_send_stream->IsSending());
6485 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006486 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006487 EXPECT_FALSE(simulcast_streams[0].active);
6488 EXPECT_FALSE(simulcast_streams[1].active);
6489 EXPECT_FALSE(simulcast_streams[2].active);
6490
Niels Möllerff40b142018-04-09 08:49:14 +02006491 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006492}
6493
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006494// Test that if a stream is reconfigured (due to a codec change or other
6495// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006496TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006497 InactiveStreamDoesntStartSendingWhenReconfigured) {
6498 // Set an initial codec list, which will be modified later.
6499 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006500 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6501 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006502 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6503
6504 FakeVideoSendStream* stream = AddSendStream();
6505 EXPECT_TRUE(channel_->SetSend(true));
6506 EXPECT_TRUE(stream->IsSending());
6507
6508 // Get current parameters and change "active" to false.
6509 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6510 ASSERT_EQ(1u, parameters.encodings.size());
6511 ASSERT_TRUE(parameters.encodings[0].active);
6512 parameters.encodings[0].active = false;
6513 EXPECT_EQ(1u, GetFakeSendStreams().size());
6514 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006515 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006516 EXPECT_FALSE(stream->IsSending());
6517
6518 // Reorder the codec list, causing the stream to be reconfigured.
6519 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006520 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6521 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006522 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6523 auto new_streams = GetFakeSendStreams();
6524 // Assert that a new underlying stream was created due to the codec change.
6525 // Otherwise, this test isn't testing what it set out to test.
6526 EXPECT_EQ(1u, GetFakeSendStreams().size());
6527 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6528
6529 // Verify that we still are not sending anything, due to the inactive
6530 // encoding.
6531 EXPECT_FALSE(new_streams[0]->IsSending());
6532}
6533
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006534// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006535TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006536 AddSendStream();
6537 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006538 parameters.codecs.push_back(GetEngineCodec("VP8"));
6539 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006540 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6541
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006542 webrtc::RtpParameters rtp_parameters =
6543 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006544 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006545 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6546 rtp_parameters.codecs[0]);
6547 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6548 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006549}
6550
Florent Castellidacec712018-05-24 16:24:21 +02006551// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6552TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6553 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6554 params.cname = "rtcpcname";
6555 AddSendStream(params);
6556
6557 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6558 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6559}
6560
deadbeeffb2aced2017-01-06 23:05:37 -08006561// Test that RtpParameters for send stream has one encoding and it has
6562// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006563TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006564 AddSendStream();
6565
6566 webrtc::RtpParameters rtp_parameters =
6567 channel_->GetRtpSendParameters(last_ssrc_);
6568 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006569 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006570}
6571
Florent Castelliabe301f2018-06-12 18:33:49 +02006572TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6573 AddSendStream();
6574
6575 webrtc::RtpParameters rtp_parameters =
6576 channel_->GetRtpSendParameters(last_ssrc_);
6577 rtp_parameters.header_extensions.emplace_back();
6578
6579 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6580
6581 webrtc::RTCError result =
6582 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6583 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6584}
6585
Florent Castelli87b3c512018-07-18 16:00:28 +02006586TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6587 AddSendStream();
6588
6589 FakeVideoCapturerWithTaskQueue capturer;
6590 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &capturer));
6591
6592 webrtc::RtpParameters rtp_parameters =
6593 channel_->GetRtpSendParameters(last_ssrc_);
6594 EXPECT_EQ(rtp_parameters.degradation_preference,
6595 webrtc::DegradationPreference::BALANCED);
6596 rtp_parameters.degradation_preference =
6597 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6598
6599 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6600
6601 webrtc::RtpParameters updated_rtp_parameters =
6602 channel_->GetRtpSendParameters(last_ssrc_);
6603 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6604 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6605
6606 // Remove the source since it will be destroyed before the channel
6607 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6608}
6609
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006610// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006611TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006612 AddSendStream();
6613 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006614 parameters.codecs.push_back(GetEngineCodec("VP8"));
6615 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006616 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6617
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006618 webrtc::RtpParameters initial_params =
6619 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006620
6621 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006622 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006623
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006624 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6625 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6626}
6627
6628// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006629TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006630 AddRecvStream();
6631 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006632 parameters.codecs.push_back(GetEngineCodec("VP8"));
6633 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006634 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6635
6636 webrtc::RtpParameters rtp_parameters =
6637 channel_->GetRtpReceiveParameters(last_ssrc_);
6638 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006639 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6640 rtp_parameters.codecs[0]);
6641 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6642 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006643}
6644
johan073ece42016-08-26 02:59:47 -07006645#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006646TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006647#else
eladalonf1841382017-06-12 01:16:46 -07006648TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006649#endif
johan3859c892016-08-05 09:19:25 -07006650 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006651 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006652 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006653 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006654 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006655 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006656 parameters.codecs.push_back(kH264sprop2);
6657 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6658
6659 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6660 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6661 webrtc::RtpParameters rtp_parameters =
6662 channel_->GetRtpReceiveParameters(last_ssrc_);
6663 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6664 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6665 ASSERT_EQ(2u, cfg.decoders.size());
6666 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006667 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006668 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006669 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6670 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006671 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006672
6673 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006674 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006675 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006676 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6677 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006678 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006679}
6680
sakal1fd95952016-06-22 00:46:15 -07006681// Test that RtpParameters for receive stream has one encoding and it has
6682// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006683TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006684 AddRecvStream();
6685
6686 webrtc::RtpParameters rtp_parameters =
6687 channel_->GetRtpReceiveParameters(last_ssrc_);
6688 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006689 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07006690}
6691
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006692// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006693TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006694 AddRecvStream();
6695 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006696 parameters.codecs.push_back(GetEngineCodec("VP8"));
6697 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006698 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6699
6700 webrtc::RtpParameters initial_params =
6701 channel_->GetRtpReceiveParameters(last_ssrc_);
6702
6703 // We should be able to set the params we just got.
6704 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
6705
6706 // ... And this shouldn't change the params returned by
6707 // GetRtpReceiveParameters.
6708 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006709}
6710
deadbeef3bc15102017-04-20 19:25:07 -07006711// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
6712// aren't signaled. It should always return an empty "RtpEncodingParameters",
6713// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07006714TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07006715 // Call necessary methods to configure receiving a default stream as
6716 // soon as it arrives.
6717 cricket::VideoRecvParameters parameters;
6718 parameters.codecs.push_back(GetEngineCodec("VP8"));
6719 parameters.codecs.push_back(GetEngineCodec("VP9"));
6720 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6721
6722 // Call GetRtpReceiveParameters before configured to receive an unsignaled
6723 // stream. Should return nothing.
6724 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
6725
6726 // Set a sink for an unsignaled stream.
6727 cricket::FakeVideoRenderer renderer;
6728 // Value of "0" means "unsignaled stream".
6729 EXPECT_TRUE(channel_->SetSink(0, &renderer));
6730
6731 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
6732 // in this method means "unsignaled stream".
6733 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
6734 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6735 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6736
6737 // Receive VP8 packet.
6738 uint8_t data[kMinRtpPacketLen];
6739 cricket::RtpHeader rtpHeader;
6740 rtpHeader.payload_type = GetEngineCodec("VP8").id;
6741 rtpHeader.seq_num = rtpHeader.timestamp = 0;
6742 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
6743 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
6744 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Niels Möllere6933812018-11-05 13:01:41 +01006745 channel_->OnPacketReceived(&packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07006746
6747 // The |ssrc| member should still be unset.
6748 rtp_parameters = channel_->GetRtpReceiveParameters(0);
6749 ASSERT_EQ(1u, rtp_parameters.encodings.size());
6750 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
6751}
6752
eladalonf1841382017-06-12 01:16:46 -07006753void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02006754 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006755 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02006756
6757 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02006758 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02006759 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02006760 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02006761
6762 if (receiver_first) {
6763 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6764 std::vector<FakeVideoReceiveStream*> receive_streams =
6765 fake_call_->GetVideoReceiveStreams();
6766 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02006767 // Default local SSRC when we have no sender.
6768 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6769 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006770 }
6771 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
6772 if (!receiver_first)
6773 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
6774 std::vector<FakeVideoReceiveStream*> receive_streams =
6775 fake_call_->GetVideoReceiveStreams();
6776 ASSERT_EQ(1u, receive_streams.size());
6777 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02006778
6779 // Removing first sender should fall back to another (in this case the second)
6780 // local send stream's SSRC.
6781 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
6782 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006783 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006784 ASSERT_EQ(1u, receive_streams.size());
6785 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
6786
6787 // Removing the last sender should fall back to default local SSRC.
6788 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02006789 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02006790 ASSERT_EQ(1u, receive_streams.size());
6791 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
6792 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02006793}
6794
eladalonf1841382017-06-12 01:16:46 -07006795TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02006796 TestReceiverLocalSsrcConfiguration(false);
6797}
6798
eladalonf1841382017-06-12 01:16:46 -07006799TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02006800 TestReceiverLocalSsrcConfiguration(true);
6801}
6802
eladalonf1841382017-06-12 01:16:46 -07006803class WebRtcVideoChannelSimulcastTest : public testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006804 public:
eladalonf1841382017-06-12 01:16:46 -07006805 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01006806 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006807 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
6808 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006809 mock_rate_allocator_factory_(
6810 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02006811 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006812 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02006813 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006814 decoder_factory_),
6815 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
6816 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07006817 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006818
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00006819 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02006820 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01006821 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
6822 VideoOptions(),
6823 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08006824 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006825 last_ssrc_ = 123;
6826 }
6827
6828 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006829 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07006830 int capture_width,
6831 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006832 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08006833 size_t expected_num_streams,
6834 bool screenshare,
6835 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006836 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006837 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08006838 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02006839 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006840
Peter Boström0c4e06b2015-10-07 12:23:21 +02006841 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07006842 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006843 ssrcs.resize(num_configured_streams);
6844
sprangf24a0642017-02-28 13:23:26 -08006845 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006846 // Send a full-size frame to trigger a stream reconfiguration to use all
6847 // expected simulcast layers.
Tommi85959932018-02-07 19:26:06 +01006848 FakeVideoCapturerWithTaskQueue capturer;
sprangf24a0642017-02-28 13:23:26 -08006849 VideoOptions options;
6850 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01006851 options.is_screencast = screenshare;
Yves Gerey665174f2018-06-19 15:03:05 +02006852 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), &options, &capturer));
sprangf24a0642017-02-28 13:23:26 -08006853 // Fetch the latest stream since SetVideoSend() may recreate it if the
6854 // screen content setting is changed.
6855 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006856 EXPECT_EQ(cricket::CS_RUNNING, capturer.Start(cricket::VideoFormat(
perkj26752742016-10-24 01:21:16 -07006857 capture_width, capture_height,
pbos@webrtc.org86196c42015-02-16 21:02:00 +00006858 cricket::VideoFormat::FpsToInterval(30),
6859 cricket::FOURCC_I420)));
6860 channel_->SetSend(true);
6861 EXPECT_TRUE(capturer.CaptureFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006862
Zach Stein3ca452b2018-01-18 10:01:24 -08006863 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
6864 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
6865
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006866 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6867 ASSERT_EQ(expected_num_streams, video_streams.size());
6868
sprang429600d2017-01-26 06:12:26 -08006869 std::vector<webrtc::VideoStream> expected_streams;
6870 if (conference_mode) {
6871 expected_streams = GetSimulcastConfig(
6872 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08006873 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02006874 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08006875 if (screenshare) {
6876 for (const webrtc::VideoStream& stream : expected_streams) {
6877 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00006878 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
6879 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08006880 }
6881 }
sprang429600d2017-01-26 06:12:26 -08006882 } else {
6883 webrtc::VideoStream stream;
6884 stream.width = capture_width;
6885 stream.height = capture_height;
6886 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01006887 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08006888 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006889 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08006890 stream.max_qp = kDefaultQpMax;
6891 expected_streams.push_back(stream);
6892 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006893
6894 ASSERT_EQ(expected_streams.size(), video_streams.size());
6895
6896 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006897 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006898 for (size_t i = 0; i < num_streams; ++i) {
6899 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
6900 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
6901
6902 EXPECT_GT(video_streams[i].max_framerate, 0);
6903 EXPECT_EQ(expected_streams[i].max_framerate,
6904 video_streams[i].max_framerate);
6905
6906 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
6907 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
6908 video_streams[i].min_bitrate_bps);
6909
6910 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
6911 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
6912 video_streams[i].target_bitrate_bps);
6913
6914 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
6915 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
6916 video_streams[i].max_bitrate_bps);
6917
6918 EXPECT_GT(video_streams[i].max_qp, 0);
6919 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
6920
Sergey Silkina796a7e2018-03-01 15:11:29 +01006921 EXPECT_EQ(conference_mode,
6922 expected_streams[i].num_temporal_layers.has_value());
6923
6924 if (conference_mode) {
6925 EXPECT_EQ(expected_streams[i].num_temporal_layers,
6926 video_streams[i].num_temporal_layers);
6927 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006928
6929 if (i == num_streams - 1) {
6930 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
6931 } else {
6932 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
6933 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006934 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00006935
Niels Möllerff40b142018-04-09 08:49:14 +02006936 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006937 }
6938
6939 FakeVideoSendStream* AddSendStream() {
6940 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
6941 }
6942
6943 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006944 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006945 EXPECT_TRUE(channel_->AddSendStream(sp));
6946 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006947 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006948 EXPECT_EQ(num_streams + 1, streams.size());
6949 return streams[streams.size() - 1];
6950 }
6951
6952 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006953 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006954 }
6955
6956 FakeVideoReceiveStream* AddRecvStream() {
6957 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
6958 }
6959
6960 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02006961 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006962 EXPECT_TRUE(channel_->AddRecvStream(sp));
6963 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006964 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006965 EXPECT_EQ(num_streams + 1, streams.size());
6966 return streams[streams.size() - 1];
6967 }
6968
skvlad11a9cbf2016-10-07 11:53:05 -07006969 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02006970 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02006971 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
6972 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08006973 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07006974 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08006975 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02006976 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006977};
6978
eladalonf1841382017-06-12 01:16:46 -07006979TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006980 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
6981 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006982}
6983
eladalonf1841382017-06-12 01:16:46 -07006984TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08006985 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
6986 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006987}
6988
6989// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07006990TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08006991 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
6992 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00006993}
sprang429600d2017-01-26 06:12:26 -08006994
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006995TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02006996 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
6997 false);
6998}
6999
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007000TEST_F(WebRtcVideoChannelSimulcastTest,
7001 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007002 webrtc::test::ScopedFieldTrials field_trials(
7003 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007004 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7005 true);
7006}
7007
eladalonf1841382017-06-12 01:16:46 -07007008TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007009 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7010 true);
7011}
7012
eladalonf1841382017-06-12 01:16:46 -07007013TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007014 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007015 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7016 false);
7017}
7018
Yves Gereyb6a89422018-10-08 10:08:32 +02007019class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007020 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02007021 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007022 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7023 }
7024 rtc::ScopedFakeClock fake_clock_;
7025};
7026
Yves Gereyb6a89422018-10-08 10:08:32 +02007027// The fake clock needs to be initialized before the call, and not
7028// destroyed until after all threads spawned by the test have been stopped.
7029// This mixin ensures that.
7030class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7031 public WebRtcVideoChannelBaseTest {};
7032
Jonas Oreland49ac5952018-09-26 16:04:32 +02007033TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7034 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7035 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7036
7037 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7038
7039 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7040 rtc::SetBE32(packet1.data() + 8, kSsrc);
7041 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7042 EXPECT_TRUE(SetDefaultCodec());
7043 EXPECT_TRUE(SetSend(true));
7044 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01007045 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007046
7047 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7048 EXPECT_EQ(1u, sources.size());
7049 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7050 int64_t timestamp1 = sources[0].timestamp_ms();
7051
7052 // a new packet.
7053 int64_t timeDeltaMs = 1;
7054 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01007055 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007056 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7057 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7058
7059 // It only keeps 10s of history.
7060 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7061 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7062 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7063}
7064
7065TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7066 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7067 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7068
7069 uint32_t kCsrc = 4321u;
7070 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7071 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7072
7073 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7074 rtc::SetBE32(packet1.data() + 8, kSsrc);
7075 rtc::SetBE32(packet1.data() + 12, kCsrc);
7076 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7077 EXPECT_TRUE(SetDefaultCodec());
7078 EXPECT_TRUE(SetSend(true));
7079 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller29e13fd2018-12-17 12:35:30 +01007080 channel_->OnPacketReceived(&packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007081
7082 {
7083 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7084 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7085 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7086 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7087 // 1 SSRC and 1 CSRC.
7088 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7089 [](const webrtc::RtpSource& source) {
7090 return source.source_type() ==
7091 webrtc::RtpSourceType::SSRC;
7092 }));
7093 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7094 [](const webrtc::RtpSource& source) {
7095 return source.source_type() ==
7096 webrtc::RtpSourceType::CSRC;
7097 }));
7098 }
7099 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7100
7101 // a new packet with only ssrc (i.e no csrc).
7102 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7103 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7104 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7105 rtc::SetBE32(packet2.data() + 8, kSsrc);
7106
7107 int64_t timeDeltaMs = 1;
7108 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Niels Möller29e13fd2018-12-17 12:35:30 +01007109 channel_->OnPacketReceived(&packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007110
7111 {
7112 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7113 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7114 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7115 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7116 // 1 SSRC and 1 CSRC.
7117 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7118 [](const webrtc::RtpSource& source) {
7119 return source.source_type() ==
7120 webrtc::RtpSourceType::SSRC;
7121 }));
7122 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7123 [](const webrtc::RtpSource& source) {
7124 return source.source_type() ==
7125 webrtc::RtpSourceType::CSRC;
7126 }));
7127 auto ssrcSource = std::find_if(
7128 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7129 return source.source_type() == webrtc::RtpSourceType::SSRC;
7130 });
7131 auto csrcSource = std::find_if(
7132 sources.begin(), sources.end(), [](const webrtc::RtpSource& source) {
7133 return source.source_type() == webrtc::RtpSourceType::CSRC;
7134 });
7135
7136 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7137 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7138 }
7139
7140 // It only keeps 10s of history.
7141 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7142
7143 {
7144 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7145 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7146 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7147 EXPECT_EQ(1, std::count_if(sources.begin(), sources.end(),
7148 [](const webrtc::RtpSource& source) {
7149 return source.source_type() ==
7150 webrtc::RtpSourceType::SSRC;
7151 }));
7152 EXPECT_EQ(0, std::count_if(sources.begin(), sources.end(),
7153 [](const webrtc::RtpSource& source) {
7154 return source.source_type() ==
7155 webrtc::RtpSourceType::CSRC;
7156 }));
7157 }
7158
7159 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7160 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7161 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7162}
7163
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007164} // namespace cricket