blob: 54e76e53e413d565ca6eb7a4cd277e8f79a203cc [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Steve Antone78bcb92017-10-31 09:53:08 -070013#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000014#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000015
Steve Anton2c9ebef2019-01-28 17:27:58 -080016#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010017#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020018#include "absl/strings/match.h"
Steve Anton10542f22019-01-11 09:11:00 -080019#include "api/rtp_parameters.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070020#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080021#include "api/test/mock_video_bitrate_allocator.h"
22#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070023#include "api/test/mock_video_decoder_factory.h"
24#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020025#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010027#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020028#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020029#include "api/video_codecs/builtin_video_decoder_factory.h"
30#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020031#include "api/video_codecs/sdp_video_format.h"
32#include "api/video_codecs/video_decoder_factory.h"
33#include "api/video_codecs/video_encoder.h"
34#include "api/video_codecs/video_encoder_factory.h"
35#include "call/flexfec_receive_stream.h"
36#include "common_video/h264/profile_level_id.h"
37#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010038#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080039#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080040#include "media/base/fake_video_renderer.h"
41#include "media/base/media_constants.h"
42#include "media/base/rtp_utils.h"
43#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020044#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/engine/fake_webrtc_call.h"
46#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020047#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080048#include "media/engine/webrtc_video_engine.h"
49#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020050#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020051#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080052#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020053#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020054#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080055#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020056#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010057#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020058#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000059
Mirko Bonadei6a489f22019-04-09 15:11:12 +020060using ::testing::Field;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010061using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070062using webrtc::RtpExtension;
63
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000064namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000065static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000066
noahricd10a68e2015-07-10 11:27:55 -070067static const uint8_t kRedRtxPayloadType = 125;
68
Niels Möller6557d0c2018-04-11 15:18:34 +020069static const uint32_t kTimeout = 5000U;
70static const uint32_t kDefaultReceiveSsrc = 0;
71static const uint32_t kSsrc = 1234u;
72static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
73static const int kVideoWidth = 640;
74static const int kVideoHeight = 360;
75static const int kFramerate = 30;
76
Peter Boström0c4e06b2015-10-07 12:23:21 +020077static const uint32_t kSsrcs1[] = {1};
78static const uint32_t kSsrcs3[] = {1, 2, 3};
79static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080080static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020081static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080082static const uint32_t kDefaultRecvSsrc = 0;
83
pbos@webrtc.org3c107582014-07-20 15:27:35 +000084static const char kUnsupportedExtensionName[] =
85 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000086
magjed509e4fe2016-11-18 01:34:11 -080087cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
88 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020089 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080090}
91
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000092void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec) {
93 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
94 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
95 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
96 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
97 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
98 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
99 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800100 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
101 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000102 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
103}
104
magjed725e4842016-11-16 00:48:13 -0800105// Return true if any codec in |codecs| is an RTX codec with associated payload
106// type |payload_type|.
107bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
108 int payload_type) {
109 for (const cricket::VideoCodec& codec : codecs) {
110 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200111 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800112 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
113 &associated_payload_type) &&
114 associated_payload_type == payload_type) {
115 return true;
116 }
117 }
118 return false;
119}
120
nisseca5706d2017-09-11 02:32:16 -0700121// TODO(nisse): Duplicated in call.cc.
122const int* FindKeyByValue(const std::map<int, int>& m, int v) {
123 for (const auto& kv : m) {
124 if (kv.second == v)
125 return &kv.first;
126 }
127 return nullptr;
128}
129
Yves Gerey665174f2018-06-19 15:03:05 +0200130bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
131 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700132 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
133 payload_type) != nullptr;
134}
135
136// Check that there's an Rtx payload type for each decoder.
137bool VerifyRtxReceiveAssociations(
138 const webrtc::VideoReceiveStream::Config& config) {
139 for (const auto& decoder : config.decoders) {
140 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
141 return false;
142 }
143 return true;
144}
145
brandtrffc61182016-11-28 06:02:22 -0800146rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700147 int width,
148 int height) {
149 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
150 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800151 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700152 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000153}
154
Shao Changbine62202f2015-04-21 20:24:50 +0800155void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
156 const std::map<int, int>& rtx_types) {
157 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200158 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800159 EXPECT_TRUE(it != rtx_types.end() &&
160 it->second == config.rtp.rtx.payload_type);
161
brandtrb5f2c3f2016-10-04 23:28:39 -0700162 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
163 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800164 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700165 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800166 }
167}
kthelgason2bc68642017-02-07 07:02:22 -0800168
169cricket::MediaConfig GetMediaConfig() {
170 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100171 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800172 return media_config;
173}
nisse26e3abb2017-08-25 04:44:25 -0700174
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200175// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
176int GetMaxDefaultBitrateBps(size_t width, size_t height) {
177 if (width * height <= 320 * 240) {
178 return 600000;
179 } else if (width * height <= 640 * 480) {
180 return 1700000;
181 } else if (width * height <= 960 * 540) {
182 return 2000000;
183 } else {
184 return 2500000;
185 }
186}
187
Niels Möller731a2c22018-07-30 15:08:07 +0200188class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
189 public:
190 MOCK_METHOD2(AddOrUpdateSink,
191 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
192 const rtc::VideoSinkWants& wants));
193 MOCK_METHOD1(RemoveSink,
194 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
195};
196
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000197} // namespace
198
Yves Gerey665174f2018-06-19 15:03:05 +0200199#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200200 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200201 EXPECT_EQ((w), renderer_.width()); \
202 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200203 EXPECT_EQ(0, renderer_.errors());
204
Yves Gerey665174f2018-06-19 15:03:05 +0200205#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200207 EXPECT_EQ((w), (r).width()); \
208 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200209 EXPECT_EQ(0, (r).errors());
210
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000211namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700212class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000213 public:
eladalonf1841382017-06-12 01:16:46 -0700214 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
215 explicit WebRtcVideoEngineTest(const char* field_trials)
stefanc1aeaf02015-10-15 07:26:07 -0700216 : override_field_trials_(field_trials),
skvlad11a9cbf2016-10-07 11:53:05 -0700217 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200218 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
219 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Anders Carlsson67537952018-05-03 11:28:29 +0200220 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200221 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200222 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -0800223 decoder_factory_),
224 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200225 // Ensure fake clock doesn't return 0, which will cause some initializations
226 // fail inside RTP senders.
227 fake_clock_.AdvanceTimeMicros(1);
228 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000229
230 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200231 void AssignDefaultAptRtxTypes();
232 void AssignDefaultCodec();
233
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100234 // Find the index of the codec in the engine with the given name. The codec
235 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100236 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100237
magjed509e4fe2016-11-18 01:34:11 -0800238 // Find the codec in the engine with the given name. The codec must be
239 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100240 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800241
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200242 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000243
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200244 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000245 const std::vector<VideoCodec>& codecs);
246
Elad Alon157540a2019-02-08 23:37:52 +0100247 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100248
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200249 // Has to be the first one, so it is initialized before the call or there is a
250 // race condition in the clock access.
251 rtc::ScopedFakeClock fake_clock_;
stefanc1aeaf02015-10-15 07:26:07 -0700252 webrtc::test::ScopedFieldTrials override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700253 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700254 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000255 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800256 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200257 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
258 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
eladalonf1841382017-06-12 01:16:46 -0700259 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000260 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800261 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000262};
263
eladalonf1841382017-06-12 01:16:46 -0700264TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200265 encoder_factory_->AddSupportedVideoCodecType("VP8");
266 AssignDefaultCodec();
267
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000268 std::vector<VideoCodec> engine_codecs = engine_.codecs();
269 for (size_t i = 0; i < engine_codecs.size(); ++i) {
270 if (engine_codecs[i].name != kRtxCodecName)
271 continue;
272 int associated_payload_type;
273 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000274 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000275 EXPECT_EQ(default_codec_.id, associated_payload_type);
276 return;
277 }
278 FAIL() << "No RTX codec found among default codecs.";
279}
280
eladalonf1841382017-06-12 01:16:46 -0700281TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100282 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000283}
284
eladalonf1841382017-06-12 01:16:46 -0700285TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100286 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000287}
288
eladalonf1841382017-06-12 01:16:46 -0700289TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100290 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700291}
292
eladalonf1841382017-06-12 01:16:46 -0700293TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100294 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
295}
296
297TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
298 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
299}
300
301TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
302 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
303}
304
305TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
306 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
307}
308
309TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
310 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100311}
312
313TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100314 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
315}
316
Elad Alonccb9b752019-02-19 13:01:31 +0100317TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
318 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
319}
320
321TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
322 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700323}
324
philipel1e054862018-10-08 16:13:53 +0200325class WebRtcVideoEngineTestWithGenericDescriptor
326 : public WebRtcVideoEngineTest {
327 public:
328 WebRtcVideoEngineTestWithGenericDescriptor()
329 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
330};
331
Elad Alonccb9b752019-02-19 13:01:31 +0100332TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
333 AdvertiseGenericDescriptor00) {
334 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
335}
336
337TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
338 AdvertiseGenericDescriptor01) {
339 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200340}
341
eladalonf1841382017-06-12 01:16:46 -0700342TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200343 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700344 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200345 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200347 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200349 std::unique_ptr<VideoMediaChannel> channel(
350 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700351 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
352
353 // Add CVO extension.
354 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800355 cricket::VideoSendParameters parameters;
356 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200357 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700358 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200359 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700360
Niels Möller731a2c22018-07-30 15:08:07 +0200361 EXPECT_CALL(
362 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200363 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200364 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700365 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200366 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700367
368 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200369 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700370
371 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200372 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200373 EXPECT_CALL(
374 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200375 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200376 Field(&rtc::VideoSinkWants::rotation_applied, true)));
377
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200378 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700379}
380
eladalonf1841382017-06-12 01:16:46 -0700381TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200382 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800383 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200384 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800385
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200386 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800387
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200388 std::unique_ptr<VideoMediaChannel> channel(
389 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800390 // Add CVO extension.
391 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800392 cricket::VideoSendParameters parameters;
393 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800394 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700395 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800396 EXPECT_TRUE(channel->SetSendParameters(parameters));
397 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
398
Niels Möller731a2c22018-07-30 15:08:07 +0200399 // Set source.
400 EXPECT_CALL(
401 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200402 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200403 Field(&rtc::VideoSinkWants::rotation_applied, false)));
404 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800405}
406
eladalonf1841382017-06-12 01:16:46 -0700407TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200408 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700409
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200410 encoder_factory_->AddSupportedVideoCodecType("VP8");
411 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700412
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200413 std::unique_ptr<VideoMediaChannel> channel(
414 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700415 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
416
417 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200418 EXPECT_CALL(
419 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200420 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200421 Field(&rtc::VideoSinkWants::rotation_applied, true)));
422 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700423
perkjcaafdba2016-03-20 07:34:29 -0700424 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200425 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700426
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700427 // Add CVO extension.
428 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800429 cricket::VideoSendParameters parameters;
430 parameters.codecs.push_back(GetEngineCodec("VP8"));
431 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200432 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700433 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700434 // Also remove the first codec to trigger a codec change as well.
435 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200436 EXPECT_CALL(
437 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200438 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200439 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200440 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700441
442 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200443 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700444
445 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200446 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200447 EXPECT_CALL(
448 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200449 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200450 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200451 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452}
453
eladalonf1841382017-06-12 01:16:46 -0700454TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200455 encoder_factory_->AddSupportedVideoCodecType("VP8");
456
Sebastian Jansson84848f22018-11-16 10:40:36 +0100457 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700458 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000459
460 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
461
462 EXPECT_FALSE(channel->SetSend(true))
463 << "Channel should not start without codecs.";
464 EXPECT_TRUE(channel->SetSend(false))
465 << "Channel should be stoppable even without set codecs.";
466}
467
eladalonf1841382017-06-12 01:16:46 -0700468TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200469 encoder_factory_->AddSupportedVideoCodecType("VP8");
470
Sebastian Jansson84848f22018-11-16 10:40:36 +0100471 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700472 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000473 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
474 VideoMediaInfo info;
475 channel->GetStats(&info);
476}
477
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200478TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200479 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000480
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200481 std::unique_ptr<VideoMediaChannel> channel(
482 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800483 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000484
485 EXPECT_TRUE(
486 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200487 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000488 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100489 webrtc::test::FrameForwarder frame_forwarder;
490 cricket::FakeFrameSource frame_source(1280, 720,
491 rtc::kNumMicrosecsPerSec / 30);
492 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
493 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100494 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200495 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
496 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000497 kTimeout);
498
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200499 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100500 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000501
502 // Setting codecs of the same type should not reallocate any encoders
503 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800504 cricket::VideoSendParameters parameters;
505 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200506 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200507 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000508
509 // Remove stream previously added to free the external encoder instance.
510 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200511 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000512}
513
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200514// Test that when an encoder factory supports H264, we add an RTX
515// codec for it.
516// TODO(deadbeef): This test should be updated if/when we start
517// adding RTX codecs for unrecognized codec names.
518TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800519 using webrtc::H264::ProfileLevelIdToString;
520 using webrtc::H264::ProfileLevelId;
521 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200522 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
523 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800524 *ProfileLevelIdToString(
525 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200526 webrtc::SdpVideoFormat h264_constrained_high("H264");
527 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800528 *ProfileLevelIdToString(
529 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200530 webrtc::SdpVideoFormat h264_high("H264");
531 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800532 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
533
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200534 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
535 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
536 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700537
magjed725e4842016-11-16 00:48:13 -0800538 // First figure out what payload types the test codecs got assigned.
539 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800540 // Now search for RTX codecs for them. Expect that they all have associated
541 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800542 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200543 codecs,
544 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
545 ->id));
magjed725e4842016-11-16 00:48:13 -0800546 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200547 codecs,
548 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
549 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800550 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200551 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700552}
553
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100554#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700555TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200556 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100557
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200558 std::unique_ptr<VideoMediaChannel> channel(
559 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100560
561 EXPECT_TRUE(
562 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
563}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100564#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100565
eladalonf1841382017-06-12 01:16:46 -0700566TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200567 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100568 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200569 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200570 std::unique_ptr<VideoMediaChannel> channel(
571 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700572
573 EXPECT_TRUE(
574 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
575
Niels Möllerd0f0f682019-01-14 09:09:53 +0100576 webrtc::test::FrameForwarder frame_forwarder;
577 cricket::FakeFrameSource frame_source(1280, 720,
578 rtc::kNumMicrosecsPerSec / 60);
579 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700580 channel->SetSend(true);
581
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200582 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700583
Niels Möllerd0f0f682019-01-14 09:09:53 +0100584 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700585 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700586 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100587 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700588 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700589 int64_t interval = timestamp - last_timestamp;
590
591 // Precision changes from nanosecond to millisecond.
592 // Allow error to be no more than 1.
593 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
594
595 last_timestamp = timestamp;
596 }
597
Niels Möllerd0f0f682019-01-14 09:09:53 +0100598 frame_forwarder.IncomingCapturedFrame(
599 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
600 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700601 last_timestamp = stream->GetLastTimestamp();
602 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100603 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
604 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
605 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700606 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700607 int64_t interval = timestamp - last_timestamp;
608
609 // Precision changes from nanosecond to millisecond.
610 // Allow error to be no more than 1.
611 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
612
613 last_timestamp = timestamp;
614 }
615
616 // Remove stream previously added to free the external encoder instance.
617 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
618}
619
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200620void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
621 std::vector<VideoCodec> engine_codecs = engine_.codecs();
622 RTC_DCHECK(!engine_codecs.empty());
623 for (const cricket::VideoCodec& codec : engine_codecs) {
624 if (codec.name == "rtx") {
625 int associated_payload_type;
626 if (codec.GetParam(kCodecParamAssociatedPayloadType,
627 &associated_payload_type)) {
628 default_apt_rtx_types_[associated_payload_type] = codec.id;
629 }
630 }
631 }
632}
633
634void WebRtcVideoEngineTest::AssignDefaultCodec() {
635 std::vector<VideoCodec> engine_codecs = engine_.codecs();
636 RTC_DCHECK(!engine_codecs.empty());
637 bool codec_set = false;
638 for (const cricket::VideoCodec& codec : engine_codecs) {
639 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
640 codec.name != "ulpfec") {
641 default_codec_ = codec;
642 codec_set = true;
643 }
644 }
645
646 RTC_DCHECK(codec_set);
647}
648
Oleh Prypina40f8242017-12-21 13:32:23 +0100649size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
650 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100651 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
652 for (size_t i = 0; i < codecs.size(); ++i) {
653 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200654 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200655 continue;
656 // The tests only use H264 Constrained Baseline. Make sure we don't return
657 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200658 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200659 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200660 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
661 if (profile_level_id->profile !=
662 webrtc::H264::kProfileConstrainedBaseline) {
663 continue;
664 }
665 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 return i;
magjed509e4fe2016-11-18 01:34:11 -0800667 }
668 // This point should never be reached.
669 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100670 return -1;
671}
672
673cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
674 const std::string& name) const {
675 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800676}
677
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200678VideoMediaChannel*
679WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100680 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700681 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200682 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800683 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200684 for (const webrtc::SdpVideoFormat& format :
685 encoder_factory_->GetSupportedFormats()) {
686 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800687 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200688 parameters.codecs.push_back(engine_codec);
689 }
690 }
magjed509e4fe2016-11-18 01:34:11 -0800691
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200692 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000693
694 return channel;
695}
696
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200697VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000698 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100699 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700700 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200701 cricket::VideoRecvParameters parameters;
702 parameters.codecs = codecs;
703 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000704
705 return channel;
706}
707
Elad Alon157540a2019-02-08 23:37:52 +0100708void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
709 bool supported) const {
710 const RtpCapabilities capabilities = engine_.GetCapabilities();
711 if (supported) {
712 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200713 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100714 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200715 EXPECT_THAT(capabilities.header_extensions,
716 ::testing::Each(::testing::Field(&RtpExtension::uri,
717 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100718 }
719}
720
eladalonf1841382017-06-12 01:16:46 -0700721TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200722 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000723
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200724 std::unique_ptr<VideoMediaChannel> channel(
725 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000726
Peter Boström0c4e06b2015-10-07 12:23:21 +0200727 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000728
Yves Gerey665174f2018-06-19 15:03:05 +0200729 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000730 EXPECT_TRUE(channel->SetSend(true));
731
Niels Möller805a27e2019-01-21 12:21:27 +0100732 webrtc::test::FrameForwarder frame_forwarder;
733 cricket::FakeFrameSource frame_source(1280, 720,
734 rtc::kNumMicrosecsPerSec / 60);
735 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
736 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000737
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200738 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000739
740 // Verify that encoders are configured for simulcast through adapter
741 // (increasing resolution and only configured to send one stream each).
742 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200743 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
744 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000745 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200746 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000747 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
748 EXPECT_GT(codec_settings.width, prev_width);
749 prev_width = codec_settings.width;
750 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000751
Niels Möllerff40b142018-04-09 08:49:14 +0200752 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000753
754 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200755 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000756}
757
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200758TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
759 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200760 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000761
Niels Möllerd0f0f682019-01-14 09:09:53 +0100762 // Frame source.
763 webrtc::test::FrameForwarder frame_forwarder;
764 cricket::FakeFrameSource frame_source(1280, 720,
765 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200766
Sebastian Jansson84848f22018-11-16 10:40:36 +0100767 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700768 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200769 cricket::VideoSendParameters parameters;
770 parameters.codecs.push_back(GetEngineCodec("H264"));
771 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000772
773 EXPECT_TRUE(
774 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100775 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200776 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100777 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200778
779 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000780
Anders Carlsson67537952018-05-03 11:28:29 +0200781 cricket::VideoSendParameters new_parameters;
782 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
783 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200784
785 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100786 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200787
Anders Carlsson8a150d92018-05-14 12:40:04 +0200788 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000789}
790
eladalonf1841382017-06-12 01:16:46 -0700791TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000792 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200793 encoder_factory_->AddSupportedVideoCodecType("VP8");
794 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000795
Sebastian Jansson84848f22018-11-16 10:40:36 +0100796 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700797 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800798 cricket::VideoSendParameters parameters;
799 parameters.codecs.push_back(GetEngineCodec("VP8"));
800 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000801
Peter Boström0c4e06b2015-10-07 12:23:21 +0200802 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000803
Yves Gerey665174f2018-06-19 15:03:05 +0200804 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000805 EXPECT_TRUE(channel->SetSend(true));
806
807 // Send a fake frame, or else the media engine will configure the simulcast
808 // encoder adapter at a low-enough size that it'll only create a single
809 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100810 webrtc::test::FrameForwarder frame_forwarder;
811 cricket::FakeFrameSource frame_source(1280, 720,
812 rtc::kNumMicrosecsPerSec / 30);
813 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
814 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000815
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200816 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
817 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000818 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200819 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
821 channel.reset();
822 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200823 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824}
825
eladalonf1841382017-06-12 01:16:46 -0700826TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000827 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200828 encoder_factory_->AddSupportedVideoCodecType("VP8");
829 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000830
Sebastian Jansson84848f22018-11-16 10:40:36 +0100831 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700832 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
magjed509e4fe2016-11-18 01:34:11 -0800833 cricket::VideoSendParameters parameters;
834 parameters.codecs.push_back(GetEngineCodec("H264"));
835 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
837 EXPECT_TRUE(
838 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100839
840 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100841 webrtc::test::FrameForwarder frame_forwarder;
842 cricket::FakeFrameSource frame_source(1280, 720,
843 rtc::kNumMicrosecsPerSec / 30);
844 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
845 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200846 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
847 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200848 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200850 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000851
852 channel.reset();
853 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000855}
856
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200857TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
858 webrtc::test::ScopedFieldTrials override_field_trials_(
859 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200860 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700861
Sebastian Jansson84848f22018-11-16 10:40:36 +0100862 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -0700863 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Anders Carlsson67537952018-05-03 11:28:29 +0200864 cricket::VideoSendParameters parameters;
865 parameters.codecs.push_back(GetEngineCodec("H264"));
866 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700867
Peter Boström0c4e06b2015-10-07 12:23:21 +0200868 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700869 EXPECT_TRUE(
870 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100871
872 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100873 webrtc::test::FrameForwarder frame_forwarder;
874 cricket::FakeFrameSource frame_source(1280, 720,
875 rtc::kNumMicrosecsPerSec / 30);
876 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
877 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100878
Niels Möller4db138e2018-04-19 09:04:13 +0200879 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200880 ASSERT_EQ(1u, encoder_factory_->encoders().size());
881 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
882 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700883 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200884 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200885 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700886}
887
brandtrffc61182016-11-28 06:02:22 -0800888// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700889// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800890//
891// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700892TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800893 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200894 encoder_factory_->AddSupportedVideoCodecType("VP8");
895
Steve Anton2c9ebef2019-01-28 17:27:58 -0800896 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800897
898 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800899 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800900
901 // FlexFEC is active with field trial.
902 webrtc::test::ScopedFieldTrials override_field_trials_(
brandtr340e3fd2017-02-28 15:43:10 -0800903 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800904 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800905}
906
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200907// Test that codecs are added in the order they are reported from the factory.
908TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
909 encoder_factory_->AddSupportedVideoCodecType("VP8");
910 const char* kFakeCodecName = "FakeCodec";
911 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000912
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200913 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100914 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200915 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
916 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000917}
918
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200919// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800920// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200921TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100922 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
923 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100924
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100925 // Set up external encoder factory with first codec, and initialize engine.
926 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
927
brandtrffc61182016-11-28 06:02:22 -0800928 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800929
930 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100931 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800932 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200933 // The codec itself and RTX should have been added.
934 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100935
936 // Check that both fake codecs are present and that the second fake codec
937 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100938 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
939 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100940 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800941}
942
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200943TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
944 const char* kFakeCodecName = "FakeCodec";
945 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
946
947 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
948 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
949}
950
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200951TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
952 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200953 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200954 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800955 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000956
kwiberg686a8ef2016-02-26 03:00:35 -0800957 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200958 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000959
960 EXPECT_TRUE(
961 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200962 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000963
964 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200965 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200966 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000967
968 // Remove stream previously added to free the external decoder instance.
969 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200970 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000971}
972
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200973// Verifies that we can set up decoders.
974TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000975 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
976 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
977 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
978 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200979 encoder_factory_->AddSupportedVideoCodecType("H264");
Anders Carlsson67537952018-05-03 11:28:29 +0200980 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000981 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -0800982 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000983
kwiberg686a8ef2016-02-26 03:00:35 -0800984 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200985 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000986
987 EXPECT_TRUE(
988 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200989 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000990}
991
Jonas Oreland49ac5952018-09-26 16:04:32 +0200992// Tests when GetSources is called with non-existing ssrc, it will return an
993// empty list of RtpSource without crashing.
994TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
995 // Setup an recv stream with |kSsrc|.
996 encoder_factory_->AddSupportedVideoCodecType("VP8");
997 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
998 cricket::VideoRecvParameters parameters;
999 parameters.codecs.push_back(GetEngineCodec("VP8"));
1000 std::unique_ptr<VideoMediaChannel> channel(
1001 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1002
1003 EXPECT_TRUE(
1004 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1005
1006 // Call GetSources with |kSsrc + 1| which doesn't exist.
1007 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1008 EXPECT_EQ(0u, sources.size());
1009}
1010
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001011TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1012 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1013 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001014 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory> rate_allocator_factory;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001015 WebRtcVideoEngine engine(std::move(encoder_factory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001016 std::move(decoder_factory),
1017 std::move(rate_allocator_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001018 EXPECT_EQ(0u, engine.codecs().size());
1019}
1020
1021TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1022 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001023 webrtc::MockVideoEncoderFactory* encoder_factory =
1024 new webrtc::MockVideoEncoderFactory();
1025 webrtc::MockVideoDecoderFactory* decoder_factory =
1026 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001027 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1028 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001029 WebRtcVideoEngine engine(
1030 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001031 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1032 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1033 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001034 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1035 EXPECT_EQ(0u, engine.codecs().size());
1036 EXPECT_CALL(*encoder_factory, Die());
1037 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001038 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001039}
1040
1041// Test full behavior in the video engine when video codec factories of the new
1042// type are injected supporting the single codec Vp8. Check the returned codecs
1043// from the engine and that we will create a Vp8 encoder and decoder using the
1044// new factories.
1045TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1046 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001047 webrtc::MockVideoEncoderFactory* encoder_factory =
1048 new webrtc::MockVideoEncoderFactory();
1049 webrtc::MockVideoDecoderFactory* decoder_factory =
1050 new webrtc::MockVideoDecoderFactory();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001051 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1052 new webrtc::MockVideoBitrateAllocatorFactory();
1053 EXPECT_CALL(*rate_allocator_factory,
1054 CreateVideoBitrateAllocatorProxy(Field(
1055 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001056 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 WebRtcVideoEngine engine(
1058 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001059 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1060 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1061 rate_allocator_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001062 const webrtc::SdpVideoFormat vp8_format("VP8");
1063 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1064 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001065 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001066
1067 // Verify the codecs from the engine.
1068 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001069 // Verify default codecs has been added correctly.
1070 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001071 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001072
1073 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001074 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001075 int vp8_associated_payload;
1076 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1077 &vp8_associated_payload));
1078 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1079
1080 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1081
1082 // RTX codec for RED.
1083 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1084 int red_associated_payload;
1085 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1086 &red_associated_payload));
1087 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1088
1089 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1090
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 int associated_payload_type;
1092 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1093 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1094 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1095 // Verify default parameters has been added to the VP8 codec.
1096 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0));
1097
1098 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001099 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1100 codec_info.is_hardware_accelerated = false;
1101 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001102 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001103 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001104 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001105 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001106 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001107 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001108 .WillOnce(
1109 ::testing::DoAll(::testing::InvokeWithoutArgs(
1110 [&encoder_created]() { encoder_created.Set(); }),
1111 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001112
1113 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001114 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001115 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001116 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001117
1118 // Create a call.
1119 webrtc::RtcEventLogNullImpl event_log;
1120 std::unique_ptr<webrtc::Call> call(
1121 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1122
1123 // Create send channel.
1124 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001125 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001126 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127 cricket::VideoSendParameters send_parameters;
1128 send_parameters.codecs.push_back(engine_codecs.at(0));
1129 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1130 send_channel->OnReadyToSend(true);
1131 EXPECT_TRUE(
1132 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1133 EXPECT_TRUE(send_channel->SetSend(true));
1134
Niels Möller4db138e2018-04-19 09:04:13 +02001135 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001136 webrtc::test::FrameForwarder frame_forwarder;
1137 cricket::FakeFrameSource frame_source(1280, 720,
1138 rtc::kNumMicrosecsPerSec / 30);
1139 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001140 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001141 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001142 encoder_created.Wait(kTimeout);
1143
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001144 // Create recv channel.
1145 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001146 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001147 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001148 cricket::VideoRecvParameters recv_parameters;
1149 recv_parameters.codecs.push_back(engine_codecs.at(0));
1150 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1151 EXPECT_TRUE(recv_channel->AddRecvStream(
1152 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1153
1154 // Remove streams previously added to free the encoder and decoder instance.
1155 EXPECT_CALL(*encoder_factory, Die());
1156 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001157 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001158 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1159 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1160}
1161
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001162// Test behavior when decoder factory fails to create a decoder (returns null).
1163TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1164 // |engine| take ownership of the factories.
1165 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001166 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001167 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001168 new webrtc::MockVideoDecoderFactory();
1169 webrtc::MockVideoBitrateAllocatorFactory* rate_allocator_factory =
1170 new webrtc::MockVideoBitrateAllocatorFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001171 WebRtcVideoEngine engine(
1172 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001173 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)),
1174 (std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
1175 rate_allocator_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001176 const webrtc::SdpVideoFormat vp8_format("VP8");
1177 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1178 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001179 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001180
1181 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001182 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1183 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001184
1185 // Create a call.
1186 webrtc::RtcEventLogNullImpl event_log;
1187 std::unique_ptr<webrtc::Call> call(
1188 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1189
1190 // Create recv channel.
1191 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001192 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07001193 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001194 cricket::VideoRecvParameters recv_parameters;
1195 recv_parameters.codecs.push_back(engine.codecs().front());
1196 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1197 EXPECT_TRUE(recv_channel->AddRecvStream(
1198 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1199
1200 // Remove streams previously added to free the encoder and decoder instance.
1201 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1202}
1203
eladalonf1841382017-06-12 01:16:46 -07001204TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001205 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001206 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001207 std::unique_ptr<VideoMediaChannel> channel(
1208 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001209 ASSERT_TRUE(
1210 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1211 cricket::VideoCodec codec = GetEngineCodec("VP8");
1212 cricket::VideoSendParameters parameters;
1213 parameters.codecs.push_back(codec);
1214 channel->OnReadyToSend(true);
1215 channel->SetSend(true);
1216 ASSERT_TRUE(channel->SetSendParameters(parameters));
1217
Niels Möller805a27e2019-01-21 12:21:27 +01001218 webrtc::test::FrameForwarder frame_forwarder;
1219 cricket::FakeFrameSource frame_source(1280, 720,
1220 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001221 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001222 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001223
Niels Möller805a27e2019-01-21 12:21:27 +01001224 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001225 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001226 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001227 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001228
Niels Möller805a27e2019-01-21 12:21:27 +01001229 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1230 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001231 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001232 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001233
1234 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001235 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1236 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001237 // Change to screen content, recreate encoder. For the simulcast encoder
1238 // adapter case, this will result in two calls since InitEncode triggers a
1239 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001240 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001241 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001242 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001243
Niels Möller805a27e2019-01-21 12:21:27 +01001244 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1245 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001246 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001247 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001248
1249 options.is_screencast.emplace(false);
1250 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001251 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001252 // Change back to regular video content, update encoder. Also change
1253 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001254 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001255 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001256 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001257 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001258
1259 // Remove stream previously added to free the external encoder instance.
1260 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001261 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001262}
1263
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001264class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001265 protected:
1266 WebRtcVideoChannelBaseTest()
Jonas Oreland49ac5952018-09-26 16:04:32 +02001267 : engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001268 webrtc::CreateBuiltinVideoDecoderFactory(),
1269 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001270
1271 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001272 // One testcase calls SetUp in a loop, only create call_ once.
1273 if (!call_) {
1274 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1275 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001276 cricket::MediaConfig media_config;
1277 // Disabling cpu overuse detection actually disables quality scaling too; it
1278 // implies DegradationPreference kMaintainResolution. Automatic scaling
1279 // needs to be disabled, otherwise, tests which check the size of received
1280 // frames become flaky.
1281 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001282 channel_.reset(
1283 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1284 call_.get(), media_config, cricket::VideoOptions(),
1285 webrtc::CryptoOptions())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001286 channel_->OnReadyToSend(true);
1287 EXPECT_TRUE(channel_.get() != NULL);
1288 network_interface_.SetDestination(channel_.get());
Anton Sukhanov98a462c2018-10-17 13:15:42 -07001289 channel_->SetInterface(&network_interface_, /*media_transport=*/nullptr);
Niels Möller6557d0c2018-04-11 15:18:34 +02001290 cricket::VideoRecvParameters parameters;
1291 parameters.codecs = engine_.codecs();
1292 channel_->SetRecvParameters(parameters);
1293 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001294 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1295 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1296 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1297 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001298 }
1299
1300 // Utility method to setup an additional stream to send and receive video.
1301 // Used to test send and recv between two streams.
1302 void SetUpSecondStream() {
1303 SetUpSecondStreamWithNoRecv();
1304 // Setup recv for second stream.
1305 EXPECT_TRUE(channel_->AddRecvStream(
1306 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1307 // Make the second renderer available for use by a new stream.
1308 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1309 }
1310 // Setup an additional stream just to send video. Defer add recv stream.
1311 // This is required if you want to test unsignalled recv of video rtp packets.
1312 void SetUpSecondStreamWithNoRecv() {
1313 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001314 EXPECT_TRUE(
1315 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001317 EXPECT_FALSE(
1318 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001319 EXPECT_TRUE(channel_->AddSendStream(
1320 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1321 // We dont add recv for the second stream.
1322
1323 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001324 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001325 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001326 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001327 }
Yves Gerey665174f2018-06-19 15:03:05 +02001328 virtual void TearDown() { channel_.reset(); }
1329 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001330
1331 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001332 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1333 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001334
1335 bool sending = channel_->sending();
1336 bool success = SetSend(false);
1337 if (success) {
1338 cricket::VideoSendParameters parameters;
1339 parameters.codecs.push_back(codec);
1340 success = channel_->SetSendParameters(parameters);
1341 }
1342 if (success) {
1343 success = SetSend(sending);
1344 }
1345 return success;
1346 }
Yves Gerey665174f2018-06-19 15:03:05 +02001347 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001348 void SendFrame() {
1349 if (frame_forwarder_2_) {
1350 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001351 }
Niels Möller805a27e2019-01-21 12:21:27 +01001352 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001353 }
1354 bool WaitAndSendFrame(int wait_ms) {
1355 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001356 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001357 return ret;
1358 }
Yves Gerey665174f2018-06-19 15:03:05 +02001359 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001360 int NumRtpBytes(uint32_t ssrc) {
1361 return network_interface_.NumRtpBytes(ssrc);
1362 }
Yves Gerey665174f2018-06-19 15:03:05 +02001363 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001364 int NumRtpPackets(uint32_t ssrc) {
1365 return network_interface_.NumRtpPackets(ssrc);
1366 }
Yves Gerey665174f2018-06-19 15:03:05 +02001367 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001368 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1369 return network_interface_.GetRtpPacket(index);
1370 }
1371 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001372 webrtc::RTPHeader header;
1373 EXPECT_TRUE(ParseRtpPacket(p, &header));
1374 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001375 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001376
Niels Möller6557d0c2018-04-11 15:18:34 +02001377 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001378 webrtc::RTPHeader* header) {
1379 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1380 webrtc::RtpHeaderParser::Create());
1381 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001382 }
1383
1384 // Tests that we can send and receive frames.
1385 void SendAndReceive(const cricket::VideoCodec& codec) {
1386 EXPECT_TRUE(SetOneCodec(codec));
1387 EXPECT_TRUE(SetSend(true));
1388 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1389 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001390 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1392 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1393 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1394 }
1395
1396 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001397 int duration_sec,
1398 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001399 EXPECT_TRUE(SetOneCodec(codec));
1400 EXPECT_TRUE(SetSend(true));
1401 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1402 EXPECT_EQ(0, renderer_.num_rendered_frames());
1403 for (int i = 0; i < duration_sec; ++i) {
1404 for (int frame = 1; frame <= fps; ++frame) {
1405 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1406 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1407 }
1408 }
1409 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1410 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1411 }
1412
Niels Möller6557d0c2018-04-11 15:18:34 +02001413 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1414 cricket::VideoMediaInfo info;
1415 EXPECT_TRUE(channel_->GetStats(&info));
1416 return info.senders[i];
1417 }
1418
1419 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1420 cricket::VideoMediaInfo info;
1421 EXPECT_TRUE(channel_->GetStats(&info));
1422 return info.receivers[i];
1423 }
1424
1425 // Two streams one channel tests.
1426
1427 // Tests that we can send and receive frames.
1428 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1429 SetUpSecondStream();
1430 // Test sending and receiving on first stream.
1431 SendAndReceive(codec);
1432 // Test sending and receiving on second stream.
1433 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1434 EXPECT_GT(NumRtpPackets(), 0);
1435 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1436 }
1437
1438 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1439 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001440 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001441 return engine_codec;
1442 }
1443 // This point should never be reached.
1444 ADD_FAILURE() << "Unrecognized codec name: " << name;
1445 return cricket::VideoCodec();
1446 }
1447
1448 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1449
1450 cricket::StreamParams DefaultSendStreamParams() {
1451 return cricket::StreamParams::CreateLegacy(kSsrc);
1452 }
1453
1454 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001455 std::unique_ptr<webrtc::Call> call_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001456 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001457
1458 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1459 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1460 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1461
Niels Möller6557d0c2018-04-11 15:18:34 +02001462 std::unique_ptr<WebRtcVideoChannel> channel_;
1463 cricket::FakeNetworkInterface network_interface_;
1464 cricket::FakeVideoRenderer renderer_;
1465
1466 // Used by test cases where 2 streams are run on the same channel.
1467 cricket::FakeVideoRenderer renderer2_;
1468};
1469
1470// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001471TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001472 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001473 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001474 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1475 EXPECT_FALSE(channel_->sending());
1476 EXPECT_TRUE(SetSend(true));
1477 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001478 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001479 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1480 EXPECT_TRUE(SetSend(false));
1481 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001482}
Niels Möller6557d0c2018-04-11 15:18:34 +02001483
1484// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001485TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001486 EXPECT_FALSE(channel_->sending());
1487 EXPECT_FALSE(SetSend(true));
1488 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001489}
Niels Möller6557d0c2018-04-11 15:18:34 +02001490
1491// Test that we properly set the send and recv buffer sizes by the time
1492// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001493TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001494 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1495 EXPECT_TRUE(SetSend(true));
1496 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001497 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001498}
1499
Johannes Kron5a0665b2019-04-08 10:35:50 +02001500// Test that we properly set the send and recv buffer sizes when overriding
1501// via field trials.
1502TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1503 // Set field trial to override the default recv buffer size, and then re-run
1504 // setup where the interface is created and configured.
1505 const int kCustomRecvBufferSize = 123456;
1506 webrtc::test::ScopedFieldTrials field_trial(
1507 "WebRTC-IncreasedReceivebuffers/123456/");
1508 SetUp();
1509
1510 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1511 EXPECT_TRUE(SetSend(true));
1512 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1513 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1514}
1515
1516// Test that we properly set the send and recv buffer sizes when overriding
1517// via field trials with suffix.
1518TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1519 // Set field trial to override the default recv buffer size, and then re-run
1520 // setup where the interface is created and configured.
1521 const int kCustomRecvBufferSize = 123456;
1522 webrtc::test::ScopedFieldTrials field_trial(
1523 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1524 SetUp();
1525
1526 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1527 EXPECT_TRUE(SetSend(true));
1528 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1529 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1530}
1531
1532// Test that we properly set the send and recv buffer sizes when overriding
1533// via field trials that don't make any sense.
1534TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1535 // Set bogus field trial values to override the default recv buffer size, and
1536 // then re-run setup where the interface is created and configured. The
1537 // default value should still be used.
1538
1539 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1540 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1541 field_trial_string += group;
1542 field_trial_string += "/";
1543 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1544 SetUp();
1545
1546 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1547 EXPECT_TRUE(SetSend(true));
1548 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1549 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1550 }
1551}
1552
Niels Möller6557d0c2018-04-11 15:18:34 +02001553// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001554TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001555 const int kDurationSec = 3;
1556 const int kFps = 10;
1557 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1558
1559 cricket::VideoMediaInfo info;
1560 EXPECT_TRUE(channel_->GetStats(&info));
1561
1562 ASSERT_EQ(1U, info.senders.size());
1563 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1564 // For webrtc, bytes_sent does not include the RTP header length.
1565 EXPECT_GT(info.senders[0].bytes_sent, 0);
1566 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1567 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1568 ASSERT_TRUE(info.senders[0].codec_payload_type);
1569 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1570 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1571 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1572 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1573 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1574 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1575 EXPECT_GT(info.senders[0].framerate_input, 0);
1576 EXPECT_GT(info.senders[0].framerate_sent, 0);
1577
1578 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1579 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1580 info.send_codecs[DefaultCodec().id]);
1581
1582 ASSERT_EQ(1U, info.receivers.size());
1583 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1584 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1585 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1586 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1587 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1588 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1589 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1590 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1591 EXPECT_EQ(0, info.receivers[0].packets_lost);
1592 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1593 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1594 EXPECT_EQ(0, info.receivers[0].firs_sent);
1595 EXPECT_EQ(0, info.receivers[0].plis_sent);
1596 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1597 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1598 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1599 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1600 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1601 EXPECT_GT(info.receivers[0].framerate_output, 0);
1602
1603 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1604 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1605 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001606}
Niels Möller6557d0c2018-04-11 15:18:34 +02001607
1608// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001609TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001610 cricket::FakeVideoRenderer renderer1, renderer2;
1611 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1612 cricket::VideoSendParameters parameters;
1613 parameters.codecs.push_back(DefaultCodec());
1614 parameters.conference_mode = true;
1615 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1616 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001617 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1618 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001619 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1620 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1621 EXPECT_EQ(0, renderer1.num_rendered_frames());
1622 EXPECT_EQ(0, renderer2.num_rendered_frames());
1623 std::vector<uint32_t> ssrcs;
1624 ssrcs.push_back(1);
1625 ssrcs.push_back(2);
1626 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001627 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001628 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1629 kTimeout);
1630 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1631 kTimeout);
1632
1633 EXPECT_TRUE(channel_->SetSend(false));
1634
1635 cricket::VideoMediaInfo info;
1636 EXPECT_TRUE(channel_->GetStats(&info));
1637 ASSERT_EQ(1U, info.senders.size());
1638 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1639 // For webrtc, bytes_sent does not include the RTP header length.
1640 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1641 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1642 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1643 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1644
1645 ASSERT_EQ(2U, info.receivers.size());
1646 for (size_t i = 0; i < info.receivers.size(); ++i) {
1647 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1648 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1649 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001650 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001651 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1652 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1653 }
srtee0c2eea2017-12-15 17:44:33 +01001654}
Niels Möller6557d0c2018-04-11 15:18:34 +02001655
1656// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001657TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001658 // Normal setup; note that we set the SSRC explicitly to ensure that
1659 // it will come first in the senders map.
1660 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1661 cricket::VideoSendParameters parameters;
1662 parameters.codecs.push_back(DefaultCodec());
1663 parameters.conference_mode = true;
1664 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001665 EXPECT_TRUE(
1666 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001667 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1668 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001669 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001670 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1671 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1672
1673 // Add an additional capturer, and hook up a renderer to receive it.
1674 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001675 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001676 const int kTestWidth = 160;
1677 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001678 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1679 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001680 EXPECT_TRUE(
1681 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001682 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001683 EXPECT_TRUE(
1684 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001685 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001686 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001687 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1688 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001689
1690 // Get stats, and make sure they are correct for two senders. We wait until
1691 // the number of expected packets have been sent to avoid races where we
1692 // check stats before it has been updated.
1693 cricket::VideoMediaInfo info;
1694 for (uint32_t i = 0; i < kTimeout; ++i) {
1695 rtc::Thread::Current()->ProcessMessages(1);
1696 EXPECT_TRUE(channel_->GetStats(&info));
1697 ASSERT_EQ(2U, info.senders.size());
1698 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1699 NumRtpPackets()) {
1700 // Stats have been updated for both sent frames, expectations can be
1701 // checked now.
1702 break;
1703 }
1704 }
1705 EXPECT_EQ(NumRtpPackets(),
1706 info.senders[0].packets_sent + info.senders[1].packets_sent)
1707 << "Timed out while waiting for packet counts for all sent packets.";
1708 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1709 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1710 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1711 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1712 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1713 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1714 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1715 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1716 // The capturer must be unregistered here as it runs out of it's scope next.
1717 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001718}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001719
Niels Möller6557d0c2018-04-11 15:18:34 +02001720// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001721TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001722 cricket::VideoSendParameters parameters;
1723 parameters.codecs.push_back(DefaultCodec());
1724 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1725 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1726 parameters.max_bandwidth_bps = 128 * 1024;
1727 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001728}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001729
Niels Möller6557d0c2018-04-11 15:18:34 +02001730// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001731TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001732 EXPECT_TRUE(SetDefaultCodec());
1733 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001734 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001735 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001736 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001737 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001738 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1739 EXPECT_EQ(kSsrc, header.ssrc);
1740
Niels Möller6557d0c2018-04-11 15:18:34 +02001741 // Packets are being paced out, so these can mismatch between the first and
1742 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001743 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1744 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001745 EXPECT_EQ(1, NumSentSsrcs());
1746 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1747 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001748}
Niels Möller6557d0c2018-04-11 15:18:34 +02001749
1750// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001751TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001752 // Remove stream added in Setup.
1753 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1754 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001755 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001756 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001757 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001758 EXPECT_TRUE(SetSend(true));
1759 EXPECT_TRUE(WaitAndSendFrame(0));
1760 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001761 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001762 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001763 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1764 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001765 // Packets are being paced out, so these can mismatch between the first and
1766 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001767 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1768 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 EXPECT_EQ(1, NumSentSsrcs());
1770 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1771 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001772}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001773
Niels Möller6557d0c2018-04-11 15:18:34 +02001774// Test that we can set the default video renderer before and after
1775// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001776TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001777 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1778 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001779
1780 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1781 rtc::SetBE32(packet1.data() + 8, kSsrc);
1782 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1783 EXPECT_TRUE(SetDefaultCodec());
1784 EXPECT_TRUE(SetSend(true));
1785 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001786 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001787 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001788 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001790}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001791
Niels Möller6557d0c2018-04-11 15:18:34 +02001792// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001793TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001794 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1795 EXPECT_TRUE(SetSend(true));
1796 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001797 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001798 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1799 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001800 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001801 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001802 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1803 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001804 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1805 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001806
1807 // Remove the send stream that was added during Setup.
1808 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1809 int rtp_packets = NumRtpPackets();
1810
Niels Möller6557d0c2018-04-11 15:18:34 +02001811 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001812 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001813 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001814 EXPECT_EQ(rtp_packets, NumRtpPackets());
1815 // Wait 30ms to guarantee the engine does not drop the frame.
1816 EXPECT_TRUE(WaitAndSendFrame(30));
1817 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1818
1819 last_packet = NumRtpPackets() - 1;
1820 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1822 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001823}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001824
Niels Möller6557d0c2018-04-11 15:18:34 +02001825// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001826TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001827 cricket::FakeVideoRenderer renderer1, renderer2;
1828 EXPECT_TRUE(SetDefaultCodec());
1829 cricket::VideoSendParameters parameters;
1830 parameters.codecs.push_back(DefaultCodec());
1831 parameters.conference_mode = true;
1832 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1833 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001834 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1835 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001836 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1837 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1838 EXPECT_EQ(0, renderer1.num_rendered_frames());
1839 EXPECT_EQ(0, renderer2.num_rendered_frames());
1840 std::vector<uint32_t> ssrcs;
1841 ssrcs.push_back(1);
1842 ssrcs.push_back(2);
1843 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001844 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001845 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1846 kTimeout);
1847 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1848 kTimeout);
1849
1850 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1851 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1852 EXPECT_EQ(kVideoWidth, renderer1.width());
1853 EXPECT_EQ(kVideoHeight, renderer1.height());
1854 EXPECT_EQ(kVideoWidth, renderer2.width());
1855 EXPECT_EQ(kVideoHeight, renderer2.height());
1856 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1857 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001858}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001859
Niels Möller6557d0c2018-04-11 15:18:34 +02001860// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001861TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001862 using cricket::VideoCodec;
1863 using cricket::VideoOptions;
1864 using cricket::VideoFormat;
1865 using cricket::FOURCC_I420;
1866
1867 VideoCodec codec = DefaultCodec();
1868 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1869 EXPECT_TRUE(SetOneCodec(codec));
1870 EXPECT_TRUE(SetSend(true));
1871 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1872 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001873 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001874 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001875
1876 webrtc::test::FrameForwarder frame_forwarder;
1877 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1878 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001879
1880 // TODO(nisse): This testcase fails if we don't configure
1881 // screencast. It's unclear why, I see nothing obvious in this
1882 // test which is related to screencast logic.
1883 VideoOptions video_options;
1884 video_options.is_screencast = true;
1885 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1886
Niels Möller6557d0c2018-04-11 15:18:34 +02001887 int captured_frames = 1;
1888 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001889 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001890 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001891 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1892
Niels Möller6557d0c2018-04-11 15:18:34 +02001893 ++captured_frames;
1894 // Wait until frame of right size is captured.
1895 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001896 480 == renderer_.width() &&
1897 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001898 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001899 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001900 EXPECT_EQ(480, renderer_.width());
1901 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001902 captured_frames = renderer_.num_rendered_frames() + 1;
1903 EXPECT_FALSE(renderer_.black_frame());
1904 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1905 // Make sure a black frame is generated within the specified timeout.
1906 // The black frame should be the resolution of the previous frame to
1907 // prevent expensive encoder reconfigurations.
1908 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001909 480 == renderer_.width() &&
1910 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001911 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001912 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001913 EXPECT_EQ(480, renderer_.width());
1914 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001915 EXPECT_TRUE(renderer_.black_frame());
1916
1917 // The black frame has the same timestamp as the next frame since it's
1918 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1919 // not render a frame with the same timestamp so capture another frame
1920 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001921 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001922 }
srtee0c2eea2017-12-15 17:44:33 +01001923}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001924
Niels Möller6557d0c2018-04-11 15:18:34 +02001925// Tests that if SetVideoSend is called with a NULL capturer after the
1926// capturer was already removed, the application doesn't crash (and no black
1927// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001928TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001929 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1930 EXPECT_TRUE(SetSend(true));
1931 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1932 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001933 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001934 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1935 // Wait for one frame so they don't get dropped because we send frames too
1936 // tightly.
1937 rtc::Thread::Current()->ProcessMessages(30);
1938 // Remove the capturer.
1939 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1940
1941 // No capturer was added, so this SetVideoSend shouldn't do anything.
1942 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1943 rtc::Thread::Current()->ProcessMessages(300);
1944 // Verify no more frames were sent.
1945 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001946}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001947
Niels Möller6557d0c2018-04-11 15:18:34 +02001948// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001949TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001950 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1951 // interval time to avoid that.
1952 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1953 // interval time to avoid that.
1954 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001955 EXPECT_TRUE(
1956 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001957 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1958 cricket::VideoFormat capture_format(
1959 kVideoWidth, kVideoHeight,
1960 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1961 // Set up additional stream 1.
1962 cricket::FakeVideoRenderer renderer1;
1963 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001964 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001965 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001966 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001967
1968 webrtc::test::FrameForwarder frame_forwarder1;
1969 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1970 rtc::kNumMicrosecsPerSec / kFramerate);
1971
Niels Möller6557d0c2018-04-11 15:18:34 +02001972 // Set up additional stream 2.
1973 cricket::FakeVideoRenderer renderer2;
1974 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001975 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001976 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001977 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01001978 webrtc::test::FrameForwarder frame_forwarder2;
1979
Niels Möller6557d0c2018-04-11 15:18:34 +02001980 // State for all the streams.
1981 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1982 // A limitation in the lmi implementation requires that SetVideoSend() is
1983 // called after SetOneCodec().
1984 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01001985 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
1986 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02001987 EXPECT_TRUE(SetSend(true));
1988 // Test capturer associated with engine.
1989 const int kTestWidth = 160;
1990 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001991 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
1992 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1993 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02001994 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
1995 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001996 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01001997 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
1998 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
1999 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002000 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2001 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002002 // Successfully remove the capturer.
2003 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2004 // The capturers must be unregistered here as it runs out of it's scope
2005 // next.
2006 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2007 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002008}
Niels Möller6557d0c2018-04-11 15:18:34 +02002009
2010// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002011TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002012 // Remove the send stream that was added during Setup.
2013 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2014
2015 cricket::StreamParams empty;
2016 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002017 EXPECT_TRUE(
2018 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002019}
Niels Möller6557d0c2018-04-11 15:18:34 +02002020
2021// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002022TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002023 // Remove stream added in Setup. I.e. remove stream corresponding to default
2024 // channel.
2025 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002026 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002027 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2028 EXPECT_TRUE(channel_->AddSendStream(
2029 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2030 }
2031 // Delete one of the non default channel streams, let the destructor delete
2032 // the remaining ones.
2033 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2034 // Stream should already be deleted.
2035 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002036}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002037
eladalonf1841382017-06-12 01:16:46 -07002038TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002039 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002040}
2041
eladalonf1841382017-06-12 01:16:46 -07002042TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002043 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002044}
2045
eladalonf1841382017-06-12 01:16:46 -07002046TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002047 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002048}
2049
eladalonf1841382017-06-12 01:16:46 -07002050TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002051 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2052 // bitrates. This currently happens at <250k, and two streams sharing 300k
2053 // initially will use QVGA instead of VGA.
2054 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2055 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002056 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002057 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002058 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002059}
2060
eladalonf1841382017-06-12 01:16:46 -07002061class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002062 public:
eladalonf1841382017-06-12 01:16:46 -07002063 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2064 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002065 : WebRtcVideoEngineTest(field_trials),
2066 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2067 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002068 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002069 encoder_factory_->AddSupportedVideoCodecType("VP8");
2070 encoder_factory_->AddSupportedVideoCodecType("VP9");
2071#if defined(WEBRTC_USE_H264)
2072 encoder_factory_->AddSupportedVideoCodecType("H264");
2073#endif
2074
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002075 fake_call_.reset(new FakeCall());
Sebastian Jansson84848f22018-11-16 10:40:36 +01002076 channel_.reset(engine_.CreateMediaChannel(fake_call_.get(),
2077 GetMediaConfig(), VideoOptions(),
2078 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002079 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002080 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002081 send_parameters_.codecs = engine_.codecs();
2082 recv_parameters_.codecs = engine_.codecs();
2083 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002084 }
2085
2086 protected:
2087 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002088 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002089 }
2090
2091 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002092 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002093 EXPECT_TRUE(channel_->AddSendStream(sp));
2094 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002095 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002096 EXPECT_EQ(num_streams + 1, streams.size());
2097 return streams[streams.size() - 1];
2098 }
2099
2100 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002101 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002102 }
2103
2104 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002105 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002106 }
2107
2108 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002109 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002110 EXPECT_TRUE(channel_->AddRecvStream(sp));
2111 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002112 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002113 EXPECT_EQ(num_streams + 1, streams.size());
2114 return streams[streams.size() - 1];
2115 }
2116
pbos@webrtc.org00873182014-11-25 14:03:34 +00002117 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2118 int expected_min_bitrate_bps,
2119 const char* start_bitrate_kbps,
2120 int expected_start_bitrate_bps,
2121 const char* max_bitrate_kbps,
2122 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002123 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2124 expected_start_bitrate_bps,
2125 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002126 auto& codecs = send_parameters_.codecs;
2127 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002128 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002129 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2130 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2131 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002132 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002133 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002134
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002135 void ExpectSetBitrateParameters(int min_bitrate_bps,
2136 int start_bitrate_bps,
2137 int max_bitrate_bps) {
2138 EXPECT_CALL(
2139 *fake_call_->GetMockTransportControllerSend(),
2140 SetSdpBitrateParameters(AllOf(
2141 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2142 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2143 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2144 }
2145
2146 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2147 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2148 SetSdpBitrateParameters(Field(
2149 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002150 }
2151
Johannes Kron9190b822018-10-29 11:22:05 +01002152 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2153 // For a caller, the answer will be applied in set remote description
2154 // where SetSendParameters() is called.
2155 EXPECT_TRUE(
2156 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2157 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2158 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2159 const webrtc::VideoSendStream::Config& config =
2160 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2161 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2162 }
2163
2164 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2165 // For a callee, the answer will be applied in set local description
2166 // where SetExtmapAllowMixed() and AddSendStream() are called.
2167 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2168 EXPECT_TRUE(
2169 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2170 const webrtc::VideoSendStream::Config& config =
2171 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2172 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2173 }
2174
isheriff6f8d6862016-05-26 11:24:55 -07002175 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002176 // Enable extension.
2177 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002178 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002179 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002180 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002181 FakeVideoSendStream* send_stream =
2182 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2183
2184 // Verify the send extension id.
2185 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2186 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002187 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002188 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002189 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002190 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2191 // receivers.
2192 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2193 ->GetConfig()
2194 .rtp.extensions.empty());
2195
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002196 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002197 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002198 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2199 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002200 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2201
2202 // Verify that adding receive RTP header extensions adds them for existing
2203 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002204 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002205 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002206 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2207 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002208 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002209 }
2210
isheriff6f8d6862016-05-26 11:24:55 -07002211 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002212 // Enable extension.
2213 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002214 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002215 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002216 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002217
2218 FakeVideoReceiveStream* recv_stream =
2219 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2220
2221 // Verify the recv extension id.
2222 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2223 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002224 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002225 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002226 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002227
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002228 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2229 // senders.
2230 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2231 ->GetConfig()
2232 .rtp.extensions.empty());
2233
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002234 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002235 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002236 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2237 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002238 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2239
2240 // Verify that adding receive RTP header extensions adds them for existing
2241 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002242 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002243 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002244 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2245 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002246 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002247 }
2248
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002249 void TestExtensionFilter(const std::vector<std::string>& extensions,
2250 const std::string& expected_extension) {
2251 cricket::VideoSendParameters parameters = send_parameters_;
2252 int expected_id = -1;
2253 int id = 1;
2254 for (const std::string& extension : extensions) {
2255 if (extension == expected_extension)
2256 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002257 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002258 }
2259 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2260 FakeVideoSendStream* send_stream =
2261 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2262
2263 // Verify that only one of them has been set, and that it is the one with
2264 // highest priority (transport sequence number).
2265 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2266 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2267 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002268 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002269 }
2270
asapersson3c81a1a2017-06-14 05:52:21 -07002271 void TestDegradationPreference(bool resolution_scaling_enabled,
2272 bool fps_scaling_enabled);
2273
Erik Språngefbde372015-04-29 16:21:28 +02002274 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002275 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002276 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2277 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002278
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002279 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002280 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002281 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002282 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002283 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002284 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002285 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002286 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002287 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002288
Erik Språng143cec12015-04-28 10:01:41 +02002289 return fake_call_->GetVideoSendStreams().back();
2290 }
2291
Peter Boström2feafdb2015-09-09 14:32:14 +02002292 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2293 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002294 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002295 std::vector<uint32_t> ssrcs;
2296 std::vector<uint32_t> rtx_ssrcs;
2297 uint32_t num_streams = enabled ? 3 : 1;
2298 for (uint32_t i = 0; i < num_streams; ++i) {
2299 uint32_t ssrc = last_ssrc_ + i;
2300 ssrcs.push_back(ssrc);
2301 if (with_rtx) {
2302 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2303 }
Erik Språng143cec12015-04-28 10:01:41 +02002304 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002305 if (with_rtx) {
2306 return AddSendStream(
2307 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2308 }
2309 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002310 }
2311
perkjfa10b552016-10-02 23:45:26 -07002312 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002313 std::vector<FakeVideoSendStream*> streams =
2314 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002315 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002316 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002317 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002318 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002319 }
2320
perkjfa10b552016-10-02 23:45:26 -07002321 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002322 int stream_max,
2323 int expected_encoder_bitrate) {
2324 VideoSendParameters limited_send_params = send_parameters_;
2325 limited_send_params.max_bandwidth_bps = global_max;
2326 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002327 webrtc::RtpParameters parameters =
2328 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002329 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002330 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002331 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002332 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002333 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002334 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002335 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002336 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002337 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002338 }
2339
Åsa Persson55659812018-06-18 17:51:32 +02002340 // Values from kSimulcastConfigs in simulcast.cc.
2341 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2342 std::vector<webrtc::VideoStream> layers(3);
2343 layers[0].min_bitrate_bps = 30000;
2344 layers[0].target_bitrate_bps = 150000;
2345 layers[0].max_bitrate_bps = 200000;
2346 layers[1].min_bitrate_bps = 150000;
2347 layers[1].target_bitrate_bps = 500000;
2348 layers[1].max_bitrate_bps = 700000;
2349 layers[2].min_bitrate_bps = 600000;
2350 layers[2].target_bitrate_bps = 2500000;
2351 layers[2].max_bitrate_bps = 2500000;
2352 return layers;
2353 }
2354
Niels Möller805a27e2019-01-21 12:21:27 +01002355 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002356 std::unique_ptr<FakeCall> fake_call_;
2357 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002358 cricket::VideoSendParameters send_parameters_;
2359 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002360 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002361};
2362
eladalonf1841382017-06-12 01:16:46 -07002363TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002364 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002365 const std::string kSyncLabel = "AvSyncLabel";
2366
2367 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002368 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002369 EXPECT_TRUE(channel_->AddRecvStream(sp));
2370
Mirko Bonadeif859e552018-05-30 15:31:29 +02002371 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002372 EXPECT_EQ(kSyncLabel,
2373 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2374 << "SyncGroup should be set based on sync_label";
2375}
2376
eladalonf1841382017-06-12 01:16:46 -07002377TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002378 cricket::VideoSendParameters parameters;
2379 parameters.codecs = engine_.codecs();
2380 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002381 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002382 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002383 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002384
2385 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002386 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2387 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002388 FakeVideoSendStream* send_stream = AddSendStream(
2389 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2390
2391 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2392 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2393 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2394
2395 // Receiver side.
2396 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2397 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002398 EXPECT_FALSE(
2399 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002400 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002401 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002402 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002403 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002404 << "RTX should be mapped for the RED payload type";
2405
brandtr14742122017-01-27 04:53:07 -08002406 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002407}
2408
eladalonf1841382017-06-12 01:16:46 -07002409TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002410 // Setup one channel with an associated RTX stream.
2411 cricket::StreamParams params =
2412 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2413 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2414 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002415 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002416
2417 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2418 << "RTX should be mapped for all decoders/payload types.";
2419 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002420 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002421 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002422}
2423
eladalonf1841382017-06-12 01:16:46 -07002424TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002425 // Setup one channel without an associated RTX stream.
2426 cricket::StreamParams params =
2427 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2428 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002429 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002430}
2431
Johannes Kron9190b822018-10-29 11:22:05 +01002432// Test propagation of extmap allow mixed setting.
2433TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2434 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2435}
2436TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2437 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2438}
2439TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2440 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2441}
2442TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2443 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2444}
2445
eladalonf1841382017-06-12 01:16:46 -07002446TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002447 FakeVideoSendStream* send_stream =
2448 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2449 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2450
2451 FakeVideoReceiveStream* recv_stream =
2452 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2453 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002454}
2455
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002456// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002457TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002458 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002459}
isheriff6f8d6862016-05-26 11:24:55 -07002460
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002462 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002463}
2464
2465// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002466TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002467 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002468}
isheriff6f8d6862016-05-26 11:24:55 -07002469
eladalonf1841382017-06-12 01:16:46 -07002470TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002471 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002472}
2473
eladalonf1841382017-06-12 01:16:46 -07002474TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002475 // Enable three redundant extensions.
2476 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002477 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2478 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2479 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2480 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002481}
2482
eladalonf1841382017-06-12 01:16:46 -07002483TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002484 // Enable two redundant extensions.
2485 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002486 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2487 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2488 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002489}
2490
stefanc1aeaf02015-10-15 07:26:07 -07002491// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002492TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002493 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002494}
eladalonf1841382017-06-12 01:16:46 -07002495TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002496 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002497}
2498
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002499// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002500TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002501 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002502}
eladalonf1841382017-06-12 01:16:46 -07002503TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002504 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002505}
2506
eladalonf1841382017-06-12 01:16:46 -07002507TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002508 const int kAbsSendTimeId = 1;
2509 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002510 send_parameters_.extensions.push_back(
2511 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2512 send_parameters_.extensions.push_back(
2513 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002514
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002515 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002516 FakeVideoSendStream* send_stream =
2517 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2518
2519 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002520 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002521
2522 // Setting the same extensions (even if in different order) shouldn't
2523 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002524 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002525 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002526
2527 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2528
2529 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002530 send_parameters_.extensions.resize(1);
2531 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002532
2533 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2534}
2535
eladalonf1841382017-06-12 01:16:46 -07002536TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002537 const int kTOffsetId = 1;
2538 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002539 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002540 recv_parameters_.extensions.push_back(
2541 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2542 recv_parameters_.extensions.push_back(
2543 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2544 recv_parameters_.extensions.push_back(
2545 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002546
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002547 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002548 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002549 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2550
2551 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002552 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002553
2554 // Setting the same extensions (even if in different order) shouldn't
2555 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002556 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002557 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002558
2559 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2560
2561 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002562 recv_parameters_.extensions.resize(1);
2563 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002564
2565 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2566}
2567
eladalonf1841382017-06-12 01:16:46 -07002568TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002569 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002570 const int kUnsupportedId = 1;
2571 const int kTOffsetId = 2;
2572
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002573 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002574 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002575 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002576 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002577 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002578 FakeVideoSendStream* send_stream =
2579 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2580
2581 // Only timestamp offset extension is set to send stream,
2582 // unsupported rtp extension is ignored.
2583 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002584 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2585 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002586}
2587
eladalonf1841382017-06-12 01:16:46 -07002588TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002589 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002590 const int kUnsupportedId = 1;
2591 const int kTOffsetId = 2;
2592
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002593 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002594 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002595 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002596 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002597 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002598 FakeVideoReceiveStream* recv_stream =
2599 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2600
2601 // Only timestamp offset extension is set to receive stream,
2602 // unsupported rtp extension is ignored.
2603 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002604 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2605 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002606}
2607
eladalonf1841382017-06-12 01:16:46 -07002608TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002609 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002610 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002611 send_parameters_.extensions.push_back(
2612 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002614 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2615 }
2616}
2617
eladalonf1841382017-06-12 01:16:46 -07002618TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002619 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002620 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002621 recv_parameters_.extensions.push_back(
2622 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002624 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2625 }
2626}
2627
eladalonf1841382017-06-12 01:16:46 -07002628TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002629 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002630 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002631 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002632 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002633 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002634 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002635
2636 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002637 send_parameters_.extensions.clear();
2638 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002639 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002640 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2641 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002642}
2643
eladalonf1841382017-06-12 01:16:46 -07002644TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002645 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002646 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002647 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002648 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002649 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002650 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002651
2652 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002653 recv_parameters_.extensions.clear();
2654 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002655 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002656 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2657 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002658}
2659
eladalonf1841382017-06-12 01:16:46 -07002660TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002661 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002662 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002663}
2664
eladalonf1841382017-06-12 01:16:46 -07002665TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002666 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002667 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002668}
2669
eladalonf1841382017-06-12 01:16:46 -07002670TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002671 FakeVideoReceiveStream* stream = AddRecvStream();
2672 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002673}
2674
eladalonf1841382017-06-12 01:16:46 -07002675TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002676 FakeVideoReceiveStream* stream = AddRecvStream();
2677 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2678}
2679
eladalonf1841382017-06-12 01:16:46 -07002680TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002681 FakeVideoReceiveStream* stream = AddRecvStream();
2682 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2683
Peter Boström126c03e2015-05-11 12:48:12 +02002684 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002685 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002686 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002687 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2688 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002689 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002690 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2691
2692 // Verify that REMB is turned on when setting default codecs since the
2693 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002694 parameters.codecs = engine_.codecs();
2695 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002696 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002697 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002698}
2699
eladalonf1841382017-06-12 01:16:46 -07002700TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002701 FakeVideoReceiveStream* stream = AddRecvStream();
2702 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2703
2704 // Verify that transport cc feedback is turned off when send(!) codecs without
2705 // transport cc feedback are set.
2706 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002707 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002708 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2709 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2710 stream = fake_call_->GetVideoReceiveStreams()[0];
2711 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2712
2713 // Verify that transport cc feedback is turned on when setting default codecs
2714 // since the default codecs have transport cc feedback enabled.
2715 parameters.codecs = engine_.codecs();
2716 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2717 stream = fake_call_->GetVideoReceiveStreams()[0];
2718 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2719}
2720
eladalonf1841382017-06-12 01:16:46 -07002721TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002722 AssignDefaultCodec();
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002723 VerifyCodecHasDefaultFeedbackParams(default_codec_);
2724
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002725 cricket::VideoSendParameters parameters;
2726 parameters.codecs = engine_.codecs();
2727 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002728 EXPECT_TRUE(channel_->SetSend(true));
2729
2730 // Send side.
2731 FakeVideoSendStream* send_stream =
2732 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2733 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2734
2735 // Receiver side.
2736 FakeVideoReceiveStream* recv_stream =
2737 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2738 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2739
2740 // Nack history size should match between sender and receiver.
2741 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2742 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002743}
2744
eladalonf1841382017-06-12 01:16:46 -07002745TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002746 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002747 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002748
2749 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2750 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2751
2752 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002753 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002754 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002755 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2756 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002757 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2758 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2759 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002760 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2761
Peter Boström67c9df72015-05-11 14:34:58 +02002762 // Verify that NACK is turned on when setting default codecs since the
2763 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002764 parameters.codecs = engine_.codecs();
2765 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002766 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2767 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2768 send_stream = fake_call_->GetVideoSendStreams()[0];
2769 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002770}
2771
Peter Boströme7ba0862016-03-12 00:02:28 +01002772// This test verifies that new frame sizes reconfigures encoders even though not
2773// (yet) sending. The purpose of this is to permit encoding as quickly as
2774// possible once we start sending. Likely the frames being input are from the
2775// same source that will be sent later, which just means that we're ready
2776// earlier.
eladalonf1841382017-06-12 01:16:46 -07002777TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002778 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002779 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002780 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2781 channel_->SetSend(false);
2782
2783 FakeVideoSendStream* stream = AddSendStream();
2784
perkjfa10b552016-10-02 23:45:26 -07002785 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002786 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002787 EXPECT_EQ(0u, streams[0].width);
2788 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002789
Niels Möller805a27e2019-01-21 12:21:27 +01002790 webrtc::test::FrameForwarder frame_forwarder;
2791 cricket::FakeFrameSource frame_source(1280, 720,
2792 rtc::kNumMicrosecsPerSec / 30);
2793
2794 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2795 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002796
2797 // Frame entered, should be reconfigured to new dimensions.
2798 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002799 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2800 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002801
Niels Möllerff40b142018-04-09 08:49:14 +02002802 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002803}
2804
eladalonf1841382017-06-12 01:16:46 -07002805TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002806 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002807 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002808 cricket::VideoSendParameters parameters;
2809 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002810 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002811 AddSendStream();
2812
Niels Möller805a27e2019-01-21 12:21:27 +01002813 webrtc::test::FrameForwarder frame_forwarder;
2814 cricket::FakeFrameSource frame_source(1280, 720,
2815 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002816 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002817 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002818 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2819 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002820
2821 EXPECT_TRUE(channel_->SetSend(true));
2822
Niels Möller805a27e2019-01-21 12:21:27 +01002823 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002824 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2825 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2826
2827 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2828
2829 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002830 webrtc::VideoEncoderConfig encoder_config =
2831 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002832 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002833 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002834 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002835 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2836 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002837 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2838 << "Non-screenshare shouldn't use min-transmit bitrate.";
2839
Niels Möllerff40b142018-04-09 08:49:14 +02002840 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002841 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002842 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002843 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002844 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2845 &frame_forwarder));
2846 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002847 // Send stream recreated after option change.
2848 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2849 send_stream = fake_call_->GetVideoSendStreams().front();
2850 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002851
2852 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002853 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002854 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002855 encoder_config.content_type);
2856 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2857 encoder_config.min_transmit_bitrate_bps);
2858
perkjfa10b552016-10-02 23:45:26 -07002859 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002860 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2861 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002862 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002863 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002864}
2865
eladalonf1841382017-06-12 01:16:46 -07002866TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002867 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002868 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002869 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002870 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002871
2872 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002873 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002874 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002875 webrtc::test::FrameForwarder frame_forwarder;
2876 cricket::FakeFrameSource frame_source(1280, 720,
2877 rtc::kNumMicrosecsPerSec / 30);
2878 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002879 EXPECT_TRUE(channel_->SetSend(true));
2880
Niels Möller805a27e2019-01-21 12:21:27 +01002881 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002882 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2883 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2884
perkj26091b12016-09-01 01:17:40 -07002885 webrtc::VideoEncoderConfig encoder_config =
2886 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002887
2888 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002889 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002890 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002891 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002892
2893 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2894 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002895 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002896 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002897 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002898
Niels Möllerff40b142018-04-09 08:49:14 +02002899 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002900}
2901
eladalonf1841382017-06-12 01:16:46 -07002902TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002903 FakeVideoSendStream* stream = AddSendStream();
2904 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2905}
2906
eladalonf1841382017-06-12 01:16:46 -07002907TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08002908 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08002909 media_config.video.suspend_below_min_bitrate = true;
2910
Sebastian Jansson84848f22018-11-16 10:40:36 +01002911 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002912 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002913 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002914
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002915 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002916
2917 FakeVideoSendStream* stream = AddSendStream();
2918 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
2919
nisse0db023a2016-03-01 04:29:59 -08002920 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01002921 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07002922 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002923 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08002924
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002925 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002926
nisse0db023a2016-03-01 04:29:59 -08002927 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00002928 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
2929}
2930
eladalonf1841382017-06-12 01:16:46 -07002931TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002932 FakeVideoSendStream* stream = AddSendStream();
2933 webrtc::VideoCodecVP8 vp8_settings;
2934 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2935 EXPECT_TRUE(vp8_settings.denoisingOn);
2936}
2937
eladalonf1841382017-06-12 01:16:46 -07002938TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002939 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002940 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002941 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002942
Peter Boström2feafdb2015-09-09 14:32:14 +02002943 // Single-stream settings should apply with RTX as well (verifies that we
2944 // check number of regular SSRCs and not StreamParams::ssrcs which contains
2945 // both RTX and regular SSRCs).
2946 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02002947
Niels Möller805a27e2019-01-21 12:21:27 +01002948 webrtc::test::FrameForwarder frame_forwarder;
2949 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002950 channel_->SetSend(true);
2951
Niels Möller805a27e2019-01-21 12:21:27 +01002952 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002953
pbos4cba4eb2015-10-26 11:18:18 -07002954 webrtc::VideoCodecVP8 vp8_settings;
2955 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2956 EXPECT_TRUE(vp8_settings.denoisingOn)
2957 << "VP8 denoising should be on by default.";
2958
Niels Möller805a27e2019-01-21 12:21:27 +01002959 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002960
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002961 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2962 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002963 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2964 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002965
Niels Möller805a27e2019-01-21 12:21:27 +01002966 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002967
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00002968 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2969 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02002970 EXPECT_TRUE(vp8_settings.automaticResizeOn);
2971 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2972
Niels Möllerff40b142018-04-09 08:49:14 +02002973 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02002974 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01002975 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02002976 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01002977 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02002978
Mirko Bonadeif859e552018-05-30 15:31:29 +02002979 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002980 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2981 // Autmatic resize off when using simulcast.
2982 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2983 EXPECT_TRUE(vp8_settings.frameDroppingOn);
2984
2985 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07002986 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002987 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002988 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01002989
Niels Möller805a27e2019-01-21 12:21:27 +01002990 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02002991
Mirko Bonadeif859e552018-05-30 15:31:29 +02002992 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02002993 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
2994 EXPECT_FALSE(vp8_settings.denoisingOn);
2995 // Resizing and frame dropping always off for screen sharing.
2996 EXPECT_FALSE(vp8_settings.automaticResizeOn);
2997 EXPECT_FALSE(vp8_settings.frameDroppingOn);
2998
Niels Möller805a27e2019-01-21 12:21:27 +01002999 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003000
3001 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3002 EXPECT_FALSE(vp8_settings.denoisingOn);
3003 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3004 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3005
Niels Möllerff40b142018-04-09 08:49:14 +02003006 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003007}
3008
deadbeef119760a2016-04-04 11:43:27 -07003009// Test that setting the same options doesn't result in the encoder being
3010// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003011TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003012 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003013 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003014
perkjfa10b552016-10-02 23:45:26 -07003015 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003016 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003017 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003018 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3019 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3020
Niels Möller805a27e2019-01-21 12:21:27 +01003021 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3022 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3023 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003024 // Expect 1 reconfigurations at this point from the initial configuration.
3025 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003026
3027 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003028 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003029 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3030
3031 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003032 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003033 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003034 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3035
Niels Möllerff40b142018-04-09 08:49:14 +02003036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003037}
3038
eladalonf1841382017-06-12 01:16:46 -07003039class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003040 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003041 Vp9SettingsTest() : Vp9SettingsTest("") {}
3042 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003043 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003044 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003045 }
3046 virtual ~Vp9SettingsTest() {}
3047
3048 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003049 void TearDown() override {
3050 // Remove references to encoder_factory_ since this will be destroyed
3051 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003052 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003053 }
Erik Språng143cec12015-04-28 10:01:41 +02003054};
3055
3056TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003057 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003058 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003059 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003060
Peter Boström2feafdb2015-09-09 14:32:14 +02003061 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003062
Niels Möller805a27e2019-01-21 12:21:27 +01003063 webrtc::test::FrameForwarder frame_forwarder;
3064 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003065 channel_->SetSend(true);
3066
Niels Möller805a27e2019-01-21 12:21:27 +01003067 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003068
pbos4cba4eb2015-10-26 11:18:18 -07003069 webrtc::VideoCodecVP9 vp9_settings;
3070 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003071 EXPECT_TRUE(vp9_settings.denoisingOn)
3072 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003073
Niels Möller805a27e2019-01-21 12:21:27 +01003074 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003075
Erik Språng143cec12015-04-28 10:01:41 +02003076 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3077 EXPECT_FALSE(vp9_settings.denoisingOn);
3078 // Frame dropping always on for real time video.
3079 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3080
Niels Möller805a27e2019-01-21 12:21:27 +01003081 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003082
3083 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3084 EXPECT_TRUE(vp9_settings.denoisingOn);
3085 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3086
3087 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003088 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003089 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003090 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003091
Niels Möller805a27e2019-01-21 12:21:27 +01003092 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003093
3094 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3095 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003096 // Frame dropping always on for screen sharing.
3097 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003098
Niels Möller805a27e2019-01-21 12:21:27 +01003099 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003100
3101 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3102 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003103 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003104
Niels Möllerff40b142018-04-09 08:49:14 +02003105 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003106}
3107
Sergey Silkinf18072e2018-03-14 10:35:35 +01003108TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3109 cricket::VideoSendParameters parameters;
3110 parameters.codecs.push_back(GetEngineCodec("VP9"));
3111 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3112
3113 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3114
3115 FakeVideoSendStream* stream =
3116 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3117
3118 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003119
Niels Möller805a27e2019-01-21 12:21:27 +01003120 webrtc::test::FrameForwarder frame_forwarder;
3121 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003122 channel_->SetSend(true);
3123
Niels Möller805a27e2019-01-21 12:21:27 +01003124 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003125
3126 webrtc::VideoCodecVP9 vp9_settings;
3127 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3128
3129 const size_t kNumSpatialLayers = ssrcs.size();
3130 const size_t kNumTemporalLayers = 3;
3131 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3132 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3133
Niels Möllerff40b142018-04-09 08:49:14 +02003134 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003135}
3136
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003137TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3138 cricket::VideoSendParameters parameters;
3139 parameters.codecs.push_back(GetEngineCodec("VP9"));
3140 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3141
3142 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3143
3144 FakeVideoSendStream* stream =
3145 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3146
3147 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3148
3149 // Despite 3 ssrcs provided, single layer is used.
3150 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3151
3152 webrtc::test::FrameForwarder frame_forwarder;
3153 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3154 channel_->SetSend(true);
3155
3156 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3157
3158 webrtc::VideoCodecVP9 vp9_settings;
3159 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3160
3161 const size_t kNumSpatialLayers = ssrcs.size();
3162 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3163
3164 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3165}
3166
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003167TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3168 cricket::VideoSendParameters send_parameters;
3169 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3170 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3171
3172 const size_t kNumSpatialLayers = 3;
3173 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3174
3175 FakeVideoSendStream* stream =
3176 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3177
3178 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3179 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3180 ASSERT_TRUE(parameters.encodings[0].active);
3181 ASSERT_TRUE(parameters.encodings[1].active);
3182 ASSERT_TRUE(parameters.encodings[2].active);
3183 // Invert value to verify copying.
3184 parameters.encodings[1].active = false;
3185 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3186
3187 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3188
3189 // number_of_streams should be 1 since all spatial layers are sent on the
3190 // same SSRC. But encoding parameters of all layers is supposed to be copied
3191 // and stored in simulcast_layers[].
3192 EXPECT_EQ(1u, encoder_config.number_of_streams);
3193 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3194 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3195 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3196 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3197}
3198
Sergey Silkincf267052019-04-09 11:40:09 +02003199class Vp9SettingsTestWithFieldTrial
3200 : public Vp9SettingsTest,
3201 public ::testing::WithParamInterface<
3202 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003203 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003204 Vp9SettingsTestWithFieldTrial()
3205 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3206 num_spatial_layers_(::testing::get<1>(GetParam())),
3207 num_temporal_layers_(::testing::get<2>(GetParam())),
3208 inter_layer_pred_(::testing::get<3>(GetParam())) {}
3209
3210 void VerifySettings(int num_spatial_layers,
3211 int num_temporal_layers,
3212 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003213 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003214 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003215 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3216
3217 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3218
Niels Möller805a27e2019-01-21 12:21:27 +01003219 webrtc::test::FrameForwarder frame_forwarder;
3220 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003221 channel_->SetSend(true);
3222
Niels Möller805a27e2019-01-21 12:21:27 +01003223 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003224
3225 webrtc::VideoCodecVP9 vp9_settings;
3226 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3227 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3228 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkincf267052019-04-09 11:40:09 +02003229 EXPECT_EQ(inter_layer_pred_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003230
Niels Möllerff40b142018-04-09 08:49:14 +02003231 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003232 }
Sergey Silkincf267052019-04-09 11:40:09 +02003233
3234 const uint8_t num_spatial_layers_;
3235 const uint8_t num_temporal_layers_;
3236 const webrtc::InterLayerPredMode inter_layer_pred_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003237};
3238
Sergey Silkincf267052019-04-09 11:40:09 +02003239TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
3240 VerifySettings(num_spatial_layers_, num_temporal_layers_, inter_layer_pred_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003241}
3242
Sergey Silkincf267052019-04-09 11:40:09 +02003243INSTANTIATE_TEST_SUITE_P(
3244 ,
3245 Vp9SettingsTestWithFieldTrial,
3246 ::testing::Values(
3247 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3248 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3249 1,
3250 1,
3251 webrtc::InterLayerPredMode::kOnKeyPic),
3252 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3253 2,
3254 3,
3255 webrtc::InterLayerPredMode::kOnKeyPic),
3256 std::make_tuple("WebRTC-Vp9InterLayerPred/0/",
3257 1,
3258 1,
3259 webrtc::InterLayerPredMode::kOff),
3260 std::make_tuple("WebRTC-Vp9InterLayerPred/1/",
3261 1,
3262 1,
3263 webrtc::InterLayerPredMode::kOn),
3264 std::make_tuple("WebRTC-Vp9InterLayerPred/2/",
3265 1,
3266 1,
3267 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003268
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003269TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3270 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3271 ASSERT_EQ(1u, streams.size());
3272 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3273}
3274
3275TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
3276 webrtc::test::ScopedFieldTrials override_field_trials_(
3277 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3278 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3279 ASSERT_EQ(1u, streams.size());
3280 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3281}
3282
asapersson3c81a1a2017-06-14 05:52:21 -07003283TEST_F(WebRtcVideoChannelTest,
3284 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
3285 webrtc::test::ScopedFieldTrials override_field_trials_(
3286 "WebRTC-Video-BalancedDegradation/Disabled/");
3287 const bool kResolutionScalingEnabled = true;
3288 const bool kFpsScalingEnabled = false;
3289 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3290}
3291
3292TEST_F(WebRtcVideoChannelTest,
3293 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
3294 webrtc::test::ScopedFieldTrials override_field_trials_(
3295 "WebRTC-Video-BalancedDegradation/Enabled/");
3296 const bool kResolutionScalingEnabled = true;
3297 const bool kFpsScalingEnabled = true;
3298 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3299}
3300
eladalonf1841382017-06-12 01:16:46 -07003301TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003302 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003303}
3304
eladalonf1841382017-06-12 01:16:46 -07003305TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003306 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003307}
3308
Niels Möller3de32e62019-01-18 08:42:18 +01003309TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3310 TestCpuAdaptation(false, true);
3311}
3312
eladalonf1841382017-06-12 01:16:46 -07003313TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003314 TestCpuAdaptation(true, true);
3315}
3316
eladalonf1841382017-06-12 01:16:46 -07003317TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003318 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003319 cricket::VideoSendParameters parameters;
3320 parameters.codecs.push_back(codec);
3321
kthelgason2bc68642017-02-07 07:02:22 -08003322 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003323 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003324 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003325 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003326 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003327 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3328
3329 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003330 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003331
Per766ad3b2016-04-05 15:23:49 +02003332 ASSERT_TRUE(channel_->SetSend(true));
3333 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003334 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003335 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003336
3337 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3338 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003339
Niels Möllerdcc70292019-01-15 16:32:38 +01003340 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3341 // Dont' expect anything on framerate_scaling_enabled, since the default is
3342 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003343
Niels Möllerdcc70292019-01-15 16:32:38 +01003344 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003345 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003346 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003347 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003348 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3349 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003350 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003351
Niels Möllerdcc70292019-01-15 16:32:38 +01003352 // Switch back to the normal capturer. Expect resolution scaling to be
3353 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003354 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3355 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003356 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3357 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003358 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003359
Niels Möllerff40b142018-04-09 08:49:14 +02003360 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003361}
3362
asapersson3c81a1a2017-06-14 05:52:21 -07003363// TODO(asapersson): Remove this test when the balanced field trial is removed.
3364void WebRtcVideoChannelTest::TestDegradationPreference(
3365 bool resolution_scaling_enabled,
3366 bool fps_scaling_enabled) {
3367 cricket::VideoCodec codec = GetEngineCodec("VP8");
3368 cricket::VideoSendParameters parameters;
3369 parameters.codecs.push_back(codec);
3370
3371 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003372 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003373 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003374 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
asapersson3c81a1a2017-06-14 05:52:21 -07003375 channel_->OnReadyToSend(true);
3376
3377 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3378
3379 AddSendStream();
3380
Niels Möller805a27e2019-01-21 12:21:27 +01003381 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003382 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003383 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003384
3385 EXPECT_TRUE(channel_->SetSend(true));
3386
3387 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3388 EXPECT_EQ(resolution_scaling_enabled,
3389 send_stream->resolution_scaling_enabled());
3390 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3391
Niels Möllerff40b142018-04-09 08:49:14 +02003392 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003393}
3394
eladalonf1841382017-06-12 01:16:46 -07003395void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3396 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003397 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003398 cricket::VideoSendParameters parameters;
3399 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003400
kthelgason2bc68642017-02-07 07:02:22 -08003401 MediaConfig media_config = GetMediaConfig();
3402 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003403 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003404 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003405 channel_.reset(engine_.CreateMediaChannel(
Benjamin Wrightbfb444c2018-10-15 10:20:24 -07003406 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003407 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003408
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003409 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003410
3411 AddSendStream();
3412
Niels Möller805a27e2019-01-21 12:21:27 +01003413 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003414 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003415 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003416 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003417
3418 EXPECT_TRUE(channel_->SetSend(true));
3419
solenberge5269742015-09-08 05:13:22 -07003420 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003421
sprangc5d62e22017-04-02 23:53:04 -07003422 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003423 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003424 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003425 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003426 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3427 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3428 } else {
3429 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3430 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3431 }
Niels Möllerff40b142018-04-09 08:49:14 +02003432 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003433}
3434
eladalonf1841382017-06-12 01:16:46 -07003435TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003436 // Start at last timestamp to verify that wraparounds are estimated correctly.
3437 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3438 static const int64_t kInitialNtpTimeMs = 1247891230;
3439 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003440 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003441
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003442 FakeVideoReceiveStream* stream = AddRecvStream();
3443 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003444 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003445
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003446 webrtc::VideoFrame video_frame =
3447 webrtc::VideoFrame::Builder()
3448 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3449 .set_timestamp_rtp(kInitialTimestamp)
3450 .set_timestamp_us(0)
3451 .set_rotation(webrtc::kVideoRotation_0)
3452 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003453 // Initial NTP time is not available on the first frame, but should still be
3454 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003455 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003456
3457 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003458
3459 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3460 // triggers a constant-overflow warning, hence we're calculating it explicitly
3461 // here.
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +02003462 fake_clock_.AdvanceTimeMicros(kFrameOffsetMs * rtc::kNumMicrosecsPerMillisec);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003463 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3464 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003465 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003466
3467 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003468
3469 // Verify that NTP time has been correctly deduced.
3470 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003471 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003472 ASSERT_EQ(1u, info.receivers.size());
3473 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003474}
3475
eladalonf1841382017-06-12 01:16:46 -07003476TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003477 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003478 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003479
3480 VideoCodec codec;
3481 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003482 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003483
3484 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003485 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3486 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003487 FakeVideoSendStream* stream = AddSendStream(
3488 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003489 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003490
3491 // Make sure NACK and FEC are enabled on the correct payload types.
3492 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003493 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3494 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003495
3496 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3497 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003498 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003499 // TODO(juberti): Check RTCP, PLI, TMMBR.
3500}
3501
brandtr31bd2242017-05-19 05:47:46 -07003502// The following four tests ensures that FlexFEC is not activated by default
3503// when the field trials are not enabled.
3504// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3505// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003506TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003507 FakeVideoSendStream* stream = AddSendStream();
3508 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3509
brandtr3d200bd2017-01-16 06:59:19 -08003510 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003511 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3512 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003513}
3514
eladalonf1841382017-06-12 01:16:46 -07003515TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003516 FakeVideoSendStream* stream = AddSendStream(
3517 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3518 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3519
brandtr3d200bd2017-01-16 06:59:19 -08003520 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003521 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3522 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3523}
3524
Yves Gerey665174f2018-06-19 15:03:05 +02003525TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003526 AddRecvStream();
3527
3528 const std::vector<FakeFlexfecReceiveStream*>& streams =
3529 fake_call_->GetFlexfecReceiveStreams();
3530 EXPECT_TRUE(streams.empty());
3531}
3532
eladalonf1841382017-06-12 01:16:46 -07003533TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003534 AddRecvStream(
3535 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3536
3537 const std::vector<FakeFlexfecReceiveStream*>& streams =
3538 fake_call_->GetFlexfecReceiveStreams();
3539 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003540}
3541
3542// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3543// tests that use this test fixture into the corresponding "non-field trial"
3544// tests.
eladalonf1841382017-06-12 01:16:46 -07003545class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003546 public:
eladalonf1841382017-06-12 01:16:46 -07003547 WebRtcVideoChannelFlexfecRecvTest()
3548 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003549};
3550
eladalonf1841382017-06-12 01:16:46 -07003551TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003552 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3553 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3554 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3555}
3556
eladalonf1841382017-06-12 01:16:46 -07003557TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003558 AddRecvStream();
3559
3560 const std::vector<FakeFlexfecReceiveStream*>& streams =
3561 fake_call_->GetFlexfecReceiveStreams();
3562 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003563
3564 const std::vector<FakeVideoReceiveStream*>& video_streams =
3565 fake_call_->GetVideoReceiveStreams();
3566 ASSERT_EQ(1U, video_streams.size());
3567 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3568 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3569 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003570}
3571
eladalonf1841382017-06-12 01:16:46 -07003572TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003573 AddRecvStream(
3574 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3575
3576 const std::vector<FakeFlexfecReceiveStream*>& streams =
3577 fake_call_->GetFlexfecReceiveStreams();
3578 ASSERT_EQ(1U, streams.size());
3579 const FakeFlexfecReceiveStream* stream = streams.front();
3580 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3581 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3582 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3583 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3584 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003585
3586 const std::vector<FakeVideoReceiveStream*>& video_streams =
3587 fake_call_->GetVideoReceiveStreams();
3588 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003589 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3590 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003591 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003592 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003593 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003594}
3595
eladalonf1841382017-06-12 01:16:46 -07003596TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003597 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3598 cricket::VideoRecvParameters recv_parameters;
3599 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3600 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3601
3602 AddRecvStream(
3603 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3604 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003605 const std::vector<FakeVideoReceiveStream*>& video_streams =
3606 fake_call_->GetVideoReceiveStreams();
3607 ASSERT_EQ(1U, video_streams.size());
3608 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3609 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3610 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003611
3612 // Enable FlexFEC.
3613 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3614 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3615 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3616 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3617 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3618 << "Enabling FlexFEC should not create VideoReceiveStream.";
3619 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3620 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003621 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3622 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003623}
3624
eladalonf1841382017-06-12 01:16:46 -07003625TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003626 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3627 cricket::VideoRecvParameters recv_parameters;
3628 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3629 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3630 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3631
3632 AddRecvStream(
3633 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3634 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003635 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003636 const std::vector<FakeVideoReceiveStream*>& video_streams =
3637 fake_call_->GetVideoReceiveStreams();
3638 ASSERT_EQ(1U, video_streams.size());
3639 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3640 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3641 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003642
3643 // Disable FlexFEC.
3644 recv_parameters.codecs.clear();
3645 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3646 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3647 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3648 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3649 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3650 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3651 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3652 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003653 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3654 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003655}
3656
brandtr31bd2242017-05-19 05:47:46 -07003657// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3658// tests that use this test fixture into the corresponding "non-field trial"
3659// tests.
eladalonf1841382017-06-12 01:16:46 -07003660class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003661 public:
eladalonf1841382017-06-12 01:16:46 -07003662 WebRtcVideoChannelFlexfecSendRecvTest()
3663 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003664 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3665 }
3666};
3667
Yves Gerey665174f2018-06-19 15:03:05 +02003668TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003669 FakeVideoSendStream* stream = AddSendStream();
3670 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3671
brandtr3d200bd2017-01-16 06:59:19 -08003672 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3673 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3674 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003675}
3676
eladalonf1841382017-06-12 01:16:46 -07003677TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003678 FakeVideoSendStream* stream = AddSendStream(
3679 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3680 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3681
brandtr3d200bd2017-01-16 06:59:19 -08003682 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3683 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3684 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3685 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003686}
3687
eladalonf1841382017-06-12 01:16:46 -07003688TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003689 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003690 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003691 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003692
3693 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003694 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003695
brandtrb5f2c3f2016-10-04 23:28:39 -07003696 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3697 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003698}
3699
eladalonf1841382017-06-12 01:16:46 -07003700TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003701 cricket::VideoSendParameters parameters;
3702 parameters.codecs.push_back(GetEngineCodec("VP8"));
3703 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3704
3705 FakeVideoSendStream* stream = AddSendStream();
3706 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3707
brandtr3d200bd2017-01-16 06:59:19 -08003708 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003709}
3710
eladalonf1841382017-06-12 01:16:46 -07003711TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003712 AddRecvStream(
3713 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003714
3715 cricket::VideoRecvParameters recv_parameters;
3716 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3717 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3718 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003719
3720 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3721 fake_call_->GetFlexfecReceiveStreams();
3722 ASSERT_EQ(1U, flexfec_streams.size());
3723 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3724 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3725 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003726 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003727 flexfec_stream_config.payload_type);
3728 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3729 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3730 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3731 const std::vector<FakeVideoReceiveStream*>& video_streams =
3732 fake_call_->GetVideoReceiveStreams();
3733 const FakeVideoReceiveStream* video_stream = video_streams.front();
3734 const webrtc::VideoReceiveStream::Config& video_stream_config =
3735 video_stream->GetConfig();
3736 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3737 flexfec_stream_config.local_ssrc);
3738 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3739 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3740 flexfec_stream_config.rtcp_send_transport);
3741 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3742 // spec-compliant way.
3743 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3744 flexfec_stream_config.transport_cc);
3745 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3746 EXPECT_EQ(video_stream_config.rtp.extensions,
3747 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003748}
3749
brandtr31bd2242017-05-19 05:47:46 -07003750// We should not send FlexFEC, even if we advertise it, unless the right
3751// field trial is set.
3752// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003753TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003754 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3755 cricket::VideoSendParameters parameters;
3756 parameters.codecs.push_back(GetEngineCodec("VP8"));
3757 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3758 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3759
3760 FakeVideoSendStream* stream = AddSendStream();
3761 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3762
3763 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003764 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003765 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3766}
3767
eladalonf1841382017-06-12 01:16:46 -07003768TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003769 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3770 cricket::VideoSendParameters parameters;
3771 parameters.codecs.push_back(GetEngineCodec("VP8"));
3772 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3773 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3774
3775 FakeVideoSendStream* stream = AddSendStream(
3776 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3777 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3778
3779 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003780 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003781 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3782}
3783
eladalonf1841382017-06-12 01:16:46 -07003784TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003785 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003786 const int kUnusedPayloadType = 127;
3787 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3788
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003789 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003790 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003791 parameters.codecs.push_back(rtx_codec);
3792 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003793 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003794}
3795
eladalonf1841382017-06-12 01:16:46 -07003796TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003797 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003798 const int kUnusedPayloadType1 = 126;
3799 const int kUnusedPayloadType2 = 127;
3800 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3801 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3802 {
3803 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3804 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3805 cricket::VideoSendParameters parameters;
3806 parameters.codecs.push_back(GetEngineCodec("VP8"));
3807 parameters.codecs.push_back(rtx_codec);
3808 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3809 }
3810 {
3811 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3812 kUnusedPayloadType1, kUnusedPayloadType2);
3813 cricket::VideoSendParameters parameters;
3814 parameters.codecs.push_back(GetEngineCodec("VP8"));
3815 parameters.codecs.push_back(rtx_codec);
3816 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3817 << "RTX without matching video codec should be rejected.";
3818 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003819}
3820
eladalonf1841382017-06-12 01:16:46 -07003821TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003822 const int kUnusedPayloadType1 = 126;
3823 const int kUnusedPayloadType2 = 127;
3824 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3825 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3826
3827 // SSRCs for RTX.
3828 cricket::StreamParams params =
3829 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3830 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3831 AddSendStream(params);
3832
3833 // Original payload type for RTX.
3834 cricket::VideoSendParameters parameters;
3835 parameters.codecs.push_back(GetEngineCodec("VP8"));
3836 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3837 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3838 parameters.codecs.push_back(rtx_codec);
3839 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3840 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3841 const webrtc::VideoSendStream::Config& config_before =
3842 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3843 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3844 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3845 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3846
3847 // Change payload type for RTX.
3848 parameters.codecs[1].id = kUnusedPayloadType2;
3849 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3850 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3851 const webrtc::VideoSendStream::Config& config_after =
3852 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3853 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3854 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3855 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3856}
3857
eladalonf1841382017-06-12 01:16:46 -07003858TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003859 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003860 parameters.codecs.push_back(GetEngineCodec("VP8"));
3861 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003862 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003863
3864 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003865 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003866
magjed509e4fe2016-11-18 01:34:11 -08003867 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003868
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003869 parameters.codecs.pop_back();
3870 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003871 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08003872 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07003873 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07003874 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003875 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
3876}
3877
eladalonf1841382017-06-12 01:16:46 -07003878TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003879 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08003880 cricket::VideoSendParameters parameters;
3881 parameters.codecs.push_back(GetEngineCodec("VP8"));
3882 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3883 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3884
3885 FakeVideoSendStream* stream = AddSendStream(
3886 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3887 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3888
brandtr3d200bd2017-01-16 06:59:19 -08003889 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3890 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08003891 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3892 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
3893
3894 parameters.codecs.pop_back();
3895 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3896 stream = fake_call_->GetVideoSendStreams()[0];
3897 ASSERT_TRUE(stream != nullptr);
3898 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08003899 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08003900 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003901}
3902
eladalonf1841382017-06-12 01:16:46 -07003903TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003904 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07003905 cricket::VideoCodec codec(100, "VP8");
3906 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
3907 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07003908
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003909 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003910 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003911
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003912 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003913 webrtc::test::FrameForwarder frame_forwarder;
3914 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00003915
3916 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003917 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00003918
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003919 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07003920 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
3921 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003922 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003923 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07003924 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02003925 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003926}
3927
eladalonf1841382017-06-12 01:16:46 -07003928TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003929 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
3930 200000);
3931}
3932
eladalonf1841382017-06-12 01:16:46 -07003933TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00003934 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
3935 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3936 ASSERT_EQ(1u, streams.size());
3937 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
3938}
3939
eladalonf1841382017-06-12 01:16:46 -07003940TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00003941 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003942 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00003943}
3944
eladalonf1841382017-06-12 01:16:46 -07003945TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00003946 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003947}
3948
eladalonf1841382017-06-12 01:16:46 -07003949TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003950 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
3951 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
3952 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003953}
3954
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003955// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3956// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07003957TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003958 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3959 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3960 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
3961 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003962 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003963 ExpectSetBitrateParameters(100000, 200000, 400000);
3964 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
3965 // Since the codec isn't changing, start_bitrate_bps should be -1.
3966 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003967
3968 // Decrease max_bandwidth_bps.
3969 send_parameters_.max_bandwidth_bps = 350000;
3970 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003971
3972 // Now try again with the values flipped around.
3973 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
3974 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003975 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003976 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003977
3978 // If we change the codec max, max_bandwidth_bps should still apply.
3979 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01003980 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003981 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07003982}
3983
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07003984// Test that when both the codec-specific bitrate params and max_bandwidth_bps
3985// are present in the same send parameters, the settings are combined correctly.
3986TEST_F(WebRtcVideoChannelTest,
3987 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
3988 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
3989 // Transport.
3990 webrtc::MediaTransportSettings settings;
3991 settings.is_caller = true;
3992 webrtc::FakeMediaTransport fake_media_transport(settings);
3993 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
3994 new cricket::FakeNetworkInterface);
3995 channel_->SetInterface(network_interface.get(), &fake_media_transport);
3996
3997 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
3998 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
3999 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4000 send_parameters_.max_bandwidth_bps = 400000;
4001 {
4002 // We expect max_bandwidth_bps to take priority, if set.
4003 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4004 ASSERT_EQ(1u,
4005 fake_media_transport.target_rate_constraints_in_order().size());
4006 const webrtc::MediaTransportTargetRateConstraints& constraint =
4007 fake_media_transport.target_rate_constraints_in_order()[0];
4008 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4009 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4010 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4011 }
4012
4013 {
4014 // Decrease max_bandwidth_bps.
4015 send_parameters_.max_bandwidth_bps = 350000;
4016 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4017 ASSERT_EQ(2u,
4018 fake_media_transport.target_rate_constraints_in_order().size());
4019 const webrtc::MediaTransportTargetRateConstraints& constraint =
4020 fake_media_transport.target_rate_constraints_in_order()[1];
4021
4022 // Since the codec isn't changing, start_bitrate_bps should be 0.
4023 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4024 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4025 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4026 }
4027
4028 {
4029 // Now try again with the values flipped around.
4030 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4031 send_parameters_.max_bandwidth_bps = 300000;
4032 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4033 ASSERT_EQ(3u,
4034 fake_media_transport.target_rate_constraints_in_order().size());
4035 const webrtc::MediaTransportTargetRateConstraints& constraint =
4036 fake_media_transport.target_rate_constraints_in_order()[2];
4037
4038 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4039 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4040 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4041 }
4042
4043 {
4044 // Now try again with the values flipped around.
4045 // If we change the codec max, max_bandwidth_bps should still apply.
4046 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4047 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4048 ASSERT_EQ(4u,
4049 fake_media_transport.target_rate_constraints_in_order().size());
4050 const webrtc::MediaTransportTargetRateConstraints& constraint =
4051 fake_media_transport.target_rate_constraints_in_order()[3];
4052
4053 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4054 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4055 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4056 }
4057}
4058
Yves Gerey665174f2018-06-19 15:03:05 +02004059TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004060 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4061 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004062 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004063 // Setting max bitrate should keep previous min bitrate.
4064 // Setting max bitrate should not reset start bitrate.
4065 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004066 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004067}
4068
eladalonf1841382017-06-12 01:16:46 -07004069TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004070 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004071 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004072 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004073 // -1 means to disable max bitrate (set infinite).
4074 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004075 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004076 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004077}
4078
eladalonf1841382017-06-12 01:16:46 -07004079TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004080 send_parameters_.max_bandwidth_bps = 99999;
4081 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004082 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004083 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004084 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4085 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4086 stream->GetVideoStreams()[0].max_bitrate_bps);
4087
4088 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004089 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004090 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4091 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004092 stream->GetVideoStreams()[0].max_bitrate_bps);
4093}
4094
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004095// Tests that when the codec specific max bitrate and VideoSendParameters
4096// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4097// appropriately.
4098TEST_F(WebRtcVideoChannelTest,
4099 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4100 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4101 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4102 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4103 send_parameters_.max_bandwidth_bps = -1;
4104 AddSendStream();
4105 ExpectSetMaxBitrate(300000);
4106 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4107
4108 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4109 ASSERT_EQ(1u, video_send_streams.size());
4110 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4111 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4112 // First the max bitrate is set based upon the codec param.
4113 EXPECT_EQ(300000,
4114 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4115
4116 // The VideoSendParameters max bitrate overrides the codec's.
4117 send_parameters_.max_bandwidth_bps = 500000;
4118 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4119 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4120 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4121 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4122}
4123
4124// Tests that when the codec specific max bitrate and RtpParameters
4125// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4126// appropriately.
4127TEST_F(WebRtcVideoChannelTest,
4128 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4129 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4130 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4131 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4132 send_parameters_.max_bandwidth_bps = -1;
4133 AddSendStream();
4134 ExpectSetMaxBitrate(300000);
4135 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4136
4137 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4138 ASSERT_EQ(1u, video_send_streams.size());
4139 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4140 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4141 // First the max bitrate is set based upon the codec param.
4142 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4143
4144 // The RtpParameter max bitrate overrides the codec's.
4145 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4146 ASSERT_EQ(1u, parameters.encodings.size());
4147 parameters.encodings[0].max_bitrate_bps = 500000;
4148 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4149 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4150 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4151 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4152}
4153
Åsa Persson55659812018-06-18 17:51:32 +02004154TEST_F(WebRtcVideoChannelTest,
4155 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4156 send_parameters_.max_bandwidth_bps = 99999;
4157 FakeVideoSendStream* stream = AddSendStream();
4158 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4159 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4160 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4161 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4162 stream->GetVideoStreams()[0].max_bitrate_bps);
4163
4164 // Get and set the rtp encoding parameters.
4165 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4166 EXPECT_EQ(1u, parameters.encodings.size());
4167
4168 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4169 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4170 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4171 stream->GetVideoStreams()[0].max_bitrate_bps);
4172
4173 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4174 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4175 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4176 stream->GetVideoStreams()[0].max_bitrate_bps);
4177}
4178
eladalonf1841382017-06-12 01:16:46 -07004179TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004180 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004181 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004182 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004183 channel_->SetSend(true);
4184
4185 FakeVideoSendStream* stream = AddSendStream();
4186
Niels Möller805a27e2019-01-21 12:21:27 +01004187 webrtc::test::FrameForwarder frame_forwarder;
4188 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004189
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004190 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4191 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4192 EXPECT_GT(initial_max_bitrate_bps, 0);
4193
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004194 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4195 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004196 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004197 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004198 streams = stream->GetVideoStreams();
4199 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004200 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004201}
4202
eladalonf1841382017-06-12 01:16:46 -07004203TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004204 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004205 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004206 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004207 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004208 channel_->SetSend(true);
4209
4210 FakeVideoSendStream* stream = AddSendStream(
4211 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4212
4213 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004214 webrtc::test::FrameForwarder frame_forwarder;
4215 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4216 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004217
4218 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4219 ASSERT_GT(streams.size(), 1u)
4220 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004221 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004222 EXPECT_GT(initial_max_bitrate_bps, 0);
4223
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004224 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4225 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004226 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004227 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004228 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004229 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004230 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4231
Niels Möllerff40b142018-04-09 08:49:14 +02004232 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004233}
4234
eladalonf1841382017-06-12 01:16:46 -07004235TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004236 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004237 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004238 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004239 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4240 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004241 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004242 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004243
4244 VideoCodec codec;
4245 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4246 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4247}
4248
eladalonf1841382017-06-12 01:16:46 -07004249TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004250 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004251 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004252 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004253 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004254 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004255 parameters.codecs[0].id = kIncorrectPayloads[i];
4256 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004257 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004258 }
4259}
4260
eladalonf1841382017-06-12 01:16:46 -07004261TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004262 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004263 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004264 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004265 parameters.codecs[0].id = payload_type;
4266 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004267 << "Payload type '" << payload_type << "' rejected.";
4268 }
4269}
4270
deadbeef67cf2c12016-04-13 10:07:16 -07004271// Test that setting the a different set of codecs but with an identical front
4272// codec doesn't result in the stream being recreated.
4273// This may happen when a subsequent negotiation includes fewer codecs, as a
4274// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004275TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004276 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4277 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004278 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4279 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004280 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4281
4282 AddSendStream();
4283 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4284
4285 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004286 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004287 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4288 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4289}
4290
eladalonf1841382017-06-12 01:16:46 -07004291TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004292 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004293 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004294 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004295}
4296
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004297// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004298TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004299 const int kUnusedPayloadType1 = 126;
4300 const int kUnusedPayloadType2 = 127;
4301 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4302 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4303
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004304 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004305 parameters.codecs.push_back(GetEngineCodec("VP8"));
4306 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004307 parameters.codecs.push_back(rtx_codec);
4308 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004309 << "RTX codec without associated payload should be rejected.";
4310
magjed509e4fe2016-11-18 01:34:11 -08004311 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004312 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004313 << "RTX codec with invalid associated payload type should be rejected.";
4314
magjed509e4fe2016-11-18 01:34:11 -08004315 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004316 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004317
magjed509e4fe2016-11-18 01:34:11 -08004318 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004319 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004320 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004321
Yves Gerey665174f2018-06-19 15:03:05 +02004322 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4323 << "RTX codec with another RTX as associated payload type should be "
4324 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004325}
4326
eladalonf1841382017-06-12 01:16:46 -07004327TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004328 const int kUnusedPayloadType1 = 126;
4329 const int kUnusedPayloadType2 = 127;
4330 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4331 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4332
4333 // SSRCs for RTX.
4334 cricket::StreamParams params =
4335 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4336 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4337 AddRecvStream(params);
4338
4339 // Original payload type for RTX.
4340 cricket::VideoRecvParameters parameters;
4341 parameters.codecs.push_back(GetEngineCodec("VP8"));
4342 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4343 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4344 parameters.codecs.push_back(rtx_codec);
4345 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4346 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4347 const webrtc::VideoReceiveStream::Config& config_before =
4348 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004349 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4350 const int* payload_type_before = FindKeyByValue(
4351 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4352 ASSERT_NE(payload_type_before, nullptr);
4353 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004354 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4355
4356 // Change payload type for RTX.
4357 parameters.codecs[1].id = kUnusedPayloadType2;
4358 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4359 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4360 const webrtc::VideoReceiveStream::Config& config_after =
4361 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004362 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4363 const int* payload_type_after = FindKeyByValue(
4364 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4365 ASSERT_NE(payload_type_after, nullptr);
4366 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004367 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4368}
4369
eladalonf1841382017-06-12 01:16:46 -07004370TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004371 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004372 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004373 parameters.codecs[0].id = 99;
4374 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004375}
4376
eladalonf1841382017-06-12 01:16:46 -07004377TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004378 cricket::VideoRecvParameters parameters;
4379 parameters.codecs = engine_.codecs();
4380 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004381
4382 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004383 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004384 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004385 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004386}
4387
eladalonf1841382017-06-12 01:16:46 -07004388TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004389 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004390 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004391 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004392 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004393}
4394
eladalonf1841382017-06-12 01:16:46 -07004395TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004396 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004397 parameters.codecs.push_back(GetEngineCodec("VP8"));
4398 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004399 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004400}
4401
eladalonf1841382017-06-12 01:16:46 -07004402TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004403 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004404 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4405 send_parameters.codecs.push_back(GetEngineCodec("red"));
4406 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004407 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004408
4409 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004410
magjed509e4fe2016-11-18 01:34:11 -08004411 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004412 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004413
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004414 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004415 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004416 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004417 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004418 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004419 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004420 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4421}
4422
eladalonf1841382017-06-12 01:16:46 -07004423TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004424 AddRecvStream(
4425 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004426 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004427 fake_call_->GetFlexfecReceiveStreams();
4428
4429 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004430 const FakeFlexfecReceiveStream* stream = streams.front();
4431 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4432 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4433 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4434 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004435
4436 cricket::VideoRecvParameters recv_parameters;
4437 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4438 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4439 EXPECT_TRUE(streams.empty())
4440 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004441}
4442
eladalonf1841382017-06-12 01:16:46 -07004443TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004444 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004445 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004446 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004447
4448 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004449 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4450 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4451 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004452 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4453 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004454 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004455 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004456 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004457 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004458
4459 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004460 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4461 send_parameters.codecs.push_back(GetEngineCodec("red"));
4462 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004463 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4464 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004465 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004466 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004467 << "ULPFEC should be enabled on the receive stream.";
4468}
4469
eladalonf1841382017-06-12 01:16:46 -07004470TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004471 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004472 AddRecvStream(
4473 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004474 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004475 fake_call_->GetFlexfecReceiveStreams();
4476
4477 cricket::VideoRecvParameters recv_parameters;
4478 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4479 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4480 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4481 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004482 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004483 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004484 stream_with_recv_params->GetConfig().payload_type);
4485 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004486 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004487 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004488 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004489 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004490
4491 cricket::VideoSendParameters send_parameters;
4492 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4493 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4494 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4495 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004496 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004497 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004498 stream_with_send_params->GetConfig().payload_type);
4499 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004500 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004501 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004502 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004503 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004504}
4505
eladalonf1841382017-06-12 01:16:46 -07004506TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004507 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004508 parameters.codecs.push_back(GetEngineCodec("VP8"));
4509 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004510 parameters.codecs[1].id = parameters.codecs[0].id;
4511 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004512}
4513
eladalonf1841382017-06-12 01:16:46 -07004514TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004515 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004516 cricket::VideoRecvParameters parameters;
4517 parameters.codecs.push_back(GetEngineCodec("VP8"));
4518 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4519 parameters.codecs[1].id = parameters.codecs[0].id;
4520 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4521}
4522
eladalonf1841382017-06-12 01:16:46 -07004523TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004524 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004525 parameters.codecs.push_back(GetEngineCodec("VP8"));
4526 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004527 parameters.codecs[1].id = parameters.codecs[0].id;
4528 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004529}
4530
eladalonf1841382017-06-12 01:16:46 -07004531TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004532 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004533 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004534 parameters.codecs.push_back(GetEngineCodec("VP8"));
4535 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004536 parameters.codecs[1].id += 1;
4537 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004538}
4539
deadbeef67cf2c12016-04-13 10:07:16 -07004540// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004541// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004542TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004543 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004544 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004545 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4546 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004547 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004548
4549 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4550 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4551
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004552 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004553 parameters2.codecs.push_back(GetEngineCodec("red"));
4554 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004555 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004556 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4557}
4558
eladalonf1841382017-06-12 01:16:46 -07004559TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004560 EXPECT_FALSE(AddSendStream()->IsSending());
4561}
4562
eladalonf1841382017-06-12 01:16:46 -07004563TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004564 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004565}
4566
eladalonf1841382017-06-12 01:16:46 -07004567TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004568 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004569 EXPECT_FALSE(stream->IsSending());
4570
4571 // false->true
4572 EXPECT_TRUE(channel_->SetSend(true));
4573 EXPECT_TRUE(stream->IsSending());
4574 // true->true
4575 EXPECT_TRUE(channel_->SetSend(true));
4576 EXPECT_TRUE(stream->IsSending());
4577 // true->false
4578 EXPECT_TRUE(channel_->SetSend(false));
4579 EXPECT_FALSE(stream->IsSending());
4580 // false->false
4581 EXPECT_TRUE(channel_->SetSend(false));
4582 EXPECT_FALSE(stream->IsSending());
4583
4584 EXPECT_TRUE(channel_->SetSend(true));
4585 FakeVideoSendStream* new_stream = AddSendStream();
4586 EXPECT_TRUE(new_stream->IsSending())
4587 << "Send stream created after SetSend(true) not sending initially.";
4588}
4589
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004590// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004591TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004592 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004593 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004594 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004595 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004596 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004597
Sebastian Jansson84848f22018-11-16 10:40:36 +01004598 channel.reset(
4599 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4600 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004601 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004602 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004603 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004604
Tim Haloun648d28a2018-10-18 16:52:22 -07004605 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4606 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004607 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004608 channel.reset(
4609 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4610 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004611 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
Tim Haloun648d28a2018-10-18 16:52:22 -07004612 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4613
4614 // Create a send stream to configure
4615 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4616 parameters = channel->GetRtpSendParameters(kSsrc);
4617 ASSERT_FALSE(parameters.encodings.empty());
4618
4619 // Various priorities map to various dscp values.
4620 parameters.encodings[0].network_priority = 4.0;
4621 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004622 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004623 parameters.encodings[0].network_priority = 0.5;
4624 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4625 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4626
4627 // A bad priority does not change the dscp value.
4628 parameters.encodings[0].network_priority = 0.0;
4629 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4630 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004631
Tim Haloun6ca98362018-09-17 17:06:08 -07004632 // Packets should also self-identify their dscp in PacketOptions.
4633 const uint8_t kData[10] = {0};
4634 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4635 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004636 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004637
nisse51542be2016-02-12 02:27:06 -08004638 // Verify that setting the option to false resets the
4639 // DiffServCodePoint.
4640 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004641 channel.reset(
4642 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
4643 call_.get(), config, VideoOptions(), webrtc::CryptoOptions())));
Anton Sukhanov98a462c2018-10-17 13:15:42 -07004644 channel->SetInterface(network_interface.get(), /*media_transport=*/nullptr);
nisse51542be2016-02-12 02:27:06 -08004645 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004646}
4647
deadbeef13871492015-12-09 12:37:51 -08004648// This test verifies that the RTCP reduced size mode is properly applied to
4649// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004650TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004651 // Create stream, expecting that default mode is "compound".
4652 FakeVideoSendStream* stream1 = AddSendStream();
4653 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004654 webrtc::RtpParameters rtp_parameters =
4655 channel_->GetRtpSendParameters(last_ssrc_);
4656 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004657
4658 // Now enable reduced size mode.
4659 send_parameters_.rtcp.reduced_size = true;
4660 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4661 stream1 = fake_call_->GetVideoSendStreams()[0];
4662 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004663 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4664 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004665
4666 // Create a new stream and ensure it picks up the reduced size mode.
4667 FakeVideoSendStream* stream2 = AddSendStream();
4668 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4669}
4670
4671// This test verifies that the RTCP reduced size mode is properly applied to
4672// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004673TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004674 // Create stream, expecting that default mode is "compound".
4675 FakeVideoReceiveStream* stream1 = AddRecvStream();
4676 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4677
4678 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004679 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4680 // the reduced_size flag should come from that.
4681 send_parameters_.rtcp.reduced_size = true;
4682 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004683 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4684 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4685
4686 // Create a new stream and ensure it picks up the reduced size mode.
4687 FakeVideoReceiveStream* stream2 = AddRecvStream();
4688 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4689}
4690
eladalonf1841382017-06-12 01:16:46 -07004691TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004692 EXPECT_EQ(webrtc::kNetworkUp,
4693 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4694 EXPECT_EQ(webrtc::kNetworkUp,
4695 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004696
4697 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004698 EXPECT_EQ(webrtc::kNetworkDown,
4699 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4700 EXPECT_EQ(webrtc::kNetworkUp,
4701 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004702
4703 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004704 EXPECT_EQ(webrtc::kNetworkUp,
4705 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4706 EXPECT_EQ(webrtc::kNetworkUp,
4707 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004708}
4709
eladalonf1841382017-06-12 01:16:46 -07004710TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004711 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004712 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004713 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004714
4715 AddSendStream();
4716
4717 cricket::VideoMediaInfo info;
4718 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004719 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004720}
4721
eladalonf1841382017-06-12 01:16:46 -07004722TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004723 FakeVideoSendStream* stream = AddSendStream();
4724 webrtc::VideoSendStream::Stats stats;
4725 stats.encoder_implementation_name = "encoder_implementation_name";
4726 stream->SetStats(stats);
4727
4728 cricket::VideoMediaInfo info;
4729 ASSERT_TRUE(channel_->GetStats(&info));
4730 EXPECT_EQ(stats.encoder_implementation_name,
4731 info.senders[0].encoder_implementation_name);
4732}
4733
eladalonf1841382017-06-12 01:16:46 -07004734TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004735 FakeVideoSendStream* stream = AddSendStream();
4736 webrtc::VideoSendStream::Stats stats;
4737 stats.avg_encode_time_ms = 13;
4738 stats.encode_usage_percent = 42;
4739 stream->SetStats(stats);
4740
4741 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004742 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004743 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4744 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4745}
4746
eladalonf1841382017-06-12 01:16:46 -07004747TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004748 FakeVideoSendStream* stream = AddSendStream();
4749 webrtc::VideoSendStream::Stats stats;
4750 stats.frames_encoded = 13;
4751 stream->SetStats(stats);
4752
4753 cricket::VideoMediaInfo info;
4754 ASSERT_TRUE(channel_->GetStats(&info));
4755 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4756}
4757
eladalonf1841382017-06-12 01:16:46 -07004758TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004759 FakeVideoSendStream* stream = AddSendStream();
4760 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004761 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004762 stream->SetStats(stats);
4763
4764 cricket::VideoMediaInfo info;
4765 ASSERT_TRUE(channel_->GetStats(&info));
4766 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4767}
4768
eladalonf1841382017-06-12 01:16:46 -07004769TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004770 FakeVideoSendStream* stream = AddSendStream();
4771 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004772 stats.substreams[17].width = 123;
4773 stats.substreams[17].height = 40;
4774 stats.substreams[42].width = 80;
4775 stats.substreams[42].height = 31;
4776 stats.substreams[11].width = 20;
4777 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004778 stream->SetStats(stats);
4779
4780 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004781 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004782 ASSERT_EQ(1u, info.senders.size());
4783 EXPECT_EQ(123, info.senders[0].send_frame_width);
4784 EXPECT_EQ(90, info.senders[0].send_frame_height);
4785}
4786
eladalonf1841382017-06-12 01:16:46 -07004787TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004788 FakeVideoSendStream* stream = AddSendStream();
4789 webrtc::VideoSendStream::Stats stats;
4790 stats.number_of_cpu_adapt_changes = 2;
4791 stats.cpu_limited_resolution = true;
4792 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004793
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004794 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004795 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004796 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004797 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004798 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004799}
4800
eladalonf1841382017-06-12 01:16:46 -07004801TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004802 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004803 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004804 stats.number_of_cpu_adapt_changes = 2;
4805 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004806 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004807 stream->SetStats(stats);
4808
4809 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004810 EXPECT_TRUE(channel_->GetStats(&info));
4811 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004812 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4813 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004814 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004815 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004816}
4817
eladalonf1841382017-06-12 01:16:46 -07004818TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08004819 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
4820 FakeVideoSendStream* stream = AddSendStream();
4821 webrtc::VideoSendStream::Stats stats;
4822 stats.bw_limited_resolution = true;
4823 stream->SetStats(stats);
4824
4825 cricket::VideoMediaInfo info;
4826 EXPECT_TRUE(channel_->GetStats(&info));
4827 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004828 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004829 info.senders[0].adapt_reason);
4830}
4831
Yves Gerey665174f2018-06-19 15:03:05 +02004832TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004833 FakeVideoSendStream* stream = AddSendStream();
4834 webrtc::VideoSendStream::Stats stats;
4835 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
4836 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
4837 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
4838
4839 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
4840 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
4841 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
4842
4843 stream->SetStats(stats);
4844
4845 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004846 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004847 EXPECT_EQ(7, info.senders[0].firs_rcvd);
4848 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
4849 EXPECT_EQ(13, info.senders[0].plis_rcvd);
4850}
4851
eladalonf1841382017-06-12 01:16:46 -07004852TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004853 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
4854 FakeVideoReceiveStream* stream = AddRecvStream();
4855 webrtc::VideoReceiveStream::Stats stats;
4856 stats.rtcp_packet_type_counts.fir_packets = 2;
4857 stats.rtcp_packet_type_counts.nack_packets = 3;
4858 stats.rtcp_packet_type_counts.pli_packets = 4;
4859 stream->SetStats(stats);
4860
4861 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004862 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004863 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004864 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004865 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004866 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004867 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004868 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00004869}
4870
eladalonf1841382017-06-12 01:16:46 -07004871TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004872 FakeVideoReceiveStream* stream = AddRecvStream();
4873 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01004874 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004875 stats.decode_ms = 2;
4876 stats.max_decode_ms = 3;
4877 stats.current_delay_ms = 4;
4878 stats.target_delay_ms = 5;
4879 stats.jitter_buffer_ms = 6;
4880 stats.min_playout_delay_ms = 7;
4881 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07004882 stats.width = 9;
4883 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08004884 stats.frame_counts.key_frames = 11;
4885 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08004886 stats.frames_rendered = 13;
4887 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01004888 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004889 stream->SetStats(stats);
4890
4891 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004892 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01004893 EXPECT_EQ(stats.decoder_implementation_name,
4894 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004895 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
4896 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
4897 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
4898 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
4899 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
4900 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
4901 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07004902 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
4903 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004904 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
4905 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08004906 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08004907 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07004908 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08004909 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004910}
4911
eladalonf1841382017-06-12 01:16:46 -07004912TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02004913 FakeVideoReceiveStream* stream = AddRecvStream();
4914 webrtc::VideoReceiveStream::Stats stats;
4915 stats.rtp_stats.transmitted.payload_bytes = 2;
4916 stats.rtp_stats.transmitted.header_bytes = 3;
4917 stats.rtp_stats.transmitted.padding_bytes = 4;
4918 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07004919 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02004920 stats.rtcp_stats.fraction_lost = 7;
4921 stream->SetStats(stats);
4922
4923 cricket::VideoMediaInfo info;
4924 ASSERT_TRUE(channel_->GetStats(&info));
4925 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
4926 stats.rtp_stats.transmitted.header_bytes +
4927 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004928 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02004929 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02004930 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07004931 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004932 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02004933 info.receivers[0].fraction_lost);
4934}
4935
eladalonf1841382017-06-12 01:16:46 -07004936TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004937 AddSendStream();
4938 AddSendStream();
4939 webrtc::Call::Stats stats;
4940 stats.rtt_ms = 123;
4941 fake_call_->SetStats(stats);
4942
4943 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004944 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00004945 ASSERT_EQ(2u, info.senders.size());
4946 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
4947 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
4948}
4949
eladalonf1841382017-06-12 01:16:46 -07004950TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004951 FakeVideoSendStream* stream = AddSendStream();
4952 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004953 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004954 stats.media_bitrate_bps = 123;
4955 stats.substreams[17].total_bitrate_bps = 1;
4956 stats.substreams[17].retransmit_bitrate_bps = 2;
4957 stats.substreams[42].total_bitrate_bps = 3;
4958 stats.substreams[42].retransmit_bitrate_bps = 4;
4959 stream->SetStats(stats);
4960
4961 FakeVideoSendStream* stream2 = AddSendStream();
4962 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004963 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004964 stats2.media_bitrate_bps = 321;
4965 stats2.substreams[13].total_bitrate_bps = 5;
4966 stats2.substreams[13].retransmit_bitrate_bps = 6;
4967 stats2.substreams[21].total_bitrate_bps = 7;
4968 stats2.substreams[21].retransmit_bitrate_bps = 8;
4969 stream2->SetStats(stats2);
4970
4971 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004972 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004973 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07004974 BandwidthEstimationInfo bwe_info;
4975 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004976 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
4977 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
4978 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
4979 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00004980 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004981 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004982 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07004983 bwe_info.actual_enc_bitrate);
4984 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004985 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07004986 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00004987 << "Bandwidth stats should take all streams into account.";
4988}
4989
eladalonf1841382017-06-12 01:16:46 -07004990TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004991 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004992
Peter Boström0c4e06b2015-10-07 12:23:21 +02004993 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
4994 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00004995
4996 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
4997 const size_t kDataLength = 12;
4998 uint8_t data[kDataLength];
4999 memset(data, 0, sizeof(data));
5000 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005001 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005002 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005003
5004 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5005 << "No default receive stream created.";
5006 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005007 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005008 << "Default receive stream should not have configured RTX";
5009
5010 EXPECT_TRUE(channel_->AddRecvStream(
5011 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5012 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005013 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005014 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005015 EXPECT_FALSE(
5016 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005017 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005018 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005019 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005020 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005021 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005022 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005023}
5024
eladalonf1841382017-06-12 01:16:46 -07005025TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005026 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005027
Peter Boström0c4e06b2015-10-07 12:23:21 +02005028 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5029 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005030
5031 StreamParams sp =
5032 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5033 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5034
5035 EXPECT_FALSE(channel_->AddSendStream(sp));
5036 EXPECT_FALSE(channel_->AddRecvStream(sp));
5037}
5038
eladalonf1841382017-06-12 01:16:46 -07005039TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005040 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005041
Peter Boström0c4e06b2015-10-07 12:23:21 +02005042 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5043 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005044
5045 StreamParams sp =
5046 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5047
5048 EXPECT_TRUE(channel_->AddSendStream(sp));
5049 EXPECT_TRUE(channel_->AddRecvStream(sp));
5050
5051 // The RTX SSRC is already used in previous streams, using it should fail.
5052 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5053 EXPECT_FALSE(channel_->AddSendStream(sp));
5054 EXPECT_FALSE(channel_->AddRecvStream(sp));
5055
5056 // After removing the original stream this should be fine to add (makes sure
5057 // that RTX ssrcs are not forever taken).
5058 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5059 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5060 EXPECT_TRUE(channel_->AddSendStream(sp));
5061 EXPECT_TRUE(channel_->AddRecvStream(sp));
5062}
5063
eladalonf1841382017-06-12 01:16:46 -07005064TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005065 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005066 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5067 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005068 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005069
Peter Boströmd6f4c252015-03-26 16:23:04 +01005070 StreamParams sp =
5071 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5072
5073 EXPECT_TRUE(channel_->AddSendStream(sp));
5074 EXPECT_TRUE(channel_->AddRecvStream(sp));
5075
5076 // One of the SSRCs is already used in previous streams, using it should fail.
5077 sp = cricket::CreateSimStreamParams("cname",
5078 MAKE_VECTOR(kOverlappingStreamSsrcs));
5079 EXPECT_FALSE(channel_->AddSendStream(sp));
5080 EXPECT_FALSE(channel_->AddRecvStream(sp));
5081
5082 // After removing the original stream this should be fine to add (makes sure
5083 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005084 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5085 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005086 EXPECT_TRUE(channel_->AddSendStream(sp));
5087 EXPECT_TRUE(channel_->AddRecvStream(sp));
5088}
5089
eladalonf1841382017-06-12 01:16:46 -07005090TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005091 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005092
5093 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5094 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5095
5096 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5097 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5098
5099 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5100
5101 static const uint32_t kReceiverSsrcs[] = {3};
5102 static const uint32_t kReceiverRtxSsrcs[] = {2};
5103
5104 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5105 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5106 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5107
5108 cricket::VideoMediaInfo info;
5109 ASSERT_TRUE(channel_->GetStats(&info));
5110
5111 ASSERT_EQ(1u, info.senders.size());
5112 ASSERT_EQ(1u, info.receivers.size());
5113
5114 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5115 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5116 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5117}
5118
eladalonf1841382017-06-12 01:16:46 -07005119TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005120 FakeVideoReceiveStream* stream = AddRecvStream();
5121 webrtc::VideoReceiveStream::Stats stats;
5122 cricket::VideoMediaInfo info;
5123
5124 // Report no codec name before receiving.
5125 stream->SetStats(stats);
5126 ASSERT_TRUE(channel_->GetStats(&info));
5127 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5128
5129 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005130 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005131 stream->SetStats(stats);
5132 ASSERT_TRUE(channel_->GetStats(&info));
5133 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5134
5135 // Report no codec name for unknown playload types.
5136 stats.current_payload_type = 3;
5137 stream->SetStats(stats);
5138 ASSERT_TRUE(channel_->GetStats(&info));
5139 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5140}
5141
Seth Hampson5897a6e2018-04-03 11:16:33 -07005142// Tests that when we add a stream without SSRCs, but contains a stream_id
5143// that it is stored and its stream id is later used when the first packet
5144// arrives to properly create a receive stream with a sync label.
5145TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5146 const char kSyncLabel[] = "sync_label";
5147 cricket::StreamParams unsignaled_stream;
5148 unsignaled_stream.set_stream_ids({kSyncLabel});
5149 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5150 // The stream shouldn't have been created at this point because it doesn't
5151 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005152 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005153
5154 // Create and deliver packet.
5155 const size_t kDataLength = 12;
5156 uint8_t data[kDataLength];
5157 memset(data, 0, sizeof(data));
5158 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5159 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005160 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005161
5162 // The stream should now be created with the appropriate sync label.
5163 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5164 EXPECT_EQ(kSyncLabel,
5165 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5166
5167 // Removing the unsignaled stream should clear the cache. This time when
5168 // a default video receive stream is created it won't have a sync_group.
5169 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5170 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5171 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5172
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005173 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005174 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5175 EXPECT_TRUE(
5176 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5177}
5178
Ruslan Burakov493a6502019-02-27 15:32:48 +01005179// Test BaseMinimumPlayoutDelayMs on receive streams.
5180TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5181 // Test that set won't work for non-existing receive streams.
5182 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5183 // Test that get won't work for non-existing receive streams.
5184 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5185
5186 EXPECT_TRUE(AddRecvStream());
5187 // Test that set works for the existing receive stream.
5188 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5189 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5190 EXPECT_TRUE(recv_stream);
5191 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5192 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5193 200);
5194}
5195
5196// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5197TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5198 absl::optional<int> delay_ms;
5199 const FakeVideoReceiveStream* recv_stream;
5200
5201 // Set default stream with SSRC 0
5202 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5203 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5204
5205 // Spawn an unsignaled stream by sending a packet, it should inherit
5206 // default delay 200.
5207 const size_t kDataLength = 12;
5208 uint8_t data[kDataLength];
5209 memset(data, 0, sizeof(data));
5210 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5211 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005212 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005213
5214 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5215 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5216 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5217 EXPECT_EQ(200, delay_ms.value_or(0));
5218
5219 // Check that now if we change delay for SSRC 0 it will change delay for the
5220 // default receiving stream as well.
5221 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5222 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5223 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5224 EXPECT_EQ(300, delay_ms.value_or(0));
5225 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5226 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5227}
5228
eladalonf1841382017-06-12 01:16:46 -07005229void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005230 uint8_t payload_type,
5231 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005232 // kRedRtxPayloadType must currently be unused.
5233 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5234
noahricd10a68e2015-07-10 11:27:55 -07005235 // Add a RED RTX codec.
5236 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005237 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005238 recv_parameters_.codecs.push_back(red_rtx_codec);
5239 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005240
5241 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5242 const size_t kDataLength = 12;
5243 uint8_t data[kDataLength];
5244 memset(data, 0, sizeof(data));
5245
5246 rtc::Set8(data, 1, payload_type);
5247 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005248 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005249 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005250
5251 if (expect_created_receive_stream) {
5252 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5253 << "Should have created a receive stream for payload type: "
5254 << payload_type;
5255 } else {
5256 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5257 << "Shouldn't have created a receive stream for payload type: "
5258 << payload_type;
5259 }
5260}
5261
Åsa Persson2c7149b2018-10-15 09:36:10 +02005262class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5263 public:
5264 WebRtcVideoChannelDiscardUnknownSsrcTest()
5265 : WebRtcVideoChannelTest(
5266 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5267};
5268
5269TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5270 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5271 false /* expect_created_receive_stream */);
5272}
5273
eladalonf1841382017-06-12 01:16:46 -07005274TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005275 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5276 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005277}
5278
eladalonf1841382017-06-12 01:16:46 -07005279TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005280 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5281 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005282}
5283
eladalonf1841382017-06-12 01:16:46 -07005284TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005285 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005286 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5287 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5288 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5289 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005290}
5291
eladalonf1841382017-06-12 01:16:46 -07005292TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005293 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5294 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005295}
5296
eladalonf1841382017-06-12 01:16:46 -07005297TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005298 FlexfecPacketDoesntCreateUnsignalledStream) {
5299 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5300 false /* expect_created_receive_stream */);
5301}
5302
eladalonf1841382017-06-12 01:16:46 -07005303TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005304 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5305 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005306}
5307
mzanaty8a855d62017-02-17 15:46:43 -08005308// Test that receiving any unsignalled SSRC works even if it changes.
5309// The first unsignalled SSRC received will create a default receive stream.
5310// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005311TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005312 // Allow receiving VP8, VP9, H264 (if enabled).
5313 cricket::VideoRecvParameters parameters;
5314 parameters.codecs.push_back(GetEngineCodec("VP8"));
5315 parameters.codecs.push_back(GetEngineCodec("VP9"));
5316
5317#if defined(WEBRTC_USE_H264)
5318 cricket::VideoCodec H264codec(126, "H264");
5319 parameters.codecs.push_back(H264codec);
5320#endif
5321
5322 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5323 // No receive streams yet.
5324 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5325 cricket::FakeVideoRenderer renderer;
5326 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5327
5328 // Receive VP8 packet on first SSRC.
5329 uint8_t data[kMinRtpPacketLen];
5330 cricket::RtpHeader rtpHeader;
5331 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5332 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005333 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005334 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5335 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005336 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005337 // VP8 packet should create default receive stream.
5338 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005339 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005340 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5341 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005342 webrtc::VideoFrame video_frame =
5343 webrtc::VideoFrame::Builder()
5344 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5345 .set_timestamp_rtp(100)
5346 .set_timestamp_us(0)
5347 .set_rotation(webrtc::kVideoRotation_0)
5348 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005349 recv_stream->InjectFrame(video_frame);
5350 EXPECT_EQ(1, renderer.num_rendered_frames());
5351
5352 // Receive VP9 packet on second SSRC.
5353 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005354 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005355 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5356 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005357 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005358 // VP9 packet should replace the default receive SSRC.
5359 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5360 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5361 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5362 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005363 webrtc::VideoFrame video_frame2 =
5364 webrtc::VideoFrame::Builder()
5365 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5366 .set_timestamp_rtp(200)
5367 .set_timestamp_us(0)
5368 .set_rotation(webrtc::kVideoRotation_0)
5369 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005370 recv_stream->InjectFrame(video_frame2);
5371 EXPECT_EQ(2, renderer.num_rendered_frames());
5372
5373#if defined(WEBRTC_USE_H264)
5374 // Receive H264 packet on third SSRC.
5375 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005376 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005377 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5378 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005379 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005380 // H264 packet should replace the default receive SSRC.
5381 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5382 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5383 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5384 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005385 webrtc::VideoFrame video_frame3 =
5386 webrtc::VideoFrame::Builder()
5387 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5388 .set_timestamp_rtp(300)
5389 .set_timestamp_us(0)
5390 .set_rotation(webrtc::kVideoRotation_0)
5391 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005392 recv_stream->InjectFrame(video_frame3);
5393 EXPECT_EQ(3, renderer.num_rendered_frames());
5394#endif
5395}
5396
brandtr0dc57ea2017-05-29 23:33:31 -07005397// This test verifies that when a new default stream is created for a new
5398// unsignaled SSRC, the new stream does not overwrite any old stream that had
5399// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005400TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005401 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5402 cricket::VideoRecvParameters parameters;
5403 parameters.codecs.push_back(GetEngineCodec("VP8"));
5404 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5405
5406 // No streams signaled and no packets received, so we should not have any
5407 // stream objects created yet.
5408 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5409
5410 // Receive packet on an unsignaled SSRC.
5411 uint8_t data[kMinRtpPacketLen];
5412 cricket::RtpHeader rtp_header;
5413 rtp_header.payload_type = GetEngineCodec("VP8").id;
5414 rtp_header.seq_num = rtp_header.timestamp = 0;
5415 rtp_header.ssrc = kSsrcs3[0];
5416 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5417 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005418 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005419 // Default receive stream should be created.
5420 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5421 FakeVideoReceiveStream* recv_stream0 =
5422 fake_call_->GetVideoReceiveStreams()[0];
5423 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5424
5425 // Signal the SSRC.
5426 EXPECT_TRUE(
5427 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5428 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5429 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5430 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5431
5432 // Receive packet on a different unsignaled SSRC.
5433 rtp_header.ssrc = kSsrcs3[1];
5434 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5435 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005436 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005437 // New default receive stream should be created, but old stream should remain.
5438 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5439 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5440 FakeVideoReceiveStream* recv_stream1 =
5441 fake_call_->GetVideoReceiveStreams()[1];
5442 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5443}
5444
Seth Hampson7c682e02018-05-04 16:28:15 -07005445TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005446 AddSendStream();
5447
Niels Möller805a27e2019-01-21 12:21:27 +01005448 webrtc::test::FrameForwarder frame_forwarder;
5449 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005450 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005451 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005452
perkjfa10b552016-10-02 23:45:26 -07005453 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005454 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005455
5456 // TODO(skvlad): Resolve the inconsistency between the interpretation
5457 // of the global bitrate limit for audio and video:
5458 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5459 // max_bandwidth_bps = -1 - remove the bandwidth limit
5460 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005461 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005462
perkjfa10b552016-10-02 23:45:26 -07005463 SetAndExpectMaxBitrate(1000, 0, 1000);
5464 SetAndExpectMaxBitrate(1000, 800, 800);
5465 SetAndExpectMaxBitrate(600, 800, 600);
5466 SetAndExpectMaxBitrate(0, 800, 800);
5467 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005468
Niels Möllerff40b142018-04-09 08:49:14 +02005469 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005470}
5471
eladalonf1841382017-06-12 01:16:46 -07005472TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005473 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005474 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005475 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005476
5477 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005478 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005479 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005480}
5481
eladalonf1841382017-06-12 01:16:46 -07005482TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005483 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005484 FakeVideoSendStream* stream = AddSendStream();
5485
Seth Hampson7c682e02018-05-04 16:28:15 -07005486 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5487 EXPECT_EQ(1UL, parameters.encodings.size());
5488 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5489 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5490
5491 // Note that this is testing the behavior of the FakeVideoSendStream, which
5492 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5493 // we are just testing the behavior of
5494 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005495 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5496 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005497
5498 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5499 // by this amount.
5500 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5501 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5502 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5503 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5504
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005505 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5506 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5507 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5508}
5509
5510TEST_F(WebRtcVideoChannelTest,
5511 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5512 FakeVideoSendStream* stream = AddSendStream();
5513
5514 // Note that this is testing the behavior of the FakeVideoSendStream, which
5515 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5516 // we are just testing the behavior of
5517 // EncoderStreamFactory::CreateEncoderStreams.
5518 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5519 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5520
5521 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5522 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5523 EXPECT_EQ(1UL, parameters.encodings.size());
5524 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5525 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5526
5527 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5528 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5529 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5530}
5531
5532TEST_F(WebRtcVideoChannelTest,
5533 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5534 send_parameters_.max_bandwidth_bps = 99999;
5535 FakeVideoSendStream* stream = AddSendStream();
5536 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5537 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5538 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5539 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5540 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5541 stream->GetVideoStreams()[0].max_bitrate_bps);
5542
5543 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5544 // adjusted down.
5545 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5546 EXPECT_EQ(1UL, parameters.encodings.size());
5547 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5548 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5549 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5550 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5551 stream->GetVideoStreams()[0].min_bitrate_bps);
5552 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5553 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005554}
5555
Åsa Persson8c1bf952018-09-13 10:42:19 +02005556TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5557 FakeVideoSendStream* stream = AddSendStream();
5558
5559 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5560 EXPECT_EQ(1UL, parameters.encodings.size());
5561 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5562 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5563
5564 // Note that this is testing the behavior of the FakeVideoSendStream, which
5565 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5566 // we are just testing the behavior of
5567 // EncoderStreamFactory::CreateEncoderStreams.
5568 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5569 EXPECT_EQ(kDefaultVideoMaxFramerate,
5570 stream->GetVideoStreams()[0].max_framerate);
5571
5572 // Set max framerate and check that VideoStream.max_framerate is set.
5573 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5574 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5575 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5576 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5577
5578 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5579 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5580}
5581
Åsa Persson23eba222018-10-02 14:47:06 +02005582TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5583 FakeVideoSendStream* stream = AddSendStream();
5584
5585 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5586 EXPECT_EQ(1UL, parameters.encodings.size());
5587 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5588 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5589
5590 // Note that this is testing the behavior of the FakeVideoSendStream, which
5591 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5592 // we are just testing the behavior of
5593 // EncoderStreamFactory::CreateEncoderStreams.
5594 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5595 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5596
5597 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5598 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5599 parameters.encodings[0].num_temporal_layers = 2;
5600 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5601
5602 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5603 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5604}
5605
Seth Hampson7c682e02018-05-04 16:28:15 -07005606TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005607 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005608 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005609 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005610 // Two or more encodings should result in failure.
5611 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005612 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005613 // Zero encodings should also fail.
5614 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005615 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005616}
5617
Zach Stein3ca452b2018-01-18 10:01:24 -08005618TEST_F(WebRtcVideoChannelTest,
5619 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5620 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5621 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5622 AddSendStream(sp);
5623
5624 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5625
5626 // Additional encodings should result in failure.
5627 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005628 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005629 // Zero encodings should also fail.
5630 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005631 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005632}
5633
deadbeeffb2aced2017-01-06 23:05:37 -08005634// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005635TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005636 AddSendStream();
5637 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005638 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005639 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005640}
5641
Seth Hampson24722b32017-12-22 09:36:42 -08005642// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5643// a value <= 0, setting the parameters returns false.
5644TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5645 AddSendStream();
5646 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5647 EXPECT_EQ(1UL, parameters.encodings.size());
5648 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5649 parameters.encodings[0].bitrate_priority);
5650
5651 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005652 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005653 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005654 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005655}
5656
5657// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5658// properly on the VideoChannel and propogates down to the video encoder.
5659TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5660 AddSendStream();
5661 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5662 EXPECT_EQ(1UL, parameters.encodings.size());
5663 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5664 parameters.encodings[0].bitrate_priority);
5665
5666 // Change the value and set it on the VideoChannel.
5667 double new_bitrate_priority = 2.0;
5668 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005669 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005670
5671 // Verify that the encoding parameters bitrate_priority is set for the
5672 // VideoChannel.
5673 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5674 EXPECT_EQ(1UL, parameters.encodings.size());
5675 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5676
5677 // Verify that the new value propagated down to the encoder.
5678 std::vector<FakeVideoSendStream*> video_send_streams =
5679 fake_call_->GetVideoSendStreams();
5680 EXPECT_EQ(1UL, video_send_streams.size());
5681 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5682 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5683 // appropriately.
5684 EXPECT_EQ(new_bitrate_priority,
5685 video_send_stream->GetEncoderConfig().bitrate_priority);
5686 // Check that the vector of VideoStreams also was propagated correctly. Note
5687 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5688 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005689 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005690 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5691}
5692
5693// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5694// VideoChannel and the value propogates to the video encoder with all simulcast
5695// streams.
5696TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5697 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005698 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005699 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5700 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5701 AddSendStream(stream_params);
5702 uint32_t primary_ssrc = stream_params.first_ssrc();
5703
Niels Möller805a27e2019-01-21 12:21:27 +01005704 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005705 // frame. This creates multiple VideoStreams for all simulcast layers when
5706 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005707 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005708 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005709 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005710 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005711 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5712 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5713 rtc::kNumMicrosecsPerSec / 30));
5714
Seth Hampson24722b32017-12-22 09:36:42 -08005715 // Get and set the rtp encoding parameters.
5716 webrtc::RtpParameters parameters =
5717 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005718 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005719 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5720 parameters.encodings[0].bitrate_priority);
5721 // Change the value and set it on the VideoChannel.
5722 double new_bitrate_priority = 2.0;
5723 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005724 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005725
5726 // Verify that the encoding parameters priority is set on the VideoChannel.
5727 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005728 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005729 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5730
5731 // Verify that the new value propagated down to the encoder.
5732 std::vector<FakeVideoSendStream*> video_send_streams =
5733 fake_call_->GetVideoSendStreams();
5734 EXPECT_EQ(1UL, video_send_streams.size());
5735 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5736 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5737 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005738 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005739 video_send_stream->GetEncoderConfig().number_of_streams);
5740 EXPECT_EQ(new_bitrate_priority,
5741 video_send_stream->GetEncoderConfig().bitrate_priority);
5742 // Check that the vector of VideoStreams also propagated correctly. The
5743 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5744 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005745 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005746 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005747 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5748 // Since we are only setting bitrate priority per-sender, the other
5749 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005750 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005751 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005752 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005753 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005754 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005755}
5756
Tim Haloun648d28a2018-10-18 16:52:22 -07005757// RTCRtpEncodingParameters.network_priority must be one of a few values
5758// derived from the default priority, corresponding to very-low, low, medium,
5759// or high.
5760TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5761 AddSendStream();
5762 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5763 EXPECT_EQ(1UL, parameters.encodings.size());
5764 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5765 parameters.encodings[0].network_priority);
5766
5767 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5768 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5769 for (auto it : good_values) {
5770 parameters.encodings[0].network_priority = it;
5771 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5772 }
5773 for (auto it : bad_values) {
5774 parameters.encodings[0].network_priority = it;
5775 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5776 }
5777}
5778
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005779TEST_F(WebRtcVideoChannelTest,
5780 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005781 VideoSendParameters parameters;
5782 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005783 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5784 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5785
5786 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005787 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005788
5789 VideoOptions options;
5790 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5791 channel_->SetSend(true);
5792
5793 // Try layers in natural order (smallest to largest).
5794 {
5795 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5796 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5797 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5798 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5799 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5800 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5801 ASSERT_TRUE(result.ok());
5802
5803 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5804
5805 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5806 ASSERT_EQ(3u, video_streams.size());
5807 EXPECT_EQ(320u, video_streams[0].width);
5808 EXPECT_EQ(180u, video_streams[0].height);
5809 EXPECT_EQ(640u, video_streams[1].width);
5810 EXPECT_EQ(360u, video_streams[1].height);
5811 EXPECT_EQ(1280u, video_streams[2].width);
5812 EXPECT_EQ(720u, video_streams[2].height);
5813 }
5814
5815 // Try layers in reverse natural order (largest to smallest).
5816 {
5817 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5818 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5819 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5820 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5821 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5822 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5823 ASSERT_TRUE(result.ok());
5824
5825 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5826
5827 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5828 ASSERT_EQ(3u, video_streams.size());
5829 EXPECT_EQ(1280u, video_streams[0].width);
5830 EXPECT_EQ(720u, video_streams[0].height);
5831 EXPECT_EQ(640u, video_streams[1].width);
5832 EXPECT_EQ(360u, video_streams[1].height);
5833 EXPECT_EQ(320u, video_streams[2].width);
5834 EXPECT_EQ(180u, video_streams[2].height);
5835 }
5836
5837 // Try layers in mixed order.
5838 {
5839 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5840 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5841 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5842 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5843 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5844 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5845 ASSERT_TRUE(result.ok());
5846
5847 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5848
5849 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5850 ASSERT_EQ(3u, video_streams.size());
5851 EXPECT_EQ(128u, video_streams[0].width);
5852 EXPECT_EQ(72u, video_streams[0].height);
5853 EXPECT_EQ(640u, video_streams[1].width);
5854 EXPECT_EQ(360u, video_streams[1].height);
5855 EXPECT_EQ(320u, video_streams[2].width);
5856 EXPECT_EQ(180u, video_streams[2].height);
5857 }
5858
5859 // Try with a missing scale setting, defaults to 1.0 if any other is set.
5860 {
5861 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5862 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5863 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5864 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
5865 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5866 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5867 ASSERT_TRUE(result.ok());
5868
5869 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5870
5871 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5872 ASSERT_EQ(3u, video_streams.size());
5873 EXPECT_EQ(1280u, video_streams[0].width);
5874 EXPECT_EQ(720u, video_streams[0].height);
5875 EXPECT_EQ(1280u, video_streams[1].width);
5876 EXPECT_EQ(720u, video_streams[1].height);
5877 EXPECT_EQ(320u, video_streams[2].width);
5878 EXPECT_EQ(180u, video_streams[2].height);
5879 }
5880
5881 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5882}
5883
5884TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01005885 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
5886 // Ensure that the top layer has width and height divisible by 2^3,
5887 // so that the bottom layer has width and height divisible by 2.
5888 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
5889 // the number of simulcast layers set by the app.
5890 webrtc::test::ScopedFieldTrials field_trial(
5891 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
5892
5893 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
5894 VideoSendParameters parameters;
5895 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
5896 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5897 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5898 webrtc::test::FrameForwarder frame_forwarder;
5899 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
5900 &frame_forwarder));
5901 channel_->SetSend(true);
5902
5903 // Set |scale_resolution_down_by|'s.
5904 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5905 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
5906 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5907 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5908 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5909 const auto result =
5910 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5911 ASSERT_TRUE(result.ok());
5912
5913 // Use a capture resolution whose width and height are not divisible by 2^3.
5914 // (See field trial set at the top of the test.)
5915 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
5916 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5917
5918 // Ensure the scaling is correct.
5919 const auto video_streams = stream->GetVideoStreams();
5920 ASSERT_EQ(video_streams.size(), 3u);
5921 // Ensure that we round the capture resolution down for the top layer...
5922 EXPECT_EQ(video_streams[0].width, 2000u);
5923 EXPECT_EQ(video_streams[0].height, 1200u);
5924 EXPECT_EQ(video_streams[1].width, 1000u);
5925 EXPECT_EQ(video_streams[1].height, 600u);
5926 // ...and that the bottom layer has a width/height divisible by 2.
5927 EXPECT_EQ(video_streams[2].width, 500u);
5928 EXPECT_EQ(video_streams[2].height, 300u);
5929
5930 // Tear down.
5931 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
5932}
5933
5934TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005935 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005936 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
5937 VideoSendParameters parameters;
5938 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005939 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5940 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5941
5942 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005943 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005944
5945 VideoOptions options;
5946 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5947 channel_->SetSend(true);
5948
5949 // Try layers in natural order (smallest to largest).
5950 {
5951 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5952 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5953 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5954 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5955 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5956 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5957 ASSERT_TRUE(result.ok());
5958
5959 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5960
5961 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5962 ASSERT_EQ(3u, video_streams.size());
5963 EXPECT_EQ(320u, video_streams[0].width);
5964 EXPECT_EQ(180u, video_streams[0].height);
5965 EXPECT_EQ(640u, video_streams[1].width);
5966 EXPECT_EQ(360u, video_streams[1].height);
5967 EXPECT_EQ(1280u, video_streams[2].width);
5968 EXPECT_EQ(720u, video_streams[2].height);
5969 }
5970
5971 // Try layers in reverse natural order (largest to smallest).
5972 {
5973 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5974 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5975 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
5976 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5977 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
5978 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5979 ASSERT_TRUE(result.ok());
5980
5981 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5982
5983 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5984 ASSERT_EQ(3u, video_streams.size());
5985 EXPECT_EQ(1280u, video_streams[0].width);
5986 EXPECT_EQ(720u, video_streams[0].height);
5987 EXPECT_EQ(640u, video_streams[1].width);
5988 EXPECT_EQ(360u, video_streams[1].height);
5989 EXPECT_EQ(320u, video_streams[2].width);
5990 EXPECT_EQ(180u, video_streams[2].height);
5991 }
5992
5993 // Try layers in mixed order.
5994 {
5995 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5996 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5997 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
5998 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5999 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6000 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6001 ASSERT_TRUE(result.ok());
6002
6003 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6004
6005 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6006 ASSERT_EQ(3u, video_streams.size());
6007 EXPECT_EQ(128u, video_streams[0].width);
6008 EXPECT_EQ(72u, video_streams[0].height);
6009 EXPECT_EQ(640u, video_streams[1].width);
6010 EXPECT_EQ(360u, video_streams[1].height);
6011 EXPECT_EQ(320u, video_streams[2].width);
6012 EXPECT_EQ(180u, video_streams[2].height);
6013 }
6014
6015 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6016 {
6017 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6018 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6019 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6020 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6021 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6022 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6023 ASSERT_TRUE(result.ok());
6024
6025 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6026
6027 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6028 ASSERT_EQ(3u, video_streams.size());
6029 EXPECT_EQ(1280u, video_streams[0].width);
6030 EXPECT_EQ(720u, video_streams[0].height);
6031 EXPECT_EQ(1280u, video_streams[1].width);
6032 EXPECT_EQ(720u, video_streams[1].height);
6033 EXPECT_EQ(320u, video_streams[2].width);
6034 EXPECT_EQ(180u, video_streams[2].height);
6035 }
6036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6037}
6038
Rasmus Brandt9387b522019-02-05 14:23:26 +01006039TEST_F(WebRtcVideoChannelTest,
6040 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6041 // Ensure that the top layer has width and height divisible by 2^3,
6042 // so that the bottom layer has width and height divisible by 2.
6043 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6044 // the number of simulcast layers set by the app.
6045 webrtc::test::ScopedFieldTrials field_trial(
6046 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6047
6048 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6049 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6050 VideoSendParameters parameters;
6051 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6052 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6053 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6054 webrtc::test::FrameForwarder frame_forwarder;
6055 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6056 &frame_forwarder));
6057 channel_->SetSend(true);
6058
6059 // Set |scale_resolution_down_by|'s.
6060 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6061 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6062 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6063 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6064 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6065 const auto result =
6066 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6067 ASSERT_TRUE(result.ok());
6068
6069 // Use a capture resolution whose width and height are not divisible by 2^3.
6070 // (See field trial set at the top of the test.)
6071 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6072 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6073
6074 // Ensure the scaling is correct.
6075 const auto video_streams = stream->GetVideoStreams();
6076 ASSERT_EQ(video_streams.size(), 3u);
6077 // Ensure that we round the capture resolution down for the top layer...
6078 EXPECT_EQ(video_streams[0].width, 2000u);
6079 EXPECT_EQ(video_streams[0].height, 1200u);
6080 EXPECT_EQ(video_streams[1].width, 1000u);
6081 EXPECT_EQ(video_streams[1].height, 600u);
6082 // ...and that the bottom layer has a width/height divisible by 2.
6083 EXPECT_EQ(video_streams[2].width, 500u);
6084 EXPECT_EQ(video_streams[2].height, 300u);
6085
6086 // Tear down.
6087 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6088}
6089
Åsa Persson8c1bf952018-09-13 10:42:19 +02006090TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6091 const size_t kNumSimulcastStreams = 3;
6092 SetUpSimulcast(true, false);
6093
6094 // Get and set the rtp encoding parameters.
6095 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6096 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6097 for (const auto& encoding : parameters.encodings) {
6098 EXPECT_FALSE(encoding.max_framerate);
6099 }
6100
6101 // Change the value and set it on the VideoChannel.
6102 parameters.encodings[0].max_framerate = 10;
6103 parameters.encodings[1].max_framerate = 20;
6104 parameters.encodings[2].max_framerate = 25;
6105 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6106
6107 // Verify that the bitrates are set on the VideoChannel.
6108 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6109 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6110 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6111 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6112 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6113}
6114
Åsa Persson23eba222018-10-02 14:47:06 +02006115TEST_F(WebRtcVideoChannelTest,
6116 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6117 const size_t kNumSimulcastStreams = 3;
6118 SetUpSimulcast(true, false);
6119
6120 // Get and set the rtp encoding parameters.
6121 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6122 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6123
6124 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6125 parameters.encodings[0].num_temporal_layers = 0;
6126 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6127 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6128 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6129 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6130 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6131}
6132
6133TEST_F(WebRtcVideoChannelTest,
6134 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6135 const size_t kNumSimulcastStreams = 3;
6136 SetUpSimulcast(true, false);
6137
6138 // Get and set the rtp encoding parameters.
6139 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6140 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6141
6142 // No/all layers should be set.
6143 parameters.encodings[0].num_temporal_layers = 1;
6144 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6145 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6146
6147 // Different values not supported.
6148 parameters.encodings[0].num_temporal_layers = 1;
6149 parameters.encodings[1].num_temporal_layers = 2;
6150 parameters.encodings[2].num_temporal_layers = 2;
6151 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6152 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6153}
6154
6155TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6156 const size_t kNumSimulcastStreams = 3;
6157 SetUpSimulcast(true, false);
6158
6159 // Get and set the rtp encoding parameters.
6160 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6161 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6162 for (const auto& encoding : parameters.encodings)
6163 EXPECT_FALSE(encoding.num_temporal_layers);
6164
6165 // Change the value and set it on the VideoChannel.
6166 parameters.encodings[0].num_temporal_layers = 3;
6167 parameters.encodings[1].num_temporal_layers = 3;
6168 parameters.encodings[2].num_temporal_layers = 3;
6169 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6170
6171 // Verify that the number of temporal layers are set on the VideoChannel.
6172 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6173 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6174 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6175 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6176 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6177}
6178
6179TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6180 const size_t kNumSimulcastStreams = 3;
6181 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6182
6183 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006184 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006185 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006186 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006187 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006188 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006189
6190 // Get and set the rtp encoding parameters.
6191 // Change the value and set it on the VideoChannel.
6192 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6193 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6194 parameters.encodings[0].num_temporal_layers = 2;
6195 parameters.encodings[1].num_temporal_layers = 2;
6196 parameters.encodings[2].num_temporal_layers = 2;
6197 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6198
6199 // Verify that the new value is propagated down to the encoder.
6200 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6201 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6202 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6203 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6204 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6205 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6206 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6207 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6208
6209 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6210 // VideoStreams are created appropriately for the simulcast case.
6211 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6212 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6213 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6214 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6215
6216 // No parameter changed, encoder should not be reconfigured.
6217 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6218 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6219
6220 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6221}
6222
6223TEST_F(WebRtcVideoChannelTest,
6224 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6225 const size_t kDefaultNumTemporalLayers = 3;
6226 const size_t kNumSimulcastStreams = 3;
6227 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6228
6229 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006230 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006231 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006232 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006233 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006234 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006235
6236 // Change rtp encoding parameters, num_temporal_layers not changed.
6237 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6238 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6239 parameters.encodings[0].min_bitrate_bps = 33000;
6240 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6241
6242 // Verify that no value is propagated down to the encoder.
6243 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6244 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6245 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6246 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6247 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6248 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6249
6250 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6251 // VideoStreams are created appropriately for the simulcast case.
6252 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6253 EXPECT_EQ(kDefaultNumTemporalLayers,
6254 stream->GetVideoStreams()[0].num_temporal_layers);
6255 EXPECT_EQ(kDefaultNumTemporalLayers,
6256 stream->GetVideoStreams()[1].num_temporal_layers);
6257 EXPECT_EQ(kDefaultNumTemporalLayers,
6258 stream->GetVideoStreams()[2].num_temporal_layers);
6259
6260 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6261}
6262
Åsa Persson8c1bf952018-09-13 10:42:19 +02006263TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6264 const size_t kNumSimulcastStreams = 3;
6265 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6266
6267 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006268 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006269 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006270 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006271 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006272 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006273
6274 // Get and set the rtp encoding parameters.
6275 // Change the value and set it on the VideoChannel.
6276 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6277 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6278 parameters.encodings[0].max_framerate = 15;
6279 parameters.encodings[1].max_framerate = 25;
6280 parameters.encodings[2].max_framerate = 20;
6281 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6282
6283 // Verify that the new value propagated down to the encoder.
6284 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6285 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6286 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6287 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6288 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6289 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6290 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6291 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6292
6293 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6294 // VideoStreams are created appropriately for the simulcast case.
6295 // Currently the maximum |max_framerate| is used.
6296 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6297 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6298 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6299 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6300
6301 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6302}
6303
6304TEST_F(WebRtcVideoChannelTest,
6305 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6306 const size_t kNumSimulcastStreams = 3;
6307 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6308 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6309
6310 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006311 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006312 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006313 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006314 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006315 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006316
6317 // Get and set the rtp encoding parameters.
6318 // Change the value and set it on the VideoChannel.
6319 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6320 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6321 parameters.encodings[0].max_framerate = 15;
6322 parameters.encodings[2].max_framerate = 20;
6323 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6324
6325 // Verify that the new value propagated down to the encoder.
6326 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6327 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6328 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6329 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6330 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6331 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6332 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6333
6334 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6335 // VideoStreams are created appropriately for the simulcast case.
6336 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6337 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6338 EXPECT_EQ(kDefaultVideoMaxFramerate,
6339 stream->GetVideoStreams()[0].max_framerate);
6340 EXPECT_EQ(kDefaultVideoMaxFramerate,
6341 stream->GetVideoStreams()[1].max_framerate);
6342 EXPECT_EQ(kDefaultVideoMaxFramerate,
6343 stream->GetVideoStreams()[2].max_framerate);
6344
6345 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6346}
6347
Åsa Persson55659812018-06-18 17:51:32 +02006348TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6349 const size_t kNumSimulcastStreams = 3;
6350 SetUpSimulcast(true, false);
6351
6352 // Get and set the rtp encoding parameters.
6353 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6354 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6355 for (const auto& encoding : parameters.encodings) {
6356 EXPECT_FALSE(encoding.min_bitrate_bps);
6357 EXPECT_FALSE(encoding.max_bitrate_bps);
6358 }
6359
6360 // Change the value and set it on the VideoChannel.
6361 parameters.encodings[0].min_bitrate_bps = 100000;
6362 parameters.encodings[0].max_bitrate_bps = 200000;
6363 parameters.encodings[1].min_bitrate_bps = 300000;
6364 parameters.encodings[1].max_bitrate_bps = 400000;
6365 parameters.encodings[2].min_bitrate_bps = 500000;
6366 parameters.encodings[2].max_bitrate_bps = 600000;
6367 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6368
6369 // Verify that the bitrates are set on the VideoChannel.
6370 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6371 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6372 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6373 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6374 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6375 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6376 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6377 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6378}
6379
6380TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6381 const size_t kNumSimulcastStreams = 3;
6382 SetUpSimulcast(true, false);
6383
6384 // Get and set the rtp encoding parameters.
6385 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6386 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6387
6388 // Max bitrate lower than min bitrate should fail.
6389 parameters.encodings[2].min_bitrate_bps = 100000;
6390 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6391 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6392 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6393}
6394
6395// Test that min and max bitrate values set via RtpParameters are correctly
6396// propagated to the underlying encoder, and that the target is set to 3/4 of
6397// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6398// that are used if no min/max are specified).
6399TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6400 const size_t kNumSimulcastStreams = 3;
6401 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6402
6403 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006404 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006405 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006406 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006407 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006408 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006409
6410 // Get and set the rtp encoding parameters.
6411 // Change the value and set it on the VideoChannel.
6412 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6413 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6414 parameters.encodings[0].min_bitrate_bps = 100000;
6415 parameters.encodings[0].max_bitrate_bps = 200000;
6416 parameters.encodings[1].min_bitrate_bps = 300000;
6417 parameters.encodings[1].max_bitrate_bps = 400000;
6418 parameters.encodings[2].min_bitrate_bps = 500000;
6419 parameters.encodings[2].max_bitrate_bps = 600000;
6420 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6421
6422 // Verify that the new value propagated down to the encoder.
6423 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6424 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6425 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6426 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6427 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6428 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6429 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6430 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6431 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6432 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6433 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6434
6435 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6436 // VideoStreams are created appropriately for the simulcast case.
6437 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6438 // Target bitrate: 200000 * 3 / 4 = 150000.
6439 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6440 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6441 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6442 // Target bitrate: 400000 * 3 / 4 = 300000.
6443 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6444 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6445 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6446 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6447 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6448 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6449 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6450
6451 // No parameter changed, encoder should not be reconfigured.
6452 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6453 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6454
6455 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6456}
6457
6458// Test to only specify the min or max bitrate value for a layer via
6459// RtpParameters. The unspecified min/max and target value should be set to the
6460// simulcast default that is used if no min/max are specified.
6461TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6462 const size_t kNumSimulcastStreams = 3;
6463 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6464 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6465
6466 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006467 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006468 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006469 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006470 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006471 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006472
6473 // Get and set the rtp encoding parameters.
6474 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6475 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6476
6477 // Change the value and set it on the VideoChannel.
6478 // Layer 0: only configure min bitrate.
6479 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6480 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6481 // Layer 1: only configure max bitrate.
6482 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6483 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6484 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6485
6486 // Verify that the new value propagated down to the encoder.
6487 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6488 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6489 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6490 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6491 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6492 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6493 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6494 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6495 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6496 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6497
6498 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6499 // VideoStreams are created appropriately for the simulcast case.
6500 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6501 // Layer 0: min configured bitrate should overwrite min default.
6502 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6503 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6504 stream->GetVideoStreams()[0].target_bitrate_bps);
6505 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6506 stream->GetVideoStreams()[0].max_bitrate_bps);
6507 // Layer 1: max configured bitrate should overwrite max default.
6508 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6509 stream->GetVideoStreams()[1].min_bitrate_bps);
6510 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6511 stream->GetVideoStreams()[1].target_bitrate_bps);
6512 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6513 // Layer 2: min and max bitrate not configured, default expected.
6514 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6515 stream->GetVideoStreams()[2].min_bitrate_bps);
6516 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6517 stream->GetVideoStreams()[2].target_bitrate_bps);
6518 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6519 stream->GetVideoStreams()[2].max_bitrate_bps);
6520
6521 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6522}
6523
6524// Test that specifying the min (or max) bitrate value for a layer via
6525// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6526// unspecified values accordingly.
6527TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6528 const size_t kNumSimulcastStreams = 3;
6529 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6530 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6531
6532 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006533 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006534 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006535 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006536 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006537 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006538
6539 // Get and set the rtp encoding parameters.
6540 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6541 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6542
6543 // Change the value and set it on the VideoChannel.
6544 // For layer 0, set the min bitrate above the default max.
6545 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6546 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6547 // For layer 1, set the max bitrate below the default min.
6548 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6549 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6550 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6551
6552 // Verify that the new value propagated down to the encoder.
6553 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6554 // VideoStreams are created appropriately for the simulcast case.
6555 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6556 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6557 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6558 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6559 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6560 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6561 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6562 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6563 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6564 // Layer 2: min and max bitrate not configured, default expected.
6565 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6566 stream->GetVideoStreams()[2].min_bitrate_bps);
6567 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6568 stream->GetVideoStreams()[2].target_bitrate_bps);
6569 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6570 stream->GetVideoStreams()[2].max_bitrate_bps);
6571
6572 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6573}
6574
6575TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6576 const size_t kNumSimulcastStreams = 3;
6577 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6578 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6579
6580 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006581 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006582 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006583 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006584 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006585 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006586
6587 // Set max bitrate for all but the highest layer.
6588 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6589 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6590 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6591 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6592 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6593
6594 // Set max bandwidth equal to total max bitrate.
6595 send_parameters_.max_bandwidth_bps =
6596 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6597 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6598 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6599
6600 // No bitrate above the total max to give to the highest layer.
6601 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6602 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6603 stream->GetVideoStreams()[2].max_bitrate_bps);
6604
6605 // Set max bandwidth above the total max bitrate.
6606 send_parameters_.max_bandwidth_bps =
6607 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6608 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6609 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6610
6611 // The highest layer has no max bitrate set -> the bitrate above the total
6612 // max should be given to the highest layer.
6613 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6614 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6615 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6616 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6617 stream->GetVideoStreams()[2].max_bitrate_bps);
6618
6619 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6620}
6621
6622TEST_F(WebRtcVideoChannelTest,
6623 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6624 const size_t kNumSimulcastStreams = 3;
6625 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6626 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6627 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6628
6629 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006630 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006631 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006632 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006633 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006634 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006635
6636 // Set max bitrate for the highest layer.
6637 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6638 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6639 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6640 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6641
6642 // Set max bandwidth above the total max bitrate.
6643 send_parameters_.max_bandwidth_bps =
6644 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6645 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6646 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6647
6648 // The highest layer has the max bitrate set -> the bitrate above the total
6649 // max should not be given to the highest layer.
6650 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6651 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6652 stream->GetVideoStreams()[2].max_bitrate_bps);
6653
6654 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6655}
6656
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006657// Test that min and max bitrate values set via RtpParameters are correctly
6658// propagated to the underlying encoder for a single stream.
6659TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6660 FakeVideoSendStream* stream = AddSendStream();
6661 EXPECT_TRUE(channel_->SetSend(true));
6662 EXPECT_TRUE(stream->IsSending());
6663
6664 // Set min and max bitrate.
6665 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6666 EXPECT_EQ(1u, parameters.encodings.size());
6667 parameters.encodings[0].min_bitrate_bps = 80000;
6668 parameters.encodings[0].max_bitrate_bps = 150000;
6669 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6670
6671 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6672 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6673 EXPECT_EQ(1u, encoder_config.number_of_streams);
6674 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6675 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6676 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6677
6678 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6679 // VideoStreams are created appropriately.
6680 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6681 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6682 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6683 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6684}
6685
6686// Test the default min and max bitrate value are correctly propagated to the
6687// underlying encoder for a single stream (when the values are not set via
6688// RtpParameters).
6689TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6690 FakeVideoSendStream* stream = AddSendStream();
6691 EXPECT_TRUE(channel_->SetSend(true));
6692 EXPECT_TRUE(stream->IsSending());
6693
6694 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6695 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6696 EXPECT_EQ(1u, encoder_config.number_of_streams);
6697 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6698 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6699 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6700
6701 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6702 // VideoStreams are created appropriately.
6703 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6704 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6705 stream->GetVideoStreams()[0].min_bitrate_bps);
6706 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6707 stream->GetVideoStreams()[0].min_bitrate_bps);
6708 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6709 stream->GetVideoStreams()[0].target_bitrate_bps);
6710}
6711
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006712// Test that a stream will not be sending if its encoding is made inactive
6713// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006714TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006715 FakeVideoSendStream* stream = AddSendStream();
6716 EXPECT_TRUE(channel_->SetSend(true));
6717 EXPECT_TRUE(stream->IsSending());
6718
6719 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006720 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006721 ASSERT_EQ(1u, parameters.encodings.size());
6722 ASSERT_TRUE(parameters.encodings[0].active);
6723 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006724 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006725 EXPECT_FALSE(stream->IsSending());
6726
6727 // Now change it back to active and verify we resume sending.
6728 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006729 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006730 EXPECT_TRUE(stream->IsSending());
6731}
6732
Seth Hampson8234ead2018-02-02 15:16:24 -08006733// Tests that when active is updated for any simulcast layer then the send
6734// stream's sending state will be updated and it will be reconfigured with the
6735// new appropriate active simulcast streams.
6736TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6737 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006738 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006739 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6740 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6741 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6742 uint32_t primary_ssrc = stream_params.first_ssrc();
6743
Niels Möller805a27e2019-01-21 12:21:27 +01006744 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006745 // frame. This allows us to test that ReconfigureEncoder is called
6746 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006747 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006748 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006749 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006750 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006751 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6752 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6753 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006754
6755 // Check that all encodings are initially active.
6756 webrtc::RtpParameters parameters =
6757 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006758 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006759 EXPECT_TRUE(parameters.encodings[0].active);
6760 EXPECT_TRUE(parameters.encodings[1].active);
6761 EXPECT_TRUE(parameters.encodings[2].active);
6762 EXPECT_TRUE(fake_video_send_stream->IsSending());
6763
6764 // Only turn on only the middle stream.
6765 parameters.encodings[0].active = false;
6766 parameters.encodings[1].active = true;
6767 parameters.encodings[2].active = false;
6768 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6769 // Verify that the active fields are set on the VideoChannel.
6770 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006771 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006772 EXPECT_FALSE(parameters.encodings[0].active);
6773 EXPECT_TRUE(parameters.encodings[1].active);
6774 EXPECT_FALSE(parameters.encodings[2].active);
6775 // Check that the VideoSendStream is updated appropriately. This means its
6776 // send state was updated and it was reconfigured.
6777 EXPECT_TRUE(fake_video_send_stream->IsSending());
6778 std::vector<webrtc::VideoStream> simulcast_streams =
6779 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006780 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006781 EXPECT_FALSE(simulcast_streams[0].active);
6782 EXPECT_TRUE(simulcast_streams[1].active);
6783 EXPECT_FALSE(simulcast_streams[2].active);
6784
6785 // Turn off all streams.
6786 parameters.encodings[0].active = false;
6787 parameters.encodings[1].active = false;
6788 parameters.encodings[2].active = false;
6789 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6790 // Verify that the active fields are set on the VideoChannel.
6791 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006792 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006793 EXPECT_FALSE(parameters.encodings[0].active);
6794 EXPECT_FALSE(parameters.encodings[1].active);
6795 EXPECT_FALSE(parameters.encodings[2].active);
6796 // Check that the VideoSendStream is off.
6797 EXPECT_FALSE(fake_video_send_stream->IsSending());
6798 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006799 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006800 EXPECT_FALSE(simulcast_streams[0].active);
6801 EXPECT_FALSE(simulcast_streams[1].active);
6802 EXPECT_FALSE(simulcast_streams[2].active);
6803
Niels Möllerff40b142018-04-09 08:49:14 +02006804 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006805}
6806
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006807// Test that if a stream is reconfigured (due to a codec change or other
6808// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006809TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006810 InactiveStreamDoesntStartSendingWhenReconfigured) {
6811 // Set an initial codec list, which will be modified later.
6812 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08006813 parameters1.codecs.push_back(GetEngineCodec("VP8"));
6814 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006815 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
6816
6817 FakeVideoSendStream* stream = AddSendStream();
6818 EXPECT_TRUE(channel_->SetSend(true));
6819 EXPECT_TRUE(stream->IsSending());
6820
6821 // Get current parameters and change "active" to false.
6822 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6823 ASSERT_EQ(1u, parameters.encodings.size());
6824 ASSERT_TRUE(parameters.encodings[0].active);
6825 parameters.encodings[0].active = false;
6826 EXPECT_EQ(1u, GetFakeSendStreams().size());
6827 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08006828 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006829 EXPECT_FALSE(stream->IsSending());
6830
6831 // Reorder the codec list, causing the stream to be reconfigured.
6832 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08006833 parameters2.codecs.push_back(GetEngineCodec("VP9"));
6834 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006835 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
6836 auto new_streams = GetFakeSendStreams();
6837 // Assert that a new underlying stream was created due to the codec change.
6838 // Otherwise, this test isn't testing what it set out to test.
6839 EXPECT_EQ(1u, GetFakeSendStreams().size());
6840 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
6841
6842 // Verify that we still are not sending anything, due to the inactive
6843 // encoding.
6844 EXPECT_FALSE(new_streams[0]->IsSending());
6845}
6846
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006847// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006848TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006849 AddSendStream();
6850 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006851 parameters.codecs.push_back(GetEngineCodec("VP8"));
6852 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006853 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6854
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006855 webrtc::RtpParameters rtp_parameters =
6856 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006857 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006858 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6859 rtp_parameters.codecs[0]);
6860 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6861 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006862}
6863
Florent Castellidacec712018-05-24 16:24:21 +02006864// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
6865TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
6866 StreamParams params = StreamParams::CreateLegacy(kSsrc);
6867 params.cname = "rtcpcname";
6868 AddSendStream(params);
6869
6870 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
6871 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
6872}
6873
deadbeeffb2aced2017-01-06 23:05:37 -08006874// Test that RtpParameters for send stream has one encoding and it has
6875// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006876TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08006877 AddSendStream();
6878
6879 webrtc::RtpParameters rtp_parameters =
6880 channel_->GetRtpSendParameters(last_ssrc_);
6881 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01006882 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08006883}
6884
Florent Castelliabe301f2018-06-12 18:33:49 +02006885TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
6886 AddSendStream();
6887
6888 webrtc::RtpParameters rtp_parameters =
6889 channel_->GetRtpSendParameters(last_ssrc_);
6890 rtp_parameters.header_extensions.emplace_back();
6891
6892 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
6893
6894 webrtc::RTCError result =
6895 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6896 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
6897}
6898
Florent Castelli87b3c512018-07-18 16:00:28 +02006899TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
6900 AddSendStream();
6901
Niels Möller805a27e2019-01-21 12:21:27 +01006902 webrtc::test::FrameForwarder frame_forwarder;
6903 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02006904
6905 webrtc::RtpParameters rtp_parameters =
6906 channel_->GetRtpSendParameters(last_ssrc_);
6907 EXPECT_EQ(rtp_parameters.degradation_preference,
6908 webrtc::DegradationPreference::BALANCED);
6909 rtp_parameters.degradation_preference =
6910 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
6911
6912 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
6913
6914 webrtc::RtpParameters updated_rtp_parameters =
6915 channel_->GetRtpSendParameters(last_ssrc_);
6916 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
6917 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
6918
6919 // Remove the source since it will be destroyed before the channel
6920 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6921}
6922
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006923// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07006924TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006925 AddSendStream();
6926 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006927 parameters.codecs.push_back(GetEngineCodec("VP8"));
6928 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006929 EXPECT_TRUE(channel_->SetSendParameters(parameters));
6930
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006931 webrtc::RtpParameters initial_params =
6932 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006933
6934 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08006935 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07006936
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006937 // ... And this shouldn't change the params returned by GetRtpSendParameters.
6938 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
6939}
6940
6941// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07006942TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006943 AddRecvStream();
6944 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08006945 parameters.codecs.push_back(GetEngineCodec("VP8"));
6946 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006947 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6948
6949 webrtc::RtpParameters rtp_parameters =
6950 channel_->GetRtpReceiveParameters(last_ssrc_);
6951 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08006952 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
6953 rtp_parameters.codecs[0]);
6954 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
6955 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006956}
6957
johan073ece42016-08-26 02:59:47 -07006958#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07006959TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006960#else
eladalonf1841382017-06-12 01:16:46 -07006961TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07006962#endif
johan3859c892016-08-05 09:19:25 -07006963 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07006964 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08006965 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07006966 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07006967 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08006968 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07006969 parameters.codecs.push_back(kH264sprop2);
6970 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
6971
6972 FakeVideoReceiveStream* recv_stream = AddRecvStream();
6973 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
6974 webrtc::RtpParameters rtp_parameters =
6975 channel_->GetRtpReceiveParameters(last_ssrc_);
6976 ASSERT_EQ(2u, rtp_parameters.codecs.size());
6977 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
6978 ASSERT_EQ(2u, cfg.decoders.size());
6979 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006980 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006981 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006982 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
6983 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006984 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07006985
6986 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02006987 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08006988 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02006989 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
6990 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08006991 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07006992}
6993
sakal1fd95952016-06-22 00:46:15 -07006994// Test that RtpParameters for receive stream has one encoding and it has
6995// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07006996TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07006997 AddRecvStream();
6998
6999 webrtc::RtpParameters rtp_parameters =
7000 channel_->GetRtpReceiveParameters(last_ssrc_);
7001 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007002 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007003}
7004
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007005// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007006TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007007 AddRecvStream();
7008 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007009 parameters.codecs.push_back(GetEngineCodec("VP8"));
7010 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007011 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7012
7013 webrtc::RtpParameters initial_params =
7014 channel_->GetRtpReceiveParameters(last_ssrc_);
7015
7016 // We should be able to set the params we just got.
7017 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7018
7019 // ... And this shouldn't change the params returned by
7020 // GetRtpReceiveParameters.
7021 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007022}
7023
deadbeef3bc15102017-04-20 19:25:07 -07007024// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7025// aren't signaled. It should always return an empty "RtpEncodingParameters",
7026// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007027TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007028 // Call necessary methods to configure receiving a default stream as
7029 // soon as it arrives.
7030 cricket::VideoRecvParameters parameters;
7031 parameters.codecs.push_back(GetEngineCodec("VP8"));
7032 parameters.codecs.push_back(GetEngineCodec("VP9"));
7033 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7034
7035 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7036 // stream. Should return nothing.
7037 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7038
7039 // Set a sink for an unsignaled stream.
7040 cricket::FakeVideoRenderer renderer;
7041 // Value of "0" means "unsignaled stream".
7042 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7043
7044 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7045 // in this method means "unsignaled stream".
7046 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7047 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7048 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7049
7050 // Receive VP8 packet.
7051 uint8_t data[kMinRtpPacketLen];
7052 cricket::RtpHeader rtpHeader;
7053 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7054 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7055 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7056 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7057 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007058 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007059
7060 // The |ssrc| member should still be unset.
7061 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7062 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7063 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7064}
7065
eladalonf1841382017-06-12 01:16:46 -07007066void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007067 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007068 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007069
7070 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007071 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007072 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007073 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007074
7075 if (receiver_first) {
7076 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7077 std::vector<FakeVideoReceiveStream*> receive_streams =
7078 fake_call_->GetVideoReceiveStreams();
7079 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007080 // Default local SSRC when we have no sender.
7081 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7082 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007083 }
7084 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7085 if (!receiver_first)
7086 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7087 std::vector<FakeVideoReceiveStream*> receive_streams =
7088 fake_call_->GetVideoReceiveStreams();
7089 ASSERT_EQ(1u, receive_streams.size());
7090 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007091
7092 // Removing first sender should fall back to another (in this case the second)
7093 // local send stream's SSRC.
7094 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7095 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007096 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007097 ASSERT_EQ(1u, receive_streams.size());
7098 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7099
7100 // Removing the last sender should fall back to default local SSRC.
7101 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007102 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007103 ASSERT_EQ(1u, receive_streams.size());
7104 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7105 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007106}
7107
eladalonf1841382017-06-12 01:16:46 -07007108TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007109 TestReceiverLocalSsrcConfiguration(false);
7110}
7111
eladalonf1841382017-06-12 01:16:46 -07007112TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007113 TestReceiverLocalSsrcConfiguration(true);
7114}
7115
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007116class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007117 public:
eladalonf1841382017-06-12 01:16:46 -07007118 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007119 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007120 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7121 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007122 mock_rate_allocator_factory_(
7123 new webrtc::MockVideoBitrateAllocatorFactory),
Anders Carlsson67537952018-05-03 11:28:29 +02007124 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007125 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007126 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007127 decoder_factory_),
7128 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>(
7129 mock_rate_allocator_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007130 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007131
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007132 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007133 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson84848f22018-11-16 10:40:36 +01007134 channel_.reset(engine_.CreateMediaChannel(&fake_call_, GetMediaConfig(),
7135 VideoOptions(),
7136 webrtc::CryptoOptions()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007137 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007138 last_ssrc_ = 123;
7139 }
7140
7141 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007142 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007143 int capture_width,
7144 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007145 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007146 size_t expected_num_streams,
7147 bool screenshare,
7148 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007149 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007150 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007151 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007152 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007153
Peter Boström0c4e06b2015-10-07 12:23:21 +02007154 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007155 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007156 ssrcs.resize(num_configured_streams);
7157
sprangf24a0642017-02-28 13:23:26 -08007158 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007159 // Send a full-size frame to trigger a stream reconfiguration to use all
7160 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007161 webrtc::test::FrameForwarder frame_forwarder;
7162 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7163 rtc::kNumMicrosecsPerSec / 30);
7164
sprangf24a0642017-02-28 13:23:26 -08007165 VideoOptions options;
7166 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007167 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007168 EXPECT_TRUE(
7169 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007170 // Fetch the latest stream since SetVideoSend() may recreate it if the
7171 // screen content setting is changed.
7172 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007173 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007174 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007175
Zach Stein3ca452b2018-01-18 10:01:24 -08007176 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7177 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7178
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007179 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7180 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007181 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007182
sprang429600d2017-01-26 06:12:26 -08007183 std::vector<webrtc::VideoStream> expected_streams;
7184 if (conference_mode) {
7185 expected_streams = GetSimulcastConfig(
7186 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08007187 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02007188 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08007189 if (screenshare) {
7190 for (const webrtc::VideoStream& stream : expected_streams) {
7191 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007192 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7193 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007194 }
7195 }
sprang429600d2017-01-26 06:12:26 -08007196 } else {
7197 webrtc::VideoStream stream;
7198 stream.width = capture_width;
7199 stream.height = capture_height;
7200 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007201 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007202 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007203 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007204 stream.max_qp = kDefaultQpMax;
7205 expected_streams.push_back(stream);
7206 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007207
7208 ASSERT_EQ(expected_streams.size(), video_streams.size());
7209
7210 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007211 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007212 for (size_t i = 0; i < num_streams; ++i) {
7213 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7214 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7215
7216 EXPECT_GT(video_streams[i].max_framerate, 0);
7217 EXPECT_EQ(expected_streams[i].max_framerate,
7218 video_streams[i].max_framerate);
7219
7220 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7221 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7222 video_streams[i].min_bitrate_bps);
7223
7224 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7225 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7226 video_streams[i].target_bitrate_bps);
7227
7228 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7229 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7230 video_streams[i].max_bitrate_bps);
7231
7232 EXPECT_GT(video_streams[i].max_qp, 0);
7233 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7234
Sergey Silkina796a7e2018-03-01 15:11:29 +01007235 EXPECT_EQ(conference_mode,
7236 expected_streams[i].num_temporal_layers.has_value());
7237
7238 if (conference_mode) {
7239 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7240 video_streams[i].num_temporal_layers);
7241 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007242
7243 if (i == num_streams - 1) {
7244 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7245 } else {
7246 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7247 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007248 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007249
Niels Möllerff40b142018-04-09 08:49:14 +02007250 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007251 }
7252
7253 FakeVideoSendStream* AddSendStream() {
7254 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7255 }
7256
7257 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007258 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007259 EXPECT_TRUE(channel_->AddSendStream(sp));
7260 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007261 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007262 EXPECT_EQ(num_streams + 1, streams.size());
7263 return streams[streams.size() - 1];
7264 }
7265
7266 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007267 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007268 }
7269
7270 FakeVideoReceiveStream* AddRecvStream() {
7271 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7272 }
7273
7274 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007275 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007276 EXPECT_TRUE(channel_->AddRecvStream(sp));
7277 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007278 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007279 EXPECT_EQ(num_streams + 1, streams.size());
7280 return streams[streams.size() - 1];
7281 }
7282
skvlad11a9cbf2016-10-07 11:53:05 -07007283 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007284 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007285 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7286 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007287 webrtc::MockVideoBitrateAllocatorFactory* mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007288 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007289 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007290 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007291};
7292
eladalonf1841382017-06-12 01:16:46 -07007293TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007294 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7295 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007296}
7297
eladalonf1841382017-06-12 01:16:46 -07007298TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007299 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7300 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007301}
7302
7303// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007304TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007305 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7306 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007307}
sprang429600d2017-01-26 06:12:26 -08007308
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007309TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007310 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7311 false);
7312}
7313
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007314TEST_F(WebRtcVideoChannelSimulcastTest,
7315 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007316 webrtc::test::ScopedFieldTrials field_trials(
7317 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007318 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7319 true);
7320}
7321
eladalonf1841382017-06-12 01:16:46 -07007322TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007323 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7324 true);
7325}
7326
eladalonf1841382017-06-12 01:16:46 -07007327TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007328 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007329 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7330 false);
7331}
7332
Yves Gereyb6a89422018-10-08 10:08:32 +02007333class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007334 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02007335 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007336 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7337 }
7338 rtc::ScopedFakeClock fake_clock_;
7339};
7340
Yves Gereyb6a89422018-10-08 10:08:32 +02007341// The fake clock needs to be initialized before the call, and not
7342// destroyed until after all threads spawned by the test have been stopped.
7343// This mixin ensures that.
7344class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7345 public WebRtcVideoChannelBaseTest {};
7346
Jonas Oreland49ac5952018-09-26 16:04:32 +02007347TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7348 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7349 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7350
7351 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7352
7353 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7354 rtc::SetBE32(packet1.data() + 8, kSsrc);
7355 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7356 EXPECT_TRUE(SetDefaultCodec());
7357 EXPECT_TRUE(SetSend(true));
7358 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007359 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007360
7361 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7362 EXPECT_EQ(1u, sources.size());
7363 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7364 int64_t timestamp1 = sources[0].timestamp_ms();
7365
7366 // a new packet.
7367 int64_t timeDeltaMs = 1;
7368 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007369 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007370 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7371 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7372
7373 // It only keeps 10s of history.
7374 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7375 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7376 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7377}
7378
7379TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7380 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7381 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7382
7383 uint32_t kCsrc = 4321u;
7384 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7385 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7386
7387 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7388 rtc::SetBE32(packet1.data() + 8, kSsrc);
7389 rtc::SetBE32(packet1.data() + 12, kCsrc);
7390 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7391 EXPECT_TRUE(SetDefaultCodec());
7392 EXPECT_TRUE(SetSend(true));
7393 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007394 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007395
7396 {
7397 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7398 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7399 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7400 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7401 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007402 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7403 return source.source_type() == webrtc::RtpSourceType::SSRC;
7404 }));
7405 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7406 return source.source_type() == webrtc::RtpSourceType::CSRC;
7407 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007408 }
7409 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7410
7411 // a new packet with only ssrc (i.e no csrc).
7412 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7413 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7414 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7415 rtc::SetBE32(packet2.data() + 8, kSsrc);
7416
7417 int64_t timeDeltaMs = 1;
7418 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007419 channel_->OnPacketReceived(packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007420
7421 {
7422 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7423 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7424 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7425 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7426 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007427 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7428 return source.source_type() == webrtc::RtpSourceType::SSRC;
7429 }));
7430 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7431 return source.source_type() == webrtc::RtpSourceType::CSRC;
7432 }));
7433 auto ssrcSource =
7434 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007435 return source.source_type() == webrtc::RtpSourceType::SSRC;
7436 });
Steve Anton2c9ebef2019-01-28 17:27:58 -08007437 auto csrcSource =
7438 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007439 return source.source_type() == webrtc::RtpSourceType::CSRC;
7440 });
7441
7442 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7443 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7444 }
7445
7446 // It only keeps 10s of history.
7447 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7448
7449 {
7450 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7451 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7452 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
Steve Anton2c9ebef2019-01-28 17:27:58 -08007453 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7454 return source.source_type() == webrtc::RtpSourceType::SSRC;
7455 }));
7456 EXPECT_EQ(0, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7457 return source.source_type() == webrtc::RtpSourceType::CSRC;
7458 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007459 }
7460
7461 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7462 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7463 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7464}
7465
Amit Hilbuchb000b712019-02-25 10:22:14 -08007466TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7467 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7468
7469 std::vector<std::string> rids = {"f", "h", "q"};
7470 std::vector<cricket::RidDescription> rid_descriptions;
7471 for (const auto& rid : rids) {
7472 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7473 }
7474 sp.set_rids(rid_descriptions);
7475
7476 ASSERT_TRUE(channel_->AddSendStream(sp));
7477 const auto& streams = fake_call_->GetVideoSendStreams();
7478 ASSERT_EQ(1u, streams.size());
7479 auto stream = streams[0];
7480 ASSERT_NE(stream, nullptr);
7481 const auto& config = stream->GetConfig();
7482 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7483}
7484
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007485} // namespace cricket