blob: 0f09960f4c153dc1b41c61a9a454f7d3ae78f527 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020013#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Steve Anton2c9ebef2019-01-28 17:27:58 -080017#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010018#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020019#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070020#include "api/media_transport_config.h"
Steve Anton10542f22019-01-11 09:11:00 -080021#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020022#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070023#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080024#include "api/test/mock_video_bitrate_allocator.h"
25#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070026#include "api/test/mock_video_decoder_factory.h"
27#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020028#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080029#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010030#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020031#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020032#include "api/video_codecs/builtin_video_decoder_factory.h"
33#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020034#include "api/video_codecs/sdp_video_format.h"
35#include "api/video_codecs/video_decoder_factory.h"
36#include "api/video_codecs/video_encoder.h"
37#include "api/video_codecs/video_encoder_factory.h"
38#include "call/flexfec_receive_stream.h"
39#include "common_video/h264/profile_level_id.h"
40#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010041#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080042#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080043#include "media/base/fake_video_renderer.h"
44#include "media/base/media_constants.h"
45#include "media/base/rtp_utils.h"
46#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020047#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080048#include "media/engine/fake_webrtc_call.h"
49#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020050#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080051#include "media/engine/webrtc_video_engine.h"
52#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020053#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020054#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080055#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020056#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020057#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080058#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020059#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010060#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020061#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000062
Mirko Bonadei6a489f22019-04-09 15:11:12 +020063using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020064using ::testing::IsEmpty;
65using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010066using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070067using webrtc::RtpExtension;
68
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000069namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000070static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000071
noahricd10a68e2015-07-10 11:27:55 -070072static const uint8_t kRedRtxPayloadType = 125;
73
Niels Möller6557d0c2018-04-11 15:18:34 +020074static const uint32_t kTimeout = 5000U;
75static const uint32_t kDefaultReceiveSsrc = 0;
76static const uint32_t kSsrc = 1234u;
77static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
78static const int kVideoWidth = 640;
79static const int kVideoHeight = 360;
80static const int kFramerate = 30;
81
Peter Boström0c4e06b2015-10-07 12:23:21 +020082static const uint32_t kSsrcs1[] = {1};
83static const uint32_t kSsrcs3[] = {1, 2, 3};
84static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080085static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020086static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080087static const uint32_t kDefaultRecvSsrc = 0;
88
pbos@webrtc.org3c107582014-07-20 15:27:35 +000089static const char kUnsupportedExtensionName[] =
90 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000091
magjed509e4fe2016-11-18 01:34:11 -080092cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
93 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020094 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080095}
96
Elad Alonfadb1812019-05-24 13:40:02 +020097void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
98 bool lntf_expected) {
99 EXPECT_EQ(lntf_expected,
100 codec.HasFeedbackParam(cricket::FeedbackParam(
101 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000102 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
103 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
104 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
105 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
106 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
107 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
108 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800109 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
110 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000111 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
112}
113
magjed725e4842016-11-16 00:48:13 -0800114// Return true if any codec in |codecs| is an RTX codec with associated payload
115// type |payload_type|.
116bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
117 int payload_type) {
118 for (const cricket::VideoCodec& codec : codecs) {
119 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200120 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800121 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
122 &associated_payload_type) &&
123 associated_payload_type == payload_type) {
124 return true;
125 }
126 }
127 return false;
128}
129
nisseca5706d2017-09-11 02:32:16 -0700130// TODO(nisse): Duplicated in call.cc.
131const int* FindKeyByValue(const std::map<int, int>& m, int v) {
132 for (const auto& kv : m) {
133 if (kv.second == v)
134 return &kv.first;
135 }
136 return nullptr;
137}
138
Yves Gerey665174f2018-06-19 15:03:05 +0200139bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
140 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700141 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
142 payload_type) != nullptr;
143}
144
145// Check that there's an Rtx payload type for each decoder.
146bool VerifyRtxReceiveAssociations(
147 const webrtc::VideoReceiveStream::Config& config) {
148 for (const auto& decoder : config.decoders) {
149 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
150 return false;
151 }
152 return true;
153}
154
brandtrffc61182016-11-28 06:02:22 -0800155rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700156 int width,
157 int height) {
158 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
159 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800160 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700161 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000162}
163
Shao Changbine62202f2015-04-21 20:24:50 +0800164void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
165 const std::map<int, int>& rtx_types) {
166 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200167 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800168 EXPECT_TRUE(it != rtx_types.end() &&
169 it->second == config.rtp.rtx.payload_type);
170
brandtrb5f2c3f2016-10-04 23:28:39 -0700171 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
172 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800173 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700174 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800175 }
176}
kthelgason2bc68642017-02-07 07:02:22 -0800177
178cricket::MediaConfig GetMediaConfig() {
179 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100180 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800181 return media_config;
182}
nisse26e3abb2017-08-25 04:44:25 -0700183
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200184// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
185int GetMaxDefaultBitrateBps(size_t width, size_t height) {
186 if (width * height <= 320 * 240) {
187 return 600000;
188 } else if (width * height <= 640 * 480) {
189 return 1700000;
190 } else if (width * height <= 960 * 540) {
191 return 2000000;
192 } else {
193 return 2500000;
194 }
195}
196
Niels Möller731a2c22018-07-30 15:08:07 +0200197class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
198 public:
199 MOCK_METHOD2(AddOrUpdateSink,
200 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
201 const rtc::VideoSinkWants& wants));
202 MOCK_METHOD1(RemoveSink,
203 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
204};
205
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000206} // namespace
207
Yves Gerey665174f2018-06-19 15:03:05 +0200208#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200209 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200210 EXPECT_EQ((w), renderer_.width()); \
211 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200212 EXPECT_EQ(0, renderer_.errors());
213
Yves Gerey665174f2018-06-19 15:03:05 +0200214#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200215 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200216 EXPECT_EQ((w), (r).width()); \
217 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200218 EXPECT_EQ(0, (r).errors());
219
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000220namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700221class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000222 public:
eladalonf1841382017-06-12 01:16:46 -0700223 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200224 explicit WebRtcVideoEngineTest(const std::string& field_trials)
225 : override_field_trials_(
226 field_trials.empty()
227 ? nullptr
228 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
229 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200230 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
231 call_(webrtc::Call::Create([&] {
232 webrtc::Call::Config call_config(&event_log_);
233 call_config.task_queue_factory = task_queue_factory_.get();
234 return call_config;
235 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200236 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
237 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200238 video_bitrate_allocator_factory_(
239 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200240 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200241 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200242 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200243 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200244 // Ensure fake clock doesn't return 0, which will cause some initializations
245 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200246 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200247 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000248
249 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200250 void AssignDefaultAptRtxTypes();
251 void AssignDefaultCodec();
252
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100253 // Find the index of the codec in the engine with the given name. The codec
254 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100255 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100256
magjed509e4fe2016-11-18 01:34:11 -0800257 // Find the codec in the engine with the given name. The codec must be
258 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100259 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800260
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200261 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000262
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200263 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000264 const std::vector<VideoCodec>& codecs);
265
Elad Alon157540a2019-02-08 23:37:52 +0100266 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100267
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200268 // Has to be the first one, so it is initialized before the call or there is a
269 // race condition in the clock access.
270 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200271 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700272 webrtc::RtcEventLogNullImpl event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200273 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700274 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000275 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800276 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200277 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
278 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200279 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
280 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700281 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000282 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800283 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000284};
285
eladalonf1841382017-06-12 01:16:46 -0700286TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200287 encoder_factory_->AddSupportedVideoCodecType("VP8");
288 AssignDefaultCodec();
289
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000290 std::vector<VideoCodec> engine_codecs = engine_.codecs();
291 for (size_t i = 0; i < engine_codecs.size(); ++i) {
292 if (engine_codecs[i].name != kRtxCodecName)
293 continue;
294 int associated_payload_type;
295 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000296 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000297 EXPECT_EQ(default_codec_.id, associated_payload_type);
298 return;
299 }
300 FAIL() << "No RTX codec found among default codecs.";
301}
302
eladalonf1841382017-06-12 01:16:46 -0700303TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100304 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000305}
306
eladalonf1841382017-06-12 01:16:46 -0700307TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100308 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000309}
310
eladalonf1841382017-06-12 01:16:46 -0700311TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100312 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700313}
314
eladalonf1841382017-06-12 01:16:46 -0700315TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100316 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
317}
318
319TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
320 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
321}
322
323TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
324 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
325}
326
327TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
328 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
329}
330
331TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
332 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100333}
334
335TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100336 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
337}
338
Elad Alonccb9b752019-02-19 13:01:31 +0100339TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
340 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
341}
342
343TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
344 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700345}
346
philipel1e054862018-10-08 16:13:53 +0200347class WebRtcVideoEngineTestWithGenericDescriptor
348 : public WebRtcVideoEngineTest {
349 public:
350 WebRtcVideoEngineTestWithGenericDescriptor()
351 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
352};
353
Elad Alonccb9b752019-02-19 13:01:31 +0100354TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
355 AdvertiseGenericDescriptor00) {
356 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
357}
358
359TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
360 AdvertiseGenericDescriptor01) {
361 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200362}
363
eladalonf1841382017-06-12 01:16:46 -0700364TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200365 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200367 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700368
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200369 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700370
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200371 std::unique_ptr<VideoMediaChannel> channel(
372 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
374
375 // Add CVO extension.
376 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800377 cricket::VideoSendParameters parameters;
378 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200379 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700380 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200381 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700382
Niels Möller731a2c22018-07-30 15:08:07 +0200383 EXPECT_CALL(
384 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200385 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200386 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700387 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200388 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700389
390 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200391 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392
393 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200394 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200395 EXPECT_CALL(
396 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200397 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200398 Field(&rtc::VideoSinkWants::rotation_applied, true)));
399
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200400 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700401}
402
eladalonf1841382017-06-12 01:16:46 -0700403TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200404 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800405 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200406 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800407
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200408 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800409
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200410 std::unique_ptr<VideoMediaChannel> channel(
411 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800412 // Add CVO extension.
413 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800414 cricket::VideoSendParameters parameters;
415 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800416 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700417 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800418 EXPECT_TRUE(channel->SetSendParameters(parameters));
419 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
420
Niels Möller731a2c22018-07-30 15:08:07 +0200421 // Set source.
422 EXPECT_CALL(
423 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200424 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200425 Field(&rtc::VideoSinkWants::rotation_applied, false)));
426 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800427}
428
eladalonf1841382017-06-12 01:16:46 -0700429TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200430 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700431
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200432 encoder_factory_->AddSupportedVideoCodecType("VP8");
433 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700434
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200435 std::unique_ptr<VideoMediaChannel> channel(
436 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700437 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
438
439 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200440 EXPECT_CALL(
441 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200442 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200443 Field(&rtc::VideoSinkWants::rotation_applied, true)));
444 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700445
perkjcaafdba2016-03-20 07:34:29 -0700446 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200447 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700448
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700449 // Add CVO extension.
450 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800451 cricket::VideoSendParameters parameters;
452 parameters.codecs.push_back(GetEngineCodec("VP8"));
453 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200454 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700455 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700456 // Also remove the first codec to trigger a codec change as well.
457 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200458 EXPECT_CALL(
459 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200460 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200461 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200462 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700463
464 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200465 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700466
467 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200468 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200469 EXPECT_CALL(
470 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200471 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200472 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200473 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700474}
475
eladalonf1841382017-06-12 01:16:46 -0700476TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200477 encoder_factory_->AddSupportedVideoCodecType("VP8");
478
Sebastian Jansson84848f22018-11-16 10:40:36 +0100479 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200480 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
481 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000482
483 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
484
485 EXPECT_FALSE(channel->SetSend(true))
486 << "Channel should not start without codecs.";
487 EXPECT_TRUE(channel->SetSend(false))
488 << "Channel should be stoppable even without set codecs.";
489}
490
eladalonf1841382017-06-12 01:16:46 -0700491TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200492 encoder_factory_->AddSupportedVideoCodecType("VP8");
493
Sebastian Jansson84848f22018-11-16 10:40:36 +0100494 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200495 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
496 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000497 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
498 VideoMediaInfo info;
499 channel->GetStats(&info);
500}
501
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200502TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200503 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000504
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200505 std::unique_ptr<VideoMediaChannel> channel(
506 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800507 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000508
509 EXPECT_TRUE(
510 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200511 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000512 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100513 webrtc::test::FrameForwarder frame_forwarder;
514 cricket::FakeFrameSource frame_source(1280, 720,
515 rtc::kNumMicrosecsPerSec / 30);
516 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
517 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100518 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200519 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
520 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000521 kTimeout);
522
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200523 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100524 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000525
526 // Setting codecs of the same type should not reallocate any encoders
527 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800528 cricket::VideoSendParameters parameters;
529 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200530 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200531 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000532
533 // Remove stream previously added to free the external encoder instance.
534 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200535 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000536}
537
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200538// Test that when an encoder factory supports H264, we add an RTX
539// codec for it.
540// TODO(deadbeef): This test should be updated if/when we start
541// adding RTX codecs for unrecognized codec names.
542TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800543 using webrtc::H264::ProfileLevelIdToString;
544 using webrtc::H264::ProfileLevelId;
545 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200546 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
547 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800548 *ProfileLevelIdToString(
549 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200550 webrtc::SdpVideoFormat h264_constrained_high("H264");
551 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800552 *ProfileLevelIdToString(
553 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200554 webrtc::SdpVideoFormat h264_high("H264");
555 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800556 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
557
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200558 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
559 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
560 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700561
magjed725e4842016-11-16 00:48:13 -0800562 // First figure out what payload types the test codecs got assigned.
563 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800564 // Now search for RTX codecs for them. Expect that they all have associated
565 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800566 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200567 codecs,
568 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
569 ->id));
magjed725e4842016-11-16 00:48:13 -0800570 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200571 codecs,
572 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
573 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800574 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200575 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700576}
577
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100578#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700579TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200580 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100581
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200582 std::unique_ptr<VideoMediaChannel> channel(
583 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100584
585 EXPECT_TRUE(
586 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
587}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100588#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100589
eladalonf1841382017-06-12 01:16:46 -0700590TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200591 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100592 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200593 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200594 std::unique_ptr<VideoMediaChannel> channel(
595 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700596
597 EXPECT_TRUE(
598 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
599
Niels Möllerd0f0f682019-01-14 09:09:53 +0100600 webrtc::test::FrameForwarder frame_forwarder;
601 cricket::FakeFrameSource frame_source(1280, 720,
602 rtc::kNumMicrosecsPerSec / 60);
603 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700604 channel->SetSend(true);
605
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200606 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700607
Niels Möllerd0f0f682019-01-14 09:09:53 +0100608 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700609 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700610 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100611 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700612 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700613 int64_t interval = timestamp - last_timestamp;
614
615 // Precision changes from nanosecond to millisecond.
616 // Allow error to be no more than 1.
617 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
618
619 last_timestamp = timestamp;
620 }
621
Niels Möllerd0f0f682019-01-14 09:09:53 +0100622 frame_forwarder.IncomingCapturedFrame(
623 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
624 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700625 last_timestamp = stream->GetLastTimestamp();
626 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100627 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
628 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
629 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700630 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700631 int64_t interval = timestamp - last_timestamp;
632
633 // Precision changes from nanosecond to millisecond.
634 // Allow error to be no more than 1.
635 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
636
637 last_timestamp = timestamp;
638 }
639
640 // Remove stream previously added to free the external encoder instance.
641 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
642}
643
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200644void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
645 std::vector<VideoCodec> engine_codecs = engine_.codecs();
646 RTC_DCHECK(!engine_codecs.empty());
647 for (const cricket::VideoCodec& codec : engine_codecs) {
648 if (codec.name == "rtx") {
649 int associated_payload_type;
650 if (codec.GetParam(kCodecParamAssociatedPayloadType,
651 &associated_payload_type)) {
652 default_apt_rtx_types_[associated_payload_type] = codec.id;
653 }
654 }
655 }
656}
657
658void WebRtcVideoEngineTest::AssignDefaultCodec() {
659 std::vector<VideoCodec> engine_codecs = engine_.codecs();
660 RTC_DCHECK(!engine_codecs.empty());
661 bool codec_set = false;
662 for (const cricket::VideoCodec& codec : engine_codecs) {
663 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
664 codec.name != "ulpfec") {
665 default_codec_ = codec;
666 codec_set = true;
667 }
668 }
669
670 RTC_DCHECK(codec_set);
671}
672
Oleh Prypina40f8242017-12-21 13:32:23 +0100673size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
674 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100675 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
676 for (size_t i = 0; i < codecs.size(); ++i) {
677 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200678 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200679 continue;
680 // The tests only use H264 Constrained Baseline. Make sure we don't return
681 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200682 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200683 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200684 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
685 if (profile_level_id->profile !=
686 webrtc::H264::kProfileConstrainedBaseline) {
687 continue;
688 }
689 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100690 return i;
magjed509e4fe2016-11-18 01:34:11 -0800691 }
692 // This point should never be reached.
693 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100694 return -1;
695}
696
697cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
698 const std::string& name) const {
699 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800700}
701
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200702VideoMediaChannel*
703WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100704 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200705 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
706 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200707 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800708 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200709 for (const webrtc::SdpVideoFormat& format :
710 encoder_factory_->GetSupportedFormats()) {
711 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800712 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200713 parameters.codecs.push_back(engine_codec);
714 }
715 }
magjed509e4fe2016-11-18 01:34:11 -0800716
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200717 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000718
719 return channel;
720}
721
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200722VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000723 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100724 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200725 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
726 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200727 cricket::VideoRecvParameters parameters;
728 parameters.codecs = codecs;
729 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000730
731 return channel;
732}
733
Elad Alon157540a2019-02-08 23:37:52 +0100734void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
735 bool supported) const {
736 const RtpCapabilities capabilities = engine_.GetCapabilities();
737 if (supported) {
738 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200739 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100740 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200741 EXPECT_THAT(capabilities.header_extensions,
742 ::testing::Each(::testing::Field(&RtpExtension::uri,
743 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100744 }
745}
746
eladalonf1841382017-06-12 01:16:46 -0700747TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200748 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000749
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200750 std::unique_ptr<VideoMediaChannel> channel(
751 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000752
Peter Boström0c4e06b2015-10-07 12:23:21 +0200753 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000754
Yves Gerey665174f2018-06-19 15:03:05 +0200755 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000756 EXPECT_TRUE(channel->SetSend(true));
757
Niels Möller805a27e2019-01-21 12:21:27 +0100758 webrtc::test::FrameForwarder frame_forwarder;
759 cricket::FakeFrameSource frame_source(1280, 720,
760 rtc::kNumMicrosecsPerSec / 60);
761 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
762 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000763
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200764 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000765
766 // Verify that encoders are configured for simulcast through adapter
767 // (increasing resolution and only configured to send one stream each).
768 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200769 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
770 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000771 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200772 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000773 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
774 EXPECT_GT(codec_settings.width, prev_width);
775 prev_width = codec_settings.width;
776 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000777
Niels Möllerff40b142018-04-09 08:49:14 +0200778 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000779
780 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200781 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000782}
783
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200784TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
785 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200786 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000787
Niels Möllerd0f0f682019-01-14 09:09:53 +0100788 // Frame source.
789 webrtc::test::FrameForwarder frame_forwarder;
790 cricket::FakeFrameSource frame_source(1280, 720,
791 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200792
Sebastian Jansson84848f22018-11-16 10:40:36 +0100793 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200794 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
795 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200796 cricket::VideoSendParameters parameters;
797 parameters.codecs.push_back(GetEngineCodec("H264"));
798 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000799
800 EXPECT_TRUE(
801 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100802 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200803 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100804 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200805
806 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000807
Anders Carlsson67537952018-05-03 11:28:29 +0200808 cricket::VideoSendParameters new_parameters;
809 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
810 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200811
812 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100813 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200814
Anders Carlsson8a150d92018-05-14 12:40:04 +0200815 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000816}
817
eladalonf1841382017-06-12 01:16:46 -0700818TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000819 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200820 encoder_factory_->AddSupportedVideoCodecType("VP8");
821 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822
Sebastian Jansson84848f22018-11-16 10:40:36 +0100823 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200824 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
825 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800826 cricket::VideoSendParameters parameters;
827 parameters.codecs.push_back(GetEngineCodec("VP8"));
828 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000829
Peter Boström0c4e06b2015-10-07 12:23:21 +0200830 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000831
Yves Gerey665174f2018-06-19 15:03:05 +0200832 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000833 EXPECT_TRUE(channel->SetSend(true));
834
835 // Send a fake frame, or else the media engine will configure the simulcast
836 // encoder adapter at a low-enough size that it'll only create a single
837 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100838 webrtc::test::FrameForwarder frame_forwarder;
839 cricket::FakeFrameSource frame_source(1280, 720,
840 rtc::kNumMicrosecsPerSec / 30);
841 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
842 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000843
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200844 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
845 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000846 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000848
849 channel.reset();
850 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200851 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000852}
853
eladalonf1841382017-06-12 01:16:46 -0700854TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000855 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200856 encoder_factory_->AddSupportedVideoCodecType("VP8");
857 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000858
Sebastian Jansson84848f22018-11-16 10:40:36 +0100859 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200860 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
861 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800862 cricket::VideoSendParameters parameters;
863 parameters.codecs.push_back(GetEngineCodec("H264"));
864 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000865
866 EXPECT_TRUE(
867 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100868
869 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100870 webrtc::test::FrameForwarder frame_forwarder;
871 cricket::FakeFrameSource frame_source(1280, 720,
872 rtc::kNumMicrosecsPerSec / 30);
873 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
874 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200875 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
876 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200877 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000878 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200879 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000880
881 channel.reset();
882 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200883 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000884}
885
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200886TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200887 RTC_DCHECK(!override_field_trials_);
888 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200889 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200890 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700891
Sebastian Jansson84848f22018-11-16 10:40:36 +0100892 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200893 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
894 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200895 cricket::VideoSendParameters parameters;
896 parameters.codecs.push_back(GetEngineCodec("H264"));
897 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700898
Peter Boström0c4e06b2015-10-07 12:23:21 +0200899 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700900 EXPECT_TRUE(
901 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100902
903 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100904 webrtc::test::FrameForwarder frame_forwarder;
905 cricket::FakeFrameSource frame_source(1280, 720,
906 rtc::kNumMicrosecsPerSec / 30);
907 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
908 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100909
Niels Möller4db138e2018-04-19 09:04:13 +0200910 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200911 ASSERT_EQ(1u, encoder_factory_->encoders().size());
912 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
913 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700914 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200915 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200916 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700917}
918
brandtrffc61182016-11-28 06:02:22 -0800919// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700920// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800921//
922// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700923TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800924 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200925 encoder_factory_->AddSupportedVideoCodecType("VP8");
926
Steve Anton2c9ebef2019-01-28 17:27:58 -0800927 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800928
929 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800930 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800931
932 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200933 RTC_DCHECK(!override_field_trials_);
934 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800935 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800936 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800937}
938
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200939// Test that codecs are added in the order they are reported from the factory.
940TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
941 encoder_factory_->AddSupportedVideoCodecType("VP8");
942 const char* kFakeCodecName = "FakeCodec";
943 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000944
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200945 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100946 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200947 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
948 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000949}
950
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200951// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800952// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200953TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100954 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
955 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100956
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100957 // Set up external encoder factory with first codec, and initialize engine.
958 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
959
brandtrffc61182016-11-28 06:02:22 -0800960 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800961
962 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100963 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800964 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200965 // The codec itself and RTX should have been added.
966 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100967
968 // Check that both fake codecs are present and that the second fake codec
969 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100970 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
971 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100972 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800973}
974
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200975TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
976 const char* kFakeCodecName = "FakeCodec";
977 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
978
979 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
980 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
981}
982
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200983TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
984 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200985 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200986 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800987 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000988
kwiberg686a8ef2016-02-26 03:00:35 -0800989 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200990 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000991
992 EXPECT_TRUE(
993 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200994 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000995
996 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200997 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200998 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000999
1000 // Remove stream previously added to free the external decoder instance.
1001 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001002 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001003}
1004
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001005// Verifies that we can set up decoders.
1006TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001007 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1008 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1009 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1010 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001011 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001012 webrtc::SdpVideoFormat supported_h264("H264");
1013 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1014 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001015 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001016 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001017
kwiberg686a8ef2016-02-26 03:00:35 -08001018 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001019 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001020
1021 EXPECT_TRUE(
1022 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001023 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001024}
1025
Jonas Oreland49ac5952018-09-26 16:04:32 +02001026// Tests when GetSources is called with non-existing ssrc, it will return an
1027// empty list of RtpSource without crashing.
1028TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1029 // Setup an recv stream with |kSsrc|.
1030 encoder_factory_->AddSupportedVideoCodecType("VP8");
1031 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1032 cricket::VideoRecvParameters parameters;
1033 parameters.codecs.push_back(GetEngineCodec("VP8"));
1034 std::unique_ptr<VideoMediaChannel> channel(
1035 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1036
1037 EXPECT_TRUE(
1038 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1039
1040 // Call GetSources with |kSsrc + 1| which doesn't exist.
1041 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1042 EXPECT_EQ(0u, sources.size());
1043}
1044
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001045TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1046 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1047 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1048 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001049 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001050 EXPECT_EQ(0u, engine.codecs().size());
1051}
1052
1053TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1054 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001055 webrtc::MockVideoEncoderFactory* encoder_factory =
1056 new webrtc::MockVideoEncoderFactory();
1057 webrtc::MockVideoDecoderFactory* decoder_factory =
1058 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001059 WebRtcVideoEngine engine(
1060 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001061 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001062 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1063 EXPECT_EQ(0u, engine.codecs().size());
1064 EXPECT_CALL(*encoder_factory, Die());
1065 EXPECT_CALL(*decoder_factory, Die());
1066}
1067
1068// Test full behavior in the video engine when video codec factories of the new
1069// type are injected supporting the single codec Vp8. Check the returned codecs
1070// from the engine and that we will create a Vp8 encoder and decoder using the
1071// new factories.
1072TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1073 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001074 webrtc::MockVideoEncoderFactory* encoder_factory =
1075 new webrtc::MockVideoEncoderFactory();
1076 webrtc::MockVideoDecoderFactory* decoder_factory =
1077 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001078 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1079 rate_allocator_factory =
1080 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001081 EXPECT_CALL(*rate_allocator_factory,
1082 CreateVideoBitrateAllocatorProxy(Field(
1083 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001084 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001085 WebRtcVideoEngine engine(
1086 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001087 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001088 const webrtc::SdpVideoFormat vp8_format("VP8");
1089 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1090 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001091 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001092
1093 // Verify the codecs from the engine.
1094 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001095 // Verify default codecs has been added correctly.
1096 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001097 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001098
1099 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001100 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001101 int vp8_associated_payload;
1102 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1103 &vp8_associated_payload));
1104 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1105
1106 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1107
1108 // RTX codec for RED.
1109 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1110 int red_associated_payload;
1111 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1112 &red_associated_payload));
1113 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1114
1115 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1116
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001117 int associated_payload_type;
1118 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1119 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1120 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1121 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001122 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1123 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001124
1125 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001126 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1127 codec_info.is_hardware_accelerated = false;
1128 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001129 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001130 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001131 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001132 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001133 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001134 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001135 .WillOnce(
1136 ::testing::DoAll(::testing::InvokeWithoutArgs(
1137 [&encoder_created]() { encoder_created.Set(); }),
1138 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001139
1140 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001141 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001142 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001143 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001144
1145 // Create a call.
1146 webrtc::RtcEventLogNullImpl event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001147 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1148 webrtc::Call::Config call_config(&event_log);
1149 call_config.task_queue_factory = task_queue_factory.get();
1150 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001151
1152 // Create send channel.
1153 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001154 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001155 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1156 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001157 cricket::VideoSendParameters send_parameters;
1158 send_parameters.codecs.push_back(engine_codecs.at(0));
1159 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1160 send_channel->OnReadyToSend(true);
1161 EXPECT_TRUE(
1162 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1163 EXPECT_TRUE(send_channel->SetSend(true));
1164
Niels Möller4db138e2018-04-19 09:04:13 +02001165 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001166 webrtc::test::FrameForwarder frame_forwarder;
1167 cricket::FakeFrameSource frame_source(1280, 720,
1168 rtc::kNumMicrosecsPerSec / 30);
1169 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001170 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001171 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001172 encoder_created.Wait(kTimeout);
1173
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001174 // Create recv channel.
1175 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001176 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001177 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1178 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001179 cricket::VideoRecvParameters recv_parameters;
1180 recv_parameters.codecs.push_back(engine_codecs.at(0));
1181 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1182 EXPECT_TRUE(recv_channel->AddRecvStream(
1183 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1184
1185 // Remove streams previously added to free the encoder and decoder instance.
1186 EXPECT_CALL(*encoder_factory, Die());
1187 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001188 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001189 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1190 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1191}
1192
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001193// Test behavior when decoder factory fails to create a decoder (returns null).
1194TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1195 // |engine| take ownership of the factories.
1196 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001197 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001198 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001199 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001200 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1201 rate_allocator_factory =
1202 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001203 WebRtcVideoEngine engine(
1204 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001205 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001206 const webrtc::SdpVideoFormat vp8_format("VP8");
1207 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1208 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001209 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001210
1211 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001212 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1213 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001214
1215 // Create a call.
1216 webrtc::RtcEventLogNullImpl event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001217 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1218 webrtc::Call::Config call_config(&event_log);
1219 call_config.task_queue_factory = task_queue_factory.get();
1220 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001221
1222 // Create recv channel.
1223 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001224 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001225 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1226 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001227 cricket::VideoRecvParameters recv_parameters;
1228 recv_parameters.codecs.push_back(engine.codecs().front());
1229 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1230 EXPECT_TRUE(recv_channel->AddRecvStream(
1231 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1232
1233 // Remove streams previously added to free the encoder and decoder instance.
1234 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1235}
1236
eladalonf1841382017-06-12 01:16:46 -07001237TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001238 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001239 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001240 std::unique_ptr<VideoMediaChannel> channel(
1241 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001242 ASSERT_TRUE(
1243 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1244 cricket::VideoCodec codec = GetEngineCodec("VP8");
1245 cricket::VideoSendParameters parameters;
1246 parameters.codecs.push_back(codec);
1247 channel->OnReadyToSend(true);
1248 channel->SetSend(true);
1249 ASSERT_TRUE(channel->SetSendParameters(parameters));
1250
Niels Möller805a27e2019-01-21 12:21:27 +01001251 webrtc::test::FrameForwarder frame_forwarder;
1252 cricket::FakeFrameSource frame_source(1280, 720,
1253 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001254 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001255 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001256
Niels Möller805a27e2019-01-21 12:21:27 +01001257 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001258 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001259 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001260 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001261
Niels Möller805a27e2019-01-21 12:21:27 +01001262 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1263 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001264 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001265 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001266
1267 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001268 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1269 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001270 // Change to screen content, recreate encoder. For the simulcast encoder
1271 // adapter case, this will result in two calls since InitEncode triggers a
1272 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001273 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001274 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001275 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001276
Niels Möller805a27e2019-01-21 12:21:27 +01001277 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1278 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001279 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001280 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001281
1282 options.is_screencast.emplace(false);
1283 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001284 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001285 // Change back to regular video content, update encoder. Also change
1286 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001287 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001288 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001289 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001290 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001291
1292 // Remove stream previously added to free the external encoder instance.
1293 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001294 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001295}
1296
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001297class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001298 protected:
1299 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001300 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1301 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001302 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1303 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1304 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001305
1306 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001307 // One testcase calls SetUp in a loop, only create call_ once.
1308 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001309 webrtc::Call::Config call_config(&event_log_);
1310 call_config.task_queue_factory = task_queue_factory_.get();
1311 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001312 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001313 cricket::MediaConfig media_config;
1314 // Disabling cpu overuse detection actually disables quality scaling too; it
1315 // implies DegradationPreference kMaintainResolution. Automatic scaling
1316 // needs to be disabled, otherwise, tests which check the size of received
1317 // frames become flaky.
1318 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001319 channel_.reset(
1320 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1321 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001322 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001323 channel_->OnReadyToSend(true);
1324 EXPECT_TRUE(channel_.get() != NULL);
1325 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001326 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001327 cricket::VideoRecvParameters parameters;
1328 parameters.codecs = engine_.codecs();
1329 channel_->SetRecvParameters(parameters);
1330 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001331 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1332 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1333 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1334 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001335 }
1336
1337 // Utility method to setup an additional stream to send and receive video.
1338 // Used to test send and recv between two streams.
1339 void SetUpSecondStream() {
1340 SetUpSecondStreamWithNoRecv();
1341 // Setup recv for second stream.
1342 EXPECT_TRUE(channel_->AddRecvStream(
1343 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1344 // Make the second renderer available for use by a new stream.
1345 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1346 }
1347 // Setup an additional stream just to send video. Defer add recv stream.
1348 // This is required if you want to test unsignalled recv of video rtp packets.
1349 void SetUpSecondStreamWithNoRecv() {
1350 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001351 EXPECT_TRUE(
1352 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001353 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001354 EXPECT_FALSE(
1355 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001356 EXPECT_TRUE(channel_->AddSendStream(
1357 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1358 // We dont add recv for the second stream.
1359
1360 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001361 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001362 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001363 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001364 }
Yves Gerey665174f2018-06-19 15:03:05 +02001365 virtual void TearDown() { channel_.reset(); }
1366 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001367
1368 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001369 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1370 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001371
1372 bool sending = channel_->sending();
1373 bool success = SetSend(false);
1374 if (success) {
1375 cricket::VideoSendParameters parameters;
1376 parameters.codecs.push_back(codec);
1377 success = channel_->SetSendParameters(parameters);
1378 }
1379 if (success) {
1380 success = SetSend(sending);
1381 }
1382 return success;
1383 }
Yves Gerey665174f2018-06-19 15:03:05 +02001384 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001385 void SendFrame() {
1386 if (frame_forwarder_2_) {
1387 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001388 }
Niels Möller805a27e2019-01-21 12:21:27 +01001389 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001390 }
1391 bool WaitAndSendFrame(int wait_ms) {
1392 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001393 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001394 return ret;
1395 }
Yves Gerey665174f2018-06-19 15:03:05 +02001396 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 int NumRtpBytes(uint32_t ssrc) {
1398 return network_interface_.NumRtpBytes(ssrc);
1399 }
Yves Gerey665174f2018-06-19 15:03:05 +02001400 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001401 int NumRtpPackets(uint32_t ssrc) {
1402 return network_interface_.NumRtpPackets(ssrc);
1403 }
Yves Gerey665174f2018-06-19 15:03:05 +02001404 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001405 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1406 return network_interface_.GetRtpPacket(index);
1407 }
1408 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001409 webrtc::RTPHeader header;
1410 EXPECT_TRUE(ParseRtpPacket(p, &header));
1411 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001412 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001413
Niels Möller6557d0c2018-04-11 15:18:34 +02001414 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001415 webrtc::RTPHeader* header) {
1416 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1417 webrtc::RtpHeaderParser::Create());
1418 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001419 }
1420
1421 // Tests that we can send and receive frames.
1422 void SendAndReceive(const cricket::VideoCodec& codec) {
1423 EXPECT_TRUE(SetOneCodec(codec));
1424 EXPECT_TRUE(SetSend(true));
1425 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1426 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001427 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001428 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1429 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1430 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1431 }
1432
1433 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001434 int duration_sec,
1435 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001436 EXPECT_TRUE(SetOneCodec(codec));
1437 EXPECT_TRUE(SetSend(true));
1438 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1439 EXPECT_EQ(0, renderer_.num_rendered_frames());
1440 for (int i = 0; i < duration_sec; ++i) {
1441 for (int frame = 1; frame <= fps; ++frame) {
1442 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1443 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1444 }
1445 }
1446 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1447 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1448 }
1449
Niels Möller6557d0c2018-04-11 15:18:34 +02001450 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1451 cricket::VideoMediaInfo info;
1452 EXPECT_TRUE(channel_->GetStats(&info));
1453 return info.senders[i];
1454 }
1455
1456 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1457 cricket::VideoMediaInfo info;
1458 EXPECT_TRUE(channel_->GetStats(&info));
1459 return info.receivers[i];
1460 }
1461
1462 // Two streams one channel tests.
1463
1464 // Tests that we can send and receive frames.
1465 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1466 SetUpSecondStream();
1467 // Test sending and receiving on first stream.
1468 SendAndReceive(codec);
1469 // Test sending and receiving on second stream.
1470 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1471 EXPECT_GT(NumRtpPackets(), 0);
1472 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1473 }
1474
1475 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1476 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001477 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001478 return engine_codec;
1479 }
1480 // This point should never be reached.
1481 ADD_FAILURE() << "Unrecognized codec name: " << name;
1482 return cricket::VideoCodec();
1483 }
1484
1485 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1486
1487 cricket::StreamParams DefaultSendStreamParams() {
1488 return cricket::StreamParams::CreateLegacy(kSsrc);
1489 }
1490
1491 webrtc::RtcEventLogNullImpl event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001492 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001493 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001494 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1495 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001496 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001497
1498 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1499 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1500 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1501
Niels Möller6557d0c2018-04-11 15:18:34 +02001502 std::unique_ptr<WebRtcVideoChannel> channel_;
1503 cricket::FakeNetworkInterface network_interface_;
1504 cricket::FakeVideoRenderer renderer_;
1505
1506 // Used by test cases where 2 streams are run on the same channel.
1507 cricket::FakeVideoRenderer renderer2_;
1508};
1509
1510// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001511TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001512 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001513 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001514 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1515 EXPECT_FALSE(channel_->sending());
1516 EXPECT_TRUE(SetSend(true));
1517 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001518 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001519 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1520 EXPECT_TRUE(SetSend(false));
1521 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001522}
Niels Möller6557d0c2018-04-11 15:18:34 +02001523
1524// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001525TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001526 EXPECT_FALSE(channel_->sending());
1527 EXPECT_FALSE(SetSend(true));
1528 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001529}
Niels Möller6557d0c2018-04-11 15:18:34 +02001530
1531// Test that we properly set the send and recv buffer sizes by the time
1532// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001533TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001534 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1535 EXPECT_TRUE(SetSend(true));
1536 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001537 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001538}
1539
Johannes Kron5a0665b2019-04-08 10:35:50 +02001540// Test that we properly set the send and recv buffer sizes when overriding
1541// via field trials.
1542TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1543 // Set field trial to override the default recv buffer size, and then re-run
1544 // setup where the interface is created and configured.
1545 const int kCustomRecvBufferSize = 123456;
1546 webrtc::test::ScopedFieldTrials field_trial(
1547 "WebRTC-IncreasedReceivebuffers/123456/");
1548 SetUp();
1549
1550 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1551 EXPECT_TRUE(SetSend(true));
1552 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1553 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1554}
1555
1556// Test that we properly set the send and recv buffer sizes when overriding
1557// via field trials with suffix.
1558TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1559 // Set field trial to override the default recv buffer size, and then re-run
1560 // setup where the interface is created and configured.
1561 const int kCustomRecvBufferSize = 123456;
1562 webrtc::test::ScopedFieldTrials field_trial(
1563 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1564 SetUp();
1565
1566 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1567 EXPECT_TRUE(SetSend(true));
1568 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1569 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1570}
1571
1572// Test that we properly set the send and recv buffer sizes when overriding
1573// via field trials that don't make any sense.
1574TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1575 // Set bogus field trial values to override the default recv buffer size, and
1576 // then re-run setup where the interface is created and configured. The
1577 // default value should still be used.
1578
1579 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1580 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1581 field_trial_string += group;
1582 field_trial_string += "/";
1583 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1584 SetUp();
1585
1586 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1587 EXPECT_TRUE(SetSend(true));
1588 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1589 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1590 }
1591}
1592
Niels Möller6557d0c2018-04-11 15:18:34 +02001593// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001594TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001595 const int kDurationSec = 3;
1596 const int kFps = 10;
1597 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1598
1599 cricket::VideoMediaInfo info;
1600 EXPECT_TRUE(channel_->GetStats(&info));
1601
1602 ASSERT_EQ(1U, info.senders.size());
1603 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1604 // For webrtc, bytes_sent does not include the RTP header length.
1605 EXPECT_GT(info.senders[0].bytes_sent, 0);
1606 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1607 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1608 ASSERT_TRUE(info.senders[0].codec_payload_type);
1609 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1610 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1611 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1612 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1613 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1614 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1615 EXPECT_GT(info.senders[0].framerate_input, 0);
1616 EXPECT_GT(info.senders[0].framerate_sent, 0);
1617
1618 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1619 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1620 info.send_codecs[DefaultCodec().id]);
1621
1622 ASSERT_EQ(1U, info.receivers.size());
1623 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1624 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1625 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1626 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1627 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1628 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1629 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001630 EXPECT_EQ(0, info.receivers[0].packets_lost);
1631 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1632 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1633 EXPECT_EQ(0, info.receivers[0].firs_sent);
1634 EXPECT_EQ(0, info.receivers[0].plis_sent);
1635 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1636 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1637 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1638 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1639 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1640 EXPECT_GT(info.receivers[0].framerate_output, 0);
1641
1642 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1643 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1644 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001645}
Niels Möller6557d0c2018-04-11 15:18:34 +02001646
1647// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001648TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001649 cricket::FakeVideoRenderer renderer1, renderer2;
1650 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1651 cricket::VideoSendParameters parameters;
1652 parameters.codecs.push_back(DefaultCodec());
1653 parameters.conference_mode = true;
1654 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1655 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001656 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1657 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001658 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1659 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1660 EXPECT_EQ(0, renderer1.num_rendered_frames());
1661 EXPECT_EQ(0, renderer2.num_rendered_frames());
1662 std::vector<uint32_t> ssrcs;
1663 ssrcs.push_back(1);
1664 ssrcs.push_back(2);
1665 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001666 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001667 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1668 kTimeout);
1669 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1670 kTimeout);
1671
1672 EXPECT_TRUE(channel_->SetSend(false));
1673
1674 cricket::VideoMediaInfo info;
1675 EXPECT_TRUE(channel_->GetStats(&info));
1676 ASSERT_EQ(1U, info.senders.size());
1677 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1678 // For webrtc, bytes_sent does not include the RTP header length.
1679 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1680 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1681 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1682 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1683
1684 ASSERT_EQ(2U, info.receivers.size());
1685 for (size_t i = 0; i < info.receivers.size(); ++i) {
1686 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1687 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1688 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001689 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001690 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1691 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1692 }
srtee0c2eea2017-12-15 17:44:33 +01001693}
Niels Möller6557d0c2018-04-11 15:18:34 +02001694
1695// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001696TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001697 // Normal setup; note that we set the SSRC explicitly to ensure that
1698 // it will come first in the senders map.
1699 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1700 cricket::VideoSendParameters parameters;
1701 parameters.codecs.push_back(DefaultCodec());
1702 parameters.conference_mode = true;
1703 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_TRUE(
1705 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001706 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1707 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001708 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001709 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1710 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1711
1712 // Add an additional capturer, and hook up a renderer to receive it.
1713 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001714 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001715 const int kTestWidth = 160;
1716 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001717 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1718 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001719 EXPECT_TRUE(
1720 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001721 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001722 EXPECT_TRUE(
1723 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001724 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001725 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001726 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1727 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001728
1729 // Get stats, and make sure they are correct for two senders. We wait until
1730 // the number of expected packets have been sent to avoid races where we
1731 // check stats before it has been updated.
1732 cricket::VideoMediaInfo info;
1733 for (uint32_t i = 0; i < kTimeout; ++i) {
1734 rtc::Thread::Current()->ProcessMessages(1);
1735 EXPECT_TRUE(channel_->GetStats(&info));
1736 ASSERT_EQ(2U, info.senders.size());
1737 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1738 NumRtpPackets()) {
1739 // Stats have been updated for both sent frames, expectations can be
1740 // checked now.
1741 break;
1742 }
1743 }
1744 EXPECT_EQ(NumRtpPackets(),
1745 info.senders[0].packets_sent + info.senders[1].packets_sent)
1746 << "Timed out while waiting for packet counts for all sent packets.";
1747 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1748 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1749 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1750 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1751 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1752 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1753 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1754 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1755 // The capturer must be unregistered here as it runs out of it's scope next.
1756 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001757}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001758
Niels Möller6557d0c2018-04-11 15:18:34 +02001759// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001760TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001761 cricket::VideoSendParameters parameters;
1762 parameters.codecs.push_back(DefaultCodec());
1763 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1764 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1765 parameters.max_bandwidth_bps = 128 * 1024;
1766 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001767}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001768
Niels Möller6557d0c2018-04-11 15:18:34 +02001769// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001770TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001771 EXPECT_TRUE(SetDefaultCodec());
1772 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001773 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001774 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001775 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001777 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1778 EXPECT_EQ(kSsrc, header.ssrc);
1779
Niels Möller6557d0c2018-04-11 15:18:34 +02001780 // Packets are being paced out, so these can mismatch between the first and
1781 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001782 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1783 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001784 EXPECT_EQ(1, NumSentSsrcs());
1785 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1786 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001787}
Niels Möller6557d0c2018-04-11 15:18:34 +02001788
1789// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001790TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 // Remove stream added in Setup.
1792 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1793 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001794 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001795 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001796 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001797 EXPECT_TRUE(SetSend(true));
1798 EXPECT_TRUE(WaitAndSendFrame(0));
1799 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001800 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001801 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001802 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1803 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001804 // Packets are being paced out, so these can mismatch between the first and
1805 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001806 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1807 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001808 EXPECT_EQ(1, NumSentSsrcs());
1809 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1810 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001811}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001812
Niels Möller6557d0c2018-04-11 15:18:34 +02001813// Test that we can set the default video renderer before and after
1814// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001815TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001816 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1817 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001818
1819 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1820 rtc::SetBE32(packet1.data() + 8, kSsrc);
1821 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1822 EXPECT_TRUE(SetDefaultCodec());
1823 EXPECT_TRUE(SetSend(true));
1824 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001825 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001826 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001827 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001828 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001829}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001830
Niels Möller6557d0c2018-04-11 15:18:34 +02001831// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001832TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001833 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1834 EXPECT_TRUE(SetSend(true));
1835 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001836 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001837 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1838 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001839 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001840 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001841 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1842 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001843 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1844 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001845
1846 // Remove the send stream that was added during Setup.
1847 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1848 int rtp_packets = NumRtpPackets();
1849
Niels Möller6557d0c2018-04-11 15:18:34 +02001850 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001851 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001852 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001853 EXPECT_EQ(rtp_packets, NumRtpPackets());
1854 // Wait 30ms to guarantee the engine does not drop the frame.
1855 EXPECT_TRUE(WaitAndSendFrame(30));
1856 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1857
1858 last_packet = NumRtpPackets() - 1;
1859 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001860 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1861 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001862}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001863
Niels Möller6557d0c2018-04-11 15:18:34 +02001864// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001865TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001866 cricket::FakeVideoRenderer renderer1, renderer2;
1867 EXPECT_TRUE(SetDefaultCodec());
1868 cricket::VideoSendParameters parameters;
1869 parameters.codecs.push_back(DefaultCodec());
1870 parameters.conference_mode = true;
1871 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1872 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001873 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1874 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001875 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1876 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1877 EXPECT_EQ(0, renderer1.num_rendered_frames());
1878 EXPECT_EQ(0, renderer2.num_rendered_frames());
1879 std::vector<uint32_t> ssrcs;
1880 ssrcs.push_back(1);
1881 ssrcs.push_back(2);
1882 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001883 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001884 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1885 kTimeout);
1886 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1887 kTimeout);
1888
1889 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1890 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1891 EXPECT_EQ(kVideoWidth, renderer1.width());
1892 EXPECT_EQ(kVideoHeight, renderer1.height());
1893 EXPECT_EQ(kVideoWidth, renderer2.width());
1894 EXPECT_EQ(kVideoHeight, renderer2.height());
1895 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1896 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001897}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001898
Niels Möller6557d0c2018-04-11 15:18:34 +02001899// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001900TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001901 using cricket::VideoCodec;
1902 using cricket::VideoOptions;
1903 using cricket::VideoFormat;
1904 using cricket::FOURCC_I420;
1905
1906 VideoCodec codec = DefaultCodec();
1907 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1908 EXPECT_TRUE(SetOneCodec(codec));
1909 EXPECT_TRUE(SetSend(true));
1910 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1911 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001912 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001913 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001914
1915 webrtc::test::FrameForwarder frame_forwarder;
1916 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1917 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001918
1919 // TODO(nisse): This testcase fails if we don't configure
1920 // screencast. It's unclear why, I see nothing obvious in this
1921 // test which is related to screencast logic.
1922 VideoOptions video_options;
1923 video_options.is_screencast = true;
1924 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1925
Niels Möller6557d0c2018-04-11 15:18:34 +02001926 int captured_frames = 1;
1927 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001928 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001929 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001930 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1931
Niels Möller6557d0c2018-04-11 15:18:34 +02001932 ++captured_frames;
1933 // Wait until frame of right size is captured.
1934 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001935 480 == renderer_.width() &&
1936 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001937 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001938 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001939 EXPECT_EQ(480, renderer_.width());
1940 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 captured_frames = renderer_.num_rendered_frames() + 1;
1942 EXPECT_FALSE(renderer_.black_frame());
1943 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1944 // Make sure a black frame is generated within the specified timeout.
1945 // The black frame should be the resolution of the previous frame to
1946 // prevent expensive encoder reconfigurations.
1947 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001948 480 == renderer_.width() &&
1949 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001950 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001951 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001952 EXPECT_EQ(480, renderer_.width());
1953 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001954 EXPECT_TRUE(renderer_.black_frame());
1955
1956 // The black frame has the same timestamp as the next frame since it's
1957 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1958 // not render a frame with the same timestamp so capture another frame
1959 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001960 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001961 }
srtee0c2eea2017-12-15 17:44:33 +01001962}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001963
Niels Möller6557d0c2018-04-11 15:18:34 +02001964// Tests that if SetVideoSend is called with a NULL capturer after the
1965// capturer was already removed, the application doesn't crash (and no black
1966// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001967TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001968 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1969 EXPECT_TRUE(SetSend(true));
1970 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1971 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001972 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1974 // Wait for one frame so they don't get dropped because we send frames too
1975 // tightly.
1976 rtc::Thread::Current()->ProcessMessages(30);
1977 // Remove the capturer.
1978 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1979
1980 // No capturer was added, so this SetVideoSend shouldn't do anything.
1981 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1982 rtc::Thread::Current()->ProcessMessages(300);
1983 // Verify no more frames were sent.
1984 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001985}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001986
Niels Möller6557d0c2018-04-11 15:18:34 +02001987// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001988TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001989 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1990 // interval time to avoid that.
1991 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1992 // interval time to avoid that.
1993 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001994 EXPECT_TRUE(
1995 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001996 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1997 cricket::VideoFormat capture_format(
1998 kVideoWidth, kVideoHeight,
1999 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2000 // Set up additional stream 1.
2001 cricket::FakeVideoRenderer renderer1;
2002 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002003 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002005 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002006
2007 webrtc::test::FrameForwarder frame_forwarder1;
2008 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2009 rtc::kNumMicrosecsPerSec / kFramerate);
2010
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 // Set up additional stream 2.
2012 cricket::FakeVideoRenderer renderer2;
2013 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002014 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002015 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002016 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002017 webrtc::test::FrameForwarder frame_forwarder2;
2018
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 // State for all the streams.
2020 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2021 // A limitation in the lmi implementation requires that SetVideoSend() is
2022 // called after SetOneCodec().
2023 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002024 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2025 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 EXPECT_TRUE(SetSend(true));
2027 // Test capturer associated with engine.
2028 const int kTestWidth = 160;
2029 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002030 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2031 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2032 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002033 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2034 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002035 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002036 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2037 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2038 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002039 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2040 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002041 // Successfully remove the capturer.
2042 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2043 // The capturers must be unregistered here as it runs out of it's scope
2044 // next.
2045 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2046 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002047}
Niels Möller6557d0c2018-04-11 15:18:34 +02002048
2049// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002050TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002051 // Remove the send stream that was added during Setup.
2052 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2053
2054 cricket::StreamParams empty;
2055 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002056 EXPECT_TRUE(
2057 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002058}
Niels Möller6557d0c2018-04-11 15:18:34 +02002059
2060// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002061TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002062 // Remove stream added in Setup. I.e. remove stream corresponding to default
2063 // channel.
2064 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002065 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002066 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2067 EXPECT_TRUE(channel_->AddSendStream(
2068 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2069 }
2070 // Delete one of the non default channel streams, let the destructor delete
2071 // the remaining ones.
2072 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2073 // Stream should already be deleted.
2074 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002075}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002076
eladalonf1841382017-06-12 01:16:46 -07002077TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002078 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002079}
2080
eladalonf1841382017-06-12 01:16:46 -07002081TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002082 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002083}
2084
eladalonf1841382017-06-12 01:16:46 -07002085TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002086 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002087}
2088
eladalonf1841382017-06-12 01:16:46 -07002089TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002090 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2091 // bitrates. This currently happens at <250k, and two streams sharing 300k
2092 // initially will use QVGA instead of VGA.
2093 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2094 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002095 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002096 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002097 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002098}
2099
philipele8ed8302019-07-03 11:53:48 +02002100TEST_F(WebRtcVideoChannelBaseTest, OnEncoderFailure) {
2101 cricket::VideoSendParameters parameters;
2102 parameters.codecs.push_back(GetEngineCodec("VP9"));
2103 parameters.codecs.push_back(GetEngineCodec("VP8"));
2104 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2105
2106 VideoCodec codec;
2107 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2108 EXPECT_EQ("VP9", codec.name);
2109
2110 // OnEncoderFailure will post a task to the worker thread (which is also
2111 // the current thread), hence the ProcessMessages call.
2112 channel_->OnEncoderFailure();
2113 rtc::Thread::Current()->ProcessMessages(30);
2114 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2115 EXPECT_EQ("VP8", codec.name);
2116
2117 // No other codec to fall back to, keep using VP8.
2118 channel_->OnEncoderFailure();
2119 rtc::Thread::Current()->ProcessMessages(30);
2120 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2121 EXPECT_EQ("VP8", codec.name);
2122}
2123
eladalonf1841382017-06-12 01:16:46 -07002124class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002125 public:
eladalonf1841382017-06-12 01:16:46 -07002126 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2127 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002128 : WebRtcVideoEngineTest(field_trials),
2129 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2130 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002131 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002132 encoder_factory_->AddSupportedVideoCodecType("VP8");
2133 encoder_factory_->AddSupportedVideoCodecType("VP9");
2134#if defined(WEBRTC_USE_H264)
2135 encoder_factory_->AddSupportedVideoCodecType("H264");
2136#endif
2137
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002138 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002139 channel_.reset(engine_.CreateMediaChannel(
2140 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2141 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002142 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002143 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002144 send_parameters_.codecs = engine_.codecs();
2145 recv_parameters_.codecs = engine_.codecs();
2146 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002147 }
2148
2149 protected:
2150 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002151 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002152 }
2153
2154 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002155 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002156 EXPECT_TRUE(channel_->AddSendStream(sp));
2157 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002158 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002159 EXPECT_EQ(num_streams + 1, streams.size());
2160 return streams[streams.size() - 1];
2161 }
2162
2163 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002164 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002165 }
2166
2167 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002168 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002169 }
2170
2171 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002172 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002173 EXPECT_TRUE(channel_->AddRecvStream(sp));
2174 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002175 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002176 EXPECT_EQ(num_streams + 1, streams.size());
2177 return streams[streams.size() - 1];
2178 }
2179
pbos@webrtc.org00873182014-11-25 14:03:34 +00002180 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2181 int expected_min_bitrate_bps,
2182 const char* start_bitrate_kbps,
2183 int expected_start_bitrate_bps,
2184 const char* max_bitrate_kbps,
2185 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002186 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2187 expected_start_bitrate_bps,
2188 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002189 auto& codecs = send_parameters_.codecs;
2190 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002191 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002192 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2193 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2194 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002195 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002196 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002197
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002198 void ExpectSetBitrateParameters(int min_bitrate_bps,
2199 int start_bitrate_bps,
2200 int max_bitrate_bps) {
2201 EXPECT_CALL(
2202 *fake_call_->GetMockTransportControllerSend(),
2203 SetSdpBitrateParameters(AllOf(
2204 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2205 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2206 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2207 }
2208
2209 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2210 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2211 SetSdpBitrateParameters(Field(
2212 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002213 }
2214
Johannes Kron9190b822018-10-29 11:22:05 +01002215 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2216 // For a caller, the answer will be applied in set remote description
2217 // where SetSendParameters() is called.
2218 EXPECT_TRUE(
2219 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2220 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2221 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2222 const webrtc::VideoSendStream::Config& config =
2223 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2224 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2225 }
2226
2227 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2228 // For a callee, the answer will be applied in set local description
2229 // where SetExtmapAllowMixed() and AddSendStream() are called.
2230 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2231 EXPECT_TRUE(
2232 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2233 const webrtc::VideoSendStream::Config& config =
2234 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2235 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2236 }
2237
isheriff6f8d6862016-05-26 11:24:55 -07002238 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002239 // Enable extension.
2240 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002241 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002242 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002243 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002244 FakeVideoSendStream* send_stream =
2245 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2246
2247 // Verify the send extension id.
2248 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2249 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002250 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002251 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002252 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002253 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2254 // receivers.
2255 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2256 ->GetConfig()
2257 .rtp.extensions.empty());
2258
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002259 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002260 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002261 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2262 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002263 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2264
2265 // Verify that adding receive RTP header extensions adds them for existing
2266 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002267 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002268 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002269 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2270 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002271 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002272 }
2273
isheriff6f8d6862016-05-26 11:24:55 -07002274 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002275 // Enable extension.
2276 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002277 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002278 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002279 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002280
2281 FakeVideoReceiveStream* recv_stream =
2282 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2283
2284 // Verify the recv extension id.
2285 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2286 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002287 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002288 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002289 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002290
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002291 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2292 // senders.
2293 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2294 ->GetConfig()
2295 .rtp.extensions.empty());
2296
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002297 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002298 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002299 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2300 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002301 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2302
2303 // Verify that adding receive RTP header extensions adds them for existing
2304 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002305 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002306 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002307 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2308 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002309 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002310 }
2311
Elad Alonfadb1812019-05-24 13:40:02 +02002312 void TestLossNotificationState(bool expect_lntf_enabled) {
2313 AssignDefaultCodec();
2314 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2315
2316 cricket::VideoSendParameters parameters;
2317 parameters.codecs = engine_.codecs();
2318 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2319 EXPECT_TRUE(channel_->SetSend(true));
2320
2321 // Send side.
2322 FakeVideoSendStream* send_stream =
2323 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2324 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2325
2326 // Receiver side.
2327 FakeVideoReceiveStream* recv_stream =
2328 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2329 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2330 }
2331
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002332 void TestExtensionFilter(const std::vector<std::string>& extensions,
2333 const std::string& expected_extension) {
2334 cricket::VideoSendParameters parameters = send_parameters_;
2335 int expected_id = -1;
2336 int id = 1;
2337 for (const std::string& extension : extensions) {
2338 if (extension == expected_extension)
2339 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002340 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002341 }
2342 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2343 FakeVideoSendStream* send_stream =
2344 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2345
2346 // Verify that only one of them has been set, and that it is the one with
2347 // highest priority (transport sequence number).
2348 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2349 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2350 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002351 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002352 }
2353
asapersson3c81a1a2017-06-14 05:52:21 -07002354 void TestDegradationPreference(bool resolution_scaling_enabled,
2355 bool fps_scaling_enabled);
2356
Erik Språngefbde372015-04-29 16:21:28 +02002357 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002358 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002359 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2360 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002361
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002362 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002363 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002364 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002365 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002366 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002367 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002368 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002369 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002370 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002371
Erik Språng143cec12015-04-28 10:01:41 +02002372 return fake_call_->GetVideoSendStreams().back();
2373 }
2374
Peter Boström2feafdb2015-09-09 14:32:14 +02002375 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2376 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002377 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002378 std::vector<uint32_t> ssrcs;
2379 std::vector<uint32_t> rtx_ssrcs;
2380 uint32_t num_streams = enabled ? 3 : 1;
2381 for (uint32_t i = 0; i < num_streams; ++i) {
2382 uint32_t ssrc = last_ssrc_ + i;
2383 ssrcs.push_back(ssrc);
2384 if (with_rtx) {
2385 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2386 }
Erik Språng143cec12015-04-28 10:01:41 +02002387 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002388 if (with_rtx) {
2389 return AddSendStream(
2390 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2391 }
2392 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002393 }
2394
perkjfa10b552016-10-02 23:45:26 -07002395 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002396 std::vector<FakeVideoSendStream*> streams =
2397 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002398 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002399 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002400 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002401 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002402 }
2403
perkjfa10b552016-10-02 23:45:26 -07002404 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002405 int stream_max,
2406 int expected_encoder_bitrate) {
2407 VideoSendParameters limited_send_params = send_parameters_;
2408 limited_send_params.max_bandwidth_bps = global_max;
2409 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002410 webrtc::RtpParameters parameters =
2411 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002412 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002413 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002414 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002415 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002416 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002417 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002418 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002419 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002420 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002421 }
2422
Åsa Persson55659812018-06-18 17:51:32 +02002423 // Values from kSimulcastConfigs in simulcast.cc.
2424 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2425 std::vector<webrtc::VideoStream> layers(3);
2426 layers[0].min_bitrate_bps = 30000;
2427 layers[0].target_bitrate_bps = 150000;
2428 layers[0].max_bitrate_bps = 200000;
2429 layers[1].min_bitrate_bps = 150000;
2430 layers[1].target_bitrate_bps = 500000;
2431 layers[1].max_bitrate_bps = 700000;
2432 layers[2].min_bitrate_bps = 600000;
2433 layers[2].target_bitrate_bps = 2500000;
2434 layers[2].max_bitrate_bps = 2500000;
2435 return layers;
2436 }
2437
Niels Möller805a27e2019-01-21 12:21:27 +01002438 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002439 std::unique_ptr<FakeCall> fake_call_;
2440 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002441 cricket::VideoSendParameters send_parameters_;
2442 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002443 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002444};
2445
eladalonf1841382017-06-12 01:16:46 -07002446TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002447 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002448 const std::string kSyncLabel = "AvSyncLabel";
2449
2450 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002451 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002452 EXPECT_TRUE(channel_->AddRecvStream(sp));
2453
Mirko Bonadeif859e552018-05-30 15:31:29 +02002454 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002455 EXPECT_EQ(kSyncLabel,
2456 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2457 << "SyncGroup should be set based on sync_label";
2458}
2459
eladalonf1841382017-06-12 01:16:46 -07002460TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002461 cricket::VideoSendParameters parameters;
2462 parameters.codecs = engine_.codecs();
2463 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002464 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002465 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002466 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002467
2468 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002469 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2470 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002471 FakeVideoSendStream* send_stream = AddSendStream(
2472 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2473
2474 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2475 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2476 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2477
2478 // Receiver side.
2479 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2480 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002481 EXPECT_FALSE(
2482 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002483 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002484 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002485 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002486 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002487 << "RTX should be mapped for the RED payload type";
2488
brandtr14742122017-01-27 04:53:07 -08002489 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002490}
2491
eladalonf1841382017-06-12 01:16:46 -07002492TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002493 // Setup one channel with an associated RTX stream.
2494 cricket::StreamParams params =
2495 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2496 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2497 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002498 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002499
2500 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2501 << "RTX should be mapped for all decoders/payload types.";
2502 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002503 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002504 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002505}
2506
eladalonf1841382017-06-12 01:16:46 -07002507TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002508 // Setup one channel without an associated RTX stream.
2509 cricket::StreamParams params =
2510 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2511 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002512 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002513}
2514
Johannes Kron9190b822018-10-29 11:22:05 +01002515// Test propagation of extmap allow mixed setting.
2516TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2517 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2518}
2519TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2520 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2521}
2522TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2523 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2524}
2525TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2526 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2527}
2528
eladalonf1841382017-06-12 01:16:46 -07002529TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002530 FakeVideoSendStream* send_stream =
2531 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2532 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2533
2534 FakeVideoReceiveStream* recv_stream =
2535 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2536 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002537}
2538
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002539// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002540TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002541 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002542}
isheriff6f8d6862016-05-26 11:24:55 -07002543
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002545 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002546}
2547
2548// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002549TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002550 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002551}
isheriff6f8d6862016-05-26 11:24:55 -07002552
eladalonf1841382017-06-12 01:16:46 -07002553TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002554 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002555}
2556
eladalonf1841382017-06-12 01:16:46 -07002557TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002558 // Enable three redundant extensions.
2559 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002560 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2561 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2562 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2563 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002564}
2565
eladalonf1841382017-06-12 01:16:46 -07002566TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002567 // Enable two redundant extensions.
2568 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002569 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2570 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2571 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002572}
2573
stefanc1aeaf02015-10-15 07:26:07 -07002574// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002575TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002576 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002577}
eladalonf1841382017-06-12 01:16:46 -07002578TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002579 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002580}
2581
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002582// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002583TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002584 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002585}
eladalonf1841382017-06-12 01:16:46 -07002586TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002587 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002588}
2589
eladalonf1841382017-06-12 01:16:46 -07002590TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002591 const int kAbsSendTimeId = 1;
2592 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002593 send_parameters_.extensions.push_back(
2594 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2595 send_parameters_.extensions.push_back(
2596 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002597
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002598 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002599 FakeVideoSendStream* send_stream =
2600 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2601
2602 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002603 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002604
2605 // Setting the same extensions (even if in different order) shouldn't
2606 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002607 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002608 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002609
2610 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2611
2612 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 send_parameters_.extensions.resize(1);
2614 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002615
2616 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2617}
2618
eladalonf1841382017-06-12 01:16:46 -07002619TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002620 const int kTOffsetId = 1;
2621 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002622 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002623 recv_parameters_.extensions.push_back(
2624 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2625 recv_parameters_.extensions.push_back(
2626 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2627 recv_parameters_.extensions.push_back(
2628 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002629
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002630 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002631 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002632 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2633
2634 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002635 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002636
2637 // Setting the same extensions (even if in different order) shouldn't
2638 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002639 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002640 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002641
2642 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2643
2644 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 recv_parameters_.extensions.resize(1);
2646 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002647
2648 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2649}
2650
eladalonf1841382017-06-12 01:16:46 -07002651TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002652 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002653 const int kUnsupportedId = 1;
2654 const int kTOffsetId = 2;
2655
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002656 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002657 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002658 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002659 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002660 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002661 FakeVideoSendStream* send_stream =
2662 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2663
2664 // Only timestamp offset extension is set to send stream,
2665 // unsupported rtp extension is ignored.
2666 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002667 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2668 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002669}
2670
eladalonf1841382017-06-12 01:16:46 -07002671TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002672 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002673 const int kUnsupportedId = 1;
2674 const int kTOffsetId = 2;
2675
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002676 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002677 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002678 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002679 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002680 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002681 FakeVideoReceiveStream* recv_stream =
2682 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2683
2684 // Only timestamp offset extension is set to receive stream,
2685 // unsupported rtp extension is ignored.
2686 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002687 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2688 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002689}
2690
eladalonf1841382017-06-12 01:16:46 -07002691TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002692 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002693 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002694 send_parameters_.extensions.push_back(
2695 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002696 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002697 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2698 }
2699}
2700
eladalonf1841382017-06-12 01:16:46 -07002701TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002702 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002703 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002704 recv_parameters_.extensions.push_back(
2705 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002706 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002707 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2708 }
2709}
2710
eladalonf1841382017-06-12 01:16:46 -07002711TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002712 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002713 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002714 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002715 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002716 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002717 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002718
2719 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002720 send_parameters_.extensions.clear();
2721 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002722 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002723 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2724 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002725}
2726
eladalonf1841382017-06-12 01:16:46 -07002727TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002728 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002729 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002730 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002731 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002732 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002733 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002734
2735 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002736 recv_parameters_.extensions.clear();
2737 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002738 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002739 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2740 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002741}
2742
eladalonf1841382017-06-12 01:16:46 -07002743TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002744 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002745 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002746}
2747
eladalonf1841382017-06-12 01:16:46 -07002748TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002749 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002750 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002751}
2752
eladalonf1841382017-06-12 01:16:46 -07002753TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002754 FakeVideoReceiveStream* stream = AddRecvStream();
2755 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002756}
2757
eladalonf1841382017-06-12 01:16:46 -07002758TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002759 FakeVideoReceiveStream* stream = AddRecvStream();
2760 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2761}
2762
eladalonf1841382017-06-12 01:16:46 -07002763TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002764 FakeVideoReceiveStream* stream = AddRecvStream();
2765 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2766
Peter Boström126c03e2015-05-11 12:48:12 +02002767 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002768 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002769 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002770 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2771 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002772 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002773 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2774
2775 // Verify that REMB is turned on when setting default codecs since the
2776 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002777 parameters.codecs = engine_.codecs();
2778 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002779 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002780 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002781}
2782
eladalonf1841382017-06-12 01:16:46 -07002783TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002784 FakeVideoReceiveStream* stream = AddRecvStream();
2785 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2786
2787 // Verify that transport cc feedback is turned off when send(!) codecs without
2788 // transport cc feedback are set.
2789 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002790 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002791 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2792 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2793 stream = fake_call_->GetVideoReceiveStreams()[0];
2794 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2795
2796 // Verify that transport cc feedback is turned on when setting default codecs
2797 // since the default codecs have transport cc feedback enabled.
2798 parameters.codecs = engine_.codecs();
2799 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2800 stream = fake_call_->GetVideoReceiveStreams()[0];
2801 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2802}
2803
Elad Alonfadb1812019-05-24 13:40:02 +02002804TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2805 TestLossNotificationState(false);
2806}
2807
2808TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2809 RTC_DCHECK(!override_field_trials_);
2810 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2811 "WebRTC-RtcpLossNotification/Enabled/");
2812 SetUp();
2813 TestLossNotificationState(true);
2814}
2815
2816TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2817 RTC_DCHECK(!override_field_trials_);
2818 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2819 "WebRTC-RtcpLossNotification/Enabled/");
2820 SetUp();
2821
2822 AssignDefaultCodec();
2823 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2824
2825 {
2826 cricket::VideoSendParameters parameters;
2827 parameters.codecs = engine_.codecs();
2828 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2829 EXPECT_TRUE(channel_->SetSend(true));
2830 }
2831
2832 // Start with LNTF enabled.
2833 FakeVideoSendStream* send_stream =
2834 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2835 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2836 FakeVideoReceiveStream* recv_stream =
2837 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2838 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2839
2840 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2841 cricket::VideoSendParameters parameters;
2842 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2843 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2844 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2845 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2846 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2847 send_stream = fake_call_->GetVideoSendStreams()[0];
2848 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2849
2850 // Setting the default codecs again, including VP8, turns LNTF back on.
2851 parameters.codecs = engine_.codecs();
2852 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2853 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2854 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2855 send_stream = fake_call_->GetVideoSendStreams()[0];
2856 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2857}
2858
eladalonf1841382017-06-12 01:16:46 -07002859TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002860 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002861 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002862
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002863 cricket::VideoSendParameters parameters;
2864 parameters.codecs = engine_.codecs();
2865 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002866 EXPECT_TRUE(channel_->SetSend(true));
2867
2868 // Send side.
2869 FakeVideoSendStream* send_stream =
2870 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2871 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2872
2873 // Receiver side.
2874 FakeVideoReceiveStream* recv_stream =
2875 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2876 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2877
2878 // Nack history size should match between sender and receiver.
2879 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2880 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002881}
2882
eladalonf1841382017-06-12 01:16:46 -07002883TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002884 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002885 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002886
2887 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2888 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2889
2890 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002891 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002892 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002893 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2894 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002895 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2896 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2897 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002898 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2899
Peter Boström67c9df72015-05-11 14:34:58 +02002900 // Verify that NACK is turned on when setting default codecs since the
2901 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002902 parameters.codecs = engine_.codecs();
2903 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002904 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2905 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2906 send_stream = fake_call_->GetVideoSendStreams()[0];
2907 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002908}
2909
Peter Boströme7ba0862016-03-12 00:02:28 +01002910// This test verifies that new frame sizes reconfigures encoders even though not
2911// (yet) sending. The purpose of this is to permit encoding as quickly as
2912// possible once we start sending. Likely the frames being input are from the
2913// same source that will be sent later, which just means that we're ready
2914// earlier.
eladalonf1841382017-06-12 01:16:46 -07002915TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002916 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002917 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002918 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2919 channel_->SetSend(false);
2920
2921 FakeVideoSendStream* stream = AddSendStream();
2922
perkjfa10b552016-10-02 23:45:26 -07002923 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002924 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002925 EXPECT_EQ(0u, streams[0].width);
2926 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002927
Niels Möller805a27e2019-01-21 12:21:27 +01002928 webrtc::test::FrameForwarder frame_forwarder;
2929 cricket::FakeFrameSource frame_source(1280, 720,
2930 rtc::kNumMicrosecsPerSec / 30);
2931
2932 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2933 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002934
2935 // Frame entered, should be reconfigured to new dimensions.
2936 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002937 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2938 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002939
Niels Möllerff40b142018-04-09 08:49:14 +02002940 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002941}
2942
eladalonf1841382017-06-12 01:16:46 -07002943TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002944 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002945 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002946 cricket::VideoSendParameters parameters;
2947 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002948 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002949 AddSendStream();
2950
Niels Möller805a27e2019-01-21 12:21:27 +01002951 webrtc::test::FrameForwarder frame_forwarder;
2952 cricket::FakeFrameSource frame_source(1280, 720,
2953 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002954 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002955 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002956 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2957 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002958
2959 EXPECT_TRUE(channel_->SetSend(true));
2960
Niels Möller805a27e2019-01-21 12:21:27 +01002961 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002962 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2963 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2964
2965 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2966
2967 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002968 webrtc::VideoEncoderConfig encoder_config =
2969 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002970 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002971 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002972 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002973 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2974 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002975 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2976 << "Non-screenshare shouldn't use min-transmit bitrate.";
2977
Niels Möllerff40b142018-04-09 08:49:14 +02002978 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002979 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002980 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002981 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002982 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2983 &frame_forwarder));
2984 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002985 // Send stream recreated after option change.
2986 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2987 send_stream = fake_call_->GetVideoSendStreams().front();
2988 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002989
2990 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002991 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002992 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002993 encoder_config.content_type);
2994 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2995 encoder_config.min_transmit_bitrate_bps);
2996
perkjfa10b552016-10-02 23:45:26 -07002997 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002998 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2999 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01003000 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02003001 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003002}
3003
eladalonf1841382017-06-12 01:16:46 -07003004TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003005 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02003006 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08003007 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003008 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003009
3010 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003011 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003012 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003013 webrtc::test::FrameForwarder frame_forwarder;
3014 cricket::FakeFrameSource frame_source(1280, 720,
3015 rtc::kNumMicrosecsPerSec / 30);
3016 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003017 EXPECT_TRUE(channel_->SetSend(true));
3018
Niels Möller805a27e2019-01-21 12:21:27 +01003019 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003020 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3021 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3022
perkj26091b12016-09-01 01:17:40 -07003023 webrtc::VideoEncoderConfig encoder_config =
3024 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003025
3026 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003027 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003028 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003029 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003030
3031 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3032 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003033 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003034 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003035 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003036
Niels Möllerff40b142018-04-09 08:49:14 +02003037 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003038}
3039
eladalonf1841382017-06-12 01:16:46 -07003040TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003041 FakeVideoSendStream* stream = AddSendStream();
3042 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3043}
3044
eladalonf1841382017-06-12 01:16:46 -07003045TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003046 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003047 media_config.video.suspend_below_min_bitrate = true;
3048
Sebastian Jansson84848f22018-11-16 10:40:36 +01003049 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003050 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3051 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003052 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003053
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003054 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003055
3056 FakeVideoSendStream* stream = AddSendStream();
3057 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3058
nisse0db023a2016-03-01 04:29:59 -08003059 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003060 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003061 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3062 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003063 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003064
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003065 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003066
nisse0db023a2016-03-01 04:29:59 -08003067 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003068 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3069}
3070
eladalonf1841382017-06-12 01:16:46 -07003071TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003072 FakeVideoSendStream* stream = AddSendStream();
3073 webrtc::VideoCodecVP8 vp8_settings;
3074 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3075 EXPECT_TRUE(vp8_settings.denoisingOn);
3076}
3077
eladalonf1841382017-06-12 01:16:46 -07003078TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003079 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003080 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003081 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003082
Peter Boström2feafdb2015-09-09 14:32:14 +02003083 // Single-stream settings should apply with RTX as well (verifies that we
3084 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3085 // both RTX and regular SSRCs).
3086 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003087
Niels Möller805a27e2019-01-21 12:21:27 +01003088 webrtc::test::FrameForwarder frame_forwarder;
3089 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003090 channel_->SetSend(true);
3091
Niels Möller805a27e2019-01-21 12:21:27 +01003092 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003093
pbos4cba4eb2015-10-26 11:18:18 -07003094 webrtc::VideoCodecVP8 vp8_settings;
3095 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3096 EXPECT_TRUE(vp8_settings.denoisingOn)
3097 << "VP8 denoising should be on by default.";
3098
Niels Möller805a27e2019-01-21 12:21:27 +01003099 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003100
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003101 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3102 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003103 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3104 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003105
Niels Möller805a27e2019-01-21 12:21:27 +01003106 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003107
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003108 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3109 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003110 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3111 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3112
Niels Möllerff40b142018-04-09 08:49:14 +02003113 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003114 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003115 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003116 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003117 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003118
Mirko Bonadeif859e552018-05-30 15:31:29 +02003119 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003120 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3121 // Autmatic resize off when using simulcast.
3122 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3123 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3124
3125 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07003126 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003127 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003128 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003129
Niels Möller805a27e2019-01-21 12:21:27 +01003130 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003131
Mirko Bonadeif859e552018-05-30 15:31:29 +02003132 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003133 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3134 EXPECT_FALSE(vp8_settings.denoisingOn);
3135 // Resizing and frame dropping always off for screen sharing.
3136 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3137 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3138
Niels Möller805a27e2019-01-21 12:21:27 +01003139 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003140
3141 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3142 EXPECT_FALSE(vp8_settings.denoisingOn);
3143 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3144 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3145
Niels Möllerff40b142018-04-09 08:49:14 +02003146 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003147}
3148
deadbeef119760a2016-04-04 11:43:27 -07003149// Test that setting the same options doesn't result in the encoder being
3150// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003151TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003152 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003153 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003154
perkjfa10b552016-10-02 23:45:26 -07003155 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003156 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003157 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003158 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3159 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3160
Niels Möller805a27e2019-01-21 12:21:27 +01003161 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3162 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3163 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003164 // Expect 1 reconfigurations at this point from the initial configuration.
3165 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003166
3167 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003168 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003169 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3170
3171 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003172 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003173 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003174 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3175
Niels Möllerff40b142018-04-09 08:49:14 +02003176 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003177}
3178
eladalonf1841382017-06-12 01:16:46 -07003179class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003180 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003181 Vp9SettingsTest() : Vp9SettingsTest("") {}
3182 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003183 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003184 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003185 }
3186 virtual ~Vp9SettingsTest() {}
3187
3188 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003189 void TearDown() override {
3190 // Remove references to encoder_factory_ since this will be destroyed
3191 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003192 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003193 }
Erik Språng143cec12015-04-28 10:01:41 +02003194};
3195
3196TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003197 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003198 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003199 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003200
Peter Boström2feafdb2015-09-09 14:32:14 +02003201 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003202
Niels Möller805a27e2019-01-21 12:21:27 +01003203 webrtc::test::FrameForwarder frame_forwarder;
3204 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003205 channel_->SetSend(true);
3206
Niels Möller805a27e2019-01-21 12:21:27 +01003207 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003208
pbos4cba4eb2015-10-26 11:18:18 -07003209 webrtc::VideoCodecVP9 vp9_settings;
3210 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003211 EXPECT_TRUE(vp9_settings.denoisingOn)
3212 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003213
Niels Möller805a27e2019-01-21 12:21:27 +01003214 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003215
Erik Språng143cec12015-04-28 10:01:41 +02003216 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3217 EXPECT_FALSE(vp9_settings.denoisingOn);
3218 // Frame dropping always on for real time video.
3219 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3220
Niels Möller805a27e2019-01-21 12:21:27 +01003221 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003222
3223 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3224 EXPECT_TRUE(vp9_settings.denoisingOn);
3225 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3226
3227 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003228 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003229 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003230 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003231
Niels Möller805a27e2019-01-21 12:21:27 +01003232 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003233
3234 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3235 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003236 // Frame dropping always on for screen sharing.
3237 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003238
Niels Möller805a27e2019-01-21 12:21:27 +01003239 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003240
3241 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3242 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003243 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003244
Niels Möllerff40b142018-04-09 08:49:14 +02003245 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003246}
3247
Sergey Silkinf18072e2018-03-14 10:35:35 +01003248TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3249 cricket::VideoSendParameters parameters;
3250 parameters.codecs.push_back(GetEngineCodec("VP9"));
3251 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3252
3253 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3254
3255 FakeVideoSendStream* stream =
3256 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3257
3258 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003259
Niels Möller805a27e2019-01-21 12:21:27 +01003260 webrtc::test::FrameForwarder frame_forwarder;
3261 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003262 channel_->SetSend(true);
3263
Niels Möller805a27e2019-01-21 12:21:27 +01003264 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003265
3266 webrtc::VideoCodecVP9 vp9_settings;
3267 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3268
3269 const size_t kNumSpatialLayers = ssrcs.size();
3270 const size_t kNumTemporalLayers = 3;
3271 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3272 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3273
Niels Möllerff40b142018-04-09 08:49:14 +02003274 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003275}
3276
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003277TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3278 cricket::VideoSendParameters parameters;
3279 parameters.codecs.push_back(GetEngineCodec("VP9"));
3280 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3281
3282 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3283
3284 FakeVideoSendStream* stream =
3285 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3286
3287 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3288
3289 // Despite 3 ssrcs provided, single layer is used.
3290 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3291
3292 webrtc::test::FrameForwarder frame_forwarder;
3293 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3294 channel_->SetSend(true);
3295
3296 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3297
3298 webrtc::VideoCodecVP9 vp9_settings;
3299 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3300
3301 const size_t kNumSpatialLayers = ssrcs.size();
3302 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3303
3304 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3305}
3306
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003307TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3308 cricket::VideoSendParameters send_parameters;
3309 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3310 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3311
3312 const size_t kNumSpatialLayers = 3;
3313 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3314
3315 FakeVideoSendStream* stream =
3316 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3317
3318 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3319 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3320 ASSERT_TRUE(parameters.encodings[0].active);
3321 ASSERT_TRUE(parameters.encodings[1].active);
3322 ASSERT_TRUE(parameters.encodings[2].active);
3323 // Invert value to verify copying.
3324 parameters.encodings[1].active = false;
3325 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3326
3327 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3328
3329 // number_of_streams should be 1 since all spatial layers are sent on the
3330 // same SSRC. But encoding parameters of all layers is supposed to be copied
3331 // and stored in simulcast_layers[].
3332 EXPECT_EQ(1u, encoder_config.number_of_streams);
3333 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3334 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3335 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3336 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3337}
3338
Sergey Silkincf267052019-04-09 11:40:09 +02003339class Vp9SettingsTestWithFieldTrial
3340 : public Vp9SettingsTest,
3341 public ::testing::WithParamInterface<
3342 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003343 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003344 Vp9SettingsTestWithFieldTrial()
3345 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3346 num_spatial_layers_(::testing::get<1>(GetParam())),
3347 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003348 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003349
3350 void VerifySettings(int num_spatial_layers,
3351 int num_temporal_layers,
3352 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003353 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003354 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003355 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3356
3357 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3358
Niels Möller805a27e2019-01-21 12:21:27 +01003359 webrtc::test::FrameForwarder frame_forwarder;
3360 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003361 channel_->SetSend(true);
3362
Niels Möller805a27e2019-01-21 12:21:27 +01003363 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003364
3365 webrtc::VideoCodecVP9 vp9_settings;
3366 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3367 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3368 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003369 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003370
Niels Möllerff40b142018-04-09 08:49:14 +02003371 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003372 }
Sergey Silkincf267052019-04-09 11:40:09 +02003373
3374 const uint8_t num_spatial_layers_;
3375 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003376 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003377};
3378
Sergey Silkincf267052019-04-09 11:40:09 +02003379TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003380 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3381 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003382}
3383
Sergey Silkincf267052019-04-09 11:40:09 +02003384INSTANTIATE_TEST_SUITE_P(
3385 ,
3386 Vp9SettingsTestWithFieldTrial,
3387 ::testing::Values(
3388 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3389 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3390 1,
3391 1,
3392 webrtc::InterLayerPredMode::kOnKeyPic),
3393 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3394 2,
3395 3,
3396 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003397 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003398 1,
3399 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003400 webrtc::InterLayerPredMode::kOnKeyPic),
3401 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003402 1,
3403 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003404 webrtc::InterLayerPredMode::kOnKeyPic),
3405 std::make_tuple(
3406 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3407 1,
3408 1,
3409 webrtc::InterLayerPredMode::kOff),
3410 std::make_tuple(
3411 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3412 1,
3413 1,
3414 webrtc::InterLayerPredMode::kOn),
3415 std::make_tuple(
3416 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3417 1,
3418 1,
3419 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003420
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003421TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3422 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3423 ASSERT_EQ(1u, streams.size());
3424 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3425}
3426
3427TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003428 RTC_DCHECK(!override_field_trials_);
3429 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003430 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3431 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3432 ASSERT_EQ(1u, streams.size());
3433 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3434}
3435
asapersson3c81a1a2017-06-14 05:52:21 -07003436TEST_F(WebRtcVideoChannelTest,
3437 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003438 RTC_DCHECK(!override_field_trials_);
3439 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003440 "WebRTC-Video-BalancedDegradation/Disabled/");
3441 const bool kResolutionScalingEnabled = true;
3442 const bool kFpsScalingEnabled = false;
3443 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3444}
3445
3446TEST_F(WebRtcVideoChannelTest,
3447 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003448 RTC_DCHECK(!override_field_trials_);
3449 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003450 "WebRTC-Video-BalancedDegradation/Enabled/");
3451 const bool kResolutionScalingEnabled = true;
3452 const bool kFpsScalingEnabled = true;
3453 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3454}
3455
eladalonf1841382017-06-12 01:16:46 -07003456TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003457 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003458}
3459
eladalonf1841382017-06-12 01:16:46 -07003460TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003461 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003462}
3463
Niels Möller3de32e62019-01-18 08:42:18 +01003464TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3465 TestCpuAdaptation(false, true);
3466}
3467
eladalonf1841382017-06-12 01:16:46 -07003468TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003469 TestCpuAdaptation(true, true);
3470}
3471
eladalonf1841382017-06-12 01:16:46 -07003472TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003473 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003474 cricket::VideoSendParameters parameters;
3475 parameters.codecs.push_back(codec);
3476
kthelgason2bc68642017-02-07 07:02:22 -08003477 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003478 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003479 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003480 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3481 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003482 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003483 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3484
3485 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003486 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003487
Per766ad3b2016-04-05 15:23:49 +02003488 ASSERT_TRUE(channel_->SetSend(true));
3489 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003490 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003491 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003492
3493 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3494 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003495
Niels Möllerdcc70292019-01-15 16:32:38 +01003496 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3497 // Dont' expect anything on framerate_scaling_enabled, since the default is
3498 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003499
Niels Möllerdcc70292019-01-15 16:32:38 +01003500 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003501 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003502 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003503 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003504 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3505 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003506 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003507
Niels Möllerdcc70292019-01-15 16:32:38 +01003508 // Switch back to the normal capturer. Expect resolution scaling to be
3509 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003510 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3511 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003512 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3513 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003514 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003515
Niels Möllerff40b142018-04-09 08:49:14 +02003516 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003517}
3518
asapersson3c81a1a2017-06-14 05:52:21 -07003519// TODO(asapersson): Remove this test when the balanced field trial is removed.
3520void WebRtcVideoChannelTest::TestDegradationPreference(
3521 bool resolution_scaling_enabled,
3522 bool fps_scaling_enabled) {
3523 cricket::VideoCodec codec = GetEngineCodec("VP8");
3524 cricket::VideoSendParameters parameters;
3525 parameters.codecs.push_back(codec);
3526
3527 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003528 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003529 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003530 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3531 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003532 channel_->OnReadyToSend(true);
3533
3534 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3535
3536 AddSendStream();
3537
Niels Möller805a27e2019-01-21 12:21:27 +01003538 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003539 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003540 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003541
3542 EXPECT_TRUE(channel_->SetSend(true));
3543
3544 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3545 EXPECT_EQ(resolution_scaling_enabled,
3546 send_stream->resolution_scaling_enabled());
3547 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3548
Niels Möllerff40b142018-04-09 08:49:14 +02003549 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003550}
3551
eladalonf1841382017-06-12 01:16:46 -07003552void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3553 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003554 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003555 cricket::VideoSendParameters parameters;
3556 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003557
kthelgason2bc68642017-02-07 07:02:22 -08003558 MediaConfig media_config = GetMediaConfig();
3559 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003560 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003561 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003562 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003563 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3564 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003565 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003566
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003567 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003568
3569 AddSendStream();
3570
Niels Möller805a27e2019-01-21 12:21:27 +01003571 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003572 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003573 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003574 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003575
3576 EXPECT_TRUE(channel_->SetSend(true));
3577
solenberge5269742015-09-08 05:13:22 -07003578 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003579
sprangc5d62e22017-04-02 23:53:04 -07003580 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003581 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003582 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003583 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003584 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3585 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3586 } else {
3587 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3588 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3589 }
Niels Möllerff40b142018-04-09 08:49:14 +02003590 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003591}
3592
eladalonf1841382017-06-12 01:16:46 -07003593TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003594 // Start at last timestamp to verify that wraparounds are estimated correctly.
3595 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3596 static const int64_t kInitialNtpTimeMs = 1247891230;
3597 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003598 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003599
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003600 FakeVideoReceiveStream* stream = AddRecvStream();
3601 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003602 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003603
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003604 webrtc::VideoFrame video_frame =
3605 webrtc::VideoFrame::Builder()
3606 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3607 .set_timestamp_rtp(kInitialTimestamp)
3608 .set_timestamp_us(0)
3609 .set_rotation(webrtc::kVideoRotation_0)
3610 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003611 // Initial NTP time is not available on the first frame, but should still be
3612 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003613 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003614
3615 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003616
3617 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3618 // triggers a constant-overflow warning, hence we're calculating it explicitly
3619 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003620 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003621 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3622 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003623 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003624
3625 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003626
3627 // Verify that NTP time has been correctly deduced.
3628 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003629 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003630 ASSERT_EQ(1u, info.receivers.size());
3631 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003632}
3633
eladalonf1841382017-06-12 01:16:46 -07003634TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003635 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003636 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003637
3638 VideoCodec codec;
3639 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003640 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003641
3642 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003643 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3644 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003645 FakeVideoSendStream* stream = AddSendStream(
3646 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003647 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003648
3649 // Make sure NACK and FEC are enabled on the correct payload types.
3650 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003651 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3652 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003653
3654 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3655 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003656 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003657 // TODO(juberti): Check RTCP, PLI, TMMBR.
3658}
3659
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003660TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3661 cricket::VideoSendParameters parameters;
3662 parameters.codecs.push_back(GetEngineCodec("VP8"));
3663 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3664
3665 FakeVideoSendStream* stream = AddSendStream();
3666 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3667 EXPECT_FALSE(config.rtp.raw_payload);
3668}
3669
3670TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3671 cricket::VideoSendParameters parameters;
3672 parameters.codecs.push_back(GetEngineCodec("VP8"));
3673 parameters.codecs.back().packetization = kPacketizationParamRaw;
3674 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3675
3676 FakeVideoSendStream* stream = AddSendStream();
3677 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3678 EXPECT_TRUE(config.rtp.raw_payload);
3679}
3680
brandtr31bd2242017-05-19 05:47:46 -07003681// The following four tests ensures that FlexFEC is not activated by default
3682// when the field trials are not enabled.
3683// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3684// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003685TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003686 FakeVideoSendStream* stream = AddSendStream();
3687 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3688
brandtr3d200bd2017-01-16 06:59:19 -08003689 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003690 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3691 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003692}
3693
eladalonf1841382017-06-12 01:16:46 -07003694TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003695 FakeVideoSendStream* stream = AddSendStream(
3696 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3697 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3698
brandtr3d200bd2017-01-16 06:59:19 -08003699 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003700 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3701 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3702}
3703
Yves Gerey665174f2018-06-19 15:03:05 +02003704TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003705 AddRecvStream();
3706
3707 const std::vector<FakeFlexfecReceiveStream*>& streams =
3708 fake_call_->GetFlexfecReceiveStreams();
3709 EXPECT_TRUE(streams.empty());
3710}
3711
eladalonf1841382017-06-12 01:16:46 -07003712TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003713 AddRecvStream(
3714 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3715
3716 const std::vector<FakeFlexfecReceiveStream*>& streams =
3717 fake_call_->GetFlexfecReceiveStreams();
3718 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003719}
3720
3721// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3722// tests that use this test fixture into the corresponding "non-field trial"
3723// tests.
eladalonf1841382017-06-12 01:16:46 -07003724class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003725 public:
eladalonf1841382017-06-12 01:16:46 -07003726 WebRtcVideoChannelFlexfecRecvTest()
3727 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003728};
3729
eladalonf1841382017-06-12 01:16:46 -07003730TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003731 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3732 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3733 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3734}
3735
eladalonf1841382017-06-12 01:16:46 -07003736TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003737 AddRecvStream();
3738
3739 const std::vector<FakeFlexfecReceiveStream*>& streams =
3740 fake_call_->GetFlexfecReceiveStreams();
3741 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003742
3743 const std::vector<FakeVideoReceiveStream*>& video_streams =
3744 fake_call_->GetVideoReceiveStreams();
3745 ASSERT_EQ(1U, video_streams.size());
3746 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3747 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3748 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003749}
3750
eladalonf1841382017-06-12 01:16:46 -07003751TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003752 AddRecvStream(
3753 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3754
3755 const std::vector<FakeFlexfecReceiveStream*>& streams =
3756 fake_call_->GetFlexfecReceiveStreams();
3757 ASSERT_EQ(1U, streams.size());
3758 const FakeFlexfecReceiveStream* stream = streams.front();
3759 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3760 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3761 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3762 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3763 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003764
3765 const std::vector<FakeVideoReceiveStream*>& video_streams =
3766 fake_call_->GetVideoReceiveStreams();
3767 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003768 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3769 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003770 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003771 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003772 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003773}
3774
eladalonf1841382017-06-12 01:16:46 -07003775TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003776 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3777 cricket::VideoRecvParameters recv_parameters;
3778 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3779 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3780
3781 AddRecvStream(
3782 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3783 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003784 const std::vector<FakeVideoReceiveStream*>& video_streams =
3785 fake_call_->GetVideoReceiveStreams();
3786 ASSERT_EQ(1U, video_streams.size());
3787 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3788 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3789 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003790
3791 // Enable FlexFEC.
3792 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3793 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3794 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3795 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3796 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3797 << "Enabling FlexFEC should not create VideoReceiveStream.";
3798 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3799 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003800 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3801 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003802}
3803
eladalonf1841382017-06-12 01:16:46 -07003804TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003805 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3806 cricket::VideoRecvParameters recv_parameters;
3807 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3808 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3809 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3810
3811 AddRecvStream(
3812 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3813 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003814 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003815 const std::vector<FakeVideoReceiveStream*>& video_streams =
3816 fake_call_->GetVideoReceiveStreams();
3817 ASSERT_EQ(1U, video_streams.size());
3818 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3819 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3820 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003821
3822 // Disable FlexFEC.
3823 recv_parameters.codecs.clear();
3824 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3825 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3826 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3827 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3828 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3829 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3830 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3831 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003832 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3833 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003834}
3835
brandtr31bd2242017-05-19 05:47:46 -07003836// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3837// tests that use this test fixture into the corresponding "non-field trial"
3838// tests.
eladalonf1841382017-06-12 01:16:46 -07003839class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003840 public:
eladalonf1841382017-06-12 01:16:46 -07003841 WebRtcVideoChannelFlexfecSendRecvTest()
3842 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003843 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3844 }
3845};
3846
Yves Gerey665174f2018-06-19 15:03:05 +02003847TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003848 FakeVideoSendStream* stream = AddSendStream();
3849 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3850
brandtr3d200bd2017-01-16 06:59:19 -08003851 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3852 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3853 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003854}
3855
eladalonf1841382017-06-12 01:16:46 -07003856TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003857 FakeVideoSendStream* stream = AddSendStream(
3858 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3859 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3860
brandtr3d200bd2017-01-16 06:59:19 -08003861 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3862 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3863 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3864 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003865}
3866
eladalonf1841382017-06-12 01:16:46 -07003867TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003868 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003869 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003870 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003871
3872 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003873 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003874
brandtrb5f2c3f2016-10-04 23:28:39 -07003875 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3876 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003877}
3878
eladalonf1841382017-06-12 01:16:46 -07003879TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003880 cricket::VideoSendParameters parameters;
3881 parameters.codecs.push_back(GetEngineCodec("VP8"));
3882 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3883
3884 FakeVideoSendStream* stream = AddSendStream();
3885 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3886
brandtr3d200bd2017-01-16 06:59:19 -08003887 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003888}
3889
eladalonf1841382017-06-12 01:16:46 -07003890TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003891 AddRecvStream(
3892 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003893
3894 cricket::VideoRecvParameters recv_parameters;
3895 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3896 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3897 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003898
3899 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3900 fake_call_->GetFlexfecReceiveStreams();
3901 ASSERT_EQ(1U, flexfec_streams.size());
3902 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3903 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3904 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003905 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003906 flexfec_stream_config.payload_type);
3907 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3908 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3909 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3910 const std::vector<FakeVideoReceiveStream*>& video_streams =
3911 fake_call_->GetVideoReceiveStreams();
3912 const FakeVideoReceiveStream* video_stream = video_streams.front();
3913 const webrtc::VideoReceiveStream::Config& video_stream_config =
3914 video_stream->GetConfig();
3915 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3916 flexfec_stream_config.local_ssrc);
3917 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3918 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3919 flexfec_stream_config.rtcp_send_transport);
3920 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3921 // spec-compliant way.
3922 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3923 flexfec_stream_config.transport_cc);
3924 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3925 EXPECT_EQ(video_stream_config.rtp.extensions,
3926 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003927}
3928
brandtr31bd2242017-05-19 05:47:46 -07003929// We should not send FlexFEC, even if we advertise it, unless the right
3930// field trial is set.
3931// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003932TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003933 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3934 cricket::VideoSendParameters parameters;
3935 parameters.codecs.push_back(GetEngineCodec("VP8"));
3936 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3937 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3938
3939 FakeVideoSendStream* stream = AddSendStream();
3940 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3941
3942 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003943 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003944 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3945}
3946
eladalonf1841382017-06-12 01:16:46 -07003947TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003948 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3949 cricket::VideoSendParameters parameters;
3950 parameters.codecs.push_back(GetEngineCodec("VP8"));
3951 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3952 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3953
3954 FakeVideoSendStream* stream = AddSendStream(
3955 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3956 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3957
3958 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003959 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003960 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3961}
3962
eladalonf1841382017-06-12 01:16:46 -07003963TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003964 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003965 const int kUnusedPayloadType = 127;
3966 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3967
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003968 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003969 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003970 parameters.codecs.push_back(rtx_codec);
3971 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003972 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003973}
3974
eladalonf1841382017-06-12 01:16:46 -07003975TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003976 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003977 const int kUnusedPayloadType1 = 126;
3978 const int kUnusedPayloadType2 = 127;
3979 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3980 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3981 {
3982 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3983 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3984 cricket::VideoSendParameters parameters;
3985 parameters.codecs.push_back(GetEngineCodec("VP8"));
3986 parameters.codecs.push_back(rtx_codec);
3987 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3988 }
3989 {
3990 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3991 kUnusedPayloadType1, kUnusedPayloadType2);
3992 cricket::VideoSendParameters parameters;
3993 parameters.codecs.push_back(GetEngineCodec("VP8"));
3994 parameters.codecs.push_back(rtx_codec);
3995 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3996 << "RTX without matching video codec should be rejected.";
3997 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003998}
3999
eladalonf1841382017-06-12 01:16:46 -07004000TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004001 const int kUnusedPayloadType1 = 126;
4002 const int kUnusedPayloadType2 = 127;
4003 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4004 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4005
4006 // SSRCs for RTX.
4007 cricket::StreamParams params =
4008 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4009 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4010 AddSendStream(params);
4011
4012 // Original payload type for RTX.
4013 cricket::VideoSendParameters parameters;
4014 parameters.codecs.push_back(GetEngineCodec("VP8"));
4015 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4016 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4017 parameters.codecs.push_back(rtx_codec);
4018 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4019 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4020 const webrtc::VideoSendStream::Config& config_before =
4021 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4022 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4023 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4024 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4025
4026 // Change payload type for RTX.
4027 parameters.codecs[1].id = kUnusedPayloadType2;
4028 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4029 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4030 const webrtc::VideoSendStream::Config& config_after =
4031 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4032 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4033 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4034 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4035}
4036
eladalonf1841382017-06-12 01:16:46 -07004037TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004038 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004039 parameters.codecs.push_back(GetEngineCodec("VP8"));
4040 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004041 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004042
4043 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004044 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004045
magjed509e4fe2016-11-18 01:34:11 -08004046 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004047
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004048 parameters.codecs.pop_back();
4049 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004050 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004051 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004052 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004053 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004054 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4055}
4056
eladalonf1841382017-06-12 01:16:46 -07004057TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004058 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004059 cricket::VideoSendParameters parameters;
4060 parameters.codecs.push_back(GetEngineCodec("VP8"));
4061 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4062 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4063
4064 FakeVideoSendStream* stream = AddSendStream(
4065 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4066 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4067
brandtr3d200bd2017-01-16 06:59:19 -08004068 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4069 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004070 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4071 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4072
4073 parameters.codecs.pop_back();
4074 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4075 stream = fake_call_->GetVideoSendStreams()[0];
4076 ASSERT_TRUE(stream != nullptr);
4077 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004078 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004079 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004080}
4081
eladalonf1841382017-06-12 01:16:46 -07004082TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004083 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004084 cricket::VideoCodec codec(100, "VP8");
4085 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4086 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004087
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004088 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004089 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004090
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004091 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004092 webrtc::test::FrameForwarder frame_forwarder;
4093 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004094
4095 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004096 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004097
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004098 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004099 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4100 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004101 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004102 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004103 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004104 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004105}
4106
eladalonf1841382017-06-12 01:16:46 -07004107TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004108 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4109 200000);
4110}
4111
eladalonf1841382017-06-12 01:16:46 -07004112TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004113 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4114 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4115 ASSERT_EQ(1u, streams.size());
4116 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4117}
4118
eladalonf1841382017-06-12 01:16:46 -07004119TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004120 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004121 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004122}
4123
eladalonf1841382017-06-12 01:16:46 -07004124TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004125 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004126}
4127
eladalonf1841382017-06-12 01:16:46 -07004128TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004129 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4130 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4131 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004132}
4133
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004134// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4135// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004136TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004137 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4138 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4139 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4140 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004141 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004142 ExpectSetBitrateParameters(100000, 200000, 400000);
4143 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4144 // Since the codec isn't changing, start_bitrate_bps should be -1.
4145 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004146
4147 // Decrease max_bandwidth_bps.
4148 send_parameters_.max_bandwidth_bps = 350000;
4149 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004150
4151 // Now try again with the values flipped around.
4152 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4153 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004154 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004155 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004156
4157 // If we change the codec max, max_bandwidth_bps should still apply.
4158 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004159 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004160 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004161}
4162
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004163// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4164// are present in the same send parameters, the settings are combined correctly.
4165TEST_F(WebRtcVideoChannelTest,
4166 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4167 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4168 // Transport.
4169 webrtc::MediaTransportSettings settings;
4170 settings.is_caller = true;
4171 webrtc::FakeMediaTransport fake_media_transport(settings);
4172 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4173 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004174 channel_->SetInterface(network_interface.get(),
4175 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004176
4177 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4178 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4179 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4180 send_parameters_.max_bandwidth_bps = 400000;
4181 {
4182 // We expect max_bandwidth_bps to take priority, if set.
4183 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4184 ASSERT_EQ(1u,
4185 fake_media_transport.target_rate_constraints_in_order().size());
4186 const webrtc::MediaTransportTargetRateConstraints& constraint =
4187 fake_media_transport.target_rate_constraints_in_order()[0];
4188 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4189 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4190 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4191 }
4192
4193 {
4194 // Decrease max_bandwidth_bps.
4195 send_parameters_.max_bandwidth_bps = 350000;
4196 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4197 ASSERT_EQ(2u,
4198 fake_media_transport.target_rate_constraints_in_order().size());
4199 const webrtc::MediaTransportTargetRateConstraints& constraint =
4200 fake_media_transport.target_rate_constraints_in_order()[1];
4201
4202 // Since the codec isn't changing, start_bitrate_bps should be 0.
4203 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4204 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4205 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4206 }
4207
4208 {
4209 // Now try again with the values flipped around.
4210 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4211 send_parameters_.max_bandwidth_bps = 300000;
4212 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4213 ASSERT_EQ(3u,
4214 fake_media_transport.target_rate_constraints_in_order().size());
4215 const webrtc::MediaTransportTargetRateConstraints& constraint =
4216 fake_media_transport.target_rate_constraints_in_order()[2];
4217
4218 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4219 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4220 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4221 }
4222
4223 {
4224 // Now try again with the values flipped around.
4225 // If we change the codec max, max_bandwidth_bps should still apply.
4226 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4227 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4228 ASSERT_EQ(4u,
4229 fake_media_transport.target_rate_constraints_in_order().size());
4230 const webrtc::MediaTransportTargetRateConstraints& constraint =
4231 fake_media_transport.target_rate_constraints_in_order()[3];
4232
4233 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4234 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4235 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4236 }
4237}
4238
Yves Gerey665174f2018-06-19 15:03:05 +02004239TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004240 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4241 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004242 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004243 // Setting max bitrate should keep previous min bitrate.
4244 // Setting max bitrate should not reset start bitrate.
4245 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004246 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004247}
4248
eladalonf1841382017-06-12 01:16:46 -07004249TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004250 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004251 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004252 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004253 // -1 means to disable max bitrate (set infinite).
4254 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004255 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004256 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004257}
4258
eladalonf1841382017-06-12 01:16:46 -07004259TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004260 send_parameters_.max_bandwidth_bps = 99999;
4261 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004262 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004263 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004264 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4265 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4266 stream->GetVideoStreams()[0].max_bitrate_bps);
4267
4268 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004269 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004270 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4271 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004272 stream->GetVideoStreams()[0].max_bitrate_bps);
4273}
4274
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004275// Tests that when the codec specific max bitrate and VideoSendParameters
4276// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4277// appropriately.
4278TEST_F(WebRtcVideoChannelTest,
4279 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4280 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4281 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4282 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4283 send_parameters_.max_bandwidth_bps = -1;
4284 AddSendStream();
4285 ExpectSetMaxBitrate(300000);
4286 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4287
4288 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4289 ASSERT_EQ(1u, video_send_streams.size());
4290 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4291 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4292 // First the max bitrate is set based upon the codec param.
4293 EXPECT_EQ(300000,
4294 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4295
4296 // The VideoSendParameters max bitrate overrides the codec's.
4297 send_parameters_.max_bandwidth_bps = 500000;
4298 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4299 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4300 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4301 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4302}
4303
4304// Tests that when the codec specific max bitrate and RtpParameters
4305// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4306// appropriately.
4307TEST_F(WebRtcVideoChannelTest,
4308 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4309 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4310 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4311 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4312 send_parameters_.max_bandwidth_bps = -1;
4313 AddSendStream();
4314 ExpectSetMaxBitrate(300000);
4315 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4316
4317 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4318 ASSERT_EQ(1u, video_send_streams.size());
4319 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4320 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4321 // First the max bitrate is set based upon the codec param.
4322 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4323
4324 // The RtpParameter max bitrate overrides the codec's.
4325 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4326 ASSERT_EQ(1u, parameters.encodings.size());
4327 parameters.encodings[0].max_bitrate_bps = 500000;
4328 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4329 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4330 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4331 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4332}
4333
Åsa Persson55659812018-06-18 17:51:32 +02004334TEST_F(WebRtcVideoChannelTest,
4335 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4336 send_parameters_.max_bandwidth_bps = 99999;
4337 FakeVideoSendStream* stream = AddSendStream();
4338 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4339 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4340 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4341 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4342 stream->GetVideoStreams()[0].max_bitrate_bps);
4343
4344 // Get and set the rtp encoding parameters.
4345 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4346 EXPECT_EQ(1u, parameters.encodings.size());
4347
4348 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4349 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4350 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4351 stream->GetVideoStreams()[0].max_bitrate_bps);
4352
4353 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4354 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4355 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4356 stream->GetVideoStreams()[0].max_bitrate_bps);
4357}
4358
eladalonf1841382017-06-12 01:16:46 -07004359TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004360 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004361 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004362 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004363 channel_->SetSend(true);
4364
4365 FakeVideoSendStream* stream = AddSendStream();
4366
Niels Möller805a27e2019-01-21 12:21:27 +01004367 webrtc::test::FrameForwarder frame_forwarder;
4368 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004369
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004370 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4371 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4372 EXPECT_GT(initial_max_bitrate_bps, 0);
4373
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004374 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4375 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004376 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004377 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004378 streams = stream->GetVideoStreams();
4379 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004380 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004381}
4382
eladalonf1841382017-06-12 01:16:46 -07004383TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004384 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004385 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004386 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004387 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004388 channel_->SetSend(true);
4389
4390 FakeVideoSendStream* stream = AddSendStream(
4391 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4392
4393 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004394 webrtc::test::FrameForwarder frame_forwarder;
4395 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4396 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004397
4398 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4399 ASSERT_GT(streams.size(), 1u)
4400 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004401 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004402 EXPECT_GT(initial_max_bitrate_bps, 0);
4403
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004404 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4405 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004406 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004407 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004408 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004409 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004410 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4411
Niels Möllerff40b142018-04-09 08:49:14 +02004412 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004413}
4414
eladalonf1841382017-06-12 01:16:46 -07004415TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004416 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004417 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004418 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004419 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4420 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004421 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004422 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004423
4424 VideoCodec codec;
4425 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4426 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4427}
4428
eladalonf1841382017-06-12 01:16:46 -07004429TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004430 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004431 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004432 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004433 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004434 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004435 parameters.codecs[0].id = kIncorrectPayloads[i];
4436 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004437 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004438 }
4439}
4440
eladalonf1841382017-06-12 01:16:46 -07004441TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004442 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004443 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004444 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004445 parameters.codecs[0].id = payload_type;
4446 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004447 << "Payload type '" << payload_type << "' rejected.";
4448 }
4449}
4450
deadbeef67cf2c12016-04-13 10:07:16 -07004451// Test that setting the a different set of codecs but with an identical front
4452// codec doesn't result in the stream being recreated.
4453// This may happen when a subsequent negotiation includes fewer codecs, as a
4454// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004455TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004456 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4457 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004458 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4459 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004460 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4461
4462 AddSendStream();
4463 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4464
4465 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004466 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004467 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4468 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4469}
4470
eladalonf1841382017-06-12 01:16:46 -07004471TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004472 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004473 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004474 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004475}
4476
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004477// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004478TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004479 const int kUnusedPayloadType1 = 126;
4480 const int kUnusedPayloadType2 = 127;
4481 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4482 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4483
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004484 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004485 parameters.codecs.push_back(GetEngineCodec("VP8"));
4486 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004487 parameters.codecs.push_back(rtx_codec);
4488 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004489 << "RTX codec without associated payload should be rejected.";
4490
magjed509e4fe2016-11-18 01:34:11 -08004491 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004492 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004493 << "RTX codec with invalid associated payload type should be rejected.";
4494
magjed509e4fe2016-11-18 01:34:11 -08004495 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004496 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004497
magjed509e4fe2016-11-18 01:34:11 -08004498 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004499 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004500 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004501
Yves Gerey665174f2018-06-19 15:03:05 +02004502 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4503 << "RTX codec with another RTX as associated payload type should be "
4504 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004505}
4506
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004507TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4508 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4509 vp8_codec.packetization = kPacketizationParamRaw;
4510
4511 cricket::VideoRecvParameters parameters;
4512 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4513 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4514
4515 const cricket::StreamParams params =
4516 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4517 AddRecvStream(params);
4518 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4519
4520 const webrtc::VideoReceiveStream::Config& config =
4521 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4522 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4523 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4524}
4525
4526TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4527 cricket::VideoRecvParameters parameters;
4528 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4529 parameters.codecs.back().packetization = kPacketizationParamRaw;
4530 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4531
4532 const cricket::StreamParams params =
4533 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4534 AddRecvStream(params);
4535 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4536 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4537
4538 parameters.codecs.back().packetization.reset();
4539 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4540 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4541}
4542
eladalonf1841382017-06-12 01:16:46 -07004543TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004544 const int kUnusedPayloadType1 = 126;
4545 const int kUnusedPayloadType2 = 127;
4546 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4547 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4548
4549 // SSRCs for RTX.
4550 cricket::StreamParams params =
4551 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4552 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4553 AddRecvStream(params);
4554
4555 // Original payload type for RTX.
4556 cricket::VideoRecvParameters parameters;
4557 parameters.codecs.push_back(GetEngineCodec("VP8"));
4558 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4559 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4560 parameters.codecs.push_back(rtx_codec);
4561 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4562 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4563 const webrtc::VideoReceiveStream::Config& config_before =
4564 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004565 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4566 const int* payload_type_before = FindKeyByValue(
4567 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4568 ASSERT_NE(payload_type_before, nullptr);
4569 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004570 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4571
4572 // Change payload type for RTX.
4573 parameters.codecs[1].id = kUnusedPayloadType2;
4574 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4575 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4576 const webrtc::VideoReceiveStream::Config& config_after =
4577 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004578 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4579 const int* payload_type_after = FindKeyByValue(
4580 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4581 ASSERT_NE(payload_type_after, nullptr);
4582 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004583 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4584}
4585
eladalonf1841382017-06-12 01:16:46 -07004586TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004587 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004588 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004589 parameters.codecs[0].id = 99;
4590 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004591}
4592
eladalonf1841382017-06-12 01:16:46 -07004593TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004594 cricket::VideoRecvParameters parameters;
4595 parameters.codecs = engine_.codecs();
4596 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004597
4598 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004599 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004600 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004601 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004602}
4603
eladalonf1841382017-06-12 01:16:46 -07004604TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004605 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004606 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004607 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004608 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004609}
4610
eladalonf1841382017-06-12 01:16:46 -07004611TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004612 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004613 parameters.codecs.push_back(GetEngineCodec("VP8"));
4614 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004615 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004616}
4617
eladalonf1841382017-06-12 01:16:46 -07004618TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004619 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004620 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4621 send_parameters.codecs.push_back(GetEngineCodec("red"));
4622 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004623 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004624
4625 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004626
magjed509e4fe2016-11-18 01:34:11 -08004627 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004628 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004629
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004630 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004631 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004632 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004633 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004634 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004635 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004636 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4637}
4638
eladalonf1841382017-06-12 01:16:46 -07004639TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004640 AddRecvStream(
4641 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004642 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004643 fake_call_->GetFlexfecReceiveStreams();
4644
4645 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004646 const FakeFlexfecReceiveStream* stream = streams.front();
4647 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4648 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4649 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4650 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004651
4652 cricket::VideoRecvParameters recv_parameters;
4653 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4654 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4655 EXPECT_TRUE(streams.empty())
4656 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004657}
4658
eladalonf1841382017-06-12 01:16:46 -07004659TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004660 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004661 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004662 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004663
4664 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004665 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4666 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4667 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004668 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4669 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004670 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004671 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004672 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004673 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004674
4675 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004676 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4677 send_parameters.codecs.push_back(GetEngineCodec("red"));
4678 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004679 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4680 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004681 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004682 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004683 << "ULPFEC should be enabled on the receive stream.";
4684}
4685
eladalonf1841382017-06-12 01:16:46 -07004686TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004687 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004688 AddRecvStream(
4689 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004690 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004691 fake_call_->GetFlexfecReceiveStreams();
4692
4693 cricket::VideoRecvParameters recv_parameters;
4694 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4695 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4696 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4697 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004698 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004699 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004700 stream_with_recv_params->GetConfig().payload_type);
4701 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004702 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004703 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004704 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004705 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004706
4707 cricket::VideoSendParameters send_parameters;
4708 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4709 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4710 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4711 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004712 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004713 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004714 stream_with_send_params->GetConfig().payload_type);
4715 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004716 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004717 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004718 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004719 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004720}
4721
eladalonf1841382017-06-12 01:16:46 -07004722TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004723 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004724 parameters.codecs.push_back(GetEngineCodec("VP8"));
4725 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004726 parameters.codecs[1].id = parameters.codecs[0].id;
4727 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004728}
4729
eladalonf1841382017-06-12 01:16:46 -07004730TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004731 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004732 cricket::VideoRecvParameters parameters;
4733 parameters.codecs.push_back(GetEngineCodec("VP8"));
4734 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4735 parameters.codecs[1].id = parameters.codecs[0].id;
4736 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4737}
4738
eladalonf1841382017-06-12 01:16:46 -07004739TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004740 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004741 parameters.codecs.push_back(GetEngineCodec("VP8"));
4742 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004743 parameters.codecs[1].id = parameters.codecs[0].id;
4744 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004745}
4746
eladalonf1841382017-06-12 01:16:46 -07004747TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004748 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004749 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004750 parameters.codecs.push_back(GetEngineCodec("VP8"));
4751 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004752 parameters.codecs[1].id += 1;
4753 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004754}
4755
deadbeef67cf2c12016-04-13 10:07:16 -07004756// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004757// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004758TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004759 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004760 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004761 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4762 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004763 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004764
4765 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4766 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4767
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004768 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004769 parameters2.codecs.push_back(GetEngineCodec("red"));
4770 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004771 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004772 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4773}
4774
eladalonf1841382017-06-12 01:16:46 -07004775TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004776 EXPECT_FALSE(AddSendStream()->IsSending());
4777}
4778
eladalonf1841382017-06-12 01:16:46 -07004779TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004780 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004781}
4782
eladalonf1841382017-06-12 01:16:46 -07004783TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004784 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004785 EXPECT_FALSE(stream->IsSending());
4786
4787 // false->true
4788 EXPECT_TRUE(channel_->SetSend(true));
4789 EXPECT_TRUE(stream->IsSending());
4790 // true->true
4791 EXPECT_TRUE(channel_->SetSend(true));
4792 EXPECT_TRUE(stream->IsSending());
4793 // true->false
4794 EXPECT_TRUE(channel_->SetSend(false));
4795 EXPECT_FALSE(stream->IsSending());
4796 // false->false
4797 EXPECT_TRUE(channel_->SetSend(false));
4798 EXPECT_FALSE(stream->IsSending());
4799
4800 EXPECT_TRUE(channel_->SetSend(true));
4801 FakeVideoSendStream* new_stream = AddSendStream();
4802 EXPECT_TRUE(new_stream->IsSending())
4803 << "Send stream created after SetSend(true) not sending initially.";
4804}
4805
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004806// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004807TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004808 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004809 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004810 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004811 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004812 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004813
Sebastian Jansson84848f22018-11-16 10:40:36 +01004814 channel.reset(
4815 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004816 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4817 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004818 channel->SetInterface(network_interface.get(),
4819 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004820 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004821 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004822
Tim Haloun648d28a2018-10-18 16:52:22 -07004823 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4824 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004825 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004826 channel.reset(
4827 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004828 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4829 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004830 channel->SetInterface(network_interface.get(),
4831 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004832 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4833
4834 // Create a send stream to configure
4835 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4836 parameters = channel->GetRtpSendParameters(kSsrc);
4837 ASSERT_FALSE(parameters.encodings.empty());
4838
4839 // Various priorities map to various dscp values.
4840 parameters.encodings[0].network_priority = 4.0;
4841 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004842 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004843 parameters.encodings[0].network_priority = 0.5;
4844 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4845 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4846
4847 // A bad priority does not change the dscp value.
4848 parameters.encodings[0].network_priority = 0.0;
4849 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4850 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004851
Tim Haloun6ca98362018-09-17 17:06:08 -07004852 // Packets should also self-identify their dscp in PacketOptions.
4853 const uint8_t kData[10] = {0};
4854 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4855 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004856 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004857
nisse51542be2016-02-12 02:27:06 -08004858 // Verify that setting the option to false resets the
4859 // DiffServCodePoint.
4860 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004861 channel.reset(
4862 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004863 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4864 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004865 channel->SetInterface(network_interface.get(),
4866 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004867 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004868}
4869
deadbeef13871492015-12-09 12:37:51 -08004870// This test verifies that the RTCP reduced size mode is properly applied to
4871// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004872TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004873 // Create stream, expecting that default mode is "compound".
4874 FakeVideoSendStream* stream1 = AddSendStream();
4875 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004876 webrtc::RtpParameters rtp_parameters =
4877 channel_->GetRtpSendParameters(last_ssrc_);
4878 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004879
4880 // Now enable reduced size mode.
4881 send_parameters_.rtcp.reduced_size = true;
4882 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4883 stream1 = fake_call_->GetVideoSendStreams()[0];
4884 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004885 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4886 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004887
4888 // Create a new stream and ensure it picks up the reduced size mode.
4889 FakeVideoSendStream* stream2 = AddSendStream();
4890 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4891}
4892
4893// This test verifies that the RTCP reduced size mode is properly applied to
4894// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004895TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004896 // Create stream, expecting that default mode is "compound".
4897 FakeVideoReceiveStream* stream1 = AddRecvStream();
4898 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4899
4900 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004901 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4902 // the reduced_size flag should come from that.
4903 send_parameters_.rtcp.reduced_size = true;
4904 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004905 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4906 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4907
4908 // Create a new stream and ensure it picks up the reduced size mode.
4909 FakeVideoReceiveStream* stream2 = AddRecvStream();
4910 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4911}
4912
eladalonf1841382017-06-12 01:16:46 -07004913TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004914 EXPECT_EQ(webrtc::kNetworkUp,
4915 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4916 EXPECT_EQ(webrtc::kNetworkUp,
4917 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004918
4919 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004920 EXPECT_EQ(webrtc::kNetworkDown,
4921 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4922 EXPECT_EQ(webrtc::kNetworkUp,
4923 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004924
4925 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004926 EXPECT_EQ(webrtc::kNetworkUp,
4927 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4928 EXPECT_EQ(webrtc::kNetworkUp,
4929 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004930}
4931
eladalonf1841382017-06-12 01:16:46 -07004932TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004933 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004934 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004935 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004936
4937 AddSendStream();
4938
4939 cricket::VideoMediaInfo info;
4940 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004941 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004942}
4943
eladalonf1841382017-06-12 01:16:46 -07004944TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004945 FakeVideoSendStream* stream = AddSendStream();
4946 webrtc::VideoSendStream::Stats stats;
4947 stats.encoder_implementation_name = "encoder_implementation_name";
4948 stream->SetStats(stats);
4949
4950 cricket::VideoMediaInfo info;
4951 ASSERT_TRUE(channel_->GetStats(&info));
4952 EXPECT_EQ(stats.encoder_implementation_name,
4953 info.senders[0].encoder_implementation_name);
4954}
4955
eladalonf1841382017-06-12 01:16:46 -07004956TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004957 FakeVideoSendStream* stream = AddSendStream();
4958 webrtc::VideoSendStream::Stats stats;
4959 stats.avg_encode_time_ms = 13;
4960 stats.encode_usage_percent = 42;
4961 stream->SetStats(stats);
4962
4963 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004964 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004965 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4966 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4967}
4968
eladalonf1841382017-06-12 01:16:46 -07004969TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004970 FakeVideoSendStream* stream = AddSendStream();
4971 webrtc::VideoSendStream::Stats stats;
4972 stats.frames_encoded = 13;
4973 stream->SetStats(stats);
4974
4975 cricket::VideoMediaInfo info;
4976 ASSERT_TRUE(channel_->GetStats(&info));
4977 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4978}
4979
Rasmus Brandt2efae772019-06-27 14:29:34 +02004980TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
4981 FakeVideoSendStream* stream = AddSendStream();
4982 webrtc::VideoSendStream::Stats stats;
4983 stats.substreams[123].frame_counts.key_frames = 10;
4984 stats.substreams[456].frame_counts.key_frames = 87;
4985 stream->SetStats(stats);
4986
4987 cricket::VideoMediaInfo info;
4988 ASSERT_TRUE(channel_->GetStats(&info));
4989 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
4990 // for each simulcast stream, instead of accumulating all keyframes encoded
4991 // over all simulcast streams in the same outbound-rtp stats object.
4992 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
4993}
4994
eladalonf1841382017-06-12 01:16:46 -07004995TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004996 FakeVideoSendStream* stream = AddSendStream();
4997 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004998 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004999 stream->SetStats(stats);
5000
5001 cricket::VideoMediaInfo info;
5002 ASSERT_TRUE(channel_->GetStats(&info));
5003 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5004}
5005
eladalonf1841382017-06-12 01:16:46 -07005006TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005007 FakeVideoSendStream* stream = AddSendStream();
5008 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005009 stats.substreams[17].width = 123;
5010 stats.substreams[17].height = 40;
5011 stats.substreams[42].width = 80;
5012 stats.substreams[42].height = 31;
5013 stats.substreams[11].width = 20;
5014 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005015 stream->SetStats(stats);
5016
5017 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005018 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005019 ASSERT_EQ(1u, info.senders.size());
5020 EXPECT_EQ(123, info.senders[0].send_frame_width);
5021 EXPECT_EQ(90, info.senders[0].send_frame_height);
5022}
5023
eladalonf1841382017-06-12 01:16:46 -07005024TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005025 FakeVideoSendStream* stream = AddSendStream();
5026 webrtc::VideoSendStream::Stats stats;
5027 stats.number_of_cpu_adapt_changes = 2;
5028 stats.cpu_limited_resolution = true;
5029 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005030
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005031 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005032 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005033 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005034 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005035 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005036}
5037
eladalonf1841382017-06-12 01:16:46 -07005038TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005039 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005040 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005041 stats.number_of_cpu_adapt_changes = 2;
5042 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005043 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005044 stream->SetStats(stats);
5045
5046 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005047 EXPECT_TRUE(channel_->GetStats(&info));
5048 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005049 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5050 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005051 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005052 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005053}
5054
eladalonf1841382017-06-12 01:16:46 -07005055TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005056 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5057 FakeVideoSendStream* stream = AddSendStream();
5058 webrtc::VideoSendStream::Stats stats;
5059 stats.bw_limited_resolution = true;
5060 stream->SetStats(stats);
5061
5062 cricket::VideoMediaInfo info;
5063 EXPECT_TRUE(channel_->GetStats(&info));
5064 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005065 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005066 info.senders[0].adapt_reason);
5067}
5068
Yves Gerey665174f2018-06-19 15:03:05 +02005069TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005070 FakeVideoSendStream* stream = AddSendStream();
5071 webrtc::VideoSendStream::Stats stats;
5072 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5073 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5074 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5075
5076 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5077 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5078 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5079
5080 stream->SetStats(stats);
5081
5082 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005083 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005084 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5085 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5086 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5087}
5088
eladalonf1841382017-06-12 01:16:46 -07005089TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005090 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5091 FakeVideoReceiveStream* stream = AddRecvStream();
5092 webrtc::VideoReceiveStream::Stats stats;
5093 stats.rtcp_packet_type_counts.fir_packets = 2;
5094 stats.rtcp_packet_type_counts.nack_packets = 3;
5095 stats.rtcp_packet_type_counts.pli_packets = 4;
5096 stream->SetStats(stats);
5097
5098 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005099 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005100 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005101 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005102 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005103 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005104 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005105 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005106}
5107
eladalonf1841382017-06-12 01:16:46 -07005108TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005109 FakeVideoReceiveStream* stream = AddRecvStream();
5110 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005111 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005112 stats.decode_ms = 2;
5113 stats.max_decode_ms = 3;
5114 stats.current_delay_ms = 4;
5115 stats.target_delay_ms = 5;
5116 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005117 stats.jitter_buffer_delay_seconds = 60;
5118 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005119 stats.min_playout_delay_ms = 7;
5120 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005121 stats.width = 9;
5122 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005123 stats.frame_counts.key_frames = 11;
5124 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005125 stats.frames_rendered = 13;
5126 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005127 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005128 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005129 stream->SetStats(stats);
5130
5131 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005132 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005133 EXPECT_EQ(stats.decoder_implementation_name,
5134 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005135 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5136 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5137 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5138 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5139 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005140 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5141 info.receivers[0].jitter_buffer_delay_seconds);
5142 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5143 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005144 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5145 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005146 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5147 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005148 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5149 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005150 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005151 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005152 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005153 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5154 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005155 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005156 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005157}
5158
eladalonf1841382017-06-12 01:16:46 -07005159TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005160 FakeVideoReceiveStream* stream = AddRecvStream();
5161 webrtc::VideoReceiveStream::Stats stats;
5162 stats.rtp_stats.transmitted.payload_bytes = 2;
5163 stats.rtp_stats.transmitted.header_bytes = 3;
5164 stats.rtp_stats.transmitted.padding_bytes = 4;
5165 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005166 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005167 stats.rtcp_stats.fraction_lost = 7;
5168 stream->SetStats(stats);
5169
5170 cricket::VideoMediaInfo info;
5171 ASSERT_TRUE(channel_->GetStats(&info));
5172 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
5173 stats.rtp_stats.transmitted.header_bytes +
5174 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005175 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005176 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005177 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005178 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005179}
5180
eladalonf1841382017-06-12 01:16:46 -07005181TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005182 AddSendStream();
5183 AddSendStream();
5184 webrtc::Call::Stats stats;
5185 stats.rtt_ms = 123;
5186 fake_call_->SetStats(stats);
5187
5188 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005189 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005190 ASSERT_EQ(2u, info.senders.size());
5191 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5192 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5193}
5194
eladalonf1841382017-06-12 01:16:46 -07005195TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005196 FakeVideoSendStream* stream = AddSendStream();
5197 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005198 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005199 stats.media_bitrate_bps = 123;
5200 stats.substreams[17].total_bitrate_bps = 1;
5201 stats.substreams[17].retransmit_bitrate_bps = 2;
5202 stats.substreams[42].total_bitrate_bps = 3;
5203 stats.substreams[42].retransmit_bitrate_bps = 4;
5204 stream->SetStats(stats);
5205
5206 FakeVideoSendStream* stream2 = AddSendStream();
5207 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005208 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005209 stats2.media_bitrate_bps = 321;
5210 stats2.substreams[13].total_bitrate_bps = 5;
5211 stats2.substreams[13].retransmit_bitrate_bps = 6;
5212 stats2.substreams[21].total_bitrate_bps = 7;
5213 stats2.substreams[21].retransmit_bitrate_bps = 8;
5214 stream2->SetStats(stats2);
5215
5216 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005217 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005218 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005219 BandwidthEstimationInfo bwe_info;
5220 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005221 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5222 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5223 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5224 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005225 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005226 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005227 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005228 bwe_info.actual_enc_bitrate);
5229 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005230 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005231 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005232 << "Bandwidth stats should take all streams into account.";
5233}
5234
eladalonf1841382017-06-12 01:16:46 -07005235TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005236 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005237
Peter Boström0c4e06b2015-10-07 12:23:21 +02005238 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5239 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005240
5241 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5242 const size_t kDataLength = 12;
5243 uint8_t data[kDataLength];
5244 memset(data, 0, sizeof(data));
5245 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005246 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005247 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005248
5249 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5250 << "No default receive stream created.";
5251 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005252 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005253 << "Default receive stream should not have configured RTX";
5254
5255 EXPECT_TRUE(channel_->AddRecvStream(
5256 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5257 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005258 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005259 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005260 EXPECT_FALSE(
5261 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005262 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005263 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005264 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005265 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005266 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005267 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005268}
5269
eladalonf1841382017-06-12 01:16:46 -07005270TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005271 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005272
Peter Boström0c4e06b2015-10-07 12:23:21 +02005273 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5274 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005275
5276 StreamParams sp =
5277 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5278 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5279
5280 EXPECT_FALSE(channel_->AddSendStream(sp));
5281 EXPECT_FALSE(channel_->AddRecvStream(sp));
5282}
5283
eladalonf1841382017-06-12 01:16:46 -07005284TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005285 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005286
Peter Boström0c4e06b2015-10-07 12:23:21 +02005287 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5288 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005289
5290 StreamParams sp =
5291 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5292
5293 EXPECT_TRUE(channel_->AddSendStream(sp));
5294 EXPECT_TRUE(channel_->AddRecvStream(sp));
5295
5296 // The RTX SSRC is already used in previous streams, using it should fail.
5297 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5298 EXPECT_FALSE(channel_->AddSendStream(sp));
5299 EXPECT_FALSE(channel_->AddRecvStream(sp));
5300
5301 // After removing the original stream this should be fine to add (makes sure
5302 // that RTX ssrcs are not forever taken).
5303 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5304 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5305 EXPECT_TRUE(channel_->AddSendStream(sp));
5306 EXPECT_TRUE(channel_->AddRecvStream(sp));
5307}
5308
eladalonf1841382017-06-12 01:16:46 -07005309TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005310 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005311 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5312 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005313 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005314
Peter Boströmd6f4c252015-03-26 16:23:04 +01005315 StreamParams sp =
5316 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5317
5318 EXPECT_TRUE(channel_->AddSendStream(sp));
5319 EXPECT_TRUE(channel_->AddRecvStream(sp));
5320
5321 // One of the SSRCs is already used in previous streams, using it should fail.
5322 sp = cricket::CreateSimStreamParams("cname",
5323 MAKE_VECTOR(kOverlappingStreamSsrcs));
5324 EXPECT_FALSE(channel_->AddSendStream(sp));
5325 EXPECT_FALSE(channel_->AddRecvStream(sp));
5326
5327 // After removing the original stream this should be fine to add (makes sure
5328 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005329 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5330 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005331 EXPECT_TRUE(channel_->AddSendStream(sp));
5332 EXPECT_TRUE(channel_->AddRecvStream(sp));
5333}
5334
eladalonf1841382017-06-12 01:16:46 -07005335TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005336 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005337
5338 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5339 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5340
5341 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5342 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5343
5344 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5345
5346 static const uint32_t kReceiverSsrcs[] = {3};
5347 static const uint32_t kReceiverRtxSsrcs[] = {2};
5348
5349 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5350 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5351 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5352
5353 cricket::VideoMediaInfo info;
5354 ASSERT_TRUE(channel_->GetStats(&info));
5355
5356 ASSERT_EQ(1u, info.senders.size());
5357 ASSERT_EQ(1u, info.receivers.size());
5358
5359 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5360 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5361 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5362}
5363
eladalonf1841382017-06-12 01:16:46 -07005364TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005365 FakeVideoReceiveStream* stream = AddRecvStream();
5366 webrtc::VideoReceiveStream::Stats stats;
5367 cricket::VideoMediaInfo info;
5368
5369 // Report no codec name before receiving.
5370 stream->SetStats(stats);
5371 ASSERT_TRUE(channel_->GetStats(&info));
5372 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5373
5374 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005375 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005376 stream->SetStats(stats);
5377 ASSERT_TRUE(channel_->GetStats(&info));
5378 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5379
5380 // Report no codec name for unknown playload types.
5381 stats.current_payload_type = 3;
5382 stream->SetStats(stats);
5383 ASSERT_TRUE(channel_->GetStats(&info));
5384 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5385}
5386
Seth Hampson5897a6e2018-04-03 11:16:33 -07005387// Tests that when we add a stream without SSRCs, but contains a stream_id
5388// that it is stored and its stream id is later used when the first packet
5389// arrives to properly create a receive stream with a sync label.
5390TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5391 const char kSyncLabel[] = "sync_label";
5392 cricket::StreamParams unsignaled_stream;
5393 unsignaled_stream.set_stream_ids({kSyncLabel});
5394 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5395 // The stream shouldn't have been created at this point because it doesn't
5396 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005397 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005398
5399 // Create and deliver packet.
5400 const size_t kDataLength = 12;
5401 uint8_t data[kDataLength];
5402 memset(data, 0, sizeof(data));
5403 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5404 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005405 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005406
5407 // The stream should now be created with the appropriate sync label.
5408 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5409 EXPECT_EQ(kSyncLabel,
5410 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5411
5412 // Removing the unsignaled stream should clear the cache. This time when
5413 // a default video receive stream is created it won't have a sync_group.
5414 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5415 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5416 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5417
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005418 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005419 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5420 EXPECT_TRUE(
5421 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5422}
5423
Ruslan Burakov493a6502019-02-27 15:32:48 +01005424// Test BaseMinimumPlayoutDelayMs on receive streams.
5425TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5426 // Test that set won't work for non-existing receive streams.
5427 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5428 // Test that get won't work for non-existing receive streams.
5429 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5430
5431 EXPECT_TRUE(AddRecvStream());
5432 // Test that set works for the existing receive stream.
5433 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5434 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5435 EXPECT_TRUE(recv_stream);
5436 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5437 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5438 200);
5439}
5440
5441// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5442TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5443 absl::optional<int> delay_ms;
5444 const FakeVideoReceiveStream* recv_stream;
5445
5446 // Set default stream with SSRC 0
5447 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5448 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5449
5450 // Spawn an unsignaled stream by sending a packet, it should inherit
5451 // default delay 200.
5452 const size_t kDataLength = 12;
5453 uint8_t data[kDataLength];
5454 memset(data, 0, sizeof(data));
5455 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5456 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005457 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005458
5459 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5460 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5461 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5462 EXPECT_EQ(200, delay_ms.value_or(0));
5463
5464 // Check that now if we change delay for SSRC 0 it will change delay for the
5465 // default receiving stream as well.
5466 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5467 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5468 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5469 EXPECT_EQ(300, delay_ms.value_or(0));
5470 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5471 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5472}
5473
eladalonf1841382017-06-12 01:16:46 -07005474void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005475 uint8_t payload_type,
5476 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005477 // kRedRtxPayloadType must currently be unused.
5478 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5479
noahricd10a68e2015-07-10 11:27:55 -07005480 // Add a RED RTX codec.
5481 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005482 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005483 recv_parameters_.codecs.push_back(red_rtx_codec);
5484 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005485
5486 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5487 const size_t kDataLength = 12;
5488 uint8_t data[kDataLength];
5489 memset(data, 0, sizeof(data));
5490
5491 rtc::Set8(data, 1, payload_type);
5492 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005493 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005494 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005495
5496 if (expect_created_receive_stream) {
5497 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5498 << "Should have created a receive stream for payload type: "
5499 << payload_type;
5500 } else {
5501 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5502 << "Shouldn't have created a receive stream for payload type: "
5503 << payload_type;
5504 }
5505}
5506
Åsa Persson2c7149b2018-10-15 09:36:10 +02005507class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5508 public:
5509 WebRtcVideoChannelDiscardUnknownSsrcTest()
5510 : WebRtcVideoChannelTest(
5511 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5512};
5513
5514TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5515 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5516 false /* expect_created_receive_stream */);
5517}
5518
eladalonf1841382017-06-12 01:16:46 -07005519TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005520 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5521 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005522}
5523
eladalonf1841382017-06-12 01:16:46 -07005524TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005525 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5526 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005527}
5528
eladalonf1841382017-06-12 01:16:46 -07005529TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005530 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005531 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5532 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5533 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5534 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005535}
5536
eladalonf1841382017-06-12 01:16:46 -07005537TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005538 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5539 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005540}
5541
eladalonf1841382017-06-12 01:16:46 -07005542TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005543 FlexfecPacketDoesntCreateUnsignalledStream) {
5544 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5545 false /* expect_created_receive_stream */);
5546}
5547
eladalonf1841382017-06-12 01:16:46 -07005548TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005549 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5550 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005551}
5552
mzanaty8a855d62017-02-17 15:46:43 -08005553// Test that receiving any unsignalled SSRC works even if it changes.
5554// The first unsignalled SSRC received will create a default receive stream.
5555// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005556TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005557 // Allow receiving VP8, VP9, H264 (if enabled).
5558 cricket::VideoRecvParameters parameters;
5559 parameters.codecs.push_back(GetEngineCodec("VP8"));
5560 parameters.codecs.push_back(GetEngineCodec("VP9"));
5561
5562#if defined(WEBRTC_USE_H264)
5563 cricket::VideoCodec H264codec(126, "H264");
5564 parameters.codecs.push_back(H264codec);
5565#endif
5566
5567 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5568 // No receive streams yet.
5569 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5570 cricket::FakeVideoRenderer renderer;
5571 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5572
5573 // Receive VP8 packet on first SSRC.
5574 uint8_t data[kMinRtpPacketLen];
5575 cricket::RtpHeader rtpHeader;
5576 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5577 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005578 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005579 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5580 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005581 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005582 // VP8 packet should create default receive stream.
5583 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005584 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005585 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5586 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005587 webrtc::VideoFrame video_frame =
5588 webrtc::VideoFrame::Builder()
5589 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5590 .set_timestamp_rtp(100)
5591 .set_timestamp_us(0)
5592 .set_rotation(webrtc::kVideoRotation_0)
5593 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005594 recv_stream->InjectFrame(video_frame);
5595 EXPECT_EQ(1, renderer.num_rendered_frames());
5596
5597 // Receive VP9 packet on second SSRC.
5598 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005599 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005600 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5601 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005602 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005603 // VP9 packet should replace the default receive SSRC.
5604 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5605 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5606 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5607 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005608 webrtc::VideoFrame video_frame2 =
5609 webrtc::VideoFrame::Builder()
5610 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5611 .set_timestamp_rtp(200)
5612 .set_timestamp_us(0)
5613 .set_rotation(webrtc::kVideoRotation_0)
5614 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005615 recv_stream->InjectFrame(video_frame2);
5616 EXPECT_EQ(2, renderer.num_rendered_frames());
5617
5618#if defined(WEBRTC_USE_H264)
5619 // Receive H264 packet on third SSRC.
5620 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005621 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005622 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5623 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005624 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005625 // H264 packet should replace the default receive SSRC.
5626 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5627 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5628 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5629 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005630 webrtc::VideoFrame video_frame3 =
5631 webrtc::VideoFrame::Builder()
5632 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5633 .set_timestamp_rtp(300)
5634 .set_timestamp_us(0)
5635 .set_rotation(webrtc::kVideoRotation_0)
5636 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005637 recv_stream->InjectFrame(video_frame3);
5638 EXPECT_EQ(3, renderer.num_rendered_frames());
5639#endif
5640}
5641
brandtr0dc57ea2017-05-29 23:33:31 -07005642// This test verifies that when a new default stream is created for a new
5643// unsignaled SSRC, the new stream does not overwrite any old stream that had
5644// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005645TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005646 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5647 cricket::VideoRecvParameters parameters;
5648 parameters.codecs.push_back(GetEngineCodec("VP8"));
5649 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5650
5651 // No streams signaled and no packets received, so we should not have any
5652 // stream objects created yet.
5653 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5654
5655 // Receive packet on an unsignaled SSRC.
5656 uint8_t data[kMinRtpPacketLen];
5657 cricket::RtpHeader rtp_header;
5658 rtp_header.payload_type = GetEngineCodec("VP8").id;
5659 rtp_header.seq_num = rtp_header.timestamp = 0;
5660 rtp_header.ssrc = kSsrcs3[0];
5661 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5662 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005663 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005664 // Default receive stream should be created.
5665 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5666 FakeVideoReceiveStream* recv_stream0 =
5667 fake_call_->GetVideoReceiveStreams()[0];
5668 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5669
5670 // Signal the SSRC.
5671 EXPECT_TRUE(
5672 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5673 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5674 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5675 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5676
5677 // Receive packet on a different unsignaled SSRC.
5678 rtp_header.ssrc = kSsrcs3[1];
5679 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5680 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005681 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005682 // New default receive stream should be created, but old stream should remain.
5683 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5684 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5685 FakeVideoReceiveStream* recv_stream1 =
5686 fake_call_->GetVideoReceiveStreams()[1];
5687 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5688}
5689
Seth Hampson7c682e02018-05-04 16:28:15 -07005690TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005691 AddSendStream();
5692
Niels Möller805a27e2019-01-21 12:21:27 +01005693 webrtc::test::FrameForwarder frame_forwarder;
5694 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005695 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005696 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005697
perkjfa10b552016-10-02 23:45:26 -07005698 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005699 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005700
5701 // TODO(skvlad): Resolve the inconsistency between the interpretation
5702 // of the global bitrate limit for audio and video:
5703 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5704 // max_bandwidth_bps = -1 - remove the bandwidth limit
5705 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005706 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005707
perkjfa10b552016-10-02 23:45:26 -07005708 SetAndExpectMaxBitrate(1000, 0, 1000);
5709 SetAndExpectMaxBitrate(1000, 800, 800);
5710 SetAndExpectMaxBitrate(600, 800, 600);
5711 SetAndExpectMaxBitrate(0, 800, 800);
5712 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005713
Niels Möllerff40b142018-04-09 08:49:14 +02005714 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005715}
5716
eladalonf1841382017-06-12 01:16:46 -07005717TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005718 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005719 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005720 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005721
5722 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005723 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005724 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005725}
5726
eladalonf1841382017-06-12 01:16:46 -07005727TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005728 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005729 FakeVideoSendStream* stream = AddSendStream();
5730
Seth Hampson7c682e02018-05-04 16:28:15 -07005731 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5732 EXPECT_EQ(1UL, parameters.encodings.size());
5733 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5734 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5735
5736 // Note that this is testing the behavior of the FakeVideoSendStream, which
5737 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5738 // we are just testing the behavior of
5739 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005740 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5741 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005742
5743 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5744 // by this amount.
5745 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5746 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5747 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5748 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5749
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005750 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5751 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5752 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5753}
5754
5755TEST_F(WebRtcVideoChannelTest,
5756 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5757 FakeVideoSendStream* stream = AddSendStream();
5758
5759 // Note that this is testing the behavior of the FakeVideoSendStream, which
5760 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5761 // we are just testing the behavior of
5762 // EncoderStreamFactory::CreateEncoderStreams.
5763 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5764 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5765
5766 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5767 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5768 EXPECT_EQ(1UL, parameters.encodings.size());
5769 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5770 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5771
5772 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5773 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5774 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5775}
5776
5777TEST_F(WebRtcVideoChannelTest,
5778 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5779 send_parameters_.max_bandwidth_bps = 99999;
5780 FakeVideoSendStream* stream = AddSendStream();
5781 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5782 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5783 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5784 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5785 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5786 stream->GetVideoStreams()[0].max_bitrate_bps);
5787
5788 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5789 // adjusted down.
5790 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5791 EXPECT_EQ(1UL, parameters.encodings.size());
5792 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5793 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5794 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5795 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5796 stream->GetVideoStreams()[0].min_bitrate_bps);
5797 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5798 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005799}
5800
Åsa Persson8c1bf952018-09-13 10:42:19 +02005801TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5802 FakeVideoSendStream* stream = AddSendStream();
5803
5804 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5805 EXPECT_EQ(1UL, parameters.encodings.size());
5806 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5807 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5808
5809 // Note that this is testing the behavior of the FakeVideoSendStream, which
5810 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5811 // we are just testing the behavior of
5812 // EncoderStreamFactory::CreateEncoderStreams.
5813 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5814 EXPECT_EQ(kDefaultVideoMaxFramerate,
5815 stream->GetVideoStreams()[0].max_framerate);
5816
5817 // Set max framerate and check that VideoStream.max_framerate is set.
5818 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5819 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5820 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5821 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5822
5823 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5824 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5825}
5826
Åsa Persson23eba222018-10-02 14:47:06 +02005827TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5828 FakeVideoSendStream* stream = AddSendStream();
5829
5830 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5831 EXPECT_EQ(1UL, parameters.encodings.size());
5832 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5833 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5834
5835 // Note that this is testing the behavior of the FakeVideoSendStream, which
5836 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5837 // we are just testing the behavior of
5838 // EncoderStreamFactory::CreateEncoderStreams.
5839 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5840 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5841
5842 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5843 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5844 parameters.encodings[0].num_temporal_layers = 2;
5845 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5846
5847 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5848 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5849}
5850
Seth Hampson7c682e02018-05-04 16:28:15 -07005851TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005852 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005853 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005854 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005855 // Two or more encodings should result in failure.
5856 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005857 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005858 // Zero encodings should also fail.
5859 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005860 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005861}
5862
Zach Stein3ca452b2018-01-18 10:01:24 -08005863TEST_F(WebRtcVideoChannelTest,
5864 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5865 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5866 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5867 AddSendStream(sp);
5868
5869 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5870
5871 // Additional encodings should result in failure.
5872 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005873 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005874 // Zero encodings should also fail.
5875 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005876 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005877}
5878
deadbeeffb2aced2017-01-06 23:05:37 -08005879// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005880TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005881 AddSendStream();
5882 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005883 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005884 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005885}
5886
Seth Hampson24722b32017-12-22 09:36:42 -08005887// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5888// a value <= 0, setting the parameters returns false.
5889TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5890 AddSendStream();
5891 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5892 EXPECT_EQ(1UL, parameters.encodings.size());
5893 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5894 parameters.encodings[0].bitrate_priority);
5895
5896 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005897 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005898 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005899 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005900}
5901
5902// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5903// properly on the VideoChannel and propogates down to the video encoder.
5904TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5905 AddSendStream();
5906 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5907 EXPECT_EQ(1UL, parameters.encodings.size());
5908 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5909 parameters.encodings[0].bitrate_priority);
5910
5911 // Change the value and set it on the VideoChannel.
5912 double new_bitrate_priority = 2.0;
5913 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005914 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005915
5916 // Verify that the encoding parameters bitrate_priority is set for the
5917 // VideoChannel.
5918 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5919 EXPECT_EQ(1UL, parameters.encodings.size());
5920 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5921
5922 // Verify that the new value propagated down to the encoder.
5923 std::vector<FakeVideoSendStream*> video_send_streams =
5924 fake_call_->GetVideoSendStreams();
5925 EXPECT_EQ(1UL, video_send_streams.size());
5926 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5927 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5928 // appropriately.
5929 EXPECT_EQ(new_bitrate_priority,
5930 video_send_stream->GetEncoderConfig().bitrate_priority);
5931 // Check that the vector of VideoStreams also was propagated correctly. Note
5932 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5933 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005934 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005935 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5936}
5937
5938// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5939// VideoChannel and the value propogates to the video encoder with all simulcast
5940// streams.
5941TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5942 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005943 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005944 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5945 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5946 AddSendStream(stream_params);
5947 uint32_t primary_ssrc = stream_params.first_ssrc();
5948
Niels Möller805a27e2019-01-21 12:21:27 +01005949 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005950 // frame. This creates multiple VideoStreams for all simulcast layers when
5951 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005952 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005953 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005954 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005955 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005956 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5957 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5958 rtc::kNumMicrosecsPerSec / 30));
5959
Seth Hampson24722b32017-12-22 09:36:42 -08005960 // Get and set the rtp encoding parameters.
5961 webrtc::RtpParameters parameters =
5962 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005963 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005964 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5965 parameters.encodings[0].bitrate_priority);
5966 // Change the value and set it on the VideoChannel.
5967 double new_bitrate_priority = 2.0;
5968 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005969 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005970
5971 // Verify that the encoding parameters priority is set on the VideoChannel.
5972 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005973 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005974 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5975
5976 // Verify that the new value propagated down to the encoder.
5977 std::vector<FakeVideoSendStream*> video_send_streams =
5978 fake_call_->GetVideoSendStreams();
5979 EXPECT_EQ(1UL, video_send_streams.size());
5980 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5981 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5982 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005983 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005984 video_send_stream->GetEncoderConfig().number_of_streams);
5985 EXPECT_EQ(new_bitrate_priority,
5986 video_send_stream->GetEncoderConfig().bitrate_priority);
5987 // Check that the vector of VideoStreams also propagated correctly. The
5988 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5989 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005990 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005991 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005992 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5993 // Since we are only setting bitrate priority per-sender, the other
5994 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005995 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005996 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005997 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005998 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005999 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006000}
6001
Tim Haloun648d28a2018-10-18 16:52:22 -07006002// RTCRtpEncodingParameters.network_priority must be one of a few values
6003// derived from the default priority, corresponding to very-low, low, medium,
6004// or high.
6005TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6006 AddSendStream();
6007 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6008 EXPECT_EQ(1UL, parameters.encodings.size());
6009 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6010 parameters.encodings[0].network_priority);
6011
6012 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6013 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6014 for (auto it : good_values) {
6015 parameters.encodings[0].network_priority = it;
6016 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6017 }
6018 for (auto it : bad_values) {
6019 parameters.encodings[0].network_priority = it;
6020 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6021 }
6022}
6023
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006024TEST_F(WebRtcVideoChannelTest,
6025 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006026 VideoSendParameters parameters;
6027 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006028 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6029 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6030
6031 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006032 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006033
6034 VideoOptions options;
6035 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6036 channel_->SetSend(true);
6037
6038 // Try layers in natural order (smallest to largest).
6039 {
6040 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6041 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6042 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6043 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6044 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6045 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6046 ASSERT_TRUE(result.ok());
6047
6048 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6049
6050 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6051 ASSERT_EQ(3u, video_streams.size());
6052 EXPECT_EQ(320u, video_streams[0].width);
6053 EXPECT_EQ(180u, video_streams[0].height);
6054 EXPECT_EQ(640u, video_streams[1].width);
6055 EXPECT_EQ(360u, video_streams[1].height);
6056 EXPECT_EQ(1280u, video_streams[2].width);
6057 EXPECT_EQ(720u, video_streams[2].height);
6058 }
6059
6060 // Try layers in reverse natural order (largest to smallest).
6061 {
6062 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6063 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6064 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6065 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6066 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6067 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6068 ASSERT_TRUE(result.ok());
6069
6070 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6071
6072 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6073 ASSERT_EQ(3u, video_streams.size());
6074 EXPECT_EQ(1280u, video_streams[0].width);
6075 EXPECT_EQ(720u, video_streams[0].height);
6076 EXPECT_EQ(640u, video_streams[1].width);
6077 EXPECT_EQ(360u, video_streams[1].height);
6078 EXPECT_EQ(320u, video_streams[2].width);
6079 EXPECT_EQ(180u, video_streams[2].height);
6080 }
6081
6082 // Try layers in mixed order.
6083 {
6084 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6085 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6086 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6087 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6088 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6089 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6090 ASSERT_TRUE(result.ok());
6091
6092 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6093
6094 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6095 ASSERT_EQ(3u, video_streams.size());
6096 EXPECT_EQ(128u, video_streams[0].width);
6097 EXPECT_EQ(72u, video_streams[0].height);
6098 EXPECT_EQ(640u, video_streams[1].width);
6099 EXPECT_EQ(360u, video_streams[1].height);
6100 EXPECT_EQ(320u, video_streams[2].width);
6101 EXPECT_EQ(180u, video_streams[2].height);
6102 }
6103
6104 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6105 {
6106 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6107 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6108 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6109 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6110 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6111 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6112 ASSERT_TRUE(result.ok());
6113
6114 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6115
6116 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6117 ASSERT_EQ(3u, video_streams.size());
6118 EXPECT_EQ(1280u, video_streams[0].width);
6119 EXPECT_EQ(720u, video_streams[0].height);
6120 EXPECT_EQ(1280u, video_streams[1].width);
6121 EXPECT_EQ(720u, video_streams[1].height);
6122 EXPECT_EQ(320u, video_streams[2].width);
6123 EXPECT_EQ(180u, video_streams[2].height);
6124 }
6125
6126 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6127}
6128
6129TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006130 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6131 // Ensure that the top layer has width and height divisible by 2^3,
6132 // so that the bottom layer has width and height divisible by 2.
6133 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6134 // the number of simulcast layers set by the app.
6135 webrtc::test::ScopedFieldTrials field_trial(
6136 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6137
6138 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6139 VideoSendParameters parameters;
6140 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6141 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6142 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6143 webrtc::test::FrameForwarder frame_forwarder;
6144 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6145 &frame_forwarder));
6146 channel_->SetSend(true);
6147
6148 // Set |scale_resolution_down_by|'s.
6149 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6150 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6151 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6152 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6153 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6154 const auto result =
6155 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6156 ASSERT_TRUE(result.ok());
6157
6158 // Use a capture resolution whose width and height are not divisible by 2^3.
6159 // (See field trial set at the top of the test.)
6160 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6161 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6162
6163 // Ensure the scaling is correct.
6164 const auto video_streams = stream->GetVideoStreams();
6165 ASSERT_EQ(video_streams.size(), 3u);
6166 // Ensure that we round the capture resolution down for the top layer...
6167 EXPECT_EQ(video_streams[0].width, 2000u);
6168 EXPECT_EQ(video_streams[0].height, 1200u);
6169 EXPECT_EQ(video_streams[1].width, 1000u);
6170 EXPECT_EQ(video_streams[1].height, 600u);
6171 // ...and that the bottom layer has a width/height divisible by 2.
6172 EXPECT_EQ(video_streams[2].width, 500u);
6173 EXPECT_EQ(video_streams[2].height, 300u);
6174
6175 // Tear down.
6176 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6177}
6178
6179TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006180 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006181 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6182 VideoSendParameters parameters;
6183 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006184 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6185 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6186
6187 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006188 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006189
6190 VideoOptions options;
6191 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6192 channel_->SetSend(true);
6193
6194 // Try layers in natural order (smallest to largest).
6195 {
6196 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6197 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6198 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6199 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6200 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6201 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6202 ASSERT_TRUE(result.ok());
6203
6204 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6205
6206 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6207 ASSERT_EQ(3u, video_streams.size());
6208 EXPECT_EQ(320u, video_streams[0].width);
6209 EXPECT_EQ(180u, video_streams[0].height);
6210 EXPECT_EQ(640u, video_streams[1].width);
6211 EXPECT_EQ(360u, video_streams[1].height);
6212 EXPECT_EQ(1280u, video_streams[2].width);
6213 EXPECT_EQ(720u, video_streams[2].height);
6214 }
6215
6216 // Try layers in reverse natural order (largest to smallest).
6217 {
6218 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6219 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6220 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6221 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6222 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6223 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6224 ASSERT_TRUE(result.ok());
6225
6226 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6227
6228 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6229 ASSERT_EQ(3u, video_streams.size());
6230 EXPECT_EQ(1280u, video_streams[0].width);
6231 EXPECT_EQ(720u, video_streams[0].height);
6232 EXPECT_EQ(640u, video_streams[1].width);
6233 EXPECT_EQ(360u, video_streams[1].height);
6234 EXPECT_EQ(320u, video_streams[2].width);
6235 EXPECT_EQ(180u, video_streams[2].height);
6236 }
6237
6238 // Try layers in mixed order.
6239 {
6240 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6241 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6242 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6243 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6244 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6245 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6246 ASSERT_TRUE(result.ok());
6247
6248 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6249
6250 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6251 ASSERT_EQ(3u, video_streams.size());
6252 EXPECT_EQ(128u, video_streams[0].width);
6253 EXPECT_EQ(72u, video_streams[0].height);
6254 EXPECT_EQ(640u, video_streams[1].width);
6255 EXPECT_EQ(360u, video_streams[1].height);
6256 EXPECT_EQ(320u, video_streams[2].width);
6257 EXPECT_EQ(180u, video_streams[2].height);
6258 }
6259
6260 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6261 {
6262 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6263 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6264 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6265 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6266 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6267 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6268 ASSERT_TRUE(result.ok());
6269
6270 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6271
6272 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6273 ASSERT_EQ(3u, video_streams.size());
6274 EXPECT_EQ(1280u, video_streams[0].width);
6275 EXPECT_EQ(720u, video_streams[0].height);
6276 EXPECT_EQ(1280u, video_streams[1].width);
6277 EXPECT_EQ(720u, video_streams[1].height);
6278 EXPECT_EQ(320u, video_streams[2].width);
6279 EXPECT_EQ(180u, video_streams[2].height);
6280 }
6281 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6282}
6283
Rasmus Brandt9387b522019-02-05 14:23:26 +01006284TEST_F(WebRtcVideoChannelTest,
6285 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6286 // Ensure that the top layer has width and height divisible by 2^3,
6287 // so that the bottom layer has width and height divisible by 2.
6288 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6289 // the number of simulcast layers set by the app.
6290 webrtc::test::ScopedFieldTrials field_trial(
6291 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6292
6293 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6294 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6295 VideoSendParameters parameters;
6296 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6297 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6298 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6299 webrtc::test::FrameForwarder frame_forwarder;
6300 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6301 &frame_forwarder));
6302 channel_->SetSend(true);
6303
6304 // Set |scale_resolution_down_by|'s.
6305 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6306 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6307 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6308 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6309 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6310 const auto result =
6311 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6312 ASSERT_TRUE(result.ok());
6313
6314 // Use a capture resolution whose width and height are not divisible by 2^3.
6315 // (See field trial set at the top of the test.)
6316 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6317 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6318
6319 // Ensure the scaling is correct.
6320 const auto video_streams = stream->GetVideoStreams();
6321 ASSERT_EQ(video_streams.size(), 3u);
6322 // Ensure that we round the capture resolution down for the top layer...
6323 EXPECT_EQ(video_streams[0].width, 2000u);
6324 EXPECT_EQ(video_streams[0].height, 1200u);
6325 EXPECT_EQ(video_streams[1].width, 1000u);
6326 EXPECT_EQ(video_streams[1].height, 600u);
6327 // ...and that the bottom layer has a width/height divisible by 2.
6328 EXPECT_EQ(video_streams[2].width, 500u);
6329 EXPECT_EQ(video_streams[2].height, 300u);
6330
6331 // Tear down.
6332 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6333}
6334
Åsa Persson8c1bf952018-09-13 10:42:19 +02006335TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6336 const size_t kNumSimulcastStreams = 3;
6337 SetUpSimulcast(true, false);
6338
6339 // Get and set the rtp encoding parameters.
6340 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6341 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6342 for (const auto& encoding : parameters.encodings) {
6343 EXPECT_FALSE(encoding.max_framerate);
6344 }
6345
6346 // Change the value and set it on the VideoChannel.
6347 parameters.encodings[0].max_framerate = 10;
6348 parameters.encodings[1].max_framerate = 20;
6349 parameters.encodings[2].max_framerate = 25;
6350 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6351
6352 // Verify that the bitrates are set on the VideoChannel.
6353 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6354 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6355 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6356 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6357 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6358}
6359
Åsa Persson23eba222018-10-02 14:47:06 +02006360TEST_F(WebRtcVideoChannelTest,
6361 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6362 const size_t kNumSimulcastStreams = 3;
6363 SetUpSimulcast(true, false);
6364
6365 // Get and set the rtp encoding parameters.
6366 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6367 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6368
6369 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6370 parameters.encodings[0].num_temporal_layers = 0;
6371 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6372 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6373 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6374 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6375 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6376}
6377
6378TEST_F(WebRtcVideoChannelTest,
6379 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6380 const size_t kNumSimulcastStreams = 3;
6381 SetUpSimulcast(true, false);
6382
6383 // Get and set the rtp encoding parameters.
6384 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6385 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6386
6387 // No/all layers should be set.
6388 parameters.encodings[0].num_temporal_layers = 1;
6389 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6390 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6391
6392 // Different values not supported.
6393 parameters.encodings[0].num_temporal_layers = 1;
6394 parameters.encodings[1].num_temporal_layers = 2;
6395 parameters.encodings[2].num_temporal_layers = 2;
6396 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6397 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6398}
6399
6400TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6401 const size_t kNumSimulcastStreams = 3;
6402 SetUpSimulcast(true, false);
6403
6404 // Get and set the rtp encoding parameters.
6405 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6406 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6407 for (const auto& encoding : parameters.encodings)
6408 EXPECT_FALSE(encoding.num_temporal_layers);
6409
6410 // Change the value and set it on the VideoChannel.
6411 parameters.encodings[0].num_temporal_layers = 3;
6412 parameters.encodings[1].num_temporal_layers = 3;
6413 parameters.encodings[2].num_temporal_layers = 3;
6414 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6415
6416 // Verify that the number of temporal layers are set on the VideoChannel.
6417 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6418 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6419 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6420 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6421 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6422}
6423
6424TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6425 const size_t kNumSimulcastStreams = 3;
6426 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6427
6428 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006429 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006430 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006431 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006432 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006433 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006434
6435 // Get and set the rtp encoding parameters.
6436 // Change the value and set it on the VideoChannel.
6437 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6438 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6439 parameters.encodings[0].num_temporal_layers = 2;
6440 parameters.encodings[1].num_temporal_layers = 2;
6441 parameters.encodings[2].num_temporal_layers = 2;
6442 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6443
6444 // Verify that the new value is propagated down to the encoder.
6445 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6446 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6447 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6448 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6449 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6450 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6451 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6452 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6453
6454 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6455 // VideoStreams are created appropriately for the simulcast case.
6456 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6457 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6458 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6459 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6460
6461 // No parameter changed, encoder should not be reconfigured.
6462 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6463 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6464
6465 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6466}
6467
6468TEST_F(WebRtcVideoChannelTest,
6469 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6470 const size_t kDefaultNumTemporalLayers = 3;
6471 const size_t kNumSimulcastStreams = 3;
6472 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6473
6474 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006475 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006476 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006477 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006478 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006479 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006480
6481 // Change rtp encoding parameters, num_temporal_layers not changed.
6482 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6483 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6484 parameters.encodings[0].min_bitrate_bps = 33000;
6485 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6486
6487 // Verify that no value is propagated down to the encoder.
6488 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6489 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6490 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6491 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6492 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6493 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6494
6495 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6496 // VideoStreams are created appropriately for the simulcast case.
6497 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6498 EXPECT_EQ(kDefaultNumTemporalLayers,
6499 stream->GetVideoStreams()[0].num_temporal_layers);
6500 EXPECT_EQ(kDefaultNumTemporalLayers,
6501 stream->GetVideoStreams()[1].num_temporal_layers);
6502 EXPECT_EQ(kDefaultNumTemporalLayers,
6503 stream->GetVideoStreams()[2].num_temporal_layers);
6504
6505 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6506}
6507
Åsa Persson8c1bf952018-09-13 10:42:19 +02006508TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6509 const size_t kNumSimulcastStreams = 3;
6510 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6511
6512 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006513 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006514 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006515 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006516 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006517 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006518
6519 // Get and set the rtp encoding parameters.
6520 // Change the value and set it on the VideoChannel.
6521 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6522 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6523 parameters.encodings[0].max_framerate = 15;
6524 parameters.encodings[1].max_framerate = 25;
6525 parameters.encodings[2].max_framerate = 20;
6526 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6527
6528 // Verify that the new value propagated down to the encoder.
6529 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6530 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6531 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6532 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6533 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6534 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6535 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6536 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6537
6538 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6539 // VideoStreams are created appropriately for the simulcast case.
6540 // Currently the maximum |max_framerate| is used.
6541 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6542 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6543 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6544 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6545
6546 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6547}
6548
6549TEST_F(WebRtcVideoChannelTest,
6550 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6551 const size_t kNumSimulcastStreams = 3;
6552 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6553 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6554
6555 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006556 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006557 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006558 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006559 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006560 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006561
6562 // Get and set the rtp encoding parameters.
6563 // Change the value and set it on the VideoChannel.
6564 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6565 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6566 parameters.encodings[0].max_framerate = 15;
6567 parameters.encodings[2].max_framerate = 20;
6568 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6569
6570 // Verify that the new value propagated down to the encoder.
6571 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6572 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6573 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6574 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6575 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6576 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6577 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6578
6579 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6580 // VideoStreams are created appropriately for the simulcast case.
6581 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6582 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6583 EXPECT_EQ(kDefaultVideoMaxFramerate,
6584 stream->GetVideoStreams()[0].max_framerate);
6585 EXPECT_EQ(kDefaultVideoMaxFramerate,
6586 stream->GetVideoStreams()[1].max_framerate);
6587 EXPECT_EQ(kDefaultVideoMaxFramerate,
6588 stream->GetVideoStreams()[2].max_framerate);
6589
6590 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6591}
6592
Åsa Persson55659812018-06-18 17:51:32 +02006593TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6594 const size_t kNumSimulcastStreams = 3;
6595 SetUpSimulcast(true, false);
6596
6597 // Get and set the rtp encoding parameters.
6598 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6599 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6600 for (const auto& encoding : parameters.encodings) {
6601 EXPECT_FALSE(encoding.min_bitrate_bps);
6602 EXPECT_FALSE(encoding.max_bitrate_bps);
6603 }
6604
6605 // Change the value and set it on the VideoChannel.
6606 parameters.encodings[0].min_bitrate_bps = 100000;
6607 parameters.encodings[0].max_bitrate_bps = 200000;
6608 parameters.encodings[1].min_bitrate_bps = 300000;
6609 parameters.encodings[1].max_bitrate_bps = 400000;
6610 parameters.encodings[2].min_bitrate_bps = 500000;
6611 parameters.encodings[2].max_bitrate_bps = 600000;
6612 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6613
6614 // Verify that the bitrates are set on the VideoChannel.
6615 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6616 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6617 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6618 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6619 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6620 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6621 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6622 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6623}
6624
6625TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6626 const size_t kNumSimulcastStreams = 3;
6627 SetUpSimulcast(true, false);
6628
6629 // Get and set the rtp encoding parameters.
6630 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6631 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6632
6633 // Max bitrate lower than min bitrate should fail.
6634 parameters.encodings[2].min_bitrate_bps = 100000;
6635 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6636 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6637 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6638}
6639
6640// Test that min and max bitrate values set via RtpParameters are correctly
6641// propagated to the underlying encoder, and that the target is set to 3/4 of
6642// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6643// that are used if no min/max are specified).
6644TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6645 const size_t kNumSimulcastStreams = 3;
6646 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6647
6648 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006649 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006650 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006651 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006652 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006653 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006654
6655 // Get and set the rtp encoding parameters.
6656 // Change the value and set it on the VideoChannel.
6657 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6658 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6659 parameters.encodings[0].min_bitrate_bps = 100000;
6660 parameters.encodings[0].max_bitrate_bps = 200000;
6661 parameters.encodings[1].min_bitrate_bps = 300000;
6662 parameters.encodings[1].max_bitrate_bps = 400000;
6663 parameters.encodings[2].min_bitrate_bps = 500000;
6664 parameters.encodings[2].max_bitrate_bps = 600000;
6665 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6666
6667 // Verify that the new value propagated down to the encoder.
6668 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6669 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6670 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6671 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6672 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6673 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6674 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6675 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6676 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6677 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6678 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6679
6680 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6681 // VideoStreams are created appropriately for the simulcast case.
6682 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6683 // Target bitrate: 200000 * 3 / 4 = 150000.
6684 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6685 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6686 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6687 // Target bitrate: 400000 * 3 / 4 = 300000.
6688 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6689 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6690 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6691 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6692 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6693 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6694 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6695
6696 // No parameter changed, encoder should not be reconfigured.
6697 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6698 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6699
6700 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6701}
6702
6703// Test to only specify the min or max bitrate value for a layer via
6704// RtpParameters. The unspecified min/max and target value should be set to the
6705// simulcast default that is used if no min/max are specified.
6706TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6707 const size_t kNumSimulcastStreams = 3;
6708 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6709 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6710
6711 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006712 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006713 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006714 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006715 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006716 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006717
6718 // Get and set the rtp encoding parameters.
6719 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6720 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6721
6722 // Change the value and set it on the VideoChannel.
6723 // Layer 0: only configure min bitrate.
6724 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6725 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6726 // Layer 1: only configure max bitrate.
6727 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6728 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6729 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6730
6731 // Verify that the new value propagated down to the encoder.
6732 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6733 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6734 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6735 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6736 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6737 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6738 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6739 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6740 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6741 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6742
6743 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6744 // VideoStreams are created appropriately for the simulcast case.
6745 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6746 // Layer 0: min configured bitrate should overwrite min default.
6747 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6748 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6749 stream->GetVideoStreams()[0].target_bitrate_bps);
6750 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6751 stream->GetVideoStreams()[0].max_bitrate_bps);
6752 // Layer 1: max configured bitrate should overwrite max default.
6753 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6754 stream->GetVideoStreams()[1].min_bitrate_bps);
6755 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6756 stream->GetVideoStreams()[1].target_bitrate_bps);
6757 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6758 // Layer 2: min and max bitrate not configured, default expected.
6759 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6760 stream->GetVideoStreams()[2].min_bitrate_bps);
6761 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6762 stream->GetVideoStreams()[2].target_bitrate_bps);
6763 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6764 stream->GetVideoStreams()[2].max_bitrate_bps);
6765
6766 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6767}
6768
6769// Test that specifying the min (or max) bitrate value for a layer via
6770// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6771// unspecified values accordingly.
6772TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6773 const size_t kNumSimulcastStreams = 3;
6774 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6775 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6776
6777 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006778 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006779 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006780 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006781 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006782 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006783
6784 // Get and set the rtp encoding parameters.
6785 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6786 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6787
6788 // Change the value and set it on the VideoChannel.
6789 // For layer 0, set the min bitrate above the default max.
6790 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6791 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6792 // For layer 1, set the max bitrate below the default min.
6793 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6794 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6795 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6796
6797 // Verify that the new value propagated down to the encoder.
6798 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6799 // VideoStreams are created appropriately for the simulcast case.
6800 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6801 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6802 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6803 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6804 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6805 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6806 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6807 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6808 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6809 // Layer 2: min and max bitrate not configured, default expected.
6810 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6811 stream->GetVideoStreams()[2].min_bitrate_bps);
6812 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6813 stream->GetVideoStreams()[2].target_bitrate_bps);
6814 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6815 stream->GetVideoStreams()[2].max_bitrate_bps);
6816
6817 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6818}
6819
6820TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6821 const size_t kNumSimulcastStreams = 3;
6822 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6823 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6824
6825 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006826 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006827 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006828 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006829 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006830 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006831
6832 // Set max bitrate for all but the highest layer.
6833 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6834 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6835 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6836 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6837 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6838
6839 // Set max bandwidth equal to total max bitrate.
6840 send_parameters_.max_bandwidth_bps =
6841 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6842 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6843 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6844
6845 // No bitrate above the total max to give to the highest layer.
6846 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6847 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6848 stream->GetVideoStreams()[2].max_bitrate_bps);
6849
6850 // Set max bandwidth above the total max bitrate.
6851 send_parameters_.max_bandwidth_bps =
6852 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6853 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6854 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6855
6856 // The highest layer has no max bitrate set -> the bitrate above the total
6857 // max should be given to the highest layer.
6858 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6859 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6860 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6861 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6862 stream->GetVideoStreams()[2].max_bitrate_bps);
6863
6864 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6865}
6866
6867TEST_F(WebRtcVideoChannelTest,
6868 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6869 const size_t kNumSimulcastStreams = 3;
6870 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6871 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6872 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6873
6874 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006875 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006876 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006877 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006878 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006879 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006880
6881 // Set max bitrate for the highest layer.
6882 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6883 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6884 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6885 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6886
6887 // Set max bandwidth above the total max bitrate.
6888 send_parameters_.max_bandwidth_bps =
6889 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6890 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6891 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6892
6893 // The highest layer has the max bitrate set -> the bitrate above the total
6894 // max should not be given to the highest layer.
6895 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6896 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6897 stream->GetVideoStreams()[2].max_bitrate_bps);
6898
6899 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6900}
6901
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006902// Test that min and max bitrate values set via RtpParameters are correctly
6903// propagated to the underlying encoder for a single stream.
6904TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6905 FakeVideoSendStream* stream = AddSendStream();
6906 EXPECT_TRUE(channel_->SetSend(true));
6907 EXPECT_TRUE(stream->IsSending());
6908
6909 // Set min and max bitrate.
6910 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6911 EXPECT_EQ(1u, parameters.encodings.size());
6912 parameters.encodings[0].min_bitrate_bps = 80000;
6913 parameters.encodings[0].max_bitrate_bps = 150000;
6914 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6915
6916 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6917 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6918 EXPECT_EQ(1u, encoder_config.number_of_streams);
6919 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6920 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6921 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6922
6923 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6924 // VideoStreams are created appropriately.
6925 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6926 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6927 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6928 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6929}
6930
6931// Test the default min and max bitrate value are correctly propagated to the
6932// underlying encoder for a single stream (when the values are not set via
6933// RtpParameters).
6934TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6935 FakeVideoSendStream* stream = AddSendStream();
6936 EXPECT_TRUE(channel_->SetSend(true));
6937 EXPECT_TRUE(stream->IsSending());
6938
6939 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6940 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6941 EXPECT_EQ(1u, encoder_config.number_of_streams);
6942 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6943 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6944 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6945
6946 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6947 // VideoStreams are created appropriately.
6948 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6949 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6950 stream->GetVideoStreams()[0].min_bitrate_bps);
6951 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6952 stream->GetVideoStreams()[0].min_bitrate_bps);
6953 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6954 stream->GetVideoStreams()[0].target_bitrate_bps);
6955}
6956
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006957// Test that a stream will not be sending if its encoding is made inactive
6958// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006959TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006960 FakeVideoSendStream* stream = AddSendStream();
6961 EXPECT_TRUE(channel_->SetSend(true));
6962 EXPECT_TRUE(stream->IsSending());
6963
6964 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006965 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006966 ASSERT_EQ(1u, parameters.encodings.size());
6967 ASSERT_TRUE(parameters.encodings[0].active);
6968 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006969 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006970 EXPECT_FALSE(stream->IsSending());
6971
6972 // Now change it back to active and verify we resume sending.
6973 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006974 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006975 EXPECT_TRUE(stream->IsSending());
6976}
6977
Seth Hampson8234ead2018-02-02 15:16:24 -08006978// Tests that when active is updated for any simulcast layer then the send
6979// stream's sending state will be updated and it will be reconfigured with the
6980// new appropriate active simulcast streams.
6981TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6982 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006983 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006984 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6985 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6986 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6987 uint32_t primary_ssrc = stream_params.first_ssrc();
6988
Niels Möller805a27e2019-01-21 12:21:27 +01006989 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006990 // frame. This allows us to test that ReconfigureEncoder is called
6991 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006992 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006993 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006994 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006995 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006996 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6997 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6998 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006999
7000 // Check that all encodings are initially active.
7001 webrtc::RtpParameters parameters =
7002 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007003 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007004 EXPECT_TRUE(parameters.encodings[0].active);
7005 EXPECT_TRUE(parameters.encodings[1].active);
7006 EXPECT_TRUE(parameters.encodings[2].active);
7007 EXPECT_TRUE(fake_video_send_stream->IsSending());
7008
7009 // Only turn on only the middle stream.
7010 parameters.encodings[0].active = false;
7011 parameters.encodings[1].active = true;
7012 parameters.encodings[2].active = false;
7013 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7014 // Verify that the active fields are set on the VideoChannel.
7015 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007016 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007017 EXPECT_FALSE(parameters.encodings[0].active);
7018 EXPECT_TRUE(parameters.encodings[1].active);
7019 EXPECT_FALSE(parameters.encodings[2].active);
7020 // Check that the VideoSendStream is updated appropriately. This means its
7021 // send state was updated and it was reconfigured.
7022 EXPECT_TRUE(fake_video_send_stream->IsSending());
7023 std::vector<webrtc::VideoStream> simulcast_streams =
7024 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007025 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007026 EXPECT_FALSE(simulcast_streams[0].active);
7027 EXPECT_TRUE(simulcast_streams[1].active);
7028 EXPECT_FALSE(simulcast_streams[2].active);
7029
7030 // Turn off all streams.
7031 parameters.encodings[0].active = false;
7032 parameters.encodings[1].active = false;
7033 parameters.encodings[2].active = false;
7034 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7035 // Verify that the active fields are set on the VideoChannel.
7036 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007037 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007038 EXPECT_FALSE(parameters.encodings[0].active);
7039 EXPECT_FALSE(parameters.encodings[1].active);
7040 EXPECT_FALSE(parameters.encodings[2].active);
7041 // Check that the VideoSendStream is off.
7042 EXPECT_FALSE(fake_video_send_stream->IsSending());
7043 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007044 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007045 EXPECT_FALSE(simulcast_streams[0].active);
7046 EXPECT_FALSE(simulcast_streams[1].active);
7047 EXPECT_FALSE(simulcast_streams[2].active);
7048
Niels Möllerff40b142018-04-09 08:49:14 +02007049 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007050}
7051
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007052// Test that if a stream is reconfigured (due to a codec change or other
7053// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007054TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007055 InactiveStreamDoesntStartSendingWhenReconfigured) {
7056 // Set an initial codec list, which will be modified later.
7057 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007058 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7059 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007060 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7061
7062 FakeVideoSendStream* stream = AddSendStream();
7063 EXPECT_TRUE(channel_->SetSend(true));
7064 EXPECT_TRUE(stream->IsSending());
7065
7066 // Get current parameters and change "active" to false.
7067 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7068 ASSERT_EQ(1u, parameters.encodings.size());
7069 ASSERT_TRUE(parameters.encodings[0].active);
7070 parameters.encodings[0].active = false;
7071 EXPECT_EQ(1u, GetFakeSendStreams().size());
7072 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007073 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007074 EXPECT_FALSE(stream->IsSending());
7075
7076 // Reorder the codec list, causing the stream to be reconfigured.
7077 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007078 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7079 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007080 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7081 auto new_streams = GetFakeSendStreams();
7082 // Assert that a new underlying stream was created due to the codec change.
7083 // Otherwise, this test isn't testing what it set out to test.
7084 EXPECT_EQ(1u, GetFakeSendStreams().size());
7085 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7086
7087 // Verify that we still are not sending anything, due to the inactive
7088 // encoding.
7089 EXPECT_FALSE(new_streams[0]->IsSending());
7090}
7091
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007092// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007093TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007094 AddSendStream();
7095 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007096 parameters.codecs.push_back(GetEngineCodec("VP8"));
7097 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007098 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7099
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007100 webrtc::RtpParameters rtp_parameters =
7101 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007102 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007103 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7104 rtp_parameters.codecs[0]);
7105 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7106 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007107}
7108
Florent Castellidacec712018-05-24 16:24:21 +02007109// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7110TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7111 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7112 params.cname = "rtcpcname";
7113 AddSendStream(params);
7114
7115 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7116 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7117}
7118
deadbeeffb2aced2017-01-06 23:05:37 -08007119// Test that RtpParameters for send stream has one encoding and it has
7120// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007121TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007122 AddSendStream();
7123
7124 webrtc::RtpParameters rtp_parameters =
7125 channel_->GetRtpSendParameters(last_ssrc_);
7126 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007127 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007128}
7129
Florent Castelliabe301f2018-06-12 18:33:49 +02007130TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7131 AddSendStream();
7132
7133 webrtc::RtpParameters rtp_parameters =
7134 channel_->GetRtpSendParameters(last_ssrc_);
7135 rtp_parameters.header_extensions.emplace_back();
7136
7137 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7138
7139 webrtc::RTCError result =
7140 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7141 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7142}
7143
Florent Castelli87b3c512018-07-18 16:00:28 +02007144TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7145 AddSendStream();
7146
Niels Möller805a27e2019-01-21 12:21:27 +01007147 webrtc::test::FrameForwarder frame_forwarder;
7148 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007149
7150 webrtc::RtpParameters rtp_parameters =
7151 channel_->GetRtpSendParameters(last_ssrc_);
7152 EXPECT_EQ(rtp_parameters.degradation_preference,
7153 webrtc::DegradationPreference::BALANCED);
7154 rtp_parameters.degradation_preference =
7155 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7156
7157 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7158
7159 webrtc::RtpParameters updated_rtp_parameters =
7160 channel_->GetRtpSendParameters(last_ssrc_);
7161 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7162 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7163
7164 // Remove the source since it will be destroyed before the channel
7165 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7166}
7167
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007168// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007169TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007170 AddSendStream();
7171 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007172 parameters.codecs.push_back(GetEngineCodec("VP8"));
7173 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007174 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7175
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007176 webrtc::RtpParameters initial_params =
7177 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007178
7179 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007180 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007181
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007182 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7183 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7184}
7185
7186// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007187TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007188 AddRecvStream();
7189 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007190 parameters.codecs.push_back(GetEngineCodec("VP8"));
7191 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007192 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7193
7194 webrtc::RtpParameters rtp_parameters =
7195 channel_->GetRtpReceiveParameters(last_ssrc_);
7196 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007197 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7198 rtp_parameters.codecs[0]);
7199 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7200 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007201}
7202
johan073ece42016-08-26 02:59:47 -07007203#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007204TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007205#else
eladalonf1841382017-06-12 01:16:46 -07007206TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007207#endif
johan3859c892016-08-05 09:19:25 -07007208 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007209 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007210 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007211 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007212 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007213 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007214 parameters.codecs.push_back(kH264sprop2);
7215 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7216
7217 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7218 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7219 webrtc::RtpParameters rtp_parameters =
7220 channel_->GetRtpReceiveParameters(last_ssrc_);
7221 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7222 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7223 ASSERT_EQ(2u, cfg.decoders.size());
7224 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007225 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007226 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007227 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7228 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007229 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007230
7231 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007232 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007233 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007234 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7235 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007236 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007237}
7238
sakal1fd95952016-06-22 00:46:15 -07007239// Test that RtpParameters for receive stream has one encoding and it has
7240// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007241TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007242 AddRecvStream();
7243
7244 webrtc::RtpParameters rtp_parameters =
7245 channel_->GetRtpReceiveParameters(last_ssrc_);
7246 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007247 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007248}
7249
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007250// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007251TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007252 AddRecvStream();
7253 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007254 parameters.codecs.push_back(GetEngineCodec("VP8"));
7255 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007256 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7257
7258 webrtc::RtpParameters initial_params =
7259 channel_->GetRtpReceiveParameters(last_ssrc_);
7260
7261 // We should be able to set the params we just got.
7262 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7263
7264 // ... And this shouldn't change the params returned by
7265 // GetRtpReceiveParameters.
7266 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007267}
7268
deadbeef3bc15102017-04-20 19:25:07 -07007269// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7270// aren't signaled. It should always return an empty "RtpEncodingParameters",
7271// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007272TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007273 // Call necessary methods to configure receiving a default stream as
7274 // soon as it arrives.
7275 cricket::VideoRecvParameters parameters;
7276 parameters.codecs.push_back(GetEngineCodec("VP8"));
7277 parameters.codecs.push_back(GetEngineCodec("VP9"));
7278 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7279
7280 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7281 // stream. Should return nothing.
7282 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7283
7284 // Set a sink for an unsignaled stream.
7285 cricket::FakeVideoRenderer renderer;
7286 // Value of "0" means "unsignaled stream".
7287 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7288
7289 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7290 // in this method means "unsignaled stream".
7291 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7292 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7293 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7294
7295 // Receive VP8 packet.
7296 uint8_t data[kMinRtpPacketLen];
7297 cricket::RtpHeader rtpHeader;
7298 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7299 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7300 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7301 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7302 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007303 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007304
7305 // The |ssrc| member should still be unset.
7306 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7307 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7308 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7309}
7310
eladalonf1841382017-06-12 01:16:46 -07007311void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007312 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007313 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007314
7315 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007316 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007317 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007318 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007319
7320 if (receiver_first) {
7321 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7322 std::vector<FakeVideoReceiveStream*> receive_streams =
7323 fake_call_->GetVideoReceiveStreams();
7324 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007325 // Default local SSRC when we have no sender.
7326 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7327 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007328 }
7329 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7330 if (!receiver_first)
7331 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7332 std::vector<FakeVideoReceiveStream*> receive_streams =
7333 fake_call_->GetVideoReceiveStreams();
7334 ASSERT_EQ(1u, receive_streams.size());
7335 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007336
7337 // Removing first sender should fall back to another (in this case the second)
7338 // local send stream's SSRC.
7339 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7340 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007341 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007342 ASSERT_EQ(1u, receive_streams.size());
7343 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7344
7345 // Removing the last sender should fall back to default local SSRC.
7346 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007347 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007348 ASSERT_EQ(1u, receive_streams.size());
7349 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7350 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007351}
7352
eladalonf1841382017-06-12 01:16:46 -07007353TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007354 TestReceiverLocalSsrcConfiguration(false);
7355}
7356
eladalonf1841382017-06-12 01:16:46 -07007357TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007358 TestReceiverLocalSsrcConfiguration(true);
7359}
7360
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007361class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007362 public:
eladalonf1841382017-06-12 01:16:46 -07007363 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007364 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007365 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7366 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007367 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007368 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007369 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007370 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007371 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007372 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007373 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007374
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007375 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007376 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007377 channel_.reset(engine_.CreateMediaChannel(
7378 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7379 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007380 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007381 last_ssrc_ = 123;
7382 }
7383
7384 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007385 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007386 int capture_width,
7387 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007388 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007389 size_t expected_num_streams,
7390 bool screenshare,
7391 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007392 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007393 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007394 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007395 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007396
Peter Boström0c4e06b2015-10-07 12:23:21 +02007397 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007398 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007399 ssrcs.resize(num_configured_streams);
7400
sprangf24a0642017-02-28 13:23:26 -08007401 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007402 // Send a full-size frame to trigger a stream reconfiguration to use all
7403 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007404 webrtc::test::FrameForwarder frame_forwarder;
7405 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7406 rtc::kNumMicrosecsPerSec / 30);
7407
sprangf24a0642017-02-28 13:23:26 -08007408 VideoOptions options;
7409 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007410 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007411 EXPECT_TRUE(
7412 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007413 // Fetch the latest stream since SetVideoSend() may recreate it if the
7414 // screen content setting is changed.
7415 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007416 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007417 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007418
Zach Stein3ca452b2018-01-18 10:01:24 -08007419 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7420 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7421
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007422 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7423 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007424 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007425
sprang429600d2017-01-26 06:12:26 -08007426 std::vector<webrtc::VideoStream> expected_streams;
7427 if (conference_mode) {
7428 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007429 num_configured_streams, capture_width, capture_height,
7430 webrtc::kDefaultBitratePriority, kDefaultQpMax, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08007431 if (screenshare) {
7432 for (const webrtc::VideoStream& stream : expected_streams) {
7433 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007434 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7435 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007436 }
7437 }
sprang429600d2017-01-26 06:12:26 -08007438 } else {
7439 webrtc::VideoStream stream;
7440 stream.width = capture_width;
7441 stream.height = capture_height;
7442 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007443 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007444 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007445 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007446 stream.max_qp = kDefaultQpMax;
7447 expected_streams.push_back(stream);
7448 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007449
7450 ASSERT_EQ(expected_streams.size(), video_streams.size());
7451
7452 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007453 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007454 for (size_t i = 0; i < num_streams; ++i) {
7455 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7456 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7457
7458 EXPECT_GT(video_streams[i].max_framerate, 0);
7459 EXPECT_EQ(expected_streams[i].max_framerate,
7460 video_streams[i].max_framerate);
7461
7462 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7463 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7464 video_streams[i].min_bitrate_bps);
7465
7466 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7467 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7468 video_streams[i].target_bitrate_bps);
7469
7470 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7471 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7472 video_streams[i].max_bitrate_bps);
7473
7474 EXPECT_GT(video_streams[i].max_qp, 0);
7475 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7476
Sergey Silkina796a7e2018-03-01 15:11:29 +01007477 EXPECT_EQ(conference_mode,
7478 expected_streams[i].num_temporal_layers.has_value());
7479
7480 if (conference_mode) {
7481 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7482 video_streams[i].num_temporal_layers);
7483 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007484
7485 if (i == num_streams - 1) {
7486 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7487 } else {
7488 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7489 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007490 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007491
Niels Möllerff40b142018-04-09 08:49:14 +02007492 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007493 }
7494
7495 FakeVideoSendStream* AddSendStream() {
7496 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7497 }
7498
7499 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007500 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007501 EXPECT_TRUE(channel_->AddSendStream(sp));
7502 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007503 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007504 EXPECT_EQ(num_streams + 1, streams.size());
7505 return streams[streams.size() - 1];
7506 }
7507
7508 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007509 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007510 }
7511
7512 FakeVideoReceiveStream* AddRecvStream() {
7513 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7514 }
7515
7516 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007517 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007518 EXPECT_TRUE(channel_->AddRecvStream(sp));
7519 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007520 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007521 EXPECT_EQ(num_streams + 1, streams.size());
7522 return streams[streams.size() - 1];
7523 }
7524
skvlad11a9cbf2016-10-07 11:53:05 -07007525 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007526 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007527 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7528 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007529 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7530 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007531 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007532 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007533 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007534};
7535
eladalonf1841382017-06-12 01:16:46 -07007536TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007537 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7538 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007539}
7540
eladalonf1841382017-06-12 01:16:46 -07007541TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007542 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7543 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007544}
7545
7546// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007547TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007548 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7549 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007550}
sprang429600d2017-01-26 06:12:26 -08007551
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007552TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007553 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7554 false);
7555}
7556
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007557TEST_F(WebRtcVideoChannelSimulcastTest,
7558 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007559 webrtc::test::ScopedFieldTrials field_trials(
7560 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007561 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7562 true);
7563}
7564
eladalonf1841382017-06-12 01:16:46 -07007565TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007566 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7567 true);
7568}
7569
eladalonf1841382017-06-12 01:16:46 -07007570TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007571 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007572 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7573 false);
7574}
7575
Chen Xing90f3b892019-06-25 10:16:14 +02007576TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7577 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007578
Chen Xing90f3b892019-06-25 10:16:14 +02007579 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007580 EXPECT_TRUE(SetDefaultCodec());
7581 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007582 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007583
Chen Xing90f3b892019-06-25 10:16:14 +02007584 // Send and receive one frame.
7585 SendFrame();
7586 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007587
Chen Xing90f3b892019-06-25 10:16:14 +02007588 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7589 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7590 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007591
Chen Xing90f3b892019-06-25 10:16:14 +02007592 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7593 EXPECT_EQ(source.source_id(), kSsrc);
7594 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7595 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7596 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007597
Chen Xing90f3b892019-06-25 10:16:14 +02007598 // Send and receive another frame.
7599 SendFrame();
7600 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007601
Chen Xing90f3b892019-06-25 10:16:14 +02007602 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7603 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7604 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007605
Chen Xing90f3b892019-06-25 10:16:14 +02007606 source = channel_->GetSources(kSsrc)[0];
7607 EXPECT_EQ(source.source_id(), kSsrc);
7608 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7609 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7610 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007611
Chen Xing90f3b892019-06-25 10:16:14 +02007612 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7613 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007614}
7615
Amit Hilbuchb000b712019-02-25 10:22:14 -08007616TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7617 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7618
7619 std::vector<std::string> rids = {"f", "h", "q"};
7620 std::vector<cricket::RidDescription> rid_descriptions;
7621 for (const auto& rid : rids) {
7622 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7623 }
7624 sp.set_rids(rid_descriptions);
7625
7626 ASSERT_TRUE(channel_->AddSendStream(sp));
7627 const auto& streams = fake_call_->GetVideoSendStreams();
7628 ASSERT_EQ(1u, streams.size());
7629 auto stream = streams[0];
7630 ASSERT_NE(stream, nullptr);
7631 const auto& config = stream->GetConfig();
7632 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7633}
7634
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007635} // namespace cricket