blob: 3702064685af044a5b8599500446180a5b32f532 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020013#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Steve Anton2c9ebef2019-01-28 17:27:58 -080017#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010018#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020019#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070020#include "api/media_transport_config.h"
Steve Anton10542f22019-01-11 09:11:00 -080021#include "api/rtp_parameters.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070022#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080023#include "api/test/mock_video_bitrate_allocator.h"
24#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070025#include "api/test/mock_video_decoder_factory.h"
26#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020027#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080028#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010029#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020030#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020031#include "api/video_codecs/builtin_video_decoder_factory.h"
32#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020033#include "api/video_codecs/sdp_video_format.h"
34#include "api/video_codecs/video_decoder_factory.h"
35#include "api/video_codecs/video_encoder.h"
36#include "api/video_codecs/video_encoder_factory.h"
37#include "call/flexfec_receive_stream.h"
38#include "common_video/h264/profile_level_id.h"
39#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010040#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080041#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080042#include "media/base/fake_video_renderer.h"
43#include "media/base/media_constants.h"
44#include "media/base/rtp_utils.h"
45#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080047#include "media/engine/fake_webrtc_call.h"
48#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/webrtc_video_engine.h"
51#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020052#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020053#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080054#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020056#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080057#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020058#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010059#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000061
Mirko Bonadei6a489f22019-04-09 15:11:12 +020062using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020063using ::testing::IsEmpty;
64using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010065using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070066using webrtc::RtpExtension;
67
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000068namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000069static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000070
noahricd10a68e2015-07-10 11:27:55 -070071static const uint8_t kRedRtxPayloadType = 125;
72
Niels Möller6557d0c2018-04-11 15:18:34 +020073static const uint32_t kTimeout = 5000U;
74static const uint32_t kDefaultReceiveSsrc = 0;
75static const uint32_t kSsrc = 1234u;
76static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
77static const int kVideoWidth = 640;
78static const int kVideoHeight = 360;
79static const int kFramerate = 30;
80
Peter Boström0c4e06b2015-10-07 12:23:21 +020081static const uint32_t kSsrcs1[] = {1};
82static const uint32_t kSsrcs3[] = {1, 2, 3};
83static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080084static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020085static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080086static const uint32_t kDefaultRecvSsrc = 0;
87
pbos@webrtc.org3c107582014-07-20 15:27:35 +000088static const char kUnsupportedExtensionName[] =
89 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000090
magjed509e4fe2016-11-18 01:34:11 -080091cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
92 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020093 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080094}
95
Elad Alonfadb1812019-05-24 13:40:02 +020096void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
97 bool lntf_expected) {
98 EXPECT_EQ(lntf_expected,
99 codec.HasFeedbackParam(cricket::FeedbackParam(
100 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000101 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
102 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
103 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
106 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800108 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000110 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
111}
112
magjed725e4842016-11-16 00:48:13 -0800113// Return true if any codec in |codecs| is an RTX codec with associated payload
114// type |payload_type|.
115bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
116 int payload_type) {
117 for (const cricket::VideoCodec& codec : codecs) {
118 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200119 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800120 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
121 &associated_payload_type) &&
122 associated_payload_type == payload_type) {
123 return true;
124 }
125 }
126 return false;
127}
128
nisseca5706d2017-09-11 02:32:16 -0700129// TODO(nisse): Duplicated in call.cc.
130const int* FindKeyByValue(const std::map<int, int>& m, int v) {
131 for (const auto& kv : m) {
132 if (kv.second == v)
133 return &kv.first;
134 }
135 return nullptr;
136}
137
Yves Gerey665174f2018-06-19 15:03:05 +0200138bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
139 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700140 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
141 payload_type) != nullptr;
142}
143
144// Check that there's an Rtx payload type for each decoder.
145bool VerifyRtxReceiveAssociations(
146 const webrtc::VideoReceiveStream::Config& config) {
147 for (const auto& decoder : config.decoders) {
148 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
149 return false;
150 }
151 return true;
152}
153
brandtrffc61182016-11-28 06:02:22 -0800154rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700155 int width,
156 int height) {
157 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
158 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800159 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700160 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000161}
162
Shao Changbine62202f2015-04-21 20:24:50 +0800163void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
164 const std::map<int, int>& rtx_types) {
165 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200166 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800167 EXPECT_TRUE(it != rtx_types.end() &&
168 it->second == config.rtp.rtx.payload_type);
169
brandtrb5f2c3f2016-10-04 23:28:39 -0700170 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
171 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800172 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700173 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800174 }
175}
kthelgason2bc68642017-02-07 07:02:22 -0800176
177cricket::MediaConfig GetMediaConfig() {
178 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100179 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800180 return media_config;
181}
nisse26e3abb2017-08-25 04:44:25 -0700182
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200183// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
184int GetMaxDefaultBitrateBps(size_t width, size_t height) {
185 if (width * height <= 320 * 240) {
186 return 600000;
187 } else if (width * height <= 640 * 480) {
188 return 1700000;
189 } else if (width * height <= 960 * 540) {
190 return 2000000;
191 } else {
192 return 2500000;
193 }
194}
195
Niels Möller731a2c22018-07-30 15:08:07 +0200196class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
197 public:
198 MOCK_METHOD2(AddOrUpdateSink,
199 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
200 const rtc::VideoSinkWants& wants));
201 MOCK_METHOD1(RemoveSink,
202 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
203};
204
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000205} // namespace
206
Yves Gerey665174f2018-06-19 15:03:05 +0200207#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200208 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200209 EXPECT_EQ((w), renderer_.width()); \
210 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200211 EXPECT_EQ(0, renderer_.errors());
212
Yves Gerey665174f2018-06-19 15:03:05 +0200213#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200214 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200215 EXPECT_EQ((w), (r).width()); \
216 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200217 EXPECT_EQ(0, (r).errors());
218
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000219namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700220class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000221 public:
eladalonf1841382017-06-12 01:16:46 -0700222 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200223 explicit WebRtcVideoEngineTest(const std::string& field_trials)
224 : override_field_trials_(
225 field_trials.empty()
226 ? nullptr
227 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
228 field_trials)),
skvlad11a9cbf2016-10-07 11:53:05 -0700229 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200230 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
231 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200232 video_bitrate_allocator_factory_(
233 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200234 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200235 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200236 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200237 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200238 // Ensure fake clock doesn't return 0, which will cause some initializations
239 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200240 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200241 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000242
243 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200244 void AssignDefaultAptRtxTypes();
245 void AssignDefaultCodec();
246
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100247 // Find the index of the codec in the engine with the given name. The codec
248 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100249 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100250
magjed509e4fe2016-11-18 01:34:11 -0800251 // Find the codec in the engine with the given name. The codec must be
252 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100253 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800254
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200255 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000256
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000258 const std::vector<VideoCodec>& codecs);
259
Elad Alon157540a2019-02-08 23:37:52 +0100260 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100261
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200262 // Has to be the first one, so it is initialized before the call or there is a
263 // race condition in the clock access.
264 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200265 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700266 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700267 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000268 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800269 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200270 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
271 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200272 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
273 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700274 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000275 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800276 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000277};
278
eladalonf1841382017-06-12 01:16:46 -0700279TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200280 encoder_factory_->AddSupportedVideoCodecType("VP8");
281 AssignDefaultCodec();
282
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000283 std::vector<VideoCodec> engine_codecs = engine_.codecs();
284 for (size_t i = 0; i < engine_codecs.size(); ++i) {
285 if (engine_codecs[i].name != kRtxCodecName)
286 continue;
287 int associated_payload_type;
288 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000289 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000290 EXPECT_EQ(default_codec_.id, associated_payload_type);
291 return;
292 }
293 FAIL() << "No RTX codec found among default codecs.";
294}
295
eladalonf1841382017-06-12 01:16:46 -0700296TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100297 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000298}
299
eladalonf1841382017-06-12 01:16:46 -0700300TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100301 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000302}
303
eladalonf1841382017-06-12 01:16:46 -0700304TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100305 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700306}
307
eladalonf1841382017-06-12 01:16:46 -0700308TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100309 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
310}
311
312TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
313 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
314}
315
316TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
317 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
318}
319
320TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
321 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
322}
323
324TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
325 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100326}
327
328TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100329 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
330}
331
Elad Alonccb9b752019-02-19 13:01:31 +0100332TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
333 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
334}
335
336TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
337 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700338}
339
philipel1e054862018-10-08 16:13:53 +0200340class WebRtcVideoEngineTestWithGenericDescriptor
341 : public WebRtcVideoEngineTest {
342 public:
343 WebRtcVideoEngineTestWithGenericDescriptor()
344 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
345};
346
Elad Alonccb9b752019-02-19 13:01:31 +0100347TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
348 AdvertiseGenericDescriptor00) {
349 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
350}
351
352TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
353 AdvertiseGenericDescriptor01) {
354 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200355}
356
eladalonf1841382017-06-12 01:16:46 -0700357TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200358 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200360 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700361
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200362 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200364 std::unique_ptr<VideoMediaChannel> channel(
365 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
367
368 // Add CVO extension.
369 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800370 cricket::VideoSendParameters parameters;
371 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200372 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700373 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200374 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700375
Niels Möller731a2c22018-07-30 15:08:07 +0200376 EXPECT_CALL(
377 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200378 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200379 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700380 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200381 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700382
383 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200384 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700385
386 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200387 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200388 EXPECT_CALL(
389 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200390 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200391 Field(&rtc::VideoSinkWants::rotation_applied, true)));
392
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200393 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700394}
395
eladalonf1841382017-06-12 01:16:46 -0700396TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200397 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800398 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200399 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800400
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200401 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800402
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200403 std::unique_ptr<VideoMediaChannel> channel(
404 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800405 // Add CVO extension.
406 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800407 cricket::VideoSendParameters parameters;
408 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800409 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700410 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800411 EXPECT_TRUE(channel->SetSendParameters(parameters));
412 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
413
Niels Möller731a2c22018-07-30 15:08:07 +0200414 // Set source.
415 EXPECT_CALL(
416 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200417 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200418 Field(&rtc::VideoSinkWants::rotation_applied, false)));
419 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800420}
421
eladalonf1841382017-06-12 01:16:46 -0700422TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200423 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700424
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200425 encoder_factory_->AddSupportedVideoCodecType("VP8");
426 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700427
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200428 std::unique_ptr<VideoMediaChannel> channel(
429 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700430 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
431
432 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200433 EXPECT_CALL(
434 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200435 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200436 Field(&rtc::VideoSinkWants::rotation_applied, true)));
437 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700438
perkjcaafdba2016-03-20 07:34:29 -0700439 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200440 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700441
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700442 // Add CVO extension.
443 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800444 cricket::VideoSendParameters parameters;
445 parameters.codecs.push_back(GetEngineCodec("VP8"));
446 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200447 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700448 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700449 // Also remove the first codec to trigger a codec change as well.
450 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200451 EXPECT_CALL(
452 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200453 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200454 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200455 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700456
457 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200458 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700459
460 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200461 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200462 EXPECT_CALL(
463 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200464 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200465 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200466 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700467}
468
eladalonf1841382017-06-12 01:16:46 -0700469TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200470 encoder_factory_->AddSupportedVideoCodecType("VP8");
471
Sebastian Jansson84848f22018-11-16 10:40:36 +0100472 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200473 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
474 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000475
476 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
477
478 EXPECT_FALSE(channel->SetSend(true))
479 << "Channel should not start without codecs.";
480 EXPECT_TRUE(channel->SetSend(false))
481 << "Channel should be stoppable even without set codecs.";
482}
483
eladalonf1841382017-06-12 01:16:46 -0700484TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200485 encoder_factory_->AddSupportedVideoCodecType("VP8");
486
Sebastian Jansson84848f22018-11-16 10:40:36 +0100487 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200488 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
489 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000490 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
491 VideoMediaInfo info;
492 channel->GetStats(&info);
493}
494
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200495TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200496 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000497
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200498 std::unique_ptr<VideoMediaChannel> channel(
499 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800500 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000501
502 EXPECT_TRUE(
503 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200504 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000505 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100506 webrtc::test::FrameForwarder frame_forwarder;
507 cricket::FakeFrameSource frame_source(1280, 720,
508 rtc::kNumMicrosecsPerSec / 30);
509 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
510 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100511 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200512 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
513 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000514 kTimeout);
515
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200516 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100517 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000518
519 // Setting codecs of the same type should not reallocate any encoders
520 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800521 cricket::VideoSendParameters parameters;
522 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200523 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200524 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000525
526 // Remove stream previously added to free the external encoder instance.
527 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200528 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000529}
530
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200531// Test that when an encoder factory supports H264, we add an RTX
532// codec for it.
533// TODO(deadbeef): This test should be updated if/when we start
534// adding RTX codecs for unrecognized codec names.
535TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800536 using webrtc::H264::ProfileLevelIdToString;
537 using webrtc::H264::ProfileLevelId;
538 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200539 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
540 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800541 *ProfileLevelIdToString(
542 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200543 webrtc::SdpVideoFormat h264_constrained_high("H264");
544 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800545 *ProfileLevelIdToString(
546 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200547 webrtc::SdpVideoFormat h264_high("H264");
548 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800549 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
550
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200551 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
552 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
553 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700554
magjed725e4842016-11-16 00:48:13 -0800555 // First figure out what payload types the test codecs got assigned.
556 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800557 // Now search for RTX codecs for them. Expect that they all have associated
558 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800559 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200560 codecs,
561 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
562 ->id));
magjed725e4842016-11-16 00:48:13 -0800563 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200564 codecs,
565 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
566 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800567 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200568 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700569}
570
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100571#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700572TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200573 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100574
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200575 std::unique_ptr<VideoMediaChannel> channel(
576 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100577
578 EXPECT_TRUE(
579 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
580}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100581#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100582
eladalonf1841382017-06-12 01:16:46 -0700583TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200584 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100585 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200586 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200587 std::unique_ptr<VideoMediaChannel> channel(
588 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700589
590 EXPECT_TRUE(
591 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
592
Niels Möllerd0f0f682019-01-14 09:09:53 +0100593 webrtc::test::FrameForwarder frame_forwarder;
594 cricket::FakeFrameSource frame_source(1280, 720,
595 rtc::kNumMicrosecsPerSec / 60);
596 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700597 channel->SetSend(true);
598
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200599 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700600
Niels Möllerd0f0f682019-01-14 09:09:53 +0100601 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700602 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700603 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100604 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700605 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700606 int64_t interval = timestamp - last_timestamp;
607
608 // Precision changes from nanosecond to millisecond.
609 // Allow error to be no more than 1.
610 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
611
612 last_timestamp = timestamp;
613 }
614
Niels Möllerd0f0f682019-01-14 09:09:53 +0100615 frame_forwarder.IncomingCapturedFrame(
616 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
617 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700618 last_timestamp = stream->GetLastTimestamp();
619 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100620 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
621 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
622 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700623 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700624 int64_t interval = timestamp - last_timestamp;
625
626 // Precision changes from nanosecond to millisecond.
627 // Allow error to be no more than 1.
628 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
629
630 last_timestamp = timestamp;
631 }
632
633 // Remove stream previously added to free the external encoder instance.
634 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
635}
636
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200637void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
638 std::vector<VideoCodec> engine_codecs = engine_.codecs();
639 RTC_DCHECK(!engine_codecs.empty());
640 for (const cricket::VideoCodec& codec : engine_codecs) {
641 if (codec.name == "rtx") {
642 int associated_payload_type;
643 if (codec.GetParam(kCodecParamAssociatedPayloadType,
644 &associated_payload_type)) {
645 default_apt_rtx_types_[associated_payload_type] = codec.id;
646 }
647 }
648 }
649}
650
651void WebRtcVideoEngineTest::AssignDefaultCodec() {
652 std::vector<VideoCodec> engine_codecs = engine_.codecs();
653 RTC_DCHECK(!engine_codecs.empty());
654 bool codec_set = false;
655 for (const cricket::VideoCodec& codec : engine_codecs) {
656 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
657 codec.name != "ulpfec") {
658 default_codec_ = codec;
659 codec_set = true;
660 }
661 }
662
663 RTC_DCHECK(codec_set);
664}
665
Oleh Prypina40f8242017-12-21 13:32:23 +0100666size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
667 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100668 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
669 for (size_t i = 0; i < codecs.size(); ++i) {
670 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200671 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200672 continue;
673 // The tests only use H264 Constrained Baseline. Make sure we don't return
674 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200675 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200676 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200677 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
678 if (profile_level_id->profile !=
679 webrtc::H264::kProfileConstrainedBaseline) {
680 continue;
681 }
682 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100683 return i;
magjed509e4fe2016-11-18 01:34:11 -0800684 }
685 // This point should never be reached.
686 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100687 return -1;
688}
689
690cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
691 const std::string& name) const {
692 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800693}
694
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200695VideoMediaChannel*
696WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100697 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200698 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
699 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200700 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800701 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200702 for (const webrtc::SdpVideoFormat& format :
703 encoder_factory_->GetSupportedFormats()) {
704 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800705 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200706 parameters.codecs.push_back(engine_codec);
707 }
708 }
magjed509e4fe2016-11-18 01:34:11 -0800709
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200710 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000711
712 return channel;
713}
714
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200715VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000716 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100717 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200718 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
719 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200720 cricket::VideoRecvParameters parameters;
721 parameters.codecs = codecs;
722 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000723
724 return channel;
725}
726
Elad Alon157540a2019-02-08 23:37:52 +0100727void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
728 bool supported) const {
729 const RtpCapabilities capabilities = engine_.GetCapabilities();
730 if (supported) {
731 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200732 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100733 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200734 EXPECT_THAT(capabilities.header_extensions,
735 ::testing::Each(::testing::Field(&RtpExtension::uri,
736 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100737 }
738}
739
eladalonf1841382017-06-12 01:16:46 -0700740TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200741 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000742
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200743 std::unique_ptr<VideoMediaChannel> channel(
744 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000745
Peter Boström0c4e06b2015-10-07 12:23:21 +0200746 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000747
Yves Gerey665174f2018-06-19 15:03:05 +0200748 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000749 EXPECT_TRUE(channel->SetSend(true));
750
Niels Möller805a27e2019-01-21 12:21:27 +0100751 webrtc::test::FrameForwarder frame_forwarder;
752 cricket::FakeFrameSource frame_source(1280, 720,
753 rtc::kNumMicrosecsPerSec / 60);
754 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
755 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000756
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200757 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000758
759 // Verify that encoders are configured for simulcast through adapter
760 // (increasing resolution and only configured to send one stream each).
761 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200762 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
763 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000764 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200765 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000766 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
767 EXPECT_GT(codec_settings.width, prev_width);
768 prev_width = codec_settings.width;
769 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000770
Niels Möllerff40b142018-04-09 08:49:14 +0200771 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000772
773 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200774 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000775}
776
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200777TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
778 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200779 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000780
Niels Möllerd0f0f682019-01-14 09:09:53 +0100781 // Frame source.
782 webrtc::test::FrameForwarder frame_forwarder;
783 cricket::FakeFrameSource frame_source(1280, 720,
784 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200785
Sebastian Jansson84848f22018-11-16 10:40:36 +0100786 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200787 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
788 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200789 cricket::VideoSendParameters parameters;
790 parameters.codecs.push_back(GetEngineCodec("H264"));
791 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000792
793 EXPECT_TRUE(
794 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100795 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200796 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100797 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200798
799 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000800
Anders Carlsson67537952018-05-03 11:28:29 +0200801 cricket::VideoSendParameters new_parameters;
802 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
803 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200804
805 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100806 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200807
Anders Carlsson8a150d92018-05-14 12:40:04 +0200808 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000809}
810
eladalonf1841382017-06-12 01:16:46 -0700811TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000812 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200813 encoder_factory_->AddSupportedVideoCodecType("VP8");
814 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000815
Sebastian Jansson84848f22018-11-16 10:40:36 +0100816 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200817 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
818 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800819 cricket::VideoSendParameters parameters;
820 parameters.codecs.push_back(GetEngineCodec("VP8"));
821 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822
Peter Boström0c4e06b2015-10-07 12:23:21 +0200823 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824
Yves Gerey665174f2018-06-19 15:03:05 +0200825 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000826 EXPECT_TRUE(channel->SetSend(true));
827
828 // Send a fake frame, or else the media engine will configure the simulcast
829 // encoder adapter at a low-enough size that it'll only create a single
830 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100831 webrtc::test::FrameForwarder frame_forwarder;
832 cricket::FakeFrameSource frame_source(1280, 720,
833 rtc::kNumMicrosecsPerSec / 30);
834 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
835 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200837 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
838 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000839 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200840 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000841
842 channel.reset();
843 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200844 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000845}
846
eladalonf1841382017-06-12 01:16:46 -0700847TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000848 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200849 encoder_factory_->AddSupportedVideoCodecType("VP8");
850 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000851
Sebastian Jansson84848f22018-11-16 10:40:36 +0100852 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200853 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
854 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800855 cricket::VideoSendParameters parameters;
856 parameters.codecs.push_back(GetEngineCodec("H264"));
857 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000858
859 EXPECT_TRUE(
860 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100861
862 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100863 webrtc::test::FrameForwarder frame_forwarder;
864 cricket::FakeFrameSource frame_source(1280, 720,
865 rtc::kNumMicrosecsPerSec / 30);
866 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
867 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200868 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
869 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200870 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000871 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200872 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000873
874 channel.reset();
875 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200876 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000877}
878
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200879TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200880 RTC_DCHECK(!override_field_trials_);
881 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200882 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200883 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700884
Sebastian Jansson84848f22018-11-16 10:40:36 +0100885 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200886 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
887 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200888 cricket::VideoSendParameters parameters;
889 parameters.codecs.push_back(GetEngineCodec("H264"));
890 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700891
Peter Boström0c4e06b2015-10-07 12:23:21 +0200892 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700893 EXPECT_TRUE(
894 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100895
896 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100897 webrtc::test::FrameForwarder frame_forwarder;
898 cricket::FakeFrameSource frame_source(1280, 720,
899 rtc::kNumMicrosecsPerSec / 30);
900 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
901 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100902
Niels Möller4db138e2018-04-19 09:04:13 +0200903 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200904 ASSERT_EQ(1u, encoder_factory_->encoders().size());
905 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
906 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700907 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200908 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200909 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700910}
911
brandtrffc61182016-11-28 06:02:22 -0800912// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700913// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800914//
915// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700916TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800917 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200918 encoder_factory_->AddSupportedVideoCodecType("VP8");
919
Steve Anton2c9ebef2019-01-28 17:27:58 -0800920 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800921
922 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800923 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800924
925 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200926 RTC_DCHECK(!override_field_trials_);
927 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800928 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800929 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800930}
931
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200932// Test that codecs are added in the order they are reported from the factory.
933TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
934 encoder_factory_->AddSupportedVideoCodecType("VP8");
935 const char* kFakeCodecName = "FakeCodec";
936 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000937
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200938 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100939 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200940 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
941 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000942}
943
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200944// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800945// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200946TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100947 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
948 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100949
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100950 // Set up external encoder factory with first codec, and initialize engine.
951 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
952
brandtrffc61182016-11-28 06:02:22 -0800953 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800954
955 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100956 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800957 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200958 // The codec itself and RTX should have been added.
959 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100960
961 // Check that both fake codecs are present and that the second fake codec
962 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100963 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
964 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100965 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800966}
967
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200968TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
969 const char* kFakeCodecName = "FakeCodec";
970 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
971
972 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
973 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
974}
975
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200976TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
977 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200978 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200979 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800980 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000981
kwiberg686a8ef2016-02-26 03:00:35 -0800982 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200983 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000984
985 EXPECT_TRUE(
986 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200987 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000988
989 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200990 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200991 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000992
993 // Remove stream previously added to free the external decoder instance.
994 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200995 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000996}
997
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200998// Verifies that we can set up decoders.
999TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001000 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1001 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1002 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1003 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001004 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001005 webrtc::SdpVideoFormat supported_h264("H264");
1006 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1007 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001008 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001009 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010
kwiberg686a8ef2016-02-26 03:00:35 -08001011 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001012 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001013
1014 EXPECT_TRUE(
1015 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001016 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001017}
1018
Jonas Oreland49ac5952018-09-26 16:04:32 +02001019// Tests when GetSources is called with non-existing ssrc, it will return an
1020// empty list of RtpSource without crashing.
1021TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1022 // Setup an recv stream with |kSsrc|.
1023 encoder_factory_->AddSupportedVideoCodecType("VP8");
1024 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1025 cricket::VideoRecvParameters parameters;
1026 parameters.codecs.push_back(GetEngineCodec("VP8"));
1027 std::unique_ptr<VideoMediaChannel> channel(
1028 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1029
1030 EXPECT_TRUE(
1031 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1032
1033 // Call GetSources with |kSsrc + 1| which doesn't exist.
1034 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1035 EXPECT_EQ(0u, sources.size());
1036}
1037
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001038TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1039 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1040 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1041 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001042 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001043 EXPECT_EQ(0u, engine.codecs().size());
1044}
1045
1046TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1047 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001048 webrtc::MockVideoEncoderFactory* encoder_factory =
1049 new webrtc::MockVideoEncoderFactory();
1050 webrtc::MockVideoDecoderFactory* decoder_factory =
1051 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001052 WebRtcVideoEngine engine(
1053 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001054 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001055 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1056 EXPECT_EQ(0u, engine.codecs().size());
1057 EXPECT_CALL(*encoder_factory, Die());
1058 EXPECT_CALL(*decoder_factory, Die());
1059}
1060
1061// Test full behavior in the video engine when video codec factories of the new
1062// type are injected supporting the single codec Vp8. Check the returned codecs
1063// from the engine and that we will create a Vp8 encoder and decoder using the
1064// new factories.
1065TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1066 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001067 webrtc::MockVideoEncoderFactory* encoder_factory =
1068 new webrtc::MockVideoEncoderFactory();
1069 webrtc::MockVideoDecoderFactory* decoder_factory =
1070 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001071 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1072 rate_allocator_factory =
1073 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001074 EXPECT_CALL(*rate_allocator_factory,
1075 CreateVideoBitrateAllocatorProxy(Field(
1076 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001077 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001078 WebRtcVideoEngine engine(
1079 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001080 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001081 const webrtc::SdpVideoFormat vp8_format("VP8");
1082 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1083 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001084 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001085
1086 // Verify the codecs from the engine.
1087 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001088 // Verify default codecs has been added correctly.
1089 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001090 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001091
1092 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001093 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001094 int vp8_associated_payload;
1095 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1096 &vp8_associated_payload));
1097 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1098
1099 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1100
1101 // RTX codec for RED.
1102 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1103 int red_associated_payload;
1104 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1105 &red_associated_payload));
1106 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1107
1108 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1109
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001110 int associated_payload_type;
1111 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1112 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1113 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1114 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001115 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1116 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001117
1118 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001119 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1120 codec_info.is_hardware_accelerated = false;
1121 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001122 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001123 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001124 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001125 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001126 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001128 .WillOnce(
1129 ::testing::DoAll(::testing::InvokeWithoutArgs(
1130 [&encoder_created]() { encoder_created.Set(); }),
1131 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001132
1133 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001134 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001135 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001136 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137
1138 // Create a call.
1139 webrtc::RtcEventLogNullImpl event_log;
1140 std::unique_ptr<webrtc::Call> call(
1141 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1142
1143 // Create send channel.
1144 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001145 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001146 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1147 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001148 cricket::VideoSendParameters send_parameters;
1149 send_parameters.codecs.push_back(engine_codecs.at(0));
1150 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1151 send_channel->OnReadyToSend(true);
1152 EXPECT_TRUE(
1153 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1154 EXPECT_TRUE(send_channel->SetSend(true));
1155
Niels Möller4db138e2018-04-19 09:04:13 +02001156 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001157 webrtc::test::FrameForwarder frame_forwarder;
1158 cricket::FakeFrameSource frame_source(1280, 720,
1159 rtc::kNumMicrosecsPerSec / 30);
1160 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001161 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001162 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001163 encoder_created.Wait(kTimeout);
1164
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001165 // Create recv channel.
1166 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001167 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001168 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1169 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001170 cricket::VideoRecvParameters recv_parameters;
1171 recv_parameters.codecs.push_back(engine_codecs.at(0));
1172 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1173 EXPECT_TRUE(recv_channel->AddRecvStream(
1174 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1175
1176 // Remove streams previously added to free the encoder and decoder instance.
1177 EXPECT_CALL(*encoder_factory, Die());
1178 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001179 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001180 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1181 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1182}
1183
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001184// Test behavior when decoder factory fails to create a decoder (returns null).
1185TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1186 // |engine| take ownership of the factories.
1187 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001188 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001189 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001190 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001191 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1192 rate_allocator_factory =
1193 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001194 WebRtcVideoEngine engine(
1195 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001196 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001197 const webrtc::SdpVideoFormat vp8_format("VP8");
1198 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1199 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001200 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001201
1202 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001203 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1204 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001205
1206 // Create a call.
1207 webrtc::RtcEventLogNullImpl event_log;
1208 std::unique_ptr<webrtc::Call> call(
1209 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1210
1211 // Create recv channel.
1212 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001213 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001214 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1215 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001216 cricket::VideoRecvParameters recv_parameters;
1217 recv_parameters.codecs.push_back(engine.codecs().front());
1218 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1219 EXPECT_TRUE(recv_channel->AddRecvStream(
1220 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1221
1222 // Remove streams previously added to free the encoder and decoder instance.
1223 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1224}
1225
eladalonf1841382017-06-12 01:16:46 -07001226TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001227 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001228 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001229 std::unique_ptr<VideoMediaChannel> channel(
1230 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001231 ASSERT_TRUE(
1232 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1233 cricket::VideoCodec codec = GetEngineCodec("VP8");
1234 cricket::VideoSendParameters parameters;
1235 parameters.codecs.push_back(codec);
1236 channel->OnReadyToSend(true);
1237 channel->SetSend(true);
1238 ASSERT_TRUE(channel->SetSendParameters(parameters));
1239
Niels Möller805a27e2019-01-21 12:21:27 +01001240 webrtc::test::FrameForwarder frame_forwarder;
1241 cricket::FakeFrameSource frame_source(1280, 720,
1242 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001243 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001244 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001245
Niels Möller805a27e2019-01-21 12:21:27 +01001246 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001247 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001248 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001249 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001250
Niels Möller805a27e2019-01-21 12:21:27 +01001251 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1252 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001253 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001254 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001255
1256 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001257 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1258 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001259 // Change to screen content, recreate encoder. For the simulcast encoder
1260 // adapter case, this will result in two calls since InitEncode triggers a
1261 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001262 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001263 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001264 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001265
Niels Möller805a27e2019-01-21 12:21:27 +01001266 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1267 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001268 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001269 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001270
1271 options.is_screencast.emplace(false);
1272 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001273 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001274 // Change back to regular video content, update encoder. Also change
1275 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001276 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001277 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001278 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001279 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001280
1281 // Remove stream previously added to free the external encoder instance.
1282 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001283 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001284}
1285
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001286class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001287 protected:
1288 WebRtcVideoChannelBaseTest()
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001289 : video_bitrate_allocator_factory_(
1290 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1291 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1292 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001293
1294 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001295 // One testcase calls SetUp in a loop, only create call_ once.
1296 if (!call_) {
1297 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1298 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001299 cricket::MediaConfig media_config;
1300 // Disabling cpu overuse detection actually disables quality scaling too; it
1301 // implies DegradationPreference kMaintainResolution. Automatic scaling
1302 // needs to be disabled, otherwise, tests which check the size of received
1303 // frames become flaky.
1304 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001305 channel_.reset(
1306 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1307 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001308 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001309 channel_->OnReadyToSend(true);
1310 EXPECT_TRUE(channel_.get() != NULL);
1311 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001312 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001313 cricket::VideoRecvParameters parameters;
1314 parameters.codecs = engine_.codecs();
1315 channel_->SetRecvParameters(parameters);
1316 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001317 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1318 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1319 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1320 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001321 }
1322
1323 // Utility method to setup an additional stream to send and receive video.
1324 // Used to test send and recv between two streams.
1325 void SetUpSecondStream() {
1326 SetUpSecondStreamWithNoRecv();
1327 // Setup recv for second stream.
1328 EXPECT_TRUE(channel_->AddRecvStream(
1329 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1330 // Make the second renderer available for use by a new stream.
1331 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1332 }
1333 // Setup an additional stream just to send video. Defer add recv stream.
1334 // This is required if you want to test unsignalled recv of video rtp packets.
1335 void SetUpSecondStreamWithNoRecv() {
1336 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001337 EXPECT_TRUE(
1338 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001339 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001340 EXPECT_FALSE(
1341 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 EXPECT_TRUE(channel_->AddSendStream(
1343 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1344 // We dont add recv for the second stream.
1345
1346 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001347 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001348 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001349 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001350 }
Yves Gerey665174f2018-06-19 15:03:05 +02001351 virtual void TearDown() { channel_.reset(); }
1352 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001353
1354 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001355 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1356 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001357
1358 bool sending = channel_->sending();
1359 bool success = SetSend(false);
1360 if (success) {
1361 cricket::VideoSendParameters parameters;
1362 parameters.codecs.push_back(codec);
1363 success = channel_->SetSendParameters(parameters);
1364 }
1365 if (success) {
1366 success = SetSend(sending);
1367 }
1368 return success;
1369 }
Yves Gerey665174f2018-06-19 15:03:05 +02001370 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001371 void SendFrame() {
1372 if (frame_forwarder_2_) {
1373 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001374 }
Niels Möller805a27e2019-01-21 12:21:27 +01001375 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001376 }
1377 bool WaitAndSendFrame(int wait_ms) {
1378 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001379 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001380 return ret;
1381 }
Yves Gerey665174f2018-06-19 15:03:05 +02001382 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001383 int NumRtpBytes(uint32_t ssrc) {
1384 return network_interface_.NumRtpBytes(ssrc);
1385 }
Yves Gerey665174f2018-06-19 15:03:05 +02001386 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001387 int NumRtpPackets(uint32_t ssrc) {
1388 return network_interface_.NumRtpPackets(ssrc);
1389 }
Yves Gerey665174f2018-06-19 15:03:05 +02001390 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1392 return network_interface_.GetRtpPacket(index);
1393 }
1394 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001395 webrtc::RTPHeader header;
1396 EXPECT_TRUE(ParseRtpPacket(p, &header));
1397 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001398 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001399
Niels Möller6557d0c2018-04-11 15:18:34 +02001400 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001401 webrtc::RTPHeader* header) {
1402 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1403 webrtc::RtpHeaderParser::Create());
1404 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001405 }
1406
1407 // Tests that we can send and receive frames.
1408 void SendAndReceive(const cricket::VideoCodec& codec) {
1409 EXPECT_TRUE(SetOneCodec(codec));
1410 EXPECT_TRUE(SetSend(true));
1411 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1412 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001413 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001414 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1415 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1416 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1417 }
1418
1419 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001420 int duration_sec,
1421 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001422 EXPECT_TRUE(SetOneCodec(codec));
1423 EXPECT_TRUE(SetSend(true));
1424 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1425 EXPECT_EQ(0, renderer_.num_rendered_frames());
1426 for (int i = 0; i < duration_sec; ++i) {
1427 for (int frame = 1; frame <= fps; ++frame) {
1428 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1429 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1430 }
1431 }
1432 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1433 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1434 }
1435
Niels Möller6557d0c2018-04-11 15:18:34 +02001436 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1437 cricket::VideoMediaInfo info;
1438 EXPECT_TRUE(channel_->GetStats(&info));
1439 return info.senders[i];
1440 }
1441
1442 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1443 cricket::VideoMediaInfo info;
1444 EXPECT_TRUE(channel_->GetStats(&info));
1445 return info.receivers[i];
1446 }
1447
1448 // Two streams one channel tests.
1449
1450 // Tests that we can send and receive frames.
1451 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1452 SetUpSecondStream();
1453 // Test sending and receiving on first stream.
1454 SendAndReceive(codec);
1455 // Test sending and receiving on second stream.
1456 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1457 EXPECT_GT(NumRtpPackets(), 0);
1458 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1459 }
1460
1461 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1462 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001463 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001464 return engine_codec;
1465 }
1466 // This point should never be reached.
1467 ADD_FAILURE() << "Unrecognized codec name: " << name;
1468 return cricket::VideoCodec();
1469 }
1470
1471 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1472
1473 cricket::StreamParams DefaultSendStreamParams() {
1474 return cricket::StreamParams::CreateLegacy(kSsrc);
1475 }
1476
1477 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001478 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001479 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1480 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001481 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001482
1483 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1484 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1485 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1486
Niels Möller6557d0c2018-04-11 15:18:34 +02001487 std::unique_ptr<WebRtcVideoChannel> channel_;
1488 cricket::FakeNetworkInterface network_interface_;
1489 cricket::FakeVideoRenderer renderer_;
1490
1491 // Used by test cases where 2 streams are run on the same channel.
1492 cricket::FakeVideoRenderer renderer2_;
1493};
1494
1495// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001496TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001497 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001498 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001499 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1500 EXPECT_FALSE(channel_->sending());
1501 EXPECT_TRUE(SetSend(true));
1502 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001503 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001504 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1505 EXPECT_TRUE(SetSend(false));
1506 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001507}
Niels Möller6557d0c2018-04-11 15:18:34 +02001508
1509// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001510TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001511 EXPECT_FALSE(channel_->sending());
1512 EXPECT_FALSE(SetSend(true));
1513 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001514}
Niels Möller6557d0c2018-04-11 15:18:34 +02001515
1516// Test that we properly set the send and recv buffer sizes by the time
1517// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001518TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001519 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1520 EXPECT_TRUE(SetSend(true));
1521 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001522 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001523}
1524
Johannes Kron5a0665b2019-04-08 10:35:50 +02001525// Test that we properly set the send and recv buffer sizes when overriding
1526// via field trials.
1527TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1528 // Set field trial to override the default recv buffer size, and then re-run
1529 // setup where the interface is created and configured.
1530 const int kCustomRecvBufferSize = 123456;
1531 webrtc::test::ScopedFieldTrials field_trial(
1532 "WebRTC-IncreasedReceivebuffers/123456/");
1533 SetUp();
1534
1535 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1536 EXPECT_TRUE(SetSend(true));
1537 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1538 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1539}
1540
1541// Test that we properly set the send and recv buffer sizes when overriding
1542// via field trials with suffix.
1543TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1544 // Set field trial to override the default recv buffer size, and then re-run
1545 // setup where the interface is created and configured.
1546 const int kCustomRecvBufferSize = 123456;
1547 webrtc::test::ScopedFieldTrials field_trial(
1548 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1549 SetUp();
1550
1551 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1552 EXPECT_TRUE(SetSend(true));
1553 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1554 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1555}
1556
1557// Test that we properly set the send and recv buffer sizes when overriding
1558// via field trials that don't make any sense.
1559TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1560 // Set bogus field trial values to override the default recv buffer size, and
1561 // then re-run setup where the interface is created and configured. The
1562 // default value should still be used.
1563
1564 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1565 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1566 field_trial_string += group;
1567 field_trial_string += "/";
1568 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1569 SetUp();
1570
1571 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1572 EXPECT_TRUE(SetSend(true));
1573 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1574 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1575 }
1576}
1577
Niels Möller6557d0c2018-04-11 15:18:34 +02001578// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001579TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001580 const int kDurationSec = 3;
1581 const int kFps = 10;
1582 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1583
1584 cricket::VideoMediaInfo info;
1585 EXPECT_TRUE(channel_->GetStats(&info));
1586
1587 ASSERT_EQ(1U, info.senders.size());
1588 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1589 // For webrtc, bytes_sent does not include the RTP header length.
1590 EXPECT_GT(info.senders[0].bytes_sent, 0);
1591 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1592 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1593 ASSERT_TRUE(info.senders[0].codec_payload_type);
1594 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1595 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1596 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1597 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1598 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1599 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1600 EXPECT_GT(info.senders[0].framerate_input, 0);
1601 EXPECT_GT(info.senders[0].framerate_sent, 0);
1602
1603 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1604 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1605 info.send_codecs[DefaultCodec().id]);
1606
1607 ASSERT_EQ(1U, info.receivers.size());
1608 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1609 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1610 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1611 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1612 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1613 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1614 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001615 EXPECT_EQ(0, info.receivers[0].packets_lost);
1616 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1617 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1618 EXPECT_EQ(0, info.receivers[0].firs_sent);
1619 EXPECT_EQ(0, info.receivers[0].plis_sent);
1620 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1621 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1622 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1623 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1624 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1625 EXPECT_GT(info.receivers[0].framerate_output, 0);
1626
1627 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1628 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1629 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001630}
Niels Möller6557d0c2018-04-11 15:18:34 +02001631
1632// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001633TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001634 cricket::FakeVideoRenderer renderer1, renderer2;
1635 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1636 cricket::VideoSendParameters parameters;
1637 parameters.codecs.push_back(DefaultCodec());
1638 parameters.conference_mode = true;
1639 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1640 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001641 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1642 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001643 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1644 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1645 EXPECT_EQ(0, renderer1.num_rendered_frames());
1646 EXPECT_EQ(0, renderer2.num_rendered_frames());
1647 std::vector<uint32_t> ssrcs;
1648 ssrcs.push_back(1);
1649 ssrcs.push_back(2);
1650 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001651 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001652 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1653 kTimeout);
1654 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1655 kTimeout);
1656
1657 EXPECT_TRUE(channel_->SetSend(false));
1658
1659 cricket::VideoMediaInfo info;
1660 EXPECT_TRUE(channel_->GetStats(&info));
1661 ASSERT_EQ(1U, info.senders.size());
1662 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1663 // For webrtc, bytes_sent does not include the RTP header length.
1664 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1665 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1666 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1667 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1668
1669 ASSERT_EQ(2U, info.receivers.size());
1670 for (size_t i = 0; i < info.receivers.size(); ++i) {
1671 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1672 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1673 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001674 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001675 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1676 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1677 }
srtee0c2eea2017-12-15 17:44:33 +01001678}
Niels Möller6557d0c2018-04-11 15:18:34 +02001679
1680// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001681TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001682 // Normal setup; note that we set the SSRC explicitly to ensure that
1683 // it will come first in the senders map.
1684 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1685 cricket::VideoSendParameters parameters;
1686 parameters.codecs.push_back(DefaultCodec());
1687 parameters.conference_mode = true;
1688 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001689 EXPECT_TRUE(
1690 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001691 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1692 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001693 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1695 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1696
1697 // Add an additional capturer, and hook up a renderer to receive it.
1698 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001699 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 const int kTestWidth = 160;
1701 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001702 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1703 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_TRUE(
1705 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001706 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001707 EXPECT_TRUE(
1708 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001709 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001710 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001711 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1712 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001713
1714 // Get stats, and make sure they are correct for two senders. We wait until
1715 // the number of expected packets have been sent to avoid races where we
1716 // check stats before it has been updated.
1717 cricket::VideoMediaInfo info;
1718 for (uint32_t i = 0; i < kTimeout; ++i) {
1719 rtc::Thread::Current()->ProcessMessages(1);
1720 EXPECT_TRUE(channel_->GetStats(&info));
1721 ASSERT_EQ(2U, info.senders.size());
1722 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1723 NumRtpPackets()) {
1724 // Stats have been updated for both sent frames, expectations can be
1725 // checked now.
1726 break;
1727 }
1728 }
1729 EXPECT_EQ(NumRtpPackets(),
1730 info.senders[0].packets_sent + info.senders[1].packets_sent)
1731 << "Timed out while waiting for packet counts for all sent packets.";
1732 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1733 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1734 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1735 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1736 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1737 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1738 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1739 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1740 // The capturer must be unregistered here as it runs out of it's scope next.
1741 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001742}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001743
Niels Möller6557d0c2018-04-11 15:18:34 +02001744// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001745TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001746 cricket::VideoSendParameters parameters;
1747 parameters.codecs.push_back(DefaultCodec());
1748 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1749 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1750 parameters.max_bandwidth_bps = 128 * 1024;
1751 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001752}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001753
Niels Möller6557d0c2018-04-11 15:18:34 +02001754// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001755TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001756 EXPECT_TRUE(SetDefaultCodec());
1757 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001758 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001759 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001760 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001761 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001762 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1763 EXPECT_EQ(kSsrc, header.ssrc);
1764
Niels Möller6557d0c2018-04-11 15:18:34 +02001765 // Packets are being paced out, so these can mismatch between the first and
1766 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001767 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1768 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 EXPECT_EQ(1, NumSentSsrcs());
1770 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1771 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001772}
Niels Möller6557d0c2018-04-11 15:18:34 +02001773
1774// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001775TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 // Remove stream added in Setup.
1777 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1778 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001779 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001780 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001781 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001782 EXPECT_TRUE(SetSend(true));
1783 EXPECT_TRUE(WaitAndSendFrame(0));
1784 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001785 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001787 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1788 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 // Packets are being paced out, so these can mismatch between the first and
1790 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001791 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1792 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001793 EXPECT_EQ(1, NumSentSsrcs());
1794 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1795 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001796}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001797
Niels Möller6557d0c2018-04-11 15:18:34 +02001798// Test that we can set the default video renderer before and after
1799// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001800TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001801 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1802 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001803
1804 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1805 rtc::SetBE32(packet1.data() + 8, kSsrc);
1806 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1807 EXPECT_TRUE(SetDefaultCodec());
1808 EXPECT_TRUE(SetSend(true));
1809 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001810 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001811 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001812 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001813 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001814}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001815
Niels Möller6557d0c2018-04-11 15:18:34 +02001816// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001817TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001818 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1819 EXPECT_TRUE(SetSend(true));
1820 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001821 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001822 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1823 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001824 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001825 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001826 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1827 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001828 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1829 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001830
1831 // Remove the send stream that was added during Setup.
1832 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1833 int rtp_packets = NumRtpPackets();
1834
Niels Möller6557d0c2018-04-11 15:18:34 +02001835 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001836 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001837 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001838 EXPECT_EQ(rtp_packets, NumRtpPackets());
1839 // Wait 30ms to guarantee the engine does not drop the frame.
1840 EXPECT_TRUE(WaitAndSendFrame(30));
1841 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1842
1843 last_packet = NumRtpPackets() - 1;
1844 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001845 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1846 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001847}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001848
Niels Möller6557d0c2018-04-11 15:18:34 +02001849// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001850TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001851 cricket::FakeVideoRenderer renderer1, renderer2;
1852 EXPECT_TRUE(SetDefaultCodec());
1853 cricket::VideoSendParameters parameters;
1854 parameters.codecs.push_back(DefaultCodec());
1855 parameters.conference_mode = true;
1856 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1857 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001858 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1859 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001860 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1861 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1862 EXPECT_EQ(0, renderer1.num_rendered_frames());
1863 EXPECT_EQ(0, renderer2.num_rendered_frames());
1864 std::vector<uint32_t> ssrcs;
1865 ssrcs.push_back(1);
1866 ssrcs.push_back(2);
1867 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001868 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001869 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1870 kTimeout);
1871 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1872 kTimeout);
1873
1874 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1875 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1876 EXPECT_EQ(kVideoWidth, renderer1.width());
1877 EXPECT_EQ(kVideoHeight, renderer1.height());
1878 EXPECT_EQ(kVideoWidth, renderer2.width());
1879 EXPECT_EQ(kVideoHeight, renderer2.height());
1880 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1881 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001882}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001883
Niels Möller6557d0c2018-04-11 15:18:34 +02001884// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001885TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001886 using cricket::VideoCodec;
1887 using cricket::VideoOptions;
1888 using cricket::VideoFormat;
1889 using cricket::FOURCC_I420;
1890
1891 VideoCodec codec = DefaultCodec();
1892 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1893 EXPECT_TRUE(SetOneCodec(codec));
1894 EXPECT_TRUE(SetSend(true));
1895 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1896 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001897 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001898 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001899
1900 webrtc::test::FrameForwarder frame_forwarder;
1901 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1902 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001903
1904 // TODO(nisse): This testcase fails if we don't configure
1905 // screencast. It's unclear why, I see nothing obvious in this
1906 // test which is related to screencast logic.
1907 VideoOptions video_options;
1908 video_options.is_screencast = true;
1909 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1910
Niels Möller6557d0c2018-04-11 15:18:34 +02001911 int captured_frames = 1;
1912 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001913 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001914 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001915 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1916
Niels Möller6557d0c2018-04-11 15:18:34 +02001917 ++captured_frames;
1918 // Wait until frame of right size is captured.
1919 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001920 480 == renderer_.width() &&
1921 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001922 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001924 EXPECT_EQ(480, renderer_.width());
1925 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001926 captured_frames = renderer_.num_rendered_frames() + 1;
1927 EXPECT_FALSE(renderer_.black_frame());
1928 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1929 // Make sure a black frame is generated within the specified timeout.
1930 // The black frame should be the resolution of the previous frame to
1931 // prevent expensive encoder reconfigurations.
1932 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001933 480 == renderer_.width() &&
1934 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001935 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001936 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001937 EXPECT_EQ(480, renderer_.width());
1938 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001939 EXPECT_TRUE(renderer_.black_frame());
1940
1941 // The black frame has the same timestamp as the next frame since it's
1942 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1943 // not render a frame with the same timestamp so capture another frame
1944 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001945 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001946 }
srtee0c2eea2017-12-15 17:44:33 +01001947}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001948
Niels Möller6557d0c2018-04-11 15:18:34 +02001949// Tests that if SetVideoSend is called with a NULL capturer after the
1950// capturer was already removed, the application doesn't crash (and no black
1951// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001952TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001953 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1954 EXPECT_TRUE(SetSend(true));
1955 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1956 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001957 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1959 // Wait for one frame so they don't get dropped because we send frames too
1960 // tightly.
1961 rtc::Thread::Current()->ProcessMessages(30);
1962 // Remove the capturer.
1963 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1964
1965 // No capturer was added, so this SetVideoSend shouldn't do anything.
1966 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1967 rtc::Thread::Current()->ProcessMessages(300);
1968 // Verify no more frames were sent.
1969 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001970}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001971
Niels Möller6557d0c2018-04-11 15:18:34 +02001972// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001973TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001974 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1975 // interval time to avoid that.
1976 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1977 // interval time to avoid that.
1978 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001979 EXPECT_TRUE(
1980 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001981 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1982 cricket::VideoFormat capture_format(
1983 kVideoWidth, kVideoHeight,
1984 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1985 // Set up additional stream 1.
1986 cricket::FakeVideoRenderer renderer1;
1987 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001988 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001989 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001990 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001991
1992 webrtc::test::FrameForwarder frame_forwarder1;
1993 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1994 rtc::kNumMicrosecsPerSec / kFramerate);
1995
Niels Möller6557d0c2018-04-11 15:18:34 +02001996 // Set up additional stream 2.
1997 cricket::FakeVideoRenderer renderer2;
1998 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001999 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002000 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002001 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002002 webrtc::test::FrameForwarder frame_forwarder2;
2003
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 // State for all the streams.
2005 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2006 // A limitation in the lmi implementation requires that SetVideoSend() is
2007 // called after SetOneCodec().
2008 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002009 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2010 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 EXPECT_TRUE(SetSend(true));
2012 // Test capturer associated with engine.
2013 const int kTestWidth = 160;
2014 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002015 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2016 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2017 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002018 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2019 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002020 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002021 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2022 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2023 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002024 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2025 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 // Successfully remove the capturer.
2027 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2028 // The capturers must be unregistered here as it runs out of it's scope
2029 // next.
2030 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2031 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002032}
Niels Möller6557d0c2018-04-11 15:18:34 +02002033
2034// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002035TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002036 // Remove the send stream that was added during Setup.
2037 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2038
2039 cricket::StreamParams empty;
2040 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002041 EXPECT_TRUE(
2042 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002043}
Niels Möller6557d0c2018-04-11 15:18:34 +02002044
2045// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002046TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002047 // Remove stream added in Setup. I.e. remove stream corresponding to default
2048 // channel.
2049 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002050 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002051 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2052 EXPECT_TRUE(channel_->AddSendStream(
2053 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2054 }
2055 // Delete one of the non default channel streams, let the destructor delete
2056 // the remaining ones.
2057 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2058 // Stream should already be deleted.
2059 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002060}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002061
eladalonf1841382017-06-12 01:16:46 -07002062TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002063 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002064}
2065
eladalonf1841382017-06-12 01:16:46 -07002066TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002067 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002068}
2069
eladalonf1841382017-06-12 01:16:46 -07002070TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002071 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002072}
2073
eladalonf1841382017-06-12 01:16:46 -07002074TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002075 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2076 // bitrates. This currently happens at <250k, and two streams sharing 300k
2077 // initially will use QVGA instead of VGA.
2078 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2079 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002080 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002081 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002082 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002083}
2084
eladalonf1841382017-06-12 01:16:46 -07002085class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002086 public:
eladalonf1841382017-06-12 01:16:46 -07002087 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2088 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002089 : WebRtcVideoEngineTest(field_trials),
2090 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2091 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002092 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002093 encoder_factory_->AddSupportedVideoCodecType("VP8");
2094 encoder_factory_->AddSupportedVideoCodecType("VP9");
2095#if defined(WEBRTC_USE_H264)
2096 encoder_factory_->AddSupportedVideoCodecType("H264");
2097#endif
2098
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002099 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002100 channel_.reset(engine_.CreateMediaChannel(
2101 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2102 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002103 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002104 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002105 send_parameters_.codecs = engine_.codecs();
2106 recv_parameters_.codecs = engine_.codecs();
2107 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002108 }
2109
2110 protected:
2111 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002112 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002113 }
2114
2115 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002116 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002117 EXPECT_TRUE(channel_->AddSendStream(sp));
2118 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002119 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002120 EXPECT_EQ(num_streams + 1, streams.size());
2121 return streams[streams.size() - 1];
2122 }
2123
2124 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002125 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002126 }
2127
2128 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002129 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002130 }
2131
2132 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002133 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002134 EXPECT_TRUE(channel_->AddRecvStream(sp));
2135 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002136 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002137 EXPECT_EQ(num_streams + 1, streams.size());
2138 return streams[streams.size() - 1];
2139 }
2140
pbos@webrtc.org00873182014-11-25 14:03:34 +00002141 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2142 int expected_min_bitrate_bps,
2143 const char* start_bitrate_kbps,
2144 int expected_start_bitrate_bps,
2145 const char* max_bitrate_kbps,
2146 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002147 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2148 expected_start_bitrate_bps,
2149 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002150 auto& codecs = send_parameters_.codecs;
2151 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002152 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002153 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2154 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2155 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002156 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002157 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002158
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002159 void ExpectSetBitrateParameters(int min_bitrate_bps,
2160 int start_bitrate_bps,
2161 int max_bitrate_bps) {
2162 EXPECT_CALL(
2163 *fake_call_->GetMockTransportControllerSend(),
2164 SetSdpBitrateParameters(AllOf(
2165 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2166 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2167 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2168 }
2169
2170 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2171 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2172 SetSdpBitrateParameters(Field(
2173 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002174 }
2175
Johannes Kron9190b822018-10-29 11:22:05 +01002176 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2177 // For a caller, the answer will be applied in set remote description
2178 // where SetSendParameters() is called.
2179 EXPECT_TRUE(
2180 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2181 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2182 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2183 const webrtc::VideoSendStream::Config& config =
2184 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2185 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2186 }
2187
2188 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2189 // For a callee, the answer will be applied in set local description
2190 // where SetExtmapAllowMixed() and AddSendStream() are called.
2191 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2192 EXPECT_TRUE(
2193 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2194 const webrtc::VideoSendStream::Config& config =
2195 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2196 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2197 }
2198
isheriff6f8d6862016-05-26 11:24:55 -07002199 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002200 // Enable extension.
2201 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002202 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002203 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002204 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002205 FakeVideoSendStream* send_stream =
2206 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2207
2208 // Verify the send extension id.
2209 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2210 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002211 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002212 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002213 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002214 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2215 // receivers.
2216 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2217 ->GetConfig()
2218 .rtp.extensions.empty());
2219
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002220 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002221 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002222 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2223 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002224 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2225
2226 // Verify that adding receive RTP header extensions adds them for existing
2227 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002228 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002229 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002230 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2231 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002232 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002233 }
2234
isheriff6f8d6862016-05-26 11:24:55 -07002235 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002236 // Enable extension.
2237 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002238 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002239 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002240 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002241
2242 FakeVideoReceiveStream* recv_stream =
2243 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2244
2245 // Verify the recv extension id.
2246 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2247 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002248 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002249 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002250 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002251
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002252 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2253 // senders.
2254 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2255 ->GetConfig()
2256 .rtp.extensions.empty());
2257
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002258 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002259 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002260 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2261 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002262 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2263
2264 // Verify that adding receive RTP header extensions adds them for existing
2265 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002266 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002267 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002268 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2269 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002270 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002271 }
2272
Elad Alonfadb1812019-05-24 13:40:02 +02002273 void TestLossNotificationState(bool expect_lntf_enabled) {
2274 AssignDefaultCodec();
2275 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2276
2277 cricket::VideoSendParameters parameters;
2278 parameters.codecs = engine_.codecs();
2279 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2280 EXPECT_TRUE(channel_->SetSend(true));
2281
2282 // Send side.
2283 FakeVideoSendStream* send_stream =
2284 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2285 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2286
2287 // Receiver side.
2288 FakeVideoReceiveStream* recv_stream =
2289 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2290 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2291 }
2292
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002293 void TestExtensionFilter(const std::vector<std::string>& extensions,
2294 const std::string& expected_extension) {
2295 cricket::VideoSendParameters parameters = send_parameters_;
2296 int expected_id = -1;
2297 int id = 1;
2298 for (const std::string& extension : extensions) {
2299 if (extension == expected_extension)
2300 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002301 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002302 }
2303 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2304 FakeVideoSendStream* send_stream =
2305 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2306
2307 // Verify that only one of them has been set, and that it is the one with
2308 // highest priority (transport sequence number).
2309 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2310 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2311 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002312 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002313 }
2314
asapersson3c81a1a2017-06-14 05:52:21 -07002315 void TestDegradationPreference(bool resolution_scaling_enabled,
2316 bool fps_scaling_enabled);
2317
Erik Språngefbde372015-04-29 16:21:28 +02002318 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002319 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002320 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2321 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002322
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002323 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002324 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002325 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002326 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002327 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002328 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002329 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002330 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002331 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002332
Erik Språng143cec12015-04-28 10:01:41 +02002333 return fake_call_->GetVideoSendStreams().back();
2334 }
2335
Peter Boström2feafdb2015-09-09 14:32:14 +02002336 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2337 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002338 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002339 std::vector<uint32_t> ssrcs;
2340 std::vector<uint32_t> rtx_ssrcs;
2341 uint32_t num_streams = enabled ? 3 : 1;
2342 for (uint32_t i = 0; i < num_streams; ++i) {
2343 uint32_t ssrc = last_ssrc_ + i;
2344 ssrcs.push_back(ssrc);
2345 if (with_rtx) {
2346 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2347 }
Erik Språng143cec12015-04-28 10:01:41 +02002348 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002349 if (with_rtx) {
2350 return AddSendStream(
2351 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2352 }
2353 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002354 }
2355
perkjfa10b552016-10-02 23:45:26 -07002356 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002357 std::vector<FakeVideoSendStream*> streams =
2358 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002359 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002360 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002361 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002362 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002363 }
2364
perkjfa10b552016-10-02 23:45:26 -07002365 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002366 int stream_max,
2367 int expected_encoder_bitrate) {
2368 VideoSendParameters limited_send_params = send_parameters_;
2369 limited_send_params.max_bandwidth_bps = global_max;
2370 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002371 webrtc::RtpParameters parameters =
2372 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002373 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002374 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002375 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002376 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002377 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002378 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002379 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002380 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002381 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002382 }
2383
Åsa Persson55659812018-06-18 17:51:32 +02002384 // Values from kSimulcastConfigs in simulcast.cc.
2385 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2386 std::vector<webrtc::VideoStream> layers(3);
2387 layers[0].min_bitrate_bps = 30000;
2388 layers[0].target_bitrate_bps = 150000;
2389 layers[0].max_bitrate_bps = 200000;
2390 layers[1].min_bitrate_bps = 150000;
2391 layers[1].target_bitrate_bps = 500000;
2392 layers[1].max_bitrate_bps = 700000;
2393 layers[2].min_bitrate_bps = 600000;
2394 layers[2].target_bitrate_bps = 2500000;
2395 layers[2].max_bitrate_bps = 2500000;
2396 return layers;
2397 }
2398
Niels Möller805a27e2019-01-21 12:21:27 +01002399 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002400 std::unique_ptr<FakeCall> fake_call_;
2401 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002402 cricket::VideoSendParameters send_parameters_;
2403 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002404 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002405};
2406
eladalonf1841382017-06-12 01:16:46 -07002407TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002408 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002409 const std::string kSyncLabel = "AvSyncLabel";
2410
2411 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002412 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002413 EXPECT_TRUE(channel_->AddRecvStream(sp));
2414
Mirko Bonadeif859e552018-05-30 15:31:29 +02002415 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002416 EXPECT_EQ(kSyncLabel,
2417 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2418 << "SyncGroup should be set based on sync_label";
2419}
2420
eladalonf1841382017-06-12 01:16:46 -07002421TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002422 cricket::VideoSendParameters parameters;
2423 parameters.codecs = engine_.codecs();
2424 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002425 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002426 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002427 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002428
2429 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002430 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2431 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002432 FakeVideoSendStream* send_stream = AddSendStream(
2433 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2434
2435 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2436 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2437 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2438
2439 // Receiver side.
2440 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2441 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002442 EXPECT_FALSE(
2443 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002444 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002445 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002446 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002447 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002448 << "RTX should be mapped for the RED payload type";
2449
brandtr14742122017-01-27 04:53:07 -08002450 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002451}
2452
eladalonf1841382017-06-12 01:16:46 -07002453TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002454 // Setup one channel with an associated RTX stream.
2455 cricket::StreamParams params =
2456 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2457 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2458 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002459 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002460
2461 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2462 << "RTX should be mapped for all decoders/payload types.";
2463 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002464 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002465 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002466}
2467
eladalonf1841382017-06-12 01:16:46 -07002468TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002469 // Setup one channel without an associated RTX stream.
2470 cricket::StreamParams params =
2471 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2472 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002473 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002474}
2475
Johannes Kron9190b822018-10-29 11:22:05 +01002476// Test propagation of extmap allow mixed setting.
2477TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2478 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2479}
2480TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2481 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2482}
2483TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2484 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2485}
2486TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2487 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2488}
2489
eladalonf1841382017-06-12 01:16:46 -07002490TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002491 FakeVideoSendStream* send_stream =
2492 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2493 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2494
2495 FakeVideoReceiveStream* recv_stream =
2496 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2497 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002498}
2499
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002500// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002501TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002502 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002503}
isheriff6f8d6862016-05-26 11:24:55 -07002504
eladalonf1841382017-06-12 01:16:46 -07002505TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002506 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002507}
2508
2509// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002510TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002511 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002512}
isheriff6f8d6862016-05-26 11:24:55 -07002513
eladalonf1841382017-06-12 01:16:46 -07002514TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002515 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002516}
2517
eladalonf1841382017-06-12 01:16:46 -07002518TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002519 // Enable three redundant extensions.
2520 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002521 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2522 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2523 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2524 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002525}
2526
eladalonf1841382017-06-12 01:16:46 -07002527TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002528 // Enable two redundant extensions.
2529 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002530 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2531 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2532 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002533}
2534
stefanc1aeaf02015-10-15 07:26:07 -07002535// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002536TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002537 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002538}
eladalonf1841382017-06-12 01:16:46 -07002539TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002540 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002541}
2542
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002543// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002545 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002546}
eladalonf1841382017-06-12 01:16:46 -07002547TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002548 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002549}
2550
eladalonf1841382017-06-12 01:16:46 -07002551TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002552 const int kAbsSendTimeId = 1;
2553 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002554 send_parameters_.extensions.push_back(
2555 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2556 send_parameters_.extensions.push_back(
2557 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002558
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002559 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002560 FakeVideoSendStream* send_stream =
2561 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2562
2563 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002564 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002565
2566 // Setting the same extensions (even if in different order) shouldn't
2567 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002568 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002569 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002570
2571 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2572
2573 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002574 send_parameters_.extensions.resize(1);
2575 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002576
2577 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2578}
2579
eladalonf1841382017-06-12 01:16:46 -07002580TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002581 const int kTOffsetId = 1;
2582 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002583 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002584 recv_parameters_.extensions.push_back(
2585 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2586 recv_parameters_.extensions.push_back(
2587 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2588 recv_parameters_.extensions.push_back(
2589 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002590
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002591 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002592 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002593 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2594
2595 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002596 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002597
2598 // Setting the same extensions (even if in different order) shouldn't
2599 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002600 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002601 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002602
2603 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2604
2605 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002606 recv_parameters_.extensions.resize(1);
2607 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002608
2609 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2610}
2611
eladalonf1841382017-06-12 01:16:46 -07002612TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002613 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002614 const int kUnsupportedId = 1;
2615 const int kTOffsetId = 2;
2616
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002617 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002618 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002619 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002620 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002621 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002622 FakeVideoSendStream* send_stream =
2623 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2624
2625 // Only timestamp offset extension is set to send stream,
2626 // unsupported rtp extension is ignored.
2627 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002628 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2629 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002630}
2631
eladalonf1841382017-06-12 01:16:46 -07002632TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002633 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002634 const int kUnsupportedId = 1;
2635 const int kTOffsetId = 2;
2636
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002637 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002638 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002639 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002640 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002641 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002642 FakeVideoReceiveStream* recv_stream =
2643 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2644
2645 // Only timestamp offset extension is set to receive stream,
2646 // unsupported rtp extension is ignored.
2647 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002648 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2649 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002650}
2651
eladalonf1841382017-06-12 01:16:46 -07002652TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002653 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002654 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002655 send_parameters_.extensions.push_back(
2656 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002657 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002658 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2659 }
2660}
2661
eladalonf1841382017-06-12 01:16:46 -07002662TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002663 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002664 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002665 recv_parameters_.extensions.push_back(
2666 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002667 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002668 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2669 }
2670}
2671
eladalonf1841382017-06-12 01:16:46 -07002672TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002673 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002674 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002675 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002676 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002677 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002678 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002679
2680 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002681 send_parameters_.extensions.clear();
2682 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002683 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002684 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2685 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002686}
2687
eladalonf1841382017-06-12 01:16:46 -07002688TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002689 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002690 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002691 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002692 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002693 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002694 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002695
2696 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002697 recv_parameters_.extensions.clear();
2698 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002699 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002700 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2701 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002702}
2703
eladalonf1841382017-06-12 01:16:46 -07002704TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002705 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002706 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002707}
2708
eladalonf1841382017-06-12 01:16:46 -07002709TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002710 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002711 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002712}
2713
eladalonf1841382017-06-12 01:16:46 -07002714TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002715 FakeVideoReceiveStream* stream = AddRecvStream();
2716 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002717}
2718
eladalonf1841382017-06-12 01:16:46 -07002719TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002720 FakeVideoReceiveStream* stream = AddRecvStream();
2721 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2722}
2723
eladalonf1841382017-06-12 01:16:46 -07002724TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002725 FakeVideoReceiveStream* stream = AddRecvStream();
2726 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2727
Peter Boström126c03e2015-05-11 12:48:12 +02002728 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002729 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002730 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002731 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2732 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002733 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002734 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2735
2736 // Verify that REMB is turned on when setting default codecs since the
2737 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002738 parameters.codecs = engine_.codecs();
2739 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002740 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002741 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002742}
2743
eladalonf1841382017-06-12 01:16:46 -07002744TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002745 FakeVideoReceiveStream* stream = AddRecvStream();
2746 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2747
2748 // Verify that transport cc feedback is turned off when send(!) codecs without
2749 // transport cc feedback are set.
2750 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002751 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002752 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2753 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2754 stream = fake_call_->GetVideoReceiveStreams()[0];
2755 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2756
2757 // Verify that transport cc feedback is turned on when setting default codecs
2758 // since the default codecs have transport cc feedback enabled.
2759 parameters.codecs = engine_.codecs();
2760 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2761 stream = fake_call_->GetVideoReceiveStreams()[0];
2762 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2763}
2764
Elad Alonfadb1812019-05-24 13:40:02 +02002765TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2766 TestLossNotificationState(false);
2767}
2768
2769TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2770 RTC_DCHECK(!override_field_trials_);
2771 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2772 "WebRTC-RtcpLossNotification/Enabled/");
2773 SetUp();
2774 TestLossNotificationState(true);
2775}
2776
2777TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2778 RTC_DCHECK(!override_field_trials_);
2779 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2780 "WebRTC-RtcpLossNotification/Enabled/");
2781 SetUp();
2782
2783 AssignDefaultCodec();
2784 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2785
2786 {
2787 cricket::VideoSendParameters parameters;
2788 parameters.codecs = engine_.codecs();
2789 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2790 EXPECT_TRUE(channel_->SetSend(true));
2791 }
2792
2793 // Start with LNTF enabled.
2794 FakeVideoSendStream* send_stream =
2795 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2796 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2797 FakeVideoReceiveStream* recv_stream =
2798 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2799 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2800
2801 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2802 cricket::VideoSendParameters parameters;
2803 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2804 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2805 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2806 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2807 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2808 send_stream = fake_call_->GetVideoSendStreams()[0];
2809 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2810
2811 // Setting the default codecs again, including VP8, turns LNTF back on.
2812 parameters.codecs = engine_.codecs();
2813 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2814 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2815 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2816 send_stream = fake_call_->GetVideoSendStreams()[0];
2817 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2818}
2819
eladalonf1841382017-06-12 01:16:46 -07002820TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002821 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002822 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002823
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002824 cricket::VideoSendParameters parameters;
2825 parameters.codecs = engine_.codecs();
2826 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002827 EXPECT_TRUE(channel_->SetSend(true));
2828
2829 // Send side.
2830 FakeVideoSendStream* send_stream =
2831 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2832 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2833
2834 // Receiver side.
2835 FakeVideoReceiveStream* recv_stream =
2836 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2837 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2838
2839 // Nack history size should match between sender and receiver.
2840 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2841 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002842}
2843
eladalonf1841382017-06-12 01:16:46 -07002844TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002845 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002846 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002847
2848 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2849 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2850
2851 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002852 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002853 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002854 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2855 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002856 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2857 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2858 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002859 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2860
Peter Boström67c9df72015-05-11 14:34:58 +02002861 // Verify that NACK is turned on when setting default codecs since the
2862 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002863 parameters.codecs = engine_.codecs();
2864 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002865 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2866 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2867 send_stream = fake_call_->GetVideoSendStreams()[0];
2868 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002869}
2870
Peter Boströme7ba0862016-03-12 00:02:28 +01002871// This test verifies that new frame sizes reconfigures encoders even though not
2872// (yet) sending. The purpose of this is to permit encoding as quickly as
2873// possible once we start sending. Likely the frames being input are from the
2874// same source that will be sent later, which just means that we're ready
2875// earlier.
eladalonf1841382017-06-12 01:16:46 -07002876TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002877 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002878 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002879 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2880 channel_->SetSend(false);
2881
2882 FakeVideoSendStream* stream = AddSendStream();
2883
perkjfa10b552016-10-02 23:45:26 -07002884 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002885 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002886 EXPECT_EQ(0u, streams[0].width);
2887 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002888
Niels Möller805a27e2019-01-21 12:21:27 +01002889 webrtc::test::FrameForwarder frame_forwarder;
2890 cricket::FakeFrameSource frame_source(1280, 720,
2891 rtc::kNumMicrosecsPerSec / 30);
2892
2893 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2894 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002895
2896 // Frame entered, should be reconfigured to new dimensions.
2897 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002898 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2899 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002900
Niels Möllerff40b142018-04-09 08:49:14 +02002901 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002902}
2903
eladalonf1841382017-06-12 01:16:46 -07002904TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002905 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002906 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002907 cricket::VideoSendParameters parameters;
2908 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002909 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002910 AddSendStream();
2911
Niels Möller805a27e2019-01-21 12:21:27 +01002912 webrtc::test::FrameForwarder frame_forwarder;
2913 cricket::FakeFrameSource frame_source(1280, 720,
2914 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002915 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002916 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002917 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2918 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002919
2920 EXPECT_TRUE(channel_->SetSend(true));
2921
Niels Möller805a27e2019-01-21 12:21:27 +01002922 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002923 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2924 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2925
2926 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2927
2928 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002929 webrtc::VideoEncoderConfig encoder_config =
2930 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002931 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002932 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002933 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002934 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2935 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002936 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2937 << "Non-screenshare shouldn't use min-transmit bitrate.";
2938
Niels Möllerff40b142018-04-09 08:49:14 +02002939 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002940 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002941 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002942 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002943 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2944 &frame_forwarder));
2945 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002946 // Send stream recreated after option change.
2947 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2948 send_stream = fake_call_->GetVideoSendStreams().front();
2949 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002950
2951 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002952 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002953 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002954 encoder_config.content_type);
2955 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2956 encoder_config.min_transmit_bitrate_bps);
2957
perkjfa10b552016-10-02 23:45:26 -07002958 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002959 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2960 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002961 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002962 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002963}
2964
eladalonf1841382017-06-12 01:16:46 -07002965TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002966 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002967 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002968 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002969 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002970
2971 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002972 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002973 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002974 webrtc::test::FrameForwarder frame_forwarder;
2975 cricket::FakeFrameSource frame_source(1280, 720,
2976 rtc::kNumMicrosecsPerSec / 30);
2977 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002978 EXPECT_TRUE(channel_->SetSend(true));
2979
Niels Möller805a27e2019-01-21 12:21:27 +01002980 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002981 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2982 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2983
perkj26091b12016-09-01 01:17:40 -07002984 webrtc::VideoEncoderConfig encoder_config =
2985 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002986
2987 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002988 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002989 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002990 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002991
2992 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2993 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002994 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002995 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002996 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002997
Niels Möllerff40b142018-04-09 08:49:14 +02002998 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002999}
3000
eladalonf1841382017-06-12 01:16:46 -07003001TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003002 FakeVideoSendStream* stream = AddSendStream();
3003 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3004}
3005
eladalonf1841382017-06-12 01:16:46 -07003006TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003007 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003008 media_config.video.suspend_below_min_bitrate = true;
3009
Sebastian Jansson84848f22018-11-16 10:40:36 +01003010 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003011 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3012 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003013 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003014
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003015 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003016
3017 FakeVideoSendStream* stream = AddSendStream();
3018 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3019
nisse0db023a2016-03-01 04:29:59 -08003020 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003021 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003022 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3023 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003024 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003025
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003026 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003027
nisse0db023a2016-03-01 04:29:59 -08003028 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003029 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3030}
3031
eladalonf1841382017-06-12 01:16:46 -07003032TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003033 FakeVideoSendStream* stream = AddSendStream();
3034 webrtc::VideoCodecVP8 vp8_settings;
3035 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3036 EXPECT_TRUE(vp8_settings.denoisingOn);
3037}
3038
eladalonf1841382017-06-12 01:16:46 -07003039TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003040 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003041 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003042 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003043
Peter Boström2feafdb2015-09-09 14:32:14 +02003044 // Single-stream settings should apply with RTX as well (verifies that we
3045 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3046 // both RTX and regular SSRCs).
3047 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003048
Niels Möller805a27e2019-01-21 12:21:27 +01003049 webrtc::test::FrameForwarder frame_forwarder;
3050 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003051 channel_->SetSend(true);
3052
Niels Möller805a27e2019-01-21 12:21:27 +01003053 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003054
pbos4cba4eb2015-10-26 11:18:18 -07003055 webrtc::VideoCodecVP8 vp8_settings;
3056 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3057 EXPECT_TRUE(vp8_settings.denoisingOn)
3058 << "VP8 denoising should be on by default.";
3059
Niels Möller805a27e2019-01-21 12:21:27 +01003060 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003061
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003062 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3063 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003064 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3065 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003066
Niels Möller805a27e2019-01-21 12:21:27 +01003067 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003068
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003069 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3070 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003071 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3072 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3073
Niels Möllerff40b142018-04-09 08:49:14 +02003074 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003075 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003076 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003077 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003078 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003079
Mirko Bonadeif859e552018-05-30 15:31:29 +02003080 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003081 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3082 // Autmatic resize off when using simulcast.
3083 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3084 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3085
3086 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07003087 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003088 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003089 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003090
Niels Möller805a27e2019-01-21 12:21:27 +01003091 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003092
Mirko Bonadeif859e552018-05-30 15:31:29 +02003093 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003094 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3095 EXPECT_FALSE(vp8_settings.denoisingOn);
3096 // Resizing and frame dropping always off for screen sharing.
3097 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3098 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3099
Niels Möller805a27e2019-01-21 12:21:27 +01003100 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003101
3102 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3103 EXPECT_FALSE(vp8_settings.denoisingOn);
3104 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3105 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3106
Niels Möllerff40b142018-04-09 08:49:14 +02003107 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003108}
3109
deadbeef119760a2016-04-04 11:43:27 -07003110// Test that setting the same options doesn't result in the encoder being
3111// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003112TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003113 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003114 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003115
perkjfa10b552016-10-02 23:45:26 -07003116 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003117 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003118 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003119 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3120 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3121
Niels Möller805a27e2019-01-21 12:21:27 +01003122 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3123 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3124 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003125 // Expect 1 reconfigurations at this point from the initial configuration.
3126 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003127
3128 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003129 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003130 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3131
3132 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003133 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003134 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003135 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3136
Niels Möllerff40b142018-04-09 08:49:14 +02003137 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003138}
3139
eladalonf1841382017-06-12 01:16:46 -07003140class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003141 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003142 Vp9SettingsTest() : Vp9SettingsTest("") {}
3143 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003144 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003145 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003146 }
3147 virtual ~Vp9SettingsTest() {}
3148
3149 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003150 void TearDown() override {
3151 // Remove references to encoder_factory_ since this will be destroyed
3152 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003153 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003154 }
Erik Språng143cec12015-04-28 10:01:41 +02003155};
3156
3157TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003158 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003159 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003160 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003161
Peter Boström2feafdb2015-09-09 14:32:14 +02003162 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003163
Niels Möller805a27e2019-01-21 12:21:27 +01003164 webrtc::test::FrameForwarder frame_forwarder;
3165 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003166 channel_->SetSend(true);
3167
Niels Möller805a27e2019-01-21 12:21:27 +01003168 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003169
pbos4cba4eb2015-10-26 11:18:18 -07003170 webrtc::VideoCodecVP9 vp9_settings;
3171 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003172 EXPECT_TRUE(vp9_settings.denoisingOn)
3173 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003174
Niels Möller805a27e2019-01-21 12:21:27 +01003175 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003176
Erik Språng143cec12015-04-28 10:01:41 +02003177 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3178 EXPECT_FALSE(vp9_settings.denoisingOn);
3179 // Frame dropping always on for real time video.
3180 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3181
Niels Möller805a27e2019-01-21 12:21:27 +01003182 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003183
3184 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3185 EXPECT_TRUE(vp9_settings.denoisingOn);
3186 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3187
3188 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003189 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003190 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003191 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003192
Niels Möller805a27e2019-01-21 12:21:27 +01003193 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003194
3195 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3196 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003197 // Frame dropping always on for screen sharing.
3198 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003199
Niels Möller805a27e2019-01-21 12:21:27 +01003200 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003201
3202 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3203 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003204 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003205
Niels Möllerff40b142018-04-09 08:49:14 +02003206 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003207}
3208
Sergey Silkinf18072e2018-03-14 10:35:35 +01003209TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3210 cricket::VideoSendParameters parameters;
3211 parameters.codecs.push_back(GetEngineCodec("VP9"));
3212 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3213
3214 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3215
3216 FakeVideoSendStream* stream =
3217 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3218
3219 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003220
Niels Möller805a27e2019-01-21 12:21:27 +01003221 webrtc::test::FrameForwarder frame_forwarder;
3222 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003223 channel_->SetSend(true);
3224
Niels Möller805a27e2019-01-21 12:21:27 +01003225 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003226
3227 webrtc::VideoCodecVP9 vp9_settings;
3228 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3229
3230 const size_t kNumSpatialLayers = ssrcs.size();
3231 const size_t kNumTemporalLayers = 3;
3232 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3233 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3234
Niels Möllerff40b142018-04-09 08:49:14 +02003235 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003236}
3237
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003238TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3239 cricket::VideoSendParameters parameters;
3240 parameters.codecs.push_back(GetEngineCodec("VP9"));
3241 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3242
3243 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3244
3245 FakeVideoSendStream* stream =
3246 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3247
3248 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3249
3250 // Despite 3 ssrcs provided, single layer is used.
3251 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3252
3253 webrtc::test::FrameForwarder frame_forwarder;
3254 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3255 channel_->SetSend(true);
3256
3257 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3258
3259 webrtc::VideoCodecVP9 vp9_settings;
3260 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3261
3262 const size_t kNumSpatialLayers = ssrcs.size();
3263 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3264
3265 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3266}
3267
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003268TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3269 cricket::VideoSendParameters send_parameters;
3270 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3271 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3272
3273 const size_t kNumSpatialLayers = 3;
3274 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3275
3276 FakeVideoSendStream* stream =
3277 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3278
3279 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3280 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3281 ASSERT_TRUE(parameters.encodings[0].active);
3282 ASSERT_TRUE(parameters.encodings[1].active);
3283 ASSERT_TRUE(parameters.encodings[2].active);
3284 // Invert value to verify copying.
3285 parameters.encodings[1].active = false;
3286 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3287
3288 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3289
3290 // number_of_streams should be 1 since all spatial layers are sent on the
3291 // same SSRC. But encoding parameters of all layers is supposed to be copied
3292 // and stored in simulcast_layers[].
3293 EXPECT_EQ(1u, encoder_config.number_of_streams);
3294 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3295 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3296 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3297 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3298}
3299
Sergey Silkincf267052019-04-09 11:40:09 +02003300class Vp9SettingsTestWithFieldTrial
3301 : public Vp9SettingsTest,
3302 public ::testing::WithParamInterface<
3303 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003304 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003305 Vp9SettingsTestWithFieldTrial()
3306 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3307 num_spatial_layers_(::testing::get<1>(GetParam())),
3308 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003309 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003310
3311 void VerifySettings(int num_spatial_layers,
3312 int num_temporal_layers,
3313 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003314 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003315 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003316 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3317
3318 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3319
Niels Möller805a27e2019-01-21 12:21:27 +01003320 webrtc::test::FrameForwarder frame_forwarder;
3321 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003322 channel_->SetSend(true);
3323
Niels Möller805a27e2019-01-21 12:21:27 +01003324 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003325
3326 webrtc::VideoCodecVP9 vp9_settings;
3327 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3328 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3329 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003330 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003331
Niels Möllerff40b142018-04-09 08:49:14 +02003332 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003333 }
Sergey Silkincf267052019-04-09 11:40:09 +02003334
3335 const uint8_t num_spatial_layers_;
3336 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003337 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003338};
3339
Sergey Silkincf267052019-04-09 11:40:09 +02003340TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003341 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3342 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003343}
3344
Sergey Silkincf267052019-04-09 11:40:09 +02003345INSTANTIATE_TEST_SUITE_P(
3346 ,
3347 Vp9SettingsTestWithFieldTrial,
3348 ::testing::Values(
3349 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3350 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3351 1,
3352 1,
3353 webrtc::InterLayerPredMode::kOnKeyPic),
3354 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3355 2,
3356 3,
3357 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003358 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003359 1,
3360 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003361 webrtc::InterLayerPredMode::kOnKeyPic),
3362 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003363 1,
3364 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003365 webrtc::InterLayerPredMode::kOnKeyPic),
3366 std::make_tuple(
3367 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3368 1,
3369 1,
3370 webrtc::InterLayerPredMode::kOff),
3371 std::make_tuple(
3372 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3373 1,
3374 1,
3375 webrtc::InterLayerPredMode::kOn),
3376 std::make_tuple(
3377 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3378 1,
3379 1,
3380 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003381
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003382TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3383 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3384 ASSERT_EQ(1u, streams.size());
3385 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3386}
3387
3388TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003389 RTC_DCHECK(!override_field_trials_);
3390 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003391 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3392 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3393 ASSERT_EQ(1u, streams.size());
3394 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3395}
3396
asapersson3c81a1a2017-06-14 05:52:21 -07003397TEST_F(WebRtcVideoChannelTest,
3398 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003399 RTC_DCHECK(!override_field_trials_);
3400 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003401 "WebRTC-Video-BalancedDegradation/Disabled/");
3402 const bool kResolutionScalingEnabled = true;
3403 const bool kFpsScalingEnabled = false;
3404 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3405}
3406
3407TEST_F(WebRtcVideoChannelTest,
3408 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003409 RTC_DCHECK(!override_field_trials_);
3410 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003411 "WebRTC-Video-BalancedDegradation/Enabled/");
3412 const bool kResolutionScalingEnabled = true;
3413 const bool kFpsScalingEnabled = true;
3414 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3415}
3416
eladalonf1841382017-06-12 01:16:46 -07003417TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003418 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003419}
3420
eladalonf1841382017-06-12 01:16:46 -07003421TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003422 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003423}
3424
Niels Möller3de32e62019-01-18 08:42:18 +01003425TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3426 TestCpuAdaptation(false, true);
3427}
3428
eladalonf1841382017-06-12 01:16:46 -07003429TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003430 TestCpuAdaptation(true, true);
3431}
3432
eladalonf1841382017-06-12 01:16:46 -07003433TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003434 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003435 cricket::VideoSendParameters parameters;
3436 parameters.codecs.push_back(codec);
3437
kthelgason2bc68642017-02-07 07:02:22 -08003438 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003439 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003440 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003441 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3442 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003443 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003444 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3445
3446 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003447 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003448
Per766ad3b2016-04-05 15:23:49 +02003449 ASSERT_TRUE(channel_->SetSend(true));
3450 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003451 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003452 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003453
3454 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3455 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003456
Niels Möllerdcc70292019-01-15 16:32:38 +01003457 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3458 // Dont' expect anything on framerate_scaling_enabled, since the default is
3459 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003460
Niels Möllerdcc70292019-01-15 16:32:38 +01003461 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003462 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003463 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003464 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003465 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3466 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003467 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003468
Niels Möllerdcc70292019-01-15 16:32:38 +01003469 // Switch back to the normal capturer. Expect resolution scaling to be
3470 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003471 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3472 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003473 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3474 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003475 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003476
Niels Möllerff40b142018-04-09 08:49:14 +02003477 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003478}
3479
asapersson3c81a1a2017-06-14 05:52:21 -07003480// TODO(asapersson): Remove this test when the balanced field trial is removed.
3481void WebRtcVideoChannelTest::TestDegradationPreference(
3482 bool resolution_scaling_enabled,
3483 bool fps_scaling_enabled) {
3484 cricket::VideoCodec codec = GetEngineCodec("VP8");
3485 cricket::VideoSendParameters parameters;
3486 parameters.codecs.push_back(codec);
3487
3488 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003489 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003490 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003491 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3492 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003493 channel_->OnReadyToSend(true);
3494
3495 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3496
3497 AddSendStream();
3498
Niels Möller805a27e2019-01-21 12:21:27 +01003499 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003500 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003501 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003502
3503 EXPECT_TRUE(channel_->SetSend(true));
3504
3505 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3506 EXPECT_EQ(resolution_scaling_enabled,
3507 send_stream->resolution_scaling_enabled());
3508 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3509
Niels Möllerff40b142018-04-09 08:49:14 +02003510 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003511}
3512
eladalonf1841382017-06-12 01:16:46 -07003513void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3514 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003515 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003516 cricket::VideoSendParameters parameters;
3517 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003518
kthelgason2bc68642017-02-07 07:02:22 -08003519 MediaConfig media_config = GetMediaConfig();
3520 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003521 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003522 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003523 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003524 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3525 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003526 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003527
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003528 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003529
3530 AddSendStream();
3531
Niels Möller805a27e2019-01-21 12:21:27 +01003532 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003533 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003534 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003535 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003536
3537 EXPECT_TRUE(channel_->SetSend(true));
3538
solenberge5269742015-09-08 05:13:22 -07003539 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003540
sprangc5d62e22017-04-02 23:53:04 -07003541 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003542 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003543 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003544 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003545 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3546 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3547 } else {
3548 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3549 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3550 }
Niels Möllerff40b142018-04-09 08:49:14 +02003551 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003552}
3553
eladalonf1841382017-06-12 01:16:46 -07003554TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003555 // Start at last timestamp to verify that wraparounds are estimated correctly.
3556 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3557 static const int64_t kInitialNtpTimeMs = 1247891230;
3558 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003559 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003560
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003561 FakeVideoReceiveStream* stream = AddRecvStream();
3562 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003563 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003564
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003565 webrtc::VideoFrame video_frame =
3566 webrtc::VideoFrame::Builder()
3567 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3568 .set_timestamp_rtp(kInitialTimestamp)
3569 .set_timestamp_us(0)
3570 .set_rotation(webrtc::kVideoRotation_0)
3571 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003572 // Initial NTP time is not available on the first frame, but should still be
3573 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003574 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003575
3576 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003577
3578 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3579 // triggers a constant-overflow warning, hence we're calculating it explicitly
3580 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003581 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003582 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3583 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003584 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003585
3586 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003587
3588 // Verify that NTP time has been correctly deduced.
3589 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003590 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003591 ASSERT_EQ(1u, info.receivers.size());
3592 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003593}
3594
eladalonf1841382017-06-12 01:16:46 -07003595TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003596 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003597 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003598
3599 VideoCodec codec;
3600 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003601 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003602
3603 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003604 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3605 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003606 FakeVideoSendStream* stream = AddSendStream(
3607 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003608 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003609
3610 // Make sure NACK and FEC are enabled on the correct payload types.
3611 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003612 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3613 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003614
3615 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3616 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003617 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003618 // TODO(juberti): Check RTCP, PLI, TMMBR.
3619}
3620
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003621TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3622 cricket::VideoSendParameters parameters;
3623 parameters.codecs.push_back(GetEngineCodec("VP8"));
3624 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3625
3626 FakeVideoSendStream* stream = AddSendStream();
3627 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3628 EXPECT_FALSE(config.rtp.raw_payload);
3629}
3630
3631TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3632 cricket::VideoSendParameters parameters;
3633 parameters.codecs.push_back(GetEngineCodec("VP8"));
3634 parameters.codecs.back().packetization = kPacketizationParamRaw;
3635 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3636
3637 FakeVideoSendStream* stream = AddSendStream();
3638 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3639 EXPECT_TRUE(config.rtp.raw_payload);
3640}
3641
brandtr31bd2242017-05-19 05:47:46 -07003642// The following four tests ensures that FlexFEC is not activated by default
3643// when the field trials are not enabled.
3644// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3645// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003646TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003647 FakeVideoSendStream* stream = AddSendStream();
3648 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3649
brandtr3d200bd2017-01-16 06:59:19 -08003650 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003651 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3652 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003653}
3654
eladalonf1841382017-06-12 01:16:46 -07003655TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003656 FakeVideoSendStream* stream = AddSendStream(
3657 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3658 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3659
brandtr3d200bd2017-01-16 06:59:19 -08003660 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003661 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3662 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3663}
3664
Yves Gerey665174f2018-06-19 15:03:05 +02003665TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003666 AddRecvStream();
3667
3668 const std::vector<FakeFlexfecReceiveStream*>& streams =
3669 fake_call_->GetFlexfecReceiveStreams();
3670 EXPECT_TRUE(streams.empty());
3671}
3672
eladalonf1841382017-06-12 01:16:46 -07003673TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003674 AddRecvStream(
3675 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3676
3677 const std::vector<FakeFlexfecReceiveStream*>& streams =
3678 fake_call_->GetFlexfecReceiveStreams();
3679 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003680}
3681
3682// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3683// tests that use this test fixture into the corresponding "non-field trial"
3684// tests.
eladalonf1841382017-06-12 01:16:46 -07003685class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003686 public:
eladalonf1841382017-06-12 01:16:46 -07003687 WebRtcVideoChannelFlexfecRecvTest()
3688 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003689};
3690
eladalonf1841382017-06-12 01:16:46 -07003691TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003692 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3693 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3694 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3695}
3696
eladalonf1841382017-06-12 01:16:46 -07003697TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003698 AddRecvStream();
3699
3700 const std::vector<FakeFlexfecReceiveStream*>& streams =
3701 fake_call_->GetFlexfecReceiveStreams();
3702 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003703
3704 const std::vector<FakeVideoReceiveStream*>& video_streams =
3705 fake_call_->GetVideoReceiveStreams();
3706 ASSERT_EQ(1U, video_streams.size());
3707 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3708 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3709 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003710}
3711
eladalonf1841382017-06-12 01:16:46 -07003712TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003713 AddRecvStream(
3714 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3715
3716 const std::vector<FakeFlexfecReceiveStream*>& streams =
3717 fake_call_->GetFlexfecReceiveStreams();
3718 ASSERT_EQ(1U, streams.size());
3719 const FakeFlexfecReceiveStream* stream = streams.front();
3720 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3721 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3722 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3723 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3724 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003725
3726 const std::vector<FakeVideoReceiveStream*>& video_streams =
3727 fake_call_->GetVideoReceiveStreams();
3728 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003729 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3730 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003731 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003732 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003733 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003734}
3735
eladalonf1841382017-06-12 01:16:46 -07003736TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003737 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3738 cricket::VideoRecvParameters recv_parameters;
3739 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3740 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3741
3742 AddRecvStream(
3743 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3744 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003745 const std::vector<FakeVideoReceiveStream*>& video_streams =
3746 fake_call_->GetVideoReceiveStreams();
3747 ASSERT_EQ(1U, video_streams.size());
3748 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3749 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3750 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003751
3752 // Enable FlexFEC.
3753 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3754 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3755 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3756 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3757 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3758 << "Enabling FlexFEC should not create VideoReceiveStream.";
3759 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3760 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003761 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3762 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003763}
3764
eladalonf1841382017-06-12 01:16:46 -07003765TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003766 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3767 cricket::VideoRecvParameters recv_parameters;
3768 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3769 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3770 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3771
3772 AddRecvStream(
3773 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3774 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003775 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003776 const std::vector<FakeVideoReceiveStream*>& video_streams =
3777 fake_call_->GetVideoReceiveStreams();
3778 ASSERT_EQ(1U, video_streams.size());
3779 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3780 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3781 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003782
3783 // Disable FlexFEC.
3784 recv_parameters.codecs.clear();
3785 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3786 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3787 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3788 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3789 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3790 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3791 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3792 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003793 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3794 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003795}
3796
brandtr31bd2242017-05-19 05:47:46 -07003797// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3798// tests that use this test fixture into the corresponding "non-field trial"
3799// tests.
eladalonf1841382017-06-12 01:16:46 -07003800class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003801 public:
eladalonf1841382017-06-12 01:16:46 -07003802 WebRtcVideoChannelFlexfecSendRecvTest()
3803 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003804 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3805 }
3806};
3807
Yves Gerey665174f2018-06-19 15:03:05 +02003808TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003809 FakeVideoSendStream* stream = AddSendStream();
3810 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3811
brandtr3d200bd2017-01-16 06:59:19 -08003812 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3813 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3814 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003815}
3816
eladalonf1841382017-06-12 01:16:46 -07003817TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003818 FakeVideoSendStream* stream = AddSendStream(
3819 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3820 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3821
brandtr3d200bd2017-01-16 06:59:19 -08003822 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3823 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3824 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3825 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003826}
3827
eladalonf1841382017-06-12 01:16:46 -07003828TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003829 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003830 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003831 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003832
3833 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003834 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003835
brandtrb5f2c3f2016-10-04 23:28:39 -07003836 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3837 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003838}
3839
eladalonf1841382017-06-12 01:16:46 -07003840TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003841 cricket::VideoSendParameters parameters;
3842 parameters.codecs.push_back(GetEngineCodec("VP8"));
3843 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3844
3845 FakeVideoSendStream* stream = AddSendStream();
3846 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3847
brandtr3d200bd2017-01-16 06:59:19 -08003848 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003849}
3850
eladalonf1841382017-06-12 01:16:46 -07003851TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003852 AddRecvStream(
3853 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003854
3855 cricket::VideoRecvParameters recv_parameters;
3856 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3857 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3858 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003859
3860 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3861 fake_call_->GetFlexfecReceiveStreams();
3862 ASSERT_EQ(1U, flexfec_streams.size());
3863 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3864 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3865 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003866 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003867 flexfec_stream_config.payload_type);
3868 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3869 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3870 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3871 const std::vector<FakeVideoReceiveStream*>& video_streams =
3872 fake_call_->GetVideoReceiveStreams();
3873 const FakeVideoReceiveStream* video_stream = video_streams.front();
3874 const webrtc::VideoReceiveStream::Config& video_stream_config =
3875 video_stream->GetConfig();
3876 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3877 flexfec_stream_config.local_ssrc);
3878 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3879 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3880 flexfec_stream_config.rtcp_send_transport);
3881 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3882 // spec-compliant way.
3883 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3884 flexfec_stream_config.transport_cc);
3885 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3886 EXPECT_EQ(video_stream_config.rtp.extensions,
3887 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003888}
3889
brandtr31bd2242017-05-19 05:47:46 -07003890// We should not send FlexFEC, even if we advertise it, unless the right
3891// field trial is set.
3892// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003893TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003894 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3895 cricket::VideoSendParameters parameters;
3896 parameters.codecs.push_back(GetEngineCodec("VP8"));
3897 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3898 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3899
3900 FakeVideoSendStream* stream = AddSendStream();
3901 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3902
3903 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003904 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003905 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3906}
3907
eladalonf1841382017-06-12 01:16:46 -07003908TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003909 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3910 cricket::VideoSendParameters parameters;
3911 parameters.codecs.push_back(GetEngineCodec("VP8"));
3912 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3913 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3914
3915 FakeVideoSendStream* stream = AddSendStream(
3916 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3917 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3918
3919 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003920 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003921 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3922}
3923
eladalonf1841382017-06-12 01:16:46 -07003924TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003925 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003926 const int kUnusedPayloadType = 127;
3927 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3928
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003929 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003930 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003931 parameters.codecs.push_back(rtx_codec);
3932 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003933 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003934}
3935
eladalonf1841382017-06-12 01:16:46 -07003936TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003937 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003938 const int kUnusedPayloadType1 = 126;
3939 const int kUnusedPayloadType2 = 127;
3940 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3941 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3942 {
3943 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3944 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3945 cricket::VideoSendParameters parameters;
3946 parameters.codecs.push_back(GetEngineCodec("VP8"));
3947 parameters.codecs.push_back(rtx_codec);
3948 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3949 }
3950 {
3951 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3952 kUnusedPayloadType1, kUnusedPayloadType2);
3953 cricket::VideoSendParameters parameters;
3954 parameters.codecs.push_back(GetEngineCodec("VP8"));
3955 parameters.codecs.push_back(rtx_codec);
3956 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3957 << "RTX without matching video codec should be rejected.";
3958 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003959}
3960
eladalonf1841382017-06-12 01:16:46 -07003961TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003962 const int kUnusedPayloadType1 = 126;
3963 const int kUnusedPayloadType2 = 127;
3964 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3965 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3966
3967 // SSRCs for RTX.
3968 cricket::StreamParams params =
3969 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3970 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3971 AddSendStream(params);
3972
3973 // Original payload type for RTX.
3974 cricket::VideoSendParameters parameters;
3975 parameters.codecs.push_back(GetEngineCodec("VP8"));
3976 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3977 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3978 parameters.codecs.push_back(rtx_codec);
3979 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3980 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3981 const webrtc::VideoSendStream::Config& config_before =
3982 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3983 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3984 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3985 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3986
3987 // Change payload type for RTX.
3988 parameters.codecs[1].id = kUnusedPayloadType2;
3989 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3990 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3991 const webrtc::VideoSendStream::Config& config_after =
3992 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3993 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3994 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3995 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3996}
3997
eladalonf1841382017-06-12 01:16:46 -07003998TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003999 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004000 parameters.codecs.push_back(GetEngineCodec("VP8"));
4001 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004002 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004003
4004 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004005 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004006
magjed509e4fe2016-11-18 01:34:11 -08004007 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004008
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004009 parameters.codecs.pop_back();
4010 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004011 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004012 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004013 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004014 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004015 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4016}
4017
eladalonf1841382017-06-12 01:16:46 -07004018TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004019 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004020 cricket::VideoSendParameters parameters;
4021 parameters.codecs.push_back(GetEngineCodec("VP8"));
4022 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4023 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4024
4025 FakeVideoSendStream* stream = AddSendStream(
4026 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4027 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4028
brandtr3d200bd2017-01-16 06:59:19 -08004029 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4030 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004031 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4032 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4033
4034 parameters.codecs.pop_back();
4035 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4036 stream = fake_call_->GetVideoSendStreams()[0];
4037 ASSERT_TRUE(stream != nullptr);
4038 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004039 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004040 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004041}
4042
eladalonf1841382017-06-12 01:16:46 -07004043TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004044 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004045 cricket::VideoCodec codec(100, "VP8");
4046 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4047 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004048
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004049 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004050 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004051
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004052 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004053 webrtc::test::FrameForwarder frame_forwarder;
4054 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004055
4056 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004057 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004058
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004059 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004060 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4061 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004062 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004063 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004064 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004065 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004066}
4067
eladalonf1841382017-06-12 01:16:46 -07004068TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004069 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4070 200000);
4071}
4072
eladalonf1841382017-06-12 01:16:46 -07004073TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004074 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4075 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4076 ASSERT_EQ(1u, streams.size());
4077 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4078}
4079
eladalonf1841382017-06-12 01:16:46 -07004080TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004081 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004082 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004083}
4084
eladalonf1841382017-06-12 01:16:46 -07004085TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004086 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004087}
4088
eladalonf1841382017-06-12 01:16:46 -07004089TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004090 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4091 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4092 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004093}
4094
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004095// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4096// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004097TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004098 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4099 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4100 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4101 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004102 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004103 ExpectSetBitrateParameters(100000, 200000, 400000);
4104 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4105 // Since the codec isn't changing, start_bitrate_bps should be -1.
4106 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004107
4108 // Decrease max_bandwidth_bps.
4109 send_parameters_.max_bandwidth_bps = 350000;
4110 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004111
4112 // Now try again with the values flipped around.
4113 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4114 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004115 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004116 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004117
4118 // If we change the codec max, max_bandwidth_bps should still apply.
4119 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004120 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004121 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004122}
4123
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004124// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4125// are present in the same send parameters, the settings are combined correctly.
4126TEST_F(WebRtcVideoChannelTest,
4127 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4128 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4129 // Transport.
4130 webrtc::MediaTransportSettings settings;
4131 settings.is_caller = true;
4132 webrtc::FakeMediaTransport fake_media_transport(settings);
4133 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4134 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004135 channel_->SetInterface(network_interface.get(),
4136 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004137
4138 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4139 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4140 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4141 send_parameters_.max_bandwidth_bps = 400000;
4142 {
4143 // We expect max_bandwidth_bps to take priority, if set.
4144 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4145 ASSERT_EQ(1u,
4146 fake_media_transport.target_rate_constraints_in_order().size());
4147 const webrtc::MediaTransportTargetRateConstraints& constraint =
4148 fake_media_transport.target_rate_constraints_in_order()[0];
4149 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4150 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4151 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4152 }
4153
4154 {
4155 // Decrease max_bandwidth_bps.
4156 send_parameters_.max_bandwidth_bps = 350000;
4157 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4158 ASSERT_EQ(2u,
4159 fake_media_transport.target_rate_constraints_in_order().size());
4160 const webrtc::MediaTransportTargetRateConstraints& constraint =
4161 fake_media_transport.target_rate_constraints_in_order()[1];
4162
4163 // Since the codec isn't changing, start_bitrate_bps should be 0.
4164 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4165 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4166 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4167 }
4168
4169 {
4170 // Now try again with the values flipped around.
4171 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4172 send_parameters_.max_bandwidth_bps = 300000;
4173 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4174 ASSERT_EQ(3u,
4175 fake_media_transport.target_rate_constraints_in_order().size());
4176 const webrtc::MediaTransportTargetRateConstraints& constraint =
4177 fake_media_transport.target_rate_constraints_in_order()[2];
4178
4179 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4180 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4181 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4182 }
4183
4184 {
4185 // Now try again with the values flipped around.
4186 // If we change the codec max, max_bandwidth_bps should still apply.
4187 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4188 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4189 ASSERT_EQ(4u,
4190 fake_media_transport.target_rate_constraints_in_order().size());
4191 const webrtc::MediaTransportTargetRateConstraints& constraint =
4192 fake_media_transport.target_rate_constraints_in_order()[3];
4193
4194 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4195 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4196 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4197 }
4198}
4199
Yves Gerey665174f2018-06-19 15:03:05 +02004200TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004201 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4202 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004203 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004204 // Setting max bitrate should keep previous min bitrate.
4205 // Setting max bitrate should not reset start bitrate.
4206 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004207 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004208}
4209
eladalonf1841382017-06-12 01:16:46 -07004210TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004211 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004212 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004213 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004214 // -1 means to disable max bitrate (set infinite).
4215 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004216 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004217 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004218}
4219
eladalonf1841382017-06-12 01:16:46 -07004220TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004221 send_parameters_.max_bandwidth_bps = 99999;
4222 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004223 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004224 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004225 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4226 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4227 stream->GetVideoStreams()[0].max_bitrate_bps);
4228
4229 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004230 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004231 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4232 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004233 stream->GetVideoStreams()[0].max_bitrate_bps);
4234}
4235
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004236// Tests that when the codec specific max bitrate and VideoSendParameters
4237// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4238// appropriately.
4239TEST_F(WebRtcVideoChannelTest,
4240 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4241 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4242 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4243 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4244 send_parameters_.max_bandwidth_bps = -1;
4245 AddSendStream();
4246 ExpectSetMaxBitrate(300000);
4247 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4248
4249 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4250 ASSERT_EQ(1u, video_send_streams.size());
4251 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4252 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4253 // First the max bitrate is set based upon the codec param.
4254 EXPECT_EQ(300000,
4255 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4256
4257 // The VideoSendParameters max bitrate overrides the codec's.
4258 send_parameters_.max_bandwidth_bps = 500000;
4259 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4260 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4261 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4262 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4263}
4264
4265// Tests that when the codec specific max bitrate and RtpParameters
4266// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4267// appropriately.
4268TEST_F(WebRtcVideoChannelTest,
4269 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4270 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4271 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4272 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4273 send_parameters_.max_bandwidth_bps = -1;
4274 AddSendStream();
4275 ExpectSetMaxBitrate(300000);
4276 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4277
4278 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4279 ASSERT_EQ(1u, video_send_streams.size());
4280 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4281 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4282 // First the max bitrate is set based upon the codec param.
4283 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4284
4285 // The RtpParameter max bitrate overrides the codec's.
4286 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4287 ASSERT_EQ(1u, parameters.encodings.size());
4288 parameters.encodings[0].max_bitrate_bps = 500000;
4289 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4290 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4291 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4292 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4293}
4294
Åsa Persson55659812018-06-18 17:51:32 +02004295TEST_F(WebRtcVideoChannelTest,
4296 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4297 send_parameters_.max_bandwidth_bps = 99999;
4298 FakeVideoSendStream* stream = AddSendStream();
4299 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4300 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4301 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4302 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4303 stream->GetVideoStreams()[0].max_bitrate_bps);
4304
4305 // Get and set the rtp encoding parameters.
4306 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4307 EXPECT_EQ(1u, parameters.encodings.size());
4308
4309 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4310 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4311 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4312 stream->GetVideoStreams()[0].max_bitrate_bps);
4313
4314 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4315 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4316 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4317 stream->GetVideoStreams()[0].max_bitrate_bps);
4318}
4319
eladalonf1841382017-06-12 01:16:46 -07004320TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004321 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004322 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004323 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004324 channel_->SetSend(true);
4325
4326 FakeVideoSendStream* stream = AddSendStream();
4327
Niels Möller805a27e2019-01-21 12:21:27 +01004328 webrtc::test::FrameForwarder frame_forwarder;
4329 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004330
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004331 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4332 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4333 EXPECT_GT(initial_max_bitrate_bps, 0);
4334
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004335 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4336 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004337 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004338 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004339 streams = stream->GetVideoStreams();
4340 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004341 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004342}
4343
eladalonf1841382017-06-12 01:16:46 -07004344TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004345 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004346 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004347 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004348 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004349 channel_->SetSend(true);
4350
4351 FakeVideoSendStream* stream = AddSendStream(
4352 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4353
4354 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004355 webrtc::test::FrameForwarder frame_forwarder;
4356 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4357 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004358
4359 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4360 ASSERT_GT(streams.size(), 1u)
4361 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004362 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004363 EXPECT_GT(initial_max_bitrate_bps, 0);
4364
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004365 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4366 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004367 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004368 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004369 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004370 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004371 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4372
Niels Möllerff40b142018-04-09 08:49:14 +02004373 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004374}
4375
eladalonf1841382017-06-12 01:16:46 -07004376TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004377 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004378 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004379 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004380 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4381 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004382 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004383 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004384
4385 VideoCodec codec;
4386 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4387 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4388}
4389
eladalonf1841382017-06-12 01:16:46 -07004390TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004391 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004392 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004393 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004394 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004395 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004396 parameters.codecs[0].id = kIncorrectPayloads[i];
4397 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004398 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004399 }
4400}
4401
eladalonf1841382017-06-12 01:16:46 -07004402TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004403 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004404 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004405 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004406 parameters.codecs[0].id = payload_type;
4407 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004408 << "Payload type '" << payload_type << "' rejected.";
4409 }
4410}
4411
deadbeef67cf2c12016-04-13 10:07:16 -07004412// Test that setting the a different set of codecs but with an identical front
4413// codec doesn't result in the stream being recreated.
4414// This may happen when a subsequent negotiation includes fewer codecs, as a
4415// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004416TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004417 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4418 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004419 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4420 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004421 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4422
4423 AddSendStream();
4424 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4425
4426 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004427 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004428 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4429 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4430}
4431
eladalonf1841382017-06-12 01:16:46 -07004432TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004433 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004434 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004435 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004436}
4437
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004438// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004439TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004440 const int kUnusedPayloadType1 = 126;
4441 const int kUnusedPayloadType2 = 127;
4442 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4443 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4444
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004445 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004446 parameters.codecs.push_back(GetEngineCodec("VP8"));
4447 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004448 parameters.codecs.push_back(rtx_codec);
4449 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004450 << "RTX codec without associated payload should be rejected.";
4451
magjed509e4fe2016-11-18 01:34:11 -08004452 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004453 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004454 << "RTX codec with invalid associated payload type should be rejected.";
4455
magjed509e4fe2016-11-18 01:34:11 -08004456 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004457 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004458
magjed509e4fe2016-11-18 01:34:11 -08004459 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004460 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004461 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004462
Yves Gerey665174f2018-06-19 15:03:05 +02004463 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4464 << "RTX codec with another RTX as associated payload type should be "
4465 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004466}
4467
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004468TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4469 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4470 vp8_codec.packetization = kPacketizationParamRaw;
4471
4472 cricket::VideoRecvParameters parameters;
4473 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4474 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4475
4476 const cricket::StreamParams params =
4477 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4478 AddRecvStream(params);
4479 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4480
4481 const webrtc::VideoReceiveStream::Config& config =
4482 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4483 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4484 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4485}
4486
4487TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4488 cricket::VideoRecvParameters parameters;
4489 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4490 parameters.codecs.back().packetization = kPacketizationParamRaw;
4491 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4492
4493 const cricket::StreamParams params =
4494 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4495 AddRecvStream(params);
4496 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4497 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4498
4499 parameters.codecs.back().packetization.reset();
4500 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4501 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4502}
4503
eladalonf1841382017-06-12 01:16:46 -07004504TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004505 const int kUnusedPayloadType1 = 126;
4506 const int kUnusedPayloadType2 = 127;
4507 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4508 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4509
4510 // SSRCs for RTX.
4511 cricket::StreamParams params =
4512 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4513 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4514 AddRecvStream(params);
4515
4516 // Original payload type for RTX.
4517 cricket::VideoRecvParameters parameters;
4518 parameters.codecs.push_back(GetEngineCodec("VP8"));
4519 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4520 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4521 parameters.codecs.push_back(rtx_codec);
4522 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4523 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4524 const webrtc::VideoReceiveStream::Config& config_before =
4525 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004526 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4527 const int* payload_type_before = FindKeyByValue(
4528 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4529 ASSERT_NE(payload_type_before, nullptr);
4530 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004531 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4532
4533 // Change payload type for RTX.
4534 parameters.codecs[1].id = kUnusedPayloadType2;
4535 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4536 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4537 const webrtc::VideoReceiveStream::Config& config_after =
4538 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004539 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4540 const int* payload_type_after = FindKeyByValue(
4541 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4542 ASSERT_NE(payload_type_after, nullptr);
4543 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004544 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4545}
4546
eladalonf1841382017-06-12 01:16:46 -07004547TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004548 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004549 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004550 parameters.codecs[0].id = 99;
4551 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004552}
4553
eladalonf1841382017-06-12 01:16:46 -07004554TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004555 cricket::VideoRecvParameters parameters;
4556 parameters.codecs = engine_.codecs();
4557 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004558
4559 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004560 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004561 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004562 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004563}
4564
eladalonf1841382017-06-12 01:16:46 -07004565TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004566 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004567 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004568 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004569 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004570}
4571
eladalonf1841382017-06-12 01:16:46 -07004572TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004573 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004574 parameters.codecs.push_back(GetEngineCodec("VP8"));
4575 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004576 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004577}
4578
eladalonf1841382017-06-12 01:16:46 -07004579TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004580 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004581 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4582 send_parameters.codecs.push_back(GetEngineCodec("red"));
4583 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004584 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004585
4586 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004587
magjed509e4fe2016-11-18 01:34:11 -08004588 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004589 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004590
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004591 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004592 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004593 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004594 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004595 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004596 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004597 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4598}
4599
eladalonf1841382017-06-12 01:16:46 -07004600TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004601 AddRecvStream(
4602 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004603 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004604 fake_call_->GetFlexfecReceiveStreams();
4605
4606 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004607 const FakeFlexfecReceiveStream* stream = streams.front();
4608 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4609 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4610 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4611 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004612
4613 cricket::VideoRecvParameters recv_parameters;
4614 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4615 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4616 EXPECT_TRUE(streams.empty())
4617 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004618}
4619
eladalonf1841382017-06-12 01:16:46 -07004620TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004621 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004622 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004623 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004624
4625 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004626 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4627 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4628 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004629 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4630 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004631 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004632 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004633 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004634 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004635
4636 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004637 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4638 send_parameters.codecs.push_back(GetEngineCodec("red"));
4639 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004640 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4641 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004642 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004643 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004644 << "ULPFEC should be enabled on the receive stream.";
4645}
4646
eladalonf1841382017-06-12 01:16:46 -07004647TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004648 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004649 AddRecvStream(
4650 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004651 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004652 fake_call_->GetFlexfecReceiveStreams();
4653
4654 cricket::VideoRecvParameters recv_parameters;
4655 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4656 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4657 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4658 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004659 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004660 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004661 stream_with_recv_params->GetConfig().payload_type);
4662 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004663 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004664 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004665 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004666 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004667
4668 cricket::VideoSendParameters send_parameters;
4669 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4670 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4671 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4672 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004673 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004674 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004675 stream_with_send_params->GetConfig().payload_type);
4676 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004677 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004678 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004679 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004680 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004681}
4682
eladalonf1841382017-06-12 01:16:46 -07004683TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004684 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004685 parameters.codecs.push_back(GetEngineCodec("VP8"));
4686 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004687 parameters.codecs[1].id = parameters.codecs[0].id;
4688 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004689}
4690
eladalonf1841382017-06-12 01:16:46 -07004691TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004692 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004693 cricket::VideoRecvParameters parameters;
4694 parameters.codecs.push_back(GetEngineCodec("VP8"));
4695 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4696 parameters.codecs[1].id = parameters.codecs[0].id;
4697 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4698}
4699
eladalonf1841382017-06-12 01:16:46 -07004700TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004701 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004702 parameters.codecs.push_back(GetEngineCodec("VP8"));
4703 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004704 parameters.codecs[1].id = parameters.codecs[0].id;
4705 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004706}
4707
eladalonf1841382017-06-12 01:16:46 -07004708TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004709 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004710 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004711 parameters.codecs.push_back(GetEngineCodec("VP8"));
4712 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004713 parameters.codecs[1].id += 1;
4714 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004715}
4716
deadbeef67cf2c12016-04-13 10:07:16 -07004717// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004718// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004719TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004720 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004721 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004722 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4723 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004724 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004725
4726 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4727 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4728
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004729 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004730 parameters2.codecs.push_back(GetEngineCodec("red"));
4731 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004732 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004733 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4734}
4735
eladalonf1841382017-06-12 01:16:46 -07004736TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004737 EXPECT_FALSE(AddSendStream()->IsSending());
4738}
4739
eladalonf1841382017-06-12 01:16:46 -07004740TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004741 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004742}
4743
eladalonf1841382017-06-12 01:16:46 -07004744TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004745 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004746 EXPECT_FALSE(stream->IsSending());
4747
4748 // false->true
4749 EXPECT_TRUE(channel_->SetSend(true));
4750 EXPECT_TRUE(stream->IsSending());
4751 // true->true
4752 EXPECT_TRUE(channel_->SetSend(true));
4753 EXPECT_TRUE(stream->IsSending());
4754 // true->false
4755 EXPECT_TRUE(channel_->SetSend(false));
4756 EXPECT_FALSE(stream->IsSending());
4757 // false->false
4758 EXPECT_TRUE(channel_->SetSend(false));
4759 EXPECT_FALSE(stream->IsSending());
4760
4761 EXPECT_TRUE(channel_->SetSend(true));
4762 FakeVideoSendStream* new_stream = AddSendStream();
4763 EXPECT_TRUE(new_stream->IsSending())
4764 << "Send stream created after SetSend(true) not sending initially.";
4765}
4766
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004767// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004768TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004769 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004770 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004771 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004772 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004773 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004774
Sebastian Jansson84848f22018-11-16 10:40:36 +01004775 channel.reset(
4776 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004777 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4778 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004779 channel->SetInterface(network_interface.get(),
4780 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004781 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004782 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004783
Tim Haloun648d28a2018-10-18 16:52:22 -07004784 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4785 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004786 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004787 channel.reset(
4788 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004789 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4790 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004791 channel->SetInterface(network_interface.get(),
4792 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004793 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4794
4795 // Create a send stream to configure
4796 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4797 parameters = channel->GetRtpSendParameters(kSsrc);
4798 ASSERT_FALSE(parameters.encodings.empty());
4799
4800 // Various priorities map to various dscp values.
4801 parameters.encodings[0].network_priority = 4.0;
4802 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004803 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004804 parameters.encodings[0].network_priority = 0.5;
4805 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4806 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4807
4808 // A bad priority does not change the dscp value.
4809 parameters.encodings[0].network_priority = 0.0;
4810 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4811 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004812
Tim Haloun6ca98362018-09-17 17:06:08 -07004813 // Packets should also self-identify their dscp in PacketOptions.
4814 const uint8_t kData[10] = {0};
4815 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4816 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004817 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004818
nisse51542be2016-02-12 02:27:06 -08004819 // Verify that setting the option to false resets the
4820 // DiffServCodePoint.
4821 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004822 channel.reset(
4823 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004824 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4825 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004826 channel->SetInterface(network_interface.get(),
4827 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004828 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004829}
4830
deadbeef13871492015-12-09 12:37:51 -08004831// This test verifies that the RTCP reduced size mode is properly applied to
4832// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004833TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004834 // Create stream, expecting that default mode is "compound".
4835 FakeVideoSendStream* stream1 = AddSendStream();
4836 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004837 webrtc::RtpParameters rtp_parameters =
4838 channel_->GetRtpSendParameters(last_ssrc_);
4839 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004840
4841 // Now enable reduced size mode.
4842 send_parameters_.rtcp.reduced_size = true;
4843 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4844 stream1 = fake_call_->GetVideoSendStreams()[0];
4845 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004846 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4847 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004848
4849 // Create a new stream and ensure it picks up the reduced size mode.
4850 FakeVideoSendStream* stream2 = AddSendStream();
4851 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4852}
4853
4854// This test verifies that the RTCP reduced size mode is properly applied to
4855// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004856TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004857 // Create stream, expecting that default mode is "compound".
4858 FakeVideoReceiveStream* stream1 = AddRecvStream();
4859 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4860
4861 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004862 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4863 // the reduced_size flag should come from that.
4864 send_parameters_.rtcp.reduced_size = true;
4865 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004866 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4867 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4868
4869 // Create a new stream and ensure it picks up the reduced size mode.
4870 FakeVideoReceiveStream* stream2 = AddRecvStream();
4871 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4872}
4873
eladalonf1841382017-06-12 01:16:46 -07004874TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004875 EXPECT_EQ(webrtc::kNetworkUp,
4876 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4877 EXPECT_EQ(webrtc::kNetworkUp,
4878 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004879
4880 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004881 EXPECT_EQ(webrtc::kNetworkDown,
4882 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4883 EXPECT_EQ(webrtc::kNetworkUp,
4884 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004885
4886 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004887 EXPECT_EQ(webrtc::kNetworkUp,
4888 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4889 EXPECT_EQ(webrtc::kNetworkUp,
4890 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004891}
4892
eladalonf1841382017-06-12 01:16:46 -07004893TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004894 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004895 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004896 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004897
4898 AddSendStream();
4899
4900 cricket::VideoMediaInfo info;
4901 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004902 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004903}
4904
eladalonf1841382017-06-12 01:16:46 -07004905TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004906 FakeVideoSendStream* stream = AddSendStream();
4907 webrtc::VideoSendStream::Stats stats;
4908 stats.encoder_implementation_name = "encoder_implementation_name";
4909 stream->SetStats(stats);
4910
4911 cricket::VideoMediaInfo info;
4912 ASSERT_TRUE(channel_->GetStats(&info));
4913 EXPECT_EQ(stats.encoder_implementation_name,
4914 info.senders[0].encoder_implementation_name);
4915}
4916
eladalonf1841382017-06-12 01:16:46 -07004917TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004918 FakeVideoSendStream* stream = AddSendStream();
4919 webrtc::VideoSendStream::Stats stats;
4920 stats.avg_encode_time_ms = 13;
4921 stats.encode_usage_percent = 42;
4922 stream->SetStats(stats);
4923
4924 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004925 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004926 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4927 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4928}
4929
eladalonf1841382017-06-12 01:16:46 -07004930TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004931 FakeVideoSendStream* stream = AddSendStream();
4932 webrtc::VideoSendStream::Stats stats;
4933 stats.frames_encoded = 13;
4934 stream->SetStats(stats);
4935
4936 cricket::VideoMediaInfo info;
4937 ASSERT_TRUE(channel_->GetStats(&info));
4938 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4939}
4940
Rasmus Brandt2efae772019-06-27 14:29:34 +02004941TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
4942 FakeVideoSendStream* stream = AddSendStream();
4943 webrtc::VideoSendStream::Stats stats;
4944 stats.substreams[123].frame_counts.key_frames = 10;
4945 stats.substreams[456].frame_counts.key_frames = 87;
4946 stream->SetStats(stats);
4947
4948 cricket::VideoMediaInfo info;
4949 ASSERT_TRUE(channel_->GetStats(&info));
4950 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
4951 // for each simulcast stream, instead of accumulating all keyframes encoded
4952 // over all simulcast streams in the same outbound-rtp stats object.
4953 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
4954}
4955
eladalonf1841382017-06-12 01:16:46 -07004956TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004957 FakeVideoSendStream* stream = AddSendStream();
4958 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004959 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004960 stream->SetStats(stats);
4961
4962 cricket::VideoMediaInfo info;
4963 ASSERT_TRUE(channel_->GetStats(&info));
4964 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4965}
4966
eladalonf1841382017-06-12 01:16:46 -07004967TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004968 FakeVideoSendStream* stream = AddSendStream();
4969 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004970 stats.substreams[17].width = 123;
4971 stats.substreams[17].height = 40;
4972 stats.substreams[42].width = 80;
4973 stats.substreams[42].height = 31;
4974 stats.substreams[11].width = 20;
4975 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004976 stream->SetStats(stats);
4977
4978 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004979 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004980 ASSERT_EQ(1u, info.senders.size());
4981 EXPECT_EQ(123, info.senders[0].send_frame_width);
4982 EXPECT_EQ(90, info.senders[0].send_frame_height);
4983}
4984
eladalonf1841382017-06-12 01:16:46 -07004985TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004986 FakeVideoSendStream* stream = AddSendStream();
4987 webrtc::VideoSendStream::Stats stats;
4988 stats.number_of_cpu_adapt_changes = 2;
4989 stats.cpu_limited_resolution = true;
4990 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004991
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004992 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004993 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004994 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004995 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004996 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004997}
4998
eladalonf1841382017-06-12 01:16:46 -07004999TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005000 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005001 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005002 stats.number_of_cpu_adapt_changes = 2;
5003 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005004 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005005 stream->SetStats(stats);
5006
5007 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005008 EXPECT_TRUE(channel_->GetStats(&info));
5009 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005010 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5011 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005012 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005013 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005014}
5015
eladalonf1841382017-06-12 01:16:46 -07005016TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005017 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5018 FakeVideoSendStream* stream = AddSendStream();
5019 webrtc::VideoSendStream::Stats stats;
5020 stats.bw_limited_resolution = true;
5021 stream->SetStats(stats);
5022
5023 cricket::VideoMediaInfo info;
5024 EXPECT_TRUE(channel_->GetStats(&info));
5025 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005026 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005027 info.senders[0].adapt_reason);
5028}
5029
Yves Gerey665174f2018-06-19 15:03:05 +02005030TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005031 FakeVideoSendStream* stream = AddSendStream();
5032 webrtc::VideoSendStream::Stats stats;
5033 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5034 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5035 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5036
5037 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5038 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5039 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5040
5041 stream->SetStats(stats);
5042
5043 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005044 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005045 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5046 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5047 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5048}
5049
eladalonf1841382017-06-12 01:16:46 -07005050TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005051 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5052 FakeVideoReceiveStream* stream = AddRecvStream();
5053 webrtc::VideoReceiveStream::Stats stats;
5054 stats.rtcp_packet_type_counts.fir_packets = 2;
5055 stats.rtcp_packet_type_counts.nack_packets = 3;
5056 stats.rtcp_packet_type_counts.pli_packets = 4;
5057 stream->SetStats(stats);
5058
5059 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005060 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005061 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005062 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005063 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005064 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005065 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005066 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005067}
5068
eladalonf1841382017-06-12 01:16:46 -07005069TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005070 FakeVideoReceiveStream* stream = AddRecvStream();
5071 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005072 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005073 stats.decode_ms = 2;
5074 stats.max_decode_ms = 3;
5075 stats.current_delay_ms = 4;
5076 stats.target_delay_ms = 5;
5077 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005078 stats.jitter_buffer_delay_seconds = 60;
5079 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005080 stats.min_playout_delay_ms = 7;
5081 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005082 stats.width = 9;
5083 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005084 stats.frame_counts.key_frames = 11;
5085 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005086 stats.frames_rendered = 13;
5087 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005088 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005089 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005090 stream->SetStats(stats);
5091
5092 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005093 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005094 EXPECT_EQ(stats.decoder_implementation_name,
5095 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005096 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5097 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5098 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5099 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5100 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005101 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5102 info.receivers[0].jitter_buffer_delay_seconds);
5103 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5104 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005105 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5106 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005107 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5108 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005109 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5110 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005111 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005112 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005113 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005114 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5115 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005116 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005117 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005118}
5119
eladalonf1841382017-06-12 01:16:46 -07005120TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005121 FakeVideoReceiveStream* stream = AddRecvStream();
5122 webrtc::VideoReceiveStream::Stats stats;
5123 stats.rtp_stats.transmitted.payload_bytes = 2;
5124 stats.rtp_stats.transmitted.header_bytes = 3;
5125 stats.rtp_stats.transmitted.padding_bytes = 4;
5126 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005127 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005128 stats.rtcp_stats.fraction_lost = 7;
5129 stream->SetStats(stats);
5130
5131 cricket::VideoMediaInfo info;
5132 ASSERT_TRUE(channel_->GetStats(&info));
5133 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
5134 stats.rtp_stats.transmitted.header_bytes +
5135 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005136 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005137 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005138 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005139 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005140}
5141
eladalonf1841382017-06-12 01:16:46 -07005142TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005143 AddSendStream();
5144 AddSendStream();
5145 webrtc::Call::Stats stats;
5146 stats.rtt_ms = 123;
5147 fake_call_->SetStats(stats);
5148
5149 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005150 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005151 ASSERT_EQ(2u, info.senders.size());
5152 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5153 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5154}
5155
eladalonf1841382017-06-12 01:16:46 -07005156TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005157 FakeVideoSendStream* stream = AddSendStream();
5158 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005159 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005160 stats.media_bitrate_bps = 123;
5161 stats.substreams[17].total_bitrate_bps = 1;
5162 stats.substreams[17].retransmit_bitrate_bps = 2;
5163 stats.substreams[42].total_bitrate_bps = 3;
5164 stats.substreams[42].retransmit_bitrate_bps = 4;
5165 stream->SetStats(stats);
5166
5167 FakeVideoSendStream* stream2 = AddSendStream();
5168 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005169 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005170 stats2.media_bitrate_bps = 321;
5171 stats2.substreams[13].total_bitrate_bps = 5;
5172 stats2.substreams[13].retransmit_bitrate_bps = 6;
5173 stats2.substreams[21].total_bitrate_bps = 7;
5174 stats2.substreams[21].retransmit_bitrate_bps = 8;
5175 stream2->SetStats(stats2);
5176
5177 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005178 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005179 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005180 BandwidthEstimationInfo bwe_info;
5181 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005182 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5183 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5184 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5185 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005186 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005187 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005188 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005189 bwe_info.actual_enc_bitrate);
5190 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005191 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005192 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005193 << "Bandwidth stats should take all streams into account.";
5194}
5195
eladalonf1841382017-06-12 01:16:46 -07005196TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005197 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005198
Peter Boström0c4e06b2015-10-07 12:23:21 +02005199 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5200 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005201
5202 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5203 const size_t kDataLength = 12;
5204 uint8_t data[kDataLength];
5205 memset(data, 0, sizeof(data));
5206 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005207 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005208 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005209
5210 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5211 << "No default receive stream created.";
5212 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005213 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005214 << "Default receive stream should not have configured RTX";
5215
5216 EXPECT_TRUE(channel_->AddRecvStream(
5217 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5218 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005219 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005220 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005221 EXPECT_FALSE(
5222 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005223 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005224 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005225 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005226 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005227 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005228 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005229}
5230
eladalonf1841382017-06-12 01:16:46 -07005231TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005232 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005233
Peter Boström0c4e06b2015-10-07 12:23:21 +02005234 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5235 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005236
5237 StreamParams sp =
5238 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5239 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5240
5241 EXPECT_FALSE(channel_->AddSendStream(sp));
5242 EXPECT_FALSE(channel_->AddRecvStream(sp));
5243}
5244
eladalonf1841382017-06-12 01:16:46 -07005245TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005246 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005247
Peter Boström0c4e06b2015-10-07 12:23:21 +02005248 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5249 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005250
5251 StreamParams sp =
5252 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5253
5254 EXPECT_TRUE(channel_->AddSendStream(sp));
5255 EXPECT_TRUE(channel_->AddRecvStream(sp));
5256
5257 // The RTX SSRC is already used in previous streams, using it should fail.
5258 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5259 EXPECT_FALSE(channel_->AddSendStream(sp));
5260 EXPECT_FALSE(channel_->AddRecvStream(sp));
5261
5262 // After removing the original stream this should be fine to add (makes sure
5263 // that RTX ssrcs are not forever taken).
5264 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5265 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5266 EXPECT_TRUE(channel_->AddSendStream(sp));
5267 EXPECT_TRUE(channel_->AddRecvStream(sp));
5268}
5269
eladalonf1841382017-06-12 01:16:46 -07005270TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005271 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005272 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5273 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005274 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005275
Peter Boströmd6f4c252015-03-26 16:23:04 +01005276 StreamParams sp =
5277 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5278
5279 EXPECT_TRUE(channel_->AddSendStream(sp));
5280 EXPECT_TRUE(channel_->AddRecvStream(sp));
5281
5282 // One of the SSRCs is already used in previous streams, using it should fail.
5283 sp = cricket::CreateSimStreamParams("cname",
5284 MAKE_VECTOR(kOverlappingStreamSsrcs));
5285 EXPECT_FALSE(channel_->AddSendStream(sp));
5286 EXPECT_FALSE(channel_->AddRecvStream(sp));
5287
5288 // After removing the original stream this should be fine to add (makes sure
5289 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005290 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5291 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005292 EXPECT_TRUE(channel_->AddSendStream(sp));
5293 EXPECT_TRUE(channel_->AddRecvStream(sp));
5294}
5295
eladalonf1841382017-06-12 01:16:46 -07005296TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005297 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005298
5299 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5300 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5301
5302 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5303 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5304
5305 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5306
5307 static const uint32_t kReceiverSsrcs[] = {3};
5308 static const uint32_t kReceiverRtxSsrcs[] = {2};
5309
5310 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5311 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5312 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5313
5314 cricket::VideoMediaInfo info;
5315 ASSERT_TRUE(channel_->GetStats(&info));
5316
5317 ASSERT_EQ(1u, info.senders.size());
5318 ASSERT_EQ(1u, info.receivers.size());
5319
5320 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5321 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5322 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5323}
5324
eladalonf1841382017-06-12 01:16:46 -07005325TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005326 FakeVideoReceiveStream* stream = AddRecvStream();
5327 webrtc::VideoReceiveStream::Stats stats;
5328 cricket::VideoMediaInfo info;
5329
5330 // Report no codec name before receiving.
5331 stream->SetStats(stats);
5332 ASSERT_TRUE(channel_->GetStats(&info));
5333 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5334
5335 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005336 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005337 stream->SetStats(stats);
5338 ASSERT_TRUE(channel_->GetStats(&info));
5339 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5340
5341 // Report no codec name for unknown playload types.
5342 stats.current_payload_type = 3;
5343 stream->SetStats(stats);
5344 ASSERT_TRUE(channel_->GetStats(&info));
5345 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5346}
5347
Seth Hampson5897a6e2018-04-03 11:16:33 -07005348// Tests that when we add a stream without SSRCs, but contains a stream_id
5349// that it is stored and its stream id is later used when the first packet
5350// arrives to properly create a receive stream with a sync label.
5351TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5352 const char kSyncLabel[] = "sync_label";
5353 cricket::StreamParams unsignaled_stream;
5354 unsignaled_stream.set_stream_ids({kSyncLabel});
5355 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5356 // The stream shouldn't have been created at this point because it doesn't
5357 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005358 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005359
5360 // Create and deliver packet.
5361 const size_t kDataLength = 12;
5362 uint8_t data[kDataLength];
5363 memset(data, 0, sizeof(data));
5364 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5365 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005366 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005367
5368 // The stream should now be created with the appropriate sync label.
5369 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5370 EXPECT_EQ(kSyncLabel,
5371 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5372
5373 // Removing the unsignaled stream should clear the cache. This time when
5374 // a default video receive stream is created it won't have a sync_group.
5375 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5376 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5377 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5378
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005379 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005380 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5381 EXPECT_TRUE(
5382 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5383}
5384
Ruslan Burakov493a6502019-02-27 15:32:48 +01005385// Test BaseMinimumPlayoutDelayMs on receive streams.
5386TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5387 // Test that set won't work for non-existing receive streams.
5388 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5389 // Test that get won't work for non-existing receive streams.
5390 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5391
5392 EXPECT_TRUE(AddRecvStream());
5393 // Test that set works for the existing receive stream.
5394 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5395 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5396 EXPECT_TRUE(recv_stream);
5397 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5398 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5399 200);
5400}
5401
5402// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5403TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5404 absl::optional<int> delay_ms;
5405 const FakeVideoReceiveStream* recv_stream;
5406
5407 // Set default stream with SSRC 0
5408 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5409 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5410
5411 // Spawn an unsignaled stream by sending a packet, it should inherit
5412 // default delay 200.
5413 const size_t kDataLength = 12;
5414 uint8_t data[kDataLength];
5415 memset(data, 0, sizeof(data));
5416 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5417 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005418 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005419
5420 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5421 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5422 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5423 EXPECT_EQ(200, delay_ms.value_or(0));
5424
5425 // Check that now if we change delay for SSRC 0 it will change delay for the
5426 // default receiving stream as well.
5427 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5428 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5429 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5430 EXPECT_EQ(300, delay_ms.value_or(0));
5431 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5432 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5433}
5434
eladalonf1841382017-06-12 01:16:46 -07005435void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005436 uint8_t payload_type,
5437 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005438 // kRedRtxPayloadType must currently be unused.
5439 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5440
noahricd10a68e2015-07-10 11:27:55 -07005441 // Add a RED RTX codec.
5442 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005443 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005444 recv_parameters_.codecs.push_back(red_rtx_codec);
5445 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005446
5447 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5448 const size_t kDataLength = 12;
5449 uint8_t data[kDataLength];
5450 memset(data, 0, sizeof(data));
5451
5452 rtc::Set8(data, 1, payload_type);
5453 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005454 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005455 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005456
5457 if (expect_created_receive_stream) {
5458 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5459 << "Should have created a receive stream for payload type: "
5460 << payload_type;
5461 } else {
5462 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5463 << "Shouldn't have created a receive stream for payload type: "
5464 << payload_type;
5465 }
5466}
5467
Åsa Persson2c7149b2018-10-15 09:36:10 +02005468class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5469 public:
5470 WebRtcVideoChannelDiscardUnknownSsrcTest()
5471 : WebRtcVideoChannelTest(
5472 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5473};
5474
5475TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5476 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5477 false /* expect_created_receive_stream */);
5478}
5479
eladalonf1841382017-06-12 01:16:46 -07005480TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005481 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5482 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005483}
5484
eladalonf1841382017-06-12 01:16:46 -07005485TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005486 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5487 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005488}
5489
eladalonf1841382017-06-12 01:16:46 -07005490TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005491 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005492 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5493 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5494 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5495 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005496}
5497
eladalonf1841382017-06-12 01:16:46 -07005498TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005499 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5500 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005501}
5502
eladalonf1841382017-06-12 01:16:46 -07005503TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005504 FlexfecPacketDoesntCreateUnsignalledStream) {
5505 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5506 false /* expect_created_receive_stream */);
5507}
5508
eladalonf1841382017-06-12 01:16:46 -07005509TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005510 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5511 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005512}
5513
mzanaty8a855d62017-02-17 15:46:43 -08005514// Test that receiving any unsignalled SSRC works even if it changes.
5515// The first unsignalled SSRC received will create a default receive stream.
5516// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005517TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005518 // Allow receiving VP8, VP9, H264 (if enabled).
5519 cricket::VideoRecvParameters parameters;
5520 parameters.codecs.push_back(GetEngineCodec("VP8"));
5521 parameters.codecs.push_back(GetEngineCodec("VP9"));
5522
5523#if defined(WEBRTC_USE_H264)
5524 cricket::VideoCodec H264codec(126, "H264");
5525 parameters.codecs.push_back(H264codec);
5526#endif
5527
5528 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5529 // No receive streams yet.
5530 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5531 cricket::FakeVideoRenderer renderer;
5532 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5533
5534 // Receive VP8 packet on first SSRC.
5535 uint8_t data[kMinRtpPacketLen];
5536 cricket::RtpHeader rtpHeader;
5537 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5538 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005539 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005540 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5541 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005542 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005543 // VP8 packet should create default receive stream.
5544 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005545 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005546 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5547 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005548 webrtc::VideoFrame video_frame =
5549 webrtc::VideoFrame::Builder()
5550 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5551 .set_timestamp_rtp(100)
5552 .set_timestamp_us(0)
5553 .set_rotation(webrtc::kVideoRotation_0)
5554 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005555 recv_stream->InjectFrame(video_frame);
5556 EXPECT_EQ(1, renderer.num_rendered_frames());
5557
5558 // Receive VP9 packet on second SSRC.
5559 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005560 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005561 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5562 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005563 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005564 // VP9 packet should replace the default receive SSRC.
5565 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5566 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5567 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5568 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005569 webrtc::VideoFrame video_frame2 =
5570 webrtc::VideoFrame::Builder()
5571 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5572 .set_timestamp_rtp(200)
5573 .set_timestamp_us(0)
5574 .set_rotation(webrtc::kVideoRotation_0)
5575 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005576 recv_stream->InjectFrame(video_frame2);
5577 EXPECT_EQ(2, renderer.num_rendered_frames());
5578
5579#if defined(WEBRTC_USE_H264)
5580 // Receive H264 packet on third SSRC.
5581 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005582 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005583 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5584 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005585 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005586 // H264 packet should replace the default receive SSRC.
5587 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5588 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5589 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5590 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005591 webrtc::VideoFrame video_frame3 =
5592 webrtc::VideoFrame::Builder()
5593 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5594 .set_timestamp_rtp(300)
5595 .set_timestamp_us(0)
5596 .set_rotation(webrtc::kVideoRotation_0)
5597 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005598 recv_stream->InjectFrame(video_frame3);
5599 EXPECT_EQ(3, renderer.num_rendered_frames());
5600#endif
5601}
5602
brandtr0dc57ea2017-05-29 23:33:31 -07005603// This test verifies that when a new default stream is created for a new
5604// unsignaled SSRC, the new stream does not overwrite any old stream that had
5605// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005606TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005607 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5608 cricket::VideoRecvParameters parameters;
5609 parameters.codecs.push_back(GetEngineCodec("VP8"));
5610 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5611
5612 // No streams signaled and no packets received, so we should not have any
5613 // stream objects created yet.
5614 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5615
5616 // Receive packet on an unsignaled SSRC.
5617 uint8_t data[kMinRtpPacketLen];
5618 cricket::RtpHeader rtp_header;
5619 rtp_header.payload_type = GetEngineCodec("VP8").id;
5620 rtp_header.seq_num = rtp_header.timestamp = 0;
5621 rtp_header.ssrc = kSsrcs3[0];
5622 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5623 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005624 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005625 // Default receive stream should be created.
5626 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5627 FakeVideoReceiveStream* recv_stream0 =
5628 fake_call_->GetVideoReceiveStreams()[0];
5629 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5630
5631 // Signal the SSRC.
5632 EXPECT_TRUE(
5633 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5634 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5635 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5636 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5637
5638 // Receive packet on a different unsignaled SSRC.
5639 rtp_header.ssrc = kSsrcs3[1];
5640 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5641 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005642 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005643 // New default receive stream should be created, but old stream should remain.
5644 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5645 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5646 FakeVideoReceiveStream* recv_stream1 =
5647 fake_call_->GetVideoReceiveStreams()[1];
5648 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5649}
5650
Seth Hampson7c682e02018-05-04 16:28:15 -07005651TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005652 AddSendStream();
5653
Niels Möller805a27e2019-01-21 12:21:27 +01005654 webrtc::test::FrameForwarder frame_forwarder;
5655 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005656 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005657 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005658
perkjfa10b552016-10-02 23:45:26 -07005659 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005660 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005661
5662 // TODO(skvlad): Resolve the inconsistency between the interpretation
5663 // of the global bitrate limit for audio and video:
5664 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5665 // max_bandwidth_bps = -1 - remove the bandwidth limit
5666 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005667 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005668
perkjfa10b552016-10-02 23:45:26 -07005669 SetAndExpectMaxBitrate(1000, 0, 1000);
5670 SetAndExpectMaxBitrate(1000, 800, 800);
5671 SetAndExpectMaxBitrate(600, 800, 600);
5672 SetAndExpectMaxBitrate(0, 800, 800);
5673 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005674
Niels Möllerff40b142018-04-09 08:49:14 +02005675 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005676}
5677
eladalonf1841382017-06-12 01:16:46 -07005678TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005679 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005680 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005681 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005682
5683 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005684 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005685 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005686}
5687
eladalonf1841382017-06-12 01:16:46 -07005688TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005689 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005690 FakeVideoSendStream* stream = AddSendStream();
5691
Seth Hampson7c682e02018-05-04 16:28:15 -07005692 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5693 EXPECT_EQ(1UL, parameters.encodings.size());
5694 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5695 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5696
5697 // Note that this is testing the behavior of the FakeVideoSendStream, which
5698 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5699 // we are just testing the behavior of
5700 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005701 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5702 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005703
5704 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5705 // by this amount.
5706 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5707 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5708 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5709 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5710
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005711 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5712 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5713 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5714}
5715
5716TEST_F(WebRtcVideoChannelTest,
5717 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5718 FakeVideoSendStream* stream = AddSendStream();
5719
5720 // Note that this is testing the behavior of the FakeVideoSendStream, which
5721 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5722 // we are just testing the behavior of
5723 // EncoderStreamFactory::CreateEncoderStreams.
5724 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5725 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5726
5727 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5728 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5729 EXPECT_EQ(1UL, parameters.encodings.size());
5730 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5731 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5732
5733 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5734 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5735 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5736}
5737
5738TEST_F(WebRtcVideoChannelTest,
5739 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5740 send_parameters_.max_bandwidth_bps = 99999;
5741 FakeVideoSendStream* stream = AddSendStream();
5742 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5743 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5744 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5745 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5746 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5747 stream->GetVideoStreams()[0].max_bitrate_bps);
5748
5749 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5750 // adjusted down.
5751 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5752 EXPECT_EQ(1UL, parameters.encodings.size());
5753 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5754 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5755 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5756 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5757 stream->GetVideoStreams()[0].min_bitrate_bps);
5758 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5759 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005760}
5761
Åsa Persson8c1bf952018-09-13 10:42:19 +02005762TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5763 FakeVideoSendStream* stream = AddSendStream();
5764
5765 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5766 EXPECT_EQ(1UL, parameters.encodings.size());
5767 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5768 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5769
5770 // Note that this is testing the behavior of the FakeVideoSendStream, which
5771 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5772 // we are just testing the behavior of
5773 // EncoderStreamFactory::CreateEncoderStreams.
5774 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5775 EXPECT_EQ(kDefaultVideoMaxFramerate,
5776 stream->GetVideoStreams()[0].max_framerate);
5777
5778 // Set max framerate and check that VideoStream.max_framerate is set.
5779 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5780 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5781 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5782 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5783
5784 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5785 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5786}
5787
Åsa Persson23eba222018-10-02 14:47:06 +02005788TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5789 FakeVideoSendStream* stream = AddSendStream();
5790
5791 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5792 EXPECT_EQ(1UL, parameters.encodings.size());
5793 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5794 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5795
5796 // Note that this is testing the behavior of the FakeVideoSendStream, which
5797 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5798 // we are just testing the behavior of
5799 // EncoderStreamFactory::CreateEncoderStreams.
5800 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5801 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5802
5803 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5804 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5805 parameters.encodings[0].num_temporal_layers = 2;
5806 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5807
5808 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5809 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5810}
5811
Seth Hampson7c682e02018-05-04 16:28:15 -07005812TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005813 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005814 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005815 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005816 // Two or more encodings should result in failure.
5817 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005818 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005819 // Zero encodings should also fail.
5820 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005821 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005822}
5823
Zach Stein3ca452b2018-01-18 10:01:24 -08005824TEST_F(WebRtcVideoChannelTest,
5825 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5826 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5827 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5828 AddSendStream(sp);
5829
5830 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5831
5832 // Additional encodings should result in failure.
5833 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005834 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005835 // Zero encodings should also fail.
5836 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005837 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005838}
5839
deadbeeffb2aced2017-01-06 23:05:37 -08005840// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005841TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005842 AddSendStream();
5843 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005844 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005845 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005846}
5847
Seth Hampson24722b32017-12-22 09:36:42 -08005848// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5849// a value <= 0, setting the parameters returns false.
5850TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5851 AddSendStream();
5852 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5853 EXPECT_EQ(1UL, parameters.encodings.size());
5854 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5855 parameters.encodings[0].bitrate_priority);
5856
5857 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005858 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005859 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005860 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005861}
5862
5863// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5864// properly on the VideoChannel and propogates down to the video encoder.
5865TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5866 AddSendStream();
5867 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5868 EXPECT_EQ(1UL, parameters.encodings.size());
5869 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5870 parameters.encodings[0].bitrate_priority);
5871
5872 // Change the value and set it on the VideoChannel.
5873 double new_bitrate_priority = 2.0;
5874 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005875 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005876
5877 // Verify that the encoding parameters bitrate_priority is set for the
5878 // VideoChannel.
5879 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5880 EXPECT_EQ(1UL, parameters.encodings.size());
5881 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5882
5883 // Verify that the new value propagated down to the encoder.
5884 std::vector<FakeVideoSendStream*> video_send_streams =
5885 fake_call_->GetVideoSendStreams();
5886 EXPECT_EQ(1UL, video_send_streams.size());
5887 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5888 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5889 // appropriately.
5890 EXPECT_EQ(new_bitrate_priority,
5891 video_send_stream->GetEncoderConfig().bitrate_priority);
5892 // Check that the vector of VideoStreams also was propagated correctly. Note
5893 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5894 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005895 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005896 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5897}
5898
5899// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5900// VideoChannel and the value propogates to the video encoder with all simulcast
5901// streams.
5902TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5903 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005904 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005905 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5906 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5907 AddSendStream(stream_params);
5908 uint32_t primary_ssrc = stream_params.first_ssrc();
5909
Niels Möller805a27e2019-01-21 12:21:27 +01005910 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005911 // frame. This creates multiple VideoStreams for all simulcast layers when
5912 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005913 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005914 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005915 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005916 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005917 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5918 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5919 rtc::kNumMicrosecsPerSec / 30));
5920
Seth Hampson24722b32017-12-22 09:36:42 -08005921 // Get and set the rtp encoding parameters.
5922 webrtc::RtpParameters parameters =
5923 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005924 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005925 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5926 parameters.encodings[0].bitrate_priority);
5927 // Change the value and set it on the VideoChannel.
5928 double new_bitrate_priority = 2.0;
5929 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005930 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005931
5932 // Verify that the encoding parameters priority is set on the VideoChannel.
5933 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005934 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005935 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5936
5937 // Verify that the new value propagated down to the encoder.
5938 std::vector<FakeVideoSendStream*> video_send_streams =
5939 fake_call_->GetVideoSendStreams();
5940 EXPECT_EQ(1UL, video_send_streams.size());
5941 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5942 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5943 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005944 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005945 video_send_stream->GetEncoderConfig().number_of_streams);
5946 EXPECT_EQ(new_bitrate_priority,
5947 video_send_stream->GetEncoderConfig().bitrate_priority);
5948 // Check that the vector of VideoStreams also propagated correctly. The
5949 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5950 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005951 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005952 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005953 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5954 // Since we are only setting bitrate priority per-sender, the other
5955 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005956 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005957 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005958 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005959 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005960 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005961}
5962
Tim Haloun648d28a2018-10-18 16:52:22 -07005963// RTCRtpEncodingParameters.network_priority must be one of a few values
5964// derived from the default priority, corresponding to very-low, low, medium,
5965// or high.
5966TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5967 AddSendStream();
5968 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5969 EXPECT_EQ(1UL, parameters.encodings.size());
5970 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5971 parameters.encodings[0].network_priority);
5972
5973 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5974 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5975 for (auto it : good_values) {
5976 parameters.encodings[0].network_priority = it;
5977 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5978 }
5979 for (auto it : bad_values) {
5980 parameters.encodings[0].network_priority = it;
5981 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5982 }
5983}
5984
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005985TEST_F(WebRtcVideoChannelTest,
5986 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005987 VideoSendParameters parameters;
5988 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005989 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5990 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5991
5992 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005993 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005994
5995 VideoOptions options;
5996 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5997 channel_->SetSend(true);
5998
5999 // Try layers in natural order (smallest to largest).
6000 {
6001 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6002 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6003 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6004 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6005 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6006 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6007 ASSERT_TRUE(result.ok());
6008
6009 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6010
6011 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6012 ASSERT_EQ(3u, video_streams.size());
6013 EXPECT_EQ(320u, video_streams[0].width);
6014 EXPECT_EQ(180u, video_streams[0].height);
6015 EXPECT_EQ(640u, video_streams[1].width);
6016 EXPECT_EQ(360u, video_streams[1].height);
6017 EXPECT_EQ(1280u, video_streams[2].width);
6018 EXPECT_EQ(720u, video_streams[2].height);
6019 }
6020
6021 // Try layers in reverse natural order (largest to smallest).
6022 {
6023 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6024 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6025 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6026 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6027 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6028 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6029 ASSERT_TRUE(result.ok());
6030
6031 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6032
6033 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6034 ASSERT_EQ(3u, video_streams.size());
6035 EXPECT_EQ(1280u, video_streams[0].width);
6036 EXPECT_EQ(720u, video_streams[0].height);
6037 EXPECT_EQ(640u, video_streams[1].width);
6038 EXPECT_EQ(360u, video_streams[1].height);
6039 EXPECT_EQ(320u, video_streams[2].width);
6040 EXPECT_EQ(180u, video_streams[2].height);
6041 }
6042
6043 // Try layers in mixed order.
6044 {
6045 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6046 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6047 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6048 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6049 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6050 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6051 ASSERT_TRUE(result.ok());
6052
6053 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6054
6055 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6056 ASSERT_EQ(3u, video_streams.size());
6057 EXPECT_EQ(128u, video_streams[0].width);
6058 EXPECT_EQ(72u, video_streams[0].height);
6059 EXPECT_EQ(640u, video_streams[1].width);
6060 EXPECT_EQ(360u, video_streams[1].height);
6061 EXPECT_EQ(320u, video_streams[2].width);
6062 EXPECT_EQ(180u, video_streams[2].height);
6063 }
6064
6065 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6066 {
6067 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6068 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6069 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6070 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6071 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6072 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6073 ASSERT_TRUE(result.ok());
6074
6075 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6076
6077 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6078 ASSERT_EQ(3u, video_streams.size());
6079 EXPECT_EQ(1280u, video_streams[0].width);
6080 EXPECT_EQ(720u, video_streams[0].height);
6081 EXPECT_EQ(1280u, video_streams[1].width);
6082 EXPECT_EQ(720u, video_streams[1].height);
6083 EXPECT_EQ(320u, video_streams[2].width);
6084 EXPECT_EQ(180u, video_streams[2].height);
6085 }
6086
6087 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6088}
6089
6090TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006091 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6092 // Ensure that the top layer has width and height divisible by 2^3,
6093 // so that the bottom layer has width and height divisible by 2.
6094 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6095 // the number of simulcast layers set by the app.
6096 webrtc::test::ScopedFieldTrials field_trial(
6097 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6098
6099 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6100 VideoSendParameters parameters;
6101 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6102 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6103 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6104 webrtc::test::FrameForwarder frame_forwarder;
6105 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6106 &frame_forwarder));
6107 channel_->SetSend(true);
6108
6109 // Set |scale_resolution_down_by|'s.
6110 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6111 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6112 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6113 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6114 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6115 const auto result =
6116 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6117 ASSERT_TRUE(result.ok());
6118
6119 // Use a capture resolution whose width and height are not divisible by 2^3.
6120 // (See field trial set at the top of the test.)
6121 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6122 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6123
6124 // Ensure the scaling is correct.
6125 const auto video_streams = stream->GetVideoStreams();
6126 ASSERT_EQ(video_streams.size(), 3u);
6127 // Ensure that we round the capture resolution down for the top layer...
6128 EXPECT_EQ(video_streams[0].width, 2000u);
6129 EXPECT_EQ(video_streams[0].height, 1200u);
6130 EXPECT_EQ(video_streams[1].width, 1000u);
6131 EXPECT_EQ(video_streams[1].height, 600u);
6132 // ...and that the bottom layer has a width/height divisible by 2.
6133 EXPECT_EQ(video_streams[2].width, 500u);
6134 EXPECT_EQ(video_streams[2].height, 300u);
6135
6136 // Tear down.
6137 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6138}
6139
6140TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006141 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006142 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6143 VideoSendParameters parameters;
6144 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006145 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6146 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6147
6148 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006149 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006150
6151 VideoOptions options;
6152 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6153 channel_->SetSend(true);
6154
6155 // Try layers in natural order (smallest to largest).
6156 {
6157 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6158 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6159 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6160 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6161 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6162 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6163 ASSERT_TRUE(result.ok());
6164
6165 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6166
6167 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6168 ASSERT_EQ(3u, video_streams.size());
6169 EXPECT_EQ(320u, video_streams[0].width);
6170 EXPECT_EQ(180u, video_streams[0].height);
6171 EXPECT_EQ(640u, video_streams[1].width);
6172 EXPECT_EQ(360u, video_streams[1].height);
6173 EXPECT_EQ(1280u, video_streams[2].width);
6174 EXPECT_EQ(720u, video_streams[2].height);
6175 }
6176
6177 // Try layers in reverse natural order (largest to smallest).
6178 {
6179 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6180 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6181 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6182 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6183 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6184 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6185 ASSERT_TRUE(result.ok());
6186
6187 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6188
6189 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6190 ASSERT_EQ(3u, video_streams.size());
6191 EXPECT_EQ(1280u, video_streams[0].width);
6192 EXPECT_EQ(720u, video_streams[0].height);
6193 EXPECT_EQ(640u, video_streams[1].width);
6194 EXPECT_EQ(360u, video_streams[1].height);
6195 EXPECT_EQ(320u, video_streams[2].width);
6196 EXPECT_EQ(180u, video_streams[2].height);
6197 }
6198
6199 // Try layers in mixed order.
6200 {
6201 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6202 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6203 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6204 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6205 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6206 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6207 ASSERT_TRUE(result.ok());
6208
6209 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6210
6211 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6212 ASSERT_EQ(3u, video_streams.size());
6213 EXPECT_EQ(128u, video_streams[0].width);
6214 EXPECT_EQ(72u, video_streams[0].height);
6215 EXPECT_EQ(640u, video_streams[1].width);
6216 EXPECT_EQ(360u, video_streams[1].height);
6217 EXPECT_EQ(320u, video_streams[2].width);
6218 EXPECT_EQ(180u, video_streams[2].height);
6219 }
6220
6221 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6222 {
6223 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6224 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6225 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6226 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6227 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6228 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6229 ASSERT_TRUE(result.ok());
6230
6231 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6232
6233 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6234 ASSERT_EQ(3u, video_streams.size());
6235 EXPECT_EQ(1280u, video_streams[0].width);
6236 EXPECT_EQ(720u, video_streams[0].height);
6237 EXPECT_EQ(1280u, video_streams[1].width);
6238 EXPECT_EQ(720u, video_streams[1].height);
6239 EXPECT_EQ(320u, video_streams[2].width);
6240 EXPECT_EQ(180u, video_streams[2].height);
6241 }
6242 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6243}
6244
Rasmus Brandt9387b522019-02-05 14:23:26 +01006245TEST_F(WebRtcVideoChannelTest,
6246 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6247 // Ensure that the top layer has width and height divisible by 2^3,
6248 // so that the bottom layer has width and height divisible by 2.
6249 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6250 // the number of simulcast layers set by the app.
6251 webrtc::test::ScopedFieldTrials field_trial(
6252 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6253
6254 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6255 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6256 VideoSendParameters parameters;
6257 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6258 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6259 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6260 webrtc::test::FrameForwarder frame_forwarder;
6261 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6262 &frame_forwarder));
6263 channel_->SetSend(true);
6264
6265 // Set |scale_resolution_down_by|'s.
6266 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6267 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6268 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6269 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6270 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6271 const auto result =
6272 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6273 ASSERT_TRUE(result.ok());
6274
6275 // Use a capture resolution whose width and height are not divisible by 2^3.
6276 // (See field trial set at the top of the test.)
6277 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6278 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6279
6280 // Ensure the scaling is correct.
6281 const auto video_streams = stream->GetVideoStreams();
6282 ASSERT_EQ(video_streams.size(), 3u);
6283 // Ensure that we round the capture resolution down for the top layer...
6284 EXPECT_EQ(video_streams[0].width, 2000u);
6285 EXPECT_EQ(video_streams[0].height, 1200u);
6286 EXPECT_EQ(video_streams[1].width, 1000u);
6287 EXPECT_EQ(video_streams[1].height, 600u);
6288 // ...and that the bottom layer has a width/height divisible by 2.
6289 EXPECT_EQ(video_streams[2].width, 500u);
6290 EXPECT_EQ(video_streams[2].height, 300u);
6291
6292 // Tear down.
6293 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6294}
6295
Åsa Persson8c1bf952018-09-13 10:42:19 +02006296TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6297 const size_t kNumSimulcastStreams = 3;
6298 SetUpSimulcast(true, false);
6299
6300 // Get and set the rtp encoding parameters.
6301 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6302 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6303 for (const auto& encoding : parameters.encodings) {
6304 EXPECT_FALSE(encoding.max_framerate);
6305 }
6306
6307 // Change the value and set it on the VideoChannel.
6308 parameters.encodings[0].max_framerate = 10;
6309 parameters.encodings[1].max_framerate = 20;
6310 parameters.encodings[2].max_framerate = 25;
6311 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6312
6313 // Verify that the bitrates are set on the VideoChannel.
6314 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6315 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6316 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6317 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6318 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6319}
6320
Åsa Persson23eba222018-10-02 14:47:06 +02006321TEST_F(WebRtcVideoChannelTest,
6322 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6323 const size_t kNumSimulcastStreams = 3;
6324 SetUpSimulcast(true, false);
6325
6326 // Get and set the rtp encoding parameters.
6327 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6328 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6329
6330 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6331 parameters.encodings[0].num_temporal_layers = 0;
6332 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6333 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6334 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6335 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6336 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6337}
6338
6339TEST_F(WebRtcVideoChannelTest,
6340 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6341 const size_t kNumSimulcastStreams = 3;
6342 SetUpSimulcast(true, false);
6343
6344 // Get and set the rtp encoding parameters.
6345 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6346 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6347
6348 // No/all layers should be set.
6349 parameters.encodings[0].num_temporal_layers = 1;
6350 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6351 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6352
6353 // Different values not supported.
6354 parameters.encodings[0].num_temporal_layers = 1;
6355 parameters.encodings[1].num_temporal_layers = 2;
6356 parameters.encodings[2].num_temporal_layers = 2;
6357 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6358 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6359}
6360
6361TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6362 const size_t kNumSimulcastStreams = 3;
6363 SetUpSimulcast(true, false);
6364
6365 // Get and set the rtp encoding parameters.
6366 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6367 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6368 for (const auto& encoding : parameters.encodings)
6369 EXPECT_FALSE(encoding.num_temporal_layers);
6370
6371 // Change the value and set it on the VideoChannel.
6372 parameters.encodings[0].num_temporal_layers = 3;
6373 parameters.encodings[1].num_temporal_layers = 3;
6374 parameters.encodings[2].num_temporal_layers = 3;
6375 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6376
6377 // Verify that the number of temporal layers are set on the VideoChannel.
6378 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6379 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6380 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6381 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6382 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6383}
6384
6385TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6386 const size_t kNumSimulcastStreams = 3;
6387 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6388
6389 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006390 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006391 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006392 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006393 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006394 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006395
6396 // Get and set the rtp encoding parameters.
6397 // Change the value and set it on the VideoChannel.
6398 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6399 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6400 parameters.encodings[0].num_temporal_layers = 2;
6401 parameters.encodings[1].num_temporal_layers = 2;
6402 parameters.encodings[2].num_temporal_layers = 2;
6403 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6404
6405 // Verify that the new value is propagated down to the encoder.
6406 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6407 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6408 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6409 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6410 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6411 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6412 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6413 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6414
6415 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6416 // VideoStreams are created appropriately for the simulcast case.
6417 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6418 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6419 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6420 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6421
6422 // No parameter changed, encoder should not be reconfigured.
6423 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6424 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6425
6426 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6427}
6428
6429TEST_F(WebRtcVideoChannelTest,
6430 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6431 const size_t kDefaultNumTemporalLayers = 3;
6432 const size_t kNumSimulcastStreams = 3;
6433 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6434
6435 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006436 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006437 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006438 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006439 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006440 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006441
6442 // Change rtp encoding parameters, num_temporal_layers not changed.
6443 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6444 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6445 parameters.encodings[0].min_bitrate_bps = 33000;
6446 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6447
6448 // Verify that no value is propagated down to the encoder.
6449 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6450 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6451 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6452 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6453 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6454 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6455
6456 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6457 // VideoStreams are created appropriately for the simulcast case.
6458 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6459 EXPECT_EQ(kDefaultNumTemporalLayers,
6460 stream->GetVideoStreams()[0].num_temporal_layers);
6461 EXPECT_EQ(kDefaultNumTemporalLayers,
6462 stream->GetVideoStreams()[1].num_temporal_layers);
6463 EXPECT_EQ(kDefaultNumTemporalLayers,
6464 stream->GetVideoStreams()[2].num_temporal_layers);
6465
6466 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6467}
6468
Åsa Persson8c1bf952018-09-13 10:42:19 +02006469TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6470 const size_t kNumSimulcastStreams = 3;
6471 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6472
6473 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006474 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006475 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006476 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006477 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006478 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006479
6480 // Get and set the rtp encoding parameters.
6481 // Change the value and set it on the VideoChannel.
6482 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6483 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6484 parameters.encodings[0].max_framerate = 15;
6485 parameters.encodings[1].max_framerate = 25;
6486 parameters.encodings[2].max_framerate = 20;
6487 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6488
6489 // Verify that the new value propagated down to the encoder.
6490 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6491 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6492 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6493 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6494 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6495 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6496 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6497 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6498
6499 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6500 // VideoStreams are created appropriately for the simulcast case.
6501 // Currently the maximum |max_framerate| is used.
6502 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6503 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6504 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6505 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6506
6507 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6508}
6509
6510TEST_F(WebRtcVideoChannelTest,
6511 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6512 const size_t kNumSimulcastStreams = 3;
6513 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6514 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6515
6516 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006517 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006518 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006519 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006520 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006521 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006522
6523 // Get and set the rtp encoding parameters.
6524 // Change the value and set it on the VideoChannel.
6525 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6526 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6527 parameters.encodings[0].max_framerate = 15;
6528 parameters.encodings[2].max_framerate = 20;
6529 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6530
6531 // Verify that the new value propagated down to the encoder.
6532 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6533 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6534 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6535 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6536 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6537 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6538 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6539
6540 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6541 // VideoStreams are created appropriately for the simulcast case.
6542 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6543 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6544 EXPECT_EQ(kDefaultVideoMaxFramerate,
6545 stream->GetVideoStreams()[0].max_framerate);
6546 EXPECT_EQ(kDefaultVideoMaxFramerate,
6547 stream->GetVideoStreams()[1].max_framerate);
6548 EXPECT_EQ(kDefaultVideoMaxFramerate,
6549 stream->GetVideoStreams()[2].max_framerate);
6550
6551 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6552}
6553
Åsa Persson55659812018-06-18 17:51:32 +02006554TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6555 const size_t kNumSimulcastStreams = 3;
6556 SetUpSimulcast(true, false);
6557
6558 // Get and set the rtp encoding parameters.
6559 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6560 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6561 for (const auto& encoding : parameters.encodings) {
6562 EXPECT_FALSE(encoding.min_bitrate_bps);
6563 EXPECT_FALSE(encoding.max_bitrate_bps);
6564 }
6565
6566 // Change the value and set it on the VideoChannel.
6567 parameters.encodings[0].min_bitrate_bps = 100000;
6568 parameters.encodings[0].max_bitrate_bps = 200000;
6569 parameters.encodings[1].min_bitrate_bps = 300000;
6570 parameters.encodings[1].max_bitrate_bps = 400000;
6571 parameters.encodings[2].min_bitrate_bps = 500000;
6572 parameters.encodings[2].max_bitrate_bps = 600000;
6573 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6574
6575 // Verify that the bitrates are set on the VideoChannel.
6576 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6577 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6578 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6579 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6580 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6581 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6582 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6583 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6584}
6585
6586TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6587 const size_t kNumSimulcastStreams = 3;
6588 SetUpSimulcast(true, false);
6589
6590 // Get and set the rtp encoding parameters.
6591 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6592 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6593
6594 // Max bitrate lower than min bitrate should fail.
6595 parameters.encodings[2].min_bitrate_bps = 100000;
6596 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6597 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6598 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6599}
6600
6601// Test that min and max bitrate values set via RtpParameters are correctly
6602// propagated to the underlying encoder, and that the target is set to 3/4 of
6603// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6604// that are used if no min/max are specified).
6605TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6606 const size_t kNumSimulcastStreams = 3;
6607 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6608
6609 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006610 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006611 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006612 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006613 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006614 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006615
6616 // Get and set the rtp encoding parameters.
6617 // Change the value and set it on the VideoChannel.
6618 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6619 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6620 parameters.encodings[0].min_bitrate_bps = 100000;
6621 parameters.encodings[0].max_bitrate_bps = 200000;
6622 parameters.encodings[1].min_bitrate_bps = 300000;
6623 parameters.encodings[1].max_bitrate_bps = 400000;
6624 parameters.encodings[2].min_bitrate_bps = 500000;
6625 parameters.encodings[2].max_bitrate_bps = 600000;
6626 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6627
6628 // Verify that the new value propagated down to the encoder.
6629 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6630 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6631 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6632 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6633 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6634 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6635 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6636 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6637 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6638 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6639 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6640
6641 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6642 // VideoStreams are created appropriately for the simulcast case.
6643 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6644 // Target bitrate: 200000 * 3 / 4 = 150000.
6645 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6646 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6647 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6648 // Target bitrate: 400000 * 3 / 4 = 300000.
6649 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6650 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6651 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6652 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6653 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6654 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6655 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6656
6657 // No parameter changed, encoder should not be reconfigured.
6658 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6659 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6660
6661 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6662}
6663
6664// Test to only specify the min or max bitrate value for a layer via
6665// RtpParameters. The unspecified min/max and target value should be set to the
6666// simulcast default that is used if no min/max are specified.
6667TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6668 const size_t kNumSimulcastStreams = 3;
6669 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6670 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6671
6672 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006673 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006674 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006675 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006676 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006677 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006678
6679 // Get and set the rtp encoding parameters.
6680 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6681 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6682
6683 // Change the value and set it on the VideoChannel.
6684 // Layer 0: only configure min bitrate.
6685 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6686 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6687 // Layer 1: only configure max bitrate.
6688 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6689 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6690 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6691
6692 // Verify that the new value propagated down to the encoder.
6693 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6694 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6695 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6696 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6697 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6698 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6699 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6700 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6701 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6702 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6703
6704 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6705 // VideoStreams are created appropriately for the simulcast case.
6706 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6707 // Layer 0: min configured bitrate should overwrite min default.
6708 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6709 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6710 stream->GetVideoStreams()[0].target_bitrate_bps);
6711 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6712 stream->GetVideoStreams()[0].max_bitrate_bps);
6713 // Layer 1: max configured bitrate should overwrite max default.
6714 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6715 stream->GetVideoStreams()[1].min_bitrate_bps);
6716 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6717 stream->GetVideoStreams()[1].target_bitrate_bps);
6718 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6719 // Layer 2: min and max bitrate not configured, default expected.
6720 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6721 stream->GetVideoStreams()[2].min_bitrate_bps);
6722 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6723 stream->GetVideoStreams()[2].target_bitrate_bps);
6724 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6725 stream->GetVideoStreams()[2].max_bitrate_bps);
6726
6727 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6728}
6729
6730// Test that specifying the min (or max) bitrate value for a layer via
6731// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6732// unspecified values accordingly.
6733TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6734 const size_t kNumSimulcastStreams = 3;
6735 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6736 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6737
6738 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006739 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006740 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006741 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006742 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006743 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006744
6745 // Get and set the rtp encoding parameters.
6746 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6747 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6748
6749 // Change the value and set it on the VideoChannel.
6750 // For layer 0, set the min bitrate above the default max.
6751 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6752 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6753 // For layer 1, set the max bitrate below the default min.
6754 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6755 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6756 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6757
6758 // Verify that the new value propagated down to the encoder.
6759 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6760 // VideoStreams are created appropriately for the simulcast case.
6761 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6762 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6763 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6764 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6765 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6766 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6767 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6768 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6769 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6770 // Layer 2: min and max bitrate not configured, default expected.
6771 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6772 stream->GetVideoStreams()[2].min_bitrate_bps);
6773 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6774 stream->GetVideoStreams()[2].target_bitrate_bps);
6775 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6776 stream->GetVideoStreams()[2].max_bitrate_bps);
6777
6778 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6779}
6780
6781TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6782 const size_t kNumSimulcastStreams = 3;
6783 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6784 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6785
6786 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006787 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006788 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006789 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006790 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006791 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006792
6793 // Set max bitrate for all but the highest layer.
6794 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6795 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6796 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6797 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6798 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6799
6800 // Set max bandwidth equal to total max bitrate.
6801 send_parameters_.max_bandwidth_bps =
6802 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6803 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6804 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6805
6806 // No bitrate above the total max to give to the highest layer.
6807 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6808 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6809 stream->GetVideoStreams()[2].max_bitrate_bps);
6810
6811 // Set max bandwidth above the total max bitrate.
6812 send_parameters_.max_bandwidth_bps =
6813 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6814 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6815 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6816
6817 // The highest layer has no max bitrate set -> the bitrate above the total
6818 // max should be given to the highest layer.
6819 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6820 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6821 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6822 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6823 stream->GetVideoStreams()[2].max_bitrate_bps);
6824
6825 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6826}
6827
6828TEST_F(WebRtcVideoChannelTest,
6829 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6830 const size_t kNumSimulcastStreams = 3;
6831 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6832 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6833 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6834
6835 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006836 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006837 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006838 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006839 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006840 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006841
6842 // Set max bitrate for the highest layer.
6843 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6844 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6845 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6846 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6847
6848 // Set max bandwidth above the total max bitrate.
6849 send_parameters_.max_bandwidth_bps =
6850 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6851 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6852 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6853
6854 // The highest layer has the max bitrate set -> the bitrate above the total
6855 // max should not be given to the highest layer.
6856 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6857 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6858 stream->GetVideoStreams()[2].max_bitrate_bps);
6859
6860 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6861}
6862
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006863// Test that min and max bitrate values set via RtpParameters are correctly
6864// propagated to the underlying encoder for a single stream.
6865TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6866 FakeVideoSendStream* stream = AddSendStream();
6867 EXPECT_TRUE(channel_->SetSend(true));
6868 EXPECT_TRUE(stream->IsSending());
6869
6870 // Set min and max bitrate.
6871 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6872 EXPECT_EQ(1u, parameters.encodings.size());
6873 parameters.encodings[0].min_bitrate_bps = 80000;
6874 parameters.encodings[0].max_bitrate_bps = 150000;
6875 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6876
6877 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6878 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6879 EXPECT_EQ(1u, encoder_config.number_of_streams);
6880 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6881 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6882 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6883
6884 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6885 // VideoStreams are created appropriately.
6886 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6887 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6888 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6889 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6890}
6891
6892// Test the default min and max bitrate value are correctly propagated to the
6893// underlying encoder for a single stream (when the values are not set via
6894// RtpParameters).
6895TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6896 FakeVideoSendStream* stream = AddSendStream();
6897 EXPECT_TRUE(channel_->SetSend(true));
6898 EXPECT_TRUE(stream->IsSending());
6899
6900 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6901 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6902 EXPECT_EQ(1u, encoder_config.number_of_streams);
6903 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6904 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6905 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6906
6907 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6908 // VideoStreams are created appropriately.
6909 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6910 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6911 stream->GetVideoStreams()[0].min_bitrate_bps);
6912 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6913 stream->GetVideoStreams()[0].min_bitrate_bps);
6914 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6915 stream->GetVideoStreams()[0].target_bitrate_bps);
6916}
6917
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006918// Test that a stream will not be sending if its encoding is made inactive
6919// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006920TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006921 FakeVideoSendStream* stream = AddSendStream();
6922 EXPECT_TRUE(channel_->SetSend(true));
6923 EXPECT_TRUE(stream->IsSending());
6924
6925 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006926 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006927 ASSERT_EQ(1u, parameters.encodings.size());
6928 ASSERT_TRUE(parameters.encodings[0].active);
6929 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006930 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006931 EXPECT_FALSE(stream->IsSending());
6932
6933 // Now change it back to active and verify we resume sending.
6934 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006935 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006936 EXPECT_TRUE(stream->IsSending());
6937}
6938
Seth Hampson8234ead2018-02-02 15:16:24 -08006939// Tests that when active is updated for any simulcast layer then the send
6940// stream's sending state will be updated and it will be reconfigured with the
6941// new appropriate active simulcast streams.
6942TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6943 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006944 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006945 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6946 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6947 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6948 uint32_t primary_ssrc = stream_params.first_ssrc();
6949
Niels Möller805a27e2019-01-21 12:21:27 +01006950 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006951 // frame. This allows us to test that ReconfigureEncoder is called
6952 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006953 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006954 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006955 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006956 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006957 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6958 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6959 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006960
6961 // Check that all encodings are initially active.
6962 webrtc::RtpParameters parameters =
6963 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006964 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006965 EXPECT_TRUE(parameters.encodings[0].active);
6966 EXPECT_TRUE(parameters.encodings[1].active);
6967 EXPECT_TRUE(parameters.encodings[2].active);
6968 EXPECT_TRUE(fake_video_send_stream->IsSending());
6969
6970 // Only turn on only the middle stream.
6971 parameters.encodings[0].active = false;
6972 parameters.encodings[1].active = true;
6973 parameters.encodings[2].active = false;
6974 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6975 // Verify that the active fields are set on the VideoChannel.
6976 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006977 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006978 EXPECT_FALSE(parameters.encodings[0].active);
6979 EXPECT_TRUE(parameters.encodings[1].active);
6980 EXPECT_FALSE(parameters.encodings[2].active);
6981 // Check that the VideoSendStream is updated appropriately. This means its
6982 // send state was updated and it was reconfigured.
6983 EXPECT_TRUE(fake_video_send_stream->IsSending());
6984 std::vector<webrtc::VideoStream> simulcast_streams =
6985 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006986 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006987 EXPECT_FALSE(simulcast_streams[0].active);
6988 EXPECT_TRUE(simulcast_streams[1].active);
6989 EXPECT_FALSE(simulcast_streams[2].active);
6990
6991 // Turn off all streams.
6992 parameters.encodings[0].active = false;
6993 parameters.encodings[1].active = false;
6994 parameters.encodings[2].active = false;
6995 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6996 // Verify that the active fields are set on the VideoChannel.
6997 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006998 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006999 EXPECT_FALSE(parameters.encodings[0].active);
7000 EXPECT_FALSE(parameters.encodings[1].active);
7001 EXPECT_FALSE(parameters.encodings[2].active);
7002 // Check that the VideoSendStream is off.
7003 EXPECT_FALSE(fake_video_send_stream->IsSending());
7004 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007005 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007006 EXPECT_FALSE(simulcast_streams[0].active);
7007 EXPECT_FALSE(simulcast_streams[1].active);
7008 EXPECT_FALSE(simulcast_streams[2].active);
7009
Niels Möllerff40b142018-04-09 08:49:14 +02007010 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007011}
7012
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007013// Test that if a stream is reconfigured (due to a codec change or other
7014// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007015TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007016 InactiveStreamDoesntStartSendingWhenReconfigured) {
7017 // Set an initial codec list, which will be modified later.
7018 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007019 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7020 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007021 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7022
7023 FakeVideoSendStream* stream = AddSendStream();
7024 EXPECT_TRUE(channel_->SetSend(true));
7025 EXPECT_TRUE(stream->IsSending());
7026
7027 // Get current parameters and change "active" to false.
7028 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7029 ASSERT_EQ(1u, parameters.encodings.size());
7030 ASSERT_TRUE(parameters.encodings[0].active);
7031 parameters.encodings[0].active = false;
7032 EXPECT_EQ(1u, GetFakeSendStreams().size());
7033 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007034 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007035 EXPECT_FALSE(stream->IsSending());
7036
7037 // Reorder the codec list, causing the stream to be reconfigured.
7038 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007039 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7040 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007041 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7042 auto new_streams = GetFakeSendStreams();
7043 // Assert that a new underlying stream was created due to the codec change.
7044 // Otherwise, this test isn't testing what it set out to test.
7045 EXPECT_EQ(1u, GetFakeSendStreams().size());
7046 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7047
7048 // Verify that we still are not sending anything, due to the inactive
7049 // encoding.
7050 EXPECT_FALSE(new_streams[0]->IsSending());
7051}
7052
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007053// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007054TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007055 AddSendStream();
7056 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007057 parameters.codecs.push_back(GetEngineCodec("VP8"));
7058 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007059 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7060
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007061 webrtc::RtpParameters rtp_parameters =
7062 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007063 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007064 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7065 rtp_parameters.codecs[0]);
7066 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7067 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007068}
7069
Florent Castellidacec712018-05-24 16:24:21 +02007070// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7071TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7072 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7073 params.cname = "rtcpcname";
7074 AddSendStream(params);
7075
7076 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7077 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7078}
7079
deadbeeffb2aced2017-01-06 23:05:37 -08007080// Test that RtpParameters for send stream has one encoding and it has
7081// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007082TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007083 AddSendStream();
7084
7085 webrtc::RtpParameters rtp_parameters =
7086 channel_->GetRtpSendParameters(last_ssrc_);
7087 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007088 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007089}
7090
Florent Castelliabe301f2018-06-12 18:33:49 +02007091TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7092 AddSendStream();
7093
7094 webrtc::RtpParameters rtp_parameters =
7095 channel_->GetRtpSendParameters(last_ssrc_);
7096 rtp_parameters.header_extensions.emplace_back();
7097
7098 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7099
7100 webrtc::RTCError result =
7101 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7102 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7103}
7104
Florent Castelli87b3c512018-07-18 16:00:28 +02007105TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7106 AddSendStream();
7107
Niels Möller805a27e2019-01-21 12:21:27 +01007108 webrtc::test::FrameForwarder frame_forwarder;
7109 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007110
7111 webrtc::RtpParameters rtp_parameters =
7112 channel_->GetRtpSendParameters(last_ssrc_);
7113 EXPECT_EQ(rtp_parameters.degradation_preference,
7114 webrtc::DegradationPreference::BALANCED);
7115 rtp_parameters.degradation_preference =
7116 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7117
7118 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7119
7120 webrtc::RtpParameters updated_rtp_parameters =
7121 channel_->GetRtpSendParameters(last_ssrc_);
7122 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7123 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7124
7125 // Remove the source since it will be destroyed before the channel
7126 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7127}
7128
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007129// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007130TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007131 AddSendStream();
7132 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007133 parameters.codecs.push_back(GetEngineCodec("VP8"));
7134 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007135 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7136
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007137 webrtc::RtpParameters initial_params =
7138 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007139
7140 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007141 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007142
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007143 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7144 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7145}
7146
7147// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007148TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007149 AddRecvStream();
7150 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007151 parameters.codecs.push_back(GetEngineCodec("VP8"));
7152 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007153 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7154
7155 webrtc::RtpParameters rtp_parameters =
7156 channel_->GetRtpReceiveParameters(last_ssrc_);
7157 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007158 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7159 rtp_parameters.codecs[0]);
7160 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7161 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007162}
7163
johan073ece42016-08-26 02:59:47 -07007164#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007165TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007166#else
eladalonf1841382017-06-12 01:16:46 -07007167TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007168#endif
johan3859c892016-08-05 09:19:25 -07007169 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007170 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007171 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007172 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007173 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007174 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007175 parameters.codecs.push_back(kH264sprop2);
7176 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7177
7178 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7179 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7180 webrtc::RtpParameters rtp_parameters =
7181 channel_->GetRtpReceiveParameters(last_ssrc_);
7182 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7183 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7184 ASSERT_EQ(2u, cfg.decoders.size());
7185 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007186 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007187 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007188 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7189 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007190 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007191
7192 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007193 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007194 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007195 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7196 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007197 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007198}
7199
sakal1fd95952016-06-22 00:46:15 -07007200// Test that RtpParameters for receive stream has one encoding and it has
7201// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007202TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007203 AddRecvStream();
7204
7205 webrtc::RtpParameters rtp_parameters =
7206 channel_->GetRtpReceiveParameters(last_ssrc_);
7207 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007208 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007209}
7210
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007211// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007212TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007213 AddRecvStream();
7214 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007215 parameters.codecs.push_back(GetEngineCodec("VP8"));
7216 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007217 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7218
7219 webrtc::RtpParameters initial_params =
7220 channel_->GetRtpReceiveParameters(last_ssrc_);
7221
7222 // We should be able to set the params we just got.
7223 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7224
7225 // ... And this shouldn't change the params returned by
7226 // GetRtpReceiveParameters.
7227 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007228}
7229
deadbeef3bc15102017-04-20 19:25:07 -07007230// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7231// aren't signaled. It should always return an empty "RtpEncodingParameters",
7232// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007233TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007234 // Call necessary methods to configure receiving a default stream as
7235 // soon as it arrives.
7236 cricket::VideoRecvParameters parameters;
7237 parameters.codecs.push_back(GetEngineCodec("VP8"));
7238 parameters.codecs.push_back(GetEngineCodec("VP9"));
7239 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7240
7241 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7242 // stream. Should return nothing.
7243 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7244
7245 // Set a sink for an unsignaled stream.
7246 cricket::FakeVideoRenderer renderer;
7247 // Value of "0" means "unsignaled stream".
7248 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7249
7250 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7251 // in this method means "unsignaled stream".
7252 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7253 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7254 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7255
7256 // Receive VP8 packet.
7257 uint8_t data[kMinRtpPacketLen];
7258 cricket::RtpHeader rtpHeader;
7259 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7260 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7261 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7262 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7263 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007264 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007265
7266 // The |ssrc| member should still be unset.
7267 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7268 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7269 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7270}
7271
eladalonf1841382017-06-12 01:16:46 -07007272void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007273 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007274 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007275
7276 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007277 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007278 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007279 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007280
7281 if (receiver_first) {
7282 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7283 std::vector<FakeVideoReceiveStream*> receive_streams =
7284 fake_call_->GetVideoReceiveStreams();
7285 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007286 // Default local SSRC when we have no sender.
7287 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7288 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007289 }
7290 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7291 if (!receiver_first)
7292 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7293 std::vector<FakeVideoReceiveStream*> receive_streams =
7294 fake_call_->GetVideoReceiveStreams();
7295 ASSERT_EQ(1u, receive_streams.size());
7296 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007297
7298 // Removing first sender should fall back to another (in this case the second)
7299 // local send stream's SSRC.
7300 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7301 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007302 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007303 ASSERT_EQ(1u, receive_streams.size());
7304 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7305
7306 // Removing the last sender should fall back to default local SSRC.
7307 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007308 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007309 ASSERT_EQ(1u, receive_streams.size());
7310 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7311 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007312}
7313
eladalonf1841382017-06-12 01:16:46 -07007314TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007315 TestReceiverLocalSsrcConfiguration(false);
7316}
7317
eladalonf1841382017-06-12 01:16:46 -07007318TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007319 TestReceiverLocalSsrcConfiguration(true);
7320}
7321
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007322class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007323 public:
eladalonf1841382017-06-12 01:16:46 -07007324 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007325 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007326 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7327 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007328 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007329 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007330 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007331 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007332 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007333 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007334 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007335
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007336 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007337 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007338 channel_.reset(engine_.CreateMediaChannel(
7339 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7340 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007341 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007342 last_ssrc_ = 123;
7343 }
7344
7345 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007346 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007347 int capture_width,
7348 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007349 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007350 size_t expected_num_streams,
7351 bool screenshare,
7352 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007353 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007354 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007355 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007356 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007357
Peter Boström0c4e06b2015-10-07 12:23:21 +02007358 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007359 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007360 ssrcs.resize(num_configured_streams);
7361
sprangf24a0642017-02-28 13:23:26 -08007362 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007363 // Send a full-size frame to trigger a stream reconfiguration to use all
7364 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007365 webrtc::test::FrameForwarder frame_forwarder;
7366 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7367 rtc::kNumMicrosecsPerSec / 30);
7368
sprangf24a0642017-02-28 13:23:26 -08007369 VideoOptions options;
7370 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007371 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007372 EXPECT_TRUE(
7373 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007374 // Fetch the latest stream since SetVideoSend() may recreate it if the
7375 // screen content setting is changed.
7376 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007377 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007378 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007379
Zach Stein3ca452b2018-01-18 10:01:24 -08007380 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7381 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7382
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007383 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7384 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007385 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007386
sprang429600d2017-01-26 06:12:26 -08007387 std::vector<webrtc::VideoStream> expected_streams;
7388 if (conference_mode) {
7389 expected_streams = GetSimulcastConfig(
7390 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08007391 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02007392 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08007393 if (screenshare) {
7394 for (const webrtc::VideoStream& stream : expected_streams) {
7395 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007396 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7397 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007398 }
7399 }
sprang429600d2017-01-26 06:12:26 -08007400 } else {
7401 webrtc::VideoStream stream;
7402 stream.width = capture_width;
7403 stream.height = capture_height;
7404 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007405 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007406 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007407 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007408 stream.max_qp = kDefaultQpMax;
7409 expected_streams.push_back(stream);
7410 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007411
7412 ASSERT_EQ(expected_streams.size(), video_streams.size());
7413
7414 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007415 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007416 for (size_t i = 0; i < num_streams; ++i) {
7417 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7418 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7419
7420 EXPECT_GT(video_streams[i].max_framerate, 0);
7421 EXPECT_EQ(expected_streams[i].max_framerate,
7422 video_streams[i].max_framerate);
7423
7424 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7425 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7426 video_streams[i].min_bitrate_bps);
7427
7428 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7429 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7430 video_streams[i].target_bitrate_bps);
7431
7432 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7433 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7434 video_streams[i].max_bitrate_bps);
7435
7436 EXPECT_GT(video_streams[i].max_qp, 0);
7437 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7438
Sergey Silkina796a7e2018-03-01 15:11:29 +01007439 EXPECT_EQ(conference_mode,
7440 expected_streams[i].num_temporal_layers.has_value());
7441
7442 if (conference_mode) {
7443 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7444 video_streams[i].num_temporal_layers);
7445 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007446
7447 if (i == num_streams - 1) {
7448 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7449 } else {
7450 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7451 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007452 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007453
Niels Möllerff40b142018-04-09 08:49:14 +02007454 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007455 }
7456
7457 FakeVideoSendStream* AddSendStream() {
7458 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7459 }
7460
7461 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007462 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007463 EXPECT_TRUE(channel_->AddSendStream(sp));
7464 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007465 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007466 EXPECT_EQ(num_streams + 1, streams.size());
7467 return streams[streams.size() - 1];
7468 }
7469
7470 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007471 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007472 }
7473
7474 FakeVideoReceiveStream* AddRecvStream() {
7475 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7476 }
7477
7478 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007479 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007480 EXPECT_TRUE(channel_->AddRecvStream(sp));
7481 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007482 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007483 EXPECT_EQ(num_streams + 1, streams.size());
7484 return streams[streams.size() - 1];
7485 }
7486
skvlad11a9cbf2016-10-07 11:53:05 -07007487 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007488 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007489 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7490 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007491 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7492 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007493 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007494 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007495 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007496};
7497
eladalonf1841382017-06-12 01:16:46 -07007498TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007499 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7500 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007501}
7502
eladalonf1841382017-06-12 01:16:46 -07007503TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007504 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7505 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007506}
7507
7508// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007509TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007510 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7511 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007512}
sprang429600d2017-01-26 06:12:26 -08007513
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007514TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007515 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7516 false);
7517}
7518
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007519TEST_F(WebRtcVideoChannelSimulcastTest,
7520 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007521 webrtc::test::ScopedFieldTrials field_trials(
7522 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007523 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7524 true);
7525}
7526
eladalonf1841382017-06-12 01:16:46 -07007527TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007528 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7529 true);
7530}
7531
eladalonf1841382017-06-12 01:16:46 -07007532TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007533 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007534 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7535 false);
7536}
7537
Chen Xing90f3b892019-06-25 10:16:14 +02007538TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7539 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007540
Chen Xing90f3b892019-06-25 10:16:14 +02007541 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007542 EXPECT_TRUE(SetDefaultCodec());
7543 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007544 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007545
Chen Xing90f3b892019-06-25 10:16:14 +02007546 // Send and receive one frame.
7547 SendFrame();
7548 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007549
Chen Xing90f3b892019-06-25 10:16:14 +02007550 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7551 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7552 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007553
Chen Xing90f3b892019-06-25 10:16:14 +02007554 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7555 EXPECT_EQ(source.source_id(), kSsrc);
7556 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7557 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7558 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007559
Chen Xing90f3b892019-06-25 10:16:14 +02007560 // Send and receive another frame.
7561 SendFrame();
7562 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007563
Chen Xing90f3b892019-06-25 10:16:14 +02007564 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7565 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7566 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007567
Chen Xing90f3b892019-06-25 10:16:14 +02007568 source = channel_->GetSources(kSsrc)[0];
7569 EXPECT_EQ(source.source_id(), kSsrc);
7570 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7571 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7572 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007573
Chen Xing90f3b892019-06-25 10:16:14 +02007574 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7575 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007576}
7577
Amit Hilbuchb000b712019-02-25 10:22:14 -08007578TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7579 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7580
7581 std::vector<std::string> rids = {"f", "h", "q"};
7582 std::vector<cricket::RidDescription> rid_descriptions;
7583 for (const auto& rid : rids) {
7584 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7585 }
7586 sp.set_rids(rid_descriptions);
7587
7588 ASSERT_TRUE(channel_->AddSendStream(sp));
7589 const auto& streams = fake_call_->GetVideoSendStreams();
7590 ASSERT_EQ(1u, streams.size());
7591 auto stream = streams[0];
7592 ASSERT_NE(stream, nullptr);
7593 const auto& config = stream->GetConfig();
7594 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7595}
7596
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007597} // namespace cricket