blob: dc94f5dd89abe87ebcc25cfe92bbfc478e4543e5 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020013#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Steve Anton2c9ebef2019-01-28 17:27:58 -080017#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010018#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020019#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070020#include "api/media_transport_config.h"
Steve Anton10542f22019-01-11 09:11:00 -080021#include "api/rtp_parameters.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070022#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080023#include "api/test/mock_video_bitrate_allocator.h"
24#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070025#include "api/test/mock_video_decoder_factory.h"
26#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020027#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080028#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010029#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020030#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020031#include "api/video_codecs/builtin_video_decoder_factory.h"
32#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020033#include "api/video_codecs/sdp_video_format.h"
34#include "api/video_codecs/video_decoder_factory.h"
35#include "api/video_codecs/video_encoder.h"
36#include "api/video_codecs/video_encoder_factory.h"
37#include "call/flexfec_receive_stream.h"
38#include "common_video/h264/profile_level_id.h"
39#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010040#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080041#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080042#include "media/base/fake_video_renderer.h"
43#include "media/base/media_constants.h"
44#include "media/base/rtp_utils.h"
45#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080047#include "media/engine/fake_webrtc_call.h"
48#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/webrtc_video_engine.h"
51#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020052#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020053#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080054#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020056#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080057#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020058#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010059#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000061
Mirko Bonadei6a489f22019-04-09 15:11:12 +020062using ::testing::Field;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010063using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070064using webrtc::RtpExtension;
65
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000066namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000067static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000068
noahricd10a68e2015-07-10 11:27:55 -070069static const uint8_t kRedRtxPayloadType = 125;
70
Niels Möller6557d0c2018-04-11 15:18:34 +020071static const uint32_t kTimeout = 5000U;
72static const uint32_t kDefaultReceiveSsrc = 0;
73static const uint32_t kSsrc = 1234u;
74static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
75static const int kVideoWidth = 640;
76static const int kVideoHeight = 360;
77static const int kFramerate = 30;
78
Peter Boström0c4e06b2015-10-07 12:23:21 +020079static const uint32_t kSsrcs1[] = {1};
80static const uint32_t kSsrcs3[] = {1, 2, 3};
81static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080082static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020083static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080084static const uint32_t kDefaultRecvSsrc = 0;
85
pbos@webrtc.org3c107582014-07-20 15:27:35 +000086static const char kUnsupportedExtensionName[] =
87 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000088
magjed509e4fe2016-11-18 01:34:11 -080089cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
90 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020091 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080092}
93
Elad Alonfadb1812019-05-24 13:40:02 +020094void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
95 bool lntf_expected) {
96 EXPECT_EQ(lntf_expected,
97 codec.HasFeedbackParam(cricket::FeedbackParam(
98 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000099 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
100 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
101 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
102 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
103 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800106 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000108 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
109}
110
magjed725e4842016-11-16 00:48:13 -0800111// Return true if any codec in |codecs| is an RTX codec with associated payload
112// type |payload_type|.
113bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
114 int payload_type) {
115 for (const cricket::VideoCodec& codec : codecs) {
116 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200117 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800118 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
119 &associated_payload_type) &&
120 associated_payload_type == payload_type) {
121 return true;
122 }
123 }
124 return false;
125}
126
nisseca5706d2017-09-11 02:32:16 -0700127// TODO(nisse): Duplicated in call.cc.
128const int* FindKeyByValue(const std::map<int, int>& m, int v) {
129 for (const auto& kv : m) {
130 if (kv.second == v)
131 return &kv.first;
132 }
133 return nullptr;
134}
135
Yves Gerey665174f2018-06-19 15:03:05 +0200136bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
137 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700138 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
139 payload_type) != nullptr;
140}
141
142// Check that there's an Rtx payload type for each decoder.
143bool VerifyRtxReceiveAssociations(
144 const webrtc::VideoReceiveStream::Config& config) {
145 for (const auto& decoder : config.decoders) {
146 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
147 return false;
148 }
149 return true;
150}
151
brandtrffc61182016-11-28 06:02:22 -0800152rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700153 int width,
154 int height) {
155 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
156 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800157 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700158 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000159}
160
Shao Changbine62202f2015-04-21 20:24:50 +0800161void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
162 const std::map<int, int>& rtx_types) {
163 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200164 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800165 EXPECT_TRUE(it != rtx_types.end() &&
166 it->second == config.rtp.rtx.payload_type);
167
brandtrb5f2c3f2016-10-04 23:28:39 -0700168 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
169 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800170 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700171 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800172 }
173}
kthelgason2bc68642017-02-07 07:02:22 -0800174
175cricket::MediaConfig GetMediaConfig() {
176 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100177 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800178 return media_config;
179}
nisse26e3abb2017-08-25 04:44:25 -0700180
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200181// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
182int GetMaxDefaultBitrateBps(size_t width, size_t height) {
183 if (width * height <= 320 * 240) {
184 return 600000;
185 } else if (width * height <= 640 * 480) {
186 return 1700000;
187 } else if (width * height <= 960 * 540) {
188 return 2000000;
189 } else {
190 return 2500000;
191 }
192}
193
Niels Möller731a2c22018-07-30 15:08:07 +0200194class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
195 public:
196 MOCK_METHOD2(AddOrUpdateSink,
197 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
198 const rtc::VideoSinkWants& wants));
199 MOCK_METHOD1(RemoveSink,
200 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
201};
202
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000203} // namespace
204
Yves Gerey665174f2018-06-19 15:03:05 +0200205#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200206 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200207 EXPECT_EQ((w), renderer_.width()); \
208 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200209 EXPECT_EQ(0, renderer_.errors());
210
Yves Gerey665174f2018-06-19 15:03:05 +0200211#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200212 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200213 EXPECT_EQ((w), (r).width()); \
214 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200215 EXPECT_EQ(0, (r).errors());
216
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000217namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700218class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000219 public:
eladalonf1841382017-06-12 01:16:46 -0700220 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200221 explicit WebRtcVideoEngineTest(const std::string& field_trials)
222 : override_field_trials_(
223 field_trials.empty()
224 ? nullptr
225 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
226 field_trials)),
skvlad11a9cbf2016-10-07 11:53:05 -0700227 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200228 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
229 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200230 video_bitrate_allocator_factory_(
231 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200232 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200233 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200234 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200235 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200236 // Ensure fake clock doesn't return 0, which will cause some initializations
237 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200238 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200239 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000240
241 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200242 void AssignDefaultAptRtxTypes();
243 void AssignDefaultCodec();
244
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100245 // Find the index of the codec in the engine with the given name. The codec
246 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100247 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100248
magjed509e4fe2016-11-18 01:34:11 -0800249 // Find the codec in the engine with the given name. The codec must be
250 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100251 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800252
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200253 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000254
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200255 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000256 const std::vector<VideoCodec>& codecs);
257
Elad Alon157540a2019-02-08 23:37:52 +0100258 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100259
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200260 // Has to be the first one, so it is initialized before the call or there is a
261 // race condition in the clock access.
262 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200263 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700264 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700265 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000266 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800267 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200268 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
269 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200270 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
271 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700272 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000273 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800274 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000275};
276
eladalonf1841382017-06-12 01:16:46 -0700277TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200278 encoder_factory_->AddSupportedVideoCodecType("VP8");
279 AssignDefaultCodec();
280
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000281 std::vector<VideoCodec> engine_codecs = engine_.codecs();
282 for (size_t i = 0; i < engine_codecs.size(); ++i) {
283 if (engine_codecs[i].name != kRtxCodecName)
284 continue;
285 int associated_payload_type;
286 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000287 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000288 EXPECT_EQ(default_codec_.id, associated_payload_type);
289 return;
290 }
291 FAIL() << "No RTX codec found among default codecs.";
292}
293
eladalonf1841382017-06-12 01:16:46 -0700294TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100295 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000296}
297
eladalonf1841382017-06-12 01:16:46 -0700298TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100299 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000300}
301
eladalonf1841382017-06-12 01:16:46 -0700302TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100303 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700304}
305
eladalonf1841382017-06-12 01:16:46 -0700306TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100307 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
308}
309
310TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
311 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
312}
313
314TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
315 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
316}
317
318TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
319 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
320}
321
322TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
323 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100327 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
328}
329
Elad Alonccb9b752019-02-19 13:01:31 +0100330TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
331 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
332}
333
334TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
335 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700336}
337
philipel1e054862018-10-08 16:13:53 +0200338class WebRtcVideoEngineTestWithGenericDescriptor
339 : public WebRtcVideoEngineTest {
340 public:
341 WebRtcVideoEngineTestWithGenericDescriptor()
342 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
343};
344
Elad Alonccb9b752019-02-19 13:01:31 +0100345TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
346 AdvertiseGenericDescriptor00) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
348}
349
350TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
351 AdvertiseGenericDescriptor01) {
352 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200353}
354
eladalonf1841382017-06-12 01:16:46 -0700355TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200356 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700357 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200358 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200360 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700361
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200362 std::unique_ptr<VideoMediaChannel> channel(
363 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700364 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
365
366 // Add CVO extension.
367 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800368 cricket::VideoSendParameters parameters;
369 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200370 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700371 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200372 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
Niels Möller731a2c22018-07-30 15:08:07 +0200374 EXPECT_CALL(
375 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200376 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200377 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700378 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200379 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700380
381 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200382 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700383
384 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200385 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200386 EXPECT_CALL(
387 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200388 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200389 Field(&rtc::VideoSinkWants::rotation_applied, true)));
390
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200391 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392}
393
eladalonf1841382017-06-12 01:16:46 -0700394TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200395 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800396 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200397 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800398
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200399 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800400
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200401 std::unique_ptr<VideoMediaChannel> channel(
402 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800403 // Add CVO extension.
404 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800405 cricket::VideoSendParameters parameters;
406 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800407 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700408 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800409 EXPECT_TRUE(channel->SetSendParameters(parameters));
410 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
411
Niels Möller731a2c22018-07-30 15:08:07 +0200412 // Set source.
413 EXPECT_CALL(
414 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200415 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200416 Field(&rtc::VideoSinkWants::rotation_applied, false)));
417 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800418}
419
eladalonf1841382017-06-12 01:16:46 -0700420TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200421 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700422
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200423 encoder_factory_->AddSupportedVideoCodecType("VP8");
424 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700425
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200426 std::unique_ptr<VideoMediaChannel> channel(
427 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700428 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
429
430 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200431 EXPECT_CALL(
432 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200433 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200434 Field(&rtc::VideoSinkWants::rotation_applied, true)));
435 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700436
perkjcaafdba2016-03-20 07:34:29 -0700437 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200438 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700439
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440 // Add CVO extension.
441 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800442 cricket::VideoSendParameters parameters;
443 parameters.codecs.push_back(GetEngineCodec("VP8"));
444 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200445 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700446 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700447 // Also remove the first codec to trigger a codec change as well.
448 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200449 EXPECT_CALL(
450 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200451 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200452 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200453 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700454
455 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200456 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700457
458 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200459 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200460 EXPECT_CALL(
461 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200462 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200463 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200464 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700465}
466
eladalonf1841382017-06-12 01:16:46 -0700467TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200468 encoder_factory_->AddSupportedVideoCodecType("VP8");
469
Sebastian Jansson84848f22018-11-16 10:40:36 +0100470 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200471 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
472 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000473
474 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
475
476 EXPECT_FALSE(channel->SetSend(true))
477 << "Channel should not start without codecs.";
478 EXPECT_TRUE(channel->SetSend(false))
479 << "Channel should be stoppable even without set codecs.";
480}
481
eladalonf1841382017-06-12 01:16:46 -0700482TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200483 encoder_factory_->AddSupportedVideoCodecType("VP8");
484
Sebastian Jansson84848f22018-11-16 10:40:36 +0100485 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200486 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
487 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000488 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
489 VideoMediaInfo info;
490 channel->GetStats(&info);
491}
492
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200493TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200494 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000495
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200496 std::unique_ptr<VideoMediaChannel> channel(
497 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800498 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000499
500 EXPECT_TRUE(
501 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200502 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000503 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100504 webrtc::test::FrameForwarder frame_forwarder;
505 cricket::FakeFrameSource frame_source(1280, 720,
506 rtc::kNumMicrosecsPerSec / 30);
507 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
508 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100509 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
511 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000512 kTimeout);
513
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200514 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100515 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000516
517 // Setting codecs of the same type should not reallocate any encoders
518 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800519 cricket::VideoSendParameters parameters;
520 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200521 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200522 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000523
524 // Remove stream previously added to free the external encoder instance.
525 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000527}
528
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200529// Test that when an encoder factory supports H264, we add an RTX
530// codec for it.
531// TODO(deadbeef): This test should be updated if/when we start
532// adding RTX codecs for unrecognized codec names.
533TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800534 using webrtc::H264::ProfileLevelIdToString;
535 using webrtc::H264::ProfileLevelId;
536 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200537 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
538 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800539 *ProfileLevelIdToString(
540 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200541 webrtc::SdpVideoFormat h264_constrained_high("H264");
542 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800543 *ProfileLevelIdToString(
544 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200545 webrtc::SdpVideoFormat h264_high("H264");
546 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800547 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
548
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200549 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
550 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
551 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700552
magjed725e4842016-11-16 00:48:13 -0800553 // First figure out what payload types the test codecs got assigned.
554 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800555 // Now search for RTX codecs for them. Expect that they all have associated
556 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800557 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200558 codecs,
559 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
560 ->id));
magjed725e4842016-11-16 00:48:13 -0800561 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200562 codecs,
563 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
564 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800565 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200566 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700567}
568
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100569#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700570TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200571 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100572
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200573 std::unique_ptr<VideoMediaChannel> channel(
574 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100575
576 EXPECT_TRUE(
577 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
578}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100579#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100580
eladalonf1841382017-06-12 01:16:46 -0700581TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200582 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100583 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200584 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200585 std::unique_ptr<VideoMediaChannel> channel(
586 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700587
588 EXPECT_TRUE(
589 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
590
Niels Möllerd0f0f682019-01-14 09:09:53 +0100591 webrtc::test::FrameForwarder frame_forwarder;
592 cricket::FakeFrameSource frame_source(1280, 720,
593 rtc::kNumMicrosecsPerSec / 60);
594 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700595 channel->SetSend(true);
596
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200597 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700598
Niels Möllerd0f0f682019-01-14 09:09:53 +0100599 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700600 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700601 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100602 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700603 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700604 int64_t interval = timestamp - last_timestamp;
605
606 // Precision changes from nanosecond to millisecond.
607 // Allow error to be no more than 1.
608 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
609
610 last_timestamp = timestamp;
611 }
612
Niels Möllerd0f0f682019-01-14 09:09:53 +0100613 frame_forwarder.IncomingCapturedFrame(
614 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
615 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700616 last_timestamp = stream->GetLastTimestamp();
617 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100618 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
619 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
620 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700621 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700622 int64_t interval = timestamp - last_timestamp;
623
624 // Precision changes from nanosecond to millisecond.
625 // Allow error to be no more than 1.
626 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
627
628 last_timestamp = timestamp;
629 }
630
631 // Remove stream previously added to free the external encoder instance.
632 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
633}
634
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200635void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
636 std::vector<VideoCodec> engine_codecs = engine_.codecs();
637 RTC_DCHECK(!engine_codecs.empty());
638 for (const cricket::VideoCodec& codec : engine_codecs) {
639 if (codec.name == "rtx") {
640 int associated_payload_type;
641 if (codec.GetParam(kCodecParamAssociatedPayloadType,
642 &associated_payload_type)) {
643 default_apt_rtx_types_[associated_payload_type] = codec.id;
644 }
645 }
646 }
647}
648
649void WebRtcVideoEngineTest::AssignDefaultCodec() {
650 std::vector<VideoCodec> engine_codecs = engine_.codecs();
651 RTC_DCHECK(!engine_codecs.empty());
652 bool codec_set = false;
653 for (const cricket::VideoCodec& codec : engine_codecs) {
654 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
655 codec.name != "ulpfec") {
656 default_codec_ = codec;
657 codec_set = true;
658 }
659 }
660
661 RTC_DCHECK(codec_set);
662}
663
Oleh Prypina40f8242017-12-21 13:32:23 +0100664size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
665 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100666 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
667 for (size_t i = 0; i < codecs.size(); ++i) {
668 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200669 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200670 continue;
671 // The tests only use H264 Constrained Baseline. Make sure we don't return
672 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200673 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200674 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200675 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
676 if (profile_level_id->profile !=
677 webrtc::H264::kProfileConstrainedBaseline) {
678 continue;
679 }
680 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100681 return i;
magjed509e4fe2016-11-18 01:34:11 -0800682 }
683 // This point should never be reached.
684 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100685 return -1;
686}
687
688cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
689 const std::string& name) const {
690 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800691}
692
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200693VideoMediaChannel*
694WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100695 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200696 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
697 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200698 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800699 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200700 for (const webrtc::SdpVideoFormat& format :
701 encoder_factory_->GetSupportedFormats()) {
702 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800703 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200704 parameters.codecs.push_back(engine_codec);
705 }
706 }
magjed509e4fe2016-11-18 01:34:11 -0800707
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200708 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000709
710 return channel;
711}
712
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200713VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000714 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100715 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200716 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
717 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200718 cricket::VideoRecvParameters parameters;
719 parameters.codecs = codecs;
720 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000721
722 return channel;
723}
724
Elad Alon157540a2019-02-08 23:37:52 +0100725void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
726 bool supported) const {
727 const RtpCapabilities capabilities = engine_.GetCapabilities();
728 if (supported) {
729 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200730 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100731 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200732 EXPECT_THAT(capabilities.header_extensions,
733 ::testing::Each(::testing::Field(&RtpExtension::uri,
734 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100735 }
736}
737
eladalonf1841382017-06-12 01:16:46 -0700738TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200739 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000740
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200741 std::unique_ptr<VideoMediaChannel> channel(
742 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000743
Peter Boström0c4e06b2015-10-07 12:23:21 +0200744 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000745
Yves Gerey665174f2018-06-19 15:03:05 +0200746 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000747 EXPECT_TRUE(channel->SetSend(true));
748
Niels Möller805a27e2019-01-21 12:21:27 +0100749 webrtc::test::FrameForwarder frame_forwarder;
750 cricket::FakeFrameSource frame_source(1280, 720,
751 rtc::kNumMicrosecsPerSec / 60);
752 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
753 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000754
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200755 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000756
757 // Verify that encoders are configured for simulcast through adapter
758 // (increasing resolution and only configured to send one stream each).
759 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200760 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
761 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000762 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200763 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000764 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
765 EXPECT_GT(codec_settings.width, prev_width);
766 prev_width = codec_settings.width;
767 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000768
Niels Möllerff40b142018-04-09 08:49:14 +0200769 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000770
771 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200772 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000773}
774
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200775TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
776 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200777 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000778
Niels Möllerd0f0f682019-01-14 09:09:53 +0100779 // Frame source.
780 webrtc::test::FrameForwarder frame_forwarder;
781 cricket::FakeFrameSource frame_source(1280, 720,
782 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200783
Sebastian Jansson84848f22018-11-16 10:40:36 +0100784 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200785 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
786 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200787 cricket::VideoSendParameters parameters;
788 parameters.codecs.push_back(GetEngineCodec("H264"));
789 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000790
791 EXPECT_TRUE(
792 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100793 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200794 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100795 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200796
797 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000798
Anders Carlsson67537952018-05-03 11:28:29 +0200799 cricket::VideoSendParameters new_parameters;
800 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
801 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200802
803 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100804 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200805
Anders Carlsson8a150d92018-05-14 12:40:04 +0200806 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000807}
808
eladalonf1841382017-06-12 01:16:46 -0700809TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000810 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200811 encoder_factory_->AddSupportedVideoCodecType("VP8");
812 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000813
Sebastian Jansson84848f22018-11-16 10:40:36 +0100814 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200815 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
816 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800817 cricket::VideoSendParameters parameters;
818 parameters.codecs.push_back(GetEngineCodec("VP8"));
819 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820
Peter Boström0c4e06b2015-10-07 12:23:21 +0200821 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822
Yves Gerey665174f2018-06-19 15:03:05 +0200823 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824 EXPECT_TRUE(channel->SetSend(true));
825
826 // Send a fake frame, or else the media engine will configure the simulcast
827 // encoder adapter at a low-enough size that it'll only create a single
828 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100829 webrtc::test::FrameForwarder frame_forwarder;
830 cricket::FakeFrameSource frame_source(1280, 720,
831 rtc::kNumMicrosecsPerSec / 30);
832 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
833 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200835 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
836 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000837 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200838 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000839
840 channel.reset();
841 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200842 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000843}
844
eladalonf1841382017-06-12 01:16:46 -0700845TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000846 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 encoder_factory_->AddSupportedVideoCodecType("VP8");
848 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849
Sebastian Jansson84848f22018-11-16 10:40:36 +0100850 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200851 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
852 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800853 cricket::VideoSendParameters parameters;
854 parameters.codecs.push_back(GetEngineCodec("H264"));
855 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000856
857 EXPECT_TRUE(
858 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100859
860 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100861 webrtc::test::FrameForwarder frame_forwarder;
862 cricket::FakeFrameSource frame_source(1280, 720,
863 rtc::kNumMicrosecsPerSec / 30);
864 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
865 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200866 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
867 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200868 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000869 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200870 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000871
872 channel.reset();
873 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200874 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000875}
876
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200877TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200878 RTC_DCHECK(!override_field_trials_);
879 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200880 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200881 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700882
Sebastian Jansson84848f22018-11-16 10:40:36 +0100883 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200884 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
885 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200886 cricket::VideoSendParameters parameters;
887 parameters.codecs.push_back(GetEngineCodec("H264"));
888 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700889
Peter Boström0c4e06b2015-10-07 12:23:21 +0200890 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700891 EXPECT_TRUE(
892 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100893
894 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100895 webrtc::test::FrameForwarder frame_forwarder;
896 cricket::FakeFrameSource frame_source(1280, 720,
897 rtc::kNumMicrosecsPerSec / 30);
898 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
899 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100900
Niels Möller4db138e2018-04-19 09:04:13 +0200901 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200902 ASSERT_EQ(1u, encoder_factory_->encoders().size());
903 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
904 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700905 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200906 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200907 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700908}
909
brandtrffc61182016-11-28 06:02:22 -0800910// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700911// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800912//
913// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700914TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800915 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200916 encoder_factory_->AddSupportedVideoCodecType("VP8");
917
Steve Anton2c9ebef2019-01-28 17:27:58 -0800918 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800919
920 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800921 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800922
923 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200924 RTC_DCHECK(!override_field_trials_);
925 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800926 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800927 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800928}
929
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200930// Test that codecs are added in the order they are reported from the factory.
931TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
932 encoder_factory_->AddSupportedVideoCodecType("VP8");
933 const char* kFakeCodecName = "FakeCodec";
934 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000935
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200936 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100937 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200938 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
939 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000940}
941
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200942// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800943// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200944TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100945 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
946 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100947
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100948 // Set up external encoder factory with first codec, and initialize engine.
949 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
950
brandtrffc61182016-11-28 06:02:22 -0800951 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800952
953 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100954 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800955 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200956 // The codec itself and RTX should have been added.
957 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100958
959 // Check that both fake codecs are present and that the second fake codec
960 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100961 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
962 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100963 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800964}
965
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200966TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
967 const char* kFakeCodecName = "FakeCodec";
968 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
969
970 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
971 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
972}
973
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200974TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
975 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200976 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200977 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800978 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000979
kwiberg686a8ef2016-02-26 03:00:35 -0800980 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200981 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000982
983 EXPECT_TRUE(
984 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200985 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000986
987 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200988 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200989 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000990
991 // Remove stream previously added to free the external decoder instance.
992 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200993 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000994}
995
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200996// Verifies that we can set up decoders.
997TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
999 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1000 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1001 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001002 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001003 webrtc::SdpVideoFormat supported_h264("H264");
1004 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1005 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001007 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001008
kwiberg686a8ef2016-02-26 03:00:35 -08001009 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001010 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001011
1012 EXPECT_TRUE(
1013 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001014 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001015}
1016
Jonas Oreland49ac5952018-09-26 16:04:32 +02001017// Tests when GetSources is called with non-existing ssrc, it will return an
1018// empty list of RtpSource without crashing.
1019TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1020 // Setup an recv stream with |kSsrc|.
1021 encoder_factory_->AddSupportedVideoCodecType("VP8");
1022 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1023 cricket::VideoRecvParameters parameters;
1024 parameters.codecs.push_back(GetEngineCodec("VP8"));
1025 std::unique_ptr<VideoMediaChannel> channel(
1026 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1027
1028 EXPECT_TRUE(
1029 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1030
1031 // Call GetSources with |kSsrc + 1| which doesn't exist.
1032 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1033 EXPECT_EQ(0u, sources.size());
1034}
1035
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001036TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1037 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1038 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1039 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001040 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001041 EXPECT_EQ(0u, engine.codecs().size());
1042}
1043
1044TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1045 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001046 webrtc::MockVideoEncoderFactory* encoder_factory =
1047 new webrtc::MockVideoEncoderFactory();
1048 webrtc::MockVideoDecoderFactory* decoder_factory =
1049 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001050 WebRtcVideoEngine engine(
1051 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001052 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001053 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1054 EXPECT_EQ(0u, engine.codecs().size());
1055 EXPECT_CALL(*encoder_factory, Die());
1056 EXPECT_CALL(*decoder_factory, Die());
1057}
1058
1059// Test full behavior in the video engine when video codec factories of the new
1060// type are injected supporting the single codec Vp8. Check the returned codecs
1061// from the engine and that we will create a Vp8 encoder and decoder using the
1062// new factories.
1063TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1064 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001065 webrtc::MockVideoEncoderFactory* encoder_factory =
1066 new webrtc::MockVideoEncoderFactory();
1067 webrtc::MockVideoDecoderFactory* decoder_factory =
1068 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001069 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1070 rate_allocator_factory =
1071 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001072 EXPECT_CALL(*rate_allocator_factory,
1073 CreateVideoBitrateAllocatorProxy(Field(
1074 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001075 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001076 WebRtcVideoEngine engine(
1077 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001078 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001079 const webrtc::SdpVideoFormat vp8_format("VP8");
1080 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1081 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001082 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001083
1084 // Verify the codecs from the engine.
1085 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001086 // Verify default codecs has been added correctly.
1087 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001088 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001089
1090 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001092 int vp8_associated_payload;
1093 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1094 &vp8_associated_payload));
1095 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1096
1097 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1098
1099 // RTX codec for RED.
1100 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1101 int red_associated_payload;
1102 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1103 &red_associated_payload));
1104 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1105
1106 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1107
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001108 int associated_payload_type;
1109 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1110 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1111 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1112 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001113 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1114 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001115
1116 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001117 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1118 codec_info.is_hardware_accelerated = false;
1119 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001120 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001121 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001122 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001123 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001124 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001125 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001126 .WillOnce(
1127 ::testing::DoAll(::testing::InvokeWithoutArgs(
1128 [&encoder_created]() { encoder_created.Set(); }),
1129 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001130
1131 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001132 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001133 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001134 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001135
1136 // Create a call.
1137 webrtc::RtcEventLogNullImpl event_log;
1138 std::unique_ptr<webrtc::Call> call(
1139 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1140
1141 // Create send channel.
1142 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001143 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001144 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1145 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001146 cricket::VideoSendParameters send_parameters;
1147 send_parameters.codecs.push_back(engine_codecs.at(0));
1148 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1149 send_channel->OnReadyToSend(true);
1150 EXPECT_TRUE(
1151 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1152 EXPECT_TRUE(send_channel->SetSend(true));
1153
Niels Möller4db138e2018-04-19 09:04:13 +02001154 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001155 webrtc::test::FrameForwarder frame_forwarder;
1156 cricket::FakeFrameSource frame_source(1280, 720,
1157 rtc::kNumMicrosecsPerSec / 30);
1158 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001159 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001160 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001161 encoder_created.Wait(kTimeout);
1162
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001163 // Create recv channel.
1164 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001165 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001166 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1167 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001168 cricket::VideoRecvParameters recv_parameters;
1169 recv_parameters.codecs.push_back(engine_codecs.at(0));
1170 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1171 EXPECT_TRUE(recv_channel->AddRecvStream(
1172 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1173
1174 // Remove streams previously added to free the encoder and decoder instance.
1175 EXPECT_CALL(*encoder_factory, Die());
1176 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001177 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001178 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1179 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1180}
1181
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001182// Test behavior when decoder factory fails to create a decoder (returns null).
1183TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1184 // |engine| take ownership of the factories.
1185 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001186 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001187 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001188 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001189 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1190 rate_allocator_factory =
1191 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001192 WebRtcVideoEngine engine(
1193 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001194 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001195 const webrtc::SdpVideoFormat vp8_format("VP8");
1196 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1197 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001198 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001199
1200 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001201 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1202 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001203
1204 // Create a call.
1205 webrtc::RtcEventLogNullImpl event_log;
1206 std::unique_ptr<webrtc::Call> call(
1207 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1208
1209 // Create recv channel.
1210 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001211 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001212 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1213 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001214 cricket::VideoRecvParameters recv_parameters;
1215 recv_parameters.codecs.push_back(engine.codecs().front());
1216 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1217 EXPECT_TRUE(recv_channel->AddRecvStream(
1218 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1219
1220 // Remove streams previously added to free the encoder and decoder instance.
1221 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1222}
1223
eladalonf1841382017-06-12 01:16:46 -07001224TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001225 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001226 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001227 std::unique_ptr<VideoMediaChannel> channel(
1228 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001229 ASSERT_TRUE(
1230 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1231 cricket::VideoCodec codec = GetEngineCodec("VP8");
1232 cricket::VideoSendParameters parameters;
1233 parameters.codecs.push_back(codec);
1234 channel->OnReadyToSend(true);
1235 channel->SetSend(true);
1236 ASSERT_TRUE(channel->SetSendParameters(parameters));
1237
Niels Möller805a27e2019-01-21 12:21:27 +01001238 webrtc::test::FrameForwarder frame_forwarder;
1239 cricket::FakeFrameSource frame_source(1280, 720,
1240 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001241 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001242 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001243
Niels Möller805a27e2019-01-21 12:21:27 +01001244 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001245 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001246 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001247 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001248
Niels Möller805a27e2019-01-21 12:21:27 +01001249 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1250 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001251 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001252 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001253
1254 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001255 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1256 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001257 // Change to screen content, recreate encoder. For the simulcast encoder
1258 // adapter case, this will result in two calls since InitEncode triggers a
1259 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001260 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001261 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001262 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001263
Niels Möller805a27e2019-01-21 12:21:27 +01001264 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1265 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001266 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001267 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001268
1269 options.is_screencast.emplace(false);
1270 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001271 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001272 // Change back to regular video content, update encoder. Also change
1273 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001274 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001275 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001276 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001277 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001278
1279 // Remove stream previously added to free the external encoder instance.
1280 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001281 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001282}
1283
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001284class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001285 protected:
1286 WebRtcVideoChannelBaseTest()
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001287 : video_bitrate_allocator_factory_(
1288 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1289 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1290 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001291
1292 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001293 // One testcase calls SetUp in a loop, only create call_ once.
1294 if (!call_) {
1295 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1296 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001297 cricket::MediaConfig media_config;
1298 // Disabling cpu overuse detection actually disables quality scaling too; it
1299 // implies DegradationPreference kMaintainResolution. Automatic scaling
1300 // needs to be disabled, otherwise, tests which check the size of received
1301 // frames become flaky.
1302 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001303 channel_.reset(
1304 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1305 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001306 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001307 channel_->OnReadyToSend(true);
1308 EXPECT_TRUE(channel_.get() != NULL);
1309 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001310 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001311 cricket::VideoRecvParameters parameters;
1312 parameters.codecs = engine_.codecs();
1313 channel_->SetRecvParameters(parameters);
1314 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001315 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1316 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1317 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1318 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001319 }
1320
1321 // Utility method to setup an additional stream to send and receive video.
1322 // Used to test send and recv between two streams.
1323 void SetUpSecondStream() {
1324 SetUpSecondStreamWithNoRecv();
1325 // Setup recv for second stream.
1326 EXPECT_TRUE(channel_->AddRecvStream(
1327 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1328 // Make the second renderer available for use by a new stream.
1329 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1330 }
1331 // Setup an additional stream just to send video. Defer add recv stream.
1332 // This is required if you want to test unsignalled recv of video rtp packets.
1333 void SetUpSecondStreamWithNoRecv() {
1334 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001335 EXPECT_TRUE(
1336 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001337 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001338 EXPECT_FALSE(
1339 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001340 EXPECT_TRUE(channel_->AddSendStream(
1341 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1342 // We dont add recv for the second stream.
1343
1344 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001345 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001346 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001347 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001348 }
Yves Gerey665174f2018-06-19 15:03:05 +02001349 virtual void TearDown() { channel_.reset(); }
1350 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001351
1352 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001353 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1354 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001355
1356 bool sending = channel_->sending();
1357 bool success = SetSend(false);
1358 if (success) {
1359 cricket::VideoSendParameters parameters;
1360 parameters.codecs.push_back(codec);
1361 success = channel_->SetSendParameters(parameters);
1362 }
1363 if (success) {
1364 success = SetSend(sending);
1365 }
1366 return success;
1367 }
Yves Gerey665174f2018-06-19 15:03:05 +02001368 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001369 void SendFrame() {
1370 if (frame_forwarder_2_) {
1371 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001372 }
Niels Möller805a27e2019-01-21 12:21:27 +01001373 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001374 }
1375 bool WaitAndSendFrame(int wait_ms) {
1376 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001377 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001378 return ret;
1379 }
Yves Gerey665174f2018-06-19 15:03:05 +02001380 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001381 int NumRtpBytes(uint32_t ssrc) {
1382 return network_interface_.NumRtpBytes(ssrc);
1383 }
Yves Gerey665174f2018-06-19 15:03:05 +02001384 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001385 int NumRtpPackets(uint32_t ssrc) {
1386 return network_interface_.NumRtpPackets(ssrc);
1387 }
Yves Gerey665174f2018-06-19 15:03:05 +02001388 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001389 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1390 return network_interface_.GetRtpPacket(index);
1391 }
1392 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001393 webrtc::RTPHeader header;
1394 EXPECT_TRUE(ParseRtpPacket(p, &header));
1395 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001396 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001397
Niels Möller6557d0c2018-04-11 15:18:34 +02001398 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001399 webrtc::RTPHeader* header) {
1400 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1401 webrtc::RtpHeaderParser::Create());
1402 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001403 }
1404
1405 // Tests that we can send and receive frames.
1406 void SendAndReceive(const cricket::VideoCodec& codec) {
1407 EXPECT_TRUE(SetOneCodec(codec));
1408 EXPECT_TRUE(SetSend(true));
1409 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1410 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001411 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001412 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1413 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1414 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1415 }
1416
1417 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001418 int duration_sec,
1419 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001420 EXPECT_TRUE(SetOneCodec(codec));
1421 EXPECT_TRUE(SetSend(true));
1422 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1423 EXPECT_EQ(0, renderer_.num_rendered_frames());
1424 for (int i = 0; i < duration_sec; ++i) {
1425 for (int frame = 1; frame <= fps; ++frame) {
1426 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1427 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1428 }
1429 }
1430 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1431 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1432 }
1433
Niels Möller6557d0c2018-04-11 15:18:34 +02001434 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1435 cricket::VideoMediaInfo info;
1436 EXPECT_TRUE(channel_->GetStats(&info));
1437 return info.senders[i];
1438 }
1439
1440 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1441 cricket::VideoMediaInfo info;
1442 EXPECT_TRUE(channel_->GetStats(&info));
1443 return info.receivers[i];
1444 }
1445
1446 // Two streams one channel tests.
1447
1448 // Tests that we can send and receive frames.
1449 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1450 SetUpSecondStream();
1451 // Test sending and receiving on first stream.
1452 SendAndReceive(codec);
1453 // Test sending and receiving on second stream.
1454 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1455 EXPECT_GT(NumRtpPackets(), 0);
1456 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1457 }
1458
1459 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1460 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001461 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001462 return engine_codec;
1463 }
1464 // This point should never be reached.
1465 ADD_FAILURE() << "Unrecognized codec name: " << name;
1466 return cricket::VideoCodec();
1467 }
1468
1469 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1470
1471 cricket::StreamParams DefaultSendStreamParams() {
1472 return cricket::StreamParams::CreateLegacy(kSsrc);
1473 }
1474
1475 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001476 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001477 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1478 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001479 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001480
1481 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1482 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1483 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1484
Niels Möller6557d0c2018-04-11 15:18:34 +02001485 std::unique_ptr<WebRtcVideoChannel> channel_;
1486 cricket::FakeNetworkInterface network_interface_;
1487 cricket::FakeVideoRenderer renderer_;
1488
1489 // Used by test cases where 2 streams are run on the same channel.
1490 cricket::FakeVideoRenderer renderer2_;
1491};
1492
1493// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001494TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001495 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001496 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001497 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1498 EXPECT_FALSE(channel_->sending());
1499 EXPECT_TRUE(SetSend(true));
1500 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001501 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001502 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1503 EXPECT_TRUE(SetSend(false));
1504 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001505}
Niels Möller6557d0c2018-04-11 15:18:34 +02001506
1507// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001508TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001509 EXPECT_FALSE(channel_->sending());
1510 EXPECT_FALSE(SetSend(true));
1511 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001512}
Niels Möller6557d0c2018-04-11 15:18:34 +02001513
1514// Test that we properly set the send and recv buffer sizes by the time
1515// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001516TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001517 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1518 EXPECT_TRUE(SetSend(true));
1519 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001520 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001521}
1522
Johannes Kron5a0665b2019-04-08 10:35:50 +02001523// Test that we properly set the send and recv buffer sizes when overriding
1524// via field trials.
1525TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1526 // Set field trial to override the default recv buffer size, and then re-run
1527 // setup where the interface is created and configured.
1528 const int kCustomRecvBufferSize = 123456;
1529 webrtc::test::ScopedFieldTrials field_trial(
1530 "WebRTC-IncreasedReceivebuffers/123456/");
1531 SetUp();
1532
1533 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1534 EXPECT_TRUE(SetSend(true));
1535 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1536 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1537}
1538
1539// Test that we properly set the send and recv buffer sizes when overriding
1540// via field trials with suffix.
1541TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1542 // Set field trial to override the default recv buffer size, and then re-run
1543 // setup where the interface is created and configured.
1544 const int kCustomRecvBufferSize = 123456;
1545 webrtc::test::ScopedFieldTrials field_trial(
1546 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1547 SetUp();
1548
1549 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1550 EXPECT_TRUE(SetSend(true));
1551 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1552 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1553}
1554
1555// Test that we properly set the send and recv buffer sizes when overriding
1556// via field trials that don't make any sense.
1557TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1558 // Set bogus field trial values to override the default recv buffer size, and
1559 // then re-run setup where the interface is created and configured. The
1560 // default value should still be used.
1561
1562 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1563 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1564 field_trial_string += group;
1565 field_trial_string += "/";
1566 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1567 SetUp();
1568
1569 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1570 EXPECT_TRUE(SetSend(true));
1571 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1572 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1573 }
1574}
1575
Niels Möller6557d0c2018-04-11 15:18:34 +02001576// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001577TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001578 const int kDurationSec = 3;
1579 const int kFps = 10;
1580 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1581
1582 cricket::VideoMediaInfo info;
1583 EXPECT_TRUE(channel_->GetStats(&info));
1584
1585 ASSERT_EQ(1U, info.senders.size());
1586 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1587 // For webrtc, bytes_sent does not include the RTP header length.
1588 EXPECT_GT(info.senders[0].bytes_sent, 0);
1589 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1590 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1591 ASSERT_TRUE(info.senders[0].codec_payload_type);
1592 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1593 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1594 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1595 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1596 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1597 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1598 EXPECT_GT(info.senders[0].framerate_input, 0);
1599 EXPECT_GT(info.senders[0].framerate_sent, 0);
1600
1601 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1602 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1603 info.send_codecs[DefaultCodec().id]);
1604
1605 ASSERT_EQ(1U, info.receivers.size());
1606 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1607 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1608 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1609 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1610 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1611 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1612 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
1613 EXPECT_EQ(0.0, info.receivers[0].fraction_lost);
1614 EXPECT_EQ(0, info.receivers[0].packets_lost);
1615 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1616 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1617 EXPECT_EQ(0, info.receivers[0].firs_sent);
1618 EXPECT_EQ(0, info.receivers[0].plis_sent);
1619 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1620 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1621 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1622 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1623 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1624 EXPECT_GT(info.receivers[0].framerate_output, 0);
1625
1626 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1627 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1628 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001629}
Niels Möller6557d0c2018-04-11 15:18:34 +02001630
1631// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001632TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001633 cricket::FakeVideoRenderer renderer1, renderer2;
1634 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1635 cricket::VideoSendParameters parameters;
1636 parameters.codecs.push_back(DefaultCodec());
1637 parameters.conference_mode = true;
1638 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1639 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001640 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1641 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001642 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1643 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1644 EXPECT_EQ(0, renderer1.num_rendered_frames());
1645 EXPECT_EQ(0, renderer2.num_rendered_frames());
1646 std::vector<uint32_t> ssrcs;
1647 ssrcs.push_back(1);
1648 ssrcs.push_back(2);
1649 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001650 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001651 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1652 kTimeout);
1653 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1654 kTimeout);
1655
1656 EXPECT_TRUE(channel_->SetSend(false));
1657
1658 cricket::VideoMediaInfo info;
1659 EXPECT_TRUE(channel_->GetStats(&info));
1660 ASSERT_EQ(1U, info.senders.size());
1661 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1662 // For webrtc, bytes_sent does not include the RTP header length.
1663 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1664 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1665 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1666 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1667
1668 ASSERT_EQ(2U, info.receivers.size());
1669 for (size_t i = 0; i < info.receivers.size(); ++i) {
1670 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1671 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1672 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001673 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001674 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1675 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1676 }
srtee0c2eea2017-12-15 17:44:33 +01001677}
Niels Möller6557d0c2018-04-11 15:18:34 +02001678
1679// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001680TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001681 // Normal setup; note that we set the SSRC explicitly to ensure that
1682 // it will come first in the senders map.
1683 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1684 cricket::VideoSendParameters parameters;
1685 parameters.codecs.push_back(DefaultCodec());
1686 parameters.conference_mode = true;
1687 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001688 EXPECT_TRUE(
1689 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001690 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1691 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001692 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001693 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1694 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1695
1696 // Add an additional capturer, and hook up a renderer to receive it.
1697 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001698 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001699 const int kTestWidth = 160;
1700 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001701 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1702 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001703 EXPECT_TRUE(
1704 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001705 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001706 EXPECT_TRUE(
1707 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001708 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001709 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001710 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1711 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001712
1713 // Get stats, and make sure they are correct for two senders. We wait until
1714 // the number of expected packets have been sent to avoid races where we
1715 // check stats before it has been updated.
1716 cricket::VideoMediaInfo info;
1717 for (uint32_t i = 0; i < kTimeout; ++i) {
1718 rtc::Thread::Current()->ProcessMessages(1);
1719 EXPECT_TRUE(channel_->GetStats(&info));
1720 ASSERT_EQ(2U, info.senders.size());
1721 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1722 NumRtpPackets()) {
1723 // Stats have been updated for both sent frames, expectations can be
1724 // checked now.
1725 break;
1726 }
1727 }
1728 EXPECT_EQ(NumRtpPackets(),
1729 info.senders[0].packets_sent + info.senders[1].packets_sent)
1730 << "Timed out while waiting for packet counts for all sent packets.";
1731 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1732 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1733 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1734 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1735 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1736 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1737 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1738 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1739 // The capturer must be unregistered here as it runs out of it's scope next.
1740 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001741}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001742
Niels Möller6557d0c2018-04-11 15:18:34 +02001743// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001744TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001745 cricket::VideoSendParameters parameters;
1746 parameters.codecs.push_back(DefaultCodec());
1747 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1748 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1749 parameters.max_bandwidth_bps = 128 * 1024;
1750 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001751}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001752
Niels Möller6557d0c2018-04-11 15:18:34 +02001753// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001754TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001755 EXPECT_TRUE(SetDefaultCodec());
1756 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001757 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001758 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001759 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001760 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001761 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1762 EXPECT_EQ(kSsrc, header.ssrc);
1763
Niels Möller6557d0c2018-04-11 15:18:34 +02001764 // Packets are being paced out, so these can mismatch between the first and
1765 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001766 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1767 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001768 EXPECT_EQ(1, NumSentSsrcs());
1769 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1770 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001771}
Niels Möller6557d0c2018-04-11 15:18:34 +02001772
1773// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001774TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001775 // Remove stream added in Setup.
1776 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1777 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001778 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001779 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001780 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001781 EXPECT_TRUE(SetSend(true));
1782 EXPECT_TRUE(WaitAndSendFrame(0));
1783 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001784 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001785 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001786 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1787 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001788 // Packets are being paced out, so these can mismatch between the first and
1789 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001790 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1791 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001792 EXPECT_EQ(1, NumSentSsrcs());
1793 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1794 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001795}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001796
Niels Möller6557d0c2018-04-11 15:18:34 +02001797// Test that we can set the default video renderer before and after
1798// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001799TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001800 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1801 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001802
1803 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1804 rtc::SetBE32(packet1.data() + 8, kSsrc);
1805 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1806 EXPECT_TRUE(SetDefaultCodec());
1807 EXPECT_TRUE(SetSend(true));
1808 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001809 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001810 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001811 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001812 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001813}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001814
Niels Möller6557d0c2018-04-11 15:18:34 +02001815// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001816TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001817 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1818 EXPECT_TRUE(SetSend(true));
1819 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001820 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001821 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1822 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001823 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001824 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001825 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1826 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001827 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1828 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001829
1830 // Remove the send stream that was added during Setup.
1831 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1832 int rtp_packets = NumRtpPackets();
1833
Niels Möller6557d0c2018-04-11 15:18:34 +02001834 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001835 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001836 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001837 EXPECT_EQ(rtp_packets, NumRtpPackets());
1838 // Wait 30ms to guarantee the engine does not drop the frame.
1839 EXPECT_TRUE(WaitAndSendFrame(30));
1840 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1841
1842 last_packet = NumRtpPackets() - 1;
1843 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001844 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1845 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001846}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001847
Niels Möller6557d0c2018-04-11 15:18:34 +02001848// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001849TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001850 cricket::FakeVideoRenderer renderer1, renderer2;
1851 EXPECT_TRUE(SetDefaultCodec());
1852 cricket::VideoSendParameters parameters;
1853 parameters.codecs.push_back(DefaultCodec());
1854 parameters.conference_mode = true;
1855 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1856 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001857 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1858 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001859 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1860 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1861 EXPECT_EQ(0, renderer1.num_rendered_frames());
1862 EXPECT_EQ(0, renderer2.num_rendered_frames());
1863 std::vector<uint32_t> ssrcs;
1864 ssrcs.push_back(1);
1865 ssrcs.push_back(2);
1866 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001867 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001868 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1869 kTimeout);
1870 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1871 kTimeout);
1872
1873 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1874 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1875 EXPECT_EQ(kVideoWidth, renderer1.width());
1876 EXPECT_EQ(kVideoHeight, renderer1.height());
1877 EXPECT_EQ(kVideoWidth, renderer2.width());
1878 EXPECT_EQ(kVideoHeight, renderer2.height());
1879 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1880 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001881}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001882
Niels Möller6557d0c2018-04-11 15:18:34 +02001883// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001884TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001885 using cricket::VideoCodec;
1886 using cricket::VideoOptions;
1887 using cricket::VideoFormat;
1888 using cricket::FOURCC_I420;
1889
1890 VideoCodec codec = DefaultCodec();
1891 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1892 EXPECT_TRUE(SetOneCodec(codec));
1893 EXPECT_TRUE(SetSend(true));
1894 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1895 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001896 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001897 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001898
1899 webrtc::test::FrameForwarder frame_forwarder;
1900 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1901 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001902
1903 // TODO(nisse): This testcase fails if we don't configure
1904 // screencast. It's unclear why, I see nothing obvious in this
1905 // test which is related to screencast logic.
1906 VideoOptions video_options;
1907 video_options.is_screencast = true;
1908 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1909
Niels Möller6557d0c2018-04-11 15:18:34 +02001910 int captured_frames = 1;
1911 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001912 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001913 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001914 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1915
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 ++captured_frames;
1917 // Wait until frame of right size is captured.
1918 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001919 480 == renderer_.width() &&
1920 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001921 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001922 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001923 EXPECT_EQ(480, renderer_.width());
1924 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001925 captured_frames = renderer_.num_rendered_frames() + 1;
1926 EXPECT_FALSE(renderer_.black_frame());
1927 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1928 // Make sure a black frame is generated within the specified timeout.
1929 // The black frame should be the resolution of the previous frame to
1930 // prevent expensive encoder reconfigurations.
1931 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001932 480 == renderer_.width() &&
1933 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001934 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001935 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001936 EXPECT_EQ(480, renderer_.width());
1937 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001938 EXPECT_TRUE(renderer_.black_frame());
1939
1940 // The black frame has the same timestamp as the next frame since it's
1941 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1942 // not render a frame with the same timestamp so capture another frame
1943 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001944 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001945 }
srtee0c2eea2017-12-15 17:44:33 +01001946}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001947
Niels Möller6557d0c2018-04-11 15:18:34 +02001948// Tests that if SetVideoSend is called with a NULL capturer after the
1949// capturer was already removed, the application doesn't crash (and no black
1950// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001951TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001952 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1953 EXPECT_TRUE(SetSend(true));
1954 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1955 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001956 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001957 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1958 // Wait for one frame so they don't get dropped because we send frames too
1959 // tightly.
1960 rtc::Thread::Current()->ProcessMessages(30);
1961 // Remove the capturer.
1962 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1963
1964 // No capturer was added, so this SetVideoSend shouldn't do anything.
1965 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1966 rtc::Thread::Current()->ProcessMessages(300);
1967 // Verify no more frames were sent.
1968 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001969}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001970
Niels Möller6557d0c2018-04-11 15:18:34 +02001971// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001972TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1974 // interval time to avoid that.
1975 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1976 // interval time to avoid that.
1977 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001978 EXPECT_TRUE(
1979 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001980 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1981 cricket::VideoFormat capture_format(
1982 kVideoWidth, kVideoHeight,
1983 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1984 // Set up additional stream 1.
1985 cricket::FakeVideoRenderer renderer1;
1986 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001987 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001989 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001990
1991 webrtc::test::FrameForwarder frame_forwarder1;
1992 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1993 rtc::kNumMicrosecsPerSec / kFramerate);
1994
Niels Möller6557d0c2018-04-11 15:18:34 +02001995 // Set up additional stream 2.
1996 cricket::FakeVideoRenderer renderer2;
1997 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001998 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001999 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002000 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002001 webrtc::test::FrameForwarder frame_forwarder2;
2002
Niels Möller6557d0c2018-04-11 15:18:34 +02002003 // State for all the streams.
2004 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2005 // A limitation in the lmi implementation requires that SetVideoSend() is
2006 // called after SetOneCodec().
2007 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002008 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2009 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002010 EXPECT_TRUE(SetSend(true));
2011 // Test capturer associated with engine.
2012 const int kTestWidth = 160;
2013 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002014 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2015 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2016 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002017 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2018 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002020 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2021 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2022 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002023 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2024 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002025 // Successfully remove the capturer.
2026 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2027 // The capturers must be unregistered here as it runs out of it's scope
2028 // next.
2029 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2030 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002031}
Niels Möller6557d0c2018-04-11 15:18:34 +02002032
2033// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002034TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002035 // Remove the send stream that was added during Setup.
2036 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2037
2038 cricket::StreamParams empty;
2039 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002040 EXPECT_TRUE(
2041 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002042}
Niels Möller6557d0c2018-04-11 15:18:34 +02002043
2044// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002045TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002046 // Remove stream added in Setup. I.e. remove stream corresponding to default
2047 // channel.
2048 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002049 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002050 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2051 EXPECT_TRUE(channel_->AddSendStream(
2052 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2053 }
2054 // Delete one of the non default channel streams, let the destructor delete
2055 // the remaining ones.
2056 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2057 // Stream should already be deleted.
2058 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002059}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002060
eladalonf1841382017-06-12 01:16:46 -07002061TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002062 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002063}
2064
eladalonf1841382017-06-12 01:16:46 -07002065TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002066 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002067}
2068
eladalonf1841382017-06-12 01:16:46 -07002069TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002070 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002071}
2072
eladalonf1841382017-06-12 01:16:46 -07002073TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002074 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2075 // bitrates. This currently happens at <250k, and two streams sharing 300k
2076 // initially will use QVGA instead of VGA.
2077 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2078 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002079 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002080 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002081 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002082}
2083
eladalonf1841382017-06-12 01:16:46 -07002084class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002085 public:
eladalonf1841382017-06-12 01:16:46 -07002086 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2087 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002088 : WebRtcVideoEngineTest(field_trials),
2089 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2090 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002091 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002092 encoder_factory_->AddSupportedVideoCodecType("VP8");
2093 encoder_factory_->AddSupportedVideoCodecType("VP9");
2094#if defined(WEBRTC_USE_H264)
2095 encoder_factory_->AddSupportedVideoCodecType("H264");
2096#endif
2097
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002098 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002099 channel_.reset(engine_.CreateMediaChannel(
2100 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2101 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002102 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002103 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002104 send_parameters_.codecs = engine_.codecs();
2105 recv_parameters_.codecs = engine_.codecs();
2106 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002107 }
2108
2109 protected:
2110 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002111 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002112 }
2113
2114 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002115 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002116 EXPECT_TRUE(channel_->AddSendStream(sp));
2117 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002118 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002119 EXPECT_EQ(num_streams + 1, streams.size());
2120 return streams[streams.size() - 1];
2121 }
2122
2123 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002124 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002125 }
2126
2127 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002128 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002129 }
2130
2131 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002132 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002133 EXPECT_TRUE(channel_->AddRecvStream(sp));
2134 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002135 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002136 EXPECT_EQ(num_streams + 1, streams.size());
2137 return streams[streams.size() - 1];
2138 }
2139
pbos@webrtc.org00873182014-11-25 14:03:34 +00002140 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2141 int expected_min_bitrate_bps,
2142 const char* start_bitrate_kbps,
2143 int expected_start_bitrate_bps,
2144 const char* max_bitrate_kbps,
2145 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002146 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2147 expected_start_bitrate_bps,
2148 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002149 auto& codecs = send_parameters_.codecs;
2150 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002151 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002152 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2153 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2154 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002155 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002156 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002157
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002158 void ExpectSetBitrateParameters(int min_bitrate_bps,
2159 int start_bitrate_bps,
2160 int max_bitrate_bps) {
2161 EXPECT_CALL(
2162 *fake_call_->GetMockTransportControllerSend(),
2163 SetSdpBitrateParameters(AllOf(
2164 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2165 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2166 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2167 }
2168
2169 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2170 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2171 SetSdpBitrateParameters(Field(
2172 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002173 }
2174
Johannes Kron9190b822018-10-29 11:22:05 +01002175 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2176 // For a caller, the answer will be applied in set remote description
2177 // where SetSendParameters() is called.
2178 EXPECT_TRUE(
2179 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2180 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2181 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2182 const webrtc::VideoSendStream::Config& config =
2183 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2184 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2185 }
2186
2187 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2188 // For a callee, the answer will be applied in set local description
2189 // where SetExtmapAllowMixed() and AddSendStream() are called.
2190 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2191 EXPECT_TRUE(
2192 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2193 const webrtc::VideoSendStream::Config& config =
2194 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2195 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2196 }
2197
isheriff6f8d6862016-05-26 11:24:55 -07002198 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002199 // Enable extension.
2200 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002201 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002202 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002203 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002204 FakeVideoSendStream* send_stream =
2205 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2206
2207 // Verify the send extension id.
2208 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2209 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002210 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002211 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002212 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002213 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2214 // receivers.
2215 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2216 ->GetConfig()
2217 .rtp.extensions.empty());
2218
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002219 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002220 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002221 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2222 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002223 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2224
2225 // Verify that adding receive RTP header extensions adds them for existing
2226 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002227 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002228 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002229 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2230 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002231 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002232 }
2233
isheriff6f8d6862016-05-26 11:24:55 -07002234 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002235 // Enable extension.
2236 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002237 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002238 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002239 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002240
2241 FakeVideoReceiveStream* recv_stream =
2242 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2243
2244 // Verify the recv extension id.
2245 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2246 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002247 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002248 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002249 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002250
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002251 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2252 // senders.
2253 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2254 ->GetConfig()
2255 .rtp.extensions.empty());
2256
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002257 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002258 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002259 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2260 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002261 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2262
2263 // Verify that adding receive RTP header extensions adds them for existing
2264 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002265 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002266 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002267 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2268 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002269 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002270 }
2271
Elad Alonfadb1812019-05-24 13:40:02 +02002272 void TestLossNotificationState(bool expect_lntf_enabled) {
2273 AssignDefaultCodec();
2274 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2275
2276 cricket::VideoSendParameters parameters;
2277 parameters.codecs = engine_.codecs();
2278 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2279 EXPECT_TRUE(channel_->SetSend(true));
2280
2281 // Send side.
2282 FakeVideoSendStream* send_stream =
2283 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2284 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2285
2286 // Receiver side.
2287 FakeVideoReceiveStream* recv_stream =
2288 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2289 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2290 }
2291
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002292 void TestExtensionFilter(const std::vector<std::string>& extensions,
2293 const std::string& expected_extension) {
2294 cricket::VideoSendParameters parameters = send_parameters_;
2295 int expected_id = -1;
2296 int id = 1;
2297 for (const std::string& extension : extensions) {
2298 if (extension == expected_extension)
2299 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002300 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002301 }
2302 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2303 FakeVideoSendStream* send_stream =
2304 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2305
2306 // Verify that only one of them has been set, and that it is the one with
2307 // highest priority (transport sequence number).
2308 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2309 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2310 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002311 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002312 }
2313
asapersson3c81a1a2017-06-14 05:52:21 -07002314 void TestDegradationPreference(bool resolution_scaling_enabled,
2315 bool fps_scaling_enabled);
2316
Erik Språngefbde372015-04-29 16:21:28 +02002317 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002318 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002319 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2320 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002321
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002322 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002323 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002324 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002325 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002326 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002327 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002328 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002329 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002330 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002331
Erik Språng143cec12015-04-28 10:01:41 +02002332 return fake_call_->GetVideoSendStreams().back();
2333 }
2334
Peter Boström2feafdb2015-09-09 14:32:14 +02002335 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2336 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002337 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002338 std::vector<uint32_t> ssrcs;
2339 std::vector<uint32_t> rtx_ssrcs;
2340 uint32_t num_streams = enabled ? 3 : 1;
2341 for (uint32_t i = 0; i < num_streams; ++i) {
2342 uint32_t ssrc = last_ssrc_ + i;
2343 ssrcs.push_back(ssrc);
2344 if (with_rtx) {
2345 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2346 }
Erik Språng143cec12015-04-28 10:01:41 +02002347 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002348 if (with_rtx) {
2349 return AddSendStream(
2350 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2351 }
2352 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002353 }
2354
perkjfa10b552016-10-02 23:45:26 -07002355 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002356 std::vector<FakeVideoSendStream*> streams =
2357 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002358 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002359 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002360 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002361 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002362 }
2363
perkjfa10b552016-10-02 23:45:26 -07002364 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002365 int stream_max,
2366 int expected_encoder_bitrate) {
2367 VideoSendParameters limited_send_params = send_parameters_;
2368 limited_send_params.max_bandwidth_bps = global_max;
2369 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002370 webrtc::RtpParameters parameters =
2371 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002372 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002373 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002374 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002375 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002376 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002377 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002378 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002379 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002380 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002381 }
2382
Åsa Persson55659812018-06-18 17:51:32 +02002383 // Values from kSimulcastConfigs in simulcast.cc.
2384 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2385 std::vector<webrtc::VideoStream> layers(3);
2386 layers[0].min_bitrate_bps = 30000;
2387 layers[0].target_bitrate_bps = 150000;
2388 layers[0].max_bitrate_bps = 200000;
2389 layers[1].min_bitrate_bps = 150000;
2390 layers[1].target_bitrate_bps = 500000;
2391 layers[1].max_bitrate_bps = 700000;
2392 layers[2].min_bitrate_bps = 600000;
2393 layers[2].target_bitrate_bps = 2500000;
2394 layers[2].max_bitrate_bps = 2500000;
2395 return layers;
2396 }
2397
Niels Möller805a27e2019-01-21 12:21:27 +01002398 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002399 std::unique_ptr<FakeCall> fake_call_;
2400 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002401 cricket::VideoSendParameters send_parameters_;
2402 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002403 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002404};
2405
eladalonf1841382017-06-12 01:16:46 -07002406TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002407 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002408 const std::string kSyncLabel = "AvSyncLabel";
2409
2410 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002411 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002412 EXPECT_TRUE(channel_->AddRecvStream(sp));
2413
Mirko Bonadeif859e552018-05-30 15:31:29 +02002414 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002415 EXPECT_EQ(kSyncLabel,
2416 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2417 << "SyncGroup should be set based on sync_label";
2418}
2419
eladalonf1841382017-06-12 01:16:46 -07002420TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002421 cricket::VideoSendParameters parameters;
2422 parameters.codecs = engine_.codecs();
2423 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002424 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002425 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002426 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002427
2428 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002429 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2430 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002431 FakeVideoSendStream* send_stream = AddSendStream(
2432 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2433
2434 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2435 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2436 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2437
2438 // Receiver side.
2439 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2440 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002441 EXPECT_FALSE(
2442 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002443 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002444 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002445 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002446 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002447 << "RTX should be mapped for the RED payload type";
2448
brandtr14742122017-01-27 04:53:07 -08002449 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002450}
2451
eladalonf1841382017-06-12 01:16:46 -07002452TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002453 // Setup one channel with an associated RTX stream.
2454 cricket::StreamParams params =
2455 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2456 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2457 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002458 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002459
2460 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2461 << "RTX should be mapped for all decoders/payload types.";
2462 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002463 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002464 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002465}
2466
eladalonf1841382017-06-12 01:16:46 -07002467TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002468 // Setup one channel without an associated RTX stream.
2469 cricket::StreamParams params =
2470 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2471 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002472 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002473}
2474
Johannes Kron9190b822018-10-29 11:22:05 +01002475// Test propagation of extmap allow mixed setting.
2476TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2477 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2478}
2479TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2480 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2481}
2482TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2483 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2484}
2485TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2486 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2487}
2488
eladalonf1841382017-06-12 01:16:46 -07002489TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002490 FakeVideoSendStream* send_stream =
2491 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2492 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2493
2494 FakeVideoReceiveStream* recv_stream =
2495 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2496 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002497}
2498
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002499// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002500TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002501 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002502}
isheriff6f8d6862016-05-26 11:24:55 -07002503
eladalonf1841382017-06-12 01:16:46 -07002504TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002505 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002506}
2507
2508// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002509TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002510 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002511}
isheriff6f8d6862016-05-26 11:24:55 -07002512
eladalonf1841382017-06-12 01:16:46 -07002513TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002514 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002515}
2516
eladalonf1841382017-06-12 01:16:46 -07002517TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002518 // Enable three redundant extensions.
2519 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002520 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2521 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2522 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2523 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002524}
2525
eladalonf1841382017-06-12 01:16:46 -07002526TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002527 // Enable two redundant extensions.
2528 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002529 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2530 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2531 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002532}
2533
stefanc1aeaf02015-10-15 07:26:07 -07002534// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002535TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002536 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002537}
eladalonf1841382017-06-12 01:16:46 -07002538TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002539 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002540}
2541
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002542// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002543TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002544 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002545}
eladalonf1841382017-06-12 01:16:46 -07002546TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002547 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002548}
2549
eladalonf1841382017-06-12 01:16:46 -07002550TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002551 const int kAbsSendTimeId = 1;
2552 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002553 send_parameters_.extensions.push_back(
2554 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2555 send_parameters_.extensions.push_back(
2556 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002557
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002558 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002559 FakeVideoSendStream* send_stream =
2560 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2561
2562 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002563 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002564
2565 // Setting the same extensions (even if in different order) shouldn't
2566 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002567 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002568 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002569
2570 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2571
2572 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002573 send_parameters_.extensions.resize(1);
2574 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002575
2576 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2577}
2578
eladalonf1841382017-06-12 01:16:46 -07002579TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002580 const int kTOffsetId = 1;
2581 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002582 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002583 recv_parameters_.extensions.push_back(
2584 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2585 recv_parameters_.extensions.push_back(
2586 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2587 recv_parameters_.extensions.push_back(
2588 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002589
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002590 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002591 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002592 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2593
2594 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002595 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002596
2597 // Setting the same extensions (even if in different order) shouldn't
2598 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002599 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002600 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002601
2602 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2603
2604 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002605 recv_parameters_.extensions.resize(1);
2606 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002607
2608 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2609}
2610
eladalonf1841382017-06-12 01:16:46 -07002611TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002612 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002613 const int kUnsupportedId = 1;
2614 const int kTOffsetId = 2;
2615
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002616 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002617 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002618 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002619 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002620 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002621 FakeVideoSendStream* send_stream =
2622 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2623
2624 // Only timestamp offset extension is set to send stream,
2625 // unsupported rtp extension is ignored.
2626 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002627 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2628 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002629}
2630
eladalonf1841382017-06-12 01:16:46 -07002631TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002632 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002633 const int kUnsupportedId = 1;
2634 const int kTOffsetId = 2;
2635
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002636 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002637 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002638 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002639 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002640 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002641 FakeVideoReceiveStream* recv_stream =
2642 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2643
2644 // Only timestamp offset extension is set to receive stream,
2645 // unsupported rtp extension is ignored.
2646 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002647 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2648 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002649}
2650
eladalonf1841382017-06-12 01:16:46 -07002651TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002652 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002653 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002654 send_parameters_.extensions.push_back(
2655 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002656 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002657 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2658 }
2659}
2660
eladalonf1841382017-06-12 01:16:46 -07002661TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002662 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002663 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002664 recv_parameters_.extensions.push_back(
2665 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002666 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002667 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2668 }
2669}
2670
eladalonf1841382017-06-12 01:16:46 -07002671TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002672 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002673 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002674 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002675 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002676 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002677 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002678
2679 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002680 send_parameters_.extensions.clear();
2681 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002682 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002683 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2684 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002685}
2686
eladalonf1841382017-06-12 01:16:46 -07002687TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002688 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002689 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002690 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002691 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002692 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002693 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002694
2695 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002696 recv_parameters_.extensions.clear();
2697 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002698 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002699 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2700 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002701}
2702
eladalonf1841382017-06-12 01:16:46 -07002703TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002704 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002705 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002706}
2707
eladalonf1841382017-06-12 01:16:46 -07002708TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002709 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002710 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002711}
2712
eladalonf1841382017-06-12 01:16:46 -07002713TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002714 FakeVideoReceiveStream* stream = AddRecvStream();
2715 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002716}
2717
eladalonf1841382017-06-12 01:16:46 -07002718TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002719 FakeVideoReceiveStream* stream = AddRecvStream();
2720 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2721}
2722
eladalonf1841382017-06-12 01:16:46 -07002723TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002724 FakeVideoReceiveStream* stream = AddRecvStream();
2725 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2726
Peter Boström126c03e2015-05-11 12:48:12 +02002727 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002728 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002729 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002730 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2731 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002732 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002733 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2734
2735 // Verify that REMB is turned on when setting default codecs since the
2736 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002737 parameters.codecs = engine_.codecs();
2738 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002739 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002740 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002741}
2742
eladalonf1841382017-06-12 01:16:46 -07002743TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002744 FakeVideoReceiveStream* stream = AddRecvStream();
2745 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2746
2747 // Verify that transport cc feedback is turned off when send(!) codecs without
2748 // transport cc feedback are set.
2749 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002750 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002751 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2752 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2753 stream = fake_call_->GetVideoReceiveStreams()[0];
2754 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2755
2756 // Verify that transport cc feedback is turned on when setting default codecs
2757 // since the default codecs have transport cc feedback enabled.
2758 parameters.codecs = engine_.codecs();
2759 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2760 stream = fake_call_->GetVideoReceiveStreams()[0];
2761 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2762}
2763
Elad Alonfadb1812019-05-24 13:40:02 +02002764TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2765 TestLossNotificationState(false);
2766}
2767
2768TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2769 RTC_DCHECK(!override_field_trials_);
2770 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2771 "WebRTC-RtcpLossNotification/Enabled/");
2772 SetUp();
2773 TestLossNotificationState(true);
2774}
2775
2776TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2777 RTC_DCHECK(!override_field_trials_);
2778 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2779 "WebRTC-RtcpLossNotification/Enabled/");
2780 SetUp();
2781
2782 AssignDefaultCodec();
2783 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2784
2785 {
2786 cricket::VideoSendParameters parameters;
2787 parameters.codecs = engine_.codecs();
2788 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2789 EXPECT_TRUE(channel_->SetSend(true));
2790 }
2791
2792 // Start with LNTF enabled.
2793 FakeVideoSendStream* send_stream =
2794 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2795 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2796 FakeVideoReceiveStream* recv_stream =
2797 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2798 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2799
2800 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2801 cricket::VideoSendParameters parameters;
2802 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2803 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2804 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2805 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2806 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2807 send_stream = fake_call_->GetVideoSendStreams()[0];
2808 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2809
2810 // Setting the default codecs again, including VP8, turns LNTF back on.
2811 parameters.codecs = engine_.codecs();
2812 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2813 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2814 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2815 send_stream = fake_call_->GetVideoSendStreams()[0];
2816 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2817}
2818
eladalonf1841382017-06-12 01:16:46 -07002819TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002820 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002821 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002822
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002823 cricket::VideoSendParameters parameters;
2824 parameters.codecs = engine_.codecs();
2825 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002826 EXPECT_TRUE(channel_->SetSend(true));
2827
2828 // Send side.
2829 FakeVideoSendStream* send_stream =
2830 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2831 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2832
2833 // Receiver side.
2834 FakeVideoReceiveStream* recv_stream =
2835 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2836 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2837
2838 // Nack history size should match between sender and receiver.
2839 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2840 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002841}
2842
eladalonf1841382017-06-12 01:16:46 -07002843TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002844 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002845 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002846
2847 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2848 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2849
2850 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002851 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002852 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002853 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2854 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002855 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2856 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2857 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002858 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2859
Peter Boström67c9df72015-05-11 14:34:58 +02002860 // Verify that NACK is turned on when setting default codecs since the
2861 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002862 parameters.codecs = engine_.codecs();
2863 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002864 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2865 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2866 send_stream = fake_call_->GetVideoSendStreams()[0];
2867 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002868}
2869
Peter Boströme7ba0862016-03-12 00:02:28 +01002870// This test verifies that new frame sizes reconfigures encoders even though not
2871// (yet) sending. The purpose of this is to permit encoding as quickly as
2872// possible once we start sending. Likely the frames being input are from the
2873// same source that will be sent later, which just means that we're ready
2874// earlier.
eladalonf1841382017-06-12 01:16:46 -07002875TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002876 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002877 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002878 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2879 channel_->SetSend(false);
2880
2881 FakeVideoSendStream* stream = AddSendStream();
2882
perkjfa10b552016-10-02 23:45:26 -07002883 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002884 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002885 EXPECT_EQ(0u, streams[0].width);
2886 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002887
Niels Möller805a27e2019-01-21 12:21:27 +01002888 webrtc::test::FrameForwarder frame_forwarder;
2889 cricket::FakeFrameSource frame_source(1280, 720,
2890 rtc::kNumMicrosecsPerSec / 30);
2891
2892 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2893 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002894
2895 // Frame entered, should be reconfigured to new dimensions.
2896 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002897 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2898 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002899
Niels Möllerff40b142018-04-09 08:49:14 +02002900 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002901}
2902
eladalonf1841382017-06-12 01:16:46 -07002903TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002904 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002905 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002906 cricket::VideoSendParameters parameters;
2907 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002908 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002909 AddSendStream();
2910
Niels Möller805a27e2019-01-21 12:21:27 +01002911 webrtc::test::FrameForwarder frame_forwarder;
2912 cricket::FakeFrameSource frame_source(1280, 720,
2913 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002914 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002915 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002916 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2917 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002918
2919 EXPECT_TRUE(channel_->SetSend(true));
2920
Niels Möller805a27e2019-01-21 12:21:27 +01002921 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002922 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2923 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2924
2925 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2926
2927 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002928 webrtc::VideoEncoderConfig encoder_config =
2929 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002930 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002931 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002932 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002933 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2934 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002935 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2936 << "Non-screenshare shouldn't use min-transmit bitrate.";
2937
Niels Möllerff40b142018-04-09 08:49:14 +02002938 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002939 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002940 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002941 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002942 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2943 &frame_forwarder));
2944 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002945 // Send stream recreated after option change.
2946 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2947 send_stream = fake_call_->GetVideoSendStreams().front();
2948 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002949
2950 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002951 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002952 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002953 encoder_config.content_type);
2954 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2955 encoder_config.min_transmit_bitrate_bps);
2956
perkjfa10b552016-10-02 23:45:26 -07002957 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002958 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2959 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002960 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002961 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002962}
2963
eladalonf1841382017-06-12 01:16:46 -07002964TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002965 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002966 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002967 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002968 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002969
2970 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002971 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002972 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002973 webrtc::test::FrameForwarder frame_forwarder;
2974 cricket::FakeFrameSource frame_source(1280, 720,
2975 rtc::kNumMicrosecsPerSec / 30);
2976 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002977 EXPECT_TRUE(channel_->SetSend(true));
2978
Niels Möller805a27e2019-01-21 12:21:27 +01002979 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002980 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2981 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2982
perkj26091b12016-09-01 01:17:40 -07002983 webrtc::VideoEncoderConfig encoder_config =
2984 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002985
2986 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002987 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002988 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002989 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002990
2991 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
2992 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01002993 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002994 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01002995 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002996
Niels Möllerff40b142018-04-09 08:49:14 +02002997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002998}
2999
eladalonf1841382017-06-12 01:16:46 -07003000TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003001 FakeVideoSendStream* stream = AddSendStream();
3002 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3003}
3004
eladalonf1841382017-06-12 01:16:46 -07003005TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003006 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003007 media_config.video.suspend_below_min_bitrate = true;
3008
Sebastian Jansson84848f22018-11-16 10:40:36 +01003009 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003010 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3011 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003012 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003013
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003014 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003015
3016 FakeVideoSendStream* stream = AddSendStream();
3017 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3018
nisse0db023a2016-03-01 04:29:59 -08003019 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003020 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003021 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3022 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003023 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003024
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003025 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003026
nisse0db023a2016-03-01 04:29:59 -08003027 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003028 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3029}
3030
eladalonf1841382017-06-12 01:16:46 -07003031TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003032 FakeVideoSendStream* stream = AddSendStream();
3033 webrtc::VideoCodecVP8 vp8_settings;
3034 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3035 EXPECT_TRUE(vp8_settings.denoisingOn);
3036}
3037
eladalonf1841382017-06-12 01:16:46 -07003038TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003039 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003040 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003041 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003042
Peter Boström2feafdb2015-09-09 14:32:14 +02003043 // Single-stream settings should apply with RTX as well (verifies that we
3044 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3045 // both RTX and regular SSRCs).
3046 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003047
Niels Möller805a27e2019-01-21 12:21:27 +01003048 webrtc::test::FrameForwarder frame_forwarder;
3049 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003050 channel_->SetSend(true);
3051
Niels Möller805a27e2019-01-21 12:21:27 +01003052 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003053
pbos4cba4eb2015-10-26 11:18:18 -07003054 webrtc::VideoCodecVP8 vp8_settings;
3055 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3056 EXPECT_TRUE(vp8_settings.denoisingOn)
3057 << "VP8 denoising should be on by default.";
3058
Niels Möller805a27e2019-01-21 12:21:27 +01003059 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003060
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003061 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3062 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003063 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3064 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003065
Niels Möller805a27e2019-01-21 12:21:27 +01003066 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003067
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003068 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3069 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003070 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3071 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3072
Niels Möllerff40b142018-04-09 08:49:14 +02003073 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003074 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003075 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003076 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003077 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003078
Mirko Bonadeif859e552018-05-30 15:31:29 +02003079 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003080 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3081 // Autmatic resize off when using simulcast.
3082 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3083 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3084
3085 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07003086 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003087 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003088 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003089
Niels Möller805a27e2019-01-21 12:21:27 +01003090 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003091
Mirko Bonadeif859e552018-05-30 15:31:29 +02003092 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003093 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3094 EXPECT_FALSE(vp8_settings.denoisingOn);
3095 // Resizing and frame dropping always off for screen sharing.
3096 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3097 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3098
Niels Möller805a27e2019-01-21 12:21:27 +01003099 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003100
3101 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3102 EXPECT_FALSE(vp8_settings.denoisingOn);
3103 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3104 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3105
Niels Möllerff40b142018-04-09 08:49:14 +02003106 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003107}
3108
deadbeef119760a2016-04-04 11:43:27 -07003109// Test that setting the same options doesn't result in the encoder being
3110// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003111TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003112 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003113 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003114
perkjfa10b552016-10-02 23:45:26 -07003115 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003116 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003117 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003118 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3119 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3120
Niels Möller805a27e2019-01-21 12:21:27 +01003121 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3122 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3123 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003124 // Expect 1 reconfigurations at this point from the initial configuration.
3125 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003126
3127 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003128 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003129 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3130
3131 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003132 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003133 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003134 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3135
Niels Möllerff40b142018-04-09 08:49:14 +02003136 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003137}
3138
eladalonf1841382017-06-12 01:16:46 -07003139class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003140 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003141 Vp9SettingsTest() : Vp9SettingsTest("") {}
3142 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003143 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003144 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003145 }
3146 virtual ~Vp9SettingsTest() {}
3147
3148 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003149 void TearDown() override {
3150 // Remove references to encoder_factory_ since this will be destroyed
3151 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003152 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003153 }
Erik Språng143cec12015-04-28 10:01:41 +02003154};
3155
3156TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003157 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003158 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003159 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003160
Peter Boström2feafdb2015-09-09 14:32:14 +02003161 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003162
Niels Möller805a27e2019-01-21 12:21:27 +01003163 webrtc::test::FrameForwarder frame_forwarder;
3164 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003165 channel_->SetSend(true);
3166
Niels Möller805a27e2019-01-21 12:21:27 +01003167 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003168
pbos4cba4eb2015-10-26 11:18:18 -07003169 webrtc::VideoCodecVP9 vp9_settings;
3170 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003171 EXPECT_TRUE(vp9_settings.denoisingOn)
3172 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003173
Niels Möller805a27e2019-01-21 12:21:27 +01003174 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003175
Erik Språng143cec12015-04-28 10:01:41 +02003176 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3177 EXPECT_FALSE(vp9_settings.denoisingOn);
3178 // Frame dropping always on for real time video.
3179 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3180
Niels Möller805a27e2019-01-21 12:21:27 +01003181 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003182
3183 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3184 EXPECT_TRUE(vp9_settings.denoisingOn);
3185 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3186
3187 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003188 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003189 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003190 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003191
Niels Möller805a27e2019-01-21 12:21:27 +01003192 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003193
3194 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3195 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003196 // Frame dropping always on for screen sharing.
3197 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003198
Niels Möller805a27e2019-01-21 12:21:27 +01003199 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003200
3201 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3202 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003203 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003204
Niels Möllerff40b142018-04-09 08:49:14 +02003205 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003206}
3207
Sergey Silkinf18072e2018-03-14 10:35:35 +01003208TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3209 cricket::VideoSendParameters parameters;
3210 parameters.codecs.push_back(GetEngineCodec("VP9"));
3211 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3212
3213 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3214
3215 FakeVideoSendStream* stream =
3216 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3217
3218 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003219
Niels Möller805a27e2019-01-21 12:21:27 +01003220 webrtc::test::FrameForwarder frame_forwarder;
3221 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003222 channel_->SetSend(true);
3223
Niels Möller805a27e2019-01-21 12:21:27 +01003224 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003225
3226 webrtc::VideoCodecVP9 vp9_settings;
3227 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3228
3229 const size_t kNumSpatialLayers = ssrcs.size();
3230 const size_t kNumTemporalLayers = 3;
3231 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3232 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3233
Niels Möllerff40b142018-04-09 08:49:14 +02003234 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003235}
3236
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003237TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3238 cricket::VideoSendParameters parameters;
3239 parameters.codecs.push_back(GetEngineCodec("VP9"));
3240 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3241
3242 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3243
3244 FakeVideoSendStream* stream =
3245 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3246
3247 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3248
3249 // Despite 3 ssrcs provided, single layer is used.
3250 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3251
3252 webrtc::test::FrameForwarder frame_forwarder;
3253 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3254 channel_->SetSend(true);
3255
3256 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3257
3258 webrtc::VideoCodecVP9 vp9_settings;
3259 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3260
3261 const size_t kNumSpatialLayers = ssrcs.size();
3262 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3263
3264 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3265}
3266
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003267TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3268 cricket::VideoSendParameters send_parameters;
3269 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3270 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3271
3272 const size_t kNumSpatialLayers = 3;
3273 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3274
3275 FakeVideoSendStream* stream =
3276 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3277
3278 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3279 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3280 ASSERT_TRUE(parameters.encodings[0].active);
3281 ASSERT_TRUE(parameters.encodings[1].active);
3282 ASSERT_TRUE(parameters.encodings[2].active);
3283 // Invert value to verify copying.
3284 parameters.encodings[1].active = false;
3285 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3286
3287 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3288
3289 // number_of_streams should be 1 since all spatial layers are sent on the
3290 // same SSRC. But encoding parameters of all layers is supposed to be copied
3291 // and stored in simulcast_layers[].
3292 EXPECT_EQ(1u, encoder_config.number_of_streams);
3293 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3294 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3295 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3296 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3297}
3298
Sergey Silkincf267052019-04-09 11:40:09 +02003299class Vp9SettingsTestWithFieldTrial
3300 : public Vp9SettingsTest,
3301 public ::testing::WithParamInterface<
3302 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003303 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003304 Vp9SettingsTestWithFieldTrial()
3305 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3306 num_spatial_layers_(::testing::get<1>(GetParam())),
3307 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003308 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003309
3310 void VerifySettings(int num_spatial_layers,
3311 int num_temporal_layers,
3312 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003313 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003314 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003315 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3316
3317 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3318
Niels Möller805a27e2019-01-21 12:21:27 +01003319 webrtc::test::FrameForwarder frame_forwarder;
3320 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003321 channel_->SetSend(true);
3322
Niels Möller805a27e2019-01-21 12:21:27 +01003323 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003324
3325 webrtc::VideoCodecVP9 vp9_settings;
3326 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3327 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3328 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003329 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003330
Niels Möllerff40b142018-04-09 08:49:14 +02003331 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003332 }
Sergey Silkincf267052019-04-09 11:40:09 +02003333
3334 const uint8_t num_spatial_layers_;
3335 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003336 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003337};
3338
Sergey Silkincf267052019-04-09 11:40:09 +02003339TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003340 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3341 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003342}
3343
Sergey Silkincf267052019-04-09 11:40:09 +02003344INSTANTIATE_TEST_SUITE_P(
3345 ,
3346 Vp9SettingsTestWithFieldTrial,
3347 ::testing::Values(
3348 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3349 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3350 1,
3351 1,
3352 webrtc::InterLayerPredMode::kOnKeyPic),
3353 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3354 2,
3355 3,
3356 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003357 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003358 1,
3359 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003360 webrtc::InterLayerPredMode::kOnKeyPic),
3361 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003362 1,
3363 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003364 webrtc::InterLayerPredMode::kOnKeyPic),
3365 std::make_tuple(
3366 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3367 1,
3368 1,
3369 webrtc::InterLayerPredMode::kOff),
3370 std::make_tuple(
3371 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3372 1,
3373 1,
3374 webrtc::InterLayerPredMode::kOn),
3375 std::make_tuple(
3376 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3377 1,
3378 1,
3379 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003380
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003381TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3382 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3383 ASSERT_EQ(1u, streams.size());
3384 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3385}
3386
3387TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003388 RTC_DCHECK(!override_field_trials_);
3389 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003390 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3391 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3392 ASSERT_EQ(1u, streams.size());
3393 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3394}
3395
asapersson3c81a1a2017-06-14 05:52:21 -07003396TEST_F(WebRtcVideoChannelTest,
3397 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003398 RTC_DCHECK(!override_field_trials_);
3399 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003400 "WebRTC-Video-BalancedDegradation/Disabled/");
3401 const bool kResolutionScalingEnabled = true;
3402 const bool kFpsScalingEnabled = false;
3403 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3404}
3405
3406TEST_F(WebRtcVideoChannelTest,
3407 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003408 RTC_DCHECK(!override_field_trials_);
3409 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003410 "WebRTC-Video-BalancedDegradation/Enabled/");
3411 const bool kResolutionScalingEnabled = true;
3412 const bool kFpsScalingEnabled = true;
3413 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3414}
3415
eladalonf1841382017-06-12 01:16:46 -07003416TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003417 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003418}
3419
eladalonf1841382017-06-12 01:16:46 -07003420TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003421 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003422}
3423
Niels Möller3de32e62019-01-18 08:42:18 +01003424TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3425 TestCpuAdaptation(false, true);
3426}
3427
eladalonf1841382017-06-12 01:16:46 -07003428TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003429 TestCpuAdaptation(true, true);
3430}
3431
eladalonf1841382017-06-12 01:16:46 -07003432TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003433 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003434 cricket::VideoSendParameters parameters;
3435 parameters.codecs.push_back(codec);
3436
kthelgason2bc68642017-02-07 07:02:22 -08003437 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003438 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003439 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003440 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3441 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003442 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003443 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3444
3445 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003446 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003447
Per766ad3b2016-04-05 15:23:49 +02003448 ASSERT_TRUE(channel_->SetSend(true));
3449 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003450 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003451 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003452
3453 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3454 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003455
Niels Möllerdcc70292019-01-15 16:32:38 +01003456 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3457 // Dont' expect anything on framerate_scaling_enabled, since the default is
3458 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003459
Niels Möllerdcc70292019-01-15 16:32:38 +01003460 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003461 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003462 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003463 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003464 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3465 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003466 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003467
Niels Möllerdcc70292019-01-15 16:32:38 +01003468 // Switch back to the normal capturer. Expect resolution scaling to be
3469 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003470 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3471 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003472 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3473 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003474 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003475
Niels Möllerff40b142018-04-09 08:49:14 +02003476 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003477}
3478
asapersson3c81a1a2017-06-14 05:52:21 -07003479// TODO(asapersson): Remove this test when the balanced field trial is removed.
3480void WebRtcVideoChannelTest::TestDegradationPreference(
3481 bool resolution_scaling_enabled,
3482 bool fps_scaling_enabled) {
3483 cricket::VideoCodec codec = GetEngineCodec("VP8");
3484 cricket::VideoSendParameters parameters;
3485 parameters.codecs.push_back(codec);
3486
3487 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003488 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003489 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003490 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3491 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003492 channel_->OnReadyToSend(true);
3493
3494 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3495
3496 AddSendStream();
3497
Niels Möller805a27e2019-01-21 12:21:27 +01003498 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003499 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003500 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003501
3502 EXPECT_TRUE(channel_->SetSend(true));
3503
3504 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3505 EXPECT_EQ(resolution_scaling_enabled,
3506 send_stream->resolution_scaling_enabled());
3507 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3508
Niels Möllerff40b142018-04-09 08:49:14 +02003509 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003510}
3511
eladalonf1841382017-06-12 01:16:46 -07003512void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3513 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003514 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003515 cricket::VideoSendParameters parameters;
3516 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003517
kthelgason2bc68642017-02-07 07:02:22 -08003518 MediaConfig media_config = GetMediaConfig();
3519 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003520 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003521 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003522 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003523 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3524 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003525 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003526
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003527 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003528
3529 AddSendStream();
3530
Niels Möller805a27e2019-01-21 12:21:27 +01003531 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003532 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003533 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003534 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003535
3536 EXPECT_TRUE(channel_->SetSend(true));
3537
solenberge5269742015-09-08 05:13:22 -07003538 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003539
sprangc5d62e22017-04-02 23:53:04 -07003540 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003541 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003542 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003543 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003544 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3545 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3546 } else {
3547 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3548 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3549 }
Niels Möllerff40b142018-04-09 08:49:14 +02003550 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003551}
3552
eladalonf1841382017-06-12 01:16:46 -07003553TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003554 // Start at last timestamp to verify that wraparounds are estimated correctly.
3555 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3556 static const int64_t kInitialNtpTimeMs = 1247891230;
3557 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003558 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003559
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003560 FakeVideoReceiveStream* stream = AddRecvStream();
3561 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003562 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003563
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003564 webrtc::VideoFrame video_frame =
3565 webrtc::VideoFrame::Builder()
3566 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3567 .set_timestamp_rtp(kInitialTimestamp)
3568 .set_timestamp_us(0)
3569 .set_rotation(webrtc::kVideoRotation_0)
3570 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003571 // Initial NTP time is not available on the first frame, but should still be
3572 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003573 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003574
3575 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003576
3577 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3578 // triggers a constant-overflow warning, hence we're calculating it explicitly
3579 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003580 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003581 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3582 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003583 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003584
3585 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003586
3587 // Verify that NTP time has been correctly deduced.
3588 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003589 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003590 ASSERT_EQ(1u, info.receivers.size());
3591 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003592}
3593
eladalonf1841382017-06-12 01:16:46 -07003594TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003595 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003596 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003597
3598 VideoCodec codec;
3599 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003600 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003601
3602 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003603 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3604 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003605 FakeVideoSendStream* stream = AddSendStream(
3606 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003607 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003608
3609 // Make sure NACK and FEC are enabled on the correct payload types.
3610 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003611 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3612 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003613
3614 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3615 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003616 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003617 // TODO(juberti): Check RTCP, PLI, TMMBR.
3618}
3619
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003620TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3621 cricket::VideoSendParameters parameters;
3622 parameters.codecs.push_back(GetEngineCodec("VP8"));
3623 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3624
3625 FakeVideoSendStream* stream = AddSendStream();
3626 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3627 EXPECT_FALSE(config.rtp.raw_payload);
3628}
3629
3630TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3631 cricket::VideoSendParameters parameters;
3632 parameters.codecs.push_back(GetEngineCodec("VP8"));
3633 parameters.codecs.back().packetization = kPacketizationParamRaw;
3634 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3635
3636 FakeVideoSendStream* stream = AddSendStream();
3637 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3638 EXPECT_TRUE(config.rtp.raw_payload);
3639}
3640
brandtr31bd2242017-05-19 05:47:46 -07003641// The following four tests ensures that FlexFEC is not activated by default
3642// when the field trials are not enabled.
3643// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3644// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003645TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003646 FakeVideoSendStream* stream = AddSendStream();
3647 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3648
brandtr3d200bd2017-01-16 06:59:19 -08003649 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003650 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3651 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003652}
3653
eladalonf1841382017-06-12 01:16:46 -07003654TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003655 FakeVideoSendStream* stream = AddSendStream(
3656 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3657 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3658
brandtr3d200bd2017-01-16 06:59:19 -08003659 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003660 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3661 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3662}
3663
Yves Gerey665174f2018-06-19 15:03:05 +02003664TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003665 AddRecvStream();
3666
3667 const std::vector<FakeFlexfecReceiveStream*>& streams =
3668 fake_call_->GetFlexfecReceiveStreams();
3669 EXPECT_TRUE(streams.empty());
3670}
3671
eladalonf1841382017-06-12 01:16:46 -07003672TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003673 AddRecvStream(
3674 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3675
3676 const std::vector<FakeFlexfecReceiveStream*>& streams =
3677 fake_call_->GetFlexfecReceiveStreams();
3678 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003679}
3680
3681// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3682// tests that use this test fixture into the corresponding "non-field trial"
3683// tests.
eladalonf1841382017-06-12 01:16:46 -07003684class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003685 public:
eladalonf1841382017-06-12 01:16:46 -07003686 WebRtcVideoChannelFlexfecRecvTest()
3687 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003688};
3689
eladalonf1841382017-06-12 01:16:46 -07003690TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003691 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3692 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3693 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3694}
3695
eladalonf1841382017-06-12 01:16:46 -07003696TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003697 AddRecvStream();
3698
3699 const std::vector<FakeFlexfecReceiveStream*>& streams =
3700 fake_call_->GetFlexfecReceiveStreams();
3701 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003702
3703 const std::vector<FakeVideoReceiveStream*>& video_streams =
3704 fake_call_->GetVideoReceiveStreams();
3705 ASSERT_EQ(1U, video_streams.size());
3706 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3707 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3708 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003709}
3710
eladalonf1841382017-06-12 01:16:46 -07003711TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003712 AddRecvStream(
3713 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3714
3715 const std::vector<FakeFlexfecReceiveStream*>& streams =
3716 fake_call_->GetFlexfecReceiveStreams();
3717 ASSERT_EQ(1U, streams.size());
3718 const FakeFlexfecReceiveStream* stream = streams.front();
3719 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3720 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3721 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3722 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3723 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003724
3725 const std::vector<FakeVideoReceiveStream*>& video_streams =
3726 fake_call_->GetVideoReceiveStreams();
3727 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003728 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3729 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003730 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003731 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003732 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003733}
3734
eladalonf1841382017-06-12 01:16:46 -07003735TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003736 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3737 cricket::VideoRecvParameters recv_parameters;
3738 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3739 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3740
3741 AddRecvStream(
3742 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3743 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003744 const std::vector<FakeVideoReceiveStream*>& video_streams =
3745 fake_call_->GetVideoReceiveStreams();
3746 ASSERT_EQ(1U, video_streams.size());
3747 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3748 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3749 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003750
3751 // Enable FlexFEC.
3752 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3753 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3754 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3755 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3756 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3757 << "Enabling FlexFEC should not create VideoReceiveStream.";
3758 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3759 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003760 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3761 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003762}
3763
eladalonf1841382017-06-12 01:16:46 -07003764TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003765 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3766 cricket::VideoRecvParameters recv_parameters;
3767 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3768 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3769 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3770
3771 AddRecvStream(
3772 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3773 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003774 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003775 const std::vector<FakeVideoReceiveStream*>& video_streams =
3776 fake_call_->GetVideoReceiveStreams();
3777 ASSERT_EQ(1U, video_streams.size());
3778 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3779 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3780 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003781
3782 // Disable FlexFEC.
3783 recv_parameters.codecs.clear();
3784 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3785 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3786 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3787 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3788 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3789 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3790 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3791 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003792 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3793 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003794}
3795
brandtr31bd2242017-05-19 05:47:46 -07003796// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3797// tests that use this test fixture into the corresponding "non-field trial"
3798// tests.
eladalonf1841382017-06-12 01:16:46 -07003799class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003800 public:
eladalonf1841382017-06-12 01:16:46 -07003801 WebRtcVideoChannelFlexfecSendRecvTest()
3802 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003803 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3804 }
3805};
3806
Yves Gerey665174f2018-06-19 15:03:05 +02003807TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003808 FakeVideoSendStream* stream = AddSendStream();
3809 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3810
brandtr3d200bd2017-01-16 06:59:19 -08003811 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3812 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3813 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003814}
3815
eladalonf1841382017-06-12 01:16:46 -07003816TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003817 FakeVideoSendStream* stream = AddSendStream(
3818 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3819 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3820
brandtr3d200bd2017-01-16 06:59:19 -08003821 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3822 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3823 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3824 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003825}
3826
eladalonf1841382017-06-12 01:16:46 -07003827TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003828 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003829 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003830 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003831
3832 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003833 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003834
brandtrb5f2c3f2016-10-04 23:28:39 -07003835 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3836 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003837}
3838
eladalonf1841382017-06-12 01:16:46 -07003839TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003840 cricket::VideoSendParameters parameters;
3841 parameters.codecs.push_back(GetEngineCodec("VP8"));
3842 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3843
3844 FakeVideoSendStream* stream = AddSendStream();
3845 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3846
brandtr3d200bd2017-01-16 06:59:19 -08003847 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003848}
3849
eladalonf1841382017-06-12 01:16:46 -07003850TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003851 AddRecvStream(
3852 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003853
3854 cricket::VideoRecvParameters recv_parameters;
3855 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3856 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3857 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003858
3859 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3860 fake_call_->GetFlexfecReceiveStreams();
3861 ASSERT_EQ(1U, flexfec_streams.size());
3862 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3863 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3864 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003865 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003866 flexfec_stream_config.payload_type);
3867 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3868 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3869 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3870 const std::vector<FakeVideoReceiveStream*>& video_streams =
3871 fake_call_->GetVideoReceiveStreams();
3872 const FakeVideoReceiveStream* video_stream = video_streams.front();
3873 const webrtc::VideoReceiveStream::Config& video_stream_config =
3874 video_stream->GetConfig();
3875 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3876 flexfec_stream_config.local_ssrc);
3877 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3878 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3879 flexfec_stream_config.rtcp_send_transport);
3880 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3881 // spec-compliant way.
3882 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3883 flexfec_stream_config.transport_cc);
3884 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3885 EXPECT_EQ(video_stream_config.rtp.extensions,
3886 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003887}
3888
brandtr31bd2242017-05-19 05:47:46 -07003889// We should not send FlexFEC, even if we advertise it, unless the right
3890// field trial is set.
3891// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003892TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003893 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3894 cricket::VideoSendParameters parameters;
3895 parameters.codecs.push_back(GetEngineCodec("VP8"));
3896 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3897 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3898
3899 FakeVideoSendStream* stream = AddSendStream();
3900 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3901
3902 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003903 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003904 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3905}
3906
eladalonf1841382017-06-12 01:16:46 -07003907TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003908 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3909 cricket::VideoSendParameters parameters;
3910 parameters.codecs.push_back(GetEngineCodec("VP8"));
3911 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3912 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3913
3914 FakeVideoSendStream* stream = AddSendStream(
3915 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3916 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3917
3918 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003919 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003920 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3921}
3922
eladalonf1841382017-06-12 01:16:46 -07003923TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003924 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003925 const int kUnusedPayloadType = 127;
3926 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3927
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003928 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003929 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003930 parameters.codecs.push_back(rtx_codec);
3931 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003932 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003933}
3934
eladalonf1841382017-06-12 01:16:46 -07003935TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003936 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003937 const int kUnusedPayloadType1 = 126;
3938 const int kUnusedPayloadType2 = 127;
3939 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3940 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3941 {
3942 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3943 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3944 cricket::VideoSendParameters parameters;
3945 parameters.codecs.push_back(GetEngineCodec("VP8"));
3946 parameters.codecs.push_back(rtx_codec);
3947 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3948 }
3949 {
3950 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3951 kUnusedPayloadType1, kUnusedPayloadType2);
3952 cricket::VideoSendParameters parameters;
3953 parameters.codecs.push_back(GetEngineCodec("VP8"));
3954 parameters.codecs.push_back(rtx_codec);
3955 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3956 << "RTX without matching video codec should be rejected.";
3957 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003958}
3959
eladalonf1841382017-06-12 01:16:46 -07003960TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003961 const int kUnusedPayloadType1 = 126;
3962 const int kUnusedPayloadType2 = 127;
3963 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3964 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3965
3966 // SSRCs for RTX.
3967 cricket::StreamParams params =
3968 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3969 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3970 AddSendStream(params);
3971
3972 // Original payload type for RTX.
3973 cricket::VideoSendParameters parameters;
3974 parameters.codecs.push_back(GetEngineCodec("VP8"));
3975 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
3976 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
3977 parameters.codecs.push_back(rtx_codec);
3978 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3979 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3980 const webrtc::VideoSendStream::Config& config_before =
3981 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3982 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
3983 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
3984 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
3985
3986 // Change payload type for RTX.
3987 parameters.codecs[1].id = kUnusedPayloadType2;
3988 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3989 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
3990 const webrtc::VideoSendStream::Config& config_after =
3991 fake_call_->GetVideoSendStreams()[0]->GetConfig();
3992 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
3993 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
3994 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
3995}
3996
eladalonf1841382017-06-12 01:16:46 -07003997TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003998 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003999 parameters.codecs.push_back(GetEngineCodec("VP8"));
4000 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004001 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004002
4003 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004004 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004005
magjed509e4fe2016-11-18 01:34:11 -08004006 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004007
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004008 parameters.codecs.pop_back();
4009 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004010 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004011 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004012 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004013 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004014 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4015}
4016
eladalonf1841382017-06-12 01:16:46 -07004017TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004018 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004019 cricket::VideoSendParameters parameters;
4020 parameters.codecs.push_back(GetEngineCodec("VP8"));
4021 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4022 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4023
4024 FakeVideoSendStream* stream = AddSendStream(
4025 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4026 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4027
brandtr3d200bd2017-01-16 06:59:19 -08004028 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4029 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004030 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4031 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4032
4033 parameters.codecs.pop_back();
4034 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4035 stream = fake_call_->GetVideoSendStreams()[0];
4036 ASSERT_TRUE(stream != nullptr);
4037 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004038 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004039 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004040}
4041
eladalonf1841382017-06-12 01:16:46 -07004042TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004043 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004044 cricket::VideoCodec codec(100, "VP8");
4045 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4046 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004047
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004048 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004049 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004050
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004051 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004052 webrtc::test::FrameForwarder frame_forwarder;
4053 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004054
4055 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004056 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004057
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004058 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004059 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4060 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004061 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004062 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004063 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004064 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004065}
4066
eladalonf1841382017-06-12 01:16:46 -07004067TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004068 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4069 200000);
4070}
4071
eladalonf1841382017-06-12 01:16:46 -07004072TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004073 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4074 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4075 ASSERT_EQ(1u, streams.size());
4076 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4077}
4078
eladalonf1841382017-06-12 01:16:46 -07004079TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004080 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004081 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004082}
4083
eladalonf1841382017-06-12 01:16:46 -07004084TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004085 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004086}
4087
eladalonf1841382017-06-12 01:16:46 -07004088TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004089 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4090 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4091 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004092}
4093
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004094// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4095// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004096TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004097 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4098 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4099 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4100 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004101 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004102 ExpectSetBitrateParameters(100000, 200000, 400000);
4103 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4104 // Since the codec isn't changing, start_bitrate_bps should be -1.
4105 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004106
4107 // Decrease max_bandwidth_bps.
4108 send_parameters_.max_bandwidth_bps = 350000;
4109 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004110
4111 // Now try again with the values flipped around.
4112 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4113 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004114 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004115 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004116
4117 // If we change the codec max, max_bandwidth_bps should still apply.
4118 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004119 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004120 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004121}
4122
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004123// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4124// are present in the same send parameters, the settings are combined correctly.
4125TEST_F(WebRtcVideoChannelTest,
4126 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4127 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4128 // Transport.
4129 webrtc::MediaTransportSettings settings;
4130 settings.is_caller = true;
4131 webrtc::FakeMediaTransport fake_media_transport(settings);
4132 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4133 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004134 channel_->SetInterface(network_interface.get(),
4135 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004136
4137 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4138 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4139 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4140 send_parameters_.max_bandwidth_bps = 400000;
4141 {
4142 // We expect max_bandwidth_bps to take priority, if set.
4143 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4144 ASSERT_EQ(1u,
4145 fake_media_transport.target_rate_constraints_in_order().size());
4146 const webrtc::MediaTransportTargetRateConstraints& constraint =
4147 fake_media_transport.target_rate_constraints_in_order()[0];
4148 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4149 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4150 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4151 }
4152
4153 {
4154 // Decrease max_bandwidth_bps.
4155 send_parameters_.max_bandwidth_bps = 350000;
4156 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4157 ASSERT_EQ(2u,
4158 fake_media_transport.target_rate_constraints_in_order().size());
4159 const webrtc::MediaTransportTargetRateConstraints& constraint =
4160 fake_media_transport.target_rate_constraints_in_order()[1];
4161
4162 // Since the codec isn't changing, start_bitrate_bps should be 0.
4163 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4164 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4165 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4166 }
4167
4168 {
4169 // Now try again with the values flipped around.
4170 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4171 send_parameters_.max_bandwidth_bps = 300000;
4172 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4173 ASSERT_EQ(3u,
4174 fake_media_transport.target_rate_constraints_in_order().size());
4175 const webrtc::MediaTransportTargetRateConstraints& constraint =
4176 fake_media_transport.target_rate_constraints_in_order()[2];
4177
4178 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4179 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4180 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4181 }
4182
4183 {
4184 // Now try again with the values flipped around.
4185 // If we change the codec max, max_bandwidth_bps should still apply.
4186 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4187 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4188 ASSERT_EQ(4u,
4189 fake_media_transport.target_rate_constraints_in_order().size());
4190 const webrtc::MediaTransportTargetRateConstraints& constraint =
4191 fake_media_transport.target_rate_constraints_in_order()[3];
4192
4193 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4194 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4195 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4196 }
4197}
4198
Yves Gerey665174f2018-06-19 15:03:05 +02004199TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004200 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4201 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004202 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004203 // Setting max bitrate should keep previous min bitrate.
4204 // Setting max bitrate should not reset start bitrate.
4205 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004206 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004207}
4208
eladalonf1841382017-06-12 01:16:46 -07004209TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004210 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004211 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004212 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004213 // -1 means to disable max bitrate (set infinite).
4214 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004215 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004216 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004217}
4218
eladalonf1841382017-06-12 01:16:46 -07004219TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004220 send_parameters_.max_bandwidth_bps = 99999;
4221 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004222 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004223 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004224 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4225 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4226 stream->GetVideoStreams()[0].max_bitrate_bps);
4227
4228 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004229 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004230 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4231 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004232 stream->GetVideoStreams()[0].max_bitrate_bps);
4233}
4234
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004235// Tests that when the codec specific max bitrate and VideoSendParameters
4236// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4237// appropriately.
4238TEST_F(WebRtcVideoChannelTest,
4239 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4240 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4241 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4242 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4243 send_parameters_.max_bandwidth_bps = -1;
4244 AddSendStream();
4245 ExpectSetMaxBitrate(300000);
4246 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4247
4248 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4249 ASSERT_EQ(1u, video_send_streams.size());
4250 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4251 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4252 // First the max bitrate is set based upon the codec param.
4253 EXPECT_EQ(300000,
4254 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4255
4256 // The VideoSendParameters max bitrate overrides the codec's.
4257 send_parameters_.max_bandwidth_bps = 500000;
4258 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4259 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4260 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4261 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4262}
4263
4264// Tests that when the codec specific max bitrate and RtpParameters
4265// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4266// appropriately.
4267TEST_F(WebRtcVideoChannelTest,
4268 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4269 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4270 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4271 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4272 send_parameters_.max_bandwidth_bps = -1;
4273 AddSendStream();
4274 ExpectSetMaxBitrate(300000);
4275 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4276
4277 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4278 ASSERT_EQ(1u, video_send_streams.size());
4279 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4280 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4281 // First the max bitrate is set based upon the codec param.
4282 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4283
4284 // The RtpParameter max bitrate overrides the codec's.
4285 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4286 ASSERT_EQ(1u, parameters.encodings.size());
4287 parameters.encodings[0].max_bitrate_bps = 500000;
4288 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4289 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4290 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4291 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4292}
4293
Åsa Persson55659812018-06-18 17:51:32 +02004294TEST_F(WebRtcVideoChannelTest,
4295 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4296 send_parameters_.max_bandwidth_bps = 99999;
4297 FakeVideoSendStream* stream = AddSendStream();
4298 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4299 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4300 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4301 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4302 stream->GetVideoStreams()[0].max_bitrate_bps);
4303
4304 // Get and set the rtp encoding parameters.
4305 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4306 EXPECT_EQ(1u, parameters.encodings.size());
4307
4308 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4309 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4310 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4311 stream->GetVideoStreams()[0].max_bitrate_bps);
4312
4313 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4314 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4315 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4316 stream->GetVideoStreams()[0].max_bitrate_bps);
4317}
4318
eladalonf1841382017-06-12 01:16:46 -07004319TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004320 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004321 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004322 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004323 channel_->SetSend(true);
4324
4325 FakeVideoSendStream* stream = AddSendStream();
4326
Niels Möller805a27e2019-01-21 12:21:27 +01004327 webrtc::test::FrameForwarder frame_forwarder;
4328 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004329
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004330 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4331 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4332 EXPECT_GT(initial_max_bitrate_bps, 0);
4333
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004334 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4335 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004336 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004337 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004338 streams = stream->GetVideoStreams();
4339 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004340 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004341}
4342
eladalonf1841382017-06-12 01:16:46 -07004343TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004344 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004345 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004346 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004347 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004348 channel_->SetSend(true);
4349
4350 FakeVideoSendStream* stream = AddSendStream(
4351 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4352
4353 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004354 webrtc::test::FrameForwarder frame_forwarder;
4355 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4356 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004357
4358 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4359 ASSERT_GT(streams.size(), 1u)
4360 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004361 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004362 EXPECT_GT(initial_max_bitrate_bps, 0);
4363
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004364 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4365 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004366 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004367 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004368 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004369 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004370 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4371
Niels Möllerff40b142018-04-09 08:49:14 +02004372 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004373}
4374
eladalonf1841382017-06-12 01:16:46 -07004375TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004376 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004377 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004378 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004379 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4380 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004381 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004382 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004383
4384 VideoCodec codec;
4385 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4386 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4387}
4388
eladalonf1841382017-06-12 01:16:46 -07004389TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004390 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004391 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004392 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004393 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004394 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004395 parameters.codecs[0].id = kIncorrectPayloads[i];
4396 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004397 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004398 }
4399}
4400
eladalonf1841382017-06-12 01:16:46 -07004401TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004402 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004403 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004404 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004405 parameters.codecs[0].id = payload_type;
4406 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004407 << "Payload type '" << payload_type << "' rejected.";
4408 }
4409}
4410
deadbeef67cf2c12016-04-13 10:07:16 -07004411// Test that setting the a different set of codecs but with an identical front
4412// codec doesn't result in the stream being recreated.
4413// This may happen when a subsequent negotiation includes fewer codecs, as a
4414// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004415TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004416 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4417 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004418 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4419 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004420 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4421
4422 AddSendStream();
4423 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4424
4425 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004426 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004427 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4428 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4429}
4430
eladalonf1841382017-06-12 01:16:46 -07004431TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004432 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004433 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004434 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004435}
4436
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004437// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004438TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004439 const int kUnusedPayloadType1 = 126;
4440 const int kUnusedPayloadType2 = 127;
4441 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4442 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4443
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004444 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004445 parameters.codecs.push_back(GetEngineCodec("VP8"));
4446 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004447 parameters.codecs.push_back(rtx_codec);
4448 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004449 << "RTX codec without associated payload should be rejected.";
4450
magjed509e4fe2016-11-18 01:34:11 -08004451 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004452 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004453 << "RTX codec with invalid associated payload type should be rejected.";
4454
magjed509e4fe2016-11-18 01:34:11 -08004455 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004456 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004457
magjed509e4fe2016-11-18 01:34:11 -08004458 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004459 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004460 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004461
Yves Gerey665174f2018-06-19 15:03:05 +02004462 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4463 << "RTX codec with another RTX as associated payload type should be "
4464 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004465}
4466
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004467TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4468 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4469 vp8_codec.packetization = kPacketizationParamRaw;
4470
4471 cricket::VideoRecvParameters parameters;
4472 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4473 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4474
4475 const cricket::StreamParams params =
4476 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4477 AddRecvStream(params);
4478 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4479
4480 const webrtc::VideoReceiveStream::Config& config =
4481 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4482 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4483 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4484}
4485
4486TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4487 cricket::VideoRecvParameters parameters;
4488 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4489 parameters.codecs.back().packetization = kPacketizationParamRaw;
4490 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4491
4492 const cricket::StreamParams params =
4493 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4494 AddRecvStream(params);
4495 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4496 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4497
4498 parameters.codecs.back().packetization.reset();
4499 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4500 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4501}
4502
eladalonf1841382017-06-12 01:16:46 -07004503TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004504 const int kUnusedPayloadType1 = 126;
4505 const int kUnusedPayloadType2 = 127;
4506 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4507 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4508
4509 // SSRCs for RTX.
4510 cricket::StreamParams params =
4511 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4512 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4513 AddRecvStream(params);
4514
4515 // Original payload type for RTX.
4516 cricket::VideoRecvParameters parameters;
4517 parameters.codecs.push_back(GetEngineCodec("VP8"));
4518 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4519 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4520 parameters.codecs.push_back(rtx_codec);
4521 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4522 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4523 const webrtc::VideoReceiveStream::Config& config_before =
4524 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004525 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4526 const int* payload_type_before = FindKeyByValue(
4527 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4528 ASSERT_NE(payload_type_before, nullptr);
4529 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004530 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4531
4532 // Change payload type for RTX.
4533 parameters.codecs[1].id = kUnusedPayloadType2;
4534 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4535 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4536 const webrtc::VideoReceiveStream::Config& config_after =
4537 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004538 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4539 const int* payload_type_after = FindKeyByValue(
4540 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4541 ASSERT_NE(payload_type_after, nullptr);
4542 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004543 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4544}
4545
eladalonf1841382017-06-12 01:16:46 -07004546TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004547 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004548 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004549 parameters.codecs[0].id = 99;
4550 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004551}
4552
eladalonf1841382017-06-12 01:16:46 -07004553TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004554 cricket::VideoRecvParameters parameters;
4555 parameters.codecs = engine_.codecs();
4556 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004557
4558 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004559 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004560 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004561 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004562}
4563
eladalonf1841382017-06-12 01:16:46 -07004564TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004565 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004566 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004567 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004568 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004569}
4570
eladalonf1841382017-06-12 01:16:46 -07004571TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004572 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004573 parameters.codecs.push_back(GetEngineCodec("VP8"));
4574 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004575 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004576}
4577
eladalonf1841382017-06-12 01:16:46 -07004578TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004579 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004580 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4581 send_parameters.codecs.push_back(GetEngineCodec("red"));
4582 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004583 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004584
4585 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004586
magjed509e4fe2016-11-18 01:34:11 -08004587 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004588 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004589
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004590 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004591 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004592 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004593 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004594 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004595 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004596 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4597}
4598
eladalonf1841382017-06-12 01:16:46 -07004599TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004600 AddRecvStream(
4601 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004602 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004603 fake_call_->GetFlexfecReceiveStreams();
4604
4605 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004606 const FakeFlexfecReceiveStream* stream = streams.front();
4607 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4608 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4609 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4610 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004611
4612 cricket::VideoRecvParameters recv_parameters;
4613 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4614 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4615 EXPECT_TRUE(streams.empty())
4616 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004617}
4618
eladalonf1841382017-06-12 01:16:46 -07004619TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004620 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004621 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004622 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004623
4624 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004625 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4626 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4627 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004628 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4629 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004630 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004631 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004632 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004633 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004634
4635 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004636 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4637 send_parameters.codecs.push_back(GetEngineCodec("red"));
4638 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004639 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4640 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004641 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004642 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004643 << "ULPFEC should be enabled on the receive stream.";
4644}
4645
eladalonf1841382017-06-12 01:16:46 -07004646TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004647 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004648 AddRecvStream(
4649 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004650 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004651 fake_call_->GetFlexfecReceiveStreams();
4652
4653 cricket::VideoRecvParameters recv_parameters;
4654 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4655 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4656 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4657 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004658 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004659 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004660 stream_with_recv_params->GetConfig().payload_type);
4661 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004662 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004663 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004664 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004665 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004666
4667 cricket::VideoSendParameters send_parameters;
4668 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4669 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4670 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4671 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004672 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004673 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004674 stream_with_send_params->GetConfig().payload_type);
4675 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004676 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004677 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004678 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004679 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004680}
4681
eladalonf1841382017-06-12 01:16:46 -07004682TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004683 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004684 parameters.codecs.push_back(GetEngineCodec("VP8"));
4685 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004686 parameters.codecs[1].id = parameters.codecs[0].id;
4687 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004688}
4689
eladalonf1841382017-06-12 01:16:46 -07004690TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004691 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004692 cricket::VideoRecvParameters parameters;
4693 parameters.codecs.push_back(GetEngineCodec("VP8"));
4694 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4695 parameters.codecs[1].id = parameters.codecs[0].id;
4696 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4697}
4698
eladalonf1841382017-06-12 01:16:46 -07004699TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004700 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004701 parameters.codecs.push_back(GetEngineCodec("VP8"));
4702 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004703 parameters.codecs[1].id = parameters.codecs[0].id;
4704 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004705}
4706
eladalonf1841382017-06-12 01:16:46 -07004707TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004708 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004709 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004710 parameters.codecs.push_back(GetEngineCodec("VP8"));
4711 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004712 parameters.codecs[1].id += 1;
4713 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004714}
4715
deadbeef67cf2c12016-04-13 10:07:16 -07004716// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004717// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004718TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004719 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004720 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004721 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4722 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004723 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004724
4725 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4726 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4727
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004728 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004729 parameters2.codecs.push_back(GetEngineCodec("red"));
4730 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004731 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004732 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4733}
4734
eladalonf1841382017-06-12 01:16:46 -07004735TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004736 EXPECT_FALSE(AddSendStream()->IsSending());
4737}
4738
eladalonf1841382017-06-12 01:16:46 -07004739TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004740 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004741}
4742
eladalonf1841382017-06-12 01:16:46 -07004743TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004744 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004745 EXPECT_FALSE(stream->IsSending());
4746
4747 // false->true
4748 EXPECT_TRUE(channel_->SetSend(true));
4749 EXPECT_TRUE(stream->IsSending());
4750 // true->true
4751 EXPECT_TRUE(channel_->SetSend(true));
4752 EXPECT_TRUE(stream->IsSending());
4753 // true->false
4754 EXPECT_TRUE(channel_->SetSend(false));
4755 EXPECT_FALSE(stream->IsSending());
4756 // false->false
4757 EXPECT_TRUE(channel_->SetSend(false));
4758 EXPECT_FALSE(stream->IsSending());
4759
4760 EXPECT_TRUE(channel_->SetSend(true));
4761 FakeVideoSendStream* new_stream = AddSendStream();
4762 EXPECT_TRUE(new_stream->IsSending())
4763 << "Send stream created after SetSend(true) not sending initially.";
4764}
4765
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004766// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004767TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004768 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004769 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004770 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004771 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004772 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004773
Sebastian Jansson84848f22018-11-16 10:40:36 +01004774 channel.reset(
4775 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004776 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4777 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004778 channel->SetInterface(network_interface.get(),
4779 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004780 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004781 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004782
Tim Haloun648d28a2018-10-18 16:52:22 -07004783 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4784 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004785 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004786 channel.reset(
4787 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004788 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4789 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004790 channel->SetInterface(network_interface.get(),
4791 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004792 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4793
4794 // Create a send stream to configure
4795 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4796 parameters = channel->GetRtpSendParameters(kSsrc);
4797 ASSERT_FALSE(parameters.encodings.empty());
4798
4799 // Various priorities map to various dscp values.
4800 parameters.encodings[0].network_priority = 4.0;
4801 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004802 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004803 parameters.encodings[0].network_priority = 0.5;
4804 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4805 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4806
4807 // A bad priority does not change the dscp value.
4808 parameters.encodings[0].network_priority = 0.0;
4809 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4810 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004811
Tim Haloun6ca98362018-09-17 17:06:08 -07004812 // Packets should also self-identify their dscp in PacketOptions.
4813 const uint8_t kData[10] = {0};
4814 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4815 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004816 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004817
nisse51542be2016-02-12 02:27:06 -08004818 // Verify that setting the option to false resets the
4819 // DiffServCodePoint.
4820 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004821 channel.reset(
4822 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004823 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4824 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004825 channel->SetInterface(network_interface.get(),
4826 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004827 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004828}
4829
deadbeef13871492015-12-09 12:37:51 -08004830// This test verifies that the RTCP reduced size mode is properly applied to
4831// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004832TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004833 // Create stream, expecting that default mode is "compound".
4834 FakeVideoSendStream* stream1 = AddSendStream();
4835 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004836 webrtc::RtpParameters rtp_parameters =
4837 channel_->GetRtpSendParameters(last_ssrc_);
4838 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004839
4840 // Now enable reduced size mode.
4841 send_parameters_.rtcp.reduced_size = true;
4842 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4843 stream1 = fake_call_->GetVideoSendStreams()[0];
4844 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004845 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4846 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004847
4848 // Create a new stream and ensure it picks up the reduced size mode.
4849 FakeVideoSendStream* stream2 = AddSendStream();
4850 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4851}
4852
4853// This test verifies that the RTCP reduced size mode is properly applied to
4854// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004855TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004856 // Create stream, expecting that default mode is "compound".
4857 FakeVideoReceiveStream* stream1 = AddRecvStream();
4858 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4859
4860 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004861 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4862 // the reduced_size flag should come from that.
4863 send_parameters_.rtcp.reduced_size = true;
4864 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004865 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4866 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4867
4868 // Create a new stream and ensure it picks up the reduced size mode.
4869 FakeVideoReceiveStream* stream2 = AddRecvStream();
4870 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4871}
4872
eladalonf1841382017-06-12 01:16:46 -07004873TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004874 EXPECT_EQ(webrtc::kNetworkUp,
4875 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4876 EXPECT_EQ(webrtc::kNetworkUp,
4877 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004878
4879 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004880 EXPECT_EQ(webrtc::kNetworkDown,
4881 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4882 EXPECT_EQ(webrtc::kNetworkUp,
4883 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004884
4885 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004886 EXPECT_EQ(webrtc::kNetworkUp,
4887 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4888 EXPECT_EQ(webrtc::kNetworkUp,
4889 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004890}
4891
eladalonf1841382017-06-12 01:16:46 -07004892TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004893 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004894 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004895 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004896
4897 AddSendStream();
4898
4899 cricket::VideoMediaInfo info;
4900 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004901 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004902}
4903
eladalonf1841382017-06-12 01:16:46 -07004904TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004905 FakeVideoSendStream* stream = AddSendStream();
4906 webrtc::VideoSendStream::Stats stats;
4907 stats.encoder_implementation_name = "encoder_implementation_name";
4908 stream->SetStats(stats);
4909
4910 cricket::VideoMediaInfo info;
4911 ASSERT_TRUE(channel_->GetStats(&info));
4912 EXPECT_EQ(stats.encoder_implementation_name,
4913 info.senders[0].encoder_implementation_name);
4914}
4915
eladalonf1841382017-06-12 01:16:46 -07004916TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004917 FakeVideoSendStream* stream = AddSendStream();
4918 webrtc::VideoSendStream::Stats stats;
4919 stats.avg_encode_time_ms = 13;
4920 stats.encode_usage_percent = 42;
4921 stream->SetStats(stats);
4922
4923 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004924 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004925 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4926 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4927}
4928
eladalonf1841382017-06-12 01:16:46 -07004929TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004930 FakeVideoSendStream* stream = AddSendStream();
4931 webrtc::VideoSendStream::Stats stats;
4932 stats.frames_encoded = 13;
4933 stream->SetStats(stats);
4934
4935 cricket::VideoMediaInfo info;
4936 ASSERT_TRUE(channel_->GetStats(&info));
4937 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4938}
4939
eladalonf1841382017-06-12 01:16:46 -07004940TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004941 FakeVideoSendStream* stream = AddSendStream();
4942 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004943 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004944 stream->SetStats(stats);
4945
4946 cricket::VideoMediaInfo info;
4947 ASSERT_TRUE(channel_->GetStats(&info));
4948 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4949}
4950
eladalonf1841382017-06-12 01:16:46 -07004951TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004952 FakeVideoSendStream* stream = AddSendStream();
4953 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004954 stats.substreams[17].width = 123;
4955 stats.substreams[17].height = 40;
4956 stats.substreams[42].width = 80;
4957 stats.substreams[42].height = 31;
4958 stats.substreams[11].width = 20;
4959 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004960 stream->SetStats(stats);
4961
4962 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004963 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004964 ASSERT_EQ(1u, info.senders.size());
4965 EXPECT_EQ(123, info.senders[0].send_frame_width);
4966 EXPECT_EQ(90, info.senders[0].send_frame_height);
4967}
4968
eladalonf1841382017-06-12 01:16:46 -07004969TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07004970 FakeVideoSendStream* stream = AddSendStream();
4971 webrtc::VideoSendStream::Stats stats;
4972 stats.number_of_cpu_adapt_changes = 2;
4973 stats.cpu_limited_resolution = true;
4974 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004975
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004976 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004977 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004978 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004979 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004980 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00004981}
4982
eladalonf1841382017-06-12 01:16:46 -07004983TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07004984 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08004985 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07004986 stats.number_of_cpu_adapt_changes = 2;
4987 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08004988 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07004989 stream->SetStats(stats);
4990
4991 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08004992 EXPECT_TRUE(channel_->GetStats(&info));
4993 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07004994 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
4995 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08004996 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07004997 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08004998}
4999
eladalonf1841382017-06-12 01:16:46 -07005000TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005001 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5002 FakeVideoSendStream* stream = AddSendStream();
5003 webrtc::VideoSendStream::Stats stats;
5004 stats.bw_limited_resolution = true;
5005 stream->SetStats(stats);
5006
5007 cricket::VideoMediaInfo info;
5008 EXPECT_TRUE(channel_->GetStats(&info));
5009 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005010 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005011 info.senders[0].adapt_reason);
5012}
5013
Yves Gerey665174f2018-06-19 15:03:05 +02005014TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005015 FakeVideoSendStream* stream = AddSendStream();
5016 webrtc::VideoSendStream::Stats stats;
5017 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5018 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5019 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5020
5021 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5022 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5023 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5024
5025 stream->SetStats(stats);
5026
5027 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005028 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005029 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5030 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5031 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5032}
5033
eladalonf1841382017-06-12 01:16:46 -07005034TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005035 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5036 FakeVideoReceiveStream* stream = AddRecvStream();
5037 webrtc::VideoReceiveStream::Stats stats;
5038 stats.rtcp_packet_type_counts.fir_packets = 2;
5039 stats.rtcp_packet_type_counts.nack_packets = 3;
5040 stats.rtcp_packet_type_counts.pli_packets = 4;
5041 stream->SetStats(stats);
5042
5043 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005044 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005045 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005046 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005047 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005048 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005049 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005050 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005051}
5052
eladalonf1841382017-06-12 01:16:46 -07005053TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005054 FakeVideoReceiveStream* stream = AddRecvStream();
5055 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005056 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005057 stats.decode_ms = 2;
5058 stats.max_decode_ms = 3;
5059 stats.current_delay_ms = 4;
5060 stats.target_delay_ms = 5;
5061 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005062 stats.jitter_buffer_delay_seconds = 60;
5063 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005064 stats.min_playout_delay_ms = 7;
5065 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005066 stats.width = 9;
5067 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005068 stats.frame_counts.key_frames = 11;
5069 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005070 stats.frames_rendered = 13;
5071 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005072 stats.qp_sum = 15;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005073 stream->SetStats(stats);
5074
5075 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005076 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005077 EXPECT_EQ(stats.decoder_implementation_name,
5078 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005079 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5080 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5081 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5082 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5083 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005084 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5085 info.receivers[0].jitter_buffer_delay_seconds);
5086 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5087 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005088 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5089 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005090 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5091 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005092 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5093 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005094 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005095 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005096 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005097 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005098}
5099
eladalonf1841382017-06-12 01:16:46 -07005100TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005101 FakeVideoReceiveStream* stream = AddRecvStream();
5102 webrtc::VideoReceiveStream::Stats stats;
5103 stats.rtp_stats.transmitted.payload_bytes = 2;
5104 stats.rtp_stats.transmitted.header_bytes = 3;
5105 stats.rtp_stats.transmitted.padding_bytes = 4;
5106 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005107 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005108 stats.rtcp_stats.fraction_lost = 7;
5109 stream->SetStats(stats);
5110
5111 cricket::VideoMediaInfo info;
5112 ASSERT_TRUE(channel_->GetStats(&info));
5113 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
5114 stats.rtp_stats.transmitted.header_bytes +
5115 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005116 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005117 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005118 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005119 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005120 EXPECT_EQ(rtc::checked_cast<float>(stats.rtcp_stats.fraction_lost) / (1 << 8),
Peter Boström393347f2015-04-22 14:52:45 +02005121 info.receivers[0].fraction_lost);
5122}
5123
eladalonf1841382017-06-12 01:16:46 -07005124TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005125 AddSendStream();
5126 AddSendStream();
5127 webrtc::Call::Stats stats;
5128 stats.rtt_ms = 123;
5129 fake_call_->SetStats(stats);
5130
5131 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005132 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005133 ASSERT_EQ(2u, info.senders.size());
5134 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5135 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5136}
5137
eladalonf1841382017-06-12 01:16:46 -07005138TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005139 FakeVideoSendStream* stream = AddSendStream();
5140 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005141 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005142 stats.media_bitrate_bps = 123;
5143 stats.substreams[17].total_bitrate_bps = 1;
5144 stats.substreams[17].retransmit_bitrate_bps = 2;
5145 stats.substreams[42].total_bitrate_bps = 3;
5146 stats.substreams[42].retransmit_bitrate_bps = 4;
5147 stream->SetStats(stats);
5148
5149 FakeVideoSendStream* stream2 = AddSendStream();
5150 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005151 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005152 stats2.media_bitrate_bps = 321;
5153 stats2.substreams[13].total_bitrate_bps = 5;
5154 stats2.substreams[13].retransmit_bitrate_bps = 6;
5155 stats2.substreams[21].total_bitrate_bps = 7;
5156 stats2.substreams[21].retransmit_bitrate_bps = 8;
5157 stream2->SetStats(stats2);
5158
5159 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005160 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005161 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005162 BandwidthEstimationInfo bwe_info;
5163 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005164 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5165 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5166 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5167 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005168 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005169 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005170 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005171 bwe_info.actual_enc_bitrate);
5172 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005173 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005174 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005175 << "Bandwidth stats should take all streams into account.";
5176}
5177
eladalonf1841382017-06-12 01:16:46 -07005178TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005179 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005180
Peter Boström0c4e06b2015-10-07 12:23:21 +02005181 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5182 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005183
5184 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5185 const size_t kDataLength = 12;
5186 uint8_t data[kDataLength];
5187 memset(data, 0, sizeof(data));
5188 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005189 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005190 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005191
5192 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5193 << "No default receive stream created.";
5194 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005195 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005196 << "Default receive stream should not have configured RTX";
5197
5198 EXPECT_TRUE(channel_->AddRecvStream(
5199 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5200 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005201 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005202 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005203 EXPECT_FALSE(
5204 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005205 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005206 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005207 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005208 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005209 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005210 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005211}
5212
eladalonf1841382017-06-12 01:16:46 -07005213TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005214 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005215
Peter Boström0c4e06b2015-10-07 12:23:21 +02005216 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5217 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005218
5219 StreamParams sp =
5220 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5221 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5222
5223 EXPECT_FALSE(channel_->AddSendStream(sp));
5224 EXPECT_FALSE(channel_->AddRecvStream(sp));
5225}
5226
eladalonf1841382017-06-12 01:16:46 -07005227TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005228 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005229
Peter Boström0c4e06b2015-10-07 12:23:21 +02005230 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5231 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005232
5233 StreamParams sp =
5234 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5235
5236 EXPECT_TRUE(channel_->AddSendStream(sp));
5237 EXPECT_TRUE(channel_->AddRecvStream(sp));
5238
5239 // The RTX SSRC is already used in previous streams, using it should fail.
5240 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5241 EXPECT_FALSE(channel_->AddSendStream(sp));
5242 EXPECT_FALSE(channel_->AddRecvStream(sp));
5243
5244 // After removing the original stream this should be fine to add (makes sure
5245 // that RTX ssrcs are not forever taken).
5246 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5247 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5248 EXPECT_TRUE(channel_->AddSendStream(sp));
5249 EXPECT_TRUE(channel_->AddRecvStream(sp));
5250}
5251
eladalonf1841382017-06-12 01:16:46 -07005252TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005253 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005254 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5255 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005256 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005257
Peter Boströmd6f4c252015-03-26 16:23:04 +01005258 StreamParams sp =
5259 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5260
5261 EXPECT_TRUE(channel_->AddSendStream(sp));
5262 EXPECT_TRUE(channel_->AddRecvStream(sp));
5263
5264 // One of the SSRCs is already used in previous streams, using it should fail.
5265 sp = cricket::CreateSimStreamParams("cname",
5266 MAKE_VECTOR(kOverlappingStreamSsrcs));
5267 EXPECT_FALSE(channel_->AddSendStream(sp));
5268 EXPECT_FALSE(channel_->AddRecvStream(sp));
5269
5270 // After removing the original stream this should be fine to add (makes sure
5271 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005272 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5273 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005274 EXPECT_TRUE(channel_->AddSendStream(sp));
5275 EXPECT_TRUE(channel_->AddRecvStream(sp));
5276}
5277
eladalonf1841382017-06-12 01:16:46 -07005278TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005279 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005280
5281 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5282 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5283
5284 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5285 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5286
5287 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5288
5289 static const uint32_t kReceiverSsrcs[] = {3};
5290 static const uint32_t kReceiverRtxSsrcs[] = {2};
5291
5292 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5293 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5294 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5295
5296 cricket::VideoMediaInfo info;
5297 ASSERT_TRUE(channel_->GetStats(&info));
5298
5299 ASSERT_EQ(1u, info.senders.size());
5300 ASSERT_EQ(1u, info.receivers.size());
5301
5302 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5303 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5304 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5305}
5306
eladalonf1841382017-06-12 01:16:46 -07005307TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005308 FakeVideoReceiveStream* stream = AddRecvStream();
5309 webrtc::VideoReceiveStream::Stats stats;
5310 cricket::VideoMediaInfo info;
5311
5312 // Report no codec name before receiving.
5313 stream->SetStats(stats);
5314 ASSERT_TRUE(channel_->GetStats(&info));
5315 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5316
5317 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005318 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005319 stream->SetStats(stats);
5320 ASSERT_TRUE(channel_->GetStats(&info));
5321 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5322
5323 // Report no codec name for unknown playload types.
5324 stats.current_payload_type = 3;
5325 stream->SetStats(stats);
5326 ASSERT_TRUE(channel_->GetStats(&info));
5327 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5328}
5329
Seth Hampson5897a6e2018-04-03 11:16:33 -07005330// Tests that when we add a stream without SSRCs, but contains a stream_id
5331// that it is stored and its stream id is later used when the first packet
5332// arrives to properly create a receive stream with a sync label.
5333TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5334 const char kSyncLabel[] = "sync_label";
5335 cricket::StreamParams unsignaled_stream;
5336 unsignaled_stream.set_stream_ids({kSyncLabel});
5337 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5338 // The stream shouldn't have been created at this point because it doesn't
5339 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005340 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005341
5342 // Create and deliver packet.
5343 const size_t kDataLength = 12;
5344 uint8_t data[kDataLength];
5345 memset(data, 0, sizeof(data));
5346 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5347 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005348 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005349
5350 // The stream should now be created with the appropriate sync label.
5351 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5352 EXPECT_EQ(kSyncLabel,
5353 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5354
5355 // Removing the unsignaled stream should clear the cache. This time when
5356 // a default video receive stream is created it won't have a sync_group.
5357 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5358 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5359 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5360
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005361 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005362 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5363 EXPECT_TRUE(
5364 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5365}
5366
Ruslan Burakov493a6502019-02-27 15:32:48 +01005367// Test BaseMinimumPlayoutDelayMs on receive streams.
5368TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5369 // Test that set won't work for non-existing receive streams.
5370 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5371 // Test that get won't work for non-existing receive streams.
5372 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5373
5374 EXPECT_TRUE(AddRecvStream());
5375 // Test that set works for the existing receive stream.
5376 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5377 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5378 EXPECT_TRUE(recv_stream);
5379 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5380 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5381 200);
5382}
5383
5384// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5385TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5386 absl::optional<int> delay_ms;
5387 const FakeVideoReceiveStream* recv_stream;
5388
5389 // Set default stream with SSRC 0
5390 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5391 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5392
5393 // Spawn an unsignaled stream by sending a packet, it should inherit
5394 // default delay 200.
5395 const size_t kDataLength = 12;
5396 uint8_t data[kDataLength];
5397 memset(data, 0, sizeof(data));
5398 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5399 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005400 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005401
5402 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5403 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5404 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5405 EXPECT_EQ(200, delay_ms.value_or(0));
5406
5407 // Check that now if we change delay for SSRC 0 it will change delay for the
5408 // default receiving stream as well.
5409 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5410 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5411 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5412 EXPECT_EQ(300, delay_ms.value_or(0));
5413 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5414 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5415}
5416
eladalonf1841382017-06-12 01:16:46 -07005417void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005418 uint8_t payload_type,
5419 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005420 // kRedRtxPayloadType must currently be unused.
5421 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5422
noahricd10a68e2015-07-10 11:27:55 -07005423 // Add a RED RTX codec.
5424 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005425 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005426 recv_parameters_.codecs.push_back(red_rtx_codec);
5427 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005428
5429 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5430 const size_t kDataLength = 12;
5431 uint8_t data[kDataLength];
5432 memset(data, 0, sizeof(data));
5433
5434 rtc::Set8(data, 1, payload_type);
5435 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005436 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005437 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005438
5439 if (expect_created_receive_stream) {
5440 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5441 << "Should have created a receive stream for payload type: "
5442 << payload_type;
5443 } else {
5444 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5445 << "Shouldn't have created a receive stream for payload type: "
5446 << payload_type;
5447 }
5448}
5449
Åsa Persson2c7149b2018-10-15 09:36:10 +02005450class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5451 public:
5452 WebRtcVideoChannelDiscardUnknownSsrcTest()
5453 : WebRtcVideoChannelTest(
5454 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5455};
5456
5457TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5458 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5459 false /* expect_created_receive_stream */);
5460}
5461
eladalonf1841382017-06-12 01:16:46 -07005462TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005463 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5464 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005465}
5466
eladalonf1841382017-06-12 01:16:46 -07005467TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005468 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5469 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005470}
5471
eladalonf1841382017-06-12 01:16:46 -07005472TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005473 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005474 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5475 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5476 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5477 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005478}
5479
eladalonf1841382017-06-12 01:16:46 -07005480TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005481 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5482 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005483}
5484
eladalonf1841382017-06-12 01:16:46 -07005485TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005486 FlexfecPacketDoesntCreateUnsignalledStream) {
5487 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5488 false /* expect_created_receive_stream */);
5489}
5490
eladalonf1841382017-06-12 01:16:46 -07005491TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005492 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5493 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005494}
5495
mzanaty8a855d62017-02-17 15:46:43 -08005496// Test that receiving any unsignalled SSRC works even if it changes.
5497// The first unsignalled SSRC received will create a default receive stream.
5498// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005499TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005500 // Allow receiving VP8, VP9, H264 (if enabled).
5501 cricket::VideoRecvParameters parameters;
5502 parameters.codecs.push_back(GetEngineCodec("VP8"));
5503 parameters.codecs.push_back(GetEngineCodec("VP9"));
5504
5505#if defined(WEBRTC_USE_H264)
5506 cricket::VideoCodec H264codec(126, "H264");
5507 parameters.codecs.push_back(H264codec);
5508#endif
5509
5510 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5511 // No receive streams yet.
5512 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5513 cricket::FakeVideoRenderer renderer;
5514 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5515
5516 // Receive VP8 packet on first SSRC.
5517 uint8_t data[kMinRtpPacketLen];
5518 cricket::RtpHeader rtpHeader;
5519 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5520 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005521 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005522 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5523 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005524 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005525 // VP8 packet should create default receive stream.
5526 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005527 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005528 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5529 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005530 webrtc::VideoFrame video_frame =
5531 webrtc::VideoFrame::Builder()
5532 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5533 .set_timestamp_rtp(100)
5534 .set_timestamp_us(0)
5535 .set_rotation(webrtc::kVideoRotation_0)
5536 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005537 recv_stream->InjectFrame(video_frame);
5538 EXPECT_EQ(1, renderer.num_rendered_frames());
5539
5540 // Receive VP9 packet on second SSRC.
5541 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005542 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005543 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5544 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005545 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005546 // VP9 packet should replace the default receive SSRC.
5547 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5548 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5549 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5550 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005551 webrtc::VideoFrame video_frame2 =
5552 webrtc::VideoFrame::Builder()
5553 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5554 .set_timestamp_rtp(200)
5555 .set_timestamp_us(0)
5556 .set_rotation(webrtc::kVideoRotation_0)
5557 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005558 recv_stream->InjectFrame(video_frame2);
5559 EXPECT_EQ(2, renderer.num_rendered_frames());
5560
5561#if defined(WEBRTC_USE_H264)
5562 // Receive H264 packet on third SSRC.
5563 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005564 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005565 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5566 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005567 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005568 // H264 packet should replace the default receive SSRC.
5569 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5570 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5571 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5572 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005573 webrtc::VideoFrame video_frame3 =
5574 webrtc::VideoFrame::Builder()
5575 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5576 .set_timestamp_rtp(300)
5577 .set_timestamp_us(0)
5578 .set_rotation(webrtc::kVideoRotation_0)
5579 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005580 recv_stream->InjectFrame(video_frame3);
5581 EXPECT_EQ(3, renderer.num_rendered_frames());
5582#endif
5583}
5584
brandtr0dc57ea2017-05-29 23:33:31 -07005585// This test verifies that when a new default stream is created for a new
5586// unsignaled SSRC, the new stream does not overwrite any old stream that had
5587// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005588TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005589 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5590 cricket::VideoRecvParameters parameters;
5591 parameters.codecs.push_back(GetEngineCodec("VP8"));
5592 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5593
5594 // No streams signaled and no packets received, so we should not have any
5595 // stream objects created yet.
5596 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5597
5598 // Receive packet on an unsignaled SSRC.
5599 uint8_t data[kMinRtpPacketLen];
5600 cricket::RtpHeader rtp_header;
5601 rtp_header.payload_type = GetEngineCodec("VP8").id;
5602 rtp_header.seq_num = rtp_header.timestamp = 0;
5603 rtp_header.ssrc = kSsrcs3[0];
5604 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5605 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005606 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005607 // Default receive stream should be created.
5608 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5609 FakeVideoReceiveStream* recv_stream0 =
5610 fake_call_->GetVideoReceiveStreams()[0];
5611 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5612
5613 // Signal the SSRC.
5614 EXPECT_TRUE(
5615 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5616 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5617 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5618 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5619
5620 // Receive packet on a different unsignaled SSRC.
5621 rtp_header.ssrc = kSsrcs3[1];
5622 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5623 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005624 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005625 // New default receive stream should be created, but old stream should remain.
5626 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5627 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5628 FakeVideoReceiveStream* recv_stream1 =
5629 fake_call_->GetVideoReceiveStreams()[1];
5630 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5631}
5632
Seth Hampson7c682e02018-05-04 16:28:15 -07005633TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005634 AddSendStream();
5635
Niels Möller805a27e2019-01-21 12:21:27 +01005636 webrtc::test::FrameForwarder frame_forwarder;
5637 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005638 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005639 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005640
perkjfa10b552016-10-02 23:45:26 -07005641 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005642 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005643
5644 // TODO(skvlad): Resolve the inconsistency between the interpretation
5645 // of the global bitrate limit for audio and video:
5646 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5647 // max_bandwidth_bps = -1 - remove the bandwidth limit
5648 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005649 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005650
perkjfa10b552016-10-02 23:45:26 -07005651 SetAndExpectMaxBitrate(1000, 0, 1000);
5652 SetAndExpectMaxBitrate(1000, 800, 800);
5653 SetAndExpectMaxBitrate(600, 800, 600);
5654 SetAndExpectMaxBitrate(0, 800, 800);
5655 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005656
Niels Möllerff40b142018-04-09 08:49:14 +02005657 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005658}
5659
eladalonf1841382017-06-12 01:16:46 -07005660TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005661 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005662 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005663 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005664
5665 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005666 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005667 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005668}
5669
eladalonf1841382017-06-12 01:16:46 -07005670TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005671 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005672 FakeVideoSendStream* stream = AddSendStream();
5673
Seth Hampson7c682e02018-05-04 16:28:15 -07005674 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5675 EXPECT_EQ(1UL, parameters.encodings.size());
5676 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5677 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5678
5679 // Note that this is testing the behavior of the FakeVideoSendStream, which
5680 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5681 // we are just testing the behavior of
5682 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005683 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5684 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005685
5686 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5687 // by this amount.
5688 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5689 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5690 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5691 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5692
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005693 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5694 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5695 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5696}
5697
5698TEST_F(WebRtcVideoChannelTest,
5699 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5700 FakeVideoSendStream* stream = AddSendStream();
5701
5702 // Note that this is testing the behavior of the FakeVideoSendStream, which
5703 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5704 // we are just testing the behavior of
5705 // EncoderStreamFactory::CreateEncoderStreams.
5706 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5707 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5708
5709 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5710 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5711 EXPECT_EQ(1UL, parameters.encodings.size());
5712 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5713 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5714
5715 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5716 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5717 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5718}
5719
5720TEST_F(WebRtcVideoChannelTest,
5721 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5722 send_parameters_.max_bandwidth_bps = 99999;
5723 FakeVideoSendStream* stream = AddSendStream();
5724 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5725 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5726 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5727 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5728 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5729 stream->GetVideoStreams()[0].max_bitrate_bps);
5730
5731 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5732 // adjusted down.
5733 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5734 EXPECT_EQ(1UL, parameters.encodings.size());
5735 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5736 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5737 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5738 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5739 stream->GetVideoStreams()[0].min_bitrate_bps);
5740 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5741 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005742}
5743
Åsa Persson8c1bf952018-09-13 10:42:19 +02005744TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5745 FakeVideoSendStream* stream = AddSendStream();
5746
5747 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5748 EXPECT_EQ(1UL, parameters.encodings.size());
5749 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5750 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5751
5752 // Note that this is testing the behavior of the FakeVideoSendStream, which
5753 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5754 // we are just testing the behavior of
5755 // EncoderStreamFactory::CreateEncoderStreams.
5756 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5757 EXPECT_EQ(kDefaultVideoMaxFramerate,
5758 stream->GetVideoStreams()[0].max_framerate);
5759
5760 // Set max framerate and check that VideoStream.max_framerate is set.
5761 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5762 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5763 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5764 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5765
5766 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5767 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5768}
5769
Åsa Persson23eba222018-10-02 14:47:06 +02005770TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5771 FakeVideoSendStream* stream = AddSendStream();
5772
5773 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5774 EXPECT_EQ(1UL, parameters.encodings.size());
5775 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5776 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5777
5778 // Note that this is testing the behavior of the FakeVideoSendStream, which
5779 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5780 // we are just testing the behavior of
5781 // EncoderStreamFactory::CreateEncoderStreams.
5782 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5783 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5784
5785 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5786 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5787 parameters.encodings[0].num_temporal_layers = 2;
5788 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5789
5790 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5791 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5792}
5793
Seth Hampson7c682e02018-05-04 16:28:15 -07005794TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005795 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005796 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005797 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005798 // Two or more encodings should result in failure.
5799 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005800 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005801 // Zero encodings should also fail.
5802 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005803 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005804}
5805
Zach Stein3ca452b2018-01-18 10:01:24 -08005806TEST_F(WebRtcVideoChannelTest,
5807 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5808 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5809 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5810 AddSendStream(sp);
5811
5812 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5813
5814 // Additional encodings should result in failure.
5815 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005816 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005817 // Zero encodings should also fail.
5818 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005819 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005820}
5821
deadbeeffb2aced2017-01-06 23:05:37 -08005822// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005823TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005824 AddSendStream();
5825 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005826 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005827 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005828}
5829
Seth Hampson24722b32017-12-22 09:36:42 -08005830// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5831// a value <= 0, setting the parameters returns false.
5832TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5833 AddSendStream();
5834 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5835 EXPECT_EQ(1UL, parameters.encodings.size());
5836 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5837 parameters.encodings[0].bitrate_priority);
5838
5839 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005840 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005841 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005842 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005843}
5844
5845// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5846// properly on the VideoChannel and propogates down to the video encoder.
5847TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5848 AddSendStream();
5849 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5850 EXPECT_EQ(1UL, parameters.encodings.size());
5851 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5852 parameters.encodings[0].bitrate_priority);
5853
5854 // Change the value and set it on the VideoChannel.
5855 double new_bitrate_priority = 2.0;
5856 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005857 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005858
5859 // Verify that the encoding parameters bitrate_priority is set for the
5860 // VideoChannel.
5861 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5862 EXPECT_EQ(1UL, parameters.encodings.size());
5863 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5864
5865 // Verify that the new value propagated down to the encoder.
5866 std::vector<FakeVideoSendStream*> video_send_streams =
5867 fake_call_->GetVideoSendStreams();
5868 EXPECT_EQ(1UL, video_send_streams.size());
5869 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5870 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5871 // appropriately.
5872 EXPECT_EQ(new_bitrate_priority,
5873 video_send_stream->GetEncoderConfig().bitrate_priority);
5874 // Check that the vector of VideoStreams also was propagated correctly. Note
5875 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5876 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005877 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005878 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5879}
5880
5881// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5882// VideoChannel and the value propogates to the video encoder with all simulcast
5883// streams.
5884TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5885 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005886 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005887 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5888 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5889 AddSendStream(stream_params);
5890 uint32_t primary_ssrc = stream_params.first_ssrc();
5891
Niels Möller805a27e2019-01-21 12:21:27 +01005892 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005893 // frame. This creates multiple VideoStreams for all simulcast layers when
5894 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005895 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005896 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005897 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005898 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005899 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5900 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5901 rtc::kNumMicrosecsPerSec / 30));
5902
Seth Hampson24722b32017-12-22 09:36:42 -08005903 // Get and set the rtp encoding parameters.
5904 webrtc::RtpParameters parameters =
5905 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005906 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005907 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5908 parameters.encodings[0].bitrate_priority);
5909 // Change the value and set it on the VideoChannel.
5910 double new_bitrate_priority = 2.0;
5911 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005912 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005913
5914 // Verify that the encoding parameters priority is set on the VideoChannel.
5915 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005916 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005917 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5918
5919 // Verify that the new value propagated down to the encoder.
5920 std::vector<FakeVideoSendStream*> video_send_streams =
5921 fake_call_->GetVideoSendStreams();
5922 EXPECT_EQ(1UL, video_send_streams.size());
5923 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5924 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5925 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005926 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005927 video_send_stream->GetEncoderConfig().number_of_streams);
5928 EXPECT_EQ(new_bitrate_priority,
5929 video_send_stream->GetEncoderConfig().bitrate_priority);
5930 // Check that the vector of VideoStreams also propagated correctly. The
5931 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5932 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005933 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005934 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005935 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5936 // Since we are only setting bitrate priority per-sender, the other
5937 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005938 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005939 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005940 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005941 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005942 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005943}
5944
Tim Haloun648d28a2018-10-18 16:52:22 -07005945// RTCRtpEncodingParameters.network_priority must be one of a few values
5946// derived from the default priority, corresponding to very-low, low, medium,
5947// or high.
5948TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5949 AddSendStream();
5950 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5951 EXPECT_EQ(1UL, parameters.encodings.size());
5952 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5953 parameters.encodings[0].network_priority);
5954
5955 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5956 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5957 for (auto it : good_values) {
5958 parameters.encodings[0].network_priority = it;
5959 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5960 }
5961 for (auto it : bad_values) {
5962 parameters.encodings[0].network_priority = it;
5963 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5964 }
5965}
5966
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005967TEST_F(WebRtcVideoChannelTest,
5968 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01005969 VideoSendParameters parameters;
5970 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005971 ASSERT_TRUE(channel_->SetSendParameters(parameters));
5972 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
5973
5974 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01005975 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01005976
5977 VideoOptions options;
5978 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
5979 channel_->SetSend(true);
5980
5981 // Try layers in natural order (smallest to largest).
5982 {
5983 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5984 ASSERT_EQ(3u, rtp_parameters.encodings.size());
5985 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
5986 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
5987 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
5988 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
5989 ASSERT_TRUE(result.ok());
5990
5991 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
5992
5993 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
5994 ASSERT_EQ(3u, video_streams.size());
5995 EXPECT_EQ(320u, video_streams[0].width);
5996 EXPECT_EQ(180u, video_streams[0].height);
5997 EXPECT_EQ(640u, video_streams[1].width);
5998 EXPECT_EQ(360u, video_streams[1].height);
5999 EXPECT_EQ(1280u, video_streams[2].width);
6000 EXPECT_EQ(720u, video_streams[2].height);
6001 }
6002
6003 // Try layers in reverse natural order (largest to smallest).
6004 {
6005 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6006 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6007 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6008 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6009 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6010 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6011 ASSERT_TRUE(result.ok());
6012
6013 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6014
6015 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6016 ASSERT_EQ(3u, video_streams.size());
6017 EXPECT_EQ(1280u, video_streams[0].width);
6018 EXPECT_EQ(720u, video_streams[0].height);
6019 EXPECT_EQ(640u, video_streams[1].width);
6020 EXPECT_EQ(360u, video_streams[1].height);
6021 EXPECT_EQ(320u, video_streams[2].width);
6022 EXPECT_EQ(180u, video_streams[2].height);
6023 }
6024
6025 // Try layers in mixed order.
6026 {
6027 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6028 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6029 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6030 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6031 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6032 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6033 ASSERT_TRUE(result.ok());
6034
6035 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6036
6037 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6038 ASSERT_EQ(3u, video_streams.size());
6039 EXPECT_EQ(128u, video_streams[0].width);
6040 EXPECT_EQ(72u, video_streams[0].height);
6041 EXPECT_EQ(640u, video_streams[1].width);
6042 EXPECT_EQ(360u, video_streams[1].height);
6043 EXPECT_EQ(320u, video_streams[2].width);
6044 EXPECT_EQ(180u, video_streams[2].height);
6045 }
6046
6047 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6048 {
6049 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6050 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6051 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6052 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6053 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6054 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6055 ASSERT_TRUE(result.ok());
6056
6057 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6058
6059 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6060 ASSERT_EQ(3u, video_streams.size());
6061 EXPECT_EQ(1280u, video_streams[0].width);
6062 EXPECT_EQ(720u, video_streams[0].height);
6063 EXPECT_EQ(1280u, video_streams[1].width);
6064 EXPECT_EQ(720u, video_streams[1].height);
6065 EXPECT_EQ(320u, video_streams[2].width);
6066 EXPECT_EQ(180u, video_streams[2].height);
6067 }
6068
6069 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6070}
6071
6072TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006073 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6074 // Ensure that the top layer has width and height divisible by 2^3,
6075 // so that the bottom layer has width and height divisible by 2.
6076 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6077 // the number of simulcast layers set by the app.
6078 webrtc::test::ScopedFieldTrials field_trial(
6079 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6080
6081 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6082 VideoSendParameters parameters;
6083 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6084 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6085 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6086 webrtc::test::FrameForwarder frame_forwarder;
6087 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6088 &frame_forwarder));
6089 channel_->SetSend(true);
6090
6091 // Set |scale_resolution_down_by|'s.
6092 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6093 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6094 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6095 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6096 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6097 const auto result =
6098 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6099 ASSERT_TRUE(result.ok());
6100
6101 // Use a capture resolution whose width and height are not divisible by 2^3.
6102 // (See field trial set at the top of the test.)
6103 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6104 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6105
6106 // Ensure the scaling is correct.
6107 const auto video_streams = stream->GetVideoStreams();
6108 ASSERT_EQ(video_streams.size(), 3u);
6109 // Ensure that we round the capture resolution down for the top layer...
6110 EXPECT_EQ(video_streams[0].width, 2000u);
6111 EXPECT_EQ(video_streams[0].height, 1200u);
6112 EXPECT_EQ(video_streams[1].width, 1000u);
6113 EXPECT_EQ(video_streams[1].height, 600u);
6114 // ...and that the bottom layer has a width/height divisible by 2.
6115 EXPECT_EQ(video_streams[2].width, 500u);
6116 EXPECT_EQ(video_streams[2].height, 300u);
6117
6118 // Tear down.
6119 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6120}
6121
6122TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006123 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006124 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6125 VideoSendParameters parameters;
6126 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006127 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6128 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6129
6130 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006131 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006132
6133 VideoOptions options;
6134 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6135 channel_->SetSend(true);
6136
6137 // Try layers in natural order (smallest to largest).
6138 {
6139 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6140 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6141 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6142 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6143 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6144 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6145 ASSERT_TRUE(result.ok());
6146
6147 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6148
6149 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6150 ASSERT_EQ(3u, video_streams.size());
6151 EXPECT_EQ(320u, video_streams[0].width);
6152 EXPECT_EQ(180u, video_streams[0].height);
6153 EXPECT_EQ(640u, video_streams[1].width);
6154 EXPECT_EQ(360u, video_streams[1].height);
6155 EXPECT_EQ(1280u, video_streams[2].width);
6156 EXPECT_EQ(720u, video_streams[2].height);
6157 }
6158
6159 // Try layers in reverse natural order (largest to smallest).
6160 {
6161 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6162 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6163 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6164 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6165 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6166 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6167 ASSERT_TRUE(result.ok());
6168
6169 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6170
6171 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6172 ASSERT_EQ(3u, video_streams.size());
6173 EXPECT_EQ(1280u, video_streams[0].width);
6174 EXPECT_EQ(720u, video_streams[0].height);
6175 EXPECT_EQ(640u, video_streams[1].width);
6176 EXPECT_EQ(360u, video_streams[1].height);
6177 EXPECT_EQ(320u, video_streams[2].width);
6178 EXPECT_EQ(180u, video_streams[2].height);
6179 }
6180
6181 // Try layers in mixed order.
6182 {
6183 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6184 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6185 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6186 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6187 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6188 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6189 ASSERT_TRUE(result.ok());
6190
6191 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6192
6193 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6194 ASSERT_EQ(3u, video_streams.size());
6195 EXPECT_EQ(128u, video_streams[0].width);
6196 EXPECT_EQ(72u, video_streams[0].height);
6197 EXPECT_EQ(640u, video_streams[1].width);
6198 EXPECT_EQ(360u, video_streams[1].height);
6199 EXPECT_EQ(320u, video_streams[2].width);
6200 EXPECT_EQ(180u, video_streams[2].height);
6201 }
6202
6203 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6204 {
6205 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6206 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6207 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6208 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6209 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6210 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6211 ASSERT_TRUE(result.ok());
6212
6213 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6214
6215 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6216 ASSERT_EQ(3u, video_streams.size());
6217 EXPECT_EQ(1280u, video_streams[0].width);
6218 EXPECT_EQ(720u, video_streams[0].height);
6219 EXPECT_EQ(1280u, video_streams[1].width);
6220 EXPECT_EQ(720u, video_streams[1].height);
6221 EXPECT_EQ(320u, video_streams[2].width);
6222 EXPECT_EQ(180u, video_streams[2].height);
6223 }
6224 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6225}
6226
Rasmus Brandt9387b522019-02-05 14:23:26 +01006227TEST_F(WebRtcVideoChannelTest,
6228 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6229 // Ensure that the top layer has width and height divisible by 2^3,
6230 // so that the bottom layer has width and height divisible by 2.
6231 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6232 // the number of simulcast layers set by the app.
6233 webrtc::test::ScopedFieldTrials field_trial(
6234 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6235
6236 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6237 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6238 VideoSendParameters parameters;
6239 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6240 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6241 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6242 webrtc::test::FrameForwarder frame_forwarder;
6243 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6244 &frame_forwarder));
6245 channel_->SetSend(true);
6246
6247 // Set |scale_resolution_down_by|'s.
6248 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6249 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6250 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6251 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6252 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6253 const auto result =
6254 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6255 ASSERT_TRUE(result.ok());
6256
6257 // Use a capture resolution whose width and height are not divisible by 2^3.
6258 // (See field trial set at the top of the test.)
6259 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6260 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6261
6262 // Ensure the scaling is correct.
6263 const auto video_streams = stream->GetVideoStreams();
6264 ASSERT_EQ(video_streams.size(), 3u);
6265 // Ensure that we round the capture resolution down for the top layer...
6266 EXPECT_EQ(video_streams[0].width, 2000u);
6267 EXPECT_EQ(video_streams[0].height, 1200u);
6268 EXPECT_EQ(video_streams[1].width, 1000u);
6269 EXPECT_EQ(video_streams[1].height, 600u);
6270 // ...and that the bottom layer has a width/height divisible by 2.
6271 EXPECT_EQ(video_streams[2].width, 500u);
6272 EXPECT_EQ(video_streams[2].height, 300u);
6273
6274 // Tear down.
6275 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6276}
6277
Åsa Persson8c1bf952018-09-13 10:42:19 +02006278TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6279 const size_t kNumSimulcastStreams = 3;
6280 SetUpSimulcast(true, false);
6281
6282 // Get and set the rtp encoding parameters.
6283 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6284 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6285 for (const auto& encoding : parameters.encodings) {
6286 EXPECT_FALSE(encoding.max_framerate);
6287 }
6288
6289 // Change the value and set it on the VideoChannel.
6290 parameters.encodings[0].max_framerate = 10;
6291 parameters.encodings[1].max_framerate = 20;
6292 parameters.encodings[2].max_framerate = 25;
6293 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6294
6295 // Verify that the bitrates are set on the VideoChannel.
6296 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6297 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6298 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6299 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6300 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6301}
6302
Åsa Persson23eba222018-10-02 14:47:06 +02006303TEST_F(WebRtcVideoChannelTest,
6304 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6305 const size_t kNumSimulcastStreams = 3;
6306 SetUpSimulcast(true, false);
6307
6308 // Get and set the rtp encoding parameters.
6309 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6310 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6311
6312 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6313 parameters.encodings[0].num_temporal_layers = 0;
6314 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6315 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6316 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6317 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6318 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6319}
6320
6321TEST_F(WebRtcVideoChannelTest,
6322 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6323 const size_t kNumSimulcastStreams = 3;
6324 SetUpSimulcast(true, false);
6325
6326 // Get and set the rtp encoding parameters.
6327 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6328 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6329
6330 // No/all layers should be set.
6331 parameters.encodings[0].num_temporal_layers = 1;
6332 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6333 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6334
6335 // Different values not supported.
6336 parameters.encodings[0].num_temporal_layers = 1;
6337 parameters.encodings[1].num_temporal_layers = 2;
6338 parameters.encodings[2].num_temporal_layers = 2;
6339 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6340 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6341}
6342
6343TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6344 const size_t kNumSimulcastStreams = 3;
6345 SetUpSimulcast(true, false);
6346
6347 // Get and set the rtp encoding parameters.
6348 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6349 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6350 for (const auto& encoding : parameters.encodings)
6351 EXPECT_FALSE(encoding.num_temporal_layers);
6352
6353 // Change the value and set it on the VideoChannel.
6354 parameters.encodings[0].num_temporal_layers = 3;
6355 parameters.encodings[1].num_temporal_layers = 3;
6356 parameters.encodings[2].num_temporal_layers = 3;
6357 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6358
6359 // Verify that the number of temporal layers are set on the VideoChannel.
6360 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6361 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6362 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6363 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6364 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6365}
6366
6367TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6368 const size_t kNumSimulcastStreams = 3;
6369 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6370
6371 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006372 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006373 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006374 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006375 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006376 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006377
6378 // Get and set the rtp encoding parameters.
6379 // Change the value and set it on the VideoChannel.
6380 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6381 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6382 parameters.encodings[0].num_temporal_layers = 2;
6383 parameters.encodings[1].num_temporal_layers = 2;
6384 parameters.encodings[2].num_temporal_layers = 2;
6385 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6386
6387 // Verify that the new value is propagated down to the encoder.
6388 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6389 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6390 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6391 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6392 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6393 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6394 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6395 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6396
6397 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6398 // VideoStreams are created appropriately for the simulcast case.
6399 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6400 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6401 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6402 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6403
6404 // No parameter changed, encoder should not be reconfigured.
6405 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6406 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6407
6408 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6409}
6410
6411TEST_F(WebRtcVideoChannelTest,
6412 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6413 const size_t kDefaultNumTemporalLayers = 3;
6414 const size_t kNumSimulcastStreams = 3;
6415 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6416
6417 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006418 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006419 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006420 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006421 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006422 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006423
6424 // Change rtp encoding parameters, num_temporal_layers not changed.
6425 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6426 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6427 parameters.encodings[0].min_bitrate_bps = 33000;
6428 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6429
6430 // Verify that no value is propagated down to the encoder.
6431 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6432 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6433 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6434 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6435 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6436 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6437
6438 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6439 // VideoStreams are created appropriately for the simulcast case.
6440 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6441 EXPECT_EQ(kDefaultNumTemporalLayers,
6442 stream->GetVideoStreams()[0].num_temporal_layers);
6443 EXPECT_EQ(kDefaultNumTemporalLayers,
6444 stream->GetVideoStreams()[1].num_temporal_layers);
6445 EXPECT_EQ(kDefaultNumTemporalLayers,
6446 stream->GetVideoStreams()[2].num_temporal_layers);
6447
6448 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6449}
6450
Åsa Persson8c1bf952018-09-13 10:42:19 +02006451TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6452 const size_t kNumSimulcastStreams = 3;
6453 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6454
6455 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006456 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006457 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006458 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006459 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006460 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006461
6462 // Get and set the rtp encoding parameters.
6463 // Change the value and set it on the VideoChannel.
6464 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6465 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6466 parameters.encodings[0].max_framerate = 15;
6467 parameters.encodings[1].max_framerate = 25;
6468 parameters.encodings[2].max_framerate = 20;
6469 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6470
6471 // Verify that the new value propagated down to the encoder.
6472 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6473 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6474 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6475 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6476 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6477 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6478 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6479 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6480
6481 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6482 // VideoStreams are created appropriately for the simulcast case.
6483 // Currently the maximum |max_framerate| is used.
6484 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6485 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6486 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6487 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6488
6489 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6490}
6491
6492TEST_F(WebRtcVideoChannelTest,
6493 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6494 const size_t kNumSimulcastStreams = 3;
6495 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6496 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6497
6498 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006499 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006500 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006501 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006502 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006503 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006504
6505 // Get and set the rtp encoding parameters.
6506 // Change the value and set it on the VideoChannel.
6507 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6508 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6509 parameters.encodings[0].max_framerate = 15;
6510 parameters.encodings[2].max_framerate = 20;
6511 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6512
6513 // Verify that the new value propagated down to the encoder.
6514 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6515 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6516 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6517 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6518 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6519 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6520 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6521
6522 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6523 // VideoStreams are created appropriately for the simulcast case.
6524 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6525 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6526 EXPECT_EQ(kDefaultVideoMaxFramerate,
6527 stream->GetVideoStreams()[0].max_framerate);
6528 EXPECT_EQ(kDefaultVideoMaxFramerate,
6529 stream->GetVideoStreams()[1].max_framerate);
6530 EXPECT_EQ(kDefaultVideoMaxFramerate,
6531 stream->GetVideoStreams()[2].max_framerate);
6532
6533 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6534}
6535
Åsa Persson55659812018-06-18 17:51:32 +02006536TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6537 const size_t kNumSimulcastStreams = 3;
6538 SetUpSimulcast(true, false);
6539
6540 // Get and set the rtp encoding parameters.
6541 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6542 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6543 for (const auto& encoding : parameters.encodings) {
6544 EXPECT_FALSE(encoding.min_bitrate_bps);
6545 EXPECT_FALSE(encoding.max_bitrate_bps);
6546 }
6547
6548 // Change the value and set it on the VideoChannel.
6549 parameters.encodings[0].min_bitrate_bps = 100000;
6550 parameters.encodings[0].max_bitrate_bps = 200000;
6551 parameters.encodings[1].min_bitrate_bps = 300000;
6552 parameters.encodings[1].max_bitrate_bps = 400000;
6553 parameters.encodings[2].min_bitrate_bps = 500000;
6554 parameters.encodings[2].max_bitrate_bps = 600000;
6555 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6556
6557 // Verify that the bitrates are set on the VideoChannel.
6558 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6559 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6560 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6561 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6562 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6563 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6564 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6565 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6566}
6567
6568TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6569 const size_t kNumSimulcastStreams = 3;
6570 SetUpSimulcast(true, false);
6571
6572 // Get and set the rtp encoding parameters.
6573 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6574 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6575
6576 // Max bitrate lower than min bitrate should fail.
6577 parameters.encodings[2].min_bitrate_bps = 100000;
6578 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6579 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6580 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6581}
6582
6583// Test that min and max bitrate values set via RtpParameters are correctly
6584// propagated to the underlying encoder, and that the target is set to 3/4 of
6585// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6586// that are used if no min/max are specified).
6587TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6588 const size_t kNumSimulcastStreams = 3;
6589 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6590
6591 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006592 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006593 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006594 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006595 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006596 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006597
6598 // Get and set the rtp encoding parameters.
6599 // Change the value and set it on the VideoChannel.
6600 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6601 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6602 parameters.encodings[0].min_bitrate_bps = 100000;
6603 parameters.encodings[0].max_bitrate_bps = 200000;
6604 parameters.encodings[1].min_bitrate_bps = 300000;
6605 parameters.encodings[1].max_bitrate_bps = 400000;
6606 parameters.encodings[2].min_bitrate_bps = 500000;
6607 parameters.encodings[2].max_bitrate_bps = 600000;
6608 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6609
6610 // Verify that the new value propagated down to the encoder.
6611 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6612 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6613 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6614 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6615 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6616 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6617 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6618 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6619 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6620 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6621 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6622
6623 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6624 // VideoStreams are created appropriately for the simulcast case.
6625 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6626 // Target bitrate: 200000 * 3 / 4 = 150000.
6627 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6628 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6629 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6630 // Target bitrate: 400000 * 3 / 4 = 300000.
6631 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6632 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6633 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6634 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6635 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6636 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6637 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6638
6639 // No parameter changed, encoder should not be reconfigured.
6640 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6641 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6642
6643 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6644}
6645
6646// Test to only specify the min or max bitrate value for a layer via
6647// RtpParameters. The unspecified min/max and target value should be set to the
6648// simulcast default that is used if no min/max are specified.
6649TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6650 const size_t kNumSimulcastStreams = 3;
6651 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6652 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6653
6654 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006655 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006656 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006657 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006658 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006659 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006660
6661 // Get and set the rtp encoding parameters.
6662 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6663 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6664
6665 // Change the value and set it on the VideoChannel.
6666 // Layer 0: only configure min bitrate.
6667 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6668 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6669 // Layer 1: only configure max bitrate.
6670 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6671 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6672 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6673
6674 // Verify that the new value propagated down to the encoder.
6675 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6676 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6677 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6678 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6679 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6680 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6681 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6682 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6683 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6684 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6685
6686 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6687 // VideoStreams are created appropriately for the simulcast case.
6688 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6689 // Layer 0: min configured bitrate should overwrite min default.
6690 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6691 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6692 stream->GetVideoStreams()[0].target_bitrate_bps);
6693 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6694 stream->GetVideoStreams()[0].max_bitrate_bps);
6695 // Layer 1: max configured bitrate should overwrite max default.
6696 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6697 stream->GetVideoStreams()[1].min_bitrate_bps);
6698 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6699 stream->GetVideoStreams()[1].target_bitrate_bps);
6700 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6701 // Layer 2: min and max bitrate not configured, default expected.
6702 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6703 stream->GetVideoStreams()[2].min_bitrate_bps);
6704 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6705 stream->GetVideoStreams()[2].target_bitrate_bps);
6706 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6707 stream->GetVideoStreams()[2].max_bitrate_bps);
6708
6709 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6710}
6711
6712// Test that specifying the min (or max) bitrate value for a layer via
6713// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6714// unspecified values accordingly.
6715TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6716 const size_t kNumSimulcastStreams = 3;
6717 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6718 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6719
6720 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006721 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006722 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006723 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006724 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006725 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006726
6727 // Get and set the rtp encoding parameters.
6728 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6729 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6730
6731 // Change the value and set it on the VideoChannel.
6732 // For layer 0, set the min bitrate above the default max.
6733 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6734 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6735 // For layer 1, set the max bitrate below the default min.
6736 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6737 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6738 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6739
6740 // Verify that the new value propagated down to the encoder.
6741 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6742 // VideoStreams are created appropriately for the simulcast case.
6743 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6744 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6745 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6746 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6747 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6748 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6749 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6750 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6751 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6752 // Layer 2: min and max bitrate not configured, default expected.
6753 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6754 stream->GetVideoStreams()[2].min_bitrate_bps);
6755 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6756 stream->GetVideoStreams()[2].target_bitrate_bps);
6757 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6758 stream->GetVideoStreams()[2].max_bitrate_bps);
6759
6760 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6761}
6762
6763TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6764 const size_t kNumSimulcastStreams = 3;
6765 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6766 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6767
6768 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006769 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006770 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006771 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006772 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006773 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006774
6775 // Set max bitrate for all but the highest layer.
6776 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6777 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6778 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6779 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6780 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6781
6782 // Set max bandwidth equal to total max bitrate.
6783 send_parameters_.max_bandwidth_bps =
6784 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6785 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6786 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6787
6788 // No bitrate above the total max to give to the highest layer.
6789 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6790 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6791 stream->GetVideoStreams()[2].max_bitrate_bps);
6792
6793 // Set max bandwidth above the total max bitrate.
6794 send_parameters_.max_bandwidth_bps =
6795 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6796 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6797 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6798
6799 // The highest layer has no max bitrate set -> the bitrate above the total
6800 // max should be given to the highest layer.
6801 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6802 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6803 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6804 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6805 stream->GetVideoStreams()[2].max_bitrate_bps);
6806
6807 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6808}
6809
6810TEST_F(WebRtcVideoChannelTest,
6811 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6812 const size_t kNumSimulcastStreams = 3;
6813 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6814 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6815 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6816
6817 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006818 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006819 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006820 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006821 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006822 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006823
6824 // Set max bitrate for the highest layer.
6825 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6826 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6827 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6828 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6829
6830 // Set max bandwidth above the total max bitrate.
6831 send_parameters_.max_bandwidth_bps =
6832 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6833 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6834 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6835
6836 // The highest layer has the max bitrate set -> the bitrate above the total
6837 // max should not be given to the highest layer.
6838 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6839 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6840 stream->GetVideoStreams()[2].max_bitrate_bps);
6841
6842 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6843}
6844
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006845// Test that min and max bitrate values set via RtpParameters are correctly
6846// propagated to the underlying encoder for a single stream.
6847TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6848 FakeVideoSendStream* stream = AddSendStream();
6849 EXPECT_TRUE(channel_->SetSend(true));
6850 EXPECT_TRUE(stream->IsSending());
6851
6852 // Set min and max bitrate.
6853 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6854 EXPECT_EQ(1u, parameters.encodings.size());
6855 parameters.encodings[0].min_bitrate_bps = 80000;
6856 parameters.encodings[0].max_bitrate_bps = 150000;
6857 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6858
6859 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6860 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6861 EXPECT_EQ(1u, encoder_config.number_of_streams);
6862 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6863 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6864 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6865
6866 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6867 // VideoStreams are created appropriately.
6868 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6869 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6870 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6871 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6872}
6873
6874// Test the default min and max bitrate value are correctly propagated to the
6875// underlying encoder for a single stream (when the values are not set via
6876// RtpParameters).
6877TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6878 FakeVideoSendStream* stream = AddSendStream();
6879 EXPECT_TRUE(channel_->SetSend(true));
6880 EXPECT_TRUE(stream->IsSending());
6881
6882 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6883 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6884 EXPECT_EQ(1u, encoder_config.number_of_streams);
6885 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6886 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6887 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6888
6889 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6890 // VideoStreams are created appropriately.
6891 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6892 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6893 stream->GetVideoStreams()[0].min_bitrate_bps);
6894 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6895 stream->GetVideoStreams()[0].min_bitrate_bps);
6896 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6897 stream->GetVideoStreams()[0].target_bitrate_bps);
6898}
6899
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006900// Test that a stream will not be sending if its encoding is made inactive
6901// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006902TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006903 FakeVideoSendStream* stream = AddSendStream();
6904 EXPECT_TRUE(channel_->SetSend(true));
6905 EXPECT_TRUE(stream->IsSending());
6906
6907 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006908 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006909 ASSERT_EQ(1u, parameters.encodings.size());
6910 ASSERT_TRUE(parameters.encodings[0].active);
6911 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006912 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006913 EXPECT_FALSE(stream->IsSending());
6914
6915 // Now change it back to active and verify we resume sending.
6916 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006917 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006918 EXPECT_TRUE(stream->IsSending());
6919}
6920
Seth Hampson8234ead2018-02-02 15:16:24 -08006921// Tests that when active is updated for any simulcast layer then the send
6922// stream's sending state will be updated and it will be reconfigured with the
6923// new appropriate active simulcast streams.
6924TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6925 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006926 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006927 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6928 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6929 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6930 uint32_t primary_ssrc = stream_params.first_ssrc();
6931
Niels Möller805a27e2019-01-21 12:21:27 +01006932 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006933 // frame. This allows us to test that ReconfigureEncoder is called
6934 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006935 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006936 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006937 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006938 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006939 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6940 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6941 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006942
6943 // Check that all encodings are initially active.
6944 webrtc::RtpParameters parameters =
6945 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006946 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006947 EXPECT_TRUE(parameters.encodings[0].active);
6948 EXPECT_TRUE(parameters.encodings[1].active);
6949 EXPECT_TRUE(parameters.encodings[2].active);
6950 EXPECT_TRUE(fake_video_send_stream->IsSending());
6951
6952 // Only turn on only the middle stream.
6953 parameters.encodings[0].active = false;
6954 parameters.encodings[1].active = true;
6955 parameters.encodings[2].active = false;
6956 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6957 // Verify that the active fields are set on the VideoChannel.
6958 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006959 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006960 EXPECT_FALSE(parameters.encodings[0].active);
6961 EXPECT_TRUE(parameters.encodings[1].active);
6962 EXPECT_FALSE(parameters.encodings[2].active);
6963 // Check that the VideoSendStream is updated appropriately. This means its
6964 // send state was updated and it was reconfigured.
6965 EXPECT_TRUE(fake_video_send_stream->IsSending());
6966 std::vector<webrtc::VideoStream> simulcast_streams =
6967 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006968 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006969 EXPECT_FALSE(simulcast_streams[0].active);
6970 EXPECT_TRUE(simulcast_streams[1].active);
6971 EXPECT_FALSE(simulcast_streams[2].active);
6972
6973 // Turn off all streams.
6974 parameters.encodings[0].active = false;
6975 parameters.encodings[1].active = false;
6976 parameters.encodings[2].active = false;
6977 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6978 // Verify that the active fields are set on the VideoChannel.
6979 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006980 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006981 EXPECT_FALSE(parameters.encodings[0].active);
6982 EXPECT_FALSE(parameters.encodings[1].active);
6983 EXPECT_FALSE(parameters.encodings[2].active);
6984 // Check that the VideoSendStream is off.
6985 EXPECT_FALSE(fake_video_send_stream->IsSending());
6986 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02006987 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006988 EXPECT_FALSE(simulcast_streams[0].active);
6989 EXPECT_FALSE(simulcast_streams[1].active);
6990 EXPECT_FALSE(simulcast_streams[2].active);
6991
Niels Möllerff40b142018-04-09 08:49:14 +02006992 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08006993}
6994
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006995// Test that if a stream is reconfigured (due to a codec change or other
6996// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07006997TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006998 InactiveStreamDoesntStartSendingWhenReconfigured) {
6999 // Set an initial codec list, which will be modified later.
7000 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007001 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7002 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007003 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7004
7005 FakeVideoSendStream* stream = AddSendStream();
7006 EXPECT_TRUE(channel_->SetSend(true));
7007 EXPECT_TRUE(stream->IsSending());
7008
7009 // Get current parameters and change "active" to false.
7010 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7011 ASSERT_EQ(1u, parameters.encodings.size());
7012 ASSERT_TRUE(parameters.encodings[0].active);
7013 parameters.encodings[0].active = false;
7014 EXPECT_EQ(1u, GetFakeSendStreams().size());
7015 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007016 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007017 EXPECT_FALSE(stream->IsSending());
7018
7019 // Reorder the codec list, causing the stream to be reconfigured.
7020 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007021 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7022 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007023 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7024 auto new_streams = GetFakeSendStreams();
7025 // Assert that a new underlying stream was created due to the codec change.
7026 // Otherwise, this test isn't testing what it set out to test.
7027 EXPECT_EQ(1u, GetFakeSendStreams().size());
7028 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7029
7030 // Verify that we still are not sending anything, due to the inactive
7031 // encoding.
7032 EXPECT_FALSE(new_streams[0]->IsSending());
7033}
7034
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007035// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007036TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007037 AddSendStream();
7038 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007039 parameters.codecs.push_back(GetEngineCodec("VP8"));
7040 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007041 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7042
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007043 webrtc::RtpParameters rtp_parameters =
7044 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007045 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007046 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7047 rtp_parameters.codecs[0]);
7048 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7049 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007050}
7051
Florent Castellidacec712018-05-24 16:24:21 +02007052// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7053TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7054 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7055 params.cname = "rtcpcname";
7056 AddSendStream(params);
7057
7058 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7059 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7060}
7061
deadbeeffb2aced2017-01-06 23:05:37 -08007062// Test that RtpParameters for send stream has one encoding and it has
7063// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007064TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007065 AddSendStream();
7066
7067 webrtc::RtpParameters rtp_parameters =
7068 channel_->GetRtpSendParameters(last_ssrc_);
7069 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007070 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007071}
7072
Florent Castelliabe301f2018-06-12 18:33:49 +02007073TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7074 AddSendStream();
7075
7076 webrtc::RtpParameters rtp_parameters =
7077 channel_->GetRtpSendParameters(last_ssrc_);
7078 rtp_parameters.header_extensions.emplace_back();
7079
7080 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7081
7082 webrtc::RTCError result =
7083 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7084 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7085}
7086
Florent Castelli87b3c512018-07-18 16:00:28 +02007087TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7088 AddSendStream();
7089
Niels Möller805a27e2019-01-21 12:21:27 +01007090 webrtc::test::FrameForwarder frame_forwarder;
7091 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007092
7093 webrtc::RtpParameters rtp_parameters =
7094 channel_->GetRtpSendParameters(last_ssrc_);
7095 EXPECT_EQ(rtp_parameters.degradation_preference,
7096 webrtc::DegradationPreference::BALANCED);
7097 rtp_parameters.degradation_preference =
7098 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7099
7100 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7101
7102 webrtc::RtpParameters updated_rtp_parameters =
7103 channel_->GetRtpSendParameters(last_ssrc_);
7104 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7105 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7106
7107 // Remove the source since it will be destroyed before the channel
7108 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7109}
7110
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007111// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007112TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007113 AddSendStream();
7114 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007115 parameters.codecs.push_back(GetEngineCodec("VP8"));
7116 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007117 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7118
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007119 webrtc::RtpParameters initial_params =
7120 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007121
7122 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007123 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007124
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007125 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7126 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7127}
7128
7129// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007130TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007131 AddRecvStream();
7132 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007133 parameters.codecs.push_back(GetEngineCodec("VP8"));
7134 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007135 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7136
7137 webrtc::RtpParameters rtp_parameters =
7138 channel_->GetRtpReceiveParameters(last_ssrc_);
7139 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007140 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7141 rtp_parameters.codecs[0]);
7142 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7143 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007144}
7145
johan073ece42016-08-26 02:59:47 -07007146#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007147TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007148#else
eladalonf1841382017-06-12 01:16:46 -07007149TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007150#endif
johan3859c892016-08-05 09:19:25 -07007151 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007152 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007153 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007154 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007155 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007156 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007157 parameters.codecs.push_back(kH264sprop2);
7158 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7159
7160 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7161 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7162 webrtc::RtpParameters rtp_parameters =
7163 channel_->GetRtpReceiveParameters(last_ssrc_);
7164 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7165 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7166 ASSERT_EQ(2u, cfg.decoders.size());
7167 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007168 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007169 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007170 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7171 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007172 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007173
7174 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007175 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007176 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007177 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7178 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007179 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007180}
7181
sakal1fd95952016-06-22 00:46:15 -07007182// Test that RtpParameters for receive stream has one encoding and it has
7183// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007184TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007185 AddRecvStream();
7186
7187 webrtc::RtpParameters rtp_parameters =
7188 channel_->GetRtpReceiveParameters(last_ssrc_);
7189 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007190 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007191}
7192
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007193// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007194TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007195 AddRecvStream();
7196 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007197 parameters.codecs.push_back(GetEngineCodec("VP8"));
7198 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007199 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7200
7201 webrtc::RtpParameters initial_params =
7202 channel_->GetRtpReceiveParameters(last_ssrc_);
7203
7204 // We should be able to set the params we just got.
7205 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7206
7207 // ... And this shouldn't change the params returned by
7208 // GetRtpReceiveParameters.
7209 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007210}
7211
deadbeef3bc15102017-04-20 19:25:07 -07007212// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7213// aren't signaled. It should always return an empty "RtpEncodingParameters",
7214// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007215TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007216 // Call necessary methods to configure receiving a default stream as
7217 // soon as it arrives.
7218 cricket::VideoRecvParameters parameters;
7219 parameters.codecs.push_back(GetEngineCodec("VP8"));
7220 parameters.codecs.push_back(GetEngineCodec("VP9"));
7221 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7222
7223 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7224 // stream. Should return nothing.
7225 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7226
7227 // Set a sink for an unsignaled stream.
7228 cricket::FakeVideoRenderer renderer;
7229 // Value of "0" means "unsignaled stream".
7230 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7231
7232 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7233 // in this method means "unsignaled stream".
7234 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7235 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7236 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7237
7238 // Receive VP8 packet.
7239 uint8_t data[kMinRtpPacketLen];
7240 cricket::RtpHeader rtpHeader;
7241 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7242 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7243 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7244 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7245 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007246 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007247
7248 // The |ssrc| member should still be unset.
7249 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7250 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7251 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7252}
7253
eladalonf1841382017-06-12 01:16:46 -07007254void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007255 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007256 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007257
7258 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007259 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007260 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007261 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007262
7263 if (receiver_first) {
7264 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7265 std::vector<FakeVideoReceiveStream*> receive_streams =
7266 fake_call_->GetVideoReceiveStreams();
7267 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007268 // Default local SSRC when we have no sender.
7269 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7270 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007271 }
7272 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7273 if (!receiver_first)
7274 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7275 std::vector<FakeVideoReceiveStream*> receive_streams =
7276 fake_call_->GetVideoReceiveStreams();
7277 ASSERT_EQ(1u, receive_streams.size());
7278 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007279
7280 // Removing first sender should fall back to another (in this case the second)
7281 // local send stream's SSRC.
7282 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7283 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007284 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007285 ASSERT_EQ(1u, receive_streams.size());
7286 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7287
7288 // Removing the last sender should fall back to default local SSRC.
7289 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007290 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007291 ASSERT_EQ(1u, receive_streams.size());
7292 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7293 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007294}
7295
eladalonf1841382017-06-12 01:16:46 -07007296TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007297 TestReceiverLocalSsrcConfiguration(false);
7298}
7299
eladalonf1841382017-06-12 01:16:46 -07007300TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007301 TestReceiverLocalSsrcConfiguration(true);
7302}
7303
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007304class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007305 public:
eladalonf1841382017-06-12 01:16:46 -07007306 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007307 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007308 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7309 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007310 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007311 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007312 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007313 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007314 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007315 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007316 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007317
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007318 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007319 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007320 channel_.reset(engine_.CreateMediaChannel(
7321 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7322 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007323 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007324 last_ssrc_ = 123;
7325 }
7326
7327 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007328 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007329 int capture_width,
7330 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007331 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007332 size_t expected_num_streams,
7333 bool screenshare,
7334 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007335 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007336 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007337 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007338 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007339
Peter Boström0c4e06b2015-10-07 12:23:21 +02007340 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007341 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007342 ssrcs.resize(num_configured_streams);
7343
sprangf24a0642017-02-28 13:23:26 -08007344 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007345 // Send a full-size frame to trigger a stream reconfiguration to use all
7346 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007347 webrtc::test::FrameForwarder frame_forwarder;
7348 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7349 rtc::kNumMicrosecsPerSec / 30);
7350
sprangf24a0642017-02-28 13:23:26 -08007351 VideoOptions options;
7352 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007353 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007354 EXPECT_TRUE(
7355 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007356 // Fetch the latest stream since SetVideoSend() may recreate it if the
7357 // screen content setting is changed.
7358 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007359 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007360 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007361
Zach Stein3ca452b2018-01-18 10:01:24 -08007362 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7363 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7364
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007365 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7366 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007367 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007368
sprang429600d2017-01-26 06:12:26 -08007369 std::vector<webrtc::VideoStream> expected_streams;
7370 if (conference_mode) {
7371 expected_streams = GetSimulcastConfig(
7372 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08007373 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02007374 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08007375 if (screenshare) {
7376 for (const webrtc::VideoStream& stream : expected_streams) {
7377 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007378 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7379 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007380 }
7381 }
sprang429600d2017-01-26 06:12:26 -08007382 } else {
7383 webrtc::VideoStream stream;
7384 stream.width = capture_width;
7385 stream.height = capture_height;
7386 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007387 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007388 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007389 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007390 stream.max_qp = kDefaultQpMax;
7391 expected_streams.push_back(stream);
7392 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007393
7394 ASSERT_EQ(expected_streams.size(), video_streams.size());
7395
7396 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007397 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007398 for (size_t i = 0; i < num_streams; ++i) {
7399 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7400 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7401
7402 EXPECT_GT(video_streams[i].max_framerate, 0);
7403 EXPECT_EQ(expected_streams[i].max_framerate,
7404 video_streams[i].max_framerate);
7405
7406 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7407 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7408 video_streams[i].min_bitrate_bps);
7409
7410 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7411 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7412 video_streams[i].target_bitrate_bps);
7413
7414 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7415 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7416 video_streams[i].max_bitrate_bps);
7417
7418 EXPECT_GT(video_streams[i].max_qp, 0);
7419 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7420
Sergey Silkina796a7e2018-03-01 15:11:29 +01007421 EXPECT_EQ(conference_mode,
7422 expected_streams[i].num_temporal_layers.has_value());
7423
7424 if (conference_mode) {
7425 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7426 video_streams[i].num_temporal_layers);
7427 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007428
7429 if (i == num_streams - 1) {
7430 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7431 } else {
7432 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7433 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007434 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007435
Niels Möllerff40b142018-04-09 08:49:14 +02007436 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007437 }
7438
7439 FakeVideoSendStream* AddSendStream() {
7440 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7441 }
7442
7443 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007444 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007445 EXPECT_TRUE(channel_->AddSendStream(sp));
7446 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007447 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007448 EXPECT_EQ(num_streams + 1, streams.size());
7449 return streams[streams.size() - 1];
7450 }
7451
7452 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007453 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007454 }
7455
7456 FakeVideoReceiveStream* AddRecvStream() {
7457 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7458 }
7459
7460 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007461 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007462 EXPECT_TRUE(channel_->AddRecvStream(sp));
7463 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007464 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007465 EXPECT_EQ(num_streams + 1, streams.size());
7466 return streams[streams.size() - 1];
7467 }
7468
skvlad11a9cbf2016-10-07 11:53:05 -07007469 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007470 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007471 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7472 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007473 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7474 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007475 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007476 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007477 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007478};
7479
eladalonf1841382017-06-12 01:16:46 -07007480TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007481 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7482 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007483}
7484
eladalonf1841382017-06-12 01:16:46 -07007485TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007486 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7487 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007488}
7489
7490// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007491TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007492 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7493 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007494}
sprang429600d2017-01-26 06:12:26 -08007495
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007496TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007497 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7498 false);
7499}
7500
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007501TEST_F(WebRtcVideoChannelSimulcastTest,
7502 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007503 webrtc::test::ScopedFieldTrials field_trials(
7504 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007505 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7506 true);
7507}
7508
eladalonf1841382017-06-12 01:16:46 -07007509TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007510 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7511 true);
7512}
7513
eladalonf1841382017-06-12 01:16:46 -07007514TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007515 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007516 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7517 false);
7518}
7519
Yves Gereyb6a89422018-10-08 10:08:32 +02007520class WebRtcVideoFakeClock {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007521 public:
Yves Gereyb6a89422018-10-08 10:08:32 +02007522 WebRtcVideoFakeClock() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007523 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1)); // avoid time=0
7524 }
7525 rtc::ScopedFakeClock fake_clock_;
7526};
7527
Yves Gereyb6a89422018-10-08 10:08:32 +02007528// The fake clock needs to be initialized before the call, and not
7529// destroyed until after all threads spawned by the test have been stopped.
7530// This mixin ensures that.
7531class WebRtcVideoChannelTestWithClock : public WebRtcVideoFakeClock,
7532 public WebRtcVideoChannelBaseTest {};
7533
Jonas Oreland49ac5952018-09-26 16:04:32 +02007534TEST_F(WebRtcVideoChannelTestWithClock, GetSources) {
7535 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7536 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7537
7538 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7539
7540 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7541 rtc::SetBE32(packet1.data() + 8, kSsrc);
7542 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7543 EXPECT_TRUE(SetDefaultCodec());
7544 EXPECT_TRUE(SetSend(true));
7545 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007546 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007547
7548 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7549 EXPECT_EQ(1u, sources.size());
7550 EXPECT_EQ(webrtc::RtpSourceType::SSRC, sources[0].source_type());
7551 int64_t timestamp1 = sources[0].timestamp_ms();
7552
7553 // a new packet.
7554 int64_t timeDeltaMs = 1;
7555 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007556 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007557 int64_t timestamp2 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7558 EXPECT_EQ(timestamp2, timestamp1 + timeDeltaMs);
7559
7560 // It only keeps 10s of history.
7561 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7562 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7563 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7564}
7565
7566TEST_F(WebRtcVideoChannelTestWithClock, GetContributingSources) {
7567 uint8_t data1[] = {0x81, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
7568 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7569
7570 uint32_t kCsrc = 4321u;
7571 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7572 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7573
7574 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
7575 rtc::SetBE32(packet1.data() + 8, kSsrc);
7576 rtc::SetBE32(packet1.data() + 12, kCsrc);
7577 channel_->SetSink(kDefaultReceiveSsrc, NULL);
7578 EXPECT_TRUE(SetDefaultCodec());
7579 EXPECT_TRUE(SetSend(true));
7580 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007581 channel_->OnPacketReceived(packet1, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007582
7583 {
7584 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7585 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7586 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7587 EXPECT_EQ(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7588 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007589 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7590 return source.source_type() == webrtc::RtpSourceType::SSRC;
7591 }));
7592 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7593 return source.source_type() == webrtc::RtpSourceType::CSRC;
7594 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007595 }
7596 int64_t timestamp1 = channel_->GetSources(kSsrc)[0].timestamp_ms();
7597
7598 // a new packet with only ssrc (i.e no csrc).
7599 uint8_t data2[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
7600 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
7601 rtc::CopyOnWriteBuffer packet2(data2, sizeof(data2));
7602 rtc::SetBE32(packet2.data() + 8, kSsrc);
7603
7604 int64_t timeDeltaMs = 1;
7605 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(timeDeltaMs));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007606 channel_->OnPacketReceived(packet2, /*packet_time_us=*/-1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007607
7608 {
7609 ASSERT_EQ(2u, channel_->GetSources(kSsrc).size());
7610 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7611 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
7612 EXPECT_NE(sources[0].timestamp_ms(), sources[1].timestamp_ms());
7613 // 1 SSRC and 1 CSRC.
Steve Anton2c9ebef2019-01-28 17:27:58 -08007614 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7615 return source.source_type() == webrtc::RtpSourceType::SSRC;
7616 }));
7617 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7618 return source.source_type() == webrtc::RtpSourceType::CSRC;
7619 }));
7620 auto ssrcSource =
7621 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007622 return source.source_type() == webrtc::RtpSourceType::SSRC;
7623 });
Steve Anton2c9ebef2019-01-28 17:27:58 -08007624 auto csrcSource =
7625 absl::c_find_if(sources, [](const webrtc::RtpSource& source) {
Jonas Oreland49ac5952018-09-26 16:04:32 +02007626 return source.source_type() == webrtc::RtpSourceType::CSRC;
7627 });
7628
7629 EXPECT_EQ(ssrcSource->timestamp_ms(), timestamp1 + timeDeltaMs);
7630 EXPECT_EQ(csrcSource->timestamp_ms(), timestamp1);
7631 }
7632
7633 // It only keeps 10s of history.
7634 fake_clock_.AdvanceTime(webrtc::TimeDelta::seconds(10));
7635
7636 {
7637 ASSERT_EQ(1u, channel_->GetSources(kSsrc).size());
7638 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7639 std::vector<webrtc::RtpSource> sources = channel_->GetSources(kSsrc);
Steve Anton2c9ebef2019-01-28 17:27:58 -08007640 EXPECT_EQ(1, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7641 return source.source_type() == webrtc::RtpSourceType::SSRC;
7642 }));
7643 EXPECT_EQ(0, absl::c_count_if(sources, [](const webrtc::RtpSource& source) {
7644 return source.source_type() == webrtc::RtpSourceType::CSRC;
7645 }));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007646 }
7647
7648 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(1));
7649 EXPECT_EQ(0u, channel_->GetSources(kSsrc).size());
7650 EXPECT_EQ(0u, channel_->GetSources(kCsrc).size());
7651}
7652
Amit Hilbuchb000b712019-02-25 10:22:14 -08007653TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7654 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7655
7656 std::vector<std::string> rids = {"f", "h", "q"};
7657 std::vector<cricket::RidDescription> rid_descriptions;
7658 for (const auto& rid : rids) {
7659 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7660 }
7661 sp.set_rids(rid_descriptions);
7662
7663 ASSERT_TRUE(channel_->AddSendStream(sp));
7664 const auto& streams = fake_call_->GetVideoSendStreams();
7665 ASSERT_EQ(1u, streams.size());
7666 auto stream = streams[0];
7667 ASSERT_NE(stream, nullptr);
7668 const auto& config = stream->GetConfig();
7669 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7670}
7671
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007672} // namespace cricket