blob: ff5f9e54db91e81a54f04c7bb28f1da89a36aa18 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
11#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080012#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020013#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070014#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000015#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000016
Steve Anton2c9ebef2019-01-28 17:27:58 -080017#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010018#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020019#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070020#include "api/media_transport_config.h"
Steve Anton10542f22019-01-11 09:11:00 -080021#include "api/rtp_parameters.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070022#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080023#include "api/test/mock_video_bitrate_allocator.h"
24#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070025#include "api/test/mock_video_decoder_factory.h"
26#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020027#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080028#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010029#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020030#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020031#include "api/video_codecs/builtin_video_decoder_factory.h"
32#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020033#include "api/video_codecs/sdp_video_format.h"
34#include "api/video_codecs/video_decoder_factory.h"
35#include "api/video_codecs/video_encoder.h"
36#include "api/video_codecs/video_encoder_factory.h"
37#include "call/flexfec_receive_stream.h"
38#include "common_video/h264/profile_level_id.h"
39#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010040#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080041#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080042#include "media/base/fake_video_renderer.h"
43#include "media/base/media_constants.h"
44#include "media/base/rtp_utils.h"
45#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020046#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080047#include "media/engine/fake_webrtc_call.h"
48#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/webrtc_video_engine.h"
51#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020052#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020053#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080054#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020056#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080057#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020058#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010059#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000061
Mirko Bonadei6a489f22019-04-09 15:11:12 +020062using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020063using ::testing::IsEmpty;
64using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010065using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070066using webrtc::RtpExtension;
67
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000068namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000069static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000070
noahricd10a68e2015-07-10 11:27:55 -070071static const uint8_t kRedRtxPayloadType = 125;
72
Niels Möller6557d0c2018-04-11 15:18:34 +020073static const uint32_t kTimeout = 5000U;
74static const uint32_t kDefaultReceiveSsrc = 0;
75static const uint32_t kSsrc = 1234u;
76static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
77static const int kVideoWidth = 640;
78static const int kVideoHeight = 360;
79static const int kFramerate = 30;
80
Peter Boström0c4e06b2015-10-07 12:23:21 +020081static const uint32_t kSsrcs1[] = {1};
82static const uint32_t kSsrcs3[] = {1, 2, 3};
83static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080084static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020085static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080086static const uint32_t kDefaultRecvSsrc = 0;
87
pbos@webrtc.org3c107582014-07-20 15:27:35 +000088static const char kUnsupportedExtensionName[] =
89 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000090
magjed509e4fe2016-11-18 01:34:11 -080091cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
92 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020093 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080094}
95
Elad Alonfadb1812019-05-24 13:40:02 +020096void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
97 bool lntf_expected) {
98 EXPECT_EQ(lntf_expected,
99 codec.HasFeedbackParam(cricket::FeedbackParam(
100 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000101 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
102 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
103 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
106 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800108 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000110 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
111}
112
magjed725e4842016-11-16 00:48:13 -0800113// Return true if any codec in |codecs| is an RTX codec with associated payload
114// type |payload_type|.
115bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
116 int payload_type) {
117 for (const cricket::VideoCodec& codec : codecs) {
118 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200119 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800120 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
121 &associated_payload_type) &&
122 associated_payload_type == payload_type) {
123 return true;
124 }
125 }
126 return false;
127}
128
nisseca5706d2017-09-11 02:32:16 -0700129// TODO(nisse): Duplicated in call.cc.
130const int* FindKeyByValue(const std::map<int, int>& m, int v) {
131 for (const auto& kv : m) {
132 if (kv.second == v)
133 return &kv.first;
134 }
135 return nullptr;
136}
137
Yves Gerey665174f2018-06-19 15:03:05 +0200138bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
139 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700140 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
141 payload_type) != nullptr;
142}
143
144// Check that there's an Rtx payload type for each decoder.
145bool VerifyRtxReceiveAssociations(
146 const webrtc::VideoReceiveStream::Config& config) {
147 for (const auto& decoder : config.decoders) {
148 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
149 return false;
150 }
151 return true;
152}
153
brandtrffc61182016-11-28 06:02:22 -0800154rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700155 int width,
156 int height) {
157 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
158 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800159 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700160 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000161}
162
Shao Changbine62202f2015-04-21 20:24:50 +0800163void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
164 const std::map<int, int>& rtx_types) {
165 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200166 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800167 EXPECT_TRUE(it != rtx_types.end() &&
168 it->second == config.rtp.rtx.payload_type);
169
brandtrb5f2c3f2016-10-04 23:28:39 -0700170 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
171 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800172 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700173 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800174 }
175}
kthelgason2bc68642017-02-07 07:02:22 -0800176
177cricket::MediaConfig GetMediaConfig() {
178 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100179 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800180 return media_config;
181}
nisse26e3abb2017-08-25 04:44:25 -0700182
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200183// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
184int GetMaxDefaultBitrateBps(size_t width, size_t height) {
185 if (width * height <= 320 * 240) {
186 return 600000;
187 } else if (width * height <= 640 * 480) {
188 return 1700000;
189 } else if (width * height <= 960 * 540) {
190 return 2000000;
191 } else {
192 return 2500000;
193 }
194}
195
Niels Möller731a2c22018-07-30 15:08:07 +0200196class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
197 public:
198 MOCK_METHOD2(AddOrUpdateSink,
199 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
200 const rtc::VideoSinkWants& wants));
201 MOCK_METHOD1(RemoveSink,
202 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
203};
204
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000205} // namespace
206
Yves Gerey665174f2018-06-19 15:03:05 +0200207#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200208 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200209 EXPECT_EQ((w), renderer_.width()); \
210 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200211 EXPECT_EQ(0, renderer_.errors());
212
Yves Gerey665174f2018-06-19 15:03:05 +0200213#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200214 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200215 EXPECT_EQ((w), (r).width()); \
216 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200217 EXPECT_EQ(0, (r).errors());
218
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000219namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700220class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000221 public:
eladalonf1841382017-06-12 01:16:46 -0700222 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200223 explicit WebRtcVideoEngineTest(const std::string& field_trials)
224 : override_field_trials_(
225 field_trials.empty()
226 ? nullptr
227 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
228 field_trials)),
skvlad11a9cbf2016-10-07 11:53:05 -0700229 call_(webrtc::Call::Create(webrtc::Call::Config(&event_log_))),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200230 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
231 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200232 video_bitrate_allocator_factory_(
233 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200234 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200235 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200236 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200237 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200238 // Ensure fake clock doesn't return 0, which will cause some initializations
239 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200240 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200241 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000242
243 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200244 void AssignDefaultAptRtxTypes();
245 void AssignDefaultCodec();
246
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100247 // Find the index of the codec in the engine with the given name. The codec
248 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100249 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100250
magjed509e4fe2016-11-18 01:34:11 -0800251 // Find the codec in the engine with the given name. The codec must be
252 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100253 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800254
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200255 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000256
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000258 const std::vector<VideoCodec>& codecs);
259
Elad Alon157540a2019-02-08 23:37:52 +0100260 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100261
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200262 // Has to be the first one, so it is initialized before the call or there is a
263 // race condition in the clock access.
264 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200265 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700266 webrtc::RtcEventLogNullImpl event_log_;
eladalonf1841382017-06-12 01:16:46 -0700267 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000268 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800269 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200270 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
271 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200272 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
273 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700274 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000275 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800276 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000277};
278
eladalonf1841382017-06-12 01:16:46 -0700279TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200280 encoder_factory_->AddSupportedVideoCodecType("VP8");
281 AssignDefaultCodec();
282
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000283 std::vector<VideoCodec> engine_codecs = engine_.codecs();
284 for (size_t i = 0; i < engine_codecs.size(); ++i) {
285 if (engine_codecs[i].name != kRtxCodecName)
286 continue;
287 int associated_payload_type;
288 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000289 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000290 EXPECT_EQ(default_codec_.id, associated_payload_type);
291 return;
292 }
293 FAIL() << "No RTX codec found among default codecs.";
294}
295
eladalonf1841382017-06-12 01:16:46 -0700296TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100297 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000298}
299
eladalonf1841382017-06-12 01:16:46 -0700300TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100301 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000302}
303
eladalonf1841382017-06-12 01:16:46 -0700304TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100305 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700306}
307
eladalonf1841382017-06-12 01:16:46 -0700308TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100309 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
310}
311
312TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
313 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
314}
315
316TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
317 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
318}
319
320TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
321 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
322}
323
324TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
325 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100326}
327
328TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100329 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
330}
331
Elad Alonccb9b752019-02-19 13:01:31 +0100332TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
333 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
334}
335
336TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
337 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700338}
339
philipel1e054862018-10-08 16:13:53 +0200340class WebRtcVideoEngineTestWithGenericDescriptor
341 : public WebRtcVideoEngineTest {
342 public:
343 WebRtcVideoEngineTestWithGenericDescriptor()
344 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
345};
346
Elad Alonccb9b752019-02-19 13:01:31 +0100347TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
348 AdvertiseGenericDescriptor00) {
349 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
350}
351
352TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
353 AdvertiseGenericDescriptor01) {
354 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200355}
356
eladalonf1841382017-06-12 01:16:46 -0700357TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200358 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700359 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200360 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700361
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200362 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700363
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200364 std::unique_ptr<VideoMediaChannel> channel(
365 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700366 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
367
368 // Add CVO extension.
369 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800370 cricket::VideoSendParameters parameters;
371 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200372 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700373 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200374 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700375
Niels Möller731a2c22018-07-30 15:08:07 +0200376 EXPECT_CALL(
377 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200378 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200379 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700380 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200381 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700382
383 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200384 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700385
386 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200387 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200388 EXPECT_CALL(
389 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200390 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200391 Field(&rtc::VideoSinkWants::rotation_applied, true)));
392
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200393 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700394}
395
eladalonf1841382017-06-12 01:16:46 -0700396TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200397 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800398 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200399 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800400
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200401 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800402
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200403 std::unique_ptr<VideoMediaChannel> channel(
404 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800405 // Add CVO extension.
406 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800407 cricket::VideoSendParameters parameters;
408 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800409 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700410 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800411 EXPECT_TRUE(channel->SetSendParameters(parameters));
412 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
413
Niels Möller731a2c22018-07-30 15:08:07 +0200414 // Set source.
415 EXPECT_CALL(
416 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200417 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200418 Field(&rtc::VideoSinkWants::rotation_applied, false)));
419 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800420}
421
eladalonf1841382017-06-12 01:16:46 -0700422TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200423 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700424
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200425 encoder_factory_->AddSupportedVideoCodecType("VP8");
426 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700427
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200428 std::unique_ptr<VideoMediaChannel> channel(
429 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700430 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
431
432 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200433 EXPECT_CALL(
434 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200435 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200436 Field(&rtc::VideoSinkWants::rotation_applied, true)));
437 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700438
perkjcaafdba2016-03-20 07:34:29 -0700439 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200440 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700441
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700442 // Add CVO extension.
443 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800444 cricket::VideoSendParameters parameters;
445 parameters.codecs.push_back(GetEngineCodec("VP8"));
446 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200447 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700448 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700449 // Also remove the first codec to trigger a codec change as well.
450 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200451 EXPECT_CALL(
452 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200453 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200454 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200455 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700456
457 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200458 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700459
460 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200461 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200462 EXPECT_CALL(
463 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200464 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200465 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200466 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700467}
468
eladalonf1841382017-06-12 01:16:46 -0700469TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200470 encoder_factory_->AddSupportedVideoCodecType("VP8");
471
Sebastian Jansson84848f22018-11-16 10:40:36 +0100472 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200473 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
474 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000475
476 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
477
478 EXPECT_FALSE(channel->SetSend(true))
479 << "Channel should not start without codecs.";
480 EXPECT_TRUE(channel->SetSend(false))
481 << "Channel should be stoppable even without set codecs.";
482}
483
eladalonf1841382017-06-12 01:16:46 -0700484TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200485 encoder_factory_->AddSupportedVideoCodecType("VP8");
486
Sebastian Jansson84848f22018-11-16 10:40:36 +0100487 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200488 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
489 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000490 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
491 VideoMediaInfo info;
492 channel->GetStats(&info);
493}
494
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200495TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200496 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000497
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200498 std::unique_ptr<VideoMediaChannel> channel(
499 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800500 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000501
502 EXPECT_TRUE(
503 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200504 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000505 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100506 webrtc::test::FrameForwarder frame_forwarder;
507 cricket::FakeFrameSource frame_source(1280, 720,
508 rtc::kNumMicrosecsPerSec / 30);
509 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
510 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100511 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200512 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
513 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000514 kTimeout);
515
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200516 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100517 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000518
519 // Setting codecs of the same type should not reallocate any encoders
520 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800521 cricket::VideoSendParameters parameters;
522 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200523 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200524 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000525
526 // Remove stream previously added to free the external encoder instance.
527 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200528 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000529}
530
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200531// Test that when an encoder factory supports H264, we add an RTX
532// codec for it.
533// TODO(deadbeef): This test should be updated if/when we start
534// adding RTX codecs for unrecognized codec names.
535TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800536 using webrtc::H264::ProfileLevelIdToString;
537 using webrtc::H264::ProfileLevelId;
538 using webrtc::H264::kLevel1;
Anders Carlsson67537952018-05-03 11:28:29 +0200539 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
540 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800541 *ProfileLevelIdToString(
542 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200543 webrtc::SdpVideoFormat h264_constrained_high("H264");
544 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800545 *ProfileLevelIdToString(
546 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200547 webrtc::SdpVideoFormat h264_high("H264");
548 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800549 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
550
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200551 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
552 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
553 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700554
magjed725e4842016-11-16 00:48:13 -0800555 // First figure out what payload types the test codecs got assigned.
556 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800557 // Now search for RTX codecs for them. Expect that they all have associated
558 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800559 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200560 codecs,
561 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
562 ->id));
magjed725e4842016-11-16 00:48:13 -0800563 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200564 codecs,
565 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
566 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800567 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200568 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700569}
570
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100571#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700572TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200573 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100574
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200575 std::unique_ptr<VideoMediaChannel> channel(
576 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100577
578 EXPECT_TRUE(
579 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
580}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100581#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100582
eladalonf1841382017-06-12 01:16:46 -0700583TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200584 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100585 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200586 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200587 std::unique_ptr<VideoMediaChannel> channel(
588 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700589
590 EXPECT_TRUE(
591 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
592
Niels Möllerd0f0f682019-01-14 09:09:53 +0100593 webrtc::test::FrameForwarder frame_forwarder;
594 cricket::FakeFrameSource frame_source(1280, 720,
595 rtc::kNumMicrosecsPerSec / 60);
596 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700597 channel->SetSend(true);
598
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200599 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700600
Niels Möllerd0f0f682019-01-14 09:09:53 +0100601 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700602 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700603 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100604 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700605 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700606 int64_t interval = timestamp - last_timestamp;
607
608 // Precision changes from nanosecond to millisecond.
609 // Allow error to be no more than 1.
610 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
611
612 last_timestamp = timestamp;
613 }
614
Niels Möllerd0f0f682019-01-14 09:09:53 +0100615 frame_forwarder.IncomingCapturedFrame(
616 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
617 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700618 last_timestamp = stream->GetLastTimestamp();
619 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100620 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
621 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
622 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700623 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700624 int64_t interval = timestamp - last_timestamp;
625
626 // Precision changes from nanosecond to millisecond.
627 // Allow error to be no more than 1.
628 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
629
630 last_timestamp = timestamp;
631 }
632
633 // Remove stream previously added to free the external encoder instance.
634 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
635}
636
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200637void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
638 std::vector<VideoCodec> engine_codecs = engine_.codecs();
639 RTC_DCHECK(!engine_codecs.empty());
640 for (const cricket::VideoCodec& codec : engine_codecs) {
641 if (codec.name == "rtx") {
642 int associated_payload_type;
643 if (codec.GetParam(kCodecParamAssociatedPayloadType,
644 &associated_payload_type)) {
645 default_apt_rtx_types_[associated_payload_type] = codec.id;
646 }
647 }
648 }
649}
650
651void WebRtcVideoEngineTest::AssignDefaultCodec() {
652 std::vector<VideoCodec> engine_codecs = engine_.codecs();
653 RTC_DCHECK(!engine_codecs.empty());
654 bool codec_set = false;
655 for (const cricket::VideoCodec& codec : engine_codecs) {
656 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
657 codec.name != "ulpfec") {
658 default_codec_ = codec;
659 codec_set = true;
660 }
661 }
662
663 RTC_DCHECK(codec_set);
664}
665
Oleh Prypina40f8242017-12-21 13:32:23 +0100666size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
667 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100668 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
669 for (size_t i = 0; i < codecs.size(); ++i) {
670 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200671 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200672 continue;
673 // The tests only use H264 Constrained Baseline. Make sure we don't return
674 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200675 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200676 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200677 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
678 if (profile_level_id->profile !=
679 webrtc::H264::kProfileConstrainedBaseline) {
680 continue;
681 }
682 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100683 return i;
magjed509e4fe2016-11-18 01:34:11 -0800684 }
685 // This point should never be reached.
686 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100687 return -1;
688}
689
690cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
691 const std::string& name) const {
692 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800693}
694
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200695VideoMediaChannel*
696WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100697 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200698 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
699 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200700 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800701 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200702 for (const webrtc::SdpVideoFormat& format :
703 encoder_factory_->GetSupportedFormats()) {
704 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800705 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200706 parameters.codecs.push_back(engine_codec);
707 }
708 }
magjed509e4fe2016-11-18 01:34:11 -0800709
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200710 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000711
712 return channel;
713}
714
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200715VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000716 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100717 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200718 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
719 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200720 cricket::VideoRecvParameters parameters;
721 parameters.codecs = codecs;
722 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000723
724 return channel;
725}
726
Elad Alon157540a2019-02-08 23:37:52 +0100727void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
728 bool supported) const {
729 const RtpCapabilities capabilities = engine_.GetCapabilities();
730 if (supported) {
731 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200732 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100733 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200734 EXPECT_THAT(capabilities.header_extensions,
735 ::testing::Each(::testing::Field(&RtpExtension::uri,
736 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100737 }
738}
739
eladalonf1841382017-06-12 01:16:46 -0700740TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200741 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000742
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200743 std::unique_ptr<VideoMediaChannel> channel(
744 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000745
Peter Boström0c4e06b2015-10-07 12:23:21 +0200746 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000747
Yves Gerey665174f2018-06-19 15:03:05 +0200748 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000749 EXPECT_TRUE(channel->SetSend(true));
750
Niels Möller805a27e2019-01-21 12:21:27 +0100751 webrtc::test::FrameForwarder frame_forwarder;
752 cricket::FakeFrameSource frame_source(1280, 720,
753 rtc::kNumMicrosecsPerSec / 60);
754 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
755 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000756
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200757 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000758
759 // Verify that encoders are configured for simulcast through adapter
760 // (increasing resolution and only configured to send one stream each).
761 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200762 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
763 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000764 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200765 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000766 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
767 EXPECT_GT(codec_settings.width, prev_width);
768 prev_width = codec_settings.width;
769 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000770
Niels Möllerff40b142018-04-09 08:49:14 +0200771 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000772
773 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200774 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000775}
776
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200777TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
778 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200779 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000780
Niels Möllerd0f0f682019-01-14 09:09:53 +0100781 // Frame source.
782 webrtc::test::FrameForwarder frame_forwarder;
783 cricket::FakeFrameSource frame_source(1280, 720,
784 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200785
Sebastian Jansson84848f22018-11-16 10:40:36 +0100786 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200787 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
788 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200789 cricket::VideoSendParameters parameters;
790 parameters.codecs.push_back(GetEngineCodec("H264"));
791 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000792
793 EXPECT_TRUE(
794 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100795 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200796 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100797 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200798
799 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000800
Anders Carlsson67537952018-05-03 11:28:29 +0200801 cricket::VideoSendParameters new_parameters;
802 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
803 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200804
805 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100806 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200807
Anders Carlsson8a150d92018-05-14 12:40:04 +0200808 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000809}
810
eladalonf1841382017-06-12 01:16:46 -0700811TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000812 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200813 encoder_factory_->AddSupportedVideoCodecType("VP8");
814 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000815
Sebastian Jansson84848f22018-11-16 10:40:36 +0100816 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200817 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
818 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800819 cricket::VideoSendParameters parameters;
820 parameters.codecs.push_back(GetEngineCodec("VP8"));
821 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822
Peter Boström0c4e06b2015-10-07 12:23:21 +0200823 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000824
Yves Gerey665174f2018-06-19 15:03:05 +0200825 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000826 EXPECT_TRUE(channel->SetSend(true));
827
828 // Send a fake frame, or else the media engine will configure the simulcast
829 // encoder adapter at a low-enough size that it'll only create a single
830 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100831 webrtc::test::FrameForwarder frame_forwarder;
832 cricket::FakeFrameSource frame_source(1280, 720,
833 rtc::kNumMicrosecsPerSec / 30);
834 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
835 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200837 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
838 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000839 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200840 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000841
842 channel.reset();
843 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200844 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000845}
846
eladalonf1841382017-06-12 01:16:46 -0700847TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000848 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200849 encoder_factory_->AddSupportedVideoCodecType("VP8");
850 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000851
Sebastian Jansson84848f22018-11-16 10:40:36 +0100852 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200853 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
854 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800855 cricket::VideoSendParameters parameters;
856 parameters.codecs.push_back(GetEngineCodec("H264"));
857 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000858
859 EXPECT_TRUE(
860 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100861
862 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100863 webrtc::test::FrameForwarder frame_forwarder;
864 cricket::FakeFrameSource frame_source(1280, 720,
865 rtc::kNumMicrosecsPerSec / 30);
866 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
867 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200868 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
869 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200870 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000871 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200872 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000873
874 channel.reset();
875 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200876 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000877}
878
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200879TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200880 RTC_DCHECK(!override_field_trials_);
881 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200882 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200883 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700884
Sebastian Jansson84848f22018-11-16 10:40:36 +0100885 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200886 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
887 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200888 cricket::VideoSendParameters parameters;
889 parameters.codecs.push_back(GetEngineCodec("H264"));
890 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700891
Peter Boström0c4e06b2015-10-07 12:23:21 +0200892 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700893 EXPECT_TRUE(
894 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100895
896 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100897 webrtc::test::FrameForwarder frame_forwarder;
898 cricket::FakeFrameSource frame_source(1280, 720,
899 rtc::kNumMicrosecsPerSec / 30);
900 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
901 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100902
Niels Möller4db138e2018-04-19 09:04:13 +0200903 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200904 ASSERT_EQ(1u, encoder_factory_->encoders().size());
905 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
906 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700907 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200908 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200909 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700910}
911
brandtrffc61182016-11-28 06:02:22 -0800912// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700913// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800914//
915// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700916TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800917 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200918 encoder_factory_->AddSupportedVideoCodecType("VP8");
919
Steve Anton2c9ebef2019-01-28 17:27:58 -0800920 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800921
922 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800923 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800924
925 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200926 RTC_DCHECK(!override_field_trials_);
927 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800928 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800929 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800930}
931
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200932// Test that codecs are added in the order they are reported from the factory.
933TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
934 encoder_factory_->AddSupportedVideoCodecType("VP8");
935 const char* kFakeCodecName = "FakeCodec";
936 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000937
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200938 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100939 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200940 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
941 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000942}
943
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200944// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800945// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200946TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100947 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
948 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100949
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100950 // Set up external encoder factory with first codec, and initialize engine.
951 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
952
brandtrffc61182016-11-28 06:02:22 -0800953 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800954
955 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100956 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800957 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200958 // The codec itself and RTX should have been added.
959 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100960
961 // Check that both fake codecs are present and that the second fake codec
962 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100963 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
964 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100965 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800966}
967
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200968TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
969 const char* kFakeCodecName = "FakeCodec";
970 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
971
972 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
973 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
974}
975
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200976TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
977 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200978 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200979 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800980 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000981
kwiberg686a8ef2016-02-26 03:00:35 -0800982 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200983 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000984
985 EXPECT_TRUE(
986 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200987 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000988
989 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200990 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200991 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000992
993 // Remove stream previously added to free the external decoder instance.
994 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200995 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000996}
997
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200998// Verifies that we can set up decoders.
999TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001000 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1001 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1002 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1003 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001004 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001005 webrtc::SdpVideoFormat supported_h264("H264");
1006 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1007 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001008 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001009 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010
kwiberg686a8ef2016-02-26 03:00:35 -08001011 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001012 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001013
1014 EXPECT_TRUE(
1015 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001016 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001017}
1018
Jonas Oreland49ac5952018-09-26 16:04:32 +02001019// Tests when GetSources is called with non-existing ssrc, it will return an
1020// empty list of RtpSource without crashing.
1021TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1022 // Setup an recv stream with |kSsrc|.
1023 encoder_factory_->AddSupportedVideoCodecType("VP8");
1024 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1025 cricket::VideoRecvParameters parameters;
1026 parameters.codecs.push_back(GetEngineCodec("VP8"));
1027 std::unique_ptr<VideoMediaChannel> channel(
1028 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1029
1030 EXPECT_TRUE(
1031 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1032
1033 // Call GetSources with |kSsrc + 1| which doesn't exist.
1034 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1035 EXPECT_EQ(0u, sources.size());
1036}
1037
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001038TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1039 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1040 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1041 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001042 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001043 EXPECT_EQ(0u, engine.codecs().size());
1044}
1045
1046TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1047 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001048 webrtc::MockVideoEncoderFactory* encoder_factory =
1049 new webrtc::MockVideoEncoderFactory();
1050 webrtc::MockVideoDecoderFactory* decoder_factory =
1051 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001052 WebRtcVideoEngine engine(
1053 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001054 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001055 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1056 EXPECT_EQ(0u, engine.codecs().size());
1057 EXPECT_CALL(*encoder_factory, Die());
1058 EXPECT_CALL(*decoder_factory, Die());
1059}
1060
1061// Test full behavior in the video engine when video codec factories of the new
1062// type are injected supporting the single codec Vp8. Check the returned codecs
1063// from the engine and that we will create a Vp8 encoder and decoder using the
1064// new factories.
1065TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1066 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001067 webrtc::MockVideoEncoderFactory* encoder_factory =
1068 new webrtc::MockVideoEncoderFactory();
1069 webrtc::MockVideoDecoderFactory* decoder_factory =
1070 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001071 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1072 rate_allocator_factory =
1073 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001074 EXPECT_CALL(*rate_allocator_factory,
1075 CreateVideoBitrateAllocatorProxy(Field(
1076 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001077 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001078 WebRtcVideoEngine engine(
1079 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001080 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001081 const webrtc::SdpVideoFormat vp8_format("VP8");
1082 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1083 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001084 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001085
1086 // Verify the codecs from the engine.
1087 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001088 // Verify default codecs has been added correctly.
1089 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001090 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001091
1092 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001093 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001094 int vp8_associated_payload;
1095 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1096 &vp8_associated_payload));
1097 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1098
1099 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1100
1101 // RTX codec for RED.
1102 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1103 int red_associated_payload;
1104 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1105 &red_associated_payload));
1106 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1107
1108 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1109
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001110 int associated_payload_type;
1111 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1112 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1113 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1114 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001115 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1116 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001117
1118 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001119 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1120 codec_info.is_hardware_accelerated = false;
1121 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001122 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001123 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001124 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001125 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001126 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001128 .WillOnce(
1129 ::testing::DoAll(::testing::InvokeWithoutArgs(
1130 [&encoder_created]() { encoder_created.Set(); }),
1131 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001132
1133 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001134 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001135 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001136 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137
1138 // Create a call.
1139 webrtc::RtcEventLogNullImpl event_log;
1140 std::unique_ptr<webrtc::Call> call(
1141 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1142
1143 // Create send channel.
1144 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001145 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001146 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1147 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001148 cricket::VideoSendParameters send_parameters;
1149 send_parameters.codecs.push_back(engine_codecs.at(0));
1150 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1151 send_channel->OnReadyToSend(true);
1152 EXPECT_TRUE(
1153 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1154 EXPECT_TRUE(send_channel->SetSend(true));
1155
Niels Möller4db138e2018-04-19 09:04:13 +02001156 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001157 webrtc::test::FrameForwarder frame_forwarder;
1158 cricket::FakeFrameSource frame_source(1280, 720,
1159 rtc::kNumMicrosecsPerSec / 30);
1160 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001161 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001162 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001163 encoder_created.Wait(kTimeout);
1164
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001165 // Create recv channel.
1166 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001167 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001168 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1169 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001170 cricket::VideoRecvParameters recv_parameters;
1171 recv_parameters.codecs.push_back(engine_codecs.at(0));
1172 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1173 EXPECT_TRUE(recv_channel->AddRecvStream(
1174 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1175
1176 // Remove streams previously added to free the encoder and decoder instance.
1177 EXPECT_CALL(*encoder_factory, Die());
1178 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001179 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001180 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1181 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1182}
1183
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001184// Test behavior when decoder factory fails to create a decoder (returns null).
1185TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1186 // |engine| take ownership of the factories.
1187 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001188 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001189 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001190 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001191 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1192 rate_allocator_factory =
1193 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001194 WebRtcVideoEngine engine(
1195 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001196 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001197 const webrtc::SdpVideoFormat vp8_format("VP8");
1198 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1199 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001200 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001201
1202 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001203 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1204 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001205
1206 // Create a call.
1207 webrtc::RtcEventLogNullImpl event_log;
1208 std::unique_ptr<webrtc::Call> call(
1209 webrtc::Call::Create(webrtc::Call::Config(&event_log)));
1210
1211 // Create recv channel.
1212 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001213 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001214 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1215 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001216 cricket::VideoRecvParameters recv_parameters;
1217 recv_parameters.codecs.push_back(engine.codecs().front());
1218 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1219 EXPECT_TRUE(recv_channel->AddRecvStream(
1220 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1221
1222 // Remove streams previously added to free the encoder and decoder instance.
1223 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1224}
1225
eladalonf1841382017-06-12 01:16:46 -07001226TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001227 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001228 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001229 std::unique_ptr<VideoMediaChannel> channel(
1230 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001231 ASSERT_TRUE(
1232 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1233 cricket::VideoCodec codec = GetEngineCodec("VP8");
1234 cricket::VideoSendParameters parameters;
1235 parameters.codecs.push_back(codec);
1236 channel->OnReadyToSend(true);
1237 channel->SetSend(true);
1238 ASSERT_TRUE(channel->SetSendParameters(parameters));
1239
Niels Möller805a27e2019-01-21 12:21:27 +01001240 webrtc::test::FrameForwarder frame_forwarder;
1241 cricket::FakeFrameSource frame_source(1280, 720,
1242 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001243 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001244 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001245
Niels Möller805a27e2019-01-21 12:21:27 +01001246 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001247 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001248 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001249 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001250
Niels Möller805a27e2019-01-21 12:21:27 +01001251 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1252 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001253 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001254 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001255
1256 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001257 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1258 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001259 // Change to screen content, recreate encoder. For the simulcast encoder
1260 // adapter case, this will result in two calls since InitEncode triggers a
1261 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001262 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001263 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001264 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001265
Niels Möller805a27e2019-01-21 12:21:27 +01001266 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1267 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001268 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001269 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001270
1271 options.is_screencast.emplace(false);
1272 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001273 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001274 // Change back to regular video content, update encoder. Also change
1275 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001276 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001277 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001278 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001279 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001280
1281 // Remove stream previously added to free the external encoder instance.
1282 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001283 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001284}
1285
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001286class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001287 protected:
1288 WebRtcVideoChannelBaseTest()
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001289 : video_bitrate_allocator_factory_(
1290 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1291 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1292 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001293
1294 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001295 // One testcase calls SetUp in a loop, only create call_ once.
1296 if (!call_) {
1297 call_.reset(webrtc::Call::Create(webrtc::Call::Config(&event_log_)));
1298 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001299 cricket::MediaConfig media_config;
1300 // Disabling cpu overuse detection actually disables quality scaling too; it
1301 // implies DegradationPreference kMaintainResolution. Automatic scaling
1302 // needs to be disabled, otherwise, tests which check the size of received
1303 // frames become flaky.
1304 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001305 channel_.reset(
1306 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1307 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001308 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001309 channel_->OnReadyToSend(true);
1310 EXPECT_TRUE(channel_.get() != NULL);
1311 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001312 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001313 cricket::VideoRecvParameters parameters;
1314 parameters.codecs = engine_.codecs();
1315 channel_->SetRecvParameters(parameters);
1316 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001317 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1318 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1319 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1320 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001321 }
1322
1323 // Utility method to setup an additional stream to send and receive video.
1324 // Used to test send and recv between two streams.
1325 void SetUpSecondStream() {
1326 SetUpSecondStreamWithNoRecv();
1327 // Setup recv for second stream.
1328 EXPECT_TRUE(channel_->AddRecvStream(
1329 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1330 // Make the second renderer available for use by a new stream.
1331 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1332 }
1333 // Setup an additional stream just to send video. Defer add recv stream.
1334 // This is required if you want to test unsignalled recv of video rtp packets.
1335 void SetUpSecondStreamWithNoRecv() {
1336 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001337 EXPECT_TRUE(
1338 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001339 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001340 EXPECT_FALSE(
1341 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 EXPECT_TRUE(channel_->AddSendStream(
1343 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1344 // We dont add recv for the second stream.
1345
1346 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001347 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001348 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001349 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001350 }
Yves Gerey665174f2018-06-19 15:03:05 +02001351 virtual void TearDown() { channel_.reset(); }
1352 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001353
1354 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001355 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1356 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001357
1358 bool sending = channel_->sending();
1359 bool success = SetSend(false);
1360 if (success) {
1361 cricket::VideoSendParameters parameters;
1362 parameters.codecs.push_back(codec);
1363 success = channel_->SetSendParameters(parameters);
1364 }
1365 if (success) {
1366 success = SetSend(sending);
1367 }
1368 return success;
1369 }
Yves Gerey665174f2018-06-19 15:03:05 +02001370 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001371 void SendFrame() {
1372 if (frame_forwarder_2_) {
1373 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001374 }
Niels Möller805a27e2019-01-21 12:21:27 +01001375 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001376 }
1377 bool WaitAndSendFrame(int wait_ms) {
1378 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001379 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001380 return ret;
1381 }
Yves Gerey665174f2018-06-19 15:03:05 +02001382 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001383 int NumRtpBytes(uint32_t ssrc) {
1384 return network_interface_.NumRtpBytes(ssrc);
1385 }
Yves Gerey665174f2018-06-19 15:03:05 +02001386 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001387 int NumRtpPackets(uint32_t ssrc) {
1388 return network_interface_.NumRtpPackets(ssrc);
1389 }
Yves Gerey665174f2018-06-19 15:03:05 +02001390 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1392 return network_interface_.GetRtpPacket(index);
1393 }
1394 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001395 webrtc::RTPHeader header;
1396 EXPECT_TRUE(ParseRtpPacket(p, &header));
1397 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001398 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001399
Niels Möller6557d0c2018-04-11 15:18:34 +02001400 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001401 webrtc::RTPHeader* header) {
1402 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1403 webrtc::RtpHeaderParser::Create());
1404 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001405 }
1406
1407 // Tests that we can send and receive frames.
1408 void SendAndReceive(const cricket::VideoCodec& codec) {
1409 EXPECT_TRUE(SetOneCodec(codec));
1410 EXPECT_TRUE(SetSend(true));
1411 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1412 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001413 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001414 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1415 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1416 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1417 }
1418
1419 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001420 int duration_sec,
1421 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001422 EXPECT_TRUE(SetOneCodec(codec));
1423 EXPECT_TRUE(SetSend(true));
1424 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1425 EXPECT_EQ(0, renderer_.num_rendered_frames());
1426 for (int i = 0; i < duration_sec; ++i) {
1427 for (int frame = 1; frame <= fps; ++frame) {
1428 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1429 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1430 }
1431 }
1432 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1433 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1434 }
1435
Niels Möller6557d0c2018-04-11 15:18:34 +02001436 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1437 cricket::VideoMediaInfo info;
1438 EXPECT_TRUE(channel_->GetStats(&info));
1439 return info.senders[i];
1440 }
1441
1442 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1443 cricket::VideoMediaInfo info;
1444 EXPECT_TRUE(channel_->GetStats(&info));
1445 return info.receivers[i];
1446 }
1447
1448 // Two streams one channel tests.
1449
1450 // Tests that we can send and receive frames.
1451 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1452 SetUpSecondStream();
1453 // Test sending and receiving on first stream.
1454 SendAndReceive(codec);
1455 // Test sending and receiving on second stream.
1456 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1457 EXPECT_GT(NumRtpPackets(), 0);
1458 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1459 }
1460
1461 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1462 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001463 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001464 return engine_codec;
1465 }
1466 // This point should never be reached.
1467 ADD_FAILURE() << "Unrecognized codec name: " << name;
1468 return cricket::VideoCodec();
1469 }
1470
1471 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1472
1473 cricket::StreamParams DefaultSendStreamParams() {
1474 return cricket::StreamParams::CreateLegacy(kSsrc);
1475 }
1476
1477 webrtc::RtcEventLogNullImpl event_log_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001478 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001479 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1480 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001481 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001482
1483 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1484 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1485 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1486
Niels Möller6557d0c2018-04-11 15:18:34 +02001487 std::unique_ptr<WebRtcVideoChannel> channel_;
1488 cricket::FakeNetworkInterface network_interface_;
1489 cricket::FakeVideoRenderer renderer_;
1490
1491 // Used by test cases where 2 streams are run on the same channel.
1492 cricket::FakeVideoRenderer renderer2_;
1493};
1494
1495// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001496TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001497 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001498 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001499 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1500 EXPECT_FALSE(channel_->sending());
1501 EXPECT_TRUE(SetSend(true));
1502 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001503 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001504 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1505 EXPECT_TRUE(SetSend(false));
1506 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001507}
Niels Möller6557d0c2018-04-11 15:18:34 +02001508
1509// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001510TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001511 EXPECT_FALSE(channel_->sending());
1512 EXPECT_FALSE(SetSend(true));
1513 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001514}
Niels Möller6557d0c2018-04-11 15:18:34 +02001515
1516// Test that we properly set the send and recv buffer sizes by the time
1517// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001518TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001519 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1520 EXPECT_TRUE(SetSend(true));
1521 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001522 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001523}
1524
Johannes Kron5a0665b2019-04-08 10:35:50 +02001525// Test that we properly set the send and recv buffer sizes when overriding
1526// via field trials.
1527TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1528 // Set field trial to override the default recv buffer size, and then re-run
1529 // setup where the interface is created and configured.
1530 const int kCustomRecvBufferSize = 123456;
1531 webrtc::test::ScopedFieldTrials field_trial(
1532 "WebRTC-IncreasedReceivebuffers/123456/");
1533 SetUp();
1534
1535 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1536 EXPECT_TRUE(SetSend(true));
1537 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1538 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1539}
1540
1541// Test that we properly set the send and recv buffer sizes when overriding
1542// via field trials with suffix.
1543TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1544 // Set field trial to override the default recv buffer size, and then re-run
1545 // setup where the interface is created and configured.
1546 const int kCustomRecvBufferSize = 123456;
1547 webrtc::test::ScopedFieldTrials field_trial(
1548 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1549 SetUp();
1550
1551 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1552 EXPECT_TRUE(SetSend(true));
1553 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1554 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1555}
1556
1557// Test that we properly set the send and recv buffer sizes when overriding
1558// via field trials that don't make any sense.
1559TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1560 // Set bogus field trial values to override the default recv buffer size, and
1561 // then re-run setup where the interface is created and configured. The
1562 // default value should still be used.
1563
1564 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1565 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1566 field_trial_string += group;
1567 field_trial_string += "/";
1568 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1569 SetUp();
1570
1571 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1572 EXPECT_TRUE(SetSend(true));
1573 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1574 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1575 }
1576}
1577
Niels Möller6557d0c2018-04-11 15:18:34 +02001578// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001579TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001580 const int kDurationSec = 3;
1581 const int kFps = 10;
1582 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1583
1584 cricket::VideoMediaInfo info;
1585 EXPECT_TRUE(channel_->GetStats(&info));
1586
1587 ASSERT_EQ(1U, info.senders.size());
1588 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1589 // For webrtc, bytes_sent does not include the RTP header length.
1590 EXPECT_GT(info.senders[0].bytes_sent, 0);
1591 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1592 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1593 ASSERT_TRUE(info.senders[0].codec_payload_type);
1594 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1595 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1596 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1597 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1598 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1599 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1600 EXPECT_GT(info.senders[0].framerate_input, 0);
1601 EXPECT_GT(info.senders[0].framerate_sent, 0);
1602
1603 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1604 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1605 info.send_codecs[DefaultCodec().id]);
1606
1607 ASSERT_EQ(1U, info.receivers.size());
1608 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1609 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1610 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1611 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1612 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
1613 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
1614 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001615 EXPECT_EQ(0, info.receivers[0].packets_lost);
1616 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1617 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1618 EXPECT_EQ(0, info.receivers[0].firs_sent);
1619 EXPECT_EQ(0, info.receivers[0].plis_sent);
1620 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1621 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1622 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1623 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1624 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1625 EXPECT_GT(info.receivers[0].framerate_output, 0);
1626
1627 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1628 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1629 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001630}
Niels Möller6557d0c2018-04-11 15:18:34 +02001631
1632// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001633TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001634 cricket::FakeVideoRenderer renderer1, renderer2;
1635 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1636 cricket::VideoSendParameters parameters;
1637 parameters.codecs.push_back(DefaultCodec());
1638 parameters.conference_mode = true;
1639 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1640 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001641 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1642 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001643 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1644 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1645 EXPECT_EQ(0, renderer1.num_rendered_frames());
1646 EXPECT_EQ(0, renderer2.num_rendered_frames());
1647 std::vector<uint32_t> ssrcs;
1648 ssrcs.push_back(1);
1649 ssrcs.push_back(2);
1650 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001651 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001652 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1653 kTimeout);
1654 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1655 kTimeout);
1656
1657 EXPECT_TRUE(channel_->SetSend(false));
1658
1659 cricket::VideoMediaInfo info;
1660 EXPECT_TRUE(channel_->GetStats(&info));
1661 ASSERT_EQ(1U, info.senders.size());
1662 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1663 // For webrtc, bytes_sent does not include the RTP header length.
1664 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
1665 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1666 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1667 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1668
1669 ASSERT_EQ(2U, info.receivers.size());
1670 for (size_t i = 0; i < info.receivers.size(); ++i) {
1671 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1672 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
1673 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001674 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001675 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1676 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1677 }
srtee0c2eea2017-12-15 17:44:33 +01001678}
Niels Möller6557d0c2018-04-11 15:18:34 +02001679
1680// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001681TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001682 // Normal setup; note that we set the SSRC explicitly to ensure that
1683 // it will come first in the senders map.
1684 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1685 cricket::VideoSendParameters parameters;
1686 parameters.codecs.push_back(DefaultCodec());
1687 parameters.conference_mode = true;
1688 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001689 EXPECT_TRUE(
1690 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001691 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1692 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001693 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1695 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1696
1697 // Add an additional capturer, and hook up a renderer to receive it.
1698 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001699 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001700 const int kTestWidth = 160;
1701 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001702 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1703 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_TRUE(
1705 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001706 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001707 EXPECT_TRUE(
1708 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001709 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001710 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001711 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1712 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001713
1714 // Get stats, and make sure they are correct for two senders. We wait until
1715 // the number of expected packets have been sent to avoid races where we
1716 // check stats before it has been updated.
1717 cricket::VideoMediaInfo info;
1718 for (uint32_t i = 0; i < kTimeout; ++i) {
1719 rtc::Thread::Current()->ProcessMessages(1);
1720 EXPECT_TRUE(channel_->GetStats(&info));
1721 ASSERT_EQ(2U, info.senders.size());
1722 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1723 NumRtpPackets()) {
1724 // Stats have been updated for both sent frames, expectations can be
1725 // checked now.
1726 break;
1727 }
1728 }
1729 EXPECT_EQ(NumRtpPackets(),
1730 info.senders[0].packets_sent + info.senders[1].packets_sent)
1731 << "Timed out while waiting for packet counts for all sent packets.";
1732 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1733 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1734 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1735 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1736 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1737 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1738 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1739 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1740 // The capturer must be unregistered here as it runs out of it's scope next.
1741 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001742}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001743
Niels Möller6557d0c2018-04-11 15:18:34 +02001744// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001745TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001746 cricket::VideoSendParameters parameters;
1747 parameters.codecs.push_back(DefaultCodec());
1748 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1749 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1750 parameters.max_bandwidth_bps = 128 * 1024;
1751 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001752}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001753
Niels Möller6557d0c2018-04-11 15:18:34 +02001754// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001755TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001756 EXPECT_TRUE(SetDefaultCodec());
1757 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001758 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001759 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001760 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001761 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001762 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1763 EXPECT_EQ(kSsrc, header.ssrc);
1764
Niels Möller6557d0c2018-04-11 15:18:34 +02001765 // Packets are being paced out, so these can mismatch between the first and
1766 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001767 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1768 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001769 EXPECT_EQ(1, NumSentSsrcs());
1770 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1771 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001772}
Niels Möller6557d0c2018-04-11 15:18:34 +02001773
1774// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001775TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 // Remove stream added in Setup.
1777 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1778 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001779 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001780 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001781 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001782 EXPECT_TRUE(SetSend(true));
1783 EXPECT_TRUE(WaitAndSendFrame(0));
1784 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001785 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001787 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1788 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 // Packets are being paced out, so these can mismatch between the first and
1790 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001791 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1792 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001793 EXPECT_EQ(1, NumSentSsrcs());
1794 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1795 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001796}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001797
Niels Möller6557d0c2018-04-11 15:18:34 +02001798// Test that we can set the default video renderer before and after
1799// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001800TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001801 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1802 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001803
1804 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1805 rtc::SetBE32(packet1.data() + 8, kSsrc);
1806 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1807 EXPECT_TRUE(SetDefaultCodec());
1808 EXPECT_TRUE(SetSend(true));
1809 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001810 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001811 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001812 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001813 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001814}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001815
Niels Möller6557d0c2018-04-11 15:18:34 +02001816// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001817TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001818 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1819 EXPECT_TRUE(SetSend(true));
1820 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001821 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001822 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1823 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001824 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001825 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001826 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1827 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001828 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1829 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001830
1831 // Remove the send stream that was added during Setup.
1832 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1833 int rtp_packets = NumRtpPackets();
1834
Niels Möller6557d0c2018-04-11 15:18:34 +02001835 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001836 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001837 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001838 EXPECT_EQ(rtp_packets, NumRtpPackets());
1839 // Wait 30ms to guarantee the engine does not drop the frame.
1840 EXPECT_TRUE(WaitAndSendFrame(30));
1841 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1842
1843 last_packet = NumRtpPackets() - 1;
1844 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001845 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1846 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001847}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001848
Niels Möller6557d0c2018-04-11 15:18:34 +02001849// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001850TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001851 cricket::FakeVideoRenderer renderer1, renderer2;
1852 EXPECT_TRUE(SetDefaultCodec());
1853 cricket::VideoSendParameters parameters;
1854 parameters.codecs.push_back(DefaultCodec());
1855 parameters.conference_mode = true;
1856 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1857 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001858 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1859 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001860 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1861 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1862 EXPECT_EQ(0, renderer1.num_rendered_frames());
1863 EXPECT_EQ(0, renderer2.num_rendered_frames());
1864 std::vector<uint32_t> ssrcs;
1865 ssrcs.push_back(1);
1866 ssrcs.push_back(2);
1867 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001868 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001869 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1870 kTimeout);
1871 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1872 kTimeout);
1873
1874 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1875 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1876 EXPECT_EQ(kVideoWidth, renderer1.width());
1877 EXPECT_EQ(kVideoHeight, renderer1.height());
1878 EXPECT_EQ(kVideoWidth, renderer2.width());
1879 EXPECT_EQ(kVideoHeight, renderer2.height());
1880 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1881 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001882}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001883
Niels Möller6557d0c2018-04-11 15:18:34 +02001884// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001885TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001886 using cricket::VideoCodec;
1887 using cricket::VideoOptions;
1888 using cricket::VideoFormat;
1889 using cricket::FOURCC_I420;
1890
1891 VideoCodec codec = DefaultCodec();
1892 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1893 EXPECT_TRUE(SetOneCodec(codec));
1894 EXPECT_TRUE(SetSend(true));
1895 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1896 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001897 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001898 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001899
1900 webrtc::test::FrameForwarder frame_forwarder;
1901 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1902 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001903
1904 // TODO(nisse): This testcase fails if we don't configure
1905 // screencast. It's unclear why, I see nothing obvious in this
1906 // test which is related to screencast logic.
1907 VideoOptions video_options;
1908 video_options.is_screencast = true;
1909 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1910
Niels Möller6557d0c2018-04-11 15:18:34 +02001911 int captured_frames = 1;
1912 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001913 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001914 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001915 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1916
Niels Möller6557d0c2018-04-11 15:18:34 +02001917 ++captured_frames;
1918 // Wait until frame of right size is captured.
1919 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001920 480 == renderer_.width() &&
1921 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001922 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001923 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001924 EXPECT_EQ(480, renderer_.width());
1925 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001926 captured_frames = renderer_.num_rendered_frames() + 1;
1927 EXPECT_FALSE(renderer_.black_frame());
1928 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1929 // Make sure a black frame is generated within the specified timeout.
1930 // The black frame should be the resolution of the previous frame to
1931 // prevent expensive encoder reconfigurations.
1932 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001933 480 == renderer_.width() &&
1934 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001935 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001936 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001937 EXPECT_EQ(480, renderer_.width());
1938 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001939 EXPECT_TRUE(renderer_.black_frame());
1940
1941 // The black frame has the same timestamp as the next frame since it's
1942 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1943 // not render a frame with the same timestamp so capture another frame
1944 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001945 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001946 }
srtee0c2eea2017-12-15 17:44:33 +01001947}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001948
Niels Möller6557d0c2018-04-11 15:18:34 +02001949// Tests that if SetVideoSend is called with a NULL capturer after the
1950// capturer was already removed, the application doesn't crash (and no black
1951// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001952TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001953 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1954 EXPECT_TRUE(SetSend(true));
1955 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1956 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001957 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001958 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1959 // Wait for one frame so they don't get dropped because we send frames too
1960 // tightly.
1961 rtc::Thread::Current()->ProcessMessages(30);
1962 // Remove the capturer.
1963 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1964
1965 // No capturer was added, so this SetVideoSend shouldn't do anything.
1966 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1967 rtc::Thread::Current()->ProcessMessages(300);
1968 // Verify no more frames were sent.
1969 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001970}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001971
Niels Möller6557d0c2018-04-11 15:18:34 +02001972// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001973TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001974 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1975 // interval time to avoid that.
1976 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1977 // interval time to avoid that.
1978 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001979 EXPECT_TRUE(
1980 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001981 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1982 cricket::VideoFormat capture_format(
1983 kVideoWidth, kVideoHeight,
1984 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
1985 // Set up additional stream 1.
1986 cricket::FakeVideoRenderer renderer1;
1987 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001988 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001989 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02001990 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01001991
1992 webrtc::test::FrameForwarder frame_forwarder1;
1993 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
1994 rtc::kNumMicrosecsPerSec / kFramerate);
1995
Niels Möller6557d0c2018-04-11 15:18:34 +02001996 // Set up additional stream 2.
1997 cricket::FakeVideoRenderer renderer2;
1998 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02001999 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002000 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002001 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002002 webrtc::test::FrameForwarder frame_forwarder2;
2003
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 // State for all the streams.
2005 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2006 // A limitation in the lmi implementation requires that SetVideoSend() is
2007 // called after SetOneCodec().
2008 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002009 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2010 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 EXPECT_TRUE(SetSend(true));
2012 // Test capturer associated with engine.
2013 const int kTestWidth = 160;
2014 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002015 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2016 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2017 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002018 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2019 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002020 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002021 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2022 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2023 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002024 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2025 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 // Successfully remove the capturer.
2027 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2028 // The capturers must be unregistered here as it runs out of it's scope
2029 // next.
2030 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2031 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002032}
Niels Möller6557d0c2018-04-11 15:18:34 +02002033
2034// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002035TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002036 // Remove the send stream that was added during Setup.
2037 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2038
2039 cricket::StreamParams empty;
2040 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002041 EXPECT_TRUE(
2042 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002043}
Niels Möller6557d0c2018-04-11 15:18:34 +02002044
2045// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002046TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002047 // Remove stream added in Setup. I.e. remove stream corresponding to default
2048 // channel.
2049 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002050 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002051 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2052 EXPECT_TRUE(channel_->AddSendStream(
2053 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2054 }
2055 // Delete one of the non default channel streams, let the destructor delete
2056 // the remaining ones.
2057 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2058 // Stream should already be deleted.
2059 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002060}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002061
eladalonf1841382017-06-12 01:16:46 -07002062TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002063 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002064}
2065
eladalonf1841382017-06-12 01:16:46 -07002066TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002067 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002068}
2069
eladalonf1841382017-06-12 01:16:46 -07002070TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002071 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002072}
2073
eladalonf1841382017-06-12 01:16:46 -07002074TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002075 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2076 // bitrates. This currently happens at <250k, and two streams sharing 300k
2077 // initially will use QVGA instead of VGA.
2078 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2079 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002080 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002081 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002082 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002083}
2084
philipele8ed8302019-07-03 11:53:48 +02002085TEST_F(WebRtcVideoChannelBaseTest, OnEncoderFailure) {
2086 cricket::VideoSendParameters parameters;
2087 parameters.codecs.push_back(GetEngineCodec("VP9"));
2088 parameters.codecs.push_back(GetEngineCodec("VP8"));
2089 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2090
2091 VideoCodec codec;
2092 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2093 EXPECT_EQ("VP9", codec.name);
2094
2095 // OnEncoderFailure will post a task to the worker thread (which is also
2096 // the current thread), hence the ProcessMessages call.
2097 channel_->OnEncoderFailure();
2098 rtc::Thread::Current()->ProcessMessages(30);
2099 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2100 EXPECT_EQ("VP8", codec.name);
2101
2102 // No other codec to fall back to, keep using VP8.
2103 channel_->OnEncoderFailure();
2104 rtc::Thread::Current()->ProcessMessages(30);
2105 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2106 EXPECT_EQ("VP8", codec.name);
2107}
2108
eladalonf1841382017-06-12 01:16:46 -07002109class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002110 public:
eladalonf1841382017-06-12 01:16:46 -07002111 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2112 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002113 : WebRtcVideoEngineTest(field_trials),
2114 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2115 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002116 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002117 encoder_factory_->AddSupportedVideoCodecType("VP8");
2118 encoder_factory_->AddSupportedVideoCodecType("VP9");
2119#if defined(WEBRTC_USE_H264)
2120 encoder_factory_->AddSupportedVideoCodecType("H264");
2121#endif
2122
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002123 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002124 channel_.reset(engine_.CreateMediaChannel(
2125 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2126 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002127 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002128 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002129 send_parameters_.codecs = engine_.codecs();
2130 recv_parameters_.codecs = engine_.codecs();
2131 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002132 }
2133
2134 protected:
2135 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002136 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002137 }
2138
2139 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002140 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002141 EXPECT_TRUE(channel_->AddSendStream(sp));
2142 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002143 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002144 EXPECT_EQ(num_streams + 1, streams.size());
2145 return streams[streams.size() - 1];
2146 }
2147
2148 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002149 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002150 }
2151
2152 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002153 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002154 }
2155
2156 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002157 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002158 EXPECT_TRUE(channel_->AddRecvStream(sp));
2159 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002160 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002161 EXPECT_EQ(num_streams + 1, streams.size());
2162 return streams[streams.size() - 1];
2163 }
2164
pbos@webrtc.org00873182014-11-25 14:03:34 +00002165 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2166 int expected_min_bitrate_bps,
2167 const char* start_bitrate_kbps,
2168 int expected_start_bitrate_bps,
2169 const char* max_bitrate_kbps,
2170 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002171 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2172 expected_start_bitrate_bps,
2173 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002174 auto& codecs = send_parameters_.codecs;
2175 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002176 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002177 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2178 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2179 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002180 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002181 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002182
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002183 void ExpectSetBitrateParameters(int min_bitrate_bps,
2184 int start_bitrate_bps,
2185 int max_bitrate_bps) {
2186 EXPECT_CALL(
2187 *fake_call_->GetMockTransportControllerSend(),
2188 SetSdpBitrateParameters(AllOf(
2189 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2190 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2191 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2192 }
2193
2194 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2195 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2196 SetSdpBitrateParameters(Field(
2197 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002198 }
2199
Johannes Kron9190b822018-10-29 11:22:05 +01002200 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2201 // For a caller, the answer will be applied in set remote description
2202 // where SetSendParameters() is called.
2203 EXPECT_TRUE(
2204 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2205 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2206 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2207 const webrtc::VideoSendStream::Config& config =
2208 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2209 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2210 }
2211
2212 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2213 // For a callee, the answer will be applied in set local description
2214 // where SetExtmapAllowMixed() and AddSendStream() are called.
2215 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2216 EXPECT_TRUE(
2217 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2218 const webrtc::VideoSendStream::Config& config =
2219 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2220 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2221 }
2222
isheriff6f8d6862016-05-26 11:24:55 -07002223 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002224 // Enable extension.
2225 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002226 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002227 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002228 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002229 FakeVideoSendStream* send_stream =
2230 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2231
2232 // Verify the send extension id.
2233 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2234 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002235 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002236 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002237 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002238 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2239 // receivers.
2240 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2241 ->GetConfig()
2242 .rtp.extensions.empty());
2243
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002244 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002245 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002246 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2247 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002248 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2249
2250 // Verify that adding receive RTP header extensions adds them for existing
2251 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002252 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002253 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002254 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2255 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002256 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002257 }
2258
isheriff6f8d6862016-05-26 11:24:55 -07002259 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002260 // Enable extension.
2261 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002262 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002263 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002264 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002265
2266 FakeVideoReceiveStream* recv_stream =
2267 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2268
2269 // Verify the recv extension id.
2270 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2271 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002272 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002273 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002274 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002275
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002276 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2277 // senders.
2278 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2279 ->GetConfig()
2280 .rtp.extensions.empty());
2281
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002282 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002283 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002284 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2285 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002286 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2287
2288 // Verify that adding receive RTP header extensions adds them for existing
2289 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002290 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002291 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002292 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2293 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002294 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002295 }
2296
Elad Alonfadb1812019-05-24 13:40:02 +02002297 void TestLossNotificationState(bool expect_lntf_enabled) {
2298 AssignDefaultCodec();
2299 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2300
2301 cricket::VideoSendParameters parameters;
2302 parameters.codecs = engine_.codecs();
2303 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2304 EXPECT_TRUE(channel_->SetSend(true));
2305
2306 // Send side.
2307 FakeVideoSendStream* send_stream =
2308 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2309 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2310
2311 // Receiver side.
2312 FakeVideoReceiveStream* recv_stream =
2313 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2314 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2315 }
2316
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002317 void TestExtensionFilter(const std::vector<std::string>& extensions,
2318 const std::string& expected_extension) {
2319 cricket::VideoSendParameters parameters = send_parameters_;
2320 int expected_id = -1;
2321 int id = 1;
2322 for (const std::string& extension : extensions) {
2323 if (extension == expected_extension)
2324 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002325 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002326 }
2327 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2328 FakeVideoSendStream* send_stream =
2329 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2330
2331 // Verify that only one of them has been set, and that it is the one with
2332 // highest priority (transport sequence number).
2333 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2334 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2335 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002336 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002337 }
2338
asapersson3c81a1a2017-06-14 05:52:21 -07002339 void TestDegradationPreference(bool resolution_scaling_enabled,
2340 bool fps_scaling_enabled);
2341
Erik Språngefbde372015-04-29 16:21:28 +02002342 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002343 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002344 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2345 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002346
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002347 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002348 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002349 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002350 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002351 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002352 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002353 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002354 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002355 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002356
Erik Språng143cec12015-04-28 10:01:41 +02002357 return fake_call_->GetVideoSendStreams().back();
2358 }
2359
Peter Boström2feafdb2015-09-09 14:32:14 +02002360 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2361 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002362 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002363 std::vector<uint32_t> ssrcs;
2364 std::vector<uint32_t> rtx_ssrcs;
2365 uint32_t num_streams = enabled ? 3 : 1;
2366 for (uint32_t i = 0; i < num_streams; ++i) {
2367 uint32_t ssrc = last_ssrc_ + i;
2368 ssrcs.push_back(ssrc);
2369 if (with_rtx) {
2370 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2371 }
Erik Språng143cec12015-04-28 10:01:41 +02002372 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002373 if (with_rtx) {
2374 return AddSendStream(
2375 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2376 }
2377 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002378 }
2379
perkjfa10b552016-10-02 23:45:26 -07002380 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002381 std::vector<FakeVideoSendStream*> streams =
2382 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002383 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002384 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002385 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002386 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002387 }
2388
perkjfa10b552016-10-02 23:45:26 -07002389 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002390 int stream_max,
2391 int expected_encoder_bitrate) {
2392 VideoSendParameters limited_send_params = send_parameters_;
2393 limited_send_params.max_bandwidth_bps = global_max;
2394 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002395 webrtc::RtpParameters parameters =
2396 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002397 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002398 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002399 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002400 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002401 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002402 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002403 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002404 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002405 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002406 }
2407
Åsa Persson55659812018-06-18 17:51:32 +02002408 // Values from kSimulcastConfigs in simulcast.cc.
2409 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2410 std::vector<webrtc::VideoStream> layers(3);
2411 layers[0].min_bitrate_bps = 30000;
2412 layers[0].target_bitrate_bps = 150000;
2413 layers[0].max_bitrate_bps = 200000;
2414 layers[1].min_bitrate_bps = 150000;
2415 layers[1].target_bitrate_bps = 500000;
2416 layers[1].max_bitrate_bps = 700000;
2417 layers[2].min_bitrate_bps = 600000;
2418 layers[2].target_bitrate_bps = 2500000;
2419 layers[2].max_bitrate_bps = 2500000;
2420 return layers;
2421 }
2422
Niels Möller805a27e2019-01-21 12:21:27 +01002423 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002424 std::unique_ptr<FakeCall> fake_call_;
2425 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002426 cricket::VideoSendParameters send_parameters_;
2427 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002428 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002429};
2430
eladalonf1841382017-06-12 01:16:46 -07002431TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002432 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002433 const std::string kSyncLabel = "AvSyncLabel";
2434
2435 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002436 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002437 EXPECT_TRUE(channel_->AddRecvStream(sp));
2438
Mirko Bonadeif859e552018-05-30 15:31:29 +02002439 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002440 EXPECT_EQ(kSyncLabel,
2441 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2442 << "SyncGroup should be set based on sync_label";
2443}
2444
eladalonf1841382017-06-12 01:16:46 -07002445TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002446 cricket::VideoSendParameters parameters;
2447 parameters.codecs = engine_.codecs();
2448 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002449 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002450 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002451 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002452
2453 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002454 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2455 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002456 FakeVideoSendStream* send_stream = AddSendStream(
2457 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2458
2459 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2460 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2461 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2462
2463 // Receiver side.
2464 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2465 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002466 EXPECT_FALSE(
2467 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002468 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002469 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002470 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002471 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002472 << "RTX should be mapped for the RED payload type";
2473
brandtr14742122017-01-27 04:53:07 -08002474 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002475}
2476
eladalonf1841382017-06-12 01:16:46 -07002477TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002478 // Setup one channel with an associated RTX stream.
2479 cricket::StreamParams params =
2480 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2481 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2482 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002483 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002484
2485 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2486 << "RTX should be mapped for all decoders/payload types.";
2487 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002488 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002489 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002490}
2491
eladalonf1841382017-06-12 01:16:46 -07002492TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002493 // Setup one channel without an associated RTX stream.
2494 cricket::StreamParams params =
2495 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2496 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002497 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002498}
2499
Johannes Kron9190b822018-10-29 11:22:05 +01002500// Test propagation of extmap allow mixed setting.
2501TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2502 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2503}
2504TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2505 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2506}
2507TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2508 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2509}
2510TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2511 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2512}
2513
eladalonf1841382017-06-12 01:16:46 -07002514TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002515 FakeVideoSendStream* send_stream =
2516 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2517 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2518
2519 FakeVideoReceiveStream* recv_stream =
2520 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2521 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002522}
2523
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002524// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002525TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002526 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002527}
isheriff6f8d6862016-05-26 11:24:55 -07002528
eladalonf1841382017-06-12 01:16:46 -07002529TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002530 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002531}
2532
2533// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002534TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002535 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002536}
isheriff6f8d6862016-05-26 11:24:55 -07002537
eladalonf1841382017-06-12 01:16:46 -07002538TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002539 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002540}
2541
eladalonf1841382017-06-12 01:16:46 -07002542TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002543 // Enable three redundant extensions.
2544 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002545 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2546 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2547 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2548 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002549}
2550
eladalonf1841382017-06-12 01:16:46 -07002551TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002552 // Enable two redundant extensions.
2553 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002554 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2555 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2556 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002557}
2558
stefanc1aeaf02015-10-15 07:26:07 -07002559// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002560TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002561 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002562}
eladalonf1841382017-06-12 01:16:46 -07002563TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002564 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002565}
2566
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002567// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002568TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002569 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002570}
eladalonf1841382017-06-12 01:16:46 -07002571TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002572 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002573}
2574
eladalonf1841382017-06-12 01:16:46 -07002575TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002576 const int kAbsSendTimeId = 1;
2577 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002578 send_parameters_.extensions.push_back(
2579 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2580 send_parameters_.extensions.push_back(
2581 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002582
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002583 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002584 FakeVideoSendStream* send_stream =
2585 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2586
2587 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002588 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002589
2590 // Setting the same extensions (even if in different order) shouldn't
2591 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002592 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002593 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002594
2595 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2596
2597 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002598 send_parameters_.extensions.resize(1);
2599 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002600
2601 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2602}
2603
eladalonf1841382017-06-12 01:16:46 -07002604TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002605 const int kTOffsetId = 1;
2606 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002607 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002608 recv_parameters_.extensions.push_back(
2609 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2610 recv_parameters_.extensions.push_back(
2611 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2612 recv_parameters_.extensions.push_back(
2613 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002614
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002615 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002616 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002617 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2618
2619 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002620 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002621
2622 // Setting the same extensions (even if in different order) shouldn't
2623 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002624 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002625 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002626
2627 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2628
2629 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002630 recv_parameters_.extensions.resize(1);
2631 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002632
2633 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2634}
2635
eladalonf1841382017-06-12 01:16:46 -07002636TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002637 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002638 const int kUnsupportedId = 1;
2639 const int kTOffsetId = 2;
2640
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002641 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002642 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002643 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002644 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002646 FakeVideoSendStream* send_stream =
2647 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2648
2649 // Only timestamp offset extension is set to send stream,
2650 // unsupported rtp extension is ignored.
2651 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002652 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2653 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002654}
2655
eladalonf1841382017-06-12 01:16:46 -07002656TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002657 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002658 const int kUnsupportedId = 1;
2659 const int kTOffsetId = 2;
2660
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002661 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002662 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002663 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002664 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002665 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002666 FakeVideoReceiveStream* recv_stream =
2667 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2668
2669 // Only timestamp offset extension is set to receive stream,
2670 // unsupported rtp extension is ignored.
2671 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002672 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2673 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002674}
2675
eladalonf1841382017-06-12 01:16:46 -07002676TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002677 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002678 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002679 send_parameters_.extensions.push_back(
2680 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002681 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002682 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2683 }
2684}
2685
eladalonf1841382017-06-12 01:16:46 -07002686TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002687 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002688 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002689 recv_parameters_.extensions.push_back(
2690 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002691 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002692 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2693 }
2694}
2695
eladalonf1841382017-06-12 01:16:46 -07002696TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002697 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002698 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002699 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002700 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002701 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002702 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002703
2704 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002705 send_parameters_.extensions.clear();
2706 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002707 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002708 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2709 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002710}
2711
eladalonf1841382017-06-12 01:16:46 -07002712TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002713 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002714 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002715 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002716 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002717 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002718 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002719
2720 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002721 recv_parameters_.extensions.clear();
2722 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002723 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002724 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2725 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002726}
2727
eladalonf1841382017-06-12 01:16:46 -07002728TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002729 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002730 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002731}
2732
eladalonf1841382017-06-12 01:16:46 -07002733TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002734 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002735 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002736}
2737
eladalonf1841382017-06-12 01:16:46 -07002738TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002739 FakeVideoReceiveStream* stream = AddRecvStream();
2740 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002741}
2742
eladalonf1841382017-06-12 01:16:46 -07002743TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002744 FakeVideoReceiveStream* stream = AddRecvStream();
2745 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2746}
2747
eladalonf1841382017-06-12 01:16:46 -07002748TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002749 FakeVideoReceiveStream* stream = AddRecvStream();
2750 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2751
Peter Boström126c03e2015-05-11 12:48:12 +02002752 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002753 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002754 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002755 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2756 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002757 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002758 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2759
2760 // Verify that REMB is turned on when setting default codecs since the
2761 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002762 parameters.codecs = engine_.codecs();
2763 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002764 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002765 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002766}
2767
eladalonf1841382017-06-12 01:16:46 -07002768TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002769 FakeVideoReceiveStream* stream = AddRecvStream();
2770 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2771
2772 // Verify that transport cc feedback is turned off when send(!) codecs without
2773 // transport cc feedback are set.
2774 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002775 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002776 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2777 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2778 stream = fake_call_->GetVideoReceiveStreams()[0];
2779 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2780
2781 // Verify that transport cc feedback is turned on when setting default codecs
2782 // since the default codecs have transport cc feedback enabled.
2783 parameters.codecs = engine_.codecs();
2784 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2785 stream = fake_call_->GetVideoReceiveStreams()[0];
2786 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2787}
2788
Elad Alonfadb1812019-05-24 13:40:02 +02002789TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2790 TestLossNotificationState(false);
2791}
2792
2793TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2794 RTC_DCHECK(!override_field_trials_);
2795 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2796 "WebRTC-RtcpLossNotification/Enabled/");
2797 SetUp();
2798 TestLossNotificationState(true);
2799}
2800
2801TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2802 RTC_DCHECK(!override_field_trials_);
2803 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2804 "WebRTC-RtcpLossNotification/Enabled/");
2805 SetUp();
2806
2807 AssignDefaultCodec();
2808 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2809
2810 {
2811 cricket::VideoSendParameters parameters;
2812 parameters.codecs = engine_.codecs();
2813 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2814 EXPECT_TRUE(channel_->SetSend(true));
2815 }
2816
2817 // Start with LNTF enabled.
2818 FakeVideoSendStream* send_stream =
2819 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2820 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2821 FakeVideoReceiveStream* recv_stream =
2822 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2823 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2824
2825 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2826 cricket::VideoSendParameters parameters;
2827 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2828 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2829 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2830 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2831 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2832 send_stream = fake_call_->GetVideoSendStreams()[0];
2833 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2834
2835 // Setting the default codecs again, including VP8, turns LNTF back on.
2836 parameters.codecs = engine_.codecs();
2837 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2838 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2839 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2840 send_stream = fake_call_->GetVideoSendStreams()[0];
2841 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2842}
2843
eladalonf1841382017-06-12 01:16:46 -07002844TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002845 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002846 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002847
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002848 cricket::VideoSendParameters parameters;
2849 parameters.codecs = engine_.codecs();
2850 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002851 EXPECT_TRUE(channel_->SetSend(true));
2852
2853 // Send side.
2854 FakeVideoSendStream* send_stream =
2855 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2856 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2857
2858 // Receiver side.
2859 FakeVideoReceiveStream* recv_stream =
2860 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2861 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2862
2863 // Nack history size should match between sender and receiver.
2864 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2865 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002866}
2867
eladalonf1841382017-06-12 01:16:46 -07002868TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002869 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002870 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002871
2872 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2873 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2874
2875 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002876 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002877 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002878 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2879 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002880 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2881 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2882 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002883 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2884
Peter Boström67c9df72015-05-11 14:34:58 +02002885 // Verify that NACK is turned on when setting default codecs since the
2886 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002887 parameters.codecs = engine_.codecs();
2888 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002889 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2890 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2891 send_stream = fake_call_->GetVideoSendStreams()[0];
2892 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002893}
2894
Peter Boströme7ba0862016-03-12 00:02:28 +01002895// This test verifies that new frame sizes reconfigures encoders even though not
2896// (yet) sending. The purpose of this is to permit encoding as quickly as
2897// possible once we start sending. Likely the frames being input are from the
2898// same source that will be sent later, which just means that we're ready
2899// earlier.
eladalonf1841382017-06-12 01:16:46 -07002900TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002901 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002902 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002903 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2904 channel_->SetSend(false);
2905
2906 FakeVideoSendStream* stream = AddSendStream();
2907
perkjfa10b552016-10-02 23:45:26 -07002908 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002909 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002910 EXPECT_EQ(0u, streams[0].width);
2911 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002912
Niels Möller805a27e2019-01-21 12:21:27 +01002913 webrtc::test::FrameForwarder frame_forwarder;
2914 cricket::FakeFrameSource frame_source(1280, 720,
2915 rtc::kNumMicrosecsPerSec / 30);
2916
2917 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2918 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002919
2920 // Frame entered, should be reconfigured to new dimensions.
2921 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002922 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2923 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002924
Niels Möllerff40b142018-04-09 08:49:14 +02002925 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002926}
2927
eladalonf1841382017-06-12 01:16:46 -07002928TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002929 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002930 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002931 cricket::VideoSendParameters parameters;
2932 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002933 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002934 AddSendStream();
2935
Niels Möller805a27e2019-01-21 12:21:27 +01002936 webrtc::test::FrameForwarder frame_forwarder;
2937 cricket::FakeFrameSource frame_source(1280, 720,
2938 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002939 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002940 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002941 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2942 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002943
2944 EXPECT_TRUE(channel_->SetSend(true));
2945
Niels Möller805a27e2019-01-21 12:21:27 +01002946 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002947 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2948 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2949
2950 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2951
2952 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002953 webrtc::VideoEncoderConfig encoder_config =
2954 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002955 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002956 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002957 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002958 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2959 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002960 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2961 << "Non-screenshare shouldn't use min-transmit bitrate.";
2962
Niels Möllerff40b142018-04-09 08:49:14 +02002963 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002964 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002965 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002966 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002967 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2968 &frame_forwarder));
2969 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002970 // Send stream recreated after option change.
2971 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2972 send_stream = fake_call_->GetVideoSendStreams().front();
2973 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002974
2975 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002976 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002977 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002978 encoder_config.content_type);
2979 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2980 encoder_config.min_transmit_bitrate_bps);
2981
perkjfa10b552016-10-02 23:45:26 -07002982 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002983 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2984 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002985 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002986 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002987}
2988
eladalonf1841382017-06-12 01:16:46 -07002989TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002990 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002991 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002992 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002993 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002994
2995 AddSendStream();
nisse05103312016-03-16 02:22:50 -07002996 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002997 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002998 webrtc::test::FrameForwarder frame_forwarder;
2999 cricket::FakeFrameSource frame_source(1280, 720,
3000 rtc::kNumMicrosecsPerSec / 30);
3001 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003002 EXPECT_TRUE(channel_->SetSend(true));
3003
Niels Möller805a27e2019-01-21 12:21:27 +01003004 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003005 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3006 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3007
perkj26091b12016-09-01 01:17:40 -07003008 webrtc::VideoEncoderConfig encoder_config =
3009 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003010
3011 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003012 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003013 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003014 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003015
3016 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3017 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003018 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003019 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003020 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003021
Niels Möllerff40b142018-04-09 08:49:14 +02003022 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003023}
3024
eladalonf1841382017-06-12 01:16:46 -07003025TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003026 FakeVideoSendStream* stream = AddSendStream();
3027 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3028}
3029
eladalonf1841382017-06-12 01:16:46 -07003030TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003031 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003032 media_config.video.suspend_below_min_bitrate = true;
3033
Sebastian Jansson84848f22018-11-16 10:40:36 +01003034 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003035 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3036 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003037 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003038
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003039 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003040
3041 FakeVideoSendStream* stream = AddSendStream();
3042 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3043
nisse0db023a2016-03-01 04:29:59 -08003044 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003045 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003046 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3047 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003048 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003049
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003050 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003051
nisse0db023a2016-03-01 04:29:59 -08003052 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003053 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3054}
3055
eladalonf1841382017-06-12 01:16:46 -07003056TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003057 FakeVideoSendStream* stream = AddSendStream();
3058 webrtc::VideoCodecVP8 vp8_settings;
3059 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3060 EXPECT_TRUE(vp8_settings.denoisingOn);
3061}
3062
eladalonf1841382017-06-12 01:16:46 -07003063TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003064 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003065 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003066 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003067
Peter Boström2feafdb2015-09-09 14:32:14 +02003068 // Single-stream settings should apply with RTX as well (verifies that we
3069 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3070 // both RTX and regular SSRCs).
3071 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003072
Niels Möller805a27e2019-01-21 12:21:27 +01003073 webrtc::test::FrameForwarder frame_forwarder;
3074 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003075 channel_->SetSend(true);
3076
Niels Möller805a27e2019-01-21 12:21:27 +01003077 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003078
pbos4cba4eb2015-10-26 11:18:18 -07003079 webrtc::VideoCodecVP8 vp8_settings;
3080 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3081 EXPECT_TRUE(vp8_settings.denoisingOn)
3082 << "VP8 denoising should be on by default.";
3083
Niels Möller805a27e2019-01-21 12:21:27 +01003084 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003085
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003086 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3087 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003088 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3089 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003090
Niels Möller805a27e2019-01-21 12:21:27 +01003091 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003092
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003093 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3094 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003095 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3096 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3097
Niels Möllerff40b142018-04-09 08:49:14 +02003098 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003099 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003100 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003101 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003102 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003103
Mirko Bonadeif859e552018-05-30 15:31:29 +02003104 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003105 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3106 // Autmatic resize off when using simulcast.
3107 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3108 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3109
3110 // In screen-share mode, denoising is forced off and simulcast disabled.
nisse05103312016-03-16 02:22:50 -07003111 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003112 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003113 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003114
Niels Möller805a27e2019-01-21 12:21:27 +01003115 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003116
Mirko Bonadeif859e552018-05-30 15:31:29 +02003117 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003118 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3119 EXPECT_FALSE(vp8_settings.denoisingOn);
3120 // Resizing and frame dropping always off for screen sharing.
3121 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3122 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3123
Niels Möller805a27e2019-01-21 12:21:27 +01003124 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003125
3126 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3127 EXPECT_FALSE(vp8_settings.denoisingOn);
3128 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3129 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3130
Niels Möllerff40b142018-04-09 08:49:14 +02003131 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003132}
3133
deadbeef119760a2016-04-04 11:43:27 -07003134// Test that setting the same options doesn't result in the encoder being
3135// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003136TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003137 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003138 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003139
perkjfa10b552016-10-02 23:45:26 -07003140 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003141 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003142 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003143 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3144 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3145
Niels Möller805a27e2019-01-21 12:21:27 +01003146 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3147 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3148 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003149 // Expect 1 reconfigurations at this point from the initial configuration.
3150 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003151
3152 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003153 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003154 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3155
3156 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003157 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003158 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003159 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3160
Niels Möllerff40b142018-04-09 08:49:14 +02003161 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003162}
3163
eladalonf1841382017-06-12 01:16:46 -07003164class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003165 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003166 Vp9SettingsTest() : Vp9SettingsTest("") {}
3167 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003168 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003169 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003170 }
3171 virtual ~Vp9SettingsTest() {}
3172
3173 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003174 void TearDown() override {
3175 // Remove references to encoder_factory_ since this will be destroyed
3176 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003177 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003178 }
Erik Språng143cec12015-04-28 10:01:41 +02003179};
3180
3181TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003182 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003183 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003184 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003185
Peter Boström2feafdb2015-09-09 14:32:14 +02003186 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003187
Niels Möller805a27e2019-01-21 12:21:27 +01003188 webrtc::test::FrameForwarder frame_forwarder;
3189 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003190 channel_->SetSend(true);
3191
Niels Möller805a27e2019-01-21 12:21:27 +01003192 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003193
pbos4cba4eb2015-10-26 11:18:18 -07003194 webrtc::VideoCodecVP9 vp9_settings;
3195 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003196 EXPECT_TRUE(vp9_settings.denoisingOn)
3197 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003198
Niels Möller805a27e2019-01-21 12:21:27 +01003199 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003200
Erik Språng143cec12015-04-28 10:01:41 +02003201 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3202 EXPECT_FALSE(vp9_settings.denoisingOn);
3203 // Frame dropping always on for real time video.
3204 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3205
Niels Möller805a27e2019-01-21 12:21:27 +01003206 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003207
3208 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3209 EXPECT_TRUE(vp9_settings.denoisingOn);
3210 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3211
3212 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003213 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003214 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003215 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003216
Niels Möller805a27e2019-01-21 12:21:27 +01003217 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003218
3219 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3220 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003221 // Frame dropping always on for screen sharing.
3222 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003223
Niels Möller805a27e2019-01-21 12:21:27 +01003224 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003225
3226 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3227 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003228 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003229
Niels Möllerff40b142018-04-09 08:49:14 +02003230 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003231}
3232
Sergey Silkinf18072e2018-03-14 10:35:35 +01003233TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3234 cricket::VideoSendParameters parameters;
3235 parameters.codecs.push_back(GetEngineCodec("VP9"));
3236 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3237
3238 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3239
3240 FakeVideoSendStream* stream =
3241 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3242
3243 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003244
Niels Möller805a27e2019-01-21 12:21:27 +01003245 webrtc::test::FrameForwarder frame_forwarder;
3246 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003247 channel_->SetSend(true);
3248
Niels Möller805a27e2019-01-21 12:21:27 +01003249 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003250
3251 webrtc::VideoCodecVP9 vp9_settings;
3252 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3253
3254 const size_t kNumSpatialLayers = ssrcs.size();
3255 const size_t kNumTemporalLayers = 3;
3256 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3257 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3258
Niels Möllerff40b142018-04-09 08:49:14 +02003259 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003260}
3261
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003262TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3263 cricket::VideoSendParameters parameters;
3264 parameters.codecs.push_back(GetEngineCodec("VP9"));
3265 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3266
3267 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3268
3269 FakeVideoSendStream* stream =
3270 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3271
3272 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3273
3274 // Despite 3 ssrcs provided, single layer is used.
3275 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3276
3277 webrtc::test::FrameForwarder frame_forwarder;
3278 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3279 channel_->SetSend(true);
3280
3281 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3282
3283 webrtc::VideoCodecVP9 vp9_settings;
3284 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3285
3286 const size_t kNumSpatialLayers = ssrcs.size();
3287 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3288
3289 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3290}
3291
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003292TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3293 cricket::VideoSendParameters send_parameters;
3294 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3295 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3296
3297 const size_t kNumSpatialLayers = 3;
3298 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3299
3300 FakeVideoSendStream* stream =
3301 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3302
3303 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3304 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3305 ASSERT_TRUE(parameters.encodings[0].active);
3306 ASSERT_TRUE(parameters.encodings[1].active);
3307 ASSERT_TRUE(parameters.encodings[2].active);
3308 // Invert value to verify copying.
3309 parameters.encodings[1].active = false;
3310 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3311
3312 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3313
3314 // number_of_streams should be 1 since all spatial layers are sent on the
3315 // same SSRC. But encoding parameters of all layers is supposed to be copied
3316 // and stored in simulcast_layers[].
3317 EXPECT_EQ(1u, encoder_config.number_of_streams);
3318 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3319 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3320 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3321 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3322}
3323
Sergey Silkincf267052019-04-09 11:40:09 +02003324class Vp9SettingsTestWithFieldTrial
3325 : public Vp9SettingsTest,
3326 public ::testing::WithParamInterface<
3327 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003328 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003329 Vp9SettingsTestWithFieldTrial()
3330 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3331 num_spatial_layers_(::testing::get<1>(GetParam())),
3332 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003333 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003334
3335 void VerifySettings(int num_spatial_layers,
3336 int num_temporal_layers,
3337 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003338 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003339 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003340 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3341
3342 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3343
Niels Möller805a27e2019-01-21 12:21:27 +01003344 webrtc::test::FrameForwarder frame_forwarder;
3345 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003346 channel_->SetSend(true);
3347
Niels Möller805a27e2019-01-21 12:21:27 +01003348 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003349
3350 webrtc::VideoCodecVP9 vp9_settings;
3351 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3352 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3353 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003354 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003355
Niels Möllerff40b142018-04-09 08:49:14 +02003356 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003357 }
Sergey Silkincf267052019-04-09 11:40:09 +02003358
3359 const uint8_t num_spatial_layers_;
3360 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003361 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003362};
3363
Sergey Silkincf267052019-04-09 11:40:09 +02003364TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003365 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3366 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003367}
3368
Sergey Silkincf267052019-04-09 11:40:09 +02003369INSTANTIATE_TEST_SUITE_P(
3370 ,
3371 Vp9SettingsTestWithFieldTrial,
3372 ::testing::Values(
3373 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3374 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3375 1,
3376 1,
3377 webrtc::InterLayerPredMode::kOnKeyPic),
3378 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3379 2,
3380 3,
3381 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003382 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003383 1,
3384 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003385 webrtc::InterLayerPredMode::kOnKeyPic),
3386 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003387 1,
3388 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003389 webrtc::InterLayerPredMode::kOnKeyPic),
3390 std::make_tuple(
3391 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3392 1,
3393 1,
3394 webrtc::InterLayerPredMode::kOff),
3395 std::make_tuple(
3396 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3397 1,
3398 1,
3399 webrtc::InterLayerPredMode::kOn),
3400 std::make_tuple(
3401 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3402 1,
3403 1,
3404 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003405
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003406TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3407 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3408 ASSERT_EQ(1u, streams.size());
3409 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3410}
3411
3412TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003413 RTC_DCHECK(!override_field_trials_);
3414 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003415 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3416 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3417 ASSERT_EQ(1u, streams.size());
3418 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3419}
3420
asapersson3c81a1a2017-06-14 05:52:21 -07003421TEST_F(WebRtcVideoChannelTest,
3422 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003423 RTC_DCHECK(!override_field_trials_);
3424 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003425 "WebRTC-Video-BalancedDegradation/Disabled/");
3426 const bool kResolutionScalingEnabled = true;
3427 const bool kFpsScalingEnabled = false;
3428 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3429}
3430
3431TEST_F(WebRtcVideoChannelTest,
3432 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003433 RTC_DCHECK(!override_field_trials_);
3434 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003435 "WebRTC-Video-BalancedDegradation/Enabled/");
3436 const bool kResolutionScalingEnabled = true;
3437 const bool kFpsScalingEnabled = true;
3438 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3439}
3440
eladalonf1841382017-06-12 01:16:46 -07003441TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003442 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003443}
3444
eladalonf1841382017-06-12 01:16:46 -07003445TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003446 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003447}
3448
Niels Möller3de32e62019-01-18 08:42:18 +01003449TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3450 TestCpuAdaptation(false, true);
3451}
3452
eladalonf1841382017-06-12 01:16:46 -07003453TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003454 TestCpuAdaptation(true, true);
3455}
3456
eladalonf1841382017-06-12 01:16:46 -07003457TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003458 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003459 cricket::VideoSendParameters parameters;
3460 parameters.codecs.push_back(codec);
3461
kthelgason2bc68642017-02-07 07:02:22 -08003462 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003463 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003464 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003465 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3466 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003467 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003468 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3469
3470 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003471 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003472
Per766ad3b2016-04-05 15:23:49 +02003473 ASSERT_TRUE(channel_->SetSend(true));
3474 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003475 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003476 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003477
3478 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3479 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003480
Niels Möllerdcc70292019-01-15 16:32:38 +01003481 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3482 // Dont' expect anything on framerate_scaling_enabled, since the default is
3483 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003484
Niels Möllerdcc70292019-01-15 16:32:38 +01003485 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003486 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003487 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003488 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003489 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3490 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003491 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003492
Niels Möllerdcc70292019-01-15 16:32:38 +01003493 // Switch back to the normal capturer. Expect resolution scaling to be
3494 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003495 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3496 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003497 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3498 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003499 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003500
Niels Möllerff40b142018-04-09 08:49:14 +02003501 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003502}
3503
asapersson3c81a1a2017-06-14 05:52:21 -07003504// TODO(asapersson): Remove this test when the balanced field trial is removed.
3505void WebRtcVideoChannelTest::TestDegradationPreference(
3506 bool resolution_scaling_enabled,
3507 bool fps_scaling_enabled) {
3508 cricket::VideoCodec codec = GetEngineCodec("VP8");
3509 cricket::VideoSendParameters parameters;
3510 parameters.codecs.push_back(codec);
3511
3512 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003513 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003514 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003515 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3516 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003517 channel_->OnReadyToSend(true);
3518
3519 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3520
3521 AddSendStream();
3522
Niels Möller805a27e2019-01-21 12:21:27 +01003523 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003524 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003525 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003526
3527 EXPECT_TRUE(channel_->SetSend(true));
3528
3529 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3530 EXPECT_EQ(resolution_scaling_enabled,
3531 send_stream->resolution_scaling_enabled());
3532 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3533
Niels Möllerff40b142018-04-09 08:49:14 +02003534 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003535}
3536
eladalonf1841382017-06-12 01:16:46 -07003537void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3538 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003539 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003540 cricket::VideoSendParameters parameters;
3541 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003542
kthelgason2bc68642017-02-07 07:02:22 -08003543 MediaConfig media_config = GetMediaConfig();
3544 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003545 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003546 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003547 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003548 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3549 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003550 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003551
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003552 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003553
3554 AddSendStream();
3555
Niels Möller805a27e2019-01-21 12:21:27 +01003556 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003557 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003558 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003559 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003560
3561 EXPECT_TRUE(channel_->SetSend(true));
3562
solenberge5269742015-09-08 05:13:22 -07003563 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003564
sprangc5d62e22017-04-02 23:53:04 -07003565 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003566 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003567 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003568 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003569 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3570 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3571 } else {
3572 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3573 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3574 }
Niels Möllerff40b142018-04-09 08:49:14 +02003575 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003576}
3577
eladalonf1841382017-06-12 01:16:46 -07003578TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003579 // Start at last timestamp to verify that wraparounds are estimated correctly.
3580 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3581 static const int64_t kInitialNtpTimeMs = 1247891230;
3582 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003583 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003584
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003585 FakeVideoReceiveStream* stream = AddRecvStream();
3586 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003587 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003588
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003589 webrtc::VideoFrame video_frame =
3590 webrtc::VideoFrame::Builder()
3591 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3592 .set_timestamp_rtp(kInitialTimestamp)
3593 .set_timestamp_us(0)
3594 .set_rotation(webrtc::kVideoRotation_0)
3595 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003596 // Initial NTP time is not available on the first frame, but should still be
3597 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003598 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003599
3600 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003601
3602 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3603 // triggers a constant-overflow warning, hence we're calculating it explicitly
3604 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003605 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003606 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3607 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003608 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003609
3610 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003611
3612 // Verify that NTP time has been correctly deduced.
3613 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003614 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003615 ASSERT_EQ(1u, info.receivers.size());
3616 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003617}
3618
eladalonf1841382017-06-12 01:16:46 -07003619TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003620 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003621 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003622
3623 VideoCodec codec;
3624 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003625 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003626
3627 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003628 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3629 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003630 FakeVideoSendStream* stream = AddSendStream(
3631 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003632 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003633
3634 // Make sure NACK and FEC are enabled on the correct payload types.
3635 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003636 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3637 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003638
3639 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3640 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003641 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003642 // TODO(juberti): Check RTCP, PLI, TMMBR.
3643}
3644
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003645TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3646 cricket::VideoSendParameters parameters;
3647 parameters.codecs.push_back(GetEngineCodec("VP8"));
3648 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3649
3650 FakeVideoSendStream* stream = AddSendStream();
3651 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3652 EXPECT_FALSE(config.rtp.raw_payload);
3653}
3654
3655TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3656 cricket::VideoSendParameters parameters;
3657 parameters.codecs.push_back(GetEngineCodec("VP8"));
3658 parameters.codecs.back().packetization = kPacketizationParamRaw;
3659 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3660
3661 FakeVideoSendStream* stream = AddSendStream();
3662 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3663 EXPECT_TRUE(config.rtp.raw_payload);
3664}
3665
brandtr31bd2242017-05-19 05:47:46 -07003666// The following four tests ensures that FlexFEC is not activated by default
3667// when the field trials are not enabled.
3668// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3669// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003670TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003671 FakeVideoSendStream* stream = AddSendStream();
3672 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3673
brandtr3d200bd2017-01-16 06:59:19 -08003674 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003675 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3676 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003677}
3678
eladalonf1841382017-06-12 01:16:46 -07003679TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003680 FakeVideoSendStream* stream = AddSendStream(
3681 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3682 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3683
brandtr3d200bd2017-01-16 06:59:19 -08003684 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003685 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3686 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3687}
3688
Yves Gerey665174f2018-06-19 15:03:05 +02003689TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003690 AddRecvStream();
3691
3692 const std::vector<FakeFlexfecReceiveStream*>& streams =
3693 fake_call_->GetFlexfecReceiveStreams();
3694 EXPECT_TRUE(streams.empty());
3695}
3696
eladalonf1841382017-06-12 01:16:46 -07003697TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003698 AddRecvStream(
3699 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3700
3701 const std::vector<FakeFlexfecReceiveStream*>& streams =
3702 fake_call_->GetFlexfecReceiveStreams();
3703 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003704}
3705
3706// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3707// tests that use this test fixture into the corresponding "non-field trial"
3708// tests.
eladalonf1841382017-06-12 01:16:46 -07003709class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003710 public:
eladalonf1841382017-06-12 01:16:46 -07003711 WebRtcVideoChannelFlexfecRecvTest()
3712 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003713};
3714
eladalonf1841382017-06-12 01:16:46 -07003715TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003716 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3717 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3718 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3719}
3720
eladalonf1841382017-06-12 01:16:46 -07003721TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003722 AddRecvStream();
3723
3724 const std::vector<FakeFlexfecReceiveStream*>& streams =
3725 fake_call_->GetFlexfecReceiveStreams();
3726 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003727
3728 const std::vector<FakeVideoReceiveStream*>& video_streams =
3729 fake_call_->GetVideoReceiveStreams();
3730 ASSERT_EQ(1U, video_streams.size());
3731 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3732 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3733 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003734}
3735
eladalonf1841382017-06-12 01:16:46 -07003736TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003737 AddRecvStream(
3738 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3739
3740 const std::vector<FakeFlexfecReceiveStream*>& streams =
3741 fake_call_->GetFlexfecReceiveStreams();
3742 ASSERT_EQ(1U, streams.size());
3743 const FakeFlexfecReceiveStream* stream = streams.front();
3744 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3745 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3746 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3747 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3748 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003749
3750 const std::vector<FakeVideoReceiveStream*>& video_streams =
3751 fake_call_->GetVideoReceiveStreams();
3752 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003753 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3754 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003755 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003756 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003757 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003758}
3759
eladalonf1841382017-06-12 01:16:46 -07003760TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003761 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3762 cricket::VideoRecvParameters recv_parameters;
3763 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3764 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3765
3766 AddRecvStream(
3767 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3768 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003769 const std::vector<FakeVideoReceiveStream*>& video_streams =
3770 fake_call_->GetVideoReceiveStreams();
3771 ASSERT_EQ(1U, video_streams.size());
3772 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3773 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3774 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003775
3776 // Enable FlexFEC.
3777 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3778 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3779 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3780 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3781 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3782 << "Enabling FlexFEC should not create VideoReceiveStream.";
3783 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3784 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003785 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3786 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003787}
3788
eladalonf1841382017-06-12 01:16:46 -07003789TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003790 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3791 cricket::VideoRecvParameters recv_parameters;
3792 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3793 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3794 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3795
3796 AddRecvStream(
3797 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3798 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003799 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003800 const std::vector<FakeVideoReceiveStream*>& video_streams =
3801 fake_call_->GetVideoReceiveStreams();
3802 ASSERT_EQ(1U, video_streams.size());
3803 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3804 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3805 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003806
3807 // Disable FlexFEC.
3808 recv_parameters.codecs.clear();
3809 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3810 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3811 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3812 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3813 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3814 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3815 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3816 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003817 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3818 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003819}
3820
brandtr31bd2242017-05-19 05:47:46 -07003821// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3822// tests that use this test fixture into the corresponding "non-field trial"
3823// tests.
eladalonf1841382017-06-12 01:16:46 -07003824class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003825 public:
eladalonf1841382017-06-12 01:16:46 -07003826 WebRtcVideoChannelFlexfecSendRecvTest()
3827 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003828 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3829 }
3830};
3831
Yves Gerey665174f2018-06-19 15:03:05 +02003832TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003833 FakeVideoSendStream* stream = AddSendStream();
3834 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3835
brandtr3d200bd2017-01-16 06:59:19 -08003836 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3837 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3838 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003839}
3840
eladalonf1841382017-06-12 01:16:46 -07003841TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003842 FakeVideoSendStream* stream = AddSendStream(
3843 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3844 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3845
brandtr3d200bd2017-01-16 06:59:19 -08003846 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3847 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3848 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3849 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003850}
3851
eladalonf1841382017-06-12 01:16:46 -07003852TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003853 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003854 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003855 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003856
3857 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003858 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003859
brandtrb5f2c3f2016-10-04 23:28:39 -07003860 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3861 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003862}
3863
eladalonf1841382017-06-12 01:16:46 -07003864TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003865 cricket::VideoSendParameters parameters;
3866 parameters.codecs.push_back(GetEngineCodec("VP8"));
3867 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3868
3869 FakeVideoSendStream* stream = AddSendStream();
3870 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3871
brandtr3d200bd2017-01-16 06:59:19 -08003872 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003873}
3874
eladalonf1841382017-06-12 01:16:46 -07003875TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003876 AddRecvStream(
3877 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003878
3879 cricket::VideoRecvParameters recv_parameters;
3880 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3881 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3882 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003883
3884 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3885 fake_call_->GetFlexfecReceiveStreams();
3886 ASSERT_EQ(1U, flexfec_streams.size());
3887 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3888 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3889 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003890 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003891 flexfec_stream_config.payload_type);
3892 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3893 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3894 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3895 const std::vector<FakeVideoReceiveStream*>& video_streams =
3896 fake_call_->GetVideoReceiveStreams();
3897 const FakeVideoReceiveStream* video_stream = video_streams.front();
3898 const webrtc::VideoReceiveStream::Config& video_stream_config =
3899 video_stream->GetConfig();
3900 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3901 flexfec_stream_config.local_ssrc);
3902 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3903 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3904 flexfec_stream_config.rtcp_send_transport);
3905 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3906 // spec-compliant way.
3907 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3908 flexfec_stream_config.transport_cc);
3909 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3910 EXPECT_EQ(video_stream_config.rtp.extensions,
3911 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003912}
3913
brandtr31bd2242017-05-19 05:47:46 -07003914// We should not send FlexFEC, even if we advertise it, unless the right
3915// field trial is set.
3916// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003917TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003918 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3919 cricket::VideoSendParameters parameters;
3920 parameters.codecs.push_back(GetEngineCodec("VP8"));
3921 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3922 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3923
3924 FakeVideoSendStream* stream = AddSendStream();
3925 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3926
3927 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003928 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003929 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3930}
3931
eladalonf1841382017-06-12 01:16:46 -07003932TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003933 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3934 cricket::VideoSendParameters parameters;
3935 parameters.codecs.push_back(GetEngineCodec("VP8"));
3936 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3937 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3938
3939 FakeVideoSendStream* stream = AddSendStream(
3940 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3941 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3942
3943 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003944 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003945 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3946}
3947
eladalonf1841382017-06-12 01:16:46 -07003948TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003949 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003950 const int kUnusedPayloadType = 127;
3951 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3952
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003953 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003954 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003955 parameters.codecs.push_back(rtx_codec);
3956 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003957 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003958}
3959
eladalonf1841382017-06-12 01:16:46 -07003960TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003961 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003962 const int kUnusedPayloadType1 = 126;
3963 const int kUnusedPayloadType2 = 127;
3964 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3965 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3966 {
3967 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3968 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3969 cricket::VideoSendParameters parameters;
3970 parameters.codecs.push_back(GetEngineCodec("VP8"));
3971 parameters.codecs.push_back(rtx_codec);
3972 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3973 }
3974 {
3975 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3976 kUnusedPayloadType1, kUnusedPayloadType2);
3977 cricket::VideoSendParameters parameters;
3978 parameters.codecs.push_back(GetEngineCodec("VP8"));
3979 parameters.codecs.push_back(rtx_codec);
3980 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3981 << "RTX without matching video codec should be rejected.";
3982 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003983}
3984
eladalonf1841382017-06-12 01:16:46 -07003985TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08003986 const int kUnusedPayloadType1 = 126;
3987 const int kUnusedPayloadType2 = 127;
3988 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3989 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3990
3991 // SSRCs for RTX.
3992 cricket::StreamParams params =
3993 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
3994 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
3995 AddSendStream(params);
3996
3997 // Original payload type for RTX.
3998 cricket::VideoSendParameters parameters;
3999 parameters.codecs.push_back(GetEngineCodec("VP8"));
4000 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4001 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4002 parameters.codecs.push_back(rtx_codec);
4003 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4004 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4005 const webrtc::VideoSendStream::Config& config_before =
4006 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4007 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4008 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4009 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4010
4011 // Change payload type for RTX.
4012 parameters.codecs[1].id = kUnusedPayloadType2;
4013 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4014 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4015 const webrtc::VideoSendStream::Config& config_after =
4016 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4017 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4018 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4019 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4020}
4021
eladalonf1841382017-06-12 01:16:46 -07004022TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004023 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004024 parameters.codecs.push_back(GetEngineCodec("VP8"));
4025 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004026 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004027
4028 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004029 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004030
magjed509e4fe2016-11-18 01:34:11 -08004031 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004032
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004033 parameters.codecs.pop_back();
4034 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004035 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004036 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004037 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004038 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004039 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4040}
4041
eladalonf1841382017-06-12 01:16:46 -07004042TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004043 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004044 cricket::VideoSendParameters parameters;
4045 parameters.codecs.push_back(GetEngineCodec("VP8"));
4046 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4047 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4048
4049 FakeVideoSendStream* stream = AddSendStream(
4050 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4051 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4052
brandtr3d200bd2017-01-16 06:59:19 -08004053 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4054 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004055 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4056 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4057
4058 parameters.codecs.pop_back();
4059 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4060 stream = fake_call_->GetVideoSendStreams()[0];
4061 ASSERT_TRUE(stream != nullptr);
4062 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004063 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004064 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004065}
4066
eladalonf1841382017-06-12 01:16:46 -07004067TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004068 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004069 cricket::VideoCodec codec(100, "VP8");
4070 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4071 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004072
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004073 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004074 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004075
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004076 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004077 webrtc::test::FrameForwarder frame_forwarder;
4078 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004079
4080 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004081 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004082
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004083 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004084 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4085 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004086 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004087 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004088 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004089 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004090}
4091
eladalonf1841382017-06-12 01:16:46 -07004092TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004093 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4094 200000);
4095}
4096
eladalonf1841382017-06-12 01:16:46 -07004097TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004098 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4099 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4100 ASSERT_EQ(1u, streams.size());
4101 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4102}
4103
eladalonf1841382017-06-12 01:16:46 -07004104TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004105 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004106 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004107}
4108
eladalonf1841382017-06-12 01:16:46 -07004109TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004110 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004111}
4112
eladalonf1841382017-06-12 01:16:46 -07004113TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004114 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4115 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4116 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004117}
4118
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004119// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4120// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004121TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004122 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4123 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4124 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4125 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004126 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004127 ExpectSetBitrateParameters(100000, 200000, 400000);
4128 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4129 // Since the codec isn't changing, start_bitrate_bps should be -1.
4130 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004131
4132 // Decrease max_bandwidth_bps.
4133 send_parameters_.max_bandwidth_bps = 350000;
4134 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004135
4136 // Now try again with the values flipped around.
4137 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4138 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004139 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004140 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004141
4142 // If we change the codec max, max_bandwidth_bps should still apply.
4143 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004144 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004145 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004146}
4147
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004148// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4149// are present in the same send parameters, the settings are combined correctly.
4150TEST_F(WebRtcVideoChannelTest,
4151 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4152 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4153 // Transport.
4154 webrtc::MediaTransportSettings settings;
4155 settings.is_caller = true;
4156 webrtc::FakeMediaTransport fake_media_transport(settings);
4157 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4158 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004159 channel_->SetInterface(network_interface.get(),
4160 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004161
4162 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4163 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4164 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4165 send_parameters_.max_bandwidth_bps = 400000;
4166 {
4167 // We expect max_bandwidth_bps to take priority, if set.
4168 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4169 ASSERT_EQ(1u,
4170 fake_media_transport.target_rate_constraints_in_order().size());
4171 const webrtc::MediaTransportTargetRateConstraints& constraint =
4172 fake_media_transport.target_rate_constraints_in_order()[0];
4173 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4174 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4175 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4176 }
4177
4178 {
4179 // Decrease max_bandwidth_bps.
4180 send_parameters_.max_bandwidth_bps = 350000;
4181 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4182 ASSERT_EQ(2u,
4183 fake_media_transport.target_rate_constraints_in_order().size());
4184 const webrtc::MediaTransportTargetRateConstraints& constraint =
4185 fake_media_transport.target_rate_constraints_in_order()[1];
4186
4187 // Since the codec isn't changing, start_bitrate_bps should be 0.
4188 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4189 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4190 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4191 }
4192
4193 {
4194 // Now try again with the values flipped around.
4195 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4196 send_parameters_.max_bandwidth_bps = 300000;
4197 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4198 ASSERT_EQ(3u,
4199 fake_media_transport.target_rate_constraints_in_order().size());
4200 const webrtc::MediaTransportTargetRateConstraints& constraint =
4201 fake_media_transport.target_rate_constraints_in_order()[2];
4202
4203 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4204 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4205 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4206 }
4207
4208 {
4209 // Now try again with the values flipped around.
4210 // If we change the codec max, max_bandwidth_bps should still apply.
4211 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4212 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4213 ASSERT_EQ(4u,
4214 fake_media_transport.target_rate_constraints_in_order().size());
4215 const webrtc::MediaTransportTargetRateConstraints& constraint =
4216 fake_media_transport.target_rate_constraints_in_order()[3];
4217
4218 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4219 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4220 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4221 }
4222}
4223
Yves Gerey665174f2018-06-19 15:03:05 +02004224TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004225 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4226 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004227 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004228 // Setting max bitrate should keep previous min bitrate.
4229 // Setting max bitrate should not reset start bitrate.
4230 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004231 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004232}
4233
eladalonf1841382017-06-12 01:16:46 -07004234TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004235 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004236 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004237 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004238 // -1 means to disable max bitrate (set infinite).
4239 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004240 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004241 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004242}
4243
eladalonf1841382017-06-12 01:16:46 -07004244TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004245 send_parameters_.max_bandwidth_bps = 99999;
4246 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004247 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004248 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004249 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4250 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4251 stream->GetVideoStreams()[0].max_bitrate_bps);
4252
4253 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004254 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004255 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4256 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004257 stream->GetVideoStreams()[0].max_bitrate_bps);
4258}
4259
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004260// Tests that when the codec specific max bitrate and VideoSendParameters
4261// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4262// appropriately.
4263TEST_F(WebRtcVideoChannelTest,
4264 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4265 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4266 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4267 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4268 send_parameters_.max_bandwidth_bps = -1;
4269 AddSendStream();
4270 ExpectSetMaxBitrate(300000);
4271 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4272
4273 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4274 ASSERT_EQ(1u, video_send_streams.size());
4275 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4276 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4277 // First the max bitrate is set based upon the codec param.
4278 EXPECT_EQ(300000,
4279 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4280
4281 // The VideoSendParameters max bitrate overrides the codec's.
4282 send_parameters_.max_bandwidth_bps = 500000;
4283 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4284 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4285 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4286 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4287}
4288
4289// Tests that when the codec specific max bitrate and RtpParameters
4290// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4291// appropriately.
4292TEST_F(WebRtcVideoChannelTest,
4293 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4294 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4295 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4296 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4297 send_parameters_.max_bandwidth_bps = -1;
4298 AddSendStream();
4299 ExpectSetMaxBitrate(300000);
4300 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4301
4302 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4303 ASSERT_EQ(1u, video_send_streams.size());
4304 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4305 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4306 // First the max bitrate is set based upon the codec param.
4307 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4308
4309 // The RtpParameter max bitrate overrides the codec's.
4310 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4311 ASSERT_EQ(1u, parameters.encodings.size());
4312 parameters.encodings[0].max_bitrate_bps = 500000;
4313 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4314 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4315 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4316 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4317}
4318
Åsa Persson55659812018-06-18 17:51:32 +02004319TEST_F(WebRtcVideoChannelTest,
4320 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4321 send_parameters_.max_bandwidth_bps = 99999;
4322 FakeVideoSendStream* stream = AddSendStream();
4323 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4324 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4325 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4326 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4327 stream->GetVideoStreams()[0].max_bitrate_bps);
4328
4329 // Get and set the rtp encoding parameters.
4330 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4331 EXPECT_EQ(1u, parameters.encodings.size());
4332
4333 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4334 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4335 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4336 stream->GetVideoStreams()[0].max_bitrate_bps);
4337
4338 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4339 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4340 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4341 stream->GetVideoStreams()[0].max_bitrate_bps);
4342}
4343
eladalonf1841382017-06-12 01:16:46 -07004344TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004345 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004346 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004347 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004348 channel_->SetSend(true);
4349
4350 FakeVideoSendStream* stream = AddSendStream();
4351
Niels Möller805a27e2019-01-21 12:21:27 +01004352 webrtc::test::FrameForwarder frame_forwarder;
4353 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004354
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004355 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4356 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4357 EXPECT_GT(initial_max_bitrate_bps, 0);
4358
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004359 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4360 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004361 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004362 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004363 streams = stream->GetVideoStreams();
4364 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004365 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004366}
4367
eladalonf1841382017-06-12 01:16:46 -07004368TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004369 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004370 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004371 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004372 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004373 channel_->SetSend(true);
4374
4375 FakeVideoSendStream* stream = AddSendStream(
4376 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4377
4378 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004379 webrtc::test::FrameForwarder frame_forwarder;
4380 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4381 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004382
4383 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4384 ASSERT_GT(streams.size(), 1u)
4385 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004386 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004387 EXPECT_GT(initial_max_bitrate_bps, 0);
4388
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004389 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4390 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004391 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004392 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004393 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004394 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004395 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4396
Niels Möllerff40b142018-04-09 08:49:14 +02004397 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004398}
4399
eladalonf1841382017-06-12 01:16:46 -07004400TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004401 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004402 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004403 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004404 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4405 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004406 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004407 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004408
4409 VideoCodec codec;
4410 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4411 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4412}
4413
eladalonf1841382017-06-12 01:16:46 -07004414TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004415 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004416 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004417 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004418 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004419 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004420 parameters.codecs[0].id = kIncorrectPayloads[i];
4421 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004422 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004423 }
4424}
4425
eladalonf1841382017-06-12 01:16:46 -07004426TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004427 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004428 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004429 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004430 parameters.codecs[0].id = payload_type;
4431 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004432 << "Payload type '" << payload_type << "' rejected.";
4433 }
4434}
4435
deadbeef67cf2c12016-04-13 10:07:16 -07004436// Test that setting the a different set of codecs but with an identical front
4437// codec doesn't result in the stream being recreated.
4438// This may happen when a subsequent negotiation includes fewer codecs, as a
4439// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004440TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004441 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4442 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004443 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4444 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004445 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4446
4447 AddSendStream();
4448 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4449
4450 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004451 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004452 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4453 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4454}
4455
eladalonf1841382017-06-12 01:16:46 -07004456TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004457 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004458 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004459 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004460}
4461
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004462// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004463TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004464 const int kUnusedPayloadType1 = 126;
4465 const int kUnusedPayloadType2 = 127;
4466 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4467 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4468
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004469 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004470 parameters.codecs.push_back(GetEngineCodec("VP8"));
4471 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004472 parameters.codecs.push_back(rtx_codec);
4473 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004474 << "RTX codec without associated payload should be rejected.";
4475
magjed509e4fe2016-11-18 01:34:11 -08004476 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004477 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004478 << "RTX codec with invalid associated payload type should be rejected.";
4479
magjed509e4fe2016-11-18 01:34:11 -08004480 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004481 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004482
magjed509e4fe2016-11-18 01:34:11 -08004483 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004484 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004485 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004486
Yves Gerey665174f2018-06-19 15:03:05 +02004487 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4488 << "RTX codec with another RTX as associated payload type should be "
4489 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004490}
4491
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004492TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4493 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4494 vp8_codec.packetization = kPacketizationParamRaw;
4495
4496 cricket::VideoRecvParameters parameters;
4497 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4498 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4499
4500 const cricket::StreamParams params =
4501 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4502 AddRecvStream(params);
4503 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4504
4505 const webrtc::VideoReceiveStream::Config& config =
4506 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4507 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4508 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4509}
4510
4511TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4512 cricket::VideoRecvParameters parameters;
4513 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4514 parameters.codecs.back().packetization = kPacketizationParamRaw;
4515 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4516
4517 const cricket::StreamParams params =
4518 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4519 AddRecvStream(params);
4520 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4521 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4522
4523 parameters.codecs.back().packetization.reset();
4524 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4525 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4526}
4527
eladalonf1841382017-06-12 01:16:46 -07004528TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004529 const int kUnusedPayloadType1 = 126;
4530 const int kUnusedPayloadType2 = 127;
4531 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4532 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4533
4534 // SSRCs for RTX.
4535 cricket::StreamParams params =
4536 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4537 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4538 AddRecvStream(params);
4539
4540 // Original payload type for RTX.
4541 cricket::VideoRecvParameters parameters;
4542 parameters.codecs.push_back(GetEngineCodec("VP8"));
4543 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4544 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4545 parameters.codecs.push_back(rtx_codec);
4546 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4547 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4548 const webrtc::VideoReceiveStream::Config& config_before =
4549 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004550 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4551 const int* payload_type_before = FindKeyByValue(
4552 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4553 ASSERT_NE(payload_type_before, nullptr);
4554 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004555 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4556
4557 // Change payload type for RTX.
4558 parameters.codecs[1].id = kUnusedPayloadType2;
4559 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4560 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4561 const webrtc::VideoReceiveStream::Config& config_after =
4562 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004563 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4564 const int* payload_type_after = FindKeyByValue(
4565 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4566 ASSERT_NE(payload_type_after, nullptr);
4567 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004568 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4569}
4570
eladalonf1841382017-06-12 01:16:46 -07004571TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004572 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004573 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004574 parameters.codecs[0].id = 99;
4575 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004576}
4577
eladalonf1841382017-06-12 01:16:46 -07004578TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004579 cricket::VideoRecvParameters parameters;
4580 parameters.codecs = engine_.codecs();
4581 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004582
4583 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004584 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004585 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004586 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004587}
4588
eladalonf1841382017-06-12 01:16:46 -07004589TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004590 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004591 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004592 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004593 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004594}
4595
eladalonf1841382017-06-12 01:16:46 -07004596TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004597 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004598 parameters.codecs.push_back(GetEngineCodec("VP8"));
4599 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004600 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004601}
4602
eladalonf1841382017-06-12 01:16:46 -07004603TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004604 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004605 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4606 send_parameters.codecs.push_back(GetEngineCodec("red"));
4607 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004608 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004609
4610 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004611
magjed509e4fe2016-11-18 01:34:11 -08004612 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004613 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004614
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004615 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004616 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004617 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004618 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004619 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004620 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004621 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4622}
4623
eladalonf1841382017-06-12 01:16:46 -07004624TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004625 AddRecvStream(
4626 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004627 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004628 fake_call_->GetFlexfecReceiveStreams();
4629
4630 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004631 const FakeFlexfecReceiveStream* stream = streams.front();
4632 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4633 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4634 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4635 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004636
4637 cricket::VideoRecvParameters recv_parameters;
4638 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4639 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4640 EXPECT_TRUE(streams.empty())
4641 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004642}
4643
eladalonf1841382017-06-12 01:16:46 -07004644TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004645 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004646 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004647 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004648
4649 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004650 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4651 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4652 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004653 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4654 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004655 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004656 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004657 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004658 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004659
4660 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004661 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4662 send_parameters.codecs.push_back(GetEngineCodec("red"));
4663 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004664 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4665 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004666 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004667 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004668 << "ULPFEC should be enabled on the receive stream.";
4669}
4670
eladalonf1841382017-06-12 01:16:46 -07004671TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004672 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004673 AddRecvStream(
4674 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004675 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004676 fake_call_->GetFlexfecReceiveStreams();
4677
4678 cricket::VideoRecvParameters recv_parameters;
4679 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4680 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4681 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4682 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004683 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004684 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004685 stream_with_recv_params->GetConfig().payload_type);
4686 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004687 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004688 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004689 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004690 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004691
4692 cricket::VideoSendParameters send_parameters;
4693 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4694 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4695 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4696 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004697 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004698 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004699 stream_with_send_params->GetConfig().payload_type);
4700 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004701 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004702 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004703 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004704 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004705}
4706
eladalonf1841382017-06-12 01:16:46 -07004707TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004708 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004709 parameters.codecs.push_back(GetEngineCodec("VP8"));
4710 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004711 parameters.codecs[1].id = parameters.codecs[0].id;
4712 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004713}
4714
eladalonf1841382017-06-12 01:16:46 -07004715TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004716 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004717 cricket::VideoRecvParameters parameters;
4718 parameters.codecs.push_back(GetEngineCodec("VP8"));
4719 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4720 parameters.codecs[1].id = parameters.codecs[0].id;
4721 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4722}
4723
eladalonf1841382017-06-12 01:16:46 -07004724TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004725 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004726 parameters.codecs.push_back(GetEngineCodec("VP8"));
4727 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004728 parameters.codecs[1].id = parameters.codecs[0].id;
4729 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004730}
4731
eladalonf1841382017-06-12 01:16:46 -07004732TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004733 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004734 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004735 parameters.codecs.push_back(GetEngineCodec("VP8"));
4736 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004737 parameters.codecs[1].id += 1;
4738 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004739}
4740
deadbeef67cf2c12016-04-13 10:07:16 -07004741// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004742// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004743TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004744 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004745 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004746 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4747 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004748 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004749
4750 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4751 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4752
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004753 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004754 parameters2.codecs.push_back(GetEngineCodec("red"));
4755 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004756 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004757 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4758}
4759
eladalonf1841382017-06-12 01:16:46 -07004760TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004761 EXPECT_FALSE(AddSendStream()->IsSending());
4762}
4763
eladalonf1841382017-06-12 01:16:46 -07004764TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004765 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004766}
4767
eladalonf1841382017-06-12 01:16:46 -07004768TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004769 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004770 EXPECT_FALSE(stream->IsSending());
4771
4772 // false->true
4773 EXPECT_TRUE(channel_->SetSend(true));
4774 EXPECT_TRUE(stream->IsSending());
4775 // true->true
4776 EXPECT_TRUE(channel_->SetSend(true));
4777 EXPECT_TRUE(stream->IsSending());
4778 // true->false
4779 EXPECT_TRUE(channel_->SetSend(false));
4780 EXPECT_FALSE(stream->IsSending());
4781 // false->false
4782 EXPECT_TRUE(channel_->SetSend(false));
4783 EXPECT_FALSE(stream->IsSending());
4784
4785 EXPECT_TRUE(channel_->SetSend(true));
4786 FakeVideoSendStream* new_stream = AddSendStream();
4787 EXPECT_TRUE(new_stream->IsSending())
4788 << "Send stream created after SetSend(true) not sending initially.";
4789}
4790
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004791// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004792TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004793 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004794 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004795 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004796 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004797 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004798
Sebastian Jansson84848f22018-11-16 10:40:36 +01004799 channel.reset(
4800 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004801 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4802 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004803 channel->SetInterface(network_interface.get(),
4804 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004805 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004806 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004807
Tim Haloun648d28a2018-10-18 16:52:22 -07004808 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4809 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004810 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004811 channel.reset(
4812 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004813 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4814 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004815 channel->SetInterface(network_interface.get(),
4816 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004817 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4818
4819 // Create a send stream to configure
4820 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4821 parameters = channel->GetRtpSendParameters(kSsrc);
4822 ASSERT_FALSE(parameters.encodings.empty());
4823
4824 // Various priorities map to various dscp values.
4825 parameters.encodings[0].network_priority = 4.0;
4826 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004827 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004828 parameters.encodings[0].network_priority = 0.5;
4829 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4830 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4831
4832 // A bad priority does not change the dscp value.
4833 parameters.encodings[0].network_priority = 0.0;
4834 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4835 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004836
Tim Haloun6ca98362018-09-17 17:06:08 -07004837 // Packets should also self-identify their dscp in PacketOptions.
4838 const uint8_t kData[10] = {0};
4839 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4840 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004841 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004842
nisse51542be2016-02-12 02:27:06 -08004843 // Verify that setting the option to false resets the
4844 // DiffServCodePoint.
4845 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004846 channel.reset(
4847 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004848 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4849 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004850 channel->SetInterface(network_interface.get(),
4851 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004852 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004853}
4854
deadbeef13871492015-12-09 12:37:51 -08004855// This test verifies that the RTCP reduced size mode is properly applied to
4856// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004857TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004858 // Create stream, expecting that default mode is "compound".
4859 FakeVideoSendStream* stream1 = AddSendStream();
4860 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004861 webrtc::RtpParameters rtp_parameters =
4862 channel_->GetRtpSendParameters(last_ssrc_);
4863 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004864
4865 // Now enable reduced size mode.
4866 send_parameters_.rtcp.reduced_size = true;
4867 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4868 stream1 = fake_call_->GetVideoSendStreams()[0];
4869 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004870 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4871 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004872
4873 // Create a new stream and ensure it picks up the reduced size mode.
4874 FakeVideoSendStream* stream2 = AddSendStream();
4875 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4876}
4877
4878// This test verifies that the RTCP reduced size mode is properly applied to
4879// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004880TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004881 // Create stream, expecting that default mode is "compound".
4882 FakeVideoReceiveStream* stream1 = AddRecvStream();
4883 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4884
4885 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004886 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4887 // the reduced_size flag should come from that.
4888 send_parameters_.rtcp.reduced_size = true;
4889 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004890 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4891 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4892
4893 // Create a new stream and ensure it picks up the reduced size mode.
4894 FakeVideoReceiveStream* stream2 = AddRecvStream();
4895 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4896}
4897
eladalonf1841382017-06-12 01:16:46 -07004898TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004899 EXPECT_EQ(webrtc::kNetworkUp,
4900 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4901 EXPECT_EQ(webrtc::kNetworkUp,
4902 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004903
4904 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004905 EXPECT_EQ(webrtc::kNetworkDown,
4906 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4907 EXPECT_EQ(webrtc::kNetworkUp,
4908 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004909
4910 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004911 EXPECT_EQ(webrtc::kNetworkUp,
4912 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4913 EXPECT_EQ(webrtc::kNetworkUp,
4914 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004915}
4916
eladalonf1841382017-06-12 01:16:46 -07004917TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004918 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004919 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004920 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004921
4922 AddSendStream();
4923
4924 cricket::VideoMediaInfo info;
4925 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004926 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004927}
4928
eladalonf1841382017-06-12 01:16:46 -07004929TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004930 FakeVideoSendStream* stream = AddSendStream();
4931 webrtc::VideoSendStream::Stats stats;
4932 stats.encoder_implementation_name = "encoder_implementation_name";
4933 stream->SetStats(stats);
4934
4935 cricket::VideoMediaInfo info;
4936 ASSERT_TRUE(channel_->GetStats(&info));
4937 EXPECT_EQ(stats.encoder_implementation_name,
4938 info.senders[0].encoder_implementation_name);
4939}
4940
eladalonf1841382017-06-12 01:16:46 -07004941TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004942 FakeVideoSendStream* stream = AddSendStream();
4943 webrtc::VideoSendStream::Stats stats;
4944 stats.avg_encode_time_ms = 13;
4945 stats.encode_usage_percent = 42;
4946 stream->SetStats(stats);
4947
4948 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004949 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004950 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4951 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4952}
4953
eladalonf1841382017-06-12 01:16:46 -07004954TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004955 FakeVideoSendStream* stream = AddSendStream();
4956 webrtc::VideoSendStream::Stats stats;
4957 stats.frames_encoded = 13;
4958 stream->SetStats(stats);
4959
4960 cricket::VideoMediaInfo info;
4961 ASSERT_TRUE(channel_->GetStats(&info));
4962 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4963}
4964
Rasmus Brandt2efae772019-06-27 14:29:34 +02004965TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
4966 FakeVideoSendStream* stream = AddSendStream();
4967 webrtc::VideoSendStream::Stats stats;
4968 stats.substreams[123].frame_counts.key_frames = 10;
4969 stats.substreams[456].frame_counts.key_frames = 87;
4970 stream->SetStats(stats);
4971
4972 cricket::VideoMediaInfo info;
4973 ASSERT_TRUE(channel_->GetStats(&info));
4974 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
4975 // for each simulcast stream, instead of accumulating all keyframes encoded
4976 // over all simulcast streams in the same outbound-rtp stats object.
4977 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
4978}
4979
eladalonf1841382017-06-12 01:16:46 -07004980TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004981 FakeVideoSendStream* stream = AddSendStream();
4982 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004983 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07004984 stream->SetStats(stats);
4985
4986 cricket::VideoMediaInfo info;
4987 ASSERT_TRUE(channel_->GetStats(&info));
4988 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
4989}
4990
eladalonf1841382017-06-12 01:16:46 -07004991TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00004992 FakeVideoSendStream* stream = AddSendStream();
4993 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00004994 stats.substreams[17].width = 123;
4995 stats.substreams[17].height = 40;
4996 stats.substreams[42].width = 80;
4997 stats.substreams[42].height = 31;
4998 stats.substreams[11].width = 20;
4999 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005000 stream->SetStats(stats);
5001
5002 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005003 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005004 ASSERT_EQ(1u, info.senders.size());
5005 EXPECT_EQ(123, info.senders[0].send_frame_width);
5006 EXPECT_EQ(90, info.senders[0].send_frame_height);
5007}
5008
eladalonf1841382017-06-12 01:16:46 -07005009TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005010 FakeVideoSendStream* stream = AddSendStream();
5011 webrtc::VideoSendStream::Stats stats;
5012 stats.number_of_cpu_adapt_changes = 2;
5013 stats.cpu_limited_resolution = true;
5014 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005015
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005016 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005017 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005018 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005019 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005020 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005021}
5022
eladalonf1841382017-06-12 01:16:46 -07005023TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005024 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005025 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005026 stats.number_of_cpu_adapt_changes = 2;
5027 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005028 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005029 stream->SetStats(stats);
5030
5031 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005032 EXPECT_TRUE(channel_->GetStats(&info));
5033 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005034 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5035 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005036 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005037 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005038}
5039
eladalonf1841382017-06-12 01:16:46 -07005040TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005041 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5042 FakeVideoSendStream* stream = AddSendStream();
5043 webrtc::VideoSendStream::Stats stats;
5044 stats.bw_limited_resolution = true;
5045 stream->SetStats(stats);
5046
5047 cricket::VideoMediaInfo info;
5048 EXPECT_TRUE(channel_->GetStats(&info));
5049 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005050 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005051 info.senders[0].adapt_reason);
5052}
5053
Yves Gerey665174f2018-06-19 15:03:05 +02005054TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005055 FakeVideoSendStream* stream = AddSendStream();
5056 webrtc::VideoSendStream::Stats stats;
5057 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5058 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5059 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5060
5061 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5062 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5063 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5064
5065 stream->SetStats(stats);
5066
5067 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005068 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005069 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5070 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5071 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5072}
5073
eladalonf1841382017-06-12 01:16:46 -07005074TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005075 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5076 FakeVideoReceiveStream* stream = AddRecvStream();
5077 webrtc::VideoReceiveStream::Stats stats;
5078 stats.rtcp_packet_type_counts.fir_packets = 2;
5079 stats.rtcp_packet_type_counts.nack_packets = 3;
5080 stats.rtcp_packet_type_counts.pli_packets = 4;
5081 stream->SetStats(stats);
5082
5083 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005084 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005085 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005086 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005087 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005088 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005089 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005090 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005091}
5092
eladalonf1841382017-06-12 01:16:46 -07005093TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005094 FakeVideoReceiveStream* stream = AddRecvStream();
5095 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005096 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005097 stats.decode_ms = 2;
5098 stats.max_decode_ms = 3;
5099 stats.current_delay_ms = 4;
5100 stats.target_delay_ms = 5;
5101 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005102 stats.jitter_buffer_delay_seconds = 60;
5103 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005104 stats.min_playout_delay_ms = 7;
5105 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005106 stats.width = 9;
5107 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005108 stats.frame_counts.key_frames = 11;
5109 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005110 stats.frames_rendered = 13;
5111 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005112 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005113 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005114 stream->SetStats(stats);
5115
5116 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005117 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005118 EXPECT_EQ(stats.decoder_implementation_name,
5119 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005120 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5121 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5122 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5123 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5124 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005125 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5126 info.receivers[0].jitter_buffer_delay_seconds);
5127 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5128 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005129 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5130 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005131 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5132 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005133 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5134 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005135 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005136 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005137 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005138 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5139 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005140 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005141 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005142}
5143
eladalonf1841382017-06-12 01:16:46 -07005144TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005145 FakeVideoReceiveStream* stream = AddRecvStream();
5146 webrtc::VideoReceiveStream::Stats stats;
5147 stats.rtp_stats.transmitted.payload_bytes = 2;
5148 stats.rtp_stats.transmitted.header_bytes = 3;
5149 stats.rtp_stats.transmitted.padding_bytes = 4;
5150 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005151 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005152 stats.rtcp_stats.fraction_lost = 7;
5153 stream->SetStats(stats);
5154
5155 cricket::VideoMediaInfo info;
5156 ASSERT_TRUE(channel_->GetStats(&info));
5157 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
5158 stats.rtp_stats.transmitted.header_bytes +
5159 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005160 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005161 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005162 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005163 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005164}
5165
eladalonf1841382017-06-12 01:16:46 -07005166TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005167 AddSendStream();
5168 AddSendStream();
5169 webrtc::Call::Stats stats;
5170 stats.rtt_ms = 123;
5171 fake_call_->SetStats(stats);
5172
5173 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005174 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005175 ASSERT_EQ(2u, info.senders.size());
5176 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5177 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5178}
5179
eladalonf1841382017-06-12 01:16:46 -07005180TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005181 FakeVideoSendStream* stream = AddSendStream();
5182 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005183 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005184 stats.media_bitrate_bps = 123;
5185 stats.substreams[17].total_bitrate_bps = 1;
5186 stats.substreams[17].retransmit_bitrate_bps = 2;
5187 stats.substreams[42].total_bitrate_bps = 3;
5188 stats.substreams[42].retransmit_bitrate_bps = 4;
5189 stream->SetStats(stats);
5190
5191 FakeVideoSendStream* stream2 = AddSendStream();
5192 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005193 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005194 stats2.media_bitrate_bps = 321;
5195 stats2.substreams[13].total_bitrate_bps = 5;
5196 stats2.substreams[13].retransmit_bitrate_bps = 6;
5197 stats2.substreams[21].total_bitrate_bps = 7;
5198 stats2.substreams[21].retransmit_bitrate_bps = 8;
5199 stream2->SetStats(stats2);
5200
5201 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005202 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005203 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005204 BandwidthEstimationInfo bwe_info;
5205 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005206 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5207 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5208 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5209 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005210 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005211 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005212 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005213 bwe_info.actual_enc_bitrate);
5214 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005215 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005216 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005217 << "Bandwidth stats should take all streams into account.";
5218}
5219
eladalonf1841382017-06-12 01:16:46 -07005220TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005221 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005222
Peter Boström0c4e06b2015-10-07 12:23:21 +02005223 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5224 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005225
5226 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5227 const size_t kDataLength = 12;
5228 uint8_t data[kDataLength];
5229 memset(data, 0, sizeof(data));
5230 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005231 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005232 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005233
5234 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5235 << "No default receive stream created.";
5236 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005237 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005238 << "Default receive stream should not have configured RTX";
5239
5240 EXPECT_TRUE(channel_->AddRecvStream(
5241 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5242 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005243 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005244 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005245 EXPECT_FALSE(
5246 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005247 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005248 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005249 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005250 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005251 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005252 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005253}
5254
eladalonf1841382017-06-12 01:16:46 -07005255TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005256 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005257
Peter Boström0c4e06b2015-10-07 12:23:21 +02005258 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5259 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005260
5261 StreamParams sp =
5262 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5263 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5264
5265 EXPECT_FALSE(channel_->AddSendStream(sp));
5266 EXPECT_FALSE(channel_->AddRecvStream(sp));
5267}
5268
eladalonf1841382017-06-12 01:16:46 -07005269TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005270 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005271
Peter Boström0c4e06b2015-10-07 12:23:21 +02005272 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5273 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005274
5275 StreamParams sp =
5276 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5277
5278 EXPECT_TRUE(channel_->AddSendStream(sp));
5279 EXPECT_TRUE(channel_->AddRecvStream(sp));
5280
5281 // The RTX SSRC is already used in previous streams, using it should fail.
5282 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5283 EXPECT_FALSE(channel_->AddSendStream(sp));
5284 EXPECT_FALSE(channel_->AddRecvStream(sp));
5285
5286 // After removing the original stream this should be fine to add (makes sure
5287 // that RTX ssrcs are not forever taken).
5288 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5289 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5290 EXPECT_TRUE(channel_->AddSendStream(sp));
5291 EXPECT_TRUE(channel_->AddRecvStream(sp));
5292}
5293
eladalonf1841382017-06-12 01:16:46 -07005294TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005295 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005296 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5297 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005298 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005299
Peter Boströmd6f4c252015-03-26 16:23:04 +01005300 StreamParams sp =
5301 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5302
5303 EXPECT_TRUE(channel_->AddSendStream(sp));
5304 EXPECT_TRUE(channel_->AddRecvStream(sp));
5305
5306 // One of the SSRCs is already used in previous streams, using it should fail.
5307 sp = cricket::CreateSimStreamParams("cname",
5308 MAKE_VECTOR(kOverlappingStreamSsrcs));
5309 EXPECT_FALSE(channel_->AddSendStream(sp));
5310 EXPECT_FALSE(channel_->AddRecvStream(sp));
5311
5312 // After removing the original stream this should be fine to add (makes sure
5313 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005314 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5315 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005316 EXPECT_TRUE(channel_->AddSendStream(sp));
5317 EXPECT_TRUE(channel_->AddRecvStream(sp));
5318}
5319
eladalonf1841382017-06-12 01:16:46 -07005320TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005321 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005322
5323 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5324 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5325
5326 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5327 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5328
5329 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5330
5331 static const uint32_t kReceiverSsrcs[] = {3};
5332 static const uint32_t kReceiverRtxSsrcs[] = {2};
5333
5334 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5335 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5336 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5337
5338 cricket::VideoMediaInfo info;
5339 ASSERT_TRUE(channel_->GetStats(&info));
5340
5341 ASSERT_EQ(1u, info.senders.size());
5342 ASSERT_EQ(1u, info.receivers.size());
5343
5344 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5345 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5346 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5347}
5348
eladalonf1841382017-06-12 01:16:46 -07005349TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005350 FakeVideoReceiveStream* stream = AddRecvStream();
5351 webrtc::VideoReceiveStream::Stats stats;
5352 cricket::VideoMediaInfo info;
5353
5354 // Report no codec name before receiving.
5355 stream->SetStats(stats);
5356 ASSERT_TRUE(channel_->GetStats(&info));
5357 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5358
5359 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005360 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005361 stream->SetStats(stats);
5362 ASSERT_TRUE(channel_->GetStats(&info));
5363 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5364
5365 // Report no codec name for unknown playload types.
5366 stats.current_payload_type = 3;
5367 stream->SetStats(stats);
5368 ASSERT_TRUE(channel_->GetStats(&info));
5369 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5370}
5371
Seth Hampson5897a6e2018-04-03 11:16:33 -07005372// Tests that when we add a stream without SSRCs, but contains a stream_id
5373// that it is stored and its stream id is later used when the first packet
5374// arrives to properly create a receive stream with a sync label.
5375TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5376 const char kSyncLabel[] = "sync_label";
5377 cricket::StreamParams unsignaled_stream;
5378 unsignaled_stream.set_stream_ids({kSyncLabel});
5379 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5380 // The stream shouldn't have been created at this point because it doesn't
5381 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005382 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005383
5384 // Create and deliver packet.
5385 const size_t kDataLength = 12;
5386 uint8_t data[kDataLength];
5387 memset(data, 0, sizeof(data));
5388 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5389 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005390 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005391
5392 // The stream should now be created with the appropriate sync label.
5393 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5394 EXPECT_EQ(kSyncLabel,
5395 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5396
5397 // Removing the unsignaled stream should clear the cache. This time when
5398 // a default video receive stream is created it won't have a sync_group.
5399 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5400 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5401 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5402
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005403 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005404 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5405 EXPECT_TRUE(
5406 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5407}
5408
Ruslan Burakov493a6502019-02-27 15:32:48 +01005409// Test BaseMinimumPlayoutDelayMs on receive streams.
5410TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5411 // Test that set won't work for non-existing receive streams.
5412 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5413 // Test that get won't work for non-existing receive streams.
5414 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5415
5416 EXPECT_TRUE(AddRecvStream());
5417 // Test that set works for the existing receive stream.
5418 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5419 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5420 EXPECT_TRUE(recv_stream);
5421 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5422 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5423 200);
5424}
5425
5426// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5427TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5428 absl::optional<int> delay_ms;
5429 const FakeVideoReceiveStream* recv_stream;
5430
5431 // Set default stream with SSRC 0
5432 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5433 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5434
5435 // Spawn an unsignaled stream by sending a packet, it should inherit
5436 // default delay 200.
5437 const size_t kDataLength = 12;
5438 uint8_t data[kDataLength];
5439 memset(data, 0, sizeof(data));
5440 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5441 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005442 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005443
5444 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5445 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5446 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5447 EXPECT_EQ(200, delay_ms.value_or(0));
5448
5449 // Check that now if we change delay for SSRC 0 it will change delay for the
5450 // default receiving stream as well.
5451 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5452 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5453 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5454 EXPECT_EQ(300, delay_ms.value_or(0));
5455 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5456 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5457}
5458
eladalonf1841382017-06-12 01:16:46 -07005459void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005460 uint8_t payload_type,
5461 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005462 // kRedRtxPayloadType must currently be unused.
5463 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5464
noahricd10a68e2015-07-10 11:27:55 -07005465 // Add a RED RTX codec.
5466 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005467 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005468 recv_parameters_.codecs.push_back(red_rtx_codec);
5469 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005470
5471 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5472 const size_t kDataLength = 12;
5473 uint8_t data[kDataLength];
5474 memset(data, 0, sizeof(data));
5475
5476 rtc::Set8(data, 1, payload_type);
5477 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005478 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005479 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005480
5481 if (expect_created_receive_stream) {
5482 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5483 << "Should have created a receive stream for payload type: "
5484 << payload_type;
5485 } else {
5486 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5487 << "Shouldn't have created a receive stream for payload type: "
5488 << payload_type;
5489 }
5490}
5491
Åsa Persson2c7149b2018-10-15 09:36:10 +02005492class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5493 public:
5494 WebRtcVideoChannelDiscardUnknownSsrcTest()
5495 : WebRtcVideoChannelTest(
5496 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5497};
5498
5499TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5500 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5501 false /* expect_created_receive_stream */);
5502}
5503
eladalonf1841382017-06-12 01:16:46 -07005504TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005505 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5506 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005507}
5508
eladalonf1841382017-06-12 01:16:46 -07005509TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005510 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5511 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005512}
5513
eladalonf1841382017-06-12 01:16:46 -07005514TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005515 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005516 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5517 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5518 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5519 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005520}
5521
eladalonf1841382017-06-12 01:16:46 -07005522TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005523 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5524 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005525}
5526
eladalonf1841382017-06-12 01:16:46 -07005527TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005528 FlexfecPacketDoesntCreateUnsignalledStream) {
5529 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5530 false /* expect_created_receive_stream */);
5531}
5532
eladalonf1841382017-06-12 01:16:46 -07005533TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005534 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5535 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005536}
5537
mzanaty8a855d62017-02-17 15:46:43 -08005538// Test that receiving any unsignalled SSRC works even if it changes.
5539// The first unsignalled SSRC received will create a default receive stream.
5540// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005541TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005542 // Allow receiving VP8, VP9, H264 (if enabled).
5543 cricket::VideoRecvParameters parameters;
5544 parameters.codecs.push_back(GetEngineCodec("VP8"));
5545 parameters.codecs.push_back(GetEngineCodec("VP9"));
5546
5547#if defined(WEBRTC_USE_H264)
5548 cricket::VideoCodec H264codec(126, "H264");
5549 parameters.codecs.push_back(H264codec);
5550#endif
5551
5552 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5553 // No receive streams yet.
5554 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5555 cricket::FakeVideoRenderer renderer;
5556 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5557
5558 // Receive VP8 packet on first SSRC.
5559 uint8_t data[kMinRtpPacketLen];
5560 cricket::RtpHeader rtpHeader;
5561 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5562 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005563 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005564 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5565 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005566 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005567 // VP8 packet should create default receive stream.
5568 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005569 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005570 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5571 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005572 webrtc::VideoFrame video_frame =
5573 webrtc::VideoFrame::Builder()
5574 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5575 .set_timestamp_rtp(100)
5576 .set_timestamp_us(0)
5577 .set_rotation(webrtc::kVideoRotation_0)
5578 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005579 recv_stream->InjectFrame(video_frame);
5580 EXPECT_EQ(1, renderer.num_rendered_frames());
5581
5582 // Receive VP9 packet on second SSRC.
5583 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005584 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005585 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5586 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005587 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005588 // VP9 packet should replace the default receive SSRC.
5589 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5590 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5591 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5592 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005593 webrtc::VideoFrame video_frame2 =
5594 webrtc::VideoFrame::Builder()
5595 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5596 .set_timestamp_rtp(200)
5597 .set_timestamp_us(0)
5598 .set_rotation(webrtc::kVideoRotation_0)
5599 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005600 recv_stream->InjectFrame(video_frame2);
5601 EXPECT_EQ(2, renderer.num_rendered_frames());
5602
5603#if defined(WEBRTC_USE_H264)
5604 // Receive H264 packet on third SSRC.
5605 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005606 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005607 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5608 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005609 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005610 // H264 packet should replace the default receive SSRC.
5611 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5612 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5613 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5614 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005615 webrtc::VideoFrame video_frame3 =
5616 webrtc::VideoFrame::Builder()
5617 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5618 .set_timestamp_rtp(300)
5619 .set_timestamp_us(0)
5620 .set_rotation(webrtc::kVideoRotation_0)
5621 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005622 recv_stream->InjectFrame(video_frame3);
5623 EXPECT_EQ(3, renderer.num_rendered_frames());
5624#endif
5625}
5626
brandtr0dc57ea2017-05-29 23:33:31 -07005627// This test verifies that when a new default stream is created for a new
5628// unsignaled SSRC, the new stream does not overwrite any old stream that had
5629// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005630TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005631 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5632 cricket::VideoRecvParameters parameters;
5633 parameters.codecs.push_back(GetEngineCodec("VP8"));
5634 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5635
5636 // No streams signaled and no packets received, so we should not have any
5637 // stream objects created yet.
5638 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5639
5640 // Receive packet on an unsignaled SSRC.
5641 uint8_t data[kMinRtpPacketLen];
5642 cricket::RtpHeader rtp_header;
5643 rtp_header.payload_type = GetEngineCodec("VP8").id;
5644 rtp_header.seq_num = rtp_header.timestamp = 0;
5645 rtp_header.ssrc = kSsrcs3[0];
5646 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5647 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005648 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005649 // Default receive stream should be created.
5650 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5651 FakeVideoReceiveStream* recv_stream0 =
5652 fake_call_->GetVideoReceiveStreams()[0];
5653 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5654
5655 // Signal the SSRC.
5656 EXPECT_TRUE(
5657 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5658 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5659 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5660 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5661
5662 // Receive packet on a different unsignaled SSRC.
5663 rtp_header.ssrc = kSsrcs3[1];
5664 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5665 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005666 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005667 // New default receive stream should be created, but old stream should remain.
5668 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5669 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5670 FakeVideoReceiveStream* recv_stream1 =
5671 fake_call_->GetVideoReceiveStreams()[1];
5672 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5673}
5674
Seth Hampson7c682e02018-05-04 16:28:15 -07005675TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005676 AddSendStream();
5677
Niels Möller805a27e2019-01-21 12:21:27 +01005678 webrtc::test::FrameForwarder frame_forwarder;
5679 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005680 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005681 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005682
perkjfa10b552016-10-02 23:45:26 -07005683 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005684 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005685
5686 // TODO(skvlad): Resolve the inconsistency between the interpretation
5687 // of the global bitrate limit for audio and video:
5688 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5689 // max_bandwidth_bps = -1 - remove the bandwidth limit
5690 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005691 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005692
perkjfa10b552016-10-02 23:45:26 -07005693 SetAndExpectMaxBitrate(1000, 0, 1000);
5694 SetAndExpectMaxBitrate(1000, 800, 800);
5695 SetAndExpectMaxBitrate(600, 800, 600);
5696 SetAndExpectMaxBitrate(0, 800, 800);
5697 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005698
Niels Möllerff40b142018-04-09 08:49:14 +02005699 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005700}
5701
eladalonf1841382017-06-12 01:16:46 -07005702TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005703 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005704 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005705 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005706
5707 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005708 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005709 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005710}
5711
eladalonf1841382017-06-12 01:16:46 -07005712TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005713 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005714 FakeVideoSendStream* stream = AddSendStream();
5715
Seth Hampson7c682e02018-05-04 16:28:15 -07005716 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5717 EXPECT_EQ(1UL, parameters.encodings.size());
5718 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5719 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5720
5721 // Note that this is testing the behavior of the FakeVideoSendStream, which
5722 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5723 // we are just testing the behavior of
5724 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005725 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5726 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005727
5728 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5729 // by this amount.
5730 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5731 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5732 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5733 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5734
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005735 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5736 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5737 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5738}
5739
5740TEST_F(WebRtcVideoChannelTest,
5741 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5742 FakeVideoSendStream* stream = AddSendStream();
5743
5744 // Note that this is testing the behavior of the FakeVideoSendStream, which
5745 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5746 // we are just testing the behavior of
5747 // EncoderStreamFactory::CreateEncoderStreams.
5748 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5749 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5750
5751 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5752 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5753 EXPECT_EQ(1UL, parameters.encodings.size());
5754 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5755 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5756
5757 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5758 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5759 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5760}
5761
5762TEST_F(WebRtcVideoChannelTest,
5763 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5764 send_parameters_.max_bandwidth_bps = 99999;
5765 FakeVideoSendStream* stream = AddSendStream();
5766 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5767 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5768 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5769 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5770 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5771 stream->GetVideoStreams()[0].max_bitrate_bps);
5772
5773 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5774 // adjusted down.
5775 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5776 EXPECT_EQ(1UL, parameters.encodings.size());
5777 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5778 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5779 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5780 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5781 stream->GetVideoStreams()[0].min_bitrate_bps);
5782 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5783 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005784}
5785
Åsa Persson8c1bf952018-09-13 10:42:19 +02005786TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5787 FakeVideoSendStream* stream = AddSendStream();
5788
5789 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5790 EXPECT_EQ(1UL, parameters.encodings.size());
5791 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5792 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5793
5794 // Note that this is testing the behavior of the FakeVideoSendStream, which
5795 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5796 // we are just testing the behavior of
5797 // EncoderStreamFactory::CreateEncoderStreams.
5798 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5799 EXPECT_EQ(kDefaultVideoMaxFramerate,
5800 stream->GetVideoStreams()[0].max_framerate);
5801
5802 // Set max framerate and check that VideoStream.max_framerate is set.
5803 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5804 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5805 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5806 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5807
5808 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5809 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5810}
5811
Åsa Persson23eba222018-10-02 14:47:06 +02005812TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5813 FakeVideoSendStream* stream = AddSendStream();
5814
5815 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5816 EXPECT_EQ(1UL, parameters.encodings.size());
5817 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5818 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5819
5820 // Note that this is testing the behavior of the FakeVideoSendStream, which
5821 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5822 // we are just testing the behavior of
5823 // EncoderStreamFactory::CreateEncoderStreams.
5824 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5825 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5826
5827 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5828 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5829 parameters.encodings[0].num_temporal_layers = 2;
5830 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5831
5832 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5833 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5834}
5835
Seth Hampson7c682e02018-05-04 16:28:15 -07005836TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005837 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005838 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005839 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005840 // Two or more encodings should result in failure.
5841 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005842 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005843 // Zero encodings should also fail.
5844 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005845 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005846}
5847
Zach Stein3ca452b2018-01-18 10:01:24 -08005848TEST_F(WebRtcVideoChannelTest,
5849 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5850 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5851 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5852 AddSendStream(sp);
5853
5854 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5855
5856 // Additional encodings should result in failure.
5857 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005858 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005859 // Zero encodings should also fail.
5860 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005861 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005862}
5863
deadbeeffb2aced2017-01-06 23:05:37 -08005864// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005865TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005866 AddSendStream();
5867 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005868 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005869 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005870}
5871
Seth Hampson24722b32017-12-22 09:36:42 -08005872// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5873// a value <= 0, setting the parameters returns false.
5874TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5875 AddSendStream();
5876 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5877 EXPECT_EQ(1UL, parameters.encodings.size());
5878 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5879 parameters.encodings[0].bitrate_priority);
5880
5881 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005882 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005883 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005884 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005885}
5886
5887// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5888// properly on the VideoChannel and propogates down to the video encoder.
5889TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5890 AddSendStream();
5891 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5892 EXPECT_EQ(1UL, parameters.encodings.size());
5893 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5894 parameters.encodings[0].bitrate_priority);
5895
5896 // Change the value and set it on the VideoChannel.
5897 double new_bitrate_priority = 2.0;
5898 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005899 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005900
5901 // Verify that the encoding parameters bitrate_priority is set for the
5902 // VideoChannel.
5903 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5904 EXPECT_EQ(1UL, parameters.encodings.size());
5905 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5906
5907 // Verify that the new value propagated down to the encoder.
5908 std::vector<FakeVideoSendStream*> video_send_streams =
5909 fake_call_->GetVideoSendStreams();
5910 EXPECT_EQ(1UL, video_send_streams.size());
5911 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5912 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5913 // appropriately.
5914 EXPECT_EQ(new_bitrate_priority,
5915 video_send_stream->GetEncoderConfig().bitrate_priority);
5916 // Check that the vector of VideoStreams also was propagated correctly. Note
5917 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5918 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005919 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005920 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5921}
5922
5923// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5924// VideoChannel and the value propogates to the video encoder with all simulcast
5925// streams.
5926TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5927 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005928 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005929 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5930 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5931 AddSendStream(stream_params);
5932 uint32_t primary_ssrc = stream_params.first_ssrc();
5933
Niels Möller805a27e2019-01-21 12:21:27 +01005934 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005935 // frame. This creates multiple VideoStreams for all simulcast layers when
5936 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005937 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005938 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005939 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005940 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005941 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5942 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5943 rtc::kNumMicrosecsPerSec / 30));
5944
Seth Hampson24722b32017-12-22 09:36:42 -08005945 // Get and set the rtp encoding parameters.
5946 webrtc::RtpParameters parameters =
5947 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005948 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005949 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5950 parameters.encodings[0].bitrate_priority);
5951 // Change the value and set it on the VideoChannel.
5952 double new_bitrate_priority = 2.0;
5953 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005954 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005955
5956 // Verify that the encoding parameters priority is set on the VideoChannel.
5957 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005958 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005959 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5960
5961 // Verify that the new value propagated down to the encoder.
5962 std::vector<FakeVideoSendStream*> video_send_streams =
5963 fake_call_->GetVideoSendStreams();
5964 EXPECT_EQ(1UL, video_send_streams.size());
5965 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5966 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5967 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005968 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005969 video_send_stream->GetEncoderConfig().number_of_streams);
5970 EXPECT_EQ(new_bitrate_priority,
5971 video_send_stream->GetEncoderConfig().bitrate_priority);
5972 // Check that the vector of VideoStreams also propagated correctly. The
5973 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5974 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005975 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005976 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005977 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5978 // Since we are only setting bitrate priority per-sender, the other
5979 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005980 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005981 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005982 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005983 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02005984 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08005985}
5986
Tim Haloun648d28a2018-10-18 16:52:22 -07005987// RTCRtpEncodingParameters.network_priority must be one of a few values
5988// derived from the default priority, corresponding to very-low, low, medium,
5989// or high.
5990TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
5991 AddSendStream();
5992 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5993 EXPECT_EQ(1UL, parameters.encodings.size());
5994 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5995 parameters.encodings[0].network_priority);
5996
5997 double good_values[] = {0.5, 1.0, 2.0, 4.0};
5998 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
5999 for (auto it : good_values) {
6000 parameters.encodings[0].network_priority = it;
6001 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6002 }
6003 for (auto it : bad_values) {
6004 parameters.encodings[0].network_priority = it;
6005 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6006 }
6007}
6008
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006009TEST_F(WebRtcVideoChannelTest,
6010 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006011 VideoSendParameters parameters;
6012 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006013 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6014 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6015
6016 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006017 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006018
6019 VideoOptions options;
6020 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6021 channel_->SetSend(true);
6022
6023 // Try layers in natural order (smallest to largest).
6024 {
6025 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6026 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6027 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6028 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6029 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6030 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6031 ASSERT_TRUE(result.ok());
6032
6033 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6034
6035 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6036 ASSERT_EQ(3u, video_streams.size());
6037 EXPECT_EQ(320u, video_streams[0].width);
6038 EXPECT_EQ(180u, video_streams[0].height);
6039 EXPECT_EQ(640u, video_streams[1].width);
6040 EXPECT_EQ(360u, video_streams[1].height);
6041 EXPECT_EQ(1280u, video_streams[2].width);
6042 EXPECT_EQ(720u, video_streams[2].height);
6043 }
6044
6045 // Try layers in reverse natural order (largest to smallest).
6046 {
6047 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6048 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6049 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6050 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6051 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6052 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6053 ASSERT_TRUE(result.ok());
6054
6055 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6056
6057 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6058 ASSERT_EQ(3u, video_streams.size());
6059 EXPECT_EQ(1280u, video_streams[0].width);
6060 EXPECT_EQ(720u, video_streams[0].height);
6061 EXPECT_EQ(640u, video_streams[1].width);
6062 EXPECT_EQ(360u, video_streams[1].height);
6063 EXPECT_EQ(320u, video_streams[2].width);
6064 EXPECT_EQ(180u, video_streams[2].height);
6065 }
6066
6067 // Try layers in mixed order.
6068 {
6069 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6070 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6071 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6072 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6073 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6074 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6075 ASSERT_TRUE(result.ok());
6076
6077 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6078
6079 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6080 ASSERT_EQ(3u, video_streams.size());
6081 EXPECT_EQ(128u, video_streams[0].width);
6082 EXPECT_EQ(72u, video_streams[0].height);
6083 EXPECT_EQ(640u, video_streams[1].width);
6084 EXPECT_EQ(360u, video_streams[1].height);
6085 EXPECT_EQ(320u, video_streams[2].width);
6086 EXPECT_EQ(180u, video_streams[2].height);
6087 }
6088
6089 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6090 {
6091 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6092 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6093 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6094 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6095 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6096 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6097 ASSERT_TRUE(result.ok());
6098
6099 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6100
6101 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6102 ASSERT_EQ(3u, video_streams.size());
6103 EXPECT_EQ(1280u, video_streams[0].width);
6104 EXPECT_EQ(720u, video_streams[0].height);
6105 EXPECT_EQ(1280u, video_streams[1].width);
6106 EXPECT_EQ(720u, video_streams[1].height);
6107 EXPECT_EQ(320u, video_streams[2].width);
6108 EXPECT_EQ(180u, video_streams[2].height);
6109 }
6110
6111 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6112}
6113
6114TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006115 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6116 // Ensure that the top layer has width and height divisible by 2^3,
6117 // so that the bottom layer has width and height divisible by 2.
6118 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6119 // the number of simulcast layers set by the app.
6120 webrtc::test::ScopedFieldTrials field_trial(
6121 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6122
6123 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6124 VideoSendParameters parameters;
6125 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6126 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6127 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6128 webrtc::test::FrameForwarder frame_forwarder;
6129 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6130 &frame_forwarder));
6131 channel_->SetSend(true);
6132
6133 // Set |scale_resolution_down_by|'s.
6134 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6135 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6136 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6137 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6138 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6139 const auto result =
6140 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6141 ASSERT_TRUE(result.ok());
6142
6143 // Use a capture resolution whose width and height are not divisible by 2^3.
6144 // (See field trial set at the top of the test.)
6145 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6146 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6147
6148 // Ensure the scaling is correct.
6149 const auto video_streams = stream->GetVideoStreams();
6150 ASSERT_EQ(video_streams.size(), 3u);
6151 // Ensure that we round the capture resolution down for the top layer...
6152 EXPECT_EQ(video_streams[0].width, 2000u);
6153 EXPECT_EQ(video_streams[0].height, 1200u);
6154 EXPECT_EQ(video_streams[1].width, 1000u);
6155 EXPECT_EQ(video_streams[1].height, 600u);
6156 // ...and that the bottom layer has a width/height divisible by 2.
6157 EXPECT_EQ(video_streams[2].width, 500u);
6158 EXPECT_EQ(video_streams[2].height, 300u);
6159
6160 // Tear down.
6161 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6162}
6163
6164TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006165 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006166 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6167 VideoSendParameters parameters;
6168 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006169 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6170 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6171
6172 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006173 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006174
6175 VideoOptions options;
6176 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6177 channel_->SetSend(true);
6178
6179 // Try layers in natural order (smallest to largest).
6180 {
6181 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6182 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6183 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6184 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6185 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6186 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6187 ASSERT_TRUE(result.ok());
6188
6189 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6190
6191 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6192 ASSERT_EQ(3u, video_streams.size());
6193 EXPECT_EQ(320u, video_streams[0].width);
6194 EXPECT_EQ(180u, video_streams[0].height);
6195 EXPECT_EQ(640u, video_streams[1].width);
6196 EXPECT_EQ(360u, video_streams[1].height);
6197 EXPECT_EQ(1280u, video_streams[2].width);
6198 EXPECT_EQ(720u, video_streams[2].height);
6199 }
6200
6201 // Try layers in reverse natural order (largest to smallest).
6202 {
6203 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6204 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6205 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6206 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6207 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6208 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6209 ASSERT_TRUE(result.ok());
6210
6211 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6212
6213 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6214 ASSERT_EQ(3u, video_streams.size());
6215 EXPECT_EQ(1280u, video_streams[0].width);
6216 EXPECT_EQ(720u, video_streams[0].height);
6217 EXPECT_EQ(640u, video_streams[1].width);
6218 EXPECT_EQ(360u, video_streams[1].height);
6219 EXPECT_EQ(320u, video_streams[2].width);
6220 EXPECT_EQ(180u, video_streams[2].height);
6221 }
6222
6223 // Try layers in mixed order.
6224 {
6225 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6226 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6227 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6228 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6229 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6230 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6231 ASSERT_TRUE(result.ok());
6232
6233 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6234
6235 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6236 ASSERT_EQ(3u, video_streams.size());
6237 EXPECT_EQ(128u, video_streams[0].width);
6238 EXPECT_EQ(72u, video_streams[0].height);
6239 EXPECT_EQ(640u, video_streams[1].width);
6240 EXPECT_EQ(360u, video_streams[1].height);
6241 EXPECT_EQ(320u, video_streams[2].width);
6242 EXPECT_EQ(180u, video_streams[2].height);
6243 }
6244
6245 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6246 {
6247 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6248 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6249 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6250 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6251 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6252 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6253 ASSERT_TRUE(result.ok());
6254
6255 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6256
6257 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6258 ASSERT_EQ(3u, video_streams.size());
6259 EXPECT_EQ(1280u, video_streams[0].width);
6260 EXPECT_EQ(720u, video_streams[0].height);
6261 EXPECT_EQ(1280u, video_streams[1].width);
6262 EXPECT_EQ(720u, video_streams[1].height);
6263 EXPECT_EQ(320u, video_streams[2].width);
6264 EXPECT_EQ(180u, video_streams[2].height);
6265 }
6266 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6267}
6268
Rasmus Brandt9387b522019-02-05 14:23:26 +01006269TEST_F(WebRtcVideoChannelTest,
6270 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6271 // Ensure that the top layer has width and height divisible by 2^3,
6272 // so that the bottom layer has width and height divisible by 2.
6273 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6274 // the number of simulcast layers set by the app.
6275 webrtc::test::ScopedFieldTrials field_trial(
6276 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6277
6278 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6279 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6280 VideoSendParameters parameters;
6281 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6282 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6283 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6284 webrtc::test::FrameForwarder frame_forwarder;
6285 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6286 &frame_forwarder));
6287 channel_->SetSend(true);
6288
6289 // Set |scale_resolution_down_by|'s.
6290 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6291 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6292 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6293 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6294 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6295 const auto result =
6296 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6297 ASSERT_TRUE(result.ok());
6298
6299 // Use a capture resolution whose width and height are not divisible by 2^3.
6300 // (See field trial set at the top of the test.)
6301 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6302 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6303
6304 // Ensure the scaling is correct.
6305 const auto video_streams = stream->GetVideoStreams();
6306 ASSERT_EQ(video_streams.size(), 3u);
6307 // Ensure that we round the capture resolution down for the top layer...
6308 EXPECT_EQ(video_streams[0].width, 2000u);
6309 EXPECT_EQ(video_streams[0].height, 1200u);
6310 EXPECT_EQ(video_streams[1].width, 1000u);
6311 EXPECT_EQ(video_streams[1].height, 600u);
6312 // ...and that the bottom layer has a width/height divisible by 2.
6313 EXPECT_EQ(video_streams[2].width, 500u);
6314 EXPECT_EQ(video_streams[2].height, 300u);
6315
6316 // Tear down.
6317 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6318}
6319
Åsa Persson8c1bf952018-09-13 10:42:19 +02006320TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6321 const size_t kNumSimulcastStreams = 3;
6322 SetUpSimulcast(true, false);
6323
6324 // Get and set the rtp encoding parameters.
6325 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6326 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6327 for (const auto& encoding : parameters.encodings) {
6328 EXPECT_FALSE(encoding.max_framerate);
6329 }
6330
6331 // Change the value and set it on the VideoChannel.
6332 parameters.encodings[0].max_framerate = 10;
6333 parameters.encodings[1].max_framerate = 20;
6334 parameters.encodings[2].max_framerate = 25;
6335 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6336
6337 // Verify that the bitrates are set on the VideoChannel.
6338 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6339 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6340 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6341 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6342 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6343}
6344
Åsa Persson23eba222018-10-02 14:47:06 +02006345TEST_F(WebRtcVideoChannelTest,
6346 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6347 const size_t kNumSimulcastStreams = 3;
6348 SetUpSimulcast(true, false);
6349
6350 // Get and set the rtp encoding parameters.
6351 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6352 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6353
6354 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6355 parameters.encodings[0].num_temporal_layers = 0;
6356 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6357 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6358 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6359 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6360 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6361}
6362
6363TEST_F(WebRtcVideoChannelTest,
6364 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6365 const size_t kNumSimulcastStreams = 3;
6366 SetUpSimulcast(true, false);
6367
6368 // Get and set the rtp encoding parameters.
6369 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6370 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6371
6372 // No/all layers should be set.
6373 parameters.encodings[0].num_temporal_layers = 1;
6374 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6375 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6376
6377 // Different values not supported.
6378 parameters.encodings[0].num_temporal_layers = 1;
6379 parameters.encodings[1].num_temporal_layers = 2;
6380 parameters.encodings[2].num_temporal_layers = 2;
6381 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6382 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6383}
6384
6385TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6386 const size_t kNumSimulcastStreams = 3;
6387 SetUpSimulcast(true, false);
6388
6389 // Get and set the rtp encoding parameters.
6390 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6391 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6392 for (const auto& encoding : parameters.encodings)
6393 EXPECT_FALSE(encoding.num_temporal_layers);
6394
6395 // Change the value and set it on the VideoChannel.
6396 parameters.encodings[0].num_temporal_layers = 3;
6397 parameters.encodings[1].num_temporal_layers = 3;
6398 parameters.encodings[2].num_temporal_layers = 3;
6399 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6400
6401 // Verify that the number of temporal layers are set on the VideoChannel.
6402 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6403 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6404 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6405 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6406 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6407}
6408
6409TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6410 const size_t kNumSimulcastStreams = 3;
6411 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6412
6413 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006414 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006415 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006416 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006417 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006418 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006419
6420 // Get and set the rtp encoding parameters.
6421 // Change the value and set it on the VideoChannel.
6422 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6423 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6424 parameters.encodings[0].num_temporal_layers = 2;
6425 parameters.encodings[1].num_temporal_layers = 2;
6426 parameters.encodings[2].num_temporal_layers = 2;
6427 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6428
6429 // Verify that the new value is propagated down to the encoder.
6430 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6431 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6432 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6433 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6434 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6435 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6436 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6437 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6438
6439 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6440 // VideoStreams are created appropriately for the simulcast case.
6441 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6442 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6443 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6444 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6445
6446 // No parameter changed, encoder should not be reconfigured.
6447 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6448 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6449
6450 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6451}
6452
6453TEST_F(WebRtcVideoChannelTest,
6454 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6455 const size_t kDefaultNumTemporalLayers = 3;
6456 const size_t kNumSimulcastStreams = 3;
6457 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6458
6459 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006460 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006461 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006462 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006463 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006464 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006465
6466 // Change rtp encoding parameters, num_temporal_layers not changed.
6467 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6468 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6469 parameters.encodings[0].min_bitrate_bps = 33000;
6470 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6471
6472 // Verify that no value is propagated down to the encoder.
6473 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6474 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6475 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6476 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6477 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6478 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6479
6480 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6481 // VideoStreams are created appropriately for the simulcast case.
6482 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6483 EXPECT_EQ(kDefaultNumTemporalLayers,
6484 stream->GetVideoStreams()[0].num_temporal_layers);
6485 EXPECT_EQ(kDefaultNumTemporalLayers,
6486 stream->GetVideoStreams()[1].num_temporal_layers);
6487 EXPECT_EQ(kDefaultNumTemporalLayers,
6488 stream->GetVideoStreams()[2].num_temporal_layers);
6489
6490 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6491}
6492
Åsa Persson8c1bf952018-09-13 10:42:19 +02006493TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6494 const size_t kNumSimulcastStreams = 3;
6495 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6496
6497 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006498 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006499 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006500 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006501 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006502 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006503
6504 // Get and set the rtp encoding parameters.
6505 // Change the value and set it on the VideoChannel.
6506 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6507 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6508 parameters.encodings[0].max_framerate = 15;
6509 parameters.encodings[1].max_framerate = 25;
6510 parameters.encodings[2].max_framerate = 20;
6511 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6512
6513 // Verify that the new value propagated down to the encoder.
6514 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6515 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6516 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6517 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6518 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6519 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6520 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6521 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6522
6523 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6524 // VideoStreams are created appropriately for the simulcast case.
6525 // Currently the maximum |max_framerate| is used.
6526 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6527 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6528 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6529 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6530
6531 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6532}
6533
6534TEST_F(WebRtcVideoChannelTest,
6535 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6536 const size_t kNumSimulcastStreams = 3;
6537 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6538 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6539
6540 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006541 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006542 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006543 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006544 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006545 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006546
6547 // Get and set the rtp encoding parameters.
6548 // Change the value and set it on the VideoChannel.
6549 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6550 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6551 parameters.encodings[0].max_framerate = 15;
6552 parameters.encodings[2].max_framerate = 20;
6553 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6554
6555 // Verify that the new value propagated down to the encoder.
6556 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6557 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6558 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6559 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6560 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6561 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6562 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6563
6564 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6565 // VideoStreams are created appropriately for the simulcast case.
6566 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6567 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6568 EXPECT_EQ(kDefaultVideoMaxFramerate,
6569 stream->GetVideoStreams()[0].max_framerate);
6570 EXPECT_EQ(kDefaultVideoMaxFramerate,
6571 stream->GetVideoStreams()[1].max_framerate);
6572 EXPECT_EQ(kDefaultVideoMaxFramerate,
6573 stream->GetVideoStreams()[2].max_framerate);
6574
6575 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6576}
6577
Åsa Persson55659812018-06-18 17:51:32 +02006578TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6579 const size_t kNumSimulcastStreams = 3;
6580 SetUpSimulcast(true, false);
6581
6582 // Get and set the rtp encoding parameters.
6583 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6584 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6585 for (const auto& encoding : parameters.encodings) {
6586 EXPECT_FALSE(encoding.min_bitrate_bps);
6587 EXPECT_FALSE(encoding.max_bitrate_bps);
6588 }
6589
6590 // Change the value and set it on the VideoChannel.
6591 parameters.encodings[0].min_bitrate_bps = 100000;
6592 parameters.encodings[0].max_bitrate_bps = 200000;
6593 parameters.encodings[1].min_bitrate_bps = 300000;
6594 parameters.encodings[1].max_bitrate_bps = 400000;
6595 parameters.encodings[2].min_bitrate_bps = 500000;
6596 parameters.encodings[2].max_bitrate_bps = 600000;
6597 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6598
6599 // Verify that the bitrates are set on the VideoChannel.
6600 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6601 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6602 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6603 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6604 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6605 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6606 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6607 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6608}
6609
6610TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6611 const size_t kNumSimulcastStreams = 3;
6612 SetUpSimulcast(true, false);
6613
6614 // Get and set the rtp encoding parameters.
6615 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6616 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6617
6618 // Max bitrate lower than min bitrate should fail.
6619 parameters.encodings[2].min_bitrate_bps = 100000;
6620 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6621 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6622 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6623}
6624
6625// Test that min and max bitrate values set via RtpParameters are correctly
6626// propagated to the underlying encoder, and that the target is set to 3/4 of
6627// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6628// that are used if no min/max are specified).
6629TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6630 const size_t kNumSimulcastStreams = 3;
6631 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6632
6633 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006634 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006635 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006636 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006637 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006638 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006639
6640 // Get and set the rtp encoding parameters.
6641 // Change the value and set it on the VideoChannel.
6642 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6643 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6644 parameters.encodings[0].min_bitrate_bps = 100000;
6645 parameters.encodings[0].max_bitrate_bps = 200000;
6646 parameters.encodings[1].min_bitrate_bps = 300000;
6647 parameters.encodings[1].max_bitrate_bps = 400000;
6648 parameters.encodings[2].min_bitrate_bps = 500000;
6649 parameters.encodings[2].max_bitrate_bps = 600000;
6650 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6651
6652 // Verify that the new value propagated down to the encoder.
6653 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6654 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6655 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6656 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6657 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6658 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6659 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6660 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6661 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6662 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6663 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6664
6665 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6666 // VideoStreams are created appropriately for the simulcast case.
6667 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6668 // Target bitrate: 200000 * 3 / 4 = 150000.
6669 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6670 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6671 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6672 // Target bitrate: 400000 * 3 / 4 = 300000.
6673 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6674 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6675 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6676 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6677 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6678 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6679 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6680
6681 // No parameter changed, encoder should not be reconfigured.
6682 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6683 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6684
6685 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6686}
6687
6688// Test to only specify the min or max bitrate value for a layer via
6689// RtpParameters. The unspecified min/max and target value should be set to the
6690// simulcast default that is used if no min/max are specified.
6691TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6692 const size_t kNumSimulcastStreams = 3;
6693 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6694 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6695
6696 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006697 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006698 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006699 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006700 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006701 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006702
6703 // Get and set the rtp encoding parameters.
6704 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6705 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6706
6707 // Change the value and set it on the VideoChannel.
6708 // Layer 0: only configure min bitrate.
6709 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6710 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6711 // Layer 1: only configure max bitrate.
6712 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6713 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6714 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6715
6716 // Verify that the new value propagated down to the encoder.
6717 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6718 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6719 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6720 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6721 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6722 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6723 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6724 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6725 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6726 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6727
6728 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6729 // VideoStreams are created appropriately for the simulcast case.
6730 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6731 // Layer 0: min configured bitrate should overwrite min default.
6732 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6733 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6734 stream->GetVideoStreams()[0].target_bitrate_bps);
6735 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6736 stream->GetVideoStreams()[0].max_bitrate_bps);
6737 // Layer 1: max configured bitrate should overwrite max default.
6738 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6739 stream->GetVideoStreams()[1].min_bitrate_bps);
6740 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6741 stream->GetVideoStreams()[1].target_bitrate_bps);
6742 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6743 // Layer 2: min and max bitrate not configured, default expected.
6744 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6745 stream->GetVideoStreams()[2].min_bitrate_bps);
6746 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6747 stream->GetVideoStreams()[2].target_bitrate_bps);
6748 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6749 stream->GetVideoStreams()[2].max_bitrate_bps);
6750
6751 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6752}
6753
6754// Test that specifying the min (or max) bitrate value for a layer via
6755// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6756// unspecified values accordingly.
6757TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6758 const size_t kNumSimulcastStreams = 3;
6759 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6760 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6761
6762 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006763 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006764 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006765 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006766 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006767 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006768
6769 // Get and set the rtp encoding parameters.
6770 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6771 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6772
6773 // Change the value and set it on the VideoChannel.
6774 // For layer 0, set the min bitrate above the default max.
6775 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6776 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6777 // For layer 1, set the max bitrate below the default min.
6778 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6779 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6780 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6781
6782 // Verify that the new value propagated down to the encoder.
6783 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6784 // VideoStreams are created appropriately for the simulcast case.
6785 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6786 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6787 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6788 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6789 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6790 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6791 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6792 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6793 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6794 // Layer 2: min and max bitrate not configured, default expected.
6795 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6796 stream->GetVideoStreams()[2].min_bitrate_bps);
6797 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6798 stream->GetVideoStreams()[2].target_bitrate_bps);
6799 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6800 stream->GetVideoStreams()[2].max_bitrate_bps);
6801
6802 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6803}
6804
6805TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6806 const size_t kNumSimulcastStreams = 3;
6807 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6808 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6809
6810 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006811 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006812 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006813 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006814 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006815 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006816
6817 // Set max bitrate for all but the highest layer.
6818 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6819 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6820 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6821 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6822 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6823
6824 // Set max bandwidth equal to total max bitrate.
6825 send_parameters_.max_bandwidth_bps =
6826 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6827 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6828 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6829
6830 // No bitrate above the total max to give to the highest layer.
6831 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6832 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6833 stream->GetVideoStreams()[2].max_bitrate_bps);
6834
6835 // Set max bandwidth above the total max bitrate.
6836 send_parameters_.max_bandwidth_bps =
6837 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6838 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6839 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6840
6841 // The highest layer has no max bitrate set -> the bitrate above the total
6842 // max should be given to the highest layer.
6843 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6844 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6845 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6846 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6847 stream->GetVideoStreams()[2].max_bitrate_bps);
6848
6849 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6850}
6851
6852TEST_F(WebRtcVideoChannelTest,
6853 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6854 const size_t kNumSimulcastStreams = 3;
6855 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6856 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6857 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6858
6859 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006860 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006861 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006862 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006863 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006864 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006865
6866 // Set max bitrate for the highest layer.
6867 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6868 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6869 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6870 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6871
6872 // Set max bandwidth above the total max bitrate.
6873 send_parameters_.max_bandwidth_bps =
6874 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6875 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6876 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6877
6878 // The highest layer has the max bitrate set -> the bitrate above the total
6879 // max should not be given to the highest layer.
6880 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6881 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6882 stream->GetVideoStreams()[2].max_bitrate_bps);
6883
6884 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6885}
6886
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006887// Test that min and max bitrate values set via RtpParameters are correctly
6888// propagated to the underlying encoder for a single stream.
6889TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6890 FakeVideoSendStream* stream = AddSendStream();
6891 EXPECT_TRUE(channel_->SetSend(true));
6892 EXPECT_TRUE(stream->IsSending());
6893
6894 // Set min and max bitrate.
6895 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6896 EXPECT_EQ(1u, parameters.encodings.size());
6897 parameters.encodings[0].min_bitrate_bps = 80000;
6898 parameters.encodings[0].max_bitrate_bps = 150000;
6899 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6900
6901 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6902 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6903 EXPECT_EQ(1u, encoder_config.number_of_streams);
6904 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6905 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6906 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6907
6908 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6909 // VideoStreams are created appropriately.
6910 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6911 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6912 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6913 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6914}
6915
6916// Test the default min and max bitrate value are correctly propagated to the
6917// underlying encoder for a single stream (when the values are not set via
6918// RtpParameters).
6919TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6920 FakeVideoSendStream* stream = AddSendStream();
6921 EXPECT_TRUE(channel_->SetSend(true));
6922 EXPECT_TRUE(stream->IsSending());
6923
6924 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6925 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6926 EXPECT_EQ(1u, encoder_config.number_of_streams);
6927 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6928 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6929 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6930
6931 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6932 // VideoStreams are created appropriately.
6933 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6934 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6935 stream->GetVideoStreams()[0].min_bitrate_bps);
6936 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6937 stream->GetVideoStreams()[0].min_bitrate_bps);
6938 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6939 stream->GetVideoStreams()[0].target_bitrate_bps);
6940}
6941
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006942// Test that a stream will not be sending if its encoding is made inactive
6943// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006944TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006945 FakeVideoSendStream* stream = AddSendStream();
6946 EXPECT_TRUE(channel_->SetSend(true));
6947 EXPECT_TRUE(stream->IsSending());
6948
6949 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006950 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006951 ASSERT_EQ(1u, parameters.encodings.size());
6952 ASSERT_TRUE(parameters.encodings[0].active);
6953 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006954 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006955 EXPECT_FALSE(stream->IsSending());
6956
6957 // Now change it back to active and verify we resume sending.
6958 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006959 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006960 EXPECT_TRUE(stream->IsSending());
6961}
6962
Seth Hampson8234ead2018-02-02 15:16:24 -08006963// Tests that when active is updated for any simulcast layer then the send
6964// stream's sending state will be updated and it will be reconfigured with the
6965// new appropriate active simulcast streams.
6966TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6967 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006968 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006969 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6970 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6971 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6972 uint32_t primary_ssrc = stream_params.first_ssrc();
6973
Niels Möller805a27e2019-01-21 12:21:27 +01006974 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006975 // frame. This allows us to test that ReconfigureEncoder is called
6976 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006977 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006978 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006979 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006980 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006981 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6982 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6983 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08006984
6985 // Check that all encodings are initially active.
6986 webrtc::RtpParameters parameters =
6987 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006988 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08006989 EXPECT_TRUE(parameters.encodings[0].active);
6990 EXPECT_TRUE(parameters.encodings[1].active);
6991 EXPECT_TRUE(parameters.encodings[2].active);
6992 EXPECT_TRUE(fake_video_send_stream->IsSending());
6993
6994 // Only turn on only the middle stream.
6995 parameters.encodings[0].active = false;
6996 parameters.encodings[1].active = true;
6997 parameters.encodings[2].active = false;
6998 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
6999 // Verify that the active fields are set on the VideoChannel.
7000 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007001 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007002 EXPECT_FALSE(parameters.encodings[0].active);
7003 EXPECT_TRUE(parameters.encodings[1].active);
7004 EXPECT_FALSE(parameters.encodings[2].active);
7005 // Check that the VideoSendStream is updated appropriately. This means its
7006 // send state was updated and it was reconfigured.
7007 EXPECT_TRUE(fake_video_send_stream->IsSending());
7008 std::vector<webrtc::VideoStream> simulcast_streams =
7009 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007010 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007011 EXPECT_FALSE(simulcast_streams[0].active);
7012 EXPECT_TRUE(simulcast_streams[1].active);
7013 EXPECT_FALSE(simulcast_streams[2].active);
7014
7015 // Turn off all streams.
7016 parameters.encodings[0].active = false;
7017 parameters.encodings[1].active = false;
7018 parameters.encodings[2].active = false;
7019 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7020 // Verify that the active fields are set on the VideoChannel.
7021 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007022 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007023 EXPECT_FALSE(parameters.encodings[0].active);
7024 EXPECT_FALSE(parameters.encodings[1].active);
7025 EXPECT_FALSE(parameters.encodings[2].active);
7026 // Check that the VideoSendStream is off.
7027 EXPECT_FALSE(fake_video_send_stream->IsSending());
7028 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007029 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007030 EXPECT_FALSE(simulcast_streams[0].active);
7031 EXPECT_FALSE(simulcast_streams[1].active);
7032 EXPECT_FALSE(simulcast_streams[2].active);
7033
Niels Möllerff40b142018-04-09 08:49:14 +02007034 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007035}
7036
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007037// Test that if a stream is reconfigured (due to a codec change or other
7038// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007039TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007040 InactiveStreamDoesntStartSendingWhenReconfigured) {
7041 // Set an initial codec list, which will be modified later.
7042 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007043 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7044 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007045 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7046
7047 FakeVideoSendStream* stream = AddSendStream();
7048 EXPECT_TRUE(channel_->SetSend(true));
7049 EXPECT_TRUE(stream->IsSending());
7050
7051 // Get current parameters and change "active" to false.
7052 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7053 ASSERT_EQ(1u, parameters.encodings.size());
7054 ASSERT_TRUE(parameters.encodings[0].active);
7055 parameters.encodings[0].active = false;
7056 EXPECT_EQ(1u, GetFakeSendStreams().size());
7057 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007058 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007059 EXPECT_FALSE(stream->IsSending());
7060
7061 // Reorder the codec list, causing the stream to be reconfigured.
7062 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007063 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7064 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007065 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7066 auto new_streams = GetFakeSendStreams();
7067 // Assert that a new underlying stream was created due to the codec change.
7068 // Otherwise, this test isn't testing what it set out to test.
7069 EXPECT_EQ(1u, GetFakeSendStreams().size());
7070 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7071
7072 // Verify that we still are not sending anything, due to the inactive
7073 // encoding.
7074 EXPECT_FALSE(new_streams[0]->IsSending());
7075}
7076
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007077// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007078TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007079 AddSendStream();
7080 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007081 parameters.codecs.push_back(GetEngineCodec("VP8"));
7082 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007083 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7084
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007085 webrtc::RtpParameters rtp_parameters =
7086 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007087 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007088 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7089 rtp_parameters.codecs[0]);
7090 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7091 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007092}
7093
Florent Castellidacec712018-05-24 16:24:21 +02007094// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7095TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7096 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7097 params.cname = "rtcpcname";
7098 AddSendStream(params);
7099
7100 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7101 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7102}
7103
deadbeeffb2aced2017-01-06 23:05:37 -08007104// Test that RtpParameters for send stream has one encoding and it has
7105// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007106TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007107 AddSendStream();
7108
7109 webrtc::RtpParameters rtp_parameters =
7110 channel_->GetRtpSendParameters(last_ssrc_);
7111 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007112 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007113}
7114
Florent Castelliabe301f2018-06-12 18:33:49 +02007115TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7116 AddSendStream();
7117
7118 webrtc::RtpParameters rtp_parameters =
7119 channel_->GetRtpSendParameters(last_ssrc_);
7120 rtp_parameters.header_extensions.emplace_back();
7121
7122 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7123
7124 webrtc::RTCError result =
7125 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7126 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7127}
7128
Florent Castelli87b3c512018-07-18 16:00:28 +02007129TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7130 AddSendStream();
7131
Niels Möller805a27e2019-01-21 12:21:27 +01007132 webrtc::test::FrameForwarder frame_forwarder;
7133 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007134
7135 webrtc::RtpParameters rtp_parameters =
7136 channel_->GetRtpSendParameters(last_ssrc_);
7137 EXPECT_EQ(rtp_parameters.degradation_preference,
7138 webrtc::DegradationPreference::BALANCED);
7139 rtp_parameters.degradation_preference =
7140 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7141
7142 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7143
7144 webrtc::RtpParameters updated_rtp_parameters =
7145 channel_->GetRtpSendParameters(last_ssrc_);
7146 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7147 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7148
7149 // Remove the source since it will be destroyed before the channel
7150 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7151}
7152
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007153// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007154TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007155 AddSendStream();
7156 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007157 parameters.codecs.push_back(GetEngineCodec("VP8"));
7158 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007159 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7160
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007161 webrtc::RtpParameters initial_params =
7162 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007163
7164 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007165 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007166
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007167 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7168 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7169}
7170
7171// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007172TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007173 AddRecvStream();
7174 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007175 parameters.codecs.push_back(GetEngineCodec("VP8"));
7176 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007177 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7178
7179 webrtc::RtpParameters rtp_parameters =
7180 channel_->GetRtpReceiveParameters(last_ssrc_);
7181 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007182 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7183 rtp_parameters.codecs[0]);
7184 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7185 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007186}
7187
johan073ece42016-08-26 02:59:47 -07007188#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007189TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007190#else
eladalonf1841382017-06-12 01:16:46 -07007191TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007192#endif
johan3859c892016-08-05 09:19:25 -07007193 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007194 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007195 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007196 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007197 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007198 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007199 parameters.codecs.push_back(kH264sprop2);
7200 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7201
7202 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7203 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7204 webrtc::RtpParameters rtp_parameters =
7205 channel_->GetRtpReceiveParameters(last_ssrc_);
7206 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7207 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7208 ASSERT_EQ(2u, cfg.decoders.size());
7209 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007210 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007211 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007212 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7213 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007214 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007215
7216 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007217 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007218 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007219 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7220 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007221 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007222}
7223
sakal1fd95952016-06-22 00:46:15 -07007224// Test that RtpParameters for receive stream has one encoding and it has
7225// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007226TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007227 AddRecvStream();
7228
7229 webrtc::RtpParameters rtp_parameters =
7230 channel_->GetRtpReceiveParameters(last_ssrc_);
7231 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007232 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007233}
7234
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007235// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007236TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007237 AddRecvStream();
7238 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007239 parameters.codecs.push_back(GetEngineCodec("VP8"));
7240 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007241 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7242
7243 webrtc::RtpParameters initial_params =
7244 channel_->GetRtpReceiveParameters(last_ssrc_);
7245
7246 // We should be able to set the params we just got.
7247 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7248
7249 // ... And this shouldn't change the params returned by
7250 // GetRtpReceiveParameters.
7251 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007252}
7253
deadbeef3bc15102017-04-20 19:25:07 -07007254// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7255// aren't signaled. It should always return an empty "RtpEncodingParameters",
7256// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007257TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007258 // Call necessary methods to configure receiving a default stream as
7259 // soon as it arrives.
7260 cricket::VideoRecvParameters parameters;
7261 parameters.codecs.push_back(GetEngineCodec("VP8"));
7262 parameters.codecs.push_back(GetEngineCodec("VP9"));
7263 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7264
7265 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7266 // stream. Should return nothing.
7267 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7268
7269 // Set a sink for an unsignaled stream.
7270 cricket::FakeVideoRenderer renderer;
7271 // Value of "0" means "unsignaled stream".
7272 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7273
7274 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7275 // in this method means "unsignaled stream".
7276 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7277 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7278 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7279
7280 // Receive VP8 packet.
7281 uint8_t data[kMinRtpPacketLen];
7282 cricket::RtpHeader rtpHeader;
7283 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7284 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7285 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7286 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7287 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007288 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007289
7290 // The |ssrc| member should still be unset.
7291 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7292 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7293 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7294}
7295
eladalonf1841382017-06-12 01:16:46 -07007296void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007297 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007298 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007299
7300 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007301 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007302 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007303 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007304
7305 if (receiver_first) {
7306 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7307 std::vector<FakeVideoReceiveStream*> receive_streams =
7308 fake_call_->GetVideoReceiveStreams();
7309 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007310 // Default local SSRC when we have no sender.
7311 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7312 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007313 }
7314 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7315 if (!receiver_first)
7316 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7317 std::vector<FakeVideoReceiveStream*> receive_streams =
7318 fake_call_->GetVideoReceiveStreams();
7319 ASSERT_EQ(1u, receive_streams.size());
7320 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007321
7322 // Removing first sender should fall back to another (in this case the second)
7323 // local send stream's SSRC.
7324 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7325 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007326 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007327 ASSERT_EQ(1u, receive_streams.size());
7328 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7329
7330 // Removing the last sender should fall back to default local SSRC.
7331 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007332 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007333 ASSERT_EQ(1u, receive_streams.size());
7334 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7335 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007336}
7337
eladalonf1841382017-06-12 01:16:46 -07007338TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007339 TestReceiverLocalSsrcConfiguration(false);
7340}
7341
eladalonf1841382017-06-12 01:16:46 -07007342TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007343 TestReceiverLocalSsrcConfiguration(true);
7344}
7345
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007346class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007347 public:
eladalonf1841382017-06-12 01:16:46 -07007348 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007349 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007350 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7351 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007352 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007353 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007354 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007355 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007356 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007357 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007358 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007359
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007360 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007361 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007362 channel_.reset(engine_.CreateMediaChannel(
7363 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7364 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007365 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007366 last_ssrc_ = 123;
7367 }
7368
7369 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007370 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007371 int capture_width,
7372 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007373 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007374 size_t expected_num_streams,
7375 bool screenshare,
7376 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007377 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007378 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007379 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007380 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007381
Peter Boström0c4e06b2015-10-07 12:23:21 +02007382 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007383 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007384 ssrcs.resize(num_configured_streams);
7385
sprangf24a0642017-02-28 13:23:26 -08007386 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007387 // Send a full-size frame to trigger a stream reconfiguration to use all
7388 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007389 webrtc::test::FrameForwarder frame_forwarder;
7390 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7391 rtc::kNumMicrosecsPerSec / 30);
7392
sprangf24a0642017-02-28 13:23:26 -08007393 VideoOptions options;
7394 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007395 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007396 EXPECT_TRUE(
7397 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007398 // Fetch the latest stream since SetVideoSend() may recreate it if the
7399 // screen content setting is changed.
7400 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007401 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007402 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007403
Zach Stein3ca452b2018-01-18 10:01:24 -08007404 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7405 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7406
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007407 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7408 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007409 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007410
sprang429600d2017-01-26 06:12:26 -08007411 std::vector<webrtc::VideoStream> expected_streams;
7412 if (conference_mode) {
7413 expected_streams = GetSimulcastConfig(
7414 num_configured_streams, capture_width, capture_height, 0,
Seth Hampson24722b32017-12-22 09:36:42 -08007415 webrtc::kDefaultBitratePriority, kDefaultQpMax,
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +02007416 kDefaultVideoMaxFramerate, screenshare, true);
sprang3ebabf12017-02-16 07:35:22 -08007417 if (screenshare) {
7418 for (const webrtc::VideoStream& stream : expected_streams) {
7419 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007420 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7421 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007422 }
7423 }
sprang429600d2017-01-26 06:12:26 -08007424 } else {
7425 webrtc::VideoStream stream;
7426 stream.width = capture_width;
7427 stream.height = capture_height;
7428 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007429 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007430 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007431 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007432 stream.max_qp = kDefaultQpMax;
7433 expected_streams.push_back(stream);
7434 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007435
7436 ASSERT_EQ(expected_streams.size(), video_streams.size());
7437
7438 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007439 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007440 for (size_t i = 0; i < num_streams; ++i) {
7441 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7442 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7443
7444 EXPECT_GT(video_streams[i].max_framerate, 0);
7445 EXPECT_EQ(expected_streams[i].max_framerate,
7446 video_streams[i].max_framerate);
7447
7448 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7449 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7450 video_streams[i].min_bitrate_bps);
7451
7452 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7453 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7454 video_streams[i].target_bitrate_bps);
7455
7456 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7457 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7458 video_streams[i].max_bitrate_bps);
7459
7460 EXPECT_GT(video_streams[i].max_qp, 0);
7461 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7462
Sergey Silkina796a7e2018-03-01 15:11:29 +01007463 EXPECT_EQ(conference_mode,
7464 expected_streams[i].num_temporal_layers.has_value());
7465
7466 if (conference_mode) {
7467 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7468 video_streams[i].num_temporal_layers);
7469 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007470
7471 if (i == num_streams - 1) {
7472 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7473 } else {
7474 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7475 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007476 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007477
Niels Möllerff40b142018-04-09 08:49:14 +02007478 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007479 }
7480
7481 FakeVideoSendStream* AddSendStream() {
7482 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7483 }
7484
7485 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007486 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007487 EXPECT_TRUE(channel_->AddSendStream(sp));
7488 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007489 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007490 EXPECT_EQ(num_streams + 1, streams.size());
7491 return streams[streams.size() - 1];
7492 }
7493
7494 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007495 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007496 }
7497
7498 FakeVideoReceiveStream* AddRecvStream() {
7499 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7500 }
7501
7502 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007503 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007504 EXPECT_TRUE(channel_->AddRecvStream(sp));
7505 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007506 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007507 EXPECT_EQ(num_streams + 1, streams.size());
7508 return streams[streams.size() - 1];
7509 }
7510
skvlad11a9cbf2016-10-07 11:53:05 -07007511 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007512 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007513 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7514 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007515 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7516 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007517 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007518 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007519 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007520};
7521
eladalonf1841382017-06-12 01:16:46 -07007522TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007523 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7524 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007525}
7526
eladalonf1841382017-06-12 01:16:46 -07007527TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007528 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7529 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007530}
7531
7532// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007533TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007534 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7535 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007536}
sprang429600d2017-01-26 06:12:26 -08007537
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007538TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007539 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7540 false);
7541}
7542
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007543TEST_F(WebRtcVideoChannelSimulcastTest,
7544 SetSendCodecsForConferenceModeScreenshare) {
Erik Språng72e52ee2018-11-29 11:41:53 +01007545 webrtc::test::ScopedFieldTrials field_trials(
7546 "WebRTC-SimulcastScreenshare/Disabled/");
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007547 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7548 true);
7549}
7550
eladalonf1841382017-06-12 01:16:46 -07007551TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007552 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7553 true);
7554}
7555
eladalonf1841382017-06-12 01:16:46 -07007556TEST_F(WebRtcVideoChannelSimulcastTest,
sprangfe627f32017-03-29 08:24:59 -07007557 NoSimulcastScreenshareWithoutConference) {
sprangfe627f32017-03-29 08:24:59 -07007558 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 1, true,
7559 false);
7560}
7561
Chen Xing90f3b892019-06-25 10:16:14 +02007562TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7563 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007564
Chen Xing90f3b892019-06-25 10:16:14 +02007565 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007566 EXPECT_TRUE(SetDefaultCodec());
7567 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007568 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007569
Chen Xing90f3b892019-06-25 10:16:14 +02007570 // Send and receive one frame.
7571 SendFrame();
7572 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007573
Chen Xing90f3b892019-06-25 10:16:14 +02007574 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7575 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7576 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007577
Chen Xing90f3b892019-06-25 10:16:14 +02007578 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7579 EXPECT_EQ(source.source_id(), kSsrc);
7580 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7581 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7582 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007583
Chen Xing90f3b892019-06-25 10:16:14 +02007584 // Send and receive another frame.
7585 SendFrame();
7586 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007587
Chen Xing90f3b892019-06-25 10:16:14 +02007588 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7589 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7590 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007591
Chen Xing90f3b892019-06-25 10:16:14 +02007592 source = channel_->GetSources(kSsrc)[0];
7593 EXPECT_EQ(source.source_id(), kSsrc);
7594 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7595 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7596 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007597
Chen Xing90f3b892019-06-25 10:16:14 +02007598 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7599 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007600}
7601
Amit Hilbuchb000b712019-02-25 10:22:14 -08007602TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7603 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7604
7605 std::vector<std::string> rids = {"f", "h", "q"};
7606 std::vector<cricket::RidDescription> rid_descriptions;
7607 for (const auto& rid : rids) {
7608 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7609 }
7610 sp.set_rids(rid_descriptions);
7611
7612 ASSERT_TRUE(channel_->AddSendStream(sp));
7613 const auto& streams = fake_call_->GetVideoSendStreams();
7614 ASSERT_EQ(1u, streams.size());
7615 auto stream = streams[0];
7616 ASSERT_NE(stream, nullptr);
7617 const auto& config = stream->GetConfig();
7618 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7619}
7620
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007621} // namespace cricket