blob: 92ffc5c47f7a23a94d54dd22fa3cf0d9b7c84b29 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "media/engine/webrtc_video_engine.h"
12
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000013#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080014#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020015#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070016#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000017#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000018
Steve Anton2c9ebef2019-01-28 17:27:58 -080019#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010020#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020021#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070022#include "api/media_transport_config.h"
Danil Chapovalov83bbe912019-08-07 12:24:53 +020023#include "api/rtc_event_log/rtc_event_log.h"
Steve Anton10542f22019-01-11 09:11:00 -080024#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020025#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070026#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080027#include "api/test/mock_video_bitrate_allocator.h"
28#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070029#include "api/test/mock_video_decoder_factory.h"
30#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020031#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080032#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010033#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020034#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020035#include "api/video_codecs/builtin_video_decoder_factory.h"
36#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "api/video_codecs/sdp_video_format.h"
38#include "api/video_codecs/video_decoder_factory.h"
39#include "api/video_codecs/video_encoder.h"
40#include "api/video_codecs/video_encoder_factory.h"
41#include "call/flexfec_receive_stream.h"
42#include "common_video/h264/profile_level_id.h"
Niels Möller805a27e2019-01-21 12:21:27 +010043#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/base/fake_video_renderer.h"
46#include "media/base/media_constants.h"
47#include "media/base/rtp_utils.h"
48#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/fake_webrtc_call.h"
51#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020054#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080056#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020058#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080059#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010061#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020062#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000063
Mirko Bonadei6a489f22019-04-09 15:11:12 +020064using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020065using ::testing::IsEmpty;
66using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010067using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070068using webrtc::RtpExtension;
69
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000070namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000071static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000072
noahricd10a68e2015-07-10 11:27:55 -070073static const uint8_t kRedRtxPayloadType = 125;
74
Niels Möller6557d0c2018-04-11 15:18:34 +020075static const uint32_t kTimeout = 5000U;
76static const uint32_t kDefaultReceiveSsrc = 0;
77static const uint32_t kSsrc = 1234u;
78static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
79static const int kVideoWidth = 640;
80static const int kVideoHeight = 360;
81static const int kFramerate = 30;
82
Peter Boström0c4e06b2015-10-07 12:23:21 +020083static const uint32_t kSsrcs1[] = {1};
84static const uint32_t kSsrcs3[] = {1, 2, 3};
85static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080086static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020087static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080088static const uint32_t kDefaultRecvSsrc = 0;
89
Bjorn A Mellemda4f0932019-07-30 08:34:03 -070090constexpr uint32_t kRtpHeaderSize = 12;
91
pbos@webrtc.org3c107582014-07-20 15:27:35 +000092static const char kUnsupportedExtensionName[] =
93 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000094
magjed509e4fe2016-11-18 01:34:11 -080095cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
96 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020097 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080098}
99
Elad Alonfadb1812019-05-24 13:40:02 +0200100void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
101 bool lntf_expected) {
102 EXPECT_EQ(lntf_expected,
103 codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
106 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
108 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
110 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
111 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800112 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
113 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000114 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
115}
116
magjed725e4842016-11-16 00:48:13 -0800117// Return true if any codec in |codecs| is an RTX codec with associated payload
118// type |payload_type|.
119bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
120 int payload_type) {
121 for (const cricket::VideoCodec& codec : codecs) {
122 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200123 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800124 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
125 &associated_payload_type) &&
126 associated_payload_type == payload_type) {
127 return true;
128 }
129 }
130 return false;
131}
132
nisseca5706d2017-09-11 02:32:16 -0700133// TODO(nisse): Duplicated in call.cc.
134const int* FindKeyByValue(const std::map<int, int>& m, int v) {
135 for (const auto& kv : m) {
136 if (kv.second == v)
137 return &kv.first;
138 }
139 return nullptr;
140}
141
Yves Gerey665174f2018-06-19 15:03:05 +0200142bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
143 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700144 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
145 payload_type) != nullptr;
146}
147
148// Check that there's an Rtx payload type for each decoder.
149bool VerifyRtxReceiveAssociations(
150 const webrtc::VideoReceiveStream::Config& config) {
151 for (const auto& decoder : config.decoders) {
152 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
153 return false;
154 }
155 return true;
156}
157
brandtrffc61182016-11-28 06:02:22 -0800158rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700159 int width,
160 int height) {
161 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
162 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800163 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700164 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000165}
166
Shao Changbine62202f2015-04-21 20:24:50 +0800167void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
168 const std::map<int, int>& rtx_types) {
169 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200170 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800171 EXPECT_TRUE(it != rtx_types.end() &&
172 it->second == config.rtp.rtx.payload_type);
173
brandtrb5f2c3f2016-10-04 23:28:39 -0700174 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
175 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800176 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700177 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800178 }
179}
kthelgason2bc68642017-02-07 07:02:22 -0800180
181cricket::MediaConfig GetMediaConfig() {
182 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100183 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800184 return media_config;
185}
nisse26e3abb2017-08-25 04:44:25 -0700186
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200187// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
188int GetMaxDefaultBitrateBps(size_t width, size_t height) {
189 if (width * height <= 320 * 240) {
190 return 600000;
191 } else if (width * height <= 640 * 480) {
192 return 1700000;
193 } else if (width * height <= 960 * 540) {
194 return 2000000;
195 } else {
196 return 2500000;
197 }
198}
199
Niels Möller731a2c22018-07-30 15:08:07 +0200200class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
201 public:
202 MOCK_METHOD2(AddOrUpdateSink,
203 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
204 const rtc::VideoSinkWants& wants));
205 MOCK_METHOD1(RemoveSink,
206 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
207};
208
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000209} // namespace
210
Yves Gerey665174f2018-06-19 15:03:05 +0200211#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200212 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200213 EXPECT_EQ((w), renderer_.width()); \
214 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200215 EXPECT_EQ(0, renderer_.errors());
216
Yves Gerey665174f2018-06-19 15:03:05 +0200217#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200218 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200219 EXPECT_EQ((w), (r).width()); \
220 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200221 EXPECT_EQ(0, (r).errors());
222
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000223namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700224class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000225 public:
eladalonf1841382017-06-12 01:16:46 -0700226 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200227 explicit WebRtcVideoEngineTest(const std::string& field_trials)
228 : override_field_trials_(
229 field_trials.empty()
230 ? nullptr
231 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
232 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200233 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
234 call_(webrtc::Call::Create([&] {
235 webrtc::Call::Config call_config(&event_log_);
236 call_config.task_queue_factory = task_queue_factory_.get();
237 return call_config;
238 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200239 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
240 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200241 video_bitrate_allocator_factory_(
242 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200243 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200244 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200245 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200246 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200247 // Ensure fake clock doesn't return 0, which will cause some initializations
248 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200249 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200250 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000251
252 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200253 void AssignDefaultAptRtxTypes();
254 void AssignDefaultCodec();
255
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100256 // Find the index of the codec in the engine with the given name. The codec
257 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100258 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100259
magjed509e4fe2016-11-18 01:34:11 -0800260 // Find the codec in the engine with the given name. The codec must be
261 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100262 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800263
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200264 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000265
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200266 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000267 const std::vector<VideoCodec>& codecs);
268
Elad Alon157540a2019-02-08 23:37:52 +0100269 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100270
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200271 // Has to be the first one, so it is initialized before the call or there is a
272 // race condition in the clock access.
273 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200274 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
Danil Chapovalov83bbe912019-08-07 12:24:53 +0200275 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200276 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700277 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000278 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800279 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200280 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
281 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200282 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
283 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700284 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000285 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800286 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000287};
288
eladalonf1841382017-06-12 01:16:46 -0700289TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200290 encoder_factory_->AddSupportedVideoCodecType("VP8");
291 AssignDefaultCodec();
292
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000293 std::vector<VideoCodec> engine_codecs = engine_.codecs();
294 for (size_t i = 0; i < engine_codecs.size(); ++i) {
295 if (engine_codecs[i].name != kRtxCodecName)
296 continue;
297 int associated_payload_type;
298 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000299 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000300 EXPECT_EQ(default_codec_.id, associated_payload_type);
301 return;
302 }
303 FAIL() << "No RTX codec found among default codecs.";
304}
305
eladalonf1841382017-06-12 01:16:46 -0700306TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100307 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100311 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100315 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700316}
317
eladalonf1841382017-06-12 01:16:46 -0700318TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100319 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
320}
321
322TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
323 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
327 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
328}
329
330TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
331 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
332}
333
334TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
335 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100336}
337
338TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100339 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
340}
341
Elad Alonccb9b752019-02-19 13:01:31 +0100342TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
343 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
344}
345
346TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348}
349
philipel1e054862018-10-08 16:13:53 +0200350class WebRtcVideoEngineTestWithGenericDescriptor
351 : public WebRtcVideoEngineTest {
352 public:
353 WebRtcVideoEngineTestWithGenericDescriptor()
354 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
355};
356
Elad Alonccb9b752019-02-19 13:01:31 +0100357TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
358 AdvertiseGenericDescriptor00) {
359 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
360}
361
362TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
363 AdvertiseGenericDescriptor01) {
364 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200365}
366
eladalonf1841382017-06-12 01:16:46 -0700367TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200368 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200370 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700371
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200372 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200374 std::unique_ptr<VideoMediaChannel> channel(
375 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700376 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
377
378 // Add CVO extension.
379 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800380 cricket::VideoSendParameters parameters;
381 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200382 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700383 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200384 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700385
Niels Möller731a2c22018-07-30 15:08:07 +0200386 EXPECT_CALL(
387 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200388 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200389 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700390 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200391 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392
393 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200394 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700395
396 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200397 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200398 EXPECT_CALL(
399 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200400 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200401 Field(&rtc::VideoSinkWants::rotation_applied, true)));
402
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200403 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700404}
405
eladalonf1841382017-06-12 01:16:46 -0700406TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200407 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800408 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200409 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800410
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200411 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800412
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200413 std::unique_ptr<VideoMediaChannel> channel(
414 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800415 // Add CVO extension.
416 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800417 cricket::VideoSendParameters parameters;
418 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800419 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700420 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800421 EXPECT_TRUE(channel->SetSendParameters(parameters));
422 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
423
Niels Möller731a2c22018-07-30 15:08:07 +0200424 // Set source.
425 EXPECT_CALL(
426 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200427 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200428 Field(&rtc::VideoSinkWants::rotation_applied, false)));
429 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800430}
431
eladalonf1841382017-06-12 01:16:46 -0700432TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200433 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700434
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200435 encoder_factory_->AddSupportedVideoCodecType("VP8");
436 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700437
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200438 std::unique_ptr<VideoMediaChannel> channel(
439 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
441
442 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200443 EXPECT_CALL(
444 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200445 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200446 Field(&rtc::VideoSinkWants::rotation_applied, true)));
447 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700448
perkjcaafdba2016-03-20 07:34:29 -0700449 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200450 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700451
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452 // Add CVO extension.
453 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800454 cricket::VideoSendParameters parameters;
455 parameters.codecs.push_back(GetEngineCodec("VP8"));
456 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200457 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700458 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700459 // Also remove the first codec to trigger a codec change as well.
460 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200461 EXPECT_CALL(
462 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200463 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200464 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200465 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700466
467 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200468 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700469
470 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200471 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200472 EXPECT_CALL(
473 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200474 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200475 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200476 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700477}
478
eladalonf1841382017-06-12 01:16:46 -0700479TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200480 encoder_factory_->AddSupportedVideoCodecType("VP8");
481
Sebastian Jansson84848f22018-11-16 10:40:36 +0100482 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200483 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
484 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000485
486 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
487
488 EXPECT_FALSE(channel->SetSend(true))
489 << "Channel should not start without codecs.";
490 EXPECT_TRUE(channel->SetSend(false))
491 << "Channel should be stoppable even without set codecs.";
492}
493
eladalonf1841382017-06-12 01:16:46 -0700494TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200495 encoder_factory_->AddSupportedVideoCodecType("VP8");
496
Sebastian Jansson84848f22018-11-16 10:40:36 +0100497 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200498 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
499 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000500 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
501 VideoMediaInfo info;
502 channel->GetStats(&info);
503}
504
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200505TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200508 std::unique_ptr<VideoMediaChannel> channel(
509 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800510 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
512 EXPECT_TRUE(
513 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200514 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100516 webrtc::test::FrameForwarder frame_forwarder;
517 cricket::FakeFrameSource frame_source(1280, 720,
518 rtc::kNumMicrosecsPerSec / 30);
519 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
520 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100521 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200522 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
523 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000524 kTimeout);
525
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100527 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000528
529 // Setting codecs of the same type should not reallocate any encoders
530 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800531 cricket::VideoSendParameters parameters;
532 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200533 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200534 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000535
536 // Remove stream previously added to free the external encoder instance.
537 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200538 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000539}
540
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200541// Test that when an encoder factory supports H264, we add an RTX
542// codec for it.
543// TODO(deadbeef): This test should be updated if/when we start
544// adding RTX codecs for unrecognized codec names.
545TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800546 using webrtc::H264::kLevel1;
Jonas Olssona4d87372019-07-05 19:08:33 +0200547 using webrtc::H264::ProfileLevelId;
548 using webrtc::H264::ProfileLevelIdToString;
Anders Carlsson67537952018-05-03 11:28:29 +0200549 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
550 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800551 *ProfileLevelIdToString(
552 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200553 webrtc::SdpVideoFormat h264_constrained_high("H264");
554 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800555 *ProfileLevelIdToString(
556 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200557 webrtc::SdpVideoFormat h264_high("H264");
558 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800559 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
560
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200561 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
562 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
563 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700564
magjed725e4842016-11-16 00:48:13 -0800565 // First figure out what payload types the test codecs got assigned.
566 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800567 // Now search for RTX codecs for them. Expect that they all have associated
568 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800569 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200570 codecs,
571 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
572 ->id));
magjed725e4842016-11-16 00:48:13 -0800573 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200574 codecs,
575 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
576 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800577 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200578 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700579}
580
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100581#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700582TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200583 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100584
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200585 std::unique_ptr<VideoMediaChannel> channel(
586 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100587
588 EXPECT_TRUE(
589 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
590}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100591#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100592
eladalonf1841382017-06-12 01:16:46 -0700593TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200594 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100595 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200596 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200597 std::unique_ptr<VideoMediaChannel> channel(
598 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700599
600 EXPECT_TRUE(
601 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
602
Niels Möllerd0f0f682019-01-14 09:09:53 +0100603 webrtc::test::FrameForwarder frame_forwarder;
604 cricket::FakeFrameSource frame_source(1280, 720,
605 rtc::kNumMicrosecsPerSec / 60);
606 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700607 channel->SetSend(true);
608
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200609 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700610
Niels Möllerd0f0f682019-01-14 09:09:53 +0100611 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700612 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700613 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100614 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700615 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700616 int64_t interval = timestamp - last_timestamp;
617
618 // Precision changes from nanosecond to millisecond.
619 // Allow error to be no more than 1.
620 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
621
622 last_timestamp = timestamp;
623 }
624
Niels Möllerd0f0f682019-01-14 09:09:53 +0100625 frame_forwarder.IncomingCapturedFrame(
626 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
627 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700628 last_timestamp = stream->GetLastTimestamp();
629 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100630 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
631 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
632 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700633 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700634 int64_t interval = timestamp - last_timestamp;
635
636 // Precision changes from nanosecond to millisecond.
637 // Allow error to be no more than 1.
638 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
639
640 last_timestamp = timestamp;
641 }
642
643 // Remove stream previously added to free the external encoder instance.
644 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
645}
646
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200647void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
648 std::vector<VideoCodec> engine_codecs = engine_.codecs();
649 RTC_DCHECK(!engine_codecs.empty());
650 for (const cricket::VideoCodec& codec : engine_codecs) {
651 if (codec.name == "rtx") {
652 int associated_payload_type;
653 if (codec.GetParam(kCodecParamAssociatedPayloadType,
654 &associated_payload_type)) {
655 default_apt_rtx_types_[associated_payload_type] = codec.id;
656 }
657 }
658 }
659}
660
661void WebRtcVideoEngineTest::AssignDefaultCodec() {
662 std::vector<VideoCodec> engine_codecs = engine_.codecs();
663 RTC_DCHECK(!engine_codecs.empty());
664 bool codec_set = false;
665 for (const cricket::VideoCodec& codec : engine_codecs) {
666 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
667 codec.name != "ulpfec") {
668 default_codec_ = codec;
669 codec_set = true;
670 }
671 }
672
673 RTC_DCHECK(codec_set);
674}
675
Oleh Prypina40f8242017-12-21 13:32:23 +0100676size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
677 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100678 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
679 for (size_t i = 0; i < codecs.size(); ++i) {
680 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200681 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200682 continue;
683 // The tests only use H264 Constrained Baseline. Make sure we don't return
684 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200685 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200686 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200687 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
688 if (profile_level_id->profile !=
689 webrtc::H264::kProfileConstrainedBaseline) {
690 continue;
691 }
692 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100693 return i;
magjed509e4fe2016-11-18 01:34:11 -0800694 }
695 // This point should never be reached.
696 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100697 return -1;
698}
699
700cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
701 const std::string& name) const {
702 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800703}
704
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200705VideoMediaChannel*
706WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100707 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200708 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
709 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200710 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800711 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200712 for (const webrtc::SdpVideoFormat& format :
713 encoder_factory_->GetSupportedFormats()) {
714 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800715 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200716 parameters.codecs.push_back(engine_codec);
717 }
718 }
magjed509e4fe2016-11-18 01:34:11 -0800719
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200720 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000721
722 return channel;
723}
724
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200725VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000726 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100727 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200728 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
729 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200730 cricket::VideoRecvParameters parameters;
731 parameters.codecs = codecs;
732 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000733
734 return channel;
735}
736
Elad Alon157540a2019-02-08 23:37:52 +0100737void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
738 bool supported) const {
739 const RtpCapabilities capabilities = engine_.GetCapabilities();
740 if (supported) {
741 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200742 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100743 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200744 EXPECT_THAT(capabilities.header_extensions,
745 ::testing::Each(::testing::Field(&RtpExtension::uri,
746 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100747 }
748}
749
eladalonf1841382017-06-12 01:16:46 -0700750TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200751 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000752
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200753 std::unique_ptr<VideoMediaChannel> channel(
754 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000755
Peter Boström0c4e06b2015-10-07 12:23:21 +0200756 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000757
Yves Gerey665174f2018-06-19 15:03:05 +0200758 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000759 EXPECT_TRUE(channel->SetSend(true));
760
Niels Möller805a27e2019-01-21 12:21:27 +0100761 webrtc::test::FrameForwarder frame_forwarder;
762 cricket::FakeFrameSource frame_source(1280, 720,
763 rtc::kNumMicrosecsPerSec / 60);
764 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
765 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000766
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200767 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000768
769 // Verify that encoders are configured for simulcast through adapter
770 // (increasing resolution and only configured to send one stream each).
771 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200772 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
773 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000774 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200775 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000776 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
777 EXPECT_GT(codec_settings.width, prev_width);
778 prev_width = codec_settings.width;
779 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000780
Niels Möllerff40b142018-04-09 08:49:14 +0200781 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782
783 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200784 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000785}
786
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200787TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
788 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200789 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000790
Niels Möllerd0f0f682019-01-14 09:09:53 +0100791 // Frame source.
792 webrtc::test::FrameForwarder frame_forwarder;
793 cricket::FakeFrameSource frame_source(1280, 720,
794 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200795
Sebastian Jansson84848f22018-11-16 10:40:36 +0100796 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200797 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
798 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200799 cricket::VideoSendParameters parameters;
800 parameters.codecs.push_back(GetEngineCodec("H264"));
801 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000802
803 EXPECT_TRUE(
804 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100805 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200806 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100807 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200808
809 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000810
Anders Carlsson67537952018-05-03 11:28:29 +0200811 cricket::VideoSendParameters new_parameters;
812 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
813 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200814
815 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100816 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200817
Anders Carlsson8a150d92018-05-14 12:40:04 +0200818 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000819}
820
eladalonf1841382017-06-12 01:16:46 -0700821TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200823 encoder_factory_->AddSupportedVideoCodecType("VP8");
824 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000825
Sebastian Jansson84848f22018-11-16 10:40:36 +0100826 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200827 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
828 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800829 cricket::VideoSendParameters parameters;
830 parameters.codecs.push_back(GetEngineCodec("VP8"));
831 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000832
Peter Boström0c4e06b2015-10-07 12:23:21 +0200833 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834
Yves Gerey665174f2018-06-19 15:03:05 +0200835 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836 EXPECT_TRUE(channel->SetSend(true));
837
838 // Send a fake frame, or else the media engine will configure the simulcast
839 // encoder adapter at a low-enough size that it'll only create a single
840 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100841 webrtc::test::FrameForwarder frame_forwarder;
842 cricket::FakeFrameSource frame_source(1280, 720,
843 rtc::kNumMicrosecsPerSec / 30);
844 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
845 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000846
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
848 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200850 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000851
852 channel.reset();
853 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000855}
856
eladalonf1841382017-06-12 01:16:46 -0700857TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000858 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200859 encoder_factory_->AddSupportedVideoCodecType("VP8");
860 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000861
Sebastian Jansson84848f22018-11-16 10:40:36 +0100862 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200863 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
864 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800865 cricket::VideoSendParameters parameters;
866 parameters.codecs.push_back(GetEngineCodec("H264"));
867 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000868
869 EXPECT_TRUE(
870 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100871
872 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100873 webrtc::test::FrameForwarder frame_forwarder;
874 cricket::FakeFrameSource frame_source(1280, 720,
875 rtc::kNumMicrosecsPerSec / 30);
876 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
877 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200878 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
879 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200880 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000881 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200882 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000883
884 channel.reset();
885 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200886 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000887}
888
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200889TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200890 RTC_DCHECK(!override_field_trials_);
891 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200892 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200893 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700894
Sebastian Jansson84848f22018-11-16 10:40:36 +0100895 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200896 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
897 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200898 cricket::VideoSendParameters parameters;
899 parameters.codecs.push_back(GetEngineCodec("H264"));
900 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700901
Peter Boström0c4e06b2015-10-07 12:23:21 +0200902 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700903 EXPECT_TRUE(
904 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100905
906 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100907 webrtc::test::FrameForwarder frame_forwarder;
908 cricket::FakeFrameSource frame_source(1280, 720,
909 rtc::kNumMicrosecsPerSec / 30);
910 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
911 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100912
Niels Möller4db138e2018-04-19 09:04:13 +0200913 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200914 ASSERT_EQ(1u, encoder_factory_->encoders().size());
915 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
916 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700917 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200918 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200919 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700920}
921
brandtrffc61182016-11-28 06:02:22 -0800922// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700923// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800924//
925// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700926TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800927 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200928 encoder_factory_->AddSupportedVideoCodecType("VP8");
929
Steve Anton2c9ebef2019-01-28 17:27:58 -0800930 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800931
932 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800933 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800934
935 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200936 RTC_DCHECK(!override_field_trials_);
937 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800938 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800939 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800940}
941
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200942// Test that codecs are added in the order they are reported from the factory.
943TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
944 encoder_factory_->AddSupportedVideoCodecType("VP8");
945 const char* kFakeCodecName = "FakeCodec";
946 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000947
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200948 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100949 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200950 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
951 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000952}
953
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200954// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800955// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200956TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100957 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
958 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100959
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100960 // Set up external encoder factory with first codec, and initialize engine.
961 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
962
brandtrffc61182016-11-28 06:02:22 -0800963 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800964
965 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100966 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800967 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200968 // The codec itself and RTX should have been added.
969 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100970
971 // Check that both fake codecs are present and that the second fake codec
972 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100973 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
974 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100975 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800976}
977
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200978TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
979 const char* kFakeCodecName = "FakeCodec";
980 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
981
982 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
983 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
984}
985
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200986TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
987 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200988 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200989 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800990 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000991
kwiberg686a8ef2016-02-26 03:00:35 -0800992 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200993 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000994
995 EXPECT_TRUE(
996 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200997 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998
999 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001000 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001001 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001002
1003 // Remove stream previously added to free the external decoder instance.
1004 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001005 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006}
1007
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001008// Verifies that we can set up decoders.
1009TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1011 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1012 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1013 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001014 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001015 webrtc::SdpVideoFormat supported_h264("H264");
1016 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1017 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001018 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001019 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001020
kwiberg686a8ef2016-02-26 03:00:35 -08001021 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001022 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001023
1024 EXPECT_TRUE(
1025 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001026 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001027}
1028
Jonas Oreland49ac5952018-09-26 16:04:32 +02001029// Tests when GetSources is called with non-existing ssrc, it will return an
1030// empty list of RtpSource without crashing.
1031TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1032 // Setup an recv stream with |kSsrc|.
1033 encoder_factory_->AddSupportedVideoCodecType("VP8");
1034 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1035 cricket::VideoRecvParameters parameters;
1036 parameters.codecs.push_back(GetEngineCodec("VP8"));
1037 std::unique_ptr<VideoMediaChannel> channel(
1038 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1039
1040 EXPECT_TRUE(
1041 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1042
1043 // Call GetSources with |kSsrc + 1| which doesn't exist.
1044 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1045 EXPECT_EQ(0u, sources.size());
1046}
1047
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001048TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1049 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1050 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1051 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001052 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001053 EXPECT_EQ(0u, engine.codecs().size());
1054}
1055
1056TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1057 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001058 webrtc::MockVideoEncoderFactory* encoder_factory =
1059 new webrtc::MockVideoEncoderFactory();
1060 webrtc::MockVideoDecoderFactory* decoder_factory =
1061 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001062 WebRtcVideoEngine engine(
1063 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001064 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001065 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1066 EXPECT_EQ(0u, engine.codecs().size());
1067 EXPECT_CALL(*encoder_factory, Die());
1068 EXPECT_CALL(*decoder_factory, Die());
1069}
1070
1071// Test full behavior in the video engine when video codec factories of the new
1072// type are injected supporting the single codec Vp8. Check the returned codecs
1073// from the engine and that we will create a Vp8 encoder and decoder using the
1074// new factories.
1075TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1076 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001077 webrtc::MockVideoEncoderFactory* encoder_factory =
1078 new webrtc::MockVideoEncoderFactory();
1079 webrtc::MockVideoDecoderFactory* decoder_factory =
1080 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001081 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1082 rate_allocator_factory =
1083 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001084 EXPECT_CALL(*rate_allocator_factory,
1085 CreateVideoBitrateAllocatorProxy(Field(
1086 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001087 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001088 WebRtcVideoEngine engine(
1089 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001090 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 const webrtc::SdpVideoFormat vp8_format("VP8");
1092 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1093 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001094 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095
1096 // Verify the codecs from the engine.
1097 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001098 // Verify default codecs has been added correctly.
1099 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001100 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001101
1102 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001103 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001104 int vp8_associated_payload;
1105 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1106 &vp8_associated_payload));
1107 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1108
1109 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1110
1111 // RTX codec for RED.
1112 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1113 int red_associated_payload;
1114 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1115 &red_associated_payload));
1116 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1117
1118 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1119
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001120 int associated_payload_type;
1121 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1122 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1123 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1124 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001125 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1126 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127
1128 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001129 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1130 codec_info.is_hardware_accelerated = false;
1131 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001132 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001133 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001134 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001135 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001136 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001138 .WillOnce(
1139 ::testing::DoAll(::testing::InvokeWithoutArgs(
1140 [&encoder_created]() { encoder_created.Set(); }),
1141 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001142
1143 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001144 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001145 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001146 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001147
1148 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001149 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001150 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1151 webrtc::Call::Config call_config(&event_log);
1152 call_config.task_queue_factory = task_queue_factory.get();
1153 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001154
1155 // Create send channel.
1156 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001157 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001158 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1159 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001160 cricket::VideoSendParameters send_parameters;
1161 send_parameters.codecs.push_back(engine_codecs.at(0));
1162 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1163 send_channel->OnReadyToSend(true);
1164 EXPECT_TRUE(
1165 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1166 EXPECT_TRUE(send_channel->SetSend(true));
1167
Niels Möller4db138e2018-04-19 09:04:13 +02001168 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001169 webrtc::test::FrameForwarder frame_forwarder;
1170 cricket::FakeFrameSource frame_source(1280, 720,
1171 rtc::kNumMicrosecsPerSec / 30);
1172 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001173 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001174 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001175 encoder_created.Wait(kTimeout);
1176
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001177 // Create recv channel.
1178 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001179 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001180 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1181 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001182 cricket::VideoRecvParameters recv_parameters;
1183 recv_parameters.codecs.push_back(engine_codecs.at(0));
1184 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1185 EXPECT_TRUE(recv_channel->AddRecvStream(
1186 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1187
1188 // Remove streams previously added to free the encoder and decoder instance.
1189 EXPECT_CALL(*encoder_factory, Die());
1190 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001191 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001192 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1193 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1194}
1195
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001196// Test behavior when decoder factory fails to create a decoder (returns null).
1197TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1198 // |engine| take ownership of the factories.
1199 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001200 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001201 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001202 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001203 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1204 rate_allocator_factory =
1205 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001206 WebRtcVideoEngine engine(
1207 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001208 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001209 const webrtc::SdpVideoFormat vp8_format("VP8");
1210 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1211 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001212 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001213
1214 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001215 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1216 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001217
1218 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001219 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001220 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1221 webrtc::Call::Config call_config(&event_log);
1222 call_config.task_queue_factory = task_queue_factory.get();
1223 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001224
1225 // Create recv channel.
1226 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001227 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001228 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1229 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001230 cricket::VideoRecvParameters recv_parameters;
1231 recv_parameters.codecs.push_back(engine.codecs().front());
1232 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1233 EXPECT_TRUE(recv_channel->AddRecvStream(
1234 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1235
1236 // Remove streams previously added to free the encoder and decoder instance.
1237 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1238}
1239
eladalonf1841382017-06-12 01:16:46 -07001240TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001241 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001242 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001243 std::unique_ptr<VideoMediaChannel> channel(
1244 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001245 ASSERT_TRUE(
1246 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1247 cricket::VideoCodec codec = GetEngineCodec("VP8");
1248 cricket::VideoSendParameters parameters;
1249 parameters.codecs.push_back(codec);
1250 channel->OnReadyToSend(true);
1251 channel->SetSend(true);
1252 ASSERT_TRUE(channel->SetSendParameters(parameters));
1253
Niels Möller805a27e2019-01-21 12:21:27 +01001254 webrtc::test::FrameForwarder frame_forwarder;
1255 cricket::FakeFrameSource frame_source(1280, 720,
1256 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001257 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001258 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001259
Niels Möller805a27e2019-01-21 12:21:27 +01001260 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001261 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001262 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001263 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001264
Niels Möller805a27e2019-01-21 12:21:27 +01001265 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1266 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001267 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001268 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001269
1270 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001271 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1272 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001273 // Change to screen content, recreate encoder. For the simulcast encoder
1274 // adapter case, this will result in two calls since InitEncode triggers a
1275 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001276 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001277 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001278 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001279
Niels Möller805a27e2019-01-21 12:21:27 +01001280 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1281 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001282 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001283 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001284
1285 options.is_screencast.emplace(false);
1286 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001287 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001288 // Change back to regular video content, update encoder. Also change
1289 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001290 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001291 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001292 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001293 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001294
1295 // Remove stream previously added to free the external encoder instance.
1296 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001297 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001298}
1299
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001300class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001301 protected:
1302 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001303 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1304 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001305 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1306 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1307 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001308
1309 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001310 // One testcase calls SetUp in a loop, only create call_ once.
1311 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001312 webrtc::Call::Config call_config(&event_log_);
1313 call_config.task_queue_factory = task_queue_factory_.get();
1314 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001315 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 cricket::MediaConfig media_config;
1317 // Disabling cpu overuse detection actually disables quality scaling too; it
1318 // implies DegradationPreference kMaintainResolution. Automatic scaling
1319 // needs to be disabled, otherwise, tests which check the size of received
1320 // frames become flaky.
1321 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001322 channel_.reset(
1323 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1324 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001325 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001326 channel_->OnReadyToSend(true);
1327 EXPECT_TRUE(channel_.get() != NULL);
1328 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001329 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001330 cricket::VideoRecvParameters parameters;
1331 parameters.codecs = engine_.codecs();
1332 channel_->SetRecvParameters(parameters);
1333 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001334 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1335 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1336 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1337 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001338 }
1339
1340 // Utility method to setup an additional stream to send and receive video.
1341 // Used to test send and recv between two streams.
1342 void SetUpSecondStream() {
1343 SetUpSecondStreamWithNoRecv();
1344 // Setup recv for second stream.
1345 EXPECT_TRUE(channel_->AddRecvStream(
1346 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1347 // Make the second renderer available for use by a new stream.
1348 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1349 }
1350 // Setup an additional stream just to send video. Defer add recv stream.
1351 // This is required if you want to test unsignalled recv of video rtp packets.
1352 void SetUpSecondStreamWithNoRecv() {
1353 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001354 EXPECT_TRUE(
1355 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001356 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001357 EXPECT_FALSE(
1358 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 EXPECT_TRUE(channel_->AddSendStream(
1360 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1361 // We dont add recv for the second stream.
1362
1363 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001364 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001365 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001366 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001367 }
Yves Gerey665174f2018-06-19 15:03:05 +02001368 virtual void TearDown() { channel_.reset(); }
1369 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001370
1371 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001372 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1373 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001374
1375 bool sending = channel_->sending();
1376 bool success = SetSend(false);
1377 if (success) {
1378 cricket::VideoSendParameters parameters;
1379 parameters.codecs.push_back(codec);
1380 success = channel_->SetSendParameters(parameters);
1381 }
1382 if (success) {
1383 success = SetSend(sending);
1384 }
1385 return success;
1386 }
Yves Gerey665174f2018-06-19 15:03:05 +02001387 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001388 void SendFrame() {
1389 if (frame_forwarder_2_) {
1390 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 }
Niels Möller805a27e2019-01-21 12:21:27 +01001392 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001393 }
1394 bool WaitAndSendFrame(int wait_ms) {
1395 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001396 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 return ret;
1398 }
Yves Gerey665174f2018-06-19 15:03:05 +02001399 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001400 int NumRtpBytes(uint32_t ssrc) {
1401 return network_interface_.NumRtpBytes(ssrc);
1402 }
Yves Gerey665174f2018-06-19 15:03:05 +02001403 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001404 int NumRtpPackets(uint32_t ssrc) {
1405 return network_interface_.NumRtpPackets(ssrc);
1406 }
Yves Gerey665174f2018-06-19 15:03:05 +02001407 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1409 return network_interface_.GetRtpPacket(index);
1410 }
1411 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001412 webrtc::RTPHeader header;
1413 EXPECT_TRUE(ParseRtpPacket(p, &header));
1414 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001415 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001416
Niels Möller6557d0c2018-04-11 15:18:34 +02001417 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001418 webrtc::RTPHeader* header) {
1419 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1420 webrtc::RtpHeaderParser::Create());
1421 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001422 }
1423
1424 // Tests that we can send and receive frames.
1425 void SendAndReceive(const cricket::VideoCodec& codec) {
1426 EXPECT_TRUE(SetOneCodec(codec));
1427 EXPECT_TRUE(SetSend(true));
1428 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1429 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001430 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001431 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1432 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1433 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1434 }
1435
1436 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001437 int duration_sec,
1438 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001439 EXPECT_TRUE(SetOneCodec(codec));
1440 EXPECT_TRUE(SetSend(true));
1441 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1442 EXPECT_EQ(0, renderer_.num_rendered_frames());
1443 for (int i = 0; i < duration_sec; ++i) {
1444 for (int frame = 1; frame <= fps; ++frame) {
1445 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1446 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1447 }
1448 }
1449 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1450 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1451 }
1452
Niels Möller6557d0c2018-04-11 15:18:34 +02001453 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1454 cricket::VideoMediaInfo info;
1455 EXPECT_TRUE(channel_->GetStats(&info));
1456 return info.senders[i];
1457 }
1458
1459 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1460 cricket::VideoMediaInfo info;
1461 EXPECT_TRUE(channel_->GetStats(&info));
1462 return info.receivers[i];
1463 }
1464
1465 // Two streams one channel tests.
1466
1467 // Tests that we can send and receive frames.
1468 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1469 SetUpSecondStream();
1470 // Test sending and receiving on first stream.
1471 SendAndReceive(codec);
1472 // Test sending and receiving on second stream.
1473 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1474 EXPECT_GT(NumRtpPackets(), 0);
1475 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1476 }
1477
1478 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1479 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001480 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001481 return engine_codec;
1482 }
1483 // This point should never be reached.
1484 ADD_FAILURE() << "Unrecognized codec name: " << name;
1485 return cricket::VideoCodec();
1486 }
1487
1488 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1489
1490 cricket::StreamParams DefaultSendStreamParams() {
1491 return cricket::StreamParams::CreateLegacy(kSsrc);
1492 }
1493
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001494 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001495 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001496 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001497 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1498 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001499 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001500
1501 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1502 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1503 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1504
Niels Möller6557d0c2018-04-11 15:18:34 +02001505 std::unique_ptr<WebRtcVideoChannel> channel_;
1506 cricket::FakeNetworkInterface network_interface_;
1507 cricket::FakeVideoRenderer renderer_;
1508
1509 // Used by test cases where 2 streams are run on the same channel.
1510 cricket::FakeVideoRenderer renderer2_;
1511};
1512
1513// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001514TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001515 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001516 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001517 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1518 EXPECT_FALSE(channel_->sending());
1519 EXPECT_TRUE(SetSend(true));
1520 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001521 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001522 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1523 EXPECT_TRUE(SetSend(false));
1524 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001525}
Niels Möller6557d0c2018-04-11 15:18:34 +02001526
1527// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001528TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001529 EXPECT_FALSE(channel_->sending());
1530 EXPECT_FALSE(SetSend(true));
1531 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001532}
Niels Möller6557d0c2018-04-11 15:18:34 +02001533
1534// Test that we properly set the send and recv buffer sizes by the time
1535// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001536TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001537 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1538 EXPECT_TRUE(SetSend(true));
1539 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001540 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001541}
1542
Johannes Kron5a0665b2019-04-08 10:35:50 +02001543// Test that we properly set the send and recv buffer sizes when overriding
1544// via field trials.
1545TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1546 // Set field trial to override the default recv buffer size, and then re-run
1547 // setup where the interface is created and configured.
1548 const int kCustomRecvBufferSize = 123456;
1549 webrtc::test::ScopedFieldTrials field_trial(
1550 "WebRTC-IncreasedReceivebuffers/123456/");
1551 SetUp();
1552
1553 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1554 EXPECT_TRUE(SetSend(true));
1555 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1556 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1557}
1558
1559// Test that we properly set the send and recv buffer sizes when overriding
1560// via field trials with suffix.
1561TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1562 // Set field trial to override the default recv buffer size, and then re-run
1563 // setup where the interface is created and configured.
1564 const int kCustomRecvBufferSize = 123456;
1565 webrtc::test::ScopedFieldTrials field_trial(
1566 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1567 SetUp();
1568
1569 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1570 EXPECT_TRUE(SetSend(true));
1571 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1572 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1573}
1574
1575// Test that we properly set the send and recv buffer sizes when overriding
1576// via field trials that don't make any sense.
1577TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1578 // Set bogus field trial values to override the default recv buffer size, and
1579 // then re-run setup where the interface is created and configured. The
1580 // default value should still be used.
1581
1582 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1583 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1584 field_trial_string += group;
1585 field_trial_string += "/";
1586 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1587 SetUp();
1588
1589 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1590 EXPECT_TRUE(SetSend(true));
1591 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1592 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1593 }
1594}
1595
Niels Möller6557d0c2018-04-11 15:18:34 +02001596// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001597TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001598 webrtc::test::ScopedFieldTrials field_trials(
1599 "WebRTC-UseStandardBytesStats/Enabled/");
1600 SetUp();
1601
Niels Möller6557d0c2018-04-11 15:18:34 +02001602 const int kDurationSec = 3;
1603 const int kFps = 10;
1604 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1605
1606 cricket::VideoMediaInfo info;
1607 EXPECT_TRUE(channel_->GetStats(&info));
1608
1609 ASSERT_EQ(1U, info.senders.size());
1610 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1611 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001612 EXPECT_EQ(info.senders[0].bytes_sent,
1613 NumRtpBytes() - kRtpHeaderSize * NumRtpPackets());
Niels Möller6557d0c2018-04-11 15:18:34 +02001614 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1615 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1616 ASSERT_TRUE(info.senders[0].codec_payload_type);
1617 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1618 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1619 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1620 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1621 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1622 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1623 EXPECT_GT(info.senders[0].framerate_input, 0);
1624 EXPECT_GT(info.senders[0].framerate_sent, 0);
1625
1626 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1627 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1628 info.send_codecs[DefaultCodec().id]);
1629
1630 ASSERT_EQ(1U, info.receivers.size());
1631 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1632 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1633 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1634 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1635 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001636 EXPECT_EQ(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1637 info.receivers[0].bytes_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001638 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001639 EXPECT_EQ(0, info.receivers[0].packets_lost);
1640 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1641 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1642 EXPECT_EQ(0, info.receivers[0].firs_sent);
1643 EXPECT_EQ(0, info.receivers[0].plis_sent);
1644 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1645 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1646 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1647 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1648 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1649 EXPECT_GT(info.receivers[0].framerate_output, 0);
1650
1651 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1652 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1653 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001654}
Niels Möller6557d0c2018-04-11 15:18:34 +02001655
1656// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001657TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001658 webrtc::test::ScopedFieldTrials field_trials(
1659 "WebRTC-UseStandardBytesStats/Enabled/");
1660 SetUp();
1661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662 cricket::FakeVideoRenderer renderer1, renderer2;
1663 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1664 cricket::VideoSendParameters parameters;
1665 parameters.codecs.push_back(DefaultCodec());
1666 parameters.conference_mode = true;
1667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1668 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001669 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1670 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001671 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1672 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1673 EXPECT_EQ(0, renderer1.num_rendered_frames());
1674 EXPECT_EQ(0, renderer2.num_rendered_frames());
1675 std::vector<uint32_t> ssrcs;
1676 ssrcs.push_back(1);
1677 ssrcs.push_back(2);
1678 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001679 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001680 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1681 kTimeout);
1682 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1683 kTimeout);
1684
1685 EXPECT_TRUE(channel_->SetSend(false));
1686
1687 cricket::VideoMediaInfo info;
1688 EXPECT_TRUE(channel_->GetStats(&info));
1689 ASSERT_EQ(1U, info.senders.size());
1690 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1691 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001692 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1693 GetSenderStats(0).bytes_sent, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1695 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1696 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1697
1698 ASSERT_EQ(2U, info.receivers.size());
1699 for (size_t i = 0; i < info.receivers.size(); ++i) {
1700 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1701 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001702 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1703 GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1706 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1707 }
srtee0c2eea2017-12-15 17:44:33 +01001708}
Niels Möller6557d0c2018-04-11 15:18:34 +02001709
1710// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001711TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 // Normal setup; note that we set the SSRC explicitly to ensure that
1713 // it will come first in the senders map.
1714 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1715 cricket::VideoSendParameters parameters;
1716 parameters.codecs.push_back(DefaultCodec());
1717 parameters.conference_mode = true;
1718 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001719 EXPECT_TRUE(
1720 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001721 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1722 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001723 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001724 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1725 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1726
1727 // Add an additional capturer, and hook up a renderer to receive it.
1728 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001729 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 const int kTestWidth = 160;
1731 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001732 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1733 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001734 EXPECT_TRUE(
1735 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001736 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001737 EXPECT_TRUE(
1738 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001739 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001740 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001741 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1742 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001743
1744 // Get stats, and make sure they are correct for two senders. We wait until
1745 // the number of expected packets have been sent to avoid races where we
1746 // check stats before it has been updated.
1747 cricket::VideoMediaInfo info;
1748 for (uint32_t i = 0; i < kTimeout; ++i) {
1749 rtc::Thread::Current()->ProcessMessages(1);
1750 EXPECT_TRUE(channel_->GetStats(&info));
1751 ASSERT_EQ(2U, info.senders.size());
1752 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1753 NumRtpPackets()) {
1754 // Stats have been updated for both sent frames, expectations can be
1755 // checked now.
1756 break;
1757 }
1758 }
1759 EXPECT_EQ(NumRtpPackets(),
1760 info.senders[0].packets_sent + info.senders[1].packets_sent)
1761 << "Timed out while waiting for packet counts for all sent packets.";
1762 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1763 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1764 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1765 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1766 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1767 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1768 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1769 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1770 // The capturer must be unregistered here as it runs out of it's scope next.
1771 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001772}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001773
Niels Möller6557d0c2018-04-11 15:18:34 +02001774// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001775TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 cricket::VideoSendParameters parameters;
1777 parameters.codecs.push_back(DefaultCodec());
1778 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1779 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1780 parameters.max_bandwidth_bps = 128 * 1024;
1781 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001782}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001783
Niels Möller6557d0c2018-04-11 15:18:34 +02001784// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001785TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 EXPECT_TRUE(SetDefaultCodec());
1787 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001788 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001790 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001792 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1793 EXPECT_EQ(kSsrc, header.ssrc);
1794
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 // Packets are being paced out, so these can mismatch between the first and
1796 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001797 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1798 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001799 EXPECT_EQ(1, NumSentSsrcs());
1800 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1801 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001802}
Niels Möller6557d0c2018-04-11 15:18:34 +02001803
1804// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001805TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001806 // Remove stream added in Setup.
1807 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1808 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001809 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001810 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001811 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001812 EXPECT_TRUE(SetSend(true));
1813 EXPECT_TRUE(WaitAndSendFrame(0));
1814 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001815 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001816 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001817 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1818 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001819 // Packets are being paced out, so these can mismatch between the first and
1820 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1822 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001823 EXPECT_EQ(1, NumSentSsrcs());
1824 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1825 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001826}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001827
Niels Möller6557d0c2018-04-11 15:18:34 +02001828// Test that we can set the default video renderer before and after
1829// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001830TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001831 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1832 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001833
1834 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1835 rtc::SetBE32(packet1.data() + 8, kSsrc);
1836 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1837 EXPECT_TRUE(SetDefaultCodec());
1838 EXPECT_TRUE(SetSend(true));
1839 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001840 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001841 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001842 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001843 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001844}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001845
Niels Möller6557d0c2018-04-11 15:18:34 +02001846// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001847TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001848 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1849 EXPECT_TRUE(SetSend(true));
1850 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001851 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001852 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1853 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001854 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001855 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001856 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1857 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001858 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1859 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001860
1861 // Remove the send stream that was added during Setup.
1862 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1863 int rtp_packets = NumRtpPackets();
1864
Niels Möller6557d0c2018-04-11 15:18:34 +02001865 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001866 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001867 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001868 EXPECT_EQ(rtp_packets, NumRtpPackets());
1869 // Wait 30ms to guarantee the engine does not drop the frame.
1870 EXPECT_TRUE(WaitAndSendFrame(30));
1871 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1872
1873 last_packet = NumRtpPackets() - 1;
1874 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001875 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1876 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001877}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001878
Niels Möller6557d0c2018-04-11 15:18:34 +02001879// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001880TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001881 cricket::FakeVideoRenderer renderer1, renderer2;
1882 EXPECT_TRUE(SetDefaultCodec());
1883 cricket::VideoSendParameters parameters;
1884 parameters.codecs.push_back(DefaultCodec());
1885 parameters.conference_mode = true;
1886 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1887 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001888 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1889 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001890 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1891 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1892 EXPECT_EQ(0, renderer1.num_rendered_frames());
1893 EXPECT_EQ(0, renderer2.num_rendered_frames());
1894 std::vector<uint32_t> ssrcs;
1895 ssrcs.push_back(1);
1896 ssrcs.push_back(2);
1897 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001898 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001899 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1900 kTimeout);
1901 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1902 kTimeout);
1903
1904 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1905 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1906 EXPECT_EQ(kVideoWidth, renderer1.width());
1907 EXPECT_EQ(kVideoHeight, renderer1.height());
1908 EXPECT_EQ(kVideoWidth, renderer2.width());
1909 EXPECT_EQ(kVideoHeight, renderer2.height());
1910 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1911 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001912}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001913
Niels Möller6557d0c2018-04-11 15:18:34 +02001914// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001915TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 using cricket::FOURCC_I420;
Jonas Olssona4d87372019-07-05 19:08:33 +02001917 using cricket::VideoCodec;
1918 using cricket::VideoFormat;
1919 using cricket::VideoOptions;
Niels Möller6557d0c2018-04-11 15:18:34 +02001920
1921 VideoCodec codec = DefaultCodec();
1922 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1923 EXPECT_TRUE(SetOneCodec(codec));
1924 EXPECT_TRUE(SetSend(true));
1925 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1926 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001927 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001928 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001929
1930 webrtc::test::FrameForwarder frame_forwarder;
1931 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1932 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001933
1934 // TODO(nisse): This testcase fails if we don't configure
1935 // screencast. It's unclear why, I see nothing obvious in this
1936 // test which is related to screencast logic.
1937 VideoOptions video_options;
1938 video_options.is_screencast = true;
1939 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1940
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 int captured_frames = 1;
1942 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001943 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001944 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001945 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1946
Niels Möller6557d0c2018-04-11 15:18:34 +02001947 ++captured_frames;
1948 // Wait until frame of right size is captured.
1949 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001950 480 == renderer_.width() &&
1951 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001952 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001953 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001954 EXPECT_EQ(480, renderer_.width());
1955 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001956 captured_frames = renderer_.num_rendered_frames() + 1;
1957 EXPECT_FALSE(renderer_.black_frame());
1958 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1959 // Make sure a black frame is generated within the specified timeout.
1960 // The black frame should be the resolution of the previous frame to
1961 // prevent expensive encoder reconfigurations.
1962 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001963 480 == renderer_.width() &&
1964 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001965 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001967 EXPECT_EQ(480, renderer_.width());
1968 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001969 EXPECT_TRUE(renderer_.black_frame());
1970
1971 // The black frame has the same timestamp as the next frame since it's
1972 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1973 // not render a frame with the same timestamp so capture another frame
1974 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001975 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001976 }
srtee0c2eea2017-12-15 17:44:33 +01001977}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001978
Niels Möller6557d0c2018-04-11 15:18:34 +02001979// Tests that if SetVideoSend is called with a NULL capturer after the
1980// capturer was already removed, the application doesn't crash (and no black
1981// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001982TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001983 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1984 EXPECT_TRUE(SetSend(true));
1985 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1986 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001987 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1989 // Wait for one frame so they don't get dropped because we send frames too
1990 // tightly.
1991 rtc::Thread::Current()->ProcessMessages(30);
1992 // Remove the capturer.
1993 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1994
1995 // No capturer was added, so this SetVideoSend shouldn't do anything.
1996 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1997 rtc::Thread::Current()->ProcessMessages(300);
1998 // Verify no more frames were sent.
1999 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01002000}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002001
Niels Möller6557d0c2018-04-11 15:18:34 +02002002// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01002003TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2005 // interval time to avoid that.
2006 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2007 // interval time to avoid that.
2008 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02002009 EXPECT_TRUE(
2010 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
2012 cricket::VideoFormat capture_format(
2013 kVideoWidth, kVideoHeight,
2014 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2015 // Set up additional stream 1.
2016 cricket::FakeVideoRenderer renderer1;
2017 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002018 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002020 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002021
2022 webrtc::test::FrameForwarder frame_forwarder1;
2023 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2024 rtc::kNumMicrosecsPerSec / kFramerate);
2025
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 // Set up additional stream 2.
2027 cricket::FakeVideoRenderer renderer2;
2028 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002029 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002030 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002031 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002032 webrtc::test::FrameForwarder frame_forwarder2;
2033
Niels Möller6557d0c2018-04-11 15:18:34 +02002034 // State for all the streams.
2035 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2036 // A limitation in the lmi implementation requires that SetVideoSend() is
2037 // called after SetOneCodec().
2038 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002039 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2040 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002041 EXPECT_TRUE(SetSend(true));
2042 // Test capturer associated with engine.
2043 const int kTestWidth = 160;
2044 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002045 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2046 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2047 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002048 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2049 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002050 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002051 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2052 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2053 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002054 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2055 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002056 // Successfully remove the capturer.
2057 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2058 // The capturers must be unregistered here as it runs out of it's scope
2059 // next.
2060 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2061 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002062}
Niels Möller6557d0c2018-04-11 15:18:34 +02002063
2064// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002065TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002066 // Remove the send stream that was added during Setup.
2067 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2068
2069 cricket::StreamParams empty;
2070 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002071 EXPECT_TRUE(
2072 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002073}
Niels Möller6557d0c2018-04-11 15:18:34 +02002074
2075// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002076TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002077 // Remove stream added in Setup. I.e. remove stream corresponding to default
2078 // channel.
2079 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002080 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002081 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2082 EXPECT_TRUE(channel_->AddSendStream(
2083 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2084 }
2085 // Delete one of the non default channel streams, let the destructor delete
2086 // the remaining ones.
2087 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2088 // Stream should already be deleted.
2089 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002090}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002091
eladalonf1841382017-06-12 01:16:46 -07002092TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002093 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002094}
2095
eladalonf1841382017-06-12 01:16:46 -07002096TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002097 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002098}
2099
eladalonf1841382017-06-12 01:16:46 -07002100TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002101 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002102}
2103
eladalonf1841382017-06-12 01:16:46 -07002104TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002105 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2106 // bitrates. This currently happens at <250k, and two streams sharing 300k
2107 // initially will use QVGA instead of VGA.
2108 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2109 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002110 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002111 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002112 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002113}
2114
philipele8ed8302019-07-03 11:53:48 +02002115TEST_F(WebRtcVideoChannelBaseTest, OnEncoderFailure) {
2116 cricket::VideoSendParameters parameters;
2117 parameters.codecs.push_back(GetEngineCodec("VP9"));
2118 parameters.codecs.push_back(GetEngineCodec("VP8"));
2119 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2120
2121 VideoCodec codec;
2122 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2123 EXPECT_EQ("VP9", codec.name);
2124
2125 // OnEncoderFailure will post a task to the worker thread (which is also
2126 // the current thread), hence the ProcessMessages call.
2127 channel_->OnEncoderFailure();
2128 rtc::Thread::Current()->ProcessMessages(30);
2129 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2130 EXPECT_EQ("VP8", codec.name);
2131
2132 // No other codec to fall back to, keep using VP8.
2133 channel_->OnEncoderFailure();
2134 rtc::Thread::Current()->ProcessMessages(30);
2135 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2136 EXPECT_EQ("VP8", codec.name);
2137}
2138
eladalonf1841382017-06-12 01:16:46 -07002139class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002140 public:
eladalonf1841382017-06-12 01:16:46 -07002141 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2142 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002143 : WebRtcVideoEngineTest(field_trials),
2144 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2145 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002146 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002147 encoder_factory_->AddSupportedVideoCodecType("VP8");
2148 encoder_factory_->AddSupportedVideoCodecType("VP9");
2149#if defined(WEBRTC_USE_H264)
2150 encoder_factory_->AddSupportedVideoCodecType("H264");
2151#endif
2152
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002153 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002154 channel_.reset(engine_.CreateMediaChannel(
2155 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2156 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002157 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002158 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002159 send_parameters_.codecs = engine_.codecs();
2160 recv_parameters_.codecs = engine_.codecs();
2161 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002162 }
2163
2164 protected:
2165 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002166 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002167 }
2168
2169 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002170 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002171 EXPECT_TRUE(channel_->AddSendStream(sp));
2172 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002173 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002174 EXPECT_EQ(num_streams + 1, streams.size());
2175 return streams[streams.size() - 1];
2176 }
2177
2178 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002179 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002180 }
2181
2182 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002183 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002184 }
2185
2186 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002187 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002188 EXPECT_TRUE(channel_->AddRecvStream(sp));
2189 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002190 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002191 EXPECT_EQ(num_streams + 1, streams.size());
2192 return streams[streams.size() - 1];
2193 }
2194
pbos@webrtc.org00873182014-11-25 14:03:34 +00002195 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2196 int expected_min_bitrate_bps,
2197 const char* start_bitrate_kbps,
2198 int expected_start_bitrate_bps,
2199 const char* max_bitrate_kbps,
2200 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002201 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2202 expected_start_bitrate_bps,
2203 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002204 auto& codecs = send_parameters_.codecs;
2205 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002206 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002207 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2208 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2209 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002210 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002211 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002212
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002213 void ExpectSetBitrateParameters(int min_bitrate_bps,
2214 int start_bitrate_bps,
2215 int max_bitrate_bps) {
2216 EXPECT_CALL(
2217 *fake_call_->GetMockTransportControllerSend(),
2218 SetSdpBitrateParameters(AllOf(
2219 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2220 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2221 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2222 }
2223
2224 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2225 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2226 SetSdpBitrateParameters(Field(
2227 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002228 }
2229
Johannes Kron9190b822018-10-29 11:22:05 +01002230 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2231 // For a caller, the answer will be applied in set remote description
2232 // where SetSendParameters() is called.
2233 EXPECT_TRUE(
2234 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2235 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2236 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2237 const webrtc::VideoSendStream::Config& config =
2238 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2239 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2240 }
2241
2242 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2243 // For a callee, the answer will be applied in set local description
2244 // where SetExtmapAllowMixed() and AddSendStream() are called.
2245 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2246 EXPECT_TRUE(
2247 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2248 const webrtc::VideoSendStream::Config& config =
2249 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2250 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2251 }
2252
isheriff6f8d6862016-05-26 11:24:55 -07002253 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002254 // Enable extension.
2255 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002256 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002257 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002258 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002259 FakeVideoSendStream* send_stream =
2260 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2261
2262 // Verify the send extension id.
2263 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2264 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002265 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002266 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002267 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002268 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2269 // receivers.
2270 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2271 ->GetConfig()
2272 .rtp.extensions.empty());
2273
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002274 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002275 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002276 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2277 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002278 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2279
2280 // Verify that adding receive RTP header extensions adds them for existing
2281 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002282 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002283 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002284 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2285 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002286 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002287 }
2288
isheriff6f8d6862016-05-26 11:24:55 -07002289 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002290 // Enable extension.
2291 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002292 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002293 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002294 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002295
2296 FakeVideoReceiveStream* recv_stream =
2297 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2298
2299 // Verify the recv extension id.
2300 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2301 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002302 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002303 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002304 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002305
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002306 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2307 // senders.
2308 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2309 ->GetConfig()
2310 .rtp.extensions.empty());
2311
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002312 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002313 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002314 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2315 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002316 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2317
2318 // Verify that adding receive RTP header extensions adds them for existing
2319 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002320 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002321 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002322 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2323 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002324 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002325 }
2326
Elad Alonfadb1812019-05-24 13:40:02 +02002327 void TestLossNotificationState(bool expect_lntf_enabled) {
2328 AssignDefaultCodec();
2329 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2330
2331 cricket::VideoSendParameters parameters;
2332 parameters.codecs = engine_.codecs();
2333 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2334 EXPECT_TRUE(channel_->SetSend(true));
2335
2336 // Send side.
2337 FakeVideoSendStream* send_stream =
2338 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2339 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2340
2341 // Receiver side.
2342 FakeVideoReceiveStream* recv_stream =
2343 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2344 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2345 }
2346
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002347 void TestExtensionFilter(const std::vector<std::string>& extensions,
2348 const std::string& expected_extension) {
2349 cricket::VideoSendParameters parameters = send_parameters_;
2350 int expected_id = -1;
2351 int id = 1;
2352 for (const std::string& extension : extensions) {
2353 if (extension == expected_extension)
2354 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002355 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002356 }
2357 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2358 FakeVideoSendStream* send_stream =
2359 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2360
2361 // Verify that only one of them has been set, and that it is the one with
2362 // highest priority (transport sequence number).
2363 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2364 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2365 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002366 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002367 }
2368
asapersson3c81a1a2017-06-14 05:52:21 -07002369 void TestDegradationPreference(bool resolution_scaling_enabled,
2370 bool fps_scaling_enabled);
2371
Erik Språngefbde372015-04-29 16:21:28 +02002372 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002373 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002374 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2375 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002376
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002377 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002378 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002379 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002380 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002381 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002382 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002383 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002384 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002385 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002386
Erik Språng143cec12015-04-28 10:01:41 +02002387 return fake_call_->GetVideoSendStreams().back();
2388 }
2389
Peter Boström2feafdb2015-09-09 14:32:14 +02002390 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2391 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002392 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002393 std::vector<uint32_t> ssrcs;
2394 std::vector<uint32_t> rtx_ssrcs;
2395 uint32_t num_streams = enabled ? 3 : 1;
2396 for (uint32_t i = 0; i < num_streams; ++i) {
2397 uint32_t ssrc = last_ssrc_ + i;
2398 ssrcs.push_back(ssrc);
2399 if (with_rtx) {
2400 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2401 }
Erik Språng143cec12015-04-28 10:01:41 +02002402 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002403 if (with_rtx) {
2404 return AddSendStream(
2405 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2406 }
2407 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002408 }
2409
perkjfa10b552016-10-02 23:45:26 -07002410 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002411 std::vector<FakeVideoSendStream*> streams =
2412 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002413 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002414 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002415 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002416 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002417 }
2418
perkjfa10b552016-10-02 23:45:26 -07002419 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002420 int stream_max,
2421 int expected_encoder_bitrate) {
2422 VideoSendParameters limited_send_params = send_parameters_;
2423 limited_send_params.max_bandwidth_bps = global_max;
2424 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002425 webrtc::RtpParameters parameters =
2426 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002427 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002428 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002429 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002430 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002431 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002432 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002433 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002434 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002435 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002436 }
2437
Åsa Persson55659812018-06-18 17:51:32 +02002438 // Values from kSimulcastConfigs in simulcast.cc.
2439 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2440 std::vector<webrtc::VideoStream> layers(3);
2441 layers[0].min_bitrate_bps = 30000;
2442 layers[0].target_bitrate_bps = 150000;
2443 layers[0].max_bitrate_bps = 200000;
2444 layers[1].min_bitrate_bps = 150000;
2445 layers[1].target_bitrate_bps = 500000;
2446 layers[1].max_bitrate_bps = 700000;
2447 layers[2].min_bitrate_bps = 600000;
2448 layers[2].target_bitrate_bps = 2500000;
2449 layers[2].max_bitrate_bps = 2500000;
2450 return layers;
2451 }
2452
Niels Möller805a27e2019-01-21 12:21:27 +01002453 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002454 std::unique_ptr<FakeCall> fake_call_;
2455 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002456 cricket::VideoSendParameters send_parameters_;
2457 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002458 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002459};
2460
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002462 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002463 const std::string kSyncLabel = "AvSyncLabel";
2464
2465 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002466 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002467 EXPECT_TRUE(channel_->AddRecvStream(sp));
2468
Mirko Bonadeif859e552018-05-30 15:31:29 +02002469 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002470 EXPECT_EQ(kSyncLabel,
2471 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2472 << "SyncGroup should be set based on sync_label";
2473}
2474
eladalonf1841382017-06-12 01:16:46 -07002475TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002476 cricket::VideoSendParameters parameters;
2477 parameters.codecs = engine_.codecs();
2478 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002479 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002480 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002481 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002482
2483 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002484 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2485 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002486 FakeVideoSendStream* send_stream = AddSendStream(
2487 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2488
2489 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2490 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2491 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2492
2493 // Receiver side.
2494 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2495 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002496 EXPECT_FALSE(
2497 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002498 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002499 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002500 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002501 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002502 << "RTX should be mapped for the RED payload type";
2503
brandtr14742122017-01-27 04:53:07 -08002504 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002505}
2506
eladalonf1841382017-06-12 01:16:46 -07002507TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002508 // Setup one channel with an associated RTX stream.
2509 cricket::StreamParams params =
2510 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2511 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2512 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002513 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002514
2515 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2516 << "RTX should be mapped for all decoders/payload types.";
2517 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002518 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002519 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002520}
2521
eladalonf1841382017-06-12 01:16:46 -07002522TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002523 // Setup one channel without an associated RTX stream.
2524 cricket::StreamParams params =
2525 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2526 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002527 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002528}
2529
Johannes Kron9190b822018-10-29 11:22:05 +01002530// Test propagation of extmap allow mixed setting.
2531TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2532 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2533}
2534TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2535 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2536}
2537TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2538 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2539}
2540TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2541 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2542}
2543
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002545 FakeVideoSendStream* send_stream =
2546 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2547 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2548
2549 FakeVideoReceiveStream* recv_stream =
2550 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2551 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002552}
2553
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002554// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002555TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002556 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002557}
isheriff6f8d6862016-05-26 11:24:55 -07002558
eladalonf1841382017-06-12 01:16:46 -07002559TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002560 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002561}
2562
2563// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002565 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002566}
isheriff6f8d6862016-05-26 11:24:55 -07002567
eladalonf1841382017-06-12 01:16:46 -07002568TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002569 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002570}
2571
eladalonf1841382017-06-12 01:16:46 -07002572TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002573 // Enable three redundant extensions.
2574 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002575 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2576 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2577 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2578 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002579}
2580
eladalonf1841382017-06-12 01:16:46 -07002581TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002582 // Enable two redundant extensions.
2583 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002584 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2585 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2586 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002587}
2588
stefanc1aeaf02015-10-15 07:26:07 -07002589// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002590TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002591 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002592}
eladalonf1841382017-06-12 01:16:46 -07002593TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002594 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002595}
2596
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002597// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002598TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002599 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002600}
eladalonf1841382017-06-12 01:16:46 -07002601TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002602 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002603}
2604
eladalonf1841382017-06-12 01:16:46 -07002605TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002606 const int kAbsSendTimeId = 1;
2607 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002608 send_parameters_.extensions.push_back(
2609 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2610 send_parameters_.extensions.push_back(
2611 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002612
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002614 FakeVideoSendStream* send_stream =
2615 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2616
2617 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002618 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002619
2620 // Setting the same extensions (even if in different order) shouldn't
2621 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002622 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002624
2625 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2626
2627 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002628 send_parameters_.extensions.resize(1);
2629 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002630
2631 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2632}
2633
eladalonf1841382017-06-12 01:16:46 -07002634TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002635 const int kTOffsetId = 1;
2636 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002637 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002638 recv_parameters_.extensions.push_back(
2639 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2640 recv_parameters_.extensions.push_back(
2641 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2642 recv_parameters_.extensions.push_back(
2643 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002644
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002646 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002647 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2648
2649 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002650 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002651
2652 // Setting the same extensions (even if in different order) shouldn't
2653 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002654 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002655 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002656
2657 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2658
2659 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002660 recv_parameters_.extensions.resize(1);
2661 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002662
2663 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2664}
2665
eladalonf1841382017-06-12 01:16:46 -07002666TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002667 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002668 const int kUnsupportedId = 1;
2669 const int kTOffsetId = 2;
2670
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002671 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002672 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002673 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002674 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002675 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002676 FakeVideoSendStream* send_stream =
2677 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2678
2679 // Only timestamp offset extension is set to send stream,
2680 // unsupported rtp extension is ignored.
2681 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002682 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2683 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002684}
2685
eladalonf1841382017-06-12 01:16:46 -07002686TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002687 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002688 const int kUnsupportedId = 1;
2689 const int kTOffsetId = 2;
2690
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002691 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002692 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002693 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002694 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002695 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002696 FakeVideoReceiveStream* recv_stream =
2697 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2698
2699 // Only timestamp offset extension is set to receive stream,
2700 // unsupported rtp extension is ignored.
2701 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002702 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2703 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002704}
2705
eladalonf1841382017-06-12 01:16:46 -07002706TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002707 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002708 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002709 send_parameters_.extensions.push_back(
2710 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002711 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002712 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2713 }
2714}
2715
eladalonf1841382017-06-12 01:16:46 -07002716TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002717 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002718 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002719 recv_parameters_.extensions.push_back(
2720 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002721 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002722 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2723 }
2724}
2725
eladalonf1841382017-06-12 01:16:46 -07002726TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002727 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002728 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002729 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002730 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002731 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002732 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002733
2734 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002735 send_parameters_.extensions.clear();
2736 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002737 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002738 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2739 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002740}
2741
eladalonf1841382017-06-12 01:16:46 -07002742TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002743 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002744 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002745 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002746 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002747 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002748 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002749
2750 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002751 recv_parameters_.extensions.clear();
2752 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002753 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002754 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2755 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002756}
2757
eladalonf1841382017-06-12 01:16:46 -07002758TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002759 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002760 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002761}
2762
eladalonf1841382017-06-12 01:16:46 -07002763TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002764 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002765 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002766}
2767
eladalonf1841382017-06-12 01:16:46 -07002768TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002769 FakeVideoReceiveStream* stream = AddRecvStream();
2770 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002771}
2772
eladalonf1841382017-06-12 01:16:46 -07002773TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002774 FakeVideoReceiveStream* stream = AddRecvStream();
2775 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2776}
2777
eladalonf1841382017-06-12 01:16:46 -07002778TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002779 FakeVideoReceiveStream* stream = AddRecvStream();
2780 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2781
Peter Boström126c03e2015-05-11 12:48:12 +02002782 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002783 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002784 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002785 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2786 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002787 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002788 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2789
2790 // Verify that REMB is turned on when setting default codecs since the
2791 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002792 parameters.codecs = engine_.codecs();
2793 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002794 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002795 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002796}
2797
eladalonf1841382017-06-12 01:16:46 -07002798TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002799 FakeVideoReceiveStream* stream = AddRecvStream();
2800 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2801
2802 // Verify that transport cc feedback is turned off when send(!) codecs without
2803 // transport cc feedback are set.
2804 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002805 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002806 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2807 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2808 stream = fake_call_->GetVideoReceiveStreams()[0];
2809 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2810
2811 // Verify that transport cc feedback is turned on when setting default codecs
2812 // since the default codecs have transport cc feedback enabled.
2813 parameters.codecs = engine_.codecs();
2814 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2815 stream = fake_call_->GetVideoReceiveStreams()[0];
2816 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2817}
2818
Elad Alonfadb1812019-05-24 13:40:02 +02002819TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2820 TestLossNotificationState(false);
2821}
2822
2823TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2824 RTC_DCHECK(!override_field_trials_);
2825 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2826 "WebRTC-RtcpLossNotification/Enabled/");
2827 SetUp();
2828 TestLossNotificationState(true);
2829}
2830
2831TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2832 RTC_DCHECK(!override_field_trials_);
2833 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2834 "WebRTC-RtcpLossNotification/Enabled/");
2835 SetUp();
2836
2837 AssignDefaultCodec();
2838 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2839
2840 {
2841 cricket::VideoSendParameters parameters;
2842 parameters.codecs = engine_.codecs();
2843 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2844 EXPECT_TRUE(channel_->SetSend(true));
2845 }
2846
2847 // Start with LNTF enabled.
2848 FakeVideoSendStream* send_stream =
2849 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2850 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2851 FakeVideoReceiveStream* recv_stream =
2852 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2853 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2854
2855 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2856 cricket::VideoSendParameters parameters;
2857 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2858 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2859 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2860 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2861 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2862 send_stream = fake_call_->GetVideoSendStreams()[0];
2863 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2864
2865 // Setting the default codecs again, including VP8, turns LNTF back on.
2866 parameters.codecs = engine_.codecs();
2867 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2868 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2869 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2870 send_stream = fake_call_->GetVideoSendStreams()[0];
2871 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2872}
2873
eladalonf1841382017-06-12 01:16:46 -07002874TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002875 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002876 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002877
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002878 cricket::VideoSendParameters parameters;
2879 parameters.codecs = engine_.codecs();
2880 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002881 EXPECT_TRUE(channel_->SetSend(true));
2882
2883 // Send side.
2884 FakeVideoSendStream* send_stream =
2885 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2886 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2887
2888 // Receiver side.
2889 FakeVideoReceiveStream* recv_stream =
2890 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2891 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2892
2893 // Nack history size should match between sender and receiver.
2894 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2895 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002896}
2897
eladalonf1841382017-06-12 01:16:46 -07002898TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002899 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002900 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002901
2902 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2903 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2904
2905 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002906 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002907 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002908 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2909 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002910 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2911 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2912 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002913 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2914
Peter Boström67c9df72015-05-11 14:34:58 +02002915 // Verify that NACK is turned on when setting default codecs since the
2916 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002917 parameters.codecs = engine_.codecs();
2918 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002919 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2920 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2921 send_stream = fake_call_->GetVideoSendStreams()[0];
2922 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002923}
2924
Peter Boströme7ba0862016-03-12 00:02:28 +01002925// This test verifies that new frame sizes reconfigures encoders even though not
2926// (yet) sending. The purpose of this is to permit encoding as quickly as
2927// possible once we start sending. Likely the frames being input are from the
2928// same source that will be sent later, which just means that we're ready
2929// earlier.
eladalonf1841382017-06-12 01:16:46 -07002930TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002931 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002932 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002933 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2934 channel_->SetSend(false);
2935
2936 FakeVideoSendStream* stream = AddSendStream();
2937
perkjfa10b552016-10-02 23:45:26 -07002938 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002939 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002940 EXPECT_EQ(0u, streams[0].width);
2941 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002942
Niels Möller805a27e2019-01-21 12:21:27 +01002943 webrtc::test::FrameForwarder frame_forwarder;
2944 cricket::FakeFrameSource frame_source(1280, 720,
2945 rtc::kNumMicrosecsPerSec / 30);
2946
2947 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2948 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002949
2950 // Frame entered, should be reconfigured to new dimensions.
2951 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002952 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2953 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002954
Niels Möllerff40b142018-04-09 08:49:14 +02002955 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002956}
2957
eladalonf1841382017-06-12 01:16:46 -07002958TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002959 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002960 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002961 cricket::VideoSendParameters parameters;
2962 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002963 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002964 AddSendStream();
2965
Niels Möller805a27e2019-01-21 12:21:27 +01002966 webrtc::test::FrameForwarder frame_forwarder;
2967 cricket::FakeFrameSource frame_source(1280, 720,
2968 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002969 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002970 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002971 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2972 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002973
2974 EXPECT_TRUE(channel_->SetSend(true));
2975
Niels Möller805a27e2019-01-21 12:21:27 +01002976 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002977 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2978 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2979
2980 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2981
2982 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002983 webrtc::VideoEncoderConfig encoder_config =
2984 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002985 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002986 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002987 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002988 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2989 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002990 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2991 << "Non-screenshare shouldn't use min-transmit bitrate.";
2992
Niels Möllerff40b142018-04-09 08:49:14 +02002993 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002994 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002995 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002996 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2998 &frame_forwarder));
2999 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08003000 // Send stream recreated after option change.
3001 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3002 send_stream = fake_call_->GetVideoSendStreams().front();
3003 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003004
3005 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003006 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003007 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003008 encoder_config.content_type);
3009 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
3010 encoder_config.min_transmit_bitrate_bps);
3011
perkjfa10b552016-10-02 23:45:26 -07003012 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003013 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3014 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01003015 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02003016 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003017}
3018
eladalonf1841382017-06-12 01:16:46 -07003019TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003020 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02003021 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08003022 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003023 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003024
3025 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003026 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003027 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003028 webrtc::test::FrameForwarder frame_forwarder;
3029 cricket::FakeFrameSource frame_source(1280, 720,
3030 rtc::kNumMicrosecsPerSec / 30);
3031 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003032 EXPECT_TRUE(channel_->SetSend(true));
3033
Niels Möller805a27e2019-01-21 12:21:27 +01003034 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003035 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3036 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3037
perkj26091b12016-09-01 01:17:40 -07003038 webrtc::VideoEncoderConfig encoder_config =
3039 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003040
3041 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003042 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003043 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003044 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003045
3046 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3047 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003048 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003049 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003050 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003051
Niels Möllerff40b142018-04-09 08:49:14 +02003052 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003053}
3054
eladalonf1841382017-06-12 01:16:46 -07003055TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003056 FakeVideoSendStream* stream = AddSendStream();
3057 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3058}
3059
eladalonf1841382017-06-12 01:16:46 -07003060TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003061 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003062 media_config.video.suspend_below_min_bitrate = true;
3063
Sebastian Jansson84848f22018-11-16 10:40:36 +01003064 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003065 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3066 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003067 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003068
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003069 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003070
3071 FakeVideoSendStream* stream = AddSendStream();
3072 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3073
nisse0db023a2016-03-01 04:29:59 -08003074 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003075 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003076 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3077 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003078 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003079
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003080 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003081
nisse0db023a2016-03-01 04:29:59 -08003082 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003083 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3084}
3085
eladalonf1841382017-06-12 01:16:46 -07003086TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003087 FakeVideoSendStream* stream = AddSendStream();
3088 webrtc::VideoCodecVP8 vp8_settings;
3089 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3090 EXPECT_TRUE(vp8_settings.denoisingOn);
3091}
3092
eladalonf1841382017-06-12 01:16:46 -07003093TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003094 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003095 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003096 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003097
Peter Boström2feafdb2015-09-09 14:32:14 +02003098 // Single-stream settings should apply with RTX as well (verifies that we
3099 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3100 // both RTX and regular SSRCs).
3101 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003102
Niels Möller805a27e2019-01-21 12:21:27 +01003103 webrtc::test::FrameForwarder frame_forwarder;
3104 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003105 channel_->SetSend(true);
3106
Niels Möller805a27e2019-01-21 12:21:27 +01003107 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003108
pbos4cba4eb2015-10-26 11:18:18 -07003109 webrtc::VideoCodecVP8 vp8_settings;
3110 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3111 EXPECT_TRUE(vp8_settings.denoisingOn)
3112 << "VP8 denoising should be on by default.";
3113
Niels Möller805a27e2019-01-21 12:21:27 +01003114 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003115
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003116 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3117 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003118 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3119 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003120
Niels Möller805a27e2019-01-21 12:21:27 +01003121 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003122
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003123 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3124 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003125 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3126 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3127
Niels Möllerff40b142018-04-09 08:49:14 +02003128 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003129 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003130 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003131 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003132 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003133
Mirko Bonadeif859e552018-05-30 15:31:29 +02003134 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003135 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3136 // Autmatic resize off when using simulcast.
3137 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3138 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3139
Florent Castelli66b38602019-07-10 16:57:57 +02003140 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003141 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003142 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003143 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003144
Niels Möller805a27e2019-01-21 12:21:27 +01003145 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003146
Florent Castelli66b38602019-07-10 16:57:57 +02003147 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003148 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3149 EXPECT_FALSE(vp8_settings.denoisingOn);
3150 // Resizing and frame dropping always off for screen sharing.
3151 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3152 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3153
Niels Möller805a27e2019-01-21 12:21:27 +01003154 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003155
3156 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3157 EXPECT_FALSE(vp8_settings.denoisingOn);
3158 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3159 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3160
Niels Möllerff40b142018-04-09 08:49:14 +02003161 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003162}
3163
deadbeef119760a2016-04-04 11:43:27 -07003164// Test that setting the same options doesn't result in the encoder being
3165// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003166TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003167 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003168 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003169
perkjfa10b552016-10-02 23:45:26 -07003170 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003171 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003172 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003173 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3174 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3175
Niels Möller805a27e2019-01-21 12:21:27 +01003176 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3177 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3178 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003179 // Expect 1 reconfigurations at this point from the initial configuration.
3180 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003181
3182 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003183 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003184 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3185
3186 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003187 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003188 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003189 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3190
Niels Möllerff40b142018-04-09 08:49:14 +02003191 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003192}
3193
eladalonf1841382017-06-12 01:16:46 -07003194class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003195 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003196 Vp9SettingsTest() : Vp9SettingsTest("") {}
3197 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003198 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003199 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003200 }
3201 virtual ~Vp9SettingsTest() {}
3202
3203 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003204 void TearDown() override {
3205 // Remove references to encoder_factory_ since this will be destroyed
3206 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003207 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003208 }
Erik Språng143cec12015-04-28 10:01:41 +02003209};
3210
3211TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003212 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003213 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003214 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003215
Peter Boström2feafdb2015-09-09 14:32:14 +02003216 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003217
Niels Möller805a27e2019-01-21 12:21:27 +01003218 webrtc::test::FrameForwarder frame_forwarder;
3219 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003220 channel_->SetSend(true);
3221
Niels Möller805a27e2019-01-21 12:21:27 +01003222 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003223
pbos4cba4eb2015-10-26 11:18:18 -07003224 webrtc::VideoCodecVP9 vp9_settings;
3225 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003226 EXPECT_TRUE(vp9_settings.denoisingOn)
3227 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003228
Niels Möller805a27e2019-01-21 12:21:27 +01003229 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003230
Erik Språng143cec12015-04-28 10:01:41 +02003231 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3232 EXPECT_FALSE(vp9_settings.denoisingOn);
3233 // Frame dropping always on for real time video.
3234 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3235
Niels Möller805a27e2019-01-21 12:21:27 +01003236 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003237
3238 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3239 EXPECT_TRUE(vp9_settings.denoisingOn);
3240 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3241
3242 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003243 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003244 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003245 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003246
Niels Möller805a27e2019-01-21 12:21:27 +01003247 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003248
3249 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3250 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003251 // Frame dropping always on for screen sharing.
3252 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003253
Niels Möller805a27e2019-01-21 12:21:27 +01003254 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003255
3256 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3257 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003258 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003259
Niels Möllerff40b142018-04-09 08:49:14 +02003260 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003261}
3262
Sergey Silkinf18072e2018-03-14 10:35:35 +01003263TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3264 cricket::VideoSendParameters parameters;
3265 parameters.codecs.push_back(GetEngineCodec("VP9"));
3266 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3267
3268 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3269
3270 FakeVideoSendStream* stream =
3271 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3272
3273 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003274
Niels Möller805a27e2019-01-21 12:21:27 +01003275 webrtc::test::FrameForwarder frame_forwarder;
3276 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003277 channel_->SetSend(true);
3278
Niels Möller805a27e2019-01-21 12:21:27 +01003279 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003280
3281 webrtc::VideoCodecVP9 vp9_settings;
3282 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3283
3284 const size_t kNumSpatialLayers = ssrcs.size();
3285 const size_t kNumTemporalLayers = 3;
3286 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3287 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3288
Niels Möllerff40b142018-04-09 08:49:14 +02003289 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003290}
3291
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003292TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3293 cricket::VideoSendParameters parameters;
3294 parameters.codecs.push_back(GetEngineCodec("VP9"));
3295 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3296
3297 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3298
3299 FakeVideoSendStream* stream =
3300 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3301
3302 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3303
3304 // Despite 3 ssrcs provided, single layer is used.
3305 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3306
3307 webrtc::test::FrameForwarder frame_forwarder;
3308 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3309 channel_->SetSend(true);
3310
3311 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3312
3313 webrtc::VideoCodecVP9 vp9_settings;
3314 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3315
3316 const size_t kNumSpatialLayers = ssrcs.size();
3317 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3318
3319 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3320}
3321
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003322TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3323 cricket::VideoSendParameters send_parameters;
3324 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3325 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3326
3327 const size_t kNumSpatialLayers = 3;
3328 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3329
3330 FakeVideoSendStream* stream =
3331 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3332
3333 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3334 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3335 ASSERT_TRUE(parameters.encodings[0].active);
3336 ASSERT_TRUE(parameters.encodings[1].active);
3337 ASSERT_TRUE(parameters.encodings[2].active);
3338 // Invert value to verify copying.
3339 parameters.encodings[1].active = false;
3340 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3341
3342 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3343
3344 // number_of_streams should be 1 since all spatial layers are sent on the
3345 // same SSRC. But encoding parameters of all layers is supposed to be copied
3346 // and stored in simulcast_layers[].
3347 EXPECT_EQ(1u, encoder_config.number_of_streams);
3348 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3349 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3350 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3351 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3352}
3353
Sergey Silkincf267052019-04-09 11:40:09 +02003354class Vp9SettingsTestWithFieldTrial
3355 : public Vp9SettingsTest,
3356 public ::testing::WithParamInterface<
3357 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003358 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003359 Vp9SettingsTestWithFieldTrial()
3360 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3361 num_spatial_layers_(::testing::get<1>(GetParam())),
3362 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003363 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003364
3365 void VerifySettings(int num_spatial_layers,
3366 int num_temporal_layers,
3367 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003368 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003369 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003370 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3371
3372 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3373
Niels Möller805a27e2019-01-21 12:21:27 +01003374 webrtc::test::FrameForwarder frame_forwarder;
3375 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003376 channel_->SetSend(true);
3377
Niels Möller805a27e2019-01-21 12:21:27 +01003378 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003379
3380 webrtc::VideoCodecVP9 vp9_settings;
3381 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3382 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3383 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003384 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003385
Niels Möllerff40b142018-04-09 08:49:14 +02003386 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003387 }
Sergey Silkincf267052019-04-09 11:40:09 +02003388
3389 const uint8_t num_spatial_layers_;
3390 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003391 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003392};
3393
Sergey Silkincf267052019-04-09 11:40:09 +02003394TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003395 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3396 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003397}
3398
Sergey Silkincf267052019-04-09 11:40:09 +02003399INSTANTIATE_TEST_SUITE_P(
3400 ,
3401 Vp9SettingsTestWithFieldTrial,
3402 ::testing::Values(
3403 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3404 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3405 1,
3406 1,
3407 webrtc::InterLayerPredMode::kOnKeyPic),
3408 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3409 2,
3410 3,
3411 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003412 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003413 1,
3414 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003415 webrtc::InterLayerPredMode::kOnKeyPic),
3416 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003417 1,
3418 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003419 webrtc::InterLayerPredMode::kOnKeyPic),
3420 std::make_tuple(
3421 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3422 1,
3423 1,
3424 webrtc::InterLayerPredMode::kOff),
3425 std::make_tuple(
3426 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3427 1,
3428 1,
3429 webrtc::InterLayerPredMode::kOn),
3430 std::make_tuple(
3431 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3432 1,
3433 1,
3434 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003435
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003436TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3437 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3438 ASSERT_EQ(1u, streams.size());
3439 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3440}
3441
3442TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003443 RTC_DCHECK(!override_field_trials_);
3444 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003445 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3446 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3447 ASSERT_EQ(1u, streams.size());
3448 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3449}
3450
asapersson3c81a1a2017-06-14 05:52:21 -07003451TEST_F(WebRtcVideoChannelTest,
3452 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003453 RTC_DCHECK(!override_field_trials_);
3454 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003455 "WebRTC-Video-BalancedDegradation/Disabled/");
3456 const bool kResolutionScalingEnabled = true;
3457 const bool kFpsScalingEnabled = false;
3458 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3459}
3460
3461TEST_F(WebRtcVideoChannelTest,
3462 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003463 RTC_DCHECK(!override_field_trials_);
3464 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003465 "WebRTC-Video-BalancedDegradation/Enabled/");
3466 const bool kResolutionScalingEnabled = true;
3467 const bool kFpsScalingEnabled = true;
3468 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3469}
3470
eladalonf1841382017-06-12 01:16:46 -07003471TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003472 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003473}
3474
eladalonf1841382017-06-12 01:16:46 -07003475TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003476 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003477}
3478
Niels Möller3de32e62019-01-18 08:42:18 +01003479TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3480 TestCpuAdaptation(false, true);
3481}
3482
eladalonf1841382017-06-12 01:16:46 -07003483TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003484 TestCpuAdaptation(true, true);
3485}
3486
eladalonf1841382017-06-12 01:16:46 -07003487TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003488 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003489 cricket::VideoSendParameters parameters;
3490 parameters.codecs.push_back(codec);
3491
kthelgason2bc68642017-02-07 07:02:22 -08003492 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003493 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003494 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003495 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3496 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003497 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003498 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3499
3500 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003501 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003502
Per766ad3b2016-04-05 15:23:49 +02003503 ASSERT_TRUE(channel_->SetSend(true));
3504 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003505 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003506 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003507
3508 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3509 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003510
Niels Möllerdcc70292019-01-15 16:32:38 +01003511 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3512 // Dont' expect anything on framerate_scaling_enabled, since the default is
3513 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003514
Niels Möllerdcc70292019-01-15 16:32:38 +01003515 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003516 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003517 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003518 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003519 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3520 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003521 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003522
Niels Möllerdcc70292019-01-15 16:32:38 +01003523 // Switch back to the normal capturer. Expect resolution scaling to be
3524 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003525 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3526 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003527 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3528 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003529 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003530
Niels Möllerff40b142018-04-09 08:49:14 +02003531 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003532}
3533
asapersson3c81a1a2017-06-14 05:52:21 -07003534// TODO(asapersson): Remove this test when the balanced field trial is removed.
3535void WebRtcVideoChannelTest::TestDegradationPreference(
3536 bool resolution_scaling_enabled,
3537 bool fps_scaling_enabled) {
3538 cricket::VideoCodec codec = GetEngineCodec("VP8");
3539 cricket::VideoSendParameters parameters;
3540 parameters.codecs.push_back(codec);
3541
3542 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003543 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003544 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003545 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3546 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003547 channel_->OnReadyToSend(true);
3548
3549 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3550
3551 AddSendStream();
3552
Niels Möller805a27e2019-01-21 12:21:27 +01003553 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003554 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003555 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003556
3557 EXPECT_TRUE(channel_->SetSend(true));
3558
3559 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3560 EXPECT_EQ(resolution_scaling_enabled,
3561 send_stream->resolution_scaling_enabled());
3562 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3563
Niels Möllerff40b142018-04-09 08:49:14 +02003564 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003565}
3566
eladalonf1841382017-06-12 01:16:46 -07003567void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3568 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003569 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003570 cricket::VideoSendParameters parameters;
3571 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003572
kthelgason2bc68642017-02-07 07:02:22 -08003573 MediaConfig media_config = GetMediaConfig();
3574 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003575 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003576 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003577 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003578 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3579 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003580 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003581
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003582 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003583
3584 AddSendStream();
3585
Niels Möller805a27e2019-01-21 12:21:27 +01003586 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003587 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003588 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003589 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003590
3591 EXPECT_TRUE(channel_->SetSend(true));
3592
solenberge5269742015-09-08 05:13:22 -07003593 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003594
sprangc5d62e22017-04-02 23:53:04 -07003595 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003596 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003597 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003598 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003599 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3600 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3601 } else {
3602 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3603 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3604 }
Niels Möllerff40b142018-04-09 08:49:14 +02003605 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003606}
3607
eladalonf1841382017-06-12 01:16:46 -07003608TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003609 // Start at last timestamp to verify that wraparounds are estimated correctly.
3610 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3611 static const int64_t kInitialNtpTimeMs = 1247891230;
3612 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003613 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003614
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003615 FakeVideoReceiveStream* stream = AddRecvStream();
3616 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003617 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003618
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003619 webrtc::VideoFrame video_frame =
3620 webrtc::VideoFrame::Builder()
3621 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3622 .set_timestamp_rtp(kInitialTimestamp)
3623 .set_timestamp_us(0)
3624 .set_rotation(webrtc::kVideoRotation_0)
3625 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003626 // Initial NTP time is not available on the first frame, but should still be
3627 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003628 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003629
3630 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003631
3632 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3633 // triggers a constant-overflow warning, hence we're calculating it explicitly
3634 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003635 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003636 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3637 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003638 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003639
3640 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003641
3642 // Verify that NTP time has been correctly deduced.
3643 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003644 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003645 ASSERT_EQ(1u, info.receivers.size());
3646 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003647}
3648
eladalonf1841382017-06-12 01:16:46 -07003649TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003650 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003651 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003652
3653 VideoCodec codec;
3654 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003655 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003656
3657 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003658 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3659 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003660 FakeVideoSendStream* stream = AddSendStream(
3661 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003662 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003663
3664 // Make sure NACK and FEC are enabled on the correct payload types.
3665 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003666 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3667 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003668
3669 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3670 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003671 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003672 // TODO(juberti): Check RTCP, PLI, TMMBR.
3673}
3674
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003675TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3676 cricket::VideoSendParameters parameters;
3677 parameters.codecs.push_back(GetEngineCodec("VP8"));
3678 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3679
3680 FakeVideoSendStream* stream = AddSendStream();
3681 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3682 EXPECT_FALSE(config.rtp.raw_payload);
3683}
3684
3685TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3686 cricket::VideoSendParameters parameters;
3687 parameters.codecs.push_back(GetEngineCodec("VP8"));
3688 parameters.codecs.back().packetization = kPacketizationParamRaw;
3689 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3690
3691 FakeVideoSendStream* stream = AddSendStream();
3692 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3693 EXPECT_TRUE(config.rtp.raw_payload);
3694}
3695
brandtr31bd2242017-05-19 05:47:46 -07003696// The following four tests ensures that FlexFEC is not activated by default
3697// when the field trials are not enabled.
3698// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3699// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003700TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003701 FakeVideoSendStream* stream = AddSendStream();
3702 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3703
brandtr3d200bd2017-01-16 06:59:19 -08003704 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003705 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3706 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003707}
3708
eladalonf1841382017-06-12 01:16:46 -07003709TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003710 FakeVideoSendStream* stream = AddSendStream(
3711 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3712 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3713
brandtr3d200bd2017-01-16 06:59:19 -08003714 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003715 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3716 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3717}
3718
Yves Gerey665174f2018-06-19 15:03:05 +02003719TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003720 AddRecvStream();
3721
3722 const std::vector<FakeFlexfecReceiveStream*>& streams =
3723 fake_call_->GetFlexfecReceiveStreams();
3724 EXPECT_TRUE(streams.empty());
3725}
3726
eladalonf1841382017-06-12 01:16:46 -07003727TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003728 AddRecvStream(
3729 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3730
3731 const std::vector<FakeFlexfecReceiveStream*>& streams =
3732 fake_call_->GetFlexfecReceiveStreams();
3733 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003734}
3735
3736// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3737// tests that use this test fixture into the corresponding "non-field trial"
3738// tests.
eladalonf1841382017-06-12 01:16:46 -07003739class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003740 public:
eladalonf1841382017-06-12 01:16:46 -07003741 WebRtcVideoChannelFlexfecRecvTest()
3742 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003743};
3744
eladalonf1841382017-06-12 01:16:46 -07003745TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003746 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3747 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3748 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3749}
3750
eladalonf1841382017-06-12 01:16:46 -07003751TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003752 AddRecvStream();
3753
3754 const std::vector<FakeFlexfecReceiveStream*>& streams =
3755 fake_call_->GetFlexfecReceiveStreams();
3756 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003757
3758 const std::vector<FakeVideoReceiveStream*>& video_streams =
3759 fake_call_->GetVideoReceiveStreams();
3760 ASSERT_EQ(1U, video_streams.size());
3761 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3762 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3763 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003764}
3765
eladalonf1841382017-06-12 01:16:46 -07003766TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003767 AddRecvStream(
3768 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3769
3770 const std::vector<FakeFlexfecReceiveStream*>& streams =
3771 fake_call_->GetFlexfecReceiveStreams();
3772 ASSERT_EQ(1U, streams.size());
3773 const FakeFlexfecReceiveStream* stream = streams.front();
3774 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3775 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3776 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3777 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3778 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003779
3780 const std::vector<FakeVideoReceiveStream*>& video_streams =
3781 fake_call_->GetVideoReceiveStreams();
3782 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003783 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3784 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003785 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003786 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003787 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003788}
3789
eladalonf1841382017-06-12 01:16:46 -07003790TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003791 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3792 cricket::VideoRecvParameters recv_parameters;
3793 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3794 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3795
3796 AddRecvStream(
3797 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3798 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003799 const std::vector<FakeVideoReceiveStream*>& video_streams =
3800 fake_call_->GetVideoReceiveStreams();
3801 ASSERT_EQ(1U, video_streams.size());
3802 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3803 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3804 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003805
3806 // Enable FlexFEC.
3807 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3808 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3809 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3810 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3811 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3812 << "Enabling FlexFEC should not create VideoReceiveStream.";
3813 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3814 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003815 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3816 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003817}
3818
eladalonf1841382017-06-12 01:16:46 -07003819TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003820 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3821 cricket::VideoRecvParameters recv_parameters;
3822 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3823 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3824 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3825
3826 AddRecvStream(
3827 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3828 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003829 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003830 const std::vector<FakeVideoReceiveStream*>& video_streams =
3831 fake_call_->GetVideoReceiveStreams();
3832 ASSERT_EQ(1U, video_streams.size());
3833 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3834 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3835 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003836
3837 // Disable FlexFEC.
3838 recv_parameters.codecs.clear();
3839 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3840 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3841 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3842 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3843 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3844 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3845 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3846 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003847 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3848 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003849}
3850
Steve Anton2d2bbb12019-08-07 09:57:59 -07003851TEST_F(WebRtcVideoChannelFlexfecRecvTest, DuplicateFlexfecCodecIsDropped) {
3852 constexpr int kUnusedPayloadType1 = 127;
3853
3854 cricket::VideoRecvParameters recv_parameters;
3855 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3856 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3857 cricket::VideoCodec duplicate = GetEngineCodec("flexfec-03");
3858 duplicate.id = kUnusedPayloadType1;
3859 recv_parameters.codecs.push_back(duplicate);
3860 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3861
3862 AddRecvStream(
3863 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3864
3865 const std::vector<FakeFlexfecReceiveStream*>& streams =
3866 fake_call_->GetFlexfecReceiveStreams();
3867 ASSERT_EQ(1U, streams.size());
3868 const FakeFlexfecReceiveStream* stream = streams.front();
3869 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3870 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3871}
3872
brandtr31bd2242017-05-19 05:47:46 -07003873// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3874// tests that use this test fixture into the corresponding "non-field trial"
3875// tests.
eladalonf1841382017-06-12 01:16:46 -07003876class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003877 public:
eladalonf1841382017-06-12 01:16:46 -07003878 WebRtcVideoChannelFlexfecSendRecvTest()
3879 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003880 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3881 }
3882};
3883
Yves Gerey665174f2018-06-19 15:03:05 +02003884TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003885 FakeVideoSendStream* stream = AddSendStream();
3886 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3887
brandtr3d200bd2017-01-16 06:59:19 -08003888 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3889 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3890 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003891}
3892
eladalonf1841382017-06-12 01:16:46 -07003893TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003894 FakeVideoSendStream* stream = AddSendStream(
3895 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3896 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3897
brandtr3d200bd2017-01-16 06:59:19 -08003898 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3899 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3900 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3901 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003902}
3903
eladalonf1841382017-06-12 01:16:46 -07003904TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003905 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003906 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003907 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003908
3909 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003910 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003911
brandtrb5f2c3f2016-10-04 23:28:39 -07003912 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3913 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003914}
3915
eladalonf1841382017-06-12 01:16:46 -07003916TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003917 cricket::VideoSendParameters parameters;
3918 parameters.codecs.push_back(GetEngineCodec("VP8"));
3919 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3920
3921 FakeVideoSendStream* stream = AddSendStream();
3922 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3923
brandtr3d200bd2017-01-16 06:59:19 -08003924 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003925}
3926
eladalonf1841382017-06-12 01:16:46 -07003927TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003928 AddRecvStream(
3929 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003930
3931 cricket::VideoRecvParameters recv_parameters;
3932 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3933 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3934 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003935
3936 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3937 fake_call_->GetFlexfecReceiveStreams();
3938 ASSERT_EQ(1U, flexfec_streams.size());
3939 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3940 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3941 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003942 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003943 flexfec_stream_config.payload_type);
3944 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3945 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3946 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3947 const std::vector<FakeVideoReceiveStream*>& video_streams =
3948 fake_call_->GetVideoReceiveStreams();
3949 const FakeVideoReceiveStream* video_stream = video_streams.front();
3950 const webrtc::VideoReceiveStream::Config& video_stream_config =
3951 video_stream->GetConfig();
3952 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3953 flexfec_stream_config.local_ssrc);
3954 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3955 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3956 flexfec_stream_config.rtcp_send_transport);
3957 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3958 // spec-compliant way.
3959 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3960 flexfec_stream_config.transport_cc);
3961 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3962 EXPECT_EQ(video_stream_config.rtp.extensions,
3963 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003964}
3965
brandtr31bd2242017-05-19 05:47:46 -07003966// We should not send FlexFEC, even if we advertise it, unless the right
3967// field trial is set.
3968// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003969TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003970 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3971 cricket::VideoSendParameters parameters;
3972 parameters.codecs.push_back(GetEngineCodec("VP8"));
3973 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3974 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3975
3976 FakeVideoSendStream* stream = AddSendStream();
3977 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3978
3979 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003980 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003981 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3982}
3983
eladalonf1841382017-06-12 01:16:46 -07003984TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003985 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3986 cricket::VideoSendParameters parameters;
3987 parameters.codecs.push_back(GetEngineCodec("VP8"));
3988 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3989 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3990
3991 FakeVideoSendStream* stream = AddSendStream(
3992 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3993 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3994
3995 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003996 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003997 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3998}
3999
eladalonf1841382017-06-12 01:16:46 -07004000TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004001 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08004002 const int kUnusedPayloadType = 127;
4003 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
4004
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004005 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004006 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004007 parameters.codecs.push_back(rtx_codec);
4008 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004009 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004010}
4011
eladalonf1841382017-06-12 01:16:46 -07004012TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004013 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08004014 const int kUnusedPayloadType1 = 126;
4015 const int kUnusedPayloadType2 = 127;
4016 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4017 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4018 {
4019 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4020 kUnusedPayloadType1, GetEngineCodec("VP8").id);
4021 cricket::VideoSendParameters parameters;
4022 parameters.codecs.push_back(GetEngineCodec("VP8"));
4023 parameters.codecs.push_back(rtx_codec);
4024 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4025 }
4026 {
4027 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4028 kUnusedPayloadType1, kUnusedPayloadType2);
4029 cricket::VideoSendParameters parameters;
4030 parameters.codecs.push_back(GetEngineCodec("VP8"));
4031 parameters.codecs.push_back(rtx_codec);
4032 EXPECT_FALSE(channel_->SetSendParameters(parameters))
4033 << "RTX without matching video codec should be rejected.";
4034 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004035}
4036
eladalonf1841382017-06-12 01:16:46 -07004037TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004038 const int kUnusedPayloadType1 = 126;
4039 const int kUnusedPayloadType2 = 127;
4040 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4041 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4042
4043 // SSRCs for RTX.
4044 cricket::StreamParams params =
4045 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4046 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4047 AddSendStream(params);
4048
4049 // Original payload type for RTX.
4050 cricket::VideoSendParameters parameters;
4051 parameters.codecs.push_back(GetEngineCodec("VP8"));
4052 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4053 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4054 parameters.codecs.push_back(rtx_codec);
4055 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4056 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4057 const webrtc::VideoSendStream::Config& config_before =
4058 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4059 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4060 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4061 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4062
4063 // Change payload type for RTX.
4064 parameters.codecs[1].id = kUnusedPayloadType2;
4065 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4066 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4067 const webrtc::VideoSendStream::Config& config_after =
4068 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4069 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4070 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4071 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4072}
4073
eladalonf1841382017-06-12 01:16:46 -07004074TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004075 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004076 parameters.codecs.push_back(GetEngineCodec("VP8"));
4077 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004078 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004079
4080 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004081 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004082
magjed509e4fe2016-11-18 01:34:11 -08004083 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004084
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004085 parameters.codecs.pop_back();
4086 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004087 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004088 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004089 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004090 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004091 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4092}
4093
eladalonf1841382017-06-12 01:16:46 -07004094TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004095 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004096 cricket::VideoSendParameters parameters;
4097 parameters.codecs.push_back(GetEngineCodec("VP8"));
4098 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4099 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4100
4101 FakeVideoSendStream* stream = AddSendStream(
4102 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4103 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4104
brandtr3d200bd2017-01-16 06:59:19 -08004105 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4106 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004107 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4108 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4109
4110 parameters.codecs.pop_back();
4111 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4112 stream = fake_call_->GetVideoSendStreams()[0];
4113 ASSERT_TRUE(stream != nullptr);
4114 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004115 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004116 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004117}
4118
eladalonf1841382017-06-12 01:16:46 -07004119TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004120 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004121 cricket::VideoCodec codec(100, "VP8");
4122 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4123 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004124
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004125 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004126 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004127
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004128 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004129 webrtc::test::FrameForwarder frame_forwarder;
4130 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004131
4132 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004133 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004134
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004135 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004136 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4137 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004138 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004139 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004140 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004141 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004142}
4143
eladalonf1841382017-06-12 01:16:46 -07004144TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004145 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4146 200000);
4147}
4148
eladalonf1841382017-06-12 01:16:46 -07004149TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004150 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4151 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4152 ASSERT_EQ(1u, streams.size());
4153 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4154}
4155
eladalonf1841382017-06-12 01:16:46 -07004156TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004157 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004158 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004159}
4160
eladalonf1841382017-06-12 01:16:46 -07004161TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004162 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004163}
4164
eladalonf1841382017-06-12 01:16:46 -07004165TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004166 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4167 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4168 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004169}
4170
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004171// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4172// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004173TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004174 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4175 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4176 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4177 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004178 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004179 ExpectSetBitrateParameters(100000, 200000, 400000);
4180 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4181 // Since the codec isn't changing, start_bitrate_bps should be -1.
4182 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004183
4184 // Decrease max_bandwidth_bps.
4185 send_parameters_.max_bandwidth_bps = 350000;
4186 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004187
4188 // Now try again with the values flipped around.
4189 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4190 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004191 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004192 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004193
4194 // If we change the codec max, max_bandwidth_bps should still apply.
4195 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004196 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004197 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004198}
4199
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004200// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4201// are present in the same send parameters, the settings are combined correctly.
4202TEST_F(WebRtcVideoChannelTest,
4203 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4204 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4205 // Transport.
4206 webrtc::MediaTransportSettings settings;
4207 settings.is_caller = true;
4208 webrtc::FakeMediaTransport fake_media_transport(settings);
4209 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4210 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004211 channel_->SetInterface(network_interface.get(),
4212 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004213
4214 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4215 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4216 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4217 send_parameters_.max_bandwidth_bps = 400000;
4218 {
4219 // We expect max_bandwidth_bps to take priority, if set.
4220 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4221 ASSERT_EQ(1u,
4222 fake_media_transport.target_rate_constraints_in_order().size());
4223 const webrtc::MediaTransportTargetRateConstraints& constraint =
4224 fake_media_transport.target_rate_constraints_in_order()[0];
4225 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4226 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4227 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4228 }
4229
4230 {
4231 // Decrease max_bandwidth_bps.
4232 send_parameters_.max_bandwidth_bps = 350000;
4233 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4234 ASSERT_EQ(2u,
4235 fake_media_transport.target_rate_constraints_in_order().size());
4236 const webrtc::MediaTransportTargetRateConstraints& constraint =
4237 fake_media_transport.target_rate_constraints_in_order()[1];
4238
4239 // Since the codec isn't changing, start_bitrate_bps should be 0.
4240 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4241 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4242 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4243 }
4244
4245 {
4246 // Now try again with the values flipped around.
4247 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4248 send_parameters_.max_bandwidth_bps = 300000;
4249 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4250 ASSERT_EQ(3u,
4251 fake_media_transport.target_rate_constraints_in_order().size());
4252 const webrtc::MediaTransportTargetRateConstraints& constraint =
4253 fake_media_transport.target_rate_constraints_in_order()[2];
4254
4255 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4256 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4257 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4258 }
4259
4260 {
4261 // Now try again with the values flipped around.
4262 // If we change the codec max, max_bandwidth_bps should still apply.
4263 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4264 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4265 ASSERT_EQ(4u,
4266 fake_media_transport.target_rate_constraints_in_order().size());
4267 const webrtc::MediaTransportTargetRateConstraints& constraint =
4268 fake_media_transport.target_rate_constraints_in_order()[3];
4269
4270 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4271 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4272 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4273 }
4274}
4275
Yves Gerey665174f2018-06-19 15:03:05 +02004276TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004277 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4278 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004279 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004280 // Setting max bitrate should keep previous min bitrate.
4281 // Setting max bitrate should not reset start bitrate.
4282 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004283 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004284}
4285
eladalonf1841382017-06-12 01:16:46 -07004286TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004287 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004288 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004289 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004290 // -1 means to disable max bitrate (set infinite).
4291 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004292 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004293 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004294}
4295
eladalonf1841382017-06-12 01:16:46 -07004296TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004297 send_parameters_.max_bandwidth_bps = 99999;
4298 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004299 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004300 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004301 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4302 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4303 stream->GetVideoStreams()[0].max_bitrate_bps);
4304
4305 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004306 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004307 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4308 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004309 stream->GetVideoStreams()[0].max_bitrate_bps);
4310}
4311
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004312// Tests that when the codec specific max bitrate and VideoSendParameters
4313// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4314// appropriately.
4315TEST_F(WebRtcVideoChannelTest,
4316 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4317 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4318 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4319 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4320 send_parameters_.max_bandwidth_bps = -1;
4321 AddSendStream();
4322 ExpectSetMaxBitrate(300000);
4323 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4324
4325 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4326 ASSERT_EQ(1u, video_send_streams.size());
4327 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4328 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4329 // First the max bitrate is set based upon the codec param.
4330 EXPECT_EQ(300000,
4331 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4332
4333 // The VideoSendParameters max bitrate overrides the codec's.
4334 send_parameters_.max_bandwidth_bps = 500000;
4335 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4336 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4337 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4338 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4339}
4340
4341// Tests that when the codec specific max bitrate and RtpParameters
4342// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4343// appropriately.
4344TEST_F(WebRtcVideoChannelTest,
4345 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4346 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4347 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4348 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4349 send_parameters_.max_bandwidth_bps = -1;
4350 AddSendStream();
4351 ExpectSetMaxBitrate(300000);
4352 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4353
4354 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4355 ASSERT_EQ(1u, video_send_streams.size());
4356 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4357 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4358 // First the max bitrate is set based upon the codec param.
4359 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4360
4361 // The RtpParameter max bitrate overrides the codec's.
4362 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4363 ASSERT_EQ(1u, parameters.encodings.size());
4364 parameters.encodings[0].max_bitrate_bps = 500000;
4365 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4366 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4367 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4368 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4369}
4370
Åsa Persson55659812018-06-18 17:51:32 +02004371TEST_F(WebRtcVideoChannelTest,
4372 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4373 send_parameters_.max_bandwidth_bps = 99999;
4374 FakeVideoSendStream* stream = AddSendStream();
4375 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4376 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4377 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4378 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4379 stream->GetVideoStreams()[0].max_bitrate_bps);
4380
4381 // Get and set the rtp encoding parameters.
4382 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4383 EXPECT_EQ(1u, parameters.encodings.size());
4384
4385 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4386 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4387 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4388 stream->GetVideoStreams()[0].max_bitrate_bps);
4389
4390 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4391 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4392 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4393 stream->GetVideoStreams()[0].max_bitrate_bps);
4394}
4395
eladalonf1841382017-06-12 01:16:46 -07004396TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004397 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004398 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004399 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004400 channel_->SetSend(true);
4401
4402 FakeVideoSendStream* stream = AddSendStream();
4403
Niels Möller805a27e2019-01-21 12:21:27 +01004404 webrtc::test::FrameForwarder frame_forwarder;
4405 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004406
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004407 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4408 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4409 EXPECT_GT(initial_max_bitrate_bps, 0);
4410
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004411 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4412 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004413 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004414 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004415 streams = stream->GetVideoStreams();
4416 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004417 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004418}
4419
eladalonf1841382017-06-12 01:16:46 -07004420TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004421 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004422 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004423 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004424 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004425 channel_->SetSend(true);
4426
4427 FakeVideoSendStream* stream = AddSendStream(
4428 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4429
4430 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004431 webrtc::test::FrameForwarder frame_forwarder;
4432 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4433 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004434
4435 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4436 ASSERT_GT(streams.size(), 1u)
4437 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004438 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004439 EXPECT_GT(initial_max_bitrate_bps, 0);
4440
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004441 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4442 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004443 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004444 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004445 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004446 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004447 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4448
Niels Möllerff40b142018-04-09 08:49:14 +02004449 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004450}
4451
eladalonf1841382017-06-12 01:16:46 -07004452TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004453 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004454 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004455 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004456 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4457 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004458 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004459 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004460
4461 VideoCodec codec;
4462 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4463 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4464}
4465
eladalonf1841382017-06-12 01:16:46 -07004466TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004467 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004468 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004469 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004470 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004471 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004472 parameters.codecs[0].id = kIncorrectPayloads[i];
4473 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004474 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004475 }
4476}
4477
eladalonf1841382017-06-12 01:16:46 -07004478TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004479 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004480 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004481 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004482 parameters.codecs[0].id = payload_type;
4483 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004484 << "Payload type '" << payload_type << "' rejected.";
4485 }
4486}
4487
deadbeef67cf2c12016-04-13 10:07:16 -07004488// Test that setting the a different set of codecs but with an identical front
4489// codec doesn't result in the stream being recreated.
4490// This may happen when a subsequent negotiation includes fewer codecs, as a
4491// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004492TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004493 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4494 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004495 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4496 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004497 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4498
4499 AddSendStream();
4500 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4501
4502 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004503 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004504 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4505 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4506}
4507
eladalonf1841382017-06-12 01:16:46 -07004508TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004509 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004510 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004511 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004512}
4513
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004514// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004515TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004516 const int kUnusedPayloadType1 = 126;
4517 const int kUnusedPayloadType2 = 127;
4518 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4519 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4520
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004521 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004522 parameters.codecs.push_back(GetEngineCodec("VP8"));
4523 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004524 parameters.codecs.push_back(rtx_codec);
4525 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004526 << "RTX codec without associated payload should be rejected.";
4527
magjed509e4fe2016-11-18 01:34:11 -08004528 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004529 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004530 << "RTX codec with invalid associated payload type should be rejected.";
4531
magjed509e4fe2016-11-18 01:34:11 -08004532 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004533 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004534
magjed509e4fe2016-11-18 01:34:11 -08004535 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004536 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004537 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004538
Yves Gerey665174f2018-06-19 15:03:05 +02004539 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4540 << "RTX codec with another RTX as associated payload type should be "
4541 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004542}
4543
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004544TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4545 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4546 vp8_codec.packetization = kPacketizationParamRaw;
4547
4548 cricket::VideoRecvParameters parameters;
4549 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4550 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4551
4552 const cricket::StreamParams params =
4553 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4554 AddRecvStream(params);
4555 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4556
4557 const webrtc::VideoReceiveStream::Config& config =
4558 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4559 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4560 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4561}
4562
4563TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4564 cricket::VideoRecvParameters parameters;
4565 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4566 parameters.codecs.back().packetization = kPacketizationParamRaw;
4567 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4568
4569 const cricket::StreamParams params =
4570 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4571 AddRecvStream(params);
4572 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4573 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4574
4575 parameters.codecs.back().packetization.reset();
4576 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4577 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4578}
4579
Steve Anton2d2bbb12019-08-07 09:57:59 -07004580TEST_F(WebRtcVideoChannelTest, DuplicateUlpfecCodecIsDropped) {
4581 constexpr int kFirstUlpfecPayloadType = 126;
4582 constexpr int kSecondUlpfecPayloadType = 127;
4583
4584 cricket::VideoRecvParameters parameters;
4585 parameters.codecs.push_back(GetEngineCodec("VP8"));
4586 parameters.codecs.push_back(
4587 cricket::VideoCodec(kFirstUlpfecPayloadType, cricket::kUlpfecCodecName));
4588 parameters.codecs.push_back(
4589 cricket::VideoCodec(kSecondUlpfecPayloadType, cricket::kUlpfecCodecName));
4590 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4591
4592 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4593 EXPECT_EQ(kFirstUlpfecPayloadType,
4594 recv_stream->GetConfig().rtp.ulpfec_payload_type);
4595}
4596
4597TEST_F(WebRtcVideoChannelTest, DuplicateRedCodecIsDropped) {
4598 constexpr int kFirstRedPayloadType = 126;
4599 constexpr int kSecondRedPayloadType = 127;
4600
4601 cricket::VideoRecvParameters parameters;
4602 parameters.codecs.push_back(GetEngineCodec("VP8"));
4603 parameters.codecs.push_back(
4604 cricket::VideoCodec(kFirstRedPayloadType, cricket::kRedCodecName));
4605 parameters.codecs.push_back(
4606 cricket::VideoCodec(kSecondRedPayloadType, cricket::kRedCodecName));
4607 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4608
4609 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4610 EXPECT_EQ(kFirstRedPayloadType,
4611 recv_stream->GetConfig().rtp.red_payload_type);
4612}
4613
eladalonf1841382017-06-12 01:16:46 -07004614TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004615 const int kUnusedPayloadType1 = 126;
4616 const int kUnusedPayloadType2 = 127;
4617 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4618 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4619
4620 // SSRCs for RTX.
4621 cricket::StreamParams params =
4622 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4623 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4624 AddRecvStream(params);
4625
4626 // Original payload type for RTX.
4627 cricket::VideoRecvParameters parameters;
4628 parameters.codecs.push_back(GetEngineCodec("VP8"));
4629 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4630 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4631 parameters.codecs.push_back(rtx_codec);
4632 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4633 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4634 const webrtc::VideoReceiveStream::Config& config_before =
4635 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004636 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4637 const int* payload_type_before = FindKeyByValue(
4638 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4639 ASSERT_NE(payload_type_before, nullptr);
4640 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004641 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4642
4643 // Change payload type for RTX.
4644 parameters.codecs[1].id = kUnusedPayloadType2;
4645 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4646 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4647 const webrtc::VideoReceiveStream::Config& config_after =
4648 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004649 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4650 const int* payload_type_after = FindKeyByValue(
4651 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4652 ASSERT_NE(payload_type_after, nullptr);
4653 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004654 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4655}
4656
eladalonf1841382017-06-12 01:16:46 -07004657TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004658 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004659 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004660 parameters.codecs[0].id = 99;
4661 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004662}
4663
eladalonf1841382017-06-12 01:16:46 -07004664TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004665 cricket::VideoRecvParameters parameters;
4666 parameters.codecs = engine_.codecs();
4667 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004668
4669 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004670 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004671 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004672 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004673}
4674
eladalonf1841382017-06-12 01:16:46 -07004675TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004676 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004677 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004678 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004679 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004680}
4681
eladalonf1841382017-06-12 01:16:46 -07004682TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004683 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004684 parameters.codecs.push_back(GetEngineCodec("VP8"));
4685 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004686 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004687}
4688
eladalonf1841382017-06-12 01:16:46 -07004689TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004690 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004691 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4692 send_parameters.codecs.push_back(GetEngineCodec("red"));
4693 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004694 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004695
4696 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004697
magjed509e4fe2016-11-18 01:34:11 -08004698 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004699 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004700
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004701 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004702 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004703 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004704 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004705 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004706 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004707 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4708}
4709
eladalonf1841382017-06-12 01:16:46 -07004710TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004711 AddRecvStream(
4712 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004713 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004714 fake_call_->GetFlexfecReceiveStreams();
4715
4716 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004717 const FakeFlexfecReceiveStream* stream = streams.front();
4718 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4719 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4720 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4721 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004722
4723 cricket::VideoRecvParameters recv_parameters;
4724 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4725 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4726 EXPECT_TRUE(streams.empty())
4727 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004728}
4729
eladalonf1841382017-06-12 01:16:46 -07004730TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004731 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004732 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004733 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004734
4735 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004736 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4737 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4738 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004739 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4740 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004741 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004742 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004743 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004744 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004745
4746 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004747 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4748 send_parameters.codecs.push_back(GetEngineCodec("red"));
4749 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004750 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4751 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004752 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004753 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004754 << "ULPFEC should be enabled on the receive stream.";
4755}
4756
eladalonf1841382017-06-12 01:16:46 -07004757TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004758 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004759 AddRecvStream(
4760 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004761 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004762 fake_call_->GetFlexfecReceiveStreams();
4763
4764 cricket::VideoRecvParameters recv_parameters;
4765 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4766 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4767 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4768 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004769 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004770 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004771 stream_with_recv_params->GetConfig().payload_type);
4772 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004773 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004774 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004775 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004776 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004777
4778 cricket::VideoSendParameters send_parameters;
4779 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4780 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4781 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4782 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004783 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004784 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004785 stream_with_send_params->GetConfig().payload_type);
4786 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004787 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004788 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004789 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004790 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004791}
4792
eladalonf1841382017-06-12 01:16:46 -07004793TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004794 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004795 parameters.codecs.push_back(GetEngineCodec("VP8"));
4796 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004797 parameters.codecs[1].id = parameters.codecs[0].id;
4798 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004799}
4800
eladalonf1841382017-06-12 01:16:46 -07004801TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004802 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004803 cricket::VideoRecvParameters parameters;
4804 parameters.codecs.push_back(GetEngineCodec("VP8"));
4805 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4806 parameters.codecs[1].id = parameters.codecs[0].id;
4807 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4808}
4809
eladalonf1841382017-06-12 01:16:46 -07004810TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004811 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004812 parameters.codecs.push_back(GetEngineCodec("VP8"));
4813 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004814 parameters.codecs[1].id = parameters.codecs[0].id;
4815 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004816}
4817
eladalonf1841382017-06-12 01:16:46 -07004818TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004819 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004820 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004821 parameters.codecs.push_back(GetEngineCodec("VP8"));
4822 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004823 parameters.codecs[1].id += 1;
4824 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004825}
4826
deadbeef67cf2c12016-04-13 10:07:16 -07004827// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004828// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004829TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004830 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004831 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004832 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4833 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004834 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004835
4836 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4837 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4838
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004839 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004840 parameters2.codecs.push_back(GetEngineCodec("red"));
4841 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004842 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004843 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4844}
4845
eladalonf1841382017-06-12 01:16:46 -07004846TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004847 EXPECT_FALSE(AddSendStream()->IsSending());
4848}
4849
eladalonf1841382017-06-12 01:16:46 -07004850TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004851 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004852}
4853
eladalonf1841382017-06-12 01:16:46 -07004854TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004855 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004856 EXPECT_FALSE(stream->IsSending());
4857
4858 // false->true
4859 EXPECT_TRUE(channel_->SetSend(true));
4860 EXPECT_TRUE(stream->IsSending());
4861 // true->true
4862 EXPECT_TRUE(channel_->SetSend(true));
4863 EXPECT_TRUE(stream->IsSending());
4864 // true->false
4865 EXPECT_TRUE(channel_->SetSend(false));
4866 EXPECT_FALSE(stream->IsSending());
4867 // false->false
4868 EXPECT_TRUE(channel_->SetSend(false));
4869 EXPECT_FALSE(stream->IsSending());
4870
4871 EXPECT_TRUE(channel_->SetSend(true));
4872 FakeVideoSendStream* new_stream = AddSendStream();
4873 EXPECT_TRUE(new_stream->IsSending())
4874 << "Send stream created after SetSend(true) not sending initially.";
4875}
4876
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004877// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004878TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004879 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004880 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004881 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004882 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004883 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004884
Sebastian Jansson84848f22018-11-16 10:40:36 +01004885 channel.reset(
4886 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004887 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4888 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004889 channel->SetInterface(network_interface.get(),
4890 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004891 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004892 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004893
Tim Haloun648d28a2018-10-18 16:52:22 -07004894 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4895 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004896 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004897 channel.reset(
4898 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004899 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4900 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004901 channel->SetInterface(network_interface.get(),
4902 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004903 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4904
4905 // Create a send stream to configure
4906 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4907 parameters = channel->GetRtpSendParameters(kSsrc);
4908 ASSERT_FALSE(parameters.encodings.empty());
4909
4910 // Various priorities map to various dscp values.
4911 parameters.encodings[0].network_priority = 4.0;
4912 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004913 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004914 parameters.encodings[0].network_priority = 0.5;
4915 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4916 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4917
4918 // A bad priority does not change the dscp value.
4919 parameters.encodings[0].network_priority = 0.0;
4920 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4921 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004922
Tim Haloun6ca98362018-09-17 17:06:08 -07004923 // Packets should also self-identify their dscp in PacketOptions.
4924 const uint8_t kData[10] = {0};
4925 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4926 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004927 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004928
nisse51542be2016-02-12 02:27:06 -08004929 // Verify that setting the option to false resets the
4930 // DiffServCodePoint.
4931 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004932 channel.reset(
4933 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004934 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4935 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004936 channel->SetInterface(network_interface.get(),
4937 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004938 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004939}
4940
deadbeef13871492015-12-09 12:37:51 -08004941// This test verifies that the RTCP reduced size mode is properly applied to
4942// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004943TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004944 // Create stream, expecting that default mode is "compound".
4945 FakeVideoSendStream* stream1 = AddSendStream();
4946 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004947 webrtc::RtpParameters rtp_parameters =
4948 channel_->GetRtpSendParameters(last_ssrc_);
4949 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004950
4951 // Now enable reduced size mode.
4952 send_parameters_.rtcp.reduced_size = true;
4953 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4954 stream1 = fake_call_->GetVideoSendStreams()[0];
4955 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004956 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4957 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004958
4959 // Create a new stream and ensure it picks up the reduced size mode.
4960 FakeVideoSendStream* stream2 = AddSendStream();
4961 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4962}
4963
4964// This test verifies that the RTCP reduced size mode is properly applied to
4965// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004966TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004967 // Create stream, expecting that default mode is "compound".
4968 FakeVideoReceiveStream* stream1 = AddRecvStream();
4969 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4970
4971 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004972 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4973 // the reduced_size flag should come from that.
4974 send_parameters_.rtcp.reduced_size = true;
4975 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004976 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4977 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4978
4979 // Create a new stream and ensure it picks up the reduced size mode.
4980 FakeVideoReceiveStream* stream2 = AddRecvStream();
4981 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4982}
4983
eladalonf1841382017-06-12 01:16:46 -07004984TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004985 EXPECT_EQ(webrtc::kNetworkUp,
4986 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4987 EXPECT_EQ(webrtc::kNetworkUp,
4988 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004989
4990 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004991 EXPECT_EQ(webrtc::kNetworkDown,
4992 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4993 EXPECT_EQ(webrtc::kNetworkUp,
4994 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004995
4996 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004997 EXPECT_EQ(webrtc::kNetworkUp,
4998 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4999 EXPECT_EQ(webrtc::kNetworkUp,
5000 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00005001}
5002
eladalonf1841382017-06-12 01:16:46 -07005003TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005004 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005005 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005006 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01005007
5008 AddSendStream();
5009
5010 cricket::VideoMediaInfo info;
5011 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08005012 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01005013}
5014
eladalonf1841382017-06-12 01:16:46 -07005015TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01005016 FakeVideoSendStream* stream = AddSendStream();
5017 webrtc::VideoSendStream::Stats stats;
5018 stats.encoder_implementation_name = "encoder_implementation_name";
5019 stream->SetStats(stats);
5020
5021 cricket::VideoMediaInfo info;
5022 ASSERT_TRUE(channel_->GetStats(&info));
5023 EXPECT_EQ(stats.encoder_implementation_name,
5024 info.senders[0].encoder_implementation_name);
5025}
5026
eladalonf1841382017-06-12 01:16:46 -07005027TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005028 FakeVideoSendStream* stream = AddSendStream();
5029 webrtc::VideoSendStream::Stats stats;
5030 stats.avg_encode_time_ms = 13;
5031 stats.encode_usage_percent = 42;
5032 stream->SetStats(stats);
5033
5034 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005035 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005036 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
5037 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
5038}
5039
eladalonf1841382017-06-12 01:16:46 -07005040TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07005041 FakeVideoSendStream* stream = AddSendStream();
5042 webrtc::VideoSendStream::Stats stats;
5043 stats.frames_encoded = 13;
5044 stream->SetStats(stats);
5045
5046 cricket::VideoMediaInfo info;
5047 ASSERT_TRUE(channel_->GetStats(&info));
5048 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
5049}
5050
Rasmus Brandt2efae772019-06-27 14:29:34 +02005051TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
5052 FakeVideoSendStream* stream = AddSendStream();
5053 webrtc::VideoSendStream::Stats stats;
5054 stats.substreams[123].frame_counts.key_frames = 10;
5055 stats.substreams[456].frame_counts.key_frames = 87;
5056 stream->SetStats(stats);
5057
5058 cricket::VideoMediaInfo info;
5059 ASSERT_TRUE(channel_->GetStats(&info));
5060 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
5061 // for each simulcast stream, instead of accumulating all keyframes encoded
5062 // over all simulcast streams in the same outbound-rtp stats object.
5063 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
5064}
5065
eladalonf1841382017-06-12 01:16:46 -07005066TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07005067 FakeVideoSendStream* stream = AddSendStream();
5068 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01005069 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07005070 stream->SetStats(stats);
5071
5072 cricket::VideoMediaInfo info;
5073 ASSERT_TRUE(channel_->GetStats(&info));
5074 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5075}
5076
eladalonf1841382017-06-12 01:16:46 -07005077TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005078 FakeVideoSendStream* stream = AddSendStream();
5079 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005080 stats.substreams[17].width = 123;
5081 stats.substreams[17].height = 40;
5082 stats.substreams[42].width = 80;
5083 stats.substreams[42].height = 31;
5084 stats.substreams[11].width = 20;
5085 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005086 stream->SetStats(stats);
5087
5088 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005089 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005090 ASSERT_EQ(1u, info.senders.size());
5091 EXPECT_EQ(123, info.senders[0].send_frame_width);
5092 EXPECT_EQ(90, info.senders[0].send_frame_height);
5093}
5094
eladalonf1841382017-06-12 01:16:46 -07005095TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005096 FakeVideoSendStream* stream = AddSendStream();
5097 webrtc::VideoSendStream::Stats stats;
5098 stats.number_of_cpu_adapt_changes = 2;
5099 stats.cpu_limited_resolution = true;
5100 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005101
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005102 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005103 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005104 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005105 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005106 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005107}
5108
eladalonf1841382017-06-12 01:16:46 -07005109TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005110 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005111 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005112 stats.number_of_cpu_adapt_changes = 2;
5113 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005114 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005115 stream->SetStats(stats);
5116
5117 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005118 EXPECT_TRUE(channel_->GetStats(&info));
5119 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005120 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5121 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005122 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005123 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005124}
5125
eladalonf1841382017-06-12 01:16:46 -07005126TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005127 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5128 FakeVideoSendStream* stream = AddSendStream();
5129 webrtc::VideoSendStream::Stats stats;
5130 stats.bw_limited_resolution = true;
5131 stream->SetStats(stats);
5132
5133 cricket::VideoMediaInfo info;
5134 EXPECT_TRUE(channel_->GetStats(&info));
5135 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005136 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005137 info.senders[0].adapt_reason);
5138}
5139
Yves Gerey665174f2018-06-19 15:03:05 +02005140TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005141 FakeVideoSendStream* stream = AddSendStream();
5142 webrtc::VideoSendStream::Stats stats;
5143 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5144 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5145 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5146
5147 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5148 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5149 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5150
5151 stream->SetStats(stats);
5152
5153 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005154 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005155 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5156 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5157 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5158}
5159
eladalonf1841382017-06-12 01:16:46 -07005160TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005161 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5162 FakeVideoReceiveStream* stream = AddRecvStream();
5163 webrtc::VideoReceiveStream::Stats stats;
5164 stats.rtcp_packet_type_counts.fir_packets = 2;
5165 stats.rtcp_packet_type_counts.nack_packets = 3;
5166 stats.rtcp_packet_type_counts.pli_packets = 4;
5167 stream->SetStats(stats);
5168
5169 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005170 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005171 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005172 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005173 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005174 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005175 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005176 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005177}
5178
eladalonf1841382017-06-12 01:16:46 -07005179TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005180 FakeVideoReceiveStream* stream = AddRecvStream();
5181 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005182 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005183 stats.decode_ms = 2;
5184 stats.max_decode_ms = 3;
5185 stats.current_delay_ms = 4;
5186 stats.target_delay_ms = 5;
5187 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005188 stats.jitter_buffer_delay_seconds = 60;
5189 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005190 stats.min_playout_delay_ms = 7;
5191 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005192 stats.width = 9;
5193 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005194 stats.frame_counts.key_frames = 11;
5195 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005196 stats.frames_rendered = 13;
5197 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005198 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005199 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005200 stream->SetStats(stats);
5201
5202 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005203 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005204 EXPECT_EQ(stats.decoder_implementation_name,
5205 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005206 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5207 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5208 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5209 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5210 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005211 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5212 info.receivers[0].jitter_buffer_delay_seconds);
5213 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5214 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005215 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5216 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005217 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5218 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005219 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5220 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005221 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005222 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005223 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005224 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5225 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005226 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005227 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005228}
5229
eladalonf1841382017-06-12 01:16:46 -07005230TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07005231 webrtc::test::ScopedFieldTrials field_trials(
5232 "WebRTC-UseStandardBytesStats/Enabled/");
5233
Peter Boström393347f2015-04-22 14:52:45 +02005234 FakeVideoReceiveStream* stream = AddRecvStream();
5235 webrtc::VideoReceiveStream::Stats stats;
5236 stats.rtp_stats.transmitted.payload_bytes = 2;
5237 stats.rtp_stats.transmitted.header_bytes = 3;
5238 stats.rtp_stats.transmitted.padding_bytes = 4;
5239 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005240 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005241 stats.rtcp_stats.fraction_lost = 7;
5242 stream->SetStats(stats);
5243
5244 cricket::VideoMediaInfo info;
5245 ASSERT_TRUE(channel_->GetStats(&info));
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07005246 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005247 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005248 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005249 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005250 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005251}
5252
eladalonf1841382017-06-12 01:16:46 -07005253TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005254 AddSendStream();
5255 AddSendStream();
5256 webrtc::Call::Stats stats;
5257 stats.rtt_ms = 123;
5258 fake_call_->SetStats(stats);
5259
5260 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005261 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005262 ASSERT_EQ(2u, info.senders.size());
5263 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5264 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5265}
5266
eladalonf1841382017-06-12 01:16:46 -07005267TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005268 FakeVideoSendStream* stream = AddSendStream();
5269 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005270 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005271 stats.media_bitrate_bps = 123;
5272 stats.substreams[17].total_bitrate_bps = 1;
5273 stats.substreams[17].retransmit_bitrate_bps = 2;
5274 stats.substreams[42].total_bitrate_bps = 3;
5275 stats.substreams[42].retransmit_bitrate_bps = 4;
5276 stream->SetStats(stats);
5277
5278 FakeVideoSendStream* stream2 = AddSendStream();
5279 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005280 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005281 stats2.media_bitrate_bps = 321;
5282 stats2.substreams[13].total_bitrate_bps = 5;
5283 stats2.substreams[13].retransmit_bitrate_bps = 6;
5284 stats2.substreams[21].total_bitrate_bps = 7;
5285 stats2.substreams[21].retransmit_bitrate_bps = 8;
5286 stream2->SetStats(stats2);
5287
5288 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005289 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005290 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005291 BandwidthEstimationInfo bwe_info;
5292 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005293 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5294 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5295 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5296 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005297 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005298 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005299 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005300 bwe_info.actual_enc_bitrate);
5301 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005302 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005303 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005304 << "Bandwidth stats should take all streams into account.";
5305}
5306
eladalonf1841382017-06-12 01:16:46 -07005307TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005308 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005309
Peter Boström0c4e06b2015-10-07 12:23:21 +02005310 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5311 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005312
5313 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5314 const size_t kDataLength = 12;
5315 uint8_t data[kDataLength];
5316 memset(data, 0, sizeof(data));
5317 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005318 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005319 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005320
5321 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5322 << "No default receive stream created.";
5323 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005324 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005325 << "Default receive stream should not have configured RTX";
5326
5327 EXPECT_TRUE(channel_->AddRecvStream(
5328 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5329 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005330 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005331 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005332 EXPECT_FALSE(
5333 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005334 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005335 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005336 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005337 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005338 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005339 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005340}
5341
eladalonf1841382017-06-12 01:16:46 -07005342TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005343 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005344
Peter Boström0c4e06b2015-10-07 12:23:21 +02005345 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5346 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005347
5348 StreamParams sp =
5349 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5350 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5351
5352 EXPECT_FALSE(channel_->AddSendStream(sp));
5353 EXPECT_FALSE(channel_->AddRecvStream(sp));
5354}
5355
eladalonf1841382017-06-12 01:16:46 -07005356TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005357 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005358
Peter Boström0c4e06b2015-10-07 12:23:21 +02005359 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5360 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005361
5362 StreamParams sp =
5363 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5364
5365 EXPECT_TRUE(channel_->AddSendStream(sp));
5366 EXPECT_TRUE(channel_->AddRecvStream(sp));
5367
5368 // The RTX SSRC is already used in previous streams, using it should fail.
5369 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5370 EXPECT_FALSE(channel_->AddSendStream(sp));
5371 EXPECT_FALSE(channel_->AddRecvStream(sp));
5372
5373 // After removing the original stream this should be fine to add (makes sure
5374 // that RTX ssrcs are not forever taken).
5375 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5376 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5377 EXPECT_TRUE(channel_->AddSendStream(sp));
5378 EXPECT_TRUE(channel_->AddRecvStream(sp));
5379}
5380
eladalonf1841382017-06-12 01:16:46 -07005381TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005382 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005383 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5384 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005385 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005386
Peter Boströmd6f4c252015-03-26 16:23:04 +01005387 StreamParams sp =
5388 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5389
5390 EXPECT_TRUE(channel_->AddSendStream(sp));
5391 EXPECT_TRUE(channel_->AddRecvStream(sp));
5392
5393 // One of the SSRCs is already used in previous streams, using it should fail.
5394 sp = cricket::CreateSimStreamParams("cname",
5395 MAKE_VECTOR(kOverlappingStreamSsrcs));
5396 EXPECT_FALSE(channel_->AddSendStream(sp));
5397 EXPECT_FALSE(channel_->AddRecvStream(sp));
5398
5399 // After removing the original stream this should be fine to add (makes sure
5400 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005401 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5402 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005403 EXPECT_TRUE(channel_->AddSendStream(sp));
5404 EXPECT_TRUE(channel_->AddRecvStream(sp));
5405}
5406
eladalonf1841382017-06-12 01:16:46 -07005407TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005408 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005409
5410 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5411 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5412
5413 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5414 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5415
5416 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5417
5418 static const uint32_t kReceiverSsrcs[] = {3};
5419 static const uint32_t kReceiverRtxSsrcs[] = {2};
5420
5421 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5422 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5423 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5424
5425 cricket::VideoMediaInfo info;
5426 ASSERT_TRUE(channel_->GetStats(&info));
5427
5428 ASSERT_EQ(1u, info.senders.size());
5429 ASSERT_EQ(1u, info.receivers.size());
5430
5431 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5432 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5433 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5434}
5435
eladalonf1841382017-06-12 01:16:46 -07005436TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005437 FakeVideoReceiveStream* stream = AddRecvStream();
5438 webrtc::VideoReceiveStream::Stats stats;
5439 cricket::VideoMediaInfo info;
5440
5441 // Report no codec name before receiving.
5442 stream->SetStats(stats);
5443 ASSERT_TRUE(channel_->GetStats(&info));
5444 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5445
5446 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005447 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005448 stream->SetStats(stats);
5449 ASSERT_TRUE(channel_->GetStats(&info));
5450 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5451
5452 // Report no codec name for unknown playload types.
5453 stats.current_payload_type = 3;
5454 stream->SetStats(stats);
5455 ASSERT_TRUE(channel_->GetStats(&info));
5456 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5457}
5458
Seth Hampson5897a6e2018-04-03 11:16:33 -07005459// Tests that when we add a stream without SSRCs, but contains a stream_id
5460// that it is stored and its stream id is later used when the first packet
5461// arrives to properly create a receive stream with a sync label.
5462TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5463 const char kSyncLabel[] = "sync_label";
5464 cricket::StreamParams unsignaled_stream;
5465 unsignaled_stream.set_stream_ids({kSyncLabel});
5466 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5467 // The stream shouldn't have been created at this point because it doesn't
5468 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005469 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005470
5471 // Create and deliver packet.
5472 const size_t kDataLength = 12;
5473 uint8_t data[kDataLength];
5474 memset(data, 0, sizeof(data));
5475 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5476 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005477 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005478
5479 // The stream should now be created with the appropriate sync label.
5480 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5481 EXPECT_EQ(kSyncLabel,
5482 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5483
5484 // Removing the unsignaled stream should clear the cache. This time when
5485 // a default video receive stream is created it won't have a sync_group.
5486 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5487 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5488 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5489
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005490 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005491 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5492 EXPECT_TRUE(
5493 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5494}
5495
Ruslan Burakov493a6502019-02-27 15:32:48 +01005496// Test BaseMinimumPlayoutDelayMs on receive streams.
5497TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5498 // Test that set won't work for non-existing receive streams.
5499 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5500 // Test that get won't work for non-existing receive streams.
5501 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5502
5503 EXPECT_TRUE(AddRecvStream());
5504 // Test that set works for the existing receive stream.
5505 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5506 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5507 EXPECT_TRUE(recv_stream);
5508 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5509 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5510 200);
5511}
5512
5513// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5514TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5515 absl::optional<int> delay_ms;
5516 const FakeVideoReceiveStream* recv_stream;
5517
5518 // Set default stream with SSRC 0
5519 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5520 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5521
5522 // Spawn an unsignaled stream by sending a packet, it should inherit
5523 // default delay 200.
5524 const size_t kDataLength = 12;
5525 uint8_t data[kDataLength];
5526 memset(data, 0, sizeof(data));
5527 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5528 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005529 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005530
5531 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5532 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5533 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5534 EXPECT_EQ(200, delay_ms.value_or(0));
5535
5536 // Check that now if we change delay for SSRC 0 it will change delay for the
5537 // default receiving stream as well.
5538 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5539 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5540 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5541 EXPECT_EQ(300, delay_ms.value_or(0));
5542 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5543 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5544}
5545
eladalonf1841382017-06-12 01:16:46 -07005546void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005547 uint8_t payload_type,
5548 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005549 // kRedRtxPayloadType must currently be unused.
5550 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5551
noahricd10a68e2015-07-10 11:27:55 -07005552 // Add a RED RTX codec.
5553 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005554 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005555 recv_parameters_.codecs.push_back(red_rtx_codec);
5556 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005557
5558 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5559 const size_t kDataLength = 12;
5560 uint8_t data[kDataLength];
5561 memset(data, 0, sizeof(data));
5562
5563 rtc::Set8(data, 1, payload_type);
5564 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005565 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005566 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005567
5568 if (expect_created_receive_stream) {
5569 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5570 << "Should have created a receive stream for payload type: "
5571 << payload_type;
5572 } else {
5573 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5574 << "Shouldn't have created a receive stream for payload type: "
5575 << payload_type;
5576 }
5577}
5578
Åsa Persson2c7149b2018-10-15 09:36:10 +02005579class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5580 public:
5581 WebRtcVideoChannelDiscardUnknownSsrcTest()
5582 : WebRtcVideoChannelTest(
5583 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5584};
5585
5586TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5587 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5588 false /* expect_created_receive_stream */);
5589}
5590
eladalonf1841382017-06-12 01:16:46 -07005591TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005592 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5593 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005594}
5595
eladalonf1841382017-06-12 01:16:46 -07005596TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005597 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5598 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005599}
5600
eladalonf1841382017-06-12 01:16:46 -07005601TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005602 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005603 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5604 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5605 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5606 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005607}
5608
eladalonf1841382017-06-12 01:16:46 -07005609TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005610 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5611 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005612}
5613
eladalonf1841382017-06-12 01:16:46 -07005614TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005615 FlexfecPacketDoesntCreateUnsignalledStream) {
5616 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5617 false /* expect_created_receive_stream */);
5618}
5619
eladalonf1841382017-06-12 01:16:46 -07005620TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005621 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5622 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005623}
5624
mzanaty8a855d62017-02-17 15:46:43 -08005625// Test that receiving any unsignalled SSRC works even if it changes.
5626// The first unsignalled SSRC received will create a default receive stream.
5627// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005628TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005629 // Allow receiving VP8, VP9, H264 (if enabled).
5630 cricket::VideoRecvParameters parameters;
5631 parameters.codecs.push_back(GetEngineCodec("VP8"));
5632 parameters.codecs.push_back(GetEngineCodec("VP9"));
5633
5634#if defined(WEBRTC_USE_H264)
5635 cricket::VideoCodec H264codec(126, "H264");
5636 parameters.codecs.push_back(H264codec);
5637#endif
5638
5639 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5640 // No receive streams yet.
5641 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5642 cricket::FakeVideoRenderer renderer;
5643 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5644
5645 // Receive VP8 packet on first SSRC.
5646 uint8_t data[kMinRtpPacketLen];
5647 cricket::RtpHeader rtpHeader;
5648 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5649 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005650 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005651 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5652 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005653 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005654 // VP8 packet should create default receive stream.
5655 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005656 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005657 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5658 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005659 webrtc::VideoFrame video_frame =
5660 webrtc::VideoFrame::Builder()
5661 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5662 .set_timestamp_rtp(100)
5663 .set_timestamp_us(0)
5664 .set_rotation(webrtc::kVideoRotation_0)
5665 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005666 recv_stream->InjectFrame(video_frame);
5667 EXPECT_EQ(1, renderer.num_rendered_frames());
5668
5669 // Receive VP9 packet on second SSRC.
5670 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005671 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005672 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5673 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005674 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005675 // VP9 packet should replace the default receive SSRC.
5676 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5677 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5678 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5679 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005680 webrtc::VideoFrame video_frame2 =
5681 webrtc::VideoFrame::Builder()
5682 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5683 .set_timestamp_rtp(200)
5684 .set_timestamp_us(0)
5685 .set_rotation(webrtc::kVideoRotation_0)
5686 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005687 recv_stream->InjectFrame(video_frame2);
5688 EXPECT_EQ(2, renderer.num_rendered_frames());
5689
5690#if defined(WEBRTC_USE_H264)
5691 // Receive H264 packet on third SSRC.
5692 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005693 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005694 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5695 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005696 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005697 // H264 packet should replace the default receive SSRC.
5698 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5699 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5700 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5701 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005702 webrtc::VideoFrame video_frame3 =
5703 webrtc::VideoFrame::Builder()
5704 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5705 .set_timestamp_rtp(300)
5706 .set_timestamp_us(0)
5707 .set_rotation(webrtc::kVideoRotation_0)
5708 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005709 recv_stream->InjectFrame(video_frame3);
5710 EXPECT_EQ(3, renderer.num_rendered_frames());
5711#endif
5712}
5713
brandtr0dc57ea2017-05-29 23:33:31 -07005714// This test verifies that when a new default stream is created for a new
5715// unsignaled SSRC, the new stream does not overwrite any old stream that had
5716// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005717TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005718 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5719 cricket::VideoRecvParameters parameters;
5720 parameters.codecs.push_back(GetEngineCodec("VP8"));
5721 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5722
5723 // No streams signaled and no packets received, so we should not have any
5724 // stream objects created yet.
5725 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5726
5727 // Receive packet on an unsignaled SSRC.
5728 uint8_t data[kMinRtpPacketLen];
5729 cricket::RtpHeader rtp_header;
5730 rtp_header.payload_type = GetEngineCodec("VP8").id;
5731 rtp_header.seq_num = rtp_header.timestamp = 0;
5732 rtp_header.ssrc = kSsrcs3[0];
5733 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5734 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005735 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005736 // Default receive stream should be created.
5737 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5738 FakeVideoReceiveStream* recv_stream0 =
5739 fake_call_->GetVideoReceiveStreams()[0];
5740 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5741
5742 // Signal the SSRC.
5743 EXPECT_TRUE(
5744 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5745 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5746 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5747 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5748
5749 // Receive packet on a different unsignaled SSRC.
5750 rtp_header.ssrc = kSsrcs3[1];
5751 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5752 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005753 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005754 // New default receive stream should be created, but old stream should remain.
5755 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5756 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5757 FakeVideoReceiveStream* recv_stream1 =
5758 fake_call_->GetVideoReceiveStreams()[1];
5759 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5760}
5761
Seth Hampson7c682e02018-05-04 16:28:15 -07005762TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005763 AddSendStream();
5764
Niels Möller805a27e2019-01-21 12:21:27 +01005765 webrtc::test::FrameForwarder frame_forwarder;
5766 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005767 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005768 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005769
perkjfa10b552016-10-02 23:45:26 -07005770 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005771 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005772
5773 // TODO(skvlad): Resolve the inconsistency between the interpretation
5774 // of the global bitrate limit for audio and video:
5775 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5776 // max_bandwidth_bps = -1 - remove the bandwidth limit
5777 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005778 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005779
perkjfa10b552016-10-02 23:45:26 -07005780 SetAndExpectMaxBitrate(1000, 0, 1000);
5781 SetAndExpectMaxBitrate(1000, 800, 800);
5782 SetAndExpectMaxBitrate(600, 800, 600);
5783 SetAndExpectMaxBitrate(0, 800, 800);
5784 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005785
Niels Möllerff40b142018-04-09 08:49:14 +02005786 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005787}
5788
eladalonf1841382017-06-12 01:16:46 -07005789TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005790 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005791 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005792 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005793
5794 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005795 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005796 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005797}
5798
eladalonf1841382017-06-12 01:16:46 -07005799TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005800 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005801 FakeVideoSendStream* stream = AddSendStream();
5802
Seth Hampson7c682e02018-05-04 16:28:15 -07005803 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5804 EXPECT_EQ(1UL, parameters.encodings.size());
5805 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5806 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5807
5808 // Note that this is testing the behavior of the FakeVideoSendStream, which
5809 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5810 // we are just testing the behavior of
5811 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005812 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5813 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005814
5815 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5816 // by this amount.
5817 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5818 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5819 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5820 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5821
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005822 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5823 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5824 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5825}
5826
5827TEST_F(WebRtcVideoChannelTest,
5828 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5829 FakeVideoSendStream* stream = AddSendStream();
5830
5831 // Note that this is testing the behavior of the FakeVideoSendStream, which
5832 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5833 // we are just testing the behavior of
5834 // EncoderStreamFactory::CreateEncoderStreams.
5835 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5836 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5837
5838 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5839 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5840 EXPECT_EQ(1UL, parameters.encodings.size());
5841 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5842 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5843
5844 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5845 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5846 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5847}
5848
5849TEST_F(WebRtcVideoChannelTest,
5850 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5851 send_parameters_.max_bandwidth_bps = 99999;
5852 FakeVideoSendStream* stream = AddSendStream();
5853 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5854 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5855 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5856 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5857 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5858 stream->GetVideoStreams()[0].max_bitrate_bps);
5859
5860 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5861 // adjusted down.
5862 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5863 EXPECT_EQ(1UL, parameters.encodings.size());
5864 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5865 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5866 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5867 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5868 stream->GetVideoStreams()[0].min_bitrate_bps);
5869 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5870 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005871}
5872
Åsa Persson8c1bf952018-09-13 10:42:19 +02005873TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5874 FakeVideoSendStream* stream = AddSendStream();
5875
5876 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5877 EXPECT_EQ(1UL, parameters.encodings.size());
5878 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5879 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5880
5881 // Note that this is testing the behavior of the FakeVideoSendStream, which
5882 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5883 // we are just testing the behavior of
5884 // EncoderStreamFactory::CreateEncoderStreams.
5885 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5886 EXPECT_EQ(kDefaultVideoMaxFramerate,
5887 stream->GetVideoStreams()[0].max_framerate);
5888
5889 // Set max framerate and check that VideoStream.max_framerate is set.
5890 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5891 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5892 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5893 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5894
5895 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5896 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5897}
5898
Åsa Persson23eba222018-10-02 14:47:06 +02005899TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5900 FakeVideoSendStream* stream = AddSendStream();
5901
5902 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5903 EXPECT_EQ(1UL, parameters.encodings.size());
5904 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5905 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5906
5907 // Note that this is testing the behavior of the FakeVideoSendStream, which
5908 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5909 // we are just testing the behavior of
5910 // EncoderStreamFactory::CreateEncoderStreams.
5911 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5912 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5913
5914 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5915 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5916 parameters.encodings[0].num_temporal_layers = 2;
5917 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5918
5919 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5920 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5921}
5922
Seth Hampson7c682e02018-05-04 16:28:15 -07005923TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005924 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005925 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005926 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005927 // Two or more encodings should result in failure.
5928 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005929 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005930 // Zero encodings should also fail.
5931 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005932 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005933}
5934
Zach Stein3ca452b2018-01-18 10:01:24 -08005935TEST_F(WebRtcVideoChannelTest,
5936 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5937 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5938 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5939 AddSendStream(sp);
5940
5941 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5942
5943 // Additional encodings should result in failure.
5944 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005945 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005946 // Zero encodings should also fail.
5947 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005948 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005949}
5950
deadbeeffb2aced2017-01-06 23:05:37 -08005951// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005952TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005953 AddSendStream();
5954 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005955 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005956 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005957}
5958
Seth Hampson24722b32017-12-22 09:36:42 -08005959// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5960// a value <= 0, setting the parameters returns false.
5961TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5962 AddSendStream();
5963 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5964 EXPECT_EQ(1UL, parameters.encodings.size());
5965 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5966 parameters.encodings[0].bitrate_priority);
5967
5968 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005969 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005970 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005971 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005972}
5973
5974// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5975// properly on the VideoChannel and propogates down to the video encoder.
5976TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5977 AddSendStream();
5978 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5979 EXPECT_EQ(1UL, parameters.encodings.size());
5980 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5981 parameters.encodings[0].bitrate_priority);
5982
5983 // Change the value and set it on the VideoChannel.
5984 double new_bitrate_priority = 2.0;
5985 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005986 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005987
5988 // Verify that the encoding parameters bitrate_priority is set for the
5989 // VideoChannel.
5990 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5991 EXPECT_EQ(1UL, parameters.encodings.size());
5992 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5993
5994 // Verify that the new value propagated down to the encoder.
5995 std::vector<FakeVideoSendStream*> video_send_streams =
5996 fake_call_->GetVideoSendStreams();
5997 EXPECT_EQ(1UL, video_send_streams.size());
5998 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5999 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6000 // appropriately.
6001 EXPECT_EQ(new_bitrate_priority,
6002 video_send_stream->GetEncoderConfig().bitrate_priority);
6003 // Check that the vector of VideoStreams also was propagated correctly. Note
6004 // that this is testing the behavior of the FakeVideoSendStream, which mimics
6005 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006006 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006007 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6008}
6009
6010// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
6011// VideoChannel and the value propogates to the video encoder with all simulcast
6012// streams.
6013TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
6014 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006015 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08006016 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6017 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6018 AddSendStream(stream_params);
6019 uint32_t primary_ssrc = stream_params.first_ssrc();
6020
Niels Möller805a27e2019-01-21 12:21:27 +01006021 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006022 // frame. This creates multiple VideoStreams for all simulcast layers when
6023 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01006024 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08006025 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006026 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08006027 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006028 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6029 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6030 rtc::kNumMicrosecsPerSec / 30));
6031
Seth Hampson24722b32017-12-22 09:36:42 -08006032 // Get and set the rtp encoding parameters.
6033 webrtc::RtpParameters parameters =
6034 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006035 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006036 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6037 parameters.encodings[0].bitrate_priority);
6038 // Change the value and set it on the VideoChannel.
6039 double new_bitrate_priority = 2.0;
6040 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08006041 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006042
6043 // Verify that the encoding parameters priority is set on the VideoChannel.
6044 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006045 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006046 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
6047
6048 // Verify that the new value propagated down to the encoder.
6049 std::vector<FakeVideoSendStream*> video_send_streams =
6050 fake_call_->GetVideoSendStreams();
6051 EXPECT_EQ(1UL, video_send_streams.size());
6052 FakeVideoSendStream* video_send_stream = video_send_streams.front();
6053 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6054 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006055 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08006056 video_send_stream->GetEncoderConfig().number_of_streams);
6057 EXPECT_EQ(new_bitrate_priority,
6058 video_send_stream->GetEncoderConfig().bitrate_priority);
6059 // Check that the vector of VideoStreams also propagated correctly. The
6060 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
6061 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006062 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02006063 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006064 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6065 // Since we are only setting bitrate priority per-sender, the other
6066 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006067 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006068 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02006069 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006070 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02006071 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006072}
6073
Tim Haloun648d28a2018-10-18 16:52:22 -07006074// RTCRtpEncodingParameters.network_priority must be one of a few values
6075// derived from the default priority, corresponding to very-low, low, medium,
6076// or high.
6077TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6078 AddSendStream();
6079 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6080 EXPECT_EQ(1UL, parameters.encodings.size());
6081 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6082 parameters.encodings[0].network_priority);
6083
6084 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6085 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6086 for (auto it : good_values) {
6087 parameters.encodings[0].network_priority = it;
6088 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6089 }
6090 for (auto it : bad_values) {
6091 parameters.encodings[0].network_priority = it;
6092 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6093 }
6094}
6095
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006096TEST_F(WebRtcVideoChannelTest,
6097 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006098 VideoSendParameters parameters;
6099 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006100 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6101 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6102
6103 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006104 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006105
6106 VideoOptions options;
6107 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6108 channel_->SetSend(true);
6109
6110 // Try layers in natural order (smallest to largest).
6111 {
6112 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6113 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6114 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6115 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6116 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6117 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6118 ASSERT_TRUE(result.ok());
6119
6120 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6121
6122 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6123 ASSERT_EQ(3u, video_streams.size());
6124 EXPECT_EQ(320u, video_streams[0].width);
6125 EXPECT_EQ(180u, video_streams[0].height);
6126 EXPECT_EQ(640u, video_streams[1].width);
6127 EXPECT_EQ(360u, video_streams[1].height);
6128 EXPECT_EQ(1280u, video_streams[2].width);
6129 EXPECT_EQ(720u, video_streams[2].height);
6130 }
6131
6132 // Try layers in reverse natural order (largest to smallest).
6133 {
6134 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6135 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6136 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6137 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6138 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6139 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6140 ASSERT_TRUE(result.ok());
6141
6142 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6143
6144 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6145 ASSERT_EQ(3u, video_streams.size());
6146 EXPECT_EQ(1280u, video_streams[0].width);
6147 EXPECT_EQ(720u, video_streams[0].height);
6148 EXPECT_EQ(640u, video_streams[1].width);
6149 EXPECT_EQ(360u, video_streams[1].height);
6150 EXPECT_EQ(320u, video_streams[2].width);
6151 EXPECT_EQ(180u, video_streams[2].height);
6152 }
6153
6154 // Try layers in mixed order.
6155 {
6156 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6157 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6158 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6159 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6160 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6161 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6162 ASSERT_TRUE(result.ok());
6163
6164 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6165
6166 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6167 ASSERT_EQ(3u, video_streams.size());
6168 EXPECT_EQ(128u, video_streams[0].width);
6169 EXPECT_EQ(72u, video_streams[0].height);
6170 EXPECT_EQ(640u, video_streams[1].width);
6171 EXPECT_EQ(360u, video_streams[1].height);
6172 EXPECT_EQ(320u, video_streams[2].width);
6173 EXPECT_EQ(180u, video_streams[2].height);
6174 }
6175
6176 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6177 {
6178 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6179 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6180 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6181 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6182 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6183 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6184 ASSERT_TRUE(result.ok());
6185
6186 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6187
6188 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6189 ASSERT_EQ(3u, video_streams.size());
6190 EXPECT_EQ(1280u, video_streams[0].width);
6191 EXPECT_EQ(720u, video_streams[0].height);
6192 EXPECT_EQ(1280u, video_streams[1].width);
6193 EXPECT_EQ(720u, video_streams[1].height);
6194 EXPECT_EQ(320u, video_streams[2].width);
6195 EXPECT_EQ(180u, video_streams[2].height);
6196 }
6197
6198 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6199}
6200
6201TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006202 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6203 // Ensure that the top layer has width and height divisible by 2^3,
6204 // so that the bottom layer has width and height divisible by 2.
6205 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6206 // the number of simulcast layers set by the app.
6207 webrtc::test::ScopedFieldTrials field_trial(
6208 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6209
6210 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6211 VideoSendParameters parameters;
6212 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6213 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6214 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6215 webrtc::test::FrameForwarder frame_forwarder;
6216 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6217 &frame_forwarder));
6218 channel_->SetSend(true);
6219
6220 // Set |scale_resolution_down_by|'s.
6221 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6222 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6223 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6224 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6225 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6226 const auto result =
6227 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6228 ASSERT_TRUE(result.ok());
6229
6230 // Use a capture resolution whose width and height are not divisible by 2^3.
6231 // (See field trial set at the top of the test.)
6232 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6233 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6234
6235 // Ensure the scaling is correct.
6236 const auto video_streams = stream->GetVideoStreams();
6237 ASSERT_EQ(video_streams.size(), 3u);
6238 // Ensure that we round the capture resolution down for the top layer...
6239 EXPECT_EQ(video_streams[0].width, 2000u);
6240 EXPECT_EQ(video_streams[0].height, 1200u);
6241 EXPECT_EQ(video_streams[1].width, 1000u);
6242 EXPECT_EQ(video_streams[1].height, 600u);
6243 // ...and that the bottom layer has a width/height divisible by 2.
6244 EXPECT_EQ(video_streams[2].width, 500u);
6245 EXPECT_EQ(video_streams[2].height, 300u);
6246
6247 // Tear down.
6248 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6249}
6250
6251TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006252 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006253 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6254 VideoSendParameters parameters;
6255 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006256 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6257 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6258
6259 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006260 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006261
6262 VideoOptions options;
6263 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6264 channel_->SetSend(true);
6265
6266 // Try layers in natural order (smallest to largest).
6267 {
6268 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6269 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6270 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6271 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6272 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6273 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6274 ASSERT_TRUE(result.ok());
6275
6276 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6277
6278 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6279 ASSERT_EQ(3u, video_streams.size());
6280 EXPECT_EQ(320u, video_streams[0].width);
6281 EXPECT_EQ(180u, video_streams[0].height);
6282 EXPECT_EQ(640u, video_streams[1].width);
6283 EXPECT_EQ(360u, video_streams[1].height);
6284 EXPECT_EQ(1280u, video_streams[2].width);
6285 EXPECT_EQ(720u, video_streams[2].height);
6286 }
6287
6288 // Try layers in reverse natural order (largest to smallest).
6289 {
6290 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6291 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6292 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6293 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6294 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6295 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6296 ASSERT_TRUE(result.ok());
6297
6298 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6299
6300 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6301 ASSERT_EQ(3u, video_streams.size());
6302 EXPECT_EQ(1280u, video_streams[0].width);
6303 EXPECT_EQ(720u, video_streams[0].height);
6304 EXPECT_EQ(640u, video_streams[1].width);
6305 EXPECT_EQ(360u, video_streams[1].height);
6306 EXPECT_EQ(320u, video_streams[2].width);
6307 EXPECT_EQ(180u, video_streams[2].height);
6308 }
6309
6310 // Try layers in mixed order.
6311 {
6312 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6313 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6314 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6315 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6316 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6317 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6318 ASSERT_TRUE(result.ok());
6319
6320 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6321
6322 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6323 ASSERT_EQ(3u, video_streams.size());
6324 EXPECT_EQ(128u, video_streams[0].width);
6325 EXPECT_EQ(72u, video_streams[0].height);
6326 EXPECT_EQ(640u, video_streams[1].width);
6327 EXPECT_EQ(360u, video_streams[1].height);
6328 EXPECT_EQ(320u, video_streams[2].width);
6329 EXPECT_EQ(180u, video_streams[2].height);
6330 }
6331
6332 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6333 {
6334 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6335 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6336 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6337 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6338 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6339 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6340 ASSERT_TRUE(result.ok());
6341
6342 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6343
6344 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6345 ASSERT_EQ(3u, video_streams.size());
6346 EXPECT_EQ(1280u, video_streams[0].width);
6347 EXPECT_EQ(720u, video_streams[0].height);
6348 EXPECT_EQ(1280u, video_streams[1].width);
6349 EXPECT_EQ(720u, video_streams[1].height);
6350 EXPECT_EQ(320u, video_streams[2].width);
6351 EXPECT_EQ(180u, video_streams[2].height);
6352 }
6353 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6354}
6355
Rasmus Brandt9387b522019-02-05 14:23:26 +01006356TEST_F(WebRtcVideoChannelTest,
6357 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6358 // Ensure that the top layer has width and height divisible by 2^3,
6359 // so that the bottom layer has width and height divisible by 2.
6360 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6361 // the number of simulcast layers set by the app.
6362 webrtc::test::ScopedFieldTrials field_trial(
6363 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6364
6365 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6366 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6367 VideoSendParameters parameters;
6368 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6369 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6370 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6371 webrtc::test::FrameForwarder frame_forwarder;
6372 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6373 &frame_forwarder));
6374 channel_->SetSend(true);
6375
6376 // Set |scale_resolution_down_by|'s.
6377 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6378 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6379 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6380 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6381 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6382 const auto result =
6383 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6384 ASSERT_TRUE(result.ok());
6385
6386 // Use a capture resolution whose width and height are not divisible by 2^3.
6387 // (See field trial set at the top of the test.)
6388 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6389 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6390
6391 // Ensure the scaling is correct.
6392 const auto video_streams = stream->GetVideoStreams();
6393 ASSERT_EQ(video_streams.size(), 3u);
6394 // Ensure that we round the capture resolution down for the top layer...
6395 EXPECT_EQ(video_streams[0].width, 2000u);
6396 EXPECT_EQ(video_streams[0].height, 1200u);
6397 EXPECT_EQ(video_streams[1].width, 1000u);
6398 EXPECT_EQ(video_streams[1].height, 600u);
6399 // ...and that the bottom layer has a width/height divisible by 2.
6400 EXPECT_EQ(video_streams[2].width, 500u);
6401 EXPECT_EQ(video_streams[2].height, 300u);
6402
6403 // Tear down.
6404 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6405}
6406
Åsa Persson8c1bf952018-09-13 10:42:19 +02006407TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6408 const size_t kNumSimulcastStreams = 3;
6409 SetUpSimulcast(true, false);
6410
6411 // Get and set the rtp encoding parameters.
6412 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6413 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6414 for (const auto& encoding : parameters.encodings) {
6415 EXPECT_FALSE(encoding.max_framerate);
6416 }
6417
6418 // Change the value and set it on the VideoChannel.
6419 parameters.encodings[0].max_framerate = 10;
6420 parameters.encodings[1].max_framerate = 20;
6421 parameters.encodings[2].max_framerate = 25;
6422 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6423
6424 // Verify that the bitrates are set on the VideoChannel.
6425 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6426 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6427 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6428 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6429 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6430}
6431
Åsa Persson23eba222018-10-02 14:47:06 +02006432TEST_F(WebRtcVideoChannelTest,
6433 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6434 const size_t kNumSimulcastStreams = 3;
6435 SetUpSimulcast(true, false);
6436
6437 // Get and set the rtp encoding parameters.
6438 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6439 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6440
6441 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6442 parameters.encodings[0].num_temporal_layers = 0;
6443 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6444 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6445 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6446 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6447 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6448}
6449
6450TEST_F(WebRtcVideoChannelTest,
6451 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6452 const size_t kNumSimulcastStreams = 3;
6453 SetUpSimulcast(true, false);
6454
6455 // Get and set the rtp encoding parameters.
6456 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6457 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6458
6459 // No/all layers should be set.
6460 parameters.encodings[0].num_temporal_layers = 1;
6461 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6462 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6463
6464 // Different values not supported.
6465 parameters.encodings[0].num_temporal_layers = 1;
6466 parameters.encodings[1].num_temporal_layers = 2;
6467 parameters.encodings[2].num_temporal_layers = 2;
6468 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6469 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6470}
6471
6472TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6473 const size_t kNumSimulcastStreams = 3;
6474 SetUpSimulcast(true, false);
6475
6476 // Get and set the rtp encoding parameters.
6477 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6478 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6479 for (const auto& encoding : parameters.encodings)
6480 EXPECT_FALSE(encoding.num_temporal_layers);
6481
6482 // Change the value and set it on the VideoChannel.
6483 parameters.encodings[0].num_temporal_layers = 3;
6484 parameters.encodings[1].num_temporal_layers = 3;
6485 parameters.encodings[2].num_temporal_layers = 3;
6486 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6487
6488 // Verify that the number of temporal layers are set on the VideoChannel.
6489 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6490 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6491 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6492 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6493 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6494}
6495
6496TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6497 const size_t kNumSimulcastStreams = 3;
6498 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6499
6500 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006501 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006502 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006503 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006504 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006505 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006506
6507 // Get and set the rtp encoding parameters.
6508 // Change the value and set it on the VideoChannel.
6509 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6510 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6511 parameters.encodings[0].num_temporal_layers = 2;
6512 parameters.encodings[1].num_temporal_layers = 2;
6513 parameters.encodings[2].num_temporal_layers = 2;
6514 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6515
6516 // Verify that the new value is propagated down to the encoder.
6517 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6518 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6519 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6520 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6521 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6522 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6523 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6524 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6525
6526 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6527 // VideoStreams are created appropriately for the simulcast case.
6528 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6529 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6530 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6531 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6532
6533 // No parameter changed, encoder should not be reconfigured.
6534 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6535 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6536
6537 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6538}
6539
6540TEST_F(WebRtcVideoChannelTest,
6541 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6542 const size_t kDefaultNumTemporalLayers = 3;
6543 const size_t kNumSimulcastStreams = 3;
6544 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6545
6546 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006547 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006548 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006549 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006550 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006551 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006552
6553 // Change rtp encoding parameters, num_temporal_layers not changed.
6554 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6555 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6556 parameters.encodings[0].min_bitrate_bps = 33000;
6557 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6558
6559 // Verify that no value is propagated down to the encoder.
6560 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6561 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6562 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6563 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6564 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6565 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6566
6567 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6568 // VideoStreams are created appropriately for the simulcast case.
6569 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6570 EXPECT_EQ(kDefaultNumTemporalLayers,
6571 stream->GetVideoStreams()[0].num_temporal_layers);
6572 EXPECT_EQ(kDefaultNumTemporalLayers,
6573 stream->GetVideoStreams()[1].num_temporal_layers);
6574 EXPECT_EQ(kDefaultNumTemporalLayers,
6575 stream->GetVideoStreams()[2].num_temporal_layers);
6576
6577 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6578}
6579
Åsa Persson8c1bf952018-09-13 10:42:19 +02006580TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6581 const size_t kNumSimulcastStreams = 3;
6582 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6583
6584 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006585 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006586 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006587 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006588 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006589 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006590
6591 // Get and set the rtp encoding parameters.
6592 // Change the value and set it on the VideoChannel.
6593 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6594 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6595 parameters.encodings[0].max_framerate = 15;
6596 parameters.encodings[1].max_framerate = 25;
6597 parameters.encodings[2].max_framerate = 20;
6598 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6599
6600 // Verify that the new value propagated down to the encoder.
6601 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6602 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6603 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6604 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6605 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6606 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6607 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6608 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6609
6610 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6611 // VideoStreams are created appropriately for the simulcast case.
6612 // Currently the maximum |max_framerate| is used.
6613 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6614 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6615 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6616 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6617
6618 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6619}
6620
6621TEST_F(WebRtcVideoChannelTest,
6622 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6623 const size_t kNumSimulcastStreams = 3;
6624 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6625 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6626
6627 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006628 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006629 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006630 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006631 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006632 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006633
6634 // Get and set the rtp encoding parameters.
6635 // Change the value and set it on the VideoChannel.
6636 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6637 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6638 parameters.encodings[0].max_framerate = 15;
6639 parameters.encodings[2].max_framerate = 20;
6640 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6641
6642 // Verify that the new value propagated down to the encoder.
6643 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6644 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6645 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6646 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6647 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6648 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6649 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6650
6651 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6652 // VideoStreams are created appropriately for the simulcast case.
6653 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6654 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6655 EXPECT_EQ(kDefaultVideoMaxFramerate,
6656 stream->GetVideoStreams()[0].max_framerate);
6657 EXPECT_EQ(kDefaultVideoMaxFramerate,
6658 stream->GetVideoStreams()[1].max_framerate);
6659 EXPECT_EQ(kDefaultVideoMaxFramerate,
6660 stream->GetVideoStreams()[2].max_framerate);
6661
6662 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6663}
6664
Åsa Persson55659812018-06-18 17:51:32 +02006665TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6666 const size_t kNumSimulcastStreams = 3;
6667 SetUpSimulcast(true, false);
6668
6669 // Get and set the rtp encoding parameters.
6670 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6671 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6672 for (const auto& encoding : parameters.encodings) {
6673 EXPECT_FALSE(encoding.min_bitrate_bps);
6674 EXPECT_FALSE(encoding.max_bitrate_bps);
6675 }
6676
6677 // Change the value and set it on the VideoChannel.
6678 parameters.encodings[0].min_bitrate_bps = 100000;
6679 parameters.encodings[0].max_bitrate_bps = 200000;
6680 parameters.encodings[1].min_bitrate_bps = 300000;
6681 parameters.encodings[1].max_bitrate_bps = 400000;
6682 parameters.encodings[2].min_bitrate_bps = 500000;
6683 parameters.encodings[2].max_bitrate_bps = 600000;
6684 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6685
6686 // Verify that the bitrates are set on the VideoChannel.
6687 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6688 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6689 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6690 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6691 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6692 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6693 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6694 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6695}
6696
6697TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6698 const size_t kNumSimulcastStreams = 3;
6699 SetUpSimulcast(true, false);
6700
6701 // Get and set the rtp encoding parameters.
6702 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6703 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6704
6705 // Max bitrate lower than min bitrate should fail.
6706 parameters.encodings[2].min_bitrate_bps = 100000;
6707 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6708 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6709 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6710}
6711
6712// Test that min and max bitrate values set via RtpParameters are correctly
6713// propagated to the underlying encoder, and that the target is set to 3/4 of
6714// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6715// that are used if no min/max are specified).
6716TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6717 const size_t kNumSimulcastStreams = 3;
6718 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6719
6720 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006721 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006722 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006723 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006724 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006725 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006726
6727 // Get and set the rtp encoding parameters.
6728 // Change the value and set it on the VideoChannel.
6729 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6730 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6731 parameters.encodings[0].min_bitrate_bps = 100000;
6732 parameters.encodings[0].max_bitrate_bps = 200000;
6733 parameters.encodings[1].min_bitrate_bps = 300000;
6734 parameters.encodings[1].max_bitrate_bps = 400000;
6735 parameters.encodings[2].min_bitrate_bps = 500000;
6736 parameters.encodings[2].max_bitrate_bps = 600000;
6737 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6738
6739 // Verify that the new value propagated down to the encoder.
6740 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6741 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6742 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6743 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6744 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6745 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6746 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6747 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6748 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6749 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6750 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6751
6752 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6753 // VideoStreams are created appropriately for the simulcast case.
6754 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6755 // Target bitrate: 200000 * 3 / 4 = 150000.
6756 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6757 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6758 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6759 // Target bitrate: 400000 * 3 / 4 = 300000.
6760 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6761 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6762 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6763 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6764 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6765 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6766 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6767
6768 // No parameter changed, encoder should not be reconfigured.
6769 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6770 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6771
6772 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6773}
6774
6775// Test to only specify the min or max bitrate value for a layer via
6776// RtpParameters. The unspecified min/max and target value should be set to the
6777// simulcast default that is used if no min/max are specified.
6778TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6779 const size_t kNumSimulcastStreams = 3;
6780 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6781 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6782
6783 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006784 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006785 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006786 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006787 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006788 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006789
6790 // Get and set the rtp encoding parameters.
6791 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6792 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6793
6794 // Change the value and set it on the VideoChannel.
6795 // Layer 0: only configure min bitrate.
6796 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6797 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6798 // Layer 1: only configure max bitrate.
6799 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6800 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6801 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6802
6803 // Verify that the new value propagated down to the encoder.
6804 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6805 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6806 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6807 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6808 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6809 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6810 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6811 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6812 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6813 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6814
6815 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6816 // VideoStreams are created appropriately for the simulcast case.
6817 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6818 // Layer 0: min configured bitrate should overwrite min default.
6819 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6820 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6821 stream->GetVideoStreams()[0].target_bitrate_bps);
6822 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6823 stream->GetVideoStreams()[0].max_bitrate_bps);
6824 // Layer 1: max configured bitrate should overwrite max default.
6825 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6826 stream->GetVideoStreams()[1].min_bitrate_bps);
6827 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6828 stream->GetVideoStreams()[1].target_bitrate_bps);
6829 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6830 // Layer 2: min and max bitrate not configured, default expected.
6831 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6832 stream->GetVideoStreams()[2].min_bitrate_bps);
6833 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6834 stream->GetVideoStreams()[2].target_bitrate_bps);
6835 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6836 stream->GetVideoStreams()[2].max_bitrate_bps);
6837
6838 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6839}
6840
6841// Test that specifying the min (or max) bitrate value for a layer via
6842// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6843// unspecified values accordingly.
6844TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6845 const size_t kNumSimulcastStreams = 3;
6846 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6847 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6848
6849 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006850 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006851 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006852 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006853 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006854 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006855
6856 // Get and set the rtp encoding parameters.
6857 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6858 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6859
6860 // Change the value and set it on the VideoChannel.
6861 // For layer 0, set the min bitrate above the default max.
6862 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6863 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6864 // For layer 1, set the max bitrate below the default min.
6865 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6866 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6867 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6868
6869 // Verify that the new value propagated down to the encoder.
6870 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6871 // VideoStreams are created appropriately for the simulcast case.
6872 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6873 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6874 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6875 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6876 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6877 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6878 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6879 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6880 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6881 // Layer 2: min and max bitrate not configured, default expected.
6882 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6883 stream->GetVideoStreams()[2].min_bitrate_bps);
6884 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6885 stream->GetVideoStreams()[2].target_bitrate_bps);
6886 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6887 stream->GetVideoStreams()[2].max_bitrate_bps);
6888
6889 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6890}
6891
6892TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6893 const size_t kNumSimulcastStreams = 3;
6894 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6895 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6896
6897 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006898 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006899 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006900 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006901 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006902 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006903
6904 // Set max bitrate for all but the highest layer.
6905 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6906 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6907 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6908 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6909 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6910
6911 // Set max bandwidth equal to total max bitrate.
6912 send_parameters_.max_bandwidth_bps =
6913 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6914 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6915 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6916
6917 // No bitrate above the total max to give to the highest layer.
6918 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6919 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6920 stream->GetVideoStreams()[2].max_bitrate_bps);
6921
6922 // Set max bandwidth above the total max bitrate.
6923 send_parameters_.max_bandwidth_bps =
6924 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6925 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6926 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6927
6928 // The highest layer has no max bitrate set -> the bitrate above the total
6929 // max should be given to the highest layer.
6930 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6931 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6932 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6933 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6934 stream->GetVideoStreams()[2].max_bitrate_bps);
6935
6936 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6937}
6938
6939TEST_F(WebRtcVideoChannelTest,
6940 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6941 const size_t kNumSimulcastStreams = 3;
6942 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6943 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6944 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6945
6946 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006947 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006948 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006949 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006950 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006951 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006952
6953 // Set max bitrate for the highest layer.
6954 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6955 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6956 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6957 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6958
6959 // Set max bandwidth above the total max bitrate.
6960 send_parameters_.max_bandwidth_bps =
6961 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6962 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6963 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6964
6965 // The highest layer has the max bitrate set -> the bitrate above the total
6966 // max should not be given to the highest layer.
6967 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6968 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6969 stream->GetVideoStreams()[2].max_bitrate_bps);
6970
6971 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6972}
6973
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006974// Test that min and max bitrate values set via RtpParameters are correctly
6975// propagated to the underlying encoder for a single stream.
6976TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6977 FakeVideoSendStream* stream = AddSendStream();
6978 EXPECT_TRUE(channel_->SetSend(true));
6979 EXPECT_TRUE(stream->IsSending());
6980
6981 // Set min and max bitrate.
6982 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6983 EXPECT_EQ(1u, parameters.encodings.size());
6984 parameters.encodings[0].min_bitrate_bps = 80000;
6985 parameters.encodings[0].max_bitrate_bps = 150000;
6986 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6987
6988 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6989 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6990 EXPECT_EQ(1u, encoder_config.number_of_streams);
6991 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6992 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6993 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6994
6995 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6996 // VideoStreams are created appropriately.
6997 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6998 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6999 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
7000 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
7001}
7002
7003// Test the default min and max bitrate value are correctly propagated to the
7004// underlying encoder for a single stream (when the values are not set via
7005// RtpParameters).
7006TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
7007 FakeVideoSendStream* stream = AddSendStream();
7008 EXPECT_TRUE(channel_->SetSend(true));
7009 EXPECT_TRUE(stream->IsSending());
7010
7011 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
7012 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
7013 EXPECT_EQ(1u, encoder_config.number_of_streams);
7014 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
7015 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
7016 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
7017
7018 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
7019 // VideoStreams are created appropriately.
7020 EXPECT_EQ(1u, stream->GetVideoStreams().size());
7021 EXPECT_EQ(cricket::kMinVideoBitrateBps,
7022 stream->GetVideoStreams()[0].min_bitrate_bps);
7023 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
7024 stream->GetVideoStreams()[0].min_bitrate_bps);
7025 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
7026 stream->GetVideoStreams()[0].target_bitrate_bps);
7027}
7028
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007029// Test that a stream will not be sending if its encoding is made inactive
7030// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08007031TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07007032 FakeVideoSendStream* stream = AddSendStream();
7033 EXPECT_TRUE(channel_->SetSend(true));
7034 EXPECT_TRUE(stream->IsSending());
7035
7036 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007037 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07007038 ASSERT_EQ(1u, parameters.encodings.size());
7039 ASSERT_TRUE(parameters.encodings[0].active);
7040 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08007041 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007042 EXPECT_FALSE(stream->IsSending());
7043
7044 // Now change it back to active and verify we resume sending.
7045 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08007046 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007047 EXPECT_TRUE(stream->IsSending());
7048}
7049
Seth Hampson8234ead2018-02-02 15:16:24 -08007050// Tests that when active is updated for any simulcast layer then the send
7051// stream's sending state will be updated and it will be reconfigured with the
7052// new appropriate active simulcast streams.
7053TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
7054 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02007055 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08007056 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
7057 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
7058 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
7059 uint32_t primary_ssrc = stream_params.first_ssrc();
7060
Niels Möller805a27e2019-01-21 12:21:27 +01007061 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01007062 // frame. This allows us to test that ReconfigureEncoder is called
7063 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01007064 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08007065 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01007066 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08007067 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007068 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
7069 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
7070 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08007071
7072 // Check that all encodings are initially active.
7073 webrtc::RtpParameters parameters =
7074 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007075 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007076 EXPECT_TRUE(parameters.encodings[0].active);
7077 EXPECT_TRUE(parameters.encodings[1].active);
7078 EXPECT_TRUE(parameters.encodings[2].active);
7079 EXPECT_TRUE(fake_video_send_stream->IsSending());
7080
7081 // Only turn on only the middle stream.
7082 parameters.encodings[0].active = false;
7083 parameters.encodings[1].active = true;
7084 parameters.encodings[2].active = false;
7085 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7086 // Verify that the active fields are set on the VideoChannel.
7087 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007088 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007089 EXPECT_FALSE(parameters.encodings[0].active);
7090 EXPECT_TRUE(parameters.encodings[1].active);
7091 EXPECT_FALSE(parameters.encodings[2].active);
7092 // Check that the VideoSendStream is updated appropriately. This means its
7093 // send state was updated and it was reconfigured.
7094 EXPECT_TRUE(fake_video_send_stream->IsSending());
7095 std::vector<webrtc::VideoStream> simulcast_streams =
7096 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007097 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007098 EXPECT_FALSE(simulcast_streams[0].active);
7099 EXPECT_TRUE(simulcast_streams[1].active);
7100 EXPECT_FALSE(simulcast_streams[2].active);
7101
7102 // Turn off all streams.
7103 parameters.encodings[0].active = false;
7104 parameters.encodings[1].active = false;
7105 parameters.encodings[2].active = false;
7106 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7107 // Verify that the active fields are set on the VideoChannel.
7108 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007109 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007110 EXPECT_FALSE(parameters.encodings[0].active);
7111 EXPECT_FALSE(parameters.encodings[1].active);
7112 EXPECT_FALSE(parameters.encodings[2].active);
7113 // Check that the VideoSendStream is off.
7114 EXPECT_FALSE(fake_video_send_stream->IsSending());
7115 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007116 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007117 EXPECT_FALSE(simulcast_streams[0].active);
7118 EXPECT_FALSE(simulcast_streams[1].active);
7119 EXPECT_FALSE(simulcast_streams[2].active);
7120
Niels Möllerff40b142018-04-09 08:49:14 +02007121 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007122}
7123
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007124// Test that if a stream is reconfigured (due to a codec change or other
7125// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007126TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007127 InactiveStreamDoesntStartSendingWhenReconfigured) {
7128 // Set an initial codec list, which will be modified later.
7129 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007130 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7131 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007132 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7133
7134 FakeVideoSendStream* stream = AddSendStream();
7135 EXPECT_TRUE(channel_->SetSend(true));
7136 EXPECT_TRUE(stream->IsSending());
7137
7138 // Get current parameters and change "active" to false.
7139 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7140 ASSERT_EQ(1u, parameters.encodings.size());
7141 ASSERT_TRUE(parameters.encodings[0].active);
7142 parameters.encodings[0].active = false;
7143 EXPECT_EQ(1u, GetFakeSendStreams().size());
7144 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007145 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007146 EXPECT_FALSE(stream->IsSending());
7147
7148 // Reorder the codec list, causing the stream to be reconfigured.
7149 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007150 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7151 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007152 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7153 auto new_streams = GetFakeSendStreams();
7154 // Assert that a new underlying stream was created due to the codec change.
7155 // Otherwise, this test isn't testing what it set out to test.
7156 EXPECT_EQ(1u, GetFakeSendStreams().size());
7157 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7158
7159 // Verify that we still are not sending anything, due to the inactive
7160 // encoding.
7161 EXPECT_FALSE(new_streams[0]->IsSending());
7162}
7163
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007164// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007165TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007166 AddSendStream();
7167 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007168 parameters.codecs.push_back(GetEngineCodec("VP8"));
7169 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007170 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7171
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007172 webrtc::RtpParameters rtp_parameters =
7173 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007174 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007175 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7176 rtp_parameters.codecs[0]);
7177 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7178 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007179}
7180
Florent Castellidacec712018-05-24 16:24:21 +02007181// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7182TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7183 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7184 params.cname = "rtcpcname";
7185 AddSendStream(params);
7186
7187 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7188 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7189}
7190
deadbeeffb2aced2017-01-06 23:05:37 -08007191// Test that RtpParameters for send stream has one encoding and it has
7192// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007193TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007194 AddSendStream();
7195
7196 webrtc::RtpParameters rtp_parameters =
7197 channel_->GetRtpSendParameters(last_ssrc_);
7198 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007199 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007200}
7201
Florent Castelliabe301f2018-06-12 18:33:49 +02007202TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7203 AddSendStream();
7204
7205 webrtc::RtpParameters rtp_parameters =
7206 channel_->GetRtpSendParameters(last_ssrc_);
7207 rtp_parameters.header_extensions.emplace_back();
7208
7209 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7210
7211 webrtc::RTCError result =
7212 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7213 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7214}
7215
Florent Castelli87b3c512018-07-18 16:00:28 +02007216TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7217 AddSendStream();
7218
Niels Möller805a27e2019-01-21 12:21:27 +01007219 webrtc::test::FrameForwarder frame_forwarder;
7220 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007221
7222 webrtc::RtpParameters rtp_parameters =
7223 channel_->GetRtpSendParameters(last_ssrc_);
7224 EXPECT_EQ(rtp_parameters.degradation_preference,
7225 webrtc::DegradationPreference::BALANCED);
7226 rtp_parameters.degradation_preference =
7227 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7228
7229 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7230
7231 webrtc::RtpParameters updated_rtp_parameters =
7232 channel_->GetRtpSendParameters(last_ssrc_);
7233 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7234 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7235
7236 // Remove the source since it will be destroyed before the channel
7237 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7238}
7239
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007240// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007241TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007242 AddSendStream();
7243 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007244 parameters.codecs.push_back(GetEngineCodec("VP8"));
7245 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007246 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7247
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007248 webrtc::RtpParameters initial_params =
7249 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007250
7251 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007252 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007253
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007254 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7255 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7256}
7257
7258// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007259TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007260 AddRecvStream();
7261 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007262 parameters.codecs.push_back(GetEngineCodec("VP8"));
7263 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007264 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7265
7266 webrtc::RtpParameters rtp_parameters =
7267 channel_->GetRtpReceiveParameters(last_ssrc_);
7268 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007269 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7270 rtp_parameters.codecs[0]);
7271 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7272 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007273}
7274
johan073ece42016-08-26 02:59:47 -07007275#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007276TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007277#else
eladalonf1841382017-06-12 01:16:46 -07007278TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007279#endif
johan3859c892016-08-05 09:19:25 -07007280 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007281 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007282 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007283 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007284 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007285 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007286 parameters.codecs.push_back(kH264sprop2);
7287 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7288
7289 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7290 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7291 webrtc::RtpParameters rtp_parameters =
7292 channel_->GetRtpReceiveParameters(last_ssrc_);
7293 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7294 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7295 ASSERT_EQ(2u, cfg.decoders.size());
7296 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007297 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007298 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007299 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7300 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007301 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007302
7303 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007304 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007305 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007306 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7307 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007308 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007309}
7310
sakal1fd95952016-06-22 00:46:15 -07007311// Test that RtpParameters for receive stream has one encoding and it has
7312// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007313TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007314 AddRecvStream();
7315
7316 webrtc::RtpParameters rtp_parameters =
7317 channel_->GetRtpReceiveParameters(last_ssrc_);
7318 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007319 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007320}
7321
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007322// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007323TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007324 AddRecvStream();
7325 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007326 parameters.codecs.push_back(GetEngineCodec("VP8"));
7327 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007328 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7329
7330 webrtc::RtpParameters initial_params =
7331 channel_->GetRtpReceiveParameters(last_ssrc_);
7332
7333 // We should be able to set the params we just got.
7334 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7335
7336 // ... And this shouldn't change the params returned by
7337 // GetRtpReceiveParameters.
7338 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007339}
7340
deadbeef3bc15102017-04-20 19:25:07 -07007341// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7342// aren't signaled. It should always return an empty "RtpEncodingParameters",
7343// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007344TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007345 // Call necessary methods to configure receiving a default stream as
7346 // soon as it arrives.
7347 cricket::VideoRecvParameters parameters;
7348 parameters.codecs.push_back(GetEngineCodec("VP8"));
7349 parameters.codecs.push_back(GetEngineCodec("VP9"));
7350 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7351
7352 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7353 // stream. Should return nothing.
7354 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7355
7356 // Set a sink for an unsignaled stream.
7357 cricket::FakeVideoRenderer renderer;
7358 // Value of "0" means "unsignaled stream".
7359 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7360
7361 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7362 // in this method means "unsignaled stream".
7363 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7364 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7365 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7366
7367 // Receive VP8 packet.
7368 uint8_t data[kMinRtpPacketLen];
7369 cricket::RtpHeader rtpHeader;
7370 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7371 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7372 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7373 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7374 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007375 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007376
7377 // The |ssrc| member should still be unset.
7378 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7379 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7380 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7381}
7382
eladalonf1841382017-06-12 01:16:46 -07007383void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007384 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007385 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007386
7387 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007388 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007389 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007390 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007391
7392 if (receiver_first) {
7393 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7394 std::vector<FakeVideoReceiveStream*> receive_streams =
7395 fake_call_->GetVideoReceiveStreams();
7396 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007397 // Default local SSRC when we have no sender.
7398 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7399 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007400 }
7401 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7402 if (!receiver_first)
7403 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7404 std::vector<FakeVideoReceiveStream*> receive_streams =
7405 fake_call_->GetVideoReceiveStreams();
7406 ASSERT_EQ(1u, receive_streams.size());
7407 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007408
7409 // Removing first sender should fall back to another (in this case the second)
7410 // local send stream's SSRC.
7411 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7412 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007413 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007414 ASSERT_EQ(1u, receive_streams.size());
7415 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7416
7417 // Removing the last sender should fall back to default local SSRC.
7418 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007419 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007420 ASSERT_EQ(1u, receive_streams.size());
7421 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7422 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007423}
7424
eladalonf1841382017-06-12 01:16:46 -07007425TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007426 TestReceiverLocalSsrcConfiguration(false);
7427}
7428
eladalonf1841382017-06-12 01:16:46 -07007429TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007430 TestReceiverLocalSsrcConfiguration(true);
7431}
7432
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007433class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007434 public:
eladalonf1841382017-06-12 01:16:46 -07007435 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007436 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007437 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7438 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007439 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007440 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007441 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007442 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007443 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007444 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007445 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007446
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007447 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007448 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007449 channel_.reset(engine_.CreateMediaChannel(
7450 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7451 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007452 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007453 last_ssrc_ = 123;
7454 }
7455
7456 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007457 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007458 int capture_width,
7459 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007460 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007461 size_t expected_num_streams,
7462 bool screenshare,
7463 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007464 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007465 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007466 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007467 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007468
Peter Boström0c4e06b2015-10-07 12:23:21 +02007469 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007470 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007471 ssrcs.resize(num_configured_streams);
7472
sprangf24a0642017-02-28 13:23:26 -08007473 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007474 // Send a full-size frame to trigger a stream reconfiguration to use all
7475 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007476 webrtc::test::FrameForwarder frame_forwarder;
7477 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7478 rtc::kNumMicrosecsPerSec / 30);
7479
sprangf24a0642017-02-28 13:23:26 -08007480 VideoOptions options;
7481 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007482 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007483 EXPECT_TRUE(
7484 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007485 // Fetch the latest stream since SetVideoSend() may recreate it if the
7486 // screen content setting is changed.
7487 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007488 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007489 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007490
Zach Stein3ca452b2018-01-18 10:01:24 -08007491 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7492 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7493
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007494 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7495 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007496 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007497
sprang429600d2017-01-26 06:12:26 -08007498 std::vector<webrtc::VideoStream> expected_streams;
Florent Castelli66b38602019-07-10 16:57:57 +02007499 if (num_configured_streams > 1 || conference_mode) {
sprang429600d2017-01-26 06:12:26 -08007500 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007501 num_configured_streams, capture_width, capture_height,
Florent Castelli66b38602019-07-10 16:57:57 +02007502 webrtc::kDefaultBitratePriority, kDefaultQpMax,
7503 screenshare && conference_mode, true);
7504 if (screenshare && conference_mode) {
sprang3ebabf12017-02-16 07:35:22 -08007505 for (const webrtc::VideoStream& stream : expected_streams) {
7506 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007507 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7508 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007509 }
7510 }
sprang429600d2017-01-26 06:12:26 -08007511 } else {
7512 webrtc::VideoStream stream;
7513 stream.width = capture_width;
7514 stream.height = capture_height;
7515 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007516 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007517 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007518 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007519 stream.max_qp = kDefaultQpMax;
7520 expected_streams.push_back(stream);
7521 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007522
7523 ASSERT_EQ(expected_streams.size(), video_streams.size());
7524
7525 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007526 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007527 for (size_t i = 0; i < num_streams; ++i) {
7528 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7529 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7530
7531 EXPECT_GT(video_streams[i].max_framerate, 0);
7532 EXPECT_EQ(expected_streams[i].max_framerate,
7533 video_streams[i].max_framerate);
7534
7535 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7536 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7537 video_streams[i].min_bitrate_bps);
7538
7539 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7540 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7541 video_streams[i].target_bitrate_bps);
7542
7543 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7544 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7545 video_streams[i].max_bitrate_bps);
7546
7547 EXPECT_GT(video_streams[i].max_qp, 0);
7548 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7549
Florent Castelli66b38602019-07-10 16:57:57 +02007550 EXPECT_EQ(num_configured_streams > 1 || conference_mode,
Sergey Silkina796a7e2018-03-01 15:11:29 +01007551 expected_streams[i].num_temporal_layers.has_value());
7552
7553 if (conference_mode) {
7554 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7555 video_streams[i].num_temporal_layers);
7556 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007557
7558 if (i == num_streams - 1) {
7559 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7560 } else {
7561 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7562 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007563 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007564
Niels Möllerff40b142018-04-09 08:49:14 +02007565 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007566 }
7567
7568 FakeVideoSendStream* AddSendStream() {
7569 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7570 }
7571
7572 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007573 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007574 EXPECT_TRUE(channel_->AddSendStream(sp));
7575 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007576 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007577 EXPECT_EQ(num_streams + 1, streams.size());
7578 return streams[streams.size() - 1];
7579 }
7580
7581 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007582 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007583 }
7584
7585 FakeVideoReceiveStream* AddRecvStream() {
7586 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7587 }
7588
7589 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007590 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007591 EXPECT_TRUE(channel_->AddRecvStream(sp));
7592 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007593 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007594 EXPECT_EQ(num_streams + 1, streams.size());
7595 return streams[streams.size() - 1];
7596 }
7597
Danil Chapovalov83bbe912019-08-07 12:24:53 +02007598 webrtc::RtcEventLogNull event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007599 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007600 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7601 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007602 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7603 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007604 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007605 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007606 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007607};
7608
eladalonf1841382017-06-12 01:16:46 -07007609TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007610 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7611 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007612}
7613
eladalonf1841382017-06-12 01:16:46 -07007614TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007615 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7616 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007617}
7618
7619// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007620TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007621 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7622 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007623}
sprang429600d2017-01-26 06:12:26 -08007624
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007625TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Florent Castelli66b38602019-07-10 16:57:57 +02007626 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007627 false);
7628}
7629
eladalonf1841382017-06-12 01:16:46 -07007630TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007631 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7632 true);
7633}
7634
Florent Castelli66b38602019-07-10 16:57:57 +02007635TEST_F(WebRtcVideoChannelSimulcastTest, SimulcastScreenshareWithoutConference) {
7636 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
sprangfe627f32017-03-29 08:24:59 -07007637 false);
7638}
7639
Chen Xing90f3b892019-06-25 10:16:14 +02007640TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7641 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007642
Chen Xing90f3b892019-06-25 10:16:14 +02007643 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007644 EXPECT_TRUE(SetDefaultCodec());
7645 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007646 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007647
Chen Xing90f3b892019-06-25 10:16:14 +02007648 // Send and receive one frame.
7649 SendFrame();
7650 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007651
Chen Xing90f3b892019-06-25 10:16:14 +02007652 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7653 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7654 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007655
Chen Xing90f3b892019-06-25 10:16:14 +02007656 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7657 EXPECT_EQ(source.source_id(), kSsrc);
7658 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7659 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7660 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007661
Chen Xing90f3b892019-06-25 10:16:14 +02007662 // Send and receive another frame.
7663 SendFrame();
7664 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007665
Chen Xing90f3b892019-06-25 10:16:14 +02007666 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7667 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7668 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007669
Chen Xing90f3b892019-06-25 10:16:14 +02007670 source = channel_->GetSources(kSsrc)[0];
7671 EXPECT_EQ(source.source_id(), kSsrc);
7672 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7673 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7674 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007675
Chen Xing90f3b892019-06-25 10:16:14 +02007676 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7677 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007678}
7679
Amit Hilbuchb000b712019-02-25 10:22:14 -08007680TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7681 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7682
7683 std::vector<std::string> rids = {"f", "h", "q"};
7684 std::vector<cricket::RidDescription> rid_descriptions;
7685 for (const auto& rid : rids) {
7686 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7687 }
7688 sp.set_rids(rid_descriptions);
7689
7690 ASSERT_TRUE(channel_->AddSendStream(sp));
7691 const auto& streams = fake_call_->GetVideoSendStreams();
7692 ASSERT_EQ(1u, streams.size());
7693 auto stream = streams[0];
7694 ASSERT_NE(stream, nullptr);
7695 const auto& config = stream->GetConfig();
7696 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7697}
7698
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007699} // namespace cricket