blob: 44bb128b59235bb39a1aa49c0f4b56202a4a407c [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "media/engine/webrtc_video_engine.h"
12
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000013#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080014#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020015#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070016#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000017#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000018
Steve Anton2c9ebef2019-01-28 17:27:58 -080019#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010020#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020021#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070022#include "api/media_transport_config.h"
Danil Chapovalov83bbe912019-08-07 12:24:53 +020023#include "api/rtc_event_log/rtc_event_log.h"
Steve Anton10542f22019-01-11 09:11:00 -080024#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020025#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070026#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080027#include "api/test/mock_video_bitrate_allocator.h"
28#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070029#include "api/test/mock_video_decoder_factory.h"
30#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020031#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080032#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010033#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020034#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020035#include "api/video_codecs/builtin_video_decoder_factory.h"
36#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "api/video_codecs/sdp_video_format.h"
38#include "api/video_codecs/video_decoder_factory.h"
39#include "api/video_codecs/video_encoder.h"
40#include "api/video_codecs/video_encoder_factory.h"
41#include "call/flexfec_receive_stream.h"
42#include "common_video/h264/profile_level_id.h"
Niels Möller805a27e2019-01-21 12:21:27 +010043#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/base/fake_video_renderer.h"
46#include "media/base/media_constants.h"
47#include "media/base/rtp_utils.h"
48#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/fake_webrtc_call.h"
51#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020054#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080056#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020058#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080059#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010061#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020062#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000063
Mirko Bonadei6a489f22019-04-09 15:11:12 +020064using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020065using ::testing::IsEmpty;
66using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010067using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070068using webrtc::RtpExtension;
69
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000070namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000071static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000072
noahricd10a68e2015-07-10 11:27:55 -070073static const uint8_t kRedRtxPayloadType = 125;
74
Niels Möller6557d0c2018-04-11 15:18:34 +020075static const uint32_t kTimeout = 5000U;
76static const uint32_t kDefaultReceiveSsrc = 0;
77static const uint32_t kSsrc = 1234u;
78static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
79static const int kVideoWidth = 640;
80static const int kVideoHeight = 360;
81static const int kFramerate = 30;
82
Peter Boström0c4e06b2015-10-07 12:23:21 +020083static const uint32_t kSsrcs1[] = {1};
84static const uint32_t kSsrcs3[] = {1, 2, 3};
85static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080086static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020087static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080088static const uint32_t kDefaultRecvSsrc = 0;
89
Bjorn A Mellemda4f0932019-07-30 08:34:03 -070090constexpr uint32_t kRtpHeaderSize = 12;
91
pbos@webrtc.org3c107582014-07-20 15:27:35 +000092static const char kUnsupportedExtensionName[] =
93 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000094
magjed509e4fe2016-11-18 01:34:11 -080095cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
96 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020097 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080098}
99
Elad Alonfadb1812019-05-24 13:40:02 +0200100void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
101 bool lntf_expected) {
102 EXPECT_EQ(lntf_expected,
103 codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
106 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
108 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
110 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
111 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800112 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
113 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000114 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
115}
116
magjed725e4842016-11-16 00:48:13 -0800117// Return true if any codec in |codecs| is an RTX codec with associated payload
118// type |payload_type|.
119bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
120 int payload_type) {
121 for (const cricket::VideoCodec& codec : codecs) {
122 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200123 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800124 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
125 &associated_payload_type) &&
126 associated_payload_type == payload_type) {
127 return true;
128 }
129 }
130 return false;
131}
132
nisseca5706d2017-09-11 02:32:16 -0700133// TODO(nisse): Duplicated in call.cc.
134const int* FindKeyByValue(const std::map<int, int>& m, int v) {
135 for (const auto& kv : m) {
136 if (kv.second == v)
137 return &kv.first;
138 }
139 return nullptr;
140}
141
Yves Gerey665174f2018-06-19 15:03:05 +0200142bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
143 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700144 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
145 payload_type) != nullptr;
146}
147
148// Check that there's an Rtx payload type for each decoder.
149bool VerifyRtxReceiveAssociations(
150 const webrtc::VideoReceiveStream::Config& config) {
151 for (const auto& decoder : config.decoders) {
152 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
153 return false;
154 }
155 return true;
156}
157
brandtrffc61182016-11-28 06:02:22 -0800158rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700159 int width,
160 int height) {
161 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
162 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800163 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700164 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000165}
166
Shao Changbine62202f2015-04-21 20:24:50 +0800167void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
168 const std::map<int, int>& rtx_types) {
169 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200170 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800171 EXPECT_TRUE(it != rtx_types.end() &&
172 it->second == config.rtp.rtx.payload_type);
173
brandtrb5f2c3f2016-10-04 23:28:39 -0700174 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
175 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800176 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700177 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800178 }
179}
kthelgason2bc68642017-02-07 07:02:22 -0800180
181cricket::MediaConfig GetMediaConfig() {
182 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100183 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800184 return media_config;
185}
nisse26e3abb2017-08-25 04:44:25 -0700186
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200187// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
188int GetMaxDefaultBitrateBps(size_t width, size_t height) {
189 if (width * height <= 320 * 240) {
190 return 600000;
191 } else if (width * height <= 640 * 480) {
192 return 1700000;
193 } else if (width * height <= 960 * 540) {
194 return 2000000;
195 } else {
196 return 2500000;
197 }
198}
199
Niels Möller731a2c22018-07-30 15:08:07 +0200200class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
201 public:
202 MOCK_METHOD2(AddOrUpdateSink,
203 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
204 const rtc::VideoSinkWants& wants));
205 MOCK_METHOD1(RemoveSink,
206 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
207};
208
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000209} // namespace
210
Yves Gerey665174f2018-06-19 15:03:05 +0200211#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200212 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200213 EXPECT_EQ((w), renderer_.width()); \
214 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200215 EXPECT_EQ(0, renderer_.errors());
216
Yves Gerey665174f2018-06-19 15:03:05 +0200217#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200218 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200219 EXPECT_EQ((w), (r).width()); \
220 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200221 EXPECT_EQ(0, (r).errors());
222
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000223namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700224class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000225 public:
eladalonf1841382017-06-12 01:16:46 -0700226 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200227 explicit WebRtcVideoEngineTest(const std::string& field_trials)
228 : override_field_trials_(
229 field_trials.empty()
230 ? nullptr
231 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
232 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200233 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
234 call_(webrtc::Call::Create([&] {
235 webrtc::Call::Config call_config(&event_log_);
236 call_config.task_queue_factory = task_queue_factory_.get();
237 return call_config;
238 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200239 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
240 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200241 video_bitrate_allocator_factory_(
242 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200243 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200244 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200245 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200246 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200247 // Ensure fake clock doesn't return 0, which will cause some initializations
248 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200249 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200250 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000251
252 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200253 void AssignDefaultAptRtxTypes();
254 void AssignDefaultCodec();
255
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100256 // Find the index of the codec in the engine with the given name. The codec
257 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100258 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100259
magjed509e4fe2016-11-18 01:34:11 -0800260 // Find the codec in the engine with the given name. The codec must be
261 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100262 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800263
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200264 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000265
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200266 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000267 const std::vector<VideoCodec>& codecs);
268
Elad Alon157540a2019-02-08 23:37:52 +0100269 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100270
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200271 // Has to be the first one, so it is initialized before the call or there is a
272 // race condition in the clock access.
273 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200274 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
Danil Chapovalov83bbe912019-08-07 12:24:53 +0200275 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200276 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700277 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000278 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800279 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200280 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
281 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200282 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
283 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700284 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000285 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800286 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000287};
288
eladalonf1841382017-06-12 01:16:46 -0700289TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200290 encoder_factory_->AddSupportedVideoCodecType("VP8");
291 AssignDefaultCodec();
292
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000293 std::vector<VideoCodec> engine_codecs = engine_.codecs();
294 for (size_t i = 0; i < engine_codecs.size(); ++i) {
295 if (engine_codecs[i].name != kRtxCodecName)
296 continue;
297 int associated_payload_type;
298 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000299 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000300 EXPECT_EQ(default_codec_.id, associated_payload_type);
301 return;
302 }
303 FAIL() << "No RTX codec found among default codecs.";
304}
305
eladalonf1841382017-06-12 01:16:46 -0700306TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100307 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100311 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100315 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700316}
317
eladalonf1841382017-06-12 01:16:46 -0700318TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100319 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
320}
321
322TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
323 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
327 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
328}
329
330TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
331 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
332}
333
334TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
335 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100336}
337
338TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100339 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
340}
341
Elad Alonccb9b752019-02-19 13:01:31 +0100342TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
343 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
344}
345
346TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348}
349
philipel1e054862018-10-08 16:13:53 +0200350class WebRtcVideoEngineTestWithGenericDescriptor
351 : public WebRtcVideoEngineTest {
352 public:
353 WebRtcVideoEngineTestWithGenericDescriptor()
354 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
355};
356
Elad Alonccb9b752019-02-19 13:01:31 +0100357TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
358 AdvertiseGenericDescriptor00) {
359 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
360}
361
362TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
363 AdvertiseGenericDescriptor01) {
364 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200365}
366
eladalonf1841382017-06-12 01:16:46 -0700367TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200368 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200370 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700371
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200372 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200374 std::unique_ptr<VideoMediaChannel> channel(
375 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700376 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
377
378 // Add CVO extension.
379 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800380 cricket::VideoSendParameters parameters;
381 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200382 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700383 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200384 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700385
Niels Möller731a2c22018-07-30 15:08:07 +0200386 EXPECT_CALL(
387 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200388 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200389 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700390 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200391 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392
393 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200394 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700395
396 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200397 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200398 EXPECT_CALL(
399 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200400 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200401 Field(&rtc::VideoSinkWants::rotation_applied, true)));
402
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200403 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700404}
405
eladalonf1841382017-06-12 01:16:46 -0700406TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200407 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800408 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200409 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800410
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200411 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800412
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200413 std::unique_ptr<VideoMediaChannel> channel(
414 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800415 // Add CVO extension.
416 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800417 cricket::VideoSendParameters parameters;
418 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800419 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700420 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800421 EXPECT_TRUE(channel->SetSendParameters(parameters));
422 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
423
Niels Möller731a2c22018-07-30 15:08:07 +0200424 // Set source.
425 EXPECT_CALL(
426 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200427 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200428 Field(&rtc::VideoSinkWants::rotation_applied, false)));
429 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800430}
431
eladalonf1841382017-06-12 01:16:46 -0700432TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200433 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700434
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200435 encoder_factory_->AddSupportedVideoCodecType("VP8");
436 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700437
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200438 std::unique_ptr<VideoMediaChannel> channel(
439 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
441
442 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200443 EXPECT_CALL(
444 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200445 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200446 Field(&rtc::VideoSinkWants::rotation_applied, true)));
447 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700448
perkjcaafdba2016-03-20 07:34:29 -0700449 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200450 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700451
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452 // Add CVO extension.
453 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800454 cricket::VideoSendParameters parameters;
455 parameters.codecs.push_back(GetEngineCodec("VP8"));
456 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200457 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700458 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700459 // Also remove the first codec to trigger a codec change as well.
460 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200461 EXPECT_CALL(
462 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200463 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200464 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200465 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700466
467 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200468 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700469
470 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200471 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200472 EXPECT_CALL(
473 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200474 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200475 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200476 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700477}
478
eladalonf1841382017-06-12 01:16:46 -0700479TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200480 encoder_factory_->AddSupportedVideoCodecType("VP8");
481
Sebastian Jansson84848f22018-11-16 10:40:36 +0100482 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200483 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
484 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000485
486 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
487
488 EXPECT_FALSE(channel->SetSend(true))
489 << "Channel should not start without codecs.";
490 EXPECT_TRUE(channel->SetSend(false))
491 << "Channel should be stoppable even without set codecs.";
492}
493
eladalonf1841382017-06-12 01:16:46 -0700494TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200495 encoder_factory_->AddSupportedVideoCodecType("VP8");
496
Sebastian Jansson84848f22018-11-16 10:40:36 +0100497 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200498 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
499 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000500 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
501 VideoMediaInfo info;
502 channel->GetStats(&info);
503}
504
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200505TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200508 std::unique_ptr<VideoMediaChannel> channel(
509 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800510 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
512 EXPECT_TRUE(
513 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200514 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100516 webrtc::test::FrameForwarder frame_forwarder;
517 cricket::FakeFrameSource frame_source(1280, 720,
518 rtc::kNumMicrosecsPerSec / 30);
519 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
520 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100521 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200522 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
523 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000524 kTimeout);
525
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100527 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000528
529 // Setting codecs of the same type should not reallocate any encoders
530 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800531 cricket::VideoSendParameters parameters;
532 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200533 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200534 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000535
536 // Remove stream previously added to free the external encoder instance.
537 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200538 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000539}
540
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200541// Test that when an encoder factory supports H264, we add an RTX
542// codec for it.
543// TODO(deadbeef): This test should be updated if/when we start
544// adding RTX codecs for unrecognized codec names.
545TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800546 using webrtc::H264::kLevel1;
Jonas Olssona4d87372019-07-05 19:08:33 +0200547 using webrtc::H264::ProfileLevelId;
548 using webrtc::H264::ProfileLevelIdToString;
Anders Carlsson67537952018-05-03 11:28:29 +0200549 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
550 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800551 *ProfileLevelIdToString(
552 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200553 webrtc::SdpVideoFormat h264_constrained_high("H264");
554 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800555 *ProfileLevelIdToString(
556 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200557 webrtc::SdpVideoFormat h264_high("H264");
558 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800559 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
560
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200561 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
562 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
563 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700564
magjed725e4842016-11-16 00:48:13 -0800565 // First figure out what payload types the test codecs got assigned.
566 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800567 // Now search for RTX codecs for them. Expect that they all have associated
568 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800569 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200570 codecs,
571 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
572 ->id));
magjed725e4842016-11-16 00:48:13 -0800573 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200574 codecs,
575 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
576 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800577 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200578 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700579}
580
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100581#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700582TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200583 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100584
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200585 std::unique_ptr<VideoMediaChannel> channel(
586 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100587
588 EXPECT_TRUE(
589 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
590}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100591#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100592
eladalonf1841382017-06-12 01:16:46 -0700593TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200594 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100595 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200596 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200597 std::unique_ptr<VideoMediaChannel> channel(
598 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700599
600 EXPECT_TRUE(
601 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
602
Niels Möllerd0f0f682019-01-14 09:09:53 +0100603 webrtc::test::FrameForwarder frame_forwarder;
604 cricket::FakeFrameSource frame_source(1280, 720,
605 rtc::kNumMicrosecsPerSec / 60);
606 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700607 channel->SetSend(true);
608
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200609 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700610
Niels Möllerd0f0f682019-01-14 09:09:53 +0100611 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700612 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700613 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100614 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700615 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700616 int64_t interval = timestamp - last_timestamp;
617
618 // Precision changes from nanosecond to millisecond.
619 // Allow error to be no more than 1.
620 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
621
622 last_timestamp = timestamp;
623 }
624
Niels Möllerd0f0f682019-01-14 09:09:53 +0100625 frame_forwarder.IncomingCapturedFrame(
626 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
627 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700628 last_timestamp = stream->GetLastTimestamp();
629 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100630 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
631 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
632 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700633 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700634 int64_t interval = timestamp - last_timestamp;
635
636 // Precision changes from nanosecond to millisecond.
637 // Allow error to be no more than 1.
638 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
639
640 last_timestamp = timestamp;
641 }
642
643 // Remove stream previously added to free the external encoder instance.
644 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
645}
646
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200647void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
648 std::vector<VideoCodec> engine_codecs = engine_.codecs();
649 RTC_DCHECK(!engine_codecs.empty());
650 for (const cricket::VideoCodec& codec : engine_codecs) {
651 if (codec.name == "rtx") {
652 int associated_payload_type;
653 if (codec.GetParam(kCodecParamAssociatedPayloadType,
654 &associated_payload_type)) {
655 default_apt_rtx_types_[associated_payload_type] = codec.id;
656 }
657 }
658 }
659}
660
661void WebRtcVideoEngineTest::AssignDefaultCodec() {
662 std::vector<VideoCodec> engine_codecs = engine_.codecs();
663 RTC_DCHECK(!engine_codecs.empty());
664 bool codec_set = false;
665 for (const cricket::VideoCodec& codec : engine_codecs) {
666 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
667 codec.name != "ulpfec") {
668 default_codec_ = codec;
669 codec_set = true;
670 }
671 }
672
673 RTC_DCHECK(codec_set);
674}
675
Oleh Prypina40f8242017-12-21 13:32:23 +0100676size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
677 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100678 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
679 for (size_t i = 0; i < codecs.size(); ++i) {
680 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200681 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200682 continue;
683 // The tests only use H264 Constrained Baseline. Make sure we don't return
684 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200685 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200686 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200687 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
688 if (profile_level_id->profile !=
689 webrtc::H264::kProfileConstrainedBaseline) {
690 continue;
691 }
692 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100693 return i;
magjed509e4fe2016-11-18 01:34:11 -0800694 }
695 // This point should never be reached.
696 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100697 return -1;
698}
699
700cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
701 const std::string& name) const {
702 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800703}
704
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200705VideoMediaChannel*
706WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100707 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200708 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
709 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200710 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800711 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200712 for (const webrtc::SdpVideoFormat& format :
713 encoder_factory_->GetSupportedFormats()) {
714 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800715 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200716 parameters.codecs.push_back(engine_codec);
717 }
718 }
magjed509e4fe2016-11-18 01:34:11 -0800719
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200720 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000721
722 return channel;
723}
724
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200725VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000726 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100727 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200728 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
729 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200730 cricket::VideoRecvParameters parameters;
731 parameters.codecs = codecs;
732 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000733
734 return channel;
735}
736
Elad Alon157540a2019-02-08 23:37:52 +0100737void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
738 bool supported) const {
739 const RtpCapabilities capabilities = engine_.GetCapabilities();
740 if (supported) {
741 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200742 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100743 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200744 EXPECT_THAT(capabilities.header_extensions,
745 ::testing::Each(::testing::Field(&RtpExtension::uri,
746 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100747 }
748}
749
eladalonf1841382017-06-12 01:16:46 -0700750TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200751 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000752
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200753 std::unique_ptr<VideoMediaChannel> channel(
754 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000755
Peter Boström0c4e06b2015-10-07 12:23:21 +0200756 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000757
Yves Gerey665174f2018-06-19 15:03:05 +0200758 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000759 EXPECT_TRUE(channel->SetSend(true));
760
Niels Möller805a27e2019-01-21 12:21:27 +0100761 webrtc::test::FrameForwarder frame_forwarder;
762 cricket::FakeFrameSource frame_source(1280, 720,
763 rtc::kNumMicrosecsPerSec / 60);
764 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
765 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000766
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200767 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000768
769 // Verify that encoders are configured for simulcast through adapter
770 // (increasing resolution and only configured to send one stream each).
771 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200772 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
773 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000774 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200775 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000776 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
777 EXPECT_GT(codec_settings.width, prev_width);
778 prev_width = codec_settings.width;
779 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000780
Niels Möllerff40b142018-04-09 08:49:14 +0200781 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782
783 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200784 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000785}
786
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200787TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
788 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200789 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000790
Niels Möllerd0f0f682019-01-14 09:09:53 +0100791 // Frame source.
792 webrtc::test::FrameForwarder frame_forwarder;
793 cricket::FakeFrameSource frame_source(1280, 720,
794 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200795
Sebastian Jansson84848f22018-11-16 10:40:36 +0100796 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200797 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
798 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200799 cricket::VideoSendParameters parameters;
800 parameters.codecs.push_back(GetEngineCodec("H264"));
801 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000802
803 EXPECT_TRUE(
804 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100805 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200806 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100807 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200808
809 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000810
Anders Carlsson67537952018-05-03 11:28:29 +0200811 cricket::VideoSendParameters new_parameters;
812 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
813 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200814
815 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100816 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200817
Anders Carlsson8a150d92018-05-14 12:40:04 +0200818 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000819}
820
eladalonf1841382017-06-12 01:16:46 -0700821TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200823 encoder_factory_->AddSupportedVideoCodecType("VP8");
824 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000825
Sebastian Jansson84848f22018-11-16 10:40:36 +0100826 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200827 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
828 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800829 cricket::VideoSendParameters parameters;
830 parameters.codecs.push_back(GetEngineCodec("VP8"));
831 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000832
Peter Boström0c4e06b2015-10-07 12:23:21 +0200833 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834
Yves Gerey665174f2018-06-19 15:03:05 +0200835 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836 EXPECT_TRUE(channel->SetSend(true));
837
838 // Send a fake frame, or else the media engine will configure the simulcast
839 // encoder adapter at a low-enough size that it'll only create a single
840 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100841 webrtc::test::FrameForwarder frame_forwarder;
842 cricket::FakeFrameSource frame_source(1280, 720,
843 rtc::kNumMicrosecsPerSec / 30);
844 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
845 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000846
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
848 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200850 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000851
852 channel.reset();
853 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000855}
856
eladalonf1841382017-06-12 01:16:46 -0700857TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000858 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200859 encoder_factory_->AddSupportedVideoCodecType("VP8");
860 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000861
Sebastian Jansson84848f22018-11-16 10:40:36 +0100862 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200863 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
864 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800865 cricket::VideoSendParameters parameters;
866 parameters.codecs.push_back(GetEngineCodec("H264"));
867 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000868
869 EXPECT_TRUE(
870 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100871
872 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100873 webrtc::test::FrameForwarder frame_forwarder;
874 cricket::FakeFrameSource frame_source(1280, 720,
875 rtc::kNumMicrosecsPerSec / 30);
876 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
877 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200878 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
879 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200880 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000881 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200882 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000883
884 channel.reset();
885 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200886 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000887}
888
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200889TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200890 RTC_DCHECK(!override_field_trials_);
891 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200892 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200893 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700894
Sebastian Jansson84848f22018-11-16 10:40:36 +0100895 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200896 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
897 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200898 cricket::VideoSendParameters parameters;
899 parameters.codecs.push_back(GetEngineCodec("H264"));
900 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700901
Peter Boström0c4e06b2015-10-07 12:23:21 +0200902 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700903 EXPECT_TRUE(
904 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100905
906 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100907 webrtc::test::FrameForwarder frame_forwarder;
908 cricket::FakeFrameSource frame_source(1280, 720,
909 rtc::kNumMicrosecsPerSec / 30);
910 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
911 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100912
Niels Möller4db138e2018-04-19 09:04:13 +0200913 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200914 ASSERT_EQ(1u, encoder_factory_->encoders().size());
915 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
916 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700917 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200918 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200919 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700920}
921
brandtrffc61182016-11-28 06:02:22 -0800922// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700923// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800924//
925// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700926TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800927 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200928 encoder_factory_->AddSupportedVideoCodecType("VP8");
929
Steve Anton2c9ebef2019-01-28 17:27:58 -0800930 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800931
932 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800933 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800934
935 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200936 RTC_DCHECK(!override_field_trials_);
937 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800938 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800939 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800940}
941
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200942// Test that codecs are added in the order they are reported from the factory.
943TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
944 encoder_factory_->AddSupportedVideoCodecType("VP8");
945 const char* kFakeCodecName = "FakeCodec";
946 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000947
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200948 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100949 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200950 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
951 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000952}
953
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200954// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800955// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200956TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100957 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
958 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100959
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100960 // Set up external encoder factory with first codec, and initialize engine.
961 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
962
brandtrffc61182016-11-28 06:02:22 -0800963 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800964
965 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100966 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800967 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200968 // The codec itself and RTX should have been added.
969 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100970
971 // Check that both fake codecs are present and that the second fake codec
972 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100973 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
974 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100975 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800976}
977
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200978TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
979 const char* kFakeCodecName = "FakeCodec";
980 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
981
982 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
983 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
984}
985
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200986TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
987 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200988 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200989 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800990 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000991
kwiberg686a8ef2016-02-26 03:00:35 -0800992 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200993 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000994
995 EXPECT_TRUE(
996 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200997 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998
999 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001000 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001001 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001002
1003 // Remove stream previously added to free the external decoder instance.
1004 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001005 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006}
1007
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001008// Verifies that we can set up decoders.
1009TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1011 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1012 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1013 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001014 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001015 webrtc::SdpVideoFormat supported_h264("H264");
1016 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1017 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001018 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001019 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001020
kwiberg686a8ef2016-02-26 03:00:35 -08001021 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001022 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001023
1024 EXPECT_TRUE(
1025 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001026 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001027}
1028
Jonas Oreland49ac5952018-09-26 16:04:32 +02001029// Tests when GetSources is called with non-existing ssrc, it will return an
1030// empty list of RtpSource without crashing.
1031TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1032 // Setup an recv stream with |kSsrc|.
1033 encoder_factory_->AddSupportedVideoCodecType("VP8");
1034 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1035 cricket::VideoRecvParameters parameters;
1036 parameters.codecs.push_back(GetEngineCodec("VP8"));
1037 std::unique_ptr<VideoMediaChannel> channel(
1038 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1039
1040 EXPECT_TRUE(
1041 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1042
1043 // Call GetSources with |kSsrc + 1| which doesn't exist.
1044 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1045 EXPECT_EQ(0u, sources.size());
1046}
1047
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001048TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1049 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1050 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1051 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001052 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001053 EXPECT_EQ(0u, engine.codecs().size());
1054}
1055
1056TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1057 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001058 webrtc::MockVideoEncoderFactory* encoder_factory =
1059 new webrtc::MockVideoEncoderFactory();
1060 webrtc::MockVideoDecoderFactory* decoder_factory =
1061 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001062 WebRtcVideoEngine engine(
1063 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001064 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001065 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1066 EXPECT_EQ(0u, engine.codecs().size());
1067 EXPECT_CALL(*encoder_factory, Die());
1068 EXPECT_CALL(*decoder_factory, Die());
1069}
1070
1071// Test full behavior in the video engine when video codec factories of the new
1072// type are injected supporting the single codec Vp8. Check the returned codecs
1073// from the engine and that we will create a Vp8 encoder and decoder using the
1074// new factories.
1075TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1076 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001077 webrtc::MockVideoEncoderFactory* encoder_factory =
1078 new webrtc::MockVideoEncoderFactory();
1079 webrtc::MockVideoDecoderFactory* decoder_factory =
1080 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001081 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1082 rate_allocator_factory =
1083 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001084 EXPECT_CALL(*rate_allocator_factory,
1085 CreateVideoBitrateAllocatorProxy(Field(
1086 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001087 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001088 WebRtcVideoEngine engine(
1089 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001090 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 const webrtc::SdpVideoFormat vp8_format("VP8");
1092 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1093 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001094 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095
1096 // Verify the codecs from the engine.
1097 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001098 // Verify default codecs has been added correctly.
1099 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001100 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001101
1102 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001103 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001104 int vp8_associated_payload;
1105 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1106 &vp8_associated_payload));
1107 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1108
1109 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1110
1111 // RTX codec for RED.
1112 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1113 int red_associated_payload;
1114 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1115 &red_associated_payload));
1116 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1117
1118 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1119
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001120 int associated_payload_type;
1121 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1122 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1123 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1124 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001125 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1126 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127
1128 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001129 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1130 codec_info.is_hardware_accelerated = false;
1131 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001132 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001133 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001134 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001135 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001136 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001138 .WillOnce(
1139 ::testing::DoAll(::testing::InvokeWithoutArgs(
1140 [&encoder_created]() { encoder_created.Set(); }),
1141 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001142
1143 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001144 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001145 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001146 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001147
1148 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001149 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001150 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1151 webrtc::Call::Config call_config(&event_log);
1152 call_config.task_queue_factory = task_queue_factory.get();
1153 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001154
1155 // Create send channel.
1156 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001157 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001158 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1159 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001160 cricket::VideoSendParameters send_parameters;
1161 send_parameters.codecs.push_back(engine_codecs.at(0));
1162 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1163 send_channel->OnReadyToSend(true);
1164 EXPECT_TRUE(
1165 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1166 EXPECT_TRUE(send_channel->SetSend(true));
1167
Niels Möller4db138e2018-04-19 09:04:13 +02001168 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001169 webrtc::test::FrameForwarder frame_forwarder;
1170 cricket::FakeFrameSource frame_source(1280, 720,
1171 rtc::kNumMicrosecsPerSec / 30);
1172 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001173 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001174 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001175 encoder_created.Wait(kTimeout);
1176
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001177 // Create recv channel.
1178 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001179 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001180 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1181 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001182 cricket::VideoRecvParameters recv_parameters;
1183 recv_parameters.codecs.push_back(engine_codecs.at(0));
1184 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1185 EXPECT_TRUE(recv_channel->AddRecvStream(
1186 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1187
1188 // Remove streams previously added to free the encoder and decoder instance.
1189 EXPECT_CALL(*encoder_factory, Die());
1190 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001191 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001192 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1193 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1194}
1195
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001196// Test behavior when decoder factory fails to create a decoder (returns null).
1197TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1198 // |engine| take ownership of the factories.
1199 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001200 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001201 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001202 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001203 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1204 rate_allocator_factory =
1205 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001206 WebRtcVideoEngine engine(
1207 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001208 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001209 const webrtc::SdpVideoFormat vp8_format("VP8");
1210 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1211 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001212 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001213
1214 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001215 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1216 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001217
1218 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001219 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001220 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1221 webrtc::Call::Config call_config(&event_log);
1222 call_config.task_queue_factory = task_queue_factory.get();
1223 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001224
1225 // Create recv channel.
1226 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001227 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001228 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1229 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001230 cricket::VideoRecvParameters recv_parameters;
1231 recv_parameters.codecs.push_back(engine.codecs().front());
1232 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1233 EXPECT_TRUE(recv_channel->AddRecvStream(
1234 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1235
1236 // Remove streams previously added to free the encoder and decoder instance.
1237 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1238}
1239
eladalonf1841382017-06-12 01:16:46 -07001240TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001241 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001242 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001243 std::unique_ptr<VideoMediaChannel> channel(
1244 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001245 ASSERT_TRUE(
1246 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1247 cricket::VideoCodec codec = GetEngineCodec("VP8");
1248 cricket::VideoSendParameters parameters;
1249 parameters.codecs.push_back(codec);
1250 channel->OnReadyToSend(true);
1251 channel->SetSend(true);
1252 ASSERT_TRUE(channel->SetSendParameters(parameters));
1253
Niels Möller805a27e2019-01-21 12:21:27 +01001254 webrtc::test::FrameForwarder frame_forwarder;
1255 cricket::FakeFrameSource frame_source(1280, 720,
1256 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001257 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001258 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001259
Niels Möller805a27e2019-01-21 12:21:27 +01001260 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001261 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001262 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001263 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001264
Niels Möller805a27e2019-01-21 12:21:27 +01001265 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1266 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001267 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001268 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001269
1270 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001271 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1272 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001273 // Change to screen content, recreate encoder. For the simulcast encoder
1274 // adapter case, this will result in two calls since InitEncode triggers a
1275 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001276 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001277 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001278 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001279
Niels Möller805a27e2019-01-21 12:21:27 +01001280 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1281 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001282 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001283 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001284
1285 options.is_screencast.emplace(false);
1286 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001287 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001288 // Change back to regular video content, update encoder. Also change
1289 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001290 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001291 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001292 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001293 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001294
1295 // Remove stream previously added to free the external encoder instance.
1296 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001297 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001298}
1299
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001300class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001301 protected:
1302 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001303 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1304 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001305 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1306 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1307 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001308
1309 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001310 // One testcase calls SetUp in a loop, only create call_ once.
1311 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001312 webrtc::Call::Config call_config(&event_log_);
1313 call_config.task_queue_factory = task_queue_factory_.get();
1314 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001315 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 cricket::MediaConfig media_config;
1317 // Disabling cpu overuse detection actually disables quality scaling too; it
1318 // implies DegradationPreference kMaintainResolution. Automatic scaling
1319 // needs to be disabled, otherwise, tests which check the size of received
1320 // frames become flaky.
1321 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001322 channel_.reset(
1323 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1324 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001325 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001326 channel_->OnReadyToSend(true);
1327 EXPECT_TRUE(channel_.get() != NULL);
1328 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001329 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001330 cricket::VideoRecvParameters parameters;
1331 parameters.codecs = engine_.codecs();
1332 channel_->SetRecvParameters(parameters);
1333 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001334 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1335 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1336 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1337 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001338 }
1339
1340 // Utility method to setup an additional stream to send and receive video.
1341 // Used to test send and recv between two streams.
1342 void SetUpSecondStream() {
1343 SetUpSecondStreamWithNoRecv();
1344 // Setup recv for second stream.
1345 EXPECT_TRUE(channel_->AddRecvStream(
1346 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1347 // Make the second renderer available for use by a new stream.
1348 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1349 }
1350 // Setup an additional stream just to send video. Defer add recv stream.
1351 // This is required if you want to test unsignalled recv of video rtp packets.
1352 void SetUpSecondStreamWithNoRecv() {
1353 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001354 EXPECT_TRUE(
1355 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001356 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001357 EXPECT_FALSE(
1358 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 EXPECT_TRUE(channel_->AddSendStream(
1360 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1361 // We dont add recv for the second stream.
1362
1363 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001364 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001365 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001366 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001367 }
Yves Gerey665174f2018-06-19 15:03:05 +02001368 virtual void TearDown() { channel_.reset(); }
1369 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001370
1371 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001372 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1373 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001374
1375 bool sending = channel_->sending();
1376 bool success = SetSend(false);
1377 if (success) {
1378 cricket::VideoSendParameters parameters;
1379 parameters.codecs.push_back(codec);
1380 success = channel_->SetSendParameters(parameters);
1381 }
1382 if (success) {
1383 success = SetSend(sending);
1384 }
1385 return success;
1386 }
Yves Gerey665174f2018-06-19 15:03:05 +02001387 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001388 void SendFrame() {
1389 if (frame_forwarder_2_) {
1390 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 }
Niels Möller805a27e2019-01-21 12:21:27 +01001392 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001393 }
1394 bool WaitAndSendFrame(int wait_ms) {
1395 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001396 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 return ret;
1398 }
Yves Gerey665174f2018-06-19 15:03:05 +02001399 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001400 int NumRtpBytes(uint32_t ssrc) {
1401 return network_interface_.NumRtpBytes(ssrc);
1402 }
Yves Gerey665174f2018-06-19 15:03:05 +02001403 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001404 int NumRtpPackets(uint32_t ssrc) {
1405 return network_interface_.NumRtpPackets(ssrc);
1406 }
Yves Gerey665174f2018-06-19 15:03:05 +02001407 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1409 return network_interface_.GetRtpPacket(index);
1410 }
1411 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001412 webrtc::RTPHeader header;
1413 EXPECT_TRUE(ParseRtpPacket(p, &header));
1414 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001415 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001416
Niels Möller6557d0c2018-04-11 15:18:34 +02001417 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001418 webrtc::RTPHeader* header) {
1419 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1420 webrtc::RtpHeaderParser::Create());
1421 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001422 }
1423
1424 // Tests that we can send and receive frames.
1425 void SendAndReceive(const cricket::VideoCodec& codec) {
1426 EXPECT_TRUE(SetOneCodec(codec));
1427 EXPECT_TRUE(SetSend(true));
1428 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1429 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001430 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001431 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1432 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1433 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1434 }
1435
1436 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001437 int duration_sec,
1438 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001439 EXPECT_TRUE(SetOneCodec(codec));
1440 EXPECT_TRUE(SetSend(true));
1441 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1442 EXPECT_EQ(0, renderer_.num_rendered_frames());
1443 for (int i = 0; i < duration_sec; ++i) {
1444 for (int frame = 1; frame <= fps; ++frame) {
1445 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1446 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1447 }
1448 }
1449 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1450 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1451 }
1452
Niels Möller6557d0c2018-04-11 15:18:34 +02001453 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1454 cricket::VideoMediaInfo info;
1455 EXPECT_TRUE(channel_->GetStats(&info));
1456 return info.senders[i];
1457 }
1458
1459 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1460 cricket::VideoMediaInfo info;
1461 EXPECT_TRUE(channel_->GetStats(&info));
1462 return info.receivers[i];
1463 }
1464
1465 // Two streams one channel tests.
1466
1467 // Tests that we can send and receive frames.
1468 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1469 SetUpSecondStream();
1470 // Test sending and receiving on first stream.
1471 SendAndReceive(codec);
1472 // Test sending and receiving on second stream.
1473 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1474 EXPECT_GT(NumRtpPackets(), 0);
1475 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1476 }
1477
1478 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1479 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001480 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001481 return engine_codec;
1482 }
1483 // This point should never be reached.
1484 ADD_FAILURE() << "Unrecognized codec name: " << name;
1485 return cricket::VideoCodec();
1486 }
1487
1488 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1489
1490 cricket::StreamParams DefaultSendStreamParams() {
1491 return cricket::StreamParams::CreateLegacy(kSsrc);
1492 }
1493
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001494 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001495 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001496 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001497 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1498 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001499 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001500
1501 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1502 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1503 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1504
Niels Möller6557d0c2018-04-11 15:18:34 +02001505 std::unique_ptr<WebRtcVideoChannel> channel_;
1506 cricket::FakeNetworkInterface network_interface_;
1507 cricket::FakeVideoRenderer renderer_;
1508
1509 // Used by test cases where 2 streams are run on the same channel.
1510 cricket::FakeVideoRenderer renderer2_;
1511};
1512
1513// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001514TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001515 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001516 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001517 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1518 EXPECT_FALSE(channel_->sending());
1519 EXPECT_TRUE(SetSend(true));
1520 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001521 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001522 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1523 EXPECT_TRUE(SetSend(false));
1524 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001525}
Niels Möller6557d0c2018-04-11 15:18:34 +02001526
1527// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001528TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001529 EXPECT_FALSE(channel_->sending());
1530 EXPECT_FALSE(SetSend(true));
1531 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001532}
Niels Möller6557d0c2018-04-11 15:18:34 +02001533
1534// Test that we properly set the send and recv buffer sizes by the time
1535// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001536TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001537 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1538 EXPECT_TRUE(SetSend(true));
1539 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001540 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001541}
1542
Johannes Kron5a0665b2019-04-08 10:35:50 +02001543// Test that we properly set the send and recv buffer sizes when overriding
1544// via field trials.
1545TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1546 // Set field trial to override the default recv buffer size, and then re-run
1547 // setup where the interface is created and configured.
1548 const int kCustomRecvBufferSize = 123456;
1549 webrtc::test::ScopedFieldTrials field_trial(
1550 "WebRTC-IncreasedReceivebuffers/123456/");
1551 SetUp();
1552
1553 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1554 EXPECT_TRUE(SetSend(true));
1555 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1556 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1557}
1558
1559// Test that we properly set the send and recv buffer sizes when overriding
1560// via field trials with suffix.
1561TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1562 // Set field trial to override the default recv buffer size, and then re-run
1563 // setup where the interface is created and configured.
1564 const int kCustomRecvBufferSize = 123456;
1565 webrtc::test::ScopedFieldTrials field_trial(
1566 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1567 SetUp();
1568
1569 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1570 EXPECT_TRUE(SetSend(true));
1571 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1572 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1573}
1574
1575// Test that we properly set the send and recv buffer sizes when overriding
1576// via field trials that don't make any sense.
1577TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1578 // Set bogus field trial values to override the default recv buffer size, and
1579 // then re-run setup where the interface is created and configured. The
1580 // default value should still be used.
1581
1582 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1583 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1584 field_trial_string += group;
1585 field_trial_string += "/";
1586 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1587 SetUp();
1588
1589 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1590 EXPECT_TRUE(SetSend(true));
1591 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1592 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1593 }
1594}
1595
Niels Möller6557d0c2018-04-11 15:18:34 +02001596// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001597TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001598 webrtc::test::ScopedFieldTrials field_trials(
1599 "WebRTC-UseStandardBytesStats/Enabled/");
1600 SetUp();
1601
Niels Möller6557d0c2018-04-11 15:18:34 +02001602 const int kDurationSec = 3;
1603 const int kFps = 10;
1604 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1605
1606 cricket::VideoMediaInfo info;
1607 EXPECT_TRUE(channel_->GetStats(&info));
1608
1609 ASSERT_EQ(1U, info.senders.size());
1610 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1611 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001612 EXPECT_EQ(info.senders[0].bytes_sent,
1613 NumRtpBytes() - kRtpHeaderSize * NumRtpPackets());
Niels Möller6557d0c2018-04-11 15:18:34 +02001614 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1615 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1616 ASSERT_TRUE(info.senders[0].codec_payload_type);
1617 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1618 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1619 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1620 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1621 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1622 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1623 EXPECT_GT(info.senders[0].framerate_input, 0);
1624 EXPECT_GT(info.senders[0].framerate_sent, 0);
1625
1626 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1627 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1628 info.send_codecs[DefaultCodec().id]);
1629
1630 ASSERT_EQ(1U, info.receivers.size());
1631 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1632 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1633 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1634 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1635 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001636 EXPECT_EQ(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1637 info.receivers[0].bytes_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001638 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001639 EXPECT_EQ(0, info.receivers[0].packets_lost);
1640 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1641 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1642 EXPECT_EQ(0, info.receivers[0].firs_sent);
1643 EXPECT_EQ(0, info.receivers[0].plis_sent);
1644 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1645 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1646 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1647 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1648 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1649 EXPECT_GT(info.receivers[0].framerate_output, 0);
1650
1651 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1652 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1653 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001654}
Niels Möller6557d0c2018-04-11 15:18:34 +02001655
1656// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001657TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001658 webrtc::test::ScopedFieldTrials field_trials(
1659 "WebRTC-UseStandardBytesStats/Enabled/");
1660 SetUp();
1661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662 cricket::FakeVideoRenderer renderer1, renderer2;
1663 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1664 cricket::VideoSendParameters parameters;
1665 parameters.codecs.push_back(DefaultCodec());
1666 parameters.conference_mode = true;
1667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1668 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001669 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1670 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001671 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1672 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1673 EXPECT_EQ(0, renderer1.num_rendered_frames());
1674 EXPECT_EQ(0, renderer2.num_rendered_frames());
1675 std::vector<uint32_t> ssrcs;
1676 ssrcs.push_back(1);
1677 ssrcs.push_back(2);
1678 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001679 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001680 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1681 kTimeout);
1682 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1683 kTimeout);
1684
1685 EXPECT_TRUE(channel_->SetSend(false));
1686
1687 cricket::VideoMediaInfo info;
1688 EXPECT_TRUE(channel_->GetStats(&info));
1689 ASSERT_EQ(1U, info.senders.size());
1690 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1691 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001692 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1693 GetSenderStats(0).bytes_sent, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1695 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1696 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1697
1698 ASSERT_EQ(2U, info.receivers.size());
1699 for (size_t i = 0; i < info.receivers.size(); ++i) {
1700 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1701 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001702 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1703 GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1706 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1707 }
srtee0c2eea2017-12-15 17:44:33 +01001708}
Niels Möller6557d0c2018-04-11 15:18:34 +02001709
1710// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001711TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 // Normal setup; note that we set the SSRC explicitly to ensure that
1713 // it will come first in the senders map.
1714 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1715 cricket::VideoSendParameters parameters;
1716 parameters.codecs.push_back(DefaultCodec());
1717 parameters.conference_mode = true;
1718 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001719 EXPECT_TRUE(
1720 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001721 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1722 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001723 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001724 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1725 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1726
1727 // Add an additional capturer, and hook up a renderer to receive it.
1728 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001729 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 const int kTestWidth = 160;
1731 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001732 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1733 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001734 EXPECT_TRUE(
1735 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001736 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001737 EXPECT_TRUE(
1738 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001739 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001740 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001741 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1742 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001743
1744 // Get stats, and make sure they are correct for two senders. We wait until
1745 // the number of expected packets have been sent to avoid races where we
1746 // check stats before it has been updated.
1747 cricket::VideoMediaInfo info;
1748 for (uint32_t i = 0; i < kTimeout; ++i) {
1749 rtc::Thread::Current()->ProcessMessages(1);
1750 EXPECT_TRUE(channel_->GetStats(&info));
1751 ASSERT_EQ(2U, info.senders.size());
1752 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1753 NumRtpPackets()) {
1754 // Stats have been updated for both sent frames, expectations can be
1755 // checked now.
1756 break;
1757 }
1758 }
1759 EXPECT_EQ(NumRtpPackets(),
1760 info.senders[0].packets_sent + info.senders[1].packets_sent)
1761 << "Timed out while waiting for packet counts for all sent packets.";
1762 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1763 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1764 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1765 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1766 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1767 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1768 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1769 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1770 // The capturer must be unregistered here as it runs out of it's scope next.
1771 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001772}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001773
Niels Möller6557d0c2018-04-11 15:18:34 +02001774// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001775TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 cricket::VideoSendParameters parameters;
1777 parameters.codecs.push_back(DefaultCodec());
1778 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1779 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1780 parameters.max_bandwidth_bps = 128 * 1024;
1781 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001782}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001783
Niels Möller6557d0c2018-04-11 15:18:34 +02001784// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001785TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 EXPECT_TRUE(SetDefaultCodec());
1787 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001788 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001790 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001792 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1793 EXPECT_EQ(kSsrc, header.ssrc);
1794
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 // Packets are being paced out, so these can mismatch between the first and
1796 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001797 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1798 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001799 EXPECT_EQ(1, NumSentSsrcs());
1800 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1801 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001802}
Niels Möller6557d0c2018-04-11 15:18:34 +02001803
1804// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001805TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001806 // Remove stream added in Setup.
1807 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1808 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001809 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001810 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001811 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001812 EXPECT_TRUE(SetSend(true));
1813 EXPECT_TRUE(WaitAndSendFrame(0));
1814 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001815 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001816 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001817 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1818 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001819 // Packets are being paced out, so these can mismatch between the first and
1820 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1822 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001823 EXPECT_EQ(1, NumSentSsrcs());
1824 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1825 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001826}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001827
Niels Möller6557d0c2018-04-11 15:18:34 +02001828// Test that we can set the default video renderer before and after
1829// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001830TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001831 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1832 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001833
1834 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1835 rtc::SetBE32(packet1.data() + 8, kSsrc);
1836 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1837 EXPECT_TRUE(SetDefaultCodec());
1838 EXPECT_TRUE(SetSend(true));
1839 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001840 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001841 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001842 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001843 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001844}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001845
Niels Möller6557d0c2018-04-11 15:18:34 +02001846// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001847TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001848 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1849 EXPECT_TRUE(SetSend(true));
1850 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001851 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001852 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1853 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001854 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001855 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001856 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1857 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001858 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1859 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001860
1861 // Remove the send stream that was added during Setup.
1862 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1863 int rtp_packets = NumRtpPackets();
1864
Niels Möller6557d0c2018-04-11 15:18:34 +02001865 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001866 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001867 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001868 EXPECT_EQ(rtp_packets, NumRtpPackets());
1869 // Wait 30ms to guarantee the engine does not drop the frame.
1870 EXPECT_TRUE(WaitAndSendFrame(30));
1871 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1872
1873 last_packet = NumRtpPackets() - 1;
1874 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001875 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1876 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001877}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001878
Niels Möller6557d0c2018-04-11 15:18:34 +02001879// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001880TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001881 cricket::FakeVideoRenderer renderer1, renderer2;
1882 EXPECT_TRUE(SetDefaultCodec());
1883 cricket::VideoSendParameters parameters;
1884 parameters.codecs.push_back(DefaultCodec());
1885 parameters.conference_mode = true;
1886 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1887 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001888 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1889 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001890 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1891 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1892 EXPECT_EQ(0, renderer1.num_rendered_frames());
1893 EXPECT_EQ(0, renderer2.num_rendered_frames());
1894 std::vector<uint32_t> ssrcs;
1895 ssrcs.push_back(1);
1896 ssrcs.push_back(2);
1897 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001898 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001899 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1900 kTimeout);
1901 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1902 kTimeout);
1903
1904 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1905 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1906 EXPECT_EQ(kVideoWidth, renderer1.width());
1907 EXPECT_EQ(kVideoHeight, renderer1.height());
1908 EXPECT_EQ(kVideoWidth, renderer2.width());
1909 EXPECT_EQ(kVideoHeight, renderer2.height());
1910 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1911 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001912}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001913
Niels Möller6557d0c2018-04-11 15:18:34 +02001914// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001915TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 using cricket::FOURCC_I420;
Jonas Olssona4d87372019-07-05 19:08:33 +02001917 using cricket::VideoCodec;
1918 using cricket::VideoFormat;
1919 using cricket::VideoOptions;
Niels Möller6557d0c2018-04-11 15:18:34 +02001920
1921 VideoCodec codec = DefaultCodec();
1922 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1923 EXPECT_TRUE(SetOneCodec(codec));
1924 EXPECT_TRUE(SetSend(true));
1925 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1926 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001927 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001928 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001929
1930 webrtc::test::FrameForwarder frame_forwarder;
1931 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1932 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001933
1934 // TODO(nisse): This testcase fails if we don't configure
1935 // screencast. It's unclear why, I see nothing obvious in this
1936 // test which is related to screencast logic.
1937 VideoOptions video_options;
1938 video_options.is_screencast = true;
1939 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1940
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 int captured_frames = 1;
1942 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001943 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001944 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001945 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1946
Niels Möller6557d0c2018-04-11 15:18:34 +02001947 ++captured_frames;
1948 // Wait until frame of right size is captured.
1949 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001950 480 == renderer_.width() &&
1951 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001952 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001953 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001954 EXPECT_EQ(480, renderer_.width());
1955 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001956 captured_frames = renderer_.num_rendered_frames() + 1;
1957 EXPECT_FALSE(renderer_.black_frame());
1958 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1959 // Make sure a black frame is generated within the specified timeout.
1960 // The black frame should be the resolution of the previous frame to
1961 // prevent expensive encoder reconfigurations.
1962 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001963 480 == renderer_.width() &&
1964 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001965 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001967 EXPECT_EQ(480, renderer_.width());
1968 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001969 EXPECT_TRUE(renderer_.black_frame());
1970
1971 // The black frame has the same timestamp as the next frame since it's
1972 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1973 // not render a frame with the same timestamp so capture another frame
1974 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001975 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001976 }
srtee0c2eea2017-12-15 17:44:33 +01001977}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001978
Niels Möller6557d0c2018-04-11 15:18:34 +02001979// Tests that if SetVideoSend is called with a NULL capturer after the
1980// capturer was already removed, the application doesn't crash (and no black
1981// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001982TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001983 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1984 EXPECT_TRUE(SetSend(true));
1985 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1986 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001987 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1989 // Wait for one frame so they don't get dropped because we send frames too
1990 // tightly.
1991 rtc::Thread::Current()->ProcessMessages(30);
1992 // Remove the capturer.
1993 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1994
1995 // No capturer was added, so this SetVideoSend shouldn't do anything.
1996 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1997 rtc::Thread::Current()->ProcessMessages(300);
1998 // Verify no more frames were sent.
1999 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01002000}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002001
Niels Möller6557d0c2018-04-11 15:18:34 +02002002// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01002003TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2005 // interval time to avoid that.
2006 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2007 // interval time to avoid that.
2008 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02002009 EXPECT_TRUE(
2010 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
2012 cricket::VideoFormat capture_format(
2013 kVideoWidth, kVideoHeight,
2014 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2015 // Set up additional stream 1.
2016 cricket::FakeVideoRenderer renderer1;
2017 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002018 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002020 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002021
2022 webrtc::test::FrameForwarder frame_forwarder1;
2023 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2024 rtc::kNumMicrosecsPerSec / kFramerate);
2025
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 // Set up additional stream 2.
2027 cricket::FakeVideoRenderer renderer2;
2028 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002029 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002030 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002031 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002032 webrtc::test::FrameForwarder frame_forwarder2;
2033
Niels Möller6557d0c2018-04-11 15:18:34 +02002034 // State for all the streams.
2035 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2036 // A limitation in the lmi implementation requires that SetVideoSend() is
2037 // called after SetOneCodec().
2038 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002039 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2040 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002041 EXPECT_TRUE(SetSend(true));
2042 // Test capturer associated with engine.
2043 const int kTestWidth = 160;
2044 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002045 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2046 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2047 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002048 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2049 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002050 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002051 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2052 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2053 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002054 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2055 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002056 // Successfully remove the capturer.
2057 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2058 // The capturers must be unregistered here as it runs out of it's scope
2059 // next.
2060 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2061 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002062}
Niels Möller6557d0c2018-04-11 15:18:34 +02002063
2064// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002065TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002066 // Remove the send stream that was added during Setup.
2067 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2068
2069 cricket::StreamParams empty;
2070 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002071 EXPECT_TRUE(
2072 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002073}
Niels Möller6557d0c2018-04-11 15:18:34 +02002074
2075// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002076TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002077 // Remove stream added in Setup. I.e. remove stream corresponding to default
2078 // channel.
2079 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002080 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002081 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2082 EXPECT_TRUE(channel_->AddSendStream(
2083 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2084 }
2085 // Delete one of the non default channel streams, let the destructor delete
2086 // the remaining ones.
2087 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2088 // Stream should already be deleted.
2089 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002090}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002091
eladalonf1841382017-06-12 01:16:46 -07002092TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002093 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002094}
2095
eladalonf1841382017-06-12 01:16:46 -07002096TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002097 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002098}
2099
eladalonf1841382017-06-12 01:16:46 -07002100TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002101 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002102}
2103
eladalonf1841382017-06-12 01:16:46 -07002104TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002105 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2106 // bitrates. This currently happens at <250k, and two streams sharing 300k
2107 // initially will use QVGA instead of VGA.
2108 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2109 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002110 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002111 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002112 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002113}
2114
philipele8ed8302019-07-03 11:53:48 +02002115TEST_F(WebRtcVideoChannelBaseTest, OnEncoderFailure) {
2116 cricket::VideoSendParameters parameters;
2117 parameters.codecs.push_back(GetEngineCodec("VP9"));
2118 parameters.codecs.push_back(GetEngineCodec("VP8"));
2119 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2120
2121 VideoCodec codec;
2122 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2123 EXPECT_EQ("VP9", codec.name);
2124
2125 // OnEncoderFailure will post a task to the worker thread (which is also
2126 // the current thread), hence the ProcessMessages call.
2127 channel_->OnEncoderFailure();
2128 rtc::Thread::Current()->ProcessMessages(30);
2129 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2130 EXPECT_EQ("VP8", codec.name);
2131
2132 // No other codec to fall back to, keep using VP8.
2133 channel_->OnEncoderFailure();
2134 rtc::Thread::Current()->ProcessMessages(30);
2135 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2136 EXPECT_EQ("VP8", codec.name);
2137}
2138
eladalonf1841382017-06-12 01:16:46 -07002139class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002140 public:
eladalonf1841382017-06-12 01:16:46 -07002141 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2142 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002143 : WebRtcVideoEngineTest(field_trials),
2144 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2145 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002146 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002147 encoder_factory_->AddSupportedVideoCodecType("VP8");
2148 encoder_factory_->AddSupportedVideoCodecType("VP9");
2149#if defined(WEBRTC_USE_H264)
2150 encoder_factory_->AddSupportedVideoCodecType("H264");
2151#endif
2152
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002153 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002154 channel_.reset(engine_.CreateMediaChannel(
2155 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2156 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002157 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002158 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002159 send_parameters_.codecs = engine_.codecs();
2160 recv_parameters_.codecs = engine_.codecs();
2161 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002162 }
2163
2164 protected:
2165 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002166 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002167 }
2168
2169 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002170 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002171 EXPECT_TRUE(channel_->AddSendStream(sp));
2172 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002173 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002174 EXPECT_EQ(num_streams + 1, streams.size());
2175 return streams[streams.size() - 1];
2176 }
2177
2178 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002179 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002180 }
2181
2182 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002183 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002184 }
2185
2186 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002187 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002188 EXPECT_TRUE(channel_->AddRecvStream(sp));
2189 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002190 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002191 EXPECT_EQ(num_streams + 1, streams.size());
2192 return streams[streams.size() - 1];
2193 }
2194
pbos@webrtc.org00873182014-11-25 14:03:34 +00002195 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2196 int expected_min_bitrate_bps,
2197 const char* start_bitrate_kbps,
2198 int expected_start_bitrate_bps,
2199 const char* max_bitrate_kbps,
2200 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002201 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2202 expected_start_bitrate_bps,
2203 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002204 auto& codecs = send_parameters_.codecs;
2205 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002206 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002207 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2208 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2209 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002210 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002211 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002212
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002213 void ExpectSetBitrateParameters(int min_bitrate_bps,
2214 int start_bitrate_bps,
2215 int max_bitrate_bps) {
2216 EXPECT_CALL(
2217 *fake_call_->GetMockTransportControllerSend(),
2218 SetSdpBitrateParameters(AllOf(
2219 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2220 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2221 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2222 }
2223
2224 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2225 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2226 SetSdpBitrateParameters(Field(
2227 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002228 }
2229
Johannes Kron9190b822018-10-29 11:22:05 +01002230 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2231 // For a caller, the answer will be applied in set remote description
2232 // where SetSendParameters() is called.
2233 EXPECT_TRUE(
2234 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2235 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2236 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2237 const webrtc::VideoSendStream::Config& config =
2238 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2239 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2240 }
2241
2242 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2243 // For a callee, the answer will be applied in set local description
2244 // where SetExtmapAllowMixed() and AddSendStream() are called.
2245 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2246 EXPECT_TRUE(
2247 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2248 const webrtc::VideoSendStream::Config& config =
2249 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2250 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2251 }
2252
isheriff6f8d6862016-05-26 11:24:55 -07002253 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002254 // Enable extension.
2255 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002256 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002257 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002258 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002259 FakeVideoSendStream* send_stream =
2260 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2261
2262 // Verify the send extension id.
2263 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2264 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002265 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002266 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002267 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002268 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2269 // receivers.
2270 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2271 ->GetConfig()
2272 .rtp.extensions.empty());
2273
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002274 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002275 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002276 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2277 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002278 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2279
2280 // Verify that adding receive RTP header extensions adds them for existing
2281 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002282 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002283 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002284 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2285 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002286 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002287 }
2288
isheriff6f8d6862016-05-26 11:24:55 -07002289 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002290 // Enable extension.
2291 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002292 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002293 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002294 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002295
2296 FakeVideoReceiveStream* recv_stream =
2297 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2298
2299 // Verify the recv extension id.
2300 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2301 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002302 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002303 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002304 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002305
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002306 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2307 // senders.
2308 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2309 ->GetConfig()
2310 .rtp.extensions.empty());
2311
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002312 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002313 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002314 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2315 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002316 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2317
2318 // Verify that adding receive RTP header extensions adds them for existing
2319 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002320 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002321 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002322 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2323 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002324 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002325 }
2326
Elad Alonfadb1812019-05-24 13:40:02 +02002327 void TestLossNotificationState(bool expect_lntf_enabled) {
2328 AssignDefaultCodec();
2329 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2330
2331 cricket::VideoSendParameters parameters;
2332 parameters.codecs = engine_.codecs();
2333 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2334 EXPECT_TRUE(channel_->SetSend(true));
2335
2336 // Send side.
2337 FakeVideoSendStream* send_stream =
2338 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2339 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2340
2341 // Receiver side.
2342 FakeVideoReceiveStream* recv_stream =
2343 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2344 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2345 }
2346
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002347 void TestExtensionFilter(const std::vector<std::string>& extensions,
2348 const std::string& expected_extension) {
2349 cricket::VideoSendParameters parameters = send_parameters_;
2350 int expected_id = -1;
2351 int id = 1;
2352 for (const std::string& extension : extensions) {
2353 if (extension == expected_extension)
2354 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002355 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002356 }
2357 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2358 FakeVideoSendStream* send_stream =
2359 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2360
2361 // Verify that only one of them has been set, and that it is the one with
2362 // highest priority (transport sequence number).
2363 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2364 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2365 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002366 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002367 }
2368
asapersson3c81a1a2017-06-14 05:52:21 -07002369 void TestDegradationPreference(bool resolution_scaling_enabled,
2370 bool fps_scaling_enabled);
2371
Erik Språngefbde372015-04-29 16:21:28 +02002372 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002373 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002374 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2375 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002376
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002377 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002378 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002379 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002380 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002381 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002382 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002383 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002384 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002385 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002386
Erik Språng143cec12015-04-28 10:01:41 +02002387 return fake_call_->GetVideoSendStreams().back();
2388 }
2389
Peter Boström2feafdb2015-09-09 14:32:14 +02002390 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2391 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002392 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002393 std::vector<uint32_t> ssrcs;
2394 std::vector<uint32_t> rtx_ssrcs;
2395 uint32_t num_streams = enabled ? 3 : 1;
2396 for (uint32_t i = 0; i < num_streams; ++i) {
2397 uint32_t ssrc = last_ssrc_ + i;
2398 ssrcs.push_back(ssrc);
2399 if (with_rtx) {
2400 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2401 }
Erik Språng143cec12015-04-28 10:01:41 +02002402 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002403 if (with_rtx) {
2404 return AddSendStream(
2405 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2406 }
2407 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002408 }
2409
perkjfa10b552016-10-02 23:45:26 -07002410 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002411 std::vector<FakeVideoSendStream*> streams =
2412 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002413 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002414 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002415 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002416 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002417 }
2418
perkjfa10b552016-10-02 23:45:26 -07002419 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002420 int stream_max,
2421 int expected_encoder_bitrate) {
2422 VideoSendParameters limited_send_params = send_parameters_;
2423 limited_send_params.max_bandwidth_bps = global_max;
2424 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002425 webrtc::RtpParameters parameters =
2426 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002427 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002428 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002429 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002430 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002431 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002432 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002433 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002434 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002435 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002436 }
2437
Åsa Persson55659812018-06-18 17:51:32 +02002438 // Values from kSimulcastConfigs in simulcast.cc.
2439 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2440 std::vector<webrtc::VideoStream> layers(3);
2441 layers[0].min_bitrate_bps = 30000;
2442 layers[0].target_bitrate_bps = 150000;
2443 layers[0].max_bitrate_bps = 200000;
2444 layers[1].min_bitrate_bps = 150000;
2445 layers[1].target_bitrate_bps = 500000;
2446 layers[1].max_bitrate_bps = 700000;
2447 layers[2].min_bitrate_bps = 600000;
2448 layers[2].target_bitrate_bps = 2500000;
2449 layers[2].max_bitrate_bps = 2500000;
2450 return layers;
2451 }
2452
Niels Möller805a27e2019-01-21 12:21:27 +01002453 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002454 std::unique_ptr<FakeCall> fake_call_;
2455 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002456 cricket::VideoSendParameters send_parameters_;
2457 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002458 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002459};
2460
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002462 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002463 const std::string kSyncLabel = "AvSyncLabel";
2464
2465 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002466 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002467 EXPECT_TRUE(channel_->AddRecvStream(sp));
2468
Mirko Bonadeif859e552018-05-30 15:31:29 +02002469 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002470 EXPECT_EQ(kSyncLabel,
2471 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2472 << "SyncGroup should be set based on sync_label";
2473}
2474
eladalonf1841382017-06-12 01:16:46 -07002475TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002476 cricket::VideoSendParameters parameters;
2477 parameters.codecs = engine_.codecs();
2478 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002479 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002480 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002481 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002482
2483 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002484 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2485 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002486 FakeVideoSendStream* send_stream = AddSendStream(
2487 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2488
2489 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2490 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2491 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2492
2493 // Receiver side.
2494 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2495 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002496 EXPECT_FALSE(
2497 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002498 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002499 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002500 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002501 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002502 << "RTX should be mapped for the RED payload type";
2503
brandtr14742122017-01-27 04:53:07 -08002504 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002505}
2506
eladalonf1841382017-06-12 01:16:46 -07002507TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002508 // Setup one channel with an associated RTX stream.
2509 cricket::StreamParams params =
2510 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2511 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2512 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002513 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002514
2515 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2516 << "RTX should be mapped for all decoders/payload types.";
2517 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002518 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002519 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002520}
2521
eladalonf1841382017-06-12 01:16:46 -07002522TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002523 // Setup one channel without an associated RTX stream.
2524 cricket::StreamParams params =
2525 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2526 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002527 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002528}
2529
Johannes Kron9190b822018-10-29 11:22:05 +01002530// Test propagation of extmap allow mixed setting.
2531TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2532 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2533}
2534TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2535 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2536}
2537TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2538 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2539}
2540TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2541 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2542}
2543
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002545 FakeVideoSendStream* send_stream =
2546 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2547 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2548
2549 FakeVideoReceiveStream* recv_stream =
2550 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2551 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002552}
2553
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002554// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002555TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002556 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002557}
isheriff6f8d6862016-05-26 11:24:55 -07002558
eladalonf1841382017-06-12 01:16:46 -07002559TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002560 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002561}
2562
2563// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002565 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002566}
isheriff6f8d6862016-05-26 11:24:55 -07002567
eladalonf1841382017-06-12 01:16:46 -07002568TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002569 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002570}
2571
eladalonf1841382017-06-12 01:16:46 -07002572TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002573 // Enable three redundant extensions.
2574 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002575 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2576 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2577 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2578 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002579}
2580
eladalonf1841382017-06-12 01:16:46 -07002581TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002582 // Enable two redundant extensions.
2583 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002584 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2585 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2586 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002587}
2588
stefanc1aeaf02015-10-15 07:26:07 -07002589// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002590TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002591 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002592}
eladalonf1841382017-06-12 01:16:46 -07002593TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002594 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002595}
2596
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002597// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002598TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002599 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002600}
eladalonf1841382017-06-12 01:16:46 -07002601TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002602 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002603}
2604
eladalonf1841382017-06-12 01:16:46 -07002605TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002606 const int kAbsSendTimeId = 1;
2607 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002608 send_parameters_.extensions.push_back(
2609 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2610 send_parameters_.extensions.push_back(
2611 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002612
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002614 FakeVideoSendStream* send_stream =
2615 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2616
2617 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002618 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002619
2620 // Setting the same extensions (even if in different order) shouldn't
2621 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002622 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002624
2625 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2626
2627 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002628 send_parameters_.extensions.resize(1);
2629 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002630
2631 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2632}
2633
eladalonf1841382017-06-12 01:16:46 -07002634TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002635 const int kTOffsetId = 1;
2636 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002637 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002638 recv_parameters_.extensions.push_back(
2639 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2640 recv_parameters_.extensions.push_back(
2641 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2642 recv_parameters_.extensions.push_back(
2643 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002644
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002646 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002647 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2648
2649 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002650 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002651
2652 // Setting the same extensions (even if in different order) shouldn't
2653 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002654 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002655 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002656
2657 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2658
2659 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002660 recv_parameters_.extensions.resize(1);
2661 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002662
2663 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2664}
2665
eladalonf1841382017-06-12 01:16:46 -07002666TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002667 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002668 const int kUnsupportedId = 1;
2669 const int kTOffsetId = 2;
2670
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002671 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002672 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002673 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002674 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002675 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002676 FakeVideoSendStream* send_stream =
2677 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2678
2679 // Only timestamp offset extension is set to send stream,
2680 // unsupported rtp extension is ignored.
2681 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002682 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2683 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002684}
2685
eladalonf1841382017-06-12 01:16:46 -07002686TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002687 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002688 const int kUnsupportedId = 1;
2689 const int kTOffsetId = 2;
2690
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002691 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002692 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002693 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002694 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002695 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002696 FakeVideoReceiveStream* recv_stream =
2697 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2698
2699 // Only timestamp offset extension is set to receive stream,
2700 // unsupported rtp extension is ignored.
2701 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002702 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2703 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002704}
2705
eladalonf1841382017-06-12 01:16:46 -07002706TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002707 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002708 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002709 send_parameters_.extensions.push_back(
2710 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002711 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002712 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2713 }
2714}
2715
eladalonf1841382017-06-12 01:16:46 -07002716TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002717 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002718 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002719 recv_parameters_.extensions.push_back(
2720 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002721 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002722 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2723 }
2724}
2725
eladalonf1841382017-06-12 01:16:46 -07002726TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002727 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002728 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002729 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002730 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002731 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002732 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002733
2734 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002735 send_parameters_.extensions.clear();
2736 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002737 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002738 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2739 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002740}
2741
eladalonf1841382017-06-12 01:16:46 -07002742TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002743 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002744 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002745 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002746 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002747 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002748 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002749
2750 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002751 recv_parameters_.extensions.clear();
2752 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002753 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002754 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2755 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002756}
2757
eladalonf1841382017-06-12 01:16:46 -07002758TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002759 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002760 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002761}
2762
eladalonf1841382017-06-12 01:16:46 -07002763TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002764 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002765 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002766}
2767
eladalonf1841382017-06-12 01:16:46 -07002768TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002769 FakeVideoReceiveStream* stream = AddRecvStream();
2770 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002771}
2772
eladalonf1841382017-06-12 01:16:46 -07002773TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002774 FakeVideoReceiveStream* stream = AddRecvStream();
2775 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2776}
2777
eladalonf1841382017-06-12 01:16:46 -07002778TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002779 FakeVideoReceiveStream* stream = AddRecvStream();
2780 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2781
Peter Boström126c03e2015-05-11 12:48:12 +02002782 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002783 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002784 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002785 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2786 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002787 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002788 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2789
2790 // Verify that REMB is turned on when setting default codecs since the
2791 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002792 parameters.codecs = engine_.codecs();
2793 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002794 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002795 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002796}
2797
eladalonf1841382017-06-12 01:16:46 -07002798TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002799 FakeVideoReceiveStream* stream = AddRecvStream();
2800 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2801
2802 // Verify that transport cc feedback is turned off when send(!) codecs without
2803 // transport cc feedback are set.
2804 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002805 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002806 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2807 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2808 stream = fake_call_->GetVideoReceiveStreams()[0];
2809 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2810
2811 // Verify that transport cc feedback is turned on when setting default codecs
2812 // since the default codecs have transport cc feedback enabled.
2813 parameters.codecs = engine_.codecs();
2814 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2815 stream = fake_call_->GetVideoReceiveStreams()[0];
2816 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2817}
2818
Elad Alonfadb1812019-05-24 13:40:02 +02002819TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2820 TestLossNotificationState(false);
2821}
2822
2823TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2824 RTC_DCHECK(!override_field_trials_);
2825 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2826 "WebRTC-RtcpLossNotification/Enabled/");
2827 SetUp();
2828 TestLossNotificationState(true);
2829}
2830
2831TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2832 RTC_DCHECK(!override_field_trials_);
2833 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2834 "WebRTC-RtcpLossNotification/Enabled/");
2835 SetUp();
2836
2837 AssignDefaultCodec();
2838 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2839
2840 {
2841 cricket::VideoSendParameters parameters;
2842 parameters.codecs = engine_.codecs();
2843 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2844 EXPECT_TRUE(channel_->SetSend(true));
2845 }
2846
2847 // Start with LNTF enabled.
2848 FakeVideoSendStream* send_stream =
2849 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2850 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2851 FakeVideoReceiveStream* recv_stream =
2852 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2853 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2854
2855 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2856 cricket::VideoSendParameters parameters;
2857 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2858 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2859 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2860 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2861 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2862 send_stream = fake_call_->GetVideoSendStreams()[0];
2863 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2864
2865 // Setting the default codecs again, including VP8, turns LNTF back on.
2866 parameters.codecs = engine_.codecs();
2867 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2868 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2869 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2870 send_stream = fake_call_->GetVideoSendStreams()[0];
2871 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2872}
2873
eladalonf1841382017-06-12 01:16:46 -07002874TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002875 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002876 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002877
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002878 cricket::VideoSendParameters parameters;
2879 parameters.codecs = engine_.codecs();
2880 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002881 EXPECT_TRUE(channel_->SetSend(true));
2882
2883 // Send side.
2884 FakeVideoSendStream* send_stream =
2885 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2886 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2887
2888 // Receiver side.
2889 FakeVideoReceiveStream* recv_stream =
2890 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2891 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2892
2893 // Nack history size should match between sender and receiver.
2894 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2895 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002896}
2897
eladalonf1841382017-06-12 01:16:46 -07002898TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002899 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002900 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002901
2902 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2903 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2904
2905 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002906 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002907 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002908 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2909 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002910 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2911 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2912 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002913 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2914
Peter Boström67c9df72015-05-11 14:34:58 +02002915 // Verify that NACK is turned on when setting default codecs since the
2916 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002917 parameters.codecs = engine_.codecs();
2918 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002919 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2920 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2921 send_stream = fake_call_->GetVideoSendStreams()[0];
2922 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002923}
2924
Peter Boströme7ba0862016-03-12 00:02:28 +01002925// This test verifies that new frame sizes reconfigures encoders even though not
2926// (yet) sending. The purpose of this is to permit encoding as quickly as
2927// possible once we start sending. Likely the frames being input are from the
2928// same source that will be sent later, which just means that we're ready
2929// earlier.
eladalonf1841382017-06-12 01:16:46 -07002930TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002931 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002932 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002933 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2934 channel_->SetSend(false);
2935
2936 FakeVideoSendStream* stream = AddSendStream();
2937
perkjfa10b552016-10-02 23:45:26 -07002938 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002939 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002940 EXPECT_EQ(0u, streams[0].width);
2941 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002942
Niels Möller805a27e2019-01-21 12:21:27 +01002943 webrtc::test::FrameForwarder frame_forwarder;
2944 cricket::FakeFrameSource frame_source(1280, 720,
2945 rtc::kNumMicrosecsPerSec / 30);
2946
2947 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2948 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002949
2950 // Frame entered, should be reconfigured to new dimensions.
2951 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002952 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2953 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002954
Niels Möllerff40b142018-04-09 08:49:14 +02002955 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002956}
2957
eladalonf1841382017-06-12 01:16:46 -07002958TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002959 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002960 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002961 cricket::VideoSendParameters parameters;
2962 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002963 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002964 AddSendStream();
2965
Niels Möller805a27e2019-01-21 12:21:27 +01002966 webrtc::test::FrameForwarder frame_forwarder;
2967 cricket::FakeFrameSource frame_source(1280, 720,
2968 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002969 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002970 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002971 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2972 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002973
2974 EXPECT_TRUE(channel_->SetSend(true));
2975
Niels Möller805a27e2019-01-21 12:21:27 +01002976 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002977 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2978 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2979
2980 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2981
2982 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002983 webrtc::VideoEncoderConfig encoder_config =
2984 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002985 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002986 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002987 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002988 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2989 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002990 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2991 << "Non-screenshare shouldn't use min-transmit bitrate.";
2992
Niels Möllerff40b142018-04-09 08:49:14 +02002993 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002994 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002995 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002996 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002997 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2998 &frame_forwarder));
2999 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08003000 // Send stream recreated after option change.
3001 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3002 send_stream = fake_call_->GetVideoSendStreams().front();
3003 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003004
3005 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003006 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003007 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003008 encoder_config.content_type);
3009 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
3010 encoder_config.min_transmit_bitrate_bps);
3011
perkjfa10b552016-10-02 23:45:26 -07003012 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003013 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3014 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01003015 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02003016 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003017}
3018
eladalonf1841382017-06-12 01:16:46 -07003019TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003020 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02003021 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08003022 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003023 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003024
3025 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003026 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003027 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003028 webrtc::test::FrameForwarder frame_forwarder;
3029 cricket::FakeFrameSource frame_source(1280, 720,
3030 rtc::kNumMicrosecsPerSec / 30);
3031 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003032 EXPECT_TRUE(channel_->SetSend(true));
3033
Niels Möller805a27e2019-01-21 12:21:27 +01003034 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003035 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3036 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3037
perkj26091b12016-09-01 01:17:40 -07003038 webrtc::VideoEncoderConfig encoder_config =
3039 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003040
3041 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003042 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003043 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003044 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003045
3046 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3047 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003048 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003049 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003050 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003051
Niels Möllerff40b142018-04-09 08:49:14 +02003052 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003053}
3054
eladalonf1841382017-06-12 01:16:46 -07003055TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003056 FakeVideoSendStream* stream = AddSendStream();
3057 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3058}
3059
eladalonf1841382017-06-12 01:16:46 -07003060TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003061 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003062 media_config.video.suspend_below_min_bitrate = true;
3063
Sebastian Jansson84848f22018-11-16 10:40:36 +01003064 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003065 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3066 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003067 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003068
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003069 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003070
3071 FakeVideoSendStream* stream = AddSendStream();
3072 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3073
nisse0db023a2016-03-01 04:29:59 -08003074 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003075 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003076 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3077 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003078 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003079
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003080 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003081
nisse0db023a2016-03-01 04:29:59 -08003082 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003083 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3084}
3085
eladalonf1841382017-06-12 01:16:46 -07003086TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003087 FakeVideoSendStream* stream = AddSendStream();
3088 webrtc::VideoCodecVP8 vp8_settings;
3089 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3090 EXPECT_TRUE(vp8_settings.denoisingOn);
3091}
3092
eladalonf1841382017-06-12 01:16:46 -07003093TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003094 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003095 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003096 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003097
Peter Boström2feafdb2015-09-09 14:32:14 +02003098 // Single-stream settings should apply with RTX as well (verifies that we
3099 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3100 // both RTX and regular SSRCs).
3101 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003102
Niels Möller805a27e2019-01-21 12:21:27 +01003103 webrtc::test::FrameForwarder frame_forwarder;
3104 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003105 channel_->SetSend(true);
3106
Niels Möller805a27e2019-01-21 12:21:27 +01003107 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003108
pbos4cba4eb2015-10-26 11:18:18 -07003109 webrtc::VideoCodecVP8 vp8_settings;
3110 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3111 EXPECT_TRUE(vp8_settings.denoisingOn)
3112 << "VP8 denoising should be on by default.";
3113
Niels Möller805a27e2019-01-21 12:21:27 +01003114 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003115
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003116 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3117 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003118 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3119 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003120
Niels Möller805a27e2019-01-21 12:21:27 +01003121 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003122
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003123 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3124 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003125 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3126 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3127
Niels Möllerff40b142018-04-09 08:49:14 +02003128 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003129 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003130 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003131 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003132 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003133
Mirko Bonadeif859e552018-05-30 15:31:29 +02003134 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003135 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3136 // Autmatic resize off when using simulcast.
3137 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3138 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3139
Florent Castelli66b38602019-07-10 16:57:57 +02003140 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003141 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003142 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003143 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003144
Niels Möller805a27e2019-01-21 12:21:27 +01003145 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003146
Florent Castelli66b38602019-07-10 16:57:57 +02003147 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003148 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3149 EXPECT_FALSE(vp8_settings.denoisingOn);
3150 // Resizing and frame dropping always off for screen sharing.
3151 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3152 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3153
Niels Möller805a27e2019-01-21 12:21:27 +01003154 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003155
3156 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3157 EXPECT_FALSE(vp8_settings.denoisingOn);
3158 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3159 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3160
Niels Möllerff40b142018-04-09 08:49:14 +02003161 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003162}
3163
deadbeef119760a2016-04-04 11:43:27 -07003164// Test that setting the same options doesn't result in the encoder being
3165// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003166TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003167 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003168 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003169
perkjfa10b552016-10-02 23:45:26 -07003170 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003171 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003172 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003173 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3174 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3175
Niels Möller805a27e2019-01-21 12:21:27 +01003176 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3177 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3178 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003179 // Expect 1 reconfigurations at this point from the initial configuration.
3180 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003181
3182 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003183 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003184 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3185
3186 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003187 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003188 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003189 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3190
Niels Möllerff40b142018-04-09 08:49:14 +02003191 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003192}
3193
eladalonf1841382017-06-12 01:16:46 -07003194class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003195 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003196 Vp9SettingsTest() : Vp9SettingsTest("") {}
3197 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003198 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003199 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003200 }
3201 virtual ~Vp9SettingsTest() {}
3202
3203 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003204 void TearDown() override {
3205 // Remove references to encoder_factory_ since this will be destroyed
3206 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003207 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003208 }
Erik Språng143cec12015-04-28 10:01:41 +02003209};
3210
3211TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003212 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003213 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003214 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003215
Peter Boström2feafdb2015-09-09 14:32:14 +02003216 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003217
Niels Möller805a27e2019-01-21 12:21:27 +01003218 webrtc::test::FrameForwarder frame_forwarder;
3219 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003220 channel_->SetSend(true);
3221
Niels Möller805a27e2019-01-21 12:21:27 +01003222 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003223
pbos4cba4eb2015-10-26 11:18:18 -07003224 webrtc::VideoCodecVP9 vp9_settings;
3225 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003226 EXPECT_TRUE(vp9_settings.denoisingOn)
3227 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003228
Niels Möller805a27e2019-01-21 12:21:27 +01003229 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003230
Erik Språng143cec12015-04-28 10:01:41 +02003231 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3232 EXPECT_FALSE(vp9_settings.denoisingOn);
3233 // Frame dropping always on for real time video.
3234 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3235
Niels Möller805a27e2019-01-21 12:21:27 +01003236 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003237
3238 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3239 EXPECT_TRUE(vp9_settings.denoisingOn);
3240 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3241
3242 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003243 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003244 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003245 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003246
Niels Möller805a27e2019-01-21 12:21:27 +01003247 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003248
3249 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3250 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003251 // Frame dropping always on for screen sharing.
3252 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003253
Niels Möller805a27e2019-01-21 12:21:27 +01003254 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003255
3256 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3257 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003258 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003259
Niels Möllerff40b142018-04-09 08:49:14 +02003260 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003261}
3262
Sergey Silkinf18072e2018-03-14 10:35:35 +01003263TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3264 cricket::VideoSendParameters parameters;
3265 parameters.codecs.push_back(GetEngineCodec("VP9"));
3266 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3267
3268 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3269
3270 FakeVideoSendStream* stream =
3271 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3272
3273 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003274
Niels Möller805a27e2019-01-21 12:21:27 +01003275 webrtc::test::FrameForwarder frame_forwarder;
3276 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003277 channel_->SetSend(true);
3278
Niels Möller805a27e2019-01-21 12:21:27 +01003279 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003280
3281 webrtc::VideoCodecVP9 vp9_settings;
3282 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3283
3284 const size_t kNumSpatialLayers = ssrcs.size();
3285 const size_t kNumTemporalLayers = 3;
3286 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3287 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3288
Niels Möllerff40b142018-04-09 08:49:14 +02003289 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003290}
3291
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003292TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3293 cricket::VideoSendParameters parameters;
3294 parameters.codecs.push_back(GetEngineCodec("VP9"));
3295 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3296
3297 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3298
3299 FakeVideoSendStream* stream =
3300 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3301
3302 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3303
3304 // Despite 3 ssrcs provided, single layer is used.
3305 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3306
3307 webrtc::test::FrameForwarder frame_forwarder;
3308 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3309 channel_->SetSend(true);
3310
3311 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3312
3313 webrtc::VideoCodecVP9 vp9_settings;
3314 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3315
3316 const size_t kNumSpatialLayers = ssrcs.size();
3317 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3318
3319 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3320}
3321
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003322TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3323 cricket::VideoSendParameters send_parameters;
3324 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3325 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3326
3327 const size_t kNumSpatialLayers = 3;
3328 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3329
3330 FakeVideoSendStream* stream =
3331 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3332
3333 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3334 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3335 ASSERT_TRUE(parameters.encodings[0].active);
3336 ASSERT_TRUE(parameters.encodings[1].active);
3337 ASSERT_TRUE(parameters.encodings[2].active);
3338 // Invert value to verify copying.
3339 parameters.encodings[1].active = false;
3340 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3341
3342 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3343
3344 // number_of_streams should be 1 since all spatial layers are sent on the
3345 // same SSRC. But encoding parameters of all layers is supposed to be copied
3346 // and stored in simulcast_layers[].
3347 EXPECT_EQ(1u, encoder_config.number_of_streams);
3348 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3349 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3350 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3351 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3352}
3353
Sergey Silkincf267052019-04-09 11:40:09 +02003354class Vp9SettingsTestWithFieldTrial
3355 : public Vp9SettingsTest,
3356 public ::testing::WithParamInterface<
3357 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003358 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003359 Vp9SettingsTestWithFieldTrial()
3360 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3361 num_spatial_layers_(::testing::get<1>(GetParam())),
3362 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003363 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003364
3365 void VerifySettings(int num_spatial_layers,
3366 int num_temporal_layers,
3367 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003368 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003369 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003370 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3371
3372 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3373
Niels Möller805a27e2019-01-21 12:21:27 +01003374 webrtc::test::FrameForwarder frame_forwarder;
3375 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003376 channel_->SetSend(true);
3377
Niels Möller805a27e2019-01-21 12:21:27 +01003378 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003379
3380 webrtc::VideoCodecVP9 vp9_settings;
3381 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3382 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3383 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003384 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003385
Niels Möllerff40b142018-04-09 08:49:14 +02003386 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003387 }
Sergey Silkincf267052019-04-09 11:40:09 +02003388
3389 const uint8_t num_spatial_layers_;
3390 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003391 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003392};
3393
Sergey Silkincf267052019-04-09 11:40:09 +02003394TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003395 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3396 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003397}
3398
Sergey Silkincf267052019-04-09 11:40:09 +02003399INSTANTIATE_TEST_SUITE_P(
3400 ,
3401 Vp9SettingsTestWithFieldTrial,
3402 ::testing::Values(
3403 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3404 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3405 1,
3406 1,
3407 webrtc::InterLayerPredMode::kOnKeyPic),
3408 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3409 2,
3410 3,
3411 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003412 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003413 1,
3414 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003415 webrtc::InterLayerPredMode::kOnKeyPic),
3416 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003417 1,
3418 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003419 webrtc::InterLayerPredMode::kOnKeyPic),
3420 std::make_tuple(
3421 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3422 1,
3423 1,
3424 webrtc::InterLayerPredMode::kOff),
3425 std::make_tuple(
3426 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3427 1,
3428 1,
3429 webrtc::InterLayerPredMode::kOn),
3430 std::make_tuple(
3431 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3432 1,
3433 1,
3434 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003435
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003436TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3437 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3438 ASSERT_EQ(1u, streams.size());
3439 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3440}
3441
3442TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003443 RTC_DCHECK(!override_field_trials_);
3444 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003445 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3446 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3447 ASSERT_EQ(1u, streams.size());
3448 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3449}
3450
asapersson3c81a1a2017-06-14 05:52:21 -07003451TEST_F(WebRtcVideoChannelTest,
3452 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003453 RTC_DCHECK(!override_field_trials_);
3454 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003455 "WebRTC-Video-BalancedDegradation/Disabled/");
3456 const bool kResolutionScalingEnabled = true;
3457 const bool kFpsScalingEnabled = false;
3458 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3459}
3460
3461TEST_F(WebRtcVideoChannelTest,
3462 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003463 RTC_DCHECK(!override_field_trials_);
3464 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003465 "WebRTC-Video-BalancedDegradation/Enabled/");
3466 const bool kResolutionScalingEnabled = true;
3467 const bool kFpsScalingEnabled = true;
3468 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3469}
3470
eladalonf1841382017-06-12 01:16:46 -07003471TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003472 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003473}
3474
eladalonf1841382017-06-12 01:16:46 -07003475TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003476 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003477}
3478
Niels Möller3de32e62019-01-18 08:42:18 +01003479TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3480 TestCpuAdaptation(false, true);
3481}
3482
eladalonf1841382017-06-12 01:16:46 -07003483TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003484 TestCpuAdaptation(true, true);
3485}
3486
eladalonf1841382017-06-12 01:16:46 -07003487TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003488 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003489 cricket::VideoSendParameters parameters;
3490 parameters.codecs.push_back(codec);
3491
kthelgason2bc68642017-02-07 07:02:22 -08003492 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003493 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003494 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003495 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3496 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003497 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003498 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3499
3500 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003501 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003502
Per766ad3b2016-04-05 15:23:49 +02003503 ASSERT_TRUE(channel_->SetSend(true));
3504 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003505 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003506 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003507
3508 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3509 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003510
Niels Möllerdcc70292019-01-15 16:32:38 +01003511 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3512 // Dont' expect anything on framerate_scaling_enabled, since the default is
3513 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003514
Niels Möllerdcc70292019-01-15 16:32:38 +01003515 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003516 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003517 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003518 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003519 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3520 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003521 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003522
Niels Möllerdcc70292019-01-15 16:32:38 +01003523 // Switch back to the normal capturer. Expect resolution scaling to be
3524 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003525 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3526 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003527 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3528 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003529 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003530
Niels Möllerff40b142018-04-09 08:49:14 +02003531 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003532}
3533
asapersson3c81a1a2017-06-14 05:52:21 -07003534// TODO(asapersson): Remove this test when the balanced field trial is removed.
3535void WebRtcVideoChannelTest::TestDegradationPreference(
3536 bool resolution_scaling_enabled,
3537 bool fps_scaling_enabled) {
3538 cricket::VideoCodec codec = GetEngineCodec("VP8");
3539 cricket::VideoSendParameters parameters;
3540 parameters.codecs.push_back(codec);
3541
3542 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003543 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003544 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003545 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3546 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003547 channel_->OnReadyToSend(true);
3548
3549 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3550
3551 AddSendStream();
3552
Niels Möller805a27e2019-01-21 12:21:27 +01003553 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003554 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003555 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003556
3557 EXPECT_TRUE(channel_->SetSend(true));
3558
3559 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3560 EXPECT_EQ(resolution_scaling_enabled,
3561 send_stream->resolution_scaling_enabled());
3562 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3563
Niels Möllerff40b142018-04-09 08:49:14 +02003564 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003565}
3566
eladalonf1841382017-06-12 01:16:46 -07003567void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3568 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003569 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003570 cricket::VideoSendParameters parameters;
3571 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003572
kthelgason2bc68642017-02-07 07:02:22 -08003573 MediaConfig media_config = GetMediaConfig();
3574 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003575 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003576 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003577 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003578 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3579 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003580 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003581
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003582 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003583
3584 AddSendStream();
3585
Niels Möller805a27e2019-01-21 12:21:27 +01003586 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003587 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003588 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003589 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003590
3591 EXPECT_TRUE(channel_->SetSend(true));
3592
solenberge5269742015-09-08 05:13:22 -07003593 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003594
sprangc5d62e22017-04-02 23:53:04 -07003595 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003596 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003597 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003598 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003599 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3600 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3601 } else {
3602 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3603 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3604 }
Niels Möllerff40b142018-04-09 08:49:14 +02003605 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003606}
3607
eladalonf1841382017-06-12 01:16:46 -07003608TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003609 // Start at last timestamp to verify that wraparounds are estimated correctly.
3610 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3611 static const int64_t kInitialNtpTimeMs = 1247891230;
3612 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003613 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003614
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003615 FakeVideoReceiveStream* stream = AddRecvStream();
3616 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003617 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003618
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003619 webrtc::VideoFrame video_frame =
3620 webrtc::VideoFrame::Builder()
3621 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3622 .set_timestamp_rtp(kInitialTimestamp)
3623 .set_timestamp_us(0)
3624 .set_rotation(webrtc::kVideoRotation_0)
3625 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003626 // Initial NTP time is not available on the first frame, but should still be
3627 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003628 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003629
3630 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003631
3632 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3633 // triggers a constant-overflow warning, hence we're calculating it explicitly
3634 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003635 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003636 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3637 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003638 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003639
3640 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003641
3642 // Verify that NTP time has been correctly deduced.
3643 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003644 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003645 ASSERT_EQ(1u, info.receivers.size());
3646 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003647}
3648
eladalonf1841382017-06-12 01:16:46 -07003649TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003650 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003651 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003652
3653 VideoCodec codec;
3654 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003655 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003656
3657 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003658 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3659 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003660 FakeVideoSendStream* stream = AddSendStream(
3661 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003662 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003663
3664 // Make sure NACK and FEC are enabled on the correct payload types.
3665 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003666 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3667 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003668
3669 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3670 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003671 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003672 // TODO(juberti): Check RTCP, PLI, TMMBR.
3673}
3674
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003675TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3676 cricket::VideoSendParameters parameters;
3677 parameters.codecs.push_back(GetEngineCodec("VP8"));
3678 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3679
3680 FakeVideoSendStream* stream = AddSendStream();
3681 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3682 EXPECT_FALSE(config.rtp.raw_payload);
3683}
3684
3685TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3686 cricket::VideoSendParameters parameters;
3687 parameters.codecs.push_back(GetEngineCodec("VP8"));
3688 parameters.codecs.back().packetization = kPacketizationParamRaw;
3689 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3690
3691 FakeVideoSendStream* stream = AddSendStream();
3692 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3693 EXPECT_TRUE(config.rtp.raw_payload);
3694}
3695
brandtr31bd2242017-05-19 05:47:46 -07003696// The following four tests ensures that FlexFEC is not activated by default
3697// when the field trials are not enabled.
3698// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3699// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003700TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003701 FakeVideoSendStream* stream = AddSendStream();
3702 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3703
brandtr3d200bd2017-01-16 06:59:19 -08003704 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003705 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3706 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003707}
3708
eladalonf1841382017-06-12 01:16:46 -07003709TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003710 FakeVideoSendStream* stream = AddSendStream(
3711 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3712 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3713
brandtr3d200bd2017-01-16 06:59:19 -08003714 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003715 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3716 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3717}
3718
Yves Gerey665174f2018-06-19 15:03:05 +02003719TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003720 AddRecvStream();
3721
3722 const std::vector<FakeFlexfecReceiveStream*>& streams =
3723 fake_call_->GetFlexfecReceiveStreams();
3724 EXPECT_TRUE(streams.empty());
3725}
3726
eladalonf1841382017-06-12 01:16:46 -07003727TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003728 AddRecvStream(
3729 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3730
3731 const std::vector<FakeFlexfecReceiveStream*>& streams =
3732 fake_call_->GetFlexfecReceiveStreams();
3733 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003734}
3735
3736// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3737// tests that use this test fixture into the corresponding "non-field trial"
3738// tests.
eladalonf1841382017-06-12 01:16:46 -07003739class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003740 public:
eladalonf1841382017-06-12 01:16:46 -07003741 WebRtcVideoChannelFlexfecRecvTest()
3742 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003743};
3744
eladalonf1841382017-06-12 01:16:46 -07003745TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003746 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3747 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3748 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3749}
3750
eladalonf1841382017-06-12 01:16:46 -07003751TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003752 AddRecvStream();
3753
3754 const std::vector<FakeFlexfecReceiveStream*>& streams =
3755 fake_call_->GetFlexfecReceiveStreams();
3756 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003757
3758 const std::vector<FakeVideoReceiveStream*>& video_streams =
3759 fake_call_->GetVideoReceiveStreams();
3760 ASSERT_EQ(1U, video_streams.size());
3761 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3762 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3763 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003764}
3765
eladalonf1841382017-06-12 01:16:46 -07003766TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003767 AddRecvStream(
3768 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3769
3770 const std::vector<FakeFlexfecReceiveStream*>& streams =
3771 fake_call_->GetFlexfecReceiveStreams();
3772 ASSERT_EQ(1U, streams.size());
3773 const FakeFlexfecReceiveStream* stream = streams.front();
3774 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3775 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3776 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3777 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3778 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003779
3780 const std::vector<FakeVideoReceiveStream*>& video_streams =
3781 fake_call_->GetVideoReceiveStreams();
3782 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003783 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3784 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003785 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003786 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003787 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003788}
3789
eladalonf1841382017-06-12 01:16:46 -07003790TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003791 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3792 cricket::VideoRecvParameters recv_parameters;
3793 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3794 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3795
3796 AddRecvStream(
3797 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3798 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003799 const std::vector<FakeVideoReceiveStream*>& video_streams =
3800 fake_call_->GetVideoReceiveStreams();
3801 ASSERT_EQ(1U, video_streams.size());
3802 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3803 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3804 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003805
3806 // Enable FlexFEC.
3807 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3808 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3809 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3810 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3811 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3812 << "Enabling FlexFEC should not create VideoReceiveStream.";
3813 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3814 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003815 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3816 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003817}
3818
eladalonf1841382017-06-12 01:16:46 -07003819TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003820 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3821 cricket::VideoRecvParameters recv_parameters;
3822 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3823 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3824 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3825
3826 AddRecvStream(
3827 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3828 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003829 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003830 const std::vector<FakeVideoReceiveStream*>& video_streams =
3831 fake_call_->GetVideoReceiveStreams();
3832 ASSERT_EQ(1U, video_streams.size());
3833 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3834 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3835 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003836
3837 // Disable FlexFEC.
3838 recv_parameters.codecs.clear();
3839 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3840 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3841 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3842 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3843 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3844 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3845 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3846 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003847 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3848 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003849}
3850
brandtr31bd2242017-05-19 05:47:46 -07003851// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3852// tests that use this test fixture into the corresponding "non-field trial"
3853// tests.
eladalonf1841382017-06-12 01:16:46 -07003854class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003855 public:
eladalonf1841382017-06-12 01:16:46 -07003856 WebRtcVideoChannelFlexfecSendRecvTest()
3857 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003858 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3859 }
3860};
3861
Yves Gerey665174f2018-06-19 15:03:05 +02003862TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003863 FakeVideoSendStream* stream = AddSendStream();
3864 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3865
brandtr3d200bd2017-01-16 06:59:19 -08003866 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3867 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3868 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003869}
3870
eladalonf1841382017-06-12 01:16:46 -07003871TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003872 FakeVideoSendStream* stream = AddSendStream(
3873 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3874 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3875
brandtr3d200bd2017-01-16 06:59:19 -08003876 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3877 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3878 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3879 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003880}
3881
eladalonf1841382017-06-12 01:16:46 -07003882TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003883 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003884 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003885 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003886
3887 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003888 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003889
brandtrb5f2c3f2016-10-04 23:28:39 -07003890 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3891 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003892}
3893
eladalonf1841382017-06-12 01:16:46 -07003894TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003895 cricket::VideoSendParameters parameters;
3896 parameters.codecs.push_back(GetEngineCodec("VP8"));
3897 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3898
3899 FakeVideoSendStream* stream = AddSendStream();
3900 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3901
brandtr3d200bd2017-01-16 06:59:19 -08003902 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003903}
3904
eladalonf1841382017-06-12 01:16:46 -07003905TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003906 AddRecvStream(
3907 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003908
3909 cricket::VideoRecvParameters recv_parameters;
3910 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3911 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3912 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003913
3914 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3915 fake_call_->GetFlexfecReceiveStreams();
3916 ASSERT_EQ(1U, flexfec_streams.size());
3917 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3918 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3919 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003920 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003921 flexfec_stream_config.payload_type);
3922 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3923 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3924 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3925 const std::vector<FakeVideoReceiveStream*>& video_streams =
3926 fake_call_->GetVideoReceiveStreams();
3927 const FakeVideoReceiveStream* video_stream = video_streams.front();
3928 const webrtc::VideoReceiveStream::Config& video_stream_config =
3929 video_stream->GetConfig();
3930 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3931 flexfec_stream_config.local_ssrc);
3932 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3933 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3934 flexfec_stream_config.rtcp_send_transport);
3935 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3936 // spec-compliant way.
3937 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3938 flexfec_stream_config.transport_cc);
3939 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3940 EXPECT_EQ(video_stream_config.rtp.extensions,
3941 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003942}
3943
brandtr31bd2242017-05-19 05:47:46 -07003944// We should not send FlexFEC, even if we advertise it, unless the right
3945// field trial is set.
3946// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003947TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003948 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3949 cricket::VideoSendParameters parameters;
3950 parameters.codecs.push_back(GetEngineCodec("VP8"));
3951 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3952 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3953
3954 FakeVideoSendStream* stream = AddSendStream();
3955 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3956
3957 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003958 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003959 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3960}
3961
eladalonf1841382017-06-12 01:16:46 -07003962TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003963 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3964 cricket::VideoSendParameters parameters;
3965 parameters.codecs.push_back(GetEngineCodec("VP8"));
3966 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3967 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3968
3969 FakeVideoSendStream* stream = AddSendStream(
3970 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3971 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3972
3973 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003974 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003975 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3976}
3977
eladalonf1841382017-06-12 01:16:46 -07003978TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003979 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003980 const int kUnusedPayloadType = 127;
3981 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3982
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003983 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003984 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003985 parameters.codecs.push_back(rtx_codec);
3986 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003987 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003988}
3989
eladalonf1841382017-06-12 01:16:46 -07003990TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003991 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003992 const int kUnusedPayloadType1 = 126;
3993 const int kUnusedPayloadType2 = 127;
3994 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3995 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3996 {
3997 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3998 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3999 cricket::VideoSendParameters parameters;
4000 parameters.codecs.push_back(GetEngineCodec("VP8"));
4001 parameters.codecs.push_back(rtx_codec);
4002 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4003 }
4004 {
4005 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4006 kUnusedPayloadType1, kUnusedPayloadType2);
4007 cricket::VideoSendParameters parameters;
4008 parameters.codecs.push_back(GetEngineCodec("VP8"));
4009 parameters.codecs.push_back(rtx_codec);
4010 EXPECT_FALSE(channel_->SetSendParameters(parameters))
4011 << "RTX without matching video codec should be rejected.";
4012 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004013}
4014
eladalonf1841382017-06-12 01:16:46 -07004015TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004016 const int kUnusedPayloadType1 = 126;
4017 const int kUnusedPayloadType2 = 127;
4018 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4019 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4020
4021 // SSRCs for RTX.
4022 cricket::StreamParams params =
4023 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4024 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4025 AddSendStream(params);
4026
4027 // Original payload type for RTX.
4028 cricket::VideoSendParameters parameters;
4029 parameters.codecs.push_back(GetEngineCodec("VP8"));
4030 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4031 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4032 parameters.codecs.push_back(rtx_codec);
4033 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4034 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4035 const webrtc::VideoSendStream::Config& config_before =
4036 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4037 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4038 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4039 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4040
4041 // Change payload type for RTX.
4042 parameters.codecs[1].id = kUnusedPayloadType2;
4043 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4044 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4045 const webrtc::VideoSendStream::Config& config_after =
4046 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4047 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4048 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4049 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4050}
4051
eladalonf1841382017-06-12 01:16:46 -07004052TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004053 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004054 parameters.codecs.push_back(GetEngineCodec("VP8"));
4055 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004056 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004057
4058 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004059 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004060
magjed509e4fe2016-11-18 01:34:11 -08004061 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004062
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004063 parameters.codecs.pop_back();
4064 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004065 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004066 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004067 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004068 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004069 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4070}
4071
eladalonf1841382017-06-12 01:16:46 -07004072TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004073 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004074 cricket::VideoSendParameters parameters;
4075 parameters.codecs.push_back(GetEngineCodec("VP8"));
4076 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4077 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4078
4079 FakeVideoSendStream* stream = AddSendStream(
4080 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4081 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4082
brandtr3d200bd2017-01-16 06:59:19 -08004083 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4084 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004085 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4086 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4087
4088 parameters.codecs.pop_back();
4089 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4090 stream = fake_call_->GetVideoSendStreams()[0];
4091 ASSERT_TRUE(stream != nullptr);
4092 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004093 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004094 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004095}
4096
eladalonf1841382017-06-12 01:16:46 -07004097TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004098 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004099 cricket::VideoCodec codec(100, "VP8");
4100 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4101 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004102
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004103 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004104 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004105
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004106 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004107 webrtc::test::FrameForwarder frame_forwarder;
4108 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004109
4110 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004111 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004112
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004113 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004114 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4115 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004116 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004117 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004118 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004119 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004120}
4121
eladalonf1841382017-06-12 01:16:46 -07004122TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004123 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4124 200000);
4125}
4126
eladalonf1841382017-06-12 01:16:46 -07004127TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004128 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4129 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4130 ASSERT_EQ(1u, streams.size());
4131 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4132}
4133
eladalonf1841382017-06-12 01:16:46 -07004134TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004135 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004136 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004137}
4138
eladalonf1841382017-06-12 01:16:46 -07004139TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004140 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004141}
4142
eladalonf1841382017-06-12 01:16:46 -07004143TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004144 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4145 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4146 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004147}
4148
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004149// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4150// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004151TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004152 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4153 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4154 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4155 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004156 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004157 ExpectSetBitrateParameters(100000, 200000, 400000);
4158 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4159 // Since the codec isn't changing, start_bitrate_bps should be -1.
4160 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004161
4162 // Decrease max_bandwidth_bps.
4163 send_parameters_.max_bandwidth_bps = 350000;
4164 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004165
4166 // Now try again with the values flipped around.
4167 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4168 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004169 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004170 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004171
4172 // If we change the codec max, max_bandwidth_bps should still apply.
4173 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004174 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004175 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004176}
4177
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004178// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4179// are present in the same send parameters, the settings are combined correctly.
4180TEST_F(WebRtcVideoChannelTest,
4181 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4182 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4183 // Transport.
4184 webrtc::MediaTransportSettings settings;
4185 settings.is_caller = true;
4186 webrtc::FakeMediaTransport fake_media_transport(settings);
4187 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4188 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004189 channel_->SetInterface(network_interface.get(),
4190 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004191
4192 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4193 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4194 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4195 send_parameters_.max_bandwidth_bps = 400000;
4196 {
4197 // We expect max_bandwidth_bps to take priority, if set.
4198 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4199 ASSERT_EQ(1u,
4200 fake_media_transport.target_rate_constraints_in_order().size());
4201 const webrtc::MediaTransportTargetRateConstraints& constraint =
4202 fake_media_transport.target_rate_constraints_in_order()[0];
4203 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4204 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4205 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4206 }
4207
4208 {
4209 // Decrease max_bandwidth_bps.
4210 send_parameters_.max_bandwidth_bps = 350000;
4211 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4212 ASSERT_EQ(2u,
4213 fake_media_transport.target_rate_constraints_in_order().size());
4214 const webrtc::MediaTransportTargetRateConstraints& constraint =
4215 fake_media_transport.target_rate_constraints_in_order()[1];
4216
4217 // Since the codec isn't changing, start_bitrate_bps should be 0.
4218 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4219 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4220 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4221 }
4222
4223 {
4224 // Now try again with the values flipped around.
4225 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4226 send_parameters_.max_bandwidth_bps = 300000;
4227 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4228 ASSERT_EQ(3u,
4229 fake_media_transport.target_rate_constraints_in_order().size());
4230 const webrtc::MediaTransportTargetRateConstraints& constraint =
4231 fake_media_transport.target_rate_constraints_in_order()[2];
4232
4233 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4234 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4235 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4236 }
4237
4238 {
4239 // Now try again with the values flipped around.
4240 // If we change the codec max, max_bandwidth_bps should still apply.
4241 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4242 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4243 ASSERT_EQ(4u,
4244 fake_media_transport.target_rate_constraints_in_order().size());
4245 const webrtc::MediaTransportTargetRateConstraints& constraint =
4246 fake_media_transport.target_rate_constraints_in_order()[3];
4247
4248 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4249 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4250 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4251 }
4252}
4253
Yves Gerey665174f2018-06-19 15:03:05 +02004254TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004255 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4256 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004257 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004258 // Setting max bitrate should keep previous min bitrate.
4259 // Setting max bitrate should not reset start bitrate.
4260 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004261 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004262}
4263
eladalonf1841382017-06-12 01:16:46 -07004264TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004265 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004266 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004267 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004268 // -1 means to disable max bitrate (set infinite).
4269 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004270 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004271 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004272}
4273
eladalonf1841382017-06-12 01:16:46 -07004274TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004275 send_parameters_.max_bandwidth_bps = 99999;
4276 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004277 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004278 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004279 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4280 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4281 stream->GetVideoStreams()[0].max_bitrate_bps);
4282
4283 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004284 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004285 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4286 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004287 stream->GetVideoStreams()[0].max_bitrate_bps);
4288}
4289
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004290// Tests that when the codec specific max bitrate and VideoSendParameters
4291// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4292// appropriately.
4293TEST_F(WebRtcVideoChannelTest,
4294 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4295 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4296 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4297 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4298 send_parameters_.max_bandwidth_bps = -1;
4299 AddSendStream();
4300 ExpectSetMaxBitrate(300000);
4301 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4302
4303 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4304 ASSERT_EQ(1u, video_send_streams.size());
4305 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4306 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4307 // First the max bitrate is set based upon the codec param.
4308 EXPECT_EQ(300000,
4309 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4310
4311 // The VideoSendParameters max bitrate overrides the codec's.
4312 send_parameters_.max_bandwidth_bps = 500000;
4313 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4314 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4315 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4316 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4317}
4318
4319// Tests that when the codec specific max bitrate and RtpParameters
4320// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4321// appropriately.
4322TEST_F(WebRtcVideoChannelTest,
4323 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4324 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4325 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4326 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4327 send_parameters_.max_bandwidth_bps = -1;
4328 AddSendStream();
4329 ExpectSetMaxBitrate(300000);
4330 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4331
4332 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4333 ASSERT_EQ(1u, video_send_streams.size());
4334 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4335 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4336 // First the max bitrate is set based upon the codec param.
4337 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4338
4339 // The RtpParameter max bitrate overrides the codec's.
4340 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4341 ASSERT_EQ(1u, parameters.encodings.size());
4342 parameters.encodings[0].max_bitrate_bps = 500000;
4343 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4344 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4345 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4346 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4347}
4348
Åsa Persson55659812018-06-18 17:51:32 +02004349TEST_F(WebRtcVideoChannelTest,
4350 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4351 send_parameters_.max_bandwidth_bps = 99999;
4352 FakeVideoSendStream* stream = AddSendStream();
4353 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4354 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4355 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4356 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4357 stream->GetVideoStreams()[0].max_bitrate_bps);
4358
4359 // Get and set the rtp encoding parameters.
4360 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4361 EXPECT_EQ(1u, parameters.encodings.size());
4362
4363 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4364 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4365 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4366 stream->GetVideoStreams()[0].max_bitrate_bps);
4367
4368 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4369 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4370 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4371 stream->GetVideoStreams()[0].max_bitrate_bps);
4372}
4373
eladalonf1841382017-06-12 01:16:46 -07004374TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004375 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004376 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004377 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004378 channel_->SetSend(true);
4379
4380 FakeVideoSendStream* stream = AddSendStream();
4381
Niels Möller805a27e2019-01-21 12:21:27 +01004382 webrtc::test::FrameForwarder frame_forwarder;
4383 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004384
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004385 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4386 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4387 EXPECT_GT(initial_max_bitrate_bps, 0);
4388
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004389 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4390 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004391 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004392 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004393 streams = stream->GetVideoStreams();
4394 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004395 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004396}
4397
eladalonf1841382017-06-12 01:16:46 -07004398TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004399 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004400 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004401 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004402 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004403 channel_->SetSend(true);
4404
4405 FakeVideoSendStream* stream = AddSendStream(
4406 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4407
4408 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004409 webrtc::test::FrameForwarder frame_forwarder;
4410 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4411 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004412
4413 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4414 ASSERT_GT(streams.size(), 1u)
4415 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004416 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004417 EXPECT_GT(initial_max_bitrate_bps, 0);
4418
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004419 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4420 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004421 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004422 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004423 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004424 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004425 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4426
Niels Möllerff40b142018-04-09 08:49:14 +02004427 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004428}
4429
eladalonf1841382017-06-12 01:16:46 -07004430TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004431 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004432 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004433 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004434 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4435 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004436 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004437 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004438
4439 VideoCodec codec;
4440 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4441 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4442}
4443
eladalonf1841382017-06-12 01:16:46 -07004444TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004445 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004446 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004447 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004448 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004449 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004450 parameters.codecs[0].id = kIncorrectPayloads[i];
4451 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004452 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004453 }
4454}
4455
eladalonf1841382017-06-12 01:16:46 -07004456TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004457 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004458 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004459 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004460 parameters.codecs[0].id = payload_type;
4461 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004462 << "Payload type '" << payload_type << "' rejected.";
4463 }
4464}
4465
deadbeef67cf2c12016-04-13 10:07:16 -07004466// Test that setting the a different set of codecs but with an identical front
4467// codec doesn't result in the stream being recreated.
4468// This may happen when a subsequent negotiation includes fewer codecs, as a
4469// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004470TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004471 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4472 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004473 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4474 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004475 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4476
4477 AddSendStream();
4478 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4479
4480 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004481 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004482 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4483 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4484}
4485
eladalonf1841382017-06-12 01:16:46 -07004486TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004487 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004488 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004489 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004490}
4491
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004492// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004493TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004494 const int kUnusedPayloadType1 = 126;
4495 const int kUnusedPayloadType2 = 127;
4496 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4497 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4498
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004499 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004500 parameters.codecs.push_back(GetEngineCodec("VP8"));
4501 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004502 parameters.codecs.push_back(rtx_codec);
4503 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004504 << "RTX codec without associated payload should be rejected.";
4505
magjed509e4fe2016-11-18 01:34:11 -08004506 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004507 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004508 << "RTX codec with invalid associated payload type should be rejected.";
4509
magjed509e4fe2016-11-18 01:34:11 -08004510 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004511 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004512
magjed509e4fe2016-11-18 01:34:11 -08004513 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004514 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004515 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004516
Yves Gerey665174f2018-06-19 15:03:05 +02004517 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4518 << "RTX codec with another RTX as associated payload type should be "
4519 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004520}
4521
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004522TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4523 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4524 vp8_codec.packetization = kPacketizationParamRaw;
4525
4526 cricket::VideoRecvParameters parameters;
4527 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4528 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4529
4530 const cricket::StreamParams params =
4531 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4532 AddRecvStream(params);
4533 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4534
4535 const webrtc::VideoReceiveStream::Config& config =
4536 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4537 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4538 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4539}
4540
4541TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4542 cricket::VideoRecvParameters parameters;
4543 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4544 parameters.codecs.back().packetization = kPacketizationParamRaw;
4545 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4546
4547 const cricket::StreamParams params =
4548 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4549 AddRecvStream(params);
4550 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4551 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4552
4553 parameters.codecs.back().packetization.reset();
4554 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4555 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4556}
4557
eladalonf1841382017-06-12 01:16:46 -07004558TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004559 const int kUnusedPayloadType1 = 126;
4560 const int kUnusedPayloadType2 = 127;
4561 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4562 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4563
4564 // SSRCs for RTX.
4565 cricket::StreamParams params =
4566 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4567 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4568 AddRecvStream(params);
4569
4570 // Original payload type for RTX.
4571 cricket::VideoRecvParameters parameters;
4572 parameters.codecs.push_back(GetEngineCodec("VP8"));
4573 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4574 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4575 parameters.codecs.push_back(rtx_codec);
4576 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4577 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4578 const webrtc::VideoReceiveStream::Config& config_before =
4579 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004580 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4581 const int* payload_type_before = FindKeyByValue(
4582 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4583 ASSERT_NE(payload_type_before, nullptr);
4584 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004585 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4586
4587 // Change payload type for RTX.
4588 parameters.codecs[1].id = kUnusedPayloadType2;
4589 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4590 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4591 const webrtc::VideoReceiveStream::Config& config_after =
4592 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004593 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4594 const int* payload_type_after = FindKeyByValue(
4595 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4596 ASSERT_NE(payload_type_after, nullptr);
4597 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004598 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4599}
4600
eladalonf1841382017-06-12 01:16:46 -07004601TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004602 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004603 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004604 parameters.codecs[0].id = 99;
4605 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004606}
4607
eladalonf1841382017-06-12 01:16:46 -07004608TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004609 cricket::VideoRecvParameters parameters;
4610 parameters.codecs = engine_.codecs();
4611 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004612
4613 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004614 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004615 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004616 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004617}
4618
eladalonf1841382017-06-12 01:16:46 -07004619TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004620 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004621 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004622 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004623 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004624}
4625
eladalonf1841382017-06-12 01:16:46 -07004626TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004627 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004628 parameters.codecs.push_back(GetEngineCodec("VP8"));
4629 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004630 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004631}
4632
eladalonf1841382017-06-12 01:16:46 -07004633TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004634 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004635 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4636 send_parameters.codecs.push_back(GetEngineCodec("red"));
4637 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004638 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004639
4640 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004641
magjed509e4fe2016-11-18 01:34:11 -08004642 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004643 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004644
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004645 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004646 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004647 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004648 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004649 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004650 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004651 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4652}
4653
eladalonf1841382017-06-12 01:16:46 -07004654TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004655 AddRecvStream(
4656 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004657 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004658 fake_call_->GetFlexfecReceiveStreams();
4659
4660 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004661 const FakeFlexfecReceiveStream* stream = streams.front();
4662 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4663 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4664 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4665 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004666
4667 cricket::VideoRecvParameters recv_parameters;
4668 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4669 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4670 EXPECT_TRUE(streams.empty())
4671 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004672}
4673
eladalonf1841382017-06-12 01:16:46 -07004674TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004675 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004676 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004677 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004678
4679 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004680 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4681 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4682 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004683 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4684 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004685 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004686 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004687 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004688 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004689
4690 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004691 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4692 send_parameters.codecs.push_back(GetEngineCodec("red"));
4693 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004694 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4695 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004696 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004697 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004698 << "ULPFEC should be enabled on the receive stream.";
4699}
4700
eladalonf1841382017-06-12 01:16:46 -07004701TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004702 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004703 AddRecvStream(
4704 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004705 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004706 fake_call_->GetFlexfecReceiveStreams();
4707
4708 cricket::VideoRecvParameters recv_parameters;
4709 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4710 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4711 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4712 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004713 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004714 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004715 stream_with_recv_params->GetConfig().payload_type);
4716 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004717 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004718 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004719 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004720 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004721
4722 cricket::VideoSendParameters send_parameters;
4723 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4724 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4725 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4726 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004727 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004728 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004729 stream_with_send_params->GetConfig().payload_type);
4730 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004731 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004732 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004733 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004734 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004735}
4736
eladalonf1841382017-06-12 01:16:46 -07004737TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004738 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004739 parameters.codecs.push_back(GetEngineCodec("VP8"));
4740 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004741 parameters.codecs[1].id = parameters.codecs[0].id;
4742 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004743}
4744
eladalonf1841382017-06-12 01:16:46 -07004745TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004746 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004747 cricket::VideoRecvParameters parameters;
4748 parameters.codecs.push_back(GetEngineCodec("VP8"));
4749 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4750 parameters.codecs[1].id = parameters.codecs[0].id;
4751 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4752}
4753
eladalonf1841382017-06-12 01:16:46 -07004754TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004755 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004756 parameters.codecs.push_back(GetEngineCodec("VP8"));
4757 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004758 parameters.codecs[1].id = parameters.codecs[0].id;
4759 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004760}
4761
eladalonf1841382017-06-12 01:16:46 -07004762TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004763 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004764 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004765 parameters.codecs.push_back(GetEngineCodec("VP8"));
4766 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004767 parameters.codecs[1].id += 1;
4768 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004769}
4770
deadbeef67cf2c12016-04-13 10:07:16 -07004771// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004772// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004773TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004774 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004775 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004776 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4777 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004778 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004779
4780 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4781 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4782
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004783 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004784 parameters2.codecs.push_back(GetEngineCodec("red"));
4785 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004786 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004787 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4788}
4789
eladalonf1841382017-06-12 01:16:46 -07004790TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004791 EXPECT_FALSE(AddSendStream()->IsSending());
4792}
4793
eladalonf1841382017-06-12 01:16:46 -07004794TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004795 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004796}
4797
eladalonf1841382017-06-12 01:16:46 -07004798TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004799 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004800 EXPECT_FALSE(stream->IsSending());
4801
4802 // false->true
4803 EXPECT_TRUE(channel_->SetSend(true));
4804 EXPECT_TRUE(stream->IsSending());
4805 // true->true
4806 EXPECT_TRUE(channel_->SetSend(true));
4807 EXPECT_TRUE(stream->IsSending());
4808 // true->false
4809 EXPECT_TRUE(channel_->SetSend(false));
4810 EXPECT_FALSE(stream->IsSending());
4811 // false->false
4812 EXPECT_TRUE(channel_->SetSend(false));
4813 EXPECT_FALSE(stream->IsSending());
4814
4815 EXPECT_TRUE(channel_->SetSend(true));
4816 FakeVideoSendStream* new_stream = AddSendStream();
4817 EXPECT_TRUE(new_stream->IsSending())
4818 << "Send stream created after SetSend(true) not sending initially.";
4819}
4820
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004821// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004822TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004823 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004824 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004825 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004826 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004827 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004828
Sebastian Jansson84848f22018-11-16 10:40:36 +01004829 channel.reset(
4830 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004831 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4832 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004833 channel->SetInterface(network_interface.get(),
4834 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004835 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004836 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004837
Tim Haloun648d28a2018-10-18 16:52:22 -07004838 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4839 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004840 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004841 channel.reset(
4842 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004843 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4844 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004845 channel->SetInterface(network_interface.get(),
4846 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004847 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4848
4849 // Create a send stream to configure
4850 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4851 parameters = channel->GetRtpSendParameters(kSsrc);
4852 ASSERT_FALSE(parameters.encodings.empty());
4853
4854 // Various priorities map to various dscp values.
4855 parameters.encodings[0].network_priority = 4.0;
4856 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004857 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004858 parameters.encodings[0].network_priority = 0.5;
4859 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4860 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4861
4862 // A bad priority does not change the dscp value.
4863 parameters.encodings[0].network_priority = 0.0;
4864 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4865 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004866
Tim Haloun6ca98362018-09-17 17:06:08 -07004867 // Packets should also self-identify their dscp in PacketOptions.
4868 const uint8_t kData[10] = {0};
4869 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4870 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004871 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004872
nisse51542be2016-02-12 02:27:06 -08004873 // Verify that setting the option to false resets the
4874 // DiffServCodePoint.
4875 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004876 channel.reset(
4877 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004878 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4879 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004880 channel->SetInterface(network_interface.get(),
4881 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004882 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004883}
4884
deadbeef13871492015-12-09 12:37:51 -08004885// This test verifies that the RTCP reduced size mode is properly applied to
4886// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004887TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004888 // Create stream, expecting that default mode is "compound".
4889 FakeVideoSendStream* stream1 = AddSendStream();
4890 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004891 webrtc::RtpParameters rtp_parameters =
4892 channel_->GetRtpSendParameters(last_ssrc_);
4893 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004894
4895 // Now enable reduced size mode.
4896 send_parameters_.rtcp.reduced_size = true;
4897 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4898 stream1 = fake_call_->GetVideoSendStreams()[0];
4899 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004900 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4901 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004902
4903 // Create a new stream and ensure it picks up the reduced size mode.
4904 FakeVideoSendStream* stream2 = AddSendStream();
4905 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4906}
4907
4908// This test verifies that the RTCP reduced size mode is properly applied to
4909// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004910TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004911 // Create stream, expecting that default mode is "compound".
4912 FakeVideoReceiveStream* stream1 = AddRecvStream();
4913 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4914
4915 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004916 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4917 // the reduced_size flag should come from that.
4918 send_parameters_.rtcp.reduced_size = true;
4919 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004920 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4921 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4922
4923 // Create a new stream and ensure it picks up the reduced size mode.
4924 FakeVideoReceiveStream* stream2 = AddRecvStream();
4925 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4926}
4927
eladalonf1841382017-06-12 01:16:46 -07004928TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004929 EXPECT_EQ(webrtc::kNetworkUp,
4930 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4931 EXPECT_EQ(webrtc::kNetworkUp,
4932 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004933
4934 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004935 EXPECT_EQ(webrtc::kNetworkDown,
4936 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4937 EXPECT_EQ(webrtc::kNetworkUp,
4938 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004939
4940 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004941 EXPECT_EQ(webrtc::kNetworkUp,
4942 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4943 EXPECT_EQ(webrtc::kNetworkUp,
4944 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004945}
4946
eladalonf1841382017-06-12 01:16:46 -07004947TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004948 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004949 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004950 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004951
4952 AddSendStream();
4953
4954 cricket::VideoMediaInfo info;
4955 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004956 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004957}
4958
eladalonf1841382017-06-12 01:16:46 -07004959TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004960 FakeVideoSendStream* stream = AddSendStream();
4961 webrtc::VideoSendStream::Stats stats;
4962 stats.encoder_implementation_name = "encoder_implementation_name";
4963 stream->SetStats(stats);
4964
4965 cricket::VideoMediaInfo info;
4966 ASSERT_TRUE(channel_->GetStats(&info));
4967 EXPECT_EQ(stats.encoder_implementation_name,
4968 info.senders[0].encoder_implementation_name);
4969}
4970
eladalonf1841382017-06-12 01:16:46 -07004971TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004972 FakeVideoSendStream* stream = AddSendStream();
4973 webrtc::VideoSendStream::Stats stats;
4974 stats.avg_encode_time_ms = 13;
4975 stats.encode_usage_percent = 42;
4976 stream->SetStats(stats);
4977
4978 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004979 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004980 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4981 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4982}
4983
eladalonf1841382017-06-12 01:16:46 -07004984TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004985 FakeVideoSendStream* stream = AddSendStream();
4986 webrtc::VideoSendStream::Stats stats;
4987 stats.frames_encoded = 13;
4988 stream->SetStats(stats);
4989
4990 cricket::VideoMediaInfo info;
4991 ASSERT_TRUE(channel_->GetStats(&info));
4992 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4993}
4994
Rasmus Brandt2efae772019-06-27 14:29:34 +02004995TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
4996 FakeVideoSendStream* stream = AddSendStream();
4997 webrtc::VideoSendStream::Stats stats;
4998 stats.substreams[123].frame_counts.key_frames = 10;
4999 stats.substreams[456].frame_counts.key_frames = 87;
5000 stream->SetStats(stats);
5001
5002 cricket::VideoMediaInfo info;
5003 ASSERT_TRUE(channel_->GetStats(&info));
5004 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
5005 // for each simulcast stream, instead of accumulating all keyframes encoded
5006 // over all simulcast streams in the same outbound-rtp stats object.
5007 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
5008}
5009
eladalonf1841382017-06-12 01:16:46 -07005010TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07005011 FakeVideoSendStream* stream = AddSendStream();
5012 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01005013 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07005014 stream->SetStats(stats);
5015
5016 cricket::VideoMediaInfo info;
5017 ASSERT_TRUE(channel_->GetStats(&info));
5018 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5019}
5020
eladalonf1841382017-06-12 01:16:46 -07005021TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005022 FakeVideoSendStream* stream = AddSendStream();
5023 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005024 stats.substreams[17].width = 123;
5025 stats.substreams[17].height = 40;
5026 stats.substreams[42].width = 80;
5027 stats.substreams[42].height = 31;
5028 stats.substreams[11].width = 20;
5029 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005030 stream->SetStats(stats);
5031
5032 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005033 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005034 ASSERT_EQ(1u, info.senders.size());
5035 EXPECT_EQ(123, info.senders[0].send_frame_width);
5036 EXPECT_EQ(90, info.senders[0].send_frame_height);
5037}
5038
eladalonf1841382017-06-12 01:16:46 -07005039TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005040 FakeVideoSendStream* stream = AddSendStream();
5041 webrtc::VideoSendStream::Stats stats;
5042 stats.number_of_cpu_adapt_changes = 2;
5043 stats.cpu_limited_resolution = true;
5044 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005045
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005046 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005047 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005048 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005049 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005050 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005051}
5052
eladalonf1841382017-06-12 01:16:46 -07005053TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005054 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005055 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005056 stats.number_of_cpu_adapt_changes = 2;
5057 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005058 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005059 stream->SetStats(stats);
5060
5061 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005062 EXPECT_TRUE(channel_->GetStats(&info));
5063 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005064 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5065 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005066 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005067 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005068}
5069
eladalonf1841382017-06-12 01:16:46 -07005070TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005071 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5072 FakeVideoSendStream* stream = AddSendStream();
5073 webrtc::VideoSendStream::Stats stats;
5074 stats.bw_limited_resolution = true;
5075 stream->SetStats(stats);
5076
5077 cricket::VideoMediaInfo info;
5078 EXPECT_TRUE(channel_->GetStats(&info));
5079 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005080 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005081 info.senders[0].adapt_reason);
5082}
5083
Yves Gerey665174f2018-06-19 15:03:05 +02005084TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005085 FakeVideoSendStream* stream = AddSendStream();
5086 webrtc::VideoSendStream::Stats stats;
5087 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5088 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5089 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5090
5091 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5092 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5093 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5094
5095 stream->SetStats(stats);
5096
5097 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005098 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005099 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5100 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5101 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5102}
5103
eladalonf1841382017-06-12 01:16:46 -07005104TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005105 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5106 FakeVideoReceiveStream* stream = AddRecvStream();
5107 webrtc::VideoReceiveStream::Stats stats;
5108 stats.rtcp_packet_type_counts.fir_packets = 2;
5109 stats.rtcp_packet_type_counts.nack_packets = 3;
5110 stats.rtcp_packet_type_counts.pli_packets = 4;
5111 stream->SetStats(stats);
5112
5113 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005114 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005115 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005116 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005117 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005118 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005119 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005120 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005121}
5122
eladalonf1841382017-06-12 01:16:46 -07005123TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005124 FakeVideoReceiveStream* stream = AddRecvStream();
5125 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005126 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005127 stats.decode_ms = 2;
5128 stats.max_decode_ms = 3;
5129 stats.current_delay_ms = 4;
5130 stats.target_delay_ms = 5;
5131 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005132 stats.jitter_buffer_delay_seconds = 60;
5133 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005134 stats.min_playout_delay_ms = 7;
5135 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005136 stats.width = 9;
5137 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005138 stats.frame_counts.key_frames = 11;
5139 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005140 stats.frames_rendered = 13;
5141 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005142 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005143 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005144 stream->SetStats(stats);
5145
5146 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005147 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005148 EXPECT_EQ(stats.decoder_implementation_name,
5149 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005150 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5151 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5152 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5153 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5154 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005155 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5156 info.receivers[0].jitter_buffer_delay_seconds);
5157 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5158 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005159 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5160 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005161 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5162 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005163 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5164 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005165 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005166 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005167 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005168 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5169 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005170 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005171 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005172}
5173
eladalonf1841382017-06-12 01:16:46 -07005174TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07005175 webrtc::test::ScopedFieldTrials field_trials(
5176 "WebRTC-UseStandardBytesStats/Enabled/");
5177
Peter Boström393347f2015-04-22 14:52:45 +02005178 FakeVideoReceiveStream* stream = AddRecvStream();
5179 webrtc::VideoReceiveStream::Stats stats;
5180 stats.rtp_stats.transmitted.payload_bytes = 2;
5181 stats.rtp_stats.transmitted.header_bytes = 3;
5182 stats.rtp_stats.transmitted.padding_bytes = 4;
5183 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005184 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005185 stats.rtcp_stats.fraction_lost = 7;
5186 stream->SetStats(stats);
5187
5188 cricket::VideoMediaInfo info;
5189 ASSERT_TRUE(channel_->GetStats(&info));
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07005190 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005191 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005192 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005193 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005194 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005195}
5196
eladalonf1841382017-06-12 01:16:46 -07005197TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005198 AddSendStream();
5199 AddSendStream();
5200 webrtc::Call::Stats stats;
5201 stats.rtt_ms = 123;
5202 fake_call_->SetStats(stats);
5203
5204 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005205 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005206 ASSERT_EQ(2u, info.senders.size());
5207 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5208 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5209}
5210
eladalonf1841382017-06-12 01:16:46 -07005211TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005212 FakeVideoSendStream* stream = AddSendStream();
5213 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005214 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005215 stats.media_bitrate_bps = 123;
5216 stats.substreams[17].total_bitrate_bps = 1;
5217 stats.substreams[17].retransmit_bitrate_bps = 2;
5218 stats.substreams[42].total_bitrate_bps = 3;
5219 stats.substreams[42].retransmit_bitrate_bps = 4;
5220 stream->SetStats(stats);
5221
5222 FakeVideoSendStream* stream2 = AddSendStream();
5223 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005224 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005225 stats2.media_bitrate_bps = 321;
5226 stats2.substreams[13].total_bitrate_bps = 5;
5227 stats2.substreams[13].retransmit_bitrate_bps = 6;
5228 stats2.substreams[21].total_bitrate_bps = 7;
5229 stats2.substreams[21].retransmit_bitrate_bps = 8;
5230 stream2->SetStats(stats2);
5231
5232 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005233 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005234 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005235 BandwidthEstimationInfo bwe_info;
5236 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005237 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5238 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5239 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5240 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005241 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005242 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005243 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005244 bwe_info.actual_enc_bitrate);
5245 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005246 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005247 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005248 << "Bandwidth stats should take all streams into account.";
5249}
5250
eladalonf1841382017-06-12 01:16:46 -07005251TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005252 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005253
Peter Boström0c4e06b2015-10-07 12:23:21 +02005254 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5255 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005256
5257 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5258 const size_t kDataLength = 12;
5259 uint8_t data[kDataLength];
5260 memset(data, 0, sizeof(data));
5261 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005262 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005263 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005264
5265 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5266 << "No default receive stream created.";
5267 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005268 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005269 << "Default receive stream should not have configured RTX";
5270
5271 EXPECT_TRUE(channel_->AddRecvStream(
5272 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5273 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005274 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005275 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005276 EXPECT_FALSE(
5277 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005278 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005279 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005280 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005281 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005282 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005283 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005284}
5285
eladalonf1841382017-06-12 01:16:46 -07005286TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005287 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005288
Peter Boström0c4e06b2015-10-07 12:23:21 +02005289 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5290 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005291
5292 StreamParams sp =
5293 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5294 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5295
5296 EXPECT_FALSE(channel_->AddSendStream(sp));
5297 EXPECT_FALSE(channel_->AddRecvStream(sp));
5298}
5299
eladalonf1841382017-06-12 01:16:46 -07005300TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005301 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005302
Peter Boström0c4e06b2015-10-07 12:23:21 +02005303 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5304 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005305
5306 StreamParams sp =
5307 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5308
5309 EXPECT_TRUE(channel_->AddSendStream(sp));
5310 EXPECT_TRUE(channel_->AddRecvStream(sp));
5311
5312 // The RTX SSRC is already used in previous streams, using it should fail.
5313 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5314 EXPECT_FALSE(channel_->AddSendStream(sp));
5315 EXPECT_FALSE(channel_->AddRecvStream(sp));
5316
5317 // After removing the original stream this should be fine to add (makes sure
5318 // that RTX ssrcs are not forever taken).
5319 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5320 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5321 EXPECT_TRUE(channel_->AddSendStream(sp));
5322 EXPECT_TRUE(channel_->AddRecvStream(sp));
5323}
5324
eladalonf1841382017-06-12 01:16:46 -07005325TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005326 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005327 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5328 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005329 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005330
Peter Boströmd6f4c252015-03-26 16:23:04 +01005331 StreamParams sp =
5332 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5333
5334 EXPECT_TRUE(channel_->AddSendStream(sp));
5335 EXPECT_TRUE(channel_->AddRecvStream(sp));
5336
5337 // One of the SSRCs is already used in previous streams, using it should fail.
5338 sp = cricket::CreateSimStreamParams("cname",
5339 MAKE_VECTOR(kOverlappingStreamSsrcs));
5340 EXPECT_FALSE(channel_->AddSendStream(sp));
5341 EXPECT_FALSE(channel_->AddRecvStream(sp));
5342
5343 // After removing the original stream this should be fine to add (makes sure
5344 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005345 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5346 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005347 EXPECT_TRUE(channel_->AddSendStream(sp));
5348 EXPECT_TRUE(channel_->AddRecvStream(sp));
5349}
5350
eladalonf1841382017-06-12 01:16:46 -07005351TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005352 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005353
5354 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5355 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5356
5357 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5358 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5359
5360 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5361
5362 static const uint32_t kReceiverSsrcs[] = {3};
5363 static const uint32_t kReceiverRtxSsrcs[] = {2};
5364
5365 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5366 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5367 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5368
5369 cricket::VideoMediaInfo info;
5370 ASSERT_TRUE(channel_->GetStats(&info));
5371
5372 ASSERT_EQ(1u, info.senders.size());
5373 ASSERT_EQ(1u, info.receivers.size());
5374
5375 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5376 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5377 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5378}
5379
eladalonf1841382017-06-12 01:16:46 -07005380TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005381 FakeVideoReceiveStream* stream = AddRecvStream();
5382 webrtc::VideoReceiveStream::Stats stats;
5383 cricket::VideoMediaInfo info;
5384
5385 // Report no codec name before receiving.
5386 stream->SetStats(stats);
5387 ASSERT_TRUE(channel_->GetStats(&info));
5388 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5389
5390 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005391 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005392 stream->SetStats(stats);
5393 ASSERT_TRUE(channel_->GetStats(&info));
5394 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5395
5396 // Report no codec name for unknown playload types.
5397 stats.current_payload_type = 3;
5398 stream->SetStats(stats);
5399 ASSERT_TRUE(channel_->GetStats(&info));
5400 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5401}
5402
Seth Hampson5897a6e2018-04-03 11:16:33 -07005403// Tests that when we add a stream without SSRCs, but contains a stream_id
5404// that it is stored and its stream id is later used when the first packet
5405// arrives to properly create a receive stream with a sync label.
5406TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5407 const char kSyncLabel[] = "sync_label";
5408 cricket::StreamParams unsignaled_stream;
5409 unsignaled_stream.set_stream_ids({kSyncLabel});
5410 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5411 // The stream shouldn't have been created at this point because it doesn't
5412 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005413 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005414
5415 // Create and deliver packet.
5416 const size_t kDataLength = 12;
5417 uint8_t data[kDataLength];
5418 memset(data, 0, sizeof(data));
5419 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5420 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005421 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005422
5423 // The stream should now be created with the appropriate sync label.
5424 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5425 EXPECT_EQ(kSyncLabel,
5426 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5427
5428 // Removing the unsignaled stream should clear the cache. This time when
5429 // a default video receive stream is created it won't have a sync_group.
5430 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5431 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5432 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5433
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005434 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005435 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5436 EXPECT_TRUE(
5437 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5438}
5439
Ruslan Burakov493a6502019-02-27 15:32:48 +01005440// Test BaseMinimumPlayoutDelayMs on receive streams.
5441TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5442 // Test that set won't work for non-existing receive streams.
5443 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5444 // Test that get won't work for non-existing receive streams.
5445 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5446
5447 EXPECT_TRUE(AddRecvStream());
5448 // Test that set works for the existing receive stream.
5449 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5450 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5451 EXPECT_TRUE(recv_stream);
5452 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5453 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5454 200);
5455}
5456
5457// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5458TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5459 absl::optional<int> delay_ms;
5460 const FakeVideoReceiveStream* recv_stream;
5461
5462 // Set default stream with SSRC 0
5463 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5464 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5465
5466 // Spawn an unsignaled stream by sending a packet, it should inherit
5467 // default delay 200.
5468 const size_t kDataLength = 12;
5469 uint8_t data[kDataLength];
5470 memset(data, 0, sizeof(data));
5471 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5472 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005473 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005474
5475 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5476 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5477 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5478 EXPECT_EQ(200, delay_ms.value_or(0));
5479
5480 // Check that now if we change delay for SSRC 0 it will change delay for the
5481 // default receiving stream as well.
5482 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5483 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5484 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5485 EXPECT_EQ(300, delay_ms.value_or(0));
5486 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5487 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5488}
5489
eladalonf1841382017-06-12 01:16:46 -07005490void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005491 uint8_t payload_type,
5492 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005493 // kRedRtxPayloadType must currently be unused.
5494 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5495
noahricd10a68e2015-07-10 11:27:55 -07005496 // Add a RED RTX codec.
5497 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005498 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005499 recv_parameters_.codecs.push_back(red_rtx_codec);
5500 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005501
5502 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5503 const size_t kDataLength = 12;
5504 uint8_t data[kDataLength];
5505 memset(data, 0, sizeof(data));
5506
5507 rtc::Set8(data, 1, payload_type);
5508 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005509 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005510 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005511
5512 if (expect_created_receive_stream) {
5513 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5514 << "Should have created a receive stream for payload type: "
5515 << payload_type;
5516 } else {
5517 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5518 << "Shouldn't have created a receive stream for payload type: "
5519 << payload_type;
5520 }
5521}
5522
Åsa Persson2c7149b2018-10-15 09:36:10 +02005523class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5524 public:
5525 WebRtcVideoChannelDiscardUnknownSsrcTest()
5526 : WebRtcVideoChannelTest(
5527 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5528};
5529
5530TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5531 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5532 false /* expect_created_receive_stream */);
5533}
5534
eladalonf1841382017-06-12 01:16:46 -07005535TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005536 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5537 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005538}
5539
eladalonf1841382017-06-12 01:16:46 -07005540TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005541 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5542 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005543}
5544
eladalonf1841382017-06-12 01:16:46 -07005545TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005546 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005547 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5548 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5549 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5550 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005551}
5552
eladalonf1841382017-06-12 01:16:46 -07005553TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005554 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5555 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005556}
5557
eladalonf1841382017-06-12 01:16:46 -07005558TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005559 FlexfecPacketDoesntCreateUnsignalledStream) {
5560 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5561 false /* expect_created_receive_stream */);
5562}
5563
eladalonf1841382017-06-12 01:16:46 -07005564TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005565 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5566 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005567}
5568
mzanaty8a855d62017-02-17 15:46:43 -08005569// Test that receiving any unsignalled SSRC works even if it changes.
5570// The first unsignalled SSRC received will create a default receive stream.
5571// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005572TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005573 // Allow receiving VP8, VP9, H264 (if enabled).
5574 cricket::VideoRecvParameters parameters;
5575 parameters.codecs.push_back(GetEngineCodec("VP8"));
5576 parameters.codecs.push_back(GetEngineCodec("VP9"));
5577
5578#if defined(WEBRTC_USE_H264)
5579 cricket::VideoCodec H264codec(126, "H264");
5580 parameters.codecs.push_back(H264codec);
5581#endif
5582
5583 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5584 // No receive streams yet.
5585 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5586 cricket::FakeVideoRenderer renderer;
5587 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5588
5589 // Receive VP8 packet on first SSRC.
5590 uint8_t data[kMinRtpPacketLen];
5591 cricket::RtpHeader rtpHeader;
5592 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5593 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005594 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005595 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5596 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005597 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005598 // VP8 packet should create default receive stream.
5599 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005600 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005601 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5602 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005603 webrtc::VideoFrame video_frame =
5604 webrtc::VideoFrame::Builder()
5605 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5606 .set_timestamp_rtp(100)
5607 .set_timestamp_us(0)
5608 .set_rotation(webrtc::kVideoRotation_0)
5609 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005610 recv_stream->InjectFrame(video_frame);
5611 EXPECT_EQ(1, renderer.num_rendered_frames());
5612
5613 // Receive VP9 packet on second SSRC.
5614 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005615 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005616 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5617 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005618 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005619 // VP9 packet should replace the default receive SSRC.
5620 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5621 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5622 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5623 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005624 webrtc::VideoFrame video_frame2 =
5625 webrtc::VideoFrame::Builder()
5626 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5627 .set_timestamp_rtp(200)
5628 .set_timestamp_us(0)
5629 .set_rotation(webrtc::kVideoRotation_0)
5630 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005631 recv_stream->InjectFrame(video_frame2);
5632 EXPECT_EQ(2, renderer.num_rendered_frames());
5633
5634#if defined(WEBRTC_USE_H264)
5635 // Receive H264 packet on third SSRC.
5636 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005637 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005638 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5639 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005640 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005641 // H264 packet should replace the default receive SSRC.
5642 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5643 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5644 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5645 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005646 webrtc::VideoFrame video_frame3 =
5647 webrtc::VideoFrame::Builder()
5648 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5649 .set_timestamp_rtp(300)
5650 .set_timestamp_us(0)
5651 .set_rotation(webrtc::kVideoRotation_0)
5652 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005653 recv_stream->InjectFrame(video_frame3);
5654 EXPECT_EQ(3, renderer.num_rendered_frames());
5655#endif
5656}
5657
brandtr0dc57ea2017-05-29 23:33:31 -07005658// This test verifies that when a new default stream is created for a new
5659// unsignaled SSRC, the new stream does not overwrite any old stream that had
5660// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005661TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005662 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5663 cricket::VideoRecvParameters parameters;
5664 parameters.codecs.push_back(GetEngineCodec("VP8"));
5665 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5666
5667 // No streams signaled and no packets received, so we should not have any
5668 // stream objects created yet.
5669 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5670
5671 // Receive packet on an unsignaled SSRC.
5672 uint8_t data[kMinRtpPacketLen];
5673 cricket::RtpHeader rtp_header;
5674 rtp_header.payload_type = GetEngineCodec("VP8").id;
5675 rtp_header.seq_num = rtp_header.timestamp = 0;
5676 rtp_header.ssrc = kSsrcs3[0];
5677 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5678 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005679 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005680 // Default receive stream should be created.
5681 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5682 FakeVideoReceiveStream* recv_stream0 =
5683 fake_call_->GetVideoReceiveStreams()[0];
5684 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5685
5686 // Signal the SSRC.
5687 EXPECT_TRUE(
5688 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5689 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5690 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5691 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5692
5693 // Receive packet on a different unsignaled SSRC.
5694 rtp_header.ssrc = kSsrcs3[1];
5695 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5696 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005697 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005698 // New default receive stream should be created, but old stream should remain.
5699 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5700 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5701 FakeVideoReceiveStream* recv_stream1 =
5702 fake_call_->GetVideoReceiveStreams()[1];
5703 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5704}
5705
Seth Hampson7c682e02018-05-04 16:28:15 -07005706TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005707 AddSendStream();
5708
Niels Möller805a27e2019-01-21 12:21:27 +01005709 webrtc::test::FrameForwarder frame_forwarder;
5710 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005711 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005712 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005713
perkjfa10b552016-10-02 23:45:26 -07005714 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005715 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005716
5717 // TODO(skvlad): Resolve the inconsistency between the interpretation
5718 // of the global bitrate limit for audio and video:
5719 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5720 // max_bandwidth_bps = -1 - remove the bandwidth limit
5721 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005722 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005723
perkjfa10b552016-10-02 23:45:26 -07005724 SetAndExpectMaxBitrate(1000, 0, 1000);
5725 SetAndExpectMaxBitrate(1000, 800, 800);
5726 SetAndExpectMaxBitrate(600, 800, 600);
5727 SetAndExpectMaxBitrate(0, 800, 800);
5728 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005729
Niels Möllerff40b142018-04-09 08:49:14 +02005730 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005731}
5732
eladalonf1841382017-06-12 01:16:46 -07005733TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005734 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005735 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005736 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005737
5738 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005739 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005740 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005741}
5742
eladalonf1841382017-06-12 01:16:46 -07005743TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005744 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005745 FakeVideoSendStream* stream = AddSendStream();
5746
Seth Hampson7c682e02018-05-04 16:28:15 -07005747 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5748 EXPECT_EQ(1UL, parameters.encodings.size());
5749 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5750 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5751
5752 // Note that this is testing the behavior of the FakeVideoSendStream, which
5753 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5754 // we are just testing the behavior of
5755 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005756 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5757 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005758
5759 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5760 // by this amount.
5761 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5762 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5763 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5764 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5765
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005766 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5767 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5768 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5769}
5770
5771TEST_F(WebRtcVideoChannelTest,
5772 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5773 FakeVideoSendStream* stream = AddSendStream();
5774
5775 // Note that this is testing the behavior of the FakeVideoSendStream, which
5776 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5777 // we are just testing the behavior of
5778 // EncoderStreamFactory::CreateEncoderStreams.
5779 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5780 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5781
5782 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5783 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5784 EXPECT_EQ(1UL, parameters.encodings.size());
5785 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5786 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5787
5788 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5789 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5790 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5791}
5792
5793TEST_F(WebRtcVideoChannelTest,
5794 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5795 send_parameters_.max_bandwidth_bps = 99999;
5796 FakeVideoSendStream* stream = AddSendStream();
5797 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5798 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5799 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5800 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5801 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5802 stream->GetVideoStreams()[0].max_bitrate_bps);
5803
5804 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5805 // adjusted down.
5806 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5807 EXPECT_EQ(1UL, parameters.encodings.size());
5808 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5809 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5810 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5811 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5812 stream->GetVideoStreams()[0].min_bitrate_bps);
5813 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5814 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005815}
5816
Åsa Persson8c1bf952018-09-13 10:42:19 +02005817TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5818 FakeVideoSendStream* stream = AddSendStream();
5819
5820 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5821 EXPECT_EQ(1UL, parameters.encodings.size());
5822 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5823 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5824
5825 // Note that this is testing the behavior of the FakeVideoSendStream, which
5826 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5827 // we are just testing the behavior of
5828 // EncoderStreamFactory::CreateEncoderStreams.
5829 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5830 EXPECT_EQ(kDefaultVideoMaxFramerate,
5831 stream->GetVideoStreams()[0].max_framerate);
5832
5833 // Set max framerate and check that VideoStream.max_framerate is set.
5834 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5835 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5836 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5837 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5838
5839 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5840 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5841}
5842
Åsa Persson23eba222018-10-02 14:47:06 +02005843TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5844 FakeVideoSendStream* stream = AddSendStream();
5845
5846 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5847 EXPECT_EQ(1UL, parameters.encodings.size());
5848 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5849 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5850
5851 // Note that this is testing the behavior of the FakeVideoSendStream, which
5852 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5853 // we are just testing the behavior of
5854 // EncoderStreamFactory::CreateEncoderStreams.
5855 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5856 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5857
5858 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5859 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5860 parameters.encodings[0].num_temporal_layers = 2;
5861 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5862
5863 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5864 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5865}
5866
Seth Hampson7c682e02018-05-04 16:28:15 -07005867TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005868 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005869 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005870 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005871 // Two or more encodings should result in failure.
5872 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005873 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005874 // Zero encodings should also fail.
5875 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005876 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005877}
5878
Zach Stein3ca452b2018-01-18 10:01:24 -08005879TEST_F(WebRtcVideoChannelTest,
5880 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5881 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5882 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5883 AddSendStream(sp);
5884
5885 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5886
5887 // Additional encodings should result in failure.
5888 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005889 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005890 // Zero encodings should also fail.
5891 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005892 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005893}
5894
deadbeeffb2aced2017-01-06 23:05:37 -08005895// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005896TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005897 AddSendStream();
5898 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005899 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005900 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005901}
5902
Seth Hampson24722b32017-12-22 09:36:42 -08005903// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5904// a value <= 0, setting the parameters returns false.
5905TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5906 AddSendStream();
5907 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5908 EXPECT_EQ(1UL, parameters.encodings.size());
5909 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5910 parameters.encodings[0].bitrate_priority);
5911
5912 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005913 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005914 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005915 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005916}
5917
5918// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5919// properly on the VideoChannel and propogates down to the video encoder.
5920TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5921 AddSendStream();
5922 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5923 EXPECT_EQ(1UL, parameters.encodings.size());
5924 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5925 parameters.encodings[0].bitrate_priority);
5926
5927 // Change the value and set it on the VideoChannel.
5928 double new_bitrate_priority = 2.0;
5929 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005930 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005931
5932 // Verify that the encoding parameters bitrate_priority is set for the
5933 // VideoChannel.
5934 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5935 EXPECT_EQ(1UL, parameters.encodings.size());
5936 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5937
5938 // Verify that the new value propagated down to the encoder.
5939 std::vector<FakeVideoSendStream*> video_send_streams =
5940 fake_call_->GetVideoSendStreams();
5941 EXPECT_EQ(1UL, video_send_streams.size());
5942 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5943 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5944 // appropriately.
5945 EXPECT_EQ(new_bitrate_priority,
5946 video_send_stream->GetEncoderConfig().bitrate_priority);
5947 // Check that the vector of VideoStreams also was propagated correctly. Note
5948 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5949 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005950 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005951 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5952}
5953
5954// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5955// VideoChannel and the value propogates to the video encoder with all simulcast
5956// streams.
5957TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5958 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005959 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005960 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5961 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5962 AddSendStream(stream_params);
5963 uint32_t primary_ssrc = stream_params.first_ssrc();
5964
Niels Möller805a27e2019-01-21 12:21:27 +01005965 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005966 // frame. This creates multiple VideoStreams for all simulcast layers when
5967 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005968 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005969 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005970 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005971 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005972 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5973 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5974 rtc::kNumMicrosecsPerSec / 30));
5975
Seth Hampson24722b32017-12-22 09:36:42 -08005976 // Get and set the rtp encoding parameters.
5977 webrtc::RtpParameters parameters =
5978 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005979 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005980 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5981 parameters.encodings[0].bitrate_priority);
5982 // Change the value and set it on the VideoChannel.
5983 double new_bitrate_priority = 2.0;
5984 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005985 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005986
5987 // Verify that the encoding parameters priority is set on the VideoChannel.
5988 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005989 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005990 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5991
5992 // Verify that the new value propagated down to the encoder.
5993 std::vector<FakeVideoSendStream*> video_send_streams =
5994 fake_call_->GetVideoSendStreams();
5995 EXPECT_EQ(1UL, video_send_streams.size());
5996 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5997 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5998 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005999 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08006000 video_send_stream->GetEncoderConfig().number_of_streams);
6001 EXPECT_EQ(new_bitrate_priority,
6002 video_send_stream->GetEncoderConfig().bitrate_priority);
6003 // Check that the vector of VideoStreams also propagated correctly. The
6004 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
6005 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006006 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02006007 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006008 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6009 // Since we are only setting bitrate priority per-sender, the other
6010 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006011 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006012 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02006013 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006014 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02006015 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006016}
6017
Tim Haloun648d28a2018-10-18 16:52:22 -07006018// RTCRtpEncodingParameters.network_priority must be one of a few values
6019// derived from the default priority, corresponding to very-low, low, medium,
6020// or high.
6021TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6022 AddSendStream();
6023 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6024 EXPECT_EQ(1UL, parameters.encodings.size());
6025 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6026 parameters.encodings[0].network_priority);
6027
6028 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6029 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6030 for (auto it : good_values) {
6031 parameters.encodings[0].network_priority = it;
6032 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6033 }
6034 for (auto it : bad_values) {
6035 parameters.encodings[0].network_priority = it;
6036 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6037 }
6038}
6039
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006040TEST_F(WebRtcVideoChannelTest,
6041 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006042 VideoSendParameters parameters;
6043 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006044 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6045 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6046
6047 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006048 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006049
6050 VideoOptions options;
6051 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6052 channel_->SetSend(true);
6053
6054 // Try layers in natural order (smallest to largest).
6055 {
6056 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6057 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6058 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6059 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6060 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6061 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6062 ASSERT_TRUE(result.ok());
6063
6064 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6065
6066 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6067 ASSERT_EQ(3u, video_streams.size());
6068 EXPECT_EQ(320u, video_streams[0].width);
6069 EXPECT_EQ(180u, video_streams[0].height);
6070 EXPECT_EQ(640u, video_streams[1].width);
6071 EXPECT_EQ(360u, video_streams[1].height);
6072 EXPECT_EQ(1280u, video_streams[2].width);
6073 EXPECT_EQ(720u, video_streams[2].height);
6074 }
6075
6076 // Try layers in reverse natural order (largest to smallest).
6077 {
6078 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6079 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6080 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6081 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6082 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6083 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6084 ASSERT_TRUE(result.ok());
6085
6086 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6087
6088 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6089 ASSERT_EQ(3u, video_streams.size());
6090 EXPECT_EQ(1280u, video_streams[0].width);
6091 EXPECT_EQ(720u, video_streams[0].height);
6092 EXPECT_EQ(640u, video_streams[1].width);
6093 EXPECT_EQ(360u, video_streams[1].height);
6094 EXPECT_EQ(320u, video_streams[2].width);
6095 EXPECT_EQ(180u, video_streams[2].height);
6096 }
6097
6098 // Try layers in mixed order.
6099 {
6100 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6101 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6102 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6103 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6104 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6105 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6106 ASSERT_TRUE(result.ok());
6107
6108 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6109
6110 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6111 ASSERT_EQ(3u, video_streams.size());
6112 EXPECT_EQ(128u, video_streams[0].width);
6113 EXPECT_EQ(72u, video_streams[0].height);
6114 EXPECT_EQ(640u, video_streams[1].width);
6115 EXPECT_EQ(360u, video_streams[1].height);
6116 EXPECT_EQ(320u, video_streams[2].width);
6117 EXPECT_EQ(180u, video_streams[2].height);
6118 }
6119
6120 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6121 {
6122 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6123 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6124 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6125 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6126 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6127 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6128 ASSERT_TRUE(result.ok());
6129
6130 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6131
6132 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6133 ASSERT_EQ(3u, video_streams.size());
6134 EXPECT_EQ(1280u, video_streams[0].width);
6135 EXPECT_EQ(720u, video_streams[0].height);
6136 EXPECT_EQ(1280u, video_streams[1].width);
6137 EXPECT_EQ(720u, video_streams[1].height);
6138 EXPECT_EQ(320u, video_streams[2].width);
6139 EXPECT_EQ(180u, video_streams[2].height);
6140 }
6141
6142 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6143}
6144
6145TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006146 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6147 // Ensure that the top layer has width and height divisible by 2^3,
6148 // so that the bottom layer has width and height divisible by 2.
6149 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6150 // the number of simulcast layers set by the app.
6151 webrtc::test::ScopedFieldTrials field_trial(
6152 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6153
6154 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6155 VideoSendParameters parameters;
6156 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6157 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6158 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6159 webrtc::test::FrameForwarder frame_forwarder;
6160 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6161 &frame_forwarder));
6162 channel_->SetSend(true);
6163
6164 // Set |scale_resolution_down_by|'s.
6165 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6166 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6167 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6168 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6169 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6170 const auto result =
6171 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6172 ASSERT_TRUE(result.ok());
6173
6174 // Use a capture resolution whose width and height are not divisible by 2^3.
6175 // (See field trial set at the top of the test.)
6176 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6177 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6178
6179 // Ensure the scaling is correct.
6180 const auto video_streams = stream->GetVideoStreams();
6181 ASSERT_EQ(video_streams.size(), 3u);
6182 // Ensure that we round the capture resolution down for the top layer...
6183 EXPECT_EQ(video_streams[0].width, 2000u);
6184 EXPECT_EQ(video_streams[0].height, 1200u);
6185 EXPECT_EQ(video_streams[1].width, 1000u);
6186 EXPECT_EQ(video_streams[1].height, 600u);
6187 // ...and that the bottom layer has a width/height divisible by 2.
6188 EXPECT_EQ(video_streams[2].width, 500u);
6189 EXPECT_EQ(video_streams[2].height, 300u);
6190
6191 // Tear down.
6192 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6193}
6194
6195TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006196 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006197 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6198 VideoSendParameters parameters;
6199 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006200 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6201 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6202
6203 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006204 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006205
6206 VideoOptions options;
6207 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6208 channel_->SetSend(true);
6209
6210 // Try layers in natural order (smallest to largest).
6211 {
6212 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6213 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6214 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6215 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6216 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6217 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6218 ASSERT_TRUE(result.ok());
6219
6220 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6221
6222 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6223 ASSERT_EQ(3u, video_streams.size());
6224 EXPECT_EQ(320u, video_streams[0].width);
6225 EXPECT_EQ(180u, video_streams[0].height);
6226 EXPECT_EQ(640u, video_streams[1].width);
6227 EXPECT_EQ(360u, video_streams[1].height);
6228 EXPECT_EQ(1280u, video_streams[2].width);
6229 EXPECT_EQ(720u, video_streams[2].height);
6230 }
6231
6232 // Try layers in reverse natural order (largest to smallest).
6233 {
6234 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6235 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6236 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6237 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6238 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6239 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6240 ASSERT_TRUE(result.ok());
6241
6242 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6243
6244 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6245 ASSERT_EQ(3u, video_streams.size());
6246 EXPECT_EQ(1280u, video_streams[0].width);
6247 EXPECT_EQ(720u, video_streams[0].height);
6248 EXPECT_EQ(640u, video_streams[1].width);
6249 EXPECT_EQ(360u, video_streams[1].height);
6250 EXPECT_EQ(320u, video_streams[2].width);
6251 EXPECT_EQ(180u, video_streams[2].height);
6252 }
6253
6254 // Try layers in mixed order.
6255 {
6256 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6257 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6258 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6259 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6260 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6261 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6262 ASSERT_TRUE(result.ok());
6263
6264 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6265
6266 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6267 ASSERT_EQ(3u, video_streams.size());
6268 EXPECT_EQ(128u, video_streams[0].width);
6269 EXPECT_EQ(72u, video_streams[0].height);
6270 EXPECT_EQ(640u, video_streams[1].width);
6271 EXPECT_EQ(360u, video_streams[1].height);
6272 EXPECT_EQ(320u, video_streams[2].width);
6273 EXPECT_EQ(180u, video_streams[2].height);
6274 }
6275
6276 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6277 {
6278 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6279 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6280 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6281 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6282 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6283 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6284 ASSERT_TRUE(result.ok());
6285
6286 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6287
6288 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6289 ASSERT_EQ(3u, video_streams.size());
6290 EXPECT_EQ(1280u, video_streams[0].width);
6291 EXPECT_EQ(720u, video_streams[0].height);
6292 EXPECT_EQ(1280u, video_streams[1].width);
6293 EXPECT_EQ(720u, video_streams[1].height);
6294 EXPECT_EQ(320u, video_streams[2].width);
6295 EXPECT_EQ(180u, video_streams[2].height);
6296 }
6297 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6298}
6299
Rasmus Brandt9387b522019-02-05 14:23:26 +01006300TEST_F(WebRtcVideoChannelTest,
6301 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6302 // Ensure that the top layer has width and height divisible by 2^3,
6303 // so that the bottom layer has width and height divisible by 2.
6304 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6305 // the number of simulcast layers set by the app.
6306 webrtc::test::ScopedFieldTrials field_trial(
6307 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6308
6309 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6310 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6311 VideoSendParameters parameters;
6312 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6313 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6314 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6315 webrtc::test::FrameForwarder frame_forwarder;
6316 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6317 &frame_forwarder));
6318 channel_->SetSend(true);
6319
6320 // Set |scale_resolution_down_by|'s.
6321 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6322 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6323 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6324 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6325 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6326 const auto result =
6327 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6328 ASSERT_TRUE(result.ok());
6329
6330 // Use a capture resolution whose width and height are not divisible by 2^3.
6331 // (See field trial set at the top of the test.)
6332 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6333 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6334
6335 // Ensure the scaling is correct.
6336 const auto video_streams = stream->GetVideoStreams();
6337 ASSERT_EQ(video_streams.size(), 3u);
6338 // Ensure that we round the capture resolution down for the top layer...
6339 EXPECT_EQ(video_streams[0].width, 2000u);
6340 EXPECT_EQ(video_streams[0].height, 1200u);
6341 EXPECT_EQ(video_streams[1].width, 1000u);
6342 EXPECT_EQ(video_streams[1].height, 600u);
6343 // ...and that the bottom layer has a width/height divisible by 2.
6344 EXPECT_EQ(video_streams[2].width, 500u);
6345 EXPECT_EQ(video_streams[2].height, 300u);
6346
6347 // Tear down.
6348 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6349}
6350
Åsa Persson8c1bf952018-09-13 10:42:19 +02006351TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6352 const size_t kNumSimulcastStreams = 3;
6353 SetUpSimulcast(true, false);
6354
6355 // Get and set the rtp encoding parameters.
6356 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6357 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6358 for (const auto& encoding : parameters.encodings) {
6359 EXPECT_FALSE(encoding.max_framerate);
6360 }
6361
6362 // Change the value and set it on the VideoChannel.
6363 parameters.encodings[0].max_framerate = 10;
6364 parameters.encodings[1].max_framerate = 20;
6365 parameters.encodings[2].max_framerate = 25;
6366 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6367
6368 // Verify that the bitrates are set on the VideoChannel.
6369 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6370 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6371 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6372 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6373 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6374}
6375
Åsa Persson23eba222018-10-02 14:47:06 +02006376TEST_F(WebRtcVideoChannelTest,
6377 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6378 const size_t kNumSimulcastStreams = 3;
6379 SetUpSimulcast(true, false);
6380
6381 // Get and set the rtp encoding parameters.
6382 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6383 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6384
6385 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6386 parameters.encodings[0].num_temporal_layers = 0;
6387 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6388 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6389 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6390 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6391 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6392}
6393
6394TEST_F(WebRtcVideoChannelTest,
6395 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6396 const size_t kNumSimulcastStreams = 3;
6397 SetUpSimulcast(true, false);
6398
6399 // Get and set the rtp encoding parameters.
6400 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6401 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6402
6403 // No/all layers should be set.
6404 parameters.encodings[0].num_temporal_layers = 1;
6405 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6406 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6407
6408 // Different values not supported.
6409 parameters.encodings[0].num_temporal_layers = 1;
6410 parameters.encodings[1].num_temporal_layers = 2;
6411 parameters.encodings[2].num_temporal_layers = 2;
6412 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6413 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6414}
6415
6416TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6417 const size_t kNumSimulcastStreams = 3;
6418 SetUpSimulcast(true, false);
6419
6420 // Get and set the rtp encoding parameters.
6421 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6422 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6423 for (const auto& encoding : parameters.encodings)
6424 EXPECT_FALSE(encoding.num_temporal_layers);
6425
6426 // Change the value and set it on the VideoChannel.
6427 parameters.encodings[0].num_temporal_layers = 3;
6428 parameters.encodings[1].num_temporal_layers = 3;
6429 parameters.encodings[2].num_temporal_layers = 3;
6430 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6431
6432 // Verify that the number of temporal layers are set on the VideoChannel.
6433 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6434 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6435 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6436 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6437 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6438}
6439
6440TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6441 const size_t kNumSimulcastStreams = 3;
6442 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6443
6444 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006445 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006446 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006447 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006448 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006449 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006450
6451 // Get and set the rtp encoding parameters.
6452 // Change the value and set it on the VideoChannel.
6453 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6454 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6455 parameters.encodings[0].num_temporal_layers = 2;
6456 parameters.encodings[1].num_temporal_layers = 2;
6457 parameters.encodings[2].num_temporal_layers = 2;
6458 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6459
6460 // Verify that the new value is propagated down to the encoder.
6461 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6462 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6463 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6464 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6465 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6466 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6467 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6468 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6469
6470 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6471 // VideoStreams are created appropriately for the simulcast case.
6472 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6473 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6474 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6475 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6476
6477 // No parameter changed, encoder should not be reconfigured.
6478 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6479 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6480
6481 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6482}
6483
6484TEST_F(WebRtcVideoChannelTest,
6485 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6486 const size_t kDefaultNumTemporalLayers = 3;
6487 const size_t kNumSimulcastStreams = 3;
6488 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6489
6490 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006491 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006492 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006493 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006494 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006495 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006496
6497 // Change rtp encoding parameters, num_temporal_layers not changed.
6498 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6499 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6500 parameters.encodings[0].min_bitrate_bps = 33000;
6501 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6502
6503 // Verify that no value is propagated down to the encoder.
6504 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6505 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6506 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6507 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6508 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6509 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6510
6511 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6512 // VideoStreams are created appropriately for the simulcast case.
6513 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6514 EXPECT_EQ(kDefaultNumTemporalLayers,
6515 stream->GetVideoStreams()[0].num_temporal_layers);
6516 EXPECT_EQ(kDefaultNumTemporalLayers,
6517 stream->GetVideoStreams()[1].num_temporal_layers);
6518 EXPECT_EQ(kDefaultNumTemporalLayers,
6519 stream->GetVideoStreams()[2].num_temporal_layers);
6520
6521 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6522}
6523
Åsa Persson8c1bf952018-09-13 10:42:19 +02006524TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6525 const size_t kNumSimulcastStreams = 3;
6526 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6527
6528 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006529 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006530 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006531 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006532 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006533 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006534
6535 // Get and set the rtp encoding parameters.
6536 // Change the value and set it on the VideoChannel.
6537 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6538 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6539 parameters.encodings[0].max_framerate = 15;
6540 parameters.encodings[1].max_framerate = 25;
6541 parameters.encodings[2].max_framerate = 20;
6542 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6543
6544 // Verify that the new value propagated down to the encoder.
6545 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6546 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6547 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6548 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6549 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6550 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6551 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6552 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6553
6554 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6555 // VideoStreams are created appropriately for the simulcast case.
6556 // Currently the maximum |max_framerate| is used.
6557 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6558 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6559 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6560 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6561
6562 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6563}
6564
6565TEST_F(WebRtcVideoChannelTest,
6566 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6567 const size_t kNumSimulcastStreams = 3;
6568 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6569 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6570
6571 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006572 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006573 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006574 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006575 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006576 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006577
6578 // Get and set the rtp encoding parameters.
6579 // Change the value and set it on the VideoChannel.
6580 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6581 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6582 parameters.encodings[0].max_framerate = 15;
6583 parameters.encodings[2].max_framerate = 20;
6584 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6585
6586 // Verify that the new value propagated down to the encoder.
6587 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6588 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6589 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6590 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6591 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6592 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6593 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6594
6595 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6596 // VideoStreams are created appropriately for the simulcast case.
6597 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6598 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6599 EXPECT_EQ(kDefaultVideoMaxFramerate,
6600 stream->GetVideoStreams()[0].max_framerate);
6601 EXPECT_EQ(kDefaultVideoMaxFramerate,
6602 stream->GetVideoStreams()[1].max_framerate);
6603 EXPECT_EQ(kDefaultVideoMaxFramerate,
6604 stream->GetVideoStreams()[2].max_framerate);
6605
6606 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6607}
6608
Åsa Persson55659812018-06-18 17:51:32 +02006609TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6610 const size_t kNumSimulcastStreams = 3;
6611 SetUpSimulcast(true, false);
6612
6613 // Get and set the rtp encoding parameters.
6614 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6615 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6616 for (const auto& encoding : parameters.encodings) {
6617 EXPECT_FALSE(encoding.min_bitrate_bps);
6618 EXPECT_FALSE(encoding.max_bitrate_bps);
6619 }
6620
6621 // Change the value and set it on the VideoChannel.
6622 parameters.encodings[0].min_bitrate_bps = 100000;
6623 parameters.encodings[0].max_bitrate_bps = 200000;
6624 parameters.encodings[1].min_bitrate_bps = 300000;
6625 parameters.encodings[1].max_bitrate_bps = 400000;
6626 parameters.encodings[2].min_bitrate_bps = 500000;
6627 parameters.encodings[2].max_bitrate_bps = 600000;
6628 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6629
6630 // Verify that the bitrates are set on the VideoChannel.
6631 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6632 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6633 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6634 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6635 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6636 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6637 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6638 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6639}
6640
6641TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6642 const size_t kNumSimulcastStreams = 3;
6643 SetUpSimulcast(true, false);
6644
6645 // Get and set the rtp encoding parameters.
6646 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6647 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6648
6649 // Max bitrate lower than min bitrate should fail.
6650 parameters.encodings[2].min_bitrate_bps = 100000;
6651 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6652 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6653 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6654}
6655
6656// Test that min and max bitrate values set via RtpParameters are correctly
6657// propagated to the underlying encoder, and that the target is set to 3/4 of
6658// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6659// that are used if no min/max are specified).
6660TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6661 const size_t kNumSimulcastStreams = 3;
6662 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6663
6664 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006665 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006666 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006667 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006668 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006669 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006670
6671 // Get and set the rtp encoding parameters.
6672 // Change the value and set it on the VideoChannel.
6673 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6674 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6675 parameters.encodings[0].min_bitrate_bps = 100000;
6676 parameters.encodings[0].max_bitrate_bps = 200000;
6677 parameters.encodings[1].min_bitrate_bps = 300000;
6678 parameters.encodings[1].max_bitrate_bps = 400000;
6679 parameters.encodings[2].min_bitrate_bps = 500000;
6680 parameters.encodings[2].max_bitrate_bps = 600000;
6681 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6682
6683 // Verify that the new value propagated down to the encoder.
6684 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6685 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6686 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6687 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6688 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6689 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6690 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6691 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6692 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6693 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6694 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6695
6696 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6697 // VideoStreams are created appropriately for the simulcast case.
6698 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6699 // Target bitrate: 200000 * 3 / 4 = 150000.
6700 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6701 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6702 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6703 // Target bitrate: 400000 * 3 / 4 = 300000.
6704 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6705 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6706 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6707 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6708 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6709 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6710 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6711
6712 // No parameter changed, encoder should not be reconfigured.
6713 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6714 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6715
6716 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6717}
6718
6719// Test to only specify the min or max bitrate value for a layer via
6720// RtpParameters. The unspecified min/max and target value should be set to the
6721// simulcast default that is used if no min/max are specified.
6722TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6723 const size_t kNumSimulcastStreams = 3;
6724 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6725 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6726
6727 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006728 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006729 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006730 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006731 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006732 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006733
6734 // Get and set the rtp encoding parameters.
6735 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6736 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6737
6738 // Change the value and set it on the VideoChannel.
6739 // Layer 0: only configure min bitrate.
6740 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6741 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6742 // Layer 1: only configure max bitrate.
6743 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6744 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6745 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6746
6747 // Verify that the new value propagated down to the encoder.
6748 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6749 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6750 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6751 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6752 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6753 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6754 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6755 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6756 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6757 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6758
6759 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6760 // VideoStreams are created appropriately for the simulcast case.
6761 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6762 // Layer 0: min configured bitrate should overwrite min default.
6763 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6764 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6765 stream->GetVideoStreams()[0].target_bitrate_bps);
6766 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6767 stream->GetVideoStreams()[0].max_bitrate_bps);
6768 // Layer 1: max configured bitrate should overwrite max default.
6769 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6770 stream->GetVideoStreams()[1].min_bitrate_bps);
6771 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6772 stream->GetVideoStreams()[1].target_bitrate_bps);
6773 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6774 // Layer 2: min and max bitrate not configured, default expected.
6775 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6776 stream->GetVideoStreams()[2].min_bitrate_bps);
6777 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6778 stream->GetVideoStreams()[2].target_bitrate_bps);
6779 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6780 stream->GetVideoStreams()[2].max_bitrate_bps);
6781
6782 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6783}
6784
6785// Test that specifying the min (or max) bitrate value for a layer via
6786// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6787// unspecified values accordingly.
6788TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6789 const size_t kNumSimulcastStreams = 3;
6790 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6791 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6792
6793 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006794 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006795 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006796 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006797 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006798 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006799
6800 // Get and set the rtp encoding parameters.
6801 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6802 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6803
6804 // Change the value and set it on the VideoChannel.
6805 // For layer 0, set the min bitrate above the default max.
6806 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6807 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6808 // For layer 1, set the max bitrate below the default min.
6809 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6810 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6811 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6812
6813 // Verify that the new value propagated down to the encoder.
6814 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6815 // VideoStreams are created appropriately for the simulcast case.
6816 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6817 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6818 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6819 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6820 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6821 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6822 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6823 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6824 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6825 // Layer 2: min and max bitrate not configured, default expected.
6826 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6827 stream->GetVideoStreams()[2].min_bitrate_bps);
6828 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6829 stream->GetVideoStreams()[2].target_bitrate_bps);
6830 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6831 stream->GetVideoStreams()[2].max_bitrate_bps);
6832
6833 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6834}
6835
6836TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6837 const size_t kNumSimulcastStreams = 3;
6838 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6839 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6840
6841 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006842 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006843 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006844 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006845 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006846 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006847
6848 // Set max bitrate for all but the highest layer.
6849 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6850 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6851 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6852 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6853 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6854
6855 // Set max bandwidth equal to total max bitrate.
6856 send_parameters_.max_bandwidth_bps =
6857 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6858 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6859 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6860
6861 // No bitrate above the total max to give to the highest layer.
6862 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6863 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6864 stream->GetVideoStreams()[2].max_bitrate_bps);
6865
6866 // Set max bandwidth above the total max bitrate.
6867 send_parameters_.max_bandwidth_bps =
6868 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6869 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6870 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6871
6872 // The highest layer has no max bitrate set -> the bitrate above the total
6873 // max should be given to the highest layer.
6874 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6875 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6876 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6877 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6878 stream->GetVideoStreams()[2].max_bitrate_bps);
6879
6880 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6881}
6882
6883TEST_F(WebRtcVideoChannelTest,
6884 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6885 const size_t kNumSimulcastStreams = 3;
6886 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6887 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6888 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6889
6890 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006891 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006892 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006893 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006894 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006895 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006896
6897 // Set max bitrate for the highest layer.
6898 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6899 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6900 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6901 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6902
6903 // Set max bandwidth above the total max bitrate.
6904 send_parameters_.max_bandwidth_bps =
6905 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6906 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6907 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6908
6909 // The highest layer has the max bitrate set -> the bitrate above the total
6910 // max should not be given to the highest layer.
6911 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6912 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6913 stream->GetVideoStreams()[2].max_bitrate_bps);
6914
6915 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6916}
6917
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006918// Test that min and max bitrate values set via RtpParameters are correctly
6919// propagated to the underlying encoder for a single stream.
6920TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6921 FakeVideoSendStream* stream = AddSendStream();
6922 EXPECT_TRUE(channel_->SetSend(true));
6923 EXPECT_TRUE(stream->IsSending());
6924
6925 // Set min and max bitrate.
6926 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6927 EXPECT_EQ(1u, parameters.encodings.size());
6928 parameters.encodings[0].min_bitrate_bps = 80000;
6929 parameters.encodings[0].max_bitrate_bps = 150000;
6930 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6931
6932 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6933 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6934 EXPECT_EQ(1u, encoder_config.number_of_streams);
6935 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6936 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6937 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6938
6939 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6940 // VideoStreams are created appropriately.
6941 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6942 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6943 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6944 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6945}
6946
6947// Test the default min and max bitrate value are correctly propagated to the
6948// underlying encoder for a single stream (when the values are not set via
6949// RtpParameters).
6950TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6951 FakeVideoSendStream* stream = AddSendStream();
6952 EXPECT_TRUE(channel_->SetSend(true));
6953 EXPECT_TRUE(stream->IsSending());
6954
6955 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6956 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6957 EXPECT_EQ(1u, encoder_config.number_of_streams);
6958 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6959 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6960 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6961
6962 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6963 // VideoStreams are created appropriately.
6964 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6965 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6966 stream->GetVideoStreams()[0].min_bitrate_bps);
6967 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6968 stream->GetVideoStreams()[0].min_bitrate_bps);
6969 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6970 stream->GetVideoStreams()[0].target_bitrate_bps);
6971}
6972
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006973// Test that a stream will not be sending if its encoding is made inactive
6974// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006975TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006976 FakeVideoSendStream* stream = AddSendStream();
6977 EXPECT_TRUE(channel_->SetSend(true));
6978 EXPECT_TRUE(stream->IsSending());
6979
6980 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006981 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006982 ASSERT_EQ(1u, parameters.encodings.size());
6983 ASSERT_TRUE(parameters.encodings[0].active);
6984 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006985 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006986 EXPECT_FALSE(stream->IsSending());
6987
6988 // Now change it back to active and verify we resume sending.
6989 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006990 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006991 EXPECT_TRUE(stream->IsSending());
6992}
6993
Seth Hampson8234ead2018-02-02 15:16:24 -08006994// Tests that when active is updated for any simulcast layer then the send
6995// stream's sending state will be updated and it will be reconfigured with the
6996// new appropriate active simulcast streams.
6997TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6998 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006999 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08007000 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
7001 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
7002 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
7003 uint32_t primary_ssrc = stream_params.first_ssrc();
7004
Niels Möller805a27e2019-01-21 12:21:27 +01007005 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01007006 // frame. This allows us to test that ReconfigureEncoder is called
7007 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01007008 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08007009 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01007010 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08007011 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007012 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
7013 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
7014 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08007015
7016 // Check that all encodings are initially active.
7017 webrtc::RtpParameters parameters =
7018 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007019 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007020 EXPECT_TRUE(parameters.encodings[0].active);
7021 EXPECT_TRUE(parameters.encodings[1].active);
7022 EXPECT_TRUE(parameters.encodings[2].active);
7023 EXPECT_TRUE(fake_video_send_stream->IsSending());
7024
7025 // Only turn on only the middle stream.
7026 parameters.encodings[0].active = false;
7027 parameters.encodings[1].active = true;
7028 parameters.encodings[2].active = false;
7029 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7030 // Verify that the active fields are set on the VideoChannel.
7031 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007032 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007033 EXPECT_FALSE(parameters.encodings[0].active);
7034 EXPECT_TRUE(parameters.encodings[1].active);
7035 EXPECT_FALSE(parameters.encodings[2].active);
7036 // Check that the VideoSendStream is updated appropriately. This means its
7037 // send state was updated and it was reconfigured.
7038 EXPECT_TRUE(fake_video_send_stream->IsSending());
7039 std::vector<webrtc::VideoStream> simulcast_streams =
7040 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007041 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007042 EXPECT_FALSE(simulcast_streams[0].active);
7043 EXPECT_TRUE(simulcast_streams[1].active);
7044 EXPECT_FALSE(simulcast_streams[2].active);
7045
7046 // Turn off all streams.
7047 parameters.encodings[0].active = false;
7048 parameters.encodings[1].active = false;
7049 parameters.encodings[2].active = false;
7050 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7051 // Verify that the active fields are set on the VideoChannel.
7052 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007053 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007054 EXPECT_FALSE(parameters.encodings[0].active);
7055 EXPECT_FALSE(parameters.encodings[1].active);
7056 EXPECT_FALSE(parameters.encodings[2].active);
7057 // Check that the VideoSendStream is off.
7058 EXPECT_FALSE(fake_video_send_stream->IsSending());
7059 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007060 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007061 EXPECT_FALSE(simulcast_streams[0].active);
7062 EXPECT_FALSE(simulcast_streams[1].active);
7063 EXPECT_FALSE(simulcast_streams[2].active);
7064
Niels Möllerff40b142018-04-09 08:49:14 +02007065 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007066}
7067
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007068// Test that if a stream is reconfigured (due to a codec change or other
7069// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007070TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007071 InactiveStreamDoesntStartSendingWhenReconfigured) {
7072 // Set an initial codec list, which will be modified later.
7073 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007074 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7075 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007076 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7077
7078 FakeVideoSendStream* stream = AddSendStream();
7079 EXPECT_TRUE(channel_->SetSend(true));
7080 EXPECT_TRUE(stream->IsSending());
7081
7082 // Get current parameters and change "active" to false.
7083 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7084 ASSERT_EQ(1u, parameters.encodings.size());
7085 ASSERT_TRUE(parameters.encodings[0].active);
7086 parameters.encodings[0].active = false;
7087 EXPECT_EQ(1u, GetFakeSendStreams().size());
7088 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007089 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007090 EXPECT_FALSE(stream->IsSending());
7091
7092 // Reorder the codec list, causing the stream to be reconfigured.
7093 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007094 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7095 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007096 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7097 auto new_streams = GetFakeSendStreams();
7098 // Assert that a new underlying stream was created due to the codec change.
7099 // Otherwise, this test isn't testing what it set out to test.
7100 EXPECT_EQ(1u, GetFakeSendStreams().size());
7101 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7102
7103 // Verify that we still are not sending anything, due to the inactive
7104 // encoding.
7105 EXPECT_FALSE(new_streams[0]->IsSending());
7106}
7107
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007108// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007109TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007110 AddSendStream();
7111 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007112 parameters.codecs.push_back(GetEngineCodec("VP8"));
7113 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007114 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7115
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007116 webrtc::RtpParameters rtp_parameters =
7117 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007118 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007119 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7120 rtp_parameters.codecs[0]);
7121 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7122 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007123}
7124
Florent Castellidacec712018-05-24 16:24:21 +02007125// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7126TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7127 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7128 params.cname = "rtcpcname";
7129 AddSendStream(params);
7130
7131 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7132 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7133}
7134
deadbeeffb2aced2017-01-06 23:05:37 -08007135// Test that RtpParameters for send stream has one encoding and it has
7136// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007137TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007138 AddSendStream();
7139
7140 webrtc::RtpParameters rtp_parameters =
7141 channel_->GetRtpSendParameters(last_ssrc_);
7142 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007143 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007144}
7145
Florent Castelliabe301f2018-06-12 18:33:49 +02007146TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7147 AddSendStream();
7148
7149 webrtc::RtpParameters rtp_parameters =
7150 channel_->GetRtpSendParameters(last_ssrc_);
7151 rtp_parameters.header_extensions.emplace_back();
7152
7153 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7154
7155 webrtc::RTCError result =
7156 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7157 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7158}
7159
Florent Castelli87b3c512018-07-18 16:00:28 +02007160TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7161 AddSendStream();
7162
Niels Möller805a27e2019-01-21 12:21:27 +01007163 webrtc::test::FrameForwarder frame_forwarder;
7164 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007165
7166 webrtc::RtpParameters rtp_parameters =
7167 channel_->GetRtpSendParameters(last_ssrc_);
7168 EXPECT_EQ(rtp_parameters.degradation_preference,
7169 webrtc::DegradationPreference::BALANCED);
7170 rtp_parameters.degradation_preference =
7171 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7172
7173 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7174
7175 webrtc::RtpParameters updated_rtp_parameters =
7176 channel_->GetRtpSendParameters(last_ssrc_);
7177 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7178 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7179
7180 // Remove the source since it will be destroyed before the channel
7181 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7182}
7183
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007184// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007185TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007186 AddSendStream();
7187 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007188 parameters.codecs.push_back(GetEngineCodec("VP8"));
7189 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007190 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7191
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007192 webrtc::RtpParameters initial_params =
7193 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007194
7195 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007196 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007197
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007198 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7199 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7200}
7201
7202// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007203TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007204 AddRecvStream();
7205 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007206 parameters.codecs.push_back(GetEngineCodec("VP8"));
7207 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007208 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7209
7210 webrtc::RtpParameters rtp_parameters =
7211 channel_->GetRtpReceiveParameters(last_ssrc_);
7212 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007213 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7214 rtp_parameters.codecs[0]);
7215 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7216 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007217}
7218
johan073ece42016-08-26 02:59:47 -07007219#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007220TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007221#else
eladalonf1841382017-06-12 01:16:46 -07007222TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007223#endif
johan3859c892016-08-05 09:19:25 -07007224 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007225 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007226 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007227 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007228 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007229 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007230 parameters.codecs.push_back(kH264sprop2);
7231 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7232
7233 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7234 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7235 webrtc::RtpParameters rtp_parameters =
7236 channel_->GetRtpReceiveParameters(last_ssrc_);
7237 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7238 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7239 ASSERT_EQ(2u, cfg.decoders.size());
7240 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007241 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007242 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007243 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7244 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007245 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007246
7247 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007248 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007249 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007250 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7251 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007252 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007253}
7254
sakal1fd95952016-06-22 00:46:15 -07007255// Test that RtpParameters for receive stream has one encoding and it has
7256// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007257TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007258 AddRecvStream();
7259
7260 webrtc::RtpParameters rtp_parameters =
7261 channel_->GetRtpReceiveParameters(last_ssrc_);
7262 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007263 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007264}
7265
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007266// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007267TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007268 AddRecvStream();
7269 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007270 parameters.codecs.push_back(GetEngineCodec("VP8"));
7271 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007272 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7273
7274 webrtc::RtpParameters initial_params =
7275 channel_->GetRtpReceiveParameters(last_ssrc_);
7276
7277 // We should be able to set the params we just got.
7278 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7279
7280 // ... And this shouldn't change the params returned by
7281 // GetRtpReceiveParameters.
7282 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007283}
7284
deadbeef3bc15102017-04-20 19:25:07 -07007285// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7286// aren't signaled. It should always return an empty "RtpEncodingParameters",
7287// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007288TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007289 // Call necessary methods to configure receiving a default stream as
7290 // soon as it arrives.
7291 cricket::VideoRecvParameters parameters;
7292 parameters.codecs.push_back(GetEngineCodec("VP8"));
7293 parameters.codecs.push_back(GetEngineCodec("VP9"));
7294 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7295
7296 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7297 // stream. Should return nothing.
7298 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7299
7300 // Set a sink for an unsignaled stream.
7301 cricket::FakeVideoRenderer renderer;
7302 // Value of "0" means "unsignaled stream".
7303 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7304
7305 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7306 // in this method means "unsignaled stream".
7307 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7308 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7309 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7310
7311 // Receive VP8 packet.
7312 uint8_t data[kMinRtpPacketLen];
7313 cricket::RtpHeader rtpHeader;
7314 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7315 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7316 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7317 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7318 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007319 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007320
7321 // The |ssrc| member should still be unset.
7322 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7323 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7324 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7325}
7326
eladalonf1841382017-06-12 01:16:46 -07007327void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007328 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007329 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007330
7331 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007332 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007333 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007334 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007335
7336 if (receiver_first) {
7337 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7338 std::vector<FakeVideoReceiveStream*> receive_streams =
7339 fake_call_->GetVideoReceiveStreams();
7340 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007341 // Default local SSRC when we have no sender.
7342 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7343 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007344 }
7345 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7346 if (!receiver_first)
7347 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7348 std::vector<FakeVideoReceiveStream*> receive_streams =
7349 fake_call_->GetVideoReceiveStreams();
7350 ASSERT_EQ(1u, receive_streams.size());
7351 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007352
7353 // Removing first sender should fall back to another (in this case the second)
7354 // local send stream's SSRC.
7355 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7356 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007357 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007358 ASSERT_EQ(1u, receive_streams.size());
7359 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7360
7361 // Removing the last sender should fall back to default local SSRC.
7362 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007363 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007364 ASSERT_EQ(1u, receive_streams.size());
7365 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7366 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007367}
7368
eladalonf1841382017-06-12 01:16:46 -07007369TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007370 TestReceiverLocalSsrcConfiguration(false);
7371}
7372
eladalonf1841382017-06-12 01:16:46 -07007373TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007374 TestReceiverLocalSsrcConfiguration(true);
7375}
7376
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007377class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007378 public:
eladalonf1841382017-06-12 01:16:46 -07007379 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007380 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007381 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7382 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007383 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007384 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007385 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007386 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007387 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007388 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007389 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007390
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007391 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007392 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007393 channel_.reset(engine_.CreateMediaChannel(
7394 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7395 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007396 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007397 last_ssrc_ = 123;
7398 }
7399
7400 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007401 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007402 int capture_width,
7403 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007404 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007405 size_t expected_num_streams,
7406 bool screenshare,
7407 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007408 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007409 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007410 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007411 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007412
Peter Boström0c4e06b2015-10-07 12:23:21 +02007413 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007414 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007415 ssrcs.resize(num_configured_streams);
7416
sprangf24a0642017-02-28 13:23:26 -08007417 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007418 // Send a full-size frame to trigger a stream reconfiguration to use all
7419 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007420 webrtc::test::FrameForwarder frame_forwarder;
7421 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7422 rtc::kNumMicrosecsPerSec / 30);
7423
sprangf24a0642017-02-28 13:23:26 -08007424 VideoOptions options;
7425 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007426 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007427 EXPECT_TRUE(
7428 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007429 // Fetch the latest stream since SetVideoSend() may recreate it if the
7430 // screen content setting is changed.
7431 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007432 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007433 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007434
Zach Stein3ca452b2018-01-18 10:01:24 -08007435 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7436 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7437
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007438 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7439 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007440 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007441
sprang429600d2017-01-26 06:12:26 -08007442 std::vector<webrtc::VideoStream> expected_streams;
Florent Castelli66b38602019-07-10 16:57:57 +02007443 if (num_configured_streams > 1 || conference_mode) {
sprang429600d2017-01-26 06:12:26 -08007444 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007445 num_configured_streams, capture_width, capture_height,
Florent Castelli66b38602019-07-10 16:57:57 +02007446 webrtc::kDefaultBitratePriority, kDefaultQpMax,
7447 screenshare && conference_mode, true);
7448 if (screenshare && conference_mode) {
sprang3ebabf12017-02-16 07:35:22 -08007449 for (const webrtc::VideoStream& stream : expected_streams) {
7450 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007451 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7452 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007453 }
7454 }
sprang429600d2017-01-26 06:12:26 -08007455 } else {
7456 webrtc::VideoStream stream;
7457 stream.width = capture_width;
7458 stream.height = capture_height;
7459 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007460 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007461 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007462 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007463 stream.max_qp = kDefaultQpMax;
7464 expected_streams.push_back(stream);
7465 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007466
7467 ASSERT_EQ(expected_streams.size(), video_streams.size());
7468
7469 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007470 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007471 for (size_t i = 0; i < num_streams; ++i) {
7472 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7473 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7474
7475 EXPECT_GT(video_streams[i].max_framerate, 0);
7476 EXPECT_EQ(expected_streams[i].max_framerate,
7477 video_streams[i].max_framerate);
7478
7479 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7480 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7481 video_streams[i].min_bitrate_bps);
7482
7483 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7484 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7485 video_streams[i].target_bitrate_bps);
7486
7487 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7488 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7489 video_streams[i].max_bitrate_bps);
7490
7491 EXPECT_GT(video_streams[i].max_qp, 0);
7492 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7493
Florent Castelli66b38602019-07-10 16:57:57 +02007494 EXPECT_EQ(num_configured_streams > 1 || conference_mode,
Sergey Silkina796a7e2018-03-01 15:11:29 +01007495 expected_streams[i].num_temporal_layers.has_value());
7496
7497 if (conference_mode) {
7498 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7499 video_streams[i].num_temporal_layers);
7500 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007501
7502 if (i == num_streams - 1) {
7503 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7504 } else {
7505 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7506 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007507 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007508
Niels Möllerff40b142018-04-09 08:49:14 +02007509 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007510 }
7511
7512 FakeVideoSendStream* AddSendStream() {
7513 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7514 }
7515
7516 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007517 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007518 EXPECT_TRUE(channel_->AddSendStream(sp));
7519 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007520 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007521 EXPECT_EQ(num_streams + 1, streams.size());
7522 return streams[streams.size() - 1];
7523 }
7524
7525 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007526 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007527 }
7528
7529 FakeVideoReceiveStream* AddRecvStream() {
7530 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7531 }
7532
7533 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007534 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007535 EXPECT_TRUE(channel_->AddRecvStream(sp));
7536 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007537 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007538 EXPECT_EQ(num_streams + 1, streams.size());
7539 return streams[streams.size() - 1];
7540 }
7541
Danil Chapovalov83bbe912019-08-07 12:24:53 +02007542 webrtc::RtcEventLogNull event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007543 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007544 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7545 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007546 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7547 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007548 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007549 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007550 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007551};
7552
eladalonf1841382017-06-12 01:16:46 -07007553TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007554 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7555 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007556}
7557
eladalonf1841382017-06-12 01:16:46 -07007558TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007559 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7560 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007561}
7562
7563// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007564TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007565 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7566 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007567}
sprang429600d2017-01-26 06:12:26 -08007568
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007569TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Florent Castelli66b38602019-07-10 16:57:57 +02007570 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007571 false);
7572}
7573
eladalonf1841382017-06-12 01:16:46 -07007574TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007575 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7576 true);
7577}
7578
Florent Castelli66b38602019-07-10 16:57:57 +02007579TEST_F(WebRtcVideoChannelSimulcastTest, SimulcastScreenshareWithoutConference) {
7580 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
sprangfe627f32017-03-29 08:24:59 -07007581 false);
7582}
7583
Chen Xing90f3b892019-06-25 10:16:14 +02007584TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7585 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007586
Chen Xing90f3b892019-06-25 10:16:14 +02007587 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007588 EXPECT_TRUE(SetDefaultCodec());
7589 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007590 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007591
Chen Xing90f3b892019-06-25 10:16:14 +02007592 // Send and receive one frame.
7593 SendFrame();
7594 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007595
Chen Xing90f3b892019-06-25 10:16:14 +02007596 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7597 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7598 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007599
Chen Xing90f3b892019-06-25 10:16:14 +02007600 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7601 EXPECT_EQ(source.source_id(), kSsrc);
7602 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7603 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7604 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007605
Chen Xing90f3b892019-06-25 10:16:14 +02007606 // Send and receive another frame.
7607 SendFrame();
7608 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007609
Chen Xing90f3b892019-06-25 10:16:14 +02007610 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7611 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7612 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007613
Chen Xing90f3b892019-06-25 10:16:14 +02007614 source = channel_->GetSources(kSsrc)[0];
7615 EXPECT_EQ(source.source_id(), kSsrc);
7616 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7617 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7618 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007619
Chen Xing90f3b892019-06-25 10:16:14 +02007620 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7621 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007622}
7623
Amit Hilbuchb000b712019-02-25 10:22:14 -08007624TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7625 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7626
7627 std::vector<std::string> rids = {"f", "h", "q"};
7628 std::vector<cricket::RidDescription> rid_descriptions;
7629 for (const auto& rid : rids) {
7630 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7631 }
7632 sp.set_rids(rid_descriptions);
7633
7634 ASSERT_TRUE(channel_->AddSendStream(sp));
7635 const auto& streams = fake_call_->GetVideoSendStreams();
7636 ASSERT_EQ(1u, streams.size());
7637 auto stream = streams[0];
7638 ASSERT_NE(stream, nullptr);
7639 const auto& config = stream->GetConfig();
7640 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7641}
7642
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007643} // namespace cricket