blob: d74f57f985f4144309630c3d76f68875f5f95b4e [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners as owners_db
48import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020049import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000050import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000051import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000052import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000053import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Edward Lemurecc27072020-01-06 16:42:34 +000069def time_time():
70 # Use this so that it can be mocked in tests without interfering with python
71 # system machinery.
72 return time.time()
73
74
maruel@chromium.org899e1c12011-04-07 17:03:18 +000075class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000076 pass
77
78
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000080 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000081 self.name = name
82 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000084 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040085 self.kwargs['stdout'] = subprocess.PIPE
86 self.kwargs['stderr'] = subprocess.STDOUT
87 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000088 self.message = message
89 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000090 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000091
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000092
Edward Lesmes8e282792018-04-03 18:50:29 -040093# Adapted from
94# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
95#
96# An object that catches SIGINT sent to the Python process and notices
97# if processes passed to wait() die by SIGINT (we need to look for
98# both of those cases, because pressing Ctrl+C can result in either
99# the main process or one of the subprocesses getting the signal).
100#
101# Before a SIGINT is seen, wait(p) will simply call p.wait() and
102# return the result. Once a SIGINT has been seen (in the main process
103# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000104# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400105class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400106 sigint_returncodes = {-signal.SIGINT, # Unix
107 -1073741510, # Windows
108 }
109 def __init__(self):
110 self.__lock = threading.Lock()
111 self.__processes = set()
112 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000113 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400114
115 def __on_sigint(self):
116 self.__got_sigint = True
117 while self.__processes:
118 try:
119 self.__processes.pop().terminate()
120 except OSError:
121 pass
122
Edward Lemur9a5bb612019-09-26 02:01:52 +0000123 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400124 with self.__lock:
125 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000126 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400127
128 def got_sigint(self):
129 with self.__lock:
130 return self.__got_sigint
131
132 def wait(self, p, stdin):
133 with self.__lock:
134 if self.__got_sigint:
135 p.terminate()
136 self.__processes.add(p)
137 stdout, stderr = p.communicate(stdin)
138 code = p.returncode
139 with self.__lock:
140 self.__processes.discard(p)
141 if code in self.sigint_returncodes:
142 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400143 return stdout, stderr
144
145sigint_handler = SigintHandler()
146
147
Edward Lemurecc27072020-01-06 16:42:34 +0000148class Timer(object):
149 def __init__(self, timeout, fn):
150 self.completed = False
151 self._fn = fn
152 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
153
154 def __enter__(self):
155 if self._timer:
156 self._timer.start()
157 return self
158
159 def __exit__(self, _type, _value, _traceback):
160 if self._timer:
161 self._timer.cancel()
162
163 def _onTimer(self):
164 self._fn()
165 self.completed = True
166
167
Edward Lesmes8e282792018-04-03 18:50:29 -0400168class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000169 def __init__(self, pool_size=None, timeout=None):
170 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400171 self._pool_size = pool_size or multiprocessing.cpu_count()
172 self._messages = []
173 self._messages_lock = threading.Lock()
174 self._tests = []
175 self._tests_lock = threading.Lock()
176 self._nonparallel_tests = []
177
Edward Lemurecc27072020-01-06 16:42:34 +0000178 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000179 vpython = 'vpython'
180 if test.python3:
181 vpython += '3'
182 if sys.platform == 'win32':
183 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400184
185 cmd = test.cmd
186 if cmd[0] == 'python':
187 cmd = list(cmd)
188 cmd[0] = vpython
189 elif cmd[0].endswith('.py'):
190 cmd = [vpython] + cmd
191
Edward Lemur336e51f2019-11-14 21:42:04 +0000192 # On Windows, scripts on the current directory take precedence over PATH, so
193 # that when testing depot_tools on Windows, calling `vpython.bat` will
194 # execute the copy of vpython of the depot_tools under test instead of the
195 # one in the bot.
196 # As a workaround, we run the tests from the parent directory instead.
197 if (cmd[0] == vpython and
198 'cwd' in test.kwargs and
199 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
200 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
201 cmd[1] = os.path.join('depot_tools', cmd[1])
202
Edward Lemurecc27072020-01-06 16:42:34 +0000203 return cmd
204
205 def _RunWithTimeout(self, cmd, stdin, kwargs):
206 p = subprocess.Popen(cmd, **kwargs)
207 with Timer(self.timeout, p.terminate) as timer:
208 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000209 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000210 if timer.completed:
211 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000212 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000213
214 def CallCommand(self, test):
215 """Runs an external program.
216
Edward Lemura5799e32020-01-17 19:26:51 +0000217 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000218 to vpython invocations.
219 """
220 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400221 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000222 start = time_time()
223 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
224 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000226 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400227 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000228 '%s\n%s exec failure (%4.2fs)\n%s' % (
229 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000230
Edward Lemurecc27072020-01-06 16:42:34 +0000231 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400232 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 '%s\n%s (%4.2fs) failed\n%s' % (
234 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000235
Edward Lesmes8e282792018-04-03 18:50:29 -0400236 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000237 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400238
239 def AddTests(self, tests, parallel=True):
240 if parallel:
241 self._tests.extend(tests)
242 else:
243 self._nonparallel_tests.extend(tests)
244
245 def RunAsync(self):
246 self._messages = []
247
248 def _WorkerFn():
249 while True:
250 test = None
251 with self._tests_lock:
252 if not self._tests:
253 break
254 test = self._tests.pop()
255 result = self.CallCommand(test)
256 if result:
257 with self._messages_lock:
258 self._messages.append(result)
259
260 def _StartDaemon():
261 t = threading.Thread(target=_WorkerFn)
262 t.daemon = True
263 t.start()
264 return t
265
266 while self._nonparallel_tests:
267 test = self._nonparallel_tests.pop()
268 result = self.CallCommand(test)
269 if result:
270 self._messages.append(result)
271
272 if self._tests:
273 threads = [_StartDaemon() for _ in range(self._pool_size)]
274 for worker in threads:
275 worker.join()
276
277 return self._messages
278
279
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000280def normpath(path):
281 '''Version of os.path.normpath that also changes backward slashes to
282 forward slashes when not running on Windows.
283 '''
284 # This is safe to always do because the Windows version of os.path.normpath
285 # will replace forward slashes with backward slashes.
286 path = path.replace(os.sep, '/')
287 return os.path.normpath(path)
288
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000289
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000290def _RightHandSideLinesImpl(affected_files):
291 """Implements RightHandSideLines for InputApi and GclChange."""
292 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000295 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000296
297
Edward Lemur6eb1d322020-02-27 22:20:15 +0000298def prompt_should_continue(prompt_string):
299 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000300 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000301 response = sys.stdin.readline().strip().lower()
302 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000303
304
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000305# Top level object so multiprocessing can pickle
306# Public access through OutputApi object.
307class _PresubmitResult(object):
308 """Base class for result objects."""
309 fatal = False
310 should_prompt = False
311
312 def __init__(self, message, items=None, long_text=''):
313 """
314 message: A short one-line message to indicate errors.
315 items: A list of short strings to indicate where errors occurred.
316 long_text: multi-line text output, e.g. from another tool
317 """
318 self._message = message
319 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000320 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
321
322 @staticmethod
323 def _ensure_str(val):
324 """
325 val: A "stringish" value. Can be any of str, unicode or bytes.
326 returns: A str after applying encoding/decoding as needed.
327 Assumes/uses UTF-8 for relevant inputs/outputs.
328
329 We'd prefer to use six.ensure_str but our copy of six is old :(
330 """
331 if isinstance(val, str):
332 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000333
Tom McKee61c72652021-07-20 11:56:32 +0000334 if six.PY2 and isinstance(val, unicode):
335 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000336
337 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000338 return val.decode()
339 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000340
Edward Lemur6eb1d322020-02-27 22:20:15 +0000341 def handle(self):
342 sys.stdout.write(self._message)
343 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000344 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000345 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000346 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000347 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000348 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000349 sys.stdout.write(' \\')
350 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000351 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000352 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000353 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000354 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000355 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000356
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000357 def json_format(self):
358 return {
359 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000360 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000361 'long_text': self._long_text,
362 'fatal': self.fatal
363 }
364
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365
366# Top level object so multiprocessing can pickle
367# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000368class _PresubmitError(_PresubmitResult):
369 """A hard presubmit error."""
370 fatal = True
371
372
373# Top level object so multiprocessing can pickle
374# Public access through OutputApi object.
375class _PresubmitPromptWarning(_PresubmitResult):
376 """An warning that prompts the user if they want to continue."""
377 should_prompt = True
378
379
380# Top level object so multiprocessing can pickle
381# Public access through OutputApi object.
382class _PresubmitNotifyResult(_PresubmitResult):
383 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000384
385
386# Top level object so multiprocessing can pickle
387# Public access through OutputApi object.
388class _MailTextResult(_PresubmitResult):
389 """A warning that should be included in the review request email."""
390 def __init__(self, *args, **kwargs):
391 super(_MailTextResult, self).__init__()
392 raise NotImplementedError()
393
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000394class GerritAccessor(object):
395 """Limited Gerrit functionality for canned presubmit checks to work.
396
397 To avoid excessive Gerrit calls, caches the results.
398 """
399
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000400 def __init__(self, url=None, project=None, branch=None):
401 self.host = urlparse.urlparse(url).netloc if url else None
402 self.project = project
403 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000404 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000405 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000406
407 def _FetchChangeDetail(self, issue):
408 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100409 try:
410 return gerrit_util.GetChangeDetail(
411 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700412 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100413 except gerrit_util.GerritError as e:
414 if e.http_status == 404:
415 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
416 'no credentials to fetch issue details' % issue)
417 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000418
419 def GetChangeInfo(self, issue):
420 """Returns labels and all revisions (patchsets) for this issue.
421
422 The result is a dictionary according to Gerrit REST Api.
423 https://gerrit-review.googlesource.com/Documentation/rest-api.html
424
425 However, API isn't very clear what's inside, so see tests for example.
426 """
427 assert issue
428 cache_key = int(issue)
429 if cache_key not in self.cache:
430 self.cache[cache_key] = self._FetchChangeDetail(issue)
431 return self.cache[cache_key]
432
433 def GetChangeDescription(self, issue, patchset=None):
434 """If patchset is none, fetches current patchset."""
435 info = self.GetChangeInfo(issue)
436 # info is a reference to cache. We'll modify it here adding description to
437 # it to the right patchset, if it is not yet there.
438
439 # Find revision info for the patchset we want.
440 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000441 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000442 if str(rev_info['_number']) == str(patchset):
443 break
444 else:
445 raise Exception('patchset %s doesn\'t exist in issue %s' % (
446 patchset, issue))
447 else:
448 rev = info['current_revision']
449 rev_info = info['revisions'][rev]
450
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100451 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000452
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800453 def GetDestRef(self, issue):
454 ref = self.GetChangeInfo(issue)['branch']
455 if not ref.startswith('refs/'):
456 # NOTE: it is possible to create 'refs/x' branch,
457 # aka 'refs/heads/refs/x'. However, this is ill-advised.
458 ref = 'refs/heads/%s' % ref
459 return ref
460
Edward Lesmes02d4b822020-11-11 00:37:35 +0000461 def _GetApproversForLabel(self, issue, label):
462 change_info = self.GetChangeInfo(issue)
463 label_info = change_info.get('labels', {}).get(label, {})
464 values = label_info.get('values', {}).keys()
465 if not values:
466 return []
467 max_value = max(int(v) for v in values)
468 return [v for v in label_info.get('all', [])
469 if v.get('value', 0) == max_value]
470
Edward Lesmesc4566172021-03-19 16:55:13 +0000471 def IsBotCommitApproved(self, issue):
472 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
473
Edward Lesmescf49cb82020-11-11 01:08:36 +0000474 def IsOwnersOverrideApproved(self, issue):
475 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
476
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000477 def GetChangeOwner(self, issue):
478 return self.GetChangeInfo(issue)['owner']['email']
479
480 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700481 changeinfo = self.GetChangeInfo(issue)
482 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000483 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700484 else:
485 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
486 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000487
Edward Lemure4d329c2020-02-03 20:41:18 +0000488 def UpdateDescription(self, description, issue):
489 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
490
Edward Lesmes8170c292021-03-19 20:04:43 +0000491 def IsCodeOwnersEnabledOnRepo(self):
492 if self.code_owners_enabled is None:
493 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000494 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000495 return self.code_owners_enabled
496
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000497
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000498class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000499 """An instance of OutputApi gets passed to presubmit scripts so that they
500 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000501 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000502 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000503 PresubmitError = _PresubmitError
504 PresubmitPromptWarning = _PresubmitPromptWarning
505 PresubmitNotifyResult = _PresubmitNotifyResult
506 MailTextResult = _MailTextResult
507
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000508 def __init__(self, is_committing):
509 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800510 self.more_cc = []
511
512 def AppendCC(self, cc):
513 """Appends a user to cc for this change."""
514 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000515
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000516 def PresubmitPromptOrNotify(self, *args, **kwargs):
517 """Warn the user when uploading, but only notify if committing."""
518 if self.is_committing:
519 return self.PresubmitNotifyResult(*args, **kwargs)
520 return self.PresubmitPromptWarning(*args, **kwargs)
521
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000522
523class InputApi(object):
524 """An instance of this object is passed to presubmit scripts so they can
525 know stuff about the change they're looking at.
526 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000527 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800528 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000529
maruel@chromium.org3410d912009-06-09 20:56:16 +0000530 # File extensions that are considered source files from a style guide
531 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000532 #
533 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000534 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000535 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
536 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000537 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000538 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
539 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000540 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000541 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000542 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000543 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
544 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000545 )
546
547 # Path regexp that should be excluded from being considered containing source
548 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000549 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000550 r'testing_support[\\\/]google_appengine[\\\/].*',
551 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900552 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
553 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000554 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000555 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000556 r'.*\bDebug[\\\/].*',
557 r'.*\bRelease[\\\/].*',
558 r'.*\bxcodebuild[\\\/].*',
559 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000560 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000561 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000562 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000563 r'(|.*[\\\/])\.git[\\\/].*',
564 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000565 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000566 r'.+\.diff$',
567 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000568 )
569
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000570 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400571 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000572 """Builds an InputApi object.
573
574 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000575 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000576 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000577 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000578 gerrit_obj: provides basic Gerrit codereview functionality.
579 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400580 parallel: if true, all tests reported via input_api.RunTests for all
581 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000582 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000583 # Version number of the presubmit_support script.
584 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000585 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000586 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000587 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000588 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000589
Edward Lesmes8e282792018-04-03 18:50:29 -0400590 self.parallel = parallel
591 self.thread_pool = thread_pool or ThreadPool()
592
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593 # We expose various modules and functions as attributes of the input_api
594 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900595 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000596 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000597 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700598 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000599 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000600 # TODO(yyanagisawa): stop exposing this when python3 become default.
601 # Since python3's tempfile has TemporaryDirectory, we do not need this.
602 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000603 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000604 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000605 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000606 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000607 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000608 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000609 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000610 self.re = re
611 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000612 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000613 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000614 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000615 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000616 if sys.version_info.major == 2:
617 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000618 self.urllib_request = urllib_request
619 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000620
Robert Iannucci50258932018-03-19 10:30:59 -0700621 self.is_windows = sys.platform == 'win32'
622
Edward Lemurb9646622019-10-25 20:57:35 +0000623 # Set python_executable to 'vpython' in order to allow scripts in other
624 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
625 # instead of inheriting the one in depot_tools.
626 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000627 # Offer a python 3 executable for use during the migration off of python 2.
628 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000629 self.environ = os.environ
630
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000631 # InputApi.platform is the platform you're currently running on.
632 self.platform = sys.platform
633
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000634 self.cpu_count = multiprocessing.cpu_count()
635
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000636 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000637 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000638
639 # We carry the canned checks so presubmit scripts can easily use them.
640 self.canned_checks = presubmit_canned_checks
641
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100642 # Temporary files we must manually remove at the end of a run.
643 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200644
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000645 self.owners_client = None
646 if self.gerrit:
647 self.owners_client = owners_client.GetCodeOwnersClient(
648 root=change.RepositoryRoot(),
649 upstream=change.UpstreamBranch(),
650 host=self.gerrit.host,
651 project=self.gerrit.project,
652 branch=self.gerrit.branch)
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000653 self.owners_db = owners_db.Database(
654 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200655 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000656 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000657 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000658
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000659 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000660 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000661 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800662 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000663 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000664 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000665 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
666 for (a, b, header) in cpplint._re_pattern_templates
667 ]
668
Edward Lemurecc27072020-01-06 16:42:34 +0000669 def SetTimeout(self, timeout):
670 self.thread_pool.timeout = timeout
671
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000672 def PresubmitLocalPath(self):
673 """Returns the local path of the presubmit script currently being run.
674
675 This is useful if you don't want to hard-code absolute paths in the
676 presubmit script. For example, It can be used to find another file
677 relative to the PRESUBMIT.py script, so the whole tree can be branched and
678 the presubmit script still works, without editing its content.
679 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000680 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000681
agable0b65e732016-11-22 09:25:46 -0800682 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000683 """Same as input_api.change.AffectedFiles() except only lists files
684 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000685 script, or subdirectories thereof. Note that files are listed using the OS
686 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000687 """
Edward Lemura5799e32020-01-17 19:26:51 +0000688 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000689 if len(dir_with_slash) == 1:
690 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000691
Edward Lemurb9830242019-10-30 22:19:20 +0000692 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000693 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000694 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000695
agable0b65e732016-11-22 09:25:46 -0800696 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000697 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800698 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000699 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000700 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000701
agable0b65e732016-11-22 09:25:46 -0800702 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000703 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800704 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000705
John Budorick16162372018-04-18 10:39:53 -0700706 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800707 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000708 in the same directory as the current presubmit script, or subdirectories
709 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000711 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000712 warn('AffectedTestableFiles(include_deletes=%s)'
713 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000714 category=DeprecationWarning,
715 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000716 return list(filter(
717 lambda x: x.IsTestableFile(),
718 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800719
720 def AffectedTextFiles(self, include_deletes=None):
721 """An alias to AffectedTestableFiles for backwards compatibility."""
722 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000723
Josip Sokcevic8c955952021-02-01 21:32:57 +0000724 def FilterSourceFile(self,
725 affected_file,
726 files_to_check=None,
727 files_to_skip=None,
728 allow_list=None,
729 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000730 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000731
local_bot64021412020-07-08 21:05:39 +0000732 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
733 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000734
735 The lists will be compiled as regular expression and
736 AffectedFile.LocalPath() needs to pass both list.
737
738 Note: Copy-paste this function to suit your needs or use a lambda function.
739 """
local_bot64021412020-07-08 21:05:39 +0000740 if files_to_check is None:
741 files_to_check = self.DEFAULT_FILES_TO_CHECK
742 if files_to_skip is None:
743 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000744
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000745 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000746 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000747 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000748 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000749 return True
750 return False
local_bot64021412020-07-08 21:05:39 +0000751 return (Find(affected_file, files_to_check) and
752 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000753
754 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800755 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000756
757 If source_file is None, InputApi.FilterSourceFile() is used.
758 """
759 if not source_file:
760 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000761 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000762
763 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000764 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000765
766 Only lists lines from new or modified text files in the change that are
767 contained by the directory of the currently executing presubmit script.
768
769 This is useful for doing line-by-line regex checks, like checking for
770 trailing whitespace.
771
772 Yields:
773 a 3 tuple:
774 the AffectedFile instance of the current file;
775 integer line number (1-based); and
776 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000777
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000778 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000779 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000780 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000781 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000782
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000783 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000784 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000785
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000786 Deny reading anything outside the repository.
787 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000788 if isinstance(file_item, AffectedFile):
789 file_item = file_item.AbsoluteLocalPath()
790 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000791 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000792 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000793
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100794 def CreateTemporaryFile(self, **kwargs):
795 """Returns a named temporary file that must be removed with a call to
796 RemoveTemporaryFiles().
797
798 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
799 except for |delete|, which is always set to False.
800
801 Presubmit checks that need to create a temporary file and pass it for
802 reading should use this function instead of NamedTemporaryFile(), as
803 Windows fails to open a file that is already open for writing.
804
805 with input_api.CreateTemporaryFile() as f:
806 f.write('xyz')
807 f.close()
808 input_api.subprocess.check_output(['script-that', '--reads-from',
809 f.name])
810
811
812 Note that callers of CreateTemporaryFile() should not worry about removing
813 any temporary file; this is done transparently by the presubmit handling
814 code.
815 """
816 if 'delete' in kwargs:
817 # Prevent users from passing |delete|; we take care of file deletion
818 # ourselves and this prevents unintuitive error messages when we pass
819 # delete=False and 'delete' is also in kwargs.
820 raise TypeError('CreateTemporaryFile() does not take a "delete" '
821 'argument, file deletion is handled automatically by '
822 'the same presubmit_support code that creates InputApi '
823 'objects.')
824 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
825 self._named_temporary_files.append(temp_file.name)
826 return temp_file
827
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000828 @property
829 def tbr(self):
830 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400831 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000832
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000833 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000834 tests = []
835 msgs = []
836 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400837 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000838 msgs.append(t)
839 else:
840 assert issubclass(t.message, _PresubmitResult)
841 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000842 if self.verbose:
843 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400844 if not t.kwargs.get('cwd'):
845 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400846 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000847 # When self.parallel is True (i.e. --parallel is passed as an option)
848 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
849 # will run all tests once all PRESUBMIT files are processed.
850 # Otherwise, it will run them and return the results.
851 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400852 msgs.extend(self.thread_pool.RunAsync())
853 return msgs
scottmg86099d72016-09-01 09:16:51 -0700854
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000855
nick@chromium.orgff526192013-06-10 19:30:26 +0000856class _DiffCache(object):
857 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000858 def __init__(self, upstream=None):
859 """Stores the upstream revision against which all diffs will be computed."""
860 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000861
862 def GetDiff(self, path, local_root):
863 """Get the diff for a particular path."""
864 raise NotImplementedError()
865
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700866 def GetOldContents(self, path, local_root):
867 """Get the old version for a particular path."""
868 raise NotImplementedError()
869
nick@chromium.orgff526192013-06-10 19:30:26 +0000870
nick@chromium.orgff526192013-06-10 19:30:26 +0000871class _GitDiffCache(_DiffCache):
872 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000873 def __init__(self, upstream):
874 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000875 self._diffs_by_file = None
876
877 def GetDiff(self, path, local_root):
878 if not self._diffs_by_file:
879 # Compute a single diff for all files and parse the output; should
880 # with git this is much faster than computing one diff for each file.
881 diffs = {}
882
883 # Don't specify any filenames below, because there are command line length
884 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000885 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
886 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000887
888 # This regex matches the path twice, separated by a space. Note that
889 # filename itself may contain spaces.
890 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
891 current_diff = []
892 keep_line_endings = True
893 for x in unified_diff.splitlines(keep_line_endings):
894 match = file_marker.match(x)
895 if match:
896 # Marks the start of a new per-file section.
897 diffs[match.group('filename')] = current_diff = [x]
898 elif x.startswith('diff --git'):
899 raise PresubmitFailure('Unexpected diff line: %s' % x)
900 else:
901 current_diff.append(x)
902
903 self._diffs_by_file = dict(
904 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
905
906 if path not in self._diffs_by_file:
907 raise PresubmitFailure(
908 'Unified diff did not contain entry for file %s' % path)
909
910 return self._diffs_by_file[path]
911
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700912 def GetOldContents(self, path, local_root):
913 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
914
nick@chromium.orgff526192013-06-10 19:30:26 +0000915
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000916class AffectedFile(object):
917 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000918
919 DIFF_CACHE = _DiffCache
920
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000921 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800922 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000923 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000924 self._path = path
925 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000926 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000927 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000928 self._cached_changed_contents = None
929 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000930 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700931 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000932
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000933 def LocalPath(self):
934 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400935
936 This should be used for error messages but not for accessing files,
937 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
938 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000939 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000940 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000941
942 def AbsoluteLocalPath(self):
943 """Returns the absolute path of this file on the local disk.
944 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000945 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000946
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000947 def Action(self):
948 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000949 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000950
agable0b65e732016-11-22 09:25:46 -0800951 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000952 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000953
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000954 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000955 raise NotImplementedError() # Implement when needed
956
agable0b65e732016-11-22 09:25:46 -0800957 def IsTextFile(self):
958 """An alias to IsTestableFile for backwards compatibility."""
959 return self.IsTestableFile()
960
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700961 def OldContents(self):
962 """Returns an iterator over the lines in the old version of file.
963
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700964 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000965 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700966
967 Contents will be empty if the file is a directory or does not exist.
968 Note: The carriage returns (LF or CR) are stripped off.
969 """
970 return self._diff_cache.GetOldContents(self.LocalPath(),
971 self._local_root).splitlines()
972
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000973 def NewContents(self):
974 """Returns an iterator over the lines in the new version of file.
975
Edward Lemura5799e32020-01-17 19:26:51 +0000976 The new version is the file in the user's workspace, i.e. the 'right hand
977 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000978
979 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000980 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000981 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000982 if self._cached_new_contents is None:
983 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800984 try:
985 self._cached_new_contents = gclient_utils.FileRead(
986 self.AbsoluteLocalPath(), 'rU').splitlines()
987 except IOError:
988 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +0000989 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +0000990 # log the filename since we're probably trying to read a binary
991 # file, and shouldn't be.
992 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
993 raise
994
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000995 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000996
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +0000997 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000998 """Returns a list of tuples (line number, line text) of all new lines.
999
1000 This relies on the scm diff output describing each changed code section
1001 with a line of the form
1002
1003 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1004 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001005 # Don't return cached results when line breaks are requested.
1006 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001007 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001008 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001009 line_num = 0
1010
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001011 # The keeplinebreaks parameter to splitlines must be True or else the
1012 # CheckForWindowsLineEndings presubmit will be a NOP.
1013 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001014 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1015 if m:
1016 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001017 continue
1018 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001019 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001020 if not line.startswith('-'):
1021 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001022 # Don't cache results with line breaks.
1023 if keeplinebreaks:
1024 return result;
1025 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001026 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001027
maruel@chromium.org5de13972009-06-10 18:16:06 +00001028 def __str__(self):
1029 return self.LocalPath()
1030
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001031 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001032 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001033
maruel@chromium.org58407af2011-04-12 23:15:57 +00001034
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001035class GitAffectedFile(AffectedFile):
1036 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001037 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001038 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001039
nick@chromium.orgff526192013-06-10 19:30:26 +00001040 DIFF_CACHE = _GitDiffCache
1041
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001042 def __init__(self, *args, **kwargs):
1043 AffectedFile.__init__(self, *args, **kwargs)
1044 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001045 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001046
agable0b65e732016-11-22 09:25:46 -08001047 def IsTestableFile(self):
1048 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001049 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001050 # A deleted file is not testable.
1051 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001052 else:
agable0b65e732016-11-22 09:25:46 -08001053 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1054 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001055
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001056
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001057class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001058 """Describe a change.
1059
1060 Used directly by the presubmit scripts to query the current change being
1061 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001062
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001063 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001064 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001065 self.KEY: equivalent to tags['KEY']
1066 """
1067
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001068 _AFFECTED_FILES = AffectedFile
1069
Edward Lemura5799e32020-01-17 19:26:51 +00001070 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001071 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001072 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001073 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001074
maruel@chromium.org58407af2011-04-12 23:15:57 +00001075 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001076 self, name, description, local_root, files, issue, patchset, author,
1077 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001078 if files is None:
1079 files = []
1080 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001081 # Convert root into an absolute path.
1082 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001083 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001084 self.issue = issue
1085 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001086 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001087
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001088 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001089 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001090 self._description_without_tags = ''
1091 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001092
maruel@chromium.orge085d812011-10-10 19:49:15 +00001093 assert all(
1094 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1095
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001096 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001097 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001098 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1099 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001100 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001101
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001102 def UpstreamBranch(self):
1103 """Returns the upstream branch for the change."""
1104 return self._upstream
1105
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001106 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001107 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001108 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001109
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001110 def DescriptionText(self):
1111 """Returns the user-entered changelist description, minus tags.
1112
Edward Lemura5799e32020-01-17 19:26:51 +00001113 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001114 (whitespace permitted before and around) is considered a tag line. Such
1115 lines are stripped out of the description this function returns.
1116 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001117 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001118
1119 def FullDescriptionText(self):
1120 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001121 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001122
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001123 def SetDescriptionText(self, description):
1124 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001125
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001126 Also updates the list of tags."""
1127 self._full_description = description
1128
1129 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001130 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001131 description_without_tags = []
1132 self.tags = {}
1133 for line in self._full_description.splitlines():
1134 m = self.TAG_LINE_RE.match(line)
1135 if m:
1136 self.tags[m.group('key')] = m.group('value')
1137 else:
1138 description_without_tags.append(line)
1139
1140 # Change back to text and remove whitespace at end.
1141 self._description_without_tags = (
1142 '\n'.join(description_without_tags).rstrip())
1143
Edward Lemur69bb8be2020-02-03 20:37:38 +00001144 def AddDescriptionFooter(self, key, value):
1145 """Adds the given footer to the change description.
1146
1147 Args:
1148 key: A string with the key for the git footer. It must conform to
1149 the git footers format (i.e. 'List-Of-Tokens') and will be case
1150 normalized so that each token is title-cased.
1151 value: A string with the value for the git footer.
1152 """
1153 description = git_footers.add_footer(
1154 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1155 self.SetDescriptionText(description)
1156
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001157 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001158 """Returns the repository (checkout) root directory for this change,
1159 as an absolute path.
1160 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001161 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001162
1163 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001164 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001165 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001166 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001167 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001168
Edward Lemur69bb8be2020-02-03 20:37:38 +00001169 def GitFootersFromDescription(self):
1170 """Return the git footers present in the description.
1171
1172 Returns:
1173 footers: A dict of {footer: [values]} containing a multimap of the footers
1174 in the change description.
1175 """
1176 return git_footers.parse_footers(self.FullDescriptionText())
1177
Aaron Gablefc03e672017-05-15 14:09:42 -07001178 def BugsFromDescription(self):
1179 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001180 bug_tags = ['BUG', 'FIXED']
1181
1182 tags = []
1183 for tag in bug_tags:
1184 values = self.tags.get(tag)
1185 if values:
1186 tags += [value.strip() for value in values.split(',')]
1187
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001188 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001189 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001190 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001191 for unsplit_footer in unsplit_footers:
1192 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001193 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001194
1195 def ReviewersFromDescription(self):
1196 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001197 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001198 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1199 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001200
1201 def TBRsFromDescription(self):
1202 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001203 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001204 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1205 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001206 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001207 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001208
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001209 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001210 @property
1211 def BUG(self):
1212 return ','.join(self.BugsFromDescription())
1213 @property
1214 def R(self):
1215 return ','.join(self.ReviewersFromDescription())
1216 @property
1217 def TBR(self):
1218 return ','.join(self.TBRsFromDescription())
1219
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001220 def AllFiles(self, root=None):
1221 """List all files under source control in the repo."""
1222 raise NotImplementedError()
1223
agable0b65e732016-11-22 09:25:46 -08001224 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001225 """Returns a list of AffectedFile instances for all files in the change.
1226
1227 Args:
1228 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001229 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001230
1231 Returns:
1232 [AffectedFile(path, action), AffectedFile(path, action)]
1233 """
Edward Lemurb9830242019-10-30 22:19:20 +00001234 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001235
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001236 if include_deletes:
1237 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001238 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001239
John Budorick16162372018-04-18 10:39:53 -07001240 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001241 """Return a list of the existing text files in a change."""
1242 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001243 warn('AffectedTeestableFiles(include_deletes=%s)'
1244 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001245 category=DeprecationWarning,
1246 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001247 return list(filter(
1248 lambda x: x.IsTestableFile(),
1249 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001250
agable0b65e732016-11-22 09:25:46 -08001251 def AffectedTextFiles(self, include_deletes=None):
1252 """An alias to AffectedTestableFiles for backwards compatibility."""
1253 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001254
agable0b65e732016-11-22 09:25:46 -08001255 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001256 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001257 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001258
agable0b65e732016-11-22 09:25:46 -08001259 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001260 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001261 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001262
1263 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001264 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001265
1266 Lists lines from new or modified text files in the change.
1267
1268 This is useful for doing line-by-line regex checks, like checking for
1269 trailing whitespace.
1270
1271 Yields:
1272 a 3 tuple:
1273 the AffectedFile instance of the current file;
1274 integer line number (1-based); and
1275 the contents of the line as a string.
1276 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001277 return _RightHandSideLinesImpl(
1278 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001279 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001280
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001281 def OriginalOwnersFiles(self):
1282 """A map from path names of affected OWNERS files to their old content."""
1283 def owners_file_filter(f):
1284 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1285 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001286 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001287
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001288
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001289class GitChange(Change):
1290 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001291 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001292
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001293 def AllFiles(self, root=None):
1294 """List all files under source control in the repo."""
1295 root = root or self.RepositoryRoot()
1296 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001297 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001298 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001299
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001300
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001301def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001302 """Finds all presubmit files that apply to a given set of source files.
1303
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001304 If inherit-review-settings-ok is present right under root, looks for
1305 PRESUBMIT.py in directories enclosing root.
1306
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001307 Args:
1308 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001309 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001310
1311 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001312 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001313 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001314 files = [normpath(os.path.join(root, f)) for f in files]
1315
1316 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001317 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001318
1319 # Ignore root if inherit-review-settings-ok is present.
1320 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1321 root = None
1322
1323 # Collect all unique directories that may contain PRESUBMIT.py.
1324 candidates = set()
1325 for directory in directories:
1326 while True:
1327 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001328 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001329 candidates.add(directory)
1330 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001331 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001332 parent_dir = os.path.dirname(directory)
1333 if parent_dir == directory:
1334 # We hit the system root directory.
1335 break
1336 directory = parent_dir
1337
1338 # Look for PRESUBMIT.py in all candidate directories.
1339 results = []
1340 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001341 try:
1342 for f in os.listdir(directory):
1343 p = os.path.join(directory, f)
1344 if os.path.isfile(p) and re.match(
1345 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1346 results.append(p)
1347 except OSError:
1348 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001349
tobiasjs2836bcf2016-08-16 04:08:16 -07001350 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001351 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001352
1353
rmistry@google.com5626a922015-02-26 14:03:30 +00001354class GetPostUploadExecuter(object):
1355 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001356 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001357 """Executes PostUploadHook() from a single presubmit script.
1358
1359 Args:
1360 script_text: The text of the presubmit script.
1361 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001362 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001363 change: The Change object.
1364
1365 Return:
1366 A list of results objects.
1367 """
1368 context = {}
1369 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001370 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1371 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001372 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001373 raise PresubmitFailure('"%s" had an exception.\n%s'
1374 % (presubmit_path, e))
1375
1376 function_name = 'PostUploadHook'
1377 if function_name not in context:
1378 return {}
1379 post_upload_hook = context[function_name]
1380 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1381 raise PresubmitFailure(
1382 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001383 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001384
1385
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001386def _MergeMasters(masters1, masters2):
1387 """Merges two master maps. Merges also the tests of each builder."""
1388 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001389 for (master, builders) in itertools.chain(masters1.items(),
1390 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001391 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001392 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001393 new_builders.setdefault(builder, set([])).update(tests)
1394 return result
1395
1396
rmistry@google.com5626a922015-02-26 14:03:30 +00001397def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001398 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001399 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001400 """Execute the post upload hook.
1401
1402 Args:
1403 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001404 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001405 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001406 """
1407 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001408 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001409 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001410 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001411 results = []
1412 executer = GetPostUploadExecuter()
1413 # The root presubmit file should be executed after the ones in subdirectories.
1414 # i.e. the specific post upload hooks should run before the general ones.
1415 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1416 presubmit_files.reverse()
1417
1418 for filename in presubmit_files:
1419 filename = os.path.abspath(filename)
1420 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001421 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001422 # Accept CRLF presubmit script.
1423 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1424 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001425 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001426
Edward Lemur6eb1d322020-02-27 22:20:15 +00001427 if not results:
1428 return 0
1429
1430 sys.stdout.write('\n')
1431 sys.stdout.write('** Post Upload Hook Messages **\n')
1432
1433 exit_code = 0
1434 for result in results:
1435 if result.fatal:
1436 exit_code = 1
1437 result.handle()
1438 sys.stdout.write('\n')
1439
1440 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001441
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001442class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001443 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001444 thread_pool=None, parallel=False, use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001445 """
1446 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001447 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001448 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001449 gerrit_obj: provides basic Gerrit codereview functionality.
1450 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001451 parallel: if true, all tests reported via input_api.RunTests for all
1452 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001453 use_python3: if true, will use python3 instead of python2 by default
1454 if USE_PYTHON3 is not specified.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001455 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001456 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001457 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001458 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001459 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001460 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001461 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001462 self.thread_pool = thread_pool
1463 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001464 self.use_python3 = use_python3
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001465
1466 def ExecPresubmitScript(self, script_text, presubmit_path):
1467 """Executes a single presubmit script.
1468
1469 Args:
1470 script_text: The text of the presubmit script.
1471 presubmit_path: The path to the presubmit file (this will be reported via
1472 input_api.PresubmitLocalPath()).
1473
1474 Return:
1475 A list of result objects, empty if no problems.
1476 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001477
chase@chromium.org8e416c82009-10-06 04:30:44 +00001478 # Change to the presubmit file's directory to support local imports.
1479 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001480 presubmit_dir = os.path.dirname(presubmit_path)
1481 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001482
1483 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001484 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001485 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001486 dry_run=self.dry_run, thread_pool=self.thread_pool,
1487 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001488 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001489 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001490
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001491 # Try to figure out whether these presubmit checks should be run under
1492 # python2 or python3. We need to do this without actually trying to
1493 # compile the text, since the text might compile in one but not the
1494 # other.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001495 m = re.search('^USE_PYTHON3 = (True|False)$', script_text,
1496 flags=re.MULTILINE)
1497 if m:
Josip Sokcevic6635baf2021-11-19 02:04:39 +00001498 use_python3 = m.group(1) == 'True'
Dirk Pranke6f0df682021-06-25 00:42:33 +00001499 else:
Josip Sokcevic6635baf2021-11-19 02:04:39 +00001500 use_python3 = self.use_python3
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001501 if (((sys.version_info.major == 2) and use_python3) or
1502 ((sys.version_info.major == 3) and not use_python3)):
1503 return []
1504
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001505 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001506 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1507 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001508 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001509 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001510
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001511 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001512
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001513 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001514 # Always use forward slashes, so that path is same in *nix and Windows
1515 root = input_api.change.RepositoryRoot()
1516 rel_path = os.path.relpath(presubmit_dir, root)
1517 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001518
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001519 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001520 host = project = ''
1521 if self.gerrit:
1522 host = self.gerrit.host or ''
1523 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001524
1525 # Prefix for test names
1526 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1527
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001528 # Perform all the desired presubmit checks.
1529 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001530
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001531 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001532 version = [
1533 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1534 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001535
Scott Leecc2fe9b2020-11-19 19:38:06 +00001536 with rdb_wrapper.client(prefix) as sink:
1537 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001538 # Copy the keys to prevent "dictionary changed size during iteration"
1539 # exception if checks add globals to context. E.g. sometimes the
1540 # Python runtime will add __warningregistry__.
1541 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001542 if not function_name.startswith('Check'):
1543 continue
1544 if function_name.endswith('Commit') and not self.committing:
1545 continue
1546 if function_name.endswith('Upload') and self.committing:
1547 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001548 logging.debug('Running %s in %s', function_name, presubmit_path)
1549 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001550 self._run_check_function(function_name, context, sink))
1551 logging.debug('Running %s done.', function_name)
1552 self.more_cc.extend(output_api.more_cc)
1553
1554 else: # Old format
1555 if self.committing:
1556 function_name = 'CheckChangeOnCommit'
1557 else:
1558 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001559 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001560 logging.debug('Running %s in %s', function_name, presubmit_path)
1561 results.extend(
1562 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563 logging.debug('Running %s done.', function_name)
1564 self.more_cc.extend(output_api.more_cc)
1565
1566 finally:
1567 for f in input_api._named_temporary_files:
1568 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001569
chase@chromium.org8e416c82009-10-06 04:30:44 +00001570 # Return the process to the original working directory.
1571 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001572 return results
1573
Scott Leecc2fe9b2020-11-19 19:38:06 +00001574 def _run_check_function(self, function_name, context, sink=None):
1575 """Evaluates and returns the result of a given presubmit function.
1576
1577 If sink is given, the result of the presubmit function will be reported
1578 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001579
1580 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001581 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001582 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001583 sink: an instance of ResultSink. None, by default.
1584 Returns:
1585 the result of the presubmit function call.
1586 """
1587 start_time = time_time()
1588 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001589 result = eval(function_name + '(*__args)', context)
1590 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001591 except Exception:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001592 if sink:
1593 elapsed_time = time_time() - start_time
1594 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbfe7d7092021-05-18 02:05:49 +00001595 # TODO(crbug.com/953884): replace reraise with native py3:
Allen Webbb65bbfe2021-05-11 21:22:01 +00001596 # raise .. from e
Allen Webbfe7d7092021-05-18 02:05:49 +00001597 e_type, e_value, e_tb = sys.exc_info()
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001598 print('Evaluation of %s failed: %s' % (function_name, e_value))
1599 six.reraise(e_type, e_value, e_tb)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001600
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001601 elapsed_time = time_time() - start_time
1602 if elapsed_time > 10.0:
1603 sys.stdout.write(
1604 '%s took %.1fs to run.\n' % (function_name, elapsed_time))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001605 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001606 status = rdb_wrapper.STATUS_PASS
1607 if any(r.fatal for r in result):
1608 status = rdb_wrapper.STATUS_FAIL
1609 sink.report(function_name, status, elapsed_time)
1610
1611 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001612
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001613 def _check_result_type(self, result):
1614 """Helper function which ensures result is a list, and all elements are
1615 instances of OutputApi.PresubmitResult"""
1616 if not isinstance(result, (tuple, list)):
1617 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1618 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1619 raise PresubmitFailure(
1620 'All presubmit results must be of types derived from '
1621 'output_api.PresubmitResult')
1622
1623
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001624def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001625 committing,
1626 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001627 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001628 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001629 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001630 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001631 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001632 json_output=None,
1633 use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001634 """Runs all presubmit checks that apply to the files in the change.
1635
1636 This finds all PRESUBMIT.py files in directories enclosing the files in the
1637 change (up to the repository root) and calls the relevant entrypoint function
1638 depending on whether the change is being committed or uploaded.
1639
1640 Prints errors, warnings and notifications. Prompts the user for warnings
1641 when needed.
1642
1643 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001644 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001645 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001646 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001647 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001648 may_prompt: Enable (y/n) questions on warning or error. If False,
1649 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001650 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001651 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001652 parallel: if true, all tests specified by input_api.RunTests in all
1653 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001654 use_python3: if true, default to using Python3 for presubmit checks
1655 rather than Python2.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001656 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001657 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001658 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001659 old_environ = os.environ
1660 try:
1661 # Make sure python subprocesses won't generate .pyc files.
1662 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001663 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001664
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001665 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001666 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001667 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001668 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001669 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001670 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1671 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001672 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001673 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001674 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001675 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001676 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001677 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001678 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001679 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001680 dry_run, thread_pool, parallel, use_python3)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001681 if default_presubmit:
1682 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001683 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001684 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1685 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1686 for filename in presubmit_files:
1687 filename = os.path.abspath(filename)
1688 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001689 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001690 # Accept CRLF presubmit script.
1691 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1692 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001693 results += thread_pool.RunAsync()
1694
Edward Lemur6eb1d322020-02-27 22:20:15 +00001695 messages = {}
1696 should_prompt = False
1697 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001698 for result in results:
1699 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001700 presubmits_failed = True
1701 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001702 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001703 should_prompt = True
1704 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001705 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001706 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001707
Edward Lemur6eb1d322020-02-27 22:20:15 +00001708 sys.stdout.write('\n')
1709 for name, items in messages.items():
1710 sys.stdout.write('** Presubmit %s **\n' % name)
1711 for item in items:
1712 item.handle()
1713 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001714
Edward Lemurecc27072020-01-06 16:42:34 +00001715 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001716 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001717 sys.stdout.write(
1718 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001719
Edward Lemur6eb1d322020-02-27 22:20:15 +00001720 if not should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001721 sys.stdout.write('%s presubmit checks passed.\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001722 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001723 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001724 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001725 presubmits_failed = not prompt_should_continue(
1726 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001727 else:
1728 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001729
Edward Lemur1dc66e12020-02-21 21:36:34 +00001730 if json_output:
1731 # Write the presubmit results to json output
1732 presubmit_results = {
1733 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001734 error.json_format()
1735 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001736 ],
1737 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001738 notification.json_format()
1739 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001740 ],
1741 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001742 warning.json_format()
1743 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001744 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001745 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001746 }
1747
1748 gclient_utils.FileWrite(
1749 json_output, json.dumps(presubmit_results, sort_keys=True))
1750
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001751 global _ASKED_FOR_FEEDBACK
1752 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001753 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001754 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001755 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1756 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1757 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001758 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001759
1760 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001761 finally:
1762 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001763
1764
Edward Lemur50984a62020-02-06 18:10:18 +00001765def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001766 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001767 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001768
1769 results = []
1770 for root, dirs, files in os.walk('.'):
1771 if '.svn' in dirs:
1772 dirs.remove('.svn')
1773 if '.git' in dirs:
1774 dirs.remove('.git')
1775 for name in files:
1776 if fnmatch.fnmatch(name, mask):
1777 results.append(os.path.join(root, name))
1778 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001779
1780
Edward Lemur50984a62020-02-06 18:10:18 +00001781def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001782 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001783 files = []
1784 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001785 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001786 return files
1787
1788
Edward Lemur50984a62020-02-06 18:10:18 +00001789def _parse_change(parser, options):
1790 """Process change options.
1791
1792 Args:
1793 parser: The parser used to parse the arguments from command line.
1794 options: The arguments parsed from command line.
1795 Returns:
1796 A GitChange if the change root is a git repository, or a Change otherwise.
1797 """
1798 if options.files and options.all_files:
1799 parser.error('<files> cannot be specified when --all-files is set.')
1800
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001801 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001802 if change_scm != 'git' and not options.files:
1803 parser.error('<files> is not optional for unversioned directories.')
1804
1805 if options.files:
1806 change_files = _parse_files(options.files, options.recursive)
1807 elif options.all_files:
1808 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001809 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001810 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001811 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001812
1813 logging.info('Found %d file(s).', len(change_files))
1814
1815 change_class = GitChange if change_scm == 'git' else Change
1816 return change_class(
1817 options.name,
1818 options.description,
1819 options.root,
1820 change_files,
1821 options.issue,
1822 options.patchset,
1823 options.author,
1824 upstream=options.upstream)
1825
1826
1827def _parse_gerrit_options(parser, options):
1828 """Process gerrit options.
1829
1830 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1831 options.gerrit_fetch is set.
1832
1833 Args:
1834 parser: The parser used to parse the arguments from command line.
1835 options: The arguments parsed from command line.
1836 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001837 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001838 """
1839 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001840 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001841 gerrit_obj = GerritAccessor(
1842 url=options.gerrit_url,
1843 project=options.gerrit_project,
1844 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001845
1846 if not options.gerrit_fetch:
1847 return gerrit_obj
1848
1849 if not options.gerrit_url or not options.issue or not options.patchset:
1850 parser.error(
1851 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1852
1853 options.author = gerrit_obj.GetChangeOwner(options.issue)
1854 options.description = gerrit_obj.GetChangeDescription(
1855 options.issue, options.patchset)
1856
1857 logging.info('Got author: "%s"', options.author)
1858 logging.info('Got description: """\n%s\n"""', options.description)
1859
1860 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001861
1862
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001863@contextlib.contextmanager
1864def canned_check_filter(method_names):
1865 filtered = {}
1866 try:
1867 for method_name in method_names:
1868 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001869 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001870 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001871 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1872 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1873 yield
1874 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001875 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001876 setattr(presubmit_canned_checks, name, method)
1877
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001878
sbc@chromium.org013731e2015-02-26 18:28:43 +00001879def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001880 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1881 hooks = parser.add_mutually_exclusive_group()
1882 hooks.add_argument('-c', '--commit', action='store_true',
1883 help='Use commit instead of upload checks.')
1884 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1885 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001886 hooks.add_argument('--post_upload', action='store_true',
1887 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001888 parser.add_argument('-r', '--recursive', action='store_true',
1889 help='Act recursively.')
1890 parser.add_argument('-v', '--verbose', action='count', default=0,
1891 help='Use 2 times for more debug info.')
1892 parser.add_argument('--name', default='no name')
1893 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001894 desc = parser.add_mutually_exclusive_group()
1895 desc.add_argument('--description', default='', help='The change description.')
1896 desc.add_argument('--description_file',
1897 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001898 parser.add_argument('--issue', type=int, default=0)
1899 parser.add_argument('--patchset', type=int, default=0)
1900 parser.add_argument('--root', default=os.getcwd(),
1901 help='Search for PRESUBMIT.py up to this directory. '
1902 'If inherit-review-settings-ok is present in this '
1903 'directory, parent directories up to the root file '
1904 'system directories will also be searched.')
1905 parser.add_argument('--upstream',
1906 help='Git only: the base ref or upstream branch against '
1907 'which the diff should be computed.')
1908 parser.add_argument('--default_presubmit')
1909 parser.add_argument('--may_prompt', action='store_true', default=False)
1910 parser.add_argument('--skip_canned', action='append', default=[],
1911 help='A list of checks to skip which appear in '
1912 'presubmit_canned_checks. Can be provided multiple times '
1913 'to skip multiple canned checks.')
1914 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1915 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001916 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1917 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001918 parser.add_argument('--gerrit_fetch', action='store_true',
1919 help=argparse.SUPPRESS)
1920 parser.add_argument('--parallel', action='store_true',
1921 help='Run all tests specified by input_api.RunTests in '
1922 'all PRESUBMIT files in parallel.')
1923 parser.add_argument('--json_output',
1924 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001925 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001926 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001927 parser.add_argument('files', nargs='*',
1928 help='List of files to be marked as modified when '
1929 'executing presubmit or post-upload hooks. fnmatch '
1930 'wildcards can also be used.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00001931 parser.add_argument('--use-python3', action='store_true',
1932 help='Use python3 for presubmit checks by default')
Edward Lemura5799e32020-01-17 19:26:51 +00001933 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001934
Erik Staabcca5c492020-04-16 17:40:07 +00001935 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001936 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001937 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001938 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001939 log_level = logging.INFO
1940 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1941 '%(filename)s] %(message)s')
1942 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001943
Edward Lemur227d5102020-02-25 23:45:35 +00001944 if options.description_file:
1945 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001946 gerrit_obj = _parse_gerrit_options(parser, options)
1947 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001948
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001949 try:
Edward Lemur75526302020-02-27 22:31:05 +00001950 if options.post_upload:
1951 return DoPostUploadExecuter(
1952 change,
1953 gerrit_obj,
1954 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001955 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001956 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001957 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001958 options.commit,
1959 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001960 options.default_presubmit,
1961 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001962 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001963 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001964 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001965 options.json_output,
1966 options.use_python3)
Raul Tambre7c938462019-05-24 16:35:35 +00001967 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001968 print(e, file=sys.stderr)
1969 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001970 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001971
1972
1973if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001974 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001975 try:
1976 sys.exit(main())
1977 except KeyboardInterrupt:
1978 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001979 sys.exit(2)