blob: 950cb1bbe8455cd7ef1a8ce2014da7657fcdd082 [file] [log] [blame]
Josip Sokcevic4de5dea2022-03-23 21:15:14 +00001#!/usr/bin/env python3
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners as owners_db
48import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020049import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000050import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000051import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000052import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000053import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Edward Lemurecc27072020-01-06 16:42:34 +000069def time_time():
70 # Use this so that it can be mocked in tests without interfering with python
71 # system machinery.
72 return time.time()
73
74
maruel@chromium.org899e1c12011-04-07 17:03:18 +000075class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000076 pass
77
78
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000080 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000081 self.name = name
82 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000084 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040085 self.kwargs['stdout'] = subprocess.PIPE
86 self.kwargs['stderr'] = subprocess.STDOUT
87 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000088 self.message = message
89 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000090 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000091
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000092
Edward Lesmes8e282792018-04-03 18:50:29 -040093# Adapted from
94# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
95#
96# An object that catches SIGINT sent to the Python process and notices
97# if processes passed to wait() die by SIGINT (we need to look for
98# both of those cases, because pressing Ctrl+C can result in either
99# the main process or one of the subprocesses getting the signal).
100#
101# Before a SIGINT is seen, wait(p) will simply call p.wait() and
102# return the result. Once a SIGINT has been seen (in the main process
103# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000104# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400105class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400106 sigint_returncodes = {-signal.SIGINT, # Unix
107 -1073741510, # Windows
108 }
109 def __init__(self):
110 self.__lock = threading.Lock()
111 self.__processes = set()
112 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000113 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400114
115 def __on_sigint(self):
116 self.__got_sigint = True
117 while self.__processes:
118 try:
119 self.__processes.pop().terminate()
120 except OSError:
121 pass
122
Edward Lemur9a5bb612019-09-26 02:01:52 +0000123 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400124 with self.__lock:
125 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000126 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400127
128 def got_sigint(self):
129 with self.__lock:
130 return self.__got_sigint
131
132 def wait(self, p, stdin):
133 with self.__lock:
134 if self.__got_sigint:
135 p.terminate()
136 self.__processes.add(p)
137 stdout, stderr = p.communicate(stdin)
138 code = p.returncode
139 with self.__lock:
140 self.__processes.discard(p)
141 if code in self.sigint_returncodes:
142 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400143 return stdout, stderr
144
145sigint_handler = SigintHandler()
146
147
Edward Lemurecc27072020-01-06 16:42:34 +0000148class Timer(object):
149 def __init__(self, timeout, fn):
150 self.completed = False
151 self._fn = fn
152 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
153
154 def __enter__(self):
155 if self._timer:
156 self._timer.start()
157 return self
158
159 def __exit__(self, _type, _value, _traceback):
160 if self._timer:
161 self._timer.cancel()
162
163 def _onTimer(self):
164 self._fn()
165 self.completed = True
166
167
Edward Lesmes8e282792018-04-03 18:50:29 -0400168class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000169 def __init__(self, pool_size=None, timeout=None):
170 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400171 self._pool_size = pool_size or multiprocessing.cpu_count()
172 self._messages = []
173 self._messages_lock = threading.Lock()
174 self._tests = []
175 self._tests_lock = threading.Lock()
176 self._nonparallel_tests = []
177
Edward Lemurecc27072020-01-06 16:42:34 +0000178 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000179 vpython = 'vpython'
180 if test.python3:
181 vpython += '3'
182 if sys.platform == 'win32':
183 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400184
185 cmd = test.cmd
186 if cmd[0] == 'python':
187 cmd = list(cmd)
188 cmd[0] = vpython
189 elif cmd[0].endswith('.py'):
190 cmd = [vpython] + cmd
191
Edward Lemur336e51f2019-11-14 21:42:04 +0000192 # On Windows, scripts on the current directory take precedence over PATH, so
193 # that when testing depot_tools on Windows, calling `vpython.bat` will
194 # execute the copy of vpython of the depot_tools under test instead of the
195 # one in the bot.
196 # As a workaround, we run the tests from the parent directory instead.
197 if (cmd[0] == vpython and
198 'cwd' in test.kwargs and
199 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
200 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
201 cmd[1] = os.path.join('depot_tools', cmd[1])
202
Edward Lemurecc27072020-01-06 16:42:34 +0000203 return cmd
204
205 def _RunWithTimeout(self, cmd, stdin, kwargs):
206 p = subprocess.Popen(cmd, **kwargs)
207 with Timer(self.timeout, p.terminate) as timer:
208 stdout, _ = sigint_handler.wait(p, stdin)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000209 stdout = stdout.decode('utf-8', 'ignore')
Edward Lemurecc27072020-01-06 16:42:34 +0000210 if timer.completed:
211 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevic6635baf2021-11-19 02:04:39 +0000212 return p.returncode, stdout
Edward Lemurecc27072020-01-06 16:42:34 +0000213
214 def CallCommand(self, test):
215 """Runs an external program.
216
Edward Lemura5799e32020-01-17 19:26:51 +0000217 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000218 to vpython invocations.
219 """
220 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400221 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000222 start = time_time()
223 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
224 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000225 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000226 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400227 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000228 '%s\n%s exec failure (%4.2fs)\n%s' % (
229 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000230
Edward Lemurecc27072020-01-06 16:42:34 +0000231 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400232 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000233 '%s\n%s (%4.2fs) failed\n%s' % (
234 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000235
Edward Lesmes8e282792018-04-03 18:50:29 -0400236 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000237 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400238
239 def AddTests(self, tests, parallel=True):
240 if parallel:
241 self._tests.extend(tests)
242 else:
243 self._nonparallel_tests.extend(tests)
244
245 def RunAsync(self):
246 self._messages = []
247
248 def _WorkerFn():
249 while True:
250 test = None
251 with self._tests_lock:
252 if not self._tests:
253 break
254 test = self._tests.pop()
255 result = self.CallCommand(test)
256 if result:
257 with self._messages_lock:
258 self._messages.append(result)
259
260 def _StartDaemon():
261 t = threading.Thread(target=_WorkerFn)
262 t.daemon = True
263 t.start()
264 return t
265
266 while self._nonparallel_tests:
267 test = self._nonparallel_tests.pop()
268 result = self.CallCommand(test)
269 if result:
270 self._messages.append(result)
271
272 if self._tests:
273 threads = [_StartDaemon() for _ in range(self._pool_size)]
274 for worker in threads:
275 worker.join()
276
277 return self._messages
278
279
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000280def normpath(path):
281 '''Version of os.path.normpath that also changes backward slashes to
282 forward slashes when not running on Windows.
283 '''
284 # This is safe to always do because the Windows version of os.path.normpath
285 # will replace forward slashes with backward slashes.
286 path = path.replace(os.sep, '/')
287 return os.path.normpath(path)
288
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000289
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000290def _RightHandSideLinesImpl(affected_files):
291 """Implements RightHandSideLines for InputApi and GclChange."""
292 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000293 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000294 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000295 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000296
297
Edward Lemur6eb1d322020-02-27 22:20:15 +0000298def prompt_should_continue(prompt_string):
299 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000300 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000301 response = sys.stdin.readline().strip().lower()
302 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000303
304
Josip Sokcevice293d3d2022-02-16 22:52:15 +0000305def _ShouldRunPresubmit(script_text, use_python3):
306 """Try to figure out whether these presubmit checks should be run under
307 python2 or python3. We need to do this without actually trying to
308 compile the text, since the text might compile in one but not the
309 other.
310
311 Args:
312 script_text: The text of the presubmit script.
313 use_python3: if true, will use python3 instead of python2 by default
314 if USE_PYTHON3 is not specified.
315
316 Return:
317 A boolean if presubmit should be executed
318 """
319 m = re.search('^USE_PYTHON3 = (True|False)$', script_text, flags=re.MULTILINE)
320 if m:
321 use_python3 = m.group(1) == 'True'
322
323 return ((sys.version_info.major == 2) and not use_python3) or \
324 ((sys.version_info.major == 3) and use_python3)
325
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000326# Top level object so multiprocessing can pickle
327# Public access through OutputApi object.
328class _PresubmitResult(object):
329 """Base class for result objects."""
330 fatal = False
331 should_prompt = False
332
333 def __init__(self, message, items=None, long_text=''):
334 """
335 message: A short one-line message to indicate errors.
336 items: A list of short strings to indicate where errors occurred.
337 long_text: multi-line text output, e.g. from another tool
338 """
339 self._message = message
340 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000341 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
342
343 @staticmethod
344 def _ensure_str(val):
345 """
346 val: A "stringish" value. Can be any of str, unicode or bytes.
347 returns: A str after applying encoding/decoding as needed.
348 Assumes/uses UTF-8 for relevant inputs/outputs.
349
350 We'd prefer to use six.ensure_str but our copy of six is old :(
351 """
352 if isinstance(val, str):
353 return val
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000354
Tom McKee61c72652021-07-20 11:56:32 +0000355 if six.PY2 and isinstance(val, unicode):
356 return val.encode()
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +0000357
358 if six.PY3 and isinstance(val, bytes):
Tom McKee61c72652021-07-20 11:56:32 +0000359 return val.decode()
360 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000361
Edward Lemur6eb1d322020-02-27 22:20:15 +0000362 def handle(self):
363 sys.stdout.write(self._message)
364 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000366 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000367 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000368 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000369 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000370 sys.stdout.write(' \\')
371 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000372 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000373 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000374 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000375 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000376 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000377
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000378 def json_format(self):
379 return {
380 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000381 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000382 'long_text': self._long_text,
383 'fatal': self.fatal
384 }
385
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000386
387# Top level object so multiprocessing can pickle
388# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000389class _PresubmitError(_PresubmitResult):
390 """A hard presubmit error."""
391 fatal = True
392
393
394# Top level object so multiprocessing can pickle
395# Public access through OutputApi object.
396class _PresubmitPromptWarning(_PresubmitResult):
397 """An warning that prompts the user if they want to continue."""
398 should_prompt = True
399
400
401# Top level object so multiprocessing can pickle
402# Public access through OutputApi object.
403class _PresubmitNotifyResult(_PresubmitResult):
404 """Just print something to the screen -- but it's not even a warning."""
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000405
406
407# Top level object so multiprocessing can pickle
408# Public access through OutputApi object.
409class _MailTextResult(_PresubmitResult):
410 """A warning that should be included in the review request email."""
411 def __init__(self, *args, **kwargs):
412 super(_MailTextResult, self).__init__()
413 raise NotImplementedError()
414
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000415class GerritAccessor(object):
416 """Limited Gerrit functionality for canned presubmit checks to work.
417
418 To avoid excessive Gerrit calls, caches the results.
419 """
420
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000421 def __init__(self, url=None, project=None, branch=None):
422 self.host = urlparse.urlparse(url).netloc if url else None
423 self.project = project
424 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000425 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000426 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000427
428 def _FetchChangeDetail(self, issue):
429 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100430 try:
431 return gerrit_util.GetChangeDetail(
432 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700433 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100434 except gerrit_util.GerritError as e:
435 if e.http_status == 404:
436 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
437 'no credentials to fetch issue details' % issue)
438 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000439
440 def GetChangeInfo(self, issue):
441 """Returns labels and all revisions (patchsets) for this issue.
442
443 The result is a dictionary according to Gerrit REST Api.
444 https://gerrit-review.googlesource.com/Documentation/rest-api.html
445
446 However, API isn't very clear what's inside, so see tests for example.
447 """
448 assert issue
449 cache_key = int(issue)
450 if cache_key not in self.cache:
451 self.cache[cache_key] = self._FetchChangeDetail(issue)
452 return self.cache[cache_key]
453
454 def GetChangeDescription(self, issue, patchset=None):
455 """If patchset is none, fetches current patchset."""
456 info = self.GetChangeInfo(issue)
457 # info is a reference to cache. We'll modify it here adding description to
458 # it to the right patchset, if it is not yet there.
459
460 # Find revision info for the patchset we want.
461 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000462 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000463 if str(rev_info['_number']) == str(patchset):
464 break
465 else:
466 raise Exception('patchset %s doesn\'t exist in issue %s' % (
467 patchset, issue))
468 else:
469 rev = info['current_revision']
470 rev_info = info['revisions'][rev]
471
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100472 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000473
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800474 def GetDestRef(self, issue):
475 ref = self.GetChangeInfo(issue)['branch']
476 if not ref.startswith('refs/'):
477 # NOTE: it is possible to create 'refs/x' branch,
478 # aka 'refs/heads/refs/x'. However, this is ill-advised.
479 ref = 'refs/heads/%s' % ref
480 return ref
481
Edward Lesmes02d4b822020-11-11 00:37:35 +0000482 def _GetApproversForLabel(self, issue, label):
483 change_info = self.GetChangeInfo(issue)
484 label_info = change_info.get('labels', {}).get(label, {})
485 values = label_info.get('values', {}).keys()
486 if not values:
487 return []
488 max_value = max(int(v) for v in values)
489 return [v for v in label_info.get('all', [])
490 if v.get('value', 0) == max_value]
491
Edward Lesmesc4566172021-03-19 16:55:13 +0000492 def IsBotCommitApproved(self, issue):
493 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
494
Edward Lesmescf49cb82020-11-11 01:08:36 +0000495 def IsOwnersOverrideApproved(self, issue):
496 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
497
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000498 def GetChangeOwner(self, issue):
499 return self.GetChangeInfo(issue)['owner']['email']
500
501 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700502 changeinfo = self.GetChangeInfo(issue)
503 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000504 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700505 else:
506 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
507 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000508
Edward Lemure4d329c2020-02-03 20:41:18 +0000509 def UpdateDescription(self, description, issue):
510 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
511
Edward Lesmes8170c292021-03-19 20:04:43 +0000512 def IsCodeOwnersEnabledOnRepo(self):
513 if self.code_owners_enabled is None:
514 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000515 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000516 return self.code_owners_enabled
517
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000518
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000519class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000520 """An instance of OutputApi gets passed to presubmit scripts so that they
521 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000522 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000523 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000524 PresubmitError = _PresubmitError
525 PresubmitPromptWarning = _PresubmitPromptWarning
526 PresubmitNotifyResult = _PresubmitNotifyResult
527 MailTextResult = _MailTextResult
528
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000529 def __init__(self, is_committing):
530 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800531 self.more_cc = []
532
533 def AppendCC(self, cc):
534 """Appends a user to cc for this change."""
535 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000536
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000537 def PresubmitPromptOrNotify(self, *args, **kwargs):
538 """Warn the user when uploading, but only notify if committing."""
539 if self.is_committing:
540 return self.PresubmitNotifyResult(*args, **kwargs)
541 return self.PresubmitPromptWarning(*args, **kwargs)
542
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000543
544class InputApi(object):
545 """An instance of this object is passed to presubmit scripts so they can
546 know stuff about the change they're looking at.
547 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000548 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800549 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000550
maruel@chromium.org3410d912009-06-09 20:56:16 +0000551 # File extensions that are considered source files from a style guide
552 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000553 #
554 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000555 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000556 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
557 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000558 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000559 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
560 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000561 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000562 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000563 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000564 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
565 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000566 )
567
568 # Path regexp that should be excluded from being considered containing source
569 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000570 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000571 r'testing_support[\\\/]google_appengine[\\\/].*',
572 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900573 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
574 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000575 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000576 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000577 r'.*\bDebug[\\\/].*',
578 r'.*\bRelease[\\\/].*',
579 r'.*\bxcodebuild[\\\/].*',
580 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000581 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000582 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000583 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000584 r'(|.*[\\\/])\.git[\\\/].*',
585 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000586 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000587 r'.+\.diff$',
588 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000589 )
590
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000591 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400592 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000593 """Builds an InputApi object.
594
595 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000596 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000597 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000598 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000599 gerrit_obj: provides basic Gerrit codereview functionality.
600 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400601 parallel: if true, all tests reported via input_api.RunTests for all
602 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000603 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000604 # Version number of the presubmit_support script.
605 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000606 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000607 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000608 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000609 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000610
Edward Lesmes8e282792018-04-03 18:50:29 -0400611 self.parallel = parallel
612 self.thread_pool = thread_pool or ThreadPool()
613
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000614 # We expose various modules and functions as attributes of the input_api
615 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900616 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000617 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000618 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700619 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000620 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000621 # TODO(yyanagisawa): stop exposing this when python3 become default.
622 # Since python3's tempfile has TemporaryDirectory, we do not need this.
623 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000624 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000625 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000626 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000627 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000628 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000629 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000630 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000631 self.re = re
632 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000633 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000635 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000636 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000637 if sys.version_info.major == 2:
638 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000639 self.urllib_request = urllib_request
640 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000641
Robert Iannucci50258932018-03-19 10:30:59 -0700642 self.is_windows = sys.platform == 'win32'
643
Edward Lemurb9646622019-10-25 20:57:35 +0000644 # Set python_executable to 'vpython' in order to allow scripts in other
645 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
646 # instead of inheriting the one in depot_tools.
647 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000648 # Offer a python 3 executable for use during the migration off of python 2.
649 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000650 self.environ = os.environ
651
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000652 # InputApi.platform is the platform you're currently running on.
653 self.platform = sys.platform
654
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000655 self.cpu_count = multiprocessing.cpu_count()
656
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000657 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000658 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000659
660 # We carry the canned checks so presubmit scripts can easily use them.
661 self.canned_checks = presubmit_canned_checks
662
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100663 # Temporary files we must manually remove at the end of a run.
664 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200665
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000666 self.owners_client = None
667 if self.gerrit:
668 self.owners_client = owners_client.GetCodeOwnersClient(
669 root=change.RepositoryRoot(),
670 upstream=change.UpstreamBranch(),
671 host=self.gerrit.host,
672 project=self.gerrit.project,
673 branch=self.gerrit.branch)
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000674 self.owners_db = owners_db.Database(
675 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200676 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000677 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000678 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000679
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000680 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000681 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000682 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800683 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000684 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000685 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000686 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
687 for (a, b, header) in cpplint._re_pattern_templates
688 ]
689
Edward Lemurecc27072020-01-06 16:42:34 +0000690 def SetTimeout(self, timeout):
691 self.thread_pool.timeout = timeout
692
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000693 def PresubmitLocalPath(self):
694 """Returns the local path of the presubmit script currently being run.
695
696 This is useful if you don't want to hard-code absolute paths in the
697 presubmit script. For example, It can be used to find another file
698 relative to the PRESUBMIT.py script, so the whole tree can be branched and
699 the presubmit script still works, without editing its content.
700 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000701 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000702
agable0b65e732016-11-22 09:25:46 -0800703 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000704 """Same as input_api.change.AffectedFiles() except only lists files
705 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000706 script, or subdirectories thereof. Note that files are listed using the OS
707 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000708 """
Edward Lemura5799e32020-01-17 19:26:51 +0000709 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000710 if len(dir_with_slash) == 1:
711 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000712
Edward Lemurb9830242019-10-30 22:19:20 +0000713 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000714 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000715 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000716
agable0b65e732016-11-22 09:25:46 -0800717 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000718 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800719 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000720 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000721 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000722
agable0b65e732016-11-22 09:25:46 -0800723 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000724 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800725 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000726
John Budorick16162372018-04-18 10:39:53 -0700727 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800728 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000729 in the same directory as the current presubmit script, or subdirectories
730 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000731 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000732 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000733 warn('AffectedTestableFiles(include_deletes=%s)'
734 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000735 category=DeprecationWarning,
736 stacklevel=2)
Josip Sokcevic4de5dea2022-03-23 21:15:14 +0000737 # pylint: disable=consider-using-generator
738 return [
739 x for x in self.AffectedFiles(include_deletes=False, **kwargs)
740 if x.IsTestableFile()
741 ]
agable0b65e732016-11-22 09:25:46 -0800742
743 def AffectedTextFiles(self, include_deletes=None):
744 """An alias to AffectedTestableFiles for backwards compatibility."""
745 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000746
Josip Sokcevic8c955952021-02-01 21:32:57 +0000747 def FilterSourceFile(self,
748 affected_file,
749 files_to_check=None,
750 files_to_skip=None,
751 allow_list=None,
752 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000753 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000754
local_bot64021412020-07-08 21:05:39 +0000755 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
756 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000757
758 The lists will be compiled as regular expression and
759 AffectedFile.LocalPath() needs to pass both list.
760
761 Note: Copy-paste this function to suit your needs or use a lambda function.
762 """
local_bot64021412020-07-08 21:05:39 +0000763 if files_to_check is None:
764 files_to_check = self.DEFAULT_FILES_TO_CHECK
765 if files_to_skip is None:
766 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000767
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000768 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000769 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000770 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000771 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000772 return True
773 return False
local_bot64021412020-07-08 21:05:39 +0000774 return (Find(affected_file, files_to_check) and
775 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000776
777 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800778 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000779
780 If source_file is None, InputApi.FilterSourceFile() is used.
781 """
782 if not source_file:
783 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000784 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000785
786 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000787 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000788
789 Only lists lines from new or modified text files in the change that are
790 contained by the directory of the currently executing presubmit script.
791
792 This is useful for doing line-by-line regex checks, like checking for
793 trailing whitespace.
794
795 Yields:
796 a 3 tuple:
797 the AffectedFile instance of the current file;
798 integer line number (1-based); and
799 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000800
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000801 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000802 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000803 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000804 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000805
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000806 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000807 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000808
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000809 Deny reading anything outside the repository.
810 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000811 if isinstance(file_item, AffectedFile):
812 file_item = file_item.AbsoluteLocalPath()
813 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000814 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000815 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000816
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100817 def CreateTemporaryFile(self, **kwargs):
818 """Returns a named temporary file that must be removed with a call to
819 RemoveTemporaryFiles().
820
821 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
822 except for |delete|, which is always set to False.
823
824 Presubmit checks that need to create a temporary file and pass it for
825 reading should use this function instead of NamedTemporaryFile(), as
826 Windows fails to open a file that is already open for writing.
827
828 with input_api.CreateTemporaryFile() as f:
829 f.write('xyz')
830 f.close()
831 input_api.subprocess.check_output(['script-that', '--reads-from',
832 f.name])
833
834
835 Note that callers of CreateTemporaryFile() should not worry about removing
836 any temporary file; this is done transparently by the presubmit handling
837 code.
838 """
839 if 'delete' in kwargs:
840 # Prevent users from passing |delete|; we take care of file deletion
841 # ourselves and this prevents unintuitive error messages when we pass
842 # delete=False and 'delete' is also in kwargs.
843 raise TypeError('CreateTemporaryFile() does not take a "delete" '
844 'argument, file deletion is handled automatically by '
845 'the same presubmit_support code that creates InputApi '
846 'objects.')
847 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
848 self._named_temporary_files.append(temp_file.name)
849 return temp_file
850
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000851 @property
852 def tbr(self):
853 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400854 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000855
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000856 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000857 tests = []
858 msgs = []
859 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400860 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000861 msgs.append(t)
862 else:
863 assert issubclass(t.message, _PresubmitResult)
864 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000865 if self.verbose:
866 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400867 if not t.kwargs.get('cwd'):
868 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400869 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000870 # When self.parallel is True (i.e. --parallel is passed as an option)
871 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
872 # will run all tests once all PRESUBMIT files are processed.
873 # Otherwise, it will run them and return the results.
874 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400875 msgs.extend(self.thread_pool.RunAsync())
876 return msgs
scottmg86099d72016-09-01 09:16:51 -0700877
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000878
nick@chromium.orgff526192013-06-10 19:30:26 +0000879class _DiffCache(object):
880 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000881 def __init__(self, upstream=None):
882 """Stores the upstream revision against which all diffs will be computed."""
883 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000884
885 def GetDiff(self, path, local_root):
886 """Get the diff for a particular path."""
887 raise NotImplementedError()
888
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700889 def GetOldContents(self, path, local_root):
890 """Get the old version for a particular path."""
891 raise NotImplementedError()
892
nick@chromium.orgff526192013-06-10 19:30:26 +0000893
nick@chromium.orgff526192013-06-10 19:30:26 +0000894class _GitDiffCache(_DiffCache):
895 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000896 def __init__(self, upstream):
897 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000898 self._diffs_by_file = None
899
900 def GetDiff(self, path, local_root):
901 if not self._diffs_by_file:
902 # Compute a single diff for all files and parse the output; should
903 # with git this is much faster than computing one diff for each file.
904 diffs = {}
905
906 # Don't specify any filenames below, because there are command line length
907 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000908 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
909 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000910
911 # This regex matches the path twice, separated by a space. Note that
912 # filename itself may contain spaces.
913 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
914 current_diff = []
915 keep_line_endings = True
916 for x in unified_diff.splitlines(keep_line_endings):
917 match = file_marker.match(x)
918 if match:
919 # Marks the start of a new per-file section.
920 diffs[match.group('filename')] = current_diff = [x]
921 elif x.startswith('diff --git'):
922 raise PresubmitFailure('Unexpected diff line: %s' % x)
923 else:
924 current_diff.append(x)
925
926 self._diffs_by_file = dict(
927 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
928
929 if path not in self._diffs_by_file:
Josip Sokcevicc1ab7342022-02-24 19:02:44 +0000930 # SCM didn't have any diff on this file. It could be that the file was not
931 # modified at all (e.g. user used --all flag in git cl presubmit).
932 # Intead of failing, return empty string.
933 # See: https://crbug.com/808346.
934 logging.warning('No diff found for %s' % path)
935 return ''
nick@chromium.orgff526192013-06-10 19:30:26 +0000936
937 return self._diffs_by_file[path]
938
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700939 def GetOldContents(self, path, local_root):
940 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
941
nick@chromium.orgff526192013-06-10 19:30:26 +0000942
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000943class AffectedFile(object):
944 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000945
946 DIFF_CACHE = _DiffCache
947
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000948 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800949 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000950 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000951 self._path = path
952 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000953 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000954 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000955 self._cached_changed_contents = None
956 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000957 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700958 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000959
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000960 def LocalPath(self):
961 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400962
963 This should be used for error messages but not for accessing files,
964 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
965 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000966 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000967 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000968
969 def AbsoluteLocalPath(self):
970 """Returns the absolute path of this file on the local disk.
971 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000972 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000973
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000974 def Action(self):
975 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000976 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000977
agable0b65e732016-11-22 09:25:46 -0800978 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000979 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000980
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000981 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000982 raise NotImplementedError() # Implement when needed
983
agable0b65e732016-11-22 09:25:46 -0800984 def IsTextFile(self):
985 """An alias to IsTestableFile for backwards compatibility."""
986 return self.IsTestableFile()
987
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700988 def OldContents(self):
989 """Returns an iterator over the lines in the old version of file.
990
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700991 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000992 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700993
994 Contents will be empty if the file is a directory or does not exist.
995 Note: The carriage returns (LF or CR) are stripped off.
996 """
997 return self._diff_cache.GetOldContents(self.LocalPath(),
998 self._local_root).splitlines()
999
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001000 def NewContents(self):
1001 """Returns an iterator over the lines in the new version of file.
1002
Edward Lemura5799e32020-01-17 19:26:51 +00001003 The new version is the file in the user's workspace, i.e. the 'right hand
1004 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001005
1006 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001007 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001008 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001009 if self._cached_new_contents is None:
1010 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -08001011 try:
1012 self._cached_new_contents = gclient_utils.FileRead(
1013 self.AbsoluteLocalPath(), 'rU').splitlines()
1014 except IOError:
1015 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +00001016 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001017 # log the filename since we're probably trying to read a binary
1018 # file, and shouldn't be.
1019 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
1020 raise
1021
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001022 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001023
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001024 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001025 """Returns a list of tuples (line number, line text) of all new lines.
1026
1027 This relies on the scm diff output describing each changed code section
1028 with a line of the form
1029
1030 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1031 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001032 # Don't return cached results when line breaks are requested.
1033 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001034 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001035 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001036 line_num = 0
1037
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001038 # The keeplinebreaks parameter to splitlines must be True or else the
1039 # CheckForWindowsLineEndings presubmit will be a NOP.
1040 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001041 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1042 if m:
1043 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001044 continue
1045 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001046 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001047 if not line.startswith('-'):
1048 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001049 # Don't cache results with line breaks.
1050 if keeplinebreaks:
1051 return result;
1052 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001053 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001054
maruel@chromium.org5de13972009-06-10 18:16:06 +00001055 def __str__(self):
1056 return self.LocalPath()
1057
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001058 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001059 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001060
maruel@chromium.org58407af2011-04-12 23:15:57 +00001061
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001062class GitAffectedFile(AffectedFile):
1063 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001064 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001065 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001066
nick@chromium.orgff526192013-06-10 19:30:26 +00001067 DIFF_CACHE = _GitDiffCache
1068
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001069 def __init__(self, *args, **kwargs):
1070 AffectedFile.__init__(self, *args, **kwargs)
1071 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001072 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001073
agable0b65e732016-11-22 09:25:46 -08001074 def IsTestableFile(self):
1075 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001076 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001077 # A deleted file is not testable.
1078 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001079 else:
agable0b65e732016-11-22 09:25:46 -08001080 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1081 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001082
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001083
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001084class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001085 """Describe a change.
1086
1087 Used directly by the presubmit scripts to query the current change being
1088 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001089
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001090 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001091 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001092 self.KEY: equivalent to tags['KEY']
1093 """
1094
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001095 _AFFECTED_FILES = AffectedFile
1096
Edward Lemura5799e32020-01-17 19:26:51 +00001097 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001098 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001099 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001100 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001101
maruel@chromium.org58407af2011-04-12 23:15:57 +00001102 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001103 self, name, description, local_root, files, issue, patchset, author,
1104 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001105 if files is None:
1106 files = []
1107 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001108 # Convert root into an absolute path.
1109 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001110 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001111 self.issue = issue
1112 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001113 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001114
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001115 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001116 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001117 self._description_without_tags = ''
1118 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001119
maruel@chromium.orge085d812011-10-10 19:49:15 +00001120 assert all(
1121 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1122
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001123 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001124 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001125 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1126 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001127 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001128
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001129 def UpstreamBranch(self):
1130 """Returns the upstream branch for the change."""
1131 return self._upstream
1132
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001133 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001134 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001135 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001136
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001137 def DescriptionText(self):
1138 """Returns the user-entered changelist description, minus tags.
1139
Edward Lemura5799e32020-01-17 19:26:51 +00001140 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001141 (whitespace permitted before and around) is considered a tag line. Such
1142 lines are stripped out of the description this function returns.
1143 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001144 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001145
1146 def FullDescriptionText(self):
1147 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001148 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001149
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001150 def SetDescriptionText(self, description):
1151 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001152
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001153 Also updates the list of tags."""
1154 self._full_description = description
1155
1156 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001157 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001158 description_without_tags = []
1159 self.tags = {}
1160 for line in self._full_description.splitlines():
1161 m = self.TAG_LINE_RE.match(line)
1162 if m:
1163 self.tags[m.group('key')] = m.group('value')
1164 else:
1165 description_without_tags.append(line)
1166
1167 # Change back to text and remove whitespace at end.
1168 self._description_without_tags = (
1169 '\n'.join(description_without_tags).rstrip())
1170
Edward Lemur69bb8be2020-02-03 20:37:38 +00001171 def AddDescriptionFooter(self, key, value):
1172 """Adds the given footer to the change description.
1173
1174 Args:
1175 key: A string with the key for the git footer. It must conform to
1176 the git footers format (i.e. 'List-Of-Tokens') and will be case
1177 normalized so that each token is title-cased.
1178 value: A string with the value for the git footer.
1179 """
1180 description = git_footers.add_footer(
1181 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1182 self.SetDescriptionText(description)
1183
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001184 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001185 """Returns the repository (checkout) root directory for this change,
1186 as an absolute path.
1187 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001188 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001189
1190 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001191 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001192 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001193 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001194 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001195
Edward Lemur69bb8be2020-02-03 20:37:38 +00001196 def GitFootersFromDescription(self):
1197 """Return the git footers present in the description.
1198
1199 Returns:
1200 footers: A dict of {footer: [values]} containing a multimap of the footers
1201 in the change description.
1202 """
1203 return git_footers.parse_footers(self.FullDescriptionText())
1204
Aaron Gablefc03e672017-05-15 14:09:42 -07001205 def BugsFromDescription(self):
1206 """Returns all bugs referenced in the commit description."""
Sean McAllister1e509c52021-10-25 17:54:25 +00001207 bug_tags = ['BUG', 'FIXED']
1208
1209 tags = []
1210 for tag in bug_tags:
1211 values = self.tags.get(tag)
1212 if values:
1213 tags += [value.strip() for value in values.split(',')]
1214
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001215 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001216 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001217 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001218 for unsplit_footer in unsplit_footers:
1219 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001220 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001221
1222 def ReviewersFromDescription(self):
1223 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001224 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001225 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1226 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001227
1228 def TBRsFromDescription(self):
1229 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001230 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001231 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1232 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001233 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001234 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001235
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001236 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001237 @property
1238 def BUG(self):
1239 return ','.join(self.BugsFromDescription())
1240 @property
1241 def R(self):
1242 return ','.join(self.ReviewersFromDescription())
1243 @property
1244 def TBR(self):
1245 return ','.join(self.TBRsFromDescription())
1246
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001247 def AllFiles(self, root=None):
1248 """List all files under source control in the repo."""
1249 raise NotImplementedError()
1250
agable0b65e732016-11-22 09:25:46 -08001251 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001252 """Returns a list of AffectedFile instances for all files in the change.
1253
1254 Args:
1255 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001256 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001257
1258 Returns:
1259 [AffectedFile(path, action), AffectedFile(path, action)]
1260 """
Edward Lemurb9830242019-10-30 22:19:20 +00001261 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001262
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001263 if include_deletes:
1264 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001265 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001266
John Budorick16162372018-04-18 10:39:53 -07001267 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001268 """Return a list of the existing text files in a change."""
1269 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001270 warn('AffectedTeestableFiles(include_deletes=%s)'
1271 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001272 category=DeprecationWarning,
1273 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001274 return list(filter(
1275 lambda x: x.IsTestableFile(),
1276 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001277
agable0b65e732016-11-22 09:25:46 -08001278 def AffectedTextFiles(self, include_deletes=None):
1279 """An alias to AffectedTestableFiles for backwards compatibility."""
1280 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001281
agable0b65e732016-11-22 09:25:46 -08001282 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001283 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001284 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001285
agable0b65e732016-11-22 09:25:46 -08001286 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001287 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001288 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001289
1290 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001291 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001292
1293 Lists lines from new or modified text files in the change.
1294
1295 This is useful for doing line-by-line regex checks, like checking for
1296 trailing whitespace.
1297
1298 Yields:
1299 a 3 tuple:
1300 the AffectedFile instance of the current file;
1301 integer line number (1-based); and
1302 the contents of the line as a string.
1303 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001304 return _RightHandSideLinesImpl(
1305 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001306 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001307
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001308 def OriginalOwnersFiles(self):
1309 """A map from path names of affected OWNERS files to their old content."""
1310 def owners_file_filter(f):
1311 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1312 files = self.AffectedFiles(file_filter=owners_file_filter)
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001313 return {f.LocalPath(): f.OldContents() for f in files}
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001314
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001315
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001316class GitChange(Change):
1317 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001318 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001319
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001320 def AllFiles(self, root=None):
1321 """List all files under source control in the repo."""
1322 root = root or self.RepositoryRoot()
1323 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001324 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001325 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001326
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001327
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001328def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001329 """Finds all presubmit files that apply to a given set of source files.
1330
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001331 If inherit-review-settings-ok is present right under root, looks for
1332 PRESUBMIT.py in directories enclosing root.
1333
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001334 Args:
1335 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001336 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001337
1338 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001339 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001340 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001341 files = [normpath(os.path.join(root, f)) for f in files]
1342
1343 # List all the individual directories containing files.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001344 directories = {os.path.dirname(f) for f in files}
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001345
1346 # Ignore root if inherit-review-settings-ok is present.
1347 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1348 root = None
1349
1350 # Collect all unique directories that may contain PRESUBMIT.py.
1351 candidates = set()
1352 for directory in directories:
1353 while True:
1354 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001355 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001356 candidates.add(directory)
1357 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001358 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001359 parent_dir = os.path.dirname(directory)
1360 if parent_dir == directory:
1361 # We hit the system root directory.
1362 break
1363 directory = parent_dir
1364
1365 # Look for PRESUBMIT.py in all candidate directories.
1366 results = []
1367 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001368 try:
1369 for f in os.listdir(directory):
1370 p = os.path.join(directory, f)
1371 if os.path.isfile(p) and re.match(
1372 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1373 results.append(p)
1374 except OSError:
1375 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001376
tobiasjs2836bcf2016-08-16 04:08:16 -07001377 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001378 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001379
1380
rmistry@google.com5626a922015-02-26 14:03:30 +00001381class GetPostUploadExecuter(object):
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001382 def __init__(self, use_python3):
1383 """
1384 Args:
1385 use_python3: if true, will use python3 instead of python2 by default
1386 if USE_PYTHON3 is not specified.
1387 """
1388 self.use_python3 = use_python3
1389
1390 def ExecPresubmitScript(self, script_text, presubmit_path, gerrit_obj,
1391 change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001392 """Executes PostUploadHook() from a single presubmit script.
1393
1394 Args:
1395 script_text: The text of the presubmit script.
1396 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001397 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001398 change: The Change object.
1399
1400 Return:
1401 A list of results objects.
1402 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001403 if not _ShouldRunPresubmit(script_text, self.use_python3):
1404 return {}
1405
rmistry@google.com5626a922015-02-26 14:03:30 +00001406 context = {}
1407 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001408 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1409 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001410 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001411 raise PresubmitFailure('"%s" had an exception.\n%s'
1412 % (presubmit_path, e))
1413
1414 function_name = 'PostUploadHook'
1415 if function_name not in context:
1416 return {}
1417 post_upload_hook = context[function_name]
1418 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1419 raise PresubmitFailure(
1420 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001421 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001422
1423
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001424def _MergeMasters(masters1, masters2):
1425 """Merges two master maps. Merges also the tests of each builder."""
1426 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001427 for (master, builders) in itertools.chain(masters1.items(),
1428 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001429 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001430 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001431 new_builders.setdefault(builder, set([])).update(tests)
1432 return result
1433
1434
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001435def DoPostUploadExecuter(change, gerrit_obj, verbose, use_python3=False):
rmistry@google.com5626a922015-02-26 14:03:30 +00001436 """Execute the post upload hook.
1437
1438 Args:
1439 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001440 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001441 verbose: Prints debug info.
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001442 use_python3: if true, default to using Python3 for presubmit checks
1443 rather than Python2.
rmistry@google.com5626a922015-02-26 14:03:30 +00001444 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001445 python_version = 'Python %s' % sys.version_info.major
1446 sys.stdout.write('Running %s post upload checks ...\n' % python_version)
rmistry@google.com5626a922015-02-26 14:03:30 +00001447 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001448 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001449 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001450 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001451 results = []
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001452 executer = GetPostUploadExecuter(use_python3)
rmistry@google.com5626a922015-02-26 14:03:30 +00001453 # The root presubmit file should be executed after the ones in subdirectories.
1454 # i.e. the specific post upload hooks should run before the general ones.
1455 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1456 presubmit_files.reverse()
1457
1458 for filename in presubmit_files:
1459 filename = os.path.abspath(filename)
1460 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001461 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001462 # Accept CRLF presubmit script.
1463 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1464 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001465 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001466
Edward Lemur6eb1d322020-02-27 22:20:15 +00001467 if not results:
1468 return 0
1469
1470 sys.stdout.write('\n')
1471 sys.stdout.write('** Post Upload Hook Messages **\n')
1472
1473 exit_code = 0
1474 for result in results:
1475 if result.fatal:
1476 exit_code = 1
1477 result.handle()
1478 sys.stdout.write('\n')
1479
1480 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001481
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001482class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001483 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001484 thread_pool=None, parallel=False, use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001485 """
1486 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001487 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001488 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001489 gerrit_obj: provides basic Gerrit codereview functionality.
1490 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001491 parallel: if true, all tests reported via input_api.RunTests for all
1492 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001493 use_python3: if true, will use python3 instead of python2 by default
1494 if USE_PYTHON3 is not specified.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001495 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001496 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001497 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001498 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001499 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001500 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001501 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001502 self.thread_pool = thread_pool
1503 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001504 self.use_python3 = use_python3
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001505
1506 def ExecPresubmitScript(self, script_text, presubmit_path):
1507 """Executes a single presubmit script.
1508
1509 Args:
1510 script_text: The text of the presubmit script.
1511 presubmit_path: The path to the presubmit file (this will be reported via
1512 input_api.PresubmitLocalPath()).
1513
1514 Return:
1515 A list of result objects, empty if no problems.
1516 """
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001517 if not _ShouldRunPresubmit(script_text, self.use_python3):
1518 return []
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001519
chase@chromium.org8e416c82009-10-06 04:30:44 +00001520 # Change to the presubmit file's directory to support local imports.
1521 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001522 presubmit_dir = os.path.dirname(presubmit_path)
1523 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001524
1525 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001526 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001527 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001528 dry_run=self.dry_run, thread_pool=self.thread_pool,
1529 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001530 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001531 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001532
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001533 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001534 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1535 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001536 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001537 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001538
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001539 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001540
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001541 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001542 # Always use forward slashes, so that path is same in *nix and Windows
1543 root = input_api.change.RepositoryRoot()
1544 rel_path = os.path.relpath(presubmit_dir, root)
1545 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001546
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001547 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001548 host = project = ''
1549 if self.gerrit:
1550 host = self.gerrit.host or ''
1551 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001552
1553 # Prefix for test names
1554 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1555
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001556 # Perform all the desired presubmit checks.
1557 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001558
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001559 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001560 version = [
1561 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1562 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001563
Scott Leecc2fe9b2020-11-19 19:38:06 +00001564 with rdb_wrapper.client(prefix) as sink:
1565 if version >= [2, 0, 0]:
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001566 # Copy the keys to prevent "dictionary changed size during iteration"
1567 # exception if checks add globals to context. E.g. sometimes the
1568 # Python runtime will add __warningregistry__.
1569 for function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001570 if not function_name.startswith('Check'):
1571 continue
1572 if function_name.endswith('Commit') and not self.committing:
1573 continue
1574 if function_name.endswith('Upload') and self.committing:
1575 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001576 logging.debug('Running %s in %s', function_name, presubmit_path)
1577 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001578 self._run_check_function(function_name, context, sink))
1579 logging.debug('Running %s done.', function_name)
1580 self.more_cc.extend(output_api.more_cc)
1581
1582 else: # Old format
1583 if self.committing:
1584 function_name = 'CheckChangeOnCommit'
1585 else:
1586 function_name = 'CheckChangeOnUpload'
Andrew Grievebdfb8f22022-02-02 21:56:47 +00001587 if function_name in list(context.keys()):
Scott Leecc2fe9b2020-11-19 19:38:06 +00001588 logging.debug('Running %s in %s', function_name, presubmit_path)
1589 results.extend(
1590 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001591 logging.debug('Running %s done.', function_name)
1592 self.more_cc.extend(output_api.more_cc)
1593
1594 finally:
1595 for f in input_api._named_temporary_files:
1596 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001597
chase@chromium.org8e416c82009-10-06 04:30:44 +00001598 # Return the process to the original working directory.
1599 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001600 return results
1601
Scott Leecc2fe9b2020-11-19 19:38:06 +00001602 def _run_check_function(self, function_name, context, sink=None):
1603 """Evaluates and returns the result of a given presubmit function.
1604
1605 If sink is given, the result of the presubmit function will be reported
1606 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001607
1608 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001609 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001610 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001611 sink: an instance of ResultSink. None, by default.
1612 Returns:
1613 the result of the presubmit function call.
1614 """
1615 start_time = time_time()
1616 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001617 result = eval(function_name + '(*__args)', context)
1618 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001619 except Exception:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001620 if sink:
1621 elapsed_time = time_time() - start_time
1622 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbfe7d7092021-05-18 02:05:49 +00001623 # TODO(crbug.com/953884): replace reraise with native py3:
Allen Webbb65bbfe2021-05-11 21:22:01 +00001624 # raise .. from e
Allen Webbfe7d7092021-05-18 02:05:49 +00001625 e_type, e_value, e_tb = sys.exc_info()
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001626 print('Evaluation of %s failed: %s' % (function_name, e_value))
1627 six.reraise(e_type, e_value, e_tb)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001628
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001629 elapsed_time = time_time() - start_time
1630 if elapsed_time > 10.0:
1631 sys.stdout.write(
1632 '%s took %.1fs to run.\n' % (function_name, elapsed_time))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001633 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001634 status = rdb_wrapper.STATUS_PASS
1635 if any(r.fatal for r in result):
1636 status = rdb_wrapper.STATUS_FAIL
1637 sink.report(function_name, status, elapsed_time)
1638
1639 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001640
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001641 def _check_result_type(self, result):
1642 """Helper function which ensures result is a list, and all elements are
1643 instances of OutputApi.PresubmitResult"""
1644 if not isinstance(result, (tuple, list)):
1645 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1646 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1647 raise PresubmitFailure(
1648 'All presubmit results must be of types derived from '
1649 'output_api.PresubmitResult')
1650
1651
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001652def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001653 committing,
1654 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001655 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001656 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001657 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001658 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001659 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001660 json_output=None,
1661 use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001662 """Runs all presubmit checks that apply to the files in the change.
1663
1664 This finds all PRESUBMIT.py files in directories enclosing the files in the
1665 change (up to the repository root) and calls the relevant entrypoint function
1666 depending on whether the change is being committed or uploaded.
1667
1668 Prints errors, warnings and notifications. Prompts the user for warnings
1669 when needed.
1670
1671 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001672 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001673 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001674 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001675 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001676 may_prompt: Enable (y/n) questions on warning or error. If False,
1677 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001678 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001679 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001680 parallel: if true, all tests specified by input_api.RunTests in all
1681 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001682 use_python3: if true, default to using Python3 for presubmit checks
1683 rather than Python2.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001684 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001685 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001686 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001687 old_environ = os.environ
1688 try:
1689 # Make sure python subprocesses won't generate .pyc files.
1690 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001691 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001692
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001693 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001694 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001695 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001696 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001697 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001698 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1699 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001700 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001701 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001702 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001703 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001704 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001705 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001706 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001707 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001708 dry_run, thread_pool, parallel, use_python3)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001709 if default_presubmit:
1710 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001711 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001712 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1713 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1714 for filename in presubmit_files:
1715 filename = os.path.abspath(filename)
1716 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001717 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001718 # Accept CRLF presubmit script.
1719 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1720 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001721 results += thread_pool.RunAsync()
1722
Edward Lemur6eb1d322020-02-27 22:20:15 +00001723 messages = {}
1724 should_prompt = False
1725 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001726 for result in results:
1727 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001728 presubmits_failed = True
1729 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001730 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001731 should_prompt = True
1732 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001733 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001734 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001735
Edward Lemur6eb1d322020-02-27 22:20:15 +00001736 for name, items in messages.items():
1737 sys.stdout.write('** Presubmit %s **\n' % name)
1738 for item in items:
1739 item.handle()
1740 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001741
Edward Lemurecc27072020-01-06 16:42:34 +00001742 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001743 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001744 sys.stdout.write(
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001745 'Presubmit checks took %.1fs to calculate.\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001746
Edward Lemur6eb1d322020-02-27 22:20:15 +00001747 if not should_prompt and not presubmits_failed:
Louis Romero4ca9e1c2022-03-10 10:29:11 +00001748 sys.stdout.write('%s presubmit checks passed.\n\n' % python_version)
Josip Sokcevic7592e0a2022-01-12 00:57:54 +00001749 elif should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001750 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001751 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001752 presubmits_failed = not prompt_should_continue(
1753 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001754 else:
1755 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001756
Edward Lemur1dc66e12020-02-21 21:36:34 +00001757 if json_output:
1758 # Write the presubmit results to json output
1759 presubmit_results = {
1760 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001761 error.json_format()
1762 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001763 ],
1764 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001765 notification.json_format()
1766 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001767 ],
1768 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001769 warning.json_format()
1770 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001771 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001772 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001773 }
1774
1775 gclient_utils.FileWrite(
1776 json_output, json.dumps(presubmit_results, sort_keys=True))
1777
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001778 global _ASKED_FOR_FEEDBACK
1779 # Ask for feedback one time out of 5.
Aravind Vasudevanc5f0cbb2022-01-24 23:56:57 +00001780 if (results and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001781 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001782 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1783 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1784 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001785 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001786
1787 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001788 finally:
1789 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001790
1791
Edward Lemur50984a62020-02-06 18:10:18 +00001792def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001793 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001794 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001795
1796 results = []
1797 for root, dirs, files in os.walk('.'):
1798 if '.svn' in dirs:
1799 dirs.remove('.svn')
1800 if '.git' in dirs:
1801 dirs.remove('.git')
1802 for name in files:
1803 if fnmatch.fnmatch(name, mask):
1804 results.append(os.path.join(root, name))
1805 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001806
1807
Edward Lemur50984a62020-02-06 18:10:18 +00001808def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001809 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001810 files = []
1811 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001812 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001813 return files
1814
1815
Edward Lemur50984a62020-02-06 18:10:18 +00001816def _parse_change(parser, options):
1817 """Process change options.
1818
1819 Args:
1820 parser: The parser used to parse the arguments from command line.
1821 options: The arguments parsed from command line.
1822 Returns:
1823 A GitChange if the change root is a git repository, or a Change otherwise.
1824 """
1825 if options.files and options.all_files:
1826 parser.error('<files> cannot be specified when --all-files is set.')
1827
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001828 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001829 if change_scm != 'git' and not options.files:
1830 parser.error('<files> is not optional for unversioned directories.')
1831
1832 if options.files:
1833 change_files = _parse_files(options.files, options.recursive)
1834 elif options.all_files:
1835 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001836 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001837 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001838 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001839
1840 logging.info('Found %d file(s).', len(change_files))
1841
1842 change_class = GitChange if change_scm == 'git' else Change
1843 return change_class(
1844 options.name,
1845 options.description,
1846 options.root,
1847 change_files,
1848 options.issue,
1849 options.patchset,
1850 options.author,
1851 upstream=options.upstream)
1852
1853
1854def _parse_gerrit_options(parser, options):
1855 """Process gerrit options.
1856
1857 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1858 options.gerrit_fetch is set.
1859
1860 Args:
1861 parser: The parser used to parse the arguments from command line.
1862 options: The arguments parsed from command line.
1863 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001864 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001865 """
1866 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001867 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001868 gerrit_obj = GerritAccessor(
1869 url=options.gerrit_url,
1870 project=options.gerrit_project,
1871 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001872
1873 if not options.gerrit_fetch:
1874 return gerrit_obj
1875
1876 if not options.gerrit_url or not options.issue or not options.patchset:
1877 parser.error(
1878 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1879
1880 options.author = gerrit_obj.GetChangeOwner(options.issue)
1881 options.description = gerrit_obj.GetChangeDescription(
1882 options.issue, options.patchset)
1883
1884 logging.info('Got author: "%s"', options.author)
1885 logging.info('Got description: """\n%s\n"""', options.description)
1886
1887 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001888
1889
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001890@contextlib.contextmanager
1891def canned_check_filter(method_names):
1892 filtered = {}
1893 try:
1894 for method_name in method_names:
1895 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001896 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001897 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001898 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1899 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1900 yield
1901 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001902 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001903 setattr(presubmit_canned_checks, name, method)
1904
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001905
sbc@chromium.org013731e2015-02-26 18:28:43 +00001906def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001907 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1908 hooks = parser.add_mutually_exclusive_group()
1909 hooks.add_argument('-c', '--commit', action='store_true',
1910 help='Use commit instead of upload checks.')
1911 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1912 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001913 hooks.add_argument('--post_upload', action='store_true',
1914 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001915 parser.add_argument('-r', '--recursive', action='store_true',
1916 help='Act recursively.')
1917 parser.add_argument('-v', '--verbose', action='count', default=0,
1918 help='Use 2 times for more debug info.')
1919 parser.add_argument('--name', default='no name')
1920 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001921 desc = parser.add_mutually_exclusive_group()
1922 desc.add_argument('--description', default='', help='The change description.')
1923 desc.add_argument('--description_file',
1924 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001925 parser.add_argument('--issue', type=int, default=0)
1926 parser.add_argument('--patchset', type=int, default=0)
1927 parser.add_argument('--root', default=os.getcwd(),
1928 help='Search for PRESUBMIT.py up to this directory. '
1929 'If inherit-review-settings-ok is present in this '
1930 'directory, parent directories up to the root file '
1931 'system directories will also be searched.')
1932 parser.add_argument('--upstream',
1933 help='Git only: the base ref or upstream branch against '
1934 'which the diff should be computed.')
1935 parser.add_argument('--default_presubmit')
1936 parser.add_argument('--may_prompt', action='store_true', default=False)
1937 parser.add_argument('--skip_canned', action='append', default=[],
1938 help='A list of checks to skip which appear in '
1939 'presubmit_canned_checks. Can be provided multiple times '
1940 'to skip multiple canned checks.')
1941 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1942 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001943 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1944 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001945 parser.add_argument('--gerrit_fetch', action='store_true',
1946 help=argparse.SUPPRESS)
1947 parser.add_argument('--parallel', action='store_true',
1948 help='Run all tests specified by input_api.RunTests in '
1949 'all PRESUBMIT files in parallel.')
1950 parser.add_argument('--json_output',
1951 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001952 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001953 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001954 parser.add_argument('files', nargs='*',
1955 help='List of files to be marked as modified when '
1956 'executing presubmit or post-upload hooks. fnmatch '
1957 'wildcards can also be used.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00001958 parser.add_argument('--use-python3', action='store_true',
1959 help='Use python3 for presubmit checks by default')
Edward Lemura5799e32020-01-17 19:26:51 +00001960 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001961
Erik Staabcca5c492020-04-16 17:40:07 +00001962 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001963 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001964 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001965 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001966 log_level = logging.INFO
1967 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1968 '%(filename)s] %(message)s')
1969 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001970
Edward Lemur227d5102020-02-25 23:45:35 +00001971 if options.description_file:
1972 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001973 gerrit_obj = _parse_gerrit_options(parser, options)
1974 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001975
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001976 try:
Edward Lemur75526302020-02-27 22:31:05 +00001977 if options.post_upload:
Josip Sokcevice293d3d2022-02-16 22:52:15 +00001978 return DoPostUploadExecuter(change, gerrit_obj, options.verbose,
1979 options.use_python3)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001980 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001981 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001982 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001983 options.commit,
1984 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001985 options.default_presubmit,
1986 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001987 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001988 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001989 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001990 options.json_output,
1991 options.use_python3)
Raul Tambre7c938462019-05-24 16:35:35 +00001992 except PresubmitFailure as e:
Josip Sokcevic0399e172022-03-21 23:11:51 +00001993 import utils
Raul Tambre80ee78e2019-05-06 22:41:05 +00001994 print(e, file=sys.stderr)
1995 print('Maybe your depot_tools is out of date?', file=sys.stderr)
Josip Sokcevic0399e172022-03-21 23:11:51 +00001996 print('depot_tools version: %s' % utils.depot_tools_version(),
1997 file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001998 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001999
2000
2001if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00002002 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00002003 try:
2004 sys.exit(main())
2005 except KeyboardInterrupt:
2006 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07002007 sys.exit(2)