blob: f8fd3c419f2a5d721fe3cb3ecf7c6975a0a79800 [file] [log] [blame]
maruel@chromium.org725f1c32011-04-01 20:24:54 +00001#!/usr/bin/env python
maruel@chromium.org3bbf2942012-01-10 16:52:06 +00002# Copyright (c) 2012 The Chromium Authors. All rights reserved.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00003# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6"""Enables directory-specific presubmit checks to run at upload and/or commit.
7"""
8
Raul Tambre80ee78e2019-05-06 22:41:05 +00009from __future__ import print_function
10
Saagar Sanghavi99816902020-08-11 22:41:25 +000011__version__ = '2.0.0'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000012
13# TODO(joi) Add caching where appropriate/needed. The API is designed to allow
14# caching (between all different invocations of presubmit scripts for a given
15# change). We should add it as our presubmit scripts start feeling slow.
16
Edward Lemura5799e32020-01-17 19:26:51 +000017import argparse
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +090018import ast # Exposed through the API.
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +000019import contextlib
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +000020import cpplint
dcheng091b7db2016-06-16 01:27:51 -070021import fnmatch # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000022import glob
asvitkine@chromium.org15169952011-09-27 14:30:53 +000023import inspect
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +000024import itertools
maruel@chromium.org4f6852c2012-04-20 20:39:20 +000025import json # Exposed through the API.
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +000026import logging
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000027import multiprocessing
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000028import os # Somewhat exposed through the API.
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000029import random
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000030import re # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040031import signal
Allen Webbfe7d7092021-05-18 02:05:49 +000032import six
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000033import sys # Parts exposed through API.
34import tempfile # Exposed through the API.
Edward Lesmes8e282792018-04-03 18:50:29 -040035import threading
jam@chromium.org2a891dc2009-08-20 20:33:37 +000036import time
Edward Lemurde9e3ca2019-10-24 21:13:31 +000037import traceback
maruel@chromium.org1487d532009-06-06 00:22:57 +000038import unittest # Exposed through the API.
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +000039from warnings import warn
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000040
41# Local imports.
maruel@chromium.org35625c72011-03-23 17:34:02 +000042import fix_encoding
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +000043import gclient_paths # Exposed through the API
44import gclient_utils
Aaron Gableb584c4f2017-04-26 16:28:08 -070045import git_footers
tandrii@chromium.org015ebae2016-04-25 19:37:22 +000046import gerrit_util
Edward Lesmes9ce03f82021-01-12 20:13:31 +000047import owners as owners_db
48import owners_client
Jochen Eisinger76f5fc62017-04-07 16:27:46 +020049import owners_finder
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000050import presubmit_canned_checks
Saagar Sanghavi9949ab72020-07-20 20:56:40 +000051import rdb_wrapper
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +000052import scm
maruel@chromium.org84f4fe32011-04-06 13:26:45 +000053import subprocess2 as subprocess # Exposed through the API.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000054
Edward Lemur16af3562019-10-17 22:11:33 +000055if sys.version_info.major == 2:
56 # TODO(1009814): Expose urllib2 only through urllib_request and urllib_error
57 import urllib2 # Exposed through the API.
58 import urlparse
59 import urllib2 as urllib_request
60 import urllib2 as urllib_error
61else:
62 import urllib.parse as urlparse
63 import urllib.request as urllib_request
64 import urllib.error as urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000065
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +000066# Ask for feedback only once in program lifetime.
67_ASKED_FOR_FEEDBACK = False
68
Edward Lemurecc27072020-01-06 16:42:34 +000069def time_time():
70 # Use this so that it can be mocked in tests without interfering with python
71 # system machinery.
72 return time.time()
73
74
maruel@chromium.org899e1c12011-04-07 17:03:18 +000075class PresubmitFailure(Exception):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +000076 pass
77
78
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000079class CommandData(object):
Edward Lemur940c2822019-08-23 00:34:25 +000080 def __init__(self, name, cmd, kwargs, message, python3=False):
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000081 self.name = name
82 self.cmd = cmd
Edward Lesmes8e282792018-04-03 18:50:29 -040083 self.stdin = kwargs.get('stdin', None)
Edward Lemur2d6b67c2019-08-23 22:25:41 +000084 self.kwargs = kwargs.copy()
Edward Lesmes8e282792018-04-03 18:50:29 -040085 self.kwargs['stdout'] = subprocess.PIPE
86 self.kwargs['stderr'] = subprocess.STDOUT
87 self.kwargs['stdin'] = subprocess.PIPE
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000088 self.message = message
89 self.info = None
Edward Lemur940c2822019-08-23 00:34:25 +000090 self.python3 = python3
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +000091
ilevy@chromium.orgbc117312013-04-20 03:57:56 +000092
Edward Lesmes8e282792018-04-03 18:50:29 -040093# Adapted from
94# https://github.com/google/gtest-parallel/blob/master/gtest_parallel.py#L37
95#
96# An object that catches SIGINT sent to the Python process and notices
97# if processes passed to wait() die by SIGINT (we need to look for
98# both of those cases, because pressing Ctrl+C can result in either
99# the main process or one of the subprocesses getting the signal).
100#
101# Before a SIGINT is seen, wait(p) will simply call p.wait() and
102# return the result. Once a SIGINT has been seen (in the main process
103# or a subprocess, including the one the current call is waiting for),
Edward Lemur9a5bb612019-09-26 02:01:52 +0000104# wait(p) will call p.terminate().
Edward Lesmes8e282792018-04-03 18:50:29 -0400105class SigintHandler(object):
Edward Lesmes8e282792018-04-03 18:50:29 -0400106 sigint_returncodes = {-signal.SIGINT, # Unix
107 -1073741510, # Windows
108 }
109 def __init__(self):
110 self.__lock = threading.Lock()
111 self.__processes = set()
112 self.__got_sigint = False
Edward Lemur9a5bb612019-09-26 02:01:52 +0000113 self.__previous_signal = signal.signal(signal.SIGINT, self.interrupt)
Edward Lesmes8e282792018-04-03 18:50:29 -0400114
115 def __on_sigint(self):
116 self.__got_sigint = True
117 while self.__processes:
118 try:
119 self.__processes.pop().terminate()
120 except OSError:
121 pass
122
Edward Lemur9a5bb612019-09-26 02:01:52 +0000123 def interrupt(self, signal_num, frame):
Edward Lesmes8e282792018-04-03 18:50:29 -0400124 with self.__lock:
125 self.__on_sigint()
Edward Lemur9a5bb612019-09-26 02:01:52 +0000126 self.__previous_signal(signal_num, frame)
Edward Lesmes8e282792018-04-03 18:50:29 -0400127
128 def got_sigint(self):
129 with self.__lock:
130 return self.__got_sigint
131
132 def wait(self, p, stdin):
133 with self.__lock:
134 if self.__got_sigint:
135 p.terminate()
136 self.__processes.add(p)
137 stdout, stderr = p.communicate(stdin)
138 code = p.returncode
139 with self.__lock:
140 self.__processes.discard(p)
141 if code in self.sigint_returncodes:
142 self.__on_sigint()
Edward Lesmes8e282792018-04-03 18:50:29 -0400143 return stdout, stderr
144
145sigint_handler = SigintHandler()
146
147
Edward Lemurecc27072020-01-06 16:42:34 +0000148class Timer(object):
149 def __init__(self, timeout, fn):
150 self.completed = False
151 self._fn = fn
152 self._timer = threading.Timer(timeout, self._onTimer) if timeout else None
153
154 def __enter__(self):
155 if self._timer:
156 self._timer.start()
157 return self
158
159 def __exit__(self, _type, _value, _traceback):
160 if self._timer:
161 self._timer.cancel()
162
163 def _onTimer(self):
164 self._fn()
165 self.completed = True
166
167
Edward Lesmes8e282792018-04-03 18:50:29 -0400168class ThreadPool(object):
Edward Lemurecc27072020-01-06 16:42:34 +0000169 def __init__(self, pool_size=None, timeout=None):
170 self.timeout = timeout
Edward Lesmes8e282792018-04-03 18:50:29 -0400171 self._pool_size = pool_size or multiprocessing.cpu_count()
172 self._messages = []
173 self._messages_lock = threading.Lock()
174 self._tests = []
175 self._tests_lock = threading.Lock()
176 self._nonparallel_tests = []
177
Edward Lemurecc27072020-01-06 16:42:34 +0000178 def _GetCommand(self, test):
Edward Lemur940c2822019-08-23 00:34:25 +0000179 vpython = 'vpython'
180 if test.python3:
181 vpython += '3'
182 if sys.platform == 'win32':
183 vpython += '.bat'
Edward Lesmes8e282792018-04-03 18:50:29 -0400184
185 cmd = test.cmd
186 if cmd[0] == 'python':
187 cmd = list(cmd)
188 cmd[0] = vpython
189 elif cmd[0].endswith('.py'):
190 cmd = [vpython] + cmd
191
Edward Lemur336e51f2019-11-14 21:42:04 +0000192 # On Windows, scripts on the current directory take precedence over PATH, so
193 # that when testing depot_tools on Windows, calling `vpython.bat` will
194 # execute the copy of vpython of the depot_tools under test instead of the
195 # one in the bot.
196 # As a workaround, we run the tests from the parent directory instead.
197 if (cmd[0] == vpython and
198 'cwd' in test.kwargs and
199 os.path.basename(test.kwargs['cwd']) == 'depot_tools'):
200 test.kwargs['cwd'] = os.path.dirname(test.kwargs['cwd'])
201 cmd[1] = os.path.join('depot_tools', cmd[1])
202
Edward Lemurecc27072020-01-06 16:42:34 +0000203 return cmd
204
205 def _RunWithTimeout(self, cmd, stdin, kwargs):
206 p = subprocess.Popen(cmd, **kwargs)
207 with Timer(self.timeout, p.terminate) as timer:
208 stdout, _ = sigint_handler.wait(p, stdin)
209 if timer.completed:
210 stdout = 'Process timed out after %ss\n%s' % (self.timeout, stdout)
Josip Sokcevicb4a7cff2021-06-09 22:56:42 +0000211 return p.returncode, stdout.decode('utf-8', 'ignore');
Edward Lemurecc27072020-01-06 16:42:34 +0000212
213 def CallCommand(self, test):
214 """Runs an external program.
215
Edward Lemura5799e32020-01-17 19:26:51 +0000216 This function converts invocation of .py files and invocations of 'python'
Edward Lemurecc27072020-01-06 16:42:34 +0000217 to vpython invocations.
218 """
219 cmd = self._GetCommand(test)
Edward Lesmes8e282792018-04-03 18:50:29 -0400220 try:
Edward Lemurecc27072020-01-06 16:42:34 +0000221 start = time_time()
222 returncode, stdout = self._RunWithTimeout(cmd, test.stdin, test.kwargs)
223 duration = time_time() - start
Edward Lemur7cf94382019-11-15 22:36:41 +0000224 except Exception:
Edward Lemurecc27072020-01-06 16:42:34 +0000225 duration = time_time() - start
Edward Lesmes8e282792018-04-03 18:50:29 -0400226 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000227 '%s\n%s exec failure (%4.2fs)\n%s' % (
228 test.name, ' '.join(cmd), duration, traceback.format_exc()))
Edward Lemurde9e3ca2019-10-24 21:13:31 +0000229
Edward Lemurecc27072020-01-06 16:42:34 +0000230 if returncode != 0:
Edward Lesmes8e282792018-04-03 18:50:29 -0400231 return test.message(
Edward Lemur7cf94382019-11-15 22:36:41 +0000232 '%s\n%s (%4.2fs) failed\n%s' % (
233 test.name, ' '.join(cmd), duration, stdout))
Edward Lemurecc27072020-01-06 16:42:34 +0000234
Edward Lesmes8e282792018-04-03 18:50:29 -0400235 if test.info:
Edward Lemur7cf94382019-11-15 22:36:41 +0000236 return test.info('%s\n%s (%4.2fs)' % (test.name, ' '.join(cmd), duration))
Edward Lesmes8e282792018-04-03 18:50:29 -0400237
238 def AddTests(self, tests, parallel=True):
239 if parallel:
240 self._tests.extend(tests)
241 else:
242 self._nonparallel_tests.extend(tests)
243
244 def RunAsync(self):
245 self._messages = []
246
247 def _WorkerFn():
248 while True:
249 test = None
250 with self._tests_lock:
251 if not self._tests:
252 break
253 test = self._tests.pop()
254 result = self.CallCommand(test)
255 if result:
256 with self._messages_lock:
257 self._messages.append(result)
258
259 def _StartDaemon():
260 t = threading.Thread(target=_WorkerFn)
261 t.daemon = True
262 t.start()
263 return t
264
265 while self._nonparallel_tests:
266 test = self._nonparallel_tests.pop()
267 result = self.CallCommand(test)
268 if result:
269 self._messages.append(result)
270
271 if self._tests:
272 threads = [_StartDaemon() for _ in range(self._pool_size)]
273 for worker in threads:
274 worker.join()
275
276 return self._messages
277
278
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000279def normpath(path):
280 '''Version of os.path.normpath that also changes backward slashes to
281 forward slashes when not running on Windows.
282 '''
283 # This is safe to always do because the Windows version of os.path.normpath
284 # will replace forward slashes with backward slashes.
285 path = path.replace(os.sep, '/')
286 return os.path.normpath(path)
287
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000288
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000289def _RightHandSideLinesImpl(affected_files):
290 """Implements RightHandSideLines for InputApi and GclChange."""
291 for af in affected_files:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000292 lines = af.ChangedContents()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000293 for line in lines:
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000294 yield (af, line[0], line[1])
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000295
296
Edward Lemur6eb1d322020-02-27 22:20:15 +0000297def prompt_should_continue(prompt_string):
298 sys.stdout.write(prompt_string)
Dirk Pranke7288f882021-06-03 18:01:30 +0000299 sys.stdout.flush()
Edward Lemur6eb1d322020-02-27 22:20:15 +0000300 response = sys.stdin.readline().strip().lower()
301 return response in ('y', 'yes')
dpranke@chromium.org5ac21012011-03-16 02:58:25 +0000302
303
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000304# Top level object so multiprocessing can pickle
305# Public access through OutputApi object.
306class _PresubmitResult(object):
307 """Base class for result objects."""
308 fatal = False
309 should_prompt = False
310
311 def __init__(self, message, items=None, long_text=''):
312 """
313 message: A short one-line message to indicate errors.
314 items: A list of short strings to indicate where errors occurred.
315 long_text: multi-line text output, e.g. from another tool
316 """
317 self._message = message
318 self._items = items or []
Tom McKee61c72652021-07-20 11:56:32 +0000319 self._long_text = _PresubmitResult._ensure_str(long_text.rstrip())
320
321 @staticmethod
322 def _ensure_str(val):
323 """
324 val: A "stringish" value. Can be any of str, unicode or bytes.
325 returns: A str after applying encoding/decoding as needed.
326 Assumes/uses UTF-8 for relevant inputs/outputs.
327
328 We'd prefer to use six.ensure_str but our copy of six is old :(
329 """
330 if isinstance(val, str):
331 return val
332 if six.PY2 and isinstance(val, unicode):
333 return val.encode()
334 elif six.PY3 and isinstance(val, bytes):
335 return val.decode()
336 raise ValueError("Unknown string type %s" % type(val))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000337
Edward Lemur6eb1d322020-02-27 22:20:15 +0000338 def handle(self):
339 sys.stdout.write(self._message)
340 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000341 for index, item in enumerate(self._items):
Edward Lemur6eb1d322020-02-27 22:20:15 +0000342 sys.stdout.write(' ')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000343 # Write separately in case it's unicode.
Edward Lemur6eb1d322020-02-27 22:20:15 +0000344 sys.stdout.write(str(item))
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000345 if index < len(self._items) - 1:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000346 sys.stdout.write(' \\')
347 sys.stdout.write('\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000348 if self._long_text:
Edward Lemur6eb1d322020-02-27 22:20:15 +0000349 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000350 # Write separately in case it's unicode.
Tom McKee61c72652021-07-20 11:56:32 +0000351 sys.stdout.write(self._long_text)
Edward Lemur6eb1d322020-02-27 22:20:15 +0000352 sys.stdout.write('\n***************\n')
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000353
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000354 def json_format(self):
355 return {
356 'message': self._message,
Debrian Figueroa6095d402019-06-28 18:47:18 +0000357 'items': [str(item) for item in self._items],
Debrian Figueroadd2737e2019-06-21 23:50:13 +0000358 'long_text': self._long_text,
359 'fatal': self.fatal
360 }
361
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000362
363# Top level object so multiprocessing can pickle
364# Public access through OutputApi object.
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000365class _PresubmitError(_PresubmitResult):
366 """A hard presubmit error."""
367 fatal = True
368
369
370# Top level object so multiprocessing can pickle
371# Public access through OutputApi object.
372class _PresubmitPromptWarning(_PresubmitResult):
373 """An warning that prompts the user if they want to continue."""
374 should_prompt = True
375
376
377# Top level object so multiprocessing can pickle
378# Public access through OutputApi object.
379class _PresubmitNotifyResult(_PresubmitResult):
380 """Just print something to the screen -- but it's not even a warning."""
381 pass
382
383
384# Top level object so multiprocessing can pickle
385# Public access through OutputApi object.
386class _MailTextResult(_PresubmitResult):
387 """A warning that should be included in the review request email."""
388 def __init__(self, *args, **kwargs):
389 super(_MailTextResult, self).__init__()
390 raise NotImplementedError()
391
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000392class GerritAccessor(object):
393 """Limited Gerrit functionality for canned presubmit checks to work.
394
395 To avoid excessive Gerrit calls, caches the results.
396 """
397
Edward Lesmeseb1bd622021-03-01 19:54:07 +0000398 def __init__(self, url=None, project=None, branch=None):
399 self.host = urlparse.urlparse(url).netloc if url else None
400 self.project = project
401 self.branch = branch
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000402 self.cache = {}
Edward Lesmes8170c292021-03-19 20:04:43 +0000403 self.code_owners_enabled = None
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000404
405 def _FetchChangeDetail(self, issue):
406 # Separate function to be easily mocked in tests.
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100407 try:
408 return gerrit_util.GetChangeDetail(
409 self.host, str(issue),
Aaron Gable6f5a8d92017-04-18 14:49:05 -0700410 ['ALL_REVISIONS', 'DETAILED_LABELS', 'ALL_COMMITS'])
Andrii Shyshkalovc6c8b4c2016-11-09 20:51:20 +0100411 except gerrit_util.GerritError as e:
412 if e.http_status == 404:
413 raise Exception('Either Gerrit issue %s doesn\'t exist, or '
414 'no credentials to fetch issue details' % issue)
415 raise
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000416
417 def GetChangeInfo(self, issue):
418 """Returns labels and all revisions (patchsets) for this issue.
419
420 The result is a dictionary according to Gerrit REST Api.
421 https://gerrit-review.googlesource.com/Documentation/rest-api.html
422
423 However, API isn't very clear what's inside, so see tests for example.
424 """
425 assert issue
426 cache_key = int(issue)
427 if cache_key not in self.cache:
428 self.cache[cache_key] = self._FetchChangeDetail(issue)
429 return self.cache[cache_key]
430
431 def GetChangeDescription(self, issue, patchset=None):
432 """If patchset is none, fetches current patchset."""
433 info = self.GetChangeInfo(issue)
434 # info is a reference to cache. We'll modify it here adding description to
435 # it to the right patchset, if it is not yet there.
436
437 # Find revision info for the patchset we want.
438 if patchset is not None:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +0000439 for rev, rev_info in info['revisions'].items():
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000440 if str(rev_info['_number']) == str(patchset):
441 break
442 else:
443 raise Exception('patchset %s doesn\'t exist in issue %s' % (
444 patchset, issue))
445 else:
446 rev = info['current_revision']
447 rev_info = info['revisions'][rev]
448
Andrii Shyshkalov9c3a4642017-01-24 17:41:22 +0100449 return rev_info['commit']['message']
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000450
Mun Yong Jang603d01e2017-12-19 16:38:30 -0800451 def GetDestRef(self, issue):
452 ref = self.GetChangeInfo(issue)['branch']
453 if not ref.startswith('refs/'):
454 # NOTE: it is possible to create 'refs/x' branch,
455 # aka 'refs/heads/refs/x'. However, this is ill-advised.
456 ref = 'refs/heads/%s' % ref
457 return ref
458
Edward Lesmes02d4b822020-11-11 00:37:35 +0000459 def _GetApproversForLabel(self, issue, label):
460 change_info = self.GetChangeInfo(issue)
461 label_info = change_info.get('labels', {}).get(label, {})
462 values = label_info.get('values', {}).keys()
463 if not values:
464 return []
465 max_value = max(int(v) for v in values)
466 return [v for v in label_info.get('all', [])
467 if v.get('value', 0) == max_value]
468
Edward Lesmesc4566172021-03-19 16:55:13 +0000469 def IsBotCommitApproved(self, issue):
470 return bool(self._GetApproversForLabel(issue, 'Bot-Commit'))
471
Edward Lesmescf49cb82020-11-11 01:08:36 +0000472 def IsOwnersOverrideApproved(self, issue):
473 return bool(self._GetApproversForLabel(issue, 'Owners-Override'))
474
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000475 def GetChangeOwner(self, issue):
476 return self.GetChangeInfo(issue)['owner']['email']
477
478 def GetChangeReviewers(self, issue, approving_only=True):
Aaron Gable8b478f02017-07-31 15:33:19 -0700479 changeinfo = self.GetChangeInfo(issue)
480 if approving_only:
Edward Lesmes02d4b822020-11-11 00:37:35 +0000481 reviewers = self._GetApproversForLabel(issue, 'Code-Review')
Aaron Gable8b478f02017-07-31 15:33:19 -0700482 else:
483 reviewers = changeinfo.get('reviewers', {}).get('REVIEWER', [])
484 return [r.get('email') for r in reviewers]
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000485
Edward Lemure4d329c2020-02-03 20:41:18 +0000486 def UpdateDescription(self, description, issue):
487 gerrit_util.SetCommitMessage(self.host, issue, description, notify='NONE')
488
Edward Lesmes8170c292021-03-19 20:04:43 +0000489 def IsCodeOwnersEnabledOnRepo(self):
490 if self.code_owners_enabled is None:
491 self.code_owners_enabled = gerrit_util.IsCodeOwnersEnabledOnRepo(
Edward Lesmes392c4072021-03-19 21:58:45 +0000492 self.host, self.project)
Edward Lesmes8170c292021-03-19 20:04:43 +0000493 return self.code_owners_enabled
494
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000495
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000496class OutputApi(object):
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000497 """An instance of OutputApi gets passed to presubmit scripts so that they
498 can output various types of results.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000499 """
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000500 PresubmitResult = _PresubmitResult
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000501 PresubmitError = _PresubmitError
502 PresubmitPromptWarning = _PresubmitPromptWarning
503 PresubmitNotifyResult = _PresubmitNotifyResult
504 MailTextResult = _MailTextResult
505
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000506 def __init__(self, is_committing):
507 self.is_committing = is_committing
Daniel Cheng7227d212017-11-17 08:12:37 -0800508 self.more_cc = []
509
510 def AppendCC(self, cc):
511 """Appends a user to cc for this change."""
512 self.more_cc.append(cc)
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000513
wez@chromium.orga6d011e2013-03-26 17:31:49 +0000514 def PresubmitPromptOrNotify(self, *args, **kwargs):
515 """Warn the user when uploading, but only notify if committing."""
516 if self.is_committing:
517 return self.PresubmitNotifyResult(*args, **kwargs)
518 return self.PresubmitPromptWarning(*args, **kwargs)
519
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000520
521class InputApi(object):
522 """An instance of this object is passed to presubmit scripts so they can
523 know stuff about the change they're looking at.
524 """
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000525 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800526 # pylint: disable=no-self-use
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000527
maruel@chromium.org3410d912009-06-09 20:56:16 +0000528 # File extensions that are considered source files from a style guide
529 # perspective. Don't modify this list from a presubmit script!
maruel@chromium.orgc33455a2011-06-24 19:14:18 +0000530 #
531 # Files without an extension aren't included in the list. If you want to
local_bot30f774e2020-06-25 18:23:34 +0000532 # filter them as source files, add r'(^|.*?[\\\/])[^.]+$' to the allow list.
local_bot64021412020-07-08 21:05:39 +0000533 # Note that ALL CAPS files are skipped in DEFAULT_FILES_TO_SKIP below.
534 DEFAULT_FILES_TO_CHECK = (
maruel@chromium.org3410d912009-06-09 20:56:16 +0000535 # C++ and friends
Edward Lemura5799e32020-01-17 19:26:51 +0000536 r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$',
537 r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000538 # Scripts
Edward Lemura5799e32020-01-17 19:26:51 +0000539 r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000540 # Other
Edward Lemura5799e32020-01-17 19:26:51 +0000541 r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$',
542 r'.+\.fidl$'
maruel@chromium.org3410d912009-06-09 20:56:16 +0000543 )
544
545 # Path regexp that should be excluded from being considered containing source
546 # files. Don't modify this list from a presubmit script!
local_bot64021412020-07-08 21:05:39 +0000547 DEFAULT_FILES_TO_SKIP = (
Edward Lemura5799e32020-01-17 19:26:51 +0000548 r'testing_support[\\\/]google_appengine[\\\/].*',
549 r'.*\bexperimental[\\\/].*',
Kent Tamura179dd1e2018-04-26 15:07:41 +0900550 # Exclude third_party/.* but NOT third_party/{WebKit,blink}
551 # (crbug.com/539768 and crbug.com/836555).
Edward Lemura5799e32020-01-17 19:26:51 +0000552 r'.*\bthird_party[\\\/](?!(WebKit|blink)[\\\/]).*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000553 # Output directories (just in case)
Edward Lemura5799e32020-01-17 19:26:51 +0000554 r'.*\bDebug[\\\/].*',
555 r'.*\bRelease[\\\/].*',
556 r'.*\bxcodebuild[\\\/].*',
557 r'.*\bout[\\\/].*',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000558 # All caps files like README and LICENCE.
Edward Lemura5799e32020-01-17 19:26:51 +0000559 r'.*\b[A-Z0-9_]{2,}$',
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000560 # SCM (can happen in dual SCM configuration). (Slightly over aggressive)
Edward Lemura5799e32020-01-17 19:26:51 +0000561 r'(|.*[\\\/])\.git[\\\/].*',
562 r'(|.*[\\\/])\.svn[\\\/].*',
maruel@chromium.org7ccb4bb2011-11-07 20:26:20 +0000563 # There is no point in processing a patch file.
Edward Lemura5799e32020-01-17 19:26:51 +0000564 r'.+\.diff$',
565 r'.+\.patch$',
maruel@chromium.org3410d912009-06-09 20:56:16 +0000566 )
567
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000568 def __init__(self, change, presubmit_path, is_committing,
Edward Lesmes8e282792018-04-03 18:50:29 -0400569 verbose, gerrit_obj, dry_run=None, thread_pool=None, parallel=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000570 """Builds an InputApi object.
571
572 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000573 change: A presubmit.Change object.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000574 presubmit_path: The path to the presubmit script being processed.
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000575 is_committing: True if the change is about to be committed.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000576 gerrit_obj: provides basic Gerrit codereview functionality.
577 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -0400578 parallel: if true, all tests reported via input_api.RunTests for all
579 PRESUBMIT files will be run in parallel.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000580 """
maruel@chromium.org9711bba2009-05-22 23:51:39 +0000581 # Version number of the presubmit_support script.
582 self.version = [int(x) for x in __version__.split('.')]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000583 self.change = change
maruel@chromium.orgd7dccf52009-06-06 18:51:58 +0000584 self.is_committing = is_committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +0000585 self.gerrit = gerrit_obj
tandrii@chromium.org57bafac2016-04-28 05:09:03 +0000586 self.dry_run = dry_run
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000587
Edward Lesmes8e282792018-04-03 18:50:29 -0400588 self.parallel = parallel
589 self.thread_pool = thread_pool or ThreadPool()
590
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000591 # We expose various modules and functions as attributes of the input_api
592 # so that presubmit scripts don't have to import them.
Takeshi Yoshino07a6bea2017-08-02 02:44:06 +0900593 self.ast = ast
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000594 self.basename = os.path.basename
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000595 self.cpplint = cpplint
dcheng091b7db2016-06-16 01:27:51 -0700596 self.fnmatch = fnmatch
Yoshisato Yanagisawa04600b42019-03-15 03:03:41 +0000597 self.gclient_paths = gclient_paths
Yoshisato Yanagisawa57dd17b2019-03-22 09:10:29 +0000598 # TODO(yyanagisawa): stop exposing this when python3 become default.
599 # Since python3's tempfile has TemporaryDirectory, we do not need this.
600 self.temporary_directory = gclient_utils.temporary_directory
dpranke@chromium.org17cc2442012-10-17 21:12:09 +0000601 self.glob = glob.glob
maruel@chromium.orgfb11c7b2010-03-18 18:22:14 +0000602 self.json = json
maruel@chromium.org6fba34d2011-06-02 13:45:12 +0000603 self.logging = logging.getLogger('PRESUBMIT')
maruel@chromium.org2b5ce562011-03-31 16:15:44 +0000604 self.os_listdir = os.listdir
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000605 self.os_path = os.path
pgervais@chromium.orgbd0cace2014-10-02 23:23:46 +0000606 self.os_stat = os.stat
Yoshisato Yanagisawa406de132018-06-29 05:43:25 +0000607 self.os_walk = os.walk
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000608 self.re = re
609 self.subprocess = subprocess
Edward Lemurb9830242019-10-30 22:19:20 +0000610 self.sys = sys
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000611 self.tempfile = tempfile
dpranke@chromium.org0d1bdea2011-03-24 22:54:38 +0000612 self.time = time
maruel@chromium.org1487d532009-06-06 00:22:57 +0000613 self.unittest = unittest
Edward Lemurb9830242019-10-30 22:19:20 +0000614 if sys.version_info.major == 2:
615 self.urllib2 = urllib2
Edward Lemur16af3562019-10-17 22:11:33 +0000616 self.urllib_request = urllib_request
617 self.urllib_error = urllib_error
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000618
Robert Iannucci50258932018-03-19 10:30:59 -0700619 self.is_windows = sys.platform == 'win32'
620
Edward Lemurb9646622019-10-25 20:57:35 +0000621 # Set python_executable to 'vpython' in order to allow scripts in other
622 # repos (e.g. src.git) to automatically pick up that repo's .vpython file,
623 # instead of inheriting the one in depot_tools.
624 self.python_executable = 'vpython'
Erik Staab69135d12021-05-14 22:31:57 +0000625 # Offer a python 3 executable for use during the migration off of python 2.
626 self.python3_executable = 'vpython3'
maruel@chromium.orgc0b22972009-06-25 16:19:14 +0000627 self.environ = os.environ
628
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000629 # InputApi.platform is the platform you're currently running on.
630 self.platform = sys.platform
631
iannucci@chromium.org0af3bb32015-06-12 20:44:35 +0000632 self.cpu_count = multiprocessing.cpu_count()
633
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000634 # The local path of the currently-being-processed presubmit script.
maruel@chromium.org3d235242009-05-15 12:40:48 +0000635 self._current_presubmit_path = os.path.dirname(presubmit_path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000636
637 # We carry the canned checks so presubmit scripts can easily use them.
638 self.canned_checks = presubmit_canned_checks
639
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100640 # Temporary files we must manually remove at the end of a run.
641 self._named_temporary_files = []
Jochen Eisinger72606f82017-04-04 10:44:18 +0200642
Edward Lesmesdc11c6b2021-03-19 19:22:05 +0000643 self.owners_client = None
644 if self.gerrit:
645 self.owners_client = owners_client.GetCodeOwnersClient(
646 root=change.RepositoryRoot(),
647 upstream=change.UpstreamBranch(),
648 host=self.gerrit.host,
649 project=self.gerrit.project,
650 branch=self.gerrit.branch)
Edward Lesmes9ce03f82021-01-12 20:13:31 +0000651 self.owners_db = owners_db.Database(
652 change.RepositoryRoot(), fopen=open, os_path=self.os_path)
Jochen Eisinger76f5fc62017-04-07 16:27:46 +0200653 self.owners_finder = owners_finder.OwnersFinder
maruel@chromium.org899e1c12011-04-07 17:03:18 +0000654 self.verbose = verbose
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000655 self.Command = CommandData
dpranke@chromium.org2a009622011-03-01 02:43:31 +0000656
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000657 # Replace <hash_map> and <hash_set> as headers that need to be included
Edward Lemura5799e32020-01-17 19:26:51 +0000658 # with 'base/containers/hash_tables.h' instead.
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000659 # Access to a protected member _XX of a client class
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800660 # pylint: disable=protected-access
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000661 self.cpplint._re_pattern_templates = [
danakj@chromium.org18278522013-06-11 22:42:32 +0000662 (a, b, 'base/containers/hash_tables.h')
enne@chromium.orge72c5f52013-04-16 00:36:40 +0000663 if header in ('<hash_map>', '<hash_set>') else (a, b, header)
664 for (a, b, header) in cpplint._re_pattern_templates
665 ]
666
Edward Lemurecc27072020-01-06 16:42:34 +0000667 def SetTimeout(self, timeout):
668 self.thread_pool.timeout = timeout
669
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000670 def PresubmitLocalPath(self):
671 """Returns the local path of the presubmit script currently being run.
672
673 This is useful if you don't want to hard-code absolute paths in the
674 presubmit script. For example, It can be used to find another file
675 relative to the PRESUBMIT.py script, so the whole tree can be branched and
676 the presubmit script still works, without editing its content.
677 """
maruel@chromium.org3d235242009-05-15 12:40:48 +0000678 return self._current_presubmit_path
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000679
agable0b65e732016-11-22 09:25:46 -0800680 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000681 """Same as input_api.change.AffectedFiles() except only lists files
682 (and optionally directories) in the same directory as the current presubmit
Bruce Dawson7a0b07a2020-04-23 17:14:40 +0000683 script, or subdirectories thereof. Note that files are listed using the OS
684 path separator, so backslashes are used as separators on Windows.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000685 """
Edward Lemura5799e32020-01-17 19:26:51 +0000686 dir_with_slash = normpath('%s/' % self.PresubmitLocalPath())
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000687 if len(dir_with_slash) == 1:
688 dir_with_slash = ''
sail@chromium.org5538e022011-05-12 17:53:16 +0000689
Edward Lemurb9830242019-10-30 22:19:20 +0000690 return list(filter(
maruel@chromium.org4661e0c2009-06-04 00:45:26 +0000691 lambda x: normpath(x.AbsoluteLocalPath()).startswith(dir_with_slash),
Edward Lemurb9830242019-10-30 22:19:20 +0000692 self.change.AffectedFiles(include_deletes, file_filter)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000693
agable0b65e732016-11-22 09:25:46 -0800694 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000695 """Returns local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800696 paths = [af.LocalPath() for af in self.AffectedFiles()]
Edward Lemura5799e32020-01-17 19:26:51 +0000697 logging.debug('LocalPaths: %s', paths)
pgervais@chromium.org2f64f782014-04-25 00:12:33 +0000698 return paths
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000699
agable0b65e732016-11-22 09:25:46 -0800700 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000701 """Returns absolute local paths of input_api.AffectedFiles()."""
agable0b65e732016-11-22 09:25:46 -0800702 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000703
John Budorick16162372018-04-18 10:39:53 -0700704 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
agable0b65e732016-11-22 09:25:46 -0800705 """Same as input_api.change.AffectedTestableFiles() except only lists files
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000706 in the same directory as the current presubmit script, or subdirectories
707 thereof.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000708 """
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000709 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +0000710 warn('AffectedTestableFiles(include_deletes=%s)'
711 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000712 category=DeprecationWarning,
713 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +0000714 return list(filter(
715 lambda x: x.IsTestableFile(),
716 self.AffectedFiles(include_deletes=False, **kwargs)))
agable0b65e732016-11-22 09:25:46 -0800717
718 def AffectedTextFiles(self, include_deletes=None):
719 """An alias to AffectedTestableFiles for backwards compatibility."""
720 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000721
Josip Sokcevic8c955952021-02-01 21:32:57 +0000722 def FilterSourceFile(self,
723 affected_file,
724 files_to_check=None,
725 files_to_skip=None,
726 allow_list=None,
727 block_list=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000728 """Filters out files that aren't considered 'source file'.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000729
local_bot64021412020-07-08 21:05:39 +0000730 If files_to_check or files_to_skip is None, InputApi.DEFAULT_FILES_TO_CHECK
731 and InputApi.DEFAULT_FILES_TO_SKIP is used respectively.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000732
733 The lists will be compiled as regular expression and
734 AffectedFile.LocalPath() needs to pass both list.
735
736 Note: Copy-paste this function to suit your needs or use a lambda function.
737 """
local_bot64021412020-07-08 21:05:39 +0000738 if files_to_check is None:
739 files_to_check = self.DEFAULT_FILES_TO_CHECK
740 if files_to_skip is None:
741 files_to_skip = self.DEFAULT_FILES_TO_SKIP
local_bot30f774e2020-06-25 18:23:34 +0000742
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000743 def Find(affected_file, items):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000744 local_path = affected_file.LocalPath()
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000745 for item in items:
maruel@chromium.orgdf1595a2009-06-11 02:00:13 +0000746 if self.re.match(item, local_path):
maruel@chromium.org3410d912009-06-09 20:56:16 +0000747 return True
748 return False
local_bot64021412020-07-08 21:05:39 +0000749 return (Find(affected_file, files_to_check) and
750 not Find(affected_file, files_to_skip))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000751
752 def AffectedSourceFiles(self, source_file):
agable0b65e732016-11-22 09:25:46 -0800753 """Filter the list of AffectedTestableFiles by the function source_file.
maruel@chromium.org3410d912009-06-09 20:56:16 +0000754
755 If source_file is None, InputApi.FilterSourceFile() is used.
756 """
757 if not source_file:
758 source_file = self.FilterSourceFile
Edward Lemurb9830242019-10-30 22:19:20 +0000759 return list(filter(source_file, self.AffectedTestableFiles()))
maruel@chromium.org3410d912009-06-09 20:56:16 +0000760
761 def RightHandSideLines(self, source_file_filter=None):
Edward Lemura5799e32020-01-17 19:26:51 +0000762 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000763
764 Only lists lines from new or modified text files in the change that are
765 contained by the directory of the currently executing presubmit script.
766
767 This is useful for doing line-by-line regex checks, like checking for
768 trailing whitespace.
769
770 Yields:
771 a 3 tuple:
772 the AffectedFile instance of the current file;
773 integer line number (1-based); and
774 the contents of the line as a string.
maruel@chromium.org1487d532009-06-06 00:22:57 +0000775
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000776 Note: The carriage return (LF or CR) is stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000777 """
maruel@chromium.org3410d912009-06-09 20:56:16 +0000778 files = self.AffectedSourceFiles(source_file_filter)
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +0000779 return _RightHandSideLinesImpl(files)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000780
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000781 def ReadFile(self, file_item, mode='r'):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000782 """Reads an arbitrary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000783
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000784 Deny reading anything outside the repository.
785 """
maruel@chromium.orge3608df2009-11-10 20:22:57 +0000786 if isinstance(file_item, AffectedFile):
787 file_item = file_item.AbsoluteLocalPath()
788 if not file_item.startswith(self.change.RepositoryRoot()):
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000789 raise IOError('Access outside the repository root is denied.')
maruel@chromium.org5aeb7dd2009-11-17 18:09:01 +0000790 return gclient_utils.FileRead(file_item, mode)
maruel@chromium.org44a17ad2009-06-08 14:14:35 +0000791
Raphael Kubo da Costaf2d16152017-11-10 18:07:58 +0100792 def CreateTemporaryFile(self, **kwargs):
793 """Returns a named temporary file that must be removed with a call to
794 RemoveTemporaryFiles().
795
796 All keyword arguments are forwarded to tempfile.NamedTemporaryFile(),
797 except for |delete|, which is always set to False.
798
799 Presubmit checks that need to create a temporary file and pass it for
800 reading should use this function instead of NamedTemporaryFile(), as
801 Windows fails to open a file that is already open for writing.
802
803 with input_api.CreateTemporaryFile() as f:
804 f.write('xyz')
805 f.close()
806 input_api.subprocess.check_output(['script-that', '--reads-from',
807 f.name])
808
809
810 Note that callers of CreateTemporaryFile() should not worry about removing
811 any temporary file; this is done transparently by the presubmit handling
812 code.
813 """
814 if 'delete' in kwargs:
815 # Prevent users from passing |delete|; we take care of file deletion
816 # ourselves and this prevents unintuitive error messages when we pass
817 # delete=False and 'delete' is also in kwargs.
818 raise TypeError('CreateTemporaryFile() does not take a "delete" '
819 'argument, file deletion is handled automatically by '
820 'the same presubmit_support code that creates InputApi '
821 'objects.')
822 temp_file = self.tempfile.NamedTemporaryFile(delete=False, **kwargs)
823 self._named_temporary_files.append(temp_file.name)
824 return temp_file
825
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000826 @property
827 def tbr(self):
828 """Returns if a change is TBR'ed."""
Jeremy Romandce22502017-06-20 15:37:29 -0400829 return 'TBR' in self.change.tags or self.change.TBRsFromDescription()
maruel@chromium.orgcc73ad62011-07-06 17:39:26 +0000830
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000831 def RunTests(self, tests_mix, parallel=True):
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000832 tests = []
833 msgs = []
834 for t in tests_mix:
Edward Lesmes8e282792018-04-03 18:50:29 -0400835 if isinstance(t, OutputApi.PresubmitResult) and t:
ilevy@chromium.orgbc117312013-04-20 03:57:56 +0000836 msgs.append(t)
837 else:
838 assert issubclass(t.message, _PresubmitResult)
839 tests.append(t)
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +0000840 if self.verbose:
841 t.info = _PresubmitNotifyResult
Edward Lemur1037c742018-05-01 18:56:04 -0400842 if not t.kwargs.get('cwd'):
843 t.kwargs['cwd'] = self.PresubmitLocalPath()
Edward Lesmes8e282792018-04-03 18:50:29 -0400844 self.thread_pool.AddTests(tests, parallel)
Edward Lemur21000eb2019-05-24 23:25:58 +0000845 # When self.parallel is True (i.e. --parallel is passed as an option)
846 # RunTests doesn't actually run tests. It adds them to a ThreadPool that
847 # will run all tests once all PRESUBMIT files are processed.
848 # Otherwise, it will run them and return the results.
849 if not self.parallel:
Edward Lesmes8e282792018-04-03 18:50:29 -0400850 msgs.extend(self.thread_pool.RunAsync())
851 return msgs
scottmg86099d72016-09-01 09:16:51 -0700852
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000853
nick@chromium.orgff526192013-06-10 19:30:26 +0000854class _DiffCache(object):
855 """Caches diffs retrieved from a particular SCM."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000856 def __init__(self, upstream=None):
857 """Stores the upstream revision against which all diffs will be computed."""
858 self._upstream = upstream
nick@chromium.orgff526192013-06-10 19:30:26 +0000859
860 def GetDiff(self, path, local_root):
861 """Get the diff for a particular path."""
862 raise NotImplementedError()
863
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700864 def GetOldContents(self, path, local_root):
865 """Get the old version for a particular path."""
866 raise NotImplementedError()
867
nick@chromium.orgff526192013-06-10 19:30:26 +0000868
nick@chromium.orgff526192013-06-10 19:30:26 +0000869class _GitDiffCache(_DiffCache):
870 """DiffCache implementation for git; gets all file diffs at once."""
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000871 def __init__(self, upstream):
872 super(_GitDiffCache, self).__init__(upstream=upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000873 self._diffs_by_file = None
874
875 def GetDiff(self, path, local_root):
876 if not self._diffs_by_file:
877 # Compute a single diff for all files and parse the output; should
878 # with git this is much faster than computing one diff for each file.
879 diffs = {}
880
881 # Don't specify any filenames below, because there are command line length
882 # limits on some platforms and GenerateDiff would fail.
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000883 unified_diff = scm.GIT.GenerateDiff(local_root, files=[], full_move=True,
884 branch=self._upstream)
nick@chromium.orgff526192013-06-10 19:30:26 +0000885
886 # This regex matches the path twice, separated by a space. Note that
887 # filename itself may contain spaces.
888 file_marker = re.compile('^diff --git (?P<filename>.*) (?P=filename)$')
889 current_diff = []
890 keep_line_endings = True
891 for x in unified_diff.splitlines(keep_line_endings):
892 match = file_marker.match(x)
893 if match:
894 # Marks the start of a new per-file section.
895 diffs[match.group('filename')] = current_diff = [x]
896 elif x.startswith('diff --git'):
897 raise PresubmitFailure('Unexpected diff line: %s' % x)
898 else:
899 current_diff.append(x)
900
901 self._diffs_by_file = dict(
902 (normpath(path), ''.join(diff)) for path, diff in diffs.items())
903
904 if path not in self._diffs_by_file:
905 raise PresubmitFailure(
906 'Unified diff did not contain entry for file %s' % path)
907
908 return self._diffs_by_file[path]
909
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700910 def GetOldContents(self, path, local_root):
911 return scm.GIT.GetOldContents(local_root, path, branch=self._upstream)
912
nick@chromium.orgff526192013-06-10 19:30:26 +0000913
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000914class AffectedFile(object):
915 """Representation of a file in a change."""
nick@chromium.orgff526192013-06-10 19:30:26 +0000916
917 DIFF_CACHE = _DiffCache
918
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +0000919 # Method could be a function
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -0800920 # pylint: disable=no-self-use
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000921 def __init__(self, path, action, repository_root, diff_cache):
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000922 self._path = path
923 self._action = action
maruel@chromium.org4ff922a2009-06-12 20:20:19 +0000924 self._local_root = repository_root
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000925 self._is_directory = None
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000926 self._cached_changed_contents = None
927 self._cached_new_contents = None
agable@chromium.orgea84ef12014-04-30 19:55:12 +0000928 self._diff_cache = diff_cache
tobiasjs2836bcf2016-08-16 04:08:16 -0700929 logging.debug('%s(%s)', self.__class__.__name__, self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000930
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000931 def LocalPath(self):
932 """Returns the path of this file on the local disk relative to client root.
Andrew Grieve92b8b992017-11-02 09:42:24 -0400933
934 This should be used for error messages but not for accessing files,
935 because presubmit checks are run with CWD=PresubmitLocalPath() (which is
936 often != client root).
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000937 """
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000938 return normpath(self._path)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000939
940 def AbsoluteLocalPath(self):
941 """Returns the absolute path of this file on the local disk.
942 """
chase@chromium.org8e416c82009-10-06 04:30:44 +0000943 return os.path.abspath(os.path.join(self._local_root, self.LocalPath()))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000944
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000945 def Action(self):
946 """Returns the action on this opened file, e.g. A, M, D, etc."""
maruel@chromium.org15bdffa2009-05-29 11:16:29 +0000947 return self._action
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000948
agable0b65e732016-11-22 09:25:46 -0800949 def IsTestableFile(self):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000950 """Returns True if the file is a text file and not a binary file.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +0000951
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +0000952 Deleted files are not text file."""
maruel@chromium.org1e08c002009-05-28 19:09:33 +0000953 raise NotImplementedError() # Implement when needed
954
agable0b65e732016-11-22 09:25:46 -0800955 def IsTextFile(self):
956 """An alias to IsTestableFile for backwards compatibility."""
957 return self.IsTestableFile()
958
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700959 def OldContents(self):
960 """Returns an iterator over the lines in the old version of file.
961
Daniel Cheng2da34fe2017-03-21 20:42:12 -0700962 The old version is the file before any modifications in the user's
Edward Lemura5799e32020-01-17 19:26:51 +0000963 workspace, i.e. the 'left hand side'.
Daniel Cheng7a1f04d2017-03-21 19:12:31 -0700964
965 Contents will be empty if the file is a directory or does not exist.
966 Note: The carriage returns (LF or CR) are stripped off.
967 """
968 return self._diff_cache.GetOldContents(self.LocalPath(),
969 self._local_root).splitlines()
970
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000971 def NewContents(self):
972 """Returns an iterator over the lines in the new version of file.
973
Edward Lemura5799e32020-01-17 19:26:51 +0000974 The new version is the file in the user's workspace, i.e. the 'right hand
975 side'.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000976
977 Contents will be empty if the file is a directory or does not exist.
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000978 Note: The carriage returns (LF or CR) are stripped off.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000979 """
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000980 if self._cached_new_contents is None:
981 self._cached_new_contents = []
agable0b65e732016-11-22 09:25:46 -0800982 try:
983 self._cached_new_contents = gclient_utils.FileRead(
984 self.AbsoluteLocalPath(), 'rU').splitlines()
985 except IOError:
986 pass # File not found? That's fine; maybe it was deleted.
Greg Thompson30cde452021-06-01 16:38:47 +0000987 except UnicodeDecodeError as e:
Dirk Pranke6fc394f2021-05-26 23:25:14 +0000988 # log the filename since we're probably trying to read a binary
989 # file, and shouldn't be.
990 print('Error reading %s: %s' % (self.AbsoluteLocalPath(), e))
991 raise
992
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +0000993 return self._cached_new_contents[:]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +0000994
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +0000995 def ChangedContents(self, keeplinebreaks=False):
maruel@chromium.orgab05d582011-02-09 23:41:22 +0000996 """Returns a list of tuples (line number, line text) of all new lines.
997
998 This relies on the scm diff output describing each changed code section
999 with a line of the form
1000
1001 ^@@ <old line num>,<old size> <new line num>,<new size> @@$
1002 """
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001003 # Don't return cached results when line breaks are requested.
1004 if not keeplinebreaks and self._cached_changed_contents is not None:
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001005 return self._cached_changed_contents[:]
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001006 result = []
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001007 line_num = 0
1008
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001009 # The keeplinebreaks parameter to splitlines must be True or else the
1010 # CheckForWindowsLineEndings presubmit will be a NOP.
1011 for line in self.GenerateScmDiff().splitlines(keeplinebreaks):
Edward Lemurac5c55f2020-02-29 00:17:16 +00001012 m = re.match(r'^@@ [0-9\,\+\-]+ \+([0-9]+)\,[0-9]+ @@', line)
1013 if m:
1014 line_num = int(m.groups(1)[0])
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001015 continue
1016 if line.startswith('+') and not line.startswith('++'):
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001017 result.append((line_num, line[1:]))
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001018 if not line.startswith('-'):
1019 line_num += 1
Bruce Dawsonf0bcfdd2021-05-21 18:10:23 +00001020 # Don't cache results with line breaks.
1021 if keeplinebreaks:
1022 return result;
1023 self._cached_changed_contents = result
nick@chromium.org2a3ab7e2011-04-27 22:06:27 +00001024 return self._cached_changed_contents[:]
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001025
maruel@chromium.org5de13972009-06-10 18:16:06 +00001026 def __str__(self):
1027 return self.LocalPath()
1028
maruel@chromium.orgab05d582011-02-09 23:41:22 +00001029 def GenerateScmDiff(self):
nick@chromium.orgff526192013-06-10 19:30:26 +00001030 return self._diff_cache.GetDiff(self.LocalPath(), self._local_root)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001031
maruel@chromium.org58407af2011-04-12 23:15:57 +00001032
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001033class GitAffectedFile(AffectedFile):
1034 """Representation of a file in a change out of a git checkout."""
maruel@chromium.orgb17b55b2010-11-03 14:42:37 +00001035 # Method 'NNN' is abstract in class 'NNN' but is not overridden
Quinten Yearsleyb2cc4a92016-12-15 13:53:26 -08001036 # pylint: disable=abstract-method
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001037
nick@chromium.orgff526192013-06-10 19:30:26 +00001038 DIFF_CACHE = _GitDiffCache
1039
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001040 def __init__(self, *args, **kwargs):
1041 AffectedFile.__init__(self, *args, **kwargs)
1042 self._server_path = None
agable0b65e732016-11-22 09:25:46 -08001043 self._is_testable_file = None
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001044
agable0b65e732016-11-22 09:25:46 -08001045 def IsTestableFile(self):
1046 if self._is_testable_file is None:
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001047 if self.Action() == 'D':
agable0b65e732016-11-22 09:25:46 -08001048 # A deleted file is not testable.
1049 self._is_testable_file = False
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001050 else:
agable0b65e732016-11-22 09:25:46 -08001051 self._is_testable_file = os.path.isfile(self.AbsoluteLocalPath())
1052 return self._is_testable_file
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001053
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001054
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001055class Change(object):
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001056 """Describe a change.
1057
1058 Used directly by the presubmit scripts to query the current change being
1059 tested.
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001060
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001061 Instance members:
nick@chromium.orgff526192013-06-10 19:30:26 +00001062 tags: Dictionary of KEY=VALUE pairs found in the change description.
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001063 self.KEY: equivalent to tags['KEY']
1064 """
1065
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001066 _AFFECTED_FILES = AffectedFile
1067
Edward Lemura5799e32020-01-17 19:26:51 +00001068 # Matches key/value (or 'tag') lines in changelist descriptions.
maruel@chromium.org428342a2011-11-10 15:46:33 +00001069 TAG_LINE_RE = re.compile(
maruel@chromium.orgc6f60e82013-04-19 17:01:57 +00001070 '^[ \t]*(?P<key>[A-Z][A-Z_0-9]*)[ \t]*=[ \t]*(?P<value>.*?)[ \t]*$')
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001071 scm = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001072
maruel@chromium.org58407af2011-04-12 23:15:57 +00001073 def __init__(
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001074 self, name, description, local_root, files, issue, patchset, author,
1075 upstream=None):
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001076 if files is None:
1077 files = []
1078 self._name = name
chase@chromium.org8e416c82009-10-06 04:30:44 +00001079 # Convert root into an absolute path.
1080 self._local_root = os.path.abspath(local_root)
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001081 self._upstream = upstream
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001082 self.issue = issue
1083 self.patchset = patchset
maruel@chromium.org58407af2011-04-12 23:15:57 +00001084 self.author_email = author
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001085
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001086 self._full_description = ''
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001087 self.tags = {}
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001088 self._description_without_tags = ''
1089 self.SetDescriptionText(description)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001090
maruel@chromium.orge085d812011-10-10 19:49:15 +00001091 assert all(
1092 (isinstance(f, (list, tuple)) and len(f) == 2) for f in files), files
1093
agable@chromium.orgea84ef12014-04-30 19:55:12 +00001094 diff_cache = self._AFFECTED_FILES.DIFF_CACHE(self._upstream)
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001095 self._affected_files = [
nick@chromium.orgff526192013-06-10 19:30:26 +00001096 self._AFFECTED_FILES(path, action.strip(), self._local_root, diff_cache)
1097 for action, path in files
maruel@chromium.orgdbbeedc2009-05-22 20:26:17 +00001098 ]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001099
Edward Lesmes9ce03f82021-01-12 20:13:31 +00001100 def UpstreamBranch(self):
1101 """Returns the upstream branch for the change."""
1102 return self._upstream
1103
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001104 def Name(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001105 """Returns the change name."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001106 return self._name
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001107
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001108 def DescriptionText(self):
1109 """Returns the user-entered changelist description, minus tags.
1110
Edward Lemura5799e32020-01-17 19:26:51 +00001111 Any line in the user-provided description starting with e.g. 'FOO='
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001112 (whitespace permitted before and around) is considered a tag line. Such
1113 lines are stripped out of the description this function returns.
1114 """
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001115 return self._description_without_tags
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001116
1117 def FullDescriptionText(self):
1118 """Returns the complete changelist description including tags."""
maruel@chromium.org6ebe68a2009-05-27 23:43:40 +00001119 return self._full_description
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001120
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001121 def SetDescriptionText(self, description):
1122 """Sets the full description text (including tags) to |description|.
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001123
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001124 Also updates the list of tags."""
1125 self._full_description = description
1126
1127 # From the description text, build up a dictionary of key/value pairs
Edward Lemura5799e32020-01-17 19:26:51 +00001128 # plus the description minus all key/value or 'tag' lines.
isherman@chromium.orgb5cded62014-03-25 17:47:57 +00001129 description_without_tags = []
1130 self.tags = {}
1131 for line in self._full_description.splitlines():
1132 m = self.TAG_LINE_RE.match(line)
1133 if m:
1134 self.tags[m.group('key')] = m.group('value')
1135 else:
1136 description_without_tags.append(line)
1137
1138 # Change back to text and remove whitespace at end.
1139 self._description_without_tags = (
1140 '\n'.join(description_without_tags).rstrip())
1141
Edward Lemur69bb8be2020-02-03 20:37:38 +00001142 def AddDescriptionFooter(self, key, value):
1143 """Adds the given footer to the change description.
1144
1145 Args:
1146 key: A string with the key for the git footer. It must conform to
1147 the git footers format (i.e. 'List-Of-Tokens') and will be case
1148 normalized so that each token is title-cased.
1149 value: A string with the value for the git footer.
1150 """
1151 description = git_footers.add_footer(
1152 self.FullDescriptionText(), git_footers.normalize_name(key), value)
1153 self.SetDescriptionText(description)
1154
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001155 def RepositoryRoot(self):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001156 """Returns the repository (checkout) root directory for this change,
1157 as an absolute path.
1158 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001159 return self._local_root
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001160
1161 def __getattr__(self, attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001162 """Return tags directly as attributes on the object."""
Edward Lemura5799e32020-01-17 19:26:51 +00001163 if not re.match(r'^[A-Z_]*$', attr):
maruel@chromium.org92022ec2009-06-11 01:59:28 +00001164 raise AttributeError(self, attr)
maruel@chromium.orge1a524f2009-05-27 14:43:46 +00001165 return self.tags.get(attr)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001166
Edward Lemur69bb8be2020-02-03 20:37:38 +00001167 def GitFootersFromDescription(self):
1168 """Return the git footers present in the description.
1169
1170 Returns:
1171 footers: A dict of {footer: [values]} containing a multimap of the footers
1172 in the change description.
1173 """
1174 return git_footers.parse_footers(self.FullDescriptionText())
1175
Aaron Gablefc03e672017-05-15 14:09:42 -07001176 def BugsFromDescription(self):
1177 """Returns all bugs referenced in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001178 tags = [b.strip() for b in self.tags.get('BUG', '').split(',') if b.strip()]
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001179 footers = []
Edward Lemur69bb8be2020-02-03 20:37:38 +00001180 parsed = self.GitFootersFromDescription()
Dan Beam62954042019-10-03 21:20:33 +00001181 unsplit_footers = parsed.get('Bug', []) + parsed.get('Fixed', [])
Caleb Rouleauc0546b92019-02-22 06:12:57 +00001182 for unsplit_footer in unsplit_footers:
1183 footers += [b.strip() for b in unsplit_footer.split(',')]
Aaron Gable12ef5012017-05-15 14:29:00 -07001184 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001185
1186 def ReviewersFromDescription(self):
1187 """Returns all reviewers listed in the commit description."""
Edward Lemura5799e32020-01-17 19:26:51 +00001188 # We don't support a 'R:' git-footer for reviewers; that is in metadata.
Aaron Gable12ef5012017-05-15 14:29:00 -07001189 tags = [r.strip() for r in self.tags.get('R', '').split(',') if r.strip()]
1190 return sorted(set(tags))
Aaron Gablefc03e672017-05-15 14:09:42 -07001191
1192 def TBRsFromDescription(self):
1193 """Returns all TBR reviewers listed in the commit description."""
Aaron Gable12ef5012017-05-15 14:29:00 -07001194 tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()]
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001195 # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are
1196 # programmatically determined by self-CR+1s.
Edward Lemur69bb8be2020-02-03 20:37:38 +00001197 footers = self.GitFootersFromDescription().get('Tbr', [])
Aaron Gable12ef5012017-05-15 14:29:00 -07001198 return sorted(set(tags + footers))
Aaron Gablefc03e672017-05-15 14:09:42 -07001199
Aaron Gable6e7ddb62020-05-27 22:23:29 +00001200 # TODO(crbug.com/753425): Delete these once we're sure they're unused.
Aaron Gablefc03e672017-05-15 14:09:42 -07001201 @property
1202 def BUG(self):
1203 return ','.join(self.BugsFromDescription())
1204 @property
1205 def R(self):
1206 return ','.join(self.ReviewersFromDescription())
1207 @property
1208 def TBR(self):
1209 return ','.join(self.TBRsFromDescription())
1210
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001211 def AllFiles(self, root=None):
1212 """List all files under source control in the repo."""
1213 raise NotImplementedError()
1214
agable0b65e732016-11-22 09:25:46 -08001215 def AffectedFiles(self, include_deletes=True, file_filter=None):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001216 """Returns a list of AffectedFile instances for all files in the change.
1217
1218 Args:
1219 include_deletes: If false, deleted files will be filtered out.
sail@chromium.org5538e022011-05-12 17:53:16 +00001220 file_filter: An additional filter to apply.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001221
1222 Returns:
1223 [AffectedFile(path, action), AffectedFile(path, action)]
1224 """
Edward Lemurb9830242019-10-30 22:19:20 +00001225 affected = list(filter(file_filter, self._affected_files))
sail@chromium.org5538e022011-05-12 17:53:16 +00001226
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001227 if include_deletes:
1228 return affected
Edward Lemurb9830242019-10-30 22:19:20 +00001229 return list(filter(lambda x: x.Action() != 'D', affected))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001230
John Budorick16162372018-04-18 10:39:53 -07001231 def AffectedTestableFiles(self, include_deletes=None, **kwargs):
maruel@chromium.org77c4f0f2009-05-29 18:53:04 +00001232 """Return a list of the existing text files in a change."""
1233 if include_deletes is not None:
Edward Lemura5799e32020-01-17 19:26:51 +00001234 warn('AffectedTeestableFiles(include_deletes=%s)'
1235 ' is deprecated and ignored' % str(include_deletes),
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001236 category=DeprecationWarning,
1237 stacklevel=2)
Edward Lemurb9830242019-10-30 22:19:20 +00001238 return list(filter(
1239 lambda x: x.IsTestableFile(),
1240 self.AffectedFiles(include_deletes=False, **kwargs)))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001241
agable0b65e732016-11-22 09:25:46 -08001242 def AffectedTextFiles(self, include_deletes=None):
1243 """An alias to AffectedTestableFiles for backwards compatibility."""
1244 return self.AffectedTestableFiles(include_deletes=include_deletes)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001245
agable0b65e732016-11-22 09:25:46 -08001246 def LocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001247 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001248 return [af.LocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001249
agable0b65e732016-11-22 09:25:46 -08001250 def AbsoluteLocalPaths(self):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001251 """Convenience function."""
agable0b65e732016-11-22 09:25:46 -08001252 return [af.AbsoluteLocalPath() for af in self.AffectedFiles()]
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001253
1254 def RightHandSideLines(self):
Edward Lemura5799e32020-01-17 19:26:51 +00001255 """An iterator over all text lines in 'new' version of changed files.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001256
1257 Lists lines from new or modified text files in the change.
1258
1259 This is useful for doing line-by-line regex checks, like checking for
1260 trailing whitespace.
1261
1262 Yields:
1263 a 3 tuple:
1264 the AffectedFile instance of the current file;
1265 integer line number (1-based); and
1266 the contents of the line as a string.
1267 """
maruel@chromium.orgcb2985f2010-11-03 14:08:31 +00001268 return _RightHandSideLinesImpl(
1269 x for x in self.AffectedFiles(include_deletes=False)
agable0b65e732016-11-22 09:25:46 -08001270 if x.IsTestableFile())
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001271
Jochen Eisingerd0573ec2017-04-13 10:55:06 +02001272 def OriginalOwnersFiles(self):
1273 """A map from path names of affected OWNERS files to their old content."""
1274 def owners_file_filter(f):
1275 return 'OWNERS' in os.path.split(f.LocalPath())[1]
1276 files = self.AffectedFiles(file_filter=owners_file_filter)
1277 return dict([(f.LocalPath(), f.OldContents()) for f in files])
1278
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001279
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001280class GitChange(Change):
1281 _AFFECTED_FILES = GitAffectedFile
maruel@chromium.orgc1938752011-04-12 23:11:13 +00001282 scm = 'git'
thestig@chromium.orgda8cddd2009-08-13 00:25:55 +00001283
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001284 def AllFiles(self, root=None):
1285 """List all files under source control in the repo."""
1286 root = root or self.RepositoryRoot()
1287 return subprocess.check_output(
Aaron Gable7817f022017-12-12 09:43:17 -08001288 ['git', '-c', 'core.quotePath=false', 'ls-files', '--', '.'],
Josip Sokcevic0b123462021-06-08 20:41:32 +00001289 cwd=root).decode('utf-8', 'ignore').splitlines()
agable@chromium.org40a3d0b2014-05-15 01:59:16 +00001290
maruel@chromium.orgc70a2202009-06-17 12:55:10 +00001291
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001292def ListRelevantPresubmitFiles(files, root):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001293 """Finds all presubmit files that apply to a given set of source files.
1294
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001295 If inherit-review-settings-ok is present right under root, looks for
1296 PRESUBMIT.py in directories enclosing root.
1297
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001298 Args:
1299 files: An iterable container containing file paths.
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001300 root: Path where to stop searching.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001301
1302 Return:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001303 List of absolute paths of the existing PRESUBMIT.py scripts.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001304 """
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001305 files = [normpath(os.path.join(root, f)) for f in files]
1306
1307 # List all the individual directories containing files.
1308 directories = set([os.path.dirname(f) for f in files])
1309
1310 # Ignore root if inherit-review-settings-ok is present.
1311 if os.path.isfile(os.path.join(root, 'inherit-review-settings-ok')):
1312 root = None
1313
1314 # Collect all unique directories that may contain PRESUBMIT.py.
1315 candidates = set()
1316 for directory in directories:
1317 while True:
1318 if directory in candidates:
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001319 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001320 candidates.add(directory)
1321 if directory == root:
maruel@chromium.org4661e0c2009-06-04 00:45:26 +00001322 break
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001323 parent_dir = os.path.dirname(directory)
1324 if parent_dir == directory:
1325 # We hit the system root directory.
1326 break
1327 directory = parent_dir
1328
1329 # Look for PRESUBMIT.py in all candidate directories.
1330 results = []
1331 for directory in sorted(list(candidates)):
tobiasjsff061c02016-08-17 03:23:57 -07001332 try:
1333 for f in os.listdir(directory):
1334 p = os.path.join(directory, f)
1335 if os.path.isfile(p) and re.match(
1336 r'PRESUBMIT.*\.py$', f) and not f.startswith('PRESUBMIT_test'):
1337 results.append(p)
1338 except OSError:
1339 pass
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001340
tobiasjs2836bcf2016-08-16 04:08:16 -07001341 logging.debug('Presubmit files: %s', ','.join(results))
maruel@chromium.orgb1901a62010-06-16 00:18:47 +00001342 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001343
1344
rmistry@google.com5626a922015-02-26 14:03:30 +00001345class GetPostUploadExecuter(object):
1346 @staticmethod
Edward Lemur016a0872020-02-04 22:13:28 +00001347 def ExecPresubmitScript(script_text, presubmit_path, gerrit_obj, change):
rmistry@google.com5626a922015-02-26 14:03:30 +00001348 """Executes PostUploadHook() from a single presubmit script.
1349
1350 Args:
1351 script_text: The text of the presubmit script.
1352 presubmit_path: Project script to run.
Edward Lemur016a0872020-02-04 22:13:28 +00001353 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001354 change: The Change object.
1355
1356 Return:
1357 A list of results objects.
1358 """
1359 context = {}
1360 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001361 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1362 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001363 except Exception as e:
rmistry@google.com5626a922015-02-26 14:03:30 +00001364 raise PresubmitFailure('"%s" had an exception.\n%s'
1365 % (presubmit_path, e))
1366
1367 function_name = 'PostUploadHook'
1368 if function_name not in context:
1369 return {}
1370 post_upload_hook = context[function_name]
1371 if not len(inspect.getargspec(post_upload_hook)[0]) == 3:
1372 raise PresubmitFailure(
1373 'Expected function "PostUploadHook" to take three arguments.')
Edward Lemur016a0872020-02-04 22:13:28 +00001374 return post_upload_hook(gerrit_obj, change, OutputApi(False))
rmistry@google.com5626a922015-02-26 14:03:30 +00001375
1376
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001377def _MergeMasters(masters1, masters2):
1378 """Merges two master maps. Merges also the tests of each builder."""
1379 result = {}
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001380 for (master, builders) in itertools.chain(masters1.items(),
1381 masters2.items()):
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001382 new_builders = result.setdefault(master, {})
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001383 for (builder, tests) in builders.items():
machenbach@chromium.org58a69cb2014-03-01 02:08:29 +00001384 new_builders.setdefault(builder, set([])).update(tests)
1385 return result
1386
1387
rmistry@google.com5626a922015-02-26 14:03:30 +00001388def DoPostUploadExecuter(change,
Edward Lemur016a0872020-02-04 22:13:28 +00001389 gerrit_obj,
Edward Lemur6eb1d322020-02-27 22:20:15 +00001390 verbose):
rmistry@google.com5626a922015-02-26 14:03:30 +00001391 """Execute the post upload hook.
1392
1393 Args:
1394 change: The Change object.
Edward Lemur016a0872020-02-04 22:13:28 +00001395 gerrit_obj: The GerritAccessor object.
rmistry@google.com5626a922015-02-26 14:03:30 +00001396 verbose: Prints debug info.
rmistry@google.com5626a922015-02-26 14:03:30 +00001397 """
1398 presubmit_files = ListRelevantPresubmitFiles(
Edward Lemur6eb1d322020-02-27 22:20:15 +00001399 change.LocalPaths(), change.RepositoryRoot())
rmistry@google.com5626a922015-02-26 14:03:30 +00001400 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001401 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
rmistry@google.com5626a922015-02-26 14:03:30 +00001402 results = []
1403 executer = GetPostUploadExecuter()
1404 # The root presubmit file should be executed after the ones in subdirectories.
1405 # i.e. the specific post upload hooks should run before the general ones.
1406 # Thus, reverse the order provided by ListRelevantPresubmitFiles.
1407 presubmit_files.reverse()
1408
1409 for filename in presubmit_files:
1410 filename = os.path.abspath(filename)
1411 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001412 sys.stdout.write('Running %s\n' % filename)
rmistry@google.com5626a922015-02-26 14:03:30 +00001413 # Accept CRLF presubmit script.
1414 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1415 results.extend(executer.ExecPresubmitScript(
Edward Lemur016a0872020-02-04 22:13:28 +00001416 presubmit_script, filename, gerrit_obj, change))
rmistry@google.com5626a922015-02-26 14:03:30 +00001417
Edward Lemur6eb1d322020-02-27 22:20:15 +00001418 if not results:
1419 return 0
1420
1421 sys.stdout.write('\n')
1422 sys.stdout.write('** Post Upload Hook Messages **\n')
1423
1424 exit_code = 0
1425 for result in results:
1426 if result.fatal:
1427 exit_code = 1
1428 result.handle()
1429 sys.stdout.write('\n')
1430
1431 return exit_code
rmistry@google.com5626a922015-02-26 14:03:30 +00001432
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001433class PresubmitExecuter(object):
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001434 def __init__(self, change, committing, verbose, gerrit_obj, dry_run=None,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001435 thread_pool=None, parallel=False, use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001436 """
1437 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001438 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001439 committing: True if 'git cl land' is running, False if 'git cl upload' is.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001440 gerrit_obj: provides basic Gerrit codereview functionality.
1441 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001442 parallel: if true, all tests reported via input_api.RunTests for all
1443 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001444 use_python3: if true, will use python3 instead of python2 by default
1445 if USE_PYTHON3 is not specified.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001446 """
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001447 self.change = change
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001448 self.committing = committing
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001449 self.gerrit = gerrit_obj
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001450 self.verbose = verbose
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001451 self.dry_run = dry_run
Daniel Cheng7227d212017-11-17 08:12:37 -08001452 self.more_cc = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001453 self.thread_pool = thread_pool
1454 self.parallel = parallel
Dirk Pranke6f0df682021-06-25 00:42:33 +00001455 self.use_python3 = use_python3
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001456
1457 def ExecPresubmitScript(self, script_text, presubmit_path):
1458 """Executes a single presubmit script.
1459
1460 Args:
1461 script_text: The text of the presubmit script.
1462 presubmit_path: The path to the presubmit file (this will be reported via
1463 input_api.PresubmitLocalPath()).
1464
1465 Return:
1466 A list of result objects, empty if no problems.
1467 """
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001468
chase@chromium.org8e416c82009-10-06 04:30:44 +00001469 # Change to the presubmit file's directory to support local imports.
1470 main_path = os.getcwd()
Saagar Sanghavi98b332f2020-07-31 17:19:15 +00001471 presubmit_dir = os.path.dirname(presubmit_path)
1472 os.chdir(presubmit_dir)
chase@chromium.org8e416c82009-10-06 04:30:44 +00001473
1474 # Load the presubmit script into context.
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001475 input_api = InputApi(self.change, presubmit_path, self.committing,
Aaron Gable668c1d82018-04-03 10:19:16 -07001476 self.verbose, gerrit_obj=self.gerrit,
Edward Lesmes8e282792018-04-03 18:50:29 -04001477 dry_run=self.dry_run, thread_pool=self.thread_pool,
1478 parallel=self.parallel)
Daniel Cheng7227d212017-11-17 08:12:37 -08001479 output_api = OutputApi(self.committing)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001480 context = {}
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001481
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001482 # Try to figure out whether these presubmit checks should be run under
1483 # python2 or python3. We need to do this without actually trying to
1484 # compile the text, since the text might compile in one but not the
1485 # other.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001486 m = re.search('^USE_PYTHON3 = (True|False)$', script_text,
1487 flags=re.MULTILINE)
1488 if m:
1489 use_python3 = m.group(1) == 'True'
1490 else:
1491 use_python3 = self.use_python3
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001492 if (((sys.version_info.major == 2) and use_python3) or
1493 ((sys.version_info.major == 3) and not use_python3)):
1494 return []
1495
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001496 try:
Raul Tambre09e64b42019-05-14 01:57:22 +00001497 exec(compile(script_text, 'PRESUBMIT.py', 'exec', dont_inherit=True),
1498 context)
Raul Tambre7c938462019-05-24 16:35:35 +00001499 except Exception as e:
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001500 raise PresubmitFailure('"%s" had an exception.\n%s' % (presubmit_path, e))
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001501
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001502 context['__args'] = (input_api, output_api)
Ben Pastene8351dc12020-08-06 05:01:35 +00001503
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001504 # Get path of presubmit directory relative to repository root.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001505 # Always use forward slashes, so that path is same in *nix and Windows
1506 root = input_api.change.RepositoryRoot()
1507 rel_path = os.path.relpath(presubmit_dir, root)
1508 rel_path = rel_path.replace(os.path.sep, '/')
Ben Pastene8351dc12020-08-06 05:01:35 +00001509
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001510 # Get the URL of git remote origin and use it to identify host and project
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001511 host = project = ''
1512 if self.gerrit:
1513 host = self.gerrit.host or ''
1514 project = self.gerrit.project or ''
Saagar Sanghavi531d9922020-08-10 20:14:01 +00001515
1516 # Prefix for test names
1517 prefix = 'presubmit:%s/%s:%s/' % (host, project, rel_path)
1518
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001519 # Perform all the desired presubmit checks.
1520 results = []
Ben Pastene8351dc12020-08-06 05:01:35 +00001521
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001522 try:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001523 version = [
1524 int(x) for x in context.get('PRESUBMIT_VERSION', '0.0.0').split('.')
1525 ]
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001526
Scott Leecc2fe9b2020-11-19 19:38:06 +00001527 with rdb_wrapper.client(prefix) as sink:
1528 if version >= [2, 0, 0]:
1529 for function_name in context:
1530 if not function_name.startswith('Check'):
1531 continue
1532 if function_name.endswith('Commit') and not self.committing:
1533 continue
1534 if function_name.endswith('Upload') and self.committing:
1535 continue
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001536 logging.debug('Running %s in %s', function_name, presubmit_path)
1537 results.extend(
Scott Leecc2fe9b2020-11-19 19:38:06 +00001538 self._run_check_function(function_name, context, sink))
1539 logging.debug('Running %s done.', function_name)
1540 self.more_cc.extend(output_api.more_cc)
1541
1542 else: # Old format
1543 if self.committing:
1544 function_name = 'CheckChangeOnCommit'
1545 else:
1546 function_name = 'CheckChangeOnUpload'
1547 if function_name in context:
1548 logging.debug('Running %s in %s', function_name, presubmit_path)
1549 results.extend(
1550 self._run_check_function(function_name, context, sink))
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001551 logging.debug('Running %s done.', function_name)
1552 self.more_cc.extend(output_api.more_cc)
1553
1554 finally:
1555 for f in input_api._named_temporary_files:
1556 os.remove(f)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001557
chase@chromium.org8e416c82009-10-06 04:30:44 +00001558 # Return the process to the original working directory.
1559 os.chdir(main_path)
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001560 return results
1561
Scott Leecc2fe9b2020-11-19 19:38:06 +00001562 def _run_check_function(self, function_name, context, sink=None):
1563 """Evaluates and returns the result of a given presubmit function.
1564
1565 If sink is given, the result of the presubmit function will be reported
1566 to the ResultSink.
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001567
1568 Args:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001569 function_name: the name of the presubmit function to evaluate
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001570 context: a context dictionary in which the function will be evaluated
Scott Leecc2fe9b2020-11-19 19:38:06 +00001571 sink: an instance of ResultSink. None, by default.
1572 Returns:
1573 the result of the presubmit function call.
1574 """
1575 start_time = time_time()
1576 try:
Saagar Sanghavi03b15132020-08-10 16:43:41 +00001577 result = eval(function_name + '(*__args)', context)
1578 self._check_result_type(result)
Allen Webbfe7d7092021-05-18 02:05:49 +00001579 except Exception:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001580 if sink:
1581 elapsed_time = time_time() - start_time
1582 sink.report(function_name, rdb_wrapper.STATUS_FAIL, elapsed_time)
Allen Webbfe7d7092021-05-18 02:05:49 +00001583 # TODO(crbug.com/953884): replace reraise with native py3:
Allen Webbb65bbfe2021-05-11 21:22:01 +00001584 # raise .. from e
Allen Webbfe7d7092021-05-18 02:05:49 +00001585 e_type, e_value, e_tb = sys.exc_info()
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001586 print('Evaluation of %s failed: %s' % (function_name, e_value))
1587 six.reraise(e_type, e_value, e_tb)
Scott Leecc2fe9b2020-11-19 19:38:06 +00001588
Bruce Dawson2bdc49f2021-05-21 19:13:03 +00001589 elapsed_time = time_time() - start_time
1590 if elapsed_time > 10.0:
1591 sys.stdout.write(
1592 '%s took %.1fs to run.\n' % (function_name, elapsed_time))
Scott Leecc2fe9b2020-11-19 19:38:06 +00001593 if sink:
Scott Leecc2fe9b2020-11-19 19:38:06 +00001594 status = rdb_wrapper.STATUS_PASS
1595 if any(r.fatal for r in result):
1596 status = rdb_wrapper.STATUS_FAIL
1597 sink.report(function_name, status, elapsed_time)
1598
1599 return result
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001600
Saagar Sanghavi9949ab72020-07-20 20:56:40 +00001601 def _check_result_type(self, result):
1602 """Helper function which ensures result is a list, and all elements are
1603 instances of OutputApi.PresubmitResult"""
1604 if not isinstance(result, (tuple, list)):
1605 raise PresubmitFailure('Presubmit functions must return a tuple or list')
1606 if not all(isinstance(res, OutputApi.PresubmitResult) for res in result):
1607 raise PresubmitFailure(
1608 'All presubmit results must be of types derived from '
1609 'output_api.PresubmitResult')
1610
1611
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001612def DoPresubmitChecks(change,
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001613 committing,
1614 verbose,
maruel@chromium.orgb0dfd352009-06-10 14:12:54 +00001615 default_presubmit,
dpranke@chromium.org970c5222011-03-12 00:32:24 +00001616 may_prompt,
Aaron Gable668c1d82018-04-03 10:19:16 -07001617 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001618 dry_run=None,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001619 parallel=False,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001620 json_output=None,
1621 use_python3=False):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001622 """Runs all presubmit checks that apply to the files in the change.
1623
1624 This finds all PRESUBMIT.py files in directories enclosing the files in the
1625 change (up to the repository root) and calls the relevant entrypoint function
1626 depending on whether the change is being committed or uploaded.
1627
1628 Prints errors, warnings and notifications. Prompts the user for warnings
1629 when needed.
1630
1631 Args:
maruel@chromium.org4ff922a2009-06-12 20:20:19 +00001632 change: The Change object.
agable92bec4f2016-08-24 09:27:27 -07001633 committing: True if 'git cl land' is running, False if 'git cl upload' is.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001634 verbose: Prints debug info.
maruel@chromium.org0ff1fab2009-05-22 13:08:15 +00001635 default_presubmit: A default presubmit script to execute in any case.
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001636 may_prompt: Enable (y/n) questions on warning or error. If False,
1637 any questions are answered with yes by default.
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001638 gerrit_obj: provides basic Gerrit codereview functionality.
tandrii@chromium.org57bafac2016-04-28 05:09:03 +00001639 dry_run: if true, some Checks will be skipped.
Edward Lesmes8e282792018-04-03 18:50:29 -04001640 parallel: if true, all tests specified by input_api.RunTests in all
1641 PRESUBMIT files will be run in parallel.
Dirk Pranke6f0df682021-06-25 00:42:33 +00001642 use_python3: if true, default to using Python3 for presubmit checks
1643 rather than Python2.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001644 Return:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001645 1 if presubmit checks failed or 0 otherwise.
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001646 """
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001647 old_environ = os.environ
1648 try:
1649 # Make sure python subprocesses won't generate .pyc files.
1650 os.environ = os.environ.copy()
Edward Lemurb9830242019-10-30 22:19:20 +00001651 os.environ['PYTHONDONTWRITEBYTECODE'] = '1'
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001652
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001653 python_version = 'Python %s' % sys.version_info.major
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001654 if committing:
Dirk Pranke6fc394f2021-05-26 23:25:14 +00001655 sys.stdout.write('Running %s presubmit commit checks ...\n' %
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001656 python_version)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001657 else:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001658 sys.stdout.write('Running %s presubmit upload checks ...\n' %
1659 python_version)
Edward Lemurecc27072020-01-06 16:42:34 +00001660 start_time = time_time()
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001661 presubmit_files = ListRelevantPresubmitFiles(
agable0b65e732016-11-22 09:25:46 -08001662 change.AbsoluteLocalPaths(), change.RepositoryRoot())
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001663 if not presubmit_files and verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001664 sys.stdout.write('Warning, no PRESUBMIT.py found.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001665 results = []
Edward Lesmes8e282792018-04-03 18:50:29 -04001666 thread_pool = ThreadPool()
Edward Lemur7e3c67f2018-07-20 20:52:49 +00001667 executer = PresubmitExecuter(change, committing, verbose, gerrit_obj,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001668 dry_run, thread_pool, parallel, use_python3)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001669 if default_presubmit:
1670 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001671 sys.stdout.write('Running default presubmit script.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001672 fake_path = os.path.join(change.RepositoryRoot(), 'PRESUBMIT.py')
1673 results += executer.ExecPresubmitScript(default_presubmit, fake_path)
1674 for filename in presubmit_files:
1675 filename = os.path.abspath(filename)
1676 if verbose:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001677 sys.stdout.write('Running %s\n' % filename)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001678 # Accept CRLF presubmit script.
1679 presubmit_script = gclient_utils.FileRead(filename, 'rU')
1680 results += executer.ExecPresubmitScript(presubmit_script, filename)
Edward Lesmes8e282792018-04-03 18:50:29 -04001681 results += thread_pool.RunAsync()
1682
Edward Lemur6eb1d322020-02-27 22:20:15 +00001683 messages = {}
1684 should_prompt = False
1685 presubmits_failed = False
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001686 for result in results:
1687 if result.fatal:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001688 presubmits_failed = True
1689 messages.setdefault('ERRORS', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001690 elif result.should_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001691 should_prompt = True
1692 messages.setdefault('Warnings', []).append(result)
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001693 else:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001694 messages.setdefault('Messages', []).append(result)
pam@chromium.orged9a0832009-09-09 22:48:55 +00001695
Edward Lemur6eb1d322020-02-27 22:20:15 +00001696 sys.stdout.write('\n')
1697 for name, items in messages.items():
1698 sys.stdout.write('** Presubmit %s **\n' % name)
1699 for item in items:
1700 item.handle()
1701 sys.stdout.write('\n')
pam@chromium.orged9a0832009-09-09 22:48:55 +00001702
Edward Lemurecc27072020-01-06 16:42:34 +00001703 total_time = time_time() - start_time
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001704 if total_time > 1.0:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001705 sys.stdout.write(
1706 'Presubmit checks took %.1fs to calculate.\n\n' % total_time)
maruel@chromium.orgce8e46b2009-06-26 22:31:51 +00001707
Edward Lemur6eb1d322020-02-27 22:20:15 +00001708 if not should_prompt and not presubmits_failed:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001709 sys.stdout.write('%s presubmit checks passed.\n' % python_version)
Edward Lemur6eb1d322020-02-27 22:20:15 +00001710 elif should_prompt:
Dirk Pranke61bf6e82021-04-23 00:50:21 +00001711 sys.stdout.write('There were %s presubmit warnings. ' % python_version)
Quinten Yearsley516fe7f2016-12-14 11:50:18 -08001712 if may_prompt:
Edward Lemur6eb1d322020-02-27 22:20:15 +00001713 presubmits_failed = not prompt_should_continue(
1714 'Are you sure you wish to continue? (y/N): ')
Garrett Beatyacb807e2020-08-28 18:17:24 +00001715 else:
1716 sys.stdout.write('\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001717
Edward Lemur1dc66e12020-02-21 21:36:34 +00001718 if json_output:
1719 # Write the presubmit results to json output
1720 presubmit_results = {
1721 'errors': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001722 error.json_format()
1723 for error in messages.get('ERRORS', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001724 ],
1725 'notifications': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001726 notification.json_format()
1727 for notification in messages.get('Messages', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001728 ],
1729 'warnings': [
Edward Lemur6eb1d322020-02-27 22:20:15 +00001730 warning.json_format()
1731 for warning in messages.get('Warnings', [])
Edward Lemur1dc66e12020-02-21 21:36:34 +00001732 ],
Edward Lemur6eb1d322020-02-27 22:20:15 +00001733 'more_cc': executer.more_cc,
Edward Lemur1dc66e12020-02-21 21:36:34 +00001734 }
1735
1736 gclient_utils.FileWrite(
1737 json_output, json.dumps(presubmit_results, sort_keys=True))
1738
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001739 global _ASKED_FOR_FEEDBACK
1740 # Ask for feedback one time out of 5.
1741 if (len(results) and random.randint(0, 4) == 0 and not _ASKED_FOR_FEEDBACK):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001742 sys.stdout.write(
maruel@chromium.org1ce8e662014-01-14 15:23:00 +00001743 'Was the presubmit check useful? If not, run "git cl presubmit -v"\n'
1744 'to figure out which PRESUBMIT.py was run, then run git blame\n'
1745 'on the file to figure out who to ask for help.\n')
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001746 _ASKED_FOR_FEEDBACK = True
Edward Lemur6eb1d322020-02-27 22:20:15 +00001747
1748 return 1 if presubmits_failed else 0
maruel@chromium.orgea7c8552011-04-18 14:12:07 +00001749 finally:
1750 os.environ = old_environ
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001751
1752
Edward Lemur50984a62020-02-06 18:10:18 +00001753def _scan_sub_dirs(mask, recursive):
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001754 if not recursive:
pgervais@chromium.orge57b09d2014-05-07 00:58:13 +00001755 return [x for x in glob.glob(mask) if x not in ('.svn', '.git')]
Lei Zhang9611c4c2017-04-04 01:41:56 -07001756
1757 results = []
1758 for root, dirs, files in os.walk('.'):
1759 if '.svn' in dirs:
1760 dirs.remove('.svn')
1761 if '.git' in dirs:
1762 dirs.remove('.git')
1763 for name in files:
1764 if fnmatch.fnmatch(name, mask):
1765 results.append(os.path.join(root, name))
1766 return results
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001767
1768
Edward Lemur50984a62020-02-06 18:10:18 +00001769def _parse_files(args, recursive):
tobiasjs2836bcf2016-08-16 04:08:16 -07001770 logging.debug('Searching for %s', args)
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001771 files = []
1772 for arg in args:
Edward Lemur50984a62020-02-06 18:10:18 +00001773 files.extend([('M', f) for f in _scan_sub_dirs(arg, recursive)])
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001774 return files
1775
1776
Edward Lemur50984a62020-02-06 18:10:18 +00001777def _parse_change(parser, options):
1778 """Process change options.
1779
1780 Args:
1781 parser: The parser used to parse the arguments from command line.
1782 options: The arguments parsed from command line.
1783 Returns:
1784 A GitChange if the change root is a git repository, or a Change otherwise.
1785 """
1786 if options.files and options.all_files:
1787 parser.error('<files> cannot be specified when --all-files is set.')
1788
Edward Lesmes44ea3ff2020-02-05 00:14:30 +00001789 change_scm = scm.determine_scm(options.root)
Edward Lemur50984a62020-02-06 18:10:18 +00001790 if change_scm != 'git' and not options.files:
1791 parser.error('<files> is not optional for unversioned directories.')
1792
1793 if options.files:
1794 change_files = _parse_files(options.files, options.recursive)
1795 elif options.all_files:
1796 change_files = [('M', f) for f in scm.GIT.GetAllFiles(options.root)]
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001797 else:
Edward Lemur50984a62020-02-06 18:10:18 +00001798 change_files = scm.GIT.CaptureStatus(
Edward Lemur7f6dec02020-02-06 20:23:58 +00001799 options.root, options.upstream or None)
Edward Lemur50984a62020-02-06 18:10:18 +00001800
1801 logging.info('Found %d file(s).', len(change_files))
1802
1803 change_class = GitChange if change_scm == 'git' else Change
1804 return change_class(
1805 options.name,
1806 options.description,
1807 options.root,
1808 change_files,
1809 options.issue,
1810 options.patchset,
1811 options.author,
1812 upstream=options.upstream)
1813
1814
1815def _parse_gerrit_options(parser, options):
1816 """Process gerrit options.
1817
1818 SIDE EFFECTS: Modifies options.author and options.description from Gerrit if
1819 options.gerrit_fetch is set.
1820
1821 Args:
1822 parser: The parser used to parse the arguments from command line.
1823 options: The arguments parsed from command line.
1824 Returns:
Stephen Martinisfb09de22021-02-25 03:41:13 +00001825 A GerritAccessor object if options.gerrit_url is set, or None otherwise.
Edward Lemur50984a62020-02-06 18:10:18 +00001826 """
1827 gerrit_obj = None
Stephen Martinisfb09de22021-02-25 03:41:13 +00001828 if options.gerrit_url:
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001829 gerrit_obj = GerritAccessor(
1830 url=options.gerrit_url,
1831 project=options.gerrit_project,
1832 branch=options.gerrit_branch)
Edward Lemur50984a62020-02-06 18:10:18 +00001833
1834 if not options.gerrit_fetch:
1835 return gerrit_obj
1836
1837 if not options.gerrit_url or not options.issue or not options.patchset:
1838 parser.error(
1839 '--gerrit_fetch requires --gerrit_url, --issue and --patchset.')
1840
1841 options.author = gerrit_obj.GetChangeOwner(options.issue)
1842 options.description = gerrit_obj.GetChangeDescription(
1843 options.issue, options.patchset)
1844
1845 logging.info('Got author: "%s"', options.author)
1846 logging.info('Got description: """\n%s\n"""', options.description)
1847
1848 return gerrit_obj
maruel@chromium.org5c8c6de2011-03-18 16:20:18 +00001849
1850
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001851@contextlib.contextmanager
1852def canned_check_filter(method_names):
1853 filtered = {}
1854 try:
1855 for method_name in method_names:
1856 if not hasattr(presubmit_canned_checks, method_name):
Gavin Make6a62332020-12-04 21:57:10 +00001857 logging.warning('Skipping unknown "canned" check %s' % method_name)
Aaron Gableecee74c2018-04-02 15:13:08 -07001858 continue
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001859 filtered[method_name] = getattr(presubmit_canned_checks, method_name)
1860 setattr(presubmit_canned_checks, method_name, lambda *_a, **_kw: [])
1861 yield
1862 finally:
Marc-Antoine Ruel8e57b4b2019-10-11 01:01:36 +00001863 for name, method in filtered.items():
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001864 setattr(presubmit_canned_checks, name, method)
1865
maruel@chromium.orgffeb2f32013-12-03 13:55:22 +00001866
sbc@chromium.org013731e2015-02-26 18:28:43 +00001867def main(argv=None):
Edward Lemura5799e32020-01-17 19:26:51 +00001868 parser = argparse.ArgumentParser(usage='%(prog)s [options] <files...>')
1869 hooks = parser.add_mutually_exclusive_group()
1870 hooks.add_argument('-c', '--commit', action='store_true',
1871 help='Use commit instead of upload checks.')
1872 hooks.add_argument('-u', '--upload', action='store_false', dest='commit',
1873 help='Use upload instead of commit checks.')
Edward Lemur75526302020-02-27 22:31:05 +00001874 hooks.add_argument('--post_upload', action='store_true',
1875 help='Run post-upload commit hooks.')
Edward Lemura5799e32020-01-17 19:26:51 +00001876 parser.add_argument('-r', '--recursive', action='store_true',
1877 help='Act recursively.')
1878 parser.add_argument('-v', '--verbose', action='count', default=0,
1879 help='Use 2 times for more debug info.')
1880 parser.add_argument('--name', default='no name')
1881 parser.add_argument('--author')
Edward Lemur227d5102020-02-25 23:45:35 +00001882 desc = parser.add_mutually_exclusive_group()
1883 desc.add_argument('--description', default='', help='The change description.')
1884 desc.add_argument('--description_file',
1885 help='File to read change description from.')
Edward Lemura5799e32020-01-17 19:26:51 +00001886 parser.add_argument('--issue', type=int, default=0)
1887 parser.add_argument('--patchset', type=int, default=0)
1888 parser.add_argument('--root', default=os.getcwd(),
1889 help='Search for PRESUBMIT.py up to this directory. '
1890 'If inherit-review-settings-ok is present in this '
1891 'directory, parent directories up to the root file '
1892 'system directories will also be searched.')
1893 parser.add_argument('--upstream',
1894 help='Git only: the base ref or upstream branch against '
1895 'which the diff should be computed.')
1896 parser.add_argument('--default_presubmit')
1897 parser.add_argument('--may_prompt', action='store_true', default=False)
1898 parser.add_argument('--skip_canned', action='append', default=[],
1899 help='A list of checks to skip which appear in '
1900 'presubmit_canned_checks. Can be provided multiple times '
1901 'to skip multiple canned checks.')
1902 parser.add_argument('--dry_run', action='store_true', help=argparse.SUPPRESS)
1903 parser.add_argument('--gerrit_url', help=argparse.SUPPRESS)
Edward Lesmeseb1bd622021-03-01 19:54:07 +00001904 parser.add_argument('--gerrit_project', help=argparse.SUPPRESS)
1905 parser.add_argument('--gerrit_branch', help=argparse.SUPPRESS)
Edward Lemura5799e32020-01-17 19:26:51 +00001906 parser.add_argument('--gerrit_fetch', action='store_true',
1907 help=argparse.SUPPRESS)
1908 parser.add_argument('--parallel', action='store_true',
1909 help='Run all tests specified by input_api.RunTests in '
1910 'all PRESUBMIT files in parallel.')
1911 parser.add_argument('--json_output',
1912 help='Write presubmit errors to json output.')
Edward Lemur1dc66e12020-02-21 21:36:34 +00001913 parser.add_argument('--all_files', action='store_true',
Edward Lemur50984a62020-02-06 18:10:18 +00001914 help='Mark all files under source control as modified.')
Edward Lemura5799e32020-01-17 19:26:51 +00001915 parser.add_argument('files', nargs='*',
1916 help='List of files to be marked as modified when '
1917 'executing presubmit or post-upload hooks. fnmatch '
1918 'wildcards can also be used.')
Dirk Pranke6f0df682021-06-25 00:42:33 +00001919 parser.add_argument('--use-python3', action='store_true',
1920 help='Use python3 for presubmit checks by default')
Edward Lemura5799e32020-01-17 19:26:51 +00001921 options = parser.parse_args(argv)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001922
Erik Staabcca5c492020-04-16 17:40:07 +00001923 log_level = logging.ERROR
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001924 if options.verbose >= 2:
Erik Staabcca5c492020-04-16 17:40:07 +00001925 log_level = logging.DEBUG
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001926 elif options.verbose:
Erik Staabcca5c492020-04-16 17:40:07 +00001927 log_level = logging.INFO
1928 log_format = ('[%(levelname).1s%(asctime)s %(process)d %(thread)d '
1929 '%(filename)s] %(message)s')
1930 logging.basicConfig(format=log_format, level=log_level)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001931
Edward Lemur227d5102020-02-25 23:45:35 +00001932 if options.description_file:
1933 options.description = gclient_utils.FileRead(options.description_file)
Edward Lemur50984a62020-02-06 18:10:18 +00001934 gerrit_obj = _parse_gerrit_options(parser, options)
1935 change = _parse_change(parser, options)
pgervais@chromium.org92c30092014-04-15 00:30:37 +00001936
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001937 try:
Edward Lemur75526302020-02-27 22:31:05 +00001938 if options.post_upload:
1939 return DoPostUploadExecuter(
1940 change,
1941 gerrit_obj,
1942 options.verbose)
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001943 with canned_check_filter(options.skip_canned):
Edward Lemur6eb1d322020-02-27 22:20:15 +00001944 return DoPresubmitChecks(
Edward Lemur50984a62020-02-06 18:10:18 +00001945 change,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001946 options.commit,
1947 options.verbose,
iannucci@chromium.org8a4a2bc2013-03-08 08:13:20 +00001948 options.default_presubmit,
1949 options.may_prompt,
tandrii@chromium.org37b07a72016-04-29 16:42:28 +00001950 gerrit_obj,
Edward Lesmes8e282792018-04-03 18:50:29 -04001951 options.dry_run,
Debrian Figueroadd2737e2019-06-21 23:50:13 +00001952 options.parallel,
Dirk Pranke6f0df682021-06-25 00:42:33 +00001953 options.json_output,
1954 options.use_python3)
Raul Tambre7c938462019-05-24 16:35:35 +00001955 except PresubmitFailure as e:
Raul Tambre80ee78e2019-05-06 22:41:05 +00001956 print(e, file=sys.stderr)
1957 print('Maybe your depot_tools is out of date?', file=sys.stderr)
maruel@chromium.org899e1c12011-04-07 17:03:18 +00001958 return 2
maruel@google.comfb2b8eb2009-04-23 21:03:42 +00001959
1960
1961if __name__ == '__main__':
maruel@chromium.org35625c72011-03-23 17:34:02 +00001962 fix_encoding.fix_encoding()
sbc@chromium.org013731e2015-02-26 18:28:43 +00001963 try:
1964 sys.exit(main())
1965 except KeyboardInterrupt:
1966 sys.stderr.write('interrupted\n')
sergiybf8a3b382016-07-05 11:21:30 -07001967 sys.exit(2)