blob: e7949fec438d19dc89034e7a66205882133db5ed [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "media/engine/webrtc_video_engine.h"
12
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000013#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080014#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020015#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070016#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000017#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000018
Steve Anton2c9ebef2019-01-28 17:27:58 -080019#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010020#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020021#include "absl/strings/match.h"
Danil Chapovalov83bbe912019-08-07 12:24:53 +020022#include "api/rtc_event_log/rtc_event_log.h"
Steve Anton10542f22019-01-11 09:11:00 -080023#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020024#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070025#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/test/mock_video_bitrate_allocator.h"
27#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070028#include "api/test/mock_video_decoder_factory.h"
29#include "api/test/mock_video_encoder_factory.h"
Niels Möller65f17ca2019-09-12 13:59:36 +020030#include "api/transport/media/media_transport_config.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020031#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080032#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010033#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020034#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020035#include "api/video_codecs/builtin_video_decoder_factory.h"
36#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "api/video_codecs/sdp_video_format.h"
38#include "api/video_codecs/video_decoder_factory.h"
39#include "api/video_codecs/video_encoder.h"
40#include "api/video_codecs/video_encoder_factory.h"
41#include "call/flexfec_receive_stream.h"
42#include "common_video/h264/profile_level_id.h"
Niels Möller805a27e2019-01-21 12:21:27 +010043#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/base/fake_video_renderer.h"
46#include "media/base/media_constants.h"
47#include "media/base/rtp_utils.h"
48#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/fake_webrtc_call.h"
51#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "media/engine/webrtc_voice_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020054#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080055#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020056#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020057#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080058#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020059#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010060#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020061#include "test/gmock.h"
Tommi25eb47c2019-08-29 16:39:05 +020062#include "test/rtp_header_parser.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000063
Mirko Bonadei6a489f22019-04-09 15:11:12 +020064using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020065using ::testing::IsEmpty;
66using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010067using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070068using webrtc::RtpExtension;
69
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000070namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000071static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000072
noahricd10a68e2015-07-10 11:27:55 -070073static const uint8_t kRedRtxPayloadType = 125;
74
Niels Möller6557d0c2018-04-11 15:18:34 +020075static const uint32_t kTimeout = 5000U;
76static const uint32_t kDefaultReceiveSsrc = 0;
77static const uint32_t kSsrc = 1234u;
78static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
79static const int kVideoWidth = 640;
80static const int kVideoHeight = 360;
81static const int kFramerate = 30;
82
Peter Boström0c4e06b2015-10-07 12:23:21 +020083static const uint32_t kSsrcs1[] = {1};
84static const uint32_t kSsrcs3[] = {1, 2, 3};
85static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080086static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020087static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080088static const uint32_t kDefaultRecvSsrc = 0;
89
Bjorn A Mellemda4f0932019-07-30 08:34:03 -070090constexpr uint32_t kRtpHeaderSize = 12;
91
pbos@webrtc.org3c107582014-07-20 15:27:35 +000092static const char kUnsupportedExtensionName[] =
93 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000094
magjed509e4fe2016-11-18 01:34:11 -080095cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
96 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020097 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080098}
99
Elad Alonfadb1812019-05-24 13:40:02 +0200100void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
101 bool lntf_expected) {
102 EXPECT_EQ(lntf_expected,
103 codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
106 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
108 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
110 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
111 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800112 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
113 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000114 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
115}
116
magjed725e4842016-11-16 00:48:13 -0800117// Return true if any codec in |codecs| is an RTX codec with associated payload
118// type |payload_type|.
119bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
120 int payload_type) {
121 for (const cricket::VideoCodec& codec : codecs) {
122 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200123 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800124 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
125 &associated_payload_type) &&
126 associated_payload_type == payload_type) {
127 return true;
128 }
129 }
130 return false;
131}
132
nisseca5706d2017-09-11 02:32:16 -0700133// TODO(nisse): Duplicated in call.cc.
134const int* FindKeyByValue(const std::map<int, int>& m, int v) {
135 for (const auto& kv : m) {
136 if (kv.second == v)
137 return &kv.first;
138 }
139 return nullptr;
140}
141
Yves Gerey665174f2018-06-19 15:03:05 +0200142bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
143 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700144 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
145 payload_type) != nullptr;
146}
147
148// Check that there's an Rtx payload type for each decoder.
149bool VerifyRtxReceiveAssociations(
150 const webrtc::VideoReceiveStream::Config& config) {
151 for (const auto& decoder : config.decoders) {
152 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
153 return false;
154 }
155 return true;
156}
157
brandtrffc61182016-11-28 06:02:22 -0800158rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700159 int width,
160 int height) {
161 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
162 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800163 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700164 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000165}
166
Shao Changbine62202f2015-04-21 20:24:50 +0800167void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
168 const std::map<int, int>& rtx_types) {
169 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200170 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800171 EXPECT_TRUE(it != rtx_types.end() &&
172 it->second == config.rtp.rtx.payload_type);
173
brandtrb5f2c3f2016-10-04 23:28:39 -0700174 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
175 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800176 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700177 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800178 }
179}
kthelgason2bc68642017-02-07 07:02:22 -0800180
181cricket::MediaConfig GetMediaConfig() {
182 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100183 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800184 return media_config;
185}
nisse26e3abb2017-08-25 04:44:25 -0700186
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200187// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
188int GetMaxDefaultBitrateBps(size_t width, size_t height) {
189 if (width * height <= 320 * 240) {
190 return 600000;
191 } else if (width * height <= 640 * 480) {
192 return 1700000;
193 } else if (width * height <= 960 * 540) {
194 return 2000000;
195 } else {
196 return 2500000;
197 }
198}
199
Niels Möller731a2c22018-07-30 15:08:07 +0200200class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
201 public:
202 MOCK_METHOD2(AddOrUpdateSink,
203 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
204 const rtc::VideoSinkWants& wants));
205 MOCK_METHOD1(RemoveSink,
206 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
207};
208
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000209} // namespace
210
Yves Gerey665174f2018-06-19 15:03:05 +0200211#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200212 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200213 EXPECT_EQ((w), renderer_.width()); \
214 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200215 EXPECT_EQ(0, renderer_.errors());
216
Yves Gerey665174f2018-06-19 15:03:05 +0200217#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200218 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200219 EXPECT_EQ((w), (r).width()); \
220 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200221 EXPECT_EQ(0, (r).errors());
222
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000223namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700224class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000225 public:
eladalonf1841382017-06-12 01:16:46 -0700226 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200227 explicit WebRtcVideoEngineTest(const std::string& field_trials)
228 : override_field_trials_(
229 field_trials.empty()
230 ? nullptr
231 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
232 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200233 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
234 call_(webrtc::Call::Create([&] {
235 webrtc::Call::Config call_config(&event_log_);
236 call_config.task_queue_factory = task_queue_factory_.get();
237 return call_config;
238 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200239 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
240 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200241 video_bitrate_allocator_factory_(
242 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200243 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200244 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200245 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200246 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200247 // Ensure fake clock doesn't return 0, which will cause some initializations
248 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200249 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200250 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000251
252 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200253 void AssignDefaultAptRtxTypes();
254 void AssignDefaultCodec();
255
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100256 // Find the index of the codec in the engine with the given name. The codec
257 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100258 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100259
magjed509e4fe2016-11-18 01:34:11 -0800260 // Find the codec in the engine with the given name. The codec must be
261 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100262 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800263
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200264 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000265
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200266 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000267 const std::vector<VideoCodec>& codecs);
268
Elad Alon157540a2019-02-08 23:37:52 +0100269 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100270
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200271 // Has to be the first one, so it is initialized before the call or there is a
272 // race condition in the clock access.
273 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200274 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
Danil Chapovalov83bbe912019-08-07 12:24:53 +0200275 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200276 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700277 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000278 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800279 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200280 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
281 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200282 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
283 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700284 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000285 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800286 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000287};
288
eladalonf1841382017-06-12 01:16:46 -0700289TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200290 encoder_factory_->AddSupportedVideoCodecType("VP8");
291 AssignDefaultCodec();
292
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000293 std::vector<VideoCodec> engine_codecs = engine_.codecs();
294 for (size_t i = 0; i < engine_codecs.size(); ++i) {
295 if (engine_codecs[i].name != kRtxCodecName)
296 continue;
297 int associated_payload_type;
298 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000299 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000300 EXPECT_EQ(default_codec_.id, associated_payload_type);
301 return;
302 }
303 FAIL() << "No RTX codec found among default codecs.";
304}
305
eladalonf1841382017-06-12 01:16:46 -0700306TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100307 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100311 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100315 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700316}
317
eladalonf1841382017-06-12 01:16:46 -0700318TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100319 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
320}
321
322TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
323 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
327 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
328}
329
330TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
331 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
332}
333
334TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
335 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100336}
337
338TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100339 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
340}
341
Elad Alonccb9b752019-02-19 13:01:31 +0100342TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
343 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
344}
345
346TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700348}
349
philipel1e054862018-10-08 16:13:53 +0200350class WebRtcVideoEngineTestWithGenericDescriptor
351 : public WebRtcVideoEngineTest {
352 public:
353 WebRtcVideoEngineTestWithGenericDescriptor()
354 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
355};
356
Elad Alonccb9b752019-02-19 13:01:31 +0100357TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
358 AdvertiseGenericDescriptor00) {
359 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
360}
361
362TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
363 AdvertiseGenericDescriptor01) {
364 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200365}
366
eladalonf1841382017-06-12 01:16:46 -0700367TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200368 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200370 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700371
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200372 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200374 std::unique_ptr<VideoMediaChannel> channel(
375 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700376 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
377
378 // Add CVO extension.
379 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800380 cricket::VideoSendParameters parameters;
381 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200382 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700383 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200384 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700385
Niels Möller731a2c22018-07-30 15:08:07 +0200386 EXPECT_CALL(
387 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200388 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200389 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700390 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200391 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700392
393 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200394 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700395
396 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200397 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200398 EXPECT_CALL(
399 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200400 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200401 Field(&rtc::VideoSinkWants::rotation_applied, true)));
402
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200403 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700404}
405
eladalonf1841382017-06-12 01:16:46 -0700406TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200407 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800408 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200409 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800410
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200411 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800412
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200413 std::unique_ptr<VideoMediaChannel> channel(
414 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800415 // Add CVO extension.
416 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800417 cricket::VideoSendParameters parameters;
418 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800419 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700420 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800421 EXPECT_TRUE(channel->SetSendParameters(parameters));
422 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
423
Niels Möller731a2c22018-07-30 15:08:07 +0200424 // Set source.
425 EXPECT_CALL(
426 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200427 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200428 Field(&rtc::VideoSinkWants::rotation_applied, false)));
429 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800430}
431
eladalonf1841382017-06-12 01:16:46 -0700432TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200433 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700434
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200435 encoder_factory_->AddSupportedVideoCodecType("VP8");
436 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700437
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200438 std::unique_ptr<VideoMediaChannel> channel(
439 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700440 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
441
442 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200443 EXPECT_CALL(
444 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200445 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200446 Field(&rtc::VideoSinkWants::rotation_applied, true)));
447 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700448
perkjcaafdba2016-03-20 07:34:29 -0700449 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200450 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700451
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452 // Add CVO extension.
453 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800454 cricket::VideoSendParameters parameters;
455 parameters.codecs.push_back(GetEngineCodec("VP8"));
456 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200457 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700458 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700459 // Also remove the first codec to trigger a codec change as well.
460 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200461 EXPECT_CALL(
462 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200463 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200464 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200465 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700466
467 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200468 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700469
470 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200471 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200472 EXPECT_CALL(
473 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200474 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200475 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200476 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700477}
478
eladalonf1841382017-06-12 01:16:46 -0700479TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200480 encoder_factory_->AddSupportedVideoCodecType("VP8");
481
Sebastian Jansson84848f22018-11-16 10:40:36 +0100482 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200483 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
484 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000485
486 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
487
488 EXPECT_FALSE(channel->SetSend(true))
489 << "Channel should not start without codecs.";
490 EXPECT_TRUE(channel->SetSend(false))
491 << "Channel should be stoppable even without set codecs.";
492}
493
eladalonf1841382017-06-12 01:16:46 -0700494TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200495 encoder_factory_->AddSupportedVideoCodecType("VP8");
496
Sebastian Jansson84848f22018-11-16 10:40:36 +0100497 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200498 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
499 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000500 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
501 VideoMediaInfo info;
502 channel->GetStats(&info);
503}
504
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200505TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200506 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000507
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200508 std::unique_ptr<VideoMediaChannel> channel(
509 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800510 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
512 EXPECT_TRUE(
513 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200514 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100516 webrtc::test::FrameForwarder frame_forwarder;
517 cricket::FakeFrameSource frame_source(1280, 720,
518 rtc::kNumMicrosecsPerSec / 30);
519 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
520 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100521 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200522 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
523 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000524 kTimeout);
525
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100527 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000528
529 // Setting codecs of the same type should not reallocate any encoders
530 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800531 cricket::VideoSendParameters parameters;
532 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200533 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200534 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000535
536 // Remove stream previously added to free the external encoder instance.
537 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200538 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000539}
540
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200541// Test that when an encoder factory supports H264, we add an RTX
542// codec for it.
543// TODO(deadbeef): This test should be updated if/when we start
544// adding RTX codecs for unrecognized codec names.
545TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800546 using webrtc::H264::kLevel1;
Jonas Olssona4d87372019-07-05 19:08:33 +0200547 using webrtc::H264::ProfileLevelId;
548 using webrtc::H264::ProfileLevelIdToString;
Anders Carlsson67537952018-05-03 11:28:29 +0200549 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
550 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800551 *ProfileLevelIdToString(
552 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200553 webrtc::SdpVideoFormat h264_constrained_high("H264");
554 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800555 *ProfileLevelIdToString(
556 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200557 webrtc::SdpVideoFormat h264_high("H264");
558 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800559 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
560
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200561 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
562 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
563 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700564
magjed725e4842016-11-16 00:48:13 -0800565 // First figure out what payload types the test codecs got assigned.
566 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800567 // Now search for RTX codecs for them. Expect that they all have associated
568 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800569 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200570 codecs,
571 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
572 ->id));
magjed725e4842016-11-16 00:48:13 -0800573 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200574 codecs,
575 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
576 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800577 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200578 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700579}
580
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100581#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700582TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200583 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100584
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200585 std::unique_ptr<VideoMediaChannel> channel(
586 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100587
588 EXPECT_TRUE(
589 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
590}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100591#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100592
eladalonf1841382017-06-12 01:16:46 -0700593TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200594 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100595 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200596 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200597 std::unique_ptr<VideoMediaChannel> channel(
598 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700599
600 EXPECT_TRUE(
601 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
602
Niels Möllerd0f0f682019-01-14 09:09:53 +0100603 webrtc::test::FrameForwarder frame_forwarder;
604 cricket::FakeFrameSource frame_source(1280, 720,
605 rtc::kNumMicrosecsPerSec / 60);
606 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700607 channel->SetSend(true);
608
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200609 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700610
Niels Möllerd0f0f682019-01-14 09:09:53 +0100611 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700612 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700613 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100614 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700615 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700616 int64_t interval = timestamp - last_timestamp;
617
618 // Precision changes from nanosecond to millisecond.
619 // Allow error to be no more than 1.
620 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
621
622 last_timestamp = timestamp;
623 }
624
Niels Möllerd0f0f682019-01-14 09:09:53 +0100625 frame_forwarder.IncomingCapturedFrame(
626 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
627 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700628 last_timestamp = stream->GetLastTimestamp();
629 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100630 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
631 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
632 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700633 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700634 int64_t interval = timestamp - last_timestamp;
635
636 // Precision changes from nanosecond to millisecond.
637 // Allow error to be no more than 1.
638 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
639
640 last_timestamp = timestamp;
641 }
642
643 // Remove stream previously added to free the external encoder instance.
644 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
645}
646
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200647void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
648 std::vector<VideoCodec> engine_codecs = engine_.codecs();
649 RTC_DCHECK(!engine_codecs.empty());
650 for (const cricket::VideoCodec& codec : engine_codecs) {
651 if (codec.name == "rtx") {
652 int associated_payload_type;
653 if (codec.GetParam(kCodecParamAssociatedPayloadType,
654 &associated_payload_type)) {
655 default_apt_rtx_types_[associated_payload_type] = codec.id;
656 }
657 }
658 }
659}
660
661void WebRtcVideoEngineTest::AssignDefaultCodec() {
662 std::vector<VideoCodec> engine_codecs = engine_.codecs();
663 RTC_DCHECK(!engine_codecs.empty());
664 bool codec_set = false;
665 for (const cricket::VideoCodec& codec : engine_codecs) {
666 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
667 codec.name != "ulpfec") {
668 default_codec_ = codec;
669 codec_set = true;
670 }
671 }
672
673 RTC_DCHECK(codec_set);
674}
675
Oleh Prypina40f8242017-12-21 13:32:23 +0100676size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
677 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100678 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
679 for (size_t i = 0; i < codecs.size(); ++i) {
680 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200681 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200682 continue;
683 // The tests only use H264 Constrained Baseline. Make sure we don't return
684 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200685 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200686 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200687 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
688 if (profile_level_id->profile !=
689 webrtc::H264::kProfileConstrainedBaseline) {
690 continue;
691 }
692 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100693 return i;
magjed509e4fe2016-11-18 01:34:11 -0800694 }
695 // This point should never be reached.
696 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100697 return -1;
698}
699
700cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
701 const std::string& name) const {
702 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800703}
704
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200705VideoMediaChannel*
706WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100707 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200708 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
709 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200710 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800711 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200712 for (const webrtc::SdpVideoFormat& format :
713 encoder_factory_->GetSupportedFormats()) {
714 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800715 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200716 parameters.codecs.push_back(engine_codec);
717 }
718 }
magjed509e4fe2016-11-18 01:34:11 -0800719
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200720 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000721
722 return channel;
723}
724
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200725VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000726 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100727 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200728 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
729 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200730 cricket::VideoRecvParameters parameters;
731 parameters.codecs = codecs;
732 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000733
734 return channel;
735}
736
Elad Alon157540a2019-02-08 23:37:52 +0100737void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
738 bool supported) const {
739 const RtpCapabilities capabilities = engine_.GetCapabilities();
740 if (supported) {
741 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200742 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100743 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200744 EXPECT_THAT(capabilities.header_extensions,
745 ::testing::Each(::testing::Field(&RtpExtension::uri,
746 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100747 }
748}
749
eladalonf1841382017-06-12 01:16:46 -0700750TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200751 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000752
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200753 std::unique_ptr<VideoMediaChannel> channel(
754 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000755
Peter Boström0c4e06b2015-10-07 12:23:21 +0200756 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000757
Yves Gerey665174f2018-06-19 15:03:05 +0200758 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000759 EXPECT_TRUE(channel->SetSend(true));
760
Niels Möller805a27e2019-01-21 12:21:27 +0100761 webrtc::test::FrameForwarder frame_forwarder;
762 cricket::FakeFrameSource frame_source(1280, 720,
763 rtc::kNumMicrosecsPerSec / 60);
764 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
765 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000766
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200767 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000768
769 // Verify that encoders are configured for simulcast through adapter
770 // (increasing resolution and only configured to send one stream each).
771 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200772 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
773 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000774 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200775 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000776 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
777 EXPECT_GT(codec_settings.width, prev_width);
778 prev_width = codec_settings.width;
779 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000780
Niels Möllerff40b142018-04-09 08:49:14 +0200781 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000782
783 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200784 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000785}
786
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200787TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
788 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200789 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000790
Niels Möllerd0f0f682019-01-14 09:09:53 +0100791 // Frame source.
792 webrtc::test::FrameForwarder frame_forwarder;
793 cricket::FakeFrameSource frame_source(1280, 720,
794 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200795
Sebastian Jansson84848f22018-11-16 10:40:36 +0100796 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200797 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
798 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200799 cricket::VideoSendParameters parameters;
800 parameters.codecs.push_back(GetEngineCodec("H264"));
801 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000802
803 EXPECT_TRUE(
804 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100805 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200806 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100807 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200808
809 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000810
Anders Carlsson67537952018-05-03 11:28:29 +0200811 cricket::VideoSendParameters new_parameters;
812 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
813 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200814
815 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100816 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200817
Anders Carlsson8a150d92018-05-14 12:40:04 +0200818 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000819}
820
eladalonf1841382017-06-12 01:16:46 -0700821TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000822 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200823 encoder_factory_->AddSupportedVideoCodecType("VP8");
824 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000825
Sebastian Jansson84848f22018-11-16 10:40:36 +0100826 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200827 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
828 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800829 cricket::VideoSendParameters parameters;
830 parameters.codecs.push_back(GetEngineCodec("VP8"));
831 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000832
Peter Boström0c4e06b2015-10-07 12:23:21 +0200833 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834
Yves Gerey665174f2018-06-19 15:03:05 +0200835 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836 EXPECT_TRUE(channel->SetSend(true));
837
838 // Send a fake frame, or else the media engine will configure the simulcast
839 // encoder adapter at a low-enough size that it'll only create a single
840 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100841 webrtc::test::FrameForwarder frame_forwarder;
842 cricket::FakeFrameSource frame_source(1280, 720,
843 rtc::kNumMicrosecsPerSec / 30);
844 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
845 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000846
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200847 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
848 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200850 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000851
852 channel.reset();
853 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000855}
856
eladalonf1841382017-06-12 01:16:46 -0700857TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000858 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200859 encoder_factory_->AddSupportedVideoCodecType("VP8");
860 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000861
Sebastian Jansson84848f22018-11-16 10:40:36 +0100862 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200863 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
864 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800865 cricket::VideoSendParameters parameters;
866 parameters.codecs.push_back(GetEngineCodec("H264"));
867 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000868
869 EXPECT_TRUE(
870 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100871
872 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100873 webrtc::test::FrameForwarder frame_forwarder;
874 cricket::FakeFrameSource frame_source(1280, 720,
875 rtc::kNumMicrosecsPerSec / 30);
876 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
877 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200878 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
879 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200880 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000881 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200882 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000883
884 channel.reset();
885 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200886 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000887}
888
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200889TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200890 RTC_DCHECK(!override_field_trials_);
891 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200892 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200893 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700894
Sebastian Jansson84848f22018-11-16 10:40:36 +0100895 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200896 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
897 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200898 cricket::VideoSendParameters parameters;
899 parameters.codecs.push_back(GetEngineCodec("H264"));
900 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700901
Peter Boström0c4e06b2015-10-07 12:23:21 +0200902 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700903 EXPECT_TRUE(
904 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100905
906 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100907 webrtc::test::FrameForwarder frame_forwarder;
908 cricket::FakeFrameSource frame_source(1280, 720,
909 rtc::kNumMicrosecsPerSec / 30);
910 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
911 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100912
Niels Möller4db138e2018-04-19 09:04:13 +0200913 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200914 ASSERT_EQ(1u, encoder_factory_->encoders().size());
915 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
916 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700917 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200918 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200919 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700920}
921
brandtrffc61182016-11-28 06:02:22 -0800922// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700923// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800924//
925// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700926TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800927 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200928 encoder_factory_->AddSupportedVideoCodecType("VP8");
929
Steve Anton2c9ebef2019-01-28 17:27:58 -0800930 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800931
932 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800933 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800934
935 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200936 RTC_DCHECK(!override_field_trials_);
937 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800938 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800939 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800940}
941
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200942// Test that codecs are added in the order they are reported from the factory.
943TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
944 encoder_factory_->AddSupportedVideoCodecType("VP8");
945 const char* kFakeCodecName = "FakeCodec";
946 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000947
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200948 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100949 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200950 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
951 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000952}
953
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200954// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800955// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200956TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100957 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
958 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100959
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100960 // Set up external encoder factory with first codec, and initialize engine.
961 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
962
brandtrffc61182016-11-28 06:02:22 -0800963 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800964
965 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100966 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800967 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200968 // The codec itself and RTX should have been added.
969 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100970
971 // Check that both fake codecs are present and that the second fake codec
972 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100973 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
974 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100975 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800976}
977
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200978TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
979 const char* kFakeCodecName = "FakeCodec";
980 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
981
982 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
983 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
984}
985
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200986TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
987 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200988 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200989 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800990 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000991
kwiberg686a8ef2016-02-26 03:00:35 -0800992 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200993 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000994
995 EXPECT_TRUE(
996 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200997 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998
999 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001000 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001001 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001002
1003 // Remove stream previously added to free the external decoder instance.
1004 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001005 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006}
1007
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001008// Verifies that we can set up decoders.
1009TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1011 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1012 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1013 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001014 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001015 webrtc::SdpVideoFormat supported_h264("H264");
1016 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1017 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001018 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001019 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001020
kwiberg686a8ef2016-02-26 03:00:35 -08001021 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001022 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001023
1024 EXPECT_TRUE(
1025 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001026 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001027}
1028
Jonas Oreland49ac5952018-09-26 16:04:32 +02001029// Tests when GetSources is called with non-existing ssrc, it will return an
1030// empty list of RtpSource without crashing.
1031TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1032 // Setup an recv stream with |kSsrc|.
1033 encoder_factory_->AddSupportedVideoCodecType("VP8");
1034 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1035 cricket::VideoRecvParameters parameters;
1036 parameters.codecs.push_back(GetEngineCodec("VP8"));
1037 std::unique_ptr<VideoMediaChannel> channel(
1038 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1039
1040 EXPECT_TRUE(
1041 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1042
1043 // Call GetSources with |kSsrc + 1| which doesn't exist.
1044 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1045 EXPECT_EQ(0u, sources.size());
1046}
1047
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001048TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1049 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1050 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1051 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001052 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001053 EXPECT_EQ(0u, engine.codecs().size());
1054}
1055
1056TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1057 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001058 webrtc::MockVideoEncoderFactory* encoder_factory =
1059 new webrtc::MockVideoEncoderFactory();
1060 webrtc::MockVideoDecoderFactory* decoder_factory =
1061 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001062 WebRtcVideoEngine engine(
1063 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001064 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001065 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1066 EXPECT_EQ(0u, engine.codecs().size());
1067 EXPECT_CALL(*encoder_factory, Die());
1068 EXPECT_CALL(*decoder_factory, Die());
1069}
1070
1071// Test full behavior in the video engine when video codec factories of the new
1072// type are injected supporting the single codec Vp8. Check the returned codecs
1073// from the engine and that we will create a Vp8 encoder and decoder using the
1074// new factories.
1075TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1076 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001077 webrtc::MockVideoEncoderFactory* encoder_factory =
1078 new webrtc::MockVideoEncoderFactory();
1079 webrtc::MockVideoDecoderFactory* decoder_factory =
1080 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001081 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1082 rate_allocator_factory =
1083 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001084 EXPECT_CALL(*rate_allocator_factory,
1085 CreateVideoBitrateAllocatorProxy(Field(
1086 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001087 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001088 WebRtcVideoEngine engine(
1089 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001090 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001091 const webrtc::SdpVideoFormat vp8_format("VP8");
1092 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1093 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001094 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095
1096 // Verify the codecs from the engine.
1097 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001098 // Verify default codecs has been added correctly.
1099 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001100 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001101
1102 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001103 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001104 int vp8_associated_payload;
1105 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1106 &vp8_associated_payload));
1107 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1108
1109 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1110
1111 // RTX codec for RED.
1112 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1113 int red_associated_payload;
1114 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1115 &red_associated_payload));
1116 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1117
1118 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1119
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001120 int associated_payload_type;
1121 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1122 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1123 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1124 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001125 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1126 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001127
1128 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001129 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1130 codec_info.is_hardware_accelerated = false;
1131 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001132 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001133 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001134 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001135 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001136 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001137 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001138 .WillOnce(
1139 ::testing::DoAll(::testing::InvokeWithoutArgs(
1140 [&encoder_created]() { encoder_created.Set(); }),
1141 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001142
1143 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001144 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001145 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001146 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001147
1148 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001149 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001150 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1151 webrtc::Call::Config call_config(&event_log);
1152 call_config.task_queue_factory = task_queue_factory.get();
1153 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001154
1155 // Create send channel.
1156 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001157 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001158 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1159 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001160 cricket::VideoSendParameters send_parameters;
1161 send_parameters.codecs.push_back(engine_codecs.at(0));
1162 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1163 send_channel->OnReadyToSend(true);
1164 EXPECT_TRUE(
1165 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1166 EXPECT_TRUE(send_channel->SetSend(true));
1167
Niels Möller4db138e2018-04-19 09:04:13 +02001168 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001169 webrtc::test::FrameForwarder frame_forwarder;
1170 cricket::FakeFrameSource frame_source(1280, 720,
1171 rtc::kNumMicrosecsPerSec / 30);
1172 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001173 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001174 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001175 encoder_created.Wait(kTimeout);
1176
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001177 // Create recv channel.
1178 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001179 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001180 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1181 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001182 cricket::VideoRecvParameters recv_parameters;
1183 recv_parameters.codecs.push_back(engine_codecs.at(0));
1184 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1185 EXPECT_TRUE(recv_channel->AddRecvStream(
1186 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1187
1188 // Remove streams previously added to free the encoder and decoder instance.
1189 EXPECT_CALL(*encoder_factory, Die());
1190 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001191 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001192 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1193 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1194}
1195
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001196// Test behavior when decoder factory fails to create a decoder (returns null).
1197TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1198 // |engine| take ownership of the factories.
1199 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001200 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001201 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001202 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001203 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1204 rate_allocator_factory =
1205 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001206 WebRtcVideoEngine engine(
1207 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001208 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001209 const webrtc::SdpVideoFormat vp8_format("VP8");
1210 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1211 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001212 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001213
1214 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001215 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1216 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001217
1218 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001219 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001220 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1221 webrtc::Call::Config call_config(&event_log);
1222 call_config.task_queue_factory = task_queue_factory.get();
1223 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001224
1225 // Create recv channel.
1226 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001227 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001228 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1229 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001230 cricket::VideoRecvParameters recv_parameters;
1231 recv_parameters.codecs.push_back(engine.codecs().front());
1232 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1233 EXPECT_TRUE(recv_channel->AddRecvStream(
1234 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1235
1236 // Remove streams previously added to free the encoder and decoder instance.
1237 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1238}
1239
eladalonf1841382017-06-12 01:16:46 -07001240TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001241 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001242 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001243 std::unique_ptr<VideoMediaChannel> channel(
1244 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001245 ASSERT_TRUE(
1246 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1247 cricket::VideoCodec codec = GetEngineCodec("VP8");
1248 cricket::VideoSendParameters parameters;
1249 parameters.codecs.push_back(codec);
1250 channel->OnReadyToSend(true);
1251 channel->SetSend(true);
1252 ASSERT_TRUE(channel->SetSendParameters(parameters));
1253
Niels Möller805a27e2019-01-21 12:21:27 +01001254 webrtc::test::FrameForwarder frame_forwarder;
1255 cricket::FakeFrameSource frame_source(1280, 720,
1256 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001257 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001258 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001259
Niels Möller805a27e2019-01-21 12:21:27 +01001260 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001261 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001262 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001263 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001264
Niels Möller805a27e2019-01-21 12:21:27 +01001265 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1266 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001267 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001268 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001269
1270 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001271 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1272 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001273 // Change to screen content, recreate encoder. For the simulcast encoder
1274 // adapter case, this will result in two calls since InitEncode triggers a
1275 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001276 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001277 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001278 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001279
Niels Möller805a27e2019-01-21 12:21:27 +01001280 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1281 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001282 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001283 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001284
1285 options.is_screencast.emplace(false);
1286 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001287 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001288 // Change back to regular video content, update encoder. Also change
1289 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001290 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001291 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001292 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001293 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001294
1295 // Remove stream previously added to free the external encoder instance.
1296 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001297 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001298}
1299
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001300class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001301 protected:
1302 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001303 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1304 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001305 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1306 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1307 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001308
1309 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001310 // One testcase calls SetUp in a loop, only create call_ once.
1311 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001312 webrtc::Call::Config call_config(&event_log_);
1313 call_config.task_queue_factory = task_queue_factory_.get();
1314 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001315 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001316 cricket::MediaConfig media_config;
1317 // Disabling cpu overuse detection actually disables quality scaling too; it
1318 // implies DegradationPreference kMaintainResolution. Automatic scaling
1319 // needs to be disabled, otherwise, tests which check the size of received
1320 // frames become flaky.
1321 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001322 channel_.reset(
1323 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1324 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001325 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001326 channel_->OnReadyToSend(true);
1327 EXPECT_TRUE(channel_.get() != NULL);
1328 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001329 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001330 cricket::VideoRecvParameters parameters;
1331 parameters.codecs = engine_.codecs();
1332 channel_->SetRecvParameters(parameters);
1333 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001334 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1335 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1336 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1337 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001338 }
1339
1340 // Utility method to setup an additional stream to send and receive video.
1341 // Used to test send and recv between two streams.
1342 void SetUpSecondStream() {
1343 SetUpSecondStreamWithNoRecv();
1344 // Setup recv for second stream.
1345 EXPECT_TRUE(channel_->AddRecvStream(
1346 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1347 // Make the second renderer available for use by a new stream.
1348 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1349 }
1350 // Setup an additional stream just to send video. Defer add recv stream.
1351 // This is required if you want to test unsignalled recv of video rtp packets.
1352 void SetUpSecondStreamWithNoRecv() {
1353 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001354 EXPECT_TRUE(
1355 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001356 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001357 EXPECT_FALSE(
1358 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001359 EXPECT_TRUE(channel_->AddSendStream(
1360 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1361 // We dont add recv for the second stream.
1362
1363 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001364 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001365 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001366 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001367 }
Yves Gerey665174f2018-06-19 15:03:05 +02001368 virtual void TearDown() { channel_.reset(); }
1369 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001370
1371 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001372 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1373 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001374
1375 bool sending = channel_->sending();
1376 bool success = SetSend(false);
1377 if (success) {
1378 cricket::VideoSendParameters parameters;
1379 parameters.codecs.push_back(codec);
1380 success = channel_->SetSendParameters(parameters);
1381 }
1382 if (success) {
1383 success = SetSend(sending);
1384 }
1385 return success;
1386 }
Yves Gerey665174f2018-06-19 15:03:05 +02001387 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001388 void SendFrame() {
1389 if (frame_forwarder_2_) {
1390 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 }
Niels Möller805a27e2019-01-21 12:21:27 +01001392 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001393 }
1394 bool WaitAndSendFrame(int wait_ms) {
1395 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001396 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 return ret;
1398 }
Yves Gerey665174f2018-06-19 15:03:05 +02001399 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001400 int NumRtpBytes(uint32_t ssrc) {
1401 return network_interface_.NumRtpBytes(ssrc);
1402 }
Yves Gerey665174f2018-06-19 15:03:05 +02001403 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001404 int NumRtpPackets(uint32_t ssrc) {
1405 return network_interface_.NumRtpPackets(ssrc);
1406 }
Yves Gerey665174f2018-06-19 15:03:05 +02001407 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1409 return network_interface_.GetRtpPacket(index);
1410 }
1411 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001412 webrtc::RTPHeader header;
1413 EXPECT_TRUE(ParseRtpPacket(p, &header));
1414 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001415 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001416
Niels Möller6557d0c2018-04-11 15:18:34 +02001417 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001418 webrtc::RTPHeader* header) {
1419 std::unique_ptr<webrtc::RtpHeaderParser> parser(
Tommi25eb47c2019-08-29 16:39:05 +02001420 webrtc::RtpHeaderParser::CreateForTest());
Åsa Persson23cd45a2018-07-03 10:40:40 +02001421 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001422 }
1423
1424 // Tests that we can send and receive frames.
1425 void SendAndReceive(const cricket::VideoCodec& codec) {
1426 EXPECT_TRUE(SetOneCodec(codec));
1427 EXPECT_TRUE(SetSend(true));
1428 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1429 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001430 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001431 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1432 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1433 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1434 }
1435
1436 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001437 int duration_sec,
1438 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001439 EXPECT_TRUE(SetOneCodec(codec));
1440 EXPECT_TRUE(SetSend(true));
1441 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1442 EXPECT_EQ(0, renderer_.num_rendered_frames());
1443 for (int i = 0; i < duration_sec; ++i) {
1444 for (int frame = 1; frame <= fps; ++frame) {
1445 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1446 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1447 }
1448 }
1449 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1450 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1451 }
1452
Niels Möller6557d0c2018-04-11 15:18:34 +02001453 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1454 cricket::VideoMediaInfo info;
1455 EXPECT_TRUE(channel_->GetStats(&info));
1456 return info.senders[i];
1457 }
1458
1459 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1460 cricket::VideoMediaInfo info;
1461 EXPECT_TRUE(channel_->GetStats(&info));
1462 return info.receivers[i];
1463 }
1464
1465 // Two streams one channel tests.
1466
1467 // Tests that we can send and receive frames.
1468 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1469 SetUpSecondStream();
1470 // Test sending and receiving on first stream.
1471 SendAndReceive(codec);
1472 // Test sending and receiving on second stream.
1473 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1474 EXPECT_GT(NumRtpPackets(), 0);
1475 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1476 }
1477
1478 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1479 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001480 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001481 return engine_codec;
1482 }
1483 // This point should never be reached.
1484 ADD_FAILURE() << "Unrecognized codec name: " << name;
1485 return cricket::VideoCodec();
1486 }
1487
1488 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1489
1490 cricket::StreamParams DefaultSendStreamParams() {
1491 return cricket::StreamParams::CreateLegacy(kSsrc);
1492 }
1493
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001494 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001495 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001496 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001497 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1498 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001499 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001500
1501 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1502 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1503 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1504
Niels Möller6557d0c2018-04-11 15:18:34 +02001505 std::unique_ptr<WebRtcVideoChannel> channel_;
1506 cricket::FakeNetworkInterface network_interface_;
1507 cricket::FakeVideoRenderer renderer_;
1508
1509 // Used by test cases where 2 streams are run on the same channel.
1510 cricket::FakeVideoRenderer renderer2_;
1511};
1512
1513// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001514TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001515 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001516 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001517 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1518 EXPECT_FALSE(channel_->sending());
1519 EXPECT_TRUE(SetSend(true));
1520 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001521 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001522 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1523 EXPECT_TRUE(SetSend(false));
1524 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001525}
Niels Möller6557d0c2018-04-11 15:18:34 +02001526
1527// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001528TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001529 EXPECT_FALSE(channel_->sending());
1530 EXPECT_FALSE(SetSend(true));
1531 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001532}
Niels Möller6557d0c2018-04-11 15:18:34 +02001533
1534// Test that we properly set the send and recv buffer sizes by the time
1535// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001536TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001537 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1538 EXPECT_TRUE(SetSend(true));
1539 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001540 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001541}
1542
Johannes Kron5a0665b2019-04-08 10:35:50 +02001543// Test that we properly set the send and recv buffer sizes when overriding
1544// via field trials.
1545TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1546 // Set field trial to override the default recv buffer size, and then re-run
1547 // setup where the interface is created and configured.
1548 const int kCustomRecvBufferSize = 123456;
1549 webrtc::test::ScopedFieldTrials field_trial(
1550 "WebRTC-IncreasedReceivebuffers/123456/");
1551 SetUp();
1552
1553 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1554 EXPECT_TRUE(SetSend(true));
1555 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1556 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1557}
1558
1559// Test that we properly set the send and recv buffer sizes when overriding
1560// via field trials with suffix.
1561TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1562 // Set field trial to override the default recv buffer size, and then re-run
1563 // setup where the interface is created and configured.
1564 const int kCustomRecvBufferSize = 123456;
1565 webrtc::test::ScopedFieldTrials field_trial(
1566 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1567 SetUp();
1568
1569 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1570 EXPECT_TRUE(SetSend(true));
1571 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1572 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1573}
1574
1575// Test that we properly set the send and recv buffer sizes when overriding
1576// via field trials that don't make any sense.
1577TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1578 // Set bogus field trial values to override the default recv buffer size, and
1579 // then re-run setup where the interface is created and configured. The
1580 // default value should still be used.
1581
1582 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1583 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1584 field_trial_string += group;
1585 field_trial_string += "/";
1586 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1587 SetUp();
1588
1589 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1590 EXPECT_TRUE(SetSend(true));
1591 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1592 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1593 }
1594}
1595
Niels Möller6557d0c2018-04-11 15:18:34 +02001596// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001597TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001598 webrtc::test::ScopedFieldTrials field_trials(
1599 "WebRTC-UseStandardBytesStats/Enabled/");
1600 SetUp();
1601
Niels Möller6557d0c2018-04-11 15:18:34 +02001602 const int kDurationSec = 3;
1603 const int kFps = 10;
1604 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1605
1606 cricket::VideoMediaInfo info;
1607 EXPECT_TRUE(channel_->GetStats(&info));
1608
1609 ASSERT_EQ(1U, info.senders.size());
1610 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1611 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001612 EXPECT_EQ(info.senders[0].bytes_sent,
1613 NumRtpBytes() - kRtpHeaderSize * NumRtpPackets());
Niels Möller6557d0c2018-04-11 15:18:34 +02001614 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1615 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1616 ASSERT_TRUE(info.senders[0].codec_payload_type);
1617 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1618 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1619 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1620 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1621 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1622 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1623 EXPECT_GT(info.senders[0].framerate_input, 0);
1624 EXPECT_GT(info.senders[0].framerate_sent, 0);
1625
1626 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1627 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1628 info.send_codecs[DefaultCodec().id]);
1629
1630 ASSERT_EQ(1U, info.receivers.size());
1631 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1632 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1633 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1634 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1635 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001636 EXPECT_EQ(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1637 info.receivers[0].bytes_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001638 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001639 EXPECT_EQ(0, info.receivers[0].packets_lost);
1640 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1641 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1642 EXPECT_EQ(0, info.receivers[0].firs_sent);
1643 EXPECT_EQ(0, info.receivers[0].plis_sent);
1644 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1645 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1646 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1647 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1648 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1649 EXPECT_GT(info.receivers[0].framerate_output, 0);
1650
1651 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1652 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1653 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001654}
Niels Möller6557d0c2018-04-11 15:18:34 +02001655
1656// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001657TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001658 webrtc::test::ScopedFieldTrials field_trials(
1659 "WebRTC-UseStandardBytesStats/Enabled/");
1660 SetUp();
1661
Niels Möller6557d0c2018-04-11 15:18:34 +02001662 cricket::FakeVideoRenderer renderer1, renderer2;
1663 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1664 cricket::VideoSendParameters parameters;
1665 parameters.codecs.push_back(DefaultCodec());
1666 parameters.conference_mode = true;
1667 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1668 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001669 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1670 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001671 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1672 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1673 EXPECT_EQ(0, renderer1.num_rendered_frames());
1674 EXPECT_EQ(0, renderer2.num_rendered_frames());
1675 std::vector<uint32_t> ssrcs;
1676 ssrcs.push_back(1);
1677 ssrcs.push_back(2);
1678 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001679 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001680 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1681 kTimeout);
1682 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1683 kTimeout);
1684
1685 EXPECT_TRUE(channel_->SetSend(false));
1686
1687 cricket::VideoMediaInfo info;
1688 EXPECT_TRUE(channel_->GetStats(&info));
1689 ASSERT_EQ(1U, info.senders.size());
1690 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1691 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001692 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1693 GetSenderStats(0).bytes_sent, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001694 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1695 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1696 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1697
1698 ASSERT_EQ(2U, info.receivers.size());
1699 for (size_t i = 0; i < info.receivers.size(); ++i) {
1700 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1701 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001702 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
1703 GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001704 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001705 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1706 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1707 }
srtee0c2eea2017-12-15 17:44:33 +01001708}
Niels Möller6557d0c2018-04-11 15:18:34 +02001709
1710// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001711TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001712 // Normal setup; note that we set the SSRC explicitly to ensure that
1713 // it will come first in the senders map.
1714 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1715 cricket::VideoSendParameters parameters;
1716 parameters.codecs.push_back(DefaultCodec());
1717 parameters.conference_mode = true;
1718 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001719 EXPECT_TRUE(
1720 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001721 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1722 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001723 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001724 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1725 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1726
1727 // Add an additional capturer, and hook up a renderer to receive it.
1728 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001729 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001730 const int kTestWidth = 160;
1731 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001732 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1733 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001734 EXPECT_TRUE(
1735 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001736 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001737 EXPECT_TRUE(
1738 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001739 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001740 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001741 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1742 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001743
1744 // Get stats, and make sure they are correct for two senders. We wait until
1745 // the number of expected packets have been sent to avoid races where we
1746 // check stats before it has been updated.
1747 cricket::VideoMediaInfo info;
1748 for (uint32_t i = 0; i < kTimeout; ++i) {
1749 rtc::Thread::Current()->ProcessMessages(1);
1750 EXPECT_TRUE(channel_->GetStats(&info));
1751 ASSERT_EQ(2U, info.senders.size());
1752 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1753 NumRtpPackets()) {
1754 // Stats have been updated for both sent frames, expectations can be
1755 // checked now.
1756 break;
1757 }
1758 }
1759 EXPECT_EQ(NumRtpPackets(),
1760 info.senders[0].packets_sent + info.senders[1].packets_sent)
1761 << "Timed out while waiting for packet counts for all sent packets.";
1762 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1763 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1764 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1765 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1766 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1767 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1768 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1769 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1770 // The capturer must be unregistered here as it runs out of it's scope next.
1771 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001772}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001773
Niels Möller6557d0c2018-04-11 15:18:34 +02001774// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001775TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001776 cricket::VideoSendParameters parameters;
1777 parameters.codecs.push_back(DefaultCodec());
1778 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1779 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1780 parameters.max_bandwidth_bps = 128 * 1024;
1781 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001782}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001783
Niels Möller6557d0c2018-04-11 15:18:34 +02001784// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001785TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001786 EXPECT_TRUE(SetDefaultCodec());
1787 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001788 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001789 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001790 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001791 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001792 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1793 EXPECT_EQ(kSsrc, header.ssrc);
1794
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 // Packets are being paced out, so these can mismatch between the first and
1796 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001797 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1798 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001799 EXPECT_EQ(1, NumSentSsrcs());
1800 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1801 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001802}
Niels Möller6557d0c2018-04-11 15:18:34 +02001803
1804// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001805TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001806 // Remove stream added in Setup.
1807 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1808 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001809 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001810 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001811 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001812 EXPECT_TRUE(SetSend(true));
1813 EXPECT_TRUE(WaitAndSendFrame(0));
1814 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001815 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001816 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001817 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1818 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001819 // Packets are being paced out, so these can mismatch between the first and
1820 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1822 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001823 EXPECT_EQ(1, NumSentSsrcs());
1824 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1825 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001826}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001827
Niels Möller6557d0c2018-04-11 15:18:34 +02001828// Test that we can set the default video renderer before and after
1829// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001830TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001831 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1832 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001833
1834 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1835 rtc::SetBE32(packet1.data() + 8, kSsrc);
1836 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1837 EXPECT_TRUE(SetDefaultCodec());
1838 EXPECT_TRUE(SetSend(true));
1839 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001840 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001841 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001842 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001843 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001844}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001845
Niels Möller6557d0c2018-04-11 15:18:34 +02001846// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001847TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001848 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1849 EXPECT_TRUE(SetSend(true));
1850 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001851 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001852 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1853 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001854 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001855 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001856 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1857 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001858 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1859 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001860
1861 // Remove the send stream that was added during Setup.
1862 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1863 int rtp_packets = NumRtpPackets();
1864
Niels Möller6557d0c2018-04-11 15:18:34 +02001865 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001866 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001867 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001868 EXPECT_EQ(rtp_packets, NumRtpPackets());
1869 // Wait 30ms to guarantee the engine does not drop the frame.
1870 EXPECT_TRUE(WaitAndSendFrame(30));
1871 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1872
1873 last_packet = NumRtpPackets() - 1;
1874 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001875 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1876 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001877}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001878
Niels Möller6557d0c2018-04-11 15:18:34 +02001879// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001880TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001881 cricket::FakeVideoRenderer renderer1, renderer2;
1882 EXPECT_TRUE(SetDefaultCodec());
1883 cricket::VideoSendParameters parameters;
1884 parameters.codecs.push_back(DefaultCodec());
1885 parameters.conference_mode = true;
1886 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1887 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001888 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1889 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001890 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1891 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1892 EXPECT_EQ(0, renderer1.num_rendered_frames());
1893 EXPECT_EQ(0, renderer2.num_rendered_frames());
1894 std::vector<uint32_t> ssrcs;
1895 ssrcs.push_back(1);
1896 ssrcs.push_back(2);
1897 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001898 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001899 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1900 kTimeout);
1901 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1902 kTimeout);
1903
1904 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1905 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1906 EXPECT_EQ(kVideoWidth, renderer1.width());
1907 EXPECT_EQ(kVideoHeight, renderer1.height());
1908 EXPECT_EQ(kVideoWidth, renderer2.width());
1909 EXPECT_EQ(kVideoHeight, renderer2.height());
1910 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1911 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001912}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001913
Niels Möller6557d0c2018-04-11 15:18:34 +02001914// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001915TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001916 using cricket::FOURCC_I420;
Jonas Olssona4d87372019-07-05 19:08:33 +02001917 using cricket::VideoCodec;
1918 using cricket::VideoFormat;
1919 using cricket::VideoOptions;
Niels Möller6557d0c2018-04-11 15:18:34 +02001920
1921 VideoCodec codec = DefaultCodec();
1922 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1923 EXPECT_TRUE(SetOneCodec(codec));
1924 EXPECT_TRUE(SetSend(true));
1925 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1926 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001927 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001928 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001929
1930 webrtc::test::FrameForwarder frame_forwarder;
1931 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1932 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001933
1934 // TODO(nisse): This testcase fails if we don't configure
1935 // screencast. It's unclear why, I see nothing obvious in this
1936 // test which is related to screencast logic.
1937 VideoOptions video_options;
1938 video_options.is_screencast = true;
1939 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1940
Niels Möller6557d0c2018-04-11 15:18:34 +02001941 int captured_frames = 1;
1942 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001943 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001944 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001945 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1946
Niels Möller6557d0c2018-04-11 15:18:34 +02001947 ++captured_frames;
1948 // Wait until frame of right size is captured.
1949 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001950 480 == renderer_.width() &&
1951 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001952 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001953 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001954 EXPECT_EQ(480, renderer_.width());
1955 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001956 captured_frames = renderer_.num_rendered_frames() + 1;
1957 EXPECT_FALSE(renderer_.black_frame());
1958 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1959 // Make sure a black frame is generated within the specified timeout.
1960 // The black frame should be the resolution of the previous frame to
1961 // prevent expensive encoder reconfigurations.
1962 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001963 480 == renderer_.width() &&
1964 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001965 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001966 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001967 EXPECT_EQ(480, renderer_.width());
1968 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001969 EXPECT_TRUE(renderer_.black_frame());
1970
1971 // The black frame has the same timestamp as the next frame since it's
1972 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1973 // not render a frame with the same timestamp so capture another frame
1974 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001975 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001976 }
srtee0c2eea2017-12-15 17:44:33 +01001977}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001978
Niels Möller6557d0c2018-04-11 15:18:34 +02001979// Tests that if SetVideoSend is called with a NULL capturer after the
1980// capturer was already removed, the application doesn't crash (and no black
1981// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001982TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001983 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1984 EXPECT_TRUE(SetSend(true));
1985 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1986 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001987 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001988 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1989 // Wait for one frame so they don't get dropped because we send frames too
1990 // tightly.
1991 rtc::Thread::Current()->ProcessMessages(30);
1992 // Remove the capturer.
1993 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1994
1995 // No capturer was added, so this SetVideoSend shouldn't do anything.
1996 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1997 rtc::Thread::Current()->ProcessMessages(300);
1998 // Verify no more frames were sent.
1999 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01002000}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002001
Niels Möller6557d0c2018-04-11 15:18:34 +02002002// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01002003TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002004 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2005 // interval time to avoid that.
2006 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2007 // interval time to avoid that.
2008 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02002009 EXPECT_TRUE(
2010 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002011 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
2012 cricket::VideoFormat capture_format(
2013 kVideoWidth, kVideoHeight,
2014 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2015 // Set up additional stream 1.
2016 cricket::FakeVideoRenderer renderer1;
2017 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002018 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002019 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002020 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002021
2022 webrtc::test::FrameForwarder frame_forwarder1;
2023 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2024 rtc::kNumMicrosecsPerSec / kFramerate);
2025
Niels Möller6557d0c2018-04-11 15:18:34 +02002026 // Set up additional stream 2.
2027 cricket::FakeVideoRenderer renderer2;
2028 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002029 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002030 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002031 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002032 webrtc::test::FrameForwarder frame_forwarder2;
2033
Niels Möller6557d0c2018-04-11 15:18:34 +02002034 // State for all the streams.
2035 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2036 // A limitation in the lmi implementation requires that SetVideoSend() is
2037 // called after SetOneCodec().
2038 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002039 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2040 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002041 EXPECT_TRUE(SetSend(true));
2042 // Test capturer associated with engine.
2043 const int kTestWidth = 160;
2044 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002045 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2046 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2047 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002048 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2049 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002050 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002051 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2052 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2053 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002054 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2055 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002056 // Successfully remove the capturer.
2057 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2058 // The capturers must be unregistered here as it runs out of it's scope
2059 // next.
2060 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2061 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002062}
Niels Möller6557d0c2018-04-11 15:18:34 +02002063
2064// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002065TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002066 // Remove the send stream that was added during Setup.
2067 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2068
2069 cricket::StreamParams empty;
2070 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002071 EXPECT_TRUE(
2072 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002073}
Niels Möller6557d0c2018-04-11 15:18:34 +02002074
2075// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002076TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002077 // Remove stream added in Setup. I.e. remove stream corresponding to default
2078 // channel.
2079 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002080 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002081 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2082 EXPECT_TRUE(channel_->AddSendStream(
2083 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2084 }
2085 // Delete one of the non default channel streams, let the destructor delete
2086 // the remaining ones.
2087 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2088 // Stream should already be deleted.
2089 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002090}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002091
eladalonf1841382017-06-12 01:16:46 -07002092TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002093 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002094}
2095
eladalonf1841382017-06-12 01:16:46 -07002096TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002097 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002098}
2099
eladalonf1841382017-06-12 01:16:46 -07002100TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002101 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002102}
2103
eladalonf1841382017-06-12 01:16:46 -07002104TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002105 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2106 // bitrates. This currently happens at <250k, and two streams sharing 300k
2107 // initially will use QVGA instead of VGA.
2108 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2109 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002110 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002111 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002112 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002113}
2114
philipele8ed8302019-07-03 11:53:48 +02002115TEST_F(WebRtcVideoChannelBaseTest, OnEncoderFailure) {
2116 cricket::VideoSendParameters parameters;
2117 parameters.codecs.push_back(GetEngineCodec("VP9"));
2118 parameters.codecs.push_back(GetEngineCodec("VP8"));
2119 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2120
2121 VideoCodec codec;
2122 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2123 EXPECT_EQ("VP9", codec.name);
2124
2125 // OnEncoderFailure will post a task to the worker thread (which is also
2126 // the current thread), hence the ProcessMessages call.
2127 channel_->OnEncoderFailure();
2128 rtc::Thread::Current()->ProcessMessages(30);
2129 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2130 EXPECT_EQ("VP8", codec.name);
2131
2132 // No other codec to fall back to, keep using VP8.
2133 channel_->OnEncoderFailure();
2134 rtc::Thread::Current()->ProcessMessages(30);
2135 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2136 EXPECT_EQ("VP8", codec.name);
2137}
2138
eladalonf1841382017-06-12 01:16:46 -07002139class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002140 public:
eladalonf1841382017-06-12 01:16:46 -07002141 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2142 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002143 : WebRtcVideoEngineTest(field_trials),
2144 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2145 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002146 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002147 encoder_factory_->AddSupportedVideoCodecType("VP8");
2148 encoder_factory_->AddSupportedVideoCodecType("VP9");
2149#if defined(WEBRTC_USE_H264)
2150 encoder_factory_->AddSupportedVideoCodecType("H264");
2151#endif
2152
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002153 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002154 channel_.reset(engine_.CreateMediaChannel(
2155 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2156 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002157 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002158 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002159 send_parameters_.codecs = engine_.codecs();
2160 recv_parameters_.codecs = engine_.codecs();
2161 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002162 }
2163
2164 protected:
2165 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002166 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002167 }
2168
2169 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002170 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002171 EXPECT_TRUE(channel_->AddSendStream(sp));
2172 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002173 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002174 EXPECT_EQ(num_streams + 1, streams.size());
2175 return streams[streams.size() - 1];
2176 }
2177
2178 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002179 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002180 }
2181
2182 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002183 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002184 }
2185
2186 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002187 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002188 EXPECT_TRUE(channel_->AddRecvStream(sp));
2189 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002190 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002191 EXPECT_EQ(num_streams + 1, streams.size());
2192 return streams[streams.size() - 1];
2193 }
2194
pbos@webrtc.org00873182014-11-25 14:03:34 +00002195 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2196 int expected_min_bitrate_bps,
2197 const char* start_bitrate_kbps,
2198 int expected_start_bitrate_bps,
2199 const char* max_bitrate_kbps,
2200 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002201 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2202 expected_start_bitrate_bps,
2203 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002204 auto& codecs = send_parameters_.codecs;
2205 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002206 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002207 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2208 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2209 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002210 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002211 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002212
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002213 void ExpectSetBitrateParameters(int min_bitrate_bps,
2214 int start_bitrate_bps,
2215 int max_bitrate_bps) {
2216 EXPECT_CALL(
2217 *fake_call_->GetMockTransportControllerSend(),
2218 SetSdpBitrateParameters(AllOf(
2219 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2220 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2221 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2222 }
2223
2224 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2225 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2226 SetSdpBitrateParameters(Field(
2227 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002228 }
2229
Johannes Kron9190b822018-10-29 11:22:05 +01002230 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2231 // For a caller, the answer will be applied in set remote description
2232 // where SetSendParameters() is called.
2233 EXPECT_TRUE(
2234 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2235 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2236 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2237 const webrtc::VideoSendStream::Config& config =
2238 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2239 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2240 }
2241
2242 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2243 // For a callee, the answer will be applied in set local description
2244 // where SetExtmapAllowMixed() and AddSendStream() are called.
2245 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2246 EXPECT_TRUE(
2247 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2248 const webrtc::VideoSendStream::Config& config =
2249 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2250 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2251 }
2252
isheriff6f8d6862016-05-26 11:24:55 -07002253 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002254 // Enable extension.
2255 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002256 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002257 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002258 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002259 FakeVideoSendStream* send_stream =
2260 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2261
2262 // Verify the send extension id.
2263 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2264 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002265 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002266 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002267 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002268 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2269 // receivers.
2270 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2271 ->GetConfig()
2272 .rtp.extensions.empty());
2273
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002274 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002275 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002276 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2277 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002278 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2279
2280 // Verify that adding receive RTP header extensions adds them for existing
2281 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002282 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002283 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002284 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2285 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002286 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002287 }
2288
isheriff6f8d6862016-05-26 11:24:55 -07002289 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002290 // Enable extension.
2291 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002292 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002293 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002294 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002295
2296 FakeVideoReceiveStream* recv_stream =
2297 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2298
2299 // Verify the recv extension id.
2300 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2301 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002302 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002303 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002304 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002305
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002306 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2307 // senders.
2308 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2309 ->GetConfig()
2310 .rtp.extensions.empty());
2311
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002312 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002313 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002314 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2315 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002316 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2317
2318 // Verify that adding receive RTP header extensions adds them for existing
2319 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002320 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002321 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002322 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2323 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002324 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002325 }
2326
Elad Alonfadb1812019-05-24 13:40:02 +02002327 void TestLossNotificationState(bool expect_lntf_enabled) {
2328 AssignDefaultCodec();
2329 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2330
2331 cricket::VideoSendParameters parameters;
2332 parameters.codecs = engine_.codecs();
2333 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2334 EXPECT_TRUE(channel_->SetSend(true));
2335
2336 // Send side.
2337 FakeVideoSendStream* send_stream =
2338 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2339 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2340
2341 // Receiver side.
2342 FakeVideoReceiveStream* recv_stream =
2343 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2344 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2345 }
2346
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002347 void TestExtensionFilter(const std::vector<std::string>& extensions,
2348 const std::string& expected_extension) {
2349 cricket::VideoSendParameters parameters = send_parameters_;
2350 int expected_id = -1;
2351 int id = 1;
2352 for (const std::string& extension : extensions) {
2353 if (extension == expected_extension)
2354 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002355 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002356 }
2357 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2358 FakeVideoSendStream* send_stream =
2359 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2360
2361 // Verify that only one of them has been set, and that it is the one with
2362 // highest priority (transport sequence number).
2363 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2364 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2365 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002366 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002367 }
2368
asapersson3c81a1a2017-06-14 05:52:21 -07002369 void TestDegradationPreference(bool resolution_scaling_enabled,
2370 bool fps_scaling_enabled);
2371
Erik Språngefbde372015-04-29 16:21:28 +02002372 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002373 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002374 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2375 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002376
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002377 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002378 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002379 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002380 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002381 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002382 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002383 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002384 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002385 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002386
Erik Språng143cec12015-04-28 10:01:41 +02002387 return fake_call_->GetVideoSendStreams().back();
2388 }
2389
Peter Boström2feafdb2015-09-09 14:32:14 +02002390 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2391 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002392 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002393 std::vector<uint32_t> ssrcs;
2394 std::vector<uint32_t> rtx_ssrcs;
2395 uint32_t num_streams = enabled ? 3 : 1;
2396 for (uint32_t i = 0; i < num_streams; ++i) {
2397 uint32_t ssrc = last_ssrc_ + i;
2398 ssrcs.push_back(ssrc);
2399 if (with_rtx) {
2400 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2401 }
Erik Språng143cec12015-04-28 10:01:41 +02002402 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002403 if (with_rtx) {
2404 return AddSendStream(
2405 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2406 }
2407 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002408 }
2409
perkjfa10b552016-10-02 23:45:26 -07002410 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002411 std::vector<FakeVideoSendStream*> streams =
2412 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002413 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002414 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002415 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002416 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002417 }
2418
perkjfa10b552016-10-02 23:45:26 -07002419 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002420 int stream_max,
2421 int expected_encoder_bitrate) {
2422 VideoSendParameters limited_send_params = send_parameters_;
2423 limited_send_params.max_bandwidth_bps = global_max;
2424 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002425 webrtc::RtpParameters parameters =
2426 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002427 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002428 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002429 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002430 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002431 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002432 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002433 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002434 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002435 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002436 }
2437
Åsa Persson55659812018-06-18 17:51:32 +02002438 // Values from kSimulcastConfigs in simulcast.cc.
2439 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2440 std::vector<webrtc::VideoStream> layers(3);
2441 layers[0].min_bitrate_bps = 30000;
2442 layers[0].target_bitrate_bps = 150000;
2443 layers[0].max_bitrate_bps = 200000;
2444 layers[1].min_bitrate_bps = 150000;
2445 layers[1].target_bitrate_bps = 500000;
2446 layers[1].max_bitrate_bps = 700000;
2447 layers[2].min_bitrate_bps = 600000;
2448 layers[2].target_bitrate_bps = 2500000;
2449 layers[2].max_bitrate_bps = 2500000;
2450 return layers;
2451 }
2452
Niels Möller805a27e2019-01-21 12:21:27 +01002453 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002454 std::unique_ptr<FakeCall> fake_call_;
2455 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002456 cricket::VideoSendParameters send_parameters_;
2457 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002458 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002459};
2460
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002462 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002463 const std::string kSyncLabel = "AvSyncLabel";
2464
2465 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002466 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002467 EXPECT_TRUE(channel_->AddRecvStream(sp));
2468
Mirko Bonadeif859e552018-05-30 15:31:29 +02002469 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002470 EXPECT_EQ(kSyncLabel,
2471 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2472 << "SyncGroup should be set based on sync_label";
2473}
2474
eladalonf1841382017-06-12 01:16:46 -07002475TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002476 cricket::VideoSendParameters parameters;
2477 parameters.codecs = engine_.codecs();
2478 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002479 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002480 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002481 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002482
2483 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002484 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2485 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002486 FakeVideoSendStream* send_stream = AddSendStream(
2487 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2488
2489 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2490 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2491 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2492
2493 // Receiver side.
2494 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2495 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002496 EXPECT_FALSE(
2497 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002498 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002499 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002500 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002501 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002502 << "RTX should be mapped for the RED payload type";
2503
brandtr14742122017-01-27 04:53:07 -08002504 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002505}
2506
eladalonf1841382017-06-12 01:16:46 -07002507TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002508 // Setup one channel with an associated RTX stream.
2509 cricket::StreamParams params =
2510 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2511 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2512 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002513 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002514
2515 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2516 << "RTX should be mapped for all decoders/payload types.";
2517 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002518 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002519 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002520}
2521
eladalonf1841382017-06-12 01:16:46 -07002522TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002523 // Setup one channel without an associated RTX stream.
2524 cricket::StreamParams params =
2525 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2526 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002527 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002528}
2529
Johannes Kron9190b822018-10-29 11:22:05 +01002530// Test propagation of extmap allow mixed setting.
2531TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2532 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2533}
2534TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2535 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2536}
2537TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2538 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2539}
2540TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2541 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2542}
2543
eladalonf1841382017-06-12 01:16:46 -07002544TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002545 FakeVideoSendStream* send_stream =
2546 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2547 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2548
2549 FakeVideoReceiveStream* recv_stream =
2550 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2551 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002552}
2553
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002554// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002555TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002556 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002557}
isheriff6f8d6862016-05-26 11:24:55 -07002558
eladalonf1841382017-06-12 01:16:46 -07002559TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002560 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002561}
2562
2563// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002564TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002565 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002566}
isheriff6f8d6862016-05-26 11:24:55 -07002567
eladalonf1841382017-06-12 01:16:46 -07002568TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002569 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002570}
2571
eladalonf1841382017-06-12 01:16:46 -07002572TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002573 // Enable three redundant extensions.
2574 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002575 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2576 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2577 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2578 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002579}
2580
eladalonf1841382017-06-12 01:16:46 -07002581TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002582 // Enable two redundant extensions.
2583 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002584 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2585 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2586 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002587}
2588
stefanc1aeaf02015-10-15 07:26:07 -07002589// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002590TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002591 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002592}
eladalonf1841382017-06-12 01:16:46 -07002593TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002594 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002595}
2596
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002597// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002598TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002599 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002600}
eladalonf1841382017-06-12 01:16:46 -07002601TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002602 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002603}
2604
eladalonf1841382017-06-12 01:16:46 -07002605TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002606 const int kAbsSendTimeId = 1;
2607 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002608 send_parameters_.extensions.push_back(
2609 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2610 send_parameters_.extensions.push_back(
2611 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002612
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002613 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002614 FakeVideoSendStream* send_stream =
2615 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2616
2617 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002618 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002619
2620 // Setting the same extensions (even if in different order) shouldn't
2621 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002622 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002623 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002624
2625 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2626
2627 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002628 send_parameters_.extensions.resize(1);
2629 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002630
2631 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2632}
2633
eladalonf1841382017-06-12 01:16:46 -07002634TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002635 const int kTOffsetId = 1;
2636 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002637 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002638 recv_parameters_.extensions.push_back(
2639 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2640 recv_parameters_.extensions.push_back(
2641 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2642 recv_parameters_.extensions.push_back(
2643 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002644
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002645 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002646 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002647 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2648
2649 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002650 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002651
2652 // Setting the same extensions (even if in different order) shouldn't
2653 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002654 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002655 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002656
2657 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2658
2659 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002660 recv_parameters_.extensions.resize(1);
2661 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002662
2663 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2664}
2665
eladalonf1841382017-06-12 01:16:46 -07002666TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002667 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002668 const int kUnsupportedId = 1;
2669 const int kTOffsetId = 2;
2670
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002671 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002672 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002673 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002674 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002675 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002676 FakeVideoSendStream* send_stream =
2677 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2678
2679 // Only timestamp offset extension is set to send stream,
2680 // unsupported rtp extension is ignored.
2681 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002682 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2683 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002684}
2685
eladalonf1841382017-06-12 01:16:46 -07002686TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002687 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002688 const int kUnsupportedId = 1;
2689 const int kTOffsetId = 2;
2690
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002691 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002692 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002693 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002694 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002695 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002696 FakeVideoReceiveStream* recv_stream =
2697 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2698
2699 // Only timestamp offset extension is set to receive stream,
2700 // unsupported rtp extension is ignored.
2701 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002702 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2703 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002704}
2705
eladalonf1841382017-06-12 01:16:46 -07002706TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002707 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002708 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002709 send_parameters_.extensions.push_back(
2710 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002711 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002712 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2713 }
2714}
2715
eladalonf1841382017-06-12 01:16:46 -07002716TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002717 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002718 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002719 recv_parameters_.extensions.push_back(
2720 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002721 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002722 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2723 }
2724}
2725
eladalonf1841382017-06-12 01:16:46 -07002726TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002727 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002728 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002729 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002730 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002731 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002732 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002733
2734 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002735 send_parameters_.extensions.clear();
2736 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002737 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002738 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2739 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002740}
2741
eladalonf1841382017-06-12 01:16:46 -07002742TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002743 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002744 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002745 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002746 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002747 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002748 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002749
2750 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002751 recv_parameters_.extensions.clear();
2752 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002753 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002754 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2755 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002756}
2757
eladalonf1841382017-06-12 01:16:46 -07002758TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002759 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002760 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002761}
2762
eladalonf1841382017-06-12 01:16:46 -07002763TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002764 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002765 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002766}
2767
eladalonf1841382017-06-12 01:16:46 -07002768TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002769 FakeVideoReceiveStream* stream = AddRecvStream();
2770 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2771}
2772
eladalonf1841382017-06-12 01:16:46 -07002773TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002774 FakeVideoReceiveStream* stream = AddRecvStream();
2775 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2776
2777 // Verify that transport cc feedback is turned off when send(!) codecs without
2778 // transport cc feedback are set.
2779 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002780 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002781 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2782 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2783 stream = fake_call_->GetVideoReceiveStreams()[0];
2784 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2785
2786 // Verify that transport cc feedback is turned on when setting default codecs
2787 // since the default codecs have transport cc feedback enabled.
2788 parameters.codecs = engine_.codecs();
2789 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2790 stream = fake_call_->GetVideoReceiveStreams()[0];
2791 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2792}
2793
Elad Alonfadb1812019-05-24 13:40:02 +02002794TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2795 TestLossNotificationState(false);
2796}
2797
2798TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2799 RTC_DCHECK(!override_field_trials_);
2800 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2801 "WebRTC-RtcpLossNotification/Enabled/");
2802 SetUp();
2803 TestLossNotificationState(true);
2804}
2805
2806TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2807 RTC_DCHECK(!override_field_trials_);
2808 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2809 "WebRTC-RtcpLossNotification/Enabled/");
2810 SetUp();
2811
2812 AssignDefaultCodec();
2813 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2814
2815 {
2816 cricket::VideoSendParameters parameters;
2817 parameters.codecs = engine_.codecs();
2818 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2819 EXPECT_TRUE(channel_->SetSend(true));
2820 }
2821
2822 // Start with LNTF enabled.
2823 FakeVideoSendStream* send_stream =
2824 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2825 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2826 FakeVideoReceiveStream* recv_stream =
2827 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2828 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2829
2830 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2831 cricket::VideoSendParameters parameters;
2832 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2833 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2834 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2835 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2836 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2837 send_stream = fake_call_->GetVideoSendStreams()[0];
2838 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2839
2840 // Setting the default codecs again, including VP8, turns LNTF back on.
2841 parameters.codecs = engine_.codecs();
2842 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2843 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2844 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2845 send_stream = fake_call_->GetVideoSendStreams()[0];
2846 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2847}
2848
eladalonf1841382017-06-12 01:16:46 -07002849TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002850 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002851 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002852
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002853 cricket::VideoSendParameters parameters;
2854 parameters.codecs = engine_.codecs();
2855 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002856 EXPECT_TRUE(channel_->SetSend(true));
2857
2858 // Send side.
2859 FakeVideoSendStream* send_stream =
2860 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2861 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2862
2863 // Receiver side.
2864 FakeVideoReceiveStream* recv_stream =
2865 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2866 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2867
2868 // Nack history size should match between sender and receiver.
2869 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2870 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002871}
2872
eladalonf1841382017-06-12 01:16:46 -07002873TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002874 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002875 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002876
2877 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2878 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2879
2880 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002881 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002882 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002883 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2884 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002885 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2886 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2887 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002888 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2889
Peter Boström67c9df72015-05-11 14:34:58 +02002890 // Verify that NACK is turned on when setting default codecs since the
2891 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002892 parameters.codecs = engine_.codecs();
2893 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002894 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2895 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2896 send_stream = fake_call_->GetVideoSendStreams()[0];
2897 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002898}
2899
Peter Boströme7ba0862016-03-12 00:02:28 +01002900// This test verifies that new frame sizes reconfigures encoders even though not
2901// (yet) sending. The purpose of this is to permit encoding as quickly as
2902// possible once we start sending. Likely the frames being input are from the
2903// same source that will be sent later, which just means that we're ready
2904// earlier.
eladalonf1841382017-06-12 01:16:46 -07002905TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002906 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002907 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002908 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2909 channel_->SetSend(false);
2910
2911 FakeVideoSendStream* stream = AddSendStream();
2912
perkjfa10b552016-10-02 23:45:26 -07002913 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002914 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002915 EXPECT_EQ(0u, streams[0].width);
2916 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002917
Niels Möller805a27e2019-01-21 12:21:27 +01002918 webrtc::test::FrameForwarder frame_forwarder;
2919 cricket::FakeFrameSource frame_source(1280, 720,
2920 rtc::kNumMicrosecsPerSec / 30);
2921
2922 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2923 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002924
2925 // Frame entered, should be reconfigured to new dimensions.
2926 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002927 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2928 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002929
Niels Möllerff40b142018-04-09 08:49:14 +02002930 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002931}
2932
eladalonf1841382017-06-12 01:16:46 -07002933TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002934 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002935 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002936 cricket::VideoSendParameters parameters;
2937 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002938 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002939 AddSendStream();
2940
Niels Möller805a27e2019-01-21 12:21:27 +01002941 webrtc::test::FrameForwarder frame_forwarder;
2942 cricket::FakeFrameSource frame_source(1280, 720,
2943 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002944 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002945 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002946 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2947 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002948
2949 EXPECT_TRUE(channel_->SetSend(true));
2950
Niels Möller805a27e2019-01-21 12:21:27 +01002951 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002952 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2953 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2954
2955 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2956
2957 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002958 webrtc::VideoEncoderConfig encoder_config =
2959 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002960 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002961 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002962 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002963 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2964 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002965 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2966 << "Non-screenshare shouldn't use min-transmit bitrate.";
2967
Niels Möllerff40b142018-04-09 08:49:14 +02002968 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002969 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002970 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002971 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002972 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2973 &frame_forwarder));
2974 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002975 // Send stream recreated after option change.
2976 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2977 send_stream = fake_call_->GetVideoSendStreams().front();
2978 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002979
2980 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002981 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002982 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002983 encoder_config.content_type);
2984 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2985 encoder_config.min_transmit_bitrate_bps);
2986
perkjfa10b552016-10-02 23:45:26 -07002987 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002988 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2989 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01002990 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02002991 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002992}
2993
eladalonf1841382017-06-12 01:16:46 -07002994TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002995 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02002996 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08002997 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002998 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00002999
3000 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003001 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003002 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003003 webrtc::test::FrameForwarder frame_forwarder;
3004 cricket::FakeFrameSource frame_source(1280, 720,
3005 rtc::kNumMicrosecsPerSec / 30);
3006 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003007 EXPECT_TRUE(channel_->SetSend(true));
3008
Niels Möller805a27e2019-01-21 12:21:27 +01003009 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003010 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3011 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3012
perkj26091b12016-09-01 01:17:40 -07003013 webrtc::VideoEncoderConfig encoder_config =
3014 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003015
3016 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003017 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003018 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003019 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003020
3021 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3022 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003023 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003024 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003025 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003026
Niels Möllerff40b142018-04-09 08:49:14 +02003027 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003028}
3029
eladalonf1841382017-06-12 01:16:46 -07003030TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003031 FakeVideoSendStream* stream = AddSendStream();
3032 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3033}
3034
eladalonf1841382017-06-12 01:16:46 -07003035TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003036 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003037 media_config.video.suspend_below_min_bitrate = true;
3038
Sebastian Jansson84848f22018-11-16 10:40:36 +01003039 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003040 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3041 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003042 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003043
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003044 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003045
3046 FakeVideoSendStream* stream = AddSendStream();
3047 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3048
nisse0db023a2016-03-01 04:29:59 -08003049 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003050 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003051 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3052 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003053 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003054
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003055 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003056
nisse0db023a2016-03-01 04:29:59 -08003057 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003058 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3059}
3060
eladalonf1841382017-06-12 01:16:46 -07003061TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003062 FakeVideoSendStream* stream = AddSendStream();
3063 webrtc::VideoCodecVP8 vp8_settings;
3064 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3065 EXPECT_TRUE(vp8_settings.denoisingOn);
3066}
3067
eladalonf1841382017-06-12 01:16:46 -07003068TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003069 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003070 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003071 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003072
Peter Boström2feafdb2015-09-09 14:32:14 +02003073 // Single-stream settings should apply with RTX as well (verifies that we
3074 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3075 // both RTX and regular SSRCs).
3076 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003077
Niels Möller805a27e2019-01-21 12:21:27 +01003078 webrtc::test::FrameForwarder frame_forwarder;
3079 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003080 channel_->SetSend(true);
3081
Niels Möller805a27e2019-01-21 12:21:27 +01003082 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003083
pbos4cba4eb2015-10-26 11:18:18 -07003084 webrtc::VideoCodecVP8 vp8_settings;
3085 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3086 EXPECT_TRUE(vp8_settings.denoisingOn)
3087 << "VP8 denoising should be on by default.";
3088
Niels Möller805a27e2019-01-21 12:21:27 +01003089 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003090
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003091 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3092 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003093 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3094 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003095
Niels Möller805a27e2019-01-21 12:21:27 +01003096 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003097
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003098 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3099 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003100 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3101 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3102
Niels Möllerff40b142018-04-09 08:49:14 +02003103 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003104 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003105 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003106 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003107 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003108
Mirko Bonadeif859e552018-05-30 15:31:29 +02003109 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003110 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3111 // Autmatic resize off when using simulcast.
3112 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3113 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3114
Florent Castelli66b38602019-07-10 16:57:57 +02003115 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003116 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003117 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003118 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003119
Niels Möller805a27e2019-01-21 12:21:27 +01003120 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003121
Florent Castelli66b38602019-07-10 16:57:57 +02003122 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003123 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3124 EXPECT_FALSE(vp8_settings.denoisingOn);
3125 // Resizing and frame dropping always off for screen sharing.
3126 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3127 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3128
Niels Möller805a27e2019-01-21 12:21:27 +01003129 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003130
3131 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3132 EXPECT_FALSE(vp8_settings.denoisingOn);
3133 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3134 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3135
Niels Möllerff40b142018-04-09 08:49:14 +02003136 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003137}
3138
deadbeef119760a2016-04-04 11:43:27 -07003139// Test that setting the same options doesn't result in the encoder being
3140// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003141TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003142 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003143 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003144
perkjfa10b552016-10-02 23:45:26 -07003145 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003146 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003147 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003148 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3149 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3150
Niels Möller805a27e2019-01-21 12:21:27 +01003151 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3152 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3153 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003154 // Expect 1 reconfigurations at this point from the initial configuration.
3155 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003156
3157 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003158 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003159 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3160
3161 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003162 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003163 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003164 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3165
Niels Möllerff40b142018-04-09 08:49:14 +02003166 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003167}
3168
eladalonf1841382017-06-12 01:16:46 -07003169class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003170 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003171 Vp9SettingsTest() : Vp9SettingsTest("") {}
3172 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003173 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003174 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003175 }
3176 virtual ~Vp9SettingsTest() {}
3177
3178 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003179 void TearDown() override {
3180 // Remove references to encoder_factory_ since this will be destroyed
3181 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003182 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003183 }
Erik Språng143cec12015-04-28 10:01:41 +02003184};
3185
3186TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003187 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003188 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003189 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003190
Peter Boström2feafdb2015-09-09 14:32:14 +02003191 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003192
Niels Möller805a27e2019-01-21 12:21:27 +01003193 webrtc::test::FrameForwarder frame_forwarder;
3194 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003195 channel_->SetSend(true);
3196
Niels Möller805a27e2019-01-21 12:21:27 +01003197 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003198
pbos4cba4eb2015-10-26 11:18:18 -07003199 webrtc::VideoCodecVP9 vp9_settings;
3200 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003201 EXPECT_TRUE(vp9_settings.denoisingOn)
3202 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003203
Niels Möller805a27e2019-01-21 12:21:27 +01003204 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003205
Erik Språng143cec12015-04-28 10:01:41 +02003206 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3207 EXPECT_FALSE(vp9_settings.denoisingOn);
3208 // Frame dropping always on for real time video.
3209 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3210
Niels Möller805a27e2019-01-21 12:21:27 +01003211 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003212
3213 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3214 EXPECT_TRUE(vp9_settings.denoisingOn);
3215 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3216
3217 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003218 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003219 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003220 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003221
Niels Möller805a27e2019-01-21 12:21:27 +01003222 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003223
3224 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3225 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003226 // Frame dropping always on for screen sharing.
3227 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003228
Niels Möller805a27e2019-01-21 12:21:27 +01003229 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003230
3231 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3232 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003233 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003234
Niels Möllerff40b142018-04-09 08:49:14 +02003235 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003236}
3237
Sergey Silkinf18072e2018-03-14 10:35:35 +01003238TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3239 cricket::VideoSendParameters parameters;
3240 parameters.codecs.push_back(GetEngineCodec("VP9"));
3241 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3242
3243 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3244
3245 FakeVideoSendStream* stream =
3246 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3247
3248 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003249
Niels Möller805a27e2019-01-21 12:21:27 +01003250 webrtc::test::FrameForwarder frame_forwarder;
3251 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003252 channel_->SetSend(true);
3253
Niels Möller805a27e2019-01-21 12:21:27 +01003254 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003255
3256 webrtc::VideoCodecVP9 vp9_settings;
3257 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3258
3259 const size_t kNumSpatialLayers = ssrcs.size();
3260 const size_t kNumTemporalLayers = 3;
3261 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3262 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3263
Niels Möllerff40b142018-04-09 08:49:14 +02003264 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003265}
3266
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003267TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3268 cricket::VideoSendParameters parameters;
3269 parameters.codecs.push_back(GetEngineCodec("VP9"));
3270 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3271
3272 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3273
3274 FakeVideoSendStream* stream =
3275 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3276
3277 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3278
3279 // Despite 3 ssrcs provided, single layer is used.
3280 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3281
3282 webrtc::test::FrameForwarder frame_forwarder;
3283 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3284 channel_->SetSend(true);
3285
3286 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3287
3288 webrtc::VideoCodecVP9 vp9_settings;
3289 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3290
3291 const size_t kNumSpatialLayers = ssrcs.size();
3292 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3293
3294 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3295}
3296
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003297TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3298 cricket::VideoSendParameters send_parameters;
3299 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3300 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3301
3302 const size_t kNumSpatialLayers = 3;
3303 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3304
3305 FakeVideoSendStream* stream =
3306 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3307
3308 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3309 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3310 ASSERT_TRUE(parameters.encodings[0].active);
3311 ASSERT_TRUE(parameters.encodings[1].active);
3312 ASSERT_TRUE(parameters.encodings[2].active);
3313 // Invert value to verify copying.
3314 parameters.encodings[1].active = false;
3315 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3316
3317 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3318
3319 // number_of_streams should be 1 since all spatial layers are sent on the
3320 // same SSRC. But encoding parameters of all layers is supposed to be copied
3321 // and stored in simulcast_layers[].
3322 EXPECT_EQ(1u, encoder_config.number_of_streams);
3323 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3324 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3325 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3326 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3327}
3328
Sergey Silkincf267052019-04-09 11:40:09 +02003329class Vp9SettingsTestWithFieldTrial
3330 : public Vp9SettingsTest,
3331 public ::testing::WithParamInterface<
3332 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003333 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003334 Vp9SettingsTestWithFieldTrial()
3335 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3336 num_spatial_layers_(::testing::get<1>(GetParam())),
3337 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003338 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003339
3340 void VerifySettings(int num_spatial_layers,
3341 int num_temporal_layers,
3342 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003343 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003344 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003345 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3346
3347 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3348
Niels Möller805a27e2019-01-21 12:21:27 +01003349 webrtc::test::FrameForwarder frame_forwarder;
3350 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003351 channel_->SetSend(true);
3352
Niels Möller805a27e2019-01-21 12:21:27 +01003353 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003354
3355 webrtc::VideoCodecVP9 vp9_settings;
3356 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3357 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3358 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003359 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003360
Niels Möllerff40b142018-04-09 08:49:14 +02003361 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003362 }
Sergey Silkincf267052019-04-09 11:40:09 +02003363
3364 const uint8_t num_spatial_layers_;
3365 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003366 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003367};
3368
Sergey Silkincf267052019-04-09 11:40:09 +02003369TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003370 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3371 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003372}
3373
Sergey Silkincf267052019-04-09 11:40:09 +02003374INSTANTIATE_TEST_SUITE_P(
3375 ,
3376 Vp9SettingsTestWithFieldTrial,
3377 ::testing::Values(
3378 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3379 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3380 1,
3381 1,
3382 webrtc::InterLayerPredMode::kOnKeyPic),
3383 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3384 2,
3385 3,
3386 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003387 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003388 1,
3389 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003390 webrtc::InterLayerPredMode::kOnKeyPic),
3391 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003392 1,
3393 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003394 webrtc::InterLayerPredMode::kOnKeyPic),
3395 std::make_tuple(
3396 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3397 1,
3398 1,
3399 webrtc::InterLayerPredMode::kOff),
3400 std::make_tuple(
3401 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3402 1,
3403 1,
3404 webrtc::InterLayerPredMode::kOn),
3405 std::make_tuple(
3406 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3407 1,
3408 1,
3409 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003410
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003411TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3412 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3413 ASSERT_EQ(1u, streams.size());
3414 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3415}
3416
3417TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003418 RTC_DCHECK(!override_field_trials_);
3419 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003420 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3421 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3422 ASSERT_EQ(1u, streams.size());
3423 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3424}
3425
asapersson3c81a1a2017-06-14 05:52:21 -07003426TEST_F(WebRtcVideoChannelTest,
3427 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003428 RTC_DCHECK(!override_field_trials_);
3429 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003430 "WebRTC-Video-BalancedDegradation/Disabled/");
3431 const bool kResolutionScalingEnabled = true;
3432 const bool kFpsScalingEnabled = false;
3433 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3434}
3435
3436TEST_F(WebRtcVideoChannelTest,
3437 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003438 RTC_DCHECK(!override_field_trials_);
3439 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003440 "WebRTC-Video-BalancedDegradation/Enabled/");
3441 const bool kResolutionScalingEnabled = true;
3442 const bool kFpsScalingEnabled = true;
3443 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3444}
3445
eladalonf1841382017-06-12 01:16:46 -07003446TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003447 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003448}
3449
eladalonf1841382017-06-12 01:16:46 -07003450TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003451 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003452}
3453
Niels Möller3de32e62019-01-18 08:42:18 +01003454TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3455 TestCpuAdaptation(false, true);
3456}
3457
eladalonf1841382017-06-12 01:16:46 -07003458TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003459 TestCpuAdaptation(true, true);
3460}
3461
eladalonf1841382017-06-12 01:16:46 -07003462TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003463 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003464 cricket::VideoSendParameters parameters;
3465 parameters.codecs.push_back(codec);
3466
kthelgason2bc68642017-02-07 07:02:22 -08003467 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003468 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003469 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003470 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3471 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003472 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003473 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3474
3475 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003476 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003477
Per766ad3b2016-04-05 15:23:49 +02003478 ASSERT_TRUE(channel_->SetSend(true));
3479 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003480 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003481 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003482
3483 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3484 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003485
Niels Möllerdcc70292019-01-15 16:32:38 +01003486 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3487 // Dont' expect anything on framerate_scaling_enabled, since the default is
3488 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003489
Niels Möllerdcc70292019-01-15 16:32:38 +01003490 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003491 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003492 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003493 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003494 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3495 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003496 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003497
Niels Möllerdcc70292019-01-15 16:32:38 +01003498 // Switch back to the normal capturer. Expect resolution scaling to be
3499 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003500 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3501 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003502 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3503 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003504 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003505
Niels Möllerff40b142018-04-09 08:49:14 +02003506 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003507}
3508
asapersson3c81a1a2017-06-14 05:52:21 -07003509// TODO(asapersson): Remove this test when the balanced field trial is removed.
3510void WebRtcVideoChannelTest::TestDegradationPreference(
3511 bool resolution_scaling_enabled,
3512 bool fps_scaling_enabled) {
3513 cricket::VideoCodec codec = GetEngineCodec("VP8");
3514 cricket::VideoSendParameters parameters;
3515 parameters.codecs.push_back(codec);
3516
3517 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003518 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003519 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003520 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3521 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003522 channel_->OnReadyToSend(true);
3523
3524 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3525
3526 AddSendStream();
3527
Niels Möller805a27e2019-01-21 12:21:27 +01003528 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003529 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003530 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003531
3532 EXPECT_TRUE(channel_->SetSend(true));
3533
3534 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3535 EXPECT_EQ(resolution_scaling_enabled,
3536 send_stream->resolution_scaling_enabled());
3537 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3538
Niels Möllerff40b142018-04-09 08:49:14 +02003539 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003540}
3541
eladalonf1841382017-06-12 01:16:46 -07003542void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3543 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003544 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003545 cricket::VideoSendParameters parameters;
3546 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003547
kthelgason2bc68642017-02-07 07:02:22 -08003548 MediaConfig media_config = GetMediaConfig();
3549 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003550 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003551 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003552 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003553 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3554 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003555 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003556
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003557 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003558
3559 AddSendStream();
3560
Niels Möller805a27e2019-01-21 12:21:27 +01003561 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003562 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003563 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003564 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003565
3566 EXPECT_TRUE(channel_->SetSend(true));
3567
solenberge5269742015-09-08 05:13:22 -07003568 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003569
sprangc5d62e22017-04-02 23:53:04 -07003570 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003571 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003572 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003573 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003574 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3575 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3576 } else {
3577 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3578 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3579 }
Niels Möllerff40b142018-04-09 08:49:14 +02003580 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003581}
3582
eladalonf1841382017-06-12 01:16:46 -07003583TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003584 // Start at last timestamp to verify that wraparounds are estimated correctly.
3585 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3586 static const int64_t kInitialNtpTimeMs = 1247891230;
3587 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003588 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003589
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003590 FakeVideoReceiveStream* stream = AddRecvStream();
3591 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003592 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003593
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003594 webrtc::VideoFrame video_frame =
3595 webrtc::VideoFrame::Builder()
3596 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3597 .set_timestamp_rtp(kInitialTimestamp)
3598 .set_timestamp_us(0)
3599 .set_rotation(webrtc::kVideoRotation_0)
3600 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003601 // Initial NTP time is not available on the first frame, but should still be
3602 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003603 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003604
3605 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003606
3607 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3608 // triggers a constant-overflow warning, hence we're calculating it explicitly
3609 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003610 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003611 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3612 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003613 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003614
3615 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003616
3617 // Verify that NTP time has been correctly deduced.
3618 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003619 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003620 ASSERT_EQ(1u, info.receivers.size());
3621 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003622}
3623
eladalonf1841382017-06-12 01:16:46 -07003624TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003625 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003626 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003627
3628 VideoCodec codec;
3629 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003630 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003631
3632 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003633 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3634 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003635 FakeVideoSendStream* stream = AddSendStream(
3636 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003637 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003638
3639 // Make sure NACK and FEC are enabled on the correct payload types.
3640 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003641 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3642 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003643
3644 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3645 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003646 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003647 // TODO(juberti): Check RTCP, PLI, TMMBR.
3648}
3649
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003650TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3651 cricket::VideoSendParameters parameters;
3652 parameters.codecs.push_back(GetEngineCodec("VP8"));
3653 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3654
3655 FakeVideoSendStream* stream = AddSendStream();
3656 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3657 EXPECT_FALSE(config.rtp.raw_payload);
3658}
3659
3660TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3661 cricket::VideoSendParameters parameters;
3662 parameters.codecs.push_back(GetEngineCodec("VP8"));
3663 parameters.codecs.back().packetization = kPacketizationParamRaw;
3664 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3665
3666 FakeVideoSendStream* stream = AddSendStream();
3667 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3668 EXPECT_TRUE(config.rtp.raw_payload);
3669}
3670
brandtr31bd2242017-05-19 05:47:46 -07003671// The following four tests ensures that FlexFEC is not activated by default
3672// when the field trials are not enabled.
3673// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3674// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003675TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003676 FakeVideoSendStream* stream = AddSendStream();
3677 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3678
brandtr3d200bd2017-01-16 06:59:19 -08003679 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003680 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3681 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003682}
3683
eladalonf1841382017-06-12 01:16:46 -07003684TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003685 FakeVideoSendStream* stream = AddSendStream(
3686 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3687 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3688
brandtr3d200bd2017-01-16 06:59:19 -08003689 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003690 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3691 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3692}
3693
Yves Gerey665174f2018-06-19 15:03:05 +02003694TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003695 AddRecvStream();
3696
3697 const std::vector<FakeFlexfecReceiveStream*>& streams =
3698 fake_call_->GetFlexfecReceiveStreams();
3699 EXPECT_TRUE(streams.empty());
3700}
3701
eladalonf1841382017-06-12 01:16:46 -07003702TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003703 AddRecvStream(
3704 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3705
3706 const std::vector<FakeFlexfecReceiveStream*>& streams =
3707 fake_call_->GetFlexfecReceiveStreams();
3708 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003709}
3710
3711// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3712// tests that use this test fixture into the corresponding "non-field trial"
3713// tests.
eladalonf1841382017-06-12 01:16:46 -07003714class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003715 public:
eladalonf1841382017-06-12 01:16:46 -07003716 WebRtcVideoChannelFlexfecRecvTest()
3717 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003718};
3719
eladalonf1841382017-06-12 01:16:46 -07003720TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003721 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3722 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3723 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3724}
3725
eladalonf1841382017-06-12 01:16:46 -07003726TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003727 AddRecvStream();
3728
3729 const std::vector<FakeFlexfecReceiveStream*>& streams =
3730 fake_call_->GetFlexfecReceiveStreams();
3731 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003732
3733 const std::vector<FakeVideoReceiveStream*>& video_streams =
3734 fake_call_->GetVideoReceiveStreams();
3735 ASSERT_EQ(1U, video_streams.size());
3736 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3737 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3738 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003739}
3740
eladalonf1841382017-06-12 01:16:46 -07003741TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003742 AddRecvStream(
3743 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3744
3745 const std::vector<FakeFlexfecReceiveStream*>& streams =
3746 fake_call_->GetFlexfecReceiveStreams();
3747 ASSERT_EQ(1U, streams.size());
3748 const FakeFlexfecReceiveStream* stream = streams.front();
3749 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3750 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3751 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3752 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3753 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003754
3755 const std::vector<FakeVideoReceiveStream*>& video_streams =
3756 fake_call_->GetVideoReceiveStreams();
3757 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003758 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3759 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003760 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003761 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003762 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003763}
3764
eladalonf1841382017-06-12 01:16:46 -07003765TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003766 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3767 cricket::VideoRecvParameters recv_parameters;
3768 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3769 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3770
3771 AddRecvStream(
3772 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3773 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003774 const std::vector<FakeVideoReceiveStream*>& video_streams =
3775 fake_call_->GetVideoReceiveStreams();
3776 ASSERT_EQ(1U, video_streams.size());
3777 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3778 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3779 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003780
3781 // Enable FlexFEC.
3782 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3783 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3784 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3785 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3786 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3787 << "Enabling FlexFEC should not create VideoReceiveStream.";
3788 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3789 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003790 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3791 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003792}
3793
eladalonf1841382017-06-12 01:16:46 -07003794TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003795 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3796 cricket::VideoRecvParameters recv_parameters;
3797 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3798 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3799 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3800
3801 AddRecvStream(
3802 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3803 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003804 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003805 const std::vector<FakeVideoReceiveStream*>& video_streams =
3806 fake_call_->GetVideoReceiveStreams();
3807 ASSERT_EQ(1U, video_streams.size());
3808 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3809 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3810 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003811
3812 // Disable FlexFEC.
3813 recv_parameters.codecs.clear();
3814 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3815 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3816 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3817 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3818 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3819 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3820 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3821 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003822 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3823 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003824}
3825
Steve Anton2d2bbb12019-08-07 09:57:59 -07003826TEST_F(WebRtcVideoChannelFlexfecRecvTest, DuplicateFlexfecCodecIsDropped) {
3827 constexpr int kUnusedPayloadType1 = 127;
3828
3829 cricket::VideoRecvParameters recv_parameters;
3830 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3831 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3832 cricket::VideoCodec duplicate = GetEngineCodec("flexfec-03");
3833 duplicate.id = kUnusedPayloadType1;
3834 recv_parameters.codecs.push_back(duplicate);
3835 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3836
3837 AddRecvStream(
3838 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3839
3840 const std::vector<FakeFlexfecReceiveStream*>& streams =
3841 fake_call_->GetFlexfecReceiveStreams();
3842 ASSERT_EQ(1U, streams.size());
3843 const FakeFlexfecReceiveStream* stream = streams.front();
3844 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3845 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3846}
3847
brandtr31bd2242017-05-19 05:47:46 -07003848// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3849// tests that use this test fixture into the corresponding "non-field trial"
3850// tests.
eladalonf1841382017-06-12 01:16:46 -07003851class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003852 public:
eladalonf1841382017-06-12 01:16:46 -07003853 WebRtcVideoChannelFlexfecSendRecvTest()
3854 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003855 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3856 }
3857};
3858
Yves Gerey665174f2018-06-19 15:03:05 +02003859TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003860 FakeVideoSendStream* stream = AddSendStream();
3861 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3862
brandtr3d200bd2017-01-16 06:59:19 -08003863 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3864 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3865 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003866}
3867
eladalonf1841382017-06-12 01:16:46 -07003868TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003869 FakeVideoSendStream* stream = AddSendStream(
3870 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3871 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3872
brandtr3d200bd2017-01-16 06:59:19 -08003873 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3874 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3875 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3876 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003877}
3878
eladalonf1841382017-06-12 01:16:46 -07003879TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003880 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003881 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003882 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003883
3884 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003885 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003886
brandtrb5f2c3f2016-10-04 23:28:39 -07003887 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3888 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003889}
3890
eladalonf1841382017-06-12 01:16:46 -07003891TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003892 cricket::VideoSendParameters parameters;
3893 parameters.codecs.push_back(GetEngineCodec("VP8"));
3894 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3895
3896 FakeVideoSendStream* stream = AddSendStream();
3897 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3898
brandtr3d200bd2017-01-16 06:59:19 -08003899 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003900}
3901
eladalonf1841382017-06-12 01:16:46 -07003902TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003903 AddRecvStream(
3904 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003905
3906 cricket::VideoRecvParameters recv_parameters;
3907 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3908 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3909 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003910
3911 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3912 fake_call_->GetFlexfecReceiveStreams();
3913 ASSERT_EQ(1U, flexfec_streams.size());
3914 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3915 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3916 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003917 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003918 flexfec_stream_config.payload_type);
3919 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3920 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3921 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3922 const std::vector<FakeVideoReceiveStream*>& video_streams =
3923 fake_call_->GetVideoReceiveStreams();
3924 const FakeVideoReceiveStream* video_stream = video_streams.front();
3925 const webrtc::VideoReceiveStream::Config& video_stream_config =
3926 video_stream->GetConfig();
3927 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3928 flexfec_stream_config.local_ssrc);
3929 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3930 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3931 flexfec_stream_config.rtcp_send_transport);
3932 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3933 // spec-compliant way.
3934 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3935 flexfec_stream_config.transport_cc);
3936 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3937 EXPECT_EQ(video_stream_config.rtp.extensions,
3938 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003939}
3940
brandtr31bd2242017-05-19 05:47:46 -07003941// We should not send FlexFEC, even if we advertise it, unless the right
3942// field trial is set.
3943// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003944TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003945 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3946 cricket::VideoSendParameters parameters;
3947 parameters.codecs.push_back(GetEngineCodec("VP8"));
3948 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3949 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3950
3951 FakeVideoSendStream* stream = AddSendStream();
3952 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3953
3954 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003955 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003956 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3957}
3958
eladalonf1841382017-06-12 01:16:46 -07003959TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003960 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3961 cricket::VideoSendParameters parameters;
3962 parameters.codecs.push_back(GetEngineCodec("VP8"));
3963 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3964 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3965
3966 FakeVideoSendStream* stream = AddSendStream(
3967 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3968 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3969
3970 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003971 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003972 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3973}
3974
eladalonf1841382017-06-12 01:16:46 -07003975TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003976 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003977 const int kUnusedPayloadType = 127;
3978 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3979
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003980 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003981 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003982 parameters.codecs.push_back(rtx_codec);
3983 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003984 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003985}
3986
eladalonf1841382017-06-12 01:16:46 -07003987TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003988 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003989 const int kUnusedPayloadType1 = 126;
3990 const int kUnusedPayloadType2 = 127;
3991 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3992 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3993 {
3994 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3995 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3996 cricket::VideoSendParameters parameters;
3997 parameters.codecs.push_back(GetEngineCodec("VP8"));
3998 parameters.codecs.push_back(rtx_codec);
3999 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4000 }
4001 {
4002 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4003 kUnusedPayloadType1, kUnusedPayloadType2);
4004 cricket::VideoSendParameters parameters;
4005 parameters.codecs.push_back(GetEngineCodec("VP8"));
4006 parameters.codecs.push_back(rtx_codec);
4007 EXPECT_FALSE(channel_->SetSendParameters(parameters))
4008 << "RTX without matching video codec should be rejected.";
4009 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004010}
4011
eladalonf1841382017-06-12 01:16:46 -07004012TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004013 const int kUnusedPayloadType1 = 126;
4014 const int kUnusedPayloadType2 = 127;
4015 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4016 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4017
4018 // SSRCs for RTX.
4019 cricket::StreamParams params =
4020 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4021 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4022 AddSendStream(params);
4023
4024 // Original payload type for RTX.
4025 cricket::VideoSendParameters parameters;
4026 parameters.codecs.push_back(GetEngineCodec("VP8"));
4027 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4028 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4029 parameters.codecs.push_back(rtx_codec);
4030 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4031 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4032 const webrtc::VideoSendStream::Config& config_before =
4033 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4034 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4035 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4036 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4037
4038 // Change payload type for RTX.
4039 parameters.codecs[1].id = kUnusedPayloadType2;
4040 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4041 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4042 const webrtc::VideoSendStream::Config& config_after =
4043 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4044 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4045 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4046 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4047}
4048
eladalonf1841382017-06-12 01:16:46 -07004049TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004050 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004051 parameters.codecs.push_back(GetEngineCodec("VP8"));
4052 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004053 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004054
4055 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004056 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004057
magjed509e4fe2016-11-18 01:34:11 -08004058 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004059
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004060 parameters.codecs.pop_back();
4061 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004062 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004063 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004064 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004065 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004066 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4067}
4068
eladalonf1841382017-06-12 01:16:46 -07004069TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004070 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004071 cricket::VideoSendParameters parameters;
4072 parameters.codecs.push_back(GetEngineCodec("VP8"));
4073 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4074 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4075
4076 FakeVideoSendStream* stream = AddSendStream(
4077 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4078 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4079
brandtr3d200bd2017-01-16 06:59:19 -08004080 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4081 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004082 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4083 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4084
4085 parameters.codecs.pop_back();
4086 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4087 stream = fake_call_->GetVideoSendStreams()[0];
4088 ASSERT_TRUE(stream != nullptr);
4089 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004090 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004091 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004092}
4093
eladalonf1841382017-06-12 01:16:46 -07004094TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004095 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004096 cricket::VideoCodec codec(100, "VP8");
4097 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4098 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004099
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004100 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004101 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004102
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004103 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004104 webrtc::test::FrameForwarder frame_forwarder;
4105 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004106
4107 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004108 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004109
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004110 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004111 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4112 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004113 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004114 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004115 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004116 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004117}
4118
eladalonf1841382017-06-12 01:16:46 -07004119TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004120 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4121 200000);
4122}
4123
eladalonf1841382017-06-12 01:16:46 -07004124TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004125 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4126 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4127 ASSERT_EQ(1u, streams.size());
4128 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4129}
4130
eladalonf1841382017-06-12 01:16:46 -07004131TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004132 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004133 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004134}
4135
eladalonf1841382017-06-12 01:16:46 -07004136TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004137 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004138}
4139
eladalonf1841382017-06-12 01:16:46 -07004140TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004141 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4142 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4143 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004144}
4145
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004146// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4147// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004148TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004149 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4150 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4151 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4152 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004153 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004154 ExpectSetBitrateParameters(100000, 200000, 400000);
4155 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4156 // Since the codec isn't changing, start_bitrate_bps should be -1.
4157 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004158
4159 // Decrease max_bandwidth_bps.
4160 send_parameters_.max_bandwidth_bps = 350000;
4161 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004162
4163 // Now try again with the values flipped around.
4164 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4165 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004166 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004167 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004168
4169 // If we change the codec max, max_bandwidth_bps should still apply.
4170 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004171 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004172 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004173}
4174
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004175// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4176// are present in the same send parameters, the settings are combined correctly.
4177TEST_F(WebRtcVideoChannelTest,
4178 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4179 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4180 // Transport.
4181 webrtc::MediaTransportSettings settings;
4182 settings.is_caller = true;
4183 webrtc::FakeMediaTransport fake_media_transport(settings);
4184 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4185 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004186 channel_->SetInterface(network_interface.get(),
4187 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004188
4189 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4190 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4191 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4192 send_parameters_.max_bandwidth_bps = 400000;
4193 {
4194 // We expect max_bandwidth_bps to take priority, if set.
4195 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4196 ASSERT_EQ(1u,
4197 fake_media_transport.target_rate_constraints_in_order().size());
4198 const webrtc::MediaTransportTargetRateConstraints& constraint =
4199 fake_media_transport.target_rate_constraints_in_order()[0];
4200 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4201 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4202 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4203 }
4204
4205 {
4206 // Decrease max_bandwidth_bps.
4207 send_parameters_.max_bandwidth_bps = 350000;
4208 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4209 ASSERT_EQ(2u,
4210 fake_media_transport.target_rate_constraints_in_order().size());
4211 const webrtc::MediaTransportTargetRateConstraints& constraint =
4212 fake_media_transport.target_rate_constraints_in_order()[1];
4213
4214 // Since the codec isn't changing, start_bitrate_bps should be 0.
4215 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4216 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4217 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4218 }
4219
4220 {
4221 // Now try again with the values flipped around.
4222 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4223 send_parameters_.max_bandwidth_bps = 300000;
4224 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4225 ASSERT_EQ(3u,
4226 fake_media_transport.target_rate_constraints_in_order().size());
4227 const webrtc::MediaTransportTargetRateConstraints& constraint =
4228 fake_media_transport.target_rate_constraints_in_order()[2];
4229
4230 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4231 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4232 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4233 }
4234
4235 {
4236 // Now try again with the values flipped around.
4237 // If we change the codec max, max_bandwidth_bps should still apply.
4238 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4239 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4240 ASSERT_EQ(4u,
4241 fake_media_transport.target_rate_constraints_in_order().size());
4242 const webrtc::MediaTransportTargetRateConstraints& constraint =
4243 fake_media_transport.target_rate_constraints_in_order()[3];
4244
4245 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4246 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4247 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4248 }
4249}
4250
Yves Gerey665174f2018-06-19 15:03:05 +02004251TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004252 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4253 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004254 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004255 // Setting max bitrate should keep previous min bitrate.
4256 // Setting max bitrate should not reset start bitrate.
4257 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004258 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004259}
4260
eladalonf1841382017-06-12 01:16:46 -07004261TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004262 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004263 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004264 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004265 // -1 means to disable max bitrate (set infinite).
4266 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004267 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004268 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004269}
4270
eladalonf1841382017-06-12 01:16:46 -07004271TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004272 send_parameters_.max_bandwidth_bps = 99999;
4273 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004274 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004275 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004276 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4277 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4278 stream->GetVideoStreams()[0].max_bitrate_bps);
4279
4280 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004281 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004282 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4283 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004284 stream->GetVideoStreams()[0].max_bitrate_bps);
4285}
4286
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004287// Tests that when the codec specific max bitrate and VideoSendParameters
4288// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4289// appropriately.
4290TEST_F(WebRtcVideoChannelTest,
4291 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4292 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4293 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4294 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4295 send_parameters_.max_bandwidth_bps = -1;
4296 AddSendStream();
4297 ExpectSetMaxBitrate(300000);
4298 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4299
4300 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4301 ASSERT_EQ(1u, video_send_streams.size());
4302 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4303 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4304 // First the max bitrate is set based upon the codec param.
4305 EXPECT_EQ(300000,
4306 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4307
4308 // The VideoSendParameters max bitrate overrides the codec's.
4309 send_parameters_.max_bandwidth_bps = 500000;
4310 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4311 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4312 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4313 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4314}
4315
4316// Tests that when the codec specific max bitrate and RtpParameters
4317// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4318// appropriately.
4319TEST_F(WebRtcVideoChannelTest,
4320 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4321 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4322 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4323 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4324 send_parameters_.max_bandwidth_bps = -1;
4325 AddSendStream();
4326 ExpectSetMaxBitrate(300000);
4327 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4328
4329 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4330 ASSERT_EQ(1u, video_send_streams.size());
4331 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4332 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4333 // First the max bitrate is set based upon the codec param.
4334 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4335
4336 // The RtpParameter max bitrate overrides the codec's.
4337 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4338 ASSERT_EQ(1u, parameters.encodings.size());
4339 parameters.encodings[0].max_bitrate_bps = 500000;
4340 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4341 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4342 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4343 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4344}
4345
Åsa Persson55659812018-06-18 17:51:32 +02004346TEST_F(WebRtcVideoChannelTest,
4347 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4348 send_parameters_.max_bandwidth_bps = 99999;
4349 FakeVideoSendStream* stream = AddSendStream();
4350 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4351 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4352 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4353 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4354 stream->GetVideoStreams()[0].max_bitrate_bps);
4355
4356 // Get and set the rtp encoding parameters.
4357 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4358 EXPECT_EQ(1u, parameters.encodings.size());
4359
4360 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4361 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4362 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4363 stream->GetVideoStreams()[0].max_bitrate_bps);
4364
4365 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4366 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4367 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4368 stream->GetVideoStreams()[0].max_bitrate_bps);
4369}
4370
eladalonf1841382017-06-12 01:16:46 -07004371TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004372 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004373 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004374 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004375 channel_->SetSend(true);
4376
4377 FakeVideoSendStream* stream = AddSendStream();
4378
Niels Möller805a27e2019-01-21 12:21:27 +01004379 webrtc::test::FrameForwarder frame_forwarder;
4380 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004381
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004382 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4383 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4384 EXPECT_GT(initial_max_bitrate_bps, 0);
4385
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004386 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4387 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004388 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004389 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004390 streams = stream->GetVideoStreams();
4391 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004392 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004393}
4394
eladalonf1841382017-06-12 01:16:46 -07004395TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004396 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004397 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004398 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004399 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004400 channel_->SetSend(true);
4401
4402 FakeVideoSendStream* stream = AddSendStream(
4403 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4404
4405 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004406 webrtc::test::FrameForwarder frame_forwarder;
4407 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4408 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004409
4410 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4411 ASSERT_GT(streams.size(), 1u)
4412 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004413 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004414 EXPECT_GT(initial_max_bitrate_bps, 0);
4415
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004416 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4417 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004418 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004419 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004420 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004421 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004422 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4423
Niels Möllerff40b142018-04-09 08:49:14 +02004424 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004425}
4426
eladalonf1841382017-06-12 01:16:46 -07004427TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004428 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004429 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004430 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004431 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4432 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004433 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004434 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004435
4436 VideoCodec codec;
4437 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4438 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4439}
4440
eladalonf1841382017-06-12 01:16:46 -07004441TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004442 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004443 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004444 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004445 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004446 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004447 parameters.codecs[0].id = kIncorrectPayloads[i];
4448 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004449 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004450 }
4451}
4452
eladalonf1841382017-06-12 01:16:46 -07004453TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004454 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004455 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004456 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004457 parameters.codecs[0].id = payload_type;
4458 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004459 << "Payload type '" << payload_type << "' rejected.";
4460 }
4461}
4462
deadbeef67cf2c12016-04-13 10:07:16 -07004463// Test that setting the a different set of codecs but with an identical front
4464// codec doesn't result in the stream being recreated.
4465// This may happen when a subsequent negotiation includes fewer codecs, as a
4466// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004467TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004468 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4469 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004470 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4471 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004472 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4473
4474 AddSendStream();
4475 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4476
4477 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004478 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004479 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4480 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4481}
4482
eladalonf1841382017-06-12 01:16:46 -07004483TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004484 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004485 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004486 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004487}
4488
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004489// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004490TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004491 const int kUnusedPayloadType1 = 126;
4492 const int kUnusedPayloadType2 = 127;
4493 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4494 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4495
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004496 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004497 parameters.codecs.push_back(GetEngineCodec("VP8"));
4498 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004499 parameters.codecs.push_back(rtx_codec);
4500 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004501 << "RTX codec without associated payload should be rejected.";
4502
magjed509e4fe2016-11-18 01:34:11 -08004503 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004504 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004505 << "RTX codec with invalid associated payload type should be rejected.";
4506
magjed509e4fe2016-11-18 01:34:11 -08004507 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004508 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004509
magjed509e4fe2016-11-18 01:34:11 -08004510 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004511 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004512 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004513
Yves Gerey665174f2018-06-19 15:03:05 +02004514 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4515 << "RTX codec with another RTX as associated payload type should be "
4516 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004517}
4518
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004519TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4520 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4521 vp8_codec.packetization = kPacketizationParamRaw;
4522
4523 cricket::VideoRecvParameters parameters;
4524 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4525 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4526
4527 const cricket::StreamParams params =
4528 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4529 AddRecvStream(params);
4530 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4531
4532 const webrtc::VideoReceiveStream::Config& config =
4533 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4534 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4535 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4536}
4537
4538TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4539 cricket::VideoRecvParameters parameters;
4540 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4541 parameters.codecs.back().packetization = kPacketizationParamRaw;
4542 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4543
4544 const cricket::StreamParams params =
4545 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4546 AddRecvStream(params);
4547 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4548 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4549
4550 parameters.codecs.back().packetization.reset();
4551 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4552 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4553}
4554
Steve Anton2d2bbb12019-08-07 09:57:59 -07004555TEST_F(WebRtcVideoChannelTest, DuplicateUlpfecCodecIsDropped) {
4556 constexpr int kFirstUlpfecPayloadType = 126;
4557 constexpr int kSecondUlpfecPayloadType = 127;
4558
4559 cricket::VideoRecvParameters parameters;
4560 parameters.codecs.push_back(GetEngineCodec("VP8"));
4561 parameters.codecs.push_back(
4562 cricket::VideoCodec(kFirstUlpfecPayloadType, cricket::kUlpfecCodecName));
4563 parameters.codecs.push_back(
4564 cricket::VideoCodec(kSecondUlpfecPayloadType, cricket::kUlpfecCodecName));
4565 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4566
4567 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4568 EXPECT_EQ(kFirstUlpfecPayloadType,
4569 recv_stream->GetConfig().rtp.ulpfec_payload_type);
4570}
4571
4572TEST_F(WebRtcVideoChannelTest, DuplicateRedCodecIsDropped) {
4573 constexpr int kFirstRedPayloadType = 126;
4574 constexpr int kSecondRedPayloadType = 127;
4575
4576 cricket::VideoRecvParameters parameters;
4577 parameters.codecs.push_back(GetEngineCodec("VP8"));
4578 parameters.codecs.push_back(
4579 cricket::VideoCodec(kFirstRedPayloadType, cricket::kRedCodecName));
4580 parameters.codecs.push_back(
4581 cricket::VideoCodec(kSecondRedPayloadType, cricket::kRedCodecName));
4582 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4583
4584 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4585 EXPECT_EQ(kFirstRedPayloadType,
4586 recv_stream->GetConfig().rtp.red_payload_type);
4587}
4588
eladalonf1841382017-06-12 01:16:46 -07004589TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004590 const int kUnusedPayloadType1 = 126;
4591 const int kUnusedPayloadType2 = 127;
4592 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4593 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4594
4595 // SSRCs for RTX.
4596 cricket::StreamParams params =
4597 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4598 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4599 AddRecvStream(params);
4600
4601 // Original payload type for RTX.
4602 cricket::VideoRecvParameters parameters;
4603 parameters.codecs.push_back(GetEngineCodec("VP8"));
4604 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4605 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4606 parameters.codecs.push_back(rtx_codec);
4607 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4608 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4609 const webrtc::VideoReceiveStream::Config& config_before =
4610 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004611 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4612 const int* payload_type_before = FindKeyByValue(
4613 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4614 ASSERT_NE(payload_type_before, nullptr);
4615 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004616 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4617
4618 // Change payload type for RTX.
4619 parameters.codecs[1].id = kUnusedPayloadType2;
4620 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4621 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4622 const webrtc::VideoReceiveStream::Config& config_after =
4623 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004624 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4625 const int* payload_type_after = FindKeyByValue(
4626 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4627 ASSERT_NE(payload_type_after, nullptr);
4628 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004629 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4630}
4631
eladalonf1841382017-06-12 01:16:46 -07004632TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004633 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004634 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004635 parameters.codecs[0].id = 99;
4636 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004637}
4638
eladalonf1841382017-06-12 01:16:46 -07004639TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004640 cricket::VideoRecvParameters parameters;
4641 parameters.codecs = engine_.codecs();
4642 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004643
4644 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004645 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004646 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004647 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004648}
4649
eladalonf1841382017-06-12 01:16:46 -07004650TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004651 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004652 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004653 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004654 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004655}
4656
eladalonf1841382017-06-12 01:16:46 -07004657TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004658 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004659 parameters.codecs.push_back(GetEngineCodec("VP8"));
4660 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004661 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004662}
4663
eladalonf1841382017-06-12 01:16:46 -07004664TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004665 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004666 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4667 send_parameters.codecs.push_back(GetEngineCodec("red"));
4668 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004669 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004670
4671 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004672
magjed509e4fe2016-11-18 01:34:11 -08004673 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004674 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004675
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004676 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004677 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004678 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004679 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004680 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004681 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004682 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4683}
4684
eladalonf1841382017-06-12 01:16:46 -07004685TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004686 AddRecvStream(
4687 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004688 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004689 fake_call_->GetFlexfecReceiveStreams();
4690
4691 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004692 const FakeFlexfecReceiveStream* stream = streams.front();
4693 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4694 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4695 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4696 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004697
4698 cricket::VideoRecvParameters recv_parameters;
4699 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4700 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4701 EXPECT_TRUE(streams.empty())
4702 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004703}
4704
eladalonf1841382017-06-12 01:16:46 -07004705TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004706 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004707 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004708 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004709
4710 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004711 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4712 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4713 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004714 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4715 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004716 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004717 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004718 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004719 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004720
4721 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004722 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4723 send_parameters.codecs.push_back(GetEngineCodec("red"));
4724 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004725 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4726 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004727 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004728 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004729 << "ULPFEC should be enabled on the receive stream.";
4730}
4731
eladalonf1841382017-06-12 01:16:46 -07004732TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004733 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004734 AddRecvStream(
4735 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004736 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004737 fake_call_->GetFlexfecReceiveStreams();
4738
4739 cricket::VideoRecvParameters recv_parameters;
4740 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4741 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4742 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4743 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004744 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004745 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004746 stream_with_recv_params->GetConfig().payload_type);
4747 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004748 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004749 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004750 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004751 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004752
4753 cricket::VideoSendParameters send_parameters;
4754 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4755 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4756 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4757 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004758 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004759 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004760 stream_with_send_params->GetConfig().payload_type);
4761 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004762 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004763 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004764 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004765 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004766}
4767
eladalonf1841382017-06-12 01:16:46 -07004768TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004769 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004770 parameters.codecs.push_back(GetEngineCodec("VP8"));
4771 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004772 parameters.codecs[1].id = parameters.codecs[0].id;
4773 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004774}
4775
eladalonf1841382017-06-12 01:16:46 -07004776TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004777 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004778 cricket::VideoRecvParameters parameters;
4779 parameters.codecs.push_back(GetEngineCodec("VP8"));
4780 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4781 parameters.codecs[1].id = parameters.codecs[0].id;
4782 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4783}
4784
eladalonf1841382017-06-12 01:16:46 -07004785TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004786 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004787 parameters.codecs.push_back(GetEngineCodec("VP8"));
4788 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004789 parameters.codecs[1].id = parameters.codecs[0].id;
4790 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004791}
4792
eladalonf1841382017-06-12 01:16:46 -07004793TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004794 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004795 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004796 parameters.codecs.push_back(GetEngineCodec("VP8"));
4797 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004798 parameters.codecs[1].id += 1;
4799 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004800}
4801
deadbeef67cf2c12016-04-13 10:07:16 -07004802// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004803// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004804TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004805 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004806 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004807 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4808 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004809 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004810
4811 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4812 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4813
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004814 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004815 parameters2.codecs.push_back(GetEngineCodec("red"));
4816 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004817 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004818 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4819}
4820
eladalonf1841382017-06-12 01:16:46 -07004821TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004822 EXPECT_FALSE(AddSendStream()->IsSending());
4823}
4824
eladalonf1841382017-06-12 01:16:46 -07004825TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004826 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004827}
4828
eladalonf1841382017-06-12 01:16:46 -07004829TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004830 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004831 EXPECT_FALSE(stream->IsSending());
4832
4833 // false->true
4834 EXPECT_TRUE(channel_->SetSend(true));
4835 EXPECT_TRUE(stream->IsSending());
4836 // true->true
4837 EXPECT_TRUE(channel_->SetSend(true));
4838 EXPECT_TRUE(stream->IsSending());
4839 // true->false
4840 EXPECT_TRUE(channel_->SetSend(false));
4841 EXPECT_FALSE(stream->IsSending());
4842 // false->false
4843 EXPECT_TRUE(channel_->SetSend(false));
4844 EXPECT_FALSE(stream->IsSending());
4845
4846 EXPECT_TRUE(channel_->SetSend(true));
4847 FakeVideoSendStream* new_stream = AddSendStream();
4848 EXPECT_TRUE(new_stream->IsSending())
4849 << "Send stream created after SetSend(true) not sending initially.";
4850}
4851
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004852// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004853TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004854 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004855 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004856 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004857 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004858 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004859
Sebastian Jansson84848f22018-11-16 10:40:36 +01004860 channel.reset(
4861 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004862 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4863 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004864 channel->SetInterface(network_interface.get(),
4865 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004866 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004867 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004868
Tim Haloun648d28a2018-10-18 16:52:22 -07004869 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4870 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004871 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004872 channel.reset(
4873 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004874 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4875 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004876 channel->SetInterface(network_interface.get(),
4877 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004878 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4879
4880 // Create a send stream to configure
4881 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4882 parameters = channel->GetRtpSendParameters(kSsrc);
4883 ASSERT_FALSE(parameters.encodings.empty());
4884
4885 // Various priorities map to various dscp values.
4886 parameters.encodings[0].network_priority = 4.0;
4887 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004888 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004889 parameters.encodings[0].network_priority = 0.5;
4890 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4891 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4892
4893 // A bad priority does not change the dscp value.
4894 parameters.encodings[0].network_priority = 0.0;
4895 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4896 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004897
Tim Haloun6ca98362018-09-17 17:06:08 -07004898 // Packets should also self-identify their dscp in PacketOptions.
4899 const uint8_t kData[10] = {0};
4900 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4901 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004902 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004903
nisse51542be2016-02-12 02:27:06 -08004904 // Verify that setting the option to false resets the
4905 // DiffServCodePoint.
4906 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004907 channel.reset(
4908 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004909 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4910 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004911 channel->SetInterface(network_interface.get(),
4912 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004913 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004914}
4915
deadbeef13871492015-12-09 12:37:51 -08004916// This test verifies that the RTCP reduced size mode is properly applied to
4917// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004918TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004919 // Create stream, expecting that default mode is "compound".
4920 FakeVideoSendStream* stream1 = AddSendStream();
4921 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004922 webrtc::RtpParameters rtp_parameters =
4923 channel_->GetRtpSendParameters(last_ssrc_);
4924 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004925
4926 // Now enable reduced size mode.
4927 send_parameters_.rtcp.reduced_size = true;
4928 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4929 stream1 = fake_call_->GetVideoSendStreams()[0];
4930 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004931 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4932 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004933
4934 // Create a new stream and ensure it picks up the reduced size mode.
4935 FakeVideoSendStream* stream2 = AddSendStream();
4936 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4937}
4938
4939// This test verifies that the RTCP reduced size mode is properly applied to
4940// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004941TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004942 // Create stream, expecting that default mode is "compound".
4943 FakeVideoReceiveStream* stream1 = AddRecvStream();
4944 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4945
4946 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004947 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4948 // the reduced_size flag should come from that.
4949 send_parameters_.rtcp.reduced_size = true;
4950 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004951 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4952 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4953
4954 // Create a new stream and ensure it picks up the reduced size mode.
4955 FakeVideoReceiveStream* stream2 = AddRecvStream();
4956 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4957}
4958
eladalonf1841382017-06-12 01:16:46 -07004959TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004960 EXPECT_EQ(webrtc::kNetworkUp,
4961 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4962 EXPECT_EQ(webrtc::kNetworkUp,
4963 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004964
4965 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004966 EXPECT_EQ(webrtc::kNetworkDown,
4967 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4968 EXPECT_EQ(webrtc::kNetworkUp,
4969 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004970
4971 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004972 EXPECT_EQ(webrtc::kNetworkUp,
4973 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4974 EXPECT_EQ(webrtc::kNetworkUp,
4975 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004976}
4977
eladalonf1841382017-06-12 01:16:46 -07004978TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004979 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004980 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004981 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004982
4983 AddSendStream();
4984
4985 cricket::VideoMediaInfo info;
4986 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004987 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004988}
4989
eladalonf1841382017-06-12 01:16:46 -07004990TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004991 FakeVideoSendStream* stream = AddSendStream();
4992 webrtc::VideoSendStream::Stats stats;
4993 stats.encoder_implementation_name = "encoder_implementation_name";
4994 stream->SetStats(stats);
4995
4996 cricket::VideoMediaInfo info;
4997 ASSERT_TRUE(channel_->GetStats(&info));
4998 EXPECT_EQ(stats.encoder_implementation_name,
4999 info.senders[0].encoder_implementation_name);
5000}
5001
eladalonf1841382017-06-12 01:16:46 -07005002TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005003 FakeVideoSendStream* stream = AddSendStream();
5004 webrtc::VideoSendStream::Stats stats;
5005 stats.avg_encode_time_ms = 13;
5006 stats.encode_usage_percent = 42;
5007 stream->SetStats(stats);
5008
5009 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005010 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005011 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
5012 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
5013}
5014
eladalonf1841382017-06-12 01:16:46 -07005015TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07005016 FakeVideoSendStream* stream = AddSendStream();
5017 webrtc::VideoSendStream::Stats stats;
5018 stats.frames_encoded = 13;
5019 stream->SetStats(stats);
5020
5021 cricket::VideoMediaInfo info;
5022 ASSERT_TRUE(channel_->GetStats(&info));
5023 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
5024}
5025
Rasmus Brandt2efae772019-06-27 14:29:34 +02005026TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
5027 FakeVideoSendStream* stream = AddSendStream();
5028 webrtc::VideoSendStream::Stats stats;
5029 stats.substreams[123].frame_counts.key_frames = 10;
5030 stats.substreams[456].frame_counts.key_frames = 87;
5031 stream->SetStats(stats);
5032
5033 cricket::VideoMediaInfo info;
5034 ASSERT_TRUE(channel_->GetStats(&info));
5035 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
5036 // for each simulcast stream, instead of accumulating all keyframes encoded
5037 // over all simulcast streams in the same outbound-rtp stats object.
5038 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
5039}
5040
eladalonf1841382017-06-12 01:16:46 -07005041TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07005042 FakeVideoSendStream* stream = AddSendStream();
5043 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01005044 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07005045 stream->SetStats(stats);
5046
5047 cricket::VideoMediaInfo info;
5048 ASSERT_TRUE(channel_->GetStats(&info));
5049 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5050}
5051
eladalonf1841382017-06-12 01:16:46 -07005052TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005053 FakeVideoSendStream* stream = AddSendStream();
5054 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005055 stats.substreams[17].width = 123;
5056 stats.substreams[17].height = 40;
5057 stats.substreams[42].width = 80;
5058 stats.substreams[42].height = 31;
5059 stats.substreams[11].width = 20;
5060 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005061 stream->SetStats(stats);
5062
5063 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005064 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005065 ASSERT_EQ(1u, info.senders.size());
5066 EXPECT_EQ(123, info.senders[0].send_frame_width);
5067 EXPECT_EQ(90, info.senders[0].send_frame_height);
5068}
5069
eladalonf1841382017-06-12 01:16:46 -07005070TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005071 FakeVideoSendStream* stream = AddSendStream();
5072 webrtc::VideoSendStream::Stats stats;
5073 stats.number_of_cpu_adapt_changes = 2;
5074 stats.cpu_limited_resolution = true;
5075 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005076
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005077 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005078 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005079 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005080 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005081 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005082}
5083
eladalonf1841382017-06-12 01:16:46 -07005084TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005085 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005086 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005087 stats.number_of_cpu_adapt_changes = 2;
5088 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005089 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005090 stream->SetStats(stats);
5091
5092 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005093 EXPECT_TRUE(channel_->GetStats(&info));
5094 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005095 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5096 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005097 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005098 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005099}
5100
eladalonf1841382017-06-12 01:16:46 -07005101TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005102 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5103 FakeVideoSendStream* stream = AddSendStream();
5104 webrtc::VideoSendStream::Stats stats;
5105 stats.bw_limited_resolution = true;
5106 stream->SetStats(stats);
5107
5108 cricket::VideoMediaInfo info;
5109 EXPECT_TRUE(channel_->GetStats(&info));
5110 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005111 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005112 info.senders[0].adapt_reason);
5113}
5114
Yves Gerey665174f2018-06-19 15:03:05 +02005115TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005116 FakeVideoSendStream* stream = AddSendStream();
5117 webrtc::VideoSendStream::Stats stats;
5118 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5119 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5120 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5121
5122 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5123 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5124 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5125
5126 stream->SetStats(stats);
5127
5128 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005129 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005130 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5131 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5132 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5133}
5134
eladalonf1841382017-06-12 01:16:46 -07005135TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005136 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5137 FakeVideoReceiveStream* stream = AddRecvStream();
5138 webrtc::VideoReceiveStream::Stats stats;
5139 stats.rtcp_packet_type_counts.fir_packets = 2;
5140 stats.rtcp_packet_type_counts.nack_packets = 3;
5141 stats.rtcp_packet_type_counts.pli_packets = 4;
5142 stream->SetStats(stats);
5143
5144 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005145 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005146 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005147 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005148 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005149 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005150 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005151 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005152}
5153
eladalonf1841382017-06-12 01:16:46 -07005154TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005155 FakeVideoReceiveStream* stream = AddRecvStream();
5156 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005157 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005158 stats.decode_ms = 2;
5159 stats.max_decode_ms = 3;
5160 stats.current_delay_ms = 4;
5161 stats.target_delay_ms = 5;
5162 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005163 stats.jitter_buffer_delay_seconds = 60;
5164 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005165 stats.min_playout_delay_ms = 7;
5166 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005167 stats.width = 9;
5168 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005169 stats.frame_counts.key_frames = 11;
5170 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005171 stats.frames_rendered = 13;
5172 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005173 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005174 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005175 stream->SetStats(stats);
5176
5177 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005178 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005179 EXPECT_EQ(stats.decoder_implementation_name,
5180 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005181 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5182 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5183 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5184 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5185 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005186 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5187 info.receivers[0].jitter_buffer_delay_seconds);
5188 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5189 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005190 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5191 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005192 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5193 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005194 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5195 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005196 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005197 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005198 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005199 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5200 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005201 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005202 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005203}
5204
eladalonf1841382017-06-12 01:16:46 -07005205TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07005206 webrtc::test::ScopedFieldTrials field_trials(
5207 "WebRTC-UseStandardBytesStats/Enabled/");
5208
Peter Boström393347f2015-04-22 14:52:45 +02005209 FakeVideoReceiveStream* stream = AddRecvStream();
5210 webrtc::VideoReceiveStream::Stats stats;
Niels Möllerd77cc242019-08-22 09:40:25 +02005211 stats.rtp_stats.packet_counter.payload_bytes = 2;
5212 stats.rtp_stats.packet_counter.header_bytes = 3;
5213 stats.rtp_stats.packet_counter.padding_bytes = 4;
5214 stats.rtp_stats.packet_counter.packets = 5;
5215 stats.rtp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005216 stream->SetStats(stats);
5217
5218 cricket::VideoMediaInfo info;
5219 ASSERT_TRUE(channel_->GetStats(&info));
Niels Möllerd77cc242019-08-22 09:40:25 +02005220 EXPECT_EQ(stats.rtp_stats.packet_counter.payload_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005221 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Niels Möllerd77cc242019-08-22 09:40:25 +02005222 EXPECT_EQ(stats.rtp_stats.packet_counter.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005223 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
Niels Möllerd77cc242019-08-22 09:40:25 +02005224 EXPECT_EQ(stats.rtp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005225}
5226
eladalonf1841382017-06-12 01:16:46 -07005227TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005228 AddSendStream();
5229 AddSendStream();
5230 webrtc::Call::Stats stats;
5231 stats.rtt_ms = 123;
5232 fake_call_->SetStats(stats);
5233
5234 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005235 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005236 ASSERT_EQ(2u, info.senders.size());
5237 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5238 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5239}
5240
eladalonf1841382017-06-12 01:16:46 -07005241TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005242 FakeVideoSendStream* stream = AddSendStream();
5243 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005244 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005245 stats.media_bitrate_bps = 123;
5246 stats.substreams[17].total_bitrate_bps = 1;
5247 stats.substreams[17].retransmit_bitrate_bps = 2;
5248 stats.substreams[42].total_bitrate_bps = 3;
5249 stats.substreams[42].retransmit_bitrate_bps = 4;
5250 stream->SetStats(stats);
5251
5252 FakeVideoSendStream* stream2 = AddSendStream();
5253 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005254 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005255 stats2.media_bitrate_bps = 321;
5256 stats2.substreams[13].total_bitrate_bps = 5;
5257 stats2.substreams[13].retransmit_bitrate_bps = 6;
5258 stats2.substreams[21].total_bitrate_bps = 7;
5259 stats2.substreams[21].retransmit_bitrate_bps = 8;
5260 stream2->SetStats(stats2);
5261
5262 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005263 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005264 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005265 BandwidthEstimationInfo bwe_info;
5266 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005267 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5268 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5269 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5270 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005271 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005272 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005273 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005274 bwe_info.actual_enc_bitrate);
5275 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005276 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005277 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005278 << "Bandwidth stats should take all streams into account.";
5279}
5280
eladalonf1841382017-06-12 01:16:46 -07005281TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005282 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005283
Peter Boström0c4e06b2015-10-07 12:23:21 +02005284 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5285 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005286
5287 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5288 const size_t kDataLength = 12;
5289 uint8_t data[kDataLength];
5290 memset(data, 0, sizeof(data));
5291 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005292 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005293 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005294
5295 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5296 << "No default receive stream created.";
5297 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005298 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005299 << "Default receive stream should not have configured RTX";
5300
5301 EXPECT_TRUE(channel_->AddRecvStream(
5302 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5303 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005304 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005305 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005306 EXPECT_FALSE(
5307 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005308 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005309 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005310 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005311 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005312 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005313 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005314}
5315
eladalonf1841382017-06-12 01:16:46 -07005316TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005317 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005318
Peter Boström0c4e06b2015-10-07 12:23:21 +02005319 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5320 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005321
5322 StreamParams sp =
5323 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5324 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5325
5326 EXPECT_FALSE(channel_->AddSendStream(sp));
5327 EXPECT_FALSE(channel_->AddRecvStream(sp));
5328}
5329
eladalonf1841382017-06-12 01:16:46 -07005330TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005331 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005332
Peter Boström0c4e06b2015-10-07 12:23:21 +02005333 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5334 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005335
5336 StreamParams sp =
5337 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5338
5339 EXPECT_TRUE(channel_->AddSendStream(sp));
5340 EXPECT_TRUE(channel_->AddRecvStream(sp));
5341
5342 // The RTX SSRC is already used in previous streams, using it should fail.
5343 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5344 EXPECT_FALSE(channel_->AddSendStream(sp));
5345 EXPECT_FALSE(channel_->AddRecvStream(sp));
5346
5347 // After removing the original stream this should be fine to add (makes sure
5348 // that RTX ssrcs are not forever taken).
5349 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5350 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5351 EXPECT_TRUE(channel_->AddSendStream(sp));
5352 EXPECT_TRUE(channel_->AddRecvStream(sp));
5353}
5354
eladalonf1841382017-06-12 01:16:46 -07005355TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005356 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005357 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5358 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005359 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005360
Peter Boströmd6f4c252015-03-26 16:23:04 +01005361 StreamParams sp =
5362 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5363
5364 EXPECT_TRUE(channel_->AddSendStream(sp));
5365 EXPECT_TRUE(channel_->AddRecvStream(sp));
5366
5367 // One of the SSRCs is already used in previous streams, using it should fail.
5368 sp = cricket::CreateSimStreamParams("cname",
5369 MAKE_VECTOR(kOverlappingStreamSsrcs));
5370 EXPECT_FALSE(channel_->AddSendStream(sp));
5371 EXPECT_FALSE(channel_->AddRecvStream(sp));
5372
5373 // After removing the original stream this should be fine to add (makes sure
5374 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005375 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5376 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005377 EXPECT_TRUE(channel_->AddSendStream(sp));
5378 EXPECT_TRUE(channel_->AddRecvStream(sp));
5379}
5380
eladalonf1841382017-06-12 01:16:46 -07005381TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005382 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005383
5384 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5385 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5386
5387 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5388 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5389
5390 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5391
5392 static const uint32_t kReceiverSsrcs[] = {3};
5393 static const uint32_t kReceiverRtxSsrcs[] = {2};
5394
5395 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5396 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5397 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5398
5399 cricket::VideoMediaInfo info;
5400 ASSERT_TRUE(channel_->GetStats(&info));
5401
5402 ASSERT_EQ(1u, info.senders.size());
5403 ASSERT_EQ(1u, info.receivers.size());
5404
5405 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5406 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5407 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5408}
5409
eladalonf1841382017-06-12 01:16:46 -07005410TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005411 FakeVideoReceiveStream* stream = AddRecvStream();
5412 webrtc::VideoReceiveStream::Stats stats;
5413 cricket::VideoMediaInfo info;
5414
5415 // Report no codec name before receiving.
5416 stream->SetStats(stats);
5417 ASSERT_TRUE(channel_->GetStats(&info));
5418 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5419
5420 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005421 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005422 stream->SetStats(stats);
5423 ASSERT_TRUE(channel_->GetStats(&info));
5424 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5425
5426 // Report no codec name for unknown playload types.
5427 stats.current_payload_type = 3;
5428 stream->SetStats(stats);
5429 ASSERT_TRUE(channel_->GetStats(&info));
5430 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5431}
5432
Seth Hampson5897a6e2018-04-03 11:16:33 -07005433// Tests that when we add a stream without SSRCs, but contains a stream_id
5434// that it is stored and its stream id is later used when the first packet
5435// arrives to properly create a receive stream with a sync label.
5436TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5437 const char kSyncLabel[] = "sync_label";
5438 cricket::StreamParams unsignaled_stream;
5439 unsignaled_stream.set_stream_ids({kSyncLabel});
5440 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5441 // The stream shouldn't have been created at this point because it doesn't
5442 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005443 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005444
5445 // Create and deliver packet.
5446 const size_t kDataLength = 12;
5447 uint8_t data[kDataLength];
5448 memset(data, 0, sizeof(data));
5449 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5450 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005451 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005452
5453 // The stream should now be created with the appropriate sync label.
5454 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5455 EXPECT_EQ(kSyncLabel,
5456 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5457
5458 // Removing the unsignaled stream should clear the cache. This time when
5459 // a default video receive stream is created it won't have a sync_group.
5460 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5461 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5462 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5463
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005464 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005465 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5466 EXPECT_TRUE(
5467 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5468}
5469
Ruslan Burakov493a6502019-02-27 15:32:48 +01005470// Test BaseMinimumPlayoutDelayMs on receive streams.
5471TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5472 // Test that set won't work for non-existing receive streams.
5473 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5474 // Test that get won't work for non-existing receive streams.
5475 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5476
5477 EXPECT_TRUE(AddRecvStream());
5478 // Test that set works for the existing receive stream.
5479 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5480 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5481 EXPECT_TRUE(recv_stream);
5482 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5483 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5484 200);
5485}
5486
5487// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5488TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5489 absl::optional<int> delay_ms;
5490 const FakeVideoReceiveStream* recv_stream;
5491
5492 // Set default stream with SSRC 0
5493 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5494 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5495
5496 // Spawn an unsignaled stream by sending a packet, it should inherit
5497 // default delay 200.
5498 const size_t kDataLength = 12;
5499 uint8_t data[kDataLength];
5500 memset(data, 0, sizeof(data));
5501 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5502 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005503 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005504
5505 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5506 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5507 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5508 EXPECT_EQ(200, delay_ms.value_or(0));
5509
5510 // Check that now if we change delay for SSRC 0 it will change delay for the
5511 // default receiving stream as well.
5512 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5513 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5514 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5515 EXPECT_EQ(300, delay_ms.value_or(0));
5516 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5517 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5518}
5519
eladalonf1841382017-06-12 01:16:46 -07005520void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005521 uint8_t payload_type,
5522 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005523 // kRedRtxPayloadType must currently be unused.
5524 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5525
noahricd10a68e2015-07-10 11:27:55 -07005526 // Add a RED RTX codec.
5527 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005528 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005529 recv_parameters_.codecs.push_back(red_rtx_codec);
5530 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005531
5532 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5533 const size_t kDataLength = 12;
5534 uint8_t data[kDataLength];
5535 memset(data, 0, sizeof(data));
5536
5537 rtc::Set8(data, 1, payload_type);
5538 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005539 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005540 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005541
5542 if (expect_created_receive_stream) {
5543 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5544 << "Should have created a receive stream for payload type: "
5545 << payload_type;
5546 } else {
5547 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5548 << "Shouldn't have created a receive stream for payload type: "
5549 << payload_type;
5550 }
5551}
5552
Åsa Persson2c7149b2018-10-15 09:36:10 +02005553class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5554 public:
5555 WebRtcVideoChannelDiscardUnknownSsrcTest()
5556 : WebRtcVideoChannelTest(
5557 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5558};
5559
5560TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5561 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5562 false /* expect_created_receive_stream */);
5563}
5564
eladalonf1841382017-06-12 01:16:46 -07005565TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005566 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5567 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005568}
5569
eladalonf1841382017-06-12 01:16:46 -07005570TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005571 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5572 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005573}
5574
eladalonf1841382017-06-12 01:16:46 -07005575TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005576 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005577 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5578 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5579 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5580 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005581}
5582
eladalonf1841382017-06-12 01:16:46 -07005583TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005584 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5585 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005586}
5587
eladalonf1841382017-06-12 01:16:46 -07005588TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005589 FlexfecPacketDoesntCreateUnsignalledStream) {
5590 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5591 false /* expect_created_receive_stream */);
5592}
5593
eladalonf1841382017-06-12 01:16:46 -07005594TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005595 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5596 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005597}
5598
mzanaty8a855d62017-02-17 15:46:43 -08005599// Test that receiving any unsignalled SSRC works even if it changes.
5600// The first unsignalled SSRC received will create a default receive stream.
5601// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005602TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005603 // Allow receiving VP8, VP9, H264 (if enabled).
5604 cricket::VideoRecvParameters parameters;
5605 parameters.codecs.push_back(GetEngineCodec("VP8"));
5606 parameters.codecs.push_back(GetEngineCodec("VP9"));
5607
5608#if defined(WEBRTC_USE_H264)
5609 cricket::VideoCodec H264codec(126, "H264");
5610 parameters.codecs.push_back(H264codec);
5611#endif
5612
5613 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5614 // No receive streams yet.
5615 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5616 cricket::FakeVideoRenderer renderer;
5617 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5618
5619 // Receive VP8 packet on first SSRC.
5620 uint8_t data[kMinRtpPacketLen];
5621 cricket::RtpHeader rtpHeader;
5622 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5623 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005624 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005625 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5626 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005627 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005628 // VP8 packet should create default receive stream.
5629 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005630 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005631 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5632 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005633 webrtc::VideoFrame video_frame =
5634 webrtc::VideoFrame::Builder()
5635 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5636 .set_timestamp_rtp(100)
5637 .set_timestamp_us(0)
5638 .set_rotation(webrtc::kVideoRotation_0)
5639 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005640 recv_stream->InjectFrame(video_frame);
5641 EXPECT_EQ(1, renderer.num_rendered_frames());
5642
5643 // Receive VP9 packet on second SSRC.
5644 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005645 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005646 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5647 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005648 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005649 // VP9 packet should replace the default receive SSRC.
5650 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5651 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5652 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5653 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005654 webrtc::VideoFrame video_frame2 =
5655 webrtc::VideoFrame::Builder()
5656 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5657 .set_timestamp_rtp(200)
5658 .set_timestamp_us(0)
5659 .set_rotation(webrtc::kVideoRotation_0)
5660 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005661 recv_stream->InjectFrame(video_frame2);
5662 EXPECT_EQ(2, renderer.num_rendered_frames());
5663
5664#if defined(WEBRTC_USE_H264)
5665 // Receive H264 packet on third SSRC.
5666 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005667 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005668 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5669 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005670 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005671 // H264 packet should replace the default receive SSRC.
5672 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5673 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5674 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5675 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005676 webrtc::VideoFrame video_frame3 =
5677 webrtc::VideoFrame::Builder()
5678 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5679 .set_timestamp_rtp(300)
5680 .set_timestamp_us(0)
5681 .set_rotation(webrtc::kVideoRotation_0)
5682 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005683 recv_stream->InjectFrame(video_frame3);
5684 EXPECT_EQ(3, renderer.num_rendered_frames());
5685#endif
5686}
5687
brandtr0dc57ea2017-05-29 23:33:31 -07005688// This test verifies that when a new default stream is created for a new
5689// unsignaled SSRC, the new stream does not overwrite any old stream that had
5690// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005691TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005692 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5693 cricket::VideoRecvParameters parameters;
5694 parameters.codecs.push_back(GetEngineCodec("VP8"));
5695 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5696
5697 // No streams signaled and no packets received, so we should not have any
5698 // stream objects created yet.
5699 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5700
5701 // Receive packet on an unsignaled SSRC.
5702 uint8_t data[kMinRtpPacketLen];
5703 cricket::RtpHeader rtp_header;
5704 rtp_header.payload_type = GetEngineCodec("VP8").id;
5705 rtp_header.seq_num = rtp_header.timestamp = 0;
5706 rtp_header.ssrc = kSsrcs3[0];
5707 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5708 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005709 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005710 // Default receive stream should be created.
5711 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5712 FakeVideoReceiveStream* recv_stream0 =
5713 fake_call_->GetVideoReceiveStreams()[0];
5714 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5715
5716 // Signal the SSRC.
5717 EXPECT_TRUE(
5718 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5719 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5720 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5721 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5722
5723 // Receive packet on a different unsignaled SSRC.
5724 rtp_header.ssrc = kSsrcs3[1];
5725 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5726 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005727 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005728 // New default receive stream should be created, but old stream should remain.
5729 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5730 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5731 FakeVideoReceiveStream* recv_stream1 =
5732 fake_call_->GetVideoReceiveStreams()[1];
5733 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5734}
5735
Seth Hampson7c682e02018-05-04 16:28:15 -07005736TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005737 AddSendStream();
5738
Niels Möller805a27e2019-01-21 12:21:27 +01005739 webrtc::test::FrameForwarder frame_forwarder;
5740 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005741 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005742 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005743
perkjfa10b552016-10-02 23:45:26 -07005744 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005745 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005746
5747 // TODO(skvlad): Resolve the inconsistency between the interpretation
5748 // of the global bitrate limit for audio and video:
5749 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5750 // max_bandwidth_bps = -1 - remove the bandwidth limit
5751 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005752 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005753
perkjfa10b552016-10-02 23:45:26 -07005754 SetAndExpectMaxBitrate(1000, 0, 1000);
5755 SetAndExpectMaxBitrate(1000, 800, 800);
5756 SetAndExpectMaxBitrate(600, 800, 600);
5757 SetAndExpectMaxBitrate(0, 800, 800);
5758 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005759
Niels Möllerff40b142018-04-09 08:49:14 +02005760 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005761}
5762
eladalonf1841382017-06-12 01:16:46 -07005763TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005764 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005765 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005766 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005767
5768 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005769 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005770 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005771}
5772
eladalonf1841382017-06-12 01:16:46 -07005773TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005774 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005775 FakeVideoSendStream* stream = AddSendStream();
5776
Seth Hampson7c682e02018-05-04 16:28:15 -07005777 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5778 EXPECT_EQ(1UL, parameters.encodings.size());
5779 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5780 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5781
5782 // Note that this is testing the behavior of the FakeVideoSendStream, which
5783 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5784 // we are just testing the behavior of
5785 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005786 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5787 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005788
5789 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5790 // by this amount.
5791 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5792 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5793 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5794 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5795
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005796 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5797 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5798 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5799}
5800
5801TEST_F(WebRtcVideoChannelTest,
5802 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5803 FakeVideoSendStream* stream = AddSendStream();
5804
5805 // Note that this is testing the behavior of the FakeVideoSendStream, which
5806 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5807 // we are just testing the behavior of
5808 // EncoderStreamFactory::CreateEncoderStreams.
5809 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5810 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5811
5812 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5813 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5814 EXPECT_EQ(1UL, parameters.encodings.size());
5815 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5816 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5817
5818 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5819 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5820 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5821}
5822
5823TEST_F(WebRtcVideoChannelTest,
5824 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5825 send_parameters_.max_bandwidth_bps = 99999;
5826 FakeVideoSendStream* stream = AddSendStream();
5827 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5828 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5829 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5830 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5831 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5832 stream->GetVideoStreams()[0].max_bitrate_bps);
5833
5834 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5835 // adjusted down.
5836 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5837 EXPECT_EQ(1UL, parameters.encodings.size());
5838 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5839 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5840 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5841 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5842 stream->GetVideoStreams()[0].min_bitrate_bps);
5843 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5844 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005845}
5846
Åsa Persson8c1bf952018-09-13 10:42:19 +02005847TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5848 FakeVideoSendStream* stream = AddSendStream();
5849
5850 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5851 EXPECT_EQ(1UL, parameters.encodings.size());
5852 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5853 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5854
5855 // Note that this is testing the behavior of the FakeVideoSendStream, which
5856 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5857 // we are just testing the behavior of
5858 // EncoderStreamFactory::CreateEncoderStreams.
5859 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5860 EXPECT_EQ(kDefaultVideoMaxFramerate,
5861 stream->GetVideoStreams()[0].max_framerate);
5862
5863 // Set max framerate and check that VideoStream.max_framerate is set.
5864 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5865 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5866 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5867 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5868
5869 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5870 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5871}
5872
Åsa Persson23eba222018-10-02 14:47:06 +02005873TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5874 FakeVideoSendStream* stream = AddSendStream();
5875
5876 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5877 EXPECT_EQ(1UL, parameters.encodings.size());
5878 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5879 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5880
5881 // Note that this is testing the behavior of the FakeVideoSendStream, which
5882 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5883 // we are just testing the behavior of
5884 // EncoderStreamFactory::CreateEncoderStreams.
5885 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5886 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5887
5888 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5889 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5890 parameters.encodings[0].num_temporal_layers = 2;
5891 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5892
5893 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5894 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5895}
5896
Seth Hampson7c682e02018-05-04 16:28:15 -07005897TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005898 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005899 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005900 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005901 // Two or more encodings should result in failure.
5902 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005903 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005904 // Zero encodings should also fail.
5905 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005906 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005907}
5908
Zach Stein3ca452b2018-01-18 10:01:24 -08005909TEST_F(WebRtcVideoChannelTest,
5910 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5911 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5912 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5913 AddSendStream(sp);
5914
5915 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5916
5917 // Additional encodings should result in failure.
5918 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005919 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005920 // Zero encodings should also fail.
5921 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005922 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005923}
5924
deadbeeffb2aced2017-01-06 23:05:37 -08005925// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005926TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005927 AddSendStream();
5928 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005929 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005930 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005931}
5932
Seth Hampson24722b32017-12-22 09:36:42 -08005933// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5934// a value <= 0, setting the parameters returns false.
5935TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5936 AddSendStream();
5937 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5938 EXPECT_EQ(1UL, parameters.encodings.size());
5939 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5940 parameters.encodings[0].bitrate_priority);
5941
5942 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005943 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005944 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005945 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005946}
5947
5948// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5949// properly on the VideoChannel and propogates down to the video encoder.
5950TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5951 AddSendStream();
5952 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5953 EXPECT_EQ(1UL, parameters.encodings.size());
5954 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5955 parameters.encodings[0].bitrate_priority);
5956
5957 // Change the value and set it on the VideoChannel.
5958 double new_bitrate_priority = 2.0;
5959 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005960 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005961
5962 // Verify that the encoding parameters bitrate_priority is set for the
5963 // VideoChannel.
5964 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5965 EXPECT_EQ(1UL, parameters.encodings.size());
5966 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5967
5968 // Verify that the new value propagated down to the encoder.
5969 std::vector<FakeVideoSendStream*> video_send_streams =
5970 fake_call_->GetVideoSendStreams();
5971 EXPECT_EQ(1UL, video_send_streams.size());
5972 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5973 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5974 // appropriately.
5975 EXPECT_EQ(new_bitrate_priority,
5976 video_send_stream->GetEncoderConfig().bitrate_priority);
5977 // Check that the vector of VideoStreams also was propagated correctly. Note
5978 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5979 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005980 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005981 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5982}
5983
5984// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5985// VideoChannel and the value propogates to the video encoder with all simulcast
5986// streams.
5987TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5988 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005989 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005990 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5991 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5992 AddSendStream(stream_params);
5993 uint32_t primary_ssrc = stream_params.first_ssrc();
5994
Niels Möller805a27e2019-01-21 12:21:27 +01005995 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005996 // frame. This creates multiple VideoStreams for all simulcast layers when
5997 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005998 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005999 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006000 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08006001 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006002 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6003 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6004 rtc::kNumMicrosecsPerSec / 30));
6005
Seth Hampson24722b32017-12-22 09:36:42 -08006006 // Get and set the rtp encoding parameters.
6007 webrtc::RtpParameters parameters =
6008 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006009 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006010 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6011 parameters.encodings[0].bitrate_priority);
6012 // Change the value and set it on the VideoChannel.
6013 double new_bitrate_priority = 2.0;
6014 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08006015 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006016
6017 // Verify that the encoding parameters priority is set on the VideoChannel.
6018 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006019 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006020 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
6021
6022 // Verify that the new value propagated down to the encoder.
6023 std::vector<FakeVideoSendStream*> video_send_streams =
6024 fake_call_->GetVideoSendStreams();
6025 EXPECT_EQ(1UL, video_send_streams.size());
6026 FakeVideoSendStream* video_send_stream = video_send_streams.front();
6027 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6028 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006029 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08006030 video_send_stream->GetEncoderConfig().number_of_streams);
6031 EXPECT_EQ(new_bitrate_priority,
6032 video_send_stream->GetEncoderConfig().bitrate_priority);
6033 // Check that the vector of VideoStreams also propagated correctly. The
6034 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
6035 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006036 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02006037 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006038 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6039 // Since we are only setting bitrate priority per-sender, the other
6040 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006041 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006042 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02006043 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006044 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02006045 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006046}
6047
Tim Haloun648d28a2018-10-18 16:52:22 -07006048// RTCRtpEncodingParameters.network_priority must be one of a few values
6049// derived from the default priority, corresponding to very-low, low, medium,
6050// or high.
6051TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6052 AddSendStream();
6053 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6054 EXPECT_EQ(1UL, parameters.encodings.size());
6055 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6056 parameters.encodings[0].network_priority);
6057
6058 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6059 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6060 for (auto it : good_values) {
6061 parameters.encodings[0].network_priority = it;
6062 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6063 }
6064 for (auto it : bad_values) {
6065 parameters.encodings[0].network_priority = it;
6066 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6067 }
6068}
6069
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006070TEST_F(WebRtcVideoChannelTest,
6071 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006072 VideoSendParameters parameters;
6073 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006074 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6075 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6076
6077 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006078 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006079
6080 VideoOptions options;
6081 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6082 channel_->SetSend(true);
6083
6084 // Try layers in natural order (smallest to largest).
6085 {
6086 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6087 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6088 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6089 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6090 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6091 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6092 ASSERT_TRUE(result.ok());
6093
6094 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6095
6096 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6097 ASSERT_EQ(3u, video_streams.size());
6098 EXPECT_EQ(320u, video_streams[0].width);
6099 EXPECT_EQ(180u, video_streams[0].height);
6100 EXPECT_EQ(640u, video_streams[1].width);
6101 EXPECT_EQ(360u, video_streams[1].height);
6102 EXPECT_EQ(1280u, video_streams[2].width);
6103 EXPECT_EQ(720u, video_streams[2].height);
6104 }
6105
6106 // Try layers in reverse natural order (largest to smallest).
6107 {
6108 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6109 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6110 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6111 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6112 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6113 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6114 ASSERT_TRUE(result.ok());
6115
6116 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6117
6118 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6119 ASSERT_EQ(3u, video_streams.size());
6120 EXPECT_EQ(1280u, video_streams[0].width);
6121 EXPECT_EQ(720u, video_streams[0].height);
6122 EXPECT_EQ(640u, video_streams[1].width);
6123 EXPECT_EQ(360u, video_streams[1].height);
6124 EXPECT_EQ(320u, video_streams[2].width);
6125 EXPECT_EQ(180u, video_streams[2].height);
6126 }
6127
6128 // Try layers in mixed order.
6129 {
6130 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6131 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6132 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6133 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6134 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6135 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6136 ASSERT_TRUE(result.ok());
6137
6138 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6139
6140 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6141 ASSERT_EQ(3u, video_streams.size());
6142 EXPECT_EQ(128u, video_streams[0].width);
6143 EXPECT_EQ(72u, video_streams[0].height);
6144 EXPECT_EQ(640u, video_streams[1].width);
6145 EXPECT_EQ(360u, video_streams[1].height);
6146 EXPECT_EQ(320u, video_streams[2].width);
6147 EXPECT_EQ(180u, video_streams[2].height);
6148 }
6149
6150 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6151 {
6152 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6153 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6154 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6155 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6156 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6157 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6158 ASSERT_TRUE(result.ok());
6159
6160 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6161
6162 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6163 ASSERT_EQ(3u, video_streams.size());
6164 EXPECT_EQ(1280u, video_streams[0].width);
6165 EXPECT_EQ(720u, video_streams[0].height);
6166 EXPECT_EQ(1280u, video_streams[1].width);
6167 EXPECT_EQ(720u, video_streams[1].height);
6168 EXPECT_EQ(320u, video_streams[2].width);
6169 EXPECT_EQ(180u, video_streams[2].height);
6170 }
6171
6172 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6173}
6174
6175TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006176 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6177 // Ensure that the top layer has width and height divisible by 2^3,
6178 // so that the bottom layer has width and height divisible by 2.
6179 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6180 // the number of simulcast layers set by the app.
6181 webrtc::test::ScopedFieldTrials field_trial(
6182 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6183
6184 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6185 VideoSendParameters parameters;
6186 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6187 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6188 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6189 webrtc::test::FrameForwarder frame_forwarder;
6190 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6191 &frame_forwarder));
6192 channel_->SetSend(true);
6193
6194 // Set |scale_resolution_down_by|'s.
6195 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6196 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6197 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6198 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6199 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6200 const auto result =
6201 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6202 ASSERT_TRUE(result.ok());
6203
6204 // Use a capture resolution whose width and height are not divisible by 2^3.
6205 // (See field trial set at the top of the test.)
6206 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6207 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6208
6209 // Ensure the scaling is correct.
6210 const auto video_streams = stream->GetVideoStreams();
6211 ASSERT_EQ(video_streams.size(), 3u);
6212 // Ensure that we round the capture resolution down for the top layer...
6213 EXPECT_EQ(video_streams[0].width, 2000u);
6214 EXPECT_EQ(video_streams[0].height, 1200u);
6215 EXPECT_EQ(video_streams[1].width, 1000u);
6216 EXPECT_EQ(video_streams[1].height, 600u);
6217 // ...and that the bottom layer has a width/height divisible by 2.
6218 EXPECT_EQ(video_streams[2].width, 500u);
6219 EXPECT_EQ(video_streams[2].height, 300u);
6220
6221 // Tear down.
6222 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6223}
6224
6225TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006226 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006227 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6228 VideoSendParameters parameters;
6229 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006230 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6231 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6232
6233 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006234 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006235
6236 VideoOptions options;
6237 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6238 channel_->SetSend(true);
6239
6240 // Try layers in natural order (smallest to largest).
6241 {
6242 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6243 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6244 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6245 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6246 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6247 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6248 ASSERT_TRUE(result.ok());
6249
6250 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6251
6252 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6253 ASSERT_EQ(3u, video_streams.size());
6254 EXPECT_EQ(320u, video_streams[0].width);
6255 EXPECT_EQ(180u, video_streams[0].height);
6256 EXPECT_EQ(640u, video_streams[1].width);
6257 EXPECT_EQ(360u, video_streams[1].height);
6258 EXPECT_EQ(1280u, video_streams[2].width);
6259 EXPECT_EQ(720u, video_streams[2].height);
6260 }
6261
6262 // Try layers in reverse natural order (largest to smallest).
6263 {
6264 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6265 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6266 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6267 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6268 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6269 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6270 ASSERT_TRUE(result.ok());
6271
6272 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6273
6274 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6275 ASSERT_EQ(3u, video_streams.size());
6276 EXPECT_EQ(1280u, video_streams[0].width);
6277 EXPECT_EQ(720u, video_streams[0].height);
6278 EXPECT_EQ(640u, video_streams[1].width);
6279 EXPECT_EQ(360u, video_streams[1].height);
6280 EXPECT_EQ(320u, video_streams[2].width);
6281 EXPECT_EQ(180u, video_streams[2].height);
6282 }
6283
6284 // Try layers in mixed order.
6285 {
6286 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6287 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6288 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6289 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6290 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6291 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6292 ASSERT_TRUE(result.ok());
6293
6294 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6295
6296 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6297 ASSERT_EQ(3u, video_streams.size());
6298 EXPECT_EQ(128u, video_streams[0].width);
6299 EXPECT_EQ(72u, video_streams[0].height);
6300 EXPECT_EQ(640u, video_streams[1].width);
6301 EXPECT_EQ(360u, video_streams[1].height);
6302 EXPECT_EQ(320u, video_streams[2].width);
6303 EXPECT_EQ(180u, video_streams[2].height);
6304 }
6305
6306 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6307 {
6308 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6309 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6310 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6311 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6312 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6313 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6314 ASSERT_TRUE(result.ok());
6315
6316 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6317
6318 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6319 ASSERT_EQ(3u, video_streams.size());
6320 EXPECT_EQ(1280u, video_streams[0].width);
6321 EXPECT_EQ(720u, video_streams[0].height);
6322 EXPECT_EQ(1280u, video_streams[1].width);
6323 EXPECT_EQ(720u, video_streams[1].height);
6324 EXPECT_EQ(320u, video_streams[2].width);
6325 EXPECT_EQ(180u, video_streams[2].height);
6326 }
6327 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6328}
6329
Rasmus Brandt9387b522019-02-05 14:23:26 +01006330TEST_F(WebRtcVideoChannelTest,
6331 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6332 // Ensure that the top layer has width and height divisible by 2^3,
6333 // so that the bottom layer has width and height divisible by 2.
6334 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6335 // the number of simulcast layers set by the app.
6336 webrtc::test::ScopedFieldTrials field_trial(
6337 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6338
6339 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6340 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6341 VideoSendParameters parameters;
6342 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6343 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6344 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6345 webrtc::test::FrameForwarder frame_forwarder;
6346 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6347 &frame_forwarder));
6348 channel_->SetSend(true);
6349
6350 // Set |scale_resolution_down_by|'s.
6351 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6352 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6353 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6354 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6355 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6356 const auto result =
6357 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6358 ASSERT_TRUE(result.ok());
6359
6360 // Use a capture resolution whose width and height are not divisible by 2^3.
6361 // (See field trial set at the top of the test.)
6362 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6363 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6364
6365 // Ensure the scaling is correct.
6366 const auto video_streams = stream->GetVideoStreams();
6367 ASSERT_EQ(video_streams.size(), 3u);
6368 // Ensure that we round the capture resolution down for the top layer...
6369 EXPECT_EQ(video_streams[0].width, 2000u);
6370 EXPECT_EQ(video_streams[0].height, 1200u);
6371 EXPECT_EQ(video_streams[1].width, 1000u);
6372 EXPECT_EQ(video_streams[1].height, 600u);
6373 // ...and that the bottom layer has a width/height divisible by 2.
6374 EXPECT_EQ(video_streams[2].width, 500u);
6375 EXPECT_EQ(video_streams[2].height, 300u);
6376
6377 // Tear down.
6378 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6379}
6380
Åsa Persson8c1bf952018-09-13 10:42:19 +02006381TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6382 const size_t kNumSimulcastStreams = 3;
6383 SetUpSimulcast(true, false);
6384
6385 // Get and set the rtp encoding parameters.
6386 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6387 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6388 for (const auto& encoding : parameters.encodings) {
6389 EXPECT_FALSE(encoding.max_framerate);
6390 }
6391
6392 // Change the value and set it on the VideoChannel.
6393 parameters.encodings[0].max_framerate = 10;
6394 parameters.encodings[1].max_framerate = 20;
6395 parameters.encodings[2].max_framerate = 25;
6396 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6397
6398 // Verify that the bitrates are set on the VideoChannel.
6399 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6400 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6401 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6402 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6403 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6404}
6405
Åsa Persson23eba222018-10-02 14:47:06 +02006406TEST_F(WebRtcVideoChannelTest,
6407 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6408 const size_t kNumSimulcastStreams = 3;
6409 SetUpSimulcast(true, false);
6410
6411 // Get and set the rtp encoding parameters.
6412 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6413 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6414
6415 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6416 parameters.encodings[0].num_temporal_layers = 0;
6417 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6418 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6419 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6420 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6421 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6422}
6423
6424TEST_F(WebRtcVideoChannelTest,
6425 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6426 const size_t kNumSimulcastStreams = 3;
6427 SetUpSimulcast(true, false);
6428
6429 // Get and set the rtp encoding parameters.
6430 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6431 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6432
6433 // No/all layers should be set.
6434 parameters.encodings[0].num_temporal_layers = 1;
6435 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6436 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6437
6438 // Different values not supported.
6439 parameters.encodings[0].num_temporal_layers = 1;
6440 parameters.encodings[1].num_temporal_layers = 2;
6441 parameters.encodings[2].num_temporal_layers = 2;
6442 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6443 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6444}
6445
6446TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6447 const size_t kNumSimulcastStreams = 3;
6448 SetUpSimulcast(true, false);
6449
6450 // Get and set the rtp encoding parameters.
6451 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6452 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6453 for (const auto& encoding : parameters.encodings)
6454 EXPECT_FALSE(encoding.num_temporal_layers);
6455
6456 // Change the value and set it on the VideoChannel.
6457 parameters.encodings[0].num_temporal_layers = 3;
6458 parameters.encodings[1].num_temporal_layers = 3;
6459 parameters.encodings[2].num_temporal_layers = 3;
6460 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6461
6462 // Verify that the number of temporal layers are set on the VideoChannel.
6463 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6464 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6465 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6466 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6467 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6468}
6469
6470TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6471 const size_t kNumSimulcastStreams = 3;
6472 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6473
6474 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006475 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006476 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006477 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006478 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006479 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006480
6481 // Get and set the rtp encoding parameters.
6482 // Change the value and set it on the VideoChannel.
6483 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6484 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6485 parameters.encodings[0].num_temporal_layers = 2;
6486 parameters.encodings[1].num_temporal_layers = 2;
6487 parameters.encodings[2].num_temporal_layers = 2;
6488 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6489
6490 // Verify that the new value is propagated down to the encoder.
6491 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6492 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6493 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6494 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6495 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6496 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6497 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6498 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6499
6500 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6501 // VideoStreams are created appropriately for the simulcast case.
6502 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6503 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6504 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6505 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6506
6507 // No parameter changed, encoder should not be reconfigured.
6508 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6509 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6510
6511 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6512}
6513
6514TEST_F(WebRtcVideoChannelTest,
6515 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6516 const size_t kDefaultNumTemporalLayers = 3;
6517 const size_t kNumSimulcastStreams = 3;
6518 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6519
6520 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006521 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006522 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006523 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006524 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006525 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006526
6527 // Change rtp encoding parameters, num_temporal_layers not changed.
6528 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6529 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6530 parameters.encodings[0].min_bitrate_bps = 33000;
6531 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6532
6533 // Verify that no value is propagated down to the encoder.
6534 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6535 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6536 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6537 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6538 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6539 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6540
6541 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6542 // VideoStreams are created appropriately for the simulcast case.
6543 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6544 EXPECT_EQ(kDefaultNumTemporalLayers,
6545 stream->GetVideoStreams()[0].num_temporal_layers);
6546 EXPECT_EQ(kDefaultNumTemporalLayers,
6547 stream->GetVideoStreams()[1].num_temporal_layers);
6548 EXPECT_EQ(kDefaultNumTemporalLayers,
6549 stream->GetVideoStreams()[2].num_temporal_layers);
6550
6551 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6552}
6553
Åsa Persson8c1bf952018-09-13 10:42:19 +02006554TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6555 const size_t kNumSimulcastStreams = 3;
6556 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6557
6558 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006559 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006560 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006561 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006562 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006563 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006564
6565 // Get and set the rtp encoding parameters.
6566 // Change the value and set it on the VideoChannel.
6567 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6568 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6569 parameters.encodings[0].max_framerate = 15;
6570 parameters.encodings[1].max_framerate = 25;
6571 parameters.encodings[2].max_framerate = 20;
6572 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6573
6574 // Verify that the new value propagated down to the encoder.
6575 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6576 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6577 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6578 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6579 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6580 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6581 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6582 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6583
6584 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6585 // VideoStreams are created appropriately for the simulcast case.
6586 // Currently the maximum |max_framerate| is used.
6587 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6588 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6589 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6590 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6591
6592 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6593}
6594
6595TEST_F(WebRtcVideoChannelTest,
6596 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6597 const size_t kNumSimulcastStreams = 3;
6598 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6599 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6600
6601 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006602 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006603 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006604 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006605 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006606 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006607
6608 // Get and set the rtp encoding parameters.
6609 // Change the value and set it on the VideoChannel.
6610 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6611 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6612 parameters.encodings[0].max_framerate = 15;
6613 parameters.encodings[2].max_framerate = 20;
6614 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6615
6616 // Verify that the new value propagated down to the encoder.
6617 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6618 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6619 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6620 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6621 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6622 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6623 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6624
6625 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6626 // VideoStreams are created appropriately for the simulcast case.
6627 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6628 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6629 EXPECT_EQ(kDefaultVideoMaxFramerate,
6630 stream->GetVideoStreams()[0].max_framerate);
6631 EXPECT_EQ(kDefaultVideoMaxFramerate,
6632 stream->GetVideoStreams()[1].max_framerate);
6633 EXPECT_EQ(kDefaultVideoMaxFramerate,
6634 stream->GetVideoStreams()[2].max_framerate);
6635
6636 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6637}
6638
Åsa Persson55659812018-06-18 17:51:32 +02006639TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6640 const size_t kNumSimulcastStreams = 3;
6641 SetUpSimulcast(true, false);
6642
6643 // Get and set the rtp encoding parameters.
6644 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6645 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6646 for (const auto& encoding : parameters.encodings) {
6647 EXPECT_FALSE(encoding.min_bitrate_bps);
6648 EXPECT_FALSE(encoding.max_bitrate_bps);
6649 }
6650
6651 // Change the value and set it on the VideoChannel.
6652 parameters.encodings[0].min_bitrate_bps = 100000;
6653 parameters.encodings[0].max_bitrate_bps = 200000;
6654 parameters.encodings[1].min_bitrate_bps = 300000;
6655 parameters.encodings[1].max_bitrate_bps = 400000;
6656 parameters.encodings[2].min_bitrate_bps = 500000;
6657 parameters.encodings[2].max_bitrate_bps = 600000;
6658 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6659
6660 // Verify that the bitrates are set on the VideoChannel.
6661 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6662 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6663 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6664 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6665 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6666 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6667 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6668 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6669}
6670
6671TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6672 const size_t kNumSimulcastStreams = 3;
6673 SetUpSimulcast(true, false);
6674
6675 // Get and set the rtp encoding parameters.
6676 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6677 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6678
6679 // Max bitrate lower than min bitrate should fail.
6680 parameters.encodings[2].min_bitrate_bps = 100000;
6681 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6682 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6683 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6684}
6685
6686// Test that min and max bitrate values set via RtpParameters are correctly
6687// propagated to the underlying encoder, and that the target is set to 3/4 of
6688// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6689// that are used if no min/max are specified).
6690TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6691 const size_t kNumSimulcastStreams = 3;
6692 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6693
6694 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006695 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006696 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006697 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006698 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006699 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006700
6701 // Get and set the rtp encoding parameters.
6702 // Change the value and set it on the VideoChannel.
6703 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6704 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6705 parameters.encodings[0].min_bitrate_bps = 100000;
6706 parameters.encodings[0].max_bitrate_bps = 200000;
6707 parameters.encodings[1].min_bitrate_bps = 300000;
6708 parameters.encodings[1].max_bitrate_bps = 400000;
6709 parameters.encodings[2].min_bitrate_bps = 500000;
6710 parameters.encodings[2].max_bitrate_bps = 600000;
6711 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6712
6713 // Verify that the new value propagated down to the encoder.
6714 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6715 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6716 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6717 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6718 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6719 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6720 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6721 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6722 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6723 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6724 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6725
6726 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6727 // VideoStreams are created appropriately for the simulcast case.
6728 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6729 // Target bitrate: 200000 * 3 / 4 = 150000.
6730 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6731 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6732 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6733 // Target bitrate: 400000 * 3 / 4 = 300000.
6734 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6735 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6736 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6737 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6738 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6739 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6740 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6741
6742 // No parameter changed, encoder should not be reconfigured.
6743 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6744 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6745
6746 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6747}
6748
6749// Test to only specify the min or max bitrate value for a layer via
6750// RtpParameters. The unspecified min/max and target value should be set to the
6751// simulcast default that is used if no min/max are specified.
6752TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6753 const size_t kNumSimulcastStreams = 3;
6754 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6755 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6756
6757 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006758 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006759 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006760 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006761 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006762 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006763
6764 // Get and set the rtp encoding parameters.
6765 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6766 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6767
6768 // Change the value and set it on the VideoChannel.
6769 // Layer 0: only configure min bitrate.
6770 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6771 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6772 // Layer 1: only configure max bitrate.
6773 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6774 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6775 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6776
6777 // Verify that the new value propagated down to the encoder.
6778 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6779 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6780 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6781 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6782 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6783 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6784 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6785 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6786 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6787 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6788
6789 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6790 // VideoStreams are created appropriately for the simulcast case.
6791 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6792 // Layer 0: min configured bitrate should overwrite min default.
6793 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6794 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6795 stream->GetVideoStreams()[0].target_bitrate_bps);
6796 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6797 stream->GetVideoStreams()[0].max_bitrate_bps);
6798 // Layer 1: max configured bitrate should overwrite max default.
6799 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6800 stream->GetVideoStreams()[1].min_bitrate_bps);
6801 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6802 stream->GetVideoStreams()[1].target_bitrate_bps);
6803 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6804 // Layer 2: min and max bitrate not configured, default expected.
6805 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6806 stream->GetVideoStreams()[2].min_bitrate_bps);
6807 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6808 stream->GetVideoStreams()[2].target_bitrate_bps);
6809 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6810 stream->GetVideoStreams()[2].max_bitrate_bps);
6811
6812 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6813}
6814
6815// Test that specifying the min (or max) bitrate value for a layer via
6816// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6817// unspecified values accordingly.
6818TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6819 const size_t kNumSimulcastStreams = 3;
6820 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6821 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6822
6823 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006824 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006825 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006826 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006827 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006828 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006829
6830 // Get and set the rtp encoding parameters.
6831 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6832 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6833
6834 // Change the value and set it on the VideoChannel.
6835 // For layer 0, set the min bitrate above the default max.
6836 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6837 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6838 // For layer 1, set the max bitrate below the default min.
6839 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6840 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6841 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6842
6843 // Verify that the new value propagated down to the encoder.
6844 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6845 // VideoStreams are created appropriately for the simulcast case.
6846 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6847 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6848 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6849 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6850 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6851 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6852 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6853 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6854 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6855 // Layer 2: min and max bitrate not configured, default expected.
6856 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6857 stream->GetVideoStreams()[2].min_bitrate_bps);
6858 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6859 stream->GetVideoStreams()[2].target_bitrate_bps);
6860 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6861 stream->GetVideoStreams()[2].max_bitrate_bps);
6862
6863 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6864}
6865
6866TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6867 const size_t kNumSimulcastStreams = 3;
6868 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6869 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6870
6871 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006872 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006873 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006874 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006875 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006876 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006877
6878 // Set max bitrate for all but the highest layer.
6879 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6880 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6881 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6882 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6883 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6884
6885 // Set max bandwidth equal to total max bitrate.
6886 send_parameters_.max_bandwidth_bps =
6887 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6888 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6889 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6890
6891 // No bitrate above the total max to give to the highest layer.
6892 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6893 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6894 stream->GetVideoStreams()[2].max_bitrate_bps);
6895
6896 // Set max bandwidth above the total max bitrate.
6897 send_parameters_.max_bandwidth_bps =
6898 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6899 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6900 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6901
6902 // The highest layer has no max bitrate set -> the bitrate above the total
6903 // max should be given to the highest layer.
6904 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6905 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6906 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6907 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6908 stream->GetVideoStreams()[2].max_bitrate_bps);
6909
6910 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6911}
6912
6913TEST_F(WebRtcVideoChannelTest,
6914 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6915 const size_t kNumSimulcastStreams = 3;
6916 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6917 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6918 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6919
6920 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006921 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006922 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006923 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006924 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006925 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006926
6927 // Set max bitrate for the highest layer.
6928 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6929 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6930 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6931 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6932
6933 // Set max bandwidth above the total max bitrate.
6934 send_parameters_.max_bandwidth_bps =
6935 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6936 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6937 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6938
6939 // The highest layer has the max bitrate set -> the bitrate above the total
6940 // max should not be given to the highest layer.
6941 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6942 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6943 stream->GetVideoStreams()[2].max_bitrate_bps);
6944
6945 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6946}
6947
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006948// Test that min and max bitrate values set via RtpParameters are correctly
6949// propagated to the underlying encoder for a single stream.
6950TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6951 FakeVideoSendStream* stream = AddSendStream();
6952 EXPECT_TRUE(channel_->SetSend(true));
6953 EXPECT_TRUE(stream->IsSending());
6954
6955 // Set min and max bitrate.
6956 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6957 EXPECT_EQ(1u, parameters.encodings.size());
6958 parameters.encodings[0].min_bitrate_bps = 80000;
6959 parameters.encodings[0].max_bitrate_bps = 150000;
6960 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6961
6962 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6963 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6964 EXPECT_EQ(1u, encoder_config.number_of_streams);
6965 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6966 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6967 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6968
6969 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6970 // VideoStreams are created appropriately.
6971 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6972 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6973 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6974 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6975}
6976
6977// Test the default min and max bitrate value are correctly propagated to the
6978// underlying encoder for a single stream (when the values are not set via
6979// RtpParameters).
6980TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6981 FakeVideoSendStream* stream = AddSendStream();
6982 EXPECT_TRUE(channel_->SetSend(true));
6983 EXPECT_TRUE(stream->IsSending());
6984
6985 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6986 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6987 EXPECT_EQ(1u, encoder_config.number_of_streams);
6988 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6989 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6990 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6991
6992 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6993 // VideoStreams are created appropriately.
6994 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6995 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6996 stream->GetVideoStreams()[0].min_bitrate_bps);
6997 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6998 stream->GetVideoStreams()[0].min_bitrate_bps);
6999 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
7000 stream->GetVideoStreams()[0].target_bitrate_bps);
7001}
7002
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007003// Test that a stream will not be sending if its encoding is made inactive
7004// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08007005TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07007006 FakeVideoSendStream* stream = AddSendStream();
7007 EXPECT_TRUE(channel_->SetSend(true));
7008 EXPECT_TRUE(stream->IsSending());
7009
7010 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007011 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07007012 ASSERT_EQ(1u, parameters.encodings.size());
7013 ASSERT_TRUE(parameters.encodings[0].active);
7014 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08007015 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007016 EXPECT_FALSE(stream->IsSending());
7017
7018 // Now change it back to active and verify we resume sending.
7019 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08007020 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007021 EXPECT_TRUE(stream->IsSending());
7022}
7023
Seth Hampson8234ead2018-02-02 15:16:24 -08007024// Tests that when active is updated for any simulcast layer then the send
7025// stream's sending state will be updated and it will be reconfigured with the
7026// new appropriate active simulcast streams.
7027TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
7028 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02007029 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08007030 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
7031 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
7032 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
7033 uint32_t primary_ssrc = stream_params.first_ssrc();
7034
Niels Möller805a27e2019-01-21 12:21:27 +01007035 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01007036 // frame. This allows us to test that ReconfigureEncoder is called
7037 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01007038 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08007039 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01007040 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08007041 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007042 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
7043 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
7044 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08007045
7046 // Check that all encodings are initially active.
7047 webrtc::RtpParameters parameters =
7048 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007049 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007050 EXPECT_TRUE(parameters.encodings[0].active);
7051 EXPECT_TRUE(parameters.encodings[1].active);
7052 EXPECT_TRUE(parameters.encodings[2].active);
7053 EXPECT_TRUE(fake_video_send_stream->IsSending());
7054
7055 // Only turn on only the middle stream.
7056 parameters.encodings[0].active = false;
7057 parameters.encodings[1].active = true;
7058 parameters.encodings[2].active = false;
7059 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7060 // Verify that the active fields are set on the VideoChannel.
7061 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007062 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007063 EXPECT_FALSE(parameters.encodings[0].active);
7064 EXPECT_TRUE(parameters.encodings[1].active);
7065 EXPECT_FALSE(parameters.encodings[2].active);
7066 // Check that the VideoSendStream is updated appropriately. This means its
7067 // send state was updated and it was reconfigured.
7068 EXPECT_TRUE(fake_video_send_stream->IsSending());
7069 std::vector<webrtc::VideoStream> simulcast_streams =
7070 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007071 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007072 EXPECT_FALSE(simulcast_streams[0].active);
7073 EXPECT_TRUE(simulcast_streams[1].active);
7074 EXPECT_FALSE(simulcast_streams[2].active);
7075
7076 // Turn off all streams.
7077 parameters.encodings[0].active = false;
7078 parameters.encodings[1].active = false;
7079 parameters.encodings[2].active = false;
7080 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7081 // Verify that the active fields are set on the VideoChannel.
7082 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007083 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007084 EXPECT_FALSE(parameters.encodings[0].active);
7085 EXPECT_FALSE(parameters.encodings[1].active);
7086 EXPECT_FALSE(parameters.encodings[2].active);
7087 // Check that the VideoSendStream is off.
7088 EXPECT_FALSE(fake_video_send_stream->IsSending());
7089 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007090 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007091 EXPECT_FALSE(simulcast_streams[0].active);
7092 EXPECT_FALSE(simulcast_streams[1].active);
7093 EXPECT_FALSE(simulcast_streams[2].active);
7094
Niels Möllerff40b142018-04-09 08:49:14 +02007095 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007096}
7097
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007098// Test that if a stream is reconfigured (due to a codec change or other
7099// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007100TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007101 InactiveStreamDoesntStartSendingWhenReconfigured) {
7102 // Set an initial codec list, which will be modified later.
7103 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007104 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7105 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007106 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7107
7108 FakeVideoSendStream* stream = AddSendStream();
7109 EXPECT_TRUE(channel_->SetSend(true));
7110 EXPECT_TRUE(stream->IsSending());
7111
7112 // Get current parameters and change "active" to false.
7113 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7114 ASSERT_EQ(1u, parameters.encodings.size());
7115 ASSERT_TRUE(parameters.encodings[0].active);
7116 parameters.encodings[0].active = false;
7117 EXPECT_EQ(1u, GetFakeSendStreams().size());
7118 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007119 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007120 EXPECT_FALSE(stream->IsSending());
7121
7122 // Reorder the codec list, causing the stream to be reconfigured.
7123 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007124 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7125 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007126 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7127 auto new_streams = GetFakeSendStreams();
7128 // Assert that a new underlying stream was created due to the codec change.
7129 // Otherwise, this test isn't testing what it set out to test.
7130 EXPECT_EQ(1u, GetFakeSendStreams().size());
7131 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7132
7133 // Verify that we still are not sending anything, due to the inactive
7134 // encoding.
7135 EXPECT_FALSE(new_streams[0]->IsSending());
7136}
7137
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007138// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007139TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007140 AddSendStream();
7141 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007142 parameters.codecs.push_back(GetEngineCodec("VP8"));
7143 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007144 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7145
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007146 webrtc::RtpParameters rtp_parameters =
7147 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007148 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007149 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7150 rtp_parameters.codecs[0]);
7151 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7152 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007153}
7154
Florent Castellidacec712018-05-24 16:24:21 +02007155// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7156TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7157 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7158 params.cname = "rtcpcname";
7159 AddSendStream(params);
7160
7161 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7162 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7163}
7164
deadbeeffb2aced2017-01-06 23:05:37 -08007165// Test that RtpParameters for send stream has one encoding and it has
7166// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007167TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007168 AddSendStream();
7169
7170 webrtc::RtpParameters rtp_parameters =
7171 channel_->GetRtpSendParameters(last_ssrc_);
7172 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007173 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007174}
7175
Florent Castelliabe301f2018-06-12 18:33:49 +02007176TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7177 AddSendStream();
7178
7179 webrtc::RtpParameters rtp_parameters =
7180 channel_->GetRtpSendParameters(last_ssrc_);
7181 rtp_parameters.header_extensions.emplace_back();
7182
7183 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7184
7185 webrtc::RTCError result =
7186 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7187 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7188}
7189
Florent Castelli87b3c512018-07-18 16:00:28 +02007190TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7191 AddSendStream();
7192
Niels Möller805a27e2019-01-21 12:21:27 +01007193 webrtc::test::FrameForwarder frame_forwarder;
7194 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007195
7196 webrtc::RtpParameters rtp_parameters =
7197 channel_->GetRtpSendParameters(last_ssrc_);
7198 EXPECT_EQ(rtp_parameters.degradation_preference,
7199 webrtc::DegradationPreference::BALANCED);
7200 rtp_parameters.degradation_preference =
7201 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7202
7203 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7204
7205 webrtc::RtpParameters updated_rtp_parameters =
7206 channel_->GetRtpSendParameters(last_ssrc_);
7207 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7208 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7209
7210 // Remove the source since it will be destroyed before the channel
7211 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7212}
7213
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007214// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007215TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007216 AddSendStream();
7217 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007218 parameters.codecs.push_back(GetEngineCodec("VP8"));
7219 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007220 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7221
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007222 webrtc::RtpParameters initial_params =
7223 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007224
7225 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007226 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007227
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007228 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7229 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7230}
7231
7232// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007233TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007234 AddRecvStream();
7235 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007236 parameters.codecs.push_back(GetEngineCodec("VP8"));
7237 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007238 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7239
7240 webrtc::RtpParameters rtp_parameters =
7241 channel_->GetRtpReceiveParameters(last_ssrc_);
7242 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007243 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7244 rtp_parameters.codecs[0]);
7245 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7246 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007247}
7248
johan073ece42016-08-26 02:59:47 -07007249#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007250TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007251#else
eladalonf1841382017-06-12 01:16:46 -07007252TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007253#endif
johan3859c892016-08-05 09:19:25 -07007254 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007255 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007256 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007257 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007258 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007259 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007260 parameters.codecs.push_back(kH264sprop2);
7261 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7262
7263 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7264 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7265 webrtc::RtpParameters rtp_parameters =
7266 channel_->GetRtpReceiveParameters(last_ssrc_);
7267 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7268 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7269 ASSERT_EQ(2u, cfg.decoders.size());
7270 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007271 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007272 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007273 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7274 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007275 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007276
7277 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007278 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007279 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007280 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7281 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007282 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007283}
7284
sakal1fd95952016-06-22 00:46:15 -07007285// Test that RtpParameters for receive stream has one encoding and it has
7286// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007287TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007288 AddRecvStream();
7289
7290 webrtc::RtpParameters rtp_parameters =
7291 channel_->GetRtpReceiveParameters(last_ssrc_);
7292 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007293 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007294}
7295
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007296// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007297TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007298 AddRecvStream();
7299 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007300 parameters.codecs.push_back(GetEngineCodec("VP8"));
7301 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007302 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7303
7304 webrtc::RtpParameters initial_params =
7305 channel_->GetRtpReceiveParameters(last_ssrc_);
7306
7307 // We should be able to set the params we just got.
7308 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7309
7310 // ... And this shouldn't change the params returned by
7311 // GetRtpReceiveParameters.
7312 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007313}
7314
deadbeef3bc15102017-04-20 19:25:07 -07007315// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7316// aren't signaled. It should always return an empty "RtpEncodingParameters",
7317// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007318TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007319 // Call necessary methods to configure receiving a default stream as
7320 // soon as it arrives.
7321 cricket::VideoRecvParameters parameters;
7322 parameters.codecs.push_back(GetEngineCodec("VP8"));
7323 parameters.codecs.push_back(GetEngineCodec("VP9"));
7324 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7325
7326 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7327 // stream. Should return nothing.
7328 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7329
7330 // Set a sink for an unsignaled stream.
7331 cricket::FakeVideoRenderer renderer;
7332 // Value of "0" means "unsignaled stream".
7333 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7334
7335 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7336 // in this method means "unsignaled stream".
7337 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7338 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7339 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7340
7341 // Receive VP8 packet.
7342 uint8_t data[kMinRtpPacketLen];
7343 cricket::RtpHeader rtpHeader;
7344 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7345 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7346 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7347 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7348 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007349 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007350
7351 // The |ssrc| member should still be unset.
7352 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7353 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7354 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7355}
7356
eladalonf1841382017-06-12 01:16:46 -07007357void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007358 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007359 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007360
7361 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007362 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007363 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007364 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007365
7366 if (receiver_first) {
7367 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7368 std::vector<FakeVideoReceiveStream*> receive_streams =
7369 fake_call_->GetVideoReceiveStreams();
7370 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007371 // Default local SSRC when we have no sender.
7372 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7373 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007374 }
7375 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7376 if (!receiver_first)
7377 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7378 std::vector<FakeVideoReceiveStream*> receive_streams =
7379 fake_call_->GetVideoReceiveStreams();
7380 ASSERT_EQ(1u, receive_streams.size());
7381 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007382
7383 // Removing first sender should fall back to another (in this case the second)
7384 // local send stream's SSRC.
7385 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7386 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007387 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007388 ASSERT_EQ(1u, receive_streams.size());
7389 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7390
7391 // Removing the last sender should fall back to default local SSRC.
7392 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007393 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007394 ASSERT_EQ(1u, receive_streams.size());
7395 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7396 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007397}
7398
eladalonf1841382017-06-12 01:16:46 -07007399TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007400 TestReceiverLocalSsrcConfiguration(false);
7401}
7402
eladalonf1841382017-06-12 01:16:46 -07007403TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007404 TestReceiverLocalSsrcConfiguration(true);
7405}
7406
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007407class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007408 public:
eladalonf1841382017-06-12 01:16:46 -07007409 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007410 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007411 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7412 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007413 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007414 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007415 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007416 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007417 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007418 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007419 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007420
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007421 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007422 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007423 channel_.reset(engine_.CreateMediaChannel(
7424 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7425 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007426 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007427 last_ssrc_ = 123;
7428 }
7429
7430 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007431 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007432 int capture_width,
7433 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007434 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007435 size_t expected_num_streams,
7436 bool screenshare,
7437 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007438 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007439 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007440 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007441 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007442
Peter Boström0c4e06b2015-10-07 12:23:21 +02007443 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007444 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007445 ssrcs.resize(num_configured_streams);
7446
sprangf24a0642017-02-28 13:23:26 -08007447 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007448 // Send a full-size frame to trigger a stream reconfiguration to use all
7449 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007450 webrtc::test::FrameForwarder frame_forwarder;
7451 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7452 rtc::kNumMicrosecsPerSec / 30);
7453
sprangf24a0642017-02-28 13:23:26 -08007454 VideoOptions options;
7455 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007456 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007457 EXPECT_TRUE(
7458 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007459 // Fetch the latest stream since SetVideoSend() may recreate it if the
7460 // screen content setting is changed.
7461 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007462 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007463 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007464
Zach Stein3ca452b2018-01-18 10:01:24 -08007465 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7466 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7467
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007468 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7469 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007470 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007471
sprang429600d2017-01-26 06:12:26 -08007472 std::vector<webrtc::VideoStream> expected_streams;
Florent Castelli66b38602019-07-10 16:57:57 +02007473 if (num_configured_streams > 1 || conference_mode) {
sprang429600d2017-01-26 06:12:26 -08007474 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007475 num_configured_streams, capture_width, capture_height,
Florent Castelli66b38602019-07-10 16:57:57 +02007476 webrtc::kDefaultBitratePriority, kDefaultQpMax,
7477 screenshare && conference_mode, true);
7478 if (screenshare && conference_mode) {
sprang3ebabf12017-02-16 07:35:22 -08007479 for (const webrtc::VideoStream& stream : expected_streams) {
7480 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007481 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7482 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007483 }
7484 }
sprang429600d2017-01-26 06:12:26 -08007485 } else {
7486 webrtc::VideoStream stream;
7487 stream.width = capture_width;
7488 stream.height = capture_height;
7489 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007490 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007491 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007492 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007493 stream.max_qp = kDefaultQpMax;
7494 expected_streams.push_back(stream);
7495 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007496
7497 ASSERT_EQ(expected_streams.size(), video_streams.size());
7498
7499 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007500 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007501 for (size_t i = 0; i < num_streams; ++i) {
7502 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7503 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7504
7505 EXPECT_GT(video_streams[i].max_framerate, 0);
7506 EXPECT_EQ(expected_streams[i].max_framerate,
7507 video_streams[i].max_framerate);
7508
7509 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7510 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7511 video_streams[i].min_bitrate_bps);
7512
7513 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7514 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7515 video_streams[i].target_bitrate_bps);
7516
7517 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7518 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7519 video_streams[i].max_bitrate_bps);
7520
7521 EXPECT_GT(video_streams[i].max_qp, 0);
7522 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7523
Florent Castelli66b38602019-07-10 16:57:57 +02007524 EXPECT_EQ(num_configured_streams > 1 || conference_mode,
Sergey Silkina796a7e2018-03-01 15:11:29 +01007525 expected_streams[i].num_temporal_layers.has_value());
7526
7527 if (conference_mode) {
7528 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7529 video_streams[i].num_temporal_layers);
7530 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007531
7532 if (i == num_streams - 1) {
7533 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7534 } else {
7535 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7536 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007537 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007538
Niels Möllerff40b142018-04-09 08:49:14 +02007539 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007540 }
7541
7542 FakeVideoSendStream* AddSendStream() {
7543 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7544 }
7545
7546 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007547 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007548 EXPECT_TRUE(channel_->AddSendStream(sp));
7549 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007550 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007551 EXPECT_EQ(num_streams + 1, streams.size());
7552 return streams[streams.size() - 1];
7553 }
7554
7555 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007556 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007557 }
7558
7559 FakeVideoReceiveStream* AddRecvStream() {
7560 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7561 }
7562
7563 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007564 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007565 EXPECT_TRUE(channel_->AddRecvStream(sp));
7566 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007567 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007568 EXPECT_EQ(num_streams + 1, streams.size());
7569 return streams[streams.size() - 1];
7570 }
7571
Danil Chapovalov83bbe912019-08-07 12:24:53 +02007572 webrtc::RtcEventLogNull event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007573 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007574 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7575 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007576 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7577 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007578 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007579 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007580 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007581};
7582
eladalonf1841382017-06-12 01:16:46 -07007583TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007584 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7585 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007586}
7587
eladalonf1841382017-06-12 01:16:46 -07007588TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007589 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7590 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007591}
7592
7593// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007594TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007595 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7596 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007597}
sprang429600d2017-01-26 06:12:26 -08007598
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007599TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Florent Castelli66b38602019-07-10 16:57:57 +02007600 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007601 false);
7602}
7603
eladalonf1841382017-06-12 01:16:46 -07007604TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007605 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7606 true);
7607}
7608
Florent Castelli66b38602019-07-10 16:57:57 +02007609TEST_F(WebRtcVideoChannelSimulcastTest, SimulcastScreenshareWithoutConference) {
7610 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
sprangfe627f32017-03-29 08:24:59 -07007611 false);
7612}
7613
Chen Xing90f3b892019-06-25 10:16:14 +02007614TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7615 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007616
Chen Xing90f3b892019-06-25 10:16:14 +02007617 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007618 EXPECT_TRUE(SetDefaultCodec());
7619 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007620 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007621
Chen Xing90f3b892019-06-25 10:16:14 +02007622 // Send and receive one frame.
7623 SendFrame();
7624 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007625
Chen Xing90f3b892019-06-25 10:16:14 +02007626 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7627 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7628 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007629
Chen Xing90f3b892019-06-25 10:16:14 +02007630 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7631 EXPECT_EQ(source.source_id(), kSsrc);
7632 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7633 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7634 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007635
Chen Xing90f3b892019-06-25 10:16:14 +02007636 // Send and receive another frame.
7637 SendFrame();
7638 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007639
Chen Xing90f3b892019-06-25 10:16:14 +02007640 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7641 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7642 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007643
Chen Xing90f3b892019-06-25 10:16:14 +02007644 source = channel_->GetSources(kSsrc)[0];
7645 EXPECT_EQ(source.source_id(), kSsrc);
7646 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7647 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7648 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007649
Chen Xing90f3b892019-06-25 10:16:14 +02007650 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7651 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007652}
7653
Amit Hilbuchb000b712019-02-25 10:22:14 -08007654TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7655 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7656
7657 std::vector<std::string> rids = {"f", "h", "q"};
7658 std::vector<cricket::RidDescription> rid_descriptions;
7659 for (const auto& rid : rids) {
7660 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7661 }
7662 sp.set_rids(rid_descriptions);
7663
7664 ASSERT_TRUE(channel_->AddSendStream(sp));
7665 const auto& streams = fake_call_->GetVideoSendStreams();
7666 ASSERT_EQ(1u, streams.size());
7667 auto stream = streams[0];
7668 ASSERT_NE(stream, nullptr);
7669 const auto& config = stream->GetConfig();
7670 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7671}
7672
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007673} // namespace cricket