blob: 4874cf62000640ffef17aeac35b55a5b941e4bf0 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "media/engine/webrtc_video_engine.h"
12
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000013#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080014#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020015#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070016#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000017#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000018
Steve Anton2c9ebef2019-01-28 17:27:58 -080019#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010020#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020021#include "absl/strings/match.h"
Anton Sukhanov4f08faa2019-05-21 11:12:57 -070022#include "api/media_transport_config.h"
Steve Anton10542f22019-01-11 09:11:00 -080023#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020024#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070025#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/test/mock_video_bitrate_allocator.h"
27#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070028#include "api/test/mock_video_decoder_factory.h"
29#include "api/test/mock_video_encoder_factory.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020030#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080031#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010032#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020033#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020034#include "api/video_codecs/builtin_video_decoder_factory.h"
35#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020036#include "api/video_codecs/sdp_video_format.h"
37#include "api/video_codecs/video_decoder_factory.h"
38#include "api/video_codecs/video_encoder.h"
39#include "api/video_codecs/video_encoder_factory.h"
40#include "call/flexfec_receive_stream.h"
41#include "common_video/h264/profile_level_id.h"
42#include "logging/rtc_event_log/rtc_event_log.h"
Niels Möller805a27e2019-01-21 12:21:27 +010043#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/base/fake_video_renderer.h"
46#include "media/base/media_constants.h"
47#include "media/base/rtp_utils.h"
48#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/fake_webrtc_call.h"
51#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "media/engine/webrtc_voice_engine.h"
Åsa Persson23cd45a2018-07-03 10:40:40 +020054#include "modules/rtp_rtcp/include/rtp_header_parser.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020055#include "rtc_base/arraysize.h"
Steve Anton10542f22019-01-11 09:11:00 -080056#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020058#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080059#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010061#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020062#include "test/gmock.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000063
Mirko Bonadei6a489f22019-04-09 15:11:12 +020064using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020065using ::testing::IsEmpty;
66using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010067using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070068using webrtc::RtpExtension;
69
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000070namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000071static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000072
noahricd10a68e2015-07-10 11:27:55 -070073static const uint8_t kRedRtxPayloadType = 125;
74
Niels Möller6557d0c2018-04-11 15:18:34 +020075static const uint32_t kTimeout = 5000U;
76static const uint32_t kDefaultReceiveSsrc = 0;
77static const uint32_t kSsrc = 1234u;
78static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
79static const int kVideoWidth = 640;
80static const int kVideoHeight = 360;
81static const int kFramerate = 30;
82
Peter Boström0c4e06b2015-10-07 12:23:21 +020083static const uint32_t kSsrcs1[] = {1};
84static const uint32_t kSsrcs3[] = {1, 2, 3};
85static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080086static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020087static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080088static const uint32_t kDefaultRecvSsrc = 0;
89
pbos@webrtc.org3c107582014-07-20 15:27:35 +000090static const char kUnsupportedExtensionName[] =
91 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000092
magjed509e4fe2016-11-18 01:34:11 -080093cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
94 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +020095 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -080096}
97
Elad Alonfadb1812019-05-24 13:40:02 +020098void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
99 bool lntf_expected) {
100 EXPECT_EQ(lntf_expected,
101 codec.HasFeedbackParam(cricket::FeedbackParam(
102 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000103 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
104 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
105 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
106 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
107 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
108 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800110 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
111 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000112 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
113}
114
magjed725e4842016-11-16 00:48:13 -0800115// Return true if any codec in |codecs| is an RTX codec with associated payload
116// type |payload_type|.
117bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
118 int payload_type) {
119 for (const cricket::VideoCodec& codec : codecs) {
120 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200121 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800122 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
123 &associated_payload_type) &&
124 associated_payload_type == payload_type) {
125 return true;
126 }
127 }
128 return false;
129}
130
nisseca5706d2017-09-11 02:32:16 -0700131// TODO(nisse): Duplicated in call.cc.
132const int* FindKeyByValue(const std::map<int, int>& m, int v) {
133 for (const auto& kv : m) {
134 if (kv.second == v)
135 return &kv.first;
136 }
137 return nullptr;
138}
139
Yves Gerey665174f2018-06-19 15:03:05 +0200140bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
141 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700142 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
143 payload_type) != nullptr;
144}
145
146// Check that there's an Rtx payload type for each decoder.
147bool VerifyRtxReceiveAssociations(
148 const webrtc::VideoReceiveStream::Config& config) {
149 for (const auto& decoder : config.decoders) {
150 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
151 return false;
152 }
153 return true;
154}
155
brandtrffc61182016-11-28 06:02:22 -0800156rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700157 int width,
158 int height) {
159 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
160 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800161 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700162 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000163}
164
Shao Changbine62202f2015-04-21 20:24:50 +0800165void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
166 const std::map<int, int>& rtx_types) {
167 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200168 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800169 EXPECT_TRUE(it != rtx_types.end() &&
170 it->second == config.rtp.rtx.payload_type);
171
brandtrb5f2c3f2016-10-04 23:28:39 -0700172 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
173 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800174 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700175 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800176 }
177}
kthelgason2bc68642017-02-07 07:02:22 -0800178
179cricket::MediaConfig GetMediaConfig() {
180 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100181 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800182 return media_config;
183}
nisse26e3abb2017-08-25 04:44:25 -0700184
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200185// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
186int GetMaxDefaultBitrateBps(size_t width, size_t height) {
187 if (width * height <= 320 * 240) {
188 return 600000;
189 } else if (width * height <= 640 * 480) {
190 return 1700000;
191 } else if (width * height <= 960 * 540) {
192 return 2000000;
193 } else {
194 return 2500000;
195 }
196}
197
Niels Möller731a2c22018-07-30 15:08:07 +0200198class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
199 public:
200 MOCK_METHOD2(AddOrUpdateSink,
201 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
202 const rtc::VideoSinkWants& wants));
203 MOCK_METHOD1(RemoveSink,
204 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
205};
206
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000207} // namespace
208
Yves Gerey665174f2018-06-19 15:03:05 +0200209#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200210 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200211 EXPECT_EQ((w), renderer_.width()); \
212 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200213 EXPECT_EQ(0, renderer_.errors());
214
Yves Gerey665174f2018-06-19 15:03:05 +0200215#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200216 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200217 EXPECT_EQ((w), (r).width()); \
218 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200219 EXPECT_EQ(0, (r).errors());
220
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000221namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700222class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000223 public:
eladalonf1841382017-06-12 01:16:46 -0700224 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200225 explicit WebRtcVideoEngineTest(const std::string& field_trials)
226 : override_field_trials_(
227 field_trials.empty()
228 ? nullptr
229 : absl::make_unique<webrtc::test::ScopedFieldTrials>(
230 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200231 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
232 call_(webrtc::Call::Create([&] {
233 webrtc::Call::Config call_config(&event_log_);
234 call_config.task_queue_factory = task_queue_factory_.get();
235 return call_config;
236 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200237 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
238 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200239 video_bitrate_allocator_factory_(
240 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200241 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200242 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200243 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200244 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200245 // Ensure fake clock doesn't return 0, which will cause some initializations
246 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200247 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200248 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000249
250 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200251 void AssignDefaultAptRtxTypes();
252 void AssignDefaultCodec();
253
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100254 // Find the index of the codec in the engine with the given name. The codec
255 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100256 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100257
magjed509e4fe2016-11-18 01:34:11 -0800258 // Find the codec in the engine with the given name. The codec must be
259 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100260 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800261
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200262 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000263
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200264 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000265 const std::vector<VideoCodec>& codecs);
266
Elad Alon157540a2019-02-08 23:37:52 +0100267 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100268
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200269 // Has to be the first one, so it is initialized before the call or there is a
270 // race condition in the clock access.
271 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200272 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
skvlad11a9cbf2016-10-07 11:53:05 -0700273 webrtc::RtcEventLogNullImpl event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200274 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700275 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000276 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800277 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200278 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
279 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200280 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
281 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700282 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000283 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800284 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000285};
286
eladalonf1841382017-06-12 01:16:46 -0700287TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200288 encoder_factory_->AddSupportedVideoCodecType("VP8");
289 AssignDefaultCodec();
290
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000291 std::vector<VideoCodec> engine_codecs = engine_.codecs();
292 for (size_t i = 0; i < engine_codecs.size(); ++i) {
293 if (engine_codecs[i].name != kRtxCodecName)
294 continue;
295 int associated_payload_type;
296 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000297 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000298 EXPECT_EQ(default_codec_.id, associated_payload_type);
299 return;
300 }
301 FAIL() << "No RTX codec found among default codecs.";
302}
303
eladalonf1841382017-06-12 01:16:46 -0700304TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100305 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000306}
307
eladalonf1841382017-06-12 01:16:46 -0700308TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100309 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000310}
311
eladalonf1841382017-06-12 01:16:46 -0700312TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100313 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700314}
315
eladalonf1841382017-06-12 01:16:46 -0700316TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100317 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
318}
319
320TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
321 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
322}
323
324TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
325 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
326}
327
328TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
329 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
330}
331
332TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
333 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100334}
335
336TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100337 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
338}
339
Elad Alonccb9b752019-02-19 13:01:31 +0100340TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
341 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
342}
343
344TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
345 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700346}
347
philipel1e054862018-10-08 16:13:53 +0200348class WebRtcVideoEngineTestWithGenericDescriptor
349 : public WebRtcVideoEngineTest {
350 public:
351 WebRtcVideoEngineTestWithGenericDescriptor()
352 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
353};
354
Elad Alonccb9b752019-02-19 13:01:31 +0100355TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
356 AdvertiseGenericDescriptor00) {
357 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
358}
359
360TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
361 AdvertiseGenericDescriptor01) {
362 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200363}
364
eladalonf1841382017-06-12 01:16:46 -0700365TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200366 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700367 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200368 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700369
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200370 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700371
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200372 std::unique_ptr<VideoMediaChannel> channel(
373 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700374 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
375
376 // Add CVO extension.
377 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800378 cricket::VideoSendParameters parameters;
379 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200380 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700381 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200382 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700383
Niels Möller731a2c22018-07-30 15:08:07 +0200384 EXPECT_CALL(
385 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200386 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200387 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700388 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200389 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700390
391 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200392 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700393
394 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200395 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200396 EXPECT_CALL(
397 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200398 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200399 Field(&rtc::VideoSinkWants::rotation_applied, true)));
400
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200401 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700402}
403
eladalonf1841382017-06-12 01:16:46 -0700404TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200405 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800406 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200407 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800408
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200409 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800410
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200411 std::unique_ptr<VideoMediaChannel> channel(
412 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800413 // Add CVO extension.
414 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800415 cricket::VideoSendParameters parameters;
416 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800417 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700418 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800419 EXPECT_TRUE(channel->SetSendParameters(parameters));
420 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
421
Niels Möller731a2c22018-07-30 15:08:07 +0200422 // Set source.
423 EXPECT_CALL(
424 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200425 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200426 Field(&rtc::VideoSinkWants::rotation_applied, false)));
427 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800428}
429
eladalonf1841382017-06-12 01:16:46 -0700430TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200431 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700432
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200433 encoder_factory_->AddSupportedVideoCodecType("VP8");
434 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700435
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200436 std::unique_ptr<VideoMediaChannel> channel(
437 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700438 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
439
440 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200441 EXPECT_CALL(
442 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200443 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200444 Field(&rtc::VideoSinkWants::rotation_applied, true)));
445 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700446
perkjcaafdba2016-03-20 07:34:29 -0700447 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200448 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700449
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700450 // Add CVO extension.
451 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800452 cricket::VideoSendParameters parameters;
453 parameters.codecs.push_back(GetEngineCodec("VP8"));
454 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200455 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700456 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700457 // Also remove the first codec to trigger a codec change as well.
458 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200459 EXPECT_CALL(
460 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200461 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200462 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200463 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700464
465 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200466 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700467
468 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200469 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200470 EXPECT_CALL(
471 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200472 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200473 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200474 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700475}
476
eladalonf1841382017-06-12 01:16:46 -0700477TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200478 encoder_factory_->AddSupportedVideoCodecType("VP8");
479
Sebastian Jansson84848f22018-11-16 10:40:36 +0100480 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200481 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
482 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000483
484 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
485
486 EXPECT_FALSE(channel->SetSend(true))
487 << "Channel should not start without codecs.";
488 EXPECT_TRUE(channel->SetSend(false))
489 << "Channel should be stoppable even without set codecs.";
490}
491
eladalonf1841382017-06-12 01:16:46 -0700492TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200493 encoder_factory_->AddSupportedVideoCodecType("VP8");
494
Sebastian Jansson84848f22018-11-16 10:40:36 +0100495 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200496 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
497 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000498 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
499 VideoMediaInfo info;
500 channel->GetStats(&info);
501}
502
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200503TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200504 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000505
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200506 std::unique_ptr<VideoMediaChannel> channel(
507 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800508 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000509
510 EXPECT_TRUE(
511 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200512 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000513 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100514 webrtc::test::FrameForwarder frame_forwarder;
515 cricket::FakeFrameSource frame_source(1280, 720,
516 rtc::kNumMicrosecsPerSec / 30);
517 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
518 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100519 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200520 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
521 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000522 kTimeout);
523
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200524 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100525 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000526
527 // Setting codecs of the same type should not reallocate any encoders
528 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800529 cricket::VideoSendParameters parameters;
530 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200531 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200532 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000533
534 // Remove stream previously added to free the external encoder instance.
535 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200536 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000537}
538
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200539// Test that when an encoder factory supports H264, we add an RTX
540// codec for it.
541// TODO(deadbeef): This test should be updated if/when we start
542// adding RTX codecs for unrecognized codec names.
543TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800544 using webrtc::H264::kLevel1;
Jonas Olssona4d87372019-07-05 19:08:33 +0200545 using webrtc::H264::ProfileLevelId;
546 using webrtc::H264::ProfileLevelIdToString;
Anders Carlsson67537952018-05-03 11:28:29 +0200547 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
548 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800549 *ProfileLevelIdToString(
550 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200551 webrtc::SdpVideoFormat h264_constrained_high("H264");
552 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800553 *ProfileLevelIdToString(
554 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200555 webrtc::SdpVideoFormat h264_high("H264");
556 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800557 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
558
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200559 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
560 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
561 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700562
magjed725e4842016-11-16 00:48:13 -0800563 // First figure out what payload types the test codecs got assigned.
564 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800565 // Now search for RTX codecs for them. Expect that they all have associated
566 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800567 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200568 codecs,
569 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
570 ->id));
magjed725e4842016-11-16 00:48:13 -0800571 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200572 codecs,
573 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
574 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800575 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200576 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700577}
578
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100579#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700580TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200581 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100582
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200583 std::unique_ptr<VideoMediaChannel> channel(
584 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100585
586 EXPECT_TRUE(
587 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
588}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100589#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100590
eladalonf1841382017-06-12 01:16:46 -0700591TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200592 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100593 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200594 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200595 std::unique_ptr<VideoMediaChannel> channel(
596 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700597
598 EXPECT_TRUE(
599 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
600
Niels Möllerd0f0f682019-01-14 09:09:53 +0100601 webrtc::test::FrameForwarder frame_forwarder;
602 cricket::FakeFrameSource frame_source(1280, 720,
603 rtc::kNumMicrosecsPerSec / 60);
604 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700605 channel->SetSend(true);
606
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200607 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700608
Niels Möllerd0f0f682019-01-14 09:09:53 +0100609 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700610 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700611 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100612 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700613 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700614 int64_t interval = timestamp - last_timestamp;
615
616 // Precision changes from nanosecond to millisecond.
617 // Allow error to be no more than 1.
618 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
619
620 last_timestamp = timestamp;
621 }
622
Niels Möllerd0f0f682019-01-14 09:09:53 +0100623 frame_forwarder.IncomingCapturedFrame(
624 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
625 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700626 last_timestamp = stream->GetLastTimestamp();
627 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100628 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
629 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
630 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700631 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700632 int64_t interval = timestamp - last_timestamp;
633
634 // Precision changes from nanosecond to millisecond.
635 // Allow error to be no more than 1.
636 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
637
638 last_timestamp = timestamp;
639 }
640
641 // Remove stream previously added to free the external encoder instance.
642 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
643}
644
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200645void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
646 std::vector<VideoCodec> engine_codecs = engine_.codecs();
647 RTC_DCHECK(!engine_codecs.empty());
648 for (const cricket::VideoCodec& codec : engine_codecs) {
649 if (codec.name == "rtx") {
650 int associated_payload_type;
651 if (codec.GetParam(kCodecParamAssociatedPayloadType,
652 &associated_payload_type)) {
653 default_apt_rtx_types_[associated_payload_type] = codec.id;
654 }
655 }
656 }
657}
658
659void WebRtcVideoEngineTest::AssignDefaultCodec() {
660 std::vector<VideoCodec> engine_codecs = engine_.codecs();
661 RTC_DCHECK(!engine_codecs.empty());
662 bool codec_set = false;
663 for (const cricket::VideoCodec& codec : engine_codecs) {
664 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
665 codec.name != "ulpfec") {
666 default_codec_ = codec;
667 codec_set = true;
668 }
669 }
670
671 RTC_DCHECK(codec_set);
672}
673
Oleh Prypina40f8242017-12-21 13:32:23 +0100674size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
675 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100676 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
677 for (size_t i = 0; i < codecs.size(); ++i) {
678 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200679 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200680 continue;
681 // The tests only use H264 Constrained Baseline. Make sure we don't return
682 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200683 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200684 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200685 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
686 if (profile_level_id->profile !=
687 webrtc::H264::kProfileConstrainedBaseline) {
688 continue;
689 }
690 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100691 return i;
magjed509e4fe2016-11-18 01:34:11 -0800692 }
693 // This point should never be reached.
694 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100695 return -1;
696}
697
698cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
699 const std::string& name) const {
700 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800701}
702
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200703VideoMediaChannel*
704WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100705 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200706 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
707 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200708 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800709 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200710 for (const webrtc::SdpVideoFormat& format :
711 encoder_factory_->GetSupportedFormats()) {
712 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800713 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200714 parameters.codecs.push_back(engine_codec);
715 }
716 }
magjed509e4fe2016-11-18 01:34:11 -0800717
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200718 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000719
720 return channel;
721}
722
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200723VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000724 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100725 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200726 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
727 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200728 cricket::VideoRecvParameters parameters;
729 parameters.codecs = codecs;
730 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000731
732 return channel;
733}
734
Elad Alon157540a2019-02-08 23:37:52 +0100735void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
736 bool supported) const {
737 const RtpCapabilities capabilities = engine_.GetCapabilities();
738 if (supported) {
739 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200740 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100741 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200742 EXPECT_THAT(capabilities.header_extensions,
743 ::testing::Each(::testing::Field(&RtpExtension::uri,
744 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100745 }
746}
747
eladalonf1841382017-06-12 01:16:46 -0700748TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200749 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000750
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200751 std::unique_ptr<VideoMediaChannel> channel(
752 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000753
Peter Boström0c4e06b2015-10-07 12:23:21 +0200754 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000755
Yves Gerey665174f2018-06-19 15:03:05 +0200756 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000757 EXPECT_TRUE(channel->SetSend(true));
758
Niels Möller805a27e2019-01-21 12:21:27 +0100759 webrtc::test::FrameForwarder frame_forwarder;
760 cricket::FakeFrameSource frame_source(1280, 720,
761 rtc::kNumMicrosecsPerSec / 60);
762 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
763 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000764
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200765 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000766
767 // Verify that encoders are configured for simulcast through adapter
768 // (increasing resolution and only configured to send one stream each).
769 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200770 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
771 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000772 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200773 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000774 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
775 EXPECT_GT(codec_settings.width, prev_width);
776 prev_width = codec_settings.width;
777 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000778
Niels Möllerff40b142018-04-09 08:49:14 +0200779 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000780
781 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200782 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000783}
784
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200785TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
786 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200787 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000788
Niels Möllerd0f0f682019-01-14 09:09:53 +0100789 // Frame source.
790 webrtc::test::FrameForwarder frame_forwarder;
791 cricket::FakeFrameSource frame_source(1280, 720,
792 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200793
Sebastian Jansson84848f22018-11-16 10:40:36 +0100794 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200795 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
796 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200797 cricket::VideoSendParameters parameters;
798 parameters.codecs.push_back(GetEngineCodec("H264"));
799 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000800
801 EXPECT_TRUE(
802 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100803 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200804 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100805 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200806
807 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000808
Anders Carlsson67537952018-05-03 11:28:29 +0200809 cricket::VideoSendParameters new_parameters;
810 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
811 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200812
813 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100814 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200815
Anders Carlsson8a150d92018-05-14 12:40:04 +0200816 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000817}
818
eladalonf1841382017-06-12 01:16:46 -0700819TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000820 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200821 encoder_factory_->AddSupportedVideoCodecType("VP8");
822 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000823
Sebastian Jansson84848f22018-11-16 10:40:36 +0100824 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200825 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
826 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800827 cricket::VideoSendParameters parameters;
828 parameters.codecs.push_back(GetEngineCodec("VP8"));
829 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000830
Peter Boström0c4e06b2015-10-07 12:23:21 +0200831 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000832
Yves Gerey665174f2018-06-19 15:03:05 +0200833 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000834 EXPECT_TRUE(channel->SetSend(true));
835
836 // Send a fake frame, or else the media engine will configure the simulcast
837 // encoder adapter at a low-enough size that it'll only create a single
838 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100839 webrtc::test::FrameForwarder frame_forwarder;
840 cricket::FakeFrameSource frame_source(1280, 720,
841 rtc::kNumMicrosecsPerSec / 30);
842 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
843 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000844
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200845 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
846 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000847 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200848 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000849
850 channel.reset();
851 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200852 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000853}
854
eladalonf1841382017-06-12 01:16:46 -0700855TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000856 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200857 encoder_factory_->AddSupportedVideoCodecType("VP8");
858 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000859
Sebastian Jansson84848f22018-11-16 10:40:36 +0100860 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200861 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
862 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800863 cricket::VideoSendParameters parameters;
864 parameters.codecs.push_back(GetEngineCodec("H264"));
865 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000866
867 EXPECT_TRUE(
868 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100869
870 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100871 webrtc::test::FrameForwarder frame_forwarder;
872 cricket::FakeFrameSource frame_source(1280, 720,
873 rtc::kNumMicrosecsPerSec / 30);
874 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
875 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200876 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
877 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200878 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000879 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200880 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000881
882 channel.reset();
883 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200884 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000885}
886
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200887TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200888 RTC_DCHECK(!override_field_trials_);
889 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200890 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200891 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700892
Sebastian Jansson84848f22018-11-16 10:40:36 +0100893 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200894 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
895 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200896 cricket::VideoSendParameters parameters;
897 parameters.codecs.push_back(GetEngineCodec("H264"));
898 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700899
Peter Boström0c4e06b2015-10-07 12:23:21 +0200900 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700901 EXPECT_TRUE(
902 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100903
904 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100905 webrtc::test::FrameForwarder frame_forwarder;
906 cricket::FakeFrameSource frame_source(1280, 720,
907 rtc::kNumMicrosecsPerSec / 30);
908 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
909 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100910
Niels Möller4db138e2018-04-19 09:04:13 +0200911 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200912 ASSERT_EQ(1u, encoder_factory_->encoders().size());
913 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
914 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700915 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200916 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200917 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700918}
919
brandtrffc61182016-11-28 06:02:22 -0800920// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700921// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800922//
923// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700924TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800925 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200926 encoder_factory_->AddSupportedVideoCodecType("VP8");
927
Steve Anton2c9ebef2019-01-28 17:27:58 -0800928 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800929
930 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800931 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800932
933 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200934 RTC_DCHECK(!override_field_trials_);
935 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800936 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800937 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800938}
939
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200940// Test that codecs are added in the order they are reported from the factory.
941TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
942 encoder_factory_->AddSupportedVideoCodecType("VP8");
943 const char* kFakeCodecName = "FakeCodec";
944 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000945
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200946 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100947 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200948 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
949 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000950}
951
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200952// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800953// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200954TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100955 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
956 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100957
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100958 // Set up external encoder factory with first codec, and initialize engine.
959 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
960
brandtrffc61182016-11-28 06:02:22 -0800961 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800962
963 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100964 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800965 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200966 // The codec itself and RTX should have been added.
967 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100968
969 // Check that both fake codecs are present and that the second fake codec
970 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100971 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
972 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100973 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800974}
975
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200976TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
977 const char* kFakeCodecName = "FakeCodec";
978 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
979
980 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
981 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
982}
983
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200984TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
985 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200986 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200987 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800988 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000989
kwiberg686a8ef2016-02-26 03:00:35 -0800990 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200991 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000992
993 EXPECT_TRUE(
994 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200995 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000996
997 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200998 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200999 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001000
1001 // Remove stream previously added to free the external decoder instance.
1002 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001003 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001004}
1005
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001006// Verifies that we can set up decoders.
1007TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001008 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1009 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1010 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1011 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001012 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001013 webrtc::SdpVideoFormat supported_h264("H264");
1014 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1015 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001016 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001017 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001018
kwiberg686a8ef2016-02-26 03:00:35 -08001019 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001020 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001021
1022 EXPECT_TRUE(
1023 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001024 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001025}
1026
Jonas Oreland49ac5952018-09-26 16:04:32 +02001027// Tests when GetSources is called with non-existing ssrc, it will return an
1028// empty list of RtpSource without crashing.
1029TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1030 // Setup an recv stream with |kSsrc|.
1031 encoder_factory_->AddSupportedVideoCodecType("VP8");
1032 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1033 cricket::VideoRecvParameters parameters;
1034 parameters.codecs.push_back(GetEngineCodec("VP8"));
1035 std::unique_ptr<VideoMediaChannel> channel(
1036 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1037
1038 EXPECT_TRUE(
1039 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1040
1041 // Call GetSources with |kSsrc + 1| which doesn't exist.
1042 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1043 EXPECT_EQ(0u, sources.size());
1044}
1045
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001046TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1047 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1048 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1049 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001050 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001051 EXPECT_EQ(0u, engine.codecs().size());
1052}
1053
1054TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1055 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001056 webrtc::MockVideoEncoderFactory* encoder_factory =
1057 new webrtc::MockVideoEncoderFactory();
1058 webrtc::MockVideoDecoderFactory* decoder_factory =
1059 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001060 WebRtcVideoEngine engine(
1061 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001062 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001063 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1064 EXPECT_EQ(0u, engine.codecs().size());
1065 EXPECT_CALL(*encoder_factory, Die());
1066 EXPECT_CALL(*decoder_factory, Die());
1067}
1068
1069// Test full behavior in the video engine when video codec factories of the new
1070// type are injected supporting the single codec Vp8. Check the returned codecs
1071// from the engine and that we will create a Vp8 encoder and decoder using the
1072// new factories.
1073TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1074 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001075 webrtc::MockVideoEncoderFactory* encoder_factory =
1076 new webrtc::MockVideoEncoderFactory();
1077 webrtc::MockVideoDecoderFactory* decoder_factory =
1078 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001079 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1080 rate_allocator_factory =
1081 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001082 EXPECT_CALL(*rate_allocator_factory,
1083 CreateVideoBitrateAllocatorProxy(Field(
1084 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001085 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001086 WebRtcVideoEngine engine(
1087 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001088 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001089 const webrtc::SdpVideoFormat vp8_format("VP8");
1090 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1091 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001092 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001093
1094 // Verify the codecs from the engine.
1095 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001096 // Verify default codecs has been added correctly.
1097 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001098 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001099
1100 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001101 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001102 int vp8_associated_payload;
1103 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1104 &vp8_associated_payload));
1105 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1106
1107 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1108
1109 // RTX codec for RED.
1110 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1111 int red_associated_payload;
1112 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1113 &red_associated_payload));
1114 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1115
1116 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1117
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001118 int associated_payload_type;
1119 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1120 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1121 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1122 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001123 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1124 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001125
1126 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001127 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1128 codec_info.is_hardware_accelerated = false;
1129 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001130 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001131 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001132 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001133 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001134 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001135 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001136 .WillOnce(
1137 ::testing::DoAll(::testing::InvokeWithoutArgs(
1138 [&encoder_created]() { encoder_created.Set(); }),
1139 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001140
1141 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001142 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001143 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001144 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001145
1146 // Create a call.
1147 webrtc::RtcEventLogNullImpl event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001148 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1149 webrtc::Call::Config call_config(&event_log);
1150 call_config.task_queue_factory = task_queue_factory.get();
1151 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001152
1153 // Create send channel.
1154 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001155 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001156 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1157 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001158 cricket::VideoSendParameters send_parameters;
1159 send_parameters.codecs.push_back(engine_codecs.at(0));
1160 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1161 send_channel->OnReadyToSend(true);
1162 EXPECT_TRUE(
1163 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1164 EXPECT_TRUE(send_channel->SetSend(true));
1165
Niels Möller4db138e2018-04-19 09:04:13 +02001166 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001167 webrtc::test::FrameForwarder frame_forwarder;
1168 cricket::FakeFrameSource frame_source(1280, 720,
1169 rtc::kNumMicrosecsPerSec / 30);
1170 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001171 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001172 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001173 encoder_created.Wait(kTimeout);
1174
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001175 // Create recv channel.
1176 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001177 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001178 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1179 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001180 cricket::VideoRecvParameters recv_parameters;
1181 recv_parameters.codecs.push_back(engine_codecs.at(0));
1182 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1183 EXPECT_TRUE(recv_channel->AddRecvStream(
1184 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1185
1186 // Remove streams previously added to free the encoder and decoder instance.
1187 EXPECT_CALL(*encoder_factory, Die());
1188 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001189 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001190 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1191 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1192}
1193
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001194// Test behavior when decoder factory fails to create a decoder (returns null).
1195TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1196 // |engine| take ownership of the factories.
1197 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001198 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001199 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001200 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001201 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1202 rate_allocator_factory =
1203 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001204 WebRtcVideoEngine engine(
1205 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001206 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001207 const webrtc::SdpVideoFormat vp8_format("VP8");
1208 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1209 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001210 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001211
1212 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001213 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1214 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001215
1216 // Create a call.
1217 webrtc::RtcEventLogNullImpl event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001218 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1219 webrtc::Call::Config call_config(&event_log);
1220 call_config.task_queue_factory = task_queue_factory.get();
1221 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001222
1223 // Create recv channel.
1224 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001225 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001226 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1227 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001228 cricket::VideoRecvParameters recv_parameters;
1229 recv_parameters.codecs.push_back(engine.codecs().front());
1230 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1231 EXPECT_TRUE(recv_channel->AddRecvStream(
1232 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1233
1234 // Remove streams previously added to free the encoder and decoder instance.
1235 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1236}
1237
eladalonf1841382017-06-12 01:16:46 -07001238TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001239 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001240 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001241 std::unique_ptr<VideoMediaChannel> channel(
1242 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001243 ASSERT_TRUE(
1244 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1245 cricket::VideoCodec codec = GetEngineCodec("VP8");
1246 cricket::VideoSendParameters parameters;
1247 parameters.codecs.push_back(codec);
1248 channel->OnReadyToSend(true);
1249 channel->SetSend(true);
1250 ASSERT_TRUE(channel->SetSendParameters(parameters));
1251
Niels Möller805a27e2019-01-21 12:21:27 +01001252 webrtc::test::FrameForwarder frame_forwarder;
1253 cricket::FakeFrameSource frame_source(1280, 720,
1254 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001255 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001256 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001257
Niels Möller805a27e2019-01-21 12:21:27 +01001258 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001259 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001260 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001261 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001262
Niels Möller805a27e2019-01-21 12:21:27 +01001263 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1264 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001265 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001266 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001267
1268 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001269 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1270 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001271 // Change to screen content, recreate encoder. For the simulcast encoder
1272 // adapter case, this will result in two calls since InitEncode triggers a
1273 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001274 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001275 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001276 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001277
Niels Möller805a27e2019-01-21 12:21:27 +01001278 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1279 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001280 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001281 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001282
1283 options.is_screencast.emplace(false);
1284 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001285 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001286 // Change back to regular video content, update encoder. Also change
1287 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001288 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001289 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001290 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001291 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001292
1293 // Remove stream previously added to free the external encoder instance.
1294 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001295 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001296}
1297
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001298class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001299 protected:
1300 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001301 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1302 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001303 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1304 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1305 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001306
1307 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001308 // One testcase calls SetUp in a loop, only create call_ once.
1309 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001310 webrtc::Call::Config call_config(&event_log_);
1311 call_config.task_queue_factory = task_queue_factory_.get();
1312 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001313 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001314 cricket::MediaConfig media_config;
1315 // Disabling cpu overuse detection actually disables quality scaling too; it
1316 // implies DegradationPreference kMaintainResolution. Automatic scaling
1317 // needs to be disabled, otherwise, tests which check the size of received
1318 // frames become flaky.
1319 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001320 channel_.reset(
1321 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1322 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001323 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001324 channel_->OnReadyToSend(true);
1325 EXPECT_TRUE(channel_.get() != NULL);
1326 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001327 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001328 cricket::VideoRecvParameters parameters;
1329 parameters.codecs = engine_.codecs();
1330 channel_->SetRecvParameters(parameters);
1331 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Niels Möller805a27e2019-01-21 12:21:27 +01001332 frame_forwarder_ = absl::make_unique<webrtc::test::FrameForwarder>();
1333 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1334 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1335 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001336 }
1337
1338 // Utility method to setup an additional stream to send and receive video.
1339 // Used to test send and recv between two streams.
1340 void SetUpSecondStream() {
1341 SetUpSecondStreamWithNoRecv();
1342 // Setup recv for second stream.
1343 EXPECT_TRUE(channel_->AddRecvStream(
1344 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1345 // Make the second renderer available for use by a new stream.
1346 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1347 }
1348 // Setup an additional stream just to send video. Defer add recv stream.
1349 // This is required if you want to test unsignalled recv of video rtp packets.
1350 void SetUpSecondStreamWithNoRecv() {
1351 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001352 EXPECT_TRUE(
1353 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001354 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001355 EXPECT_FALSE(
1356 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001357 EXPECT_TRUE(channel_->AddSendStream(
1358 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1359 // We dont add recv for the second stream.
1360
1361 // Setup the receive and renderer for second stream after send.
Niels Möller805a27e2019-01-21 12:21:27 +01001362 frame_forwarder_2_ = absl::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001363 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001364 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001365 }
Yves Gerey665174f2018-06-19 15:03:05 +02001366 virtual void TearDown() { channel_.reset(); }
1367 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001368
1369 bool SetOneCodec(const cricket::VideoCodec& codec) {
Niels Möller805a27e2019-01-21 12:21:27 +01001370 frame_source_ = absl::make_unique<cricket::FakeFrameSource>(
1371 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001372
1373 bool sending = channel_->sending();
1374 bool success = SetSend(false);
1375 if (success) {
1376 cricket::VideoSendParameters parameters;
1377 parameters.codecs.push_back(codec);
1378 success = channel_->SetSendParameters(parameters);
1379 }
1380 if (success) {
1381 success = SetSend(sending);
1382 }
1383 return success;
1384 }
Yves Gerey665174f2018-06-19 15:03:05 +02001385 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001386 void SendFrame() {
1387 if (frame_forwarder_2_) {
1388 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001389 }
Niels Möller805a27e2019-01-21 12:21:27 +01001390 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001391 }
1392 bool WaitAndSendFrame(int wait_ms) {
1393 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001394 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001395 return ret;
1396 }
Yves Gerey665174f2018-06-19 15:03:05 +02001397 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001398 int NumRtpBytes(uint32_t ssrc) {
1399 return network_interface_.NumRtpBytes(ssrc);
1400 }
Yves Gerey665174f2018-06-19 15:03:05 +02001401 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001402 int NumRtpPackets(uint32_t ssrc) {
1403 return network_interface_.NumRtpPackets(ssrc);
1404 }
Yves Gerey665174f2018-06-19 15:03:05 +02001405 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001406 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1407 return network_interface_.GetRtpPacket(index);
1408 }
1409 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001410 webrtc::RTPHeader header;
1411 EXPECT_TRUE(ParseRtpPacket(p, &header));
1412 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001413 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001414
Niels Möller6557d0c2018-04-11 15:18:34 +02001415 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001416 webrtc::RTPHeader* header) {
1417 std::unique_ptr<webrtc::RtpHeaderParser> parser(
1418 webrtc::RtpHeaderParser::Create());
1419 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001420 }
1421
1422 // Tests that we can send and receive frames.
1423 void SendAndReceive(const cricket::VideoCodec& codec) {
1424 EXPECT_TRUE(SetOneCodec(codec));
1425 EXPECT_TRUE(SetSend(true));
1426 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1427 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001428 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001429 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1430 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1431 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1432 }
1433
1434 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001435 int duration_sec,
1436 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001437 EXPECT_TRUE(SetOneCodec(codec));
1438 EXPECT_TRUE(SetSend(true));
1439 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1440 EXPECT_EQ(0, renderer_.num_rendered_frames());
1441 for (int i = 0; i < duration_sec; ++i) {
1442 for (int frame = 1; frame <= fps; ++frame) {
1443 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1444 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1445 }
1446 }
1447 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1448 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1449 }
1450
Niels Möller6557d0c2018-04-11 15:18:34 +02001451 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1452 cricket::VideoMediaInfo info;
1453 EXPECT_TRUE(channel_->GetStats(&info));
1454 return info.senders[i];
1455 }
1456
1457 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1458 cricket::VideoMediaInfo info;
1459 EXPECT_TRUE(channel_->GetStats(&info));
1460 return info.receivers[i];
1461 }
1462
1463 // Two streams one channel tests.
1464
1465 // Tests that we can send and receive frames.
1466 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1467 SetUpSecondStream();
1468 // Test sending and receiving on first stream.
1469 SendAndReceive(codec);
1470 // Test sending and receiving on second stream.
1471 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1472 EXPECT_GT(NumRtpPackets(), 0);
1473 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1474 }
1475
1476 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1477 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001478 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001479 return engine_codec;
1480 }
1481 // This point should never be reached.
1482 ADD_FAILURE() << "Unrecognized codec name: " << name;
1483 return cricket::VideoCodec();
1484 }
1485
1486 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1487
1488 cricket::StreamParams DefaultSendStreamParams() {
1489 return cricket::StreamParams::CreateLegacy(kSsrc);
1490 }
1491
1492 webrtc::RtcEventLogNullImpl event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001493 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001494 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001495 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1496 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001497 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001498
1499 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1500 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1501 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1502
Niels Möller6557d0c2018-04-11 15:18:34 +02001503 std::unique_ptr<WebRtcVideoChannel> channel_;
1504 cricket::FakeNetworkInterface network_interface_;
1505 cricket::FakeVideoRenderer renderer_;
1506
1507 // Used by test cases where 2 streams are run on the same channel.
1508 cricket::FakeVideoRenderer renderer2_;
1509};
1510
1511// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001512TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001513 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001514 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001515 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1516 EXPECT_FALSE(channel_->sending());
1517 EXPECT_TRUE(SetSend(true));
1518 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001519 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001520 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1521 EXPECT_TRUE(SetSend(false));
1522 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001523}
Niels Möller6557d0c2018-04-11 15:18:34 +02001524
1525// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001526TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001527 EXPECT_FALSE(channel_->sending());
1528 EXPECT_FALSE(SetSend(true));
1529 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001530}
Niels Möller6557d0c2018-04-11 15:18:34 +02001531
1532// Test that we properly set the send and recv buffer sizes by the time
1533// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001534TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001535 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1536 EXPECT_TRUE(SetSend(true));
1537 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001538 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001539}
1540
Johannes Kron5a0665b2019-04-08 10:35:50 +02001541// Test that we properly set the send and recv buffer sizes when overriding
1542// via field trials.
1543TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1544 // Set field trial to override the default recv buffer size, and then re-run
1545 // setup where the interface is created and configured.
1546 const int kCustomRecvBufferSize = 123456;
1547 webrtc::test::ScopedFieldTrials field_trial(
1548 "WebRTC-IncreasedReceivebuffers/123456/");
1549 SetUp();
1550
1551 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1552 EXPECT_TRUE(SetSend(true));
1553 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1554 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1555}
1556
1557// Test that we properly set the send and recv buffer sizes when overriding
1558// via field trials with suffix.
1559TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1560 // Set field trial to override the default recv buffer size, and then re-run
1561 // setup where the interface is created and configured.
1562 const int kCustomRecvBufferSize = 123456;
1563 webrtc::test::ScopedFieldTrials field_trial(
1564 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1565 SetUp();
1566
1567 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1568 EXPECT_TRUE(SetSend(true));
1569 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1570 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1571}
1572
1573// Test that we properly set the send and recv buffer sizes when overriding
1574// via field trials that don't make any sense.
1575TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1576 // Set bogus field trial values to override the default recv buffer size, and
1577 // then re-run setup where the interface is created and configured. The
1578 // default value should still be used.
1579
1580 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1581 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1582 field_trial_string += group;
1583 field_trial_string += "/";
1584 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1585 SetUp();
1586
1587 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1588 EXPECT_TRUE(SetSend(true));
1589 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1590 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1591 }
1592}
1593
Niels Möller6557d0c2018-04-11 15:18:34 +02001594// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001595TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001596 const int kDurationSec = 3;
1597 const int kFps = 10;
1598 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1599
1600 cricket::VideoMediaInfo info;
1601 EXPECT_TRUE(channel_->GetStats(&info));
1602
1603 ASSERT_EQ(1U, info.senders.size());
1604 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1605 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn Mellembcd068d2019-07-29 22:09:00 +00001606 EXPECT_GT(info.senders[0].bytes_sent, 0);
Niels Möller6557d0c2018-04-11 15:18:34 +02001607 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1608 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1609 ASSERT_TRUE(info.senders[0].codec_payload_type);
1610 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1611 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1612 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1613 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1614 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1615 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1616 EXPECT_GT(info.senders[0].framerate_input, 0);
1617 EXPECT_GT(info.senders[0].framerate_sent, 0);
1618
1619 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1620 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1621 info.send_codecs[DefaultCodec().id]);
1622
1623 ASSERT_EQ(1U, info.receivers.size());
1624 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1625 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1626 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1627 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1628 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
Bjorn Mellembcd068d2019-07-29 22:09:00 +00001629 EXPECT_EQ(NumRtpBytes(), info.receivers[0].bytes_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001630 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001631 EXPECT_EQ(0, info.receivers[0].packets_lost);
1632 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1633 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1634 EXPECT_EQ(0, info.receivers[0].firs_sent);
1635 EXPECT_EQ(0, info.receivers[0].plis_sent);
1636 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1637 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1638 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1639 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1640 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1641 EXPECT_GT(info.receivers[0].framerate_output, 0);
1642
1643 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1644 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1645 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001646}
Niels Möller6557d0c2018-04-11 15:18:34 +02001647
1648// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001649TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001650 cricket::FakeVideoRenderer renderer1, renderer2;
1651 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1652 cricket::VideoSendParameters parameters;
1653 parameters.codecs.push_back(DefaultCodec());
1654 parameters.conference_mode = true;
1655 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1656 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001657 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1658 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001659 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1660 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1661 EXPECT_EQ(0, renderer1.num_rendered_frames());
1662 EXPECT_EQ(0, renderer2.num_rendered_frames());
1663 std::vector<uint32_t> ssrcs;
1664 ssrcs.push_back(1);
1665 ssrcs.push_back(2);
1666 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001667 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001668 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1669 kTimeout);
1670 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1671 kTimeout);
1672
1673 EXPECT_TRUE(channel_->SetSend(false));
1674
1675 cricket::VideoMediaInfo info;
1676 EXPECT_TRUE(channel_->GetStats(&info));
1677 ASSERT_EQ(1U, info.senders.size());
1678 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1679 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn Mellembcd068d2019-07-29 22:09:00 +00001680 EXPECT_GT(GetSenderStats(0).bytes_sent, 0);
Niels Möller6557d0c2018-04-11 15:18:34 +02001681 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1682 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1683 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1684
1685 ASSERT_EQ(2U, info.receivers.size());
1686 for (size_t i = 0; i < info.receivers.size(); ++i) {
1687 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1688 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
Bjorn Mellembcd068d2019-07-29 22:09:00 +00001689 EXPECT_EQ_WAIT(NumRtpBytes(), GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001690 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001691 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1692 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1693 }
srtee0c2eea2017-12-15 17:44:33 +01001694}
Niels Möller6557d0c2018-04-11 15:18:34 +02001695
1696// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001697TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001698 // Normal setup; note that we set the SSRC explicitly to ensure that
1699 // it will come first in the senders map.
1700 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1701 cricket::VideoSendParameters parameters;
1702 parameters.codecs.push_back(DefaultCodec());
1703 parameters.conference_mode = true;
1704 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001705 EXPECT_TRUE(
1706 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001707 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1708 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001709 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001710 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1711 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1712
1713 // Add an additional capturer, and hook up a renderer to receive it.
1714 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001715 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001716 const int kTestWidth = 160;
1717 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001718 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1719 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001720 EXPECT_TRUE(
1721 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001722 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001723 EXPECT_TRUE(
1724 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001726 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001727 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1728 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001729
1730 // Get stats, and make sure they are correct for two senders. We wait until
1731 // the number of expected packets have been sent to avoid races where we
1732 // check stats before it has been updated.
1733 cricket::VideoMediaInfo info;
1734 for (uint32_t i = 0; i < kTimeout; ++i) {
1735 rtc::Thread::Current()->ProcessMessages(1);
1736 EXPECT_TRUE(channel_->GetStats(&info));
1737 ASSERT_EQ(2U, info.senders.size());
1738 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1739 NumRtpPackets()) {
1740 // Stats have been updated for both sent frames, expectations can be
1741 // checked now.
1742 break;
1743 }
1744 }
1745 EXPECT_EQ(NumRtpPackets(),
1746 info.senders[0].packets_sent + info.senders[1].packets_sent)
1747 << "Timed out while waiting for packet counts for all sent packets.";
1748 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1749 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1750 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1751 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1752 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1753 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1754 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1755 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1756 // The capturer must be unregistered here as it runs out of it's scope next.
1757 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001758}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001759
Niels Möller6557d0c2018-04-11 15:18:34 +02001760// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001761TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001762 cricket::VideoSendParameters parameters;
1763 parameters.codecs.push_back(DefaultCodec());
1764 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1765 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1766 parameters.max_bandwidth_bps = 128 * 1024;
1767 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001768}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001769
Niels Möller6557d0c2018-04-11 15:18:34 +02001770// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001771TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001772 EXPECT_TRUE(SetDefaultCodec());
1773 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001774 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001775 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001776 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001777 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001778 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1779 EXPECT_EQ(kSsrc, header.ssrc);
1780
Niels Möller6557d0c2018-04-11 15:18:34 +02001781 // Packets are being paced out, so these can mismatch between the first and
1782 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001783 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1784 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001785 EXPECT_EQ(1, NumSentSsrcs());
1786 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1787 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001788}
Niels Möller6557d0c2018-04-11 15:18:34 +02001789
1790// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001791TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001792 // Remove stream added in Setup.
1793 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1794 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001796 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001797 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001798 EXPECT_TRUE(SetSend(true));
1799 EXPECT_TRUE(WaitAndSendFrame(0));
1800 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001801 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001802 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001803 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1804 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001805 // Packets are being paced out, so these can mismatch between the first and
1806 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001807 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1808 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001809 EXPECT_EQ(1, NumSentSsrcs());
1810 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1811 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001812}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001813
Niels Möller6557d0c2018-04-11 15:18:34 +02001814// Test that we can set the default video renderer before and after
1815// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001816TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001817 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1818 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001819
1820 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1821 rtc::SetBE32(packet1.data() + 8, kSsrc);
1822 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1823 EXPECT_TRUE(SetDefaultCodec());
1824 EXPECT_TRUE(SetSend(true));
1825 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001826 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001827 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001828 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001829 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001830}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001831
Niels Möller6557d0c2018-04-11 15:18:34 +02001832// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001833TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001834 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1835 EXPECT_TRUE(SetSend(true));
1836 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001837 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001838 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1839 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001840 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001841 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001842 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1843 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001844 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1845 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001846
1847 // Remove the send stream that was added during Setup.
1848 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1849 int rtp_packets = NumRtpPackets();
1850
Niels Möller6557d0c2018-04-11 15:18:34 +02001851 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001852 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001853 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001854 EXPECT_EQ(rtp_packets, NumRtpPackets());
1855 // Wait 30ms to guarantee the engine does not drop the frame.
1856 EXPECT_TRUE(WaitAndSendFrame(30));
1857 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1858
1859 last_packet = NumRtpPackets() - 1;
1860 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001861 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1862 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001863}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001864
Niels Möller6557d0c2018-04-11 15:18:34 +02001865// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001866TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001867 cricket::FakeVideoRenderer renderer1, renderer2;
1868 EXPECT_TRUE(SetDefaultCodec());
1869 cricket::VideoSendParameters parameters;
1870 parameters.codecs.push_back(DefaultCodec());
1871 parameters.conference_mode = true;
1872 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1873 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001874 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1875 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001876 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1877 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1878 EXPECT_EQ(0, renderer1.num_rendered_frames());
1879 EXPECT_EQ(0, renderer2.num_rendered_frames());
1880 std::vector<uint32_t> ssrcs;
1881 ssrcs.push_back(1);
1882 ssrcs.push_back(2);
1883 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001884 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001885 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1886 kTimeout);
1887 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1888 kTimeout);
1889
1890 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1891 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1892 EXPECT_EQ(kVideoWidth, renderer1.width());
1893 EXPECT_EQ(kVideoHeight, renderer1.height());
1894 EXPECT_EQ(kVideoWidth, renderer2.width());
1895 EXPECT_EQ(kVideoHeight, renderer2.height());
1896 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1897 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001898}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001899
Niels Möller6557d0c2018-04-11 15:18:34 +02001900// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001901TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001902 using cricket::FOURCC_I420;
Jonas Olssona4d87372019-07-05 19:08:33 +02001903 using cricket::VideoCodec;
1904 using cricket::VideoFormat;
1905 using cricket::VideoOptions;
Niels Möller6557d0c2018-04-11 15:18:34 +02001906
1907 VideoCodec codec = DefaultCodec();
1908 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1909 EXPECT_TRUE(SetOneCodec(codec));
1910 EXPECT_TRUE(SetSend(true));
1911 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1912 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001913 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001914 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001915
1916 webrtc::test::FrameForwarder frame_forwarder;
1917 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1918 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001919
1920 // TODO(nisse): This testcase fails if we don't configure
1921 // screencast. It's unclear why, I see nothing obvious in this
1922 // test which is related to screencast logic.
1923 VideoOptions video_options;
1924 video_options.is_screencast = true;
1925 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1926
Niels Möller6557d0c2018-04-11 15:18:34 +02001927 int captured_frames = 1;
1928 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001929 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001930 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001931 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1932
Niels Möller6557d0c2018-04-11 15:18:34 +02001933 ++captured_frames;
1934 // Wait until frame of right size is captured.
1935 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001936 480 == renderer_.width() &&
1937 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001938 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001939 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001940 EXPECT_EQ(480, renderer_.width());
1941 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001942 captured_frames = renderer_.num_rendered_frames() + 1;
1943 EXPECT_FALSE(renderer_.black_frame());
1944 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1945 // Make sure a black frame is generated within the specified timeout.
1946 // The black frame should be the resolution of the previous frame to
1947 // prevent expensive encoder reconfigurations.
1948 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001949 480 == renderer_.width() &&
1950 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001951 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001952 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001953 EXPECT_EQ(480, renderer_.width());
1954 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001955 EXPECT_TRUE(renderer_.black_frame());
1956
1957 // The black frame has the same timestamp as the next frame since it's
1958 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1959 // not render a frame with the same timestamp so capture another frame
1960 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001961 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001962 }
srtee0c2eea2017-12-15 17:44:33 +01001963}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001964
Niels Möller6557d0c2018-04-11 15:18:34 +02001965// Tests that if SetVideoSend is called with a NULL capturer after the
1966// capturer was already removed, the application doesn't crash (and no black
1967// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001968TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001969 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1970 EXPECT_TRUE(SetSend(true));
1971 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1972 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001973 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001974 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1975 // Wait for one frame so they don't get dropped because we send frames too
1976 // tightly.
1977 rtc::Thread::Current()->ProcessMessages(30);
1978 // Remove the capturer.
1979 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1980
1981 // No capturer was added, so this SetVideoSend shouldn't do anything.
1982 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1983 rtc::Thread::Current()->ProcessMessages(300);
1984 // Verify no more frames were sent.
1985 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01001986}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001987
Niels Möller6557d0c2018-04-11 15:18:34 +02001988// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01001989TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001990 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1991 // interval time to avoid that.
1992 // WebRTC implementation will drop frames if pushed to quickly. Wait the
1993 // interval time to avoid that.
1994 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02001995 EXPECT_TRUE(
1996 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001997 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1998 cricket::VideoFormat capture_format(
1999 kVideoWidth, kVideoHeight,
2000 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2001 // Set up additional stream 1.
2002 cricket::FakeVideoRenderer renderer1;
2003 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002004 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002005 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002006 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002007
2008 webrtc::test::FrameForwarder frame_forwarder1;
2009 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2010 rtc::kNumMicrosecsPerSec / kFramerate);
2011
Niels Möller6557d0c2018-04-11 15:18:34 +02002012 // Set up additional stream 2.
2013 cricket::FakeVideoRenderer renderer2;
2014 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002015 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002016 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002017 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002018 webrtc::test::FrameForwarder frame_forwarder2;
2019
Niels Möller6557d0c2018-04-11 15:18:34 +02002020 // State for all the streams.
2021 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2022 // A limitation in the lmi implementation requires that SetVideoSend() is
2023 // called after SetOneCodec().
2024 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002025 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2026 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002027 EXPECT_TRUE(SetSend(true));
2028 // Test capturer associated with engine.
2029 const int kTestWidth = 160;
2030 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002031 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2032 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2033 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002034 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2035 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002036 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002037 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2038 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2039 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002040 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2041 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002042 // Successfully remove the capturer.
2043 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2044 // The capturers must be unregistered here as it runs out of it's scope
2045 // next.
2046 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2047 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002048}
Niels Möller6557d0c2018-04-11 15:18:34 +02002049
2050// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002051TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002052 // Remove the send stream that was added during Setup.
2053 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2054
2055 cricket::StreamParams empty;
2056 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002057 EXPECT_TRUE(
2058 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002059}
Niels Möller6557d0c2018-04-11 15:18:34 +02002060
2061// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002062TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002063 // Remove stream added in Setup. I.e. remove stream corresponding to default
2064 // channel.
2065 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002066 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002067 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2068 EXPECT_TRUE(channel_->AddSendStream(
2069 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2070 }
2071 // Delete one of the non default channel streams, let the destructor delete
2072 // the remaining ones.
2073 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2074 // Stream should already be deleted.
2075 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002076}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002077
eladalonf1841382017-06-12 01:16:46 -07002078TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002079 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002080}
2081
eladalonf1841382017-06-12 01:16:46 -07002082TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002083 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002084}
2085
eladalonf1841382017-06-12 01:16:46 -07002086TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002087 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002088}
2089
eladalonf1841382017-06-12 01:16:46 -07002090TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002091 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2092 // bitrates. This currently happens at <250k, and two streams sharing 300k
2093 // initially will use QVGA instead of VGA.
2094 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2095 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002096 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002097 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002098 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002099}
2100
philipele8ed8302019-07-03 11:53:48 +02002101TEST_F(WebRtcVideoChannelBaseTest, OnEncoderFailure) {
2102 cricket::VideoSendParameters parameters;
2103 parameters.codecs.push_back(GetEngineCodec("VP9"));
2104 parameters.codecs.push_back(GetEngineCodec("VP8"));
2105 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2106
2107 VideoCodec codec;
2108 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2109 EXPECT_EQ("VP9", codec.name);
2110
2111 // OnEncoderFailure will post a task to the worker thread (which is also
2112 // the current thread), hence the ProcessMessages call.
2113 channel_->OnEncoderFailure();
2114 rtc::Thread::Current()->ProcessMessages(30);
2115 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2116 EXPECT_EQ("VP8", codec.name);
2117
2118 // No other codec to fall back to, keep using VP8.
2119 channel_->OnEncoderFailure();
2120 rtc::Thread::Current()->ProcessMessages(30);
2121 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2122 EXPECT_EQ("VP8", codec.name);
2123}
2124
eladalonf1841382017-06-12 01:16:46 -07002125class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002126 public:
eladalonf1841382017-06-12 01:16:46 -07002127 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2128 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002129 : WebRtcVideoEngineTest(field_trials),
2130 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2131 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002132 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002133 encoder_factory_->AddSupportedVideoCodecType("VP8");
2134 encoder_factory_->AddSupportedVideoCodecType("VP9");
2135#if defined(WEBRTC_USE_H264)
2136 encoder_factory_->AddSupportedVideoCodecType("H264");
2137#endif
2138
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002139 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002140 channel_.reset(engine_.CreateMediaChannel(
2141 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2142 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002143 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002144 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002145 send_parameters_.codecs = engine_.codecs();
2146 recv_parameters_.codecs = engine_.codecs();
2147 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002148 }
2149
2150 protected:
2151 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002152 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002153 }
2154
2155 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002156 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002157 EXPECT_TRUE(channel_->AddSendStream(sp));
2158 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002159 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002160 EXPECT_EQ(num_streams + 1, streams.size());
2161 return streams[streams.size() - 1];
2162 }
2163
2164 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002165 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002166 }
2167
2168 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002169 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002170 }
2171
2172 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002173 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002174 EXPECT_TRUE(channel_->AddRecvStream(sp));
2175 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002176 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002177 EXPECT_EQ(num_streams + 1, streams.size());
2178 return streams[streams.size() - 1];
2179 }
2180
pbos@webrtc.org00873182014-11-25 14:03:34 +00002181 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2182 int expected_min_bitrate_bps,
2183 const char* start_bitrate_kbps,
2184 int expected_start_bitrate_bps,
2185 const char* max_bitrate_kbps,
2186 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002187 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2188 expected_start_bitrate_bps,
2189 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002190 auto& codecs = send_parameters_.codecs;
2191 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002192 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002193 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2194 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2195 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002196 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002197 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002198
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002199 void ExpectSetBitrateParameters(int min_bitrate_bps,
2200 int start_bitrate_bps,
2201 int max_bitrate_bps) {
2202 EXPECT_CALL(
2203 *fake_call_->GetMockTransportControllerSend(),
2204 SetSdpBitrateParameters(AllOf(
2205 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2206 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2207 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2208 }
2209
2210 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2211 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2212 SetSdpBitrateParameters(Field(
2213 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002214 }
2215
Johannes Kron9190b822018-10-29 11:22:05 +01002216 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2217 // For a caller, the answer will be applied in set remote description
2218 // where SetSendParameters() is called.
2219 EXPECT_TRUE(
2220 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2221 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2222 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2223 const webrtc::VideoSendStream::Config& config =
2224 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2225 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2226 }
2227
2228 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2229 // For a callee, the answer will be applied in set local description
2230 // where SetExtmapAllowMixed() and AddSendStream() are called.
2231 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2232 EXPECT_TRUE(
2233 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2234 const webrtc::VideoSendStream::Config& config =
2235 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2236 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2237 }
2238
isheriff6f8d6862016-05-26 11:24:55 -07002239 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002240 // Enable extension.
2241 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002242 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002243 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002244 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002245 FakeVideoSendStream* send_stream =
2246 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2247
2248 // Verify the send extension id.
2249 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2250 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002251 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002252 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002253 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002254 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2255 // receivers.
2256 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2257 ->GetConfig()
2258 .rtp.extensions.empty());
2259
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002260 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002261 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002262 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2263 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002264 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2265
2266 // Verify that adding receive RTP header extensions adds them for existing
2267 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002268 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002269 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002270 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2271 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002272 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002273 }
2274
isheriff6f8d6862016-05-26 11:24:55 -07002275 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002276 // Enable extension.
2277 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002278 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002279 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002280 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002281
2282 FakeVideoReceiveStream* recv_stream =
2283 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2284
2285 // Verify the recv extension id.
2286 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2287 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002288 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002289 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002290 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002291
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002292 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2293 // senders.
2294 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2295 ->GetConfig()
2296 .rtp.extensions.empty());
2297
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002298 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002299 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002300 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2301 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002302 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2303
2304 // Verify that adding receive RTP header extensions adds them for existing
2305 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002306 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002307 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002308 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2309 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002310 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002311 }
2312
Elad Alonfadb1812019-05-24 13:40:02 +02002313 void TestLossNotificationState(bool expect_lntf_enabled) {
2314 AssignDefaultCodec();
2315 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2316
2317 cricket::VideoSendParameters parameters;
2318 parameters.codecs = engine_.codecs();
2319 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2320 EXPECT_TRUE(channel_->SetSend(true));
2321
2322 // Send side.
2323 FakeVideoSendStream* send_stream =
2324 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2325 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2326
2327 // Receiver side.
2328 FakeVideoReceiveStream* recv_stream =
2329 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2330 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2331 }
2332
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002333 void TestExtensionFilter(const std::vector<std::string>& extensions,
2334 const std::string& expected_extension) {
2335 cricket::VideoSendParameters parameters = send_parameters_;
2336 int expected_id = -1;
2337 int id = 1;
2338 for (const std::string& extension : extensions) {
2339 if (extension == expected_extension)
2340 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002341 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002342 }
2343 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2344 FakeVideoSendStream* send_stream =
2345 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2346
2347 // Verify that only one of them has been set, and that it is the one with
2348 // highest priority (transport sequence number).
2349 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2350 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2351 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002352 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002353 }
2354
asapersson3c81a1a2017-06-14 05:52:21 -07002355 void TestDegradationPreference(bool resolution_scaling_enabled,
2356 bool fps_scaling_enabled);
2357
Erik Språngefbde372015-04-29 16:21:28 +02002358 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002359 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002360 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2361 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002362
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002363 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002364 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002365 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002366 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002367 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002368 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002369 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002370 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002371 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002372
Erik Språng143cec12015-04-28 10:01:41 +02002373 return fake_call_->GetVideoSendStreams().back();
2374 }
2375
Peter Boström2feafdb2015-09-09 14:32:14 +02002376 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2377 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002378 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002379 std::vector<uint32_t> ssrcs;
2380 std::vector<uint32_t> rtx_ssrcs;
2381 uint32_t num_streams = enabled ? 3 : 1;
2382 for (uint32_t i = 0; i < num_streams; ++i) {
2383 uint32_t ssrc = last_ssrc_ + i;
2384 ssrcs.push_back(ssrc);
2385 if (with_rtx) {
2386 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2387 }
Erik Språng143cec12015-04-28 10:01:41 +02002388 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002389 if (with_rtx) {
2390 return AddSendStream(
2391 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2392 }
2393 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002394 }
2395
perkjfa10b552016-10-02 23:45:26 -07002396 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002397 std::vector<FakeVideoSendStream*> streams =
2398 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002399 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002400 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002401 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002402 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002403 }
2404
perkjfa10b552016-10-02 23:45:26 -07002405 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002406 int stream_max,
2407 int expected_encoder_bitrate) {
2408 VideoSendParameters limited_send_params = send_parameters_;
2409 limited_send_params.max_bandwidth_bps = global_max;
2410 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002411 webrtc::RtpParameters parameters =
2412 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002413 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002414 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002415 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002416 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002417 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002418 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002419 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002420 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002421 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002422 }
2423
Åsa Persson55659812018-06-18 17:51:32 +02002424 // Values from kSimulcastConfigs in simulcast.cc.
2425 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2426 std::vector<webrtc::VideoStream> layers(3);
2427 layers[0].min_bitrate_bps = 30000;
2428 layers[0].target_bitrate_bps = 150000;
2429 layers[0].max_bitrate_bps = 200000;
2430 layers[1].min_bitrate_bps = 150000;
2431 layers[1].target_bitrate_bps = 500000;
2432 layers[1].max_bitrate_bps = 700000;
2433 layers[2].min_bitrate_bps = 600000;
2434 layers[2].target_bitrate_bps = 2500000;
2435 layers[2].max_bitrate_bps = 2500000;
2436 return layers;
2437 }
2438
Niels Möller805a27e2019-01-21 12:21:27 +01002439 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002440 std::unique_ptr<FakeCall> fake_call_;
2441 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002442 cricket::VideoSendParameters send_parameters_;
2443 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002444 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002445};
2446
eladalonf1841382017-06-12 01:16:46 -07002447TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002448 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002449 const std::string kSyncLabel = "AvSyncLabel";
2450
2451 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002452 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002453 EXPECT_TRUE(channel_->AddRecvStream(sp));
2454
Mirko Bonadeif859e552018-05-30 15:31:29 +02002455 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002456 EXPECT_EQ(kSyncLabel,
2457 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2458 << "SyncGroup should be set based on sync_label";
2459}
2460
eladalonf1841382017-06-12 01:16:46 -07002461TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002462 cricket::VideoSendParameters parameters;
2463 parameters.codecs = engine_.codecs();
2464 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002465 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002466 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002467 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002468
2469 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002470 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2471 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002472 FakeVideoSendStream* send_stream = AddSendStream(
2473 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2474
2475 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2476 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2477 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2478
2479 // Receiver side.
2480 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2481 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002482 EXPECT_FALSE(
2483 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002484 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002485 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002486 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002487 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002488 << "RTX should be mapped for the RED payload type";
2489
brandtr14742122017-01-27 04:53:07 -08002490 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002491}
2492
eladalonf1841382017-06-12 01:16:46 -07002493TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002494 // Setup one channel with an associated RTX stream.
2495 cricket::StreamParams params =
2496 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2497 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2498 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002499 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002500
2501 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2502 << "RTX should be mapped for all decoders/payload types.";
2503 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002504 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002505 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002506}
2507
eladalonf1841382017-06-12 01:16:46 -07002508TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002509 // Setup one channel without an associated RTX stream.
2510 cricket::StreamParams params =
2511 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2512 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002513 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002514}
2515
Johannes Kron9190b822018-10-29 11:22:05 +01002516// Test propagation of extmap allow mixed setting.
2517TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2518 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2519}
2520TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2521 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2522}
2523TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2524 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2525}
2526TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2527 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2528}
2529
eladalonf1841382017-06-12 01:16:46 -07002530TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002531 FakeVideoSendStream* send_stream =
2532 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2533 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2534
2535 FakeVideoReceiveStream* recv_stream =
2536 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2537 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002538}
2539
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002540// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002541TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002542 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002543}
isheriff6f8d6862016-05-26 11:24:55 -07002544
eladalonf1841382017-06-12 01:16:46 -07002545TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002546 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002547}
2548
2549// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002550TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002551 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002552}
isheriff6f8d6862016-05-26 11:24:55 -07002553
eladalonf1841382017-06-12 01:16:46 -07002554TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002555 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002556}
2557
eladalonf1841382017-06-12 01:16:46 -07002558TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002559 // Enable three redundant extensions.
2560 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002561 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2562 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2563 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2564 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002565}
2566
eladalonf1841382017-06-12 01:16:46 -07002567TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002568 // Enable two redundant extensions.
2569 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002570 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2571 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2572 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002573}
2574
stefanc1aeaf02015-10-15 07:26:07 -07002575// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002576TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002577 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002578}
eladalonf1841382017-06-12 01:16:46 -07002579TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002580 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002581}
2582
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002583// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002584TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002585 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002586}
eladalonf1841382017-06-12 01:16:46 -07002587TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002588 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002589}
2590
eladalonf1841382017-06-12 01:16:46 -07002591TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002592 const int kAbsSendTimeId = 1;
2593 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002594 send_parameters_.extensions.push_back(
2595 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2596 send_parameters_.extensions.push_back(
2597 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002598
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002599 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002600 FakeVideoSendStream* send_stream =
2601 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2602
2603 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002604 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002605
2606 // Setting the same extensions (even if in different order) shouldn't
2607 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002608 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002609 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002610
2611 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2612
2613 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002614 send_parameters_.extensions.resize(1);
2615 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002616
2617 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2618}
2619
eladalonf1841382017-06-12 01:16:46 -07002620TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002621 const int kTOffsetId = 1;
2622 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002623 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002624 recv_parameters_.extensions.push_back(
2625 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2626 recv_parameters_.extensions.push_back(
2627 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2628 recv_parameters_.extensions.push_back(
2629 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002630
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002631 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002632 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002633 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2634
2635 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002636 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002637
2638 // Setting the same extensions (even if in different order) shouldn't
2639 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002640 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002641 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002642
2643 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2644
2645 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002646 recv_parameters_.extensions.resize(1);
2647 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002648
2649 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2650}
2651
eladalonf1841382017-06-12 01:16:46 -07002652TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002653 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002654 const int kUnsupportedId = 1;
2655 const int kTOffsetId = 2;
2656
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002657 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002658 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002659 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002660 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002661 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002662 FakeVideoSendStream* send_stream =
2663 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2664
2665 // Only timestamp offset extension is set to send stream,
2666 // unsupported rtp extension is ignored.
2667 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002668 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2669 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002670}
2671
eladalonf1841382017-06-12 01:16:46 -07002672TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002673 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002674 const int kUnsupportedId = 1;
2675 const int kTOffsetId = 2;
2676
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002677 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002678 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002679 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002680 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002681 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002682 FakeVideoReceiveStream* recv_stream =
2683 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2684
2685 // Only timestamp offset extension is set to receive stream,
2686 // unsupported rtp extension is ignored.
2687 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002688 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2689 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002690}
2691
eladalonf1841382017-06-12 01:16:46 -07002692TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002693 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002694 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002695 send_parameters_.extensions.push_back(
2696 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002697 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002698 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2699 }
2700}
2701
eladalonf1841382017-06-12 01:16:46 -07002702TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002703 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002704 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002705 recv_parameters_.extensions.push_back(
2706 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002707 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002708 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2709 }
2710}
2711
eladalonf1841382017-06-12 01:16:46 -07002712TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002713 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002714 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002715 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002716 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002717 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002718 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002719
2720 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002721 send_parameters_.extensions.clear();
2722 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002723 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002724 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2725 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002726}
2727
eladalonf1841382017-06-12 01:16:46 -07002728TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002729 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002730 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002731 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002732 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002733 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002734 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002735
2736 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002737 recv_parameters_.extensions.clear();
2738 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002739 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002740 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2741 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002742}
2743
eladalonf1841382017-06-12 01:16:46 -07002744TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002745 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002746 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002747}
2748
eladalonf1841382017-06-12 01:16:46 -07002749TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002750 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002751 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002752}
2753
eladalonf1841382017-06-12 01:16:46 -07002754TEST_F(WebRtcVideoChannelTest, RembIsEnabledByDefault) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002755 FakeVideoReceiveStream* stream = AddRecvStream();
2756 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002757}
2758
eladalonf1841382017-06-12 01:16:46 -07002759TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002760 FakeVideoReceiveStream* stream = AddRecvStream();
2761 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2762}
2763
eladalonf1841382017-06-12 01:16:46 -07002764TEST_F(WebRtcVideoChannelTest, RembCanBeEnabledAndDisabled) {
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002765 FakeVideoReceiveStream* stream = AddRecvStream();
2766 EXPECT_TRUE(stream->GetConfig().rtp.remb);
2767
Peter Boström126c03e2015-05-11 12:48:12 +02002768 // Verify that REMB is turned off when send(!) codecs without REMB are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002769 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002770 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002771 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2772 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002773 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002774 EXPECT_FALSE(stream->GetConfig().rtp.remb);
2775
2776 // Verify that REMB is turned on when setting default codecs since the
2777 // default codecs have REMB enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002778 parameters.codecs = engine_.codecs();
2779 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002780 stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.org257e1302014-07-25 19:01:32 +00002781 EXPECT_TRUE(stream->GetConfig().rtp.remb);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002782}
2783
eladalonf1841382017-06-12 01:16:46 -07002784TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002785 FakeVideoReceiveStream* stream = AddRecvStream();
2786 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2787
2788 // Verify that transport cc feedback is turned off when send(!) codecs without
2789 // transport cc feedback are set.
2790 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002791 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002792 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2793 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2794 stream = fake_call_->GetVideoReceiveStreams()[0];
2795 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2796
2797 // Verify that transport cc feedback is turned on when setting default codecs
2798 // since the default codecs have transport cc feedback enabled.
2799 parameters.codecs = engine_.codecs();
2800 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2801 stream = fake_call_->GetVideoReceiveStreams()[0];
2802 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2803}
2804
Elad Alonfadb1812019-05-24 13:40:02 +02002805TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2806 TestLossNotificationState(false);
2807}
2808
2809TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2810 RTC_DCHECK(!override_field_trials_);
2811 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2812 "WebRTC-RtcpLossNotification/Enabled/");
2813 SetUp();
2814 TestLossNotificationState(true);
2815}
2816
2817TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2818 RTC_DCHECK(!override_field_trials_);
2819 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
2820 "WebRTC-RtcpLossNotification/Enabled/");
2821 SetUp();
2822
2823 AssignDefaultCodec();
2824 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2825
2826 {
2827 cricket::VideoSendParameters parameters;
2828 parameters.codecs = engine_.codecs();
2829 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2830 EXPECT_TRUE(channel_->SetSend(true));
2831 }
2832
2833 // Start with LNTF enabled.
2834 FakeVideoSendStream* send_stream =
2835 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2836 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2837 FakeVideoReceiveStream* recv_stream =
2838 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2839 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2840
2841 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2842 cricket::VideoSendParameters parameters;
2843 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2844 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2845 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2846 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2847 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2848 send_stream = fake_call_->GetVideoSendStreams()[0];
2849 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2850
2851 // Setting the default codecs again, including VP8, turns LNTF back on.
2852 parameters.codecs = engine_.codecs();
2853 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2854 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2855 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2856 send_stream = fake_call_->GetVideoSendStreams()[0];
2857 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2858}
2859
eladalonf1841382017-06-12 01:16:46 -07002860TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002861 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002862 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002863
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002864 cricket::VideoSendParameters parameters;
2865 parameters.codecs = engine_.codecs();
2866 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002867 EXPECT_TRUE(channel_->SetSend(true));
2868
2869 // Send side.
2870 FakeVideoSendStream* send_stream =
2871 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2872 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2873
2874 // Receiver side.
2875 FakeVideoReceiveStream* recv_stream =
2876 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2877 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2878
2879 // Nack history size should match between sender and receiver.
2880 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2881 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002882}
2883
eladalonf1841382017-06-12 01:16:46 -07002884TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002885 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002886 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002887
2888 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2889 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2890
2891 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002892 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002893 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002894 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2895 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002896 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2897 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2898 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002899 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2900
Peter Boström67c9df72015-05-11 14:34:58 +02002901 // Verify that NACK is turned on when setting default codecs since the
2902 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002903 parameters.codecs = engine_.codecs();
2904 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002905 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2906 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2907 send_stream = fake_call_->GetVideoSendStreams()[0];
2908 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002909}
2910
Peter Boströme7ba0862016-03-12 00:02:28 +01002911// This test verifies that new frame sizes reconfigures encoders even though not
2912// (yet) sending. The purpose of this is to permit encoding as quickly as
2913// possible once we start sending. Likely the frames being input are from the
2914// same source that will be sent later, which just means that we're ready
2915// earlier.
eladalonf1841382017-06-12 01:16:46 -07002916TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002917 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002918 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002919 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2920 channel_->SetSend(false);
2921
2922 FakeVideoSendStream* stream = AddSendStream();
2923
perkjfa10b552016-10-02 23:45:26 -07002924 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002925 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002926 EXPECT_EQ(0u, streams[0].width);
2927 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002928
Niels Möller805a27e2019-01-21 12:21:27 +01002929 webrtc::test::FrameForwarder frame_forwarder;
2930 cricket::FakeFrameSource frame_source(1280, 720,
2931 rtc::kNumMicrosecsPerSec / 30);
2932
2933 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
2934 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01002935
2936 // Frame entered, should be reconfigured to new dimensions.
2937 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002938 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
2939 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002940
Niels Möllerff40b142018-04-09 08:49:14 +02002941 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01002942}
2943
eladalonf1841382017-06-12 01:16:46 -07002944TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002945 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08002946 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002947 cricket::VideoSendParameters parameters;
2948 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002949 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002950 AddSendStream();
2951
Niels Möller805a27e2019-01-21 12:21:27 +01002952 webrtc::test::FrameForwarder frame_forwarder;
2953 cricket::FakeFrameSource frame_source(1280, 720,
2954 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07002955 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002956 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01002957 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
2958 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002959
2960 EXPECT_TRUE(channel_->SetSend(true));
2961
Niels Möller805a27e2019-01-21 12:21:27 +01002962 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002963 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2964 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
2965
2966 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
2967
2968 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07002969 webrtc::VideoEncoderConfig encoder_config =
2970 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002971 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002972 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07002973 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002974 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
2975 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002976 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
2977 << "Non-screenshare shouldn't use min-transmit bitrate.";
2978
Niels Möllerff40b142018-04-09 08:49:14 +02002979 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08002980 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07002981 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002982 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01002983 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
2984 &frame_forwarder));
2985 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08002986 // Send stream recreated after option change.
2987 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2988 send_stream = fake_call_->GetVideoSendStreams().front();
2989 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002990
2991 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07002992 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02002993 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00002994 encoder_config.content_type);
2995 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
2996 encoder_config.min_transmit_bitrate_bps);
2997
perkjfa10b552016-10-02 23:45:26 -07002998 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01002999 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3000 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01003001 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02003002 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003003}
3004
eladalonf1841382017-06-12 01:16:46 -07003005TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003006 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02003007 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08003008 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003009 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003010
3011 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003012 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003013 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003014 webrtc::test::FrameForwarder frame_forwarder;
3015 cricket::FakeFrameSource frame_source(1280, 720,
3016 rtc::kNumMicrosecsPerSec / 30);
3017 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003018 EXPECT_TRUE(channel_->SetSend(true));
3019
Niels Möller805a27e2019-01-21 12:21:27 +01003020 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003021 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3022 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3023
perkj26091b12016-09-01 01:17:40 -07003024 webrtc::VideoEncoderConfig encoder_config =
3025 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003026
3027 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003028 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003029 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003030 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003031
3032 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3033 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003034 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003035 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003036 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003037
Niels Möllerff40b142018-04-09 08:49:14 +02003038 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003039}
3040
eladalonf1841382017-06-12 01:16:46 -07003041TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003042 FakeVideoSendStream* stream = AddSendStream();
3043 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3044}
3045
eladalonf1841382017-06-12 01:16:46 -07003046TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003047 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003048 media_config.video.suspend_below_min_bitrate = true;
3049
Sebastian Jansson84848f22018-11-16 10:40:36 +01003050 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003051 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3052 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003053 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003054
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003055 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003056
3057 FakeVideoSendStream* stream = AddSendStream();
3058 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3059
nisse0db023a2016-03-01 04:29:59 -08003060 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003061 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003062 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3063 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003064 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003065
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003066 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003067
nisse0db023a2016-03-01 04:29:59 -08003068 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003069 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3070}
3071
eladalonf1841382017-06-12 01:16:46 -07003072TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003073 FakeVideoSendStream* stream = AddSendStream();
3074 webrtc::VideoCodecVP8 vp8_settings;
3075 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3076 EXPECT_TRUE(vp8_settings.denoisingOn);
3077}
3078
eladalonf1841382017-06-12 01:16:46 -07003079TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003080 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003081 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003082 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003083
Peter Boström2feafdb2015-09-09 14:32:14 +02003084 // Single-stream settings should apply with RTX as well (verifies that we
3085 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3086 // both RTX and regular SSRCs).
3087 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003088
Niels Möller805a27e2019-01-21 12:21:27 +01003089 webrtc::test::FrameForwarder frame_forwarder;
3090 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003091 channel_->SetSend(true);
3092
Niels Möller805a27e2019-01-21 12:21:27 +01003093 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003094
pbos4cba4eb2015-10-26 11:18:18 -07003095 webrtc::VideoCodecVP8 vp8_settings;
3096 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3097 EXPECT_TRUE(vp8_settings.denoisingOn)
3098 << "VP8 denoising should be on by default.";
3099
Niels Möller805a27e2019-01-21 12:21:27 +01003100 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003101
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003102 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3103 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003104 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3105 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003106
Niels Möller805a27e2019-01-21 12:21:27 +01003107 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003108
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003109 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3110 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003111 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3112 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3113
Niels Möllerff40b142018-04-09 08:49:14 +02003114 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003115 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003116 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003117 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003118 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003119
Mirko Bonadeif859e552018-05-30 15:31:29 +02003120 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003121 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3122 // Autmatic resize off when using simulcast.
3123 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3124 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3125
Florent Castelli66b38602019-07-10 16:57:57 +02003126 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003127 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003128 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003129 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003130
Niels Möller805a27e2019-01-21 12:21:27 +01003131 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003132
Florent Castelli66b38602019-07-10 16:57:57 +02003133 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003134 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3135 EXPECT_FALSE(vp8_settings.denoisingOn);
3136 // Resizing and frame dropping always off for screen sharing.
3137 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3138 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3139
Niels Möller805a27e2019-01-21 12:21:27 +01003140 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003141
3142 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3143 EXPECT_FALSE(vp8_settings.denoisingOn);
3144 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3145 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3146
Niels Möllerff40b142018-04-09 08:49:14 +02003147 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003148}
3149
deadbeef119760a2016-04-04 11:43:27 -07003150// Test that setting the same options doesn't result in the encoder being
3151// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003152TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003153 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003154 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003155
perkjfa10b552016-10-02 23:45:26 -07003156 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003157 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003158 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003159 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3160 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3161
Niels Möller805a27e2019-01-21 12:21:27 +01003162 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3163 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3164 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003165 // Expect 1 reconfigurations at this point from the initial configuration.
3166 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003167
3168 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003169 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003170 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3171
3172 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003173 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003174 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003175 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3176
Niels Möllerff40b142018-04-09 08:49:14 +02003177 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003178}
3179
eladalonf1841382017-06-12 01:16:46 -07003180class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003181 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003182 Vp9SettingsTest() : Vp9SettingsTest("") {}
3183 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003184 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003185 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003186 }
3187 virtual ~Vp9SettingsTest() {}
3188
3189 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003190 void TearDown() override {
3191 // Remove references to encoder_factory_ since this will be destroyed
3192 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003193 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003194 }
Erik Språng143cec12015-04-28 10:01:41 +02003195};
3196
3197TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003198 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003199 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003200 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003201
Peter Boström2feafdb2015-09-09 14:32:14 +02003202 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003203
Niels Möller805a27e2019-01-21 12:21:27 +01003204 webrtc::test::FrameForwarder frame_forwarder;
3205 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003206 channel_->SetSend(true);
3207
Niels Möller805a27e2019-01-21 12:21:27 +01003208 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003209
pbos4cba4eb2015-10-26 11:18:18 -07003210 webrtc::VideoCodecVP9 vp9_settings;
3211 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003212 EXPECT_TRUE(vp9_settings.denoisingOn)
3213 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003214
Niels Möller805a27e2019-01-21 12:21:27 +01003215 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003216
Erik Språng143cec12015-04-28 10:01:41 +02003217 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3218 EXPECT_FALSE(vp9_settings.denoisingOn);
3219 // Frame dropping always on for real time video.
3220 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3221
Niels Möller805a27e2019-01-21 12:21:27 +01003222 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003223
3224 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3225 EXPECT_TRUE(vp9_settings.denoisingOn);
3226 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3227
3228 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003229 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003230 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003231 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003232
Niels Möller805a27e2019-01-21 12:21:27 +01003233 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003234
3235 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3236 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003237 // Frame dropping always on for screen sharing.
3238 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003239
Niels Möller805a27e2019-01-21 12:21:27 +01003240 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003241
3242 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3243 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003244 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003245
Niels Möllerff40b142018-04-09 08:49:14 +02003246 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003247}
3248
Sergey Silkinf18072e2018-03-14 10:35:35 +01003249TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3250 cricket::VideoSendParameters parameters;
3251 parameters.codecs.push_back(GetEngineCodec("VP9"));
3252 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3253
3254 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3255
3256 FakeVideoSendStream* stream =
3257 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3258
3259 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003260
Niels Möller805a27e2019-01-21 12:21:27 +01003261 webrtc::test::FrameForwarder frame_forwarder;
3262 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003263 channel_->SetSend(true);
3264
Niels Möller805a27e2019-01-21 12:21:27 +01003265 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003266
3267 webrtc::VideoCodecVP9 vp9_settings;
3268 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3269
3270 const size_t kNumSpatialLayers = ssrcs.size();
3271 const size_t kNumTemporalLayers = 3;
3272 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3273 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3274
Niels Möllerff40b142018-04-09 08:49:14 +02003275 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003276}
3277
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003278TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3279 cricket::VideoSendParameters parameters;
3280 parameters.codecs.push_back(GetEngineCodec("VP9"));
3281 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3282
3283 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3284
3285 FakeVideoSendStream* stream =
3286 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3287
3288 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3289
3290 // Despite 3 ssrcs provided, single layer is used.
3291 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3292
3293 webrtc::test::FrameForwarder frame_forwarder;
3294 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3295 channel_->SetSend(true);
3296
3297 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3298
3299 webrtc::VideoCodecVP9 vp9_settings;
3300 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3301
3302 const size_t kNumSpatialLayers = ssrcs.size();
3303 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3304
3305 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3306}
3307
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003308TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3309 cricket::VideoSendParameters send_parameters;
3310 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3311 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3312
3313 const size_t kNumSpatialLayers = 3;
3314 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3315
3316 FakeVideoSendStream* stream =
3317 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3318
3319 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3320 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3321 ASSERT_TRUE(parameters.encodings[0].active);
3322 ASSERT_TRUE(parameters.encodings[1].active);
3323 ASSERT_TRUE(parameters.encodings[2].active);
3324 // Invert value to verify copying.
3325 parameters.encodings[1].active = false;
3326 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3327
3328 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3329
3330 // number_of_streams should be 1 since all spatial layers are sent on the
3331 // same SSRC. But encoding parameters of all layers is supposed to be copied
3332 // and stored in simulcast_layers[].
3333 EXPECT_EQ(1u, encoder_config.number_of_streams);
3334 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3335 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3336 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3337 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3338}
3339
Sergey Silkincf267052019-04-09 11:40:09 +02003340class Vp9SettingsTestWithFieldTrial
3341 : public Vp9SettingsTest,
3342 public ::testing::WithParamInterface<
3343 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003344 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003345 Vp9SettingsTestWithFieldTrial()
3346 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3347 num_spatial_layers_(::testing::get<1>(GetParam())),
3348 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003349 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003350
3351 void VerifySettings(int num_spatial_layers,
3352 int num_temporal_layers,
3353 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003354 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003355 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003356 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3357
3358 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3359
Niels Möller805a27e2019-01-21 12:21:27 +01003360 webrtc::test::FrameForwarder frame_forwarder;
3361 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003362 channel_->SetSend(true);
3363
Niels Möller805a27e2019-01-21 12:21:27 +01003364 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003365
3366 webrtc::VideoCodecVP9 vp9_settings;
3367 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3368 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3369 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003370 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003371
Niels Möllerff40b142018-04-09 08:49:14 +02003372 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003373 }
Sergey Silkincf267052019-04-09 11:40:09 +02003374
3375 const uint8_t num_spatial_layers_;
3376 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003377 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003378};
3379
Sergey Silkincf267052019-04-09 11:40:09 +02003380TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003381 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3382 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003383}
3384
Sergey Silkincf267052019-04-09 11:40:09 +02003385INSTANTIATE_TEST_SUITE_P(
3386 ,
3387 Vp9SettingsTestWithFieldTrial,
3388 ::testing::Values(
3389 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3390 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3391 1,
3392 1,
3393 webrtc::InterLayerPredMode::kOnKeyPic),
3394 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3395 2,
3396 3,
3397 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003398 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003399 1,
3400 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003401 webrtc::InterLayerPredMode::kOnKeyPic),
3402 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003403 1,
3404 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003405 webrtc::InterLayerPredMode::kOnKeyPic),
3406 std::make_tuple(
3407 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3408 1,
3409 1,
3410 webrtc::InterLayerPredMode::kOff),
3411 std::make_tuple(
3412 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3413 1,
3414 1,
3415 webrtc::InterLayerPredMode::kOn),
3416 std::make_tuple(
3417 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3418 1,
3419 1,
3420 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003421
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003422TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3423 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3424 ASSERT_EQ(1u, streams.size());
3425 EXPECT_EQ(cricket::kMinVideoBitrateBps, streams[0].min_bitrate_bps);
3426}
3427
3428TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003429 RTC_DCHECK(!override_field_trials_);
3430 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003431 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3432 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3433 ASSERT_EQ(1u, streams.size());
3434 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3435}
3436
asapersson3c81a1a2017-06-14 05:52:21 -07003437TEST_F(WebRtcVideoChannelTest,
3438 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003439 RTC_DCHECK(!override_field_trials_);
3440 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003441 "WebRTC-Video-BalancedDegradation/Disabled/");
3442 const bool kResolutionScalingEnabled = true;
3443 const bool kFpsScalingEnabled = false;
3444 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3445}
3446
3447TEST_F(WebRtcVideoChannelTest,
3448 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003449 RTC_DCHECK(!override_field_trials_);
3450 override_field_trials_ = absl::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003451 "WebRTC-Video-BalancedDegradation/Enabled/");
3452 const bool kResolutionScalingEnabled = true;
3453 const bool kFpsScalingEnabled = true;
3454 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3455}
3456
eladalonf1841382017-06-12 01:16:46 -07003457TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003458 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003459}
3460
eladalonf1841382017-06-12 01:16:46 -07003461TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003462 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003463}
3464
Niels Möller3de32e62019-01-18 08:42:18 +01003465TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3466 TestCpuAdaptation(false, true);
3467}
3468
eladalonf1841382017-06-12 01:16:46 -07003469TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003470 TestCpuAdaptation(true, true);
3471}
3472
eladalonf1841382017-06-12 01:16:46 -07003473TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003474 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003475 cricket::VideoSendParameters parameters;
3476 parameters.codecs.push_back(codec);
3477
kthelgason2bc68642017-02-07 07:02:22 -08003478 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003479 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003480 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003481 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3482 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003483 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003484 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3485
3486 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003487 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003488
Per766ad3b2016-04-05 15:23:49 +02003489 ASSERT_TRUE(channel_->SetSend(true));
3490 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003491 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003492 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003493
3494 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3495 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003496
Niels Möllerdcc70292019-01-15 16:32:38 +01003497 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3498 // Dont' expect anything on framerate_scaling_enabled, since the default is
3499 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003500
Niels Möllerdcc70292019-01-15 16:32:38 +01003501 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003502 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003503 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003504 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003505 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3506 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003507 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003508
Niels Möllerdcc70292019-01-15 16:32:38 +01003509 // Switch back to the normal capturer. Expect resolution scaling to be
3510 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003511 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3512 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003513 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3514 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003515 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003516
Niels Möllerff40b142018-04-09 08:49:14 +02003517 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003518}
3519
asapersson3c81a1a2017-06-14 05:52:21 -07003520// TODO(asapersson): Remove this test when the balanced field trial is removed.
3521void WebRtcVideoChannelTest::TestDegradationPreference(
3522 bool resolution_scaling_enabled,
3523 bool fps_scaling_enabled) {
3524 cricket::VideoCodec codec = GetEngineCodec("VP8");
3525 cricket::VideoSendParameters parameters;
3526 parameters.codecs.push_back(codec);
3527
3528 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003529 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003530 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003531 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3532 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003533 channel_->OnReadyToSend(true);
3534
3535 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3536
3537 AddSendStream();
3538
Niels Möller805a27e2019-01-21 12:21:27 +01003539 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003540 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003541 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003542
3543 EXPECT_TRUE(channel_->SetSend(true));
3544
3545 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3546 EXPECT_EQ(resolution_scaling_enabled,
3547 send_stream->resolution_scaling_enabled());
3548 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3549
Niels Möllerff40b142018-04-09 08:49:14 +02003550 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003551}
3552
eladalonf1841382017-06-12 01:16:46 -07003553void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3554 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003555 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003556 cricket::VideoSendParameters parameters;
3557 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003558
kthelgason2bc68642017-02-07 07:02:22 -08003559 MediaConfig media_config = GetMediaConfig();
3560 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003561 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003562 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003563 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003564 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3565 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003566 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003567
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003568 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003569
3570 AddSendStream();
3571
Niels Möller805a27e2019-01-21 12:21:27 +01003572 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003573 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003574 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003575 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003576
3577 EXPECT_TRUE(channel_->SetSend(true));
3578
solenberge5269742015-09-08 05:13:22 -07003579 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003580
sprangc5d62e22017-04-02 23:53:04 -07003581 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003582 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003583 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003584 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003585 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3586 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3587 } else {
3588 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3589 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3590 }
Niels Möllerff40b142018-04-09 08:49:14 +02003591 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003592}
3593
eladalonf1841382017-06-12 01:16:46 -07003594TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003595 // Start at last timestamp to verify that wraparounds are estimated correctly.
3596 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3597 static const int64_t kInitialNtpTimeMs = 1247891230;
3598 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003599 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003600
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003601 FakeVideoReceiveStream* stream = AddRecvStream();
3602 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003603 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003604
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003605 webrtc::VideoFrame video_frame =
3606 webrtc::VideoFrame::Builder()
3607 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3608 .set_timestamp_rtp(kInitialTimestamp)
3609 .set_timestamp_us(0)
3610 .set_rotation(webrtc::kVideoRotation_0)
3611 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003612 // Initial NTP time is not available on the first frame, but should still be
3613 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003614 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003615
3616 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003617
3618 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3619 // triggers a constant-overflow warning, hence we're calculating it explicitly
3620 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003621 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003622 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3623 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003624 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003625
3626 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003627
3628 // Verify that NTP time has been correctly deduced.
3629 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003630 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003631 ASSERT_EQ(1u, info.receivers.size());
3632 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003633}
3634
eladalonf1841382017-06-12 01:16:46 -07003635TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003636 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003637 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003638
3639 VideoCodec codec;
3640 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003641 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003642
3643 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003644 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3645 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003646 FakeVideoSendStream* stream = AddSendStream(
3647 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003648 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003649
3650 // Make sure NACK and FEC are enabled on the correct payload types.
3651 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003652 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3653 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003654
3655 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3656 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003657 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003658 // TODO(juberti): Check RTCP, PLI, TMMBR.
3659}
3660
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003661TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3662 cricket::VideoSendParameters parameters;
3663 parameters.codecs.push_back(GetEngineCodec("VP8"));
3664 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3665
3666 FakeVideoSendStream* stream = AddSendStream();
3667 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3668 EXPECT_FALSE(config.rtp.raw_payload);
3669}
3670
3671TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3672 cricket::VideoSendParameters parameters;
3673 parameters.codecs.push_back(GetEngineCodec("VP8"));
3674 parameters.codecs.back().packetization = kPacketizationParamRaw;
3675 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3676
3677 FakeVideoSendStream* stream = AddSendStream();
3678 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3679 EXPECT_TRUE(config.rtp.raw_payload);
3680}
3681
brandtr31bd2242017-05-19 05:47:46 -07003682// The following four tests ensures that FlexFEC is not activated by default
3683// when the field trials are not enabled.
3684// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3685// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003686TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003687 FakeVideoSendStream* stream = AddSendStream();
3688 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3689
brandtr3d200bd2017-01-16 06:59:19 -08003690 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003691 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3692 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003693}
3694
eladalonf1841382017-06-12 01:16:46 -07003695TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003696 FakeVideoSendStream* stream = AddSendStream(
3697 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3698 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3699
brandtr3d200bd2017-01-16 06:59:19 -08003700 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003701 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3702 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3703}
3704
Yves Gerey665174f2018-06-19 15:03:05 +02003705TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003706 AddRecvStream();
3707
3708 const std::vector<FakeFlexfecReceiveStream*>& streams =
3709 fake_call_->GetFlexfecReceiveStreams();
3710 EXPECT_TRUE(streams.empty());
3711}
3712
eladalonf1841382017-06-12 01:16:46 -07003713TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003714 AddRecvStream(
3715 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3716
3717 const std::vector<FakeFlexfecReceiveStream*>& streams =
3718 fake_call_->GetFlexfecReceiveStreams();
3719 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003720}
3721
3722// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3723// tests that use this test fixture into the corresponding "non-field trial"
3724// tests.
eladalonf1841382017-06-12 01:16:46 -07003725class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003726 public:
eladalonf1841382017-06-12 01:16:46 -07003727 WebRtcVideoChannelFlexfecRecvTest()
3728 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003729};
3730
eladalonf1841382017-06-12 01:16:46 -07003731TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003732 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3733 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3734 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3735}
3736
eladalonf1841382017-06-12 01:16:46 -07003737TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003738 AddRecvStream();
3739
3740 const std::vector<FakeFlexfecReceiveStream*>& streams =
3741 fake_call_->GetFlexfecReceiveStreams();
3742 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003743
3744 const std::vector<FakeVideoReceiveStream*>& video_streams =
3745 fake_call_->GetVideoReceiveStreams();
3746 ASSERT_EQ(1U, video_streams.size());
3747 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3748 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3749 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003750}
3751
eladalonf1841382017-06-12 01:16:46 -07003752TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003753 AddRecvStream(
3754 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3755
3756 const std::vector<FakeFlexfecReceiveStream*>& streams =
3757 fake_call_->GetFlexfecReceiveStreams();
3758 ASSERT_EQ(1U, streams.size());
3759 const FakeFlexfecReceiveStream* stream = streams.front();
3760 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3761 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3762 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3763 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3764 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003765
3766 const std::vector<FakeVideoReceiveStream*>& video_streams =
3767 fake_call_->GetVideoReceiveStreams();
3768 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003769 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3770 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003771 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003772 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003773 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003774}
3775
eladalonf1841382017-06-12 01:16:46 -07003776TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003777 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3778 cricket::VideoRecvParameters recv_parameters;
3779 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3780 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3781
3782 AddRecvStream(
3783 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3784 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003785 const std::vector<FakeVideoReceiveStream*>& video_streams =
3786 fake_call_->GetVideoReceiveStreams();
3787 ASSERT_EQ(1U, video_streams.size());
3788 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3789 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3790 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003791
3792 // Enable FlexFEC.
3793 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3794 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3795 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3796 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3797 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3798 << "Enabling FlexFEC should not create VideoReceiveStream.";
3799 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3800 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003801 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3802 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003803}
3804
eladalonf1841382017-06-12 01:16:46 -07003805TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003806 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3807 cricket::VideoRecvParameters recv_parameters;
3808 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3809 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3810 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3811
3812 AddRecvStream(
3813 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3814 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003815 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003816 const std::vector<FakeVideoReceiveStream*>& video_streams =
3817 fake_call_->GetVideoReceiveStreams();
3818 ASSERT_EQ(1U, video_streams.size());
3819 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3820 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3821 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003822
3823 // Disable FlexFEC.
3824 recv_parameters.codecs.clear();
3825 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3826 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3827 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3828 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3829 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3830 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3831 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3832 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003833 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3834 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003835}
3836
brandtr31bd2242017-05-19 05:47:46 -07003837// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3838// tests that use this test fixture into the corresponding "non-field trial"
3839// tests.
eladalonf1841382017-06-12 01:16:46 -07003840class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003841 public:
eladalonf1841382017-06-12 01:16:46 -07003842 WebRtcVideoChannelFlexfecSendRecvTest()
3843 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003844 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3845 }
3846};
3847
Yves Gerey665174f2018-06-19 15:03:05 +02003848TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003849 FakeVideoSendStream* stream = AddSendStream();
3850 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3851
brandtr3d200bd2017-01-16 06:59:19 -08003852 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3853 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3854 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003855}
3856
eladalonf1841382017-06-12 01:16:46 -07003857TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003858 FakeVideoSendStream* stream = AddSendStream(
3859 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3860 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3861
brandtr3d200bd2017-01-16 06:59:19 -08003862 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3863 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3864 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3865 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003866}
3867
eladalonf1841382017-06-12 01:16:46 -07003868TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003869 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003870 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003871 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003872
3873 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003874 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003875
brandtrb5f2c3f2016-10-04 23:28:39 -07003876 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3877 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003878}
3879
eladalonf1841382017-06-12 01:16:46 -07003880TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003881 cricket::VideoSendParameters parameters;
3882 parameters.codecs.push_back(GetEngineCodec("VP8"));
3883 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3884
3885 FakeVideoSendStream* stream = AddSendStream();
3886 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3887
brandtr3d200bd2017-01-16 06:59:19 -08003888 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003889}
3890
eladalonf1841382017-06-12 01:16:46 -07003891TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003892 AddRecvStream(
3893 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003894
3895 cricket::VideoRecvParameters recv_parameters;
3896 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3897 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3898 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003899
3900 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3901 fake_call_->GetFlexfecReceiveStreams();
3902 ASSERT_EQ(1U, flexfec_streams.size());
3903 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3904 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3905 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003906 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003907 flexfec_stream_config.payload_type);
3908 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3909 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
3910 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
3911 const std::vector<FakeVideoReceiveStream*>& video_streams =
3912 fake_call_->GetVideoReceiveStreams();
3913 const FakeVideoReceiveStream* video_stream = video_streams.front();
3914 const webrtc::VideoReceiveStream::Config& video_stream_config =
3915 video_stream->GetConfig();
3916 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
3917 flexfec_stream_config.local_ssrc);
3918 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3919 EXPECT_EQ(video_stream_config.rtcp_send_transport,
3920 flexfec_stream_config.rtcp_send_transport);
3921 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
3922 // spec-compliant way.
3923 EXPECT_EQ(video_stream_config.rtp.transport_cc,
3924 flexfec_stream_config.transport_cc);
3925 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
3926 EXPECT_EQ(video_stream_config.rtp.extensions,
3927 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08003928}
3929
brandtr31bd2242017-05-19 05:47:46 -07003930// We should not send FlexFEC, even if we advertise it, unless the right
3931// field trial is set.
3932// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07003933TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003934 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
3935 cricket::VideoSendParameters parameters;
3936 parameters.codecs.push_back(GetEngineCodec("VP8"));
3937 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3938 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3939
3940 FakeVideoSendStream* stream = AddSendStream();
3941 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3942
3943 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003944 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003945 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3946}
3947
eladalonf1841382017-06-12 01:16:46 -07003948TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07003949 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
3950 cricket::VideoSendParameters parameters;
3951 parameters.codecs.push_back(GetEngineCodec("VP8"));
3952 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3953 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3954
3955 FakeVideoSendStream* stream = AddSendStream(
3956 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3957 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3958
3959 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02003960 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07003961 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3962}
3963
eladalonf1841382017-06-12 01:16:46 -07003964TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003965 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08003966 const int kUnusedPayloadType = 127;
3967 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
3968
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003969 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003970 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003971 parameters.codecs.push_back(rtx_codec);
3972 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003973 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003974}
3975
eladalonf1841382017-06-12 01:16:46 -07003976TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003977 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08003978 const int kUnusedPayloadType1 = 126;
3979 const int kUnusedPayloadType2 = 127;
3980 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
3981 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
3982 {
3983 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3984 kUnusedPayloadType1, GetEngineCodec("VP8").id);
3985 cricket::VideoSendParameters parameters;
3986 parameters.codecs.push_back(GetEngineCodec("VP8"));
3987 parameters.codecs.push_back(rtx_codec);
3988 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3989 }
3990 {
3991 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
3992 kUnusedPayloadType1, kUnusedPayloadType2);
3993 cricket::VideoSendParameters parameters;
3994 parameters.codecs.push_back(GetEngineCodec("VP8"));
3995 parameters.codecs.push_back(rtx_codec);
3996 EXPECT_FALSE(channel_->SetSendParameters(parameters))
3997 << "RTX without matching video codec should be rejected.";
3998 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003999}
4000
eladalonf1841382017-06-12 01:16:46 -07004001TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004002 const int kUnusedPayloadType1 = 126;
4003 const int kUnusedPayloadType2 = 127;
4004 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4005 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4006
4007 // SSRCs for RTX.
4008 cricket::StreamParams params =
4009 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4010 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4011 AddSendStream(params);
4012
4013 // Original payload type for RTX.
4014 cricket::VideoSendParameters parameters;
4015 parameters.codecs.push_back(GetEngineCodec("VP8"));
4016 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4017 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4018 parameters.codecs.push_back(rtx_codec);
4019 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4020 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4021 const webrtc::VideoSendStream::Config& config_before =
4022 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4023 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4024 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4025 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4026
4027 // Change payload type for RTX.
4028 parameters.codecs[1].id = kUnusedPayloadType2;
4029 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4030 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4031 const webrtc::VideoSendStream::Config& config_after =
4032 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4033 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4034 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4035 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4036}
4037
eladalonf1841382017-06-12 01:16:46 -07004038TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004039 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004040 parameters.codecs.push_back(GetEngineCodec("VP8"));
4041 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004042 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004043
4044 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004045 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004046
magjed509e4fe2016-11-18 01:34:11 -08004047 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004048
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004049 parameters.codecs.pop_back();
4050 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004051 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004052 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004053 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004054 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004055 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4056}
4057
eladalonf1841382017-06-12 01:16:46 -07004058TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004059 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004060 cricket::VideoSendParameters parameters;
4061 parameters.codecs.push_back(GetEngineCodec("VP8"));
4062 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4063 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4064
4065 FakeVideoSendStream* stream = AddSendStream(
4066 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4067 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4068
brandtr3d200bd2017-01-16 06:59:19 -08004069 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4070 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004071 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4072 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4073
4074 parameters.codecs.pop_back();
4075 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4076 stream = fake_call_->GetVideoSendStreams()[0];
4077 ASSERT_TRUE(stream != nullptr);
4078 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004079 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004080 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004081}
4082
eladalonf1841382017-06-12 01:16:46 -07004083TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004084 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004085 cricket::VideoCodec codec(100, "VP8");
4086 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4087 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004088
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004089 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004090 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004091
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004092 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004093 webrtc::test::FrameForwarder frame_forwarder;
4094 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004095
4096 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004097 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004098
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004099 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004100 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4101 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004102 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004103 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004104 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004105 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004106}
4107
eladalonf1841382017-06-12 01:16:46 -07004108TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004109 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4110 200000);
4111}
4112
eladalonf1841382017-06-12 01:16:46 -07004113TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004114 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4115 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4116 ASSERT_EQ(1u, streams.size());
4117 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4118}
4119
eladalonf1841382017-06-12 01:16:46 -07004120TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004121 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004122 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004123}
4124
eladalonf1841382017-06-12 01:16:46 -07004125TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004126 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004127}
4128
eladalonf1841382017-06-12 01:16:46 -07004129TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004130 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4131 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4132 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004133}
4134
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004135// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4136// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004137TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004138 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4139 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4140 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4141 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004142 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004143 ExpectSetBitrateParameters(100000, 200000, 400000);
4144 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4145 // Since the codec isn't changing, start_bitrate_bps should be -1.
4146 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004147
4148 // Decrease max_bandwidth_bps.
4149 send_parameters_.max_bandwidth_bps = 350000;
4150 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004151
4152 // Now try again with the values flipped around.
4153 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4154 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004155 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004156 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004157
4158 // If we change the codec max, max_bandwidth_bps should still apply.
4159 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004160 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004161 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004162}
4163
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004164// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4165// are present in the same send parameters, the settings are combined correctly.
4166TEST_F(WebRtcVideoChannelTest,
4167 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4168 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4169 // Transport.
4170 webrtc::MediaTransportSettings settings;
4171 settings.is_caller = true;
4172 webrtc::FakeMediaTransport fake_media_transport(settings);
4173 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4174 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004175 channel_->SetInterface(network_interface.get(),
4176 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004177
4178 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4179 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4180 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4181 send_parameters_.max_bandwidth_bps = 400000;
4182 {
4183 // We expect max_bandwidth_bps to take priority, if set.
4184 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4185 ASSERT_EQ(1u,
4186 fake_media_transport.target_rate_constraints_in_order().size());
4187 const webrtc::MediaTransportTargetRateConstraints& constraint =
4188 fake_media_transport.target_rate_constraints_in_order()[0];
4189 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4190 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4191 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4192 }
4193
4194 {
4195 // Decrease max_bandwidth_bps.
4196 send_parameters_.max_bandwidth_bps = 350000;
4197 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4198 ASSERT_EQ(2u,
4199 fake_media_transport.target_rate_constraints_in_order().size());
4200 const webrtc::MediaTransportTargetRateConstraints& constraint =
4201 fake_media_transport.target_rate_constraints_in_order()[1];
4202
4203 // Since the codec isn't changing, start_bitrate_bps should be 0.
4204 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4205 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4206 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4207 }
4208
4209 {
4210 // Now try again with the values flipped around.
4211 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4212 send_parameters_.max_bandwidth_bps = 300000;
4213 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4214 ASSERT_EQ(3u,
4215 fake_media_transport.target_rate_constraints_in_order().size());
4216 const webrtc::MediaTransportTargetRateConstraints& constraint =
4217 fake_media_transport.target_rate_constraints_in_order()[2];
4218
4219 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4220 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4221 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4222 }
4223
4224 {
4225 // Now try again with the values flipped around.
4226 // If we change the codec max, max_bandwidth_bps should still apply.
4227 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4228 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4229 ASSERT_EQ(4u,
4230 fake_media_transport.target_rate_constraints_in_order().size());
4231 const webrtc::MediaTransportTargetRateConstraints& constraint =
4232 fake_media_transport.target_rate_constraints_in_order()[3];
4233
4234 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4235 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4236 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4237 }
4238}
4239
Yves Gerey665174f2018-06-19 15:03:05 +02004240TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004241 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4242 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004243 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004244 // Setting max bitrate should keep previous min bitrate.
4245 // Setting max bitrate should not reset start bitrate.
4246 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004247 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004248}
4249
eladalonf1841382017-06-12 01:16:46 -07004250TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004251 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004252 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004253 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004254 // -1 means to disable max bitrate (set infinite).
4255 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004256 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004257 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004258}
4259
eladalonf1841382017-06-12 01:16:46 -07004260TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004261 send_parameters_.max_bandwidth_bps = 99999;
4262 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004263 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004264 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004265 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4266 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4267 stream->GetVideoStreams()[0].max_bitrate_bps);
4268
4269 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004270 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004271 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4272 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004273 stream->GetVideoStreams()[0].max_bitrate_bps);
4274}
4275
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004276// Tests that when the codec specific max bitrate and VideoSendParameters
4277// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4278// appropriately.
4279TEST_F(WebRtcVideoChannelTest,
4280 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4281 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4282 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4283 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4284 send_parameters_.max_bandwidth_bps = -1;
4285 AddSendStream();
4286 ExpectSetMaxBitrate(300000);
4287 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4288
4289 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4290 ASSERT_EQ(1u, video_send_streams.size());
4291 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4292 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4293 // First the max bitrate is set based upon the codec param.
4294 EXPECT_EQ(300000,
4295 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4296
4297 // The VideoSendParameters max bitrate overrides the codec's.
4298 send_parameters_.max_bandwidth_bps = 500000;
4299 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4300 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4301 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4302 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4303}
4304
4305// Tests that when the codec specific max bitrate and RtpParameters
4306// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4307// appropriately.
4308TEST_F(WebRtcVideoChannelTest,
4309 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4310 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4311 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4312 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4313 send_parameters_.max_bandwidth_bps = -1;
4314 AddSendStream();
4315 ExpectSetMaxBitrate(300000);
4316 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4317
4318 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4319 ASSERT_EQ(1u, video_send_streams.size());
4320 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4321 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4322 // First the max bitrate is set based upon the codec param.
4323 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4324
4325 // The RtpParameter max bitrate overrides the codec's.
4326 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4327 ASSERT_EQ(1u, parameters.encodings.size());
4328 parameters.encodings[0].max_bitrate_bps = 500000;
4329 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4330 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4331 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4332 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4333}
4334
Åsa Persson55659812018-06-18 17:51:32 +02004335TEST_F(WebRtcVideoChannelTest,
4336 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4337 send_parameters_.max_bandwidth_bps = 99999;
4338 FakeVideoSendStream* stream = AddSendStream();
4339 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4340 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4341 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4342 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4343 stream->GetVideoStreams()[0].max_bitrate_bps);
4344
4345 // Get and set the rtp encoding parameters.
4346 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4347 EXPECT_EQ(1u, parameters.encodings.size());
4348
4349 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4350 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4351 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4352 stream->GetVideoStreams()[0].max_bitrate_bps);
4353
4354 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4355 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4356 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4357 stream->GetVideoStreams()[0].max_bitrate_bps);
4358}
4359
eladalonf1841382017-06-12 01:16:46 -07004360TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004361 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004362 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004363 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004364 channel_->SetSend(true);
4365
4366 FakeVideoSendStream* stream = AddSendStream();
4367
Niels Möller805a27e2019-01-21 12:21:27 +01004368 webrtc::test::FrameForwarder frame_forwarder;
4369 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004370
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004371 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4372 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4373 EXPECT_GT(initial_max_bitrate_bps, 0);
4374
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004375 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4376 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004377 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004378 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004379 streams = stream->GetVideoStreams();
4380 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004381 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004382}
4383
eladalonf1841382017-06-12 01:16:46 -07004384TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004385 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004386 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004387 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004388 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004389 channel_->SetSend(true);
4390
4391 FakeVideoSendStream* stream = AddSendStream(
4392 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4393
4394 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004395 webrtc::test::FrameForwarder frame_forwarder;
4396 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4397 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004398
4399 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4400 ASSERT_GT(streams.size(), 1u)
4401 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004402 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004403 EXPECT_GT(initial_max_bitrate_bps, 0);
4404
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004405 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4406 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004407 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004408 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004409 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004410 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004411 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4412
Niels Möllerff40b142018-04-09 08:49:14 +02004413 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004414}
4415
eladalonf1841382017-06-12 01:16:46 -07004416TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004417 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004418 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004419 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004420 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4421 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004422 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004423 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004424
4425 VideoCodec codec;
4426 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4427 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4428}
4429
eladalonf1841382017-06-12 01:16:46 -07004430TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004431 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004432 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004433 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004434 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004435 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004436 parameters.codecs[0].id = kIncorrectPayloads[i];
4437 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004438 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004439 }
4440}
4441
eladalonf1841382017-06-12 01:16:46 -07004442TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004443 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004444 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004445 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004446 parameters.codecs[0].id = payload_type;
4447 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004448 << "Payload type '" << payload_type << "' rejected.";
4449 }
4450}
4451
deadbeef67cf2c12016-04-13 10:07:16 -07004452// Test that setting the a different set of codecs but with an identical front
4453// codec doesn't result in the stream being recreated.
4454// This may happen when a subsequent negotiation includes fewer codecs, as a
4455// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004456TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004457 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4458 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004459 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4460 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004461 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4462
4463 AddSendStream();
4464 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4465
4466 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004467 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004468 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4469 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4470}
4471
eladalonf1841382017-06-12 01:16:46 -07004472TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004473 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004474 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004475 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004476}
4477
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004478// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004479TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004480 const int kUnusedPayloadType1 = 126;
4481 const int kUnusedPayloadType2 = 127;
4482 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4483 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4484
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004485 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004486 parameters.codecs.push_back(GetEngineCodec("VP8"));
4487 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004488 parameters.codecs.push_back(rtx_codec);
4489 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004490 << "RTX codec without associated payload should be rejected.";
4491
magjed509e4fe2016-11-18 01:34:11 -08004492 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004493 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004494 << "RTX codec with invalid associated payload type should be rejected.";
4495
magjed509e4fe2016-11-18 01:34:11 -08004496 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004497 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004498
magjed509e4fe2016-11-18 01:34:11 -08004499 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004500 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004501 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004502
Yves Gerey665174f2018-06-19 15:03:05 +02004503 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4504 << "RTX codec with another RTX as associated payload type should be "
4505 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004506}
4507
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004508TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4509 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4510 vp8_codec.packetization = kPacketizationParamRaw;
4511
4512 cricket::VideoRecvParameters parameters;
4513 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4514 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4515
4516 const cricket::StreamParams params =
4517 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4518 AddRecvStream(params);
4519 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4520
4521 const webrtc::VideoReceiveStream::Config& config =
4522 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4523 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4524 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4525}
4526
4527TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4528 cricket::VideoRecvParameters parameters;
4529 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4530 parameters.codecs.back().packetization = kPacketizationParamRaw;
4531 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4532
4533 const cricket::StreamParams params =
4534 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4535 AddRecvStream(params);
4536 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4537 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4538
4539 parameters.codecs.back().packetization.reset();
4540 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4541 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4542}
4543
eladalonf1841382017-06-12 01:16:46 -07004544TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004545 const int kUnusedPayloadType1 = 126;
4546 const int kUnusedPayloadType2 = 127;
4547 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4548 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4549
4550 // SSRCs for RTX.
4551 cricket::StreamParams params =
4552 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4553 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4554 AddRecvStream(params);
4555
4556 // Original payload type for RTX.
4557 cricket::VideoRecvParameters parameters;
4558 parameters.codecs.push_back(GetEngineCodec("VP8"));
4559 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4560 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4561 parameters.codecs.push_back(rtx_codec);
4562 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4563 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4564 const webrtc::VideoReceiveStream::Config& config_before =
4565 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004566 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4567 const int* payload_type_before = FindKeyByValue(
4568 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4569 ASSERT_NE(payload_type_before, nullptr);
4570 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004571 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4572
4573 // Change payload type for RTX.
4574 parameters.codecs[1].id = kUnusedPayloadType2;
4575 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4576 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4577 const webrtc::VideoReceiveStream::Config& config_after =
4578 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004579 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4580 const int* payload_type_after = FindKeyByValue(
4581 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4582 ASSERT_NE(payload_type_after, nullptr);
4583 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004584 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4585}
4586
eladalonf1841382017-06-12 01:16:46 -07004587TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004588 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004589 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004590 parameters.codecs[0].id = 99;
4591 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004592}
4593
eladalonf1841382017-06-12 01:16:46 -07004594TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004595 cricket::VideoRecvParameters parameters;
4596 parameters.codecs = engine_.codecs();
4597 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004598
4599 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004600 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004601 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004602 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004603}
4604
eladalonf1841382017-06-12 01:16:46 -07004605TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004606 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004607 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004608 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004609 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004610}
4611
eladalonf1841382017-06-12 01:16:46 -07004612TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004613 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004614 parameters.codecs.push_back(GetEngineCodec("VP8"));
4615 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004616 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004617}
4618
eladalonf1841382017-06-12 01:16:46 -07004619TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004620 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004621 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4622 send_parameters.codecs.push_back(GetEngineCodec("red"));
4623 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004624 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004625
4626 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004627
magjed509e4fe2016-11-18 01:34:11 -08004628 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004629 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004630
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004631 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004632 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004633 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004634 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004635 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004636 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004637 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4638}
4639
eladalonf1841382017-06-12 01:16:46 -07004640TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004641 AddRecvStream(
4642 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004643 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004644 fake_call_->GetFlexfecReceiveStreams();
4645
4646 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004647 const FakeFlexfecReceiveStream* stream = streams.front();
4648 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4649 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4650 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4651 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004652
4653 cricket::VideoRecvParameters recv_parameters;
4654 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4655 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4656 EXPECT_TRUE(streams.empty())
4657 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004658}
4659
eladalonf1841382017-06-12 01:16:46 -07004660TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004661 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004662 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004663 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004664
4665 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004666 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4667 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4668 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004669 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4670 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004671 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004672 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004673 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004674 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004675
4676 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004677 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4678 send_parameters.codecs.push_back(GetEngineCodec("red"));
4679 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004680 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4681 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004682 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004683 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004684 << "ULPFEC should be enabled on the receive stream.";
4685}
4686
eladalonf1841382017-06-12 01:16:46 -07004687TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004688 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004689 AddRecvStream(
4690 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004691 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004692 fake_call_->GetFlexfecReceiveStreams();
4693
4694 cricket::VideoRecvParameters recv_parameters;
4695 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4696 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4697 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4698 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004699 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004700 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004701 stream_with_recv_params->GetConfig().payload_type);
4702 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004703 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004704 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004705 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004706 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004707
4708 cricket::VideoSendParameters send_parameters;
4709 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4710 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4711 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4712 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004713 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004714 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004715 stream_with_send_params->GetConfig().payload_type);
4716 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004717 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004718 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004719 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004720 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004721}
4722
eladalonf1841382017-06-12 01:16:46 -07004723TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004724 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004725 parameters.codecs.push_back(GetEngineCodec("VP8"));
4726 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004727 parameters.codecs[1].id = parameters.codecs[0].id;
4728 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004729}
4730
eladalonf1841382017-06-12 01:16:46 -07004731TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004732 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004733 cricket::VideoRecvParameters parameters;
4734 parameters.codecs.push_back(GetEngineCodec("VP8"));
4735 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4736 parameters.codecs[1].id = parameters.codecs[0].id;
4737 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4738}
4739
eladalonf1841382017-06-12 01:16:46 -07004740TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004741 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004742 parameters.codecs.push_back(GetEngineCodec("VP8"));
4743 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004744 parameters.codecs[1].id = parameters.codecs[0].id;
4745 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004746}
4747
eladalonf1841382017-06-12 01:16:46 -07004748TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004749 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004750 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004751 parameters.codecs.push_back(GetEngineCodec("VP8"));
4752 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004753 parameters.codecs[1].id += 1;
4754 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004755}
4756
deadbeef67cf2c12016-04-13 10:07:16 -07004757// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004758// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004759TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004760 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004761 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004762 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4763 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004764 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004765
4766 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4767 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4768
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004769 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004770 parameters2.codecs.push_back(GetEngineCodec("red"));
4771 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004772 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004773 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4774}
4775
eladalonf1841382017-06-12 01:16:46 -07004776TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004777 EXPECT_FALSE(AddSendStream()->IsSending());
4778}
4779
eladalonf1841382017-06-12 01:16:46 -07004780TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004781 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004782}
4783
eladalonf1841382017-06-12 01:16:46 -07004784TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004785 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004786 EXPECT_FALSE(stream->IsSending());
4787
4788 // false->true
4789 EXPECT_TRUE(channel_->SetSend(true));
4790 EXPECT_TRUE(stream->IsSending());
4791 // true->true
4792 EXPECT_TRUE(channel_->SetSend(true));
4793 EXPECT_TRUE(stream->IsSending());
4794 // true->false
4795 EXPECT_TRUE(channel_->SetSend(false));
4796 EXPECT_FALSE(stream->IsSending());
4797 // false->false
4798 EXPECT_TRUE(channel_->SetSend(false));
4799 EXPECT_FALSE(stream->IsSending());
4800
4801 EXPECT_TRUE(channel_->SetSend(true));
4802 FakeVideoSendStream* new_stream = AddSendStream();
4803 EXPECT_TRUE(new_stream->IsSending())
4804 << "Send stream created after SetSend(true) not sending initially.";
4805}
4806
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004807// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004808TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004809 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004810 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004811 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004812 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004813 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004814
Sebastian Jansson84848f22018-11-16 10:40:36 +01004815 channel.reset(
4816 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004817 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4818 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004819 channel->SetInterface(network_interface.get(),
4820 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004821 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004822 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004823
Tim Haloun648d28a2018-10-18 16:52:22 -07004824 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4825 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004826 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004827 channel.reset(
4828 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004829 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4830 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004831 channel->SetInterface(network_interface.get(),
4832 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004833 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4834
4835 // Create a send stream to configure
4836 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4837 parameters = channel->GetRtpSendParameters(kSsrc);
4838 ASSERT_FALSE(parameters.encodings.empty());
4839
4840 // Various priorities map to various dscp values.
4841 parameters.encodings[0].network_priority = 4.0;
4842 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004843 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004844 parameters.encodings[0].network_priority = 0.5;
4845 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4846 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4847
4848 // A bad priority does not change the dscp value.
4849 parameters.encodings[0].network_priority = 0.0;
4850 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4851 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004852
Tim Haloun6ca98362018-09-17 17:06:08 -07004853 // Packets should also self-identify their dscp in PacketOptions.
4854 const uint8_t kData[10] = {0};
4855 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4856 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004857 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004858
nisse51542be2016-02-12 02:27:06 -08004859 // Verify that setting the option to false resets the
4860 // DiffServCodePoint.
4861 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004862 channel.reset(
4863 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004864 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4865 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004866 channel->SetInterface(network_interface.get(),
4867 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004868 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004869}
4870
deadbeef13871492015-12-09 12:37:51 -08004871// This test verifies that the RTCP reduced size mode is properly applied to
4872// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004873TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004874 // Create stream, expecting that default mode is "compound".
4875 FakeVideoSendStream* stream1 = AddSendStream();
4876 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004877 webrtc::RtpParameters rtp_parameters =
4878 channel_->GetRtpSendParameters(last_ssrc_);
4879 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004880
4881 // Now enable reduced size mode.
4882 send_parameters_.rtcp.reduced_size = true;
4883 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4884 stream1 = fake_call_->GetVideoSendStreams()[0];
4885 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02004886 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
4887 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08004888
4889 // Create a new stream and ensure it picks up the reduced size mode.
4890 FakeVideoSendStream* stream2 = AddSendStream();
4891 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4892}
4893
4894// This test verifies that the RTCP reduced size mode is properly applied to
4895// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07004896TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004897 // Create stream, expecting that default mode is "compound".
4898 FakeVideoReceiveStream* stream1 = AddRecvStream();
4899 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
4900
4901 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07004902 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
4903 // the reduced_size flag should come from that.
4904 send_parameters_.rtcp.reduced_size = true;
4905 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08004906 stream1 = fake_call_->GetVideoReceiveStreams()[0];
4907 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
4908
4909 // Create a new stream and ensure it picks up the reduced size mode.
4910 FakeVideoReceiveStream* stream2 = AddRecvStream();
4911 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
4912}
4913
eladalonf1841382017-06-12 01:16:46 -07004914TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07004915 EXPECT_EQ(webrtc::kNetworkUp,
4916 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4917 EXPECT_EQ(webrtc::kNetworkUp,
4918 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004919
4920 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07004921 EXPECT_EQ(webrtc::kNetworkDown,
4922 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4923 EXPECT_EQ(webrtc::kNetworkUp,
4924 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00004925
4926 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07004927 EXPECT_EQ(webrtc::kNetworkUp,
4928 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
4929 EXPECT_EQ(webrtc::kNetworkUp,
4930 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004931}
4932
eladalonf1841382017-06-12 01:16:46 -07004933TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004934 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004935 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004936 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01004937
4938 AddSendStream();
4939
4940 cricket::VideoMediaInfo info;
4941 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08004942 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01004943}
4944
eladalonf1841382017-06-12 01:16:46 -07004945TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01004946 FakeVideoSendStream* stream = AddSendStream();
4947 webrtc::VideoSendStream::Stats stats;
4948 stats.encoder_implementation_name = "encoder_implementation_name";
4949 stream->SetStats(stats);
4950
4951 cricket::VideoMediaInfo info;
4952 ASSERT_TRUE(channel_->GetStats(&info));
4953 EXPECT_EQ(stats.encoder_implementation_name,
4954 info.senders[0].encoder_implementation_name);
4955}
4956
eladalonf1841382017-06-12 01:16:46 -07004957TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004958 FakeVideoSendStream* stream = AddSendStream();
4959 webrtc::VideoSendStream::Stats stats;
4960 stats.avg_encode_time_ms = 13;
4961 stats.encode_usage_percent = 42;
4962 stream->SetStats(stats);
4963
4964 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00004965 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00004966 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
4967 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
4968}
4969
eladalonf1841382017-06-12 01:16:46 -07004970TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07004971 FakeVideoSendStream* stream = AddSendStream();
4972 webrtc::VideoSendStream::Stats stats;
4973 stats.frames_encoded = 13;
4974 stream->SetStats(stats);
4975
4976 cricket::VideoMediaInfo info;
4977 ASSERT_TRUE(channel_->GetStats(&info));
4978 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
4979}
4980
Rasmus Brandt2efae772019-06-27 14:29:34 +02004981TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
4982 FakeVideoSendStream* stream = AddSendStream();
4983 webrtc::VideoSendStream::Stats stats;
4984 stats.substreams[123].frame_counts.key_frames = 10;
4985 stats.substreams[456].frame_counts.key_frames = 87;
4986 stream->SetStats(stats);
4987
4988 cricket::VideoMediaInfo info;
4989 ASSERT_TRUE(channel_->GetStats(&info));
4990 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
4991 // for each simulcast stream, instead of accumulating all keyframes encoded
4992 // over all simulcast streams in the same outbound-rtp stats object.
4993 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
4994}
4995
eladalonf1841382017-06-12 01:16:46 -07004996TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07004997 FakeVideoSendStream* stream = AddSendStream();
4998 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01004999 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07005000 stream->SetStats(stats);
5001
5002 cricket::VideoMediaInfo info;
5003 ASSERT_TRUE(channel_->GetStats(&info));
5004 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5005}
5006
eladalonf1841382017-06-12 01:16:46 -07005007TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005008 FakeVideoSendStream* stream = AddSendStream();
5009 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005010 stats.substreams[17].width = 123;
5011 stats.substreams[17].height = 40;
5012 stats.substreams[42].width = 80;
5013 stats.substreams[42].height = 31;
5014 stats.substreams[11].width = 20;
5015 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005016 stream->SetStats(stats);
5017
5018 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005019 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005020 ASSERT_EQ(1u, info.senders.size());
5021 EXPECT_EQ(123, info.senders[0].send_frame_width);
5022 EXPECT_EQ(90, info.senders[0].send_frame_height);
5023}
5024
eladalonf1841382017-06-12 01:16:46 -07005025TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005026 FakeVideoSendStream* stream = AddSendStream();
5027 webrtc::VideoSendStream::Stats stats;
5028 stats.number_of_cpu_adapt_changes = 2;
5029 stats.cpu_limited_resolution = true;
5030 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005031
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005032 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005033 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005034 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005035 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005036 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005037}
5038
eladalonf1841382017-06-12 01:16:46 -07005039TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005040 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005041 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005042 stats.number_of_cpu_adapt_changes = 2;
5043 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005044 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005045 stream->SetStats(stats);
5046
5047 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005048 EXPECT_TRUE(channel_->GetStats(&info));
5049 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005050 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5051 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005052 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005053 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005054}
5055
eladalonf1841382017-06-12 01:16:46 -07005056TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005057 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5058 FakeVideoSendStream* stream = AddSendStream();
5059 webrtc::VideoSendStream::Stats stats;
5060 stats.bw_limited_resolution = true;
5061 stream->SetStats(stats);
5062
5063 cricket::VideoMediaInfo info;
5064 EXPECT_TRUE(channel_->GetStats(&info));
5065 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005066 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005067 info.senders[0].adapt_reason);
5068}
5069
Yves Gerey665174f2018-06-19 15:03:05 +02005070TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005071 FakeVideoSendStream* stream = AddSendStream();
5072 webrtc::VideoSendStream::Stats stats;
5073 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5074 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5075 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5076
5077 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5078 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5079 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5080
5081 stream->SetStats(stats);
5082
5083 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005084 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005085 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5086 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5087 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5088}
5089
eladalonf1841382017-06-12 01:16:46 -07005090TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005091 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5092 FakeVideoReceiveStream* stream = AddRecvStream();
5093 webrtc::VideoReceiveStream::Stats stats;
5094 stats.rtcp_packet_type_counts.fir_packets = 2;
5095 stats.rtcp_packet_type_counts.nack_packets = 3;
5096 stats.rtcp_packet_type_counts.pli_packets = 4;
5097 stream->SetStats(stats);
5098
5099 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005100 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005101 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005102 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005103 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005104 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005105 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005106 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005107}
5108
eladalonf1841382017-06-12 01:16:46 -07005109TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005110 FakeVideoReceiveStream* stream = AddRecvStream();
5111 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005112 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005113 stats.decode_ms = 2;
5114 stats.max_decode_ms = 3;
5115 stats.current_delay_ms = 4;
5116 stats.target_delay_ms = 5;
5117 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005118 stats.jitter_buffer_delay_seconds = 60;
5119 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005120 stats.min_playout_delay_ms = 7;
5121 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005122 stats.width = 9;
5123 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005124 stats.frame_counts.key_frames = 11;
5125 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005126 stats.frames_rendered = 13;
5127 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005128 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005129 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005130 stream->SetStats(stats);
5131
5132 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005133 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005134 EXPECT_EQ(stats.decoder_implementation_name,
5135 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005136 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5137 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5138 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5139 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5140 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005141 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5142 info.receivers[0].jitter_buffer_delay_seconds);
5143 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5144 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005145 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5146 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005147 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5148 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005149 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5150 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005151 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005152 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005153 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005154 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5155 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005156 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005157 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005158}
5159
eladalonf1841382017-06-12 01:16:46 -07005160TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Peter Boström393347f2015-04-22 14:52:45 +02005161 FakeVideoReceiveStream* stream = AddRecvStream();
5162 webrtc::VideoReceiveStream::Stats stats;
5163 stats.rtp_stats.transmitted.payload_bytes = 2;
5164 stats.rtp_stats.transmitted.header_bytes = 3;
5165 stats.rtp_stats.transmitted.padding_bytes = 4;
5166 stats.rtp_stats.transmitted.packets = 5;
srte186d9c32017-08-04 05:03:53 -07005167 stats.rtcp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005168 stats.rtcp_stats.fraction_lost = 7;
5169 stream->SetStats(stats);
5170
5171 cricket::VideoMediaInfo info;
5172 ASSERT_TRUE(channel_->GetStats(&info));
Bjorn Mellembcd068d2019-07-29 22:09:00 +00005173 EXPECT_EQ(stats.rtp_stats.transmitted.payload_bytes +
5174 stats.rtp_stats.transmitted.header_bytes +
5175 stats.rtp_stats.transmitted.padding_bytes,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005176 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Peter Boström393347f2015-04-22 14:52:45 +02005177 EXPECT_EQ(stats.rtp_stats.transmitted.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005178 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
srte186d9c32017-08-04 05:03:53 -07005179 EXPECT_EQ(stats.rtcp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005180}
5181
eladalonf1841382017-06-12 01:16:46 -07005182TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005183 AddSendStream();
5184 AddSendStream();
5185 webrtc::Call::Stats stats;
5186 stats.rtt_ms = 123;
5187 fake_call_->SetStats(stats);
5188
5189 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005190 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005191 ASSERT_EQ(2u, info.senders.size());
5192 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5193 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5194}
5195
eladalonf1841382017-06-12 01:16:46 -07005196TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005197 FakeVideoSendStream* stream = AddSendStream();
5198 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005199 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005200 stats.media_bitrate_bps = 123;
5201 stats.substreams[17].total_bitrate_bps = 1;
5202 stats.substreams[17].retransmit_bitrate_bps = 2;
5203 stats.substreams[42].total_bitrate_bps = 3;
5204 stats.substreams[42].retransmit_bitrate_bps = 4;
5205 stream->SetStats(stats);
5206
5207 FakeVideoSendStream* stream2 = AddSendStream();
5208 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005209 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005210 stats2.media_bitrate_bps = 321;
5211 stats2.substreams[13].total_bitrate_bps = 5;
5212 stats2.substreams[13].retransmit_bitrate_bps = 6;
5213 stats2.substreams[21].total_bitrate_bps = 7;
5214 stats2.substreams[21].retransmit_bitrate_bps = 8;
5215 stream2->SetStats(stats2);
5216
5217 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005218 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005219 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005220 BandwidthEstimationInfo bwe_info;
5221 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005222 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5223 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5224 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5225 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005226 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005227 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005228 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005229 bwe_info.actual_enc_bitrate);
5230 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005231 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005232 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005233 << "Bandwidth stats should take all streams into account.";
5234}
5235
eladalonf1841382017-06-12 01:16:46 -07005236TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005237 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005238
Peter Boström0c4e06b2015-10-07 12:23:21 +02005239 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5240 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005241
5242 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5243 const size_t kDataLength = 12;
5244 uint8_t data[kDataLength];
5245 memset(data, 0, sizeof(data));
5246 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005247 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005248 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005249
5250 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5251 << "No default receive stream created.";
5252 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005253 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005254 << "Default receive stream should not have configured RTX";
5255
5256 EXPECT_TRUE(channel_->AddRecvStream(
5257 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5258 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005259 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005260 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005261 EXPECT_FALSE(
5262 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005263 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005264 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005265 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005266 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005267 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005268 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005269}
5270
eladalonf1841382017-06-12 01:16:46 -07005271TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005272 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005273
Peter Boström0c4e06b2015-10-07 12:23:21 +02005274 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5275 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005276
5277 StreamParams sp =
5278 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5279 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5280
5281 EXPECT_FALSE(channel_->AddSendStream(sp));
5282 EXPECT_FALSE(channel_->AddRecvStream(sp));
5283}
5284
eladalonf1841382017-06-12 01:16:46 -07005285TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005286 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005287
Peter Boström0c4e06b2015-10-07 12:23:21 +02005288 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5289 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005290
5291 StreamParams sp =
5292 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5293
5294 EXPECT_TRUE(channel_->AddSendStream(sp));
5295 EXPECT_TRUE(channel_->AddRecvStream(sp));
5296
5297 // The RTX SSRC is already used in previous streams, using it should fail.
5298 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5299 EXPECT_FALSE(channel_->AddSendStream(sp));
5300 EXPECT_FALSE(channel_->AddRecvStream(sp));
5301
5302 // After removing the original stream this should be fine to add (makes sure
5303 // that RTX ssrcs are not forever taken).
5304 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5305 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5306 EXPECT_TRUE(channel_->AddSendStream(sp));
5307 EXPECT_TRUE(channel_->AddRecvStream(sp));
5308}
5309
eladalonf1841382017-06-12 01:16:46 -07005310TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005311 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005312 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5313 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005314 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005315
Peter Boströmd6f4c252015-03-26 16:23:04 +01005316 StreamParams sp =
5317 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5318
5319 EXPECT_TRUE(channel_->AddSendStream(sp));
5320 EXPECT_TRUE(channel_->AddRecvStream(sp));
5321
5322 // One of the SSRCs is already used in previous streams, using it should fail.
5323 sp = cricket::CreateSimStreamParams("cname",
5324 MAKE_VECTOR(kOverlappingStreamSsrcs));
5325 EXPECT_FALSE(channel_->AddSendStream(sp));
5326 EXPECT_FALSE(channel_->AddRecvStream(sp));
5327
5328 // After removing the original stream this should be fine to add (makes sure
5329 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005330 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5331 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005332 EXPECT_TRUE(channel_->AddSendStream(sp));
5333 EXPECT_TRUE(channel_->AddRecvStream(sp));
5334}
5335
eladalonf1841382017-06-12 01:16:46 -07005336TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005337 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005338
5339 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5340 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5341
5342 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5343 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5344
5345 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5346
5347 static const uint32_t kReceiverSsrcs[] = {3};
5348 static const uint32_t kReceiverRtxSsrcs[] = {2};
5349
5350 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5351 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5352 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5353
5354 cricket::VideoMediaInfo info;
5355 ASSERT_TRUE(channel_->GetStats(&info));
5356
5357 ASSERT_EQ(1u, info.senders.size());
5358 ASSERT_EQ(1u, info.receivers.size());
5359
5360 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5361 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5362 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5363}
5364
eladalonf1841382017-06-12 01:16:46 -07005365TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005366 FakeVideoReceiveStream* stream = AddRecvStream();
5367 webrtc::VideoReceiveStream::Stats stats;
5368 cricket::VideoMediaInfo info;
5369
5370 // Report no codec name before receiving.
5371 stream->SetStats(stats);
5372 ASSERT_TRUE(channel_->GetStats(&info));
5373 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5374
5375 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005376 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005377 stream->SetStats(stats);
5378 ASSERT_TRUE(channel_->GetStats(&info));
5379 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5380
5381 // Report no codec name for unknown playload types.
5382 stats.current_payload_type = 3;
5383 stream->SetStats(stats);
5384 ASSERT_TRUE(channel_->GetStats(&info));
5385 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5386}
5387
Seth Hampson5897a6e2018-04-03 11:16:33 -07005388// Tests that when we add a stream without SSRCs, but contains a stream_id
5389// that it is stored and its stream id is later used when the first packet
5390// arrives to properly create a receive stream with a sync label.
5391TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5392 const char kSyncLabel[] = "sync_label";
5393 cricket::StreamParams unsignaled_stream;
5394 unsignaled_stream.set_stream_ids({kSyncLabel});
5395 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5396 // The stream shouldn't have been created at this point because it doesn't
5397 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005398 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005399
5400 // Create and deliver packet.
5401 const size_t kDataLength = 12;
5402 uint8_t data[kDataLength];
5403 memset(data, 0, sizeof(data));
5404 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5405 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005406 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005407
5408 // The stream should now be created with the appropriate sync label.
5409 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5410 EXPECT_EQ(kSyncLabel,
5411 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5412
5413 // Removing the unsignaled stream should clear the cache. This time when
5414 // a default video receive stream is created it won't have a sync_group.
5415 ASSERT_TRUE(channel_->RemoveRecvStream(0));
5416 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5417 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5418
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005419 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005420 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5421 EXPECT_TRUE(
5422 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5423}
5424
Ruslan Burakov493a6502019-02-27 15:32:48 +01005425// Test BaseMinimumPlayoutDelayMs on receive streams.
5426TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5427 // Test that set won't work for non-existing receive streams.
5428 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5429 // Test that get won't work for non-existing receive streams.
5430 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5431
5432 EXPECT_TRUE(AddRecvStream());
5433 // Test that set works for the existing receive stream.
5434 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5435 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5436 EXPECT_TRUE(recv_stream);
5437 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5438 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5439 200);
5440}
5441
5442// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5443TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5444 absl::optional<int> delay_ms;
5445 const FakeVideoReceiveStream* recv_stream;
5446
5447 // Set default stream with SSRC 0
5448 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5449 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5450
5451 // Spawn an unsignaled stream by sending a packet, it should inherit
5452 // default delay 200.
5453 const size_t kDataLength = 12;
5454 uint8_t data[kDataLength];
5455 memset(data, 0, sizeof(data));
5456 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5457 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005458 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005459
5460 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5461 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5462 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5463 EXPECT_EQ(200, delay_ms.value_or(0));
5464
5465 // Check that now if we change delay for SSRC 0 it will change delay for the
5466 // default receiving stream as well.
5467 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5468 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5469 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5470 EXPECT_EQ(300, delay_ms.value_or(0));
5471 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5472 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5473}
5474
eladalonf1841382017-06-12 01:16:46 -07005475void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005476 uint8_t payload_type,
5477 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005478 // kRedRtxPayloadType must currently be unused.
5479 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5480
noahricd10a68e2015-07-10 11:27:55 -07005481 // Add a RED RTX codec.
5482 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005483 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005484 recv_parameters_.codecs.push_back(red_rtx_codec);
5485 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005486
5487 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5488 const size_t kDataLength = 12;
5489 uint8_t data[kDataLength];
5490 memset(data, 0, sizeof(data));
5491
5492 rtc::Set8(data, 1, payload_type);
5493 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005494 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005495 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005496
5497 if (expect_created_receive_stream) {
5498 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5499 << "Should have created a receive stream for payload type: "
5500 << payload_type;
5501 } else {
5502 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5503 << "Shouldn't have created a receive stream for payload type: "
5504 << payload_type;
5505 }
5506}
5507
Åsa Persson2c7149b2018-10-15 09:36:10 +02005508class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5509 public:
5510 WebRtcVideoChannelDiscardUnknownSsrcTest()
5511 : WebRtcVideoChannelTest(
5512 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5513};
5514
5515TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5516 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5517 false /* expect_created_receive_stream */);
5518}
5519
eladalonf1841382017-06-12 01:16:46 -07005520TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005521 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5522 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005523}
5524
eladalonf1841382017-06-12 01:16:46 -07005525TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005526 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5527 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005528}
5529
eladalonf1841382017-06-12 01:16:46 -07005530TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005531 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005532 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5533 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5534 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5535 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005536}
5537
eladalonf1841382017-06-12 01:16:46 -07005538TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005539 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5540 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005541}
5542
eladalonf1841382017-06-12 01:16:46 -07005543TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005544 FlexfecPacketDoesntCreateUnsignalledStream) {
5545 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5546 false /* expect_created_receive_stream */);
5547}
5548
eladalonf1841382017-06-12 01:16:46 -07005549TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005550 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5551 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005552}
5553
mzanaty8a855d62017-02-17 15:46:43 -08005554// Test that receiving any unsignalled SSRC works even if it changes.
5555// The first unsignalled SSRC received will create a default receive stream.
5556// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005557TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005558 // Allow receiving VP8, VP9, H264 (if enabled).
5559 cricket::VideoRecvParameters parameters;
5560 parameters.codecs.push_back(GetEngineCodec("VP8"));
5561 parameters.codecs.push_back(GetEngineCodec("VP9"));
5562
5563#if defined(WEBRTC_USE_H264)
5564 cricket::VideoCodec H264codec(126, "H264");
5565 parameters.codecs.push_back(H264codec);
5566#endif
5567
5568 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5569 // No receive streams yet.
5570 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5571 cricket::FakeVideoRenderer renderer;
5572 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5573
5574 // Receive VP8 packet on first SSRC.
5575 uint8_t data[kMinRtpPacketLen];
5576 cricket::RtpHeader rtpHeader;
5577 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5578 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005579 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005580 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5581 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005582 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005583 // VP8 packet should create default receive stream.
5584 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005585 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005586 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5587 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005588 webrtc::VideoFrame video_frame =
5589 webrtc::VideoFrame::Builder()
5590 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5591 .set_timestamp_rtp(100)
5592 .set_timestamp_us(0)
5593 .set_rotation(webrtc::kVideoRotation_0)
5594 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005595 recv_stream->InjectFrame(video_frame);
5596 EXPECT_EQ(1, renderer.num_rendered_frames());
5597
5598 // Receive VP9 packet on second SSRC.
5599 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005600 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005601 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5602 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005603 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005604 // VP9 packet should replace the default receive SSRC.
5605 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5606 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5607 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5608 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005609 webrtc::VideoFrame video_frame2 =
5610 webrtc::VideoFrame::Builder()
5611 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5612 .set_timestamp_rtp(200)
5613 .set_timestamp_us(0)
5614 .set_rotation(webrtc::kVideoRotation_0)
5615 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005616 recv_stream->InjectFrame(video_frame2);
5617 EXPECT_EQ(2, renderer.num_rendered_frames());
5618
5619#if defined(WEBRTC_USE_H264)
5620 // Receive H264 packet on third SSRC.
5621 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005622 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005623 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5624 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005625 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005626 // H264 packet should replace the default receive SSRC.
5627 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5628 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5629 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5630 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005631 webrtc::VideoFrame video_frame3 =
5632 webrtc::VideoFrame::Builder()
5633 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5634 .set_timestamp_rtp(300)
5635 .set_timestamp_us(0)
5636 .set_rotation(webrtc::kVideoRotation_0)
5637 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005638 recv_stream->InjectFrame(video_frame3);
5639 EXPECT_EQ(3, renderer.num_rendered_frames());
5640#endif
5641}
5642
brandtr0dc57ea2017-05-29 23:33:31 -07005643// This test verifies that when a new default stream is created for a new
5644// unsignaled SSRC, the new stream does not overwrite any old stream that had
5645// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005646TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005647 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5648 cricket::VideoRecvParameters parameters;
5649 parameters.codecs.push_back(GetEngineCodec("VP8"));
5650 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5651
5652 // No streams signaled and no packets received, so we should not have any
5653 // stream objects created yet.
5654 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5655
5656 // Receive packet on an unsignaled SSRC.
5657 uint8_t data[kMinRtpPacketLen];
5658 cricket::RtpHeader rtp_header;
5659 rtp_header.payload_type = GetEngineCodec("VP8").id;
5660 rtp_header.seq_num = rtp_header.timestamp = 0;
5661 rtp_header.ssrc = kSsrcs3[0];
5662 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5663 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005664 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005665 // Default receive stream should be created.
5666 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5667 FakeVideoReceiveStream* recv_stream0 =
5668 fake_call_->GetVideoReceiveStreams()[0];
5669 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5670
5671 // Signal the SSRC.
5672 EXPECT_TRUE(
5673 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5674 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5675 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5676 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5677
5678 // Receive packet on a different unsignaled SSRC.
5679 rtp_header.ssrc = kSsrcs3[1];
5680 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5681 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005682 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005683 // New default receive stream should be created, but old stream should remain.
5684 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5685 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5686 FakeVideoReceiveStream* recv_stream1 =
5687 fake_call_->GetVideoReceiveStreams()[1];
5688 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5689}
5690
Seth Hampson7c682e02018-05-04 16:28:15 -07005691TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005692 AddSendStream();
5693
Niels Möller805a27e2019-01-21 12:21:27 +01005694 webrtc::test::FrameForwarder frame_forwarder;
5695 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005696 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005697 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005698
perkjfa10b552016-10-02 23:45:26 -07005699 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005700 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005701
5702 // TODO(skvlad): Resolve the inconsistency between the interpretation
5703 // of the global bitrate limit for audio and video:
5704 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5705 // max_bandwidth_bps = -1 - remove the bandwidth limit
5706 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005707 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005708
perkjfa10b552016-10-02 23:45:26 -07005709 SetAndExpectMaxBitrate(1000, 0, 1000);
5710 SetAndExpectMaxBitrate(1000, 800, 800);
5711 SetAndExpectMaxBitrate(600, 800, 600);
5712 SetAndExpectMaxBitrate(0, 800, 800);
5713 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005714
Niels Möllerff40b142018-04-09 08:49:14 +02005715 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005716}
5717
eladalonf1841382017-06-12 01:16:46 -07005718TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005719 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005720 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005721 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005722
5723 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005724 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005725 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005726}
5727
eladalonf1841382017-06-12 01:16:46 -07005728TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005729 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005730 FakeVideoSendStream* stream = AddSendStream();
5731
Seth Hampson7c682e02018-05-04 16:28:15 -07005732 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5733 EXPECT_EQ(1UL, parameters.encodings.size());
5734 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5735 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5736
5737 // Note that this is testing the behavior of the FakeVideoSendStream, which
5738 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5739 // we are just testing the behavior of
5740 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005741 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5742 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005743
5744 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5745 // by this amount.
5746 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5747 int low_max_bitrate_bps = kMinVideoBitrateBps - 1000;
5748 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5749 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5750
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005751 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5752 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5753 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5754}
5755
5756TEST_F(WebRtcVideoChannelTest,
5757 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5758 FakeVideoSendStream* stream = AddSendStream();
5759
5760 // Note that this is testing the behavior of the FakeVideoSendStream, which
5761 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5762 // we are just testing the behavior of
5763 // EncoderStreamFactory::CreateEncoderStreams.
5764 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5765 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5766
5767 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5768 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5769 EXPECT_EQ(1UL, parameters.encodings.size());
5770 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5771 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5772
5773 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5774 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5775 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5776}
5777
5778TEST_F(WebRtcVideoChannelTest,
5779 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5780 send_parameters_.max_bandwidth_bps = 99999;
5781 FakeVideoSendStream* stream = AddSendStream();
5782 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5783 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5784 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5785 EXPECT_EQ(kMinVideoBitrateBps, stream->GetVideoStreams()[0].min_bitrate_bps);
5786 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5787 stream->GetVideoStreams()[0].max_bitrate_bps);
5788
5789 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5790 // adjusted down.
5791 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5792 EXPECT_EQ(1UL, parameters.encodings.size());
5793 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5794 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5795 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5796 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5797 stream->GetVideoStreams()[0].min_bitrate_bps);
5798 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5799 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005800}
5801
Åsa Persson8c1bf952018-09-13 10:42:19 +02005802TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5803 FakeVideoSendStream* stream = AddSendStream();
5804
5805 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5806 EXPECT_EQ(1UL, parameters.encodings.size());
5807 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5808 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5809
5810 // Note that this is testing the behavior of the FakeVideoSendStream, which
5811 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5812 // we are just testing the behavior of
5813 // EncoderStreamFactory::CreateEncoderStreams.
5814 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5815 EXPECT_EQ(kDefaultVideoMaxFramerate,
5816 stream->GetVideoStreams()[0].max_framerate);
5817
5818 // Set max framerate and check that VideoStream.max_framerate is set.
5819 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5820 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5821 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5822 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5823
5824 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5825 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5826}
5827
Åsa Persson23eba222018-10-02 14:47:06 +02005828TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5829 FakeVideoSendStream* stream = AddSendStream();
5830
5831 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5832 EXPECT_EQ(1UL, parameters.encodings.size());
5833 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5834 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5835
5836 // Note that this is testing the behavior of the FakeVideoSendStream, which
5837 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5838 // we are just testing the behavior of
5839 // EncoderStreamFactory::CreateEncoderStreams.
5840 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5841 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5842
5843 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5844 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5845 parameters.encodings[0].num_temporal_layers = 2;
5846 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5847
5848 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5849 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5850}
5851
Seth Hampson7c682e02018-05-04 16:28:15 -07005852TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005853 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005854 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005855 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005856 // Two or more encodings should result in failure.
5857 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005858 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005859 // Zero encodings should also fail.
5860 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005861 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005862}
5863
Zach Stein3ca452b2018-01-18 10:01:24 -08005864TEST_F(WebRtcVideoChannelTest,
5865 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5866 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5867 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5868 AddSendStream(sp);
5869
5870 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5871
5872 // Additional encodings should result in failure.
5873 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005874 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005875 // Zero encodings should also fail.
5876 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005877 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08005878}
5879
deadbeeffb2aced2017-01-06 23:05:37 -08005880// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07005881TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08005882 AddSendStream();
5883 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01005884 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08005885 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005886}
5887
Seth Hampson24722b32017-12-22 09:36:42 -08005888// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
5889// a value <= 0, setting the parameters returns false.
5890TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
5891 AddSendStream();
5892 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5893 EXPECT_EQ(1UL, parameters.encodings.size());
5894 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5895 parameters.encodings[0].bitrate_priority);
5896
5897 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08005898 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005899 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08005900 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005901}
5902
5903// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
5904// properly on the VideoChannel and propogates down to the video encoder.
5905TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
5906 AddSendStream();
5907 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5908 EXPECT_EQ(1UL, parameters.encodings.size());
5909 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5910 parameters.encodings[0].bitrate_priority);
5911
5912 // Change the value and set it on the VideoChannel.
5913 double new_bitrate_priority = 2.0;
5914 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005915 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005916
5917 // Verify that the encoding parameters bitrate_priority is set for the
5918 // VideoChannel.
5919 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5920 EXPECT_EQ(1UL, parameters.encodings.size());
5921 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5922
5923 // Verify that the new value propagated down to the encoder.
5924 std::vector<FakeVideoSendStream*> video_send_streams =
5925 fake_call_->GetVideoSendStreams();
5926 EXPECT_EQ(1UL, video_send_streams.size());
5927 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5928 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5929 // appropriately.
5930 EXPECT_EQ(new_bitrate_priority,
5931 video_send_stream->GetEncoderConfig().bitrate_priority);
5932 // Check that the vector of VideoStreams also was propagated correctly. Note
5933 // that this is testing the behavior of the FakeVideoSendStream, which mimics
5934 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005935 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005936 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5937}
5938
5939// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
5940// VideoChannel and the value propogates to the video encoder with all simulcast
5941// streams.
5942TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
5943 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005944 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08005945 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5946 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
5947 AddSendStream(stream_params);
5948 uint32_t primary_ssrc = stream_params.first_ssrc();
5949
Niels Möller805a27e2019-01-21 12:21:27 +01005950 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01005951 // frame. This creates multiple VideoStreams for all simulcast layers when
5952 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01005953 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08005954 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01005955 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08005956 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01005957 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
5958 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
5959 rtc::kNumMicrosecsPerSec / 30));
5960
Seth Hampson24722b32017-12-22 09:36:42 -08005961 // Get and set the rtp encoding parameters.
5962 webrtc::RtpParameters parameters =
5963 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005964 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005965 EXPECT_EQ(webrtc::kDefaultBitratePriority,
5966 parameters.encodings[0].bitrate_priority);
5967 // Change the value and set it on the VideoChannel.
5968 double new_bitrate_priority = 2.0;
5969 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08005970 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08005971
5972 // Verify that the encoding parameters priority is set on the VideoChannel.
5973 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02005974 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08005975 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
5976
5977 // Verify that the new value propagated down to the encoder.
5978 std::vector<FakeVideoSendStream*> video_send_streams =
5979 fake_call_->GetVideoSendStreams();
5980 EXPECT_EQ(1UL, video_send_streams.size());
5981 FakeVideoSendStream* video_send_stream = video_send_streams.front();
5982 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
5983 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005984 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08005985 video_send_stream->GetEncoderConfig().number_of_streams);
5986 EXPECT_EQ(new_bitrate_priority,
5987 video_send_stream->GetEncoderConfig().bitrate_priority);
5988 // Check that the vector of VideoStreams also propagated correctly. The
5989 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
5990 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02005991 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02005992 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08005993 video_send_stream->GetVideoStreams()[0].bitrate_priority);
5994 // Since we are only setting bitrate priority per-sender, the other
5995 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02005996 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005997 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02005998 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08005999 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02006000 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006001}
6002
Tim Haloun648d28a2018-10-18 16:52:22 -07006003// RTCRtpEncodingParameters.network_priority must be one of a few values
6004// derived from the default priority, corresponding to very-low, low, medium,
6005// or high.
6006TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6007 AddSendStream();
6008 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6009 EXPECT_EQ(1UL, parameters.encodings.size());
6010 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6011 parameters.encodings[0].network_priority);
6012
6013 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6014 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6015 for (auto it : good_values) {
6016 parameters.encodings[0].network_priority = it;
6017 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6018 }
6019 for (auto it : bad_values) {
6020 parameters.encodings[0].network_priority = it;
6021 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6022 }
6023}
6024
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006025TEST_F(WebRtcVideoChannelTest,
6026 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006027 VideoSendParameters parameters;
6028 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006029 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6030 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6031
6032 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006033 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006034
6035 VideoOptions options;
6036 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6037 channel_->SetSend(true);
6038
6039 // Try layers in natural order (smallest to largest).
6040 {
6041 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6042 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6043 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6044 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6045 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6046 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6047 ASSERT_TRUE(result.ok());
6048
6049 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6050
6051 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6052 ASSERT_EQ(3u, video_streams.size());
6053 EXPECT_EQ(320u, video_streams[0].width);
6054 EXPECT_EQ(180u, video_streams[0].height);
6055 EXPECT_EQ(640u, video_streams[1].width);
6056 EXPECT_EQ(360u, video_streams[1].height);
6057 EXPECT_EQ(1280u, video_streams[2].width);
6058 EXPECT_EQ(720u, video_streams[2].height);
6059 }
6060
6061 // Try layers in reverse natural order (largest to smallest).
6062 {
6063 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6064 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6065 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6066 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6067 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6068 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6069 ASSERT_TRUE(result.ok());
6070
6071 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6072
6073 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6074 ASSERT_EQ(3u, video_streams.size());
6075 EXPECT_EQ(1280u, video_streams[0].width);
6076 EXPECT_EQ(720u, video_streams[0].height);
6077 EXPECT_EQ(640u, video_streams[1].width);
6078 EXPECT_EQ(360u, video_streams[1].height);
6079 EXPECT_EQ(320u, video_streams[2].width);
6080 EXPECT_EQ(180u, video_streams[2].height);
6081 }
6082
6083 // Try layers in mixed order.
6084 {
6085 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6086 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6087 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6088 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6089 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6090 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6091 ASSERT_TRUE(result.ok());
6092
6093 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6094
6095 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6096 ASSERT_EQ(3u, video_streams.size());
6097 EXPECT_EQ(128u, video_streams[0].width);
6098 EXPECT_EQ(72u, video_streams[0].height);
6099 EXPECT_EQ(640u, video_streams[1].width);
6100 EXPECT_EQ(360u, video_streams[1].height);
6101 EXPECT_EQ(320u, video_streams[2].width);
6102 EXPECT_EQ(180u, video_streams[2].height);
6103 }
6104
6105 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6106 {
6107 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6108 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6109 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6110 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6111 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6112 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6113 ASSERT_TRUE(result.ok());
6114
6115 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6116
6117 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6118 ASSERT_EQ(3u, video_streams.size());
6119 EXPECT_EQ(1280u, video_streams[0].width);
6120 EXPECT_EQ(720u, video_streams[0].height);
6121 EXPECT_EQ(1280u, video_streams[1].width);
6122 EXPECT_EQ(720u, video_streams[1].height);
6123 EXPECT_EQ(320u, video_streams[2].width);
6124 EXPECT_EQ(180u, video_streams[2].height);
6125 }
6126
6127 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6128}
6129
6130TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006131 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6132 // Ensure that the top layer has width and height divisible by 2^3,
6133 // so that the bottom layer has width and height divisible by 2.
6134 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6135 // the number of simulcast layers set by the app.
6136 webrtc::test::ScopedFieldTrials field_trial(
6137 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6138
6139 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6140 VideoSendParameters parameters;
6141 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6142 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6143 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6144 webrtc::test::FrameForwarder frame_forwarder;
6145 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6146 &frame_forwarder));
6147 channel_->SetSend(true);
6148
6149 // Set |scale_resolution_down_by|'s.
6150 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6151 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6152 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6153 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6154 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6155 const auto result =
6156 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6157 ASSERT_TRUE(result.ok());
6158
6159 // Use a capture resolution whose width and height are not divisible by 2^3.
6160 // (See field trial set at the top of the test.)
6161 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6162 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6163
6164 // Ensure the scaling is correct.
6165 const auto video_streams = stream->GetVideoStreams();
6166 ASSERT_EQ(video_streams.size(), 3u);
6167 // Ensure that we round the capture resolution down for the top layer...
6168 EXPECT_EQ(video_streams[0].width, 2000u);
6169 EXPECT_EQ(video_streams[0].height, 1200u);
6170 EXPECT_EQ(video_streams[1].width, 1000u);
6171 EXPECT_EQ(video_streams[1].height, 600u);
6172 // ...and that the bottom layer has a width/height divisible by 2.
6173 EXPECT_EQ(video_streams[2].width, 500u);
6174 EXPECT_EQ(video_streams[2].height, 300u);
6175
6176 // Tear down.
6177 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6178}
6179
6180TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006181 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006182 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6183 VideoSendParameters parameters;
6184 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006185 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6186 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6187
6188 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006189 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006190
6191 VideoOptions options;
6192 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6193 channel_->SetSend(true);
6194
6195 // Try layers in natural order (smallest to largest).
6196 {
6197 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6198 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6199 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6200 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6201 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6202 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6203 ASSERT_TRUE(result.ok());
6204
6205 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6206
6207 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6208 ASSERT_EQ(3u, video_streams.size());
6209 EXPECT_EQ(320u, video_streams[0].width);
6210 EXPECT_EQ(180u, video_streams[0].height);
6211 EXPECT_EQ(640u, video_streams[1].width);
6212 EXPECT_EQ(360u, video_streams[1].height);
6213 EXPECT_EQ(1280u, video_streams[2].width);
6214 EXPECT_EQ(720u, video_streams[2].height);
6215 }
6216
6217 // Try layers in reverse natural order (largest to smallest).
6218 {
6219 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6220 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6221 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6222 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6223 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6224 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6225 ASSERT_TRUE(result.ok());
6226
6227 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6228
6229 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6230 ASSERT_EQ(3u, video_streams.size());
6231 EXPECT_EQ(1280u, video_streams[0].width);
6232 EXPECT_EQ(720u, video_streams[0].height);
6233 EXPECT_EQ(640u, video_streams[1].width);
6234 EXPECT_EQ(360u, video_streams[1].height);
6235 EXPECT_EQ(320u, video_streams[2].width);
6236 EXPECT_EQ(180u, video_streams[2].height);
6237 }
6238
6239 // Try layers in mixed order.
6240 {
6241 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6242 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6243 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6244 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6245 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6246 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6247 ASSERT_TRUE(result.ok());
6248
6249 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6250
6251 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6252 ASSERT_EQ(3u, video_streams.size());
6253 EXPECT_EQ(128u, video_streams[0].width);
6254 EXPECT_EQ(72u, video_streams[0].height);
6255 EXPECT_EQ(640u, video_streams[1].width);
6256 EXPECT_EQ(360u, video_streams[1].height);
6257 EXPECT_EQ(320u, video_streams[2].width);
6258 EXPECT_EQ(180u, video_streams[2].height);
6259 }
6260
6261 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6262 {
6263 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6264 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6265 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6266 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6267 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6268 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6269 ASSERT_TRUE(result.ok());
6270
6271 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6272
6273 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6274 ASSERT_EQ(3u, video_streams.size());
6275 EXPECT_EQ(1280u, video_streams[0].width);
6276 EXPECT_EQ(720u, video_streams[0].height);
6277 EXPECT_EQ(1280u, video_streams[1].width);
6278 EXPECT_EQ(720u, video_streams[1].height);
6279 EXPECT_EQ(320u, video_streams[2].width);
6280 EXPECT_EQ(180u, video_streams[2].height);
6281 }
6282 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6283}
6284
Rasmus Brandt9387b522019-02-05 14:23:26 +01006285TEST_F(WebRtcVideoChannelTest,
6286 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6287 // Ensure that the top layer has width and height divisible by 2^3,
6288 // so that the bottom layer has width and height divisible by 2.
6289 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6290 // the number of simulcast layers set by the app.
6291 webrtc::test::ScopedFieldTrials field_trial(
6292 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6293
6294 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6295 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6296 VideoSendParameters parameters;
6297 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6298 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6299 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6300 webrtc::test::FrameForwarder frame_forwarder;
6301 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6302 &frame_forwarder));
6303 channel_->SetSend(true);
6304
6305 // Set |scale_resolution_down_by|'s.
6306 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6307 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6308 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6309 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6310 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6311 const auto result =
6312 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6313 ASSERT_TRUE(result.ok());
6314
6315 // Use a capture resolution whose width and height are not divisible by 2^3.
6316 // (See field trial set at the top of the test.)
6317 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6318 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6319
6320 // Ensure the scaling is correct.
6321 const auto video_streams = stream->GetVideoStreams();
6322 ASSERT_EQ(video_streams.size(), 3u);
6323 // Ensure that we round the capture resolution down for the top layer...
6324 EXPECT_EQ(video_streams[0].width, 2000u);
6325 EXPECT_EQ(video_streams[0].height, 1200u);
6326 EXPECT_EQ(video_streams[1].width, 1000u);
6327 EXPECT_EQ(video_streams[1].height, 600u);
6328 // ...and that the bottom layer has a width/height divisible by 2.
6329 EXPECT_EQ(video_streams[2].width, 500u);
6330 EXPECT_EQ(video_streams[2].height, 300u);
6331
6332 // Tear down.
6333 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6334}
6335
Åsa Persson8c1bf952018-09-13 10:42:19 +02006336TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6337 const size_t kNumSimulcastStreams = 3;
6338 SetUpSimulcast(true, false);
6339
6340 // Get and set the rtp encoding parameters.
6341 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6342 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6343 for (const auto& encoding : parameters.encodings) {
6344 EXPECT_FALSE(encoding.max_framerate);
6345 }
6346
6347 // Change the value and set it on the VideoChannel.
6348 parameters.encodings[0].max_framerate = 10;
6349 parameters.encodings[1].max_framerate = 20;
6350 parameters.encodings[2].max_framerate = 25;
6351 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6352
6353 // Verify that the bitrates are set on the VideoChannel.
6354 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6355 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6356 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6357 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6358 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6359}
6360
Åsa Persson23eba222018-10-02 14:47:06 +02006361TEST_F(WebRtcVideoChannelTest,
6362 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6363 const size_t kNumSimulcastStreams = 3;
6364 SetUpSimulcast(true, false);
6365
6366 // Get and set the rtp encoding parameters.
6367 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6368 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6369
6370 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6371 parameters.encodings[0].num_temporal_layers = 0;
6372 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6373 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6374 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6375 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6376 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6377}
6378
6379TEST_F(WebRtcVideoChannelTest,
6380 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6381 const size_t kNumSimulcastStreams = 3;
6382 SetUpSimulcast(true, false);
6383
6384 // Get and set the rtp encoding parameters.
6385 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6386 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6387
6388 // No/all layers should be set.
6389 parameters.encodings[0].num_temporal_layers = 1;
6390 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6391 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6392
6393 // Different values not supported.
6394 parameters.encodings[0].num_temporal_layers = 1;
6395 parameters.encodings[1].num_temporal_layers = 2;
6396 parameters.encodings[2].num_temporal_layers = 2;
6397 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6398 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6399}
6400
6401TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6402 const size_t kNumSimulcastStreams = 3;
6403 SetUpSimulcast(true, false);
6404
6405 // Get and set the rtp encoding parameters.
6406 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6407 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6408 for (const auto& encoding : parameters.encodings)
6409 EXPECT_FALSE(encoding.num_temporal_layers);
6410
6411 // Change the value and set it on the VideoChannel.
6412 parameters.encodings[0].num_temporal_layers = 3;
6413 parameters.encodings[1].num_temporal_layers = 3;
6414 parameters.encodings[2].num_temporal_layers = 3;
6415 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6416
6417 // Verify that the number of temporal layers are set on the VideoChannel.
6418 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6419 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6420 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6421 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6422 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6423}
6424
6425TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6426 const size_t kNumSimulcastStreams = 3;
6427 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6428
6429 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006430 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006431 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006432 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006433 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006434 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006435
6436 // Get and set the rtp encoding parameters.
6437 // Change the value and set it on the VideoChannel.
6438 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6439 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6440 parameters.encodings[0].num_temporal_layers = 2;
6441 parameters.encodings[1].num_temporal_layers = 2;
6442 parameters.encodings[2].num_temporal_layers = 2;
6443 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6444
6445 // Verify that the new value is propagated down to the encoder.
6446 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6447 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6448 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6449 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6450 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6451 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6452 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6453 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6454
6455 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6456 // VideoStreams are created appropriately for the simulcast case.
6457 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6458 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6459 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6460 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6461
6462 // No parameter changed, encoder should not be reconfigured.
6463 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6464 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6465
6466 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6467}
6468
6469TEST_F(WebRtcVideoChannelTest,
6470 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6471 const size_t kDefaultNumTemporalLayers = 3;
6472 const size_t kNumSimulcastStreams = 3;
6473 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6474
6475 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006476 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006477 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006478 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006479 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006480 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006481
6482 // Change rtp encoding parameters, num_temporal_layers not changed.
6483 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6484 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6485 parameters.encodings[0].min_bitrate_bps = 33000;
6486 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6487
6488 // Verify that no value is propagated down to the encoder.
6489 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6490 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6491 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6492 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6493 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6494 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6495
6496 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6497 // VideoStreams are created appropriately for the simulcast case.
6498 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6499 EXPECT_EQ(kDefaultNumTemporalLayers,
6500 stream->GetVideoStreams()[0].num_temporal_layers);
6501 EXPECT_EQ(kDefaultNumTemporalLayers,
6502 stream->GetVideoStreams()[1].num_temporal_layers);
6503 EXPECT_EQ(kDefaultNumTemporalLayers,
6504 stream->GetVideoStreams()[2].num_temporal_layers);
6505
6506 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6507}
6508
Åsa Persson8c1bf952018-09-13 10:42:19 +02006509TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6510 const size_t kNumSimulcastStreams = 3;
6511 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6512
6513 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006514 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006515 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006516 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006517 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006518 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006519
6520 // Get and set the rtp encoding parameters.
6521 // Change the value and set it on the VideoChannel.
6522 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6523 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6524 parameters.encodings[0].max_framerate = 15;
6525 parameters.encodings[1].max_framerate = 25;
6526 parameters.encodings[2].max_framerate = 20;
6527 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6528
6529 // Verify that the new value propagated down to the encoder.
6530 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6531 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6532 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6533 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6534 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6535 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6536 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6537 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6538
6539 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6540 // VideoStreams are created appropriately for the simulcast case.
6541 // Currently the maximum |max_framerate| is used.
6542 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6543 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6544 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6545 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6546
6547 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6548}
6549
6550TEST_F(WebRtcVideoChannelTest,
6551 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6552 const size_t kNumSimulcastStreams = 3;
6553 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6554 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6555
6556 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006557 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006558 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006559 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006560 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006561 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006562
6563 // Get and set the rtp encoding parameters.
6564 // Change the value and set it on the VideoChannel.
6565 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6566 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6567 parameters.encodings[0].max_framerate = 15;
6568 parameters.encodings[2].max_framerate = 20;
6569 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6570
6571 // Verify that the new value propagated down to the encoder.
6572 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6573 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6574 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6575 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6576 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6577 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6578 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6579
6580 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6581 // VideoStreams are created appropriately for the simulcast case.
6582 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6583 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6584 EXPECT_EQ(kDefaultVideoMaxFramerate,
6585 stream->GetVideoStreams()[0].max_framerate);
6586 EXPECT_EQ(kDefaultVideoMaxFramerate,
6587 stream->GetVideoStreams()[1].max_framerate);
6588 EXPECT_EQ(kDefaultVideoMaxFramerate,
6589 stream->GetVideoStreams()[2].max_framerate);
6590
6591 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6592}
6593
Åsa Persson55659812018-06-18 17:51:32 +02006594TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6595 const size_t kNumSimulcastStreams = 3;
6596 SetUpSimulcast(true, false);
6597
6598 // Get and set the rtp encoding parameters.
6599 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6600 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6601 for (const auto& encoding : parameters.encodings) {
6602 EXPECT_FALSE(encoding.min_bitrate_bps);
6603 EXPECT_FALSE(encoding.max_bitrate_bps);
6604 }
6605
6606 // Change the value and set it on the VideoChannel.
6607 parameters.encodings[0].min_bitrate_bps = 100000;
6608 parameters.encodings[0].max_bitrate_bps = 200000;
6609 parameters.encodings[1].min_bitrate_bps = 300000;
6610 parameters.encodings[1].max_bitrate_bps = 400000;
6611 parameters.encodings[2].min_bitrate_bps = 500000;
6612 parameters.encodings[2].max_bitrate_bps = 600000;
6613 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6614
6615 // Verify that the bitrates are set on the VideoChannel.
6616 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6617 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6618 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6619 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6620 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6621 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6622 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6623 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6624}
6625
6626TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6627 const size_t kNumSimulcastStreams = 3;
6628 SetUpSimulcast(true, false);
6629
6630 // Get and set the rtp encoding parameters.
6631 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6632 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6633
6634 // Max bitrate lower than min bitrate should fail.
6635 parameters.encodings[2].min_bitrate_bps = 100000;
6636 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6637 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6638 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6639}
6640
6641// Test that min and max bitrate values set via RtpParameters are correctly
6642// propagated to the underlying encoder, and that the target is set to 3/4 of
6643// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6644// that are used if no min/max are specified).
6645TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6646 const size_t kNumSimulcastStreams = 3;
6647 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6648
6649 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006650 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006651 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006652 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006653 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006654 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006655
6656 // Get and set the rtp encoding parameters.
6657 // Change the value and set it on the VideoChannel.
6658 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6659 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6660 parameters.encodings[0].min_bitrate_bps = 100000;
6661 parameters.encodings[0].max_bitrate_bps = 200000;
6662 parameters.encodings[1].min_bitrate_bps = 300000;
6663 parameters.encodings[1].max_bitrate_bps = 400000;
6664 parameters.encodings[2].min_bitrate_bps = 500000;
6665 parameters.encodings[2].max_bitrate_bps = 600000;
6666 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6667
6668 // Verify that the new value propagated down to the encoder.
6669 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6670 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6671 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6672 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6673 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6674 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6675 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6676 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6677 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6678 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6679 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6680
6681 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6682 // VideoStreams are created appropriately for the simulcast case.
6683 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6684 // Target bitrate: 200000 * 3 / 4 = 150000.
6685 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6686 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6687 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6688 // Target bitrate: 400000 * 3 / 4 = 300000.
6689 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6690 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6691 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6692 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6693 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6694 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6695 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6696
6697 // No parameter changed, encoder should not be reconfigured.
6698 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6699 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6700
6701 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6702}
6703
6704// Test to only specify the min or max bitrate value for a layer via
6705// RtpParameters. The unspecified min/max and target value should be set to the
6706// simulcast default that is used if no min/max are specified.
6707TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6708 const size_t kNumSimulcastStreams = 3;
6709 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6710 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6711
6712 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006713 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006714 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006715 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006716 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006717 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006718
6719 // Get and set the rtp encoding parameters.
6720 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6721 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6722
6723 // Change the value and set it on the VideoChannel.
6724 // Layer 0: only configure min bitrate.
6725 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6726 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6727 // Layer 1: only configure max bitrate.
6728 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6729 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6730 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6731
6732 // Verify that the new value propagated down to the encoder.
6733 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6734 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6735 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6736 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6737 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6738 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6739 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6740 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6741 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6742 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6743
6744 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6745 // VideoStreams are created appropriately for the simulcast case.
6746 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6747 // Layer 0: min configured bitrate should overwrite min default.
6748 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6749 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6750 stream->GetVideoStreams()[0].target_bitrate_bps);
6751 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6752 stream->GetVideoStreams()[0].max_bitrate_bps);
6753 // Layer 1: max configured bitrate should overwrite max default.
6754 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6755 stream->GetVideoStreams()[1].min_bitrate_bps);
6756 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6757 stream->GetVideoStreams()[1].target_bitrate_bps);
6758 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6759 // Layer 2: min and max bitrate not configured, default expected.
6760 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6761 stream->GetVideoStreams()[2].min_bitrate_bps);
6762 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6763 stream->GetVideoStreams()[2].target_bitrate_bps);
6764 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6765 stream->GetVideoStreams()[2].max_bitrate_bps);
6766
6767 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6768}
6769
6770// Test that specifying the min (or max) bitrate value for a layer via
6771// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6772// unspecified values accordingly.
6773TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6774 const size_t kNumSimulcastStreams = 3;
6775 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6776 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6777
6778 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006779 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006780 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006781 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006782 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006783 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006784
6785 // Get and set the rtp encoding parameters.
6786 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6787 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6788
6789 // Change the value and set it on the VideoChannel.
6790 // For layer 0, set the min bitrate above the default max.
6791 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6792 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6793 // For layer 1, set the max bitrate below the default min.
6794 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6795 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6796 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6797
6798 // Verify that the new value propagated down to the encoder.
6799 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6800 // VideoStreams are created appropriately for the simulcast case.
6801 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6802 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6803 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6804 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6805 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6806 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6807 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6808 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6809 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6810 // Layer 2: min and max bitrate not configured, default expected.
6811 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6812 stream->GetVideoStreams()[2].min_bitrate_bps);
6813 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6814 stream->GetVideoStreams()[2].target_bitrate_bps);
6815 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6816 stream->GetVideoStreams()[2].max_bitrate_bps);
6817
6818 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6819}
6820
6821TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6822 const size_t kNumSimulcastStreams = 3;
6823 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6824 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6825
6826 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006827 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006828 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006829 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006830 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006831 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006832
6833 // Set max bitrate for all but the highest layer.
6834 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6835 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6836 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6837 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6838 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6839
6840 // Set max bandwidth equal to total max bitrate.
6841 send_parameters_.max_bandwidth_bps =
6842 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6843 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6844 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6845
6846 // No bitrate above the total max to give to the highest layer.
6847 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6848 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6849 stream->GetVideoStreams()[2].max_bitrate_bps);
6850
6851 // Set max bandwidth above the total max bitrate.
6852 send_parameters_.max_bandwidth_bps =
6853 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6854 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6855 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6856
6857 // The highest layer has no max bitrate set -> the bitrate above the total
6858 // max should be given to the highest layer.
6859 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6860 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6861 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6862 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6863 stream->GetVideoStreams()[2].max_bitrate_bps);
6864
6865 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6866}
6867
6868TEST_F(WebRtcVideoChannelTest,
6869 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6870 const size_t kNumSimulcastStreams = 3;
6871 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6872 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6873 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6874
6875 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006876 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006877 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006878 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006879 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006880 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006881
6882 // Set max bitrate for the highest layer.
6883 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6884 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6885 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
6886 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6887
6888 // Set max bandwidth above the total max bitrate.
6889 send_parameters_.max_bandwidth_bps =
6890 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6891 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6892 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6893
6894 // The highest layer has the max bitrate set -> the bitrate above the total
6895 // max should not be given to the highest layer.
6896 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6897 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
6898 stream->GetVideoStreams()[2].max_bitrate_bps);
6899
6900 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6901}
6902
Åsa Perssonbdee46d2018-06-25 11:28:06 +02006903// Test that min and max bitrate values set via RtpParameters are correctly
6904// propagated to the underlying encoder for a single stream.
6905TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
6906 FakeVideoSendStream* stream = AddSendStream();
6907 EXPECT_TRUE(channel_->SetSend(true));
6908 EXPECT_TRUE(stream->IsSending());
6909
6910 // Set min and max bitrate.
6911 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6912 EXPECT_EQ(1u, parameters.encodings.size());
6913 parameters.encodings[0].min_bitrate_bps = 80000;
6914 parameters.encodings[0].max_bitrate_bps = 150000;
6915 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6916
6917 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6918 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6919 EXPECT_EQ(1u, encoder_config.number_of_streams);
6920 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6921 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6922 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6923
6924 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6925 // VideoStreams are created appropriately.
6926 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6927 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
6928 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6929 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
6930}
6931
6932// Test the default min and max bitrate value are correctly propagated to the
6933// underlying encoder for a single stream (when the values are not set via
6934// RtpParameters).
6935TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
6936 FakeVideoSendStream* stream = AddSendStream();
6937 EXPECT_TRUE(channel_->SetSend(true));
6938 EXPECT_TRUE(stream->IsSending());
6939
6940 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6941 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6942 EXPECT_EQ(1u, encoder_config.number_of_streams);
6943 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
6944 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
6945 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6946
6947 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6948 // VideoStreams are created appropriately.
6949 EXPECT_EQ(1u, stream->GetVideoStreams().size());
6950 EXPECT_EQ(cricket::kMinVideoBitrateBps,
6951 stream->GetVideoStreams()[0].min_bitrate_bps);
6952 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
6953 stream->GetVideoStreams()[0].min_bitrate_bps);
6954 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
6955 stream->GetVideoStreams()[0].target_bitrate_bps);
6956}
6957
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07006958// Test that a stream will not be sending if its encoding is made inactive
6959// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08006960TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07006961 FakeVideoSendStream* stream = AddSendStream();
6962 EXPECT_TRUE(channel_->SetSend(true));
6963 EXPECT_TRUE(stream->IsSending());
6964
6965 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07006966 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07006967 ASSERT_EQ(1u, parameters.encodings.size());
6968 ASSERT_TRUE(parameters.encodings[0].active);
6969 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08006970 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006971 EXPECT_FALSE(stream->IsSending());
6972
6973 // Now change it back to active and verify we resume sending.
6974 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08006975 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07006976 EXPECT_TRUE(stream->IsSending());
6977}
6978
Seth Hampson8234ead2018-02-02 15:16:24 -08006979// Tests that when active is updated for any simulcast layer then the send
6980// stream's sending state will be updated and it will be reconfigured with the
6981// new appropriate active simulcast streams.
6982TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
6983 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006984 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08006985 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6986 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6987 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
6988 uint32_t primary_ssrc = stream_params.first_ssrc();
6989
Niels Möller805a27e2019-01-21 12:21:27 +01006990 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006991 // frame. This allows us to test that ReconfigureEncoder is called
6992 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01006993 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08006994 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006995 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08006996 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006997 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6998 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6999 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08007000
7001 // Check that all encodings are initially active.
7002 webrtc::RtpParameters parameters =
7003 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007004 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007005 EXPECT_TRUE(parameters.encodings[0].active);
7006 EXPECT_TRUE(parameters.encodings[1].active);
7007 EXPECT_TRUE(parameters.encodings[2].active);
7008 EXPECT_TRUE(fake_video_send_stream->IsSending());
7009
7010 // Only turn on only the middle stream.
7011 parameters.encodings[0].active = false;
7012 parameters.encodings[1].active = true;
7013 parameters.encodings[2].active = false;
7014 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7015 // Verify that the active fields are set on the VideoChannel.
7016 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007017 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007018 EXPECT_FALSE(parameters.encodings[0].active);
7019 EXPECT_TRUE(parameters.encodings[1].active);
7020 EXPECT_FALSE(parameters.encodings[2].active);
7021 // Check that the VideoSendStream is updated appropriately. This means its
7022 // send state was updated and it was reconfigured.
7023 EXPECT_TRUE(fake_video_send_stream->IsSending());
7024 std::vector<webrtc::VideoStream> simulcast_streams =
7025 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007026 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007027 EXPECT_FALSE(simulcast_streams[0].active);
7028 EXPECT_TRUE(simulcast_streams[1].active);
7029 EXPECT_FALSE(simulcast_streams[2].active);
7030
7031 // Turn off all streams.
7032 parameters.encodings[0].active = false;
7033 parameters.encodings[1].active = false;
7034 parameters.encodings[2].active = false;
7035 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7036 // Verify that the active fields are set on the VideoChannel.
7037 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007038 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007039 EXPECT_FALSE(parameters.encodings[0].active);
7040 EXPECT_FALSE(parameters.encodings[1].active);
7041 EXPECT_FALSE(parameters.encodings[2].active);
7042 // Check that the VideoSendStream is off.
7043 EXPECT_FALSE(fake_video_send_stream->IsSending());
7044 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007045 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007046 EXPECT_FALSE(simulcast_streams[0].active);
7047 EXPECT_FALSE(simulcast_streams[1].active);
7048 EXPECT_FALSE(simulcast_streams[2].active);
7049
Niels Möllerff40b142018-04-09 08:49:14 +02007050 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007051}
7052
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007053// Test that if a stream is reconfigured (due to a codec change or other
7054// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007055TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007056 InactiveStreamDoesntStartSendingWhenReconfigured) {
7057 // Set an initial codec list, which will be modified later.
7058 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007059 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7060 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007061 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7062
7063 FakeVideoSendStream* stream = AddSendStream();
7064 EXPECT_TRUE(channel_->SetSend(true));
7065 EXPECT_TRUE(stream->IsSending());
7066
7067 // Get current parameters and change "active" to false.
7068 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7069 ASSERT_EQ(1u, parameters.encodings.size());
7070 ASSERT_TRUE(parameters.encodings[0].active);
7071 parameters.encodings[0].active = false;
7072 EXPECT_EQ(1u, GetFakeSendStreams().size());
7073 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007074 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007075 EXPECT_FALSE(stream->IsSending());
7076
7077 // Reorder the codec list, causing the stream to be reconfigured.
7078 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007079 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7080 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007081 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7082 auto new_streams = GetFakeSendStreams();
7083 // Assert that a new underlying stream was created due to the codec change.
7084 // Otherwise, this test isn't testing what it set out to test.
7085 EXPECT_EQ(1u, GetFakeSendStreams().size());
7086 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7087
7088 // Verify that we still are not sending anything, due to the inactive
7089 // encoding.
7090 EXPECT_FALSE(new_streams[0]->IsSending());
7091}
7092
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007093// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007094TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007095 AddSendStream();
7096 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007097 parameters.codecs.push_back(GetEngineCodec("VP8"));
7098 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007099 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7100
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007101 webrtc::RtpParameters rtp_parameters =
7102 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007103 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007104 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7105 rtp_parameters.codecs[0]);
7106 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7107 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007108}
7109
Florent Castellidacec712018-05-24 16:24:21 +02007110// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7111TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7112 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7113 params.cname = "rtcpcname";
7114 AddSendStream(params);
7115
7116 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7117 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7118}
7119
deadbeeffb2aced2017-01-06 23:05:37 -08007120// Test that RtpParameters for send stream has one encoding and it has
7121// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007122TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007123 AddSendStream();
7124
7125 webrtc::RtpParameters rtp_parameters =
7126 channel_->GetRtpSendParameters(last_ssrc_);
7127 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007128 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007129}
7130
Florent Castelliabe301f2018-06-12 18:33:49 +02007131TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7132 AddSendStream();
7133
7134 webrtc::RtpParameters rtp_parameters =
7135 channel_->GetRtpSendParameters(last_ssrc_);
7136 rtp_parameters.header_extensions.emplace_back();
7137
7138 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7139
7140 webrtc::RTCError result =
7141 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7142 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7143}
7144
Florent Castelli87b3c512018-07-18 16:00:28 +02007145TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7146 AddSendStream();
7147
Niels Möller805a27e2019-01-21 12:21:27 +01007148 webrtc::test::FrameForwarder frame_forwarder;
7149 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007150
7151 webrtc::RtpParameters rtp_parameters =
7152 channel_->GetRtpSendParameters(last_ssrc_);
7153 EXPECT_EQ(rtp_parameters.degradation_preference,
7154 webrtc::DegradationPreference::BALANCED);
7155 rtp_parameters.degradation_preference =
7156 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7157
7158 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7159
7160 webrtc::RtpParameters updated_rtp_parameters =
7161 channel_->GetRtpSendParameters(last_ssrc_);
7162 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7163 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7164
7165 // Remove the source since it will be destroyed before the channel
7166 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7167}
7168
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007169// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007170TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007171 AddSendStream();
7172 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007173 parameters.codecs.push_back(GetEngineCodec("VP8"));
7174 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007175 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7176
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007177 webrtc::RtpParameters initial_params =
7178 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007179
7180 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007181 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007182
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007183 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7184 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7185}
7186
7187// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007188TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007189 AddRecvStream();
7190 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007191 parameters.codecs.push_back(GetEngineCodec("VP8"));
7192 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007193 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7194
7195 webrtc::RtpParameters rtp_parameters =
7196 channel_->GetRtpReceiveParameters(last_ssrc_);
7197 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007198 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7199 rtp_parameters.codecs[0]);
7200 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7201 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007202}
7203
johan073ece42016-08-26 02:59:47 -07007204#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007205TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007206#else
eladalonf1841382017-06-12 01:16:46 -07007207TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007208#endif
johan3859c892016-08-05 09:19:25 -07007209 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007210 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007211 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007212 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007213 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007214 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007215 parameters.codecs.push_back(kH264sprop2);
7216 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7217
7218 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7219 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7220 webrtc::RtpParameters rtp_parameters =
7221 channel_->GetRtpReceiveParameters(last_ssrc_);
7222 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7223 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7224 ASSERT_EQ(2u, cfg.decoders.size());
7225 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007226 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007227 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007228 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7229 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007230 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007231
7232 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007233 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007234 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007235 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7236 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007237 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007238}
7239
sakal1fd95952016-06-22 00:46:15 -07007240// Test that RtpParameters for receive stream has one encoding and it has
7241// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007242TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007243 AddRecvStream();
7244
7245 webrtc::RtpParameters rtp_parameters =
7246 channel_->GetRtpReceiveParameters(last_ssrc_);
7247 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007248 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007249}
7250
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007251// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007252TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007253 AddRecvStream();
7254 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007255 parameters.codecs.push_back(GetEngineCodec("VP8"));
7256 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007257 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7258
7259 webrtc::RtpParameters initial_params =
7260 channel_->GetRtpReceiveParameters(last_ssrc_);
7261
7262 // We should be able to set the params we just got.
7263 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7264
7265 // ... And this shouldn't change the params returned by
7266 // GetRtpReceiveParameters.
7267 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007268}
7269
deadbeef3bc15102017-04-20 19:25:07 -07007270// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7271// aren't signaled. It should always return an empty "RtpEncodingParameters",
7272// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007273TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007274 // Call necessary methods to configure receiving a default stream as
7275 // soon as it arrives.
7276 cricket::VideoRecvParameters parameters;
7277 parameters.codecs.push_back(GetEngineCodec("VP8"));
7278 parameters.codecs.push_back(GetEngineCodec("VP9"));
7279 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7280
7281 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7282 // stream. Should return nothing.
7283 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7284
7285 // Set a sink for an unsignaled stream.
7286 cricket::FakeVideoRenderer renderer;
7287 // Value of "0" means "unsignaled stream".
7288 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7289
7290 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7291 // in this method means "unsignaled stream".
7292 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7293 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7294 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7295
7296 // Receive VP8 packet.
7297 uint8_t data[kMinRtpPacketLen];
7298 cricket::RtpHeader rtpHeader;
7299 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7300 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7301 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7302 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7303 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007304 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007305
7306 // The |ssrc| member should still be unset.
7307 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7308 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7309 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7310}
7311
eladalonf1841382017-06-12 01:16:46 -07007312void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007313 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007314 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007315
7316 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007317 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007318 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007319 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007320
7321 if (receiver_first) {
7322 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7323 std::vector<FakeVideoReceiveStream*> receive_streams =
7324 fake_call_->GetVideoReceiveStreams();
7325 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007326 // Default local SSRC when we have no sender.
7327 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7328 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007329 }
7330 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7331 if (!receiver_first)
7332 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7333 std::vector<FakeVideoReceiveStream*> receive_streams =
7334 fake_call_->GetVideoReceiveStreams();
7335 ASSERT_EQ(1u, receive_streams.size());
7336 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007337
7338 // Removing first sender should fall back to another (in this case the second)
7339 // local send stream's SSRC.
7340 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7341 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007342 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007343 ASSERT_EQ(1u, receive_streams.size());
7344 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7345
7346 // Removing the last sender should fall back to default local SSRC.
7347 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007348 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007349 ASSERT_EQ(1u, receive_streams.size());
7350 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7351 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007352}
7353
eladalonf1841382017-06-12 01:16:46 -07007354TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007355 TestReceiverLocalSsrcConfiguration(false);
7356}
7357
eladalonf1841382017-06-12 01:16:46 -07007358TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007359 TestReceiverLocalSsrcConfiguration(true);
7360}
7361
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007362class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007363 public:
eladalonf1841382017-06-12 01:16:46 -07007364 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007365 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007366 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7367 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007368 mock_rate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007369 absl::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007370 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007371 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007372 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007373 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007374 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007375
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007376 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007377 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007378 channel_.reset(engine_.CreateMediaChannel(
7379 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7380 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007381 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007382 last_ssrc_ = 123;
7383 }
7384
7385 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007386 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007387 int capture_width,
7388 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007389 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007390 size_t expected_num_streams,
7391 bool screenshare,
7392 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007393 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007394 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007395 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007396 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007397
Peter Boström0c4e06b2015-10-07 12:23:21 +02007398 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007399 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007400 ssrcs.resize(num_configured_streams);
7401
sprangf24a0642017-02-28 13:23:26 -08007402 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007403 // Send a full-size frame to trigger a stream reconfiguration to use all
7404 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007405 webrtc::test::FrameForwarder frame_forwarder;
7406 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7407 rtc::kNumMicrosecsPerSec / 30);
7408
sprangf24a0642017-02-28 13:23:26 -08007409 VideoOptions options;
7410 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007411 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007412 EXPECT_TRUE(
7413 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007414 // Fetch the latest stream since SetVideoSend() may recreate it if the
7415 // screen content setting is changed.
7416 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007417 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007418 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007419
Zach Stein3ca452b2018-01-18 10:01:24 -08007420 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7421 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7422
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007423 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7424 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007425 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007426
sprang429600d2017-01-26 06:12:26 -08007427 std::vector<webrtc::VideoStream> expected_streams;
Florent Castelli66b38602019-07-10 16:57:57 +02007428 if (num_configured_streams > 1 || conference_mode) {
sprang429600d2017-01-26 06:12:26 -08007429 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007430 num_configured_streams, capture_width, capture_height,
Florent Castelli66b38602019-07-10 16:57:57 +02007431 webrtc::kDefaultBitratePriority, kDefaultQpMax,
7432 screenshare && conference_mode, true);
7433 if (screenshare && conference_mode) {
sprang3ebabf12017-02-16 07:35:22 -08007434 for (const webrtc::VideoStream& stream : expected_streams) {
7435 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007436 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7437 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007438 }
7439 }
sprang429600d2017-01-26 06:12:26 -08007440 } else {
7441 webrtc::VideoStream stream;
7442 stream.width = capture_width;
7443 stream.height = capture_height;
7444 stream.max_framerate = kDefaultVideoMaxFramerate;
Åsa Persson45bbc8a2017-11-13 10:16:47 +01007445 stream.min_bitrate_bps = cricket::kMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007446 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007447 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007448 stream.max_qp = kDefaultQpMax;
7449 expected_streams.push_back(stream);
7450 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007451
7452 ASSERT_EQ(expected_streams.size(), video_streams.size());
7453
7454 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007455 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007456 for (size_t i = 0; i < num_streams; ++i) {
7457 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7458 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7459
7460 EXPECT_GT(video_streams[i].max_framerate, 0);
7461 EXPECT_EQ(expected_streams[i].max_framerate,
7462 video_streams[i].max_framerate);
7463
7464 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7465 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7466 video_streams[i].min_bitrate_bps);
7467
7468 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7469 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7470 video_streams[i].target_bitrate_bps);
7471
7472 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7473 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7474 video_streams[i].max_bitrate_bps);
7475
7476 EXPECT_GT(video_streams[i].max_qp, 0);
7477 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7478
Florent Castelli66b38602019-07-10 16:57:57 +02007479 EXPECT_EQ(num_configured_streams > 1 || conference_mode,
Sergey Silkina796a7e2018-03-01 15:11:29 +01007480 expected_streams[i].num_temporal_layers.has_value());
7481
7482 if (conference_mode) {
7483 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7484 video_streams[i].num_temporal_layers);
7485 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007486
7487 if (i == num_streams - 1) {
7488 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7489 } else {
7490 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7491 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007492 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007493
Niels Möllerff40b142018-04-09 08:49:14 +02007494 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007495 }
7496
7497 FakeVideoSendStream* AddSendStream() {
7498 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7499 }
7500
7501 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007502 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007503 EXPECT_TRUE(channel_->AddSendStream(sp));
7504 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007505 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007506 EXPECT_EQ(num_streams + 1, streams.size());
7507 return streams[streams.size() - 1];
7508 }
7509
7510 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007511 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007512 }
7513
7514 FakeVideoReceiveStream* AddRecvStream() {
7515 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7516 }
7517
7518 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007519 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007520 EXPECT_TRUE(channel_->AddRecvStream(sp));
7521 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007522 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007523 EXPECT_EQ(num_streams + 1, streams.size());
7524 return streams[streams.size() - 1];
7525 }
7526
skvlad11a9cbf2016-10-07 11:53:05 -07007527 webrtc::RtcEventLogNullImpl event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007528 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007529 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7530 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007531 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7532 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007533 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007534 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007535 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007536};
7537
eladalonf1841382017-06-12 01:16:46 -07007538TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007539 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7540 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007541}
7542
eladalonf1841382017-06-12 01:16:46 -07007543TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007544 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7545 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007546}
7547
7548// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007549TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007550 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7551 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007552}
sprang429600d2017-01-26 06:12:26 -08007553
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007554TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Florent Castelli66b38602019-07-10 16:57:57 +02007555 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007556 false);
7557}
7558
eladalonf1841382017-06-12 01:16:46 -07007559TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007560 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7561 true);
7562}
7563
Florent Castelli66b38602019-07-10 16:57:57 +02007564TEST_F(WebRtcVideoChannelSimulcastTest, SimulcastScreenshareWithoutConference) {
7565 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
sprangfe627f32017-03-29 08:24:59 -07007566 false);
7567}
7568
Chen Xing90f3b892019-06-25 10:16:14 +02007569TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7570 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007571
Chen Xing90f3b892019-06-25 10:16:14 +02007572 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007573 EXPECT_TRUE(SetDefaultCodec());
7574 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007575 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007576
Chen Xing90f3b892019-06-25 10:16:14 +02007577 // Send and receive one frame.
7578 SendFrame();
7579 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007580
Chen Xing90f3b892019-06-25 10:16:14 +02007581 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7582 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7583 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007584
Chen Xing90f3b892019-06-25 10:16:14 +02007585 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7586 EXPECT_EQ(source.source_id(), kSsrc);
7587 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7588 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7589 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007590
Chen Xing90f3b892019-06-25 10:16:14 +02007591 // Send and receive another frame.
7592 SendFrame();
7593 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007594
Chen Xing90f3b892019-06-25 10:16:14 +02007595 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7596 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7597 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007598
Chen Xing90f3b892019-06-25 10:16:14 +02007599 source = channel_->GetSources(kSsrc)[0];
7600 EXPECT_EQ(source.source_id(), kSsrc);
7601 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7602 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7603 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007604
Chen Xing90f3b892019-06-25 10:16:14 +02007605 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7606 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007607}
7608
Amit Hilbuchb000b712019-02-25 10:22:14 -08007609TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7610 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7611
7612 std::vector<std::string> rids = {"f", "h", "q"};
7613 std::vector<cricket::RidDescription> rid_descriptions;
7614 for (const auto& rid : rids) {
7615 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7616 }
7617 sp.set_rids(rid_descriptions);
7618
7619 ASSERT_TRUE(channel_->AddSendStream(sp));
7620 const auto& streams = fake_call_->GetVideoSendStreams();
7621 ASSERT_EQ(1u, streams.size());
7622 auto stream = streams[0];
7623 ASSERT_NE(stream, nullptr);
7624 const auto& config = stream->GetConfig();
7625 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7626}
7627
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007628} // namespace cricket