blob: b4a0a6195ab69069b76c1fd49d7715fdb2455a73 [file] [log] [blame]
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001/*
kjellander1afca732016-02-07 20:46:45 -08002 * Copyright (c) 2004 The WebRTC project authors. All Rights Reserved.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003 *
kjellander1afca732016-02-07 20:46:45 -08004 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree.
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00009 */
10
Jonas Olssona4d87372019-07-05 19:08:33 +020011#include "media/engine/webrtc_video_engine.h"
12
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000013#include <map>
kwiberg686a8ef2016-02-26 03:00:35 -080014#include <memory>
Elad Alon040dc432019-05-22 15:40:02 +020015#include <string>
Steve Antone78bcb92017-10-31 09:53:08 -070016#include <utility>
pbos@webrtc.org86f613d2014-06-10 08:53:05 +000017#include <vector>
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000018
Steve Anton2c9ebef2019-01-28 17:27:58 -080019#include "absl/algorithm/container.h"
Niels Möller805a27e2019-01-21 12:21:27 +010020#include "absl/memory/memory.h"
Niels Möller039743e2018-10-23 10:07:25 +020021#include "absl/strings/match.h"
Danil Chapovalov83bbe912019-08-07 12:24:53 +020022#include "api/rtc_event_log/rtc_event_log.h"
Steve Anton10542f22019-01-11 09:11:00 -080023#include "api/rtp_parameters.h"
Danil Chapovalov53d45ba2019-07-03 14:56:33 +020024#include "api/task_queue/default_task_queue_factory.h"
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -070025#include "api/test/fake_media_transport.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080026#include "api/test/mock_video_bitrate_allocator.h"
27#include "api/test/mock_video_bitrate_allocator_factory.h"
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -070028#include "api/test/mock_video_decoder_factory.h"
29#include "api/test/mock_video_encoder_factory.h"
Niels Möller65f17ca2019-09-12 13:59:36 +020030#include "api/transport/media/media_transport_config.h"
Jonas Oreland49ac5952018-09-26 16:04:32 +020031#include "api/units/time_delta.h"
Jiawei Ouc2ebe212018-11-08 10:02:56 -080032#include "api/video/builtin_video_bitrate_allocator_factory.h"
Niels Möller805a27e2019-01-21 12:21:27 +010033#include "api/video/i420_buffer.h"
Åsa Persson23eba222018-10-02 14:47:06 +020034#include "api/video/video_bitrate_allocation.h"
Anders Carlsson5f2bb622018-05-14 09:48:06 +020035#include "api/video_codecs/builtin_video_decoder_factory.h"
36#include "api/video_codecs/builtin_video_encoder_factory.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020037#include "api/video_codecs/sdp_video_format.h"
38#include "api/video_codecs/video_decoder_factory.h"
39#include "api/video_codecs/video_encoder.h"
40#include "api/video_codecs/video_encoder_factory.h"
41#include "call/flexfec_receive_stream.h"
42#include "common_video/h264/profile_level_id.h"
Niels Möller805a27e2019-01-21 12:21:27 +010043#include "media/base/fake_frame_source.h"
Steve Anton10542f22019-01-11 09:11:00 -080044#include "media/base/fake_network_interface.h"
Steve Anton10542f22019-01-11 09:11:00 -080045#include "media/base/fake_video_renderer.h"
46#include "media/base/media_constants.h"
47#include "media/base/rtp_utils.h"
48#include "media/base/test_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020049#include "media/engine/constants.h"
Steve Anton10542f22019-01-11 09:11:00 -080050#include "media/engine/fake_webrtc_call.h"
51#include "media/engine/fake_webrtc_video_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020052#include "media/engine/simulcast.h"
Steve Anton10542f22019-01-11 09:11:00 -080053#include "media/engine/webrtc_voice_engine.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020054#include "rtc_base/arraysize.h"
Elad Alon80f53b72019-10-11 16:19:43 +020055#include "rtc_base/experiments/min_video_bitrate_experiment.h"
Steve Anton10542f22019-01-11 09:11:00 -080056#include "rtc_base/fake_clock.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020057#include "rtc_base/gunit.h"
Yves Gerey665174f2018-06-19 15:03:05 +020058#include "rtc_base/numerics/safe_conversions.h"
Steve Antonf3802842019-01-24 19:07:40 -080059#include "rtc_base/time_utils.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020060#include "test/field_trial.h"
Niels Möllerd0f0f682019-01-14 09:09:53 +010061#include "test/frame_generator.h"
Mirko Bonadei92ea95e2017-09-15 06:47:31 +020062#include "test/gmock.h"
Tommi25eb47c2019-08-29 16:39:05 +020063#include "test/rtp_header_parser.h"
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000064
philipeld9cc8c02019-09-16 14:53:40 +020065using ::testing::Contains;
66using ::testing::Eq;
Mirko Bonadei6a489f22019-04-09 15:11:12 +020067using ::testing::Field;
Chen Xing90f3b892019-06-25 10:16:14 +020068using ::testing::IsEmpty;
philipeld9cc8c02019-09-16 14:53:40 +020069using ::testing::Pair;
Chen Xing90f3b892019-06-25 10:16:14 +020070using ::testing::SizeIs;
Sebastian Jansson8f83b422018-02-21 13:07:13 +010071using webrtc::BitrateConstraints;
isheriff6f8d6862016-05-26 11:24:55 -070072using webrtc::RtpExtension;
73
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +000074namespace {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000075static const int kDefaultQpMax = 56;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +000076
noahricd10a68e2015-07-10 11:27:55 -070077static const uint8_t kRedRtxPayloadType = 125;
78
Niels Möller6557d0c2018-04-11 15:18:34 +020079static const uint32_t kTimeout = 5000U;
80static const uint32_t kDefaultReceiveSsrc = 0;
81static const uint32_t kSsrc = 1234u;
82static const uint32_t kSsrcs4[] = {1, 2, 3, 4};
83static const int kVideoWidth = 640;
84static const int kVideoHeight = 360;
85static const int kFramerate = 30;
86
Peter Boström0c4e06b2015-10-07 12:23:21 +020087static const uint32_t kSsrcs1[] = {1};
88static const uint32_t kSsrcs3[] = {1, 2, 3};
89static const uint32_t kRtxSsrcs1[] = {4};
brandtr468da7c2016-11-22 02:16:47 -080090static const uint32_t kFlexfecSsrc = 5;
Peter Boström0c4e06b2015-10-07 12:23:21 +020091static const uint32_t kIncomingUnsignalledSsrc = 0xC0FFEE;
mzanaty8a855d62017-02-17 15:46:43 -080092static const uint32_t kDefaultRecvSsrc = 0;
93
Bjorn A Mellemda4f0932019-07-30 08:34:03 -070094constexpr uint32_t kRtpHeaderSize = 12;
95
pbos@webrtc.org3c107582014-07-20 15:27:35 +000096static const char kUnsupportedExtensionName[] =
97 "urn:ietf:params:rtp-hdrext:unsupported";
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +000098
magjed509e4fe2016-11-18 01:34:11 -080099cricket::VideoCodec RemoveFeedbackParams(cricket::VideoCodec&& codec) {
100 codec.feedback_params = cricket::FeedbackParams();
Mirko Bonadei29a8d102018-04-25 23:58:26 +0200101 return std::move(codec);
magjed509e4fe2016-11-18 01:34:11 -0800102}
103
Elad Alonfadb1812019-05-24 13:40:02 +0200104void VerifyCodecHasDefaultFeedbackParams(const cricket::VideoCodec& codec,
105 bool lntf_expected) {
106 EXPECT_EQ(lntf_expected,
107 codec.HasFeedbackParam(cricket::FeedbackParam(
108 cricket::kRtcpFbParamLntf, cricket::kParamValueEmpty)));
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000109 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
110 cricket::kRtcpFbParamNack, cricket::kParamValueEmpty)));
111 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
112 cricket::kRtcpFbParamNack, cricket::kRtcpFbNackParamPli)));
113 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
114 cricket::kRtcpFbParamRemb, cricket::kParamValueEmpty)));
115 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
stefan43edf0f2015-11-20 18:05:48 -0800116 cricket::kRtcpFbParamTransportCc, cricket::kParamValueEmpty)));
117 EXPECT_TRUE(codec.HasFeedbackParam(cricket::FeedbackParam(
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +0000118 cricket::kRtcpFbParamCcm, cricket::kRtcpFbCcmParamFir)));
119}
120
magjed725e4842016-11-16 00:48:13 -0800121// Return true if any codec in |codecs| is an RTX codec with associated payload
122// type |payload_type|.
123bool HasRtxCodec(const std::vector<cricket::VideoCodec>& codecs,
124 int payload_type) {
125 for (const cricket::VideoCodec& codec : codecs) {
126 int associated_payload_type;
Niels Möller039743e2018-10-23 10:07:25 +0200127 if (absl::EqualsIgnoreCase(codec.name.c_str(), "rtx") &&
magjed725e4842016-11-16 00:48:13 -0800128 codec.GetParam(cricket::kCodecParamAssociatedPayloadType,
129 &associated_payload_type) &&
130 associated_payload_type == payload_type) {
131 return true;
132 }
133 }
134 return false;
135}
136
nisseca5706d2017-09-11 02:32:16 -0700137// TODO(nisse): Duplicated in call.cc.
138const int* FindKeyByValue(const std::map<int, int>& m, int v) {
139 for (const auto& kv : m) {
140 if (kv.second == v)
141 return &kv.first;
142 }
143 return nullptr;
144}
145
Yves Gerey665174f2018-06-19 15:03:05 +0200146bool HasRtxReceiveAssociation(const webrtc::VideoReceiveStream::Config& config,
147 int payload_type) {
nisseca5706d2017-09-11 02:32:16 -0700148 return FindKeyByValue(config.rtp.rtx_associated_payload_types,
149 payload_type) != nullptr;
150}
151
152// Check that there's an Rtx payload type for each decoder.
153bool VerifyRtxReceiveAssociations(
154 const webrtc::VideoReceiveStream::Config& config) {
155 for (const auto& decoder : config.decoders) {
156 if (!HasRtxReceiveAssociation(config, decoder.payload_type))
157 return false;
158 }
159 return true;
160}
161
brandtrffc61182016-11-28 06:02:22 -0800162rtc::scoped_refptr<webrtc::VideoFrameBuffer> CreateBlackFrameBuffer(
nisse64ec8f82016-09-27 00:17:25 -0700163 int width,
164 int height) {
165 rtc::scoped_refptr<webrtc::I420Buffer> buffer =
166 webrtc::I420Buffer::Create(width, height);
nisseaf916892017-01-10 07:44:26 -0800167 webrtc::I420Buffer::SetBlack(buffer);
nisse64ec8f82016-09-27 00:17:25 -0700168 return buffer;
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +0000169}
170
Shao Changbine62202f2015-04-21 20:24:50 +0800171void VerifySendStreamHasRtxTypes(const webrtc::VideoSendStream::Config& config,
172 const std::map<int, int>& rtx_types) {
173 std::map<int, int>::const_iterator it;
Niels Möller259a4972018-04-05 15:36:51 +0200174 it = rtx_types.find(config.rtp.payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800175 EXPECT_TRUE(it != rtx_types.end() &&
176 it->second == config.rtp.rtx.payload_type);
177
brandtrb5f2c3f2016-10-04 23:28:39 -0700178 if (config.rtp.ulpfec.red_rtx_payload_type != -1) {
179 it = rtx_types.find(config.rtp.ulpfec.red_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800180 EXPECT_TRUE(it != rtx_types.end() &&
brandtrb5f2c3f2016-10-04 23:28:39 -0700181 it->second == config.rtp.ulpfec.red_rtx_payload_type);
Shao Changbine62202f2015-04-21 20:24:50 +0800182 }
183}
kthelgason2bc68642017-02-07 07:02:22 -0800184
185cricket::MediaConfig GetMediaConfig() {
186 cricket::MediaConfig media_config;
Niels Möller1d7ecd22018-01-18 15:25:12 +0100187 media_config.video.enable_cpu_adaptation = false;
kthelgason2bc68642017-02-07 07:02:22 -0800188 return media_config;
189}
nisse26e3abb2017-08-25 04:44:25 -0700190
Åsa Perssonbdee46d2018-06-25 11:28:06 +0200191// Values from GetMaxDefaultVideoBitrateKbps in webrtcvideoengine.cc.
192int GetMaxDefaultBitrateBps(size_t width, size_t height) {
193 if (width * height <= 320 * 240) {
194 return 600000;
195 } else if (width * height <= 640 * 480) {
196 return 1700000;
197 } else if (width * height <= 960 * 540) {
198 return 2000000;
199 } else {
200 return 2500000;
201 }
202}
203
Niels Möller731a2c22018-07-30 15:08:07 +0200204class MockVideoSource : public rtc::VideoSourceInterface<webrtc::VideoFrame> {
205 public:
206 MOCK_METHOD2(AddOrUpdateSink,
207 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink,
208 const rtc::VideoSinkWants& wants));
209 MOCK_METHOD1(RemoveSink,
210 void(rtc::VideoSinkInterface<webrtc::VideoFrame>* sink));
211};
212
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000213} // namespace
214
Yves Gerey665174f2018-06-19 15:03:05 +0200215#define EXPECT_FRAME_WAIT(c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200216 EXPECT_EQ_WAIT((c), renderer_.num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200217 EXPECT_EQ((w), renderer_.width()); \
218 EXPECT_EQ((h), renderer_.height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200219 EXPECT_EQ(0, renderer_.errors());
220
Yves Gerey665174f2018-06-19 15:03:05 +0200221#define EXPECT_FRAME_ON_RENDERER_WAIT(r, c, w, h, t) \
Niels Möller6557d0c2018-04-11 15:18:34 +0200222 EXPECT_EQ_WAIT((c), (r).num_rendered_frames(), (t)); \
Yves Gerey665174f2018-06-19 15:03:05 +0200223 EXPECT_EQ((w), (r).width()); \
224 EXPECT_EQ((h), (r).height()); \
Niels Möller6557d0c2018-04-11 15:18:34 +0200225 EXPECT_EQ(0, (r).errors());
226
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000227namespace cricket {
eladalonf1841382017-06-12 01:16:46 -0700228class WebRtcVideoEngineTest : public ::testing::Test {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000229 public:
eladalonf1841382017-06-12 01:16:46 -0700230 WebRtcVideoEngineTest() : WebRtcVideoEngineTest("") {}
Elad Alon040dc432019-05-22 15:40:02 +0200231 explicit WebRtcVideoEngineTest(const std::string& field_trials)
232 : override_field_trials_(
233 field_trials.empty()
234 ? nullptr
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200235 : std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alon040dc432019-05-22 15:40:02 +0200236 field_trials)),
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200237 task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
238 call_(webrtc::Call::Create([&] {
239 webrtc::Call::Config call_config(&event_log_);
240 call_config.task_queue_factory = task_queue_factory_.get();
241 return call_config;
242 }())),
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200243 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
244 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200245 video_bitrate_allocator_factory_(
246 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
Anders Carlsson67537952018-05-03 11:28:29 +0200247 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200248 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +0200249 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200250 decoder_factory_)) {
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200251 // Ensure fake clock doesn't return 0, which will cause some initializations
252 // fail inside RTP senders.
Sebastian Jansson40889f32019-04-17 12:11:20 +0200253 fake_clock_.AdvanceTime(webrtc::TimeDelta::us(1));
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200254 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000255
256 protected:
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200257 void AssignDefaultAptRtxTypes();
258 void AssignDefaultCodec();
259
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100260 // Find the index of the codec in the engine with the given name. The codec
261 // must be present.
Oleh Prypina40f8242017-12-21 13:32:23 +0100262 size_t GetEngineCodecIndex(const std::string& name) const;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100263
magjed509e4fe2016-11-18 01:34:11 -0800264 // Find the codec in the engine with the given name. The codec must be
265 // present.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100266 cricket::VideoCodec GetEngineCodec(const std::string& name) const;
magjed509e4fe2016-11-18 01:34:11 -0800267
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200268 VideoMediaChannel* SetSendParamsWithAllSupportedCodecs();
pbos@webrtc.orgfa553ef2014-10-20 11:07:07 +0000269
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200270 VideoMediaChannel* SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000271 const std::vector<VideoCodec>& codecs);
272
Elad Alon157540a2019-02-08 23:37:52 +0100273 void ExpectRtpCapabilitySupport(const char* uri, bool supported) const;
Peter Boströme4499152016-02-05 11:13:28 +0100274
Ilya Nikolaevskiy9c38c472018-09-03 16:11:42 +0200275 // Has to be the first one, so it is initialized before the call or there is a
276 // race condition in the clock access.
277 rtc::ScopedFakeClock fake_clock_;
Elad Alon040dc432019-05-22 15:40:02 +0200278 std::unique_ptr<webrtc::test::ScopedFieldTrials> override_field_trials_;
Danil Chapovalov83bbe912019-08-07 12:24:53 +0200279 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +0200280 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
eladalonf1841382017-06-12 01:16:46 -0700281 // Used in WebRtcVideoEngineVoiceTest, but defined here so it's properly
pbos@webrtc.orgf1f0d9a2015-03-02 13:30:15 +0000282 // initialized when the constructor is called.
kwiberg686a8ef2016-02-26 03:00:35 -0800283 std::unique_ptr<webrtc::Call> call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200284 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
285 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200286 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
287 video_bitrate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -0700288 WebRtcVideoEngine engine_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000289 VideoCodec default_codec_;
Shao Changbine62202f2015-04-21 20:24:50 +0800290 std::map<int, int> default_apt_rtx_types_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +0000291};
292
eladalonf1841382017-06-12 01:16:46 -0700293TEST_F(WebRtcVideoEngineTest, DefaultRtxCodecHasAssociatedPayloadTypeSet) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200294 encoder_factory_->AddSupportedVideoCodecType("VP8");
295 AssignDefaultCodec();
296
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000297 std::vector<VideoCodec> engine_codecs = engine_.codecs();
298 for (size_t i = 0; i < engine_codecs.size(); ++i) {
299 if (engine_codecs[i].name != kRtxCodecName)
300 continue;
301 int associated_payload_type;
302 EXPECT_TRUE(engine_codecs[i].GetParam(kCodecParamAssociatedPayloadType,
pbos@webrtc.org42684be2014-10-03 11:25:45 +0000303 &associated_payload_type));
pbos@webrtc.orge322a172014-06-13 11:47:28 +0000304 EXPECT_EQ(default_codec_.id, associated_payload_type);
305 return;
306 }
307 FAIL() << "No RTX codec found among default codecs.";
308}
309
eladalonf1841382017-06-12 01:16:46 -0700310TEST_F(WebRtcVideoEngineTest, SupportsTimestampOffsetHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100311 ExpectRtpCapabilitySupport(RtpExtension::kTimestampOffsetUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000312}
313
eladalonf1841382017-06-12 01:16:46 -0700314TEST_F(WebRtcVideoEngineTest, SupportsAbsoluteSenderTimeHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100315 ExpectRtpCapabilitySupport(RtpExtension::kAbsSendTimeUri, true);
pbos@webrtc.org587ef602014-06-16 17:32:02 +0000316}
317
eladalonf1841382017-06-12 01:16:46 -0700318TEST_F(WebRtcVideoEngineTest, SupportsTransportSequenceNumberHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100319 ExpectRtpCapabilitySupport(RtpExtension::kTransportSequenceNumberUri, true);
stefanc1aeaf02015-10-15 07:26:07 -0700320}
321
eladalonf1841382017-06-12 01:16:46 -0700322TEST_F(WebRtcVideoEngineTest, SupportsVideoRotationHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100323 ExpectRtpCapabilitySupport(RtpExtension::kVideoRotationUri, true);
324}
325
326TEST_F(WebRtcVideoEngineTest, SupportsPlayoutDelayHeaderExtension) {
327 ExpectRtpCapabilitySupport(RtpExtension::kPlayoutDelayUri, true);
328}
329
330TEST_F(WebRtcVideoEngineTest, SupportsVideoContentTypeHeaderExtension) {
331 ExpectRtpCapabilitySupport(RtpExtension::kVideoContentTypeUri, true);
332}
333
334TEST_F(WebRtcVideoEngineTest, SupportsVideoTimingHeaderExtension) {
335 ExpectRtpCapabilitySupport(RtpExtension::kVideoTimingUri, true);
336}
337
338TEST_F(WebRtcVideoEngineTest, SupportsFrameMarkingHeaderExtension) {
339 ExpectRtpCapabilitySupport(RtpExtension::kFrameMarkingUri, true);
Johannes Krond0b69a82018-12-03 14:18:53 +0100340}
341
342TEST_F(WebRtcVideoEngineTest, SupportsColorSpaceHeaderExtension) {
Elad Alon157540a2019-02-08 23:37:52 +0100343 ExpectRtpCapabilitySupport(RtpExtension::kColorSpaceUri, true);
344}
345
Elad Alonccb9b752019-02-19 13:01:31 +0100346TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor00) {
347 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, false);
348}
349
350TEST_F(WebRtcVideoEngineTest, AdvertiseGenericDescriptor01) {
351 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, false);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700352}
353
philipel1e054862018-10-08 16:13:53 +0200354class WebRtcVideoEngineTestWithGenericDescriptor
355 : public WebRtcVideoEngineTest {
356 public:
357 WebRtcVideoEngineTestWithGenericDescriptor()
358 : WebRtcVideoEngineTest("WebRTC-GenericDescriptorAdvertised/Enabled/") {}
359};
360
Elad Alonccb9b752019-02-19 13:01:31 +0100361TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
362 AdvertiseGenericDescriptor00) {
363 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri00, true);
364}
365
366TEST_F(WebRtcVideoEngineTestWithGenericDescriptor,
367 AdvertiseGenericDescriptor01) {
368 ExpectRtpCapabilitySupport(RtpExtension::kGenericFrameDescriptorUri01, true);
philipel1e054862018-10-08 16:13:53 +0200369}
370
eladalonf1841382017-06-12 01:16:46 -0700371TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeCapturer) {
Niels Möller731a2c22018-07-30 15:08:07 +0200372 // Allocate the source first to prevent early destruction before channel's
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700373 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200374 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700375
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200376 encoder_factory_->AddSupportedVideoCodecType("VP8");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700377
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200378 std::unique_ptr<VideoMediaChannel> channel(
379 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700380 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
381
382 // Add CVO extension.
383 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800384 cricket::VideoSendParameters parameters;
385 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200386 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700387 RtpExtension(RtpExtension::kVideoRotationUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200388 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700389
Niels Möller731a2c22018-07-30 15:08:07 +0200390 EXPECT_CALL(
391 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200392 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200393 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700394 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200395 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700396
397 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200398 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700399
400 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200401 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200402 EXPECT_CALL(
403 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200404 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200405 Field(&rtc::VideoSinkWants::rotation_applied, true)));
406
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200407 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700408}
409
eladalonf1841382017-06-12 01:16:46 -0700410TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionBeforeAddSendStream) {
Niels Möller731a2c22018-07-30 15:08:07 +0200411 // Allocate the source first to prevent early destruction before channel's
perkj91e1c152016-03-02 05:34:00 -0800412 // dtor is called.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200413 ::testing::NiceMock<MockVideoSource> video_source;
perkj91e1c152016-03-02 05:34:00 -0800414
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200415 encoder_factory_->AddSupportedVideoCodecType("VP8");
perkj91e1c152016-03-02 05:34:00 -0800416
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200417 std::unique_ptr<VideoMediaChannel> channel(
418 SetSendParamsWithAllSupportedCodecs());
perkj91e1c152016-03-02 05:34:00 -0800419 // Add CVO extension.
420 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800421 cricket::VideoSendParameters parameters;
422 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj91e1c152016-03-02 05:34:00 -0800423 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700424 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkj91e1c152016-03-02 05:34:00 -0800425 EXPECT_TRUE(channel->SetSendParameters(parameters));
426 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
427
Niels Möller731a2c22018-07-30 15:08:07 +0200428 // Set source.
429 EXPECT_CALL(
430 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200431 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200432 Field(&rtc::VideoSinkWants::rotation_applied, false)));
433 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
perkj91e1c152016-03-02 05:34:00 -0800434}
435
eladalonf1841382017-06-12 01:16:46 -0700436TEST_F(WebRtcVideoEngineTest, CVOSetHeaderExtensionAfterCapturer) {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200437 ::testing::NiceMock<MockVideoSource> video_source;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700438
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200439 encoder_factory_->AddSupportedVideoCodecType("VP8");
440 encoder_factory_->AddSupportedVideoCodecType("VP9");
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700441
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200442 std::unique_ptr<VideoMediaChannel> channel(
443 SetSendParamsWithAllSupportedCodecs());
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700444 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
445
446 // Set capturer.
Niels Möller731a2c22018-07-30 15:08:07 +0200447 EXPECT_CALL(
448 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200449 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200450 Field(&rtc::VideoSinkWants::rotation_applied, true)));
451 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &video_source));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700452
perkjcaafdba2016-03-20 07:34:29 -0700453 // Verify capturer has turned on applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200454 ::testing::Mock::VerifyAndClear(&video_source);
perkjcaafdba2016-03-20 07:34:29 -0700455
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700456 // Add CVO extension.
457 const int id = 1;
magjed509e4fe2016-11-18 01:34:11 -0800458 cricket::VideoSendParameters parameters;
459 parameters.codecs.push_back(GetEngineCodec("VP8"));
460 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200461 parameters.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -0700462 RtpExtension(RtpExtension::kVideoRotationUri, id));
perkjcaafdba2016-03-20 07:34:29 -0700463 // Also remove the first codec to trigger a codec change as well.
464 parameters.codecs.erase(parameters.codecs.begin());
Niels Möller731a2c22018-07-30 15:08:07 +0200465 EXPECT_CALL(
466 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200467 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200468 Field(&rtc::VideoSinkWants::rotation_applied, false)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200469 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700470
471 // Verify capturer has turned off applying rotation.
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200472 ::testing::Mock::VerifyAndClear(&video_source);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700473
474 // Verify removing header extension turns on applying rotation.
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200475 parameters.extensions.clear();
Niels Möller731a2c22018-07-30 15:08:07 +0200476 EXPECT_CALL(
477 video_source,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200478 AddOrUpdateSink(::testing::_,
Niels Möller731a2c22018-07-30 15:08:07 +0200479 Field(&rtc::VideoSinkWants::rotation_applied, true)));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200480 EXPECT_TRUE(channel->SetSendParameters(parameters));
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -0700481}
482
eladalonf1841382017-06-12 01:16:46 -0700483TEST_F(WebRtcVideoEngineTest, SetSendFailsBeforeSettingCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200484 encoder_factory_->AddSupportedVideoCodecType("VP8");
485
Sebastian Jansson84848f22018-11-16 10:40:36 +0100486 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200487 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
488 video_bitrate_allocator_factory_.get()));
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +0000489
490 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
491
492 EXPECT_FALSE(channel->SetSend(true))
493 << "Channel should not start without codecs.";
494 EXPECT_TRUE(channel->SetSend(false))
495 << "Channel should be stoppable even without set codecs.";
496}
497
eladalonf1841382017-06-12 01:16:46 -0700498TEST_F(WebRtcVideoEngineTest, GetStatsWithoutSendCodecsSetDoesNotCrash) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200499 encoder_factory_->AddSupportedVideoCodecType("VP8");
500
Sebastian Jansson84848f22018-11-16 10:40:36 +0100501 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200502 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
503 video_bitrate_allocator_factory_.get()));
pbos@webrtc.orgc3d2bd22014-08-12 20:55:10 +0000504 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(123)));
505 VideoMediaInfo info;
506 channel->GetStats(&info);
507}
508
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200509TEST_F(WebRtcVideoEngineTest, UseFactoryForVp8WhenSupported) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200510 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000511
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200512 std::unique_ptr<VideoMediaChannel> channel(
513 SetSendParamsWithAllSupportedCodecs());
Sergey Ulanove2b15012016-11-22 16:08:30 -0800514 channel->OnReadyToSend(true);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000515
516 EXPECT_TRUE(
517 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200518 EXPECT_EQ(0, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000519 EXPECT_TRUE(channel->SetSend(true));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100520 webrtc::test::FrameForwarder frame_forwarder;
521 cricket::FakeFrameSource frame_source(1280, 720,
522 rtc::kNumMicrosecsPerSec / 30);
523 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
524 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Per21d45d22016-10-30 21:37:57 +0100525 // Sending one frame will have allocate the encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200526 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
527 EXPECT_TRUE_WAIT(encoder_factory_->encoders()[0]->GetNumEncodedFrames() > 0,
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000528 kTimeout);
529
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200530 int num_created_encoders = encoder_factory_->GetNumCreatedEncoders();
Per21d45d22016-10-30 21:37:57 +0100531 EXPECT_EQ(num_created_encoders, 1);
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000532
533 // Setting codecs of the same type should not reallocate any encoders
534 // (expecting a no-op).
magjed509e4fe2016-11-18 01:34:11 -0800535 cricket::VideoSendParameters parameters;
536 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200537 EXPECT_TRUE(channel->SetSendParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200538 EXPECT_EQ(num_created_encoders, encoder_factory_->GetNumCreatedEncoders());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000539
540 // Remove stream previously added to free the external encoder instance.
541 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200542 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000543}
544
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200545// Test that when an encoder factory supports H264, we add an RTX
546// codec for it.
547// TODO(deadbeef): This test should be updated if/when we start
548// adding RTX codecs for unrecognized codec names.
549TEST_F(WebRtcVideoEngineTest, RtxCodecAddedForH264Codec) {
magjed725e4842016-11-16 00:48:13 -0800550 using webrtc::H264::kLevel1;
Jonas Olssona4d87372019-07-05 19:08:33 +0200551 using webrtc::H264::ProfileLevelId;
552 using webrtc::H264::ProfileLevelIdToString;
Anders Carlsson67537952018-05-03 11:28:29 +0200553 webrtc::SdpVideoFormat h264_constrained_baseline("H264");
554 h264_constrained_baseline.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800555 *ProfileLevelIdToString(
556 ProfileLevelId(webrtc::H264::kProfileConstrainedBaseline, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200557 webrtc::SdpVideoFormat h264_constrained_high("H264");
558 h264_constrained_high.parameters[kH264FmtpProfileLevelId] =
magjed725e4842016-11-16 00:48:13 -0800559 *ProfileLevelIdToString(
560 ProfileLevelId(webrtc::H264::kProfileConstrainedHigh, kLevel1));
Anders Carlsson67537952018-05-03 11:28:29 +0200561 webrtc::SdpVideoFormat h264_high("H264");
562 h264_high.parameters[kH264FmtpProfileLevelId] = *ProfileLevelIdToString(
magjed725e4842016-11-16 00:48:13 -0800563 ProfileLevelId(webrtc::H264::kProfileHigh, kLevel1));
564
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200565 encoder_factory_->AddSupportedVideoCodec(h264_constrained_baseline);
566 encoder_factory_->AddSupportedVideoCodec(h264_constrained_high);
567 encoder_factory_->AddSupportedVideoCodec(h264_high);
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700568
magjed725e4842016-11-16 00:48:13 -0800569 // First figure out what payload types the test codecs got assigned.
570 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
magjed509e4fe2016-11-18 01:34:11 -0800571 // Now search for RTX codecs for them. Expect that they all have associated
572 // RTX codecs.
magjed725e4842016-11-16 00:48:13 -0800573 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200574 codecs,
575 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_baseline))
576 ->id));
magjed725e4842016-11-16 00:48:13 -0800577 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200578 codecs,
579 FindMatchingCodec(codecs, cricket::VideoCodec(h264_constrained_high))
580 ->id));
magjed509e4fe2016-11-18 01:34:11 -0800581 EXPECT_TRUE(HasRtxCodec(
Anders Carlsson67537952018-05-03 11:28:29 +0200582 codecs, FindMatchingCodec(codecs, cricket::VideoCodec(h264_high))->id));
Taylor Brandstetter6c3e7882016-06-29 11:14:19 -0700583}
584
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100585#if defined(RTC_ENABLE_VP9)
eladalonf1841382017-06-12 01:16:46 -0700586TEST_F(WebRtcVideoEngineTest, CanConstructDecoderForVp9EncoderFactory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200587 encoder_factory_->AddSupportedVideoCodecType("VP9");
Peter Boström53eda3d2015-03-27 15:53:18 +0100588
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200589 std::unique_ptr<VideoMediaChannel> channel(
590 SetSendParamsWithAllSupportedCodecs());
Peter Boström53eda3d2015-03-27 15:53:18 +0100591
592 EXPECT_TRUE(
593 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
594}
Mirko Bonadei8ef57932018-11-16 14:38:03 +0100595#endif // defined(RTC_ENABLE_VP9)
Peter Boström53eda3d2015-03-27 15:53:18 +0100596
eladalonf1841382017-06-12 01:16:46 -0700597TEST_F(WebRtcVideoEngineTest, PropagatesInputFrameTimestamp) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200598 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +0100599 FakeCall* fake_call = new FakeCall();
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200600 call_.reset(fake_call);
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200601 std::unique_ptr<VideoMediaChannel> channel(
602 SetSendParamsWithAllSupportedCodecs());
qiangchenc27d89f2015-07-16 10:27:16 -0700603
604 EXPECT_TRUE(
605 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
606
Niels Möllerd0f0f682019-01-14 09:09:53 +0100607 webrtc::test::FrameForwarder frame_forwarder;
608 cricket::FakeFrameSource frame_source(1280, 720,
609 rtc::kNumMicrosecsPerSec / 60);
610 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
qiangchenc27d89f2015-07-16 10:27:16 -0700611 channel->SetSend(true);
612
Fredrik Solenberg709ed672015-09-15 12:26:33 +0200613 FakeVideoSendStream* stream = fake_call->GetVideoSendStreams()[0];
qiangchenc27d89f2015-07-16 10:27:16 -0700614
Niels Möllerd0f0f682019-01-14 09:09:53 +0100615 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700616 int64_t last_timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700617 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100618 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos1cb121d2015-09-14 11:38:38 -0700619 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700620 int64_t interval = timestamp - last_timestamp;
621
622 // Precision changes from nanosecond to millisecond.
623 // Allow error to be no more than 1.
624 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(60) / 1E6, interval, 1);
625
626 last_timestamp = timestamp;
627 }
628
Niels Möllerd0f0f682019-01-14 09:09:53 +0100629 frame_forwarder.IncomingCapturedFrame(
630 frame_source.GetFrame(1280, 720, webrtc::VideoRotation::kVideoRotation_0,
631 rtc::kNumMicrosecsPerSec / 30));
qiangchenc27d89f2015-07-16 10:27:16 -0700632 last_timestamp = stream->GetLastTimestamp();
633 for (int i = 0; i < 10; i++) {
Niels Möllerd0f0f682019-01-14 09:09:53 +0100634 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame(
635 1280, 720, webrtc::VideoRotation::kVideoRotation_0,
636 rtc::kNumMicrosecsPerSec / 30));
pbos1cb121d2015-09-14 11:38:38 -0700637 int64_t timestamp = stream->GetLastTimestamp();
qiangchenc27d89f2015-07-16 10:27:16 -0700638 int64_t interval = timestamp - last_timestamp;
639
640 // Precision changes from nanosecond to millisecond.
641 // Allow error to be no more than 1.
642 EXPECT_NEAR(cricket::VideoFormat::FpsToInterval(30) / 1E6, interval, 1);
643
644 last_timestamp = timestamp;
645 }
646
647 // Remove stream previously added to free the external encoder instance.
648 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
649}
650
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200651void WebRtcVideoEngineTest::AssignDefaultAptRtxTypes() {
652 std::vector<VideoCodec> engine_codecs = engine_.codecs();
653 RTC_DCHECK(!engine_codecs.empty());
654 for (const cricket::VideoCodec& codec : engine_codecs) {
655 if (codec.name == "rtx") {
656 int associated_payload_type;
657 if (codec.GetParam(kCodecParamAssociatedPayloadType,
658 &associated_payload_type)) {
659 default_apt_rtx_types_[associated_payload_type] = codec.id;
660 }
661 }
662 }
663}
664
665void WebRtcVideoEngineTest::AssignDefaultCodec() {
666 std::vector<VideoCodec> engine_codecs = engine_.codecs();
667 RTC_DCHECK(!engine_codecs.empty());
668 bool codec_set = false;
669 for (const cricket::VideoCodec& codec : engine_codecs) {
670 if (!codec_set && codec.name != "rtx" && codec.name != "red" &&
671 codec.name != "ulpfec") {
672 default_codec_ = codec;
673 codec_set = true;
674 }
675 }
676
677 RTC_DCHECK(codec_set);
678}
679
Oleh Prypina40f8242017-12-21 13:32:23 +0100680size_t WebRtcVideoEngineTest::GetEngineCodecIndex(
681 const std::string& name) const {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100682 const std::vector<cricket::VideoCodec> codecs = engine_.codecs();
683 for (size_t i = 0; i < codecs.size(); ++i) {
684 const cricket::VideoCodec engine_codec = codecs[i];
Niels Möller039743e2018-10-23 10:07:25 +0200685 if (!absl::EqualsIgnoreCase(name, engine_codec.name))
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200686 continue;
687 // The tests only use H264 Constrained Baseline. Make sure we don't return
688 // an internal H264 codec from the engine with a different H264 profile.
Niels Möller039743e2018-10-23 10:07:25 +0200689 if (absl::EqualsIgnoreCase(name.c_str(), kH264CodecName)) {
Danil Chapovalov00c71832018-06-15 15:58:38 +0200690 const absl::optional<webrtc::H264::ProfileLevelId> profile_level_id =
Magnus Jedvert8deb8182017-10-05 13:13:32 +0200691 webrtc::H264::ParseSdpProfileLevelId(engine_codec.params);
692 if (profile_level_id->profile !=
693 webrtc::H264::kProfileConstrainedBaseline) {
694 continue;
695 }
696 }
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100697 return i;
magjed509e4fe2016-11-18 01:34:11 -0800698 }
699 // This point should never be reached.
700 ADD_FAILURE() << "Unrecognized codec name: " << name;
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100701 return -1;
702}
703
704cricket::VideoCodec WebRtcVideoEngineTest::GetEngineCodec(
705 const std::string& name) const {
706 return engine_.codecs()[GetEngineCodecIndex(name)];
magjed509e4fe2016-11-18 01:34:11 -0800707}
708
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200709VideoMediaChannel*
710WebRtcVideoEngineTest::SetSendParamsWithAllSupportedCodecs() {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100711 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200712 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
713 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200714 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800715 // We need to look up the codec in the engine to get the correct payload type.
Anders Carlsson67537952018-05-03 11:28:29 +0200716 for (const webrtc::SdpVideoFormat& format :
717 encoder_factory_->GetSupportedFormats()) {
718 cricket::VideoCodec engine_codec = GetEngineCodec(format.name);
Steve Anton2c9ebef2019-01-28 17:27:58 -0800719 if (!absl::c_linear_search(parameters.codecs, engine_codec)) {
Anders Carlsson67537952018-05-03 11:28:29 +0200720 parameters.codecs.push_back(engine_codec);
721 }
722 }
magjed509e4fe2016-11-18 01:34:11 -0800723
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200724 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000725
726 return channel;
727}
728
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200729VideoMediaChannel* WebRtcVideoEngineTest::SetRecvParamsWithSupportedCodecs(
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000730 const std::vector<VideoCodec>& codecs) {
Sebastian Jansson84848f22018-11-16 10:40:36 +0100731 VideoMediaChannel* channel = engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200732 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
733 video_bitrate_allocator_factory_.get());
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200734 cricket::VideoRecvParameters parameters;
735 parameters.codecs = codecs;
736 EXPECT_TRUE(channel->SetRecvParameters(parameters));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000737
738 return channel;
739}
740
Elad Alon157540a2019-02-08 23:37:52 +0100741void WebRtcVideoEngineTest::ExpectRtpCapabilitySupport(const char* uri,
742 bool supported) const {
743 const RtpCapabilities capabilities = engine_.GetCapabilities();
744 if (supported) {
745 EXPECT_THAT(capabilities.header_extensions,
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200746 ::testing::Contains(::testing::Field(&RtpExtension::uri, uri)));
Elad Alon157540a2019-02-08 23:37:52 +0100747 } else {
Mirko Bonadei6a489f22019-04-09 15:11:12 +0200748 EXPECT_THAT(capabilities.header_extensions,
749 ::testing::Each(::testing::Field(&RtpExtension::uri,
750 ::testing::StrNe(uri))));
Elad Alon157540a2019-02-08 23:37:52 +0100751 }
752}
753
eladalonf1841382017-06-12 01:16:46 -0700754TEST_F(WebRtcVideoEngineTest, UsesSimulcastAdapterForVp8Factories) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200755 encoder_factory_->AddSupportedVideoCodecType("VP8");
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000756
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200757 std::unique_ptr<VideoMediaChannel> channel(
758 SetSendParamsWithAllSupportedCodecs());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000759
Peter Boström0c4e06b2015-10-07 12:23:21 +0200760 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000761
Yves Gerey665174f2018-06-19 15:03:05 +0200762 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000763 EXPECT_TRUE(channel->SetSend(true));
764
Niels Möller805a27e2019-01-21 12:21:27 +0100765 webrtc::test::FrameForwarder frame_forwarder;
766 cricket::FakeFrameSource frame_source(1280, 720,
767 rtc::kNumMicrosecsPerSec / 60);
768 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
769 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000770
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200771 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000772
773 // Verify that encoders are configured for simulcast through adapter
774 // (increasing resolution and only configured to send one stream each).
775 int prev_width = -1;
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200776 for (size_t i = 0; i < encoder_factory_->encoders().size(); ++i) {
777 ASSERT_TRUE(encoder_factory_->encoders()[i]->WaitForInitEncode());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000778 webrtc::VideoCodec codec_settings =
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200779 encoder_factory_->encoders()[i]->GetCodecSettings();
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000780 EXPECT_EQ(0, codec_settings.numberOfSimulcastStreams);
781 EXPECT_GT(codec_settings.width, prev_width);
782 prev_width = codec_settings.width;
783 }
pbos@webrtc.org86196c42015-02-16 21:02:00 +0000784
Niels Möllerff40b142018-04-09 08:49:14 +0200785 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, nullptr));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000786
787 channel.reset();
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200788 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.orgf18fba22015-01-14 16:26:23 +0000789}
790
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200791TEST_F(WebRtcVideoEngineTest, ChannelWithH264CanChangeToVp8) {
792 encoder_factory_->AddSupportedVideoCodecType("VP8");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200793 encoder_factory_->AddSupportedVideoCodecType("H264");
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000794
Niels Möllerd0f0f682019-01-14 09:09:53 +0100795 // Frame source.
796 webrtc::test::FrameForwarder frame_forwarder;
797 cricket::FakeFrameSource frame_source(1280, 720,
798 rtc::kNumMicrosecsPerSec / 30);
Niels Möller4db138e2018-04-19 09:04:13 +0200799
Sebastian Jansson84848f22018-11-16 10:40:36 +0100800 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200801 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
802 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200803 cricket::VideoSendParameters parameters;
804 parameters.codecs.push_back(GetEngineCodec("H264"));
805 EXPECT_TRUE(channel->SetSendParameters(parameters));
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000806
807 EXPECT_TRUE(
808 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möllerd0f0f682019-01-14 09:09:53 +0100809 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +0200810 // Sending one frame will have allocate the encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100811 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200812
813 ASSERT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000814
Anders Carlsson67537952018-05-03 11:28:29 +0200815 cricket::VideoSendParameters new_parameters;
816 new_parameters.codecs.push_back(GetEngineCodec("VP8"));
817 EXPECT_TRUE(channel->SetSendParameters(new_parameters));
Niels Möller4db138e2018-04-19 09:04:13 +0200818
819 // Sending one frame will switch encoder.
Niels Möllerd0f0f682019-01-14 09:09:53 +0100820 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200821
Anders Carlsson8a150d92018-05-14 12:40:04 +0200822 EXPECT_EQ_WAIT(1u, encoder_factory_->encoders().size(), kTimeout);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000823}
824
eladalonf1841382017-06-12 01:16:46 -0700825TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000826 UsesSimulcastAdapterForVp8WithCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200827 encoder_factory_->AddSupportedVideoCodecType("VP8");
828 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000829
Sebastian Jansson84848f22018-11-16 10:40:36 +0100830 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200831 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
832 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800833 cricket::VideoSendParameters parameters;
834 parameters.codecs.push_back(GetEngineCodec("VP8"));
835 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000836
Peter Boström0c4e06b2015-10-07 12:23:21 +0200837 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000838
Yves Gerey665174f2018-06-19 15:03:05 +0200839 EXPECT_TRUE(channel->AddSendStream(CreateSimStreamParams("cname", ssrcs)));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000840 EXPECT_TRUE(channel->SetSend(true));
841
842 // Send a fake frame, or else the media engine will configure the simulcast
843 // encoder adapter at a low-enough size that it'll only create a single
844 // encoder layer.
Niels Möller805a27e2019-01-21 12:21:27 +0100845 webrtc::test::FrameForwarder frame_forwarder;
846 cricket::FakeFrameSource frame_source(1280, 720,
847 rtc::kNumMicrosecsPerSec / 30);
848 EXPECT_TRUE(channel->SetVideoSend(ssrcs.front(), nullptr, &frame_forwarder));
849 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000850
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200851 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
852 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000853 EXPECT_EQ(webrtc::kVideoCodecVP8,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200854 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000855
856 channel.reset();
857 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200858 EXPECT_EQ(0u, encoder_factory_->encoders().size());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000859}
860
eladalonf1841382017-06-12 01:16:46 -0700861TEST_F(WebRtcVideoEngineTest,
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000862 DestroysNonSimulcastEncoderFromCombinedVP8AndH264Factory) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200863 encoder_factory_->AddSupportedVideoCodecType("VP8");
864 encoder_factory_->AddSupportedVideoCodecType("H264");
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000865
Sebastian Jansson84848f22018-11-16 10:40:36 +0100866 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200867 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
868 video_bitrate_allocator_factory_.get()));
magjed509e4fe2016-11-18 01:34:11 -0800869 cricket::VideoSendParameters parameters;
870 parameters.codecs.push_back(GetEngineCodec("H264"));
871 EXPECT_TRUE(channel->SetSendParameters(parameters));
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000872
873 EXPECT_TRUE(
874 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Per21d45d22016-10-30 21:37:57 +0100875
876 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100877 webrtc::test::FrameForwarder frame_forwarder;
878 cricket::FakeFrameSource frame_source(1280, 720,
879 rtc::kNumMicrosecsPerSec / 30);
880 EXPECT_TRUE(channel->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
881 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +0200882 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
883 ASSERT_EQ(1u, encoder_factory_->encoders().size());
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200884 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000885 EXPECT_EQ(webrtc::kVideoCodecH264,
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200886 encoder_factory_->encoders()[0]->GetCodecSettings().codecType);
pthatcher@webrtc.org818c4982015-03-06 02:20:58 +0000887
888 channel.reset();
889 // Make sure DestroyVideoEncoder was called on the factory.
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200890 ASSERT_EQ(0u, encoder_factory_->encoders().size());
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000891}
892
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200893TEST_F(WebRtcVideoEngineTest, SimulcastEnabledForH264BehindFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +0200894 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200895 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200896 "WebRTC-H264Simulcast/Enabled/");
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200897 encoder_factory_->AddSupportedVideoCodecType("H264");
noahricfdac5162015-08-27 01:59:29 -0700898
Sebastian Jansson84848f22018-11-16 10:40:36 +0100899 std::unique_ptr<VideoMediaChannel> channel(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +0200900 call_.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
901 video_bitrate_allocator_factory_.get()));
Anders Carlsson67537952018-05-03 11:28:29 +0200902 cricket::VideoSendParameters parameters;
903 parameters.codecs.push_back(GetEngineCodec("H264"));
904 EXPECT_TRUE(channel->SetSendParameters(parameters));
noahricfdac5162015-08-27 01:59:29 -0700905
Peter Boström0c4e06b2015-10-07 12:23:21 +0200906 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
noahricfdac5162015-08-27 01:59:29 -0700907 EXPECT_TRUE(
908 channel->AddSendStream(cricket::CreateSimStreamParams("cname", ssrcs)));
Peter Boströmce23bee2016-02-02 14:14:30 +0100909
910 // Send a frame of 720p. This should trigger a "real" encoder initialization.
Niels Möller805a27e2019-01-21 12:21:27 +0100911 webrtc::test::FrameForwarder frame_forwarder;
912 cricket::FakeFrameSource frame_source(1280, 720,
913 rtc::kNumMicrosecsPerSec / 30);
914 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
915 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströmce23bee2016-02-02 14:14:30 +0100916
Niels Möller4db138e2018-04-19 09:04:13 +0200917 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Magnus Jedvert02e7a192017-09-23 17:21:32 +0200918 ASSERT_EQ(1u, encoder_factory_->encoders().size());
919 FakeWebRtcVideoEncoder* encoder = encoder_factory_->encoders()[0];
920 ASSERT_TRUE(encoder_factory_->encoders()[0]->WaitForInitEncode());
noahricfdac5162015-08-27 01:59:29 -0700921 EXPECT_EQ(webrtc::kVideoCodecH264, encoder->GetCodecSettings().codecType);
Sergio Garcia Murillo43800f92018-06-21 16:16:38 +0200922 EXPECT_LT(1u, encoder->GetCodecSettings().numberOfSimulcastStreams);
Niels Möllerff40b142018-04-09 08:49:14 +0200923 EXPECT_TRUE(channel->SetVideoSend(ssrcs[0], nullptr, nullptr));
noahricfdac5162015-08-27 01:59:29 -0700924}
925
brandtrffc61182016-11-28 06:02:22 -0800926// Test that the FlexFEC field trial properly alters the output of
eladalonf1841382017-06-12 01:16:46 -0700927// WebRtcVideoEngine::codecs(), for an existing |engine_| object.
brandtrffc61182016-11-28 06:02:22 -0800928//
929// TODO(brandtr): Remove this test, when the FlexFEC field trial is gone.
eladalonf1841382017-06-12 01:16:46 -0700930TEST_F(WebRtcVideoEngineTest,
brandtrffc61182016-11-28 06:02:22 -0800931 Flexfec03SupportedAsInternalCodecBehindFieldTrial) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200932 encoder_factory_->AddSupportedVideoCodecType("VP8");
933
Steve Anton2c9ebef2019-01-28 17:27:58 -0800934 auto flexfec = Field("name", &VideoCodec::name, "flexfec-03");
brandtrffc61182016-11-28 06:02:22 -0800935
936 // FlexFEC is not active without field trial.
Steve Anton2c9ebef2019-01-28 17:27:58 -0800937 EXPECT_THAT(engine_.codecs(), Not(Contains(flexfec)));
brandtrffc61182016-11-28 06:02:22 -0800938
939 // FlexFEC is active with field trial.
Elad Alon040dc432019-05-22 15:40:02 +0200940 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +0200941 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
brandtr340e3fd2017-02-28 15:43:10 -0800942 "WebRTC-FlexFEC-03-Advertised/Enabled/");
Steve Anton2c9ebef2019-01-28 17:27:58 -0800943 EXPECT_THAT(engine_.codecs(), Contains(flexfec));
brandtrffc61182016-11-28 06:02:22 -0800944}
945
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200946// Test that codecs are added in the order they are reported from the factory.
947TEST_F(WebRtcVideoEngineTest, ReportSupportedCodecs) {
948 encoder_factory_->AddSupportedVideoCodecType("VP8");
949 const char* kFakeCodecName = "FakeCodec";
950 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000951
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200952 // The last reported codec should appear after the first codec in the vector.
Oleh Prypina40f8242017-12-21 13:32:23 +0100953 const size_t vp8_index = GetEngineCodecIndex("VP8");
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200954 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
955 EXPECT_LT(vp8_index, fake_codec_index);
pbos@webrtc.org7fe1e032014-10-14 04:25:33 +0000956}
957
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200958// Test that a codec that was added after the engine was initialized
brandtrffc61182016-11-28 06:02:22 -0800959// does show up in the codec list after it was added.
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200960TEST_F(WebRtcVideoEngineTest, ReportSupportedAddedCodec) {
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100961 const char* kFakeExternalCodecName1 = "FakeExternalCodec1";
962 const char* kFakeExternalCodecName2 = "FakeExternalCodec2";
Magnus Jedvert154ee1f2017-11-15 19:27:11 +0100963
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100964 // Set up external encoder factory with first codec, and initialize engine.
965 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName1);
966
brandtrffc61182016-11-28 06:02:22 -0800967 std::vector<cricket::VideoCodec> codecs_before(engine_.codecs());
brandtrffc61182016-11-28 06:02:22 -0800968
969 // Add second codec.
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100970 encoder_factory_->AddSupportedVideoCodecType(kFakeExternalCodecName2);
brandtrffc61182016-11-28 06:02:22 -0800971 std::vector<cricket::VideoCodec> codecs_after(engine_.codecs());
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200972 // The codec itself and RTX should have been added.
973 EXPECT_EQ(codecs_before.size() + 2, codecs_after.size());
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100974
975 // Check that both fake codecs are present and that the second fake codec
976 // appears after the first fake codec.
Oleh Prypina40f8242017-12-21 13:32:23 +0100977 const size_t fake_codec_index1 = GetEngineCodecIndex(kFakeExternalCodecName1);
978 const size_t fake_codec_index2 = GetEngineCodecIndex(kFakeExternalCodecName2);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +0100979 EXPECT_LT(fake_codec_index1, fake_codec_index2);
brandtrffc61182016-11-28 06:02:22 -0800980}
981
Sami Kalliomäkie9a18b22018-07-13 10:28:21 +0200982TEST_F(WebRtcVideoEngineTest, ReportRtxForExternalCodec) {
983 const char* kFakeCodecName = "FakeCodec";
984 encoder_factory_->AddSupportedVideoCodecType(kFakeCodecName);
985
986 const size_t fake_codec_index = GetEngineCodecIndex(kFakeCodecName);
987 EXPECT_EQ("rtx", engine_.codecs().at(fake_codec_index + 1).name);
988}
989
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200990TEST_F(WebRtcVideoEngineTest, RegisterDecodersIfSupported) {
991 encoder_factory_->AddSupportedVideoCodecType("VP8");
Anders Carlsson67537952018-05-03 11:28:29 +0200992 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +0200993 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -0800994 parameters.codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000995
kwiberg686a8ef2016-02-26 03:00:35 -0800996 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +0200997 SetRecvParamsWithSupportedCodecs(parameters.codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +0000998
999 EXPECT_TRUE(
1000 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001001 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001002
1003 // Setting codecs of the same type should not reallocate the decoder.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02001004 EXPECT_TRUE(channel->SetRecvParameters(parameters));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001005 EXPECT_EQ(1, decoder_factory_->GetNumCreatedDecoders());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001006
1007 // Remove stream previously added to free the external decoder instance.
1008 EXPECT_TRUE(channel->RemoveRecvStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001009 EXPECT_EQ(0u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001010}
1011
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001012// Verifies that we can set up decoders.
1013TEST_F(WebRtcVideoEngineTest, RegisterH264DecoderIfSupported) {
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001014 // TODO(pbos): Do not assume that encoder/decoder support is symmetric. We
1015 // can't even query the WebRtcVideoDecoderFactory for supported codecs.
1016 // For now we add a FakeWebRtcVideoEncoderFactory to add H264 to supported
1017 // codecs.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001018 encoder_factory_->AddSupportedVideoCodecType("H264");
Steve Anton2dbc6272019-05-31 13:08:58 -07001019 webrtc::SdpVideoFormat supported_h264("H264");
1020 supported_h264.parameters[kH264FmtpPacketizationMode] = "1";
1021 decoder_factory_->AddSupportedVideoCodecType(supported_h264);
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001022 std::vector<cricket::VideoCodec> codecs;
magjed509e4fe2016-11-18 01:34:11 -08001023 codecs.push_back(GetEngineCodec("H264"));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001024
kwiberg686a8ef2016-02-26 03:00:35 -08001025 std::unique_ptr<VideoMediaChannel> channel(
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001026 SetRecvParamsWithSupportedCodecs(codecs));
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001027
1028 EXPECT_TRUE(
1029 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001030 ASSERT_EQ(1u, decoder_factory_->decoders().size());
pbos@webrtc.org96a93252014-11-03 14:46:44 +00001031}
1032
Jonas Oreland49ac5952018-09-26 16:04:32 +02001033// Tests when GetSources is called with non-existing ssrc, it will return an
1034// empty list of RtpSource without crashing.
1035TEST_F(WebRtcVideoEngineTest, GetSourcesWithNonExistingSsrc) {
1036 // Setup an recv stream with |kSsrc|.
1037 encoder_factory_->AddSupportedVideoCodecType("VP8");
1038 decoder_factory_->AddSupportedVideoCodecType(webrtc::SdpVideoFormat("VP8"));
1039 cricket::VideoRecvParameters parameters;
1040 parameters.codecs.push_back(GetEngineCodec("VP8"));
1041 std::unique_ptr<VideoMediaChannel> channel(
1042 SetRecvParamsWithSupportedCodecs(parameters.codecs));
1043
1044 EXPECT_TRUE(
1045 channel->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1046
1047 // Call GetSources with |kSsrc + 1| which doesn't exist.
1048 std::vector<webrtc::RtpSource> sources = channel->GetSources(kSsrc + 1);
1049 EXPECT_EQ(0u, sources.size());
1050}
1051
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001052TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullFactories) {
1053 std::unique_ptr<webrtc::VideoEncoderFactory> encoder_factory;
1054 std::unique_ptr<webrtc::VideoDecoderFactory> decoder_factory;
1055 WebRtcVideoEngine engine(std::move(encoder_factory),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001056 std::move(decoder_factory));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001057 EXPECT_EQ(0u, engine.codecs().size());
1058}
1059
1060TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, EmptyFactories) {
1061 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001062 webrtc::MockVideoEncoderFactory* encoder_factory =
1063 new webrtc::MockVideoEncoderFactory();
1064 webrtc::MockVideoDecoderFactory* decoder_factory =
1065 new webrtc::MockVideoDecoderFactory();
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001066 WebRtcVideoEngine engine(
1067 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001068 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001069 EXPECT_CALL(*encoder_factory, GetSupportedFormats());
1070 EXPECT_EQ(0u, engine.codecs().size());
1071 EXPECT_CALL(*encoder_factory, Die());
1072 EXPECT_CALL(*decoder_factory, Die());
1073}
1074
1075// Test full behavior in the video engine when video codec factories of the new
1076// type are injected supporting the single codec Vp8. Check the returned codecs
1077// from the engine and that we will create a Vp8 encoder and decoder using the
1078// new factories.
1079TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, Vp8) {
1080 // |engine| take ownership of the factories.
Emircan Uysalerdbcac7f2017-10-30 23:10:12 -07001081 webrtc::MockVideoEncoderFactory* encoder_factory =
1082 new webrtc::MockVideoEncoderFactory();
1083 webrtc::MockVideoDecoderFactory* decoder_factory =
1084 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001085 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1086 rate_allocator_factory =
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001087 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001088 EXPECT_CALL(*rate_allocator_factory,
1089 CreateVideoBitrateAllocatorProxy(Field(
1090 &webrtc::VideoCodec::codecType, webrtc::kVideoCodecVP8)))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001091 .WillOnce(::testing::Return(new webrtc::MockVideoBitrateAllocator()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001092 WebRtcVideoEngine engine(
1093 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001094 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001095 const webrtc::SdpVideoFormat vp8_format("VP8");
1096 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1097 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001098 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001099
1100 // Verify the codecs from the engine.
1101 const std::vector<VideoCodec> engine_codecs = engine.codecs();
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001102 // Verify default codecs has been added correctly.
1103 EXPECT_EQ(5u, engine_codecs.size());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001104 EXPECT_EQ("VP8", engine_codecs.at(0).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001105
1106 // RTX codec for VP8.
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001107 EXPECT_EQ("rtx", engine_codecs.at(1).name);
Magnus Jedvert9b16e2d2017-11-18 12:08:55 +01001108 int vp8_associated_payload;
1109 EXPECT_TRUE(engine_codecs.at(1).GetParam(kCodecParamAssociatedPayloadType,
1110 &vp8_associated_payload));
1111 EXPECT_EQ(vp8_associated_payload, engine_codecs.at(0).id);
1112
1113 EXPECT_EQ(kRedCodecName, engine_codecs.at(2).name);
1114
1115 // RTX codec for RED.
1116 EXPECT_EQ("rtx", engine_codecs.at(3).name);
1117 int red_associated_payload;
1118 EXPECT_TRUE(engine_codecs.at(3).GetParam(kCodecParamAssociatedPayloadType,
1119 &red_associated_payload));
1120 EXPECT_EQ(red_associated_payload, engine_codecs.at(2).id);
1121
1122 EXPECT_EQ(kUlpfecCodecName, engine_codecs.at(4).name);
1123
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001124 int associated_payload_type;
1125 EXPECT_TRUE(engine_codecs.at(1).GetParam(
1126 cricket::kCodecParamAssociatedPayloadType, &associated_payload_type));
1127 EXPECT_EQ(engine_codecs.at(0).id, associated_payload_type);
1128 // Verify default parameters has been added to the VP8 codec.
Elad Alonfadb1812019-05-24 13:40:02 +02001129 VerifyCodecHasDefaultFeedbackParams(engine_codecs.at(0),
1130 /*lntf_expected=*/false);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001131
1132 // Mock encoder creation. |engine| take ownership of the encoder.
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001133 webrtc::VideoEncoderFactory::CodecInfo codec_info;
1134 codec_info.is_hardware_accelerated = false;
1135 codec_info.has_internal_source = false;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001136 const webrtc::SdpVideoFormat format("VP8");
Mirta Dvornicic1ec2a162018-12-10 09:47:34 +00001137 EXPECT_CALL(*encoder_factory, QueryVideoEncoder(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001138 .WillRepeatedly(::testing::Return(codec_info));
Anders Carlsson67537952018-05-03 11:28:29 +02001139 FakeWebRtcVideoEncoder* const encoder = new FakeWebRtcVideoEncoder(nullptr);
Niels Möllerc572ff32018-11-07 08:43:50 +01001140 rtc::Event encoder_created;
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001141 EXPECT_CALL(*encoder_factory, CreateVideoEncoderProxy(format))
Niels Möller4db138e2018-04-19 09:04:13 +02001142 .WillOnce(
1143 ::testing::DoAll(::testing::InvokeWithoutArgs(
1144 [&encoder_created]() { encoder_created.Set(); }),
1145 ::testing::Return(encoder)));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001146
1147 // Mock decoder creation. |engine| take ownership of the decoder.
Anders Carlsson67537952018-05-03 11:28:29 +02001148 FakeWebRtcVideoDecoder* const decoder = new FakeWebRtcVideoDecoder(nullptr);
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001149 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(format))
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001150 .WillOnce(::testing::Return(decoder));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001151
1152 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001153 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001154 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1155 webrtc::Call::Config call_config(&event_log);
1156 call_config.task_queue_factory = task_queue_factory.get();
1157 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001158
1159 // Create send channel.
1160 const int send_ssrc = 123;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001161 std::unique_ptr<VideoMediaChannel> send_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001162 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1163 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001164 cricket::VideoSendParameters send_parameters;
1165 send_parameters.codecs.push_back(engine_codecs.at(0));
1166 EXPECT_TRUE(send_channel->SetSendParameters(send_parameters));
1167 send_channel->OnReadyToSend(true);
1168 EXPECT_TRUE(
1169 send_channel->AddSendStream(StreamParams::CreateLegacy(send_ssrc)));
1170 EXPECT_TRUE(send_channel->SetSend(true));
1171
Niels Möller4db138e2018-04-19 09:04:13 +02001172 // Set capturer.
Niels Möller805a27e2019-01-21 12:21:27 +01001173 webrtc::test::FrameForwarder frame_forwarder;
1174 cricket::FakeFrameSource frame_source(1280, 720,
1175 rtc::kNumMicrosecsPerSec / 30);
1176 EXPECT_TRUE(send_channel->SetVideoSend(send_ssrc, nullptr, &frame_forwarder));
Niels Möller4db138e2018-04-19 09:04:13 +02001177 // Sending one frame will allocate the encoder.
Niels Möller805a27e2019-01-21 12:21:27 +01001178 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller4db138e2018-04-19 09:04:13 +02001179 encoder_created.Wait(kTimeout);
1180
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001181 // Create recv channel.
1182 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001183 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001184 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1185 rate_allocator_factory.get()));
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001186 cricket::VideoRecvParameters recv_parameters;
1187 recv_parameters.codecs.push_back(engine_codecs.at(0));
1188 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1189 EXPECT_TRUE(recv_channel->AddRecvStream(
1190 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1191
1192 // Remove streams previously added to free the encoder and decoder instance.
1193 EXPECT_CALL(*encoder_factory, Die());
1194 EXPECT_CALL(*decoder_factory, Die());
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001195 EXPECT_CALL(*rate_allocator_factory, Die());
Magnus Jedvertd4b0c052017-09-14 10:24:54 +02001196 EXPECT_TRUE(send_channel->RemoveSendStream(send_ssrc));
1197 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1198}
1199
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001200// Test behavior when decoder factory fails to create a decoder (returns null).
1201TEST(WebRtcVideoEngineNewVideoCodecFactoryTest, NullDecoder) {
1202 // |engine| take ownership of the factories.
1203 webrtc::MockVideoEncoderFactory* encoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001204 new webrtc::MockVideoEncoderFactory();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001205 webrtc::MockVideoDecoderFactory* decoder_factory =
Jiawei Ouc2ebe212018-11-08 10:02:56 -08001206 new webrtc::MockVideoDecoderFactory();
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001207 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
1208 rate_allocator_factory =
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001209 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>();
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001210 WebRtcVideoEngine engine(
1211 (std::unique_ptr<webrtc::VideoEncoderFactory>(encoder_factory)),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001212 (std::unique_ptr<webrtc::VideoDecoderFactory>(decoder_factory)));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001213 const webrtc::SdpVideoFormat vp8_format("VP8");
1214 const std::vector<webrtc::SdpVideoFormat> supported_formats = {vp8_format};
1215 EXPECT_CALL(*encoder_factory, GetSupportedFormats())
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001216 .WillRepeatedly(::testing::Return(supported_formats));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001217
1218 // Decoder creation fails.
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001219 EXPECT_CALL(*decoder_factory, CreateVideoDecoderProxy(::testing::_))
1220 .WillOnce(::testing::Return(nullptr));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001221
1222 // Create a call.
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001223 webrtc::RtcEventLogNull event_log;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001224 auto task_queue_factory = webrtc::CreateDefaultTaskQueueFactory();
1225 webrtc::Call::Config call_config(&event_log);
1226 call_config.task_queue_factory = task_queue_factory.get();
1227 const auto call = absl::WrapUnique(webrtc::Call::Create(call_config));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001228
1229 // Create recv channel.
1230 const int recv_ssrc = 321;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001231 std::unique_ptr<VideoMediaChannel> recv_channel(engine.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001232 call.get(), GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
1233 rate_allocator_factory.get()));
Magnus Jedvert7501b1c2017-11-09 13:43:42 +01001234 cricket::VideoRecvParameters recv_parameters;
1235 recv_parameters.codecs.push_back(engine.codecs().front());
1236 EXPECT_TRUE(recv_channel->SetRecvParameters(recv_parameters));
1237 EXPECT_TRUE(recv_channel->AddRecvStream(
1238 cricket::StreamParams::CreateLegacy(recv_ssrc)));
1239
1240 // Remove streams previously added to free the encoder and decoder instance.
1241 EXPECT_TRUE(recv_channel->RemoveRecvStream(recv_ssrc));
1242}
1243
eladalonf1841382017-06-12 01:16:46 -07001244TEST_F(WebRtcVideoEngineTest, DISABLED_RecreatesEncoderOnContentTypeChange) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001245 encoder_factory_->AddSupportedVideoCodecType("VP8");
Sebastian Jansson8f83b422018-02-21 13:07:13 +01001246 std::unique_ptr<FakeCall> fake_call(new FakeCall());
Anders Carlsson5f2bb622018-05-14 09:48:06 +02001247 std::unique_ptr<VideoMediaChannel> channel(
1248 SetSendParamsWithAllSupportedCodecs());
sprangf24a0642017-02-28 13:23:26 -08001249 ASSERT_TRUE(
1250 channel->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
1251 cricket::VideoCodec codec = GetEngineCodec("VP8");
1252 cricket::VideoSendParameters parameters;
1253 parameters.codecs.push_back(codec);
1254 channel->OnReadyToSend(true);
1255 channel->SetSend(true);
1256 ASSERT_TRUE(channel->SetSendParameters(parameters));
1257
Niels Möller805a27e2019-01-21 12:21:27 +01001258 webrtc::test::FrameForwarder frame_forwarder;
1259 cricket::FakeFrameSource frame_source(1280, 720,
1260 rtc::kNumMicrosecsPerSec / 30);
sprangf24a0642017-02-28 13:23:26 -08001261 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01001262 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001263
Niels Möller805a27e2019-01-21 12:21:27 +01001264 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001265 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(1));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001266 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001267 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001268
Niels Möller805a27e2019-01-21 12:21:27 +01001269 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1270 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001271 // No change in content type, keep current encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001272 EXPECT_EQ(1, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001273
1274 options.is_screencast.emplace(true);
Niels Möller805a27e2019-01-21 12:21:27 +01001275 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1276 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001277 // Change to screen content, recreate encoder. For the simulcast encoder
1278 // adapter case, this will result in two calls since InitEncode triggers a
1279 // a new instance.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001280 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(2));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001281 EXPECT_EQ(webrtc::VideoCodecMode::kScreensharing,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001282 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001283
Niels Möller805a27e2019-01-21 12:21:27 +01001284 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
1285 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08001286 // Still screen content, no need to update encoder.
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001287 EXPECT_EQ(2, encoder_factory_->GetNumCreatedEncoders());
sprangf24a0642017-02-28 13:23:26 -08001288
1289 options.is_screencast.emplace(false);
1290 options.video_noise_reduction.emplace(false);
Niels Möller805a27e2019-01-21 12:21:27 +01001291 EXPECT_TRUE(channel->SetVideoSend(kSsrc, &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08001292 // Change back to regular video content, update encoder. Also change
1293 // a non |is_screencast| option just to verify it doesn't affect recreation.
Niels Möller805a27e2019-01-21 12:21:27 +01001294 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001295 ASSERT_TRUE(encoder_factory_->WaitForCreatedVideoEncoders(3));
Niels Möllere3cf3d02018-06-13 11:52:16 +02001296 EXPECT_EQ(webrtc::VideoCodecMode::kRealtimeVideo,
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001297 encoder_factory_->encoders().back()->GetCodecSettings().mode);
sprangf24a0642017-02-28 13:23:26 -08001298
1299 // Remove stream previously added to free the external encoder instance.
1300 EXPECT_TRUE(channel->RemoveSendStream(kSsrc));
Magnus Jedvert02e7a192017-09-23 17:21:32 +02001301 EXPECT_EQ(0u, encoder_factory_->encoders().size());
sprangf24a0642017-02-28 13:23:26 -08001302}
1303
Mirko Bonadei6a489f22019-04-09 15:11:12 +02001304class WebRtcVideoChannelBaseTest : public ::testing::Test {
Niels Möller6557d0c2018-04-11 15:18:34 +02001305 protected:
1306 WebRtcVideoChannelBaseTest()
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001307 : task_queue_factory_(webrtc::CreateDefaultTaskQueueFactory()),
1308 video_bitrate_allocator_factory_(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001309 webrtc::CreateBuiltinVideoBitrateAllocatorFactory()),
1310 engine_(webrtc::CreateBuiltinVideoEncoderFactory(),
1311 webrtc::CreateBuiltinVideoDecoderFactory()) {}
Niels Möller6557d0c2018-04-11 15:18:34 +02001312
1313 virtual void SetUp() {
Jonas Oreland49ac5952018-09-26 16:04:32 +02001314 // One testcase calls SetUp in a loop, only create call_ once.
1315 if (!call_) {
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001316 webrtc::Call::Config call_config(&event_log_);
1317 call_config.task_queue_factory = task_queue_factory_.get();
1318 call_.reset(webrtc::Call::Create(call_config));
Jonas Oreland49ac5952018-09-26 16:04:32 +02001319 }
Niels Möller6557d0c2018-04-11 15:18:34 +02001320 cricket::MediaConfig media_config;
1321 // Disabling cpu overuse detection actually disables quality scaling too; it
1322 // implies DegradationPreference kMaintainResolution. Automatic scaling
1323 // needs to be disabled, otherwise, tests which check the size of received
1324 // frames become flaky.
1325 media_config.video.enable_cpu_adaptation = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01001326 channel_.reset(
1327 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
1328 call_.get(), media_config, cricket::VideoOptions(),
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001329 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get())));
Niels Möller6557d0c2018-04-11 15:18:34 +02001330 channel_->OnReadyToSend(true);
1331 EXPECT_TRUE(channel_.get() != NULL);
1332 network_interface_.SetDestination(channel_.get());
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07001333 channel_->SetInterface(&network_interface_, webrtc::MediaTransportConfig());
Niels Möller6557d0c2018-04-11 15:18:34 +02001334 cricket::VideoRecvParameters parameters;
1335 parameters.codecs = engine_.codecs();
1336 channel_->SetRecvParameters(parameters);
1337 EXPECT_TRUE(channel_->AddSendStream(DefaultSendStreamParams()));
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001338 frame_forwarder_ = std::make_unique<webrtc::test::FrameForwarder>();
1339 frame_source_ = std::make_unique<cricket::FakeFrameSource>(
Niels Möller805a27e2019-01-21 12:21:27 +01001340 640, 480, rtc::kNumMicrosecsPerSec / kFramerate);
1341 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001342 }
1343
1344 // Utility method to setup an additional stream to send and receive video.
1345 // Used to test send and recv between two streams.
1346 void SetUpSecondStream() {
1347 SetUpSecondStreamWithNoRecv();
1348 // Setup recv for second stream.
1349 EXPECT_TRUE(channel_->AddRecvStream(
1350 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1351 // Make the second renderer available for use by a new stream.
1352 EXPECT_TRUE(channel_->SetSink(kSsrc + 2, &renderer2_));
1353 }
1354 // Setup an additional stream just to send video. Defer add recv stream.
1355 // This is required if you want to test unsignalled recv of video rtp packets.
1356 void SetUpSecondStreamWithNoRecv() {
1357 // SetUp() already added kSsrc make sure duplicate SSRCs cant be added.
Yves Gerey665174f2018-06-19 15:03:05 +02001358 EXPECT_TRUE(
1359 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001360 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
Yves Gerey665174f2018-06-19 15:03:05 +02001361 EXPECT_FALSE(
1362 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001363 EXPECT_TRUE(channel_->AddSendStream(
1364 cricket::StreamParams::CreateLegacy(kSsrc + 2)));
1365 // We dont add recv for the second stream.
1366
1367 // Setup the receive and renderer for second stream after send.
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001368 frame_forwarder_2_ = std::make_unique<webrtc::test::FrameForwarder>();
Yves Gerey665174f2018-06-19 15:03:05 +02001369 EXPECT_TRUE(
Niels Möller805a27e2019-01-21 12:21:27 +01001370 channel_->SetVideoSend(kSsrc + 2, nullptr, frame_forwarder_2_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001371 }
Yves Gerey665174f2018-06-19 15:03:05 +02001372 virtual void TearDown() { channel_.reset(); }
1373 bool SetDefaultCodec() { return SetOneCodec(DefaultCodec()); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001374
1375 bool SetOneCodec(const cricket::VideoCodec& codec) {
Mirko Bonadei317a1f02019-09-17 17:06:18 +02001376 frame_source_ = std::make_unique<cricket::FakeFrameSource>(
Niels Möller805a27e2019-01-21 12:21:27 +01001377 kVideoWidth, kVideoHeight, rtc::kNumMicrosecsPerSec / kFramerate);
Niels Möller6557d0c2018-04-11 15:18:34 +02001378
1379 bool sending = channel_->sending();
1380 bool success = SetSend(false);
1381 if (success) {
1382 cricket::VideoSendParameters parameters;
1383 parameters.codecs.push_back(codec);
1384 success = channel_->SetSendParameters(parameters);
1385 }
1386 if (success) {
1387 success = SetSend(sending);
1388 }
1389 return success;
1390 }
Yves Gerey665174f2018-06-19 15:03:05 +02001391 bool SetSend(bool send) { return channel_->SetSend(send); }
Niels Möller805a27e2019-01-21 12:21:27 +01001392 void SendFrame() {
1393 if (frame_forwarder_2_) {
1394 frame_forwarder_2_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001395 }
Niels Möller805a27e2019-01-21 12:21:27 +01001396 frame_forwarder_->IncomingCapturedFrame(frame_source_->GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001397 }
1398 bool WaitAndSendFrame(int wait_ms) {
1399 bool ret = rtc::Thread::Current()->ProcessMessages(wait_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001400 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001401 return ret;
1402 }
Yves Gerey665174f2018-06-19 15:03:05 +02001403 int NumRtpBytes() { return network_interface_.NumRtpBytes(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001404 int NumRtpBytes(uint32_t ssrc) {
1405 return network_interface_.NumRtpBytes(ssrc);
1406 }
Yves Gerey665174f2018-06-19 15:03:05 +02001407 int NumRtpPackets() { return network_interface_.NumRtpPackets(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001408 int NumRtpPackets(uint32_t ssrc) {
1409 return network_interface_.NumRtpPackets(ssrc);
1410 }
Yves Gerey665174f2018-06-19 15:03:05 +02001411 int NumSentSsrcs() { return network_interface_.NumSentSsrcs(); }
Niels Möller6557d0c2018-04-11 15:18:34 +02001412 const rtc::CopyOnWriteBuffer* GetRtpPacket(int index) {
1413 return network_interface_.GetRtpPacket(index);
1414 }
1415 static int GetPayloadType(const rtc::CopyOnWriteBuffer* p) {
Åsa Persson23cd45a2018-07-03 10:40:40 +02001416 webrtc::RTPHeader header;
1417 EXPECT_TRUE(ParseRtpPacket(p, &header));
1418 return header.payloadType;
Niels Möller6557d0c2018-04-11 15:18:34 +02001419 }
Åsa Persson23cd45a2018-07-03 10:40:40 +02001420
Niels Möller6557d0c2018-04-11 15:18:34 +02001421 static bool ParseRtpPacket(const rtc::CopyOnWriteBuffer* p,
Åsa Persson23cd45a2018-07-03 10:40:40 +02001422 webrtc::RTPHeader* header) {
1423 std::unique_ptr<webrtc::RtpHeaderParser> parser(
Tommi25eb47c2019-08-29 16:39:05 +02001424 webrtc::RtpHeaderParser::CreateForTest());
Åsa Persson23cd45a2018-07-03 10:40:40 +02001425 return parser->Parse(p->cdata(), p->size(), header);
Niels Möller6557d0c2018-04-11 15:18:34 +02001426 }
1427
1428 // Tests that we can send and receive frames.
1429 void SendAndReceive(const cricket::VideoCodec& codec) {
1430 EXPECT_TRUE(SetOneCodec(codec));
1431 EXPECT_TRUE(SetSend(true));
1432 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1433 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001434 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001435 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1436 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1437 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1438 }
1439
1440 void SendReceiveManyAndGetStats(const cricket::VideoCodec& codec,
Yves Gerey665174f2018-06-19 15:03:05 +02001441 int duration_sec,
1442 int fps) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001443 EXPECT_TRUE(SetOneCodec(codec));
1444 EXPECT_TRUE(SetSend(true));
1445 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1446 EXPECT_EQ(0, renderer_.num_rendered_frames());
1447 for (int i = 0; i < duration_sec; ++i) {
1448 for (int frame = 1; frame <= fps; ++frame) {
1449 EXPECT_TRUE(WaitAndSendFrame(1000 / fps));
1450 EXPECT_FRAME_WAIT(frame + i * fps, kVideoWidth, kVideoHeight, kTimeout);
1451 }
1452 }
1453 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1454 EXPECT_EQ(codec.id, GetPayloadType(p.get()));
1455 }
1456
Niels Möller6557d0c2018-04-11 15:18:34 +02001457 cricket::VideoSenderInfo GetSenderStats(size_t i) {
1458 cricket::VideoMediaInfo info;
1459 EXPECT_TRUE(channel_->GetStats(&info));
1460 return info.senders[i];
1461 }
1462
1463 cricket::VideoReceiverInfo GetReceiverStats(size_t i) {
1464 cricket::VideoMediaInfo info;
1465 EXPECT_TRUE(channel_->GetStats(&info));
1466 return info.receivers[i];
1467 }
1468
1469 // Two streams one channel tests.
1470
1471 // Tests that we can send and receive frames.
1472 void TwoStreamsSendAndReceive(const cricket::VideoCodec& codec) {
1473 SetUpSecondStream();
1474 // Test sending and receiving on first stream.
1475 SendAndReceive(codec);
1476 // Test sending and receiving on second stream.
1477 EXPECT_EQ_WAIT(1, renderer2_.num_rendered_frames(), kTimeout);
1478 EXPECT_GT(NumRtpPackets(), 0);
1479 EXPECT_EQ(1, renderer2_.num_rendered_frames());
1480 }
1481
1482 cricket::VideoCodec GetEngineCodec(const std::string& name) {
1483 for (const cricket::VideoCodec& engine_codec : engine_.codecs()) {
Niels Möller039743e2018-10-23 10:07:25 +02001484 if (absl::EqualsIgnoreCase(name, engine_codec.name))
Niels Möller6557d0c2018-04-11 15:18:34 +02001485 return engine_codec;
1486 }
1487 // This point should never be reached.
1488 ADD_FAILURE() << "Unrecognized codec name: " << name;
1489 return cricket::VideoCodec();
1490 }
1491
1492 cricket::VideoCodec DefaultCodec() { return GetEngineCodec("VP8"); }
1493
1494 cricket::StreamParams DefaultSendStreamParams() {
1495 return cricket::StreamParams::CreateLegacy(kSsrc);
1496 }
1497
Danil Chapovalov83bbe912019-08-07 12:24:53 +02001498 webrtc::RtcEventLogNull event_log_;
Danil Chapovalov53d45ba2019-07-03 14:56:33 +02001499 std::unique_ptr<webrtc::TaskQueueFactory> task_queue_factory_;
Jonas Oreland49ac5952018-09-26 16:04:32 +02001500 std::unique_ptr<webrtc::Call> call_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02001501 std::unique_ptr<webrtc::VideoBitrateAllocatorFactory>
1502 video_bitrate_allocator_factory_;
Niels Möller6557d0c2018-04-11 15:18:34 +02001503 WebRtcVideoEngine engine_;
Niels Möller805a27e2019-01-21 12:21:27 +01001504
1505 std::unique_ptr<cricket::FakeFrameSource> frame_source_;
1506 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_;
1507 std::unique_ptr<webrtc::test::FrameForwarder> frame_forwarder_2_;
1508
Niels Möller6557d0c2018-04-11 15:18:34 +02001509 std::unique_ptr<WebRtcVideoChannel> channel_;
1510 cricket::FakeNetworkInterface network_interface_;
1511 cricket::FakeVideoRenderer renderer_;
1512
1513 // Used by test cases where 2 streams are run on the same channel.
1514 cricket::FakeVideoRenderer renderer2_;
1515};
1516
1517// Test that SetSend works.
srtee0c2eea2017-12-15 17:44:33 +01001518TEST_F(WebRtcVideoChannelBaseTest, SetSend) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001519 EXPECT_FALSE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001520 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001521 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1522 EXPECT_FALSE(channel_->sending());
1523 EXPECT_TRUE(SetSend(true));
1524 EXPECT_TRUE(channel_->sending());
Niels Möller805a27e2019-01-21 12:21:27 +01001525 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001526 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1527 EXPECT_TRUE(SetSend(false));
1528 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001529}
Niels Möller6557d0c2018-04-11 15:18:34 +02001530
1531// Test that SetSend fails without codecs being set.
srtee0c2eea2017-12-15 17:44:33 +01001532TEST_F(WebRtcVideoChannelBaseTest, SetSendWithoutCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001533 EXPECT_FALSE(channel_->sending());
1534 EXPECT_FALSE(SetSend(true));
1535 EXPECT_FALSE(channel_->sending());
srtee0c2eea2017-12-15 17:44:33 +01001536}
Niels Möller6557d0c2018-04-11 15:18:34 +02001537
1538// Test that we properly set the send and recv buffer sizes by the time
1539// SetSend is called.
srtee0c2eea2017-12-15 17:44:33 +01001540TEST_F(WebRtcVideoChannelBaseTest, SetSendSetsTransportBufferSizes) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001541 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1542 EXPECT_TRUE(SetSend(true));
1543 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
Johannes Krond38a2b82018-10-23 11:31:19 +02001544 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
Erik Språng820ebd02018-08-20 17:14:25 +02001545}
1546
Johannes Kron5a0665b2019-04-08 10:35:50 +02001547// Test that we properly set the send and recv buffer sizes when overriding
1548// via field trials.
1549TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSize) {
1550 // Set field trial to override the default recv buffer size, and then re-run
1551 // setup where the interface is created and configured.
1552 const int kCustomRecvBufferSize = 123456;
1553 webrtc::test::ScopedFieldTrials field_trial(
1554 "WebRTC-IncreasedReceivebuffers/123456/");
1555 SetUp();
1556
1557 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1558 EXPECT_TRUE(SetSend(true));
1559 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1560 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1561}
1562
1563// Test that we properly set the send and recv buffer sizes when overriding
1564// via field trials with suffix.
1565TEST_F(WebRtcVideoChannelBaseTest, OverridesRecvBufferSizeWithSuffix) {
1566 // Set field trial to override the default recv buffer size, and then re-run
1567 // setup where the interface is created and configured.
1568 const int kCustomRecvBufferSize = 123456;
1569 webrtc::test::ScopedFieldTrials field_trial(
1570 "WebRTC-IncreasedReceivebuffers/123456_Dogfood/");
1571 SetUp();
1572
1573 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1574 EXPECT_TRUE(SetSend(true));
1575 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1576 EXPECT_EQ(kCustomRecvBufferSize, network_interface_.recvbuf_size());
1577}
1578
1579// Test that we properly set the send and recv buffer sizes when overriding
1580// via field trials that don't make any sense.
1581TEST_F(WebRtcVideoChannelBaseTest, InvalidRecvBufferSize) {
1582 // Set bogus field trial values to override the default recv buffer size, and
1583 // then re-run setup where the interface is created and configured. The
1584 // default value should still be used.
1585
1586 for (std::string group : {" ", "NotANumber", "-1", "0"}) {
1587 std::string field_trial_string = "WebRTC-IncreasedReceivebuffers/";
1588 field_trial_string += group;
1589 field_trial_string += "/";
1590 webrtc::test::ScopedFieldTrials field_trial(field_trial_string);
1591 SetUp();
1592
1593 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1594 EXPECT_TRUE(SetSend(true));
1595 EXPECT_EQ(64 * 1024, network_interface_.sendbuf_size());
1596 EXPECT_EQ(256 * 1024, network_interface_.recvbuf_size());
1597 }
1598}
1599
Niels Möller6557d0c2018-04-11 15:18:34 +02001600// Test that stats work properly for a 1-1 call.
srtee0c2eea2017-12-15 17:44:33 +01001601TEST_F(WebRtcVideoChannelBaseTest, GetStats) {
Mirko Bonadeief0627f2019-10-15 08:54:49 +00001602 webrtc::test::ScopedFieldTrials field_trials(
1603 "WebRTC-UseStandardBytesStats/Enabled/");
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001604 SetUp();
1605
Niels Möller6557d0c2018-04-11 15:18:34 +02001606 const int kDurationSec = 3;
1607 const int kFps = 10;
1608 SendReceiveManyAndGetStats(DefaultCodec(), kDurationSec, kFps);
1609
1610 cricket::VideoMediaInfo info;
1611 EXPECT_TRUE(channel_->GetStats(&info));
1612
1613 ASSERT_EQ(1U, info.senders.size());
1614 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1615 // For webrtc, bytes_sent does not include the RTP header length.
Mirko Bonadeief0627f2019-10-15 08:54:49 +00001616 EXPECT_EQ(info.senders[0].bytes_sent,
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001617 NumRtpBytes() - kRtpHeaderSize * NumRtpPackets());
Niels Möller6557d0c2018-04-11 15:18:34 +02001618 EXPECT_EQ(NumRtpPackets(), info.senders[0].packets_sent);
1619 EXPECT_EQ(0.0, info.senders[0].fraction_lost);
1620 ASSERT_TRUE(info.senders[0].codec_payload_type);
1621 EXPECT_EQ(DefaultCodec().id, *info.senders[0].codec_payload_type);
1622 EXPECT_EQ(0, info.senders[0].firs_rcvd);
1623 EXPECT_EQ(0, info.senders[0].plis_rcvd);
1624 EXPECT_EQ(0, info.senders[0].nacks_rcvd);
1625 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1626 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1627 EXPECT_GT(info.senders[0].framerate_input, 0);
1628 EXPECT_GT(info.senders[0].framerate_sent, 0);
1629
1630 EXPECT_EQ(1U, info.send_codecs.count(DefaultCodec().id));
1631 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1632 info.send_codecs[DefaultCodec().id]);
1633
1634 ASSERT_EQ(1U, info.receivers.size());
1635 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1636 EXPECT_EQ(1U, info.receivers[0].ssrcs().size());
1637 EXPECT_EQ(info.senders[0].ssrcs()[0], info.receivers[0].ssrcs()[0]);
1638 ASSERT_TRUE(info.receivers[0].codec_payload_type);
1639 EXPECT_EQ(DefaultCodec().id, *info.receivers[0].codec_payload_type);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001640 EXPECT_EQ(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Mirko Bonadeief0627f2019-10-15 08:54:49 +00001641 info.receivers[0].bytes_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001642 EXPECT_EQ(NumRtpPackets(), info.receivers[0].packets_rcvd);
Niels Möller6557d0c2018-04-11 15:18:34 +02001643 EXPECT_EQ(0, info.receivers[0].packets_lost);
1644 // TODO(asapersson): Not set for webrtc. Handle missing stats.
1645 // EXPECT_EQ(0, info.receivers[0].packets_concealed);
1646 EXPECT_EQ(0, info.receivers[0].firs_sent);
1647 EXPECT_EQ(0, info.receivers[0].plis_sent);
1648 EXPECT_EQ(0, info.receivers[0].nacks_sent);
1649 EXPECT_EQ(kVideoWidth, info.receivers[0].frame_width);
1650 EXPECT_EQ(kVideoHeight, info.receivers[0].frame_height);
1651 EXPECT_GT(info.receivers[0].framerate_rcvd, 0);
1652 EXPECT_GT(info.receivers[0].framerate_decoded, 0);
1653 EXPECT_GT(info.receivers[0].framerate_output, 0);
1654
1655 EXPECT_EQ(1U, info.receive_codecs.count(DefaultCodec().id));
1656 EXPECT_EQ(DefaultCodec().ToCodecParameters(),
1657 info.receive_codecs[DefaultCodec().id]);
srtee0c2eea2017-12-15 17:44:33 +01001658}
Niels Möller6557d0c2018-04-11 15:18:34 +02001659
1660// Test that stats work properly for a conf call with multiple recv streams.
srtee0c2eea2017-12-15 17:44:33 +01001661TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleRecvStreams) {
Mirko Bonadeief0627f2019-10-15 08:54:49 +00001662 webrtc::test::ScopedFieldTrials field_trials(
1663 "WebRTC-UseStandardBytesStats/Enabled/");
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001664 SetUp();
1665
Niels Möller6557d0c2018-04-11 15:18:34 +02001666 cricket::FakeVideoRenderer renderer1, renderer2;
1667 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1668 cricket::VideoSendParameters parameters;
1669 parameters.codecs.push_back(DefaultCodec());
1670 parameters.conference_mode = true;
1671 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1672 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001673 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1674 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001675 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1676 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1677 EXPECT_EQ(0, renderer1.num_rendered_frames());
1678 EXPECT_EQ(0, renderer2.num_rendered_frames());
1679 std::vector<uint32_t> ssrcs;
1680 ssrcs.push_back(1);
1681 ssrcs.push_back(2);
1682 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001683 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001684 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1685 kTimeout);
1686 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1687 kTimeout);
1688
1689 EXPECT_TRUE(channel_->SetSend(false));
1690
1691 cricket::VideoMediaInfo info;
1692 EXPECT_TRUE(channel_->GetStats(&info));
1693 ASSERT_EQ(1U, info.senders.size());
1694 // TODO(whyuan): bytes_sent and bytes_rcvd are different. Are both payload?
1695 // For webrtc, bytes_sent does not include the RTP header length.
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001696 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Mirko Bonadeief0627f2019-10-15 08:54:49 +00001697 GetSenderStats(0).bytes_sent, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001698 EXPECT_EQ_WAIT(NumRtpPackets(), GetSenderStats(0).packets_sent, kTimeout);
1699 EXPECT_EQ(kVideoWidth, GetSenderStats(0).send_frame_width);
1700 EXPECT_EQ(kVideoHeight, GetSenderStats(0).send_frame_height);
1701
1702 ASSERT_EQ(2U, info.receivers.size());
1703 for (size_t i = 0; i < info.receivers.size(); ++i) {
1704 EXPECT_EQ(1U, GetReceiverStats(i).ssrcs().size());
1705 EXPECT_EQ(i + 1, GetReceiverStats(i).ssrcs()[0]);
Bjorn A Mellemda4f0932019-07-30 08:34:03 -07001706 EXPECT_EQ_WAIT(NumRtpBytes() - kRtpHeaderSize * NumRtpPackets(),
Mirko Bonadeief0627f2019-10-15 08:54:49 +00001707 GetReceiverStats(i).bytes_rcvd, kTimeout);
Yves Gerey665174f2018-06-19 15:03:05 +02001708 EXPECT_EQ_WAIT(NumRtpPackets(), GetReceiverStats(i).packets_rcvd, kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001709 EXPECT_EQ_WAIT(kVideoWidth, GetReceiverStats(i).frame_width, kTimeout);
1710 EXPECT_EQ_WAIT(kVideoHeight, GetReceiverStats(i).frame_height, kTimeout);
1711 }
srtee0c2eea2017-12-15 17:44:33 +01001712}
Niels Möller6557d0c2018-04-11 15:18:34 +02001713
1714// Test that stats work properly for a conf call with multiple send streams.
srtee0c2eea2017-12-15 17:44:33 +01001715TEST_F(WebRtcVideoChannelBaseTest, GetStatsMultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001716 // Normal setup; note that we set the SSRC explicitly to ensure that
1717 // it will come first in the senders map.
1718 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1719 cricket::VideoSendParameters parameters;
1720 parameters.codecs.push_back(DefaultCodec());
1721 parameters.conference_mode = true;
1722 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Yves Gerey665174f2018-06-19 15:03:05 +02001723 EXPECT_TRUE(
1724 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001725 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
1726 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001727 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001728 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
1729 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1730
1731 // Add an additional capturer, and hook up a renderer to receive it.
1732 cricket::FakeVideoRenderer renderer2;
Niels Möller805a27e2019-01-21 12:21:27 +01001733 webrtc::test::FrameForwarder frame_forwarder;
Niels Möller6557d0c2018-04-11 15:18:34 +02001734 const int kTestWidth = 160;
1735 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01001736 cricket::FakeFrameSource frame_source(kTestWidth, kTestHeight,
1737 rtc::kNumMicrosecsPerSec / 5);
Yves Gerey665174f2018-06-19 15:03:05 +02001738 EXPECT_TRUE(
1739 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller805a27e2019-01-21 12:21:27 +01001740 EXPECT_TRUE(channel_->SetVideoSend(5678, nullptr, &frame_forwarder));
Yves Gerey665174f2018-06-19 15:03:05 +02001741 EXPECT_TRUE(
1742 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(5678)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001743 EXPECT_TRUE(channel_->SetSink(5678, &renderer2));
Niels Möller805a27e2019-01-21 12:21:27 +01001744 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Yves Gerey665174f2018-06-19 15:03:05 +02001745 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
1746 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001747
1748 // Get stats, and make sure they are correct for two senders. We wait until
1749 // the number of expected packets have been sent to avoid races where we
1750 // check stats before it has been updated.
1751 cricket::VideoMediaInfo info;
1752 for (uint32_t i = 0; i < kTimeout; ++i) {
1753 rtc::Thread::Current()->ProcessMessages(1);
1754 EXPECT_TRUE(channel_->GetStats(&info));
1755 ASSERT_EQ(2U, info.senders.size());
1756 if (info.senders[0].packets_sent + info.senders[1].packets_sent ==
1757 NumRtpPackets()) {
1758 // Stats have been updated for both sent frames, expectations can be
1759 // checked now.
1760 break;
1761 }
1762 }
1763 EXPECT_EQ(NumRtpPackets(),
1764 info.senders[0].packets_sent + info.senders[1].packets_sent)
1765 << "Timed out while waiting for packet counts for all sent packets.";
1766 EXPECT_EQ(1U, info.senders[0].ssrcs().size());
1767 EXPECT_EQ(1234U, info.senders[0].ssrcs()[0]);
1768 EXPECT_EQ(kVideoWidth, info.senders[0].send_frame_width);
1769 EXPECT_EQ(kVideoHeight, info.senders[0].send_frame_height);
1770 EXPECT_EQ(1U, info.senders[1].ssrcs().size());
1771 EXPECT_EQ(5678U, info.senders[1].ssrcs()[0]);
1772 EXPECT_EQ(kTestWidth, info.senders[1].send_frame_width);
1773 EXPECT_EQ(kTestHeight, info.senders[1].send_frame_height);
1774 // The capturer must be unregistered here as it runs out of it's scope next.
1775 channel_->SetVideoSend(5678, nullptr, nullptr);
srtee0c2eea2017-12-15 17:44:33 +01001776}
pbos@webrtc.org8fdeee62014-07-20 14:40:23 +00001777
Niels Möller6557d0c2018-04-11 15:18:34 +02001778// Test that we can set the bandwidth.
srtee0c2eea2017-12-15 17:44:33 +01001779TEST_F(WebRtcVideoChannelBaseTest, SetSendBandwidth) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001780 cricket::VideoSendParameters parameters;
1781 parameters.codecs.push_back(DefaultCodec());
1782 parameters.max_bandwidth_bps = -1; // <= 0 means unlimited.
1783 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1784 parameters.max_bandwidth_bps = 128 * 1024;
1785 EXPECT_TRUE(channel_->SetSendParameters(parameters));
srtee0c2eea2017-12-15 17:44:33 +01001786}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001787
Niels Möller6557d0c2018-04-11 15:18:34 +02001788// Test that we can set the SSRC for the default send source.
srtee0c2eea2017-12-15 17:44:33 +01001789TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrc) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001790 EXPECT_TRUE(SetDefaultCodec());
1791 EXPECT_TRUE(SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01001792 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001793 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001794 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001795 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001796 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1797 EXPECT_EQ(kSsrc, header.ssrc);
1798
Niels Möller6557d0c2018-04-11 15:18:34 +02001799 // Packets are being paced out, so these can mismatch between the first and
1800 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001801 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1802 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001803 EXPECT_EQ(1, NumSentSsrcs());
1804 EXPECT_EQ(0, NumRtpPackets(kSsrc - 1));
1805 EXPECT_EQ(0, NumRtpBytes(kSsrc - 1));
srtee0c2eea2017-12-15 17:44:33 +01001806}
Niels Möller6557d0c2018-04-11 15:18:34 +02001807
1808// Test that we can set the SSRC even after codecs are set.
srtee0c2eea2017-12-15 17:44:33 +01001809TEST_F(WebRtcVideoChannelBaseTest, SetSendSsrcAfterSetCodecs) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001810 // Remove stream added in Setup.
1811 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1812 EXPECT_TRUE(SetDefaultCodec());
Niels Möller6557d0c2018-04-11 15:18:34 +02001813 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001814 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(999)));
Niels Möller805a27e2019-01-21 12:21:27 +01001815 EXPECT_TRUE(channel_->SetVideoSend(999u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001816 EXPECT_TRUE(SetSend(true));
1817 EXPECT_TRUE(WaitAndSendFrame(0));
1818 EXPECT_TRUE_WAIT(NumRtpPackets() > 0, kTimeout);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001819 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001820 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001821 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1822 EXPECT_EQ(999u, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001823 // Packets are being paced out, so these can mismatch between the first and
1824 // second call to NumRtpPackets until pending packets are paced out.
Åsa Persson23cd45a2018-07-03 10:40:40 +02001825 EXPECT_EQ_WAIT(NumRtpPackets(), NumRtpPackets(header.ssrc), kTimeout);
1826 EXPECT_EQ_WAIT(NumRtpBytes(), NumRtpBytes(header.ssrc), kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001827 EXPECT_EQ(1, NumSentSsrcs());
1828 EXPECT_EQ(0, NumRtpPackets(kSsrc));
1829 EXPECT_EQ(0, NumRtpBytes(kSsrc));
srtee0c2eea2017-12-15 17:44:33 +01001830}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001831
Niels Möller6557d0c2018-04-11 15:18:34 +02001832// Test that we can set the default video renderer before and after
1833// media is received.
srtee0c2eea2017-12-15 17:44:33 +01001834TEST_F(WebRtcVideoChannelBaseTest, SetSink) {
Yves Gerey665174f2018-06-19 15:03:05 +02001835 uint8_t data1[] = {0x80, 0x00, 0x00, 0x00, 0x00, 0x00,
1836 0x00, 0x00, 0x00, 0x00, 0x00, 0x00};
Niels Möller6557d0c2018-04-11 15:18:34 +02001837
1838 rtc::CopyOnWriteBuffer packet1(data1, sizeof(data1));
1839 rtc::SetBE32(packet1.data() + 8, kSsrc);
1840 channel_->SetSink(kDefaultReceiveSsrc, NULL);
1841 EXPECT_TRUE(SetDefaultCodec());
1842 EXPECT_TRUE(SetSend(true));
1843 EXPECT_EQ(0, renderer_.num_rendered_frames());
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07001844 channel_->OnPacketReceived(packet1, /* packet_time_us */ -1);
Niels Möller6557d0c2018-04-11 15:18:34 +02001845 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001846 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001847 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
srtee0c2eea2017-12-15 17:44:33 +01001848}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001849
Niels Möller6557d0c2018-04-11 15:18:34 +02001850// Tests setting up and configuring a send stream.
srtee0c2eea2017-12-15 17:44:33 +01001851TEST_F(WebRtcVideoChannelBaseTest, AddRemoveSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001852 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1853 EXPECT_TRUE(SetSend(true));
1854 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Niels Möller805a27e2019-01-21 12:21:27 +01001855 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001856 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1857 EXPECT_GT(NumRtpPackets(), 0);
Åsa Persson23cd45a2018-07-03 10:40:40 +02001858 webrtc::RTPHeader header;
Niels Möller6557d0c2018-04-11 15:18:34 +02001859 size_t last_packet = NumRtpPackets() - 1;
Yves Gerey665174f2018-06-19 15:03:05 +02001860 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(
1861 GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001862 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1863 EXPECT_EQ(kSsrc, header.ssrc);
Niels Möller6557d0c2018-04-11 15:18:34 +02001864
1865 // Remove the send stream that was added during Setup.
1866 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
1867 int rtp_packets = NumRtpPackets();
1868
Niels Möller6557d0c2018-04-11 15:18:34 +02001869 EXPECT_TRUE(
Yves Gerey665174f2018-06-19 15:03:05 +02001870 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
Niels Möller805a27e2019-01-21 12:21:27 +01001871 EXPECT_TRUE(channel_->SetVideoSend(789u, nullptr, frame_forwarder_.get()));
Niels Möller6557d0c2018-04-11 15:18:34 +02001872 EXPECT_EQ(rtp_packets, NumRtpPackets());
1873 // Wait 30ms to guarantee the engine does not drop the frame.
1874 EXPECT_TRUE(WaitAndSendFrame(30));
1875 EXPECT_TRUE_WAIT(NumRtpPackets() > rtp_packets, kTimeout);
1876
1877 last_packet = NumRtpPackets() - 1;
1878 p.reset(GetRtpPacket(static_cast<int>(last_packet)));
Åsa Persson23cd45a2018-07-03 10:40:40 +02001879 EXPECT_TRUE(ParseRtpPacket(p.get(), &header));
1880 EXPECT_EQ(789u, header.ssrc);
srtee0c2eea2017-12-15 17:44:33 +01001881}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001882
Niels Möller6557d0c2018-04-11 15:18:34 +02001883// Tests the behavior of incoming streams in a conference scenario.
srtee0c2eea2017-12-15 17:44:33 +01001884TEST_F(WebRtcVideoChannelBaseTest, SimulateConference) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001885 cricket::FakeVideoRenderer renderer1, renderer2;
1886 EXPECT_TRUE(SetDefaultCodec());
1887 cricket::VideoSendParameters parameters;
1888 parameters.codecs.push_back(DefaultCodec());
1889 parameters.conference_mode = true;
1890 EXPECT_TRUE(channel_->SetSendParameters(parameters));
1891 EXPECT_TRUE(SetSend(true));
Yves Gerey665174f2018-06-19 15:03:05 +02001892 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
1893 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02001894 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
1895 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
1896 EXPECT_EQ(0, renderer1.num_rendered_frames());
1897 EXPECT_EQ(0, renderer2.num_rendered_frames());
1898 std::vector<uint32_t> ssrcs;
1899 ssrcs.push_back(1);
1900 ssrcs.push_back(2);
1901 network_interface_.SetConferenceMode(true, ssrcs);
Niels Möller805a27e2019-01-21 12:21:27 +01001902 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001903 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kVideoWidth, kVideoHeight,
1904 kTimeout);
1905 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kVideoWidth, kVideoHeight,
1906 kTimeout);
1907
1908 std::unique_ptr<const rtc::CopyOnWriteBuffer> p(GetRtpPacket(0));
1909 EXPECT_EQ(DefaultCodec().id, GetPayloadType(p.get()));
1910 EXPECT_EQ(kVideoWidth, renderer1.width());
1911 EXPECT_EQ(kVideoHeight, renderer1.height());
1912 EXPECT_EQ(kVideoWidth, renderer2.width());
1913 EXPECT_EQ(kVideoHeight, renderer2.height());
1914 EXPECT_TRUE(channel_->RemoveRecvStream(2));
1915 EXPECT_TRUE(channel_->RemoveRecvStream(1));
srtee0c2eea2017-12-15 17:44:33 +01001916}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001917
Niels Möller6557d0c2018-04-11 15:18:34 +02001918// Tests that we can add and remove capturers and frames are sent out properly
srtee0c2eea2017-12-15 17:44:33 +01001919TEST_F(WebRtcVideoChannelBaseTest, DISABLED_AddRemoveCapturer) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001920 using cricket::FOURCC_I420;
Jonas Olssona4d87372019-07-05 19:08:33 +02001921 using cricket::VideoCodec;
1922 using cricket::VideoFormat;
1923 using cricket::VideoOptions;
Niels Möller6557d0c2018-04-11 15:18:34 +02001924
1925 VideoCodec codec = DefaultCodec();
1926 const int time_between_send_ms = VideoFormat::FpsToInterval(kFramerate);
1927 EXPECT_TRUE(SetOneCodec(codec));
1928 EXPECT_TRUE(SetSend(true));
1929 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1930 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001931 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001932 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Niels Möller805a27e2019-01-21 12:21:27 +01001933
1934 webrtc::test::FrameForwarder frame_forwarder;
1935 cricket::FakeFrameSource frame_source(480, 360, rtc::kNumMicrosecsPerSec / 30,
1936 rtc::kNumMicrosecsPerSec / 30);
Niels Möller6557d0c2018-04-11 15:18:34 +02001937
1938 // TODO(nisse): This testcase fails if we don't configure
1939 // screencast. It's unclear why, I see nothing obvious in this
1940 // test which is related to screencast logic.
1941 VideoOptions video_options;
1942 video_options.is_screencast = true;
1943 channel_->SetVideoSend(kSsrc, &video_options, nullptr);
1944
Niels Möller6557d0c2018-04-11 15:18:34 +02001945 int captured_frames = 1;
1946 for (int iterations = 0; iterations < 2; ++iterations) {
Niels Möller805a27e2019-01-21 12:21:27 +01001947 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, &frame_forwarder));
Niels Möller6557d0c2018-04-11 15:18:34 +02001948 rtc::Thread::Current()->ProcessMessages(time_between_send_ms);
Niels Möller805a27e2019-01-21 12:21:27 +01001949 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
1950
Niels Möller6557d0c2018-04-11 15:18:34 +02001951 ++captured_frames;
1952 // Wait until frame of right size is captured.
1953 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001954 480 == renderer_.width() &&
1955 360 == renderer_.height() && !renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001956 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001957 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001958 EXPECT_EQ(480, renderer_.width());
1959 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001960 captured_frames = renderer_.num_rendered_frames() + 1;
1961 EXPECT_FALSE(renderer_.black_frame());
1962 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1963 // Make sure a black frame is generated within the specified timeout.
1964 // The black frame should be the resolution of the previous frame to
1965 // prevent expensive encoder reconfigurations.
1966 EXPECT_TRUE_WAIT(renderer_.num_rendered_frames() >= captured_frames &&
Niels Möller805a27e2019-01-21 12:21:27 +01001967 480 == renderer_.width() &&
1968 360 == renderer_.height() && renderer_.black_frame(),
Yves Gerey665174f2018-06-19 15:03:05 +02001969 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02001970 EXPECT_GE(renderer_.num_rendered_frames(), captured_frames);
Niels Möller805a27e2019-01-21 12:21:27 +01001971 EXPECT_EQ(480, renderer_.width());
1972 EXPECT_EQ(360, renderer_.height());
Niels Möller6557d0c2018-04-11 15:18:34 +02001973 EXPECT_TRUE(renderer_.black_frame());
1974
1975 // The black frame has the same timestamp as the next frame since it's
1976 // timestamp is set to the last frame's timestamp + interval. WebRTC will
1977 // not render a frame with the same timestamp so capture another frame
1978 // with the frame capturer to increment the next frame's timestamp.
Niels Möller805a27e2019-01-21 12:21:27 +01001979 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Niels Möller6557d0c2018-04-11 15:18:34 +02001980 }
srtee0c2eea2017-12-15 17:44:33 +01001981}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00001982
Niels Möller6557d0c2018-04-11 15:18:34 +02001983// Tests that if SetVideoSend is called with a NULL capturer after the
1984// capturer was already removed, the application doesn't crash (and no black
1985// frame is sent).
srtee0c2eea2017-12-15 17:44:33 +01001986TEST_F(WebRtcVideoChannelBaseTest, RemoveCapturerWithoutAdd) {
Niels Möller6557d0c2018-04-11 15:18:34 +02001987 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
1988 EXPECT_TRUE(SetSend(true));
1989 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
1990 EXPECT_EQ(0, renderer_.num_rendered_frames());
Niels Möller805a27e2019-01-21 12:21:27 +01001991 SendFrame();
Niels Möller6557d0c2018-04-11 15:18:34 +02001992 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
1993 // Wait for one frame so they don't get dropped because we send frames too
1994 // tightly.
1995 rtc::Thread::Current()->ProcessMessages(30);
1996 // Remove the capturer.
1997 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
1998
1999 // No capturer was added, so this SetVideoSend shouldn't do anything.
2000 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2001 rtc::Thread::Current()->ProcessMessages(300);
2002 // Verify no more frames were sent.
2003 EXPECT_EQ(1, renderer_.num_rendered_frames());
srtee0c2eea2017-12-15 17:44:33 +01002004}
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002005
Niels Möller6557d0c2018-04-11 15:18:34 +02002006// Tests that we can add and remove capturer as unique sources.
srtee0c2eea2017-12-15 17:44:33 +01002007TEST_F(WebRtcVideoChannelBaseTest, AddRemoveCapturerMultipleSources) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002008 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2009 // interval time to avoid that.
2010 // WebRTC implementation will drop frames if pushed to quickly. Wait the
2011 // interval time to avoid that.
2012 // Set up the stream associated with the engine.
Yves Gerey665174f2018-06-19 15:03:05 +02002013 EXPECT_TRUE(
2014 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrc)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002015 EXPECT_TRUE(channel_->SetSink(kSsrc, &renderer_));
2016 cricket::VideoFormat capture_format(
2017 kVideoWidth, kVideoHeight,
2018 cricket::VideoFormat::FpsToInterval(kFramerate), cricket::FOURCC_I420);
2019 // Set up additional stream 1.
2020 cricket::FakeVideoRenderer renderer1;
2021 EXPECT_FALSE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002022 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002023 EXPECT_TRUE(channel_->SetSink(1, &renderer1));
Yves Gerey665174f2018-06-19 15:03:05 +02002024 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(1)));
Niels Möller805a27e2019-01-21 12:21:27 +01002025
2026 webrtc::test::FrameForwarder frame_forwarder1;
2027 cricket::FakeFrameSource frame_source(kVideoWidth, kVideoHeight,
2028 rtc::kNumMicrosecsPerSec / kFramerate);
2029
Niels Möller6557d0c2018-04-11 15:18:34 +02002030 // Set up additional stream 2.
2031 cricket::FakeVideoRenderer renderer2;
2032 EXPECT_FALSE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002033 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller6557d0c2018-04-11 15:18:34 +02002034 EXPECT_TRUE(channel_->SetSink(2, &renderer2));
Yves Gerey665174f2018-06-19 15:03:05 +02002035 EXPECT_TRUE(channel_->AddSendStream(cricket::StreamParams::CreateLegacy(2)));
Niels Möller805a27e2019-01-21 12:21:27 +01002036 webrtc::test::FrameForwarder frame_forwarder2;
2037
Niels Möller6557d0c2018-04-11 15:18:34 +02002038 // State for all the streams.
2039 EXPECT_TRUE(SetOneCodec(DefaultCodec()));
2040 // A limitation in the lmi implementation requires that SetVideoSend() is
2041 // called after SetOneCodec().
2042 // TODO(hellner): this seems like an unnecessary constraint, fix it.
Niels Möller805a27e2019-01-21 12:21:27 +01002043 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, &frame_forwarder1));
2044 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, &frame_forwarder2));
Niels Möller6557d0c2018-04-11 15:18:34 +02002045 EXPECT_TRUE(SetSend(true));
2046 // Test capturer associated with engine.
2047 const int kTestWidth = 160;
2048 const int kTestHeight = 120;
Niels Möller805a27e2019-01-21 12:21:27 +01002049 frame_forwarder1.IncomingCapturedFrame(frame_source.GetFrame(
2050 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2051 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002052 EXPECT_FRAME_ON_RENDERER_WAIT(renderer1, 1, kTestWidth, kTestHeight,
2053 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002054 // Capture a frame with additional capturer2, frames should be received
Niels Möller805a27e2019-01-21 12:21:27 +01002055 frame_forwarder2.IncomingCapturedFrame(frame_source.GetFrame(
2056 kTestWidth, kTestHeight, webrtc::VideoRotation::kVideoRotation_0,
2057 rtc::kNumMicrosecsPerSec / kFramerate));
Yves Gerey665174f2018-06-19 15:03:05 +02002058 EXPECT_FRAME_ON_RENDERER_WAIT(renderer2, 1, kTestWidth, kTestHeight,
2059 kTimeout);
Niels Möller6557d0c2018-04-11 15:18:34 +02002060 // Successfully remove the capturer.
2061 EXPECT_TRUE(channel_->SetVideoSend(kSsrc, nullptr, nullptr));
2062 // The capturers must be unregistered here as it runs out of it's scope
2063 // next.
2064 EXPECT_TRUE(channel_->SetVideoSend(1, nullptr, nullptr));
2065 EXPECT_TRUE(channel_->SetVideoSend(2, nullptr, nullptr));
srtee0c2eea2017-12-15 17:44:33 +01002066}
Niels Möller6557d0c2018-04-11 15:18:34 +02002067
2068// Tests empty StreamParams is rejected.
srtee0c2eea2017-12-15 17:44:33 +01002069TEST_F(WebRtcVideoChannelBaseTest, RejectEmptyStreamParams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002070 // Remove the send stream that was added during Setup.
2071 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
2072
2073 cricket::StreamParams empty;
2074 EXPECT_FALSE(channel_->AddSendStream(empty));
Yves Gerey665174f2018-06-19 15:03:05 +02002075 EXPECT_TRUE(
2076 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(789u)));
srtee0c2eea2017-12-15 17:44:33 +01002077}
Niels Möller6557d0c2018-04-11 15:18:34 +02002078
2079// Test that multiple send streams can be created and deleted properly.
srtee0c2eea2017-12-15 17:44:33 +01002080TEST_F(WebRtcVideoChannelBaseTest, MultipleSendStreams) {
Niels Möller6557d0c2018-04-11 15:18:34 +02002081 // Remove stream added in Setup. I.e. remove stream corresponding to default
2082 // channel.
2083 EXPECT_TRUE(channel_->RemoveSendStream(kSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02002084 const unsigned int kSsrcsSize = sizeof(kSsrcs4) / sizeof(kSsrcs4[0]);
Niels Möller6557d0c2018-04-11 15:18:34 +02002085 for (unsigned int i = 0; i < kSsrcsSize; ++i) {
2086 EXPECT_TRUE(channel_->AddSendStream(
2087 cricket::StreamParams::CreateLegacy(kSsrcs4[i])));
2088 }
2089 // Delete one of the non default channel streams, let the destructor delete
2090 // the remaining ones.
2091 EXPECT_TRUE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
2092 // Stream should already be deleted.
2093 EXPECT_FALSE(channel_->RemoveSendStream(kSsrcs4[kSsrcsSize - 1]));
srtee0c2eea2017-12-15 17:44:33 +01002094}
pbos@webrtc.orgc4175b92014-09-03 15:25:49 +00002095
eladalonf1841382017-06-12 01:16:46 -07002096TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Vga) {
magjed509e4fe2016-11-18 01:34:11 -08002097 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002098}
2099
eladalonf1841382017-06-12 01:16:46 -07002100TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8Qvga) {
magjed509e4fe2016-11-18 01:34:11 -08002101 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002102}
2103
eladalonf1841382017-06-12 01:16:46 -07002104TEST_F(WebRtcVideoChannelBaseTest, SendAndReceiveVp8SvcQqvga) {
magjed509e4fe2016-11-18 01:34:11 -08002105 SendAndReceive(GetEngineCodec("VP8"));
pbos@webrtc.org9359cb32014-07-23 15:44:48 +00002106}
2107
eladalonf1841382017-06-12 01:16:46 -07002108TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) {
Peter Boströmd1f584b2016-04-20 16:31:53 +02002109 // Set a high bitrate to not be downscaled by VP8 due to low initial start
2110 // bitrates. This currently happens at <250k, and two streams sharing 300k
2111 // initially will use QVGA instead of VGA.
2112 // TODO(pbos): Set up the quality scaler so that both senders reliably start
2113 // at QVGA, then verify that instead.
magjed509e4fe2016-11-18 01:34:11 -08002114 cricket::VideoCodec codec = GetEngineCodec("VP8");
Peter Boströmd1f584b2016-04-20 16:31:53 +02002115 codec.params[kCodecParamStartBitrate] = "1000000";
Niels Möller6557d0c2018-04-11 15:18:34 +02002116 TwoStreamsSendAndReceive(codec);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002117}
2118
philipeld9cc8c02019-09-16 14:53:40 +02002119TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderFallback) {
philipele8ed8302019-07-03 11:53:48 +02002120 cricket::VideoSendParameters parameters;
2121 parameters.codecs.push_back(GetEngineCodec("VP9"));
2122 parameters.codecs.push_back(GetEngineCodec("VP8"));
2123 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2124
2125 VideoCodec codec;
2126 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2127 EXPECT_EQ("VP9", codec.name);
2128
philipeld9cc8c02019-09-16 14:53:40 +02002129 // RequestEncoderFallback will post a task to the worker thread (which is also
philipele8ed8302019-07-03 11:53:48 +02002130 // the current thread), hence the ProcessMessages call.
philipeld9cc8c02019-09-16 14:53:40 +02002131 channel_->RequestEncoderFallback();
philipele8ed8302019-07-03 11:53:48 +02002132 rtc::Thread::Current()->ProcessMessages(30);
2133 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2134 EXPECT_EQ("VP8", codec.name);
2135
2136 // No other codec to fall back to, keep using VP8.
philipeld9cc8c02019-09-16 14:53:40 +02002137 channel_->RequestEncoderFallback();
philipele8ed8302019-07-03 11:53:48 +02002138 rtc::Thread::Current()->ProcessMessages(30);
2139 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2140 EXPECT_EQ("VP8", codec.name);
2141}
2142
philipeld9cc8c02019-09-16 14:53:40 +02002143TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderSwitchWithConfig) {
2144 const std::string kParam = "the-param";
2145 const std::string kPing = "ping";
2146 const std::string kPong = "pong";
2147
2148 cricket::VideoSendParameters parameters;
2149 VideoCodec vp9 = GetEngineCodec("VP9");
2150 vp9.params[kParam] = kPong;
2151 parameters.codecs.push_back(vp9);
2152
2153 VideoCodec vp8 = GetEngineCodec("VP8");
2154 vp8.params[kParam] = kPing;
2155 parameters.codecs.push_back(vp8);
2156
2157 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2158
2159 VideoCodec codec;
2160 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2161 EXPECT_THAT(codec.name, Eq("VP9"));
2162
2163 // RequestEncoderSwitch will post a task to the worker thread (which is also
2164 // the current thread), hence the ProcessMessages call.
2165 webrtc::EncoderSwitchRequestCallback::Config conf1{"VP8", kParam, kPing};
2166 channel_->RequestEncoderSwitch(conf1);
2167 rtc::Thread::Current()->ProcessMessages(30);
2168 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2169 EXPECT_THAT(codec.name, Eq("VP8"));
2170 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2171
2172 webrtc::EncoderSwitchRequestCallback::Config conf2{"VP9", kParam, kPong};
2173 channel_->RequestEncoderSwitch(conf2);
2174 rtc::Thread::Current()->ProcessMessages(30);
2175 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2176 EXPECT_THAT(codec.name, Eq("VP9"));
2177 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPong)));
2178}
2179
2180TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderSwitchIncorrectParam) {
2181 const std::string kParam = "the-param";
2182 const std::string kPing = "ping";
2183 const std::string kPong = "pong";
2184
2185 cricket::VideoSendParameters parameters;
2186 VideoCodec vp9 = GetEngineCodec("VP9");
2187 vp9.params[kParam] = kPong;
2188 parameters.codecs.push_back(vp9);
2189
2190 VideoCodec vp8 = GetEngineCodec("VP8");
2191 vp8.params[kParam] = kPing;
2192 parameters.codecs.push_back(vp8);
2193
2194 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2195
2196 VideoCodec codec;
2197 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2198 EXPECT_THAT(codec.name, Eq("VP9"));
2199
2200 // RequestEncoderSwitch will post a task to the worker thread (which is also
2201 // the current thread), hence the ProcessMessages call.
2202 webrtc::EncoderSwitchRequestCallback::Config conf1{"VP8", kParam, kPing};
2203 channel_->RequestEncoderSwitch(conf1);
2204 rtc::Thread::Current()->ProcessMessages(30);
2205 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2206 EXPECT_THAT(codec.name, Eq("VP8"));
2207 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2208
2209 // Incorrect conf2.value, expect no codec switch.
2210 webrtc::EncoderSwitchRequestCallback::Config conf2{"VP9", kParam, kPing};
2211 channel_->RequestEncoderSwitch(conf2);
2212 rtc::Thread::Current()->ProcessMessages(30);
2213 ASSERT_TRUE(channel_->GetSendCodec(&codec));
2214 EXPECT_THAT(codec.name, Eq("VP8"));
2215 EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing)));
2216}
2217
eladalonf1841382017-06-12 01:16:46 -07002218class WebRtcVideoChannelTest : public WebRtcVideoEngineTest {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002219 public:
eladalonf1841382017-06-12 01:16:46 -07002220 WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}
2221 explicit WebRtcVideoChannelTest(const char* field_trials)
Niels Möller805a27e2019-01-21 12:21:27 +01002222 : WebRtcVideoEngineTest(field_trials),
2223 frame_source_(1280, 720, rtc::kNumMicrosecsPerSec / 30),
2224 last_ssrc_(0) {}
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00002225 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002226 encoder_factory_->AddSupportedVideoCodecType("VP8");
2227 encoder_factory_->AddSupportedVideoCodecType("VP9");
2228#if defined(WEBRTC_USE_H264)
2229 encoder_factory_->AddSupportedVideoCodecType("H264");
2230#endif
2231
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002232 fake_call_.reset(new FakeCall());
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02002233 channel_.reset(engine_.CreateMediaChannel(
2234 fake_call_.get(), GetMediaConfig(), VideoOptions(),
2235 webrtc::CryptoOptions(), video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08002236 channel_->OnReadyToSend(true);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002237 last_ssrc_ = 123;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002238 send_parameters_.codecs = engine_.codecs();
2239 recv_parameters_.codecs = engine_.codecs();
2240 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002241 }
2242
2243 protected:
2244 FakeVideoSendStream* AddSendStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002245 return AddSendStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002246 }
2247
2248 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002249 size_t num_streams = fake_call_->GetVideoSendStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002250 EXPECT_TRUE(channel_->AddSendStream(sp));
2251 std::vector<FakeVideoSendStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002252 fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002253 EXPECT_EQ(num_streams + 1, streams.size());
2254 return streams[streams.size() - 1];
2255 }
2256
2257 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002258 return fake_call_->GetVideoSendStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002259 }
2260
2261 FakeVideoReceiveStream* AddRecvStream() {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002262 return AddRecvStream(StreamParams::CreateLegacy(++last_ssrc_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002263 }
2264
2265 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002266 size_t num_streams = fake_call_->GetVideoReceiveStreams().size();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002267 EXPECT_TRUE(channel_->AddRecvStream(sp));
2268 std::vector<FakeVideoReceiveStream*> streams =
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002269 fake_call_->GetVideoReceiveStreams();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002270 EXPECT_EQ(num_streams + 1, streams.size());
2271 return streams[streams.size() - 1];
2272 }
2273
pbos@webrtc.org00873182014-11-25 14:03:34 +00002274 void SetSendCodecsShouldWorkForBitrates(const char* min_bitrate_kbps,
2275 int expected_min_bitrate_bps,
2276 const char* start_bitrate_kbps,
2277 int expected_start_bitrate_bps,
2278 const char* max_bitrate_kbps,
2279 int expected_max_bitrate_bps) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002280 ExpectSetBitrateParameters(expected_min_bitrate_bps,
2281 expected_start_bitrate_bps,
2282 expected_max_bitrate_bps);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002283 auto& codecs = send_parameters_.codecs;
2284 codecs.clear();
magjed509e4fe2016-11-18 01:34:11 -08002285 codecs.push_back(GetEngineCodec("VP8"));
pbos@webrtc.org00873182014-11-25 14:03:34 +00002286 codecs[0].params[kCodecParamMinBitrate] = min_bitrate_kbps;
2287 codecs[0].params[kCodecParamStartBitrate] = start_bitrate_kbps;
2288 codecs[0].params[kCodecParamMaxBitrate] = max_bitrate_kbps;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002289 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002290 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002291
Sebastian Jansson8f83b422018-02-21 13:07:13 +01002292 void ExpectSetBitrateParameters(int min_bitrate_bps,
2293 int start_bitrate_bps,
2294 int max_bitrate_bps) {
2295 EXPECT_CALL(
2296 *fake_call_->GetMockTransportControllerSend(),
2297 SetSdpBitrateParameters(AllOf(
2298 Field(&BitrateConstraints::min_bitrate_bps, min_bitrate_bps),
2299 Field(&BitrateConstraints::start_bitrate_bps, start_bitrate_bps),
2300 Field(&BitrateConstraints::max_bitrate_bps, max_bitrate_bps))));
2301 }
2302
2303 void ExpectSetMaxBitrate(int max_bitrate_bps) {
2304 EXPECT_CALL(*fake_call_->GetMockTransportControllerSend(),
2305 SetSdpBitrateParameters(Field(
2306 &BitrateConstraints::max_bitrate_bps, max_bitrate_bps)));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002307 }
2308
Johannes Kron9190b822018-10-29 11:22:05 +01002309 void TestExtmapAllowMixedCaller(bool extmap_allow_mixed) {
2310 // For a caller, the answer will be applied in set remote description
2311 // where SetSendParameters() is called.
2312 EXPECT_TRUE(
2313 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2314 send_parameters_.extmap_allow_mixed = extmap_allow_mixed;
2315 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
2316 const webrtc::VideoSendStream::Config& config =
2317 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2318 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2319 }
2320
2321 void TestExtmapAllowMixedCallee(bool extmap_allow_mixed) {
2322 // For a callee, the answer will be applied in set local description
2323 // where SetExtmapAllowMixed() and AddSendStream() are called.
2324 channel_->SetExtmapAllowMixed(extmap_allow_mixed);
2325 EXPECT_TRUE(
2326 channel_->AddSendStream(cricket::StreamParams::CreateLegacy(kSsrc)));
2327 const webrtc::VideoSendStream::Config& config =
2328 fake_call_->GetVideoSendStreams()[0]->GetConfig();
2329 EXPECT_EQ(extmap_allow_mixed, config.rtp.extmap_allow_mixed);
2330 }
2331
isheriff6f8d6862016-05-26 11:24:55 -07002332 void TestSetSendRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002333 // Enable extension.
2334 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002335 cricket::VideoSendParameters parameters = send_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002336 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002337 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002338 FakeVideoSendStream* send_stream =
2339 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2340
2341 // Verify the send extension id.
2342 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2343 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002344 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002345 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002346 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002347 // Verify that SetSendRtpHeaderExtensions doesn't implicitly add them for
2348 // receivers.
2349 EXPECT_TRUE(AddRecvStream(cricket::StreamParams::CreateLegacy(123))
2350 ->GetConfig()
2351 .rtp.extensions.empty());
2352
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002353 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002354 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002355 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
2356 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002357 EXPECT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2358
2359 // Verify that adding receive RTP header extensions adds them for existing
2360 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002361 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002362 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002363 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2364 EXPECT_EQ(id, send_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002365 EXPECT_EQ(ext_uri, send_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002366 }
2367
isheriff6f8d6862016-05-26 11:24:55 -07002368 void TestSetRecvRtpHeaderExtensions(const std::string& ext_uri) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002369 // Enable extension.
2370 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002371 cricket::VideoRecvParameters parameters = recv_parameters_;
isheriff6f8d6862016-05-26 11:24:55 -07002372 parameters.extensions.push_back(RtpExtension(ext_uri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002373 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002374
2375 FakeVideoReceiveStream* recv_stream =
2376 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2377
2378 // Verify the recv extension id.
2379 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2380 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002381 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002382 // Verify call with same set of extensions returns true.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002383 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002384
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002385 // Verify that SetRecvRtpHeaderExtensions doesn't implicitly add them for
2386 // senders.
2387 EXPECT_TRUE(AddSendStream(cricket::StreamParams::CreateLegacy(123))
2388 ->GetConfig()
2389 .rtp.extensions.empty());
2390
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002391 // Verify that existing RTP header extensions can be removed.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002392 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002393 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
2394 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002395 EXPECT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
2396
2397 // Verify that adding receive RTP header extensions adds them for existing
2398 // streams.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002399 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
Fredrik Solenberg709ed672015-09-15 12:26:33 +02002400 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00002401 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
2402 EXPECT_EQ(id, recv_stream->GetConfig().rtp.extensions[0].id);
isheriff6f8d6862016-05-26 11:24:55 -07002403 EXPECT_EQ(ext_uri, recv_stream->GetConfig().rtp.extensions[0].uri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002404 }
2405
Elad Alonfadb1812019-05-24 13:40:02 +02002406 void TestLossNotificationState(bool expect_lntf_enabled) {
2407 AssignDefaultCodec();
2408 VerifyCodecHasDefaultFeedbackParams(default_codec_, expect_lntf_enabled);
2409
2410 cricket::VideoSendParameters parameters;
2411 parameters.codecs = engine_.codecs();
2412 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2413 EXPECT_TRUE(channel_->SetSend(true));
2414
2415 // Send side.
2416 FakeVideoSendStream* send_stream =
2417 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2418 EXPECT_EQ(send_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2419
2420 // Receiver side.
2421 FakeVideoReceiveStream* recv_stream =
2422 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2423 EXPECT_EQ(recv_stream->GetConfig().rtp.lntf.enabled, expect_lntf_enabled);
2424 }
2425
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002426 void TestExtensionFilter(const std::vector<std::string>& extensions,
2427 const std::string& expected_extension) {
2428 cricket::VideoSendParameters parameters = send_parameters_;
2429 int expected_id = -1;
2430 int id = 1;
2431 for (const std::string& extension : extensions) {
2432 if (extension == expected_extension)
2433 expected_id = id;
isheriff6f8d6862016-05-26 11:24:55 -07002434 parameters.extensions.push_back(RtpExtension(extension, id++));
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002435 }
2436 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2437 FakeVideoSendStream* send_stream =
2438 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2439
2440 // Verify that only one of them has been set, and that it is the one with
2441 // highest priority (transport sequence number).
2442 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
2443 EXPECT_EQ(expected_id, send_stream->GetConfig().rtp.extensions[0].id);
2444 EXPECT_EQ(expected_extension,
isheriff6f8d6862016-05-26 11:24:55 -07002445 send_stream->GetConfig().rtp.extensions[0].uri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002446 }
2447
asapersson3c81a1a2017-06-14 05:52:21 -07002448 void TestDegradationPreference(bool resolution_scaling_enabled,
2449 bool fps_scaling_enabled);
2450
Erik Språngefbde372015-04-29 16:21:28 +02002451 void TestCpuAdaptation(bool enable_overuse, bool is_screenshare);
Peter Boström3548dd22015-05-22 18:48:36 +02002452 void TestReceiverLocalSsrcConfiguration(bool receiver_first);
magjed509e4fe2016-11-18 01:34:11 -08002453 void TestReceiveUnsignaledSsrcPacket(uint8_t payload_type,
2454 bool expect_created_receive_stream);
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002455
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002456 FakeVideoSendStream* SetDenoisingOption(
nisse05103312016-03-16 02:22:50 -07002457 uint32_t ssrc,
Niels Möller805a27e2019-01-21 12:21:27 +01002458 webrtc::test::FrameForwarder* frame_forwarder,
nisse0db023a2016-03-01 04:29:59 -08002459 bool enabled) {
nisse05103312016-03-16 02:22:50 -07002460 cricket::VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01002461 options.video_noise_reduction = enabled;
Niels Möller805a27e2019-01-21 12:21:27 +01002462 EXPECT_TRUE(channel_->SetVideoSend(ssrc, &options, frame_forwarder));
nisse0db023a2016-03-01 04:29:59 -08002463 // Options only take effect on the next frame.
Niels Möller805a27e2019-01-21 12:21:27 +01002464 frame_forwarder->IncomingCapturedFrame(frame_source_.GetFrame());
nisse0db023a2016-03-01 04:29:59 -08002465
Erik Språng143cec12015-04-28 10:01:41 +02002466 return fake_call_->GetVideoSendStreams().back();
2467 }
2468
Peter Boström2feafdb2015-09-09 14:32:14 +02002469 FakeVideoSendStream* SetUpSimulcast(bool enabled, bool with_rtx) {
2470 const int kRtxSsrcOffset = 0xDEADBEEF;
Erik Språng143cec12015-04-28 10:01:41 +02002471 last_ssrc_ += 3;
Peter Boström2feafdb2015-09-09 14:32:14 +02002472 std::vector<uint32_t> ssrcs;
2473 std::vector<uint32_t> rtx_ssrcs;
2474 uint32_t num_streams = enabled ? 3 : 1;
2475 for (uint32_t i = 0; i < num_streams; ++i) {
2476 uint32_t ssrc = last_ssrc_ + i;
2477 ssrcs.push_back(ssrc);
2478 if (with_rtx) {
2479 rtx_ssrcs.push_back(ssrc + kRtxSsrcOffset);
2480 }
Erik Språng143cec12015-04-28 10:01:41 +02002481 }
Peter Boström2feafdb2015-09-09 14:32:14 +02002482 if (with_rtx) {
2483 return AddSendStream(
2484 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2485 }
2486 return AddSendStream(CreateSimStreamParams("cname", ssrcs));
Erik Språng143cec12015-04-28 10:01:41 +02002487 }
2488
perkjfa10b552016-10-02 23:45:26 -07002489 int GetMaxEncoderBitrate() {
skvladdc1c62c2016-03-16 19:07:43 -07002490 std::vector<FakeVideoSendStream*> streams =
2491 fake_call_->GetVideoSendStreams();
perkjfa10b552016-10-02 23:45:26 -07002492 EXPECT_EQ(1u, streams.size());
skvladdc1c62c2016-03-16 19:07:43 -07002493 FakeVideoSendStream* stream = streams[streams.size() - 1];
Mirko Bonadeif859e552018-05-30 15:31:29 +02002494 EXPECT_EQ(1u, stream->GetEncoderConfig().number_of_streams);
perkjfa10b552016-10-02 23:45:26 -07002495 return stream->GetVideoStreams()[0].max_bitrate_bps;
skvladdc1c62c2016-03-16 19:07:43 -07002496 }
2497
perkjfa10b552016-10-02 23:45:26 -07002498 void SetAndExpectMaxBitrate(int global_max,
skvladdc1c62c2016-03-16 19:07:43 -07002499 int stream_max,
2500 int expected_encoder_bitrate) {
2501 VideoSendParameters limited_send_params = send_parameters_;
2502 limited_send_params.max_bandwidth_bps = global_max;
2503 EXPECT_TRUE(channel_->SetSendParameters(limited_send_params));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002504 webrtc::RtpParameters parameters =
2505 channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002506 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002507 parameters.encodings[0].max_bitrate_bps = stream_max;
Zach Steinba37b4b2018-01-23 15:02:36 -08002508 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07002509 // Read back the parameteres and verify they have the correct value
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07002510 parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07002511 EXPECT_EQ(1UL, parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01002512 EXPECT_EQ(stream_max, parameters.encodings[0].max_bitrate_bps);
skvladdc1c62c2016-03-16 19:07:43 -07002513 // Verify that the new value propagated down to the encoder
perkjfa10b552016-10-02 23:45:26 -07002514 EXPECT_EQ(expected_encoder_bitrate, GetMaxEncoderBitrate());
skvladdc1c62c2016-03-16 19:07:43 -07002515 }
2516
Åsa Persson55659812018-06-18 17:51:32 +02002517 // Values from kSimulcastConfigs in simulcast.cc.
2518 const std::vector<webrtc::VideoStream> GetSimulcastBitrates720p() const {
2519 std::vector<webrtc::VideoStream> layers(3);
2520 layers[0].min_bitrate_bps = 30000;
2521 layers[0].target_bitrate_bps = 150000;
2522 layers[0].max_bitrate_bps = 200000;
2523 layers[1].min_bitrate_bps = 150000;
2524 layers[1].target_bitrate_bps = 500000;
2525 layers[1].max_bitrate_bps = 700000;
2526 layers[2].min_bitrate_bps = 600000;
2527 layers[2].target_bitrate_bps = 2500000;
2528 layers[2].max_bitrate_bps = 2500000;
2529 return layers;
2530 }
2531
Niels Möller805a27e2019-01-21 12:21:27 +01002532 cricket::FakeFrameSource frame_source_;
kwiberg686a8ef2016-02-26 03:00:35 -08002533 std::unique_ptr<FakeCall> fake_call_;
2534 std::unique_ptr<VideoMediaChannel> channel_;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002535 cricket::VideoSendParameters send_parameters_;
2536 cricket::VideoRecvParameters recv_parameters_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02002537 uint32_t last_ssrc_;
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002538};
2539
eladalonf1841382017-06-12 01:16:46 -07002540TEST_F(WebRtcVideoChannelTest, SetsSyncGroupFromSyncLabel) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02002541 const uint32_t kVideoSsrc = 123;
pbos8fc7fa72015-07-15 08:02:58 -07002542 const std::string kSyncLabel = "AvSyncLabel";
2543
2544 cricket::StreamParams sp = cricket::StreamParams::CreateLegacy(kVideoSsrc);
Seth Hampson845e8782018-03-02 11:34:10 -08002545 sp.set_stream_ids({kSyncLabel});
pbos8fc7fa72015-07-15 08:02:58 -07002546 EXPECT_TRUE(channel_->AddRecvStream(sp));
2547
Mirko Bonadeif859e552018-05-30 15:31:29 +02002548 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos8fc7fa72015-07-15 08:02:58 -07002549 EXPECT_EQ(kSyncLabel,
2550 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group)
2551 << "SyncGroup should be set based on sync_label";
2552}
2553
eladalonf1841382017-06-12 01:16:46 -07002554TEST_F(WebRtcVideoChannelTest, RecvStreamWithSimAndRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002555 cricket::VideoSendParameters parameters;
2556 parameters.codecs = engine_.codecs();
2557 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002558 EXPECT_TRUE(channel_->SetSend(true));
nisse4b4dc862016-02-17 05:25:36 -08002559 parameters.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002560 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002561
2562 // Send side.
Peter Boström0c4e06b2015-10-07 12:23:21 +02002563 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
2564 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002565 FakeVideoSendStream* send_stream = AddSendStream(
2566 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
2567
2568 ASSERT_EQ(rtx_ssrcs.size(), send_stream->GetConfig().rtp.rtx.ssrcs.size());
2569 for (size_t i = 0; i < rtx_ssrcs.size(); ++i)
2570 EXPECT_EQ(rtx_ssrcs[i], send_stream->GetConfig().rtp.rtx.ssrcs[i]);
2571
2572 // Receiver side.
2573 FakeVideoReceiveStream* recv_stream = AddRecvStream(
2574 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
nisse26e3abb2017-08-25 04:44:25 -07002575 EXPECT_FALSE(
2576 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07002577 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02002578 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07002579 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002580 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002581 << "RTX should be mapped for the RED payload type";
2582
brandtr14742122017-01-27 04:53:07 -08002583 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002584}
2585
eladalonf1841382017-06-12 01:16:46 -07002586TEST_F(WebRtcVideoChannelTest, RecvStreamWithRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002587 // Setup one channel with an associated RTX stream.
2588 cricket::StreamParams params =
2589 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2590 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
2591 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002592 EXPECT_EQ(kRtxSsrcs1[0], recv_stream->GetConfig().rtp.rtx_ssrc);
nisseca5706d2017-09-11 02:32:16 -07002593
2594 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
2595 << "RTX should be mapped for all decoders/payload types.";
2596 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02002597 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07002598 << "RTX should be mapped for the RED payload type";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002599}
2600
eladalonf1841382017-06-12 01:16:46 -07002601TEST_F(WebRtcVideoChannelTest, RecvStreamNoRtx) {
pbos@webrtc.orge322a172014-06-13 11:47:28 +00002602 // Setup one channel without an associated RTX stream.
2603 cricket::StreamParams params =
2604 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
2605 FakeVideoReceiveStream* recv_stream = AddRecvStream(params);
brandtr14742122017-01-27 04:53:07 -08002606 ASSERT_EQ(0U, recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002607}
2608
Johannes Kron9190b822018-10-29 11:22:05 +01002609// Test propagation of extmap allow mixed setting.
2610TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCaller) {
2611 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/true);
2612}
2613TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCaller) {
2614 TestExtmapAllowMixedCaller(/*extmap_allow_mixed=*/false);
2615}
2616TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedAsCallee) {
2617 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/true);
2618}
2619TEST_F(WebRtcVideoChannelTest, SetExtmapAllowMixedDisabledAsCallee) {
2620 TestExtmapAllowMixedCallee(/*extmap_allow_mixed=*/false);
2621}
2622
eladalonf1841382017-06-12 01:16:46 -07002623TEST_F(WebRtcVideoChannelTest, NoHeaderExtesionsByDefault) {
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002624 FakeVideoSendStream* send_stream =
2625 AddSendStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2626 ASSERT_TRUE(send_stream->GetConfig().rtp.extensions.empty());
2627
2628 FakeVideoReceiveStream* recv_stream =
2629 AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs1[0]));
2630 ASSERT_TRUE(recv_stream->GetConfig().rtp.extensions.empty());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002631}
2632
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002633// Test support for RTP timestamp offset header extension.
eladalonf1841382017-06-12 01:16:46 -07002634TEST_F(WebRtcVideoChannelTest, SendRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002635 TestSetSendRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002636}
isheriff6f8d6862016-05-26 11:24:55 -07002637
eladalonf1841382017-06-12 01:16:46 -07002638TEST_F(WebRtcVideoChannelTest, RecvRtpTimestampOffsetHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002639 TestSetRecvRtpHeaderExtensions(RtpExtension::kTimestampOffsetUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002640}
2641
2642// Test support for absolute send time header extension.
eladalonf1841382017-06-12 01:16:46 -07002643TEST_F(WebRtcVideoChannelTest, SendAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002644 TestSetSendRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.org587ef602014-06-16 17:32:02 +00002645}
isheriff6f8d6862016-05-26 11:24:55 -07002646
eladalonf1841382017-06-12 01:16:46 -07002647TEST_F(WebRtcVideoChannelTest, RecvAbsoluteSendTimeHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002648 TestSetRecvRtpHeaderExtensions(RtpExtension::kAbsSendTimeUri);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002649}
2650
eladalonf1841382017-06-12 01:16:46 -07002651TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksTransportSeqNum) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002652 // Enable three redundant extensions.
2653 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002654 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2655 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2656 extensions.push_back(RtpExtension::kTransportSequenceNumberUri);
2657 TestExtensionFilter(extensions, RtpExtension::kTransportSequenceNumberUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002658}
2659
eladalonf1841382017-06-12 01:16:46 -07002660TEST_F(WebRtcVideoChannelTest, FiltersExtensionsPicksAbsSendTime) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002661 // Enable two redundant extensions.
2662 std::vector<std::string> extensions;
isheriff6f8d6862016-05-26 11:24:55 -07002663 extensions.push_back(RtpExtension::kAbsSendTimeUri);
2664 extensions.push_back(RtpExtension::kTimestampOffsetUri);
2665 TestExtensionFilter(extensions, RtpExtension::kAbsSendTimeUri);
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002666}
2667
stefanc1aeaf02015-10-15 07:26:07 -07002668// Test support for transport sequence number header extension.
eladalonf1841382017-06-12 01:16:46 -07002669TEST_F(WebRtcVideoChannelTest, SendTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002670 TestSetSendRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002671}
eladalonf1841382017-06-12 01:16:46 -07002672TEST_F(WebRtcVideoChannelTest, RecvTransportSequenceNumberHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002673 TestSetRecvRtpHeaderExtensions(RtpExtension::kTransportSequenceNumberUri);
stefanc1aeaf02015-10-15 07:26:07 -07002674}
2675
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002676// Test support for video rotation header extension.
eladalonf1841382017-06-12 01:16:46 -07002677TEST_F(WebRtcVideoChannelTest, SendVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002678 TestSetSendRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002679}
eladalonf1841382017-06-12 01:16:46 -07002680TEST_F(WebRtcVideoChannelTest, RecvVideoRotationHeaderExtensions) {
isheriff6f8d6862016-05-26 11:24:55 -07002681 TestSetRecvRtpHeaderExtensions(RtpExtension::kVideoRotationUri);
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002682}
2683
eladalonf1841382017-06-12 01:16:46 -07002684TEST_F(WebRtcVideoChannelTest, IdenticalSendExtensionsDoesntRecreateStream) {
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002685 const int kAbsSendTimeId = 1;
2686 const int kVideoRotationId = 2;
isheriff6f8d6862016-05-26 11:24:55 -07002687 send_parameters_.extensions.push_back(
2688 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2689 send_parameters_.extensions.push_back(
2690 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002691
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002692 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002693 FakeVideoSendStream* send_stream =
2694 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2695
2696 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Stefan Holmerbbaf3632015-10-29 18:53:23 +01002697 ASSERT_EQ(2u, send_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002698
2699 // Setting the same extensions (even if in different order) shouldn't
2700 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002701 absl::c_reverse(send_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002702 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002703
2704 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
2705
2706 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002707 send_parameters_.extensions.resize(1);
2708 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002709
2710 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
2711}
2712
eladalonf1841382017-06-12 01:16:46 -07002713TEST_F(WebRtcVideoChannelTest, IdenticalRecvExtensionsDoesntRecreateStream) {
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002714 const int kTOffsetId = 1;
2715 const int kAbsSendTimeId = 2;
Guo-wei Shieh64c1e8c2015-04-01 15:33:06 -07002716 const int kVideoRotationId = 3;
isheriff6f8d6862016-05-26 11:24:55 -07002717 recv_parameters_.extensions.push_back(
2718 RtpExtension(RtpExtension::kAbsSendTimeUri, kAbsSendTimeId));
2719 recv_parameters_.extensions.push_back(
2720 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
2721 recv_parameters_.extensions.push_back(
2722 RtpExtension(RtpExtension::kVideoRotationUri, kVideoRotationId));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002723
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002724 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
Peter Boström54be3e02015-05-25 15:04:24 +02002725 FakeVideoReceiveStream* recv_stream =
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002726 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2727
2728 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Peter Boström54be3e02015-05-25 15:04:24 +02002729 ASSERT_EQ(3u, recv_stream->GetConfig().rtp.extensions.size());
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002730
2731 // Setting the same extensions (even if in different order) shouldn't
2732 // reallocate the stream.
Steve Anton2c9ebef2019-01-28 17:27:58 -08002733 absl::c_reverse(recv_parameters_.extensions);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002734 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002735
2736 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
2737
2738 // Setting different extensions should recreate the stream.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002739 recv_parameters_.extensions.resize(1);
2740 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgc37e72e2015-01-05 18:51:13 +00002741
2742 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
2743}
2744
eladalonf1841382017-06-12 01:16:46 -07002745TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002746 SetSendRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002747 const int kUnsupportedId = 1;
2748 const int kTOffsetId = 2;
2749
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002750 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002751 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002752 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002753 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002754 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002755 FakeVideoSendStream* send_stream =
2756 AddSendStream(cricket::StreamParams::CreateLegacy(123));
2757
2758 // Only timestamp offset extension is set to send stream,
2759 // unsupported rtp extension is ignored.
2760 ASSERT_EQ(1u, send_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002761 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2762 send_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002763}
2764
eladalonf1841382017-06-12 01:16:46 -07002765TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002766 SetRecvRtpHeaderExtensionsExcludeUnsupportedExtensions) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002767 const int kUnsupportedId = 1;
2768 const int kTOffsetId = 2;
2769
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002770 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002771 RtpExtension(kUnsupportedExtensionName, kUnsupportedId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002772 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002773 RtpExtension(RtpExtension::kTimestampOffsetUri, kTOffsetId));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002774 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002775 FakeVideoReceiveStream* recv_stream =
2776 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
2777
2778 // Only timestamp offset extension is set to receive stream,
2779 // unsupported rtp extension is ignored.
2780 ASSERT_EQ(1u, recv_stream->GetConfig().rtp.extensions.size());
isheriff6f8d6862016-05-26 11:24:55 -07002781 EXPECT_STREQ(RtpExtension::kTimestampOffsetUri,
2782 recv_stream->GetConfig().rtp.extensions[0].uri.c_str());
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002783}
2784
eladalonf1841382017-06-12 01:16:46 -07002785TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002786 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002787 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002788 send_parameters_.extensions.push_back(
2789 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002790 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002791 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2792 }
2793}
2794
eladalonf1841382017-06-12 01:16:46 -07002795TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsIncorrectIds) {
Peter Boström23914fe2015-03-31 15:08:04 +02002796 const int kIncorrectIds[] = {-2, -1, 0, 15, 16};
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00002797 for (size_t i = 0; i < arraysize(kIncorrectIds); ++i) {
isheriff6f8d6862016-05-26 11:24:55 -07002798 recv_parameters_.extensions.push_back(
2799 RtpExtension(RtpExtension::kTimestampOffsetUri, kIncorrectIds[i]));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002800 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_))
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002801 << "Bad extension id '" << kIncorrectIds[i] << "' accepted.";
2802 }
2803}
2804
eladalonf1841382017-06-12 01:16:46 -07002805TEST_F(WebRtcVideoChannelTest, SetSendRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002806 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002807 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002808 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002809 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002810 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002811 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002812
2813 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002814 send_parameters_.extensions.clear();
2815 send_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002816 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002817 send_parameters_.extensions.push_back(send_parameters_.extensions.back());
2818 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002819}
2820
eladalonf1841382017-06-12 01:16:46 -07002821TEST_F(WebRtcVideoChannelTest, SetRecvRtpHeaderExtensionsRejectsDuplicateIds) {
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002822 const int id = 1;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002823 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002824 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002825 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002826 RtpExtension(RtpExtension::kAbsSendTimeUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002827 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002828
2829 // Duplicate entries are also not supported.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002830 recv_parameters_.extensions.clear();
2831 recv_parameters_.extensions.push_back(
isheriff6f8d6862016-05-26 11:24:55 -07002832 RtpExtension(RtpExtension::kTimestampOffsetUri, id));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002833 recv_parameters_.extensions.push_back(recv_parameters_.extensions.back());
2834 EXPECT_FALSE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.org3c107582014-07-20 15:27:35 +00002835}
2836
eladalonf1841382017-06-12 01:16:46 -07002837TEST_F(WebRtcVideoChannelTest, AddRecvStreamOnlyUsesOneReceiveStream) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002838 EXPECT_TRUE(channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(1)));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00002839 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002840}
2841
eladalonf1841382017-06-12 01:16:46 -07002842TEST_F(WebRtcVideoChannelTest, RtcpIsCompoundByDefault) {
Peter Boströmd7da1202015-06-05 14:09:38 +02002843 FakeVideoReceiveStream* stream = AddRecvStream();
pbosda903ea2015-10-02 02:36:56 -07002844 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream->GetConfig().rtp.rtcp_mode);
Peter Boströmd7da1202015-06-05 14:09:38 +02002845}
2846
eladalonf1841382017-06-12 01:16:46 -07002847TEST_F(WebRtcVideoChannelTest, TransportCcIsEnabledByDefault) {
stefan43edf0f2015-11-20 18:05:48 -08002848 FakeVideoReceiveStream* stream = AddRecvStream();
2849 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2850}
2851
eladalonf1841382017-06-12 01:16:46 -07002852TEST_F(WebRtcVideoChannelTest, TransportCcCanBeEnabledAndDisabled) {
stefan43edf0f2015-11-20 18:05:48 -08002853 FakeVideoReceiveStream* stream = AddRecvStream();
2854 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2855
2856 // Verify that transport cc feedback is turned off when send(!) codecs without
2857 // transport cc feedback are set.
2858 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002859 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
stefan43edf0f2015-11-20 18:05:48 -08002860 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2861 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2862 stream = fake_call_->GetVideoReceiveStreams()[0];
2863 EXPECT_FALSE(stream->GetConfig().rtp.transport_cc);
2864
2865 // Verify that transport cc feedback is turned on when setting default codecs
2866 // since the default codecs have transport cc feedback enabled.
2867 parameters.codecs = engine_.codecs();
2868 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2869 stream = fake_call_->GetVideoReceiveStreams()[0];
2870 EXPECT_TRUE(stream->GetConfig().rtp.transport_cc);
2871}
2872
Elad Alonfadb1812019-05-24 13:40:02 +02002873TEST_F(WebRtcVideoChannelTest, LossNotificationIsDisabledByDefault) {
2874 TestLossNotificationState(false);
2875}
2876
2877TEST_F(WebRtcVideoChannelTest, LossNotificationIsEnabledByFieldTrial) {
2878 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002879 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alonfadb1812019-05-24 13:40:02 +02002880 "WebRTC-RtcpLossNotification/Enabled/");
2881 SetUp();
2882 TestLossNotificationState(true);
2883}
2884
2885TEST_F(WebRtcVideoChannelTest, LossNotificationCanBeEnabledAndDisabled) {
2886 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02002887 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Elad Alonfadb1812019-05-24 13:40:02 +02002888 "WebRTC-RtcpLossNotification/Enabled/");
2889 SetUp();
2890
2891 AssignDefaultCodec();
2892 VerifyCodecHasDefaultFeedbackParams(default_codec_, true);
2893
2894 {
2895 cricket::VideoSendParameters parameters;
2896 parameters.codecs = engine_.codecs();
2897 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2898 EXPECT_TRUE(channel_->SetSend(true));
2899 }
2900
2901 // Start with LNTF enabled.
2902 FakeVideoSendStream* send_stream =
2903 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2904 ASSERT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2905 FakeVideoReceiveStream* recv_stream =
2906 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2907 ASSERT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2908
2909 // Verify that LNTF is turned off when send(!) codecs without LNTF are set.
2910 cricket::VideoSendParameters parameters;
2911 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
2912 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2913 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2914 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2915 EXPECT_FALSE(recv_stream->GetConfig().rtp.lntf.enabled);
2916 send_stream = fake_call_->GetVideoSendStreams()[0];
2917 EXPECT_FALSE(send_stream->GetConfig().rtp.lntf.enabled);
2918
2919 // Setting the default codecs again, including VP8, turns LNTF back on.
2920 parameters.codecs = engine_.codecs();
2921 EXPECT_TRUE(channel_->SetSendParameters(parameters));
2922 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2923 EXPECT_TRUE(recv_stream->GetConfig().rtp.lntf.enabled);
2924 send_stream = fake_call_->GetVideoSendStreams()[0];
2925 EXPECT_TRUE(send_stream->GetConfig().rtp.lntf.enabled);
2926}
2927
eladalonf1841382017-06-12 01:16:46 -07002928TEST_F(WebRtcVideoChannelTest, NackIsEnabledByDefault) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02002929 AssignDefaultCodec();
Elad Alonfadb1812019-05-24 13:40:02 +02002930 VerifyCodecHasDefaultFeedbackParams(default_codec_, false);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002931
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002932 cricket::VideoSendParameters parameters;
2933 parameters.codecs = engine_.codecs();
2934 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org19864742014-05-30 07:35:47 +00002935 EXPECT_TRUE(channel_->SetSend(true));
2936
2937 // Send side.
2938 FakeVideoSendStream* send_stream =
2939 AddSendStream(cricket::StreamParams::CreateLegacy(1));
2940 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2941
2942 // Receiver side.
2943 FakeVideoReceiveStream* recv_stream =
2944 AddRecvStream(cricket::StreamParams::CreateLegacy(1));
2945 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2946
2947 // Nack history size should match between sender and receiver.
2948 EXPECT_EQ(send_stream->GetConfig().rtp.nack.rtp_history_ms,
2949 recv_stream->GetConfig().rtp.nack.rtp_history_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00002950}
2951
eladalonf1841382017-06-12 01:16:46 -07002952TEST_F(WebRtcVideoChannelTest, NackCanBeEnabledAndDisabled) {
Peter Boström67c9df72015-05-11 14:34:58 +02002953 FakeVideoSendStream* send_stream = AddSendStream();
Peter Boström3548dd22015-05-22 18:48:36 +02002954 FakeVideoReceiveStream* recv_stream = AddRecvStream();
Peter Boström67c9df72015-05-11 14:34:58 +02002955
2956 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2957 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2958
2959 // Verify that NACK is turned off when send(!) codecs without NACK are set.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002960 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002961 parameters.codecs.push_back(RemoveFeedbackParams(GetEngineCodec("VP8")));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002962 EXPECT_TRUE(parameters.codecs[0].feedback_params.params().empty());
2963 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002964 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2965 EXPECT_EQ(0, recv_stream->GetConfig().rtp.nack.rtp_history_ms);
2966 send_stream = fake_call_->GetVideoSendStreams()[0];
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002967 EXPECT_EQ(0, send_stream->GetConfig().rtp.nack.rtp_history_ms);
2968
Peter Boström67c9df72015-05-11 14:34:58 +02002969 // Verify that NACK is turned on when setting default codecs since the
2970 // default codecs have NACK enabled.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02002971 parameters.codecs = engine_.codecs();
2972 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström67c9df72015-05-11 14:34:58 +02002973 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
2974 EXPECT_GT(recv_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
2975 send_stream = fake_call_->GetVideoSendStreams()[0];
2976 EXPECT_GT(send_stream->GetConfig().rtp.nack.rtp_history_ms, 0);
pbos@webrtc.orgf99c2f22014-06-13 12:27:38 +00002977}
2978
Peter Boströme7ba0862016-03-12 00:02:28 +01002979// This test verifies that new frame sizes reconfigures encoders even though not
2980// (yet) sending. The purpose of this is to permit encoding as quickly as
2981// possible once we start sending. Likely the frames being input are from the
2982// same source that will be sent later, which just means that we're ready
2983// earlier.
eladalonf1841382017-06-12 01:16:46 -07002984TEST_F(WebRtcVideoChannelTest, ReconfiguresEncodersWhenNotSending) {
Peter Boströme7ba0862016-03-12 00:02:28 +01002985 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08002986 parameters.codecs.push_back(GetEngineCodec("VP8"));
Peter Boströme7ba0862016-03-12 00:02:28 +01002987 ASSERT_TRUE(channel_->SetSendParameters(parameters));
2988 channel_->SetSend(false);
2989
2990 FakeVideoSendStream* stream = AddSendStream();
2991
perkjfa10b552016-10-02 23:45:26 -07002992 // No frames entered.
Peter Boströme7ba0862016-03-12 00:02:28 +01002993 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
Danil Chapovalov350531e2018-06-08 11:04:04 +00002994 EXPECT_EQ(0u, streams[0].width);
2995 EXPECT_EQ(0u, streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01002996
Niels Möller805a27e2019-01-21 12:21:27 +01002997 webrtc::test::FrameForwarder frame_forwarder;
2998 cricket::FakeFrameSource frame_source(1280, 720,
2999 rtc::kNumMicrosecsPerSec / 30);
3000
3001 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
3002 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
Peter Boströme7ba0862016-03-12 00:02:28 +01003003
3004 // Frame entered, should be reconfigured to new dimensions.
3005 streams = stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003006 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams[0].width);
3007 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams[0].height);
Peter Boströme7ba0862016-03-12 00:02:28 +01003008
Niels Möllerff40b142018-04-09 08:49:14 +02003009 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströme7ba0862016-03-12 00:02:28 +01003010}
3011
eladalonf1841382017-06-12 01:16:46 -07003012TEST_F(WebRtcVideoChannelTest, UsesCorrectSettingsForScreencast) {
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003013 static const int kScreenshareMinBitrateKbps = 800;
magjed509e4fe2016-11-18 01:34:11 -08003014 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003015 cricket::VideoSendParameters parameters;
3016 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003017 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003018 AddSendStream();
3019
Niels Möller805a27e2019-01-21 12:21:27 +01003020 webrtc::test::FrameForwarder frame_forwarder;
3021 cricket::FakeFrameSource frame_source(1280, 720,
3022 rtc::kNumMicrosecsPerSec / 30);
nisse05103312016-03-16 02:22:50 -07003023 VideoOptions min_bitrate_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003024 min_bitrate_options.screencast_min_bitrate_kbps = kScreenshareMinBitrateKbps;
Niels Möller805a27e2019-01-21 12:21:27 +01003025 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &min_bitrate_options,
3026 &frame_forwarder));
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003027
3028 EXPECT_TRUE(channel_->SetSend(true));
3029
Niels Möller805a27e2019-01-21 12:21:27 +01003030 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003031 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3032 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3033
3034 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
3035
3036 // Verify non-screencast settings.
perkj26091b12016-09-01 01:17:40 -07003037 webrtc::VideoEncoderConfig encoder_config =
3038 send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003039 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kRealtimeVideo,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003040 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003041 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003042 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3043 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003044 EXPECT_EQ(0, encoder_config.min_transmit_bitrate_bps)
3045 << "Non-screenshare shouldn't use min-transmit bitrate.";
3046
Niels Möllerff40b142018-04-09 08:49:14 +02003047 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
perkjd533aec2017-01-13 05:57:25 -08003048 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
nisse05103312016-03-16 02:22:50 -07003049 VideoOptions screencast_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003050 screencast_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003051 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &screencast_options,
3052 &frame_forwarder));
3053 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
sprangf24a0642017-02-28 13:23:26 -08003054 // Send stream recreated after option change.
3055 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3056 send_stream = fake_call_->GetVideoSendStreams().front();
3057 EXPECT_EQ(1, send_stream->GetNumberOfSwappedFrames());
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003058
3059 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003060 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003061 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003062 encoder_config.content_type);
3063 EXPECT_EQ(kScreenshareMinBitrateKbps * 1000,
3064 encoder_config.min_transmit_bitrate_bps);
3065
perkjfa10b552016-10-02 23:45:26 -07003066 streams = send_stream->GetVideoStreams();
Niels Möller805a27e2019-01-21 12:21:27 +01003067 EXPECT_EQ(rtc::checked_cast<size_t>(1280), streams.front().width);
3068 EXPECT_EQ(rtc::checked_cast<size_t>(720), streams.front().height);
Sergey Silkina796a7e2018-03-01 15:11:29 +01003069 EXPECT_FALSE(streams[0].num_temporal_layers.has_value());
Niels Möllerff40b142018-04-09 08:49:14 +02003070 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003071}
3072
eladalonf1841382017-06-12 01:16:46 -07003073TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003074 ConferenceModeScreencastConfiguresTemporalLayer) {
Rasmus Brandt195d1d72018-05-09 11:28:01 +02003075 static const int kConferenceScreencastTemporalBitrateBps = 200 * 1000;
nisse4b4dc862016-02-17 05:25:36 -08003076 send_parameters_.conference_mode = true;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003077 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003078
3079 AddSendStream();
nisse05103312016-03-16 02:22:50 -07003080 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003081 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003082 webrtc::test::FrameForwarder frame_forwarder;
3083 cricket::FakeFrameSource frame_source(1280, 720,
3084 rtc::kNumMicrosecsPerSec / 30);
3085 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003086 EXPECT_TRUE(channel_->SetSend(true));
3087
Niels Möller805a27e2019-01-21 12:21:27 +01003088 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003089 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3090 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3091
perkj26091b12016-09-01 01:17:40 -07003092 webrtc::VideoEncoderConfig encoder_config =
3093 send_stream->GetEncoderConfig().Copy();
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003094
3095 // Verify screencast settings.
perkj26091b12016-09-01 01:17:40 -07003096 encoder_config = send_stream->GetEncoderConfig().Copy();
Erik Språng143cec12015-04-28 10:01:41 +02003097 EXPECT_EQ(webrtc::VideoEncoderConfig::ContentType::kScreen,
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003098 encoder_config.content_type);
perkjfa10b552016-10-02 23:45:26 -07003099
3100 std::vector<webrtc::VideoStream> streams = send_stream->GetVideoStreams();
3101 ASSERT_EQ(1u, streams.size());
Sergey Silkina796a7e2018-03-01 15:11:29 +01003102 ASSERT_EQ(2u, streams[0].num_temporal_layers);
pbos@webrtc.orgb7ed7792014-10-31 13:08:10 +00003103 EXPECT_EQ(kConferenceScreencastTemporalBitrateBps,
Sergey Silkina796a7e2018-03-01 15:11:29 +01003104 streams[0].target_bitrate_bps);
pbos@webrtc.orgefc82c22014-10-27 13:58:00 +00003105
Niels Möllerff40b142018-04-09 08:49:14 +02003106 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003107}
3108
eladalonf1841382017-06-12 01:16:46 -07003109TEST_F(WebRtcVideoChannelTest, SuspendBelowMinBitrateDisabledByDefault) {
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003110 FakeVideoSendStream* stream = AddSendStream();
3111 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3112}
3113
eladalonf1841382017-06-12 01:16:46 -07003114TEST_F(WebRtcVideoChannelTest, SetMediaConfigSuspendBelowMinBitrate) {
kthelgason2bc68642017-02-07 07:02:22 -08003115 MediaConfig media_config = GetMediaConfig();
nisse0db023a2016-03-01 04:29:59 -08003116 media_config.video.suspend_below_min_bitrate = true;
3117
Sebastian Jansson84848f22018-11-16 10:40:36 +01003118 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003119 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3120 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003121 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003122
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003123 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003124
3125 FakeVideoSendStream* stream = AddSendStream();
3126 EXPECT_TRUE(stream->GetConfig().suspend_below_min_bitrate);
3127
nisse0db023a2016-03-01 04:29:59 -08003128 media_config.video.suspend_below_min_bitrate = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003129 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003130 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3131 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003132 channel_->OnReadyToSend(true);
nisse0db023a2016-03-01 04:29:59 -08003133
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003134 channel_->SetSendParameters(send_parameters_);
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003135
nisse0db023a2016-03-01 04:29:59 -08003136 stream = AddSendStream();
pbos@webrtc.org5ff71ab2014-07-23 07:28:56 +00003137 EXPECT_FALSE(stream->GetConfig().suspend_below_min_bitrate);
3138}
3139
eladalonf1841382017-06-12 01:16:46 -07003140TEST_F(WebRtcVideoChannelTest, Vp8DenoisingEnabledByDefault) {
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003141 FakeVideoSendStream* stream = AddSendStream();
3142 webrtc::VideoCodecVP8 vp8_settings;
3143 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3144 EXPECT_TRUE(vp8_settings.denoisingOn);
3145}
3146
eladalonf1841382017-06-12 01:16:46 -07003147TEST_F(WebRtcVideoChannelTest, VerifyVp8SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003148 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003149 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003150 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003151
Peter Boström2feafdb2015-09-09 14:32:14 +02003152 // Single-stream settings should apply with RTX as well (verifies that we
3153 // check number of regular SSRCs and not StreamParams::ssrcs which contains
3154 // both RTX and regular SSRCs).
3155 FakeVideoSendStream* stream = SetUpSimulcast(false, true);
Erik Språng143cec12015-04-28 10:01:41 +02003156
Niels Möller805a27e2019-01-21 12:21:27 +01003157 webrtc::test::FrameForwarder frame_forwarder;
3158 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003159 channel_->SetSend(true);
3160
Niels Möller805a27e2019-01-21 12:21:27 +01003161 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003162
pbos4cba4eb2015-10-26 11:18:18 -07003163 webrtc::VideoCodecVP8 vp8_settings;
3164 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3165 EXPECT_TRUE(vp8_settings.denoisingOn)
3166 << "VP8 denoising should be on by default.";
3167
Niels Möller805a27e2019-01-21 12:21:27 +01003168 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003169
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003170 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3171 EXPECT_FALSE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003172 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3173 EXPECT_TRUE(vp8_settings.frameDroppingOn);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003174
Niels Möller805a27e2019-01-21 12:21:27 +01003175 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003176
pbos@webrtc.org6f48f1b2014-07-22 16:29:54 +00003177 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3178 EXPECT_TRUE(vp8_settings.denoisingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003179 EXPECT_TRUE(vp8_settings.automaticResizeOn);
3180 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3181
Niels Möllerff40b142018-04-09 08:49:14 +02003182 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boström2feafdb2015-09-09 14:32:14 +02003183 stream = SetUpSimulcast(true, false);
Niels Möller805a27e2019-01-21 12:21:27 +01003184 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003185 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01003186 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003187
Mirko Bonadeif859e552018-05-30 15:31:29 +02003188 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003189 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3190 // Autmatic resize off when using simulcast.
3191 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3192 EXPECT_TRUE(vp8_settings.frameDroppingOn);
3193
Florent Castelli66b38602019-07-10 16:57:57 +02003194 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003195 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003196 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003197 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Niels Möller60653ba2016-03-02 11:41:36 +01003198
Niels Möller805a27e2019-01-21 12:21:27 +01003199 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003200
Florent Castelli66b38602019-07-10 16:57:57 +02003201 EXPECT_EQ(3u, stream->GetVideoStreams().size());
Erik Språng143cec12015-04-28 10:01:41 +02003202 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3203 EXPECT_FALSE(vp8_settings.denoisingOn);
3204 // Resizing and frame dropping always off for screen sharing.
3205 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3206 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3207
Niels Möller805a27e2019-01-21 12:21:27 +01003208 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003209
3210 ASSERT_TRUE(stream->GetVp8Settings(&vp8_settings)) << "No VP8 config set.";
3211 EXPECT_FALSE(vp8_settings.denoisingOn);
3212 EXPECT_FALSE(vp8_settings.automaticResizeOn);
3213 EXPECT_FALSE(vp8_settings.frameDroppingOn);
3214
Niels Möllerff40b142018-04-09 08:49:14 +02003215 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Erik Språng143cec12015-04-28 10:01:41 +02003216}
3217
deadbeef119760a2016-04-04 11:43:27 -07003218// Test that setting the same options doesn't result in the encoder being
3219// reconfigured.
eladalonf1841382017-06-12 01:16:46 -07003220TEST_F(WebRtcVideoChannelTest, SetIdenticalOptionsDoesntReconfigureEncoder) {
deadbeef119760a2016-04-04 11:43:27 -07003221 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003222 webrtc::test::FrameForwarder frame_forwarder;
deadbeef119760a2016-04-04 11:43:27 -07003223
perkjfa10b552016-10-02 23:45:26 -07003224 AddSendStream();
perkjfa10b552016-10-02 23:45:26 -07003225 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003226 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkjfa10b552016-10-02 23:45:26 -07003227 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3228 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3229
Niels Möller805a27e2019-01-21 12:21:27 +01003230 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3231 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
3232 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
perkjfa10b552016-10-02 23:45:26 -07003233 // Expect 1 reconfigurations at this point from the initial configuration.
3234 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
deadbeef119760a2016-04-04 11:43:27 -07003235
3236 // Set the options one more time and expect no additional reconfigurations.
Niels Möller805a27e2019-01-21 12:21:27 +01003237 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkjfa10b552016-10-02 23:45:26 -07003238 EXPECT_EQ(1, send_stream->num_encoder_reconfigurations());
3239
3240 // Change |options| and expect 2 reconfigurations.
Oskar Sundbom78807582017-11-16 11:09:55 +01003241 options.video_noise_reduction = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003242 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
deadbeef119760a2016-04-04 11:43:27 -07003243 EXPECT_EQ(2, send_stream->num_encoder_reconfigurations());
3244
Niels Möllerff40b142018-04-09 08:49:14 +02003245 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
deadbeef119760a2016-04-04 11:43:27 -07003246}
3247
eladalonf1841382017-06-12 01:16:46 -07003248class Vp9SettingsTest : public WebRtcVideoChannelTest {
Erik Språng143cec12015-04-28 10:01:41 +02003249 public:
asaperssonc5dabdd2016-03-21 04:15:50 -07003250 Vp9SettingsTest() : Vp9SettingsTest("") {}
3251 explicit Vp9SettingsTest(const char* field_trials)
eladalonf1841382017-06-12 01:16:46 -07003252 : WebRtcVideoChannelTest(field_trials) {
Magnus Jedvert02e7a192017-09-23 17:21:32 +02003253 encoder_factory_->AddSupportedVideoCodecType("VP9");
Erik Språng143cec12015-04-28 10:01:41 +02003254 }
3255 virtual ~Vp9SettingsTest() {}
3256
3257 protected:
Erik Språng143cec12015-04-28 10:01:41 +02003258 void TearDown() override {
3259 // Remove references to encoder_factory_ since this will be destroyed
3260 // before channel_ and engine_.
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003261 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
Erik Språng143cec12015-04-28 10:01:41 +02003262 }
Erik Språng143cec12015-04-28 10:01:41 +02003263};
3264
3265TEST_F(Vp9SettingsTest, VerifyVp9SpecificSettings) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003266 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003267 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003268 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Erik Språng143cec12015-04-28 10:01:41 +02003269
Peter Boström2feafdb2015-09-09 14:32:14 +02003270 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
Erik Språng143cec12015-04-28 10:01:41 +02003271
Niels Möller805a27e2019-01-21 12:21:27 +01003272 webrtc::test::FrameForwarder frame_forwarder;
3273 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Erik Språng143cec12015-04-28 10:01:41 +02003274 channel_->SetSend(true);
3275
Niels Möller805a27e2019-01-21 12:21:27 +01003276 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Erik Språng143cec12015-04-28 10:01:41 +02003277
pbos4cba4eb2015-10-26 11:18:18 -07003278 webrtc::VideoCodecVP9 vp9_settings;
3279 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
jianja5e8aa62017-03-27 10:09:00 -07003280 EXPECT_TRUE(vp9_settings.denoisingOn)
3281 << "VP9 denoising should be on by default.";
pbos4cba4eb2015-10-26 11:18:18 -07003282
Niels Möller805a27e2019-01-21 12:21:27 +01003283 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003284
Erik Språng143cec12015-04-28 10:01:41 +02003285 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3286 EXPECT_FALSE(vp9_settings.denoisingOn);
3287 // Frame dropping always on for real time video.
3288 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3289
Niels Möller805a27e2019-01-21 12:21:27 +01003290 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, true);
Erik Språng143cec12015-04-28 10:01:41 +02003291
3292 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3293 EXPECT_TRUE(vp9_settings.denoisingOn);
3294 EXPECT_TRUE(vp9_settings.frameDroppingOn);
3295
3296 // In screen-share mode, denoising is forced off.
nisse05103312016-03-16 02:22:50 -07003297 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003298 options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003299 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
perkj2d5f0912016-02-29 00:04:41 -08003300
Niels Möller805a27e2019-01-21 12:21:27 +01003301 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003302
3303 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3304 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003305 // Frame dropping always on for screen sharing.
3306 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003307
Niels Möller805a27e2019-01-21 12:21:27 +01003308 stream = SetDenoisingOption(last_ssrc_, &frame_forwarder, false);
Erik Språng143cec12015-04-28 10:01:41 +02003309
3310 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3311 EXPECT_FALSE(vp9_settings.denoisingOn);
Sergey Silkinbe71a1e2018-05-17 16:46:43 +02003312 EXPECT_TRUE(vp9_settings.frameDroppingOn);
Erik Språng143cec12015-04-28 10:01:41 +02003313
Niels Möllerff40b142018-04-09 08:49:14 +02003314 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003315}
3316
Sergey Silkinf18072e2018-03-14 10:35:35 +01003317TEST_F(Vp9SettingsTest, MultipleSsrcsEnablesSvc) {
3318 cricket::VideoSendParameters parameters;
3319 parameters.codecs.push_back(GetEngineCodec("VP9"));
3320 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3321
3322 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3323
3324 FakeVideoSendStream* stream =
3325 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3326
3327 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
Sergey Silkinf18072e2018-03-14 10:35:35 +01003328
Niels Möller805a27e2019-01-21 12:21:27 +01003329 webrtc::test::FrameForwarder frame_forwarder;
3330 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003331 channel_->SetSend(true);
3332
Niels Möller805a27e2019-01-21 12:21:27 +01003333 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Sergey Silkinf18072e2018-03-14 10:35:35 +01003334
3335 webrtc::VideoCodecVP9 vp9_settings;
3336 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3337
3338 const size_t kNumSpatialLayers = ssrcs.size();
3339 const size_t kNumTemporalLayers = 3;
3340 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3341 EXPECT_EQ(vp9_settings.numberOfTemporalLayers, kNumTemporalLayers);
3342
Niels Möllerff40b142018-04-09 08:49:14 +02003343 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
Sergey Silkinf18072e2018-03-14 10:35:35 +01003344}
3345
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02003346TEST_F(Vp9SettingsTest, SvcModeCreatesSingleRtpStream) {
3347 cricket::VideoSendParameters parameters;
3348 parameters.codecs.push_back(GetEngineCodec("VP9"));
3349 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3350
3351 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3352
3353 FakeVideoSendStream* stream =
3354 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3355
3356 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3357
3358 // Despite 3 ssrcs provided, single layer is used.
3359 EXPECT_EQ(1u, config.rtp.ssrcs.size());
3360
3361 webrtc::test::FrameForwarder frame_forwarder;
3362 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, &frame_forwarder));
3363 channel_->SetSend(true);
3364
3365 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
3366
3367 webrtc::VideoCodecVP9 vp9_settings;
3368 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3369
3370 const size_t kNumSpatialLayers = ssrcs.size();
3371 EXPECT_EQ(vp9_settings.numberOfSpatialLayers, kNumSpatialLayers);
3372
3373 EXPECT_TRUE(channel_->SetVideoSend(ssrcs[0], nullptr, nullptr));
3374}
3375
Sergey Silkin8b9b5f92018-12-10 09:28:53 +01003376TEST_F(Vp9SettingsTest, AllEncodingParametersCopied) {
3377 cricket::VideoSendParameters send_parameters;
3378 send_parameters.codecs.push_back(GetEngineCodec("VP9"));
3379 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
3380
3381 const size_t kNumSpatialLayers = 3;
3382 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
3383
3384 FakeVideoSendStream* stream =
3385 AddSendStream(CreateSimStreamParams("cname", ssrcs));
3386
3387 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(ssrcs[0]);
3388 ASSERT_EQ(kNumSpatialLayers, parameters.encodings.size());
3389 ASSERT_TRUE(parameters.encodings[0].active);
3390 ASSERT_TRUE(parameters.encodings[1].active);
3391 ASSERT_TRUE(parameters.encodings[2].active);
3392 // Invert value to verify copying.
3393 parameters.encodings[1].active = false;
3394 EXPECT_TRUE(channel_->SetRtpSendParameters(ssrcs[0], parameters).ok());
3395
3396 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
3397
3398 // number_of_streams should be 1 since all spatial layers are sent on the
3399 // same SSRC. But encoding parameters of all layers is supposed to be copied
3400 // and stored in simulcast_layers[].
3401 EXPECT_EQ(1u, encoder_config.number_of_streams);
3402 EXPECT_EQ(encoder_config.simulcast_layers.size(), kNumSpatialLayers);
3403 EXPECT_TRUE(encoder_config.simulcast_layers[0].active);
3404 EXPECT_FALSE(encoder_config.simulcast_layers[1].active);
3405 EXPECT_TRUE(encoder_config.simulcast_layers[2].active);
3406}
3407
Sergey Silkincf267052019-04-09 11:40:09 +02003408class Vp9SettingsTestWithFieldTrial
3409 : public Vp9SettingsTest,
3410 public ::testing::WithParamInterface<
3411 ::testing::tuple<const char*, int, int, webrtc::InterLayerPredMode>> {
asaperssonc5dabdd2016-03-21 04:15:50 -07003412 protected:
Sergey Silkincf267052019-04-09 11:40:09 +02003413 Vp9SettingsTestWithFieldTrial()
3414 : Vp9SettingsTest(::testing::get<0>(GetParam())),
3415 num_spatial_layers_(::testing::get<1>(GetParam())),
3416 num_temporal_layers_(::testing::get<2>(GetParam())),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003417 inter_layer_pred_mode_(::testing::get<3>(GetParam())) {}
Sergey Silkincf267052019-04-09 11:40:09 +02003418
3419 void VerifySettings(int num_spatial_layers,
3420 int num_temporal_layers,
3421 webrtc::InterLayerPredMode interLayerPred) {
asaperssonc5dabdd2016-03-21 04:15:50 -07003422 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003423 parameters.codecs.push_back(GetEngineCodec("VP9"));
asaperssonc5dabdd2016-03-21 04:15:50 -07003424 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3425
3426 FakeVideoSendStream* stream = SetUpSimulcast(false, false);
3427
Niels Möller805a27e2019-01-21 12:21:27 +01003428 webrtc::test::FrameForwarder frame_forwarder;
3429 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
asaperssonc5dabdd2016-03-21 04:15:50 -07003430 channel_->SetSend(true);
3431
Niels Möller805a27e2019-01-21 12:21:27 +01003432 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
asaperssonc5dabdd2016-03-21 04:15:50 -07003433
3434 webrtc::VideoCodecVP9 vp9_settings;
3435 ASSERT_TRUE(stream->GetVp9Settings(&vp9_settings)) << "No VP9 config set.";
3436 EXPECT_EQ(num_spatial_layers, vp9_settings.numberOfSpatialLayers);
3437 EXPECT_EQ(num_temporal_layers, vp9_settings.numberOfTemporalLayers);
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003438 EXPECT_EQ(inter_layer_pred_mode_, vp9_settings.interLayerPred);
asaperssonc5dabdd2016-03-21 04:15:50 -07003439
Niels Möllerff40b142018-04-09 08:49:14 +02003440 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asaperssonc5dabdd2016-03-21 04:15:50 -07003441 }
Sergey Silkincf267052019-04-09 11:40:09 +02003442
3443 const uint8_t num_spatial_layers_;
3444 const uint8_t num_temporal_layers_;
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003445 const webrtc::InterLayerPredMode inter_layer_pred_mode_;
asaperssonc5dabdd2016-03-21 04:15:50 -07003446};
3447
Sergey Silkincf267052019-04-09 11:40:09 +02003448TEST_P(Vp9SettingsTestWithFieldTrial, VerifyCodecSettings) {
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003449 VerifySettings(num_spatial_layers_, num_temporal_layers_,
3450 inter_layer_pred_mode_);
asaperssonc5dabdd2016-03-21 04:15:50 -07003451}
3452
Sergey Silkincf267052019-04-09 11:40:09 +02003453INSTANTIATE_TEST_SUITE_P(
Mirko Bonadei09f11952019-09-29 10:19:42 +02003454 All,
Sergey Silkincf267052019-04-09 11:40:09 +02003455 Vp9SettingsTestWithFieldTrial,
3456 ::testing::Values(
3457 std::make_tuple("", 1, 1, webrtc::InterLayerPredMode::kOnKeyPic),
3458 std::make_tuple("WebRTC-SupportVP9SVC/Default/",
3459 1,
3460 1,
3461 webrtc::InterLayerPredMode::kOnKeyPic),
3462 std::make_tuple("WebRTC-SupportVP9SVC/EnabledByFlag_2SL3TL/",
3463 2,
3464 3,
3465 webrtc::InterLayerPredMode::kOnKeyPic),
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003466 std::make_tuple("WebRTC-Vp9InterLayerPred/Default/",
Sergey Silkincf267052019-04-09 11:40:09 +02003467 1,
3468 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003469 webrtc::InterLayerPredMode::kOnKeyPic),
3470 std::make_tuple("WebRTC-Vp9InterLayerPred/Disabled/",
Sergey Silkincf267052019-04-09 11:40:09 +02003471 1,
3472 1,
Sergey Silkin19da5ce2019-05-20 17:57:17 +02003473 webrtc::InterLayerPredMode::kOnKeyPic),
3474 std::make_tuple(
3475 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:off/",
3476 1,
3477 1,
3478 webrtc::InterLayerPredMode::kOff),
3479 std::make_tuple(
3480 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:on/",
3481 1,
3482 1,
3483 webrtc::InterLayerPredMode::kOn),
3484 std::make_tuple(
3485 "WebRTC-Vp9InterLayerPred/Enabled,inter_layer_pred_mode:onkeypic/",
3486 1,
3487 1,
3488 webrtc::InterLayerPredMode::kOnKeyPic)));
asaperssonc5dabdd2016-03-21 04:15:50 -07003489
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003490TEST_F(WebRtcVideoChannelTest, VerifyMinBitrate) {
3491 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3492 ASSERT_EQ(1u, streams.size());
Elad Alon80f53b72019-10-11 16:19:43 +02003493 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps, streams[0].min_bitrate_bps);
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003494}
3495
3496TEST_F(WebRtcVideoChannelTest, VerifyMinBitrateWithForcedFallbackFieldTrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003497 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003498 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
Åsa Persson45bbc8a2017-11-13 10:16:47 +01003499 "WebRTC-VP8-Forced-Fallback-Encoder-v2/Enabled-1,2,34567/");
3500 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
3501 ASSERT_EQ(1u, streams.size());
3502 EXPECT_EQ(34567, streams[0].min_bitrate_bps);
3503}
3504
asapersson3c81a1a2017-06-14 05:52:21 -07003505TEST_F(WebRtcVideoChannelTest,
3506 BalancedDegradationPreferenceNotSupportedWithoutFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003507 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003508 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003509 "WebRTC-Video-BalancedDegradation/Disabled/");
3510 const bool kResolutionScalingEnabled = true;
3511 const bool kFpsScalingEnabled = false;
3512 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3513}
3514
3515TEST_F(WebRtcVideoChannelTest,
3516 BalancedDegradationPreferenceSupportedBehindFieldtrial) {
Elad Alon040dc432019-05-22 15:40:02 +02003517 RTC_DCHECK(!override_field_trials_);
Mirko Bonadei317a1f02019-09-17 17:06:18 +02003518 override_field_trials_ = std::make_unique<webrtc::test::ScopedFieldTrials>(
asapersson3c81a1a2017-06-14 05:52:21 -07003519 "WebRTC-Video-BalancedDegradation/Enabled/");
3520 const bool kResolutionScalingEnabled = true;
3521 const bool kFpsScalingEnabled = true;
3522 TestDegradationPreference(kResolutionScalingEnabled, kFpsScalingEnabled);
3523}
3524
eladalonf1841382017-06-12 01:16:46 -07003525TEST_F(WebRtcVideoChannelTest, AdaptsOnOveruse) {
Erik Språngefbde372015-04-29 16:21:28 +02003526 TestCpuAdaptation(true, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003527}
3528
eladalonf1841382017-06-12 01:16:46 -07003529TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenDisabled) {
Erik Språngefbde372015-04-29 16:21:28 +02003530 TestCpuAdaptation(false, false);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003531}
3532
Niels Möller3de32e62019-01-18 08:42:18 +01003533TEST_F(WebRtcVideoChannelTest, DoesNotAdaptWhenScreeensharing) {
3534 TestCpuAdaptation(false, true);
3535}
3536
eladalonf1841382017-06-12 01:16:46 -07003537TEST_F(WebRtcVideoChannelTest, DoesNotAdaptOnOveruseWhenScreensharing) {
Erik Språngefbde372015-04-29 16:21:28 +02003538 TestCpuAdaptation(true, true);
3539}
3540
eladalonf1841382017-06-12 01:16:46 -07003541TEST_F(WebRtcVideoChannelTest, PreviousAdaptationDoesNotApplyToScreenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003542 cricket::VideoCodec codec = GetEngineCodec("VP8");
Per766ad3b2016-04-05 15:23:49 +02003543 cricket::VideoSendParameters parameters;
3544 parameters.codecs.push_back(codec);
3545
kthelgason2bc68642017-02-07 07:02:22 -08003546 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003547 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003548 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003549 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3550 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003551 channel_->OnReadyToSend(true);
Per766ad3b2016-04-05 15:23:49 +02003552 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3553
3554 AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01003555 webrtc::test::FrameForwarder frame_forwarder;
Per766ad3b2016-04-05 15:23:49 +02003556
Per766ad3b2016-04-05 15:23:49 +02003557 ASSERT_TRUE(channel_->SetSend(true));
3558 cricket::VideoOptions camera_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003559 camera_options.is_screencast = false;
Niels Möller805a27e2019-01-21 12:21:27 +01003560 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
Per766ad3b2016-04-05 15:23:49 +02003561
3562 ASSERT_EQ(1u, fake_call_->GetVideoSendStreams().size());
3563 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
Per766ad3b2016-04-05 15:23:49 +02003564
Niels Möllerdcc70292019-01-15 16:32:38 +01003565 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3566 // Dont' expect anything on framerate_scaling_enabled, since the default is
3567 // transitioning from MAINTAIN_FRAMERATE to BALANCED.
Per766ad3b2016-04-05 15:23:49 +02003568
Niels Möllerdcc70292019-01-15 16:32:38 +01003569 // Switch to screen share. Expect no resolution scaling.
Per766ad3b2016-04-05 15:23:49 +02003570 cricket::VideoOptions screenshare_options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003571 screenshare_options.is_screencast = true;
Niels Möller805a27e2019-01-21 12:21:27 +01003572 channel_->SetVideoSend(last_ssrc_, &screenshare_options, &frame_forwarder);
sprangf24a0642017-02-28 13:23:26 -08003573 ASSERT_EQ(2, fake_call_->GetNumCreatedSendStreams());
3574 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003575 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003576
Niels Möllerdcc70292019-01-15 16:32:38 +01003577 // Switch back to the normal capturer. Expect resolution scaling to be
3578 // reenabled.
Niels Möller805a27e2019-01-21 12:21:27 +01003579 channel_->SetVideoSend(last_ssrc_, &camera_options, &frame_forwarder);
3580 send_stream = fake_call_->GetVideoSendStreams().front();
sprangf24a0642017-02-28 13:23:26 -08003581 ASSERT_EQ(3, fake_call_->GetNumCreatedSendStreams());
3582 send_stream = fake_call_->GetVideoSendStreams().front();
Niels Möllerdcc70292019-01-15 16:32:38 +01003583 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
Per766ad3b2016-04-05 15:23:49 +02003584
Niels Möllerff40b142018-04-09 08:49:14 +02003585 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Per766ad3b2016-04-05 15:23:49 +02003586}
3587
asapersson3c81a1a2017-06-14 05:52:21 -07003588// TODO(asapersson): Remove this test when the balanced field trial is removed.
3589void WebRtcVideoChannelTest::TestDegradationPreference(
3590 bool resolution_scaling_enabled,
3591 bool fps_scaling_enabled) {
3592 cricket::VideoCodec codec = GetEngineCodec("VP8");
3593 cricket::VideoSendParameters parameters;
3594 parameters.codecs.push_back(codec);
3595
3596 MediaConfig media_config = GetMediaConfig();
Niels Möller1d7ecd22018-01-18 15:25:12 +01003597 media_config.video.enable_cpu_adaptation = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01003598 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003599 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3600 video_bitrate_allocator_factory_.get()));
asapersson3c81a1a2017-06-14 05:52:21 -07003601 channel_->OnReadyToSend(true);
3602
3603 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3604
3605 AddSendStream();
3606
Niels Möller805a27e2019-01-21 12:21:27 +01003607 webrtc::test::FrameForwarder frame_forwarder;
asapersson3c81a1a2017-06-14 05:52:21 -07003608 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01003609 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
asapersson3c81a1a2017-06-14 05:52:21 -07003610
3611 EXPECT_TRUE(channel_->SetSend(true));
3612
3613 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
3614 EXPECT_EQ(resolution_scaling_enabled,
3615 send_stream->resolution_scaling_enabled());
3616 EXPECT_EQ(fps_scaling_enabled, send_stream->framerate_scaling_enabled());
3617
Niels Möllerff40b142018-04-09 08:49:14 +02003618 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
asapersson3c81a1a2017-06-14 05:52:21 -07003619}
3620
eladalonf1841382017-06-12 01:16:46 -07003621void WebRtcVideoChannelTest::TestCpuAdaptation(bool enable_overuse,
3622 bool is_screenshare) {
magjed509e4fe2016-11-18 01:34:11 -08003623 cricket::VideoCodec codec = GetEngineCodec("VP8");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003624 cricket::VideoSendParameters parameters;
3625 parameters.codecs.push_back(codec);
nisse51542be2016-02-12 02:27:06 -08003626
kthelgason2bc68642017-02-07 07:02:22 -08003627 MediaConfig media_config = GetMediaConfig();
3628 if (enable_overuse) {
Niels Möller1d7ecd22018-01-18 15:25:12 +01003629 media_config.video.enable_cpu_adaptation = true;
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003630 }
Sebastian Jansson84848f22018-11-16 10:40:36 +01003631 channel_.reset(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02003632 fake_call_.get(), media_config, VideoOptions(), webrtc::CryptoOptions(),
3633 video_bitrate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08003634 channel_->OnReadyToSend(true);
nisse51542be2016-02-12 02:27:06 -08003635
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003636 EXPECT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003637
3638 AddSendStream();
3639
Niels Möller805a27e2019-01-21 12:21:27 +01003640 webrtc::test::FrameForwarder frame_forwarder;
nisse05103312016-03-16 02:22:50 -07003641 VideoOptions options;
Oskar Sundbom78807582017-11-16 11:09:55 +01003642 options.is_screencast = is_screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01003643 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00003644
3645 EXPECT_TRUE(channel_->SetSend(true));
3646
solenberge5269742015-09-08 05:13:22 -07003647 FakeVideoSendStream* send_stream = fake_call_->GetVideoSendStreams().front();
perkj2d5f0912016-02-29 00:04:41 -08003648
sprangc5d62e22017-04-02 23:53:04 -07003649 if (!enable_overuse) {
perkj803d97f2016-11-01 11:45:46 -07003650 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
sprangc5d62e22017-04-02 23:53:04 -07003651 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
Niels Möller805a27e2019-01-21 12:21:27 +01003652 } else if (is_screenshare) {
sprangc5d62e22017-04-02 23:53:04 -07003653 EXPECT_FALSE(send_stream->resolution_scaling_enabled());
3654 EXPECT_TRUE(send_stream->framerate_scaling_enabled());
3655 } else {
3656 EXPECT_TRUE(send_stream->resolution_scaling_enabled());
3657 EXPECT_FALSE(send_stream->framerate_scaling_enabled());
3658 }
Niels Möllerff40b142018-04-09 08:49:14 +02003659 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003660}
3661
eladalonf1841382017-06-12 01:16:46 -07003662TEST_F(WebRtcVideoChannelTest, EstimatesNtpStartTimeCorrectly) {
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003663 // Start at last timestamp to verify that wraparounds are estimated correctly.
3664 static const uint32_t kInitialTimestamp = 0xFFFFFFFFu;
3665 static const int64_t kInitialNtpTimeMs = 1247891230;
3666 static const int kFrameOffsetMs = 20;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003667 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003668
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003669 FakeVideoReceiveStream* stream = AddRecvStream();
3670 cricket::FakeVideoRenderer renderer;
nisse08582ff2016-02-04 01:24:52 -08003671 EXPECT_TRUE(channel_->SetSink(last_ssrc_, &renderer));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003672
Artem Titov1ebfb6a2019-01-03 23:49:37 +01003673 webrtc::VideoFrame video_frame =
3674 webrtc::VideoFrame::Builder()
3675 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
3676 .set_timestamp_rtp(kInitialTimestamp)
3677 .set_timestamp_us(0)
3678 .set_rotation(webrtc::kVideoRotation_0)
3679 .build();
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003680 // Initial NTP time is not available on the first frame, but should still be
3681 // able to be estimated.
nisseeb83a1a2016-03-21 01:27:56 -07003682 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003683
3684 EXPECT_EQ(1, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003685
3686 // This timestamp is kInitialTimestamp (-1) + kFrameOffsetMs * 90, which
3687 // triggers a constant-overflow warning, hence we're calculating it explicitly
3688 // here.
Sebastian Jansson40889f32019-04-17 12:11:20 +02003689 fake_clock_.AdvanceTime(webrtc::TimeDelta::ms(kFrameOffsetMs));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003690 video_frame.set_timestamp(kFrameOffsetMs * 90 - 1);
3691 video_frame.set_ntp_time_ms(kInitialNtpTimeMs + kFrameOffsetMs);
nisseeb83a1a2016-03-21 01:27:56 -07003692 stream->InjectFrame(video_frame);
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003693
3694 EXPECT_EQ(2, renderer.num_rendered_frames());
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003695
3696 // Verify that NTP time has been correctly deduced.
3697 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00003698 ASSERT_TRUE(channel_->GetStats(&info));
magjed@webrtc.orgfc5ad952015-01-27 09:57:01 +00003699 ASSERT_EQ(1u, info.receivers.size());
3700 EXPECT_EQ(kInitialNtpTimeMs, info.receivers[0].capture_start_ntp_time_ms);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003701}
3702
eladalonf1841382017-06-12 01:16:46 -07003703TEST_F(WebRtcVideoChannelTest, SetDefaultSendCodecs) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02003704 AssignDefaultAptRtxTypes();
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003705 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003706
3707 VideoCodec codec;
3708 EXPECT_TRUE(channel_->GetSendCodec(&codec));
pbos@webrtc.org9fbb7172014-06-13 09:34:13 +00003709 EXPECT_TRUE(codec.Matches(engine_.codecs()[0]));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003710
3711 // Using a RTX setup to verify that the default RTX payload type is good.
Peter Boström0c4e06b2015-10-07 12:23:21 +02003712 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
3713 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003714 FakeVideoSendStream* stream = AddSendStream(
3715 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs));
perkj26091b12016-09-01 01:17:40 -07003716 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003717
3718 // Make sure NACK and FEC are enabled on the correct payload types.
3719 EXPECT_EQ(1000, config.rtp.nack.rtp_history_ms);
magjed509e4fe2016-11-18 01:34:11 -08003720 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
3721 EXPECT_EQ(GetEngineCodec("red").id, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00003722
3723 EXPECT_EQ(1u, config.rtp.rtx.ssrcs.size());
3724 EXPECT_EQ(kRtxSsrcs1[0], config.rtp.rtx.ssrcs[0]);
Shao Changbine62202f2015-04-21 20:24:50 +08003725 VerifySendStreamHasRtxTypes(config, default_apt_rtx_types_);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003726 // TODO(juberti): Check RTCP, PLI, TMMBR.
3727}
3728
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02003729TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutPacketization) {
3730 cricket::VideoSendParameters parameters;
3731 parameters.codecs.push_back(GetEngineCodec("VP8"));
3732 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3733
3734 FakeVideoSendStream* stream = AddSendStream();
3735 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3736 EXPECT_FALSE(config.rtp.raw_payload);
3737}
3738
3739TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithPacketization) {
3740 cricket::VideoSendParameters parameters;
3741 parameters.codecs.push_back(GetEngineCodec("VP8"));
3742 parameters.codecs.back().packetization = kPacketizationParamRaw;
3743 EXPECT_TRUE(channel_->SetSendParameters(parameters));
3744
3745 FakeVideoSendStream* stream = AddSendStream();
3746 const webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3747 EXPECT_TRUE(config.rtp.raw_payload);
3748}
3749
brandtr31bd2242017-05-19 05:47:46 -07003750// The following four tests ensures that FlexFEC is not activated by default
3751// when the field trials are not enabled.
3752// TODO(brandtr): Remove or update these tests when FlexFEC _is_ enabled by
3753// default.
Yves Gerey665174f2018-06-19 15:03:05 +02003754TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithoutSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003755 FakeVideoSendStream* stream = AddSendStream();
3756 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3757
brandtr3d200bd2017-01-16 06:59:19 -08003758 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003759 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3760 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003761}
3762
eladalonf1841382017-06-12 01:16:46 -07003763TEST_F(WebRtcVideoChannelTest, FlexfecSendCodecWithSsrcNotExposedByDefault) {
brandtr468da7c2016-11-22 02:16:47 -08003764 FakeVideoSendStream* stream = AddSendStream(
3765 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3766 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3767
brandtr3d200bd2017-01-16 06:59:19 -08003768 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr31bd2242017-05-19 05:47:46 -07003769 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3770 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
3771}
3772
Yves Gerey665174f2018-06-19 15:03:05 +02003773TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithoutSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003774 AddRecvStream();
3775
3776 const std::vector<FakeFlexfecReceiveStream*>& streams =
3777 fake_call_->GetFlexfecReceiveStreams();
3778 EXPECT_TRUE(streams.empty());
3779}
3780
eladalonf1841382017-06-12 01:16:46 -07003781TEST_F(WebRtcVideoChannelTest, FlexfecRecvCodecWithSsrcNotExposedByDefault) {
brandtr31bd2242017-05-19 05:47:46 -07003782 AddRecvStream(
3783 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3784
3785 const std::vector<FakeFlexfecReceiveStream*>& streams =
3786 fake_call_->GetFlexfecReceiveStreams();
3787 EXPECT_TRUE(streams.empty());
brandtr468da7c2016-11-22 02:16:47 -08003788}
3789
3790// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3791// tests that use this test fixture into the corresponding "non-field trial"
3792// tests.
eladalonf1841382017-06-12 01:16:46 -07003793class WebRtcVideoChannelFlexfecRecvTest : public WebRtcVideoChannelTest {
brandtr468da7c2016-11-22 02:16:47 -08003794 public:
eladalonf1841382017-06-12 01:16:46 -07003795 WebRtcVideoChannelFlexfecRecvTest()
3796 : WebRtcVideoChannelTest("WebRTC-FlexFEC-03-Advertised/Enabled/") {}
brandtr468da7c2016-11-22 02:16:47 -08003797};
3798
eladalonf1841382017-06-12 01:16:46 -07003799TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr36e7d702017-01-13 07:15:54 -08003800 DefaultFlexfecCodecHasTransportCcAndRembFeedbackParam) {
3801 EXPECT_TRUE(cricket::HasTransportCc(GetEngineCodec("flexfec-03")));
3802 EXPECT_TRUE(cricket::HasRemb(GetEngineCodec("flexfec-03")));
3803}
3804
eladalonf1841382017-06-12 01:16:46 -07003805TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithoutSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003806 AddRecvStream();
3807
3808 const std::vector<FakeFlexfecReceiveStream*>& streams =
3809 fake_call_->GetFlexfecReceiveStreams();
3810 EXPECT_TRUE(streams.empty());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003811
3812 const std::vector<FakeVideoReceiveStream*>& video_streams =
3813 fake_call_->GetVideoReceiveStreams();
3814 ASSERT_EQ(1U, video_streams.size());
3815 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3816 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3817 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr31bd2242017-05-19 05:47:46 -07003818}
3819
eladalonf1841382017-06-12 01:16:46 -07003820TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetDefaultRecvCodecsWithSsrc) {
brandtr31bd2242017-05-19 05:47:46 -07003821 AddRecvStream(
3822 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3823
3824 const std::vector<FakeFlexfecReceiveStream*>& streams =
3825 fake_call_->GetFlexfecReceiveStreams();
3826 ASSERT_EQ(1U, streams.size());
3827 const FakeFlexfecReceiveStream* stream = streams.front();
3828 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3829 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3830 EXPECT_EQ(kFlexfecSsrc, config.remote_ssrc);
3831 ASSERT_EQ(1U, config.protected_media_ssrcs.size());
3832 EXPECT_EQ(kSsrcs1[0], config.protected_media_ssrcs[0]);
brandtr7cd28b92017-09-22 00:26:25 -07003833
3834 const std::vector<FakeVideoReceiveStream*>& video_streams =
3835 fake_call_->GetVideoReceiveStreams();
3836 ASSERT_EQ(1U, video_streams.size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003837 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3838 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
brandtr7cd28b92017-09-22 00:26:25 -07003839 const webrtc::VideoReceiveStream::Config& video_config =
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003840 video_stream.GetConfig();
brandtr7cd28b92017-09-22 00:26:25 -07003841 EXPECT_TRUE(video_config.rtp.protected_by_flexfec);
brandtr31bd2242017-05-19 05:47:46 -07003842}
3843
eladalonf1841382017-06-12 01:16:46 -07003844TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003845 EnablingFlexfecDoesNotRecreateVideoReceiveStream) {
3846 cricket::VideoRecvParameters recv_parameters;
3847 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3848 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3849
3850 AddRecvStream(
3851 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3852 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003853 const std::vector<FakeVideoReceiveStream*>& video_streams =
3854 fake_call_->GetVideoReceiveStreams();
3855 ASSERT_EQ(1U, video_streams.size());
3856 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3857 EXPECT_EQ(0, video_stream.GetNumAddedSecondarySinks());
3858 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003859
3860 // Enable FlexFEC.
3861 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3862 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3863 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3864 << "Enabling FlexFEC should create FlexfecReceiveStream.";
3865 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3866 << "Enabling FlexFEC should not create VideoReceiveStream.";
3867 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size())
3868 << "Enabling FlexFEC should create a single FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003869 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3870 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003871}
3872
eladalonf1841382017-06-12 01:16:46 -07003873TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr11fb4722017-05-30 01:31:37 -07003874 DisablingFlexfecDoesNotRecreateVideoReceiveStream) {
3875 cricket::VideoRecvParameters recv_parameters;
3876 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3877 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3878 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3879
3880 AddRecvStream(
3881 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3882 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams());
brandtr11fb4722017-05-30 01:31:37 -07003883 EXPECT_EQ(1U, fake_call_->GetFlexfecReceiveStreams().size());
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003884 const std::vector<FakeVideoReceiveStream*>& video_streams =
3885 fake_call_->GetVideoReceiveStreams();
3886 ASSERT_EQ(1U, video_streams.size());
3887 const FakeVideoReceiveStream& video_stream = *video_streams.front();
3888 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3889 EXPECT_EQ(0, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003890
3891 // Disable FlexFEC.
3892 recv_parameters.codecs.clear();
3893 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3894 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3895 EXPECT_EQ(2, fake_call_->GetNumCreatedReceiveStreams())
3896 << "Disabling FlexFEC should not recreate VideoReceiveStream.";
3897 EXPECT_EQ(1U, fake_call_->GetVideoReceiveStreams().size())
3898 << "Disabling FlexFEC should not destroy VideoReceiveStream.";
3899 EXPECT_TRUE(fake_call_->GetFlexfecReceiveStreams().empty())
3900 << "Disabling FlexFEC should destroy FlexfecReceiveStream.";
Rasmus Brandt60bb6fe2018-02-05 09:51:47 +01003901 EXPECT_EQ(1, video_stream.GetNumAddedSecondarySinks());
3902 EXPECT_EQ(1, video_stream.GetNumRemovedSecondarySinks());
brandtr11fb4722017-05-30 01:31:37 -07003903}
3904
Steve Anton2d2bbb12019-08-07 09:57:59 -07003905TEST_F(WebRtcVideoChannelFlexfecRecvTest, DuplicateFlexfecCodecIsDropped) {
3906 constexpr int kUnusedPayloadType1 = 127;
3907
3908 cricket::VideoRecvParameters recv_parameters;
3909 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3910 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3911 cricket::VideoCodec duplicate = GetEngineCodec("flexfec-03");
3912 duplicate.id = kUnusedPayloadType1;
3913 recv_parameters.codecs.push_back(duplicate);
3914 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
3915
3916 AddRecvStream(
3917 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3918
3919 const std::vector<FakeFlexfecReceiveStream*>& streams =
3920 fake_call_->GetFlexfecReceiveStreams();
3921 ASSERT_EQ(1U, streams.size());
3922 const FakeFlexfecReceiveStream* stream = streams.front();
3923 const webrtc::FlexfecReceiveStream::Config& config = stream->GetConfig();
3924 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.payload_type);
3925}
3926
brandtr31bd2242017-05-19 05:47:46 -07003927// TODO(brandtr): When FlexFEC is no longer behind a field trial, merge all
3928// tests that use this test fixture into the corresponding "non-field trial"
3929// tests.
eladalonf1841382017-06-12 01:16:46 -07003930class WebRtcVideoChannelFlexfecSendRecvTest : public WebRtcVideoChannelTest {
brandtr31bd2242017-05-19 05:47:46 -07003931 public:
eladalonf1841382017-06-12 01:16:46 -07003932 WebRtcVideoChannelFlexfecSendRecvTest()
3933 : WebRtcVideoChannelTest(
brandtr31bd2242017-05-19 05:47:46 -07003934 "WebRTC-FlexFEC-03-Advertised/Enabled/WebRTC-FlexFEC-03/Enabled/") {
3935 }
3936};
3937
Yves Gerey665174f2018-06-19 15:03:05 +02003938TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithoutSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003939 FakeVideoSendStream* stream = AddSendStream();
3940 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3941
brandtr3d200bd2017-01-16 06:59:19 -08003942 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3943 EXPECT_EQ(0U, config.rtp.flexfec.ssrc);
3944 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
brandtr468da7c2016-11-22 02:16:47 -08003945}
3946
eladalonf1841382017-06-12 01:16:46 -07003947TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetDefaultSendCodecsWithSsrc) {
brandtr468da7c2016-11-22 02:16:47 -08003948 FakeVideoSendStream* stream = AddSendStream(
3949 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
3950 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3951
brandtr3d200bd2017-01-16 06:59:19 -08003952 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
3953 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
3954 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
3955 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08003956}
3957
eladalonf1841382017-06-12 01:16:46 -07003958TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003959 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08003960 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02003961 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003962
3963 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07003964 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003965
brandtrb5f2c3f2016-10-04 23:28:39 -07003966 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type);
3967 EXPECT_EQ(-1, config.rtp.ulpfec.red_payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00003968}
3969
eladalonf1841382017-06-12 01:16:46 -07003970TEST_F(WebRtcVideoChannelFlexfecSendRecvTest, SetSendCodecsWithoutFec) {
brandtr468da7c2016-11-22 02:16:47 -08003971 cricket::VideoSendParameters parameters;
3972 parameters.codecs.push_back(GetEngineCodec("VP8"));
3973 ASSERT_TRUE(channel_->SetSendParameters(parameters));
3974
3975 FakeVideoSendStream* stream = AddSendStream();
3976 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
3977
brandtr3d200bd2017-01-16 06:59:19 -08003978 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
brandtr468da7c2016-11-22 02:16:47 -08003979}
3980
eladalonf1841382017-06-12 01:16:46 -07003981TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvCodecsWithFec) {
brandtr9c3d4c42017-01-23 06:59:13 -08003982 AddRecvStream(
3983 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08003984
3985 cricket::VideoRecvParameters recv_parameters;
3986 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
3987 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
3988 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
brandtr9d58d942017-02-03 04:43:41 -08003989
3990 const std::vector<FakeFlexfecReceiveStream*>& flexfec_streams =
3991 fake_call_->GetFlexfecReceiveStreams();
3992 ASSERT_EQ(1U, flexfec_streams.size());
3993 const FakeFlexfecReceiveStream* flexfec_stream = flexfec_streams.front();
3994 const webrtc::FlexfecReceiveStream::Config& flexfec_stream_config =
3995 flexfec_stream->GetConfig();
brandtr9c3d4c42017-01-23 06:59:13 -08003996 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9d58d942017-02-03 04:43:41 -08003997 flexfec_stream_config.payload_type);
3998 EXPECT_EQ(kFlexfecSsrc, flexfec_stream_config.remote_ssrc);
3999 ASSERT_EQ(1U, flexfec_stream_config.protected_media_ssrcs.size());
4000 EXPECT_EQ(kSsrcs1[0], flexfec_stream_config.protected_media_ssrcs[0]);
4001 const std::vector<FakeVideoReceiveStream*>& video_streams =
4002 fake_call_->GetVideoReceiveStreams();
4003 const FakeVideoReceiveStream* video_stream = video_streams.front();
4004 const webrtc::VideoReceiveStream::Config& video_stream_config =
4005 video_stream->GetConfig();
4006 EXPECT_EQ(video_stream_config.rtp.local_ssrc,
4007 flexfec_stream_config.local_ssrc);
4008 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
4009 EXPECT_EQ(video_stream_config.rtcp_send_transport,
4010 flexfec_stream_config.rtcp_send_transport);
4011 // TODO(brandtr): Update this EXPECT when we set |transport_cc| in a
4012 // spec-compliant way.
4013 EXPECT_EQ(video_stream_config.rtp.transport_cc,
4014 flexfec_stream_config.transport_cc);
4015 EXPECT_EQ(video_stream_config.rtp.rtcp_mode, flexfec_stream_config.rtcp_mode);
4016 EXPECT_EQ(video_stream_config.rtp.extensions,
4017 flexfec_stream_config.rtp_header_extensions);
brandtr9c3d4c42017-01-23 06:59:13 -08004018}
4019
brandtr31bd2242017-05-19 05:47:46 -07004020// We should not send FlexFEC, even if we advertise it, unless the right
4021// field trial is set.
4022// TODO(brandtr): Remove when FlexFEC is enabled by default.
eladalonf1841382017-06-12 01:16:46 -07004023TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004024 SetSendCodecsWithoutSsrcWithFecDoesNotEnableFec) {
4025 cricket::VideoSendParameters parameters;
4026 parameters.codecs.push_back(GetEngineCodec("VP8"));
4027 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4028 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4029
4030 FakeVideoSendStream* stream = AddSendStream();
4031 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4032
4033 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004034 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07004035 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
4036}
4037
eladalonf1841382017-06-12 01:16:46 -07004038TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004039 SetSendCodecsWithSsrcWithFecDoesNotEnableFec) {
4040 cricket::VideoSendParameters parameters;
4041 parameters.codecs.push_back(GetEngineCodec("VP8"));
4042 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4043 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4044
4045 FakeVideoSendStream* stream = AddSendStream(
4046 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4047 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4048
4049 EXPECT_EQ(-1, config.rtp.flexfec.payload_type);
Mirko Bonadeif859e552018-05-30 15:31:29 +02004050 EXPECT_EQ(0u, config.rtp.flexfec.ssrc);
brandtr31bd2242017-05-19 05:47:46 -07004051 EXPECT_TRUE(config.rtp.flexfec.protected_media_ssrcs.empty());
4052}
4053
eladalonf1841382017-06-12 01:16:46 -07004054TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004055 SetSendCodecRejectsRtxWithoutAssociatedPayloadType) {
magjed509e4fe2016-11-18 01:34:11 -08004056 const int kUnusedPayloadType = 127;
4057 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType));
4058
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004059 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004060 cricket::VideoCodec rtx_codec(kUnusedPayloadType, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004061 parameters.codecs.push_back(rtx_codec);
4062 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004063 << "RTX codec without associated payload type should be rejected.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004064}
4065
eladalonf1841382017-06-12 01:16:46 -07004066TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004067 SetSendCodecRejectsRtxWithoutMatchingVideoCodec) {
magjed509e4fe2016-11-18 01:34:11 -08004068 const int kUnusedPayloadType1 = 126;
4069 const int kUnusedPayloadType2 = 127;
4070 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4071 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4072 {
4073 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4074 kUnusedPayloadType1, GetEngineCodec("VP8").id);
4075 cricket::VideoSendParameters parameters;
4076 parameters.codecs.push_back(GetEngineCodec("VP8"));
4077 parameters.codecs.push_back(rtx_codec);
4078 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4079 }
4080 {
4081 cricket::VideoCodec rtx_codec = cricket::VideoCodec::CreateRtxCodec(
4082 kUnusedPayloadType1, kUnusedPayloadType2);
4083 cricket::VideoSendParameters parameters;
4084 parameters.codecs.push_back(GetEngineCodec("VP8"));
4085 parameters.codecs.push_back(rtx_codec);
4086 EXPECT_FALSE(channel_->SetSendParameters(parameters))
4087 << "RTX without matching video codec should be rejected.";
4088 }
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004089}
4090
eladalonf1841382017-06-12 01:16:46 -07004091TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004092 const int kUnusedPayloadType1 = 126;
4093 const int kUnusedPayloadType2 = 127;
4094 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4095 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4096
4097 // SSRCs for RTX.
4098 cricket::StreamParams params =
4099 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4100 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4101 AddSendStream(params);
4102
4103 // Original payload type for RTX.
4104 cricket::VideoSendParameters parameters;
4105 parameters.codecs.push_back(GetEngineCodec("VP8"));
4106 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4107 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4108 parameters.codecs.push_back(rtx_codec);
4109 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4110 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4111 const webrtc::VideoSendStream::Config& config_before =
4112 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4113 EXPECT_EQ(kUnusedPayloadType1, config_before.rtp.rtx.payload_type);
4114 ASSERT_EQ(1U, config_before.rtp.rtx.ssrcs.size());
4115 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx.ssrcs[0]);
4116
4117 // Change payload type for RTX.
4118 parameters.codecs[1].id = kUnusedPayloadType2;
4119 EXPECT_TRUE(channel_->SetSendParameters(parameters));
4120 ASSERT_EQ(1U, fake_call_->GetVideoSendStreams().size());
4121 const webrtc::VideoSendStream::Config& config_after =
4122 fake_call_->GetVideoSendStreams()[0]->GetConfig();
4123 EXPECT_EQ(kUnusedPayloadType2, config_after.rtp.rtx.payload_type);
4124 ASSERT_EQ(1U, config_after.rtp.rtx.ssrcs.size());
4125 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx.ssrcs[0]);
4126}
4127
eladalonf1841382017-06-12 01:16:46 -07004128TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004129 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004130 parameters.codecs.push_back(GetEngineCodec("VP8"));
4131 parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004132 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004133
4134 FakeVideoSendStream* stream = AddSendStream();
perkj26091b12016-09-01 01:17:40 -07004135 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004136
magjed509e4fe2016-11-18 01:34:11 -08004137 EXPECT_EQ(GetEngineCodec("ulpfec").id, config.rtp.ulpfec.ulpfec_payload_type);
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004138
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004139 parameters.codecs.pop_back();
4140 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004141 stream = fake_call_->GetVideoSendStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004142 ASSERT_TRUE(stream != nullptr);
perkj26091b12016-09-01 01:17:40 -07004143 config = stream->GetConfig().Copy();
brandtrb5f2c3f2016-10-04 23:28:39 -07004144 EXPECT_EQ(-1, config.rtp.ulpfec.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004145 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4146}
4147
eladalonf1841382017-06-12 01:16:46 -07004148TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004149 SetSendCodecsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004150 cricket::VideoSendParameters parameters;
4151 parameters.codecs.push_back(GetEngineCodec("VP8"));
4152 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4153 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4154
4155 FakeVideoSendStream* stream = AddSendStream(
4156 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
4157 webrtc::VideoSendStream::Config config = stream->GetConfig().Copy();
4158
brandtr3d200bd2017-01-16 06:59:19 -08004159 EXPECT_EQ(GetEngineCodec("flexfec-03").id, config.rtp.flexfec.payload_type);
4160 EXPECT_EQ(kFlexfecSsrc, config.rtp.flexfec.ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004161 ASSERT_EQ(1U, config.rtp.flexfec.protected_media_ssrcs.size());
4162 EXPECT_EQ(kSsrcs1[0], config.rtp.flexfec.protected_media_ssrcs[0]);
4163
4164 parameters.codecs.pop_back();
4165 ASSERT_TRUE(channel_->SetSendParameters(parameters));
4166 stream = fake_call_->GetVideoSendStreams()[0];
4167 ASSERT_TRUE(stream != nullptr);
4168 config = stream->GetConfig().Copy();
brandtr3d200bd2017-01-16 06:59:19 -08004169 EXPECT_EQ(-1, config.rtp.flexfec.payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004170 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004171}
4172
eladalonf1841382017-06-12 01:16:46 -07004173TEST_F(WebRtcVideoChannelTest, SetSendCodecsChangesExistingStreams) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004174 cricket::VideoSendParameters parameters;
perkj26752742016-10-24 01:21:16 -07004175 cricket::VideoCodec codec(100, "VP8");
4176 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax);
4177 parameters.codecs.push_back(codec);
perkjfa10b552016-10-02 23:45:26 -07004178
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004179 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004180 channel_->SetSend(true);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004181
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004182 FakeVideoSendStream* stream = AddSendStream();
Niels Möller805a27e2019-01-21 12:21:27 +01004183 webrtc::test::FrameForwarder frame_forwarder;
4184 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00004185
4186 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004187 EXPECT_EQ(kDefaultQpMax, streams[0].max_qp);
pbos@webrtc.org38ce7d02014-07-16 08:01:38 +00004188
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004189 parameters.codecs.clear();
perkj26752742016-10-24 01:21:16 -07004190 codec.SetParam(kCodecParamMaxQuantization, kDefaultQpMax + 1);
4191 parameters.codecs.push_back(codec);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004192 ASSERT_TRUE(channel_->SetSendParameters(parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004193 streams = fake_call_->GetVideoSendStreams()[0]->GetVideoStreams();
perkjfa10b552016-10-02 23:45:26 -07004194 EXPECT_EQ(kDefaultQpMax + 1, streams[0].max_qp);
Niels Möllerff40b142018-04-09 08:49:14 +02004195 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004196}
4197
eladalonf1841382017-06-12 01:16:46 -07004198TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004199 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4200 200000);
4201}
4202
eladalonf1841382017-06-12 01:16:46 -07004203TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithHighMaxBitrate) {
pbos@webrtc.orga5f6fb52015-03-23 22:29:39 +00004204 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "10000", 10000000);
4205 std::vector<webrtc::VideoStream> streams = AddSendStream()->GetVideoStreams();
4206 ASSERT_EQ(1u, streams.size());
4207 EXPECT_EQ(10000000, streams[0].max_bitrate_bps);
4208}
4209
eladalonf1841382017-06-12 01:16:46 -07004210TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org00873182014-11-25 14:03:34 +00004211 SetSendCodecsWithoutBitratesUsesCorrectDefaults) {
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004212 SetSendCodecsShouldWorkForBitrates("", 0, "", -1, "", -1);
pbos@webrtc.org00873182014-11-25 14:03:34 +00004213}
4214
eladalonf1841382017-06-12 01:16:46 -07004215TEST_F(WebRtcVideoChannelTest, SetSendCodecsCapsMinAndStartBitrate) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004216 SetSendCodecsShouldWorkForBitrates("-1", 0, "-100", -1, "", -1);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004217}
4218
eladalonf1841382017-06-12 01:16:46 -07004219TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectsMaxLessThanMinBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004220 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "300";
4221 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "200";
4222 EXPECT_FALSE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004223}
4224
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004225// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4226// are present in the same send parameters, the settings are combined correctly.
eladalonf1841382017-06-12 01:16:46 -07004227TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithBitratesAndMaxSendBandwidth) {
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004228 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4229 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4230 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4231 send_parameters_.max_bandwidth_bps = 400000;
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004232 // We expect max_bandwidth_bps to take priority, if set.
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004233 ExpectSetBitrateParameters(100000, 200000, 400000);
4234 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
4235 // Since the codec isn't changing, start_bitrate_bps should be -1.
4236 ExpectSetBitrateParameters(100000, -1, 350000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004237
4238 // Decrease max_bandwidth_bps.
4239 send_parameters_.max_bandwidth_bps = 350000;
4240 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004241
4242 // Now try again with the values flipped around.
4243 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4244 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004245 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004246 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004247
4248 // If we change the codec max, max_bandwidth_bps should still apply.
4249 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004250 ExpectSetBitrateParameters(100000, 200000, 300000);
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004251 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Taylor Brandstetter58f2bd92016-04-26 17:15:23 -07004252}
4253
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004254// Test that when both the codec-specific bitrate params and max_bandwidth_bps
4255// are present in the same send parameters, the settings are combined correctly.
4256TEST_F(WebRtcVideoChannelTest,
4257 SetSendCodecsWithBitratesAndMaxSendBandwidthForMediaTransport) {
4258 // Same as SetSendCodecsWithBitratesAndMaxSendBandwidth but with Media
4259 // Transport.
4260 webrtc::MediaTransportSettings settings;
4261 settings.is_caller = true;
4262 webrtc::FakeMediaTransport fake_media_transport(settings);
4263 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
4264 new cricket::FakeNetworkInterface);
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004265 channel_->SetInterface(network_interface.get(),
4266 webrtc::MediaTransportConfig(&fake_media_transport));
Piotr (Peter) Slatala946b9682019-03-18 10:25:02 -07004267
4268 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4269 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4270 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4271 send_parameters_.max_bandwidth_bps = 400000;
4272 {
4273 // We expect max_bandwidth_bps to take priority, if set.
4274 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4275 ASSERT_EQ(1u,
4276 fake_media_transport.target_rate_constraints_in_order().size());
4277 const webrtc::MediaTransportTargetRateConstraints& constraint =
4278 fake_media_transport.target_rate_constraints_in_order()[0];
4279 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4280 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4281 ASSERT_EQ(webrtc::DataRate::bps(400000), constraint.max_bitrate);
4282 }
4283
4284 {
4285 // Decrease max_bandwidth_bps.
4286 send_parameters_.max_bandwidth_bps = 350000;
4287 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4288 ASSERT_EQ(2u,
4289 fake_media_transport.target_rate_constraints_in_order().size());
4290 const webrtc::MediaTransportTargetRateConstraints& constraint =
4291 fake_media_transport.target_rate_constraints_in_order()[1];
4292
4293 // Since the codec isn't changing, start_bitrate_bps should be 0.
4294 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4295 ASSERT_EQ(absl::nullopt, constraint.starting_bitrate);
4296 ASSERT_EQ(webrtc::DataRate::bps(350000), constraint.max_bitrate);
4297 }
4298
4299 {
4300 // Now try again with the values flipped around.
4301 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "400";
4302 send_parameters_.max_bandwidth_bps = 300000;
4303 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4304 ASSERT_EQ(3u,
4305 fake_media_transport.target_rate_constraints_in_order().size());
4306 const webrtc::MediaTransportTargetRateConstraints& constraint =
4307 fake_media_transport.target_rate_constraints_in_order()[2];
4308
4309 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4310 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4311 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4312 }
4313
4314 {
4315 // Now try again with the values flipped around.
4316 // If we change the codec max, max_bandwidth_bps should still apply.
4317 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "350";
4318 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4319 ASSERT_EQ(4u,
4320 fake_media_transport.target_rate_constraints_in_order().size());
4321 const webrtc::MediaTransportTargetRateConstraints& constraint =
4322 fake_media_transport.target_rate_constraints_in_order()[3];
4323
4324 ASSERT_EQ(webrtc::DataRate::bps(100000), constraint.min_bitrate);
4325 ASSERT_EQ(webrtc::DataRate::bps(200000), constraint.starting_bitrate);
4326 ASSERT_EQ(webrtc::DataRate::bps(300000), constraint.max_bitrate);
4327 }
4328}
4329
Yves Gerey665174f2018-06-19 15:03:05 +02004330TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldPreserveOtherBitrates) {
pbos@webrtc.org00873182014-11-25 14:03:34 +00004331 SetSendCodecsShouldWorkForBitrates("100", 100000, "150", 150000, "200",
4332 200000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004333 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004334 // Setting max bitrate should keep previous min bitrate.
4335 // Setting max bitrate should not reset start bitrate.
4336 ExpectSetBitrateParameters(100000, -1, 300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004337 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.org00873182014-11-25 14:03:34 +00004338}
4339
eladalonf1841382017-06-12 01:16:46 -07004340TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthShouldBeRemovable) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004341 send_parameters_.max_bandwidth_bps = 300000;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004342 ExpectSetMaxBitrate(300000);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004343 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos5c7760a2017-03-10 11:23:12 -08004344 // -1 means to disable max bitrate (set infinite).
4345 send_parameters_.max_bandwidth_bps = -1;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004346 ExpectSetMaxBitrate(-1);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004347 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004348}
4349
eladalonf1841382017-06-12 01:16:46 -07004350TEST_F(WebRtcVideoChannelTest, SetMaxSendBandwidthAndAddSendStream) {
perkjfa10b552016-10-02 23:45:26 -07004351 send_parameters_.max_bandwidth_bps = 99999;
4352 FakeVideoSendStream* stream = AddSendStream();
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004353 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004354 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
perkjfa10b552016-10-02 23:45:26 -07004355 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4356 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4357 stream->GetVideoStreams()[0].max_bitrate_bps);
4358
4359 send_parameters_.max_bandwidth_bps = 77777;
Sebastian Jansson8f83b422018-02-21 13:07:13 +01004360 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
perkjfa10b552016-10-02 23:45:26 -07004361 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4362 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
perkjfa10b552016-10-02 23:45:26 -07004363 stream->GetVideoStreams()[0].max_bitrate_bps);
4364}
4365
Seth Hampsonfeec91e2018-07-13 10:41:10 -07004366// Tests that when the codec specific max bitrate and VideoSendParameters
4367// max_bandwidth_bps are used, that it sets the VideoStream's max bitrate
4368// appropriately.
4369TEST_F(WebRtcVideoChannelTest,
4370 MaxBitratePrioritizesVideoSendParametersOverCodecMaxBitrate) {
4371 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4372 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4373 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4374 send_parameters_.max_bandwidth_bps = -1;
4375 AddSendStream();
4376 ExpectSetMaxBitrate(300000);
4377 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4378
4379 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4380 ASSERT_EQ(1u, video_send_streams.size());
4381 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4382 ASSERT_EQ(1u, video_send_streams[0]->GetVideoStreams().size());
4383 // First the max bitrate is set based upon the codec param.
4384 EXPECT_EQ(300000,
4385 video_send_streams[0]->GetVideoStreams()[0].max_bitrate_bps);
4386
4387 // The VideoSendParameters max bitrate overrides the codec's.
4388 send_parameters_.max_bandwidth_bps = 500000;
4389 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4390 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4391 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4392 EXPECT_EQ(500000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4393}
4394
4395// Tests that when the codec specific max bitrate and RtpParameters
4396// max_bitrate_bps are used, that it sets the VideoStream's max bitrate
4397// appropriately.
4398TEST_F(WebRtcVideoChannelTest,
4399 MaxBitratePrioritizesRtpParametersOverCodecMaxBitrate) {
4400 send_parameters_.codecs[0].params[kCodecParamMinBitrate] = "100";
4401 send_parameters_.codecs[0].params[kCodecParamStartBitrate] = "200";
4402 send_parameters_.codecs[0].params[kCodecParamMaxBitrate] = "300";
4403 send_parameters_.max_bandwidth_bps = -1;
4404 AddSendStream();
4405 ExpectSetMaxBitrate(300000);
4406 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4407
4408 std::vector<FakeVideoSendStream*> video_send_streams = GetFakeSendStreams();
4409 ASSERT_EQ(1u, video_send_streams.size());
4410 FakeVideoSendStream* video_send_stream = video_send_streams[0];
4411 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4412 // First the max bitrate is set based upon the codec param.
4413 EXPECT_EQ(300000, video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4414
4415 // The RtpParameter max bitrate overrides the codec's.
4416 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4417 ASSERT_EQ(1u, parameters.encodings.size());
4418 parameters.encodings[0].max_bitrate_bps = 500000;
4419 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4420 ASSERT_EQ(1u, video_send_stream->GetVideoStreams().size());
4421 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4422 video_send_stream->GetVideoStreams()[0].max_bitrate_bps);
4423}
4424
Åsa Persson55659812018-06-18 17:51:32 +02004425TEST_F(WebRtcVideoChannelTest,
4426 MaxBitrateIsMinimumOfMaxSendBandwidthAndMaxEncodingBitrate) {
4427 send_parameters_.max_bandwidth_bps = 99999;
4428 FakeVideoSendStream* stream = AddSendStream();
4429 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
4430 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
4431 ASSERT_EQ(1u, stream->GetVideoStreams().size());
4432 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4433 stream->GetVideoStreams()[0].max_bitrate_bps);
4434
4435 // Get and set the rtp encoding parameters.
4436 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
4437 EXPECT_EQ(1u, parameters.encodings.size());
4438
4439 parameters.encodings[0].max_bitrate_bps = 99999 - 1;
4440 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4441 EXPECT_EQ(parameters.encodings[0].max_bitrate_bps,
4442 stream->GetVideoStreams()[0].max_bitrate_bps);
4443
4444 parameters.encodings[0].max_bitrate_bps = 99999 + 1;
4445 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
4446 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
4447 stream->GetVideoStreams()[0].max_bitrate_bps);
4448}
4449
eladalonf1841382017-06-12 01:16:46 -07004450TEST_F(WebRtcVideoChannelTest, SetMaxSendBitrateCanIncreaseSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004451 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004452 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004453 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004454 channel_->SetSend(true);
4455
4456 FakeVideoSendStream* stream = AddSendStream();
4457
Niels Möller805a27e2019-01-21 12:21:27 +01004458 webrtc::test::FrameForwarder frame_forwarder;
4459 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Peter Boström3afc8c42016-01-27 16:45:21 +01004460
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004461 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4462 int initial_max_bitrate_bps = streams[0].max_bitrate_bps;
4463 EXPECT_GT(initial_max_bitrate_bps, 0);
4464
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004465 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4466 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004467 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004468 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004469 streams = stream->GetVideoStreams();
4470 EXPECT_EQ(initial_max_bitrate_bps * 2, streams[0].max_bitrate_bps);
Niels Möllerff40b142018-04-09 08:49:14 +02004471 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004472}
4473
eladalonf1841382017-06-12 01:16:46 -07004474TEST_F(WebRtcVideoChannelTest,
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004475 SetMaxSendBitrateCanIncreaseSimulcastSenderBitrate) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004476 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004477 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004478 ASSERT_TRUE(channel_->SetSendParameters(parameters));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004479 channel_->SetSend(true);
4480
4481 FakeVideoSendStream* stream = AddSendStream(
4482 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kSsrcs3)));
4483
4484 // Send a frame to make sure this scales up to >1 stream (simulcast).
Niels Möller805a27e2019-01-21 12:21:27 +01004485 webrtc::test::FrameForwarder frame_forwarder;
4486 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, &frame_forwarder));
4487 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004488
4489 std::vector<webrtc::VideoStream> streams = stream->GetVideoStreams();
4490 ASSERT_GT(streams.size(), 1u)
4491 << "Without simulcast this test doesn't make sense.";
pbosbe16f792015-10-16 12:49:39 -07004492 int initial_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004493 EXPECT_GT(initial_max_bitrate_bps, 0);
4494
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004495 parameters.max_bandwidth_bps = initial_max_bitrate_bps * 2;
4496 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström3afc8c42016-01-27 16:45:21 +01004497 // Insert a frame to update the encoder config.
Niels Möller805a27e2019-01-21 12:21:27 +01004498 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004499 streams = stream->GetVideoStreams();
pbosbe16f792015-10-16 12:49:39 -07004500 int increased_max_bitrate_bps = GetTotalMaxBitrateBps(streams);
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004501 EXPECT_EQ(initial_max_bitrate_bps * 2, increased_max_bitrate_bps);
4502
Niels Möllerff40b142018-04-09 08:49:14 +02004503 EXPECT_TRUE(channel_->SetVideoSend(kSsrcs3[0], nullptr, nullptr));
Peter Boströmdfd53fe2015-03-27 15:58:11 +01004504}
4505
eladalonf1841382017-06-12 01:16:46 -07004506TEST_F(WebRtcVideoChannelTest, SetSendCodecsWithMaxQuantization) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004507 static const char* kMaxQuantization = "21";
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004508 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004509 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004510 parameters.codecs[0].params[kCodecParamMaxQuantization] = kMaxQuantization;
4511 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Mirko Bonadeif859e552018-05-30 15:31:29 +02004512 EXPECT_EQ(atoi(kMaxQuantization),
pbos@webrtc.org6ae48c62014-06-06 10:49:19 +00004513 AddSendStream()->GetVideoStreams().back().max_qp);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004514
4515 VideoCodec codec;
4516 EXPECT_TRUE(channel_->GetSendCodec(&codec));
4517 EXPECT_EQ(kMaxQuantization, codec.params[kCodecParamMaxQuantization]);
4518}
4519
eladalonf1841382017-06-12 01:16:46 -07004520TEST_F(WebRtcVideoChannelTest, SetSendCodecsRejectBadPayloadTypes) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004521 // TODO(pbos): Should we only allow the dynamic range?
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004522 static const int kIncorrectPayloads[] = {-2, -1, 128, 129};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004523 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004524 parameters.codecs.push_back(GetEngineCodec("VP8"));
pkasting@chromium.orge7a4a122015-01-28 21:36:55 +00004525 for (size_t i = 0; i < arraysize(kIncorrectPayloads); ++i) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004526 parameters.codecs[0].id = kIncorrectPayloads[i];
4527 EXPECT_FALSE(channel_->SetSendParameters(parameters))
pkasting@chromium.orgd3245462015-02-23 21:28:22 +00004528 << "Bad payload type '" << kIncorrectPayloads[i] << "' accepted.";
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004529 }
4530}
4531
eladalonf1841382017-06-12 01:16:46 -07004532TEST_F(WebRtcVideoChannelTest, SetSendCodecsAcceptAllValidPayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004533 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004534 parameters.codecs.push_back(GetEngineCodec("VP8"));
magjedf823ede2016-11-12 09:53:04 -08004535 for (int payload_type = 96; payload_type <= 127; ++payload_type) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004536 parameters.codecs[0].id = payload_type;
4537 EXPECT_TRUE(channel_->SetSendParameters(parameters))
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004538 << "Payload type '" << payload_type << "' rejected.";
4539 }
4540}
4541
deadbeef67cf2c12016-04-13 10:07:16 -07004542// Test that setting the a different set of codecs but with an identical front
4543// codec doesn't result in the stream being recreated.
4544// This may happen when a subsequent negotiation includes fewer codecs, as a
4545// result of one of the codecs being rejected.
eladalonf1841382017-06-12 01:16:46 -07004546TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004547 SetSendCodecsIdenticalFirstCodecDoesntRecreateStream) {
4548 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004549 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4550 parameters1.codecs.push_back(GetEngineCodec("VP9"));
deadbeef67cf2c12016-04-13 10:07:16 -07004551 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
4552
4553 AddSendStream();
4554 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4555
4556 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004557 parameters2.codecs.push_back(GetEngineCodec("VP8"));
deadbeef67cf2c12016-04-13 10:07:16 -07004558 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
4559 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
4560}
4561
eladalonf1841382017-06-12 01:16:46 -07004562TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithOnlyVp8) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004563 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004564 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004565 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004566}
4567
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004568// Test that we set our inbound RTX codecs properly.
eladalonf1841382017-06-12 01:16:46 -07004569TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithRtx) {
magjed509e4fe2016-11-18 01:34:11 -08004570 const int kUnusedPayloadType1 = 126;
4571 const int kUnusedPayloadType2 = 127;
4572 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4573 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4574
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004575 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004576 parameters.codecs.push_back(GetEngineCodec("VP8"));
4577 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004578 parameters.codecs.push_back(rtx_codec);
4579 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004580 << "RTX codec without associated payload should be rejected.";
4581
magjed509e4fe2016-11-18 01:34:11 -08004582 parameters.codecs[1].SetParam("apt", kUnusedPayloadType2);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004583 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004584 << "RTX codec with invalid associated payload type should be rejected.";
4585
magjed509e4fe2016-11-18 01:34:11 -08004586 parameters.codecs[1].SetParam("apt", GetEngineCodec("VP8").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004587 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004588
magjed509e4fe2016-11-18 01:34:11 -08004589 cricket::VideoCodec rtx_codec2(kUnusedPayloadType2, "rtx");
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004590 rtx_codec2.SetParam("apt", rtx_codec.id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004591 parameters.codecs.push_back(rtx_codec2);
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004592
Yves Gerey665174f2018-06-19 15:03:05 +02004593 EXPECT_FALSE(channel_->SetRecvParameters(parameters))
4594 << "RTX codec with another RTX as associated payload type should be "
4595 "rejected.";
pbos@webrtc.orge322a172014-06-13 11:47:28 +00004596}
4597
Mirta Dvornicic479a3c02019-06-04 15:38:50 +02004598TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketization) {
4599 cricket::VideoCodec vp8_codec = GetEngineCodec("VP8");
4600 vp8_codec.packetization = kPacketizationParamRaw;
4601
4602 cricket::VideoRecvParameters parameters;
4603 parameters.codecs = {vp8_codec, GetEngineCodec("VP9")};
4604 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4605
4606 const cricket::StreamParams params =
4607 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4608 AddRecvStream(params);
4609 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4610
4611 const webrtc::VideoReceiveStream::Config& config =
4612 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
4613 ASSERT_THAT(config.rtp.raw_payload_types, testing::SizeIs(1));
4614 EXPECT_EQ(config.rtp.raw_payload_types.count(vp8_codec.id), 1U);
4615}
4616
4617TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithPacketizationRecreatesStream) {
4618 cricket::VideoRecvParameters parameters;
4619 parameters.codecs = {GetEngineCodec("VP8"), GetEngineCodec("VP9")};
4620 parameters.codecs.back().packetization = kPacketizationParamRaw;
4621 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4622
4623 const cricket::StreamParams params =
4624 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4625 AddRecvStream(params);
4626 ASSERT_THAT(fake_call_->GetVideoReceiveStreams(), testing::SizeIs(1));
4627 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 1);
4628
4629 parameters.codecs.back().packetization.reset();
4630 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4631 EXPECT_EQ(fake_call_->GetNumCreatedReceiveStreams(), 2);
4632}
4633
Steve Anton2d2bbb12019-08-07 09:57:59 -07004634TEST_F(WebRtcVideoChannelTest, DuplicateUlpfecCodecIsDropped) {
4635 constexpr int kFirstUlpfecPayloadType = 126;
4636 constexpr int kSecondUlpfecPayloadType = 127;
4637
4638 cricket::VideoRecvParameters parameters;
4639 parameters.codecs.push_back(GetEngineCodec("VP8"));
4640 parameters.codecs.push_back(
4641 cricket::VideoCodec(kFirstUlpfecPayloadType, cricket::kUlpfecCodecName));
4642 parameters.codecs.push_back(
4643 cricket::VideoCodec(kSecondUlpfecPayloadType, cricket::kUlpfecCodecName));
4644 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4645
4646 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4647 EXPECT_EQ(kFirstUlpfecPayloadType,
4648 recv_stream->GetConfig().rtp.ulpfec_payload_type);
4649}
4650
4651TEST_F(WebRtcVideoChannelTest, DuplicateRedCodecIsDropped) {
4652 constexpr int kFirstRedPayloadType = 126;
4653 constexpr int kSecondRedPayloadType = 127;
4654
4655 cricket::VideoRecvParameters parameters;
4656 parameters.codecs.push_back(GetEngineCodec("VP8"));
4657 parameters.codecs.push_back(
4658 cricket::VideoCodec(kFirstRedPayloadType, cricket::kRedCodecName));
4659 parameters.codecs.push_back(
4660 cricket::VideoCodec(kSecondRedPayloadType, cricket::kRedCodecName));
4661 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
4662
4663 FakeVideoReceiveStream* recv_stream = AddRecvStream();
4664 EXPECT_EQ(kFirstRedPayloadType,
4665 recv_stream->GetConfig().rtp.red_payload_type);
4666}
4667
eladalonf1841382017-06-12 01:16:46 -07004668TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithChangedRtxPayloadType) {
brandtr14742122017-01-27 04:53:07 -08004669 const int kUnusedPayloadType1 = 126;
4670 const int kUnusedPayloadType2 = 127;
4671 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType1));
4672 EXPECT_FALSE(FindCodecById(engine_.codecs(), kUnusedPayloadType2));
4673
4674 // SSRCs for RTX.
4675 cricket::StreamParams params =
4676 cricket::StreamParams::CreateLegacy(kSsrcs1[0]);
4677 params.AddFidSsrc(kSsrcs1[0], kRtxSsrcs1[0]);
4678 AddRecvStream(params);
4679
4680 // Original payload type for RTX.
4681 cricket::VideoRecvParameters parameters;
4682 parameters.codecs.push_back(GetEngineCodec("VP8"));
4683 cricket::VideoCodec rtx_codec(kUnusedPayloadType1, "rtx");
4684 rtx_codec.SetParam("apt", GetEngineCodec("VP8").id);
4685 parameters.codecs.push_back(rtx_codec);
4686 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4687 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4688 const webrtc::VideoReceiveStream::Config& config_before =
4689 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004690 EXPECT_EQ(1U, config_before.rtp.rtx_associated_payload_types.size());
4691 const int* payload_type_before = FindKeyByValue(
4692 config_before.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4693 ASSERT_NE(payload_type_before, nullptr);
4694 EXPECT_EQ(kUnusedPayloadType1, *payload_type_before);
brandtr14742122017-01-27 04:53:07 -08004695 EXPECT_EQ(kRtxSsrcs1[0], config_before.rtp.rtx_ssrc);
4696
4697 // Change payload type for RTX.
4698 parameters.codecs[1].id = kUnusedPayloadType2;
4699 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
4700 ASSERT_EQ(1U, fake_call_->GetVideoReceiveStreams().size());
4701 const webrtc::VideoReceiveStream::Config& config_after =
4702 fake_call_->GetVideoReceiveStreams()[0]->GetConfig();
nisse26e3abb2017-08-25 04:44:25 -07004703 EXPECT_EQ(1U, config_after.rtp.rtx_associated_payload_types.size());
4704 const int* payload_type_after = FindKeyByValue(
4705 config_after.rtp.rtx_associated_payload_types, GetEngineCodec("VP8").id);
4706 ASSERT_NE(payload_type_after, nullptr);
4707 EXPECT_EQ(kUnusedPayloadType2, *payload_type_after);
brandtr14742122017-01-27 04:53:07 -08004708 EXPECT_EQ(kRtxSsrcs1[0], config_after.rtp.rtx_ssrc);
4709}
4710
eladalonf1841382017-06-12 01:16:46 -07004711TEST_F(WebRtcVideoChannelTest, SetRecvCodecsDifferentPayloadType) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004712 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004713 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004714 parameters.codecs[0].id = 99;
4715 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004716}
4717
eladalonf1841382017-06-12 01:16:46 -07004718TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptDefaultCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004719 cricket::VideoRecvParameters parameters;
4720 parameters.codecs = engine_.codecs();
4721 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgccbed3b2014-07-11 13:02:54 +00004722
4723 FakeVideoReceiveStream* stream = AddRecvStream();
Tommi733b5472016-06-10 17:58:01 +02004724 const webrtc::VideoReceiveStream::Config& config = stream->GetConfig();
Niels Möllercb7e1d22018-09-11 15:56:04 +02004725 EXPECT_EQ(engine_.codecs()[0].name, config.decoders[0].video_format.name);
pbos@webrtc.org776e6f22014-10-29 15:28:39 +00004726 EXPECT_EQ(engine_.codecs()[0].id, config.decoders[0].payload_type);
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004727}
4728
eladalonf1841382017-06-12 01:16:46 -07004729TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectUnsupportedCodec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004730 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004731 parameters.codecs.push_back(GetEngineCodec("VP8"));
perkj26752742016-10-24 01:21:16 -07004732 parameters.codecs.push_back(VideoCodec(101, "WTF3"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004733 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004734}
4735
eladalonf1841382017-06-12 01:16:46 -07004736TEST_F(WebRtcVideoChannelTest, SetRecvCodecsAcceptsMultipleVideoCodecs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004737 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004738 parameters.codecs.push_back(GetEngineCodec("VP8"));
4739 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004740 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004741}
4742
eladalonf1841382017-06-12 01:16:46 -07004743TEST_F(WebRtcVideoChannelTest, SetRecvCodecsWithoutFecDisablesFec) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004744 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004745 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4746 send_parameters.codecs.push_back(GetEngineCodec("red"));
4747 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004748 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004749
4750 FakeVideoReceiveStream* stream = AddRecvStream();
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004751
magjed509e4fe2016-11-18 01:34:11 -08004752 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004753 stream->GetConfig().rtp.ulpfec_payload_type);
pbos@webrtc.orgd1ea06b2014-07-18 09:35:58 +00004754
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004755 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004756 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004757 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
pbos@webrtc.org42684be2014-10-03 11:25:45 +00004758 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004759 ASSERT_TRUE(stream != nullptr);
nisse3b3622f2017-09-26 02:49:21 -07004760 EXPECT_EQ(-1, stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004761 << "SetSendCodec without ULPFEC should disable current ULPFEC.";
4762}
4763
eladalonf1841382017-06-12 01:16:46 -07004764TEST_F(WebRtcVideoChannelFlexfecRecvTest, SetRecvParamsWithoutFecDisablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004765 AddRecvStream(
4766 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004767 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004768 fake_call_->GetFlexfecReceiveStreams();
4769
4770 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004771 const FakeFlexfecReceiveStream* stream = streams.front();
4772 EXPECT_EQ(GetEngineCodec("flexfec-03").id, stream->GetConfig().payload_type);
4773 EXPECT_EQ(kFlexfecSsrc, stream->GetConfig().remote_ssrc);
4774 ASSERT_EQ(1U, stream->GetConfig().protected_media_ssrcs.size());
4775 EXPECT_EQ(kSsrcs1[0], stream->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004776
4777 cricket::VideoRecvParameters recv_parameters;
4778 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4779 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4780 EXPECT_TRUE(streams.empty())
4781 << "SetSendCodec without FlexFEC should disable current FlexFEC.";
pbos@webrtc.org269605c2014-06-26 08:49:03 +00004782}
4783
eladalonf1841382017-06-12 01:16:46 -07004784TEST_F(WebRtcVideoChannelTest, SetSendParamsWithFecEnablesFec) {
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004785 FakeVideoReceiveStream* stream = AddRecvStream();
magjed509e4fe2016-11-18 01:34:11 -08004786 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004787 stream->GetConfig().rtp.ulpfec_payload_type);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004788
4789 cricket::VideoRecvParameters recv_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004790 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4791 recv_parameters.codecs.push_back(GetEngineCodec("red"));
4792 recv_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004793 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4794 stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr468da7c2016-11-22 02:16:47 -08004795 ASSERT_TRUE(stream != nullptr);
magjed509e4fe2016-11-18 01:34:11 -08004796 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004797 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004798 << "ULPFEC should be enabled on the receive stream.";
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004799
4800 cricket::VideoSendParameters send_parameters;
magjed509e4fe2016-11-18 01:34:11 -08004801 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4802 send_parameters.codecs.push_back(GetEngineCodec("red"));
4803 send_parameters.codecs.push_back(GetEngineCodec("ulpfec"));
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004804 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4805 stream = fake_call_->GetVideoReceiveStreams()[0];
magjed509e4fe2016-11-18 01:34:11 -08004806 EXPECT_EQ(GetEngineCodec("ulpfec").id,
nisse3b3622f2017-09-26 02:49:21 -07004807 stream->GetConfig().rtp.ulpfec_payload_type)
brandtr468da7c2016-11-22 02:16:47 -08004808 << "ULPFEC should be enabled on the receive stream.";
4809}
4810
eladalonf1841382017-06-12 01:16:46 -07004811TEST_F(WebRtcVideoChannelFlexfecSendRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004812 SetSendRecvParamsWithFecEnablesFec) {
brandtr468da7c2016-11-22 02:16:47 -08004813 AddRecvStream(
4814 CreatePrimaryWithFecFrStreamParams("cname", kSsrcs1[0], kFlexfecSsrc));
brandtr9c3d4c42017-01-23 06:59:13 -08004815 const std::vector<FakeFlexfecReceiveStream*>& streams =
brandtr468da7c2016-11-22 02:16:47 -08004816 fake_call_->GetFlexfecReceiveStreams();
4817
4818 cricket::VideoRecvParameters recv_parameters;
4819 recv_parameters.codecs.push_back(GetEngineCodec("VP8"));
4820 recv_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4821 ASSERT_TRUE(channel_->SetRecvParameters(recv_parameters));
4822 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004823 const FakeFlexfecReceiveStream* stream_with_recv_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004824 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004825 stream_with_recv_params->GetConfig().payload_type);
4826 EXPECT_EQ(kFlexfecSsrc, stream_with_recv_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004827 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004828 stream_with_recv_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004829 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004830 stream_with_recv_params->GetConfig().protected_media_ssrcs[0]);
brandtr468da7c2016-11-22 02:16:47 -08004831
4832 cricket::VideoSendParameters send_parameters;
4833 send_parameters.codecs.push_back(GetEngineCodec("VP8"));
4834 send_parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4835 ASSERT_TRUE(channel_->SetSendParameters(send_parameters));
4836 ASSERT_EQ(1U, streams.size());
brandtr9c3d4c42017-01-23 06:59:13 -08004837 const FakeFlexfecReceiveStream* stream_with_send_params = streams.front();
brandtr468da7c2016-11-22 02:16:47 -08004838 EXPECT_EQ(GetEngineCodec("flexfec-03").id,
brandtr9c3d4c42017-01-23 06:59:13 -08004839 stream_with_send_params->GetConfig().payload_type);
4840 EXPECT_EQ(kFlexfecSsrc, stream_with_send_params->GetConfig().remote_ssrc);
brandtr468da7c2016-11-22 02:16:47 -08004841 EXPECT_EQ(1U,
brandtr9c3d4c42017-01-23 06:59:13 -08004842 stream_with_send_params->GetConfig().protected_media_ssrcs.size());
brandtr468da7c2016-11-22 02:16:47 -08004843 EXPECT_EQ(kSsrcs1[0],
brandtr9c3d4c42017-01-23 06:59:13 -08004844 stream_with_send_params->GetConfig().protected_media_ssrcs[0]);
Stefan Holmer2b1f6512016-05-17 16:33:30 +02004845}
4846
eladalonf1841382017-06-12 01:16:46 -07004847TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateFecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004848 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004849 parameters.codecs.push_back(GetEngineCodec("VP8"));
4850 parameters.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004851 parameters.codecs[1].id = parameters.codecs[0].id;
4852 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004853}
4854
eladalonf1841382017-06-12 01:16:46 -07004855TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr31bd2242017-05-19 05:47:46 -07004856 SetRecvCodecsRejectDuplicateFecPayloads) {
brandtr468da7c2016-11-22 02:16:47 -08004857 cricket::VideoRecvParameters parameters;
4858 parameters.codecs.push_back(GetEngineCodec("VP8"));
4859 parameters.codecs.push_back(GetEngineCodec("flexfec-03"));
4860 parameters.codecs[1].id = parameters.codecs[0].id;
4861 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
4862}
4863
eladalonf1841382017-06-12 01:16:46 -07004864TEST_F(WebRtcVideoChannelTest, SetRecvCodecsRejectDuplicateCodecPayloads) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004865 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004866 parameters.codecs.push_back(GetEngineCodec("VP8"));
4867 parameters.codecs.push_back(GetEngineCodec("VP9"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004868 parameters.codecs[1].id = parameters.codecs[0].id;
4869 EXPECT_FALSE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004870}
4871
eladalonf1841382017-06-12 01:16:46 -07004872TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004873 SetRecvCodecsAcceptSameCodecOnMultiplePayloadTypes) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004874 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08004875 parameters.codecs.push_back(GetEngineCodec("VP8"));
4876 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004877 parameters.codecs[1].id += 1;
4878 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004879}
4880
deadbeef67cf2c12016-04-13 10:07:16 -07004881// Test that setting the same codecs but with a different order
deadbeef874ca3a2015-08-20 17:19:20 -07004882// doesn't result in the stream being recreated.
eladalonf1841382017-06-12 01:16:46 -07004883TEST_F(WebRtcVideoChannelTest,
deadbeef67cf2c12016-04-13 10:07:16 -07004884 SetRecvCodecsDifferentOrderDoesntRecreateStream) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004885 cricket::VideoRecvParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08004886 parameters1.codecs.push_back(GetEngineCodec("VP8"));
4887 parameters1.codecs.push_back(GetEngineCodec("red"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004888 EXPECT_TRUE(channel_->SetRecvParameters(parameters1));
deadbeef874ca3a2015-08-20 17:19:20 -07004889
4890 AddRecvStream(cricket::StreamParams::CreateLegacy(123));
4891 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4892
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004893 cricket::VideoRecvParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08004894 parameters2.codecs.push_back(GetEngineCodec("red"));
4895 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02004896 EXPECT_TRUE(channel_->SetRecvParameters(parameters2));
deadbeef874ca3a2015-08-20 17:19:20 -07004897 EXPECT_EQ(1, fake_call_->GetNumCreatedReceiveStreams());
4898}
4899
eladalonf1841382017-06-12 01:16:46 -07004900TEST_F(WebRtcVideoChannelTest, SendStreamNotSendingByDefault) {
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004901 EXPECT_FALSE(AddSendStream()->IsSending());
4902}
4903
eladalonf1841382017-06-12 01:16:46 -07004904TEST_F(WebRtcVideoChannelTest, ReceiveStreamReceivingByDefault) {
pbos@webrtc.org85f42942014-07-22 09:14:58 +00004905 EXPECT_TRUE(AddRecvStream()->IsReceiving());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004906}
4907
eladalonf1841382017-06-12 01:16:46 -07004908TEST_F(WebRtcVideoChannelTest, SetSend) {
pbos@webrtc.org5301b0f2014-07-17 08:51:46 +00004909 FakeVideoSendStream* stream = AddSendStream();
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004910 EXPECT_FALSE(stream->IsSending());
4911
4912 // false->true
4913 EXPECT_TRUE(channel_->SetSend(true));
4914 EXPECT_TRUE(stream->IsSending());
4915 // true->true
4916 EXPECT_TRUE(channel_->SetSend(true));
4917 EXPECT_TRUE(stream->IsSending());
4918 // true->false
4919 EXPECT_TRUE(channel_->SetSend(false));
4920 EXPECT_FALSE(stream->IsSending());
4921 // false->false
4922 EXPECT_TRUE(channel_->SetSend(false));
4923 EXPECT_FALSE(stream->IsSending());
4924
4925 EXPECT_TRUE(channel_->SetSend(true));
4926 FakeVideoSendStream* new_stream = AddSendStream();
4927 EXPECT_TRUE(new_stream->IsSending())
4928 << "Send stream created after SetSend(true) not sending initially.";
4929}
4930
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004931// This test verifies DSCP settings are properly applied on video media channel.
eladalonf1841382017-06-12 01:16:46 -07004932TEST_F(WebRtcVideoChannelTest, TestSetDscpOptions) {
kwiberg686a8ef2016-02-26 03:00:35 -08004933 std::unique_ptr<cricket::FakeNetworkInterface> network_interface(
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004934 new cricket::FakeNetworkInterface);
nisse51542be2016-02-12 02:27:06 -08004935 MediaConfig config;
Tim Haloun6ca98362018-09-17 17:06:08 -07004936 std::unique_ptr<cricket::WebRtcVideoChannel> channel;
Tim Haloun648d28a2018-10-18 16:52:22 -07004937 webrtc::RtpParameters parameters;
nisse51542be2016-02-12 02:27:06 -08004938
Sebastian Jansson84848f22018-11-16 10:40:36 +01004939 channel.reset(
4940 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004941 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4942 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004943 channel->SetInterface(network_interface.get(),
4944 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004945 // Default value when DSCP is disabled should be DSCP_DEFAULT.
pbos@webrtc.orgd8198032014-11-10 14:41:43 +00004946 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004947
Tim Haloun648d28a2018-10-18 16:52:22 -07004948 // Default value when DSCP is enabled is also DSCP_DEFAULT, until it is set
4949 // through rtp parameters.
nisse51542be2016-02-12 02:27:06 -08004950 config.enable_dscp = true;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004951 channel.reset(
4952 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004953 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4954 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004955 channel->SetInterface(network_interface.get(),
4956 webrtc::MediaTransportConfig());
Tim Haloun648d28a2018-10-18 16:52:22 -07004957 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
4958
4959 // Create a send stream to configure
4960 EXPECT_TRUE(channel->AddSendStream(StreamParams::CreateLegacy(kSsrc)));
4961 parameters = channel->GetRtpSendParameters(kSsrc);
4962 ASSERT_FALSE(parameters.encodings.empty());
4963
4964 // Various priorities map to various dscp values.
4965 parameters.encodings[0].network_priority = 4.0;
4966 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
nisse51542be2016-02-12 02:27:06 -08004967 EXPECT_EQ(rtc::DSCP_AF41, network_interface->dscp());
Tim Haloun648d28a2018-10-18 16:52:22 -07004968 parameters.encodings[0].network_priority = 0.5;
4969 ASSERT_TRUE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4970 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
4971
4972 // A bad priority does not change the dscp value.
4973 parameters.encodings[0].network_priority = 0.0;
4974 ASSERT_FALSE(channel->SetRtpSendParameters(kSsrc, parameters).ok());
4975 EXPECT_EQ(rtc::DSCP_CS1, network_interface->dscp());
nisse51542be2016-02-12 02:27:06 -08004976
Tim Haloun6ca98362018-09-17 17:06:08 -07004977 // Packets should also self-identify their dscp in PacketOptions.
4978 const uint8_t kData[10] = {0};
4979 EXPECT_TRUE(static_cast<webrtc::Transport*>(channel.get())
4980 ->SendRtcp(kData, sizeof(kData)));
Tim Haloun648d28a2018-10-18 16:52:22 -07004981 EXPECT_EQ(rtc::DSCP_CS1, network_interface->options().dscp);
Tim Haloun6ca98362018-09-17 17:06:08 -07004982
nisse51542be2016-02-12 02:27:06 -08004983 // Verify that setting the option to false resets the
4984 // DiffServCodePoint.
4985 config.enable_dscp = false;
Sebastian Jansson84848f22018-11-16 10:40:36 +01004986 channel.reset(
4987 static_cast<cricket::WebRtcVideoChannel*>(engine_.CreateMediaChannel(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02004988 call_.get(), config, VideoOptions(), webrtc::CryptoOptions(),
4989 video_bitrate_allocator_factory_.get())));
Anton Sukhanov4f08faa2019-05-21 11:12:57 -07004990 channel->SetInterface(network_interface.get(),
4991 webrtc::MediaTransportConfig());
nisse51542be2016-02-12 02:27:06 -08004992 EXPECT_EQ(rtc::DSCP_DEFAULT, network_interface->dscp());
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00004993}
4994
deadbeef13871492015-12-09 12:37:51 -08004995// This test verifies that the RTCP reduced size mode is properly applied to
4996// send video streams.
eladalonf1841382017-06-12 01:16:46 -07004997TEST_F(WebRtcVideoChannelTest, TestSetSendRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08004998 // Create stream, expecting that default mode is "compound".
4999 FakeVideoSendStream* stream1 = AddSendStream();
5000 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02005001 webrtc::RtpParameters rtp_parameters =
5002 channel_->GetRtpSendParameters(last_ssrc_);
5003 EXPECT_FALSE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08005004
5005 // Now enable reduced size mode.
5006 send_parameters_.rtcp.reduced_size = true;
5007 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
5008 stream1 = fake_call_->GetVideoSendStreams()[0];
5009 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
Florent Castellidacec712018-05-24 16:24:21 +02005010 rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
5011 EXPECT_TRUE(rtp_parameters.rtcp.reduced_size);
deadbeef13871492015-12-09 12:37:51 -08005012
5013 // Create a new stream and ensure it picks up the reduced size mode.
5014 FakeVideoSendStream* stream2 = AddSendStream();
5015 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
5016}
5017
5018// This test verifies that the RTCP reduced size mode is properly applied to
5019// receive video streams.
eladalonf1841382017-06-12 01:16:46 -07005020TEST_F(WebRtcVideoChannelTest, TestSetRecvRtcpReducedSize) {
deadbeef13871492015-12-09 12:37:51 -08005021 // Create stream, expecting that default mode is "compound".
5022 FakeVideoReceiveStream* stream1 = AddRecvStream();
5023 EXPECT_EQ(webrtc::RtcpMode::kCompound, stream1->GetConfig().rtp.rtcp_mode);
5024
5025 // Now enable reduced size mode.
Taylor Brandstetter5f0b83b2016-03-18 15:02:07 -07005026 // TODO(deadbeef): Once "recv_parameters" becomes "receiver_parameters",
5027 // the reduced_size flag should come from that.
5028 send_parameters_.rtcp.reduced_size = true;
5029 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
deadbeef13871492015-12-09 12:37:51 -08005030 stream1 = fake_call_->GetVideoReceiveStreams()[0];
5031 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream1->GetConfig().rtp.rtcp_mode);
5032
5033 // Create a new stream and ensure it picks up the reduced size mode.
5034 FakeVideoReceiveStream* stream2 = AddRecvStream();
5035 EXPECT_EQ(webrtc::RtcpMode::kReducedSize, stream2->GetConfig().rtp.rtcp_mode);
5036}
5037
eladalonf1841382017-06-12 01:16:46 -07005038TEST_F(WebRtcVideoChannelTest, OnReadyToSendSignalsNetworkState) {
skvlad7a43d252016-03-22 15:32:27 -07005039 EXPECT_EQ(webrtc::kNetworkUp,
5040 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5041 EXPECT_EQ(webrtc::kNetworkUp,
5042 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00005043
5044 channel_->OnReadyToSend(false);
skvlad7a43d252016-03-22 15:32:27 -07005045 EXPECT_EQ(webrtc::kNetworkDown,
5046 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5047 EXPECT_EQ(webrtc::kNetworkUp,
5048 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.org26c0c412014-09-03 16:17:12 +00005049
5050 channel_->OnReadyToSend(true);
skvlad7a43d252016-03-22 15:32:27 -07005051 EXPECT_EQ(webrtc::kNetworkUp,
5052 fake_call_->GetNetworkState(webrtc::MediaType::VIDEO));
5053 EXPECT_EQ(webrtc::kNetworkUp,
5054 fake_call_->GetNetworkState(webrtc::MediaType::AUDIO));
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00005055}
5056
eladalonf1841382017-06-12 01:16:46 -07005057TEST_F(WebRtcVideoChannelTest, GetStatsReportsSentCodecName) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005058 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08005059 parameters.codecs.push_back(GetEngineCodec("VP8"));
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005060 EXPECT_TRUE(channel_->SetSendParameters(parameters));
Peter Boström74d9ed72015-03-26 16:28:31 +01005061
5062 AddSendStream();
5063
5064 cricket::VideoMediaInfo info;
5065 ASSERT_TRUE(channel_->GetStats(&info));
magjed509e4fe2016-11-18 01:34:11 -08005066 EXPECT_EQ("VP8", info.senders[0].codec_name);
Peter Boström74d9ed72015-03-26 16:28:31 +01005067}
5068
eladalonf1841382017-06-12 01:16:46 -07005069TEST_F(WebRtcVideoChannelTest, GetStatsReportsEncoderImplementationName) {
Peter Boströmb7d9a972015-12-18 16:01:11 +01005070 FakeVideoSendStream* stream = AddSendStream();
5071 webrtc::VideoSendStream::Stats stats;
5072 stats.encoder_implementation_name = "encoder_implementation_name";
5073 stream->SetStats(stats);
5074
5075 cricket::VideoMediaInfo info;
5076 ASSERT_TRUE(channel_->GetStats(&info));
5077 EXPECT_EQ(stats.encoder_implementation_name,
5078 info.senders[0].encoder_implementation_name);
5079}
5080
eladalonf1841382017-06-12 01:16:46 -07005081TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuOveruseMetrics) {
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005082 FakeVideoSendStream* stream = AddSendStream();
5083 webrtc::VideoSendStream::Stats stats;
5084 stats.avg_encode_time_ms = 13;
5085 stats.encode_usage_percent = 42;
5086 stream->SetStats(stats);
5087
5088 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005089 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org3e6e2712015-02-26 12:19:31 +00005090 EXPECT_EQ(stats.avg_encode_time_ms, info.senders[0].avg_encode_ms);
5091 EXPECT_EQ(stats.encode_usage_percent, info.senders[0].encode_usage_percent);
5092}
5093
eladalonf1841382017-06-12 01:16:46 -07005094TEST_F(WebRtcVideoChannelTest, GetStatsReportsFramesEncoded) {
sakal43536c32016-10-24 01:46:43 -07005095 FakeVideoSendStream* stream = AddSendStream();
5096 webrtc::VideoSendStream::Stats stats;
5097 stats.frames_encoded = 13;
5098 stream->SetStats(stats);
5099
5100 cricket::VideoMediaInfo info;
5101 ASSERT_TRUE(channel_->GetStats(&info));
5102 EXPECT_EQ(stats.frames_encoded, info.senders[0].frames_encoded);
5103}
5104
Rasmus Brandt2efae772019-06-27 14:29:34 +02005105TEST_F(WebRtcVideoChannelTest, GetStatsReportsKeyFramesEncoded) {
5106 FakeVideoSendStream* stream = AddSendStream();
5107 webrtc::VideoSendStream::Stats stats;
5108 stats.substreams[123].frame_counts.key_frames = 10;
5109 stats.substreams[456].frame_counts.key_frames = 87;
5110 stream->SetStats(stats);
5111
5112 cricket::VideoMediaInfo info;
5113 ASSERT_TRUE(channel_->GetStats(&info));
5114 // TODO(bugs.webrtc.org/9547): Populate individual outbound-rtp stats objects
5115 // for each simulcast stream, instead of accumulating all keyframes encoded
5116 // over all simulcast streams in the same outbound-rtp stats object.
5117 EXPECT_EQ(97u, info.senders[0].key_frames_encoded);
5118}
5119
eladalonf1841382017-06-12 01:16:46 -07005120TEST_F(WebRtcVideoChannelTest, GetStatsReportsQpSum) {
sakal87da4042016-10-31 06:53:47 -07005121 FakeVideoSendStream* stream = AddSendStream();
5122 webrtc::VideoSendStream::Stats stats;
Oskar Sundbom78807582017-11-16 11:09:55 +01005123 stats.qp_sum = 13;
sakal87da4042016-10-31 06:53:47 -07005124 stream->SetStats(stats);
5125
5126 cricket::VideoMediaInfo info;
5127 ASSERT_TRUE(channel_->GetStats(&info));
5128 EXPECT_EQ(stats.qp_sum, info.senders[0].qp_sum);
5129}
5130
eladalonf1841382017-06-12 01:16:46 -07005131TEST_F(WebRtcVideoChannelTest, GetStatsReportsUpperResolution) {
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005132 FakeVideoSendStream* stream = AddSendStream();
5133 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005134 stats.substreams[17].width = 123;
5135 stats.substreams[17].height = 40;
5136 stats.substreams[42].width = 80;
5137 stats.substreams[42].height = 31;
5138 stats.substreams[11].width = 20;
5139 stats.substreams[11].height = 90;
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005140 stream->SetStats(stats);
5141
5142 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005143 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org273a4142014-12-01 15:23:21 +00005144 ASSERT_EQ(1u, info.senders.size());
5145 EXPECT_EQ(123, info.senders[0].send_frame_width);
5146 EXPECT_EQ(90, info.senders[0].send_frame_height);
5147}
5148
eladalonf1841382017-06-12 01:16:46 -07005149TEST_F(WebRtcVideoChannelTest, GetStatsReportsCpuAdaptationStats) {
perkj803d97f2016-11-01 11:45:46 -07005150 FakeVideoSendStream* stream = AddSendStream();
5151 webrtc::VideoSendStream::Stats stats;
5152 stats.number_of_cpu_adapt_changes = 2;
5153 stats.cpu_limited_resolution = true;
5154 stream->SetStats(stats);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005155
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005156 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005157 EXPECT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005158 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005159 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU, info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005160 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
pbos@webrtc.org9a4410e2015-02-26 10:03:39 +00005161}
5162
eladalonf1841382017-06-12 01:16:46 -07005163TEST_F(WebRtcVideoChannelTest, GetStatsReportsAdaptationAndBandwidthStats) {
perkj803d97f2016-11-01 11:45:46 -07005164 FakeVideoSendStream* stream = AddSendStream();
asapersson17821db2015-12-14 02:08:12 -08005165 webrtc::VideoSendStream::Stats stats;
perkj803d97f2016-11-01 11:45:46 -07005166 stats.number_of_cpu_adapt_changes = 2;
5167 stats.cpu_limited_resolution = true;
asapersson17821db2015-12-14 02:08:12 -08005168 stats.bw_limited_resolution = true;
perkj803d97f2016-11-01 11:45:46 -07005169 stream->SetStats(stats);
5170
5171 cricket::VideoMediaInfo info;
asapersson17821db2015-12-14 02:08:12 -08005172 EXPECT_TRUE(channel_->GetStats(&info));
5173 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005174 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_CPU |
5175 WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005176 info.senders[0].adapt_reason);
perkj803d97f2016-11-01 11:45:46 -07005177 EXPECT_EQ(stats.number_of_cpu_adapt_changes, info.senders[0].adapt_changes);
asapersson17821db2015-12-14 02:08:12 -08005178}
5179
eladalonf1841382017-06-12 01:16:46 -07005180TEST_F(WebRtcVideoChannelTest,
asapersson17821db2015-12-14 02:08:12 -08005181 GetStatsTranslatesBandwidthLimitedResolutionCorrectly) {
5182 FakeVideoSendStream* stream = AddSendStream();
5183 webrtc::VideoSendStream::Stats stats;
5184 stats.bw_limited_resolution = true;
5185 stream->SetStats(stats);
5186
5187 cricket::VideoMediaInfo info;
5188 EXPECT_TRUE(channel_->GetStats(&info));
5189 ASSERT_EQ(1U, info.senders.size());
eladalonf1841382017-06-12 01:16:46 -07005190 EXPECT_EQ(WebRtcVideoChannel::ADAPTREASON_BANDWIDTH,
asapersson17821db2015-12-14 02:08:12 -08005191 info.senders[0].adapt_reason);
5192}
5193
Yves Gerey665174f2018-06-19 15:03:05 +02005194TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesSendRtcpPacketTypesCorrectly) {
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005195 FakeVideoSendStream* stream = AddSendStream();
5196 webrtc::VideoSendStream::Stats stats;
5197 stats.substreams[17].rtcp_packet_type_counts.fir_packets = 2;
5198 stats.substreams[17].rtcp_packet_type_counts.nack_packets = 3;
5199 stats.substreams[17].rtcp_packet_type_counts.pli_packets = 4;
5200
5201 stats.substreams[42].rtcp_packet_type_counts.fir_packets = 5;
5202 stats.substreams[42].rtcp_packet_type_counts.nack_packets = 7;
5203 stats.substreams[42].rtcp_packet_type_counts.pli_packets = 9;
5204
5205 stream->SetStats(stats);
5206
5207 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005208 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005209 EXPECT_EQ(7, info.senders[0].firs_rcvd);
5210 EXPECT_EQ(10, info.senders[0].nacks_rcvd);
5211 EXPECT_EQ(13, info.senders[0].plis_rcvd);
5212}
5213
eladalonf1841382017-06-12 01:16:46 -07005214TEST_F(WebRtcVideoChannelTest,
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005215 GetStatsTranslatesReceiveRtcpPacketTypesCorrectly) {
5216 FakeVideoReceiveStream* stream = AddRecvStream();
5217 webrtc::VideoReceiveStream::Stats stats;
5218 stats.rtcp_packet_type_counts.fir_packets = 2;
5219 stats.rtcp_packet_type_counts.nack_packets = 3;
5220 stats.rtcp_packet_type_counts.pli_packets = 4;
5221 stream->SetStats(stats);
5222
5223 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005224 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005225 EXPECT_EQ(stats.rtcp_packet_type_counts.fir_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005226 rtc::checked_cast<unsigned int>(info.receivers[0].firs_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005227 EXPECT_EQ(stats.rtcp_packet_type_counts.nack_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005228 rtc::checked_cast<unsigned int>(info.receivers[0].nacks_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005229 EXPECT_EQ(stats.rtcp_packet_type_counts.pli_packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005230 rtc::checked_cast<unsigned int>(info.receivers[0].plis_sent));
pbos@webrtc.org1d0fa5d2015-02-19 12:47:00 +00005231}
5232
eladalonf1841382017-06-12 01:16:46 -07005233TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesDecodeStatsCorrectly) {
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005234 FakeVideoReceiveStream* stream = AddRecvStream();
5235 webrtc::VideoReceiveStream::Stats stats;
Peter Boströmb7d9a972015-12-18 16:01:11 +01005236 stats.decoder_implementation_name = "decoder_implementation_name";
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005237 stats.decode_ms = 2;
5238 stats.max_decode_ms = 3;
5239 stats.current_delay_ms = 4;
5240 stats.target_delay_ms = 5;
5241 stats.jitter_buffer_ms = 6;
Guido Urdaneta67378412019-05-28 17:38:08 +02005242 stats.jitter_buffer_delay_seconds = 60;
5243 stats.jitter_buffer_emitted_count = 6;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005244 stats.min_playout_delay_ms = 7;
5245 stats.render_delay_ms = 8;
asapersson26dd92b2016-08-30 00:45:45 -07005246 stats.width = 9;
5247 stats.height = 10;
hbos42f6d2f2017-01-20 03:56:50 -08005248 stats.frame_counts.key_frames = 11;
5249 stats.frame_counts.delta_frames = 12;
hbos50cfe1f2017-01-23 07:21:55 -08005250 stats.frames_rendered = 13;
5251 stats.frames_decoded = 14;
Oskar Sundbom78807582017-11-16 11:09:55 +01005252 stats.qp_sum = 15;
Johannes Kronbfd343b2019-07-01 10:07:50 +02005253 stats.total_decode_time_ms = 16;
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005254 stream->SetStats(stats);
5255
5256 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005257 ASSERT_TRUE(channel_->GetStats(&info));
Peter Boströmb7d9a972015-12-18 16:01:11 +01005258 EXPECT_EQ(stats.decoder_implementation_name,
5259 info.receivers[0].decoder_implementation_name);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005260 EXPECT_EQ(stats.decode_ms, info.receivers[0].decode_ms);
5261 EXPECT_EQ(stats.max_decode_ms, info.receivers[0].max_decode_ms);
5262 EXPECT_EQ(stats.current_delay_ms, info.receivers[0].current_delay_ms);
5263 EXPECT_EQ(stats.target_delay_ms, info.receivers[0].target_delay_ms);
5264 EXPECT_EQ(stats.jitter_buffer_ms, info.receivers[0].jitter_buffer_ms);
Guido Urdaneta67378412019-05-28 17:38:08 +02005265 EXPECT_EQ(stats.jitter_buffer_delay_seconds,
5266 info.receivers[0].jitter_buffer_delay_seconds);
5267 EXPECT_EQ(stats.jitter_buffer_emitted_count,
5268 info.receivers[0].jitter_buffer_emitted_count);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005269 EXPECT_EQ(stats.min_playout_delay_ms, info.receivers[0].min_playout_delay_ms);
5270 EXPECT_EQ(stats.render_delay_ms, info.receivers[0].render_delay_ms);
asapersson26dd92b2016-08-30 00:45:45 -07005271 EXPECT_EQ(stats.width, info.receivers[0].frame_width);
5272 EXPECT_EQ(stats.height, info.receivers[0].frame_height);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005273 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames +
5274 stats.frame_counts.delta_frames),
hbos42f6d2f2017-01-20 03:56:50 -08005275 info.receivers[0].frames_received);
hbos50cfe1f2017-01-23 07:21:55 -08005276 EXPECT_EQ(stats.frames_rendered, info.receivers[0].frames_rendered);
sakale5ba44e2016-10-26 07:09:24 -07005277 EXPECT_EQ(stats.frames_decoded, info.receivers[0].frames_decoded);
Rasmus Brandt2efae772019-06-27 14:29:34 +02005278 EXPECT_EQ(rtc::checked_cast<unsigned int>(stats.frame_counts.key_frames),
5279 info.receivers[0].key_frames_decoded);
sakalcc452e12017-02-09 04:53:45 -08005280 EXPECT_EQ(stats.qp_sum, info.receivers[0].qp_sum);
Johannes Kronbfd343b2019-07-01 10:07:50 +02005281 EXPECT_EQ(stats.total_decode_time_ms, info.receivers[0].total_decode_time_ms);
pbos@webrtc.org09c77b92015-02-25 10:42:16 +00005282}
5283
eladalonf1841382017-06-12 01:16:46 -07005284TEST_F(WebRtcVideoChannelTest, GetStatsTranslatesReceivePacketStatsCorrectly) {
Mirko Bonadeief0627f2019-10-15 08:54:49 +00005285 webrtc::test::ScopedFieldTrials field_trials(
5286 "WebRTC-UseStandardBytesStats/Enabled/");
5287
Peter Boström393347f2015-04-22 14:52:45 +02005288 FakeVideoReceiveStream* stream = AddRecvStream();
5289 webrtc::VideoReceiveStream::Stats stats;
Niels Möllerd77cc242019-08-22 09:40:25 +02005290 stats.rtp_stats.packet_counter.payload_bytes = 2;
5291 stats.rtp_stats.packet_counter.header_bytes = 3;
5292 stats.rtp_stats.packet_counter.padding_bytes = 4;
5293 stats.rtp_stats.packet_counter.packets = 5;
5294 stats.rtp_stats.packets_lost = 6;
Peter Boström393347f2015-04-22 14:52:45 +02005295 stream->SetStats(stats);
5296
5297 cricket::VideoMediaInfo info;
5298 ASSERT_TRUE(channel_->GetStats(&info));
Niels Möllerd77cc242019-08-22 09:40:25 +02005299 EXPECT_EQ(stats.rtp_stats.packet_counter.payload_bytes,
Mirko Bonadeief0627f2019-10-15 08:54:49 +00005300 rtc::checked_cast<size_t>(info.receivers[0].bytes_rcvd));
Niels Möllerd77cc242019-08-22 09:40:25 +02005301 EXPECT_EQ(stats.rtp_stats.packet_counter.packets,
Mirko Bonadeif859e552018-05-30 15:31:29 +02005302 rtc::checked_cast<unsigned int>(info.receivers[0].packets_rcvd));
Niels Möllerd77cc242019-08-22 09:40:25 +02005303 EXPECT_EQ(stats.rtp_stats.packets_lost, info.receivers[0].packets_lost);
Peter Boström393347f2015-04-22 14:52:45 +02005304}
5305
eladalonf1841382017-06-12 01:16:46 -07005306TEST_F(WebRtcVideoChannelTest, TranslatesCallStatsCorrectly) {
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005307 AddSendStream();
5308 AddSendStream();
5309 webrtc::Call::Stats stats;
5310 stats.rtt_ms = 123;
5311 fake_call_->SetStats(stats);
5312
5313 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005314 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org2b19f062014-12-11 13:26:09 +00005315 ASSERT_EQ(2u, info.senders.size());
5316 EXPECT_EQ(stats.rtt_ms, info.senders[0].rtt_ms);
5317 EXPECT_EQ(stats.rtt_ms, info.senders[1].rtt_ms);
5318}
5319
eladalonf1841382017-06-12 01:16:46 -07005320TEST_F(WebRtcVideoChannelTest, TranslatesSenderBitrateStatsCorrectly) {
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005321 FakeVideoSendStream* stream = AddSendStream();
5322 webrtc::VideoSendStream::Stats stats;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005323 stats.target_media_bitrate_bps = 156;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005324 stats.media_bitrate_bps = 123;
5325 stats.substreams[17].total_bitrate_bps = 1;
5326 stats.substreams[17].retransmit_bitrate_bps = 2;
5327 stats.substreams[42].total_bitrate_bps = 3;
5328 stats.substreams[42].retransmit_bitrate_bps = 4;
5329 stream->SetStats(stats);
5330
5331 FakeVideoSendStream* stream2 = AddSendStream();
5332 webrtc::VideoSendStream::Stats stats2;
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005333 stats2.target_media_bitrate_bps = 200;
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005334 stats2.media_bitrate_bps = 321;
5335 stats2.substreams[13].total_bitrate_bps = 5;
5336 stats2.substreams[13].retransmit_bitrate_bps = 6;
5337 stats2.substreams[21].total_bitrate_bps = 7;
5338 stats2.substreams[21].retransmit_bitrate_bps = 8;
5339 stream2->SetStats(stats2);
5340
5341 cricket::VideoMediaInfo info;
pbos@webrtc.org058b1f12015-03-04 08:54:32 +00005342 ASSERT_TRUE(channel_->GetStats(&info));
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005343 ASSERT_EQ(2u, info.senders.size());
stefanf79ade12017-06-02 06:44:03 -07005344 BandwidthEstimationInfo bwe_info;
5345 channel_->FillBitrateInfo(&bwe_info);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005346 // Assuming stream and stream2 corresponds to senders[0] and [1] respectively
5347 // is OK as std::maps are sorted and AddSendStream() gives increasing SSRCs.
5348 EXPECT_EQ(stats.media_bitrate_bps, info.senders[0].nominal_bitrate);
5349 EXPECT_EQ(stats2.media_bitrate_bps, info.senders[1].nominal_bitrate);
pbos@webrtc.org891d4832015-02-26 13:15:22 +00005350 EXPECT_EQ(stats.target_media_bitrate_bps + stats2.target_media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005351 bwe_info.target_enc_bitrate);
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005352 EXPECT_EQ(stats.media_bitrate_bps + stats2.media_bitrate_bps,
stefanf79ade12017-06-02 06:44:03 -07005353 bwe_info.actual_enc_bitrate);
5354 EXPECT_EQ(1 + 3 + 5 + 7, bwe_info.transmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005355 << "Bandwidth stats should take all streams into account.";
stefanf79ade12017-06-02 06:44:03 -07005356 EXPECT_EQ(2 + 4 + 6 + 8, bwe_info.retransmit_bitrate)
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00005357 << "Bandwidth stats should take all streams into account.";
5358}
5359
eladalonf1841382017-06-12 01:16:46 -07005360TEST_F(WebRtcVideoChannelTest, DefaultReceiveStreamReconfiguresToUseRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005361 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005362
Peter Boström0c4e06b2015-10-07 12:23:21 +02005363 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5364 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005365
5366 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5367 const size_t kDataLength = 12;
5368 uint8_t data[kDataLength];
5369 memset(data, 0, sizeof(data));
5370 rtc::SetBE32(&data[8], ssrcs[0]);
jbaucheec21bd2016-03-20 06:15:43 -07005371 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005372 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005373
5374 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5375 << "No default receive stream created.";
5376 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
brandtr14742122017-01-27 04:53:07 -08005377 EXPECT_EQ(0u, recv_stream->GetConfig().rtp.rtx_ssrc)
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005378 << "Default receive stream should not have configured RTX";
5379
5380 EXPECT_TRUE(channel_->AddRecvStream(
5381 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs)));
5382 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
brandtr14742122017-01-27 04:53:07 -08005383 << "AddRecvStream should have reconfigured, not added a new receiver.";
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005384 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
nisse26e3abb2017-08-25 04:44:25 -07005385 EXPECT_FALSE(
5386 recv_stream->GetConfig().rtp.rtx_associated_payload_types.empty());
nisseca5706d2017-09-11 02:32:16 -07005387 EXPECT_TRUE(VerifyRtxReceiveAssociations(recv_stream->GetConfig()))
Peter Boströmd8b01092016-05-12 16:44:36 +02005388 << "RTX should be mapped for all decoders/payload types.";
nisseca5706d2017-09-11 02:32:16 -07005389 EXPECT_TRUE(HasRtxReceiveAssociation(recv_stream->GetConfig(),
Yves Gerey665174f2018-06-19 15:03:05 +02005390 GetEngineCodec("red").id))
nisseca5706d2017-09-11 02:32:16 -07005391 << "RTX should be mapped also for the RED payload type";
brandtr14742122017-01-27 04:53:07 -08005392 EXPECT_EQ(rtx_ssrcs[0], recv_stream->GetConfig().rtp.rtx_ssrc);
pbos@webrtc.orga2a6fe62015-03-06 15:35:19 +00005393}
5394
eladalonf1841382017-06-12 01:16:46 -07005395TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithMissingSsrcsForRtx) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005396 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd4362cd2015-03-25 14:17:23 +01005397
Peter Boström0c4e06b2015-10-07 12:23:21 +02005398 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5399 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd4362cd2015-03-25 14:17:23 +01005400
5401 StreamParams sp =
5402 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5403 sp.ssrcs = ssrcs; // Without RTXs, this is the important part.
5404
5405 EXPECT_FALSE(channel_->AddSendStream(sp));
5406 EXPECT_FALSE(channel_->AddRecvStream(sp));
5407}
5408
eladalonf1841382017-06-12 01:16:46 -07005409TEST_F(WebRtcVideoChannelTest, RejectsAddingStreamsWithOverlappingRtxSsrcs) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005410 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005411
Peter Boström0c4e06b2015-10-07 12:23:21 +02005412 const std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs1);
5413 const std::vector<uint32_t> rtx_ssrcs = MAKE_VECTOR(kRtxSsrcs1);
Peter Boströmd6f4c252015-03-26 16:23:04 +01005414
5415 StreamParams sp =
5416 cricket::CreateSimWithRtxStreamParams("cname", ssrcs, rtx_ssrcs);
5417
5418 EXPECT_TRUE(channel_->AddSendStream(sp));
5419 EXPECT_TRUE(channel_->AddRecvStream(sp));
5420
5421 // The RTX SSRC is already used in previous streams, using it should fail.
5422 sp = cricket::StreamParams::CreateLegacy(rtx_ssrcs[0]);
5423 EXPECT_FALSE(channel_->AddSendStream(sp));
5424 EXPECT_FALSE(channel_->AddRecvStream(sp));
5425
5426 // After removing the original stream this should be fine to add (makes sure
5427 // that RTX ssrcs are not forever taken).
5428 EXPECT_TRUE(channel_->RemoveSendStream(ssrcs[0]));
5429 EXPECT_TRUE(channel_->RemoveRecvStream(ssrcs[0]));
5430 EXPECT_TRUE(channel_->AddSendStream(sp));
5431 EXPECT_TRUE(channel_->AddRecvStream(sp));
5432}
5433
eladalonf1841382017-06-12 01:16:46 -07005434TEST_F(WebRtcVideoChannelTest,
Peter Boströmd6f4c252015-03-26 16:23:04 +01005435 RejectsAddingStreamsWithOverlappingSimulcastSsrcs) {
Peter Boström0c4e06b2015-10-07 12:23:21 +02005436 static const uint32_t kFirstStreamSsrcs[] = {1, 2, 3};
5437 static const uint32_t kOverlappingStreamSsrcs[] = {4, 3, 5};
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005438 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005439
Peter Boströmd6f4c252015-03-26 16:23:04 +01005440 StreamParams sp =
5441 cricket::CreateSimStreamParams("cname", MAKE_VECTOR(kFirstStreamSsrcs));
5442
5443 EXPECT_TRUE(channel_->AddSendStream(sp));
5444 EXPECT_TRUE(channel_->AddRecvStream(sp));
5445
5446 // One of the SSRCs is already used in previous streams, using it should fail.
5447 sp = cricket::CreateSimStreamParams("cname",
5448 MAKE_VECTOR(kOverlappingStreamSsrcs));
5449 EXPECT_FALSE(channel_->AddSendStream(sp));
5450 EXPECT_FALSE(channel_->AddRecvStream(sp));
5451
5452 // After removing the original stream this should be fine to add (makes sure
5453 // that RTX ssrcs are not forever taken).
Peter Boström3548dd22015-05-22 18:48:36 +02005454 EXPECT_TRUE(channel_->RemoveSendStream(kFirstStreamSsrcs[0]));
5455 EXPECT_TRUE(channel_->RemoveRecvStream(kFirstStreamSsrcs[0]));
Peter Boströmd6f4c252015-03-26 16:23:04 +01005456 EXPECT_TRUE(channel_->AddSendStream(sp));
5457 EXPECT_TRUE(channel_->AddRecvStream(sp));
5458}
5459
eladalonf1841382017-06-12 01:16:46 -07005460TEST_F(WebRtcVideoChannelTest, ReportsSsrcGroupsInStats) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005461 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström259bd202015-05-28 13:39:50 +02005462
5463 static const uint32_t kSenderSsrcs[] = {4, 7, 10};
5464 static const uint32_t kSenderRtxSsrcs[] = {5, 8, 11};
5465
5466 StreamParams sender_sp = cricket::CreateSimWithRtxStreamParams(
5467 "cname", MAKE_VECTOR(kSenderSsrcs), MAKE_VECTOR(kSenderRtxSsrcs));
5468
5469 EXPECT_TRUE(channel_->AddSendStream(sender_sp));
5470
5471 static const uint32_t kReceiverSsrcs[] = {3};
5472 static const uint32_t kReceiverRtxSsrcs[] = {2};
5473
5474 StreamParams receiver_sp = cricket::CreateSimWithRtxStreamParams(
5475 "cname", MAKE_VECTOR(kReceiverSsrcs), MAKE_VECTOR(kReceiverRtxSsrcs));
5476 EXPECT_TRUE(channel_->AddRecvStream(receiver_sp));
5477
5478 cricket::VideoMediaInfo info;
5479 ASSERT_TRUE(channel_->GetStats(&info));
5480
5481 ASSERT_EQ(1u, info.senders.size());
5482 ASSERT_EQ(1u, info.receivers.size());
5483
5484 EXPECT_NE(sender_sp.ssrc_groups, receiver_sp.ssrc_groups);
5485 EXPECT_EQ(sender_sp.ssrc_groups, info.senders[0].ssrc_groups);
5486 EXPECT_EQ(receiver_sp.ssrc_groups, info.receivers[0].ssrc_groups);
5487}
5488
eladalonf1841382017-06-12 01:16:46 -07005489TEST_F(WebRtcVideoChannelTest, MapsReceivedPayloadTypeToCodecName) {
pbosf42376c2015-08-28 07:35:32 -07005490 FakeVideoReceiveStream* stream = AddRecvStream();
5491 webrtc::VideoReceiveStream::Stats stats;
5492 cricket::VideoMediaInfo info;
5493
5494 // Report no codec name before receiving.
5495 stream->SetStats(stats);
5496 ASSERT_TRUE(channel_->GetStats(&info));
5497 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5498
5499 // Report VP8 if we're receiving it.
magjed509e4fe2016-11-18 01:34:11 -08005500 stats.current_payload_type = GetEngineCodec("VP8").id;
pbosf42376c2015-08-28 07:35:32 -07005501 stream->SetStats(stats);
5502 ASSERT_TRUE(channel_->GetStats(&info));
5503 EXPECT_STREQ(kVp8CodecName, info.receivers[0].codec_name.c_str());
5504
5505 // Report no codec name for unknown playload types.
5506 stats.current_payload_type = 3;
5507 stream->SetStats(stats);
5508 ASSERT_TRUE(channel_->GetStats(&info));
5509 EXPECT_STREQ("", info.receivers[0].codec_name.c_str());
5510}
5511
Seth Hampson5897a6e2018-04-03 11:16:33 -07005512// Tests that when we add a stream without SSRCs, but contains a stream_id
5513// that it is stored and its stream id is later used when the first packet
5514// arrives to properly create a receive stream with a sync label.
5515TEST_F(WebRtcVideoChannelTest, RecvUnsignaledSsrcWithSignaledStreamId) {
5516 const char kSyncLabel[] = "sync_label";
5517 cricket::StreamParams unsignaled_stream;
5518 unsignaled_stream.set_stream_ids({kSyncLabel});
5519 ASSERT_TRUE(channel_->AddRecvStream(unsignaled_stream));
5520 // The stream shouldn't have been created at this point because it doesn't
5521 // have any SSRCs.
Mirko Bonadeif859e552018-05-30 15:31:29 +02005522 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
Seth Hampson5897a6e2018-04-03 11:16:33 -07005523
5524 // Create and deliver packet.
5525 const size_t kDataLength = 12;
5526 uint8_t data[kDataLength];
5527 memset(data, 0, sizeof(data));
5528 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5529 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005530 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005531
5532 // The stream should now be created with the appropriate sync label.
5533 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5534 EXPECT_EQ(kSyncLabel,
5535 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group);
5536
Saurav Dasff27da52019-09-20 11:05:30 -07005537 // Reset the unsignaled stream to clear the cache. This time when
Seth Hampson5897a6e2018-04-03 11:16:33 -07005538 // a default video receive stream is created it won't have a sync_group.
Saurav Dasff27da52019-09-20 11:05:30 -07005539 channel_->ResetUnsignaledRecvStream();
Seth Hampson5897a6e2018-04-03 11:16:33 -07005540 ASSERT_TRUE(channel_->RemoveRecvStream(kIncomingUnsignalledSsrc));
5541 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5542
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005543 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Seth Hampson5897a6e2018-04-03 11:16:33 -07005544 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5545 EXPECT_TRUE(
5546 fake_call_->GetVideoReceiveStreams()[0]->GetConfig().sync_group.empty());
5547}
5548
Ruslan Burakov493a6502019-02-27 15:32:48 +01005549// Test BaseMinimumPlayoutDelayMs on receive streams.
5550TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMs) {
5551 // Test that set won't work for non-existing receive streams.
5552 EXPECT_FALSE(channel_->SetBaseMinimumPlayoutDelayMs(kSsrc + 2, 200));
5553 // Test that get won't work for non-existing receive streams.
5554 EXPECT_FALSE(channel_->GetBaseMinimumPlayoutDelayMs(kSsrc + 2));
5555
5556 EXPECT_TRUE(AddRecvStream());
5557 // Test that set works for the existing receive stream.
5558 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(last_ssrc_, 200));
5559 auto* recv_stream = fake_call_->GetVideoReceiveStream(last_ssrc_);
5560 EXPECT_TRUE(recv_stream);
5561 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5562 EXPECT_EQ(channel_->GetBaseMinimumPlayoutDelayMs(last_ssrc_).value_or(0),
5563 200);
5564}
5565
5566// Test BaseMinimumPlayoutDelayMs on unsignaled receive streams.
5567TEST_F(WebRtcVideoChannelTest, BaseMinimumPlayoutDelayMsUnsignaledRecvStream) {
5568 absl::optional<int> delay_ms;
5569 const FakeVideoReceiveStream* recv_stream;
5570
5571 // Set default stream with SSRC 0
5572 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 200));
5573 EXPECT_EQ(200, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5574
5575 // Spawn an unsignaled stream by sending a packet, it should inherit
5576 // default delay 200.
5577 const size_t kDataLength = 12;
5578 uint8_t data[kDataLength];
5579 memset(data, 0, sizeof(data));
5580 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
5581 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005582 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
Ruslan Burakov493a6502019-02-27 15:32:48 +01005583
5584 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5585 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 200);
5586 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5587 EXPECT_EQ(200, delay_ms.value_or(0));
5588
5589 // Check that now if we change delay for SSRC 0 it will change delay for the
5590 // default receiving stream as well.
5591 EXPECT_TRUE(channel_->SetBaseMinimumPlayoutDelayMs(0, 300));
5592 EXPECT_EQ(300, channel_->GetBaseMinimumPlayoutDelayMs(0).value_or(0));
5593 delay_ms = channel_->GetBaseMinimumPlayoutDelayMs(kIncomingUnsignalledSsrc);
5594 EXPECT_EQ(300, delay_ms.value_or(0));
5595 recv_stream = fake_call_->GetVideoReceiveStream(kIncomingUnsignalledSsrc);
5596 EXPECT_EQ(recv_stream->base_mininum_playout_delay_ms(), 300);
5597}
5598
eladalonf1841382017-06-12 01:16:46 -07005599void WebRtcVideoChannelTest::TestReceiveUnsignaledSsrcPacket(
noahricd10a68e2015-07-10 11:27:55 -07005600 uint8_t payload_type,
5601 bool expect_created_receive_stream) {
magjed509e4fe2016-11-18 01:34:11 -08005602 // kRedRtxPayloadType must currently be unused.
5603 EXPECT_FALSE(FindCodecById(engine_.codecs(), kRedRtxPayloadType));
5604
noahricd10a68e2015-07-10 11:27:55 -07005605 // Add a RED RTX codec.
5606 VideoCodec red_rtx_codec =
magjed509e4fe2016-11-18 01:34:11 -08005607 VideoCodec::CreateRtxCodec(kRedRtxPayloadType, GetEngineCodec("red").id);
Fredrik Solenbergb071a192015-09-17 16:42:56 +02005608 recv_parameters_.codecs.push_back(red_rtx_codec);
5609 EXPECT_TRUE(channel_->SetRecvParameters(recv_parameters_));
noahricd10a68e2015-07-10 11:27:55 -07005610
5611 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5612 const size_t kDataLength = 12;
5613 uint8_t data[kDataLength];
5614 memset(data, 0, sizeof(data));
5615
5616 rtc::Set8(data, 1, payload_type);
5617 rtc::SetBE32(&data[8], kIncomingUnsignalledSsrc);
jbaucheec21bd2016-03-20 06:15:43 -07005618 rtc::CopyOnWriteBuffer packet(data, kDataLength);
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005619 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
noahricd10a68e2015-07-10 11:27:55 -07005620
5621 if (expect_created_receive_stream) {
5622 EXPECT_EQ(1u, fake_call_->GetVideoReceiveStreams().size())
5623 << "Should have created a receive stream for payload type: "
5624 << payload_type;
5625 } else {
5626 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size())
5627 << "Shouldn't have created a receive stream for payload type: "
5628 << payload_type;
5629 }
5630}
5631
Åsa Persson2c7149b2018-10-15 09:36:10 +02005632class WebRtcVideoChannelDiscardUnknownSsrcTest : public WebRtcVideoChannelTest {
5633 public:
5634 WebRtcVideoChannelDiscardUnknownSsrcTest()
5635 : WebRtcVideoChannelTest(
5636 "WebRTC-Video-DiscardPacketsWithUnknownSsrc/Enabled/") {}
5637};
5638
5639TEST_F(WebRtcVideoChannelDiscardUnknownSsrcTest, NoUnsignalledStreamCreated) {
5640 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5641 false /* expect_created_receive_stream */);
5642}
5643
eladalonf1841382017-06-12 01:16:46 -07005644TEST_F(WebRtcVideoChannelTest, Vp8PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005645 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP8").id,
5646 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005647}
5648
eladalonf1841382017-06-12 01:16:46 -07005649TEST_F(WebRtcVideoChannelTest, Vp9PacketCreatesUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005650 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("VP9").id,
5651 true /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005652}
5653
eladalonf1841382017-06-12 01:16:46 -07005654TEST_F(WebRtcVideoChannelTest, RtxPacketDoesntCreateUnsignalledStream) {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02005655 AssignDefaultAptRtxTypes();
magjed509e4fe2016-11-18 01:34:11 -08005656 const cricket::VideoCodec vp8 = GetEngineCodec("VP8");
5657 const int rtx_vp8_payload_type = default_apt_rtx_types_[vp8.id];
5658 TestReceiveUnsignaledSsrcPacket(rtx_vp8_payload_type,
5659 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005660}
5661
eladalonf1841382017-06-12 01:16:46 -07005662TEST_F(WebRtcVideoChannelTest, UlpfecPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005663 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("ulpfec").id,
5664 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005665}
5666
eladalonf1841382017-06-12 01:16:46 -07005667TEST_F(WebRtcVideoChannelFlexfecRecvTest,
brandtr468da7c2016-11-22 02:16:47 -08005668 FlexfecPacketDoesntCreateUnsignalledStream) {
5669 TestReceiveUnsignaledSsrcPacket(GetEngineCodec("flexfec-03").id,
5670 false /* expect_created_receive_stream */);
5671}
5672
eladalonf1841382017-06-12 01:16:46 -07005673TEST_F(WebRtcVideoChannelTest, RedRtxPacketDoesntCreateUnsignalledStream) {
magjed509e4fe2016-11-18 01:34:11 -08005674 TestReceiveUnsignaledSsrcPacket(kRedRtxPayloadType,
5675 false /* expect_created_receive_stream */);
noahricd10a68e2015-07-10 11:27:55 -07005676}
5677
mzanaty8a855d62017-02-17 15:46:43 -08005678// Test that receiving any unsignalled SSRC works even if it changes.
5679// The first unsignalled SSRC received will create a default receive stream.
5680// Any different unsignalled SSRC received will replace the default.
eladalonf1841382017-06-12 01:16:46 -07005681TEST_F(WebRtcVideoChannelTest, ReceiveDifferentUnsignaledSsrc) {
mzanaty8a855d62017-02-17 15:46:43 -08005682 // Allow receiving VP8, VP9, H264 (if enabled).
5683 cricket::VideoRecvParameters parameters;
5684 parameters.codecs.push_back(GetEngineCodec("VP8"));
5685 parameters.codecs.push_back(GetEngineCodec("VP9"));
5686
5687#if defined(WEBRTC_USE_H264)
5688 cricket::VideoCodec H264codec(126, "H264");
5689 parameters.codecs.push_back(H264codec);
5690#endif
5691
5692 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
5693 // No receive streams yet.
5694 ASSERT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5695 cricket::FakeVideoRenderer renderer;
5696 EXPECT_TRUE(channel_->SetSink(kDefaultRecvSsrc, &renderer));
5697
5698 // Receive VP8 packet on first SSRC.
5699 uint8_t data[kMinRtpPacketLen];
5700 cricket::RtpHeader rtpHeader;
5701 rtpHeader.payload_type = GetEngineCodec("VP8").id;
5702 rtpHeader.seq_num = rtpHeader.timestamp = 0;
Yves Gerey665174f2018-06-19 15:03:05 +02005703 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 1;
mzanaty8a855d62017-02-17 15:46:43 -08005704 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5705 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005706 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005707 // VP8 packet should create default receive stream.
5708 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
Yves Gerey665174f2018-06-19 15:03:05 +02005709 FakeVideoReceiveStream* recv_stream = fake_call_->GetVideoReceiveStreams()[0];
mzanaty8a855d62017-02-17 15:46:43 -08005710 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5711 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005712 webrtc::VideoFrame video_frame =
5713 webrtc::VideoFrame::Builder()
5714 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5715 .set_timestamp_rtp(100)
5716 .set_timestamp_us(0)
5717 .set_rotation(webrtc::kVideoRotation_0)
5718 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005719 recv_stream->InjectFrame(video_frame);
5720 EXPECT_EQ(1, renderer.num_rendered_frames());
5721
5722 // Receive VP9 packet on second SSRC.
5723 rtpHeader.payload_type = GetEngineCodec("VP9").id;
Yves Gerey665174f2018-06-19 15:03:05 +02005724 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 2;
mzanaty8a855d62017-02-17 15:46:43 -08005725 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5726 rtc::CopyOnWriteBuffer packet2(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005727 channel_->OnPacketReceived(packet2, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005728 // VP9 packet should replace the default receive SSRC.
5729 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5730 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5731 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5732 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005733 webrtc::VideoFrame video_frame2 =
5734 webrtc::VideoFrame::Builder()
5735 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5736 .set_timestamp_rtp(200)
5737 .set_timestamp_us(0)
5738 .set_rotation(webrtc::kVideoRotation_0)
5739 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005740 recv_stream->InjectFrame(video_frame2);
5741 EXPECT_EQ(2, renderer.num_rendered_frames());
5742
5743#if defined(WEBRTC_USE_H264)
5744 // Receive H264 packet on third SSRC.
5745 rtpHeader.payload_type = 126;
Yves Gerey665174f2018-06-19 15:03:05 +02005746 rtpHeader.ssrc = kIncomingUnsignalledSsrc + 3;
mzanaty8a855d62017-02-17 15:46:43 -08005747 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
5748 rtc::CopyOnWriteBuffer packet3(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005749 channel_->OnPacketReceived(packet3, /* packet_time_us */ -1);
mzanaty8a855d62017-02-17 15:46:43 -08005750 // H264 packet should replace the default receive SSRC.
5751 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5752 recv_stream = fake_call_->GetVideoReceiveStreams()[0];
5753 EXPECT_EQ(rtpHeader.ssrc, recv_stream->GetConfig().rtp.remote_ssrc);
5754 // Verify that the receive stream sinks to a renderer.
Artem Titov1ebfb6a2019-01-03 23:49:37 +01005755 webrtc::VideoFrame video_frame3 =
5756 webrtc::VideoFrame::Builder()
5757 .set_video_frame_buffer(CreateBlackFrameBuffer(4, 4))
5758 .set_timestamp_rtp(300)
5759 .set_timestamp_us(0)
5760 .set_rotation(webrtc::kVideoRotation_0)
5761 .build();
mzanaty8a855d62017-02-17 15:46:43 -08005762 recv_stream->InjectFrame(video_frame3);
5763 EXPECT_EQ(3, renderer.num_rendered_frames());
5764#endif
5765}
5766
brandtr0dc57ea2017-05-29 23:33:31 -07005767// This test verifies that when a new default stream is created for a new
5768// unsignaled SSRC, the new stream does not overwrite any old stream that had
5769// been the default receive stream before being properly signaled.
eladalonf1841382017-06-12 01:16:46 -07005770TEST_F(WebRtcVideoChannelTest,
brandtr0dc57ea2017-05-29 23:33:31 -07005771 NewUnsignaledStreamDoesNotDestroyPreviouslyUnsignaledStream) {
5772 cricket::VideoRecvParameters parameters;
5773 parameters.codecs.push_back(GetEngineCodec("VP8"));
5774 ASSERT_TRUE(channel_->SetRecvParameters(parameters));
5775
5776 // No streams signaled and no packets received, so we should not have any
5777 // stream objects created yet.
5778 EXPECT_EQ(0u, fake_call_->GetVideoReceiveStreams().size());
5779
5780 // Receive packet on an unsignaled SSRC.
5781 uint8_t data[kMinRtpPacketLen];
5782 cricket::RtpHeader rtp_header;
5783 rtp_header.payload_type = GetEngineCodec("VP8").id;
5784 rtp_header.seq_num = rtp_header.timestamp = 0;
5785 rtp_header.ssrc = kSsrcs3[0];
5786 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5787 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005788 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005789 // Default receive stream should be created.
5790 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5791 FakeVideoReceiveStream* recv_stream0 =
5792 fake_call_->GetVideoReceiveStreams()[0];
5793 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5794
5795 // Signal the SSRC.
5796 EXPECT_TRUE(
5797 channel_->AddRecvStream(cricket::StreamParams::CreateLegacy(kSsrcs3[0])));
5798 ASSERT_EQ(1u, fake_call_->GetVideoReceiveStreams().size());
5799 recv_stream0 = fake_call_->GetVideoReceiveStreams()[0];
5800 EXPECT_EQ(kSsrcs3[0], recv_stream0->GetConfig().rtp.remote_ssrc);
5801
5802 // Receive packet on a different unsignaled SSRC.
5803 rtp_header.ssrc = kSsrcs3[1];
5804 cricket::SetRtpHeader(data, sizeof(data), rtp_header);
5805 packet.SetData(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07005806 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
brandtr0dc57ea2017-05-29 23:33:31 -07005807 // New default receive stream should be created, but old stream should remain.
5808 ASSERT_EQ(2u, fake_call_->GetVideoReceiveStreams().size());
5809 EXPECT_EQ(recv_stream0, fake_call_->GetVideoReceiveStreams()[0]);
5810 FakeVideoReceiveStream* recv_stream1 =
5811 fake_call_->GetVideoReceiveStreams()[1];
5812 EXPECT_EQ(kSsrcs3[1], recv_stream1->GetConfig().rtp.remote_ssrc);
5813}
5814
Seth Hampson7c682e02018-05-04 16:28:15 -07005815TEST_F(WebRtcVideoChannelTest, CanSetMaxBitrateForExistingStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005816 AddSendStream();
5817
Niels Möller805a27e2019-01-21 12:21:27 +01005818 webrtc::test::FrameForwarder frame_forwarder;
5819 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
skvladdc1c62c2016-03-16 19:07:43 -07005820 EXPECT_TRUE(channel_->SetSend(true));
Niels Möller805a27e2019-01-21 12:21:27 +01005821 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
skvladdc1c62c2016-03-16 19:07:43 -07005822
perkjfa10b552016-10-02 23:45:26 -07005823 int default_encoder_bitrate = GetMaxEncoderBitrate();
brandtr468da7c2016-11-22 02:16:47 -08005824 EXPECT_GT(default_encoder_bitrate, 1000);
skvladdc1c62c2016-03-16 19:07:43 -07005825
5826 // TODO(skvlad): Resolve the inconsistency between the interpretation
5827 // of the global bitrate limit for audio and video:
5828 // - Audio: max_bandwidth_bps = 0 - fail the operation,
5829 // max_bandwidth_bps = -1 - remove the bandwidth limit
5830 // - Video: max_bandwidth_bps = 0 - remove the bandwidth limit,
pbos5c7760a2017-03-10 11:23:12 -08005831 // max_bandwidth_bps = -1 - remove the bandwidth limit
skvladdc1c62c2016-03-16 19:07:43 -07005832
perkjfa10b552016-10-02 23:45:26 -07005833 SetAndExpectMaxBitrate(1000, 0, 1000);
5834 SetAndExpectMaxBitrate(1000, 800, 800);
5835 SetAndExpectMaxBitrate(600, 800, 600);
5836 SetAndExpectMaxBitrate(0, 800, 800);
5837 SetAndExpectMaxBitrate(0, 0, default_encoder_bitrate);
skvladdc1c62c2016-03-16 19:07:43 -07005838
Niels Möllerff40b142018-04-09 08:49:14 +02005839 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
skvladdc1c62c2016-03-16 19:07:43 -07005840}
5841
eladalonf1841382017-06-12 01:16:46 -07005842TEST_F(WebRtcVideoChannelTest, CannotSetMaxBitrateForNonexistentStream) {
skvladdc1c62c2016-03-16 19:07:43 -07005843 webrtc::RtpParameters nonexistent_parameters =
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005844 channel_->GetRtpSendParameters(last_ssrc_);
Mirko Bonadeif859e552018-05-30 15:31:29 +02005845 EXPECT_EQ(0u, nonexistent_parameters.encodings.size());
skvladdc1c62c2016-03-16 19:07:43 -07005846
5847 nonexistent_parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005848 EXPECT_FALSE(
Zach Steinba37b4b2018-01-23 15:02:36 -08005849 channel_->SetRtpSendParameters(last_ssrc_, nonexistent_parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07005850}
5851
eladalonf1841382017-06-12 01:16:46 -07005852TEST_F(WebRtcVideoChannelTest,
Seth Hampson7c682e02018-05-04 16:28:15 -07005853 SetLowMaxBitrateOverwritesVideoStreamMinBitrate) {
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005854 FakeVideoSendStream* stream = AddSendStream();
5855
Seth Hampson7c682e02018-05-04 16:28:15 -07005856 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5857 EXPECT_EQ(1UL, parameters.encodings.size());
5858 EXPECT_FALSE(parameters.encodings[0].max_bitrate_bps.has_value());
5859 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5860
5861 // Note that this is testing the behavior of the FakeVideoSendStream, which
5862 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5863 // we are just testing the behavior of
5864 // EncoderStreamFactory::CreateEncoderStreams.
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005865 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02005866 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
5867 stream->GetVideoStreams()[0].min_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005868
5869 // Set a low max bitrate & check that VideoStream.min_bitrate_bps is limited
5870 // by this amount.
5871 parameters = channel_->GetRtpSendParameters(last_ssrc_);
Elad Alon80f53b72019-10-11 16:19:43 +02005872 int low_max_bitrate_bps = webrtc::kDefaultMinVideoBitrateBps - 1000;
Seth Hampson7c682e02018-05-04 16:28:15 -07005873 parameters.encodings[0].max_bitrate_bps = low_max_bitrate_bps;
5874 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5875
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005876 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5877 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5878 EXPECT_EQ(low_max_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5879}
5880
5881TEST_F(WebRtcVideoChannelTest,
5882 SetHighMinBitrateOverwritesVideoStreamMaxBitrate) {
5883 FakeVideoSendStream* stream = AddSendStream();
5884
5885 // Note that this is testing the behavior of the FakeVideoSendStream, which
5886 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5887 // we are just testing the behavior of
5888 // EncoderStreamFactory::CreateEncoderStreams.
5889 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5890 int high_min_bitrate_bps = stream->GetVideoStreams()[0].max_bitrate_bps + 1;
5891
5892 // Set a high min bitrate and check that max_bitrate_bps is adjusted up.
5893 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5894 EXPECT_EQ(1UL, parameters.encodings.size());
5895 parameters.encodings[0].min_bitrate_bps = high_min_bitrate_bps;
5896 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5897
5898 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5899 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].min_bitrate_bps);
5900 EXPECT_EQ(high_min_bitrate_bps, stream->GetVideoStreams()[0].max_bitrate_bps);
5901}
5902
5903TEST_F(WebRtcVideoChannelTest,
5904 SetMinBitrateAboveMaxBitrateLimitAdjustsMinBitrateDown) {
5905 send_parameters_.max_bandwidth_bps = 99999;
5906 FakeVideoSendStream* stream = AddSendStream();
5907 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
5908 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
5909 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02005910 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
5911 stream->GetVideoStreams()[0].min_bitrate_bps);
Åsa Perssonbdee46d2018-06-25 11:28:06 +02005912 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5913 stream->GetVideoStreams()[0].max_bitrate_bps);
5914
5915 // Set min bitrate above global max bitrate and check that min_bitrate_bps is
5916 // adjusted down.
5917 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5918 EXPECT_EQ(1UL, parameters.encodings.size());
5919 parameters.encodings[0].min_bitrate_bps = 99999 + 1;
5920 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5921 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5922 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5923 stream->GetVideoStreams()[0].min_bitrate_bps);
5924 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
5925 stream->GetVideoStreams()[0].max_bitrate_bps);
Seth Hampson7c682e02018-05-04 16:28:15 -07005926}
5927
Åsa Persson8c1bf952018-09-13 10:42:19 +02005928TEST_F(WebRtcVideoChannelTest, SetMaxFramerateOneStream) {
5929 FakeVideoSendStream* stream = AddSendStream();
5930
5931 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5932 EXPECT_EQ(1UL, parameters.encodings.size());
5933 EXPECT_FALSE(parameters.encodings[0].max_framerate.has_value());
5934 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5935
5936 // Note that this is testing the behavior of the FakeVideoSendStream, which
5937 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5938 // we are just testing the behavior of
5939 // EncoderStreamFactory::CreateEncoderStreams.
5940 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5941 EXPECT_EQ(kDefaultVideoMaxFramerate,
5942 stream->GetVideoStreams()[0].max_framerate);
5943
5944 // Set max framerate and check that VideoStream.max_framerate is set.
5945 const int kNewMaxFramerate = kDefaultVideoMaxFramerate - 1;
5946 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5947 parameters.encodings[0].max_framerate = kNewMaxFramerate;
5948 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5949
5950 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5951 EXPECT_EQ(kNewMaxFramerate, stream->GetVideoStreams()[0].max_framerate);
5952}
5953
Åsa Persson23eba222018-10-02 14:47:06 +02005954TEST_F(WebRtcVideoChannelTest, SetNumTemporalLayersForSingleStream) {
5955 FakeVideoSendStream* stream = AddSendStream();
5956
5957 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5958 EXPECT_EQ(1UL, parameters.encodings.size());
5959 EXPECT_FALSE(parameters.encodings[0].num_temporal_layers.has_value());
5960 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5961
5962 // Note that this is testing the behavior of the FakeVideoSendStream, which
5963 // also calls to CreateEncoderStreams to get the VideoStreams, so essentially
5964 // we are just testing the behavior of
5965 // EncoderStreamFactory::CreateEncoderStreams.
5966 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5967 EXPECT_FALSE(stream->GetVideoStreams()[0].num_temporal_layers.has_value());
5968
5969 // Set temporal layers and check that VideoStream.num_temporal_layers is set.
5970 parameters = channel_->GetRtpSendParameters(last_ssrc_);
5971 parameters.encodings[0].num_temporal_layers = 2;
5972 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
5973
5974 ASSERT_EQ(1UL, stream->GetVideoStreams().size());
5975 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
5976}
5977
Seth Hampson7c682e02018-05-04 16:28:15 -07005978TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005979 CannotSetRtpSendParametersWithIncorrectNumberOfEncodings) {
skvladdc1c62c2016-03-16 19:07:43 -07005980 AddSendStream();
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07005981 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
skvladdc1c62c2016-03-16 19:07:43 -07005982 // Two or more encodings should result in failure.
5983 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08005984 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005985 // Zero encodings should also fail.
5986 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08005987 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeeffb2aced2017-01-06 23:05:37 -08005988}
5989
Zach Stein3ca452b2018-01-18 10:01:24 -08005990TEST_F(WebRtcVideoChannelTest,
5991 CannotSetSimulcastRtpSendParametersWithIncorrectNumberOfEncodings) {
5992 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
5993 StreamParams sp = CreateSimStreamParams("cname", ssrcs);
5994 AddSendStream(sp);
5995
5996 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
5997
5998 // Additional encodings should result in failure.
5999 parameters.encodings.push_back(webrtc::RtpEncodingParameters());
Zach Steinba37b4b2018-01-23 15:02:36 -08006000 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08006001 // Zero encodings should also fail.
6002 parameters.encodings.clear();
Zach Steinba37b4b2018-01-23 15:02:36 -08006003 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Zach Stein3ca452b2018-01-18 10:01:24 -08006004}
6005
deadbeeffb2aced2017-01-06 23:05:37 -08006006// Changing the SSRC through RtpParameters is not allowed.
eladalonf1841382017-06-12 01:16:46 -07006007TEST_F(WebRtcVideoChannelTest, CannotSetSsrcInRtpSendParameters) {
deadbeeffb2aced2017-01-06 23:05:37 -08006008 AddSendStream();
6009 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
Oskar Sundbom78807582017-11-16 11:09:55 +01006010 parameters.encodings[0].ssrc = 0xdeadbeef;
Zach Steinba37b4b2018-01-23 15:02:36 -08006011 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
skvladdc1c62c2016-03-16 19:07:43 -07006012}
6013
Seth Hampson24722b32017-12-22 09:36:42 -08006014// Tests that when RTCRtpEncodingParameters.bitrate_priority gets set to
6015// a value <= 0, setting the parameters returns false.
6016TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidBitratePriority) {
6017 AddSendStream();
6018 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6019 EXPECT_EQ(1UL, parameters.encodings.size());
6020 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6021 parameters.encodings[0].bitrate_priority);
6022
6023 parameters.encodings[0].bitrate_priority = 0;
Zach Steinba37b4b2018-01-23 15:02:36 -08006024 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006025 parameters.encodings[0].bitrate_priority = -2;
Zach Steinba37b4b2018-01-23 15:02:36 -08006026 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006027}
6028
6029// Tests when the the RTCRtpEncodingParameters.bitrate_priority gets set
6030// properly on the VideoChannel and propogates down to the video encoder.
6031TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPriorityOneStream) {
6032 AddSendStream();
6033 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6034 EXPECT_EQ(1UL, parameters.encodings.size());
6035 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6036 parameters.encodings[0].bitrate_priority);
6037
6038 // Change the value and set it on the VideoChannel.
6039 double new_bitrate_priority = 2.0;
6040 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08006041 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006042
6043 // Verify that the encoding parameters bitrate_priority is set for the
6044 // VideoChannel.
6045 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6046 EXPECT_EQ(1UL, parameters.encodings.size());
6047 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
6048
6049 // Verify that the new value propagated down to the encoder.
6050 std::vector<FakeVideoSendStream*> video_send_streams =
6051 fake_call_->GetVideoSendStreams();
6052 EXPECT_EQ(1UL, video_send_streams.size());
6053 FakeVideoSendStream* video_send_stream = video_send_streams.front();
6054 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6055 // appropriately.
6056 EXPECT_EQ(new_bitrate_priority,
6057 video_send_stream->GetEncoderConfig().bitrate_priority);
6058 // Check that the vector of VideoStreams also was propagated correctly. Note
6059 // that this is testing the behavior of the FakeVideoSendStream, which mimics
6060 // the calls to CreateEncoderStreams to get the VideoStreams.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006061 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006062 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6063}
6064
6065// Tests that the RTCRtpEncodingParameters.bitrate_priority is set for the
6066// VideoChannel and the value propogates to the video encoder with all simulcast
6067// streams.
6068TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersPrioritySimulcastStreams) {
6069 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006070 const size_t kNumSimulcastStreams = 3;
Seth Hampson24722b32017-12-22 09:36:42 -08006071 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
6072 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
6073 AddSendStream(stream_params);
6074 uint32_t primary_ssrc = stream_params.first_ssrc();
6075
Niels Möller805a27e2019-01-21 12:21:27 +01006076 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01006077 // frame. This creates multiple VideoStreams for all simulcast layers when
6078 // reconfiguring, and allows us to test this behavior.
Niels Möller805a27e2019-01-21 12:21:27 +01006079 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson24722b32017-12-22 09:36:42 -08006080 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006081 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson24722b32017-12-22 09:36:42 -08006082 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006083 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
6084 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
6085 rtc::kNumMicrosecsPerSec / 30));
6086
Seth Hampson24722b32017-12-22 09:36:42 -08006087 // Get and set the rtp encoding parameters.
6088 webrtc::RtpParameters parameters =
6089 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006090 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006091 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6092 parameters.encodings[0].bitrate_priority);
6093 // Change the value and set it on the VideoChannel.
6094 double new_bitrate_priority = 2.0;
6095 parameters.encodings[0].bitrate_priority = new_bitrate_priority;
Zach Steinba37b4b2018-01-23 15:02:36 -08006096 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
Seth Hampson24722b32017-12-22 09:36:42 -08006097
6098 // Verify that the encoding parameters priority is set on the VideoChannel.
6099 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02006100 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson24722b32017-12-22 09:36:42 -08006101 EXPECT_EQ(new_bitrate_priority, parameters.encodings[0].bitrate_priority);
6102
6103 // Verify that the new value propagated down to the encoder.
6104 std::vector<FakeVideoSendStream*> video_send_streams =
6105 fake_call_->GetVideoSendStreams();
6106 EXPECT_EQ(1UL, video_send_streams.size());
6107 FakeVideoSendStream* video_send_stream = video_send_streams.front();
6108 // Check that the WebRtcVideoSendStream updated the VideoEncoderConfig
6109 // appropriately.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006110 EXPECT_EQ(kNumSimulcastStreams,
Seth Hampson24722b32017-12-22 09:36:42 -08006111 video_send_stream->GetEncoderConfig().number_of_streams);
6112 EXPECT_EQ(new_bitrate_priority,
6113 video_send_stream->GetEncoderConfig().bitrate_priority);
6114 // Check that the vector of VideoStreams also propagated correctly. The
6115 // FakeVideoSendStream calls CreateEncoderStreams, and we are testing that
6116 // these are created appropriately for the simulcast case.
Åsa Persson31cb8f92018-06-27 10:44:56 +02006117 EXPECT_EQ(kNumSimulcastStreams, video_send_stream->GetVideoStreams().size());
Danil Chapovalov00c71832018-06-15 15:58:38 +02006118 EXPECT_EQ(absl::optional<double>(new_bitrate_priority),
Seth Hampson24722b32017-12-22 09:36:42 -08006119 video_send_stream->GetVideoStreams()[0].bitrate_priority);
6120 // Since we are only setting bitrate priority per-sender, the other
6121 // VideoStreams should have a bitrate priority of 0.
Danil Chapovalov00c71832018-06-15 15:58:38 +02006122 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006123 video_send_stream->GetVideoStreams()[1].bitrate_priority);
Danil Chapovalov00c71832018-06-15 15:58:38 +02006124 EXPECT_EQ(absl::nullopt,
Seth Hampson24722b32017-12-22 09:36:42 -08006125 video_send_stream->GetVideoStreams()[2].bitrate_priority);
Niels Möllerff40b142018-04-09 08:49:14 +02006126 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson24722b32017-12-22 09:36:42 -08006127}
6128
Tim Haloun648d28a2018-10-18 16:52:22 -07006129// RTCRtpEncodingParameters.network_priority must be one of a few values
6130// derived from the default priority, corresponding to very-low, low, medium,
6131// or high.
6132TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersInvalidNetworkPriority) {
6133 AddSendStream();
6134 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6135 EXPECT_EQ(1UL, parameters.encodings.size());
6136 EXPECT_EQ(webrtc::kDefaultBitratePriority,
6137 parameters.encodings[0].network_priority);
6138
6139 double good_values[] = {0.5, 1.0, 2.0, 4.0};
6140 double bad_values[] = {-1.0, 0.0, 0.49, 0.51, 1.1, 3.99, 4.1, 5.0};
6141 for (auto it : good_values) {
6142 parameters.encodings[0].network_priority = it;
6143 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6144 }
6145 for (auto it : bad_values) {
6146 parameters.encodings[0].network_priority = it;
6147 EXPECT_FALSE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6148 }
6149}
6150
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006151TEST_F(WebRtcVideoChannelTest,
6152 GetAndSetRtpSendParametersScaleResolutionDownByVP8) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006153 VideoSendParameters parameters;
6154 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006155 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6156 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6157
6158 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006159 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006160
6161 VideoOptions options;
6162 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6163 channel_->SetSend(true);
6164
6165 // Try layers in natural order (smallest to largest).
6166 {
6167 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6168 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6169 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6170 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6171 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6172 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6173 ASSERT_TRUE(result.ok());
6174
6175 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6176
6177 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6178 ASSERT_EQ(3u, video_streams.size());
6179 EXPECT_EQ(320u, video_streams[0].width);
6180 EXPECT_EQ(180u, video_streams[0].height);
6181 EXPECT_EQ(640u, video_streams[1].width);
6182 EXPECT_EQ(360u, video_streams[1].height);
6183 EXPECT_EQ(1280u, video_streams[2].width);
6184 EXPECT_EQ(720u, video_streams[2].height);
6185 }
6186
6187 // Try layers in reverse natural order (largest to smallest).
6188 {
6189 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6190 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6191 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6192 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6193 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6194 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6195 ASSERT_TRUE(result.ok());
6196
6197 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6198
6199 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6200 ASSERT_EQ(3u, video_streams.size());
6201 EXPECT_EQ(1280u, video_streams[0].width);
6202 EXPECT_EQ(720u, video_streams[0].height);
6203 EXPECT_EQ(640u, video_streams[1].width);
6204 EXPECT_EQ(360u, video_streams[1].height);
6205 EXPECT_EQ(320u, video_streams[2].width);
6206 EXPECT_EQ(180u, video_streams[2].height);
6207 }
6208
6209 // Try layers in mixed order.
6210 {
6211 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6212 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6213 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6214 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6215 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6216 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6217 ASSERT_TRUE(result.ok());
6218
6219 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6220
6221 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6222 ASSERT_EQ(3u, video_streams.size());
6223 EXPECT_EQ(128u, video_streams[0].width);
6224 EXPECT_EQ(72u, video_streams[0].height);
6225 EXPECT_EQ(640u, video_streams[1].width);
6226 EXPECT_EQ(360u, video_streams[1].height);
6227 EXPECT_EQ(320u, video_streams[2].width);
6228 EXPECT_EQ(180u, video_streams[2].height);
6229 }
6230
6231 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6232 {
6233 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6234 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6235 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6236 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6237 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6238 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6239 ASSERT_TRUE(result.ok());
6240
6241 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6242
6243 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6244 ASSERT_EQ(3u, video_streams.size());
6245 EXPECT_EQ(1280u, video_streams[0].width);
6246 EXPECT_EQ(720u, video_streams[0].height);
6247 EXPECT_EQ(1280u, video_streams[1].width);
6248 EXPECT_EQ(720u, video_streams[1].height);
6249 EXPECT_EQ(320u, video_streams[2].width);
6250 EXPECT_EQ(180u, video_streams[2].height);
6251 }
6252
6253 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6254}
6255
6256TEST_F(WebRtcVideoChannelTest,
Rasmus Brandt9387b522019-02-05 14:23:26 +01006257 GetAndSetRtpSendParametersScaleResolutionDownByVP8WithOddResolution) {
6258 // Ensure that the top layer has width and height divisible by 2^3,
6259 // so that the bottom layer has width and height divisible by 2.
6260 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6261 // the number of simulcast layers set by the app.
6262 webrtc::test::ScopedFieldTrials field_trial(
6263 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6264
6265 // Set up WebRtcVideoChannel for 3-layer VP8 simulcast.
6266 VideoSendParameters parameters;
6267 parameters.codecs.push_back(VideoCodec(kVp8CodecName));
6268 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6269 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6270 webrtc::test::FrameForwarder frame_forwarder;
6271 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6272 &frame_forwarder));
6273 channel_->SetSend(true);
6274
6275 // Set |scale_resolution_down_by|'s.
6276 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6277 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6278 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6279 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6280 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6281 const auto result =
6282 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6283 ASSERT_TRUE(result.ok());
6284
6285 // Use a capture resolution whose width and height are not divisible by 2^3.
6286 // (See field trial set at the top of the test.)
6287 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6288 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6289
6290 // Ensure the scaling is correct.
6291 const auto video_streams = stream->GetVideoStreams();
6292 ASSERT_EQ(video_streams.size(), 3u);
6293 // Ensure that we round the capture resolution down for the top layer...
6294 EXPECT_EQ(video_streams[0].width, 2000u);
6295 EXPECT_EQ(video_streams[0].height, 1200u);
6296 EXPECT_EQ(video_streams[1].width, 1000u);
6297 EXPECT_EQ(video_streams[1].height, 600u);
6298 // ...and that the bottom layer has a width/height divisible by 2.
6299 EXPECT_EQ(video_streams[2].width, 500u);
6300 EXPECT_EQ(video_streams[2].height, 300u);
6301
6302 // Tear down.
6303 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6304}
6305
6306TEST_F(WebRtcVideoChannelTest,
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006307 GetAndSetRtpSendParametersScaleResolutionDownByH264) {
Rasmus Brandt9387b522019-02-05 14:23:26 +01006308 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6309 VideoSendParameters parameters;
6310 parameters.codecs.push_back(VideoCodec(kH264CodecName));
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006311 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6312 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6313
6314 webrtc::test::FrameForwarder frame_forwarder;
Rasmus Brandt9387b522019-02-05 14:23:26 +01006315 FakeFrameSource frame_source(1280, 720, rtc::kNumMicrosecsPerSec / 30);
Florent Castellic1a0bcb2019-01-29 14:26:48 +01006316
6317 VideoOptions options;
6318 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
6319 channel_->SetSend(true);
6320
6321 // Try layers in natural order (smallest to largest).
6322 {
6323 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6324 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6325 rtp_parameters.encodings[0].scale_resolution_down_by = 4.0;
6326 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6327 rtp_parameters.encodings[2].scale_resolution_down_by = 1.0;
6328 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6329 ASSERT_TRUE(result.ok());
6330
6331 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6332
6333 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6334 ASSERT_EQ(3u, video_streams.size());
6335 EXPECT_EQ(320u, video_streams[0].width);
6336 EXPECT_EQ(180u, video_streams[0].height);
6337 EXPECT_EQ(640u, video_streams[1].width);
6338 EXPECT_EQ(360u, video_streams[1].height);
6339 EXPECT_EQ(1280u, video_streams[2].width);
6340 EXPECT_EQ(720u, video_streams[2].height);
6341 }
6342
6343 // Try layers in reverse natural order (largest to smallest).
6344 {
6345 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6346 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6347 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6348 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6349 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6350 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6351 ASSERT_TRUE(result.ok());
6352
6353 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6354
6355 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6356 ASSERT_EQ(3u, video_streams.size());
6357 EXPECT_EQ(1280u, video_streams[0].width);
6358 EXPECT_EQ(720u, video_streams[0].height);
6359 EXPECT_EQ(640u, video_streams[1].width);
6360 EXPECT_EQ(360u, video_streams[1].height);
6361 EXPECT_EQ(320u, video_streams[2].width);
6362 EXPECT_EQ(180u, video_streams[2].height);
6363 }
6364
6365 // Try layers in mixed order.
6366 {
6367 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6368 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6369 rtp_parameters.encodings[0].scale_resolution_down_by = 10.0;
6370 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6371 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6372 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6373 ASSERT_TRUE(result.ok());
6374
6375 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6376
6377 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6378 ASSERT_EQ(3u, video_streams.size());
6379 EXPECT_EQ(128u, video_streams[0].width);
6380 EXPECT_EQ(72u, video_streams[0].height);
6381 EXPECT_EQ(640u, video_streams[1].width);
6382 EXPECT_EQ(360u, video_streams[1].height);
6383 EXPECT_EQ(320u, video_streams[2].width);
6384 EXPECT_EQ(180u, video_streams[2].height);
6385 }
6386
6387 // Try with a missing scale setting, defaults to 1.0 if any other is set.
6388 {
6389 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6390 ASSERT_EQ(3u, rtp_parameters.encodings.size());
6391 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6392 rtp_parameters.encodings[1].scale_resolution_down_by.reset();
6393 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6394 auto result = channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6395 ASSERT_TRUE(result.ok());
6396
6397 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6398
6399 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
6400 ASSERT_EQ(3u, video_streams.size());
6401 EXPECT_EQ(1280u, video_streams[0].width);
6402 EXPECT_EQ(720u, video_streams[0].height);
6403 EXPECT_EQ(1280u, video_streams[1].width);
6404 EXPECT_EQ(720u, video_streams[1].height);
6405 EXPECT_EQ(320u, video_streams[2].width);
6406 EXPECT_EQ(180u, video_streams[2].height);
6407 }
6408 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6409}
6410
Rasmus Brandt9387b522019-02-05 14:23:26 +01006411TEST_F(WebRtcVideoChannelTest,
6412 GetAndSetRtpSendParametersScaleResolutionDownByH264WithOddResolution) {
6413 // Ensure that the top layer has width and height divisible by 2^3,
6414 // so that the bottom layer has width and height divisible by 2.
6415 // TODO(bugs.webrtc.org/8785): Remove this field trial when we fully trust
6416 // the number of simulcast layers set by the app.
6417 webrtc::test::ScopedFieldTrials field_trial(
6418 "WebRTC-NormalizeSimulcastResolution/Enabled-3/");
6419
6420 // Set up WebRtcVideoChannel for 3-layer H264 simulcast.
6421 encoder_factory_->AddSupportedVideoCodecType(kH264CodecName);
6422 VideoSendParameters parameters;
6423 parameters.codecs.push_back(VideoCodec(kH264CodecName));
6424 ASSERT_TRUE(channel_->SetSendParameters(parameters));
6425 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6426 webrtc::test::FrameForwarder frame_forwarder;
6427 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, /*options=*/nullptr,
6428 &frame_forwarder));
6429 channel_->SetSend(true);
6430
6431 // Set |scale_resolution_down_by|'s.
6432 auto rtp_parameters = channel_->GetRtpSendParameters(last_ssrc_);
6433 ASSERT_EQ(rtp_parameters.encodings.size(), 3u);
6434 rtp_parameters.encodings[0].scale_resolution_down_by = 1.0;
6435 rtp_parameters.encodings[1].scale_resolution_down_by = 2.0;
6436 rtp_parameters.encodings[2].scale_resolution_down_by = 4.0;
6437 const auto result =
6438 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
6439 ASSERT_TRUE(result.ok());
6440
6441 // Use a capture resolution whose width and height are not divisible by 2^3.
6442 // (See field trial set at the top of the test.)
6443 FakeFrameSource frame_source(2007, 1207, rtc::kNumMicrosecsPerSec / 30);
6444 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
6445
6446 // Ensure the scaling is correct.
6447 const auto video_streams = stream->GetVideoStreams();
6448 ASSERT_EQ(video_streams.size(), 3u);
6449 // Ensure that we round the capture resolution down for the top layer...
6450 EXPECT_EQ(video_streams[0].width, 2000u);
6451 EXPECT_EQ(video_streams[0].height, 1200u);
6452 EXPECT_EQ(video_streams[1].width, 1000u);
6453 EXPECT_EQ(video_streams[1].height, 600u);
6454 // ...and that the bottom layer has a width/height divisible by 2.
6455 EXPECT_EQ(video_streams[2].width, 500u);
6456 EXPECT_EQ(video_streams[2].height, 300u);
6457
6458 // Tear down.
6459 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6460}
6461
Åsa Persson8c1bf952018-09-13 10:42:19 +02006462TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMaxFramerate) {
6463 const size_t kNumSimulcastStreams = 3;
6464 SetUpSimulcast(true, false);
6465
6466 // Get and set the rtp encoding parameters.
6467 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6468 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6469 for (const auto& encoding : parameters.encodings) {
6470 EXPECT_FALSE(encoding.max_framerate);
6471 }
6472
6473 // Change the value and set it on the VideoChannel.
6474 parameters.encodings[0].max_framerate = 10;
6475 parameters.encodings[1].max_framerate = 20;
6476 parameters.encodings[2].max_framerate = 25;
6477 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6478
6479 // Verify that the bitrates are set on the VideoChannel.
6480 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6481 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6482 EXPECT_EQ(10, parameters.encodings[0].max_framerate);
6483 EXPECT_EQ(20, parameters.encodings[1].max_framerate);
6484 EXPECT_EQ(25, parameters.encodings[2].max_framerate);
6485}
6486
Åsa Persson23eba222018-10-02 14:47:06 +02006487TEST_F(WebRtcVideoChannelTest,
6488 SetRtpSendParametersNumTemporalLayersFailsForInvalidRange) {
6489 const size_t kNumSimulcastStreams = 3;
6490 SetUpSimulcast(true, false);
6491
6492 // Get and set the rtp encoding parameters.
6493 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6494 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6495
6496 // Num temporal layers should be in the range [1, kMaxTemporalStreams].
6497 parameters.encodings[0].num_temporal_layers = 0;
6498 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6499 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6500 parameters.encodings[0].num_temporal_layers = webrtc::kMaxTemporalStreams + 1;
6501 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6502 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6503}
6504
6505TEST_F(WebRtcVideoChannelTest,
6506 SetRtpSendParametersNumTemporalLayersFailsForInvalidModification) {
6507 const size_t kNumSimulcastStreams = 3;
6508 SetUpSimulcast(true, false);
6509
6510 // Get and set the rtp encoding parameters.
6511 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6512 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6513
6514 // No/all layers should be set.
6515 parameters.encodings[0].num_temporal_layers = 1;
6516 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6517 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6518
6519 // Different values not supported.
6520 parameters.encodings[0].num_temporal_layers = 1;
6521 parameters.encodings[1].num_temporal_layers = 2;
6522 parameters.encodings[2].num_temporal_layers = 2;
6523 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION,
6524 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6525}
6526
6527TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersNumTemporalLayers) {
6528 const size_t kNumSimulcastStreams = 3;
6529 SetUpSimulcast(true, false);
6530
6531 // Get and set the rtp encoding parameters.
6532 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6533 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6534 for (const auto& encoding : parameters.encodings)
6535 EXPECT_FALSE(encoding.num_temporal_layers);
6536
6537 // Change the value and set it on the VideoChannel.
6538 parameters.encodings[0].num_temporal_layers = 3;
6539 parameters.encodings[1].num_temporal_layers = 3;
6540 parameters.encodings[2].num_temporal_layers = 3;
6541 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6542
6543 // Verify that the number of temporal layers are set on the VideoChannel.
6544 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6545 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6546 EXPECT_EQ(3, parameters.encodings[0].num_temporal_layers);
6547 EXPECT_EQ(3, parameters.encodings[1].num_temporal_layers);
6548 EXPECT_EQ(3, parameters.encodings[2].num_temporal_layers);
6549}
6550
6551TEST_F(WebRtcVideoChannelTest, NumTemporalLayersPropagatedToEncoder) {
6552 const size_t kNumSimulcastStreams = 3;
6553 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6554
6555 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006556 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006557 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006558 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006559 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006560 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006561
6562 // Get and set the rtp encoding parameters.
6563 // Change the value and set it on the VideoChannel.
6564 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6565 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6566 parameters.encodings[0].num_temporal_layers = 2;
6567 parameters.encodings[1].num_temporal_layers = 2;
6568 parameters.encodings[2].num_temporal_layers = 2;
6569 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6570
6571 // Verify that the new value is propagated down to the encoder.
6572 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6573 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6574 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6575 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6576 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6577 EXPECT_EQ(2UL, encoder_config.simulcast_layers[0].num_temporal_layers);
6578 EXPECT_EQ(2UL, encoder_config.simulcast_layers[1].num_temporal_layers);
6579 EXPECT_EQ(2UL, encoder_config.simulcast_layers[2].num_temporal_layers);
6580
6581 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6582 // VideoStreams are created appropriately for the simulcast case.
6583 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6584 EXPECT_EQ(2UL, stream->GetVideoStreams()[0].num_temporal_layers);
6585 EXPECT_EQ(2UL, stream->GetVideoStreams()[1].num_temporal_layers);
6586 EXPECT_EQ(2UL, stream->GetVideoStreams()[2].num_temporal_layers);
6587
6588 // No parameter changed, encoder should not be reconfigured.
6589 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6590 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6591
6592 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6593}
6594
6595TEST_F(WebRtcVideoChannelTest,
6596 DefaultValuePropagatedToEncoderForUnsetNumTemporalLayers) {
6597 const size_t kDefaultNumTemporalLayers = 3;
6598 const size_t kNumSimulcastStreams = 3;
6599 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6600
6601 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006602 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson23eba222018-10-02 14:47:06 +02006603 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006604 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson23eba222018-10-02 14:47:06 +02006605 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006606 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson23eba222018-10-02 14:47:06 +02006607
6608 // Change rtp encoding parameters, num_temporal_layers not changed.
6609 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6610 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6611 parameters.encodings[0].min_bitrate_bps = 33000;
6612 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6613
6614 // Verify that no value is propagated down to the encoder.
6615 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6616 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6617 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6618 EXPECT_FALSE(encoder_config.simulcast_layers[0].num_temporal_layers);
6619 EXPECT_FALSE(encoder_config.simulcast_layers[1].num_temporal_layers);
6620 EXPECT_FALSE(encoder_config.simulcast_layers[2].num_temporal_layers);
6621
6622 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6623 // VideoStreams are created appropriately for the simulcast case.
6624 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6625 EXPECT_EQ(kDefaultNumTemporalLayers,
6626 stream->GetVideoStreams()[0].num_temporal_layers);
6627 EXPECT_EQ(kDefaultNumTemporalLayers,
6628 stream->GetVideoStreams()[1].num_temporal_layers);
6629 EXPECT_EQ(kDefaultNumTemporalLayers,
6630 stream->GetVideoStreams()[2].num_temporal_layers);
6631
6632 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6633}
6634
Åsa Persson8c1bf952018-09-13 10:42:19 +02006635TEST_F(WebRtcVideoChannelTest, MaxSimulcastFrameratePropagatedToEncoder) {
6636 const size_t kNumSimulcastStreams = 3;
6637 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6638
6639 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006640 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006641 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006642 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006643 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006644 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006645
6646 // Get and set the rtp encoding parameters.
6647 // Change the value and set it on the VideoChannel.
6648 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6649 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6650 parameters.encodings[0].max_framerate = 15;
6651 parameters.encodings[1].max_framerate = 25;
6652 parameters.encodings[2].max_framerate = 20;
6653 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6654
6655 // Verify that the new value propagated down to the encoder.
6656 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6657 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6658 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6659 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6660 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6661 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6662 EXPECT_EQ(25, encoder_config.simulcast_layers[1].max_framerate);
6663 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6664
6665 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6666 // VideoStreams are created appropriately for the simulcast case.
6667 // Currently the maximum |max_framerate| is used.
6668 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6669 EXPECT_EQ(25, stream->GetVideoStreams()[0].max_framerate);
6670 EXPECT_EQ(25, stream->GetVideoStreams()[1].max_framerate);
6671 EXPECT_EQ(25, stream->GetVideoStreams()[2].max_framerate);
6672
6673 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6674}
6675
6676TEST_F(WebRtcVideoChannelTest,
6677 DefaultValuePropagatedToEncoderForUnsetFramerate) {
6678 const size_t kNumSimulcastStreams = 3;
6679 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6680 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6681
6682 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006683 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson8c1bf952018-09-13 10:42:19 +02006684 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006685 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson8c1bf952018-09-13 10:42:19 +02006686 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006687 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson8c1bf952018-09-13 10:42:19 +02006688
6689 // Get and set the rtp encoding parameters.
6690 // Change the value and set it on the VideoChannel.
6691 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6692 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6693 parameters.encodings[0].max_framerate = 15;
6694 parameters.encodings[2].max_framerate = 20;
6695 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6696
6697 // Verify that the new value propagated down to the encoder.
6698 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6699 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6700 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6701 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6702 EXPECT_EQ(15, encoder_config.simulcast_layers[0].max_framerate);
6703 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].max_framerate);
6704 EXPECT_EQ(20, encoder_config.simulcast_layers[2].max_framerate);
6705
6706 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6707 // VideoStreams are created appropriately for the simulcast case.
6708 // The maximum |max_framerate| is used, kDefaultVideoMaxFramerate: 60.
6709 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6710 EXPECT_EQ(kDefaultVideoMaxFramerate,
6711 stream->GetVideoStreams()[0].max_framerate);
6712 EXPECT_EQ(kDefaultVideoMaxFramerate,
6713 stream->GetVideoStreams()[1].max_framerate);
6714 EXPECT_EQ(kDefaultVideoMaxFramerate,
6715 stream->GetVideoStreams()[2].max_framerate);
6716
6717 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6718}
6719
Åsa Persson55659812018-06-18 17:51:32 +02006720TEST_F(WebRtcVideoChannelTest, GetAndSetRtpSendParametersMinAndMaxBitrate) {
6721 const size_t kNumSimulcastStreams = 3;
6722 SetUpSimulcast(true, false);
6723
6724 // Get and set the rtp encoding parameters.
6725 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6726 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6727 for (const auto& encoding : parameters.encodings) {
6728 EXPECT_FALSE(encoding.min_bitrate_bps);
6729 EXPECT_FALSE(encoding.max_bitrate_bps);
6730 }
6731
6732 // Change the value and set it on the VideoChannel.
6733 parameters.encodings[0].min_bitrate_bps = 100000;
6734 parameters.encodings[0].max_bitrate_bps = 200000;
6735 parameters.encodings[1].min_bitrate_bps = 300000;
6736 parameters.encodings[1].max_bitrate_bps = 400000;
6737 parameters.encodings[2].min_bitrate_bps = 500000;
6738 parameters.encodings[2].max_bitrate_bps = 600000;
6739 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6740
6741 // Verify that the bitrates are set on the VideoChannel.
6742 parameters = channel_->GetRtpSendParameters(last_ssrc_);
6743 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6744 EXPECT_EQ(100000, parameters.encodings[0].min_bitrate_bps);
6745 EXPECT_EQ(200000, parameters.encodings[0].max_bitrate_bps);
6746 EXPECT_EQ(300000, parameters.encodings[1].min_bitrate_bps);
6747 EXPECT_EQ(400000, parameters.encodings[1].max_bitrate_bps);
6748 EXPECT_EQ(500000, parameters.encodings[2].min_bitrate_bps);
6749 EXPECT_EQ(600000, parameters.encodings[2].max_bitrate_bps);
6750}
6751
6752TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersFailsWithIncorrectBitrate) {
6753 const size_t kNumSimulcastStreams = 3;
6754 SetUpSimulcast(true, false);
6755
6756 // Get and set the rtp encoding parameters.
6757 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6758 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6759
6760 // Max bitrate lower than min bitrate should fail.
6761 parameters.encodings[2].min_bitrate_bps = 100000;
6762 parameters.encodings[2].max_bitrate_bps = 100000 - 1;
6763 EXPECT_EQ(webrtc::RTCErrorType::INVALID_RANGE,
6764 channel_->SetRtpSendParameters(last_ssrc_, parameters).type());
6765}
6766
6767// Test that min and max bitrate values set via RtpParameters are correctly
6768// propagated to the underlying encoder, and that the target is set to 3/4 of
6769// the maximum (3/4 was chosen because it's similar to the simulcast defaults
6770// that are used if no min/max are specified).
6771TEST_F(WebRtcVideoChannelTest, MinAndMaxSimulcastBitratePropagatedToEncoder) {
6772 const size_t kNumSimulcastStreams = 3;
6773 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6774
6775 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006776 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006777 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006778 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006779 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006780 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006781
6782 // Get and set the rtp encoding parameters.
6783 // Change the value and set it on the VideoChannel.
6784 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6785 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6786 parameters.encodings[0].min_bitrate_bps = 100000;
6787 parameters.encodings[0].max_bitrate_bps = 200000;
6788 parameters.encodings[1].min_bitrate_bps = 300000;
6789 parameters.encodings[1].max_bitrate_bps = 400000;
6790 parameters.encodings[2].min_bitrate_bps = 500000;
6791 parameters.encodings[2].max_bitrate_bps = 600000;
6792 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6793
6794 // Verify that the new value propagated down to the encoder.
6795 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6796 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6797 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6798 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6799 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6800 EXPECT_EQ(100000, encoder_config.simulcast_layers[0].min_bitrate_bps);
6801 EXPECT_EQ(200000, encoder_config.simulcast_layers[0].max_bitrate_bps);
6802 EXPECT_EQ(300000, encoder_config.simulcast_layers[1].min_bitrate_bps);
6803 EXPECT_EQ(400000, encoder_config.simulcast_layers[1].max_bitrate_bps);
6804 EXPECT_EQ(500000, encoder_config.simulcast_layers[2].min_bitrate_bps);
6805 EXPECT_EQ(600000, encoder_config.simulcast_layers[2].max_bitrate_bps);
6806
6807 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6808 // VideoStreams are created appropriately for the simulcast case.
6809 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6810 // Target bitrate: 200000 * 3 / 4 = 150000.
6811 EXPECT_EQ(100000, stream->GetVideoStreams()[0].min_bitrate_bps);
6812 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
6813 EXPECT_EQ(200000, stream->GetVideoStreams()[0].max_bitrate_bps);
6814 // Target bitrate: 400000 * 3 / 4 = 300000.
6815 EXPECT_EQ(300000, stream->GetVideoStreams()[1].min_bitrate_bps);
6816 EXPECT_EQ(300000, stream->GetVideoStreams()[1].target_bitrate_bps);
6817 EXPECT_EQ(400000, stream->GetVideoStreams()[1].max_bitrate_bps);
6818 // Target bitrate: 600000 * 3 / 4 = 450000, less than min -> max.
6819 EXPECT_EQ(500000, stream->GetVideoStreams()[2].min_bitrate_bps);
6820 EXPECT_EQ(600000, stream->GetVideoStreams()[2].target_bitrate_bps);
6821 EXPECT_EQ(600000, stream->GetVideoStreams()[2].max_bitrate_bps);
6822
6823 // No parameter changed, encoder should not be reconfigured.
6824 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6825 EXPECT_EQ(2, stream->num_encoder_reconfigurations());
6826
6827 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6828}
6829
6830// Test to only specify the min or max bitrate value for a layer via
6831// RtpParameters. The unspecified min/max and target value should be set to the
6832// simulcast default that is used if no min/max are specified.
6833TEST_F(WebRtcVideoChannelTest, MinOrMaxSimulcastBitratePropagatedToEncoder) {
6834 const size_t kNumSimulcastStreams = 3;
6835 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6836 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6837
6838 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006839 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006840 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006841 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006842 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006843 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006844
6845 // Get and set the rtp encoding parameters.
6846 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6847 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6848
6849 // Change the value and set it on the VideoChannel.
6850 // Layer 0: only configure min bitrate.
6851 const int kMinBpsLayer0 = kDefault[0].min_bitrate_bps + 1;
6852 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6853 // Layer 1: only configure max bitrate.
6854 const int kMaxBpsLayer1 = kDefault[1].max_bitrate_bps - 1;
6855 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6856 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6857
6858 // Verify that the new value propagated down to the encoder.
6859 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
6860 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
6861 EXPECT_EQ(kNumSimulcastStreams, encoder_config.number_of_streams);
6862 EXPECT_EQ(kNumSimulcastStreams, encoder_config.simulcast_layers.size());
6863 EXPECT_EQ(kMinBpsLayer0, encoder_config.simulcast_layers[0].min_bitrate_bps);
6864 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
6865 EXPECT_EQ(-1, encoder_config.simulcast_layers[1].min_bitrate_bps);
6866 EXPECT_EQ(kMaxBpsLayer1, encoder_config.simulcast_layers[1].max_bitrate_bps);
6867 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].min_bitrate_bps);
6868 EXPECT_EQ(-1, encoder_config.simulcast_layers[2].max_bitrate_bps);
6869
6870 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6871 // VideoStreams are created appropriately for the simulcast case.
6872 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6873 // Layer 0: min configured bitrate should overwrite min default.
6874 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6875 EXPECT_EQ(kDefault[0].target_bitrate_bps,
6876 stream->GetVideoStreams()[0].target_bitrate_bps);
6877 EXPECT_EQ(kDefault[0].max_bitrate_bps,
6878 stream->GetVideoStreams()[0].max_bitrate_bps);
6879 // Layer 1: max configured bitrate should overwrite max default.
6880 EXPECT_EQ(kDefault[1].min_bitrate_bps,
6881 stream->GetVideoStreams()[1].min_bitrate_bps);
6882 EXPECT_EQ(kDefault[1].target_bitrate_bps,
6883 stream->GetVideoStreams()[1].target_bitrate_bps);
6884 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6885 // Layer 2: min and max bitrate not configured, default expected.
6886 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6887 stream->GetVideoStreams()[2].min_bitrate_bps);
6888 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6889 stream->GetVideoStreams()[2].target_bitrate_bps);
6890 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6891 stream->GetVideoStreams()[2].max_bitrate_bps);
6892
6893 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6894}
6895
6896// Test that specifying the min (or max) bitrate value for a layer via
6897// RtpParameters above (or below) the simulcast default max (or min) adjusts the
6898// unspecified values accordingly.
6899TEST_F(WebRtcVideoChannelTest, SetMinAndMaxSimulcastBitrateAboveBelowDefault) {
6900 const size_t kNumSimulcastStreams = 3;
6901 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6902 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6903
6904 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006905 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006906 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006907 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006908 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006909 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006910
6911 // Get and set the rtp encoding parameters.
6912 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6913 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6914
6915 // Change the value and set it on the VideoChannel.
6916 // For layer 0, set the min bitrate above the default max.
6917 const int kMinBpsLayer0 = kDefault[0].max_bitrate_bps + 1;
6918 parameters.encodings[0].min_bitrate_bps = kMinBpsLayer0;
6919 // For layer 1, set the max bitrate below the default min.
6920 const int kMaxBpsLayer1 = kDefault[1].min_bitrate_bps - 1;
6921 parameters.encodings[1].max_bitrate_bps = kMaxBpsLayer1;
6922 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6923
6924 // Verify that the new value propagated down to the encoder.
6925 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
6926 // VideoStreams are created appropriately for the simulcast case.
6927 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6928 // Layer 0: Min bitrate above default max (target/max should be adjusted).
6929 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].min_bitrate_bps);
6930 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].target_bitrate_bps);
6931 EXPECT_EQ(kMinBpsLayer0, stream->GetVideoStreams()[0].max_bitrate_bps);
6932 // Layer 1: Max bitrate below default min (min/target should be adjusted).
6933 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].min_bitrate_bps);
6934 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].target_bitrate_bps);
6935 EXPECT_EQ(kMaxBpsLayer1, stream->GetVideoStreams()[1].max_bitrate_bps);
6936 // Layer 2: min and max bitrate not configured, default expected.
6937 EXPECT_EQ(kDefault[2].min_bitrate_bps,
6938 stream->GetVideoStreams()[2].min_bitrate_bps);
6939 EXPECT_EQ(kDefault[2].target_bitrate_bps,
6940 stream->GetVideoStreams()[2].target_bitrate_bps);
6941 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6942 stream->GetVideoStreams()[2].max_bitrate_bps);
6943
6944 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6945}
6946
6947TEST_F(WebRtcVideoChannelTest, BandwidthAboveTotalMaxBitrateGivenToMaxLayer) {
6948 const size_t kNumSimulcastStreams = 3;
6949 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6950 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
6951
6952 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01006953 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02006954 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01006955 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02006956 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01006957 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02006958
6959 // Set max bitrate for all but the highest layer.
6960 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
6961 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
6962 parameters.encodings[0].max_bitrate_bps = kDefault[0].max_bitrate_bps;
6963 parameters.encodings[1].max_bitrate_bps = kDefault[1].max_bitrate_bps;
6964 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
6965
6966 // Set max bandwidth equal to total max bitrate.
6967 send_parameters_.max_bandwidth_bps =
6968 GetTotalMaxBitrateBps(stream->GetVideoStreams());
6969 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6970 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6971
6972 // No bitrate above the total max to give to the highest layer.
6973 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6974 EXPECT_EQ(kDefault[2].max_bitrate_bps,
6975 stream->GetVideoStreams()[2].max_bitrate_bps);
6976
6977 // Set max bandwidth above the total max bitrate.
6978 send_parameters_.max_bandwidth_bps =
6979 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
6980 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
6981 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
6982
6983 // The highest layer has no max bitrate set -> the bitrate above the total
6984 // max should be given to the highest layer.
6985 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
6986 EXPECT_EQ(send_parameters_.max_bandwidth_bps,
6987 GetTotalMaxBitrateBps(stream->GetVideoStreams()));
6988 EXPECT_EQ(kDefault[2].max_bitrate_bps + 1,
6989 stream->GetVideoStreams()[2].max_bitrate_bps);
6990
6991 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
6992}
6993
6994TEST_F(WebRtcVideoChannelTest,
6995 BandwidthAboveTotalMaxBitrateNotGivenToMaxLayerIfMaxBitrateSet) {
6996 const size_t kNumSimulcastStreams = 3;
6997 const std::vector<webrtc::VideoStream> kDefault = GetSimulcastBitrates720p();
6998 EXPECT_EQ(kNumSimulcastStreams, kDefault.size());
6999 FakeVideoSendStream* stream = SetUpSimulcast(true, false);
7000
7001 // Send a full size frame so all simulcast layers are used when reconfiguring.
Niels Möller805a27e2019-01-21 12:21:27 +01007002 webrtc::test::FrameForwarder frame_forwarder;
Åsa Persson55659812018-06-18 17:51:32 +02007003 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01007004 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, &options, &frame_forwarder));
Åsa Persson55659812018-06-18 17:51:32 +02007005 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007006 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame());
Åsa Persson55659812018-06-18 17:51:32 +02007007
7008 // Set max bitrate for the highest layer.
7009 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7010 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
7011 parameters.encodings[2].max_bitrate_bps = kDefault[2].max_bitrate_bps;
7012 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
7013
7014 // Set max bandwidth above the total max bitrate.
7015 send_parameters_.max_bandwidth_bps =
7016 GetTotalMaxBitrateBps(stream->GetVideoStreams()) + 1;
7017 ExpectSetMaxBitrate(send_parameters_.max_bandwidth_bps);
7018 ASSERT_TRUE(channel_->SetSendParameters(send_parameters_));
7019
7020 // The highest layer has the max bitrate set -> the bitrate above the total
7021 // max should not be given to the highest layer.
7022 EXPECT_EQ(kNumSimulcastStreams, stream->GetVideoStreams().size());
7023 EXPECT_EQ(*parameters.encodings[2].max_bitrate_bps,
7024 stream->GetVideoStreams()[2].max_bitrate_bps);
7025
7026 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7027}
7028
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007029// Test that min and max bitrate values set via RtpParameters are correctly
7030// propagated to the underlying encoder for a single stream.
7031TEST_F(WebRtcVideoChannelTest, MinAndMaxBitratePropagatedToEncoder) {
7032 FakeVideoSendStream* stream = AddSendStream();
7033 EXPECT_TRUE(channel_->SetSend(true));
7034 EXPECT_TRUE(stream->IsSending());
7035
7036 // Set min and max bitrate.
7037 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7038 EXPECT_EQ(1u, parameters.encodings.size());
7039 parameters.encodings[0].min_bitrate_bps = 80000;
7040 parameters.encodings[0].max_bitrate_bps = 150000;
7041 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
7042
7043 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
7044 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
7045 EXPECT_EQ(1u, encoder_config.number_of_streams);
7046 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
7047 EXPECT_EQ(80000, encoder_config.simulcast_layers[0].min_bitrate_bps);
7048 EXPECT_EQ(150000, encoder_config.simulcast_layers[0].max_bitrate_bps);
7049
7050 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
7051 // VideoStreams are created appropriately.
7052 EXPECT_EQ(1u, stream->GetVideoStreams().size());
7053 EXPECT_EQ(80000, stream->GetVideoStreams()[0].min_bitrate_bps);
7054 EXPECT_EQ(150000, stream->GetVideoStreams()[0].target_bitrate_bps);
7055 EXPECT_EQ(150000, stream->GetVideoStreams()[0].max_bitrate_bps);
7056}
7057
7058// Test the default min and max bitrate value are correctly propagated to the
7059// underlying encoder for a single stream (when the values are not set via
7060// RtpParameters).
7061TEST_F(WebRtcVideoChannelTest, DefaultMinAndMaxBitratePropagatedToEncoder) {
7062 FakeVideoSendStream* stream = AddSendStream();
7063 EXPECT_TRUE(channel_->SetSend(true));
7064 EXPECT_TRUE(stream->IsSending());
7065
7066 // Check that WebRtcVideoSendStream updates VideoEncoderConfig correctly.
7067 webrtc::VideoEncoderConfig encoder_config = stream->GetEncoderConfig().Copy();
7068 EXPECT_EQ(1u, encoder_config.number_of_streams);
7069 EXPECT_EQ(1u, encoder_config.simulcast_layers.size());
7070 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].min_bitrate_bps);
7071 EXPECT_EQ(-1, encoder_config.simulcast_layers[0].max_bitrate_bps);
7072
7073 // FakeVideoSendStream calls CreateEncoderStreams, test that the vector of
7074 // VideoStreams are created appropriately.
7075 EXPECT_EQ(1u, stream->GetVideoStreams().size());
Elad Alon80f53b72019-10-11 16:19:43 +02007076 EXPECT_EQ(webrtc::kDefaultMinVideoBitrateBps,
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007077 stream->GetVideoStreams()[0].min_bitrate_bps);
7078 EXPECT_GT(stream->GetVideoStreams()[0].max_bitrate_bps,
7079 stream->GetVideoStreams()[0].min_bitrate_bps);
7080 EXPECT_EQ(stream->GetVideoStreams()[0].max_bitrate_bps,
7081 stream->GetVideoStreams()[0].target_bitrate_bps);
7082}
7083
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007084// Test that a stream will not be sending if its encoding is made inactive
7085// through SetRtpSendParameters.
Seth Hampson8234ead2018-02-02 15:16:24 -08007086TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersOneEncodingActive) {
deadbeefdbe2b872016-03-22 15:42:00 -07007087 FakeVideoSendStream* stream = AddSendStream();
7088 EXPECT_TRUE(channel_->SetSend(true));
7089 EXPECT_TRUE(stream->IsSending());
7090
7091 // Get current parameters and change "active" to false.
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007092 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
deadbeefdbe2b872016-03-22 15:42:00 -07007093 ASSERT_EQ(1u, parameters.encodings.size());
7094 ASSERT_TRUE(parameters.encodings[0].active);
7095 parameters.encodings[0].active = false;
Zach Steinba37b4b2018-01-23 15:02:36 -08007096 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007097 EXPECT_FALSE(stream->IsSending());
7098
7099 // Now change it back to active and verify we resume sending.
7100 parameters.encodings[0].active = true;
Zach Steinba37b4b2018-01-23 15:02:36 -08007101 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
deadbeefdbe2b872016-03-22 15:42:00 -07007102 EXPECT_TRUE(stream->IsSending());
7103}
7104
Seth Hampson8234ead2018-02-02 15:16:24 -08007105// Tests that when active is updated for any simulcast layer then the send
7106// stream's sending state will be updated and it will be reconfigured with the
7107// new appropriate active simulcast streams.
7108TEST_F(WebRtcVideoChannelTest, SetRtpSendParametersMultipleEncodingsActive) {
7109 // Create the stream params with multiple ssrcs for simulcast.
Åsa Persson31cb8f92018-06-27 10:44:56 +02007110 const size_t kNumSimulcastStreams = 3;
Seth Hampson8234ead2018-02-02 15:16:24 -08007111 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
7112 StreamParams stream_params = CreateSimStreamParams("cname", ssrcs);
7113 FakeVideoSendStream* fake_video_send_stream = AddSendStream(stream_params);
7114 uint32_t primary_ssrc = stream_params.first_ssrc();
7115
Niels Möller805a27e2019-01-21 12:21:27 +01007116 // Using the FrameForwarder, we manually send a full size
Tommi85959932018-02-07 19:26:06 +01007117 // frame. This allows us to test that ReconfigureEncoder is called
7118 // appropriately.
Niels Möller805a27e2019-01-21 12:21:27 +01007119 webrtc::test::FrameForwarder frame_forwarder;
Seth Hampson8234ead2018-02-02 15:16:24 -08007120 VideoOptions options;
Niels Möller805a27e2019-01-21 12:21:27 +01007121 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, &options, &frame_forwarder));
Seth Hampson8234ead2018-02-02 15:16:24 -08007122 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007123 frame_forwarder.IncomingCapturedFrame(frame_source_.GetFrame(
7124 1920, 1080, webrtc::VideoRotation::kVideoRotation_0,
7125 rtc::kNumMicrosecsPerSec / 30));
Seth Hampson8234ead2018-02-02 15:16:24 -08007126
7127 // Check that all encodings are initially active.
7128 webrtc::RtpParameters parameters =
7129 channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007130 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007131 EXPECT_TRUE(parameters.encodings[0].active);
7132 EXPECT_TRUE(parameters.encodings[1].active);
7133 EXPECT_TRUE(parameters.encodings[2].active);
7134 EXPECT_TRUE(fake_video_send_stream->IsSending());
7135
7136 // Only turn on only the middle stream.
7137 parameters.encodings[0].active = false;
7138 parameters.encodings[1].active = true;
7139 parameters.encodings[2].active = false;
7140 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7141 // Verify that the active fields are set on the VideoChannel.
7142 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007143 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007144 EXPECT_FALSE(parameters.encodings[0].active);
7145 EXPECT_TRUE(parameters.encodings[1].active);
7146 EXPECT_FALSE(parameters.encodings[2].active);
7147 // Check that the VideoSendStream is updated appropriately. This means its
7148 // send state was updated and it was reconfigured.
7149 EXPECT_TRUE(fake_video_send_stream->IsSending());
7150 std::vector<webrtc::VideoStream> simulcast_streams =
7151 fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007152 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007153 EXPECT_FALSE(simulcast_streams[0].active);
7154 EXPECT_TRUE(simulcast_streams[1].active);
7155 EXPECT_FALSE(simulcast_streams[2].active);
7156
7157 // Turn off all streams.
7158 parameters.encodings[0].active = false;
7159 parameters.encodings[1].active = false;
7160 parameters.encodings[2].active = false;
7161 EXPECT_TRUE(channel_->SetRtpSendParameters(primary_ssrc, parameters).ok());
7162 // Verify that the active fields are set on the VideoChannel.
7163 parameters = channel_->GetRtpSendParameters(primary_ssrc);
Åsa Persson31cb8f92018-06-27 10:44:56 +02007164 EXPECT_EQ(kNumSimulcastStreams, parameters.encodings.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007165 EXPECT_FALSE(parameters.encodings[0].active);
7166 EXPECT_FALSE(parameters.encodings[1].active);
7167 EXPECT_FALSE(parameters.encodings[2].active);
7168 // Check that the VideoSendStream is off.
7169 EXPECT_FALSE(fake_video_send_stream->IsSending());
7170 simulcast_streams = fake_video_send_stream->GetVideoStreams();
Åsa Persson31cb8f92018-06-27 10:44:56 +02007171 EXPECT_EQ(kNumSimulcastStreams, simulcast_streams.size());
Seth Hampson8234ead2018-02-02 15:16:24 -08007172 EXPECT_FALSE(simulcast_streams[0].active);
7173 EXPECT_FALSE(simulcast_streams[1].active);
7174 EXPECT_FALSE(simulcast_streams[2].active);
7175
Niels Möllerff40b142018-04-09 08:49:14 +02007176 EXPECT_TRUE(channel_->SetVideoSend(primary_ssrc, nullptr, nullptr));
Seth Hampson8234ead2018-02-02 15:16:24 -08007177}
7178
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007179// Test that if a stream is reconfigured (due to a codec change or other
7180// change) while its encoding is still inactive, it doesn't start sending.
eladalonf1841382017-06-12 01:16:46 -07007181TEST_F(WebRtcVideoChannelTest,
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007182 InactiveStreamDoesntStartSendingWhenReconfigured) {
7183 // Set an initial codec list, which will be modified later.
7184 cricket::VideoSendParameters parameters1;
magjed509e4fe2016-11-18 01:34:11 -08007185 parameters1.codecs.push_back(GetEngineCodec("VP8"));
7186 parameters1.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007187 EXPECT_TRUE(channel_->SetSendParameters(parameters1));
7188
7189 FakeVideoSendStream* stream = AddSendStream();
7190 EXPECT_TRUE(channel_->SetSend(true));
7191 EXPECT_TRUE(stream->IsSending());
7192
7193 // Get current parameters and change "active" to false.
7194 webrtc::RtpParameters parameters = channel_->GetRtpSendParameters(last_ssrc_);
7195 ASSERT_EQ(1u, parameters.encodings.size());
7196 ASSERT_TRUE(parameters.encodings[0].active);
7197 parameters.encodings[0].active = false;
7198 EXPECT_EQ(1u, GetFakeSendStreams().size());
7199 EXPECT_EQ(1, fake_call_->GetNumCreatedSendStreams());
Zach Steinba37b4b2018-01-23 15:02:36 -08007200 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, parameters).ok());
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007201 EXPECT_FALSE(stream->IsSending());
7202
7203 // Reorder the codec list, causing the stream to be reconfigured.
7204 cricket::VideoSendParameters parameters2;
magjed509e4fe2016-11-18 01:34:11 -08007205 parameters2.codecs.push_back(GetEngineCodec("VP9"));
7206 parameters2.codecs.push_back(GetEngineCodec("VP8"));
Taylor Brandstetter14b9d792016-09-07 17:16:54 -07007207 EXPECT_TRUE(channel_->SetSendParameters(parameters2));
7208 auto new_streams = GetFakeSendStreams();
7209 // Assert that a new underlying stream was created due to the codec change.
7210 // Otherwise, this test isn't testing what it set out to test.
7211 EXPECT_EQ(1u, GetFakeSendStreams().size());
7212 EXPECT_EQ(2, fake_call_->GetNumCreatedSendStreams());
7213
7214 // Verify that we still are not sending anything, due to the inactive
7215 // encoding.
7216 EXPECT_FALSE(new_streams[0]->IsSending());
7217}
7218
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007219// Test that GetRtpSendParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007220TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersCodecs) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007221 AddSendStream();
7222 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007223 parameters.codecs.push_back(GetEngineCodec("VP8"));
7224 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007225 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7226
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007227 webrtc::RtpParameters rtp_parameters =
7228 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007229 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007230 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7231 rtp_parameters.codecs[0]);
7232 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7233 rtp_parameters.codecs[1]);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007234}
7235
Florent Castellidacec712018-05-24 16:24:21 +02007236// Test that GetRtpSendParameters returns the currently configured RTCP CNAME.
7237TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersRtcpCname) {
7238 StreamParams params = StreamParams::CreateLegacy(kSsrc);
7239 params.cname = "rtcpcname";
7240 AddSendStream(params);
7241
7242 webrtc::RtpParameters rtp_parameters = channel_->GetRtpSendParameters(kSsrc);
7243 EXPECT_STREQ("rtcpcname", rtp_parameters.rtcp.cname.c_str());
7244}
7245
deadbeeffb2aced2017-01-06 23:05:37 -08007246// Test that RtpParameters for send stream has one encoding and it has
7247// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007248TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersSsrc) {
deadbeeffb2aced2017-01-06 23:05:37 -08007249 AddSendStream();
7250
7251 webrtc::RtpParameters rtp_parameters =
7252 channel_->GetRtpSendParameters(last_ssrc_);
7253 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007254 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
deadbeeffb2aced2017-01-06 23:05:37 -08007255}
7256
Florent Castelliabe301f2018-06-12 18:33:49 +02007257TEST_F(WebRtcVideoChannelTest, DetectRtpSendParameterHeaderExtensionsChange) {
7258 AddSendStream();
7259
7260 webrtc::RtpParameters rtp_parameters =
7261 channel_->GetRtpSendParameters(last_ssrc_);
7262 rtp_parameters.header_extensions.emplace_back();
7263
7264 EXPECT_NE(0u, rtp_parameters.header_extensions.size());
7265
7266 webrtc::RTCError result =
7267 channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters);
7268 EXPECT_EQ(webrtc::RTCErrorType::INVALID_MODIFICATION, result.type());
7269}
7270
Florent Castelli87b3c512018-07-18 16:00:28 +02007271TEST_F(WebRtcVideoChannelTest, GetRtpSendParametersDegradationPreference) {
7272 AddSendStream();
7273
Niels Möller805a27e2019-01-21 12:21:27 +01007274 webrtc::test::FrameForwarder frame_forwarder;
7275 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, &frame_forwarder));
Florent Castelli87b3c512018-07-18 16:00:28 +02007276
7277 webrtc::RtpParameters rtp_parameters =
7278 channel_->GetRtpSendParameters(last_ssrc_);
7279 EXPECT_EQ(rtp_parameters.degradation_preference,
7280 webrtc::DegradationPreference::BALANCED);
7281 rtp_parameters.degradation_preference =
7282 webrtc::DegradationPreference::MAINTAIN_FRAMERATE;
7283
7284 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, rtp_parameters).ok());
7285
7286 webrtc::RtpParameters updated_rtp_parameters =
7287 channel_->GetRtpSendParameters(last_ssrc_);
7288 EXPECT_EQ(updated_rtp_parameters.degradation_preference,
7289 webrtc::DegradationPreference::MAINTAIN_FRAMERATE);
7290
7291 // Remove the source since it will be destroyed before the channel
7292 EXPECT_TRUE(channel_->SetVideoSend(last_ssrc_, nullptr, nullptr));
7293}
7294
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007295// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007296TEST_F(WebRtcVideoChannelTest, SetAndGetRtpSendParameters) {
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007297 AddSendStream();
7298 cricket::VideoSendParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007299 parameters.codecs.push_back(GetEngineCodec("VP8"));
7300 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007301 EXPECT_TRUE(channel_->SetSendParameters(parameters));
7302
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007303 webrtc::RtpParameters initial_params =
7304 channel_->GetRtpSendParameters(last_ssrc_);
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007305
7306 // We should be able to set the params we just got.
Zach Steinba37b4b2018-01-23 15:02:36 -08007307 EXPECT_TRUE(channel_->SetRtpSendParameters(last_ssrc_, initial_params).ok());
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007308
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007309 // ... And this shouldn't change the params returned by GetRtpSendParameters.
7310 EXPECT_EQ(initial_params, channel_->GetRtpSendParameters(last_ssrc_));
7311}
7312
7313// Test that GetRtpReceiveParameters returns the currently configured codecs.
eladalonf1841382017-06-12 01:16:46 -07007314TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersCodecs) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007315 AddRecvStream();
7316 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007317 parameters.codecs.push_back(GetEngineCodec("VP8"));
7318 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007319 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7320
7321 webrtc::RtpParameters rtp_parameters =
7322 channel_->GetRtpReceiveParameters(last_ssrc_);
7323 ASSERT_EQ(2u, rtp_parameters.codecs.size());
magjed509e4fe2016-11-18 01:34:11 -08007324 EXPECT_EQ(GetEngineCodec("VP8").ToCodecParameters(),
7325 rtp_parameters.codecs[0]);
7326 EXPECT_EQ(GetEngineCodec("VP9").ToCodecParameters(),
7327 rtp_parameters.codecs[1]);
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007328}
7329
johan073ece42016-08-26 02:59:47 -07007330#if defined(WEBRTC_USE_H264)
eladalonf1841382017-06-12 01:16:46 -07007331TEST_F(WebRtcVideoChannelTest, GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007332#else
eladalonf1841382017-06-12 01:16:46 -07007333TEST_F(WebRtcVideoChannelTest, DISABLED_GetRtpReceiveFmtpSprop) {
johan073ece42016-08-26 02:59:47 -07007334#endif
johan3859c892016-08-05 09:19:25 -07007335 cricket::VideoRecvParameters parameters;
perkj26752742016-10-24 01:21:16 -07007336 cricket::VideoCodec kH264sprop1(101, "H264");
magjed5dfac562016-11-25 03:56:37 -08007337 kH264sprop1.SetParam(kH264FmtpSpropParameterSets, "uvw");
johan3859c892016-08-05 09:19:25 -07007338 parameters.codecs.push_back(kH264sprop1);
perkj26752742016-10-24 01:21:16 -07007339 cricket::VideoCodec kH264sprop2(102, "H264");
magjed5dfac562016-11-25 03:56:37 -08007340 kH264sprop2.SetParam(kH264FmtpSpropParameterSets, "xyz");
johan3859c892016-08-05 09:19:25 -07007341 parameters.codecs.push_back(kH264sprop2);
7342 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7343
7344 FakeVideoReceiveStream* recv_stream = AddRecvStream();
7345 const webrtc::VideoReceiveStream::Config& cfg = recv_stream->GetConfig();
7346 webrtc::RtpParameters rtp_parameters =
7347 channel_->GetRtpReceiveParameters(last_ssrc_);
7348 ASSERT_EQ(2u, rtp_parameters.codecs.size());
7349 EXPECT_EQ(kH264sprop1.ToCodecParameters(), rtp_parameters.codecs[0]);
7350 ASSERT_EQ(2u, cfg.decoders.size());
7351 EXPECT_EQ(101, cfg.decoders[0].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007352 EXPECT_EQ("H264", cfg.decoders[0].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007353 const auto it0 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007354 cfg.decoders[0].video_format.parameters.find(kH264FmtpSpropParameterSets);
7355 ASSERT_TRUE(it0 != cfg.decoders[0].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007356 EXPECT_EQ("uvw", it0->second);
johan3859c892016-08-05 09:19:25 -07007357
7358 EXPECT_EQ(102, cfg.decoders[1].payload_type);
Niels Möllercb7e1d22018-09-11 15:56:04 +02007359 EXPECT_EQ("H264", cfg.decoders[1].video_format.name);
magjed5dfac562016-11-25 03:56:37 -08007360 const auto it1 =
Niels Möllercb7e1d22018-09-11 15:56:04 +02007361 cfg.decoders[1].video_format.parameters.find(kH264FmtpSpropParameterSets);
7362 ASSERT_TRUE(it1 != cfg.decoders[1].video_format.parameters.end());
magjed5dfac562016-11-25 03:56:37 -08007363 EXPECT_EQ("xyz", it1->second);
johan3859c892016-08-05 09:19:25 -07007364}
7365
sakal1fd95952016-06-22 00:46:15 -07007366// Test that RtpParameters for receive stream has one encoding and it has
7367// the correct SSRC.
eladalonf1841382017-06-12 01:16:46 -07007368TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersSsrc) {
sakal1fd95952016-06-22 00:46:15 -07007369 AddRecvStream();
7370
7371 webrtc::RtpParameters rtp_parameters =
7372 channel_->GetRtpReceiveParameters(last_ssrc_);
7373 ASSERT_EQ(1u, rtp_parameters.encodings.size());
Oskar Sundbom78807582017-11-16 11:09:55 +01007374 EXPECT_EQ(last_ssrc_, rtp_parameters.encodings[0].ssrc);
sakal1fd95952016-06-22 00:46:15 -07007375}
7376
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007377// Test that if we set/get parameters multiple times, we get the same results.
eladalonf1841382017-06-12 01:16:46 -07007378TEST_F(WebRtcVideoChannelTest, SetAndGetRtpReceiveParameters) {
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007379 AddRecvStream();
7380 cricket::VideoRecvParameters parameters;
magjed509e4fe2016-11-18 01:34:11 -08007381 parameters.codecs.push_back(GetEngineCodec("VP8"));
7382 parameters.codecs.push_back(GetEngineCodec("VP9"));
Taylor Brandstetterdb0cd9e2016-05-16 11:40:30 -07007383 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7384
7385 webrtc::RtpParameters initial_params =
7386 channel_->GetRtpReceiveParameters(last_ssrc_);
7387
7388 // We should be able to set the params we just got.
7389 EXPECT_TRUE(channel_->SetRtpReceiveParameters(last_ssrc_, initial_params));
7390
7391 // ... And this shouldn't change the params returned by
7392 // GetRtpReceiveParameters.
7393 EXPECT_EQ(initial_params, channel_->GetRtpReceiveParameters(last_ssrc_));
Taylor Brandstetter0cd086b2016-04-20 16:23:10 -07007394}
7395
deadbeef3bc15102017-04-20 19:25:07 -07007396// Test that GetRtpReceiveParameters returns parameters correctly when SSRCs
7397// aren't signaled. It should always return an empty "RtpEncodingParameters",
7398// even after a packet is received and the unsignaled SSRC is known.
eladalonf1841382017-06-12 01:16:46 -07007399TEST_F(WebRtcVideoChannelTest, GetRtpReceiveParametersWithUnsignaledSsrc) {
deadbeef3bc15102017-04-20 19:25:07 -07007400 // Call necessary methods to configure receiving a default stream as
7401 // soon as it arrives.
7402 cricket::VideoRecvParameters parameters;
7403 parameters.codecs.push_back(GetEngineCodec("VP8"));
7404 parameters.codecs.push_back(GetEngineCodec("VP9"));
7405 EXPECT_TRUE(channel_->SetRecvParameters(parameters));
7406
7407 // Call GetRtpReceiveParameters before configured to receive an unsignaled
7408 // stream. Should return nothing.
7409 EXPECT_EQ(webrtc::RtpParameters(), channel_->GetRtpReceiveParameters(0));
7410
7411 // Set a sink for an unsignaled stream.
7412 cricket::FakeVideoRenderer renderer;
7413 // Value of "0" means "unsignaled stream".
7414 EXPECT_TRUE(channel_->SetSink(0, &renderer));
7415
7416 // Call GetRtpReceiveParameters before the SSRC is known. Value of "0"
7417 // in this method means "unsignaled stream".
7418 webrtc::RtpParameters rtp_parameters = channel_->GetRtpReceiveParameters(0);
7419 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7420 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7421
7422 // Receive VP8 packet.
7423 uint8_t data[kMinRtpPacketLen];
7424 cricket::RtpHeader rtpHeader;
7425 rtpHeader.payload_type = GetEngineCodec("VP8").id;
7426 rtpHeader.seq_num = rtpHeader.timestamp = 0;
7427 rtpHeader.ssrc = kIncomingUnsignalledSsrc;
7428 cricket::SetRtpHeader(data, sizeof(data), rtpHeader);
7429 rtc::CopyOnWriteBuffer packet(data, sizeof(data));
Amit Hilbuche7a5f7b2019-03-12 11:10:27 -07007430 channel_->OnPacketReceived(packet, /* packet_time_us */ -1);
deadbeef3bc15102017-04-20 19:25:07 -07007431
7432 // The |ssrc| member should still be unset.
7433 rtp_parameters = channel_->GetRtpReceiveParameters(0);
7434 ASSERT_EQ(1u, rtp_parameters.encodings.size());
7435 EXPECT_FALSE(rtp_parameters.encodings[0].ssrc);
7436}
7437
eladalonf1841382017-06-12 01:16:46 -07007438void WebRtcVideoChannelTest::TestReceiverLocalSsrcConfiguration(
Peter Boström3548dd22015-05-22 18:48:36 +02007439 bool receiver_first) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007440 EXPECT_TRUE(channel_->SetSendParameters(send_parameters_));
Peter Boström3548dd22015-05-22 18:48:36 +02007441
7442 const uint32_t kSenderSsrc = 0xC0FFEE;
Peter Boströmdfa28152015-10-21 17:21:10 +02007443 const uint32_t kSecondSenderSsrc = 0xBADCAFE;
Peter Boström3548dd22015-05-22 18:48:36 +02007444 const uint32_t kReceiverSsrc = 0x4711;
Peter Boströmdfa28152015-10-21 17:21:10 +02007445 const uint32_t kExpectedDefaultReceiverSsrc = 1;
Peter Boström3548dd22015-05-22 18:48:36 +02007446
7447 if (receiver_first) {
7448 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7449 std::vector<FakeVideoReceiveStream*> receive_streams =
7450 fake_call_->GetVideoReceiveStreams();
7451 ASSERT_EQ(1u, receive_streams.size());
Peter Boströmdfa28152015-10-21 17:21:10 +02007452 // Default local SSRC when we have no sender.
7453 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7454 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007455 }
7456 AddSendStream(StreamParams::CreateLegacy(kSenderSsrc));
7457 if (!receiver_first)
7458 AddRecvStream(StreamParams::CreateLegacy(kReceiverSsrc));
7459 std::vector<FakeVideoReceiveStream*> receive_streams =
7460 fake_call_->GetVideoReceiveStreams();
7461 ASSERT_EQ(1u, receive_streams.size());
7462 EXPECT_EQ(kSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boströmdfa28152015-10-21 17:21:10 +02007463
7464 // Removing first sender should fall back to another (in this case the second)
7465 // local send stream's SSRC.
7466 AddSendStream(StreamParams::CreateLegacy(kSecondSenderSsrc));
7467 ASSERT_TRUE(channel_->RemoveSendStream(kSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007468 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007469 ASSERT_EQ(1u, receive_streams.size());
7470 EXPECT_EQ(kSecondSenderSsrc, receive_streams[0]->GetConfig().rtp.local_ssrc);
7471
7472 // Removing the last sender should fall back to default local SSRC.
7473 ASSERT_TRUE(channel_->RemoveSendStream(kSecondSenderSsrc));
Yves Gerey665174f2018-06-19 15:03:05 +02007474 receive_streams = fake_call_->GetVideoReceiveStreams();
Peter Boströmdfa28152015-10-21 17:21:10 +02007475 ASSERT_EQ(1u, receive_streams.size());
7476 EXPECT_EQ(kExpectedDefaultReceiverSsrc,
7477 receive_streams[0]->GetConfig().rtp.local_ssrc);
Peter Boström3548dd22015-05-22 18:48:36 +02007478}
7479
eladalonf1841382017-06-12 01:16:46 -07007480TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrc) {
Peter Boström3548dd22015-05-22 18:48:36 +02007481 TestReceiverLocalSsrcConfiguration(false);
7482}
7483
eladalonf1841382017-06-12 01:16:46 -07007484TEST_F(WebRtcVideoChannelTest, ConfiguresLocalSsrcOnExistingReceivers) {
Peter Boström3548dd22015-05-22 18:48:36 +02007485 TestReceiverLocalSsrcConfiguration(true);
7486}
7487
Mirko Bonadei6a489f22019-04-09 15:11:12 +02007488class WebRtcVideoChannelSimulcastTest : public ::testing::Test {
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007489 public:
eladalonf1841382017-06-12 01:16:46 -07007490 WebRtcVideoChannelSimulcastTest()
Sebastian Jansson8f83b422018-02-21 13:07:13 +01007491 : fake_call_(),
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007492 encoder_factory_(new cricket::FakeWebRtcVideoEncoderFactory),
7493 decoder_factory_(new cricket::FakeWebRtcVideoDecoderFactory),
Jiawei Ouc2ebe212018-11-08 10:02:56 -08007494 mock_rate_allocator_factory_(
Mirko Bonadei317a1f02019-09-17 17:06:18 +02007495 std::make_unique<webrtc::MockVideoBitrateAllocatorFactory>()),
Anders Carlsson67537952018-05-03 11:28:29 +02007496 engine_(std::unique_ptr<cricket::FakeWebRtcVideoEncoderFactory>(
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007497 encoder_factory_),
Anders Carlsson67537952018-05-03 11:28:29 +02007498 std::unique_ptr<cricket::FakeWebRtcVideoDecoderFactory>(
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007499 decoder_factory_)),
magjed2475ae22017-09-12 04:42:15 -07007500 last_ssrc_(0) {}
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007501
kjellander@webrtc.org14665ff2015-03-04 12:58:35 +00007502 void SetUp() override {
Anders Carlsson5f2bb622018-05-14 09:48:06 +02007503 encoder_factory_->AddSupportedVideoCodecType("VP8");
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007504 channel_.reset(engine_.CreateMediaChannel(
7505 &fake_call_, GetMediaConfig(), VideoOptions(), webrtc::CryptoOptions(),
7506 mock_rate_allocator_factory_.get()));
Sergey Ulanove2b15012016-11-22 16:08:30 -08007507 channel_->OnReadyToSend(true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007508 last_ssrc_ = 123;
7509 }
7510
7511 protected:
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007512 void VerifySimulcastSettings(const VideoCodec& codec,
perkj26752742016-10-24 01:21:16 -07007513 int capture_width,
7514 int capture_height,
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007515 size_t num_configured_streams,
sprang429600d2017-01-26 06:12:26 -08007516 size_t expected_num_streams,
7517 bool screenshare,
7518 bool conference_mode) {
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007519 cricket::VideoSendParameters parameters;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007520 parameters.codecs.push_back(codec);
sprang429600d2017-01-26 06:12:26 -08007521 parameters.conference_mode = conference_mode;
Fredrik Solenbergb071a192015-09-17 16:42:56 +02007522 ASSERT_TRUE(channel_->SetSendParameters(parameters));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007523
Peter Boström0c4e06b2015-10-07 12:23:21 +02007524 std::vector<uint32_t> ssrcs = MAKE_VECTOR(kSsrcs3);
henrikg91d6ede2015-09-17 00:24:34 -07007525 RTC_DCHECK(num_configured_streams <= ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007526 ssrcs.resize(num_configured_streams);
7527
sprangf24a0642017-02-28 13:23:26 -08007528 AddSendStream(CreateSimStreamParams("cname", ssrcs));
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007529 // Send a full-size frame to trigger a stream reconfiguration to use all
7530 // expected simulcast layers.
Niels Möller805a27e2019-01-21 12:21:27 +01007531 webrtc::test::FrameForwarder frame_forwarder;
7532 cricket::FakeFrameSource frame_source(capture_width, capture_height,
7533 rtc::kNumMicrosecsPerSec / 30);
7534
sprangf24a0642017-02-28 13:23:26 -08007535 VideoOptions options;
7536 if (screenshare)
Oskar Sundbom78807582017-11-16 11:09:55 +01007537 options.is_screencast = screenshare;
Niels Möller805a27e2019-01-21 12:21:27 +01007538 EXPECT_TRUE(
7539 channel_->SetVideoSend(ssrcs.front(), &options, &frame_forwarder));
sprangf24a0642017-02-28 13:23:26 -08007540 // Fetch the latest stream since SetVideoSend() may recreate it if the
7541 // screen content setting is changed.
7542 FakeVideoSendStream* stream = fake_call_.GetVideoSendStreams().front();
pbos@webrtc.org86196c42015-02-16 21:02:00 +00007543 channel_->SetSend(true);
Niels Möller805a27e2019-01-21 12:21:27 +01007544 frame_forwarder.IncomingCapturedFrame(frame_source.GetFrame());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007545
Zach Stein3ca452b2018-01-18 10:01:24 -08007546 auto rtp_parameters = channel_->GetRtpSendParameters(kSsrcs3[0]);
7547 EXPECT_EQ(num_configured_streams, rtp_parameters.encodings.size());
7548
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007549 std::vector<webrtc::VideoStream> video_streams = stream->GetVideoStreams();
7550 ASSERT_EQ(expected_num_streams, video_streams.size());
Ilya Nikolaevskiy33d2a912019-04-02 11:05:03 +02007551 EXPECT_LE(expected_num_streams, stream->GetConfig().rtp.ssrcs.size());
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007552
sprang429600d2017-01-26 06:12:26 -08007553 std::vector<webrtc::VideoStream> expected_streams;
Florent Castelli66b38602019-07-10 16:57:57 +02007554 if (num_configured_streams > 1 || conference_mode) {
sprang429600d2017-01-26 06:12:26 -08007555 expected_streams = GetSimulcastConfig(
Florent Castelli668ce0c2019-07-04 17:06:04 +02007556 num_configured_streams, capture_width, capture_height,
Florent Castelli66b38602019-07-10 16:57:57 +02007557 webrtc::kDefaultBitratePriority, kDefaultQpMax,
7558 screenshare && conference_mode, true);
7559 if (screenshare && conference_mode) {
sprang3ebabf12017-02-16 07:35:22 -08007560 for (const webrtc::VideoStream& stream : expected_streams) {
7561 // Never scale screen content.
Danil Chapovalov350531e2018-06-08 11:04:04 +00007562 EXPECT_EQ(stream.width, rtc::checked_cast<size_t>(capture_width));
7563 EXPECT_EQ(stream.height, rtc::checked_cast<size_t>(capture_height));
sprang3ebabf12017-02-16 07:35:22 -08007564 }
7565 }
sprang429600d2017-01-26 06:12:26 -08007566 } else {
7567 webrtc::VideoStream stream;
7568 stream.width = capture_width;
7569 stream.height = capture_height;
7570 stream.max_framerate = kDefaultVideoMaxFramerate;
Elad Alon80f53b72019-10-11 16:19:43 +02007571 stream.min_bitrate_bps = webrtc::kDefaultMinVideoBitrateBps;
sprang429600d2017-01-26 06:12:26 -08007572 stream.target_bitrate_bps = stream.max_bitrate_bps =
Åsa Perssonbdee46d2018-06-25 11:28:06 +02007573 GetMaxDefaultBitrateBps(capture_width, capture_height);
sprang429600d2017-01-26 06:12:26 -08007574 stream.max_qp = kDefaultQpMax;
7575 expected_streams.push_back(stream);
7576 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007577
7578 ASSERT_EQ(expected_streams.size(), video_streams.size());
7579
7580 size_t num_streams = video_streams.size();
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007581 int total_max_bitrate_bps = 0;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007582 for (size_t i = 0; i < num_streams; ++i) {
7583 EXPECT_EQ(expected_streams[i].width, video_streams[i].width);
7584 EXPECT_EQ(expected_streams[i].height, video_streams[i].height);
7585
7586 EXPECT_GT(video_streams[i].max_framerate, 0);
7587 EXPECT_EQ(expected_streams[i].max_framerate,
7588 video_streams[i].max_framerate);
7589
7590 EXPECT_GT(video_streams[i].min_bitrate_bps, 0);
7591 EXPECT_EQ(expected_streams[i].min_bitrate_bps,
7592 video_streams[i].min_bitrate_bps);
7593
7594 EXPECT_GT(video_streams[i].target_bitrate_bps, 0);
7595 EXPECT_EQ(expected_streams[i].target_bitrate_bps,
7596 video_streams[i].target_bitrate_bps);
7597
7598 EXPECT_GT(video_streams[i].max_bitrate_bps, 0);
7599 EXPECT_EQ(expected_streams[i].max_bitrate_bps,
7600 video_streams[i].max_bitrate_bps);
7601
7602 EXPECT_GT(video_streams[i].max_qp, 0);
7603 EXPECT_EQ(expected_streams[i].max_qp, video_streams[i].max_qp);
7604
Florent Castelli66b38602019-07-10 16:57:57 +02007605 EXPECT_EQ(num_configured_streams > 1 || conference_mode,
Sergey Silkina796a7e2018-03-01 15:11:29 +01007606 expected_streams[i].num_temporal_layers.has_value());
7607
7608 if (conference_mode) {
7609 EXPECT_EQ(expected_streams[i].num_temporal_layers,
7610 video_streams[i].num_temporal_layers);
7611 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007612
7613 if (i == num_streams - 1) {
7614 total_max_bitrate_bps += video_streams[i].max_bitrate_bps;
7615 } else {
7616 total_max_bitrate_bps += video_streams[i].target_bitrate_bps;
7617 }
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007618 }
pbos@webrtc.org77e11bb2015-02-23 16:39:07 +00007619
Niels Möllerff40b142018-04-09 08:49:14 +02007620 EXPECT_TRUE(channel_->SetVideoSend(ssrcs.front(), nullptr, nullptr));
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007621 }
7622
7623 FakeVideoSendStream* AddSendStream() {
7624 return AddSendStream(StreamParams::CreateLegacy(last_ssrc_++));
7625 }
7626
7627 FakeVideoSendStream* AddSendStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007628 size_t num_streams = fake_call_.GetVideoSendStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007629 EXPECT_TRUE(channel_->AddSendStream(sp));
7630 std::vector<FakeVideoSendStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007631 fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007632 EXPECT_EQ(num_streams + 1, streams.size());
7633 return streams[streams.size() - 1];
7634 }
7635
7636 std::vector<FakeVideoSendStream*> GetFakeSendStreams() {
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007637 return fake_call_.GetVideoSendStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007638 }
7639
7640 FakeVideoReceiveStream* AddRecvStream() {
7641 return AddRecvStream(StreamParams::CreateLegacy(last_ssrc_++));
7642 }
7643
7644 FakeVideoReceiveStream* AddRecvStream(const StreamParams& sp) {
Yves Gerey665174f2018-06-19 15:03:05 +02007645 size_t num_streams = fake_call_.GetVideoReceiveStreams().size();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007646 EXPECT_TRUE(channel_->AddRecvStream(sp));
7647 std::vector<FakeVideoReceiveStream*> streams =
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007648 fake_call_.GetVideoReceiveStreams();
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007649 EXPECT_EQ(num_streams + 1, streams.size());
7650 return streams[streams.size() - 1];
7651 }
7652
Danil Chapovalov83bbe912019-08-07 12:24:53 +02007653 webrtc::RtcEventLogNull event_log_;
Fredrik Solenberg709ed672015-09-15 12:26:33 +02007654 FakeCall fake_call_;
Magnus Jedvert02e7a192017-09-23 17:21:32 +02007655 cricket::FakeWebRtcVideoEncoderFactory* encoder_factory_;
7656 cricket::FakeWebRtcVideoDecoderFactory* decoder_factory_;
Jonas Orelanda3aa9bd2019-04-17 07:38:40 +02007657 std::unique_ptr<webrtc::MockVideoBitrateAllocatorFactory>
7658 mock_rate_allocator_factory_;
eladalonf1841382017-06-12 01:16:46 -07007659 WebRtcVideoEngine engine_;
kwiberg686a8ef2016-02-26 03:00:35 -08007660 std::unique_ptr<VideoMediaChannel> channel_;
Peter Boström0c4e06b2015-10-07 12:23:21 +02007661 uint32_t last_ssrc_;
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007662};
7663
eladalonf1841382017-06-12 01:16:46 -07007664TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith2SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007665 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 640, 360, 2, 2, false,
7666 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007667}
7668
eladalonf1841382017-06-12 01:16:46 -07007669TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWith3SimulcastStreams) {
sprang429600d2017-01-26 06:12:26 -08007670 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, false,
7671 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007672}
7673
7674// Test that we normalize send codec format size in simulcast.
eladalonf1841382017-06-12 01:16:46 -07007675TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsWithOddSizeInSimulcast) {
sprang429600d2017-01-26 06:12:26 -08007676 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 541, 271, 2, 2, false,
7677 true);
buildbot@webrtc.orga8530772014-12-10 09:01:18 +00007678}
sprang429600d2017-01-26 06:12:26 -08007679
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007680TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForScreenshare) {
Florent Castelli66b38602019-07-10 16:57:57 +02007681 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
Ilya Nikolaevskiy3df1d5d2018-08-22 09:26:51 +02007682 false);
7683}
7684
eladalonf1841382017-06-12 01:16:46 -07007685TEST_F(WebRtcVideoChannelSimulcastTest, SetSendCodecsForSimulcastScreenshare) {
sprang429600d2017-01-26 06:12:26 -08007686 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 2, true,
7687 true);
7688}
7689
Florent Castelli66b38602019-07-10 16:57:57 +02007690TEST_F(WebRtcVideoChannelSimulcastTest, SimulcastScreenshareWithoutConference) {
7691 VerifySimulcastSettings(cricket::VideoCodec("VP8"), 1280, 720, 3, 3, true,
sprangfe627f32017-03-29 08:24:59 -07007692 false);
7693}
7694
Chen Xing90f3b892019-06-25 10:16:14 +02007695TEST_F(WebRtcVideoChannelBaseTest, GetSources) {
7696 EXPECT_THAT(channel_->GetSources(kSsrc), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007697
Chen Xing90f3b892019-06-25 10:16:14 +02007698 EXPECT_TRUE(channel_->SetSink(kDefaultReceiveSsrc, &renderer_));
Jonas Oreland49ac5952018-09-26 16:04:32 +02007699 EXPECT_TRUE(SetDefaultCodec());
7700 EXPECT_TRUE(SetSend(true));
Chen Xing90f3b892019-06-25 10:16:14 +02007701 EXPECT_EQ(renderer_.num_rendered_frames(), 0);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007702
Chen Xing90f3b892019-06-25 10:16:14 +02007703 // Send and receive one frame.
7704 SendFrame();
7705 EXPECT_FRAME_WAIT(1, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007706
Chen Xing90f3b892019-06-25 10:16:14 +02007707 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7708 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7709 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007710
Chen Xing90f3b892019-06-25 10:16:14 +02007711 webrtc::RtpSource source = channel_->GetSources(kSsrc)[0];
7712 EXPECT_EQ(source.source_id(), kSsrc);
7713 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7714 int64_t rtp_timestamp_1 = source.rtp_timestamp();
7715 int64_t timestamp_ms_1 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007716
Chen Xing90f3b892019-06-25 10:16:14 +02007717 // Send and receive another frame.
7718 SendFrame();
7719 EXPECT_FRAME_WAIT(2, kVideoWidth, kVideoHeight, kTimeout);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007720
Chen Xing90f3b892019-06-25 10:16:14 +02007721 EXPECT_THAT(channel_->GetSources(kSsrc - 1), IsEmpty());
7722 EXPECT_THAT(channel_->GetSources(kSsrc), SizeIs(1));
7723 EXPECT_THAT(channel_->GetSources(kSsrc + 1), IsEmpty());
Jonas Oreland49ac5952018-09-26 16:04:32 +02007724
Chen Xing90f3b892019-06-25 10:16:14 +02007725 source = channel_->GetSources(kSsrc)[0];
7726 EXPECT_EQ(source.source_id(), kSsrc);
7727 EXPECT_EQ(source.source_type(), webrtc::RtpSourceType::SSRC);
7728 int64_t rtp_timestamp_2 = source.rtp_timestamp();
7729 int64_t timestamp_ms_2 = source.timestamp_ms();
Jonas Oreland49ac5952018-09-26 16:04:32 +02007730
Chen Xing90f3b892019-06-25 10:16:14 +02007731 EXPECT_GT(rtp_timestamp_2, rtp_timestamp_1);
7732 EXPECT_GT(timestamp_ms_2, timestamp_ms_1);
Jonas Oreland49ac5952018-09-26 16:04:32 +02007733}
7734
Amit Hilbuchb000b712019-02-25 10:22:14 -08007735TEST_F(WebRtcVideoChannelTest, SetsRidsOnSendStream) {
7736 StreamParams sp = CreateSimStreamParams("cname", {123, 456, 789});
7737
7738 std::vector<std::string> rids = {"f", "h", "q"};
7739 std::vector<cricket::RidDescription> rid_descriptions;
7740 for (const auto& rid : rids) {
7741 rid_descriptions.emplace_back(rid, cricket::RidDirection::kSend);
7742 }
7743 sp.set_rids(rid_descriptions);
7744
7745 ASSERT_TRUE(channel_->AddSendStream(sp));
7746 const auto& streams = fake_call_->GetVideoSendStreams();
7747 ASSERT_EQ(1u, streams.size());
7748 auto stream = streams[0];
7749 ASSERT_NE(stream, nullptr);
7750 const auto& config = stream->GetConfig();
7751 EXPECT_THAT(config.rtp.rids, ::testing::ElementsAreArray(rids));
7752}
7753
pbos@webrtc.orgb5a22b12014-05-13 11:07:01 +00007754} // namespace cricket